github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Hide 'view and edit SQL' if config.allow_sql turned off

Browse source
This commit is contained in:
Simon Willison 2018-08-05 20:17:17 -07:00
commit fe5b6ea95a
No known key found for this signature in database
GPG key ID: 17E2DEA2588B7F52
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
datasette/templates/table.html
View file

@ -88,7 +88,7 @@
</div>
</form>
{% if query.sql %}
{% if query.sql and config.allow_sql %}
<p><a class="not-underlined" title="{{ query.sql }}" href="/{{ database }}-{{ database_hash }}?{{ {'sql': query.sql}|urlencode|safe }}{% if query.params %}&amp;{{ query.params|urlencode|safe }}{% endif %}">&#x270e; <span class="underlined">View and edit SQL</span></a></p>
{% endif %}

9
tests/test_html.py
View file

@ -713,6 +713,10 @@ def test_allow_sql_on(app_client):
)
soup = Soup(response.body, 'html.parser')
assert len(soup.findAll('textarea', {'name': 'sql'}))
response = app_client.get(
"/fixtures/sortable"
)
assert b"View and edit SQL" in response.body
def test_allow_sql_off():
@ -724,6 +728,11 @@ def test_allow_sql_off():
)
soup = Soup(response.body, 'html.parser')
assert not len(soup.findAll('textarea', {'name': 'sql'}))
# The table page should no longer show "View and edit SQL"
response = client.get(
"/fixtures/sortable"
)
assert b"View and edit SQL" not in response.body
def assert_querystring_equal(expected, actual):