github/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2025-12-10 16:51:24 +01:00
Code Issues Projects Releases Packages Wiki Activity
320 commits 143 branches 163 tags 44 MiB
Commit graph

72 commits

Author SHA1 Message Date
Simon Willison
aaf59db570
 		Longer time limit for test_paginate_compound_keys 
It was failing intermittently in Travis - see #209
 2018-04-17 18:09:48 -07:00
Simon Willison
e7c769ef30
 		Working implementation of #216 which passes the tests 
Reverted commit 5364fa7f33 (where I removed the
code that didn't work).

Added primary keys to order-by clause for sorting to get tests to pass
 2018-04-16 18:41:55 -07:00
Simon Willison
5364fa7f33
 		Revert #216 until I can get tests to pass in Travis 
Revert "Fix for _sort_desc=sortable_with_nulls test, refs #216"

This reverts commit 07fc2d113e.

Revert "Fixed #216 - paginate correctly when sorting by nullable column"

This reverts commit 2abe539a0f.
 2018-04-16 17:53:37 -07:00
Simon Willison
07fc2d113e
 		Fix for _sort_desc=sortable_with_nulls test, refs #216 2018-04-16 17:05:03 -07:00
Simon Willison
2abe539a0f
 		Fixed #216 - paginate correctly when sorting by nullable column 2018-04-16 16:52:50 -07:00
Simon Willison
b2955d9065
 		New --plugins-dir=plugins/ option (#212) 
* New --plugins-dir=plugins/ option

New option causing Datasette to load and evaluate all of the Python files in
the specified directory and register any plugins that are defined in those
files.

This new option is available for the following commands:

    datasette serve mydb.db --plugins-dir=plugins/
    datasette publish now/heroku mydb.db --plugins-dir=plugins/
    datasette package mydb.db --plugins-dir=plugins/

* Unit tests for --plugins-dir=plugins/

Closes #211
 2018-04-15 22:22:01 -07:00
Simon Willison
dd4491dd81
 		Update number of expected tables 2018-04-14 08:16:54 -07:00
Simon Willison
6b15a53cd3
 		Unit test for unlabelled foreign keys from #207 2018-04-14 08:00:54 -07:00
Simon Willison
d72201e883
 		Added unit test for foreign key links in HTML 
Needed to add a further unit test for #207
 2018-04-14 07:55:27 -07:00
Russ Garrett
ed974417ad
 		Tests for unit filtering 2018-04-14 15:06:52 +01:00
Simon Willison
9f28bbe43d
 		Better mechanism for handling errors; 404s for missing table/database 
New error mechanism closes #193

404s for missing tables/databesse closes #184

Makes pull request #202 unnecessary.
 2018-04-13 11:17:22 -07:00
Simon Willison
46b237c29a
 		datasette inspect now finds primary_keys 
Closes #195
 2018-04-09 17:54:12 -07:00
Simon Willison
57b19f09d1
 		Ability to sort using form fields (for mobile portrait mode) 
We now display sort options as a select box plus a descending checkbox, which
means you can apply sort orders even in portrait mode on a mobile phone where
the column headers are hidden.

Closes #199
 2018-04-09 17:34:32 -07:00
Simon Willison
a290f28caa
 		table_rows => table_rows_count, filtered_table_rows => filtered_table_rows_count 
Renamed properties. Closes #194
 2018-04-08 22:24:24 -07:00
Simon Willison
c1d37fdf2b Fixed bug with human filter description, refs #189 
We were showing this:

    201 rows where sorted by sortable_with_nulls

We now show this:

    201 rows sorted by sortable_with_nulls
 2018-04-08 22:10:22 -07:00
Simon Willison
b13f0986f2 New sortable_columns option in metadata.json to control sort options 
You can now explicitly set which columns in a table can be used for sorting
using the _sort and _sort_desc arguments using metadata.json:

    {
        "databases": {
            "database1": {
                "tables": {
                    "example_table": {
                        "sortable_columns": [
                            "height",
                            "weight"
                        ]
                    }
                }
            }
        }
    }

Refs #189
 2018-04-08 22:10:22 -07:00
Simon Willison
a87df963a0 Error handling for ?_sort and ?_sort_desc 
Verifies that they match an existing column, and only one or the other option
is provided - refs #189

Eses a new DatasetteError exception that closes #193
 2018-04-08 22:10:22 -07:00
Simon Willison
747a801b50 Column headers now link to sort/desc sort - refs #189 2018-04-08 22:10:22 -07:00
Simon Willison
9f2ec39fbc Current sort order now reflected in human filter description 
Plus renamed human_description to human_description_en

Refs #189
 2018-04-08 22:10:22 -07:00
Simon Willison
f3a3820ff5 _sort and _sort_desc parameters for table views 
Allows for paginated sorted results based on a specified column.

Refs #189
 2018-04-08 22:10:22 -07:00
Simon Willison
0abd3abacb
 		New ?_shape=objects/object/lists param for JSON API (#192) 
New _shape= parameter replacing old .jsono extension

Now instead of this:

	/database/table.jsono

We use the _shape parameter like this:

	/database/table.json?_shape=objects

Also introduced a new _shape called 'object' which looks like this:

	/database/table.json?_shape=object

Returning an object for the rows key:

	...
	"rows": {
		"pk1": {
			...
		},
		"pk2": {
			...
		}
	}

Refs #122
 2018-04-03 07:52:54 -07:00
Simon Willison
dd0566ff8e
 		Utility for writing test database fixtures to a .db file 
python tests/fixtures.py /tmp/hello.db

This is useful for making a SQLite database of the test fixtures for
interactive exploration.
 2018-04-03 06:46:11 -07:00
Simon Willison
8f0d44d646
 		escape_sqlite_table_name => escape_sqlite, handles reserved words 
It can be used for column names as well as table names.

Reserved word list from https://www.sqlite.org/lang_keywords.html
 2018-04-03 06:40:49 -07:00
Simon Willison
7365c3f51c
 		Compound primary key _next= now plays well with extra filters 
Closes #190
 2018-03-29 23:26:22 -07:00
Simon Willison
31f63d1672
 		Fixed bug with keyset pagination over compound primary keys 
Closes #190
 2018-03-29 22:11:02 -07:00
Simon Willison
89d9fbb91b
 		Database/Table views inherit source/license/source_url/license_url metadata 
If you set the source_url/license_url/source/license fields in your root
metadata those values will now be inherited all the way down to the database
and table templates.

The title/description are NOT inherited.

Also added unit tests for the HTML generated by the metadata.

Refs #185
 2018-03-27 09:18:32 -07:00
Simon Willison
306e1c6ac4
 		Broke up test_app into test_api and test_html 2017-12-15 04:08:24 -08:00
Simon Willison
ae94006809
 		No longer include database hash in hyperlinks 
It was making the unit tests unreliable. Also we do not do that for foreign key links.
 2017-12-09 17:31:08 -08:00
Simon Willison
794c3bfcfc
 		Cleaned up row/column display logic, fixed bug 
Closes #167
 2017-12-09 16:59:25 -08:00
Simon Willison
7a7e4b2ed8
 		Started unit tests for row/table HTML pages 
Refs #167

Thanks to the new tests, spotted and fixed a bug where pages that were
supposed to have 100 things on them were actually displaying 101.
 2017-12-09 15:32:54 -08:00
Simon Willison
b01304d707
 		Updated tests I broke in c195ee4 2017-12-09 10:39:19 -08:00
Simon Willison
cbfd6b745e
 		Publish should now work if /tmp is on different device 
Fixes #141
 2017-12-08 08:06:24 -08:00
Simon Willison
709f4f2798
 		Fixed bug with detecting FTS tables 
Closes #135
 2017-12-06 20:54:37 -08:00
Simon Willison
0cfd7ce59d
 		Allow WITH query (previously we required SELECT at start) 
Fixes #161
 2017-12-03 20:51:31 -08:00
Simon Willison
8ab3a169d4
 		CSS styling hooks as classes on the body 
Refs #153

Every template now gets CSS classes in the body designed to support custom
styling.

The index template (the top level page at /) gets this:

    <body class="index">

The database template (/dbname/) gets this:

    <body class="db db-dbname">

The table template (/dbname/tablename) gets:

    <body class="table db-dbname table-tablename">

The row template (/dbname/tablename/rowid) gets:

    <body class="row db-dbname table-tablename">

The db-x and table-x classes use the database or table names themselves IF
they are valid CSS identifiers. If they aren't, we strip any invalid
characters out and append a 6 character md5 digest of the original name, in
order to ensure that multiple tables which resolve to the same stripped
character version still have different CSS classes.

Some examples (extracted from the unit tests):

    "simple" => "simple"
    "MixedCase" => "MixedCase"
    "-no-leading-hyphens" => "no-leading-hyphens-65bea6"
    "_no-leading-underscores" => "no-leading-underscores-b921bc"
    "no spaces" => "no-spaces-7088d7"
    "-" => "336d5e"
    "no $ characters" => "no--characters-59e024"
 2017-11-29 23:09:54 -08:00
Simon Willison
b67890d15d
 		Auto-link column values that look like URLs 
Refs #153
 2017-11-29 09:05:24 -08:00
Simon Willison
c5c923d93c
 		Don't incorrectly detect VIEWs as supporting FTS 2017-11-24 14:51:00 -08:00
Simon Willison
a802cbee74
 		Search now applies to current filters 
Combined search into the same form as filters.

Closes #133
 2017-11-24 14:29:54 -08:00
Simon Willison
b450778391
 		Added column__not=blah filter 
Closes #148
 2017-11-23 14:09:50 -08:00
Simon Willison
a30c5b220c
 		Fixed bug on rows page, added unit test 
Rows page for rows that linked to the same table in more
than one columns were display incorrectly. Fixed that and added a test.

Also introduced /db/table/row-pk.json?_extras=foreign_key_tables

This is used by the new unit test, but is the first example of a new
?_extras=comma-separated-list pattern I am introducing.
 2017-11-23 13:09:45 -08:00
Simon Willison
ef3eacf622
 		Select option for removing filters 2017-11-23 12:32:54 -08:00
Simon Willison
0071b5d6f5
 		Added UI for editing table filters 
Refs #86
 2017-11-22 20:33:55 -08:00
Simon Willison
53534b6e9d
 		Even more complicated redirect scheme 
This:

    ?_filter_column_1=name&_filter_op_1=contains&_filter_value_1=hello
    &_filter_column_2=age&_filter_op_2=gte&_filter_value_2=12

Now redirects to this:

    ?name__contains=hello&age__gte=12

This is needed for the filter editing interface, refs #86
 2017-11-22 20:03:46 -08:00
Simon Willison
c8e7c85fd3
 		Updated test_database_page test 2017-11-22 12:25:51 -08:00
Simon Willison
a9b9d42791
 		Mark FTS-related tables as 'hidden' in inspect() 
Refs #129
 2017-11-21 12:55:59 -08:00
Simon Willison
b4e6211a97
 		Refactored filter logic and added human descriptions - refs #86 2017-11-19 22:03:24 -08:00
Simon Willison
a5881e105a
 		?_filter_column=col&_filter_op=isnull__1 redirect 
if filter_op contains a __ the value is set to the right hand side.

e.g.

    ?_filter_column=col&_filter_op=isnull__1&_filter_value=x

Redirects to:

    ?col__isnull=1

Refs #86
 2017-11-19 12:33:30 -08:00
Simon Willison
386fb11d42
 		?_filter_column=col&_filter_op=op&_filter_value=value redirect 
Part of implementing the filters UI (refs #86) - the following:

    /trees/Trees?_filter_column=SiteOrder&_filter_op=gt&_filter_value=2

Now redirects to this;

    /trees/Trees?SiteOrder__gt=2
 2017-11-19 12:25:29 -08:00
Simon Willison
eed6a0fe36
 		Implemented ?_search=XXX + UI if a FTS table is detected 
Closes #131
 2017-11-19 08:59:26 -08:00
Simon Willison
45e502aace Added unit tests for inspect() foreign key detection 
Used them to fix a bug with it.

Refs #85
 2017-11-17 08:08:11 -08:00