mirror of
https://github.com/simonw/datasette.git
synced 2025-12-10 16:51:24 +01:00
2620938661
Replace one-by-one permission checks with bulk allowed_resources() call: - DatabaseView and QueryView now fetch all allowed tables once - Filter views and tables using pre-fetched allowed_table_set - Update TableResource.resources_sql() to include views from catalog_views This improves performance by reducing permission checks from O(n) to O(1) per table/view, where n is the number of tables in the database. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
69 lines
1.7 KiB
Python
69 lines
1.7 KiB
Python
"""Core resource types for Datasette's permission system."""
|
|
|
|
from datasette.permissions import Resource
|
|
|
|
|
|
class InstanceResource(Resource):
|
|
"""The Datasette instance itself."""
|
|
|
|
name = "instance"
|
|
parent_name = None
|
|
|
|
def __init__(self):
|
|
super().__init__(parent=None, child=None)
|
|
|
|
@classmethod
|
|
def resources_sql(cls) -> str:
|
|
return "SELECT NULL AS parent, NULL AS child"
|
|
|
|
|
|
class DatabaseResource(Resource):
|
|
"""A database in Datasette."""
|
|
|
|
name = "database"
|
|
parent_name = "instance"
|
|
|
|
def __init__(self, database: str):
|
|
super().__init__(parent=database, child=None)
|
|
|
|
@classmethod
|
|
def resources_sql(cls) -> str:
|
|
return """
|
|
SELECT database_name AS parent, NULL AS child
|
|
FROM catalog_databases
|
|
"""
|
|
|
|
|
|
class TableResource(Resource):
|
|
"""A table in a database."""
|
|
|
|
name = "table"
|
|
parent_name = "database"
|
|
|
|
def __init__(self, database: str, table: str):
|
|
super().__init__(parent=database, child=table)
|
|
|
|
@classmethod
|
|
def resources_sql(cls) -> str:
|
|
return """
|
|
SELECT database_name AS parent, table_name AS child
|
|
FROM catalog_tables
|
|
UNION ALL
|
|
SELECT database_name AS parent, view_name AS child
|
|
FROM catalog_views
|
|
"""
|
|
|
|
|
|
class QueryResource(Resource):
|
|
"""A canned query in a database."""
|
|
|
|
name = "query"
|
|
parent_name = "database"
|
|
|
|
def __init__(self, database: str, query: str):
|
|
super().__init__(parent=database, child=query)
|
|
|
|
@classmethod
|
|
def resources_sql(cls) -> str:
|
|
# TODO: Need catalog for queries
|
|
return "SELECT NULL AS parent, NULL AS child WHERE 0"
|