From 6899fd8becd9a5cbf77b5061763e18c0f0d53306 Mon Sep 17 00:00:00 2001 From: joelsvensson Date: Tue, 4 Mar 2025 15:06:23 +0100 Subject: [PATCH 1/4] fix: ShellCheck SC2162 lint error --- .github/workflows/github_pages.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/github_pages.yml b/.github/workflows/github_pages.yml index 9c279ab1..15fa66ed 100644 --- a/.github/workflows/github_pages.yml +++ b/.github/workflows/github_pages.yml @@ -82,7 +82,7 @@ jobs: subprocess.run(cmd, shell=True, check=True) - name: Fix permissions run: | - chmod -c -R +rX "${{ inputs.output-path }}" | while read line; do + chmod -c -R +rX "${{ inputs.output-path }}" | while read -r line; do echo "::warning title=Invalid file permissions automatically fixed::$line" done - name: Upload artifact From 8f825ac9e98f9a768ed4ad6dce02c4f54c84bc5f Mon Sep 17 00:00:00 2001 From: joelsvensson Date: Tue, 4 Mar 2025 15:16:24 +0100 Subject: [PATCH 2/4] add option to install stork on runner --- .github/workflows/github_pages.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/github_pages.yml b/.github/workflows/github_pages.yml index 15fa66ed..4ca0c9fe 100644 --- a/.github/workflows/github_pages.yml +++ b/.github/workflows/github_pages.yml @@ -42,6 +42,11 @@ on: default: true description: "Whether to deploy the site. If true then build the site and deploy it. If false then just test that the site builds successfully but don't deploy anything." type: boolean + stork: + required: false + default: false + description: "Whether to add stork. If true it will be installed on runner" + type: boolean permissions: contents: read pages: write @@ -62,6 +67,9 @@ jobs: - name: Configure GitHub Pages id: pages uses: actions/configure-pages@v5 + - name: Install stork + if: ${{ inputs.stork }} + run: cargo install stork-search --locked - name: Install requirements run: pip install ${{ inputs.requirements }} - name: Build Pelican site From f60e9acfe3fc4e429c8e55a21dad326cb0a4b958 Mon Sep 17 00:00:00 2001 From: joelsvensson Date: Tue, 4 Mar 2025 15:21:13 +0100 Subject: [PATCH 3/4] add stork option do docs --- docs/tips.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/tips.rst b/docs/tips.rst index 4df20ae3..0af5621b 100644 --- a/docs/tips.rst +++ b/docs/tips.rst @@ -252,6 +252,10 @@ Here's the complete list of workflow inputs: | | | change to your website in a pull request | | | | | | before deploying those change. | | | +------------------+----------+--------------------------------------------+--------+---------------+ +| ``stork`` | No | This is used to determine whether stork | bool | ``false`` | +| | | will be installed on the runner to be able | | | +| | | to build a site with stork search enabled | | | ++------------------+----------+--------------------------------------------+--------+---------------+ Testing Your Build in a GitHub Pull Request """"""""""""""""""""""""""""""""""""""""""" From 62bad8cb0abad6d8cd74e5b1a96cbe4ddd2abf3b Mon Sep 17 00:00:00 2001 From: joelsvensson Date: Fri, 4 Apr 2025 06:24:13 +0000 Subject: [PATCH 4/4] minor corrections --- .github/workflows/github_pages.yml | 4 ++-- docs/tips.rst | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/github_pages.yml b/.github/workflows/github_pages.yml index 4ca0c9fe..511a8c01 100644 --- a/.github/workflows/github_pages.yml +++ b/.github/workflows/github_pages.yml @@ -45,7 +45,7 @@ on: stork: required: false default: false - description: "Whether to add stork. If true it will be installed on runner" + description: "Whether to add Stork search tool. If true, it will be installed on runner." type: boolean permissions: contents: read @@ -67,7 +67,7 @@ jobs: - name: Configure GitHub Pages id: pages uses: actions/configure-pages@v5 - - name: Install stork + - name: Install Stork if: ${{ inputs.stork }} run: cargo install stork-search --locked - name: Install requirements diff --git a/docs/tips.rst b/docs/tips.rst index 0af5621b..3d228522 100644 --- a/docs/tips.rst +++ b/docs/tips.rst @@ -252,9 +252,9 @@ Here's the complete list of workflow inputs: | | | change to your website in a pull request | | | | | | before deploying those change. | | | +------------------+----------+--------------------------------------------+--------+---------------+ -| ``stork`` | No | This is used to determine whether stork | bool | ``false`` | +| ``stork`` | No | This is used to determine whether Stork | bool | ``false`` | | | | will be installed on the runner to be able | | | -| | | to build a site with stork search enabled | | | +| | | to build a site with Stork search enabled | | | +------------------+----------+--------------------------------------------+--------+---------------+ Testing Your Build in a GitHub Pull Request