Merge pull request #1701 from avaris/urlwrapper_slug_property

Change URLWrapper.slug to a property
This commit is contained in:
Justin Mayer 2015-04-29 15:58:50 +02:00
commit 222c6e4c03

View file

@ -13,12 +13,10 @@ logger = logging.getLogger(__name__)
@functools.total_ordering @functools.total_ordering
class URLWrapper(object): class URLWrapper(object):
def __init__(self, name, settings): def __init__(self, name, settings):
# next 2 lines are redundant with the setter of the name property
# but are here for clarity
self.settings = settings self.settings = settings
self._name = name self._name = name
self.slug = slugify(name, self.settings.get('SLUG_SUBSTITUTIONS', ())) self._slug = None
self.name = name self._slug_from_name = True
@property @property
def name(self): def name(self):
@ -27,11 +25,28 @@ class URLWrapper(object):
@name.setter @name.setter
def name(self, name): def name(self, name):
self._name = name self._name = name
self.slug = slugify(name, self.settings.get('SLUG_SUBSTITUTIONS', ())) # if slug wasn't explicitly set, it needs to be regenerated from name
# so, changing name should reset slug for slugification
if self._slug_from_name:
self._slug = None
@property
def slug(self):
if self._slug is None:
self._slug = slugify(self.name,
self.settings.get('SLUG_SUBSTITUTIONS', ()))
return self._slug
@slug.setter
def slug(self, slug):
# if slug is expliticly set, changing name won't alter slug
self._slug_from_name = False
self._slug = slug
def as_dict(self): def as_dict(self):
d = self.__dict__ d = self.__dict__
d['name'] = self.name d['name'] = self.name
d['slug'] = self.slug
return d return d
def __hash__(self): def __hash__(self):