From 5ff553f6f337f2ddcb6173bd80af138cdbd298ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= <mosra@centrum.cz>
Date: Sat, 10 Nov 2018 19:42:59 +0100
Subject: [PATCH] Add tests verifying graceful handling on reST errors.

Currently all fail.
---
 pelican/tests/parse_error/parse_error.rst |  4 ++++
 pelican/tests/test_pelican.py             | 15 +++++++++++++++
 pelican/tests/test_readers.py             |  6 ++++++
 3 files changed, 25 insertions(+)
 create mode 100644 pelican/tests/parse_error/parse_error.rst

diff --git a/pelican/tests/parse_error/parse_error.rst b/pelican/tests/parse_error/parse_error.rst
new file mode 100644
index 00000000..7aee68e1
--- /dev/null
+++ b/pelican/tests/parse_error/parse_error.rst
@@ -0,0 +1,4 @@
+Page with a parse error
+#############
+
+The underline is too short.
diff --git a/pelican/tests/test_pelican.py b/pelican/tests/test_pelican.py
index 273fc430..adc07072 100644
--- a/pelican/tests/test_pelican.py
+++ b/pelican/tests/test_pelican.py
@@ -225,3 +225,18 @@ class TestPelican(LoggedTestCase):
             count=1,
             msg="MD_EXTENSIONS is deprecated use MARKDOWN instead.",
             level=logging.WARNING)
+
+    def test_parse_errors(self):
+        # Verify that just an error is printed and the application doesn't
+        # abort, exit or something.
+        settings = read_settings(path=None, override={
+            'PATH': os.path.abspath(os.path.join(CURRENT_DIR, 'parse_error')),
+            'OUTPUT_PATH': self.temp_path,
+            'CACHE_PATH': self.temp_cache,
+        })
+        pelican = Pelican(settings=settings)
+        mute(True)(pelican.run)()
+        self.assertLogCountEqual(
+            count=1,
+            msg="Could not process .*parse_error.rst",
+            level=logging.ERROR)
diff --git a/pelican/tests/test_readers.py b/pelican/tests/test_readers.py
index 4db4938e..81a7d92d 100644
--- a/pelican/tests/test_readers.py
+++ b/pelican/tests/test_readers.py
@@ -410,6 +410,12 @@ class RstReaderTest(ReaderTest):
         self.assertEqual(tuple_date.metadata['date'],
                          string_date.metadata['date'])
 
+    def test_parse_error(self):
+        # Verify that it raises an Exception, not nothing and not SystemExit or
+        # some such
+        with six.assertRaisesRegex(self, Exception, "underline too short"):
+            self.read_file(path='../parse_error/parse_error.rst')
+
 
 @unittest.skipUnless(readers.Markdown, "markdown isn't installed")
 class MdReaderTest(ReaderTest):