From b12443f48a11f542d613f2c52a59fb38919f5604 Mon Sep 17 00:00:00 2001 From: Nam Nguyen Date: Tue, 5 Jan 2021 10:40:31 -0800 Subject: [PATCH 1/2] Use a top (instead of bottom) border in hentry. `hentry` uses `clear: both` with the intention of placing a separator line (1px border) between each entry. However, it is wrongly using `border-bottom` instead of `border-top` to make that separator. CSS `clear` makes space to clear the **preceding** floats. Hence a `border-bottom` won't enjoy that `clear` effect. --- pelican/themes/notmyidea/static/css/main.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pelican/themes/notmyidea/static/css/main.css b/pelican/themes/notmyidea/static/css/main.css index 63f5adc0..aaea9b81 100644 --- a/pelican/themes/notmyidea/static/css/main.css +++ b/pelican/themes/notmyidea/static/css/main.css @@ -384,10 +384,10 @@ div.figure p.caption, figure p.caption { /* margin provided by figure */ .hentry { display: block; clear: both; - border-bottom: 1px solid #eee; + border-top: 1px solid #eee; padding: 1.5em 0; } -li:last-child .hentry, #content > .hentry {border: 0; margin: 0;} +li:first-child .hentry, #content > .hentry {border: 0; margin: 0;} #content > .hentry {padding: 1em 0;} .hentry img{display : none ;} .entry-title {font-size: 3em; margin-bottom: 10px; margin-top: 0;} From 507d68e5c6cb6eb6e184283944d8f4c543996619 Mon Sep 17 00:00:00 2001 From: Nam Nguyen Date: Thu, 7 Jan 2021 14:09:38 -0800 Subject: [PATCH 2/2] Update functional tests. --- pelican/tests/output/basic/theme/css/main.css | 4 ++-- pelican/tests/output/custom/author/alexis-metaireau.html | 2 +- pelican/tests/output/custom/author/alexis-metaireau2.html | 2 +- pelican/tests/output/custom/author/alexis-metaireau3.html | 2 +- pelican/tests/output/custom/index.html | 2 +- pelican/tests/output/custom/index2.html | 2 +- pelican/tests/output/custom/index3.html | 2 +- pelican/tests/output/custom/theme/css/main.css | 4 ++-- .../tests/output/custom_locale/author/alexis-metaireau.html | 2 +- .../tests/output/custom_locale/author/alexis-metaireau2.html | 2 +- .../tests/output/custom_locale/author/alexis-metaireau3.html | 2 +- pelican/tests/output/custom_locale/index.html | 2 +- pelican/tests/output/custom_locale/index2.html | 2 +- pelican/tests/output/custom_locale/index3.html | 2 +- pelican/tests/output/custom_locale/theme/css/main.css | 4 ++-- 15 files changed, 18 insertions(+), 18 deletions(-) diff --git a/pelican/tests/output/basic/theme/css/main.css b/pelican/tests/output/basic/theme/css/main.css index 63f5adc0..aaea9b81 100644 --- a/pelican/tests/output/basic/theme/css/main.css +++ b/pelican/tests/output/basic/theme/css/main.css @@ -384,10 +384,10 @@ div.figure p.caption, figure p.caption { /* margin provided by figure */ .hentry { display: block; clear: both; - border-bottom: 1px solid #eee; + border-top: 1px solid #eee; padding: 1.5em 0; } -li:last-child .hentry, #content > .hentry {border: 0; margin: 0;} +li:first-child .hentry, #content > .hentry {border: 0; margin: 0;} #content > .hentry {padding: 1em 0;} .hentry img{display : none ;} .entry-title {font-size: 3em; margin-bottom: 10px; margin-top: 0;} diff --git a/pelican/tests/output/custom/author/alexis-metaireau.html b/pelican/tests/output/custom/author/alexis-metaireau.html index 7a277e2c..f768b15e 100644 --- a/pelican/tests/output/custom/author/alexis-metaireau.html +++ b/pelican/tests/output/custom/author/alexis-metaireau.html @@ -168,4 +168,4 @@ }()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom/author/alexis-metaireau2.html b/pelican/tests/output/custom/author/alexis-metaireau2.html index a5588090..96b34bff 100644 --- a/pelican/tests/output/custom/author/alexis-metaireau2.html +++ b/pelican/tests/output/custom/author/alexis-metaireau2.html @@ -183,4 +183,4 @@ YEAH !

}()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom/author/alexis-metaireau3.html b/pelican/tests/output/custom/author/alexis-metaireau3.html index 095b39b6..c8ee5759 100644 --- a/pelican/tests/output/custom/author/alexis-metaireau3.html +++ b/pelican/tests/output/custom/author/alexis-metaireau3.html @@ -133,4 +133,4 @@ pelican.conf, it will …

}()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom/index.html b/pelican/tests/output/custom/index.html index e63db6ec..ff675f85 100644 --- a/pelican/tests/output/custom/index.html +++ b/pelican/tests/output/custom/index.html @@ -168,4 +168,4 @@ }()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom/index2.html b/pelican/tests/output/custom/index2.html index 570e3b81..941c176e 100644 --- a/pelican/tests/output/custom/index2.html +++ b/pelican/tests/output/custom/index2.html @@ -183,4 +183,4 @@ YEAH !

}()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom/index3.html b/pelican/tests/output/custom/index3.html index f92bdbb1..ce73759d 100644 --- a/pelican/tests/output/custom/index3.html +++ b/pelican/tests/output/custom/index3.html @@ -133,4 +133,4 @@ pelican.conf, it will …

}()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom/theme/css/main.css b/pelican/tests/output/custom/theme/css/main.css index 63f5adc0..aaea9b81 100644 --- a/pelican/tests/output/custom/theme/css/main.css +++ b/pelican/tests/output/custom/theme/css/main.css @@ -384,10 +384,10 @@ div.figure p.caption, figure p.caption { /* margin provided by figure */ .hentry { display: block; clear: both; - border-bottom: 1px solid #eee; + border-top: 1px solid #eee; padding: 1.5em 0; } -li:last-child .hentry, #content > .hentry {border: 0; margin: 0;} +li:first-child .hentry, #content > .hentry {border: 0; margin: 0;} #content > .hentry {padding: 1em 0;} .hentry img{display : none ;} .entry-title {font-size: 3em; margin-bottom: 10px; margin-top: 0;} diff --git a/pelican/tests/output/custom_locale/author/alexis-metaireau.html b/pelican/tests/output/custom_locale/author/alexis-metaireau.html index 9b4ca7dd..68054d97 100644 --- a/pelican/tests/output/custom_locale/author/alexis-metaireau.html +++ b/pelican/tests/output/custom_locale/author/alexis-metaireau.html @@ -168,4 +168,4 @@ }()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom_locale/author/alexis-metaireau2.html b/pelican/tests/output/custom_locale/author/alexis-metaireau2.html index a1848677..16431fb9 100644 --- a/pelican/tests/output/custom_locale/author/alexis-metaireau2.html +++ b/pelican/tests/output/custom_locale/author/alexis-metaireau2.html @@ -183,4 +183,4 @@ YEAH !

}()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom_locale/author/alexis-metaireau3.html b/pelican/tests/output/custom_locale/author/alexis-metaireau3.html index 78fdd866..d43663bd 100644 --- a/pelican/tests/output/custom_locale/author/alexis-metaireau3.html +++ b/pelican/tests/output/custom_locale/author/alexis-metaireau3.html @@ -133,4 +133,4 @@ pelican.conf, it will …

}()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom_locale/index.html b/pelican/tests/output/custom_locale/index.html index 29e12b1b..6e0d632d 100644 --- a/pelican/tests/output/custom_locale/index.html +++ b/pelican/tests/output/custom_locale/index.html @@ -168,4 +168,4 @@ }()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom_locale/index2.html b/pelican/tests/output/custom_locale/index2.html index c0727385..5ff21fac 100644 --- a/pelican/tests/output/custom_locale/index2.html +++ b/pelican/tests/output/custom_locale/index2.html @@ -183,4 +183,4 @@ YEAH !

}()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom_locale/index3.html b/pelican/tests/output/custom_locale/index3.html index 0d2722f2..97ca0bb4 100644 --- a/pelican/tests/output/custom_locale/index3.html +++ b/pelican/tests/output/custom_locale/index3.html @@ -133,4 +133,4 @@ pelican.conf, it will …

}()); - + \ No newline at end of file diff --git a/pelican/tests/output/custom_locale/theme/css/main.css b/pelican/tests/output/custom_locale/theme/css/main.css index 63f5adc0..aaea9b81 100644 --- a/pelican/tests/output/custom_locale/theme/css/main.css +++ b/pelican/tests/output/custom_locale/theme/css/main.css @@ -384,10 +384,10 @@ div.figure p.caption, figure p.caption { /* margin provided by figure */ .hentry { display: block; clear: both; - border-bottom: 1px solid #eee; + border-top: 1px solid #eee; padding: 1.5em 0; } -li:last-child .hentry, #content > .hentry {border: 0; margin: 0;} +li:first-child .hentry, #content > .hentry {border: 0; margin: 0;} #content > .hentry {padding: 1em 0;} .hentry img{display : none ;} .entry-title {font-size: 3em; margin-bottom: 10px; margin-top: 0;}