github/pelican
1
0
Fork 1
mirror of https://github.com/getpelican/pelican.git synced 2025-10-15 20:28:56 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Terminate with non-zero exit as error handling default. Fixes #3172.

Browse source
This commit is contained in:
Andreas Krüger 2023-08-15 11:36:30 +02:00
commit 8c01dbfad8
No known key found for this signature in database
GPG key ID: 4779172E114322B8
3 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
RELEASE.md Normal file
View file

@ -0,0 +1,3 @@
Release type: major
Change default of `--fatal` command line switch to terminate on error.

8
pelican/__init__.py
View file

@ -358,10 +358,10 @@ def parse_arguments(argv=None):
dest='selected_paths', default=None,
help='Comma separated list of selected paths to write')
parser.add_argument('--fatal', metavar='errors|warnings',
choices=('errors', 'warnings'), default='',
parser.add_argument('--fatal', metavar='errors|warnings|ignore',
choices=('errors', 'warnings', 'ignore'), default='errors',
help=('Exit the program with non-zero status if any '
'errors/warnings encountered.'))
'errors/warnings encountered, or ignore any errors.'))
parser.add_argument('--logs-dedup-min-level', default='WARNING',
choices=('DEBUG', 'INFO', 'WARNING', 'ERROR'),
@ -525,7 +525,7 @@ def listen(server, port, output, excqueue=None):
def main(argv=None):
args = parse_arguments(argv)
logs_dedup_min_level = getattr(logging, args.logs_dedup_min_level)
init_logging(level=args.verbosity, fatal=args.fatal,
init_logging(level=args.verbosity, fatal=(args.fatal if args.fatal != 'ignore' else ''),
name=__name__, logs_dedup_min_level=logs_dedup_min_level)
logger.debug('Pelican version: %s', __version__)

2
pelican/log.py
View file

@ -103,7 +103,7 @@ logging.setLoggerClass(FatalLogger)
logging.getLogger().__class__ = FatalLogger
def init(level=None, fatal='', handler=RichHandler(console=console), name=None,
def init(level=None, fatal='errors', handler=RichHandler(console=console), name=None,
logs_dedup_min_level=None):
FatalLogger.warnings_fatal = fatal.startswith('warning')
FatalLogger.errors_fatal = bool(fatal)