github/pelican
1
0
Fork 1
mirror of https://github.com/getpelican/pelican.git synced 2025-10-15 20:28:56 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use the with statement when opening files.

Browse source
This commit is contained in:
Alexis Metaireau 2012-03-09 16:17:09 +01:00
commit df25dec30a
2 changed files with 11 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
pelican/generators.py
View file

@ -375,7 +375,8 @@ class PdfGenerator(Generator):
filename = obj.slug + ".pdf" filename = obj.slug + ".pdf"
output_pdf=os.path.join(output_path, filename) output_pdf=os.path.join(output_path, filename)
# print "Generating pdf for", obj.filename, " in ", output_pdf # print "Generating pdf for", obj.filename, " in ", output_pdf
self.pdfcreator.createPdf(text=open(obj.filename), output=output_pdf) with open(obj.filename) as f:
self.pdfcreator.createPdf(text=f, output=output_pdf)
info(u' [ok] writing %s' % output_pdf) info(u' [ok] writing %s' % output_pdf)
def generate_context(self): def generate_context(self):

18
pelican/readers.py
View file

@ -121,20 +121,20 @@ class HtmlReader(Reader):
def read(self, filename): def read(self, filename):
"""Parse content and metadata of (x)HTML files""" """Parse content and metadata of (x)HTML files"""
content = open(filename) with open(filename) as content:
metadata = {'title':'unnamed'} metadata = {'title': 'unnamed'}
for i in self._re.findall(content): for i in self._re.findall(content):
key = i.split(':')[0][5:].strip() key = i.split(':')[0][5:].strip()
value = i.split(':')[-1][:-3].strip() value = i.split(':')[-1][:-3].strip()
name = key.lower() name = key.lower()
metadata[name] = self.process_metadata(name, value) metadata[name] = self.process_metadata(name, value)
return content, metadata
return content, metadata
_EXTENSIONS = dict((cls.extension, cls) for cls in Reader.__subclasses__()) _EXTENSIONS = dict((cls.extension, cls) for cls in Reader.__subclasses__())
def read_file(filename, fmt=None, settings=None): def read_file(filename, fmt=None, settings=None):
"""Return a reader object using the given format.""" """Return a reader object using the given format."""
if not fmt: if not fmt: