mirror of
https://github.com/basnijholt/adaptive-lighting.git
synced 2026-09-27 20:34:20 +02:00
fix: entity translations were dead, and both validators disabled themselves
Entity._name_internal returns _attr_name before it ever consults translation_key (homeassistant/helpers/entity.py:689). sensor.py and number.py set both, so every entity.sensor.* and entity.number.* string added to strings.json has been unreachable — the five sliders and five sensors rendered English regardless of the user's language, bolted onto an integration that is otherwise translated into 36. Dropping the three _attr_name assignments makes the keys live; display_name was then a dead constructor parameter and goes too. Two keys existed in strings.json but not translations/en.json (ambient_lux, lux_reduction) and ramp_half_width was in neither, so a bare deletion would have left three entities unnamed. Added them to both files. ambient_lux carries unit lx and is textbook SensorDeviceClass.ILLUMINANCE; it was inheriting the class-level _attr_device_class = None along with the four curve outputs that genuinely have no equivalent. Without it the sensor loses standard icon, unit handling and long-term-statistics grouping. Now a per-key lookup, so the outputs keep their honest None. The five number entities are behaviour knobs, not state — EntityCategory.CONFIG moves them off the primary device page. Both validate.yml and hassfest.yaml carried `schedule: cron "0 0 * * *"`, and GitHub auto-disables any workflow with a schedule after 60 days of repository inactivity. Both were taken out on 2026-09-08, 60 days after the last push. A disabled workflow also stops answering push and pull_request, so this repo now has no HACS or hassfest validation at all. Removing the cron is the durable fix; re-enabling in the UI just restarts the same clock. README claimed the tanh ramp has "a fixed 30-minute half-width" 60 lines above documenting the live 5-120 min slider that replaced it. 164 tests pass, ruff clean.
This commit is contained in:
parent
d5dc129c11
commit
6725f164aa
7 changed files with 58 additions and 31 deletions
6
.github/workflows/hassfest.yaml
vendored
6
.github/workflows/hassfest.yaml
vendored
|
|
@ -4,9 +4,11 @@ on:
|
|||
push:
|
||||
branches: [main, master]
|
||||
pull_request:
|
||||
schedule:
|
||||
- cron: "0 0 * * *"
|
||||
workflow_dispatch:
|
||||
# No schedule: GitHub auto-disables any workflow containing one after 60
|
||||
# days of repository inactivity, and a disabled workflow stops answering
|
||||
# push and pull_request too. Both of this repo's validators were taken
|
||||
# out that way on 2026-09-08.
|
||||
|
||||
jobs:
|
||||
validate_hassfest:
|
||||
|
|
|
|||
6
.github/workflows/validate.yml
vendored
6
.github/workflows/validate.yml
vendored
|
|
@ -4,9 +4,11 @@ on:
|
|||
push:
|
||||
branches: [main, master]
|
||||
pull_request:
|
||||
schedule:
|
||||
- cron: "0 0 * * *"
|
||||
workflow_dispatch:
|
||||
# No schedule: GitHub auto-disables any workflow containing one after 60
|
||||
# days of repository inactivity, and a disabled workflow stops answering
|
||||
# push and pull_request too. Both of this repo's validators were taken
|
||||
# out that way on 2026-09-08.
|
||||
|
||||
jobs:
|
||||
validate_hacs:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue