remote/adaptive-lighting
1
0
Fork 0
mirror of https://github.com/basnijholt/adaptive-lighting.git synced 2026-09-27 04:14:47 +02:00
Code Issues Projects Releases Packages Wiki Activity

lux_reduction sensor: report reduction %, not retained factor

Browse source 
The 'Lux reduction' sensor published the retained brightness factor, so it
read 100% when nothing was being reduced (0% actual reduction) — the label
and value were inverses. Now it publishes the actual reduction:
100 - round(factor*100), so 0% = no dimming, higher = more cut, None when
the gate is inactive.

Updates the output-sensors spec scenarios to match (71 -> 29, 100 -> 0,
adds the gate-inactive None case) and adds a publish-level value test
(none existed — the prior scenarios were never enforced in code).
This commit is contained in:
Casey 2026-05-30 22:35:59 +02:00
commit 76f04237d7
3 changed files with 43 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

28
tests/test_sensor_platform.py
View file

@ -20,6 +20,8 @@ from pytest_homeassistant_custom_component.common import MockConfigEntry
from custom_components.adaptive_lighting import sensor as sensor_module
from custom_components.adaptive_lighting.const import (
CONF_LUX_SENSOR,
CONF_TARGET_LUX,
CONFIG_ENTRY_VERSION,
DOMAIN,
OUTPUT_SENSORS,
@ -194,6 +196,32 @@ async def test_curve_tick_publishes_outputs(hass) -> None:
assert outputs["updated_at"] >= before
async def test_lux_reduction_reports_reduction_not_retained_factor(hass) -> None:
"""lux_reduction is the percentage *reduced* (0 = none), not the kept factor."""
entry = await _setup_entry(
hass,
options={CONF_LUX_SENSOR: "sensor.test_lux", CONF_TARGET_LUX: 500},
)
al_switch = hass.data[DOMAIN][entry.entry_id]["switch"]
al_switch._settings.update({"brightness_pct": 80, "color_temp_kelvin": 3000})
hass.states.async_set("sun.sun", "above_horizon", {"elevation": 10.0})
# Above target -> dimming. factor = 500/700 = 0.714 -> reduction = 29 %.
hass.states.async_set("sensor.test_lux", "700")
al_switch._publish_outputs_and_wake_sensors()
assert hass.data[DOMAIN][entry.entry_id]["outputs"]["lux_reduction"] == 29
# At/below target -> no reduction -> 0 % (the at-rest value).
hass.states.async_set("sensor.test_lux", "300")
al_switch._publish_outputs_and_wake_sensors()
assert hass.data[DOMAIN][entry.entry_id]["outputs"]["lux_reduction"] == 0
# No usable reading -> gate inactive -> None (sensor renders unknown).
hass.states.async_set("sensor.test_lux", "unavailable")
al_switch._publish_outputs_and_wake_sensors()
assert hass.data[DOMAIN][entry.entry_id]["outputs"]["lux_reduction"] is None
# ---------------------------------------------------------------------------
# 4.7 — Firing the dispatcher signal updates the three sensors
# ---------------------------------------------------------------------------