Commit graph

8 commits

Author SHA1 Message Date
Casey
6725f164aa fix: entity translations were dead, and both validators disabled themselves
Entity._name_internal returns _attr_name before it ever consults
translation_key (homeassistant/helpers/entity.py:689). sensor.py and number.py
set both, so every entity.sensor.* and entity.number.* string added to
strings.json has been unreachable — the five sliders and five sensors rendered
English regardless of the user's language, bolted onto an integration that is
otherwise translated into 36. Dropping the three _attr_name assignments makes
the keys live; display_name was then a dead constructor parameter and goes too.

Two keys existed in strings.json but not translations/en.json (ambient_lux,
lux_reduction) and ramp_half_width was in neither, so a bare deletion would
have left three entities unnamed. Added them to both files.

ambient_lux carries unit lx and is textbook SensorDeviceClass.ILLUMINANCE; it
was inheriting the class-level _attr_device_class = None along with the four
curve outputs that genuinely have no equivalent. Without it the sensor loses
standard icon, unit handling and long-term-statistics grouping. Now a per-key
lookup, so the outputs keep their honest None.

The five number entities are behaviour knobs, not state — EntityCategory.CONFIG
moves them off the primary device page.

Both validate.yml and hassfest.yaml carried `schedule: cron "0 0 * * *"`, and
GitHub auto-disables any workflow with a schedule after 60 days of repository
inactivity. Both were taken out on 2026-09-08, 60 days after the last push. A
disabled workflow also stops answering push and pull_request, so this repo now
has no HACS or hassfest validation at all. Removing the cron is the durable
fix; re-enabling in the UI just restarts the same clock.

README claimed the tanh ramp has "a fixed 30-minute half-width" 60 lines above
documenting the live 5-120 min slider that replaced it.

164 tests pass, ruff clean.
2026-09-08 13:34:27 +02:00
Casey Romkes
3db6a5490e ci: add workflow_dispatch to validation workflows (manual re-run) 2026-06-09 16:36:53 +02:00
Casey Romkes
262bfa5e17 fix hassfest: drop invalid 'homeassistant' manifest key; run validation on main
- manifest.json: remove the 'homeassistant' key (not a valid manifest key;
  the min HA version lives in hacs.json). Verified hassfest-clean locally.
- validate.yml / hassfest.yaml: trigger on push to main (default branch) too,
  not only master, so CI actually runs.
2026-06-09 14:21:27 +02:00
renovate[bot]
b34cc1ffaa
⬆️ Update actions/checkout action to v6 (#1288)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-27 09:27:27 -08:00
renovate[bot]
4739863fb2
⬆️ Update actions/checkout action to v4 (#1106)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-05 21:49:56 +02:00
Bas Nijholt
54eba57baf Rename steps in CI 2022-08-29 08:38:37 -07:00
Bas Nijholt
377333beb2 Do not duplicate tests 2022-08-28 12:29:42 -07:00
@RubenKelevra
449de6510f
add validation workflow for HACS 2021-08-01 17:47:20 +02:00