remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-05-28 04:46:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

API explorer special case for rowid in /-/upsert

Browse source 
Refs #1936
This commit is contained in:
Simon Willison 2026-04-15 15:47:48 -07:00
commit 1a7030d668
2 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
datasette/views/special.py
View file

@ -817,11 +817,14 @@ class ApiExplorerView(BaseView):
column,
(
" (primary key)"
if column in pks
if column in (pks or ["rowid"])
else ""
),
)
for column in await db.table_columns(table)
for column in (
(["rowid"] if not pks else [])
+ await db.table_columns(table)
)
}
]
},

21
tests/test_api_write.py
View file

@ -47,7 +47,6 @@ def _headers(token):
@pytest.mark.asyncio
async def test_api_explorer_upsert_example_json(ds_write):
response = await ds_write.client.get("/-/api", actor={"id": "root"})
print("STATUS", response.status_code)
assert response.status_code == 200
import urllib.parse
@ -60,6 +59,26 @@ async def test_api_explorer_upsert_example_json(ds_write):
assert '"age": "<age>"' in upsert_chunk
@pytest.mark.asyncio
async def test_api_explorer_upsert_example_json_rowid_table(tmp_path_factory):
db_path = str(tmp_path_factory.mktemp("dbs") / "data.db")
conn = sqlite3.connect(db_path)
conn.execute("create table things (title text, score float)")
conn.close()
ds = Datasette([db_path])
ds.root_enabled = True
response = await ds.client.get("/-/api", actor={"id": "root"})
assert response.status_code == 200
import urllib.parse
text = urllib.parse.unquote_plus(response.text)
upsert_idx = text.index("/data/things/-/upsert")
upsert_chunk = text[upsert_idx : upsert_idx + 500]
assert '"rowid": "<rowid (primary key)>"' in upsert_chunk
assert '"title": "<title>"' in upsert_chunk
assert '"score": "<score>"' in upsert_chunk
@pytest.mark.asyncio
@pytest.mark.parametrize(
"content_type",