remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-09-28 04:44:21 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix race in mobile column actions dialog test

Browse source 
The dialog's aria-expanded sync on the trigger button runs from the
native dialog close event, which fires in a queued task after the
dialog is already hidden. Use a retrying expect() assertion instead of
reading the attribute immediately.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TShiUYVMmmF4zyJR6GMw34
This commit is contained in:
Claude 2026-07-02 16:24:05 +00:00
commit 256ce15184
No known key found for this signature in database
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/test_playwright.py
View file

@ -937,6 +937,9 @@ def test_column_chooser_dialog_escape_discards_changes(page, datasette_server):
@pytest.mark.playwright
def test_mobile_column_actions_dialog(page, datasette_server):
# Deferred import so collecting this module works without playwright
from playwright.sync_api import expect
page.set_viewport_size({"width": 400, "height": 800})
page.goto(f"{datasette_server}data/projects")
trigger = page.locator("button.column-actions-mobile")
@ -956,7 +959,9 @@ def test_mobile_column_actions_dialog(page, datasette_server):
dialog.locator(".mobile-column-actions-done").click()
dialog.wait_for(state="hidden")
assert trigger.get_attribute("aria-expanded") == "false"
# aria-expanded resets from the dialog close event, which fires in a
# queued task after the dialog is already hidden - so poll for it
expect(trigger).to_have_attribute("aria-expanded", "false")
@pytest.mark.playwright