From 28d811320b859bdc10b69d061703b5f90a949b0f Mon Sep 17 00:00:00 2001
From: Alex Garcia <alexsebastian.garcia@gmail.com>
Date: Fri, 10 Jul 2026 10:44:58 -0700
Subject: [PATCH] Version-agnostic CodeMirror bundle filenames,
 rollup.config.mjs build

cm-editor-6.0.1.{js,bundle.js} -> cm-editor.{js,bundle.js}; new
npm run build:codemirror replaces the documented rollup one-liner.
Cache busting already handled by the static() template helper's
?_hash= content hash.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 ...m-editor-6.0.1.bundle.js => cm-editor.bundle.js} |  0
 .../static/{cm-editor-6.0.1.js => cm-editor.js}     |  0
 datasette/templates/_codemirror.html                |  2 +-
 docs/contributing.rst                               | 13 +++++--------
 package.json                                        |  1 +
 rollup.config.mjs                                   | 12 ++++++++++++
 6 files changed, 19 insertions(+), 9 deletions(-)
 rename datasette/static/{cm-editor-6.0.1.bundle.js => cm-editor.bundle.js} (100%)
 rename datasette/static/{cm-editor-6.0.1.js => cm-editor.js} (100%)
 create mode 100644 rollup.config.mjs

diff --git a/datasette/static/cm-editor-6.0.1.bundle.js b/datasette/static/cm-editor.bundle.js
similarity index 100%
rename from datasette/static/cm-editor-6.0.1.bundle.js
rename to datasette/static/cm-editor.bundle.js
diff --git a/datasette/static/cm-editor-6.0.1.js b/datasette/static/cm-editor.js
similarity index 100%
rename from datasette/static/cm-editor-6.0.1.js
rename to datasette/static/cm-editor.js
diff --git a/datasette/templates/_codemirror.html b/datasette/templates/_codemirror.html
index 75c16168..657f99ac 100644
--- a/datasette/templates/_codemirror.html
+++ b/datasette/templates/_codemirror.html
@@ -1,5 +1,5 @@
 <script src="{{ static('sql-formatter-2.3.3.min.js') }}" defer></script>
-<script src="{{ static('cm-editor-6.0.1.bundle.js') }}"></script>
+<script src="{{ static('cm-editor.bundle.js') }}"></script>
 <style>
   .cm-editor {
     resize: both;
diff --git a/docs/contributing.rst b/docs/contributing.rst
index 692f94c8..21470f6e 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -434,13 +434,10 @@ Datasette bundles `CodeMirror <https://codemirror.net/>`__ for the SQL editing i
 
     npm i codemirror @codemirror/lang-sql
 
-* Build the bundle using the version number from package.json with::
+* Build the bundle with::
 
-    node_modules/.bin/rollup datasette/static/cm-editor-6.0.1.js \
-      -f iife \
-      -n cm \
-      -o datasette/static/cm-editor-6.0.1.bundle.js \
-      -p @rollup/plugin-node-resolve \
-      -p @rollup/plugin-terser
+    npm install && npm run build:codemirror
 
-* Update the version reference in the ``codemirror.html`` template.
+  This runs ``rollup -c`` against the ``rollup.config.mjs`` file at the root of the repository, which reads ``datasette/static/cm-editor.js`` and writes the bundled, minified output to ``datasette/static/cm-editor.bundle.js``. The bundle filename does not include the CodeMirror version number, so no template needs to be updated.
+
+* Commit the rebuilt ``datasette/static/cm-editor.bundle.js`` - the bundle is checked into the repository.
diff --git a/package.json b/package.json
index 4d4c3e0c..91335fb5 100644
--- a/package.json
+++ b/package.json
@@ -5,6 +5,7 @@
     "prettier": "^3.0.0"
   },
   "scripts": {
+    "build:codemirror": "rollup -c",
     "fix": "npm run prettier -- --write",
     "prettier": "prettier 'datasette/static/*[!.min|bundle].js'"
   },
diff --git a/rollup.config.mjs b/rollup.config.mjs
new file mode 100644
index 00000000..875b2822
--- /dev/null
+++ b/rollup.config.mjs
@@ -0,0 +1,12 @@
+import { nodeResolve } from "@rollup/plugin-node-resolve";
+import terser from "@rollup/plugin-terser";
+
+export default {
+  input: "datasette/static/cm-editor.js",
+  output: {
+    file: "datasette/static/cm-editor.bundle.js",
+    format: "iife",
+    name: "cm",
+  },
+  plugins: [nodeResolve(), terser()],
+};