remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-09-29 21:34:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

Drop table button in alter dialog

Browse source
This commit is contained in:
Simon Willison 2026-06-19 22:40:14 -07:00
commit 354780a136
4 changed files with 111 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
tests/test_table_html.py
View file

@ -1089,8 +1089,9 @@ async def test_table_alter_action_button_and_data():
"tables": {
"items": {
"permissions": {
"alter-table": {"id": "root"},
"alter-table": {"id": ["root", "alter-only"]},
"set-column-type": {"id": "root"},
"drop-table": {"id": "root"},
},
"column_types": {"name": "textarea"},
},
@ -1147,6 +1148,7 @@ async def test_table_alter_action_button_and_data():
"textarea",
"url",
]
assert alter_data["dropPath"] == "/data/items/-/drop"
assert alter_data["columns"] == [
{
"name": "id",
@ -1192,6 +1194,16 @@ async def test_table_alter_action_button_and_data():
is None
)
assert "alterTable" not in table_data_from_soup(soup_without_permission)
# An actor that can alter but not drop should not get a dropPath
response_alter_only = await ds.client.get(
"/data/items", actor={"id": "alter-only"}
)
assert response_alter_only.status_code == 200
alter_only_data = table_data_from_soup(
Soup(response_alter_only.text, "html.parser")
)["alterTable"]
assert "dropPath" not in alter_only_data
finally:
ds.close()