remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-06-12 03:57:00 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix write query failing when a named parameter is called :sql (#2765)

Browse source 
Closes #2761
This commit is contained in:
Viraat Das 2026-06-10 20:15:03 -07:00 • committed by GitHub
commit 3c1012dcc2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 79 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/test_html.py
View file

@ -342,7 +342,7 @@ async def test_query_parameter_form_fields(ds_client):
response = await ds_client.get("/fixtures/-/query?sql=select+:name")
assert response.status_code == 200
assert (
'<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="" data-parameter-control>'
'<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="" data-parameter-control data-parameter-name="name">'
in response.text
)
assert 'data-parameters-url="/fixtures/-/query/parameters"' in response.text
@ -351,7 +351,7 @@ async def test_query_parameter_form_fields(ds_client):
response2 = await ds_client.get("/fixtures/-/query?sql=select+:name&name=hello")
assert response2.status_code == 200
assert (
'<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="hello" data-parameter-control>'
'<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="hello" data-parameter-control data-parameter-name="name">'
in response2.text
)