From 557e08c6ef02ba1ddee264400868d0295e11c734 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 5 Jul 2026 22:46:00 -0700
Subject: [PATCH] Make binary playwright test more robust

Failed here: https://github.com/simonw/datasette/actions/runs/28746832371/job/85239037361
---
 tests/test_playwright.py | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 15c642fe..eb1edb57 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -356,6 +356,14 @@ def binary_file_blob(datasette_server, pk):
     return response.content
 
 
+def wait_for_binary_control_file(binary_control, size, name=None):
+    binary_control.locator(
+        ".row-edit-binary-size", has_text=f"Binary: {size} bytes"
+    ).wait_for()
+    if name:
+        binary_control.locator(".row-edit-binary-name", has_text=name).wait_for()
+
+
 def bulk_default_rows(datasette_server, **filters):
     params = {
         "_shape": "objects",
@@ -1516,11 +1524,7 @@ def test_edit_row_binary_control_replaces_blob_from_file(page, datasette_server)
             "buffer": replacement,
         }
     )
-    assert (
-        binary_control.locator(".row-edit-binary-size").inner_text()
-        == f"Binary: {len(replacement)} bytes"
-    )
-    assert "replacement.bin" in binary_control.inner_text()
+    wait_for_binary_control_file(binary_control, len(replacement), "replacement.bin")
 
     dialog.locator(".row-edit-save").click()
     page.locator(".row-mutation-status", has_text="Updated row 1").wait_for()
@@ -1547,10 +1551,7 @@ def test_edit_row_binary_control_handles_null_blob(page, datasette_server):
             "buffer": replacement,
         }
     )
-    assert (
-        binary_control.locator(".row-edit-binary-size").inner_text()
-        == f"Binary: {len(replacement)} bytes"
-    )
+    wait_for_binary_control_file(binary_control, len(replacement), "from-null.bin")
 
     dialog.locator(".row-edit-save").click()
     page.locator(".row-mutation-status", has_text="Updated row 3").wait_for()
@@ -1583,11 +1584,7 @@ def test_insert_row_binary_control_accepts_pasted_file(page, datasette_server):
         }""",
         list(pasted),
     )
-    assert (
-        binary_control.locator(".row-edit-binary-size").inner_text()
-        == f"Binary: {len(pasted)} bytes"
-    )
-    assert "pasted.bin" in binary_control.inner_text()
+    wait_for_binary_control_file(binary_control, len(pasted), "pasted.bin")
 
     dialog.locator(".row-edit-save").click()
     page.locator(".row-mutation-status", has_text="Inserted row 4").wait_for()