remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-05-27 20:36:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix mobile column actions not showing items for SQL views (#2670)

Browse source 
* Fix mobile column actions not showing items for SQL views

The previous fix to exclude the Link column from mobile column actions
(d02072b) used .dropdown-menu-icon presence as a proxy, but dropdown
icons are only added to sortable columns (those with <a> tags). This
caused all non-sortable columns to be excluded too.

Instead, explicitly mark the Link column with a data-is-link-column
attribute and filter by that in mobileColumnHeaders, so non-sortable
columns on views and tables still appear in the mobile column actions.

* Prettier formatting for mobile-column-actions.js

https://claude.ai/code/session_01CG545gLcZxet7dS5nMzfCd
This commit is contained in:
Simon Willison 2026-03-18 09:46:36 -07:00 • committed by GitHub
commit 68966880c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tests/test_table_html.py
View file

@ -248,6 +248,7 @@ async def test_sort_links(ds_client):
"data-column-type": "",
"data-column-not-null": "0",
"data-is-pk": "0",
"data-is-link-column": "1",
},
"a_href": None,
},