remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-06-07 09:36:57 +02:00
Code Issues Projects Releases Packages Wiki Activity

datasette inspect now counts 10,000+ tables correctly (#2752)

Browse source 
Closes #2712

Refs https://github.com/simonw/datasette/pull/2721#issuecomment-4568966383
This commit is contained in:
Simon Willison 2026-05-28 15:52:51 -07:00 • committed by GitHub
commit 6a998610ee
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 22 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/test_cli.py
View file

@ -35,12 +35,28 @@ def test_inspect_cli(app_client):
assert expected_count == database["tables"][table_name]["count"]
def test_inspect_cli_counts_all_rows(tmp_path):
db_path = tmp_path / "big.db"
conn = sqlite3.connect(db_path)
with conn:
conn.execute("create table t (id integer primary key)")
conn.executemany("insert into t (id) values (?)", ((i,) for i in range(10002)))
conn.close()
runner = CliRunner()
result = runner.invoke(cli, ["inspect", str(db_path)])
assert result.exit_code == 0, result.output
data = json.loads(result.output)
assert data["big"]["tables"]["t"]["count"] == 10002
def test_inspect_cli_writes_to_file(app_client):
runner = CliRunner()
result = runner.invoke(
cli, ["inspect", "fixtures.db", "--inspect-file", "foo.json"]
)
assert 0 == result.exit_code, result.output
assert result.exit_code == 0, result.output
with open("foo.json") as fp:
data = json.load(fp)
assert ["fixtures"] == list(data.keys())