From 74244c9f41060f953c210b75a752db5367fe5926 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 4 Oct 2026 10:33:51 +0000 Subject: [PATCH] Correct the explanation in a memory-database test comment Commit 6f87527 said SQLite 3.53 refuses VACUUM INTO an existing in-memory database. That was wrong: the test ran VACUUM INTO from a connection opened without uri=True, and SQLite builds without SQLITE_USE_URI (the uv/ python-build-standalone 3.14 builds) treat the target as a plain file name, so the first run created a file literally named "file:review_fixes_copy?mode=memory&cache=shared" and later runs failed with "output file already exists". The test already uses a plain connection; only the comment changes. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01EwkLo2rJWidpkDVT3HkvNv --- tests/test_connection_review_fixes.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/test_connection_review_fixes.py b/tests/test_connection_review_fixes.py index 233ae64b..209b6e49 100644 --- a/tests/test_connection_review_fixes.py +++ b/tests/test_connection_review_fixes.py @@ -619,9 +619,10 @@ async def test_new_memory_database_is_not_scanned_at_registration(): state = memory._watch_state assert state.scan_future is None assert state in watcher._pending - # Fill it from a connection of its own, as the plugin does (it uses - # VACUUM INTO, which newer SQLite versions refuse for an existing - # in-memory database, so a plain connection here) + # Fill it from a connection of its own, as the plugin does. (The plugin + # uses VACUUM INTO from a connection opened with uri=True; a plain + # connection is simpler and does not depend on whether the SQLite build + # treats URI file names as URIs without that flag) conn = sqlite3.connect("file:review_fixes_copy?mode=memory&cache=shared", uri=True) conn.execute("create table copied (id integer)") conn.commit()