remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-06-04 16:16:59 +02:00
Code Issues Projects Releases Packages Wiki Activity

datasette.utils.StartupError() now becomes a click exception, closes #2624

Browse source
This commit is contained in:
Simon Willison 2026-01-06 07:58:18 -08:00
commit 757ce92baf
3 changed files with 39 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

26
tests/test_cli.py
View file

@ -304,6 +304,32 @@ def test_plugin_s_overwrite():
)
def test_startup_error_from_plugin_is_click_exception(tmp_path):
plugins_dir = tmp_path / "plugins"
plugins_dir.mkdir()
(plugins_dir / "startup_error.py").write_text(
"from datasette import hookimpl\n"
"from datasette.utils import StartupError\n"
"\n"
"@hookimpl\n"
"def startup(datasette):\n"
' raise StartupError("boom")\n',
"utf-8",
)
runner = CliRunner()
result = runner.invoke(
cli,
[
"--plugins-dir",
str(plugins_dir),
"--get",
"/",
],
)
assert result.exit_code == 1
assert "Error: boom" in result.output
def test_setting_type_validation():
runner = CliRunner()
result = runner.invoke(cli, ["--setting", "default_page_size", "dog"])