remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-07-09 17:14:35 +02:00
Code Issues Projects Releases Packages Wiki Activity

Allow declared column type case to vary

Browse source
This commit is contained in:
Simon Willison 2026-07-03 17:12:26 -07:00
commit 81d6ee69cd
2 changed files with 50 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

32
tests/test_api.py
View file

@ -446,8 +446,10 @@ async def test_row_extras(ds_client):
"format": "json",
}
assert len(data["foreign_key_tables"]) == 5
assert data["column_details"]["id"] == {
"type": "INTEGER",
id_detail = data["column_details"]["id"]
assert id_detail["type"].lower() == "integer"
assert id_detail == {
"type": id_detail["type"],
"sqlite_type": "INTEGER",
"notnull": False,
"default": None,
@ -455,8 +457,10 @@ async def test_row_extras(ds_client):
"pk_position": 1,
"hidden": 0,
}
assert data["column_details"]["content"] == {
"type": "TEXT",
content_detail = data["column_details"]["content"]
assert content_detail["type"].lower() == "text"
assert content_detail == {
"type": content_detail["type"],
"sqlite_type": "TEXT",
"notnull": False,
"default": None,
@ -470,16 +474,16 @@ async def test_row_extras(ds_client):
async def test_column_details_extra_row_for_null_blob(ds_client):
response = await ds_client.get("/fixtures/binary_data/3.json?_extra=column_details")
assert response.status_code == 200
assert response.json()["column_details"] == {
"data": {
"type": "BLOB",
"sqlite_type": "BLOB",
"notnull": False,
"default": None,
"is_pk": False,
"pk_position": 0,
"hidden": 0,
}
data_detail = response.json()["column_details"]["data"]
assert data_detail["type"].lower() == "blob"
assert data_detail == {
"type": data_detail["type"],
"sqlite_type": "BLOB",
"notnull": False,
"default": None,
"is_pk": False,
"pk_position": 0,
"hidden": 0,
}

61
tests/test_table_api.py
View file

@ -1342,41 +1342,44 @@ async def test_column_details_extra_table(ds_client):
"/fixtures/binary_data.json?_size=0&_extra=column_details"
)
assert response.status_code == 200
assert response.json()["column_details"] == {
"data": {
"type": "BLOB",
"sqlite_type": "BLOB",
"notnull": False,
"default": None,
"is_pk": False,
"pk_position": 0,
"hidden": 0,
}
data_detail = response.json()["column_details"]["data"]
assert data_detail["type"].lower() == "blob"
assert data_detail == {
"type": data_detail["type"],
"sqlite_type": "BLOB",
"notnull": False,
"default": None,
"is_pk": False,
"pk_position": 0,
"hidden": 0,
}
response = await ds_client.get(
"/fixtures/simple_primary_key.json?_size=0&_extra=column_details"
)
assert response.status_code == 200
assert response.json()["column_details"] == {
"id": {
"type": "INTEGER",
"sqlite_type": "INTEGER",
"notnull": False,
"default": None,
"is_pk": True,
"pk_position": 1,
"hidden": 0,
},
"content": {
"type": "TEXT",
"sqlite_type": "TEXT",
"notnull": False,
"default": None,
"is_pk": False,
"pk_position": 0,
"hidden": 0,
},
column_details = response.json()["column_details"]
id_detail = column_details["id"]
assert id_detail["type"].lower() == "integer"
assert id_detail == {
"type": id_detail["type"],
"sqlite_type": "INTEGER",
"notnull": False,
"default": None,
"is_pk": True,
"pk_position": 1,
"hidden": 0,
}
content_detail = column_details["content"]
assert content_detail["type"].lower() == "text"
assert content_detail == {
"type": content_detail["type"],
"sqlite_type": "TEXT",
"notnull": False,
"default": None,
"is_pk": False,
"pk_position": 0,
"hidden": 0,
}
response = await ds_client.get(