remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-10-07 18:06:59 +02:00
Code Issues Projects Releases Packages Wiki Activity

TableContext - table page now renders a documented Context dataclass

Browse source 
The table HTML view constructs a TableContext instead of an ad-hoc
dict, matching how the database and query pages already work. Fields
resolved by registered extras are declared with extra_field() so their
documentation lives on the Extra classes in table_extras.py; fields
added by the view code carry help metadata next to the view.

render_template() now converts Context dataclasses shallowly instead
of via dataclasses.asdict(), which deep-copied every value and would
fail on values like sqlite3.Row.

Keys not declared on TableContext - extras requested with ?_extra= on
the HTML page, or extra filter context from filters_from_request
plugins - are now dropped from the HTML template context rather than
passed through undocumented.

Refs #2127

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Simon Willison 2026-06-11 06:57:51 -07:00
commit 8b89a3aca8
4 changed files with 172 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/test_template_context.py
View file

@ -178,6 +178,14 @@ async def test_template_context_matches_documented_contract(
)
def test_table_context_fields_match_documented_contract():
from datasette.views.table import TableContext
assert {f.name for f in TableContext.documented_fields()} == {
key.name for key in PAGES["table"].documented_keys()
}
def test_base_context_keys_all_have_docs():
for key in BASE_CONTEXT_KEYS:
assert key.doc, "Base context key {} is missing docs".format(key.name)