From a1b6a6976d0ddafba6b927ce9fb83e62cb9091c3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 22:55:28 -0700
Subject: [PATCH] Remove dead weight from the extras machinery

- TableExtraContext.next_value, RowExtraContext.resolved and
  QueryExtraContext.stored_query/stored_query_write/error had no
  readers - drop the fields and the arguments that populated them
- Extra.documentation() and the stable classvar were unused parallel
  descriptions of what the docs generator reads directly
- ExtraRegistry.resolve no longer carries an always-true membership
  guard (resolve_multi returns every requested registered name)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/extras.py             | 19 +------------------
 datasette/views/database.py     |  3 ---
 datasette/views/row.py          |  1 -
 datasette/views/table.py        |  1 -
 datasette/views/table_extras.py |  5 -----
 5 files changed, 1 insertion(+), 28 deletions(-)

diff --git a/datasette/extras.py b/datasette/extras.py
index d5847937..4aa93057 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -50,7 +50,6 @@ class Extra(Provider):
     example: ClassVar[ExtraExample | None] = None
     examples: ClassVar[dict[ExtraScope, ExtraExample | list[ExtraExample]]] = {}
     public: ClassVar[bool] = True
-    stable: ClassVar[bool] = True
     expensive: ClassVar[bool] = False
     docs_note: ClassVar[str | None] = None
 
@@ -58,20 +57,6 @@ class Extra(Provider):
     def example_for_scope(cls, scope):
         return cls.examples.get(scope, cls.example)
 
-    @classmethod
-    def documentation(cls):
-        return {
-            "name": cls.key(),
-            "description": cls.description,
-            "scopes": [
-                scope.value for scope in sorted(cls.scopes, key=lambda s: s.value)
-            ],
-            "stable": cls.stable,
-            "expensive": cls.expensive,
-            "docs_note": cls.docs_note,
-            "example": cls.example,
-        }
-
 
 class ExtraRegistry:
     def __init__(self, classes):
@@ -106,9 +91,7 @@ class ExtraRegistry:
         }
         requested_names = [name for name in requested if name in allowed_names]
         resolved = await registry.resolve_multi(requested_names)
-        return {
-            name: resolved[name] for name in requested_names if name in resolved
-        }
+        return {name: resolved[name] for name in requested_names}
 
 
 def _camel_to_snake(name):
diff --git a/datasette/views/database.py b/datasette/views/database.py
index ad3fb843..46e26496 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -733,9 +733,6 @@ class QueryView(View):
                     sql=sql,
                     params=named_parameter_values,
                     query_name=stored_query.name if stored_query else None,
-                    stored_query=stored_query,
-                    stored_query_write=stored_query_write,
-                    error=query_error,
                     metadata=await query_metadata(),
                     extras=extras,
                     extra_registry=table_extra_registry,
diff --git a/datasette/views/row.py b/datasette/views/row.py
index e15dfce9..c300758b 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -172,7 +172,6 @@ class RowView(DataView):
         row_extra_context = RowExtraContext(
             datasette=self.ds,
             request=request,
-            resolved=resolved,
             db=db,
             database_name=database,
             table_name=table,
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 3cf8e6c6..65388c9c 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1497,7 +1497,6 @@ async def table_view_data(
         nofacet=nofacet,
         nosuggest=nosuggest,
         next_arg=request.args.get("_next"),
-        next_value=next_value,
         next_url=next_url,
         sql=sql,
         sql_no_order_no_limit=sql_no_order_no_limit,
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index c98ae22c..493135f3 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -37,7 +37,6 @@ class TableExtraContext:
     nofacet: object
     nosuggest: object
     next_arg: object
-    next_value: object
     next_url: str | None
     sql: str
     sql_no_order_no_limit: str
@@ -60,7 +59,6 @@ class TableExtraContext:
 class RowExtraContext:
     datasette: object
     request: object
-    resolved: object
     db: object
     database_name: str
     table_name: str
@@ -90,9 +88,6 @@ class QueryExtraContext:
     sql: str | None
     params: dict
     query_name: str | None
-    stored_query: object
-    stored_query_write: bool
-    error: str | None
     metadata: dict
     extras: set
     extra_registry: ExtraRegistry