mirror of
https://github.com/simonw/datasette.git
synced 2026-09-02 22:54:08 +02:00
Remove references to untracked local plans/ and todos/ directories
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012U7coQfVu8nK2R4q2mCULA
This commit is contained in:
parent
c910b8849a
commit
b276bc3aa2
5 changed files with 5 additions and 11 deletions
|
|
@ -2890,8 +2890,7 @@ class Datasette:
|
|||
``_suppress_background_tasks`` is set (the ``--get`` CLI path: its
|
||||
one-shot TestClient request flows through the full ASGI stack,
|
||||
including the first-request fallback, but must never launch
|
||||
long-lived background work per decision #3 in
|
||||
``plans/first-request/04-core-plan.md``).
|
||||
long-lived background work).
|
||||
"""
|
||||
if self._suppress_background_tasks:
|
||||
return
|
||||
|
|
|
|||
|
|
@ -22,9 +22,6 @@ consumer, a scheduled job runner) register it with
|
|||
- **cancellation**: :meth:`BackgroundTaskSupervisor.cancel_all` cancels
|
||||
every task still running and waits (with a grace period) for them to
|
||||
actually stop.
|
||||
|
||||
See ``plans/first-request/04-core-plan.md`` (decisions #2-#5) for the
|
||||
design rationale.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
|
|
|||
|
|
@ -678,8 +678,7 @@ def serve(
|
|||
except StartupError as e:
|
||||
raise click.ClickException(e.args[0])
|
||||
|
||||
# --get never launches background tasks (decision #3 in
|
||||
# plans/first-request/04-core-plan.md): TestClient's request below
|
||||
# --get never launches background tasks: TestClient's request below
|
||||
# flows through the full ASGI stack, including the
|
||||
# AsgiRunOnFirstRequest fallback, which would otherwise launch them.
|
||||
ds._suppress_background_tasks = True
|
||||
|
|
|
|||
|
|
@ -1,8 +1,7 @@
|
|||
"""
|
||||
Tests for datasette.add_background_task() / start_background_tasks() and the
|
||||
BackgroundTask / BackgroundTaskSupervisor machinery in
|
||||
datasette/background_tasks.py, per plans/first-request/04-core-plan.md
|
||||
(decisions #2-#5) and todos/first-request/03-background-tasks-api.md.
|
||||
datasette/background_tasks.py.
|
||||
"""
|
||||
|
||||
import asyncio
|
||||
|
|
|
|||
|
|
@ -53,8 +53,8 @@ def test_serve_with_get(tmp_path_factory):
|
|||
|
||||
|
||||
def test_serve_with_get_does_not_launch_background_tasks(tmp_path_factory):
|
||||
# Per decision #3 in plans/first-request/04-core-plan.md, --get must
|
||||
# never launch background tasks, even though its TestClient request
|
||||
# --get must never launch background tasks, even though its TestClient
|
||||
# request
|
||||
# flows through the full ASGI stack (including the AsgiRunOnFirstRequest
|
||||
# fallback that would otherwise launch them). The plugin's startup hook
|
||||
# itself still runs (registration happens) - only the launch is
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue