remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-09-04 07:34:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove references to untracked local plans/ and todos/ directories

Browse source 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012U7coQfVu8nK2R4q2mCULA
This commit is contained in:
Alex Garcia 2026-08-31 13:03:56 -07:00 • committed by Simon Willison
commit b8341fbcc3
2 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
datasette/app.py
View file

@ -2910,10 +2910,9 @@ class Datasette:
plugin's cleanup, or skip task cancellation / ``close()``
altogether.
Order matters (decision #6, ``plans/first-request/04-core-plan.md``):
hooks run first, while background tasks are still alive, so a
plugin can coordinate with its own task (e.g. tell a queue
consumer to stop pulling new work) before that task gets
Order matters: hooks run first, while background tasks are still
alive, so a plugin can coordinate with its own task (e.g. tell a
queue consumer to stop pulling new work) before that task gets
cancelled; ``close()`` runs last so both the hooks and the
cancelled tasks still have working database connections to write
any final state.

4
tests/test_shutdown.py
View file

@ -1,7 +1,5 @@
"""
Tests for the shutdown(datasette) plugin hook and Datasette.invoke_shutdown(),
per plans/first-request/04-core-plan.md (decision #6) and
todos/first-request/04-shutdown-hook.md.
Tests for the shutdown(datasette) plugin hook and Datasette.invoke_shutdown().
Order under test: plugin `shutdown` hooks run first (while background tasks
are still alive) -> supervised background tasks are cancelled and drained