remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-06-05 16:46:57 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove source and source_key columns from JumpSQL

Browse source 
Refs https://github.com/simonw/datasette/pull/2732#issuecomment-4527290391
This commit is contained in:
Simon Willison 2026-05-23 20:41:32 -07:00
commit cef6aa85b6
6 changed files with 9 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/test_jump.py
View file

@ -147,8 +147,6 @@ async def test_jump_sql_menu_item_helper(ds_for_jump):
label="Plugin dashboard",
url="/-/plugin-dashboard",
description="Plugin tool",
source="test-plugin",
sort_key=70,
search_text="dashboard plugin",
display_name="Plugin Dashboard",
item_type="plugin",
@ -162,8 +160,6 @@ async def test_jump_sql_menu_item_helper(ds_for_jump):
"description": "Plugin tool",
"url": "/-/plugin-dashboard",
"search_text": "dashboard plugin",
"sort_key": 70,
"source": "test-plugin",
"display_name": "Plugin Dashboard",
}
@ -200,7 +196,7 @@ async def test_debug_menu_items_are_in_jump_for_debug_menu_permission():
}
assert all(descriptions_by_name.values())
assert descriptions_by_name["Databases"] == (
"List of databases known to this Datasette instance"
"List of databases known to this Datasette instance."
)
@ -228,8 +224,6 @@ async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
'Plugin supplied item' AS description,
'/-/plugin-dashboard' AS url,
'plugin dashboard ' || :actor_id AS search_text,
80 AS sort_key,
'test-plugin' AS source,
'Plugin dashboard for ' || :actor_id AS display_name
""",
params={"actor_id": actor["id"] if actor else "anonymous"},
@ -275,8 +269,6 @@ async def test_jump_resolves_url_descriptors_from_sql(ds_for_jump):
'table', 'comments'
) AS url,
'table descriptor comments' AS search_text,
80 AS sort_key,
'test-plugin' AS source,
NULL AS display_name
""")