remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-06-03 07:37:00 +02:00
Code Issues Projects Releases Packages Wiki Activity

Major redesign of create saved query UI

Browse source 
https://github.com/simonw/datasette/pull/2741#issuecomment-4548707129
This commit is contained in:
Simon Willison 2026-05-26 13:48:40 -07:00
commit eb7c25c57c
9 changed files with 705 additions and 172 deletions
Download patch file Download diff file Expand all files Collapse all files

17
datasette/templates/_sql_parameter_scripts.html
View file

@ -215,9 +215,10 @@ window.datasetteSqlParameters = (() => {
if (!form) {
return null;
}
const shouldRenderParameters = options.renderParameters !== false;
const section =
options.section || form.querySelector("[data-sql-parameters-section]");
if (!section) {
if (shouldRenderParameters && !section) {
return null;
}
const manager = {
@ -225,12 +226,16 @@ window.datasetteSqlParameters = (() => {
section,
allowExpand:
options.allowExpand === undefined
? section.dataset.allowExpand === "1"
? section
? section.dataset.allowExpand === "1"
: false
: options.allowExpand,
parameterState: new Map(),
};
bindParameterControls(manager);
syncParameterState(manager);
if (section) {
bindParameterControls(manager);
syncParameterState(manager);
}
const url = options.url || form.dataset.parametersUrl;
let refreshTimer = null;
@ -254,7 +259,9 @@ window.datasetteSqlParameters = (() => {
if (!response.ok) {
throw new Error((data.errors || [response.statusText]).join("; "));
}
renderParameters(manager, data.parameters || []);
if (shouldRenderParameters) {
renderParameters(manager, data.parameters || []);
}
if (options.onData) {
options.onData(data, manager);
}