remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-06-11 11:36:58 +02:00
Code Issues Projects Releases Packages Wiki Activity

Tweak URL designs of new endpoints

Browse source
This commit is contained in:
Simon Willison 2026-05-25 14:05:26 -07:00
commit f1dd86ebfb
9 changed files with 25 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/test_html.py
View file

@ -329,7 +329,7 @@ async def test_query_parameter_form_fields(ds_client):
'<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="" data-parameter-control>'
in response.text
)
assert 'data-parameters-url="/fixtures/-/query/-/parameters"' in response.text
assert 'data-parameters-url="/fixtures/-/query/parameters"' in response.text
assert 'id="sql-parameters-section"' in response.text
assert "setupSqlParameterRefresh" in response.text
response2 = await ds_client.get("/fixtures/-/query?sql=select+:name&name=hello")
@ -344,7 +344,7 @@ async def test_query_parameter_form_fields(ds_client):
async def test_database_page_sql_parameter_refresh_markup(ds_client):
response = await ds_client.get("/fixtures")
assert response.status_code == 200
assert 'data-parameters-url="/fixtures/-/query/-/parameters"' in response.text
assert 'data-parameters-url="/fixtures/-/query/parameters"' in response.text
assert 'id="sql-parameters-section"' in response.text
assert "setupSqlParameterRefresh" in response.text

22
tests/test_queries.py
View file

@ -356,7 +356,7 @@ async def test_query_insert_api_creates_read_only_query():
await ds.invoke_startup()
response = await ds.client.post(
"/data/-/queries/-/insert",
"/data/-/queries/insert",
actor={"id": "root"},
json={
"query": {
@ -568,7 +568,7 @@ async def test_query_insert_api_publish_requires_publish_query():
await ds.invoke_startup()
response = await ds.client.post(
"/data/-/queries/-/insert",
"/data/-/queries/insert",
actor={"id": "writer"},
json={"query": {"name": "public", "sql": "select 1", "is_published": True}},
)
@ -586,7 +586,7 @@ async def test_query_insert_api_creates_writable_query():
await ds.invoke_startup()
response = await ds.client.post(
"/data/-/queries/-/insert",
"/data/-/queries/insert",
actor={"id": "root"},
json={
"query": {
@ -603,7 +603,7 @@ async def test_query_insert_api_creates_writable_query():
assert query["parameters"] == ["name"]
bad_response = await ds.client.post(
"/data/-/queries/-/insert",
"/data/-/queries/insert",
actor={"id": "root"},
json={
"query": {
@ -671,7 +671,7 @@ async def test_query_insert_api_rejects_magic_parameters():
await ds.invoke_startup()
response = await ds.client.post(
"/data/-/queries/-/insert",
"/data/-/queries/insert",
actor={"id": "root"},
json={"query": {"name": "magic", "sql": "select :_actor_id"}},
)
@ -742,7 +742,7 @@ async def test_execute_write_get_prepopulates_without_executing():
assert 'data-sql-template="insert"' in response.text
assert 'data-sql-template="update"' in response.text
assert 'data-sql-template="delete"' in response.text
assert 'data-analyze-url="/data/-/execute-write/-/analyze"' in response.text
assert 'data-analyze-url="/data/-/execute-write/analyze"' in response.text
assert 'addEventListener("paste"' in response.text
assert "setupSqlParameterRefresh" in response.text
assert '<table class="execute-write-analysis">' in response.text
@ -771,12 +771,12 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
await ds.invoke_startup()
response = await ds.client.get(
"/data/-/execute-write/-/analyze",
"/data/-/execute-write/analyze",
actor={"id": "root"},
params={"sql": "insert into dogs (name) values (:name)"},
)
read_only_response = await ds.client.get(
"/data/-/execute-write/-/analyze",
"/data/-/execute-write/analyze",
actor={"id": "root"},
params={"sql": "select * from dogs where name = :name"},
)
@ -818,19 +818,19 @@ async def test_query_parameters_endpoint_uses_get_sql_only():
await ds.invoke_startup()
response = await ds.client.get(
"/data/-/query/-/parameters",
"/data/-/query/parameters",
actor={"id": "root"},
params={
"sql": "select * from dogs where name = :name and id = :id",
},
)
permission_denied_response = await ds.client.get(
"/data/-/query/-/parameters",
"/data/-/query/parameters",
actor={"id": "not-root"},
params={"sql": "select * from dogs where name = :name"},
)
magic_parameter_response = await ds.client.get(
"/data/-/query/-/parameters",
"/data/-/query/parameters",
actor={"id": "root"},
params={"sql": "select :_actor_id"},
)