remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-06-01 06:37:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

Better empty state message

Browse source 
Root user was being told they didn't have permission when actually
the problem was there were no tables at all.
This commit is contained in:
Simon Willison 2026-05-31 13:49:22 -07:00
commit f9f3465582
2 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
datasette/templates/execute_write.html
View file

@ -111,7 +111,7 @@ form.sql.core input[data-execute-write-submit]:disabled {
</details>
</div>
{% else %}
<p class="message-warning execute-write-template-unavailable">You don't currently have permission to insert, edit or delete from any tables.</p>
<p class="message-warning execute-write-template-unavailable">There are no tables that you can currently edit.</p>
{% endif %}
<p class="sql-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>

5
tests/test_queries.py
View file

@ -1580,10 +1580,7 @@ async def test_execute_write_templates_are_filtered_by_permission_and_server_gen
assert viewer_response.status_code == 200
assert "<summary>Start with a template</summary>" not in viewer_response.text
assert (
"You don't currently have permission to insert, edit or delete from any tables."
in viewer_response.text
)
assert "There are no tables that you can currently edit." in viewer_response.text
assert "data-template-insert-sql" not in viewer_response.text
assert "data-template-update-sql" not in viewer_response.text
assert "data-template-delete-sql" not in viewer_response.text