From 2e014cda806c128fe4b09538d38369f55b827a68 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Wed, 6 May 2026 01:03:01 +0000
Subject: [PATCH 001/386] Warn once when writing to temporary internal database

The internal database defaults to a temporary file that is deleted on
shutdown. Plugin writes that expect persistence currently vanish silently.

Detect such writes via an `internal_ephemeral_writes()` context manager
in `datasette.database`: Datasette wraps `_refresh_schemas` (its own
catalog/metadata writes) with the marker, and `Database.execute_write_fn`
prints a one-time stderr warning when a write hits a `is_temp_disk`
database without the marker set. The warning recommends restarting with
`--internal path/to/file.db` for persistence.
---
 datasette/app.py                  | 76 ++++++++++++++--------------
 datasette/database.py             | 32 ++++++++++++
 docs/internals.rst                |  2 +
 tests/test_internal_db_warning.py | 83 +++++++++++++++++++++++++++++++
 4 files changed, 156 insertions(+), 37 deletions(-)
 create mode 100644 tests/test_internal_db_warning.py

diff --git a/datasette/app.py b/datasette/app.py
index 358081ef..dcbfa2ad 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -73,7 +73,7 @@ from .views.table import (
 from .views.row import RowView, RowDeleteView, RowUpdateView
 from .renderer import json_renderer
 from .url_builder import Urls
-from .database import Database, QueryInterrupted
+from .database import Database, QueryInterrupted, internal_ephemeral_writes
 
 from .utils import (
     PaginatedResources,
@@ -380,6 +380,7 @@ class Datasette:
             )
 
         self.internal_db_created = False
+        self._warned_internal_temp_write = False
         if internal is None:
             self._internal_database = Database(self, is_temp_disk=True)
         else:
@@ -604,43 +605,44 @@ class Datasette:
 
     async def _refresh_schemas(self):
         internal_db = self.get_internal_database()
-        if not self.internal_db_created:
-            await init_internal_db(internal_db)
-            await self.apply_metadata_json()
-            self.internal_db_created = True
-        current_schema_versions = {
-            row["database_name"]: row["schema_version"]
-            for row in await internal_db.execute(
-                "select database_name, schema_version from catalog_databases"
+        with internal_ephemeral_writes():
+            if not self.internal_db_created:
+                await init_internal_db(internal_db)
+                await self.apply_metadata_json()
+                self.internal_db_created = True
+            current_schema_versions = {
+                row["database_name"]: row["schema_version"]
+                for row in await internal_db.execute(
+                    "select database_name, schema_version from catalog_databases"
+                )
+            }
+            # Delete stale entries for databases that are no longer attached
+            stale_databases = set(current_schema_versions.keys()) - set(
+                self.databases.keys()
             )
-        }
-        # Delete stale entries for databases that are no longer attached
-        stale_databases = set(current_schema_versions.keys()) - set(
-            self.databases.keys()
-        )
-        for stale_db_name in stale_databases:
-            await internal_db.execute_write(
-                "DELETE FROM catalog_databases WHERE database_name = ?",
-                [stale_db_name],
-            )
-        for database_name, db in self.databases.items():
-            schema_version = (await db.execute("PRAGMA schema_version")).first()[0]
-            # Compare schema versions to see if we should skip it
-            if schema_version == current_schema_versions.get(database_name):
-                continue
-            placeholders = "(?, ?, ?, ?)"
-            values = [database_name, str(db.path), db.is_memory, schema_version]
-            if db.path is None:
-                placeholders = "(?, null, ?, ?)"
-                values = [database_name, db.is_memory, schema_version]
-            await internal_db.execute_write(
-                """
-                INSERT OR REPLACE INTO catalog_databases (database_name, path, is_memory, schema_version)
-                VALUES {}
-            """.format(placeholders),
-                values,
-            )
-            await populate_schema_tables(internal_db, db)
+            for stale_db_name in stale_databases:
+                await internal_db.execute_write(
+                    "DELETE FROM catalog_databases WHERE database_name = ?",
+                    [stale_db_name],
+                )
+            for database_name, db in self.databases.items():
+                schema_version = (await db.execute("PRAGMA schema_version")).first()[0]
+                # Compare schema versions to see if we should skip it
+                if schema_version == current_schema_versions.get(database_name):
+                    continue
+                placeholders = "(?, ?, ?, ?)"
+                values = [database_name, str(db.path), db.is_memory, schema_version]
+                if db.path is None:
+                    placeholders = "(?, null, ?, ?)"
+                    values = [database_name, db.is_memory, schema_version]
+                await internal_db.execute_write(
+                    """
+                    INSERT OR REPLACE INTO catalog_databases (database_name, path, is_memory, schema_version)
+                    VALUES {}
+                """.format(placeholders),
+                    values,
+                )
+                await populate_schema_tables(internal_db, db)
 
     @property
     def urls(self):
diff --git a/datasette/database.py b/datasette/database.py
index e3c4bfec..3f13198d 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -1,6 +1,8 @@
 import asyncio
 import atexit
 from collections import namedtuple
+import contextlib
+import contextvars
 import inspect
 import os
 from pathlib import Path
@@ -13,6 +15,24 @@ import threading
 import uuid
 
 from .tracer import trace
+
+
+_internal_ephemeral_write = contextvars.ContextVar(
+    "datasette_internal_ephemeral_write", default=False
+)
+
+
+@contextlib.contextmanager
+def internal_ephemeral_writes():
+    """Mark internal-database writes inside this block as ephemeral catalog
+    writes that Datasette recreates on startup. Suppresses the temp-internal-DB
+    warning for the duration of the block. Plugins should NOT use this — their
+    writes are exactly what the warning is meant to catch."""
+    token = _internal_ephemeral_write.set(True)
+    try:
+        yield
+    finally:
+        _internal_ephemeral_write.reset(token)
 from .utils import (
     call_with_supported_arguments,
     detect_fts,
@@ -289,6 +309,18 @@ class Database:
 
     async def execute_write_fn(self, fn, block=True, transaction=True, request=None):
         self._check_not_closed()
+        if (
+            self.is_temp_disk
+            and not self.ds._warned_internal_temp_write
+            and not _internal_ephemeral_write.get()
+        ):
+            self.ds._warned_internal_temp_write = True
+            print(
+                "Datasette warning: write to the internal database, which is a "
+                "temporary file that will be deleted on shutdown. If this data "
+                "should persist, restart Datasette with --internal path/to/file.db",
+                file=sys.stderr,
+            )
         pending_events = []
 
         def track_event(event):
diff --git a/docs/internals.rst b/docs/internals.rst
index e0123a7b..fa2b2345 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -2037,6 +2037,8 @@ Plugin authors are asked to practice good etiquette when using the internal data
 3. Use temporary tables or shared in-memory attached databases when possible.
 4. Avoid implementing features that could expose private data stored in the internal database by other plugins.
 
+If a plugin writes to the default temporary internal database, Datasette prints a one-time warning to standard error noting that the data will be lost on shutdown and recommending the ``--internal path/to/file.db`` flag for persistence. Datasette suppresses this warning for its own catalog and metadata writes, which are recreated on every startup.
+
 .. _internals_internal_schema:
 
 Internal database schema
diff --git a/tests/test_internal_db_warning.py b/tests/test_internal_db_warning.py
new file mode 100644
index 00000000..23365ae8
--- /dev/null
+++ b/tests/test_internal_db_warning.py
@@ -0,0 +1,83 @@
+import pytest
+
+from datasette.app import Datasette
+
+
+@pytest.mark.asyncio
+async def test_no_warning_during_startup(tmp_path, capfd):
+    """Catalog/metadata writes during _refresh_schemas must not warn."""
+    data_db = tmp_path / "data.db"
+    import sqlite3
+
+    conn = sqlite3.connect(str(data_db))
+    conn.execute("CREATE TABLE t (id INTEGER PRIMARY KEY)")
+    conn.close()
+
+    ds = Datasette(files=[str(data_db)])
+    await ds.invoke_startup()
+    # Trigger the schema refresh / index hit so all catalog writes happen.
+    response = await ds.client.get("/")
+    assert response.status_code == 200
+
+    captured = capfd.readouterr()
+    assert "internal database" not in captured.err
+    assert ds._warned_internal_temp_write is False
+
+
+@pytest.mark.asyncio
+async def test_warning_fires_once_on_plugin_style_write(tmp_path, capfd):
+    """A write to the temp internal DB outside the ephemeral context must
+    print the warning to stderr exactly once."""
+    data_db = tmp_path / "data.db"
+    import sqlite3
+
+    conn = sqlite3.connect(str(data_db))
+    conn.execute("CREATE TABLE t (id INTEGER PRIMARY KEY)")
+    conn.close()
+
+    ds = Datasette(files=[str(data_db)])
+    await ds.invoke_startup()
+    await ds.client.get("/")
+    capfd.readouterr()  # discard startup output
+
+    internal_db = ds.get_internal_database()
+    await internal_db.execute_write(
+        "CREATE TABLE IF NOT EXISTS plugin_table (k TEXT)"
+    )
+    first = capfd.readouterr()
+    assert "internal database" in first.err
+    assert "--internal" in first.err
+    assert ds._warned_internal_temp_write is True
+
+    # A second plugin write must not warn again.
+    await internal_db.execute_write(
+        "INSERT INTO plugin_table (k) VALUES (?)", ["v"]
+    )
+    second = capfd.readouterr()
+    assert second.err == ""
+
+
+@pytest.mark.asyncio
+async def test_no_warning_with_persistent_internal(tmp_path, capfd):
+    """When --internal is given, is_temp_disk is False so no warning fires."""
+    data_db = tmp_path / "data.db"
+    import sqlite3
+
+    conn = sqlite3.connect(str(data_db))
+    conn.execute("CREATE TABLE t (id INTEGER PRIMARY KEY)")
+    conn.close()
+
+    ds = Datasette(
+        files=[str(data_db)],
+        internal=str(tmp_path / "internal.db"),
+    )
+    await ds.invoke_startup()
+    await ds.client.get("/")
+
+    internal_db = ds.get_internal_database()
+    await internal_db.execute_write(
+        "CREATE TABLE IF NOT EXISTS plugin_table (k TEXT)"
+    )
+    captured = capfd.readouterr()
+    assert "internal database" not in captured.err
+    assert ds._warned_internal_temp_write is False

From 345f910043bebd4fb829c1f8c248a17e38856191 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 12 May 2026 16:31:36 -0700
Subject: [PATCH 002/386] Fix for Database.close()/Datasette.close() order
 (#2710)

Closes:
- #2709

The key behavior change: after close() starts, no new execute work can be submitted, but already-running execute work is allowed to finish before SQLite connections are closed.
---
 datasette/database.py             | 26 +++++++++++++---
 datasette/version.py              |  2 +-
 tests/test_internals_datasette.py | 49 +++++++++++++++++++++++++++++++
 3 files changed, 72 insertions(+), 5 deletions(-)

diff --git a/datasette/database.py b/datasette/database.py
index e3c4bfec..657adfa5 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -84,6 +84,8 @@ class Database:
         self._write_thread = None
         self._write_queue = None
         self._closed = False
+        self._pending_execute_futures = set()
+        self._pending_execute_futures_lock = threading.Lock()
         # These are used when in non-threaded mode:
         self._read_connection = None
         self._write_connection = None
@@ -98,6 +100,10 @@ class Database:
                 "Database {!r} has been closed".format(self.name)
             )
 
+    def _remove_pending_execute_future(self, future):
+        with self._pending_execute_futures_lock:
+            self._pending_execute_futures.discard(future)
+
     @property
     def cached_table_counts(self):
         if self._cached_table_counts is not None:
@@ -170,7 +176,11 @@ class Database:
         """
         if self._closed:
             return
-        self._closed = True
+        with self._pending_execute_futures_lock:
+            if self._closed:
+                return
+            self._closed = True
+            pending_execute_futures = tuple(self._pending_execute_futures)
         # Shut down the write thread, if any, via a sentinel. The thread
         # drains any writes already queued before the sentinel and then
         # closes its own write connection and returns.
@@ -185,6 +195,11 @@ class Database:
                     )
                 )
                 sys.stderr.flush()
+        for future in pending_execute_futures:
+            try:
+                future.result()
+            except Exception:
+                pass
         # Close anything still tracked in _all_file_connections
         for connection in self._all_file_connections:
             try:
@@ -456,9 +471,12 @@ class Database:
                 setattr(connections, self._thread_local_id, conn)
             return fn(conn)
 
-        return await asyncio.get_event_loop().run_in_executor(
-            self.ds.executor, in_thread
-        )
+        with self._pending_execute_futures_lock:
+            self._check_not_closed()
+            future = self.ds.executor.submit(in_thread)
+            self._pending_execute_futures.add(future)
+        future.add_done_callback(self._remove_pending_execute_future)
+        return await asyncio.wrap_future(future)
 
     async def execute(
         self,
diff --git a/datasette/version.py b/datasette/version.py
index cf908bb2..898d388c 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a28"
+__version__ = "1.0a28.post1"
 __version_info__ = tuple(__version__.split("."))
diff --git a/tests/test_internals_datasette.py b/tests/test_internals_datasette.py
index d58c9a29..3f867eb0 100644
--- a/tests/test_internals_datasette.py
+++ b/tests/test_internals_datasette.py
@@ -2,8 +2,11 @@
 Tests for the datasette.app.Datasette class
 """
 
+import asyncio
 import dataclasses
 import os
+import sqlite3
+import time
 from datasette import Context
 from datasette.app import Datasette, Database, ResourcesSQL
 from datasette.database import DatasetteClosedError
@@ -256,6 +259,52 @@ async def test_datasette_close_raises_on_use():
         await ds.get_internal_database().execute("select 1")
 
 
+async def _datasette_with_sleeping_execute(tmp_path, sleep_ms=200):
+    db_path = tmp_path / "data.db"
+    internal_path = tmp_path / "internal.db"
+    sqlite3.connect(db_path).close()
+    ds = Datasette([str(db_path)], internal=str(internal_path))
+    loop = asyncio.get_running_loop()
+    sql_started = asyncio.Event()
+    original_prepare_connection = ds._prepare_connection
+
+    def prepare_connection(conn, name):
+        original_prepare_connection(conn, name)
+
+        def sleep_ms(ms):
+            loop.call_soon_threadsafe(sql_started.set)
+            time.sleep(ms / 1000)
+            return ms
+
+        conn.create_function("sleep_ms", 1, sleep_ms)
+
+    ds._prepare_connection = prepare_connection
+    task = asyncio.create_task(
+        ds.get_database().execute(
+            f"select sleep_ms({sleep_ms})", custom_time_limit=1000
+        )
+    )
+    await asyncio.wait_for(sql_started.wait(), timeout=5)
+    return ds, task
+
+
+@pytest.mark.asyncio
+async def test_datasette_close_waits_for_in_flight_execute(tmp_path):
+    ds, task = await _datasette_with_sleeping_execute(tmp_path)
+    ds.close()
+    results = await task
+    assert [tuple(row) for row in results.rows] == [(200,)]
+
+
+@pytest.mark.asyncio
+async def test_datasette_close_waits_for_cancelled_in_flight_execute(tmp_path):
+    ds, task = await _datasette_with_sleeping_execute(tmp_path)
+    task.cancel()
+    with pytest.raises(asyncio.CancelledError):
+        await task
+    ds.close()
+
+
 @pytest.mark.asyncio
 async def test_asgi_lifespan_shutdown_closes_datasette():
     ds = Datasette(memory=True)

From db16003865dee862d63895dbc156461e8b89372b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 12 May 2026 16:39:06 -0700
Subject: [PATCH 003/386] Release 1.0a29

Refs #2695, #2701, #2708, #2709
---
 datasette/version.py |  2 +-
 docs/changelog.rst   | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/datasette/version.py b/datasette/version.py
index 898d388c..e661e76d 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a28.post1"
+__version__ = "1.0a29"
 __version_info__ = tuple(__version__.split("."))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 7c1da152..dd9273ca 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,6 +4,16 @@
 Changelog
 =========
 
+.. _v1_0_a29:
+
+1.0a29 (2026-05-12)
+-------------------
+
+- New ``TokenRestrictions.abbreviated(datasette)`` :ref:`utility method <TokenRestrictions>` for creating ``"_r"`` dictionaries. (:issue:`2695`)
+- Table headers and column options are now visible even if a table contains zero rows. (:issue:`2701`)
+- Fixed bug with display of column actions dialog on Mobile Safari. (:issue:`2708`)
+- Fixed bug where tests could crash with a segfault due to a race condition between ``Datasette.close()`` and ``Datasette.close()``. (:issue:`2709`)
+-
 .. _v1_0_a28:
 
 1.0a28 (2026-04-16)

From 036aa6aa2ef71350d5e99cd12620f9bcd70d7a19 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 12 May 2026 16:39:46 -0700
Subject: [PATCH 004/386] Removed a rogue hyphen

---
 docs/changelog.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index dd9273ca..4f26066c 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -13,7 +13,7 @@ Changelog
 - Table headers and column options are now visible even if a table contains zero rows. (:issue:`2701`)
 - Fixed bug with display of column actions dialog on Mobile Safari. (:issue:`2708`)
 - Fixed bug where tests could crash with a segfault due to a race condition between ``Datasette.close()`` and ``Datasette.close()``. (:issue:`2709`)
--
+
 .. _v1_0_a28:
 
 1.0a28 (2026-04-16)

From 46d90a0b887bfa23f986a28499eb5f85cd7eed04 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 12 May 2026 16:46:56 -0700
Subject: [PATCH 005/386] Bump to actions/checkout@v6

---
 .github/workflows/publish.yml | 8 ++++----
 .github/workflows/test.yml    | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 2e8cea9c..87300593 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -14,7 +14,7 @@ jobs:
       matrix:
         python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v6
       with:
@@ -35,7 +35,7 @@ jobs:
     permissions:
       id-token: write
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
@@ -56,7 +56,7 @@ jobs:
     needs: [deploy]
     if: "!github.event.release.prerelease"
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
@@ -92,7 +92,7 @@ jobs:
     needs: [deploy]
     if: "!github.event.release.prerelease"
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Build and push to Docker Hub
       env:
         DOCKER_USER: ${{ secrets.DOCKER_USER }}
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index a0f5477b..a1b2e9d2 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -12,7 +12,7 @@ jobs:
       matrix:
         python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v6
       with:

From 3110faa0bab8cdeb4e4e042e87fefa434f64162f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 16 May 2026 11:45:43 -0700
Subject: [PATCH 006/386] Replace Janus queue with asyncio.Future

Closes #1752

AI generated patch explanation: https://gisthost.github.io/?e2b8d9c7666e988b5c003ff5e5ef3098
---
 datasette/database.py            | 117 +++++++++++++++++++------------
 docs/changelog.rst               |   8 +++
 pyproject.toml                   |   1 -
 tests/test_internals_database.py |  34 +++++++++
 tests/test_write_wrapper.py      |  27 ++++++-
 5 files changed, 140 insertions(+), 47 deletions(-)

diff --git a/datasette/database.py b/datasette/database.py
index 657adfa5..66d50ffa 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -4,7 +4,6 @@ from collections import namedtuple
 import inspect
 import os
 from pathlib import Path
-import janus
 import queue
 import sqlite_utils
 import sys
@@ -330,13 +329,16 @@ class Database:
         else:
             # For non-blocking writes, spawn a background task to
             # dispatch events after the write thread completes
-            task_id, reply_queue = result
+            task_id, reply_future = result
 
             async def _dispatch_events_after_write():
-                write_result = await reply_queue.async_q.get()
-                if not isinstance(write_result, Exception):
-                    for event in pending_events:
-                        await self.ds.track_event(event)
+                try:
+                    await reply_future
+                except Exception:
+                    # if the write failed, don't emit success events
+                    return
+                for event in pending_events:
+                    await self.ds.track_event(event)
 
             asyncio.ensure_future(_dispatch_events_after_write())
             result = task_id
@@ -390,18 +392,15 @@ class Database:
             )
             self._write_thread.start()
         task_id = uuid.uuid5(uuid.NAMESPACE_DNS, "datasette.io")
-        reply_queue = janus.Queue()
+        loop = asyncio.get_running_loop()
+        reply_future = loop.create_future()
         self._write_queue.put(
-            WriteTask(fn, task_id, reply_queue, isolated_connection, transaction)
+            WriteTask(fn, task_id, loop, reply_future, isolated_connection, transaction)
         )
         if block:
-            result = await reply_queue.async_q.get()
-            if isinstance(result, Exception):
-                raise result
-            else:
-                return result
+            return await reply_future
         else:
-            return task_id, reply_queue
+            return task_id, reply_future
 
     def _execute_writes(self):
         # Infinite looping thread that protects the single write connection
@@ -422,36 +421,37 @@ class Database:
                     except Exception:
                         pass
                 return
+            exception = None
+            result = None
             if conn_exception is not None:
-                result = conn_exception
+                exception = conn_exception
+            elif task.isolated_connection:
+                isolated_connection = self.connect(write=True)
+                try:
+                    result = task.fn(isolated_connection)
+                except Exception as e:
+                    sys.stderr.write("{}\n".format(e))
+                    sys.stderr.flush()
+                    exception = e
+                finally:
+                    isolated_connection.close()
+                    try:
+                        self._all_file_connections.remove(isolated_connection)
+                    except ValueError:
+                        # Was probably a memory connection
+                        pass
             else:
-                if task.isolated_connection:
-                    isolated_connection = self.connect(write=True)
-                    try:
-                        result = task.fn(isolated_connection)
-                    except Exception as e:
-                        sys.stderr.write("{}\n".format(e))
-                        sys.stderr.flush()
-                        result = e
-                    finally:
-                        isolated_connection.close()
-                        try:
-                            self._all_file_connections.remove(isolated_connection)
-                        except ValueError:
-                            # Was probably a memory connection
-                            pass
-                else:
-                    try:
-                        if task.transaction:
-                            with conn:
-                                result = task.fn(conn)
-                        else:
+                try:
+                    if task.transaction:
+                        with conn:
                             result = task.fn(conn)
-                    except Exception as e:
-                        sys.stderr.write("{}\n".format(e))
-                        sys.stderr.flush()
-                        result = e
-            task.reply_queue.sync_q.put(result)
+                    else:
+                        result = task.fn(conn)
+                except Exception as e:
+                    sys.stderr.write("{}\n".format(e))
+                    sys.stderr.flush()
+                    exception = e
+            _deliver_write_result(task, result, exception)
 
     async def execute_fn(self, fn):
         self._check_not_closed()
@@ -892,16 +892,45 @@ def _apply_write_wrapper(fn, wrapper_factory, track_event):
 
 
 class WriteTask:
-    __slots__ = ("fn", "task_id", "reply_queue", "isolated_connection", "transaction")
+    __slots__ = (
+        "fn",
+        "task_id",
+        "loop",
+        "reply_future",
+        "isolated_connection",
+        "transaction",
+    )
 
-    def __init__(self, fn, task_id, reply_queue, isolated_connection, transaction):
+    def __init__(
+        self, fn, task_id, loop, reply_future, isolated_connection, transaction
+    ):
         self.fn = fn
         self.task_id = task_id
-        self.reply_queue = reply_queue
+        self.loop = loop
+        self.reply_future = reply_future
         self.isolated_connection = isolated_connection
         self.transaction = transaction
 
 
+def _deliver_write_result(task, result, exception):
+    # Called from the write thread. Delivers the result back to the
+    # awaiting coroutine on its event loop via call_soon_threadsafe.
+    def _set():
+        if task.reply_future.done():
+            # Awaiter was cancelled; nothing to do.
+            return
+        if exception is not None:
+            task.reply_future.set_exception(exception)
+        else:
+            task.reply_future.set_result(result)
+
+    try:
+        task.loop.call_soon_threadsafe(_set)
+    except RuntimeError:
+        # Event loop has been closed; the awaiter is gone.
+        pass
+
+
 class QueryInterrupted(Exception):
     def __init__(self, e, sql, params):
         self.e = e
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 4f26066c..5b637797 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,6 +4,14 @@
 Changelog
 =========
 
+.. _unreleased:
+
+Unreleased
+----------
+
+- Dropped Janus as a dependency, previously used to manage the write queue. This should not have any impact on plugin developers or end-users. (:issue:`1752`)
+
+
 .. _v1_0_a29:
 
 1.0a29 (2026-05-12)
diff --git a/pyproject.toml b/pyproject.toml
index e6007afd..c50c720a 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -32,7 +32,6 @@ dependencies = [
     "pluggy>=1.0",
     "uvicorn>=0.11",
     "aiofiles>=0.4",
-    "janus>=0.6.2",
     "PyYAML>=5.3",
     "mergedeep>=1.1.1",
     "itsdangerous>=1.1",
diff --git a/tests/test_internals_database.py b/tests/test_internals_database.py
index 8ff74a83..75ae8d39 100644
--- a/tests/test_internals_database.py
+++ b/tests/test_internals_database.py
@@ -2,9 +2,12 @@
 Tests for the datasette.database.Database class
 """
 
+import asyncio
+from types import SimpleNamespace
 from datasette.app import Datasette
 from datasette.database import Database, Results, MultipleValues
 from datasette.database import DatasetteClosedError
+from datasette.database import _deliver_write_result
 from datasette.utils.sqlite import sqlite3, sqlite_version
 from datasette.utils import Column
 import pytest
@@ -590,6 +593,37 @@ async def test_execute_write_fn_connection_exception(tmpdir, app_client):
     app_client.ds.remove_database("immutable-db")
 
 
+@pytest.mark.asyncio
+async def test_deliver_write_result_leaves_done_future_alone():
+    loop = asyncio.get_running_loop()
+    reply_future = loop.create_future()
+    reply_future.set_result("original")
+    task = SimpleNamespace(loop=loop, reply_future=reply_future)
+
+    # The write thread can finish after the caller has stopped waiting for the
+    # result. Delivery should notice that the future is already resolved and
+    # leave the caller's outcome alone instead of raising InvalidStateError.
+    _deliver_write_result(task, "replacement", None)
+    await asyncio.sleep(0)
+
+    assert reply_future.result() == "original"
+
+
+@pytest.mark.asyncio
+async def test_deliver_write_result_ignores_closed_loop():
+    closed_loop = asyncio.new_event_loop()
+    closed_loop.close()
+    reply_future = asyncio.get_running_loop().create_future()
+    task = SimpleNamespace(loop=closed_loop, reply_future=reply_future)
+
+    # If the event loop that submitted the write has gone away, the write
+    # thread should drop the result rather than crash while reporting back to
+    # that closed loop.
+    _deliver_write_result(task, "result", None)
+
+    assert not reply_future.done()
+
+
 def table_exists(conn, name):
     return bool(
         conn.execute(
diff --git a/tests/test_write_wrapper.py b/tests/test_write_wrapper.py
index 48c964b4..88ce5520 100644
--- a/tests/test_write_wrapper.py
+++ b/tests/test_write_wrapper.py
@@ -2,6 +2,7 @@
 Tests for the write_wrapper plugin hook.
 """
 
+import asyncio
 from dataclasses import dataclass
 from datasette.app import Datasette
 from datasette.events import Event
@@ -633,8 +634,6 @@ async def test_track_event_with_block_false(ds_with_event_tracking):
     assert task_id is not None
 
     # Give the background task time to complete
-    import asyncio
-
     for _ in range(50):
         if ds._tracked_events:
             break
@@ -644,6 +643,30 @@ async def test_track_event_with_block_false(ds_with_event_tracking):
     assert ds._tracked_events[0].message == "non-blocking"
 
 
+@pytest.mark.asyncio
+async def test_track_event_with_block_false_discarded_on_exception(
+    ds_with_event_tracking,
+):
+    """Events queued by a non-blocking write are discarded if the write fails."""
+    ds = ds_with_event_tracking
+    db = ds.get_database("test")
+
+    def my_write(conn, track_event):
+        track_event(DummyEvent(actor=None, message="should not fire"))
+        raise ValueError("deliberate error")
+
+    task_id = await db.execute_write_fn(my_write, block=False)
+    assert task_id is not None
+
+    # A following blocking write proves the failed non-blocking task has
+    # completed; one more loop turn lets its event-dispatch task observe the
+    # exception and exit.
+    await db.execute_write_fn(lambda conn: conn.execute("select 1"))
+    await asyncio.sleep(0)
+
+    assert ds._tracked_events == []
+
+
 # --- Tests for RenameTableEvent detection ---
 
 

From 10a1caac53be3d4b8344500f676c49bf82dd5384 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 16 May 2026 16:38:49 -0700
Subject: [PATCH 007/386] Upgrade a whole lot of GitHum Actions references

---
 .github/workflows/deploy-branch-preview.yml | 2 +-
 .github/workflows/deploy-latest.yml         | 2 +-
 .github/workflows/prettier.yml              | 4 ++--
 .github/workflows/push_docker_tag.yml       | 2 +-
 .github/workflows/spellcheck.yml            | 2 +-
 .github/workflows/stable-docs.yml           | 2 +-
 .github/workflows/test-coverage.yml         | 2 +-
 .github/workflows/test-pyodide.yml          | 4 ++--
 .github/workflows/test-sqlite-support.yml   | 2 +-
 .github/workflows/tmate-mac.yml             | 2 +-
 .github/workflows/tmate.yml                 | 2 +-
 11 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/deploy-branch-preview.yml b/.github/workflows/deploy-branch-preview.yml
index e56d9c27..4aa676da 100644
--- a/.github/workflows/deploy-branch-preview.yml
+++ b/.github/workflows/deploy-branch-preview.yml
@@ -12,7 +12,7 @@ jobs:
   deploy-branch-preview:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v6
     - name: Set up Python 3.11
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/deploy-latest.yml b/.github/workflows/deploy-latest.yml
index 7349a1ab..18c01fdc 100644
--- a/.github/workflows/deploy-latest.yml
+++ b/.github/workflows/deploy-latest.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out datasette
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/prettier.yml b/.github/workflows/prettier.yml
index 77cce7d1..735e14e9 100644
--- a/.github/workflows/prettier.yml
+++ b/.github/workflows/prettier.yml
@@ -10,8 +10,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out repo
-      uses: actions/checkout@v4
-    - uses: actions/cache@v4
+      uses: actions/checkout@v6
+    - uses: actions/cache@v5
       name: Configure npm caching
       with:
         path: ~/.npm
diff --git a/.github/workflows/push_docker_tag.yml b/.github/workflows/push_docker_tag.yml
index afe8d6b2..e622ef4c 100644
--- a/.github/workflows/push_docker_tag.yml
+++ b/.github/workflows/push_docker_tag.yml
@@ -13,7 +13,7 @@ jobs:
   deploy_docker:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v6
     - name: Build and push to Docker Hub
       env:
         DOCKER_USER: ${{ secrets.DOCKER_USER }}
diff --git a/.github/workflows/spellcheck.yml b/.github/workflows/spellcheck.yml
index d42ae96b..9a808194 100644
--- a/.github/workflows/spellcheck.yml
+++ b/.github/workflows/spellcheck.yml
@@ -9,7 +9,7 @@ jobs:
   spellcheck:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/stable-docs.yml b/.github/workflows/stable-docs.yml
index 3119d617..59b5fbc0 100644
--- a/.github/workflows/stable-docs.yml
+++ b/.github/workflows/stable-docs.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         fetch-depth: 0  # We need all commits to find docs/ changes
     - name: Set up Git user
diff --git a/.github/workflows/test-coverage.yml b/.github/workflows/test-coverage.yml
index 1b3d2f2c..c514048e 100644
--- a/.github/workflows/test-coverage.yml
+++ b/.github/workflows/test-coverage.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out datasette
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/test-pyodide.yml b/.github/workflows/test-pyodide.yml
index b490a9bf..5162c47a 100644
--- a/.github/workflows/test-pyodide.yml
+++ b/.github/workflows/test-pyodide.yml
@@ -12,7 +12,7 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Python 3.10
       uses: actions/setup-python@v6
       with:
@@ -20,7 +20,7 @@ jobs:
         cache: 'pip'
         cache-dependency-path: '**/pyproject.toml'
     - name: Cache Playwright browsers
-      uses: actions/cache@v4
+      uses: actions/cache@v5
       with:
         path: ~/.cache/ms-playwright/
         key: ${{ runner.os }}-browsers
diff --git a/.github/workflows/test-sqlite-support.yml b/.github/workflows/test-sqlite-support.yml
index c81a3c0b..23fce459 100644
--- a/.github/workflows/test-sqlite-support.yml
+++ b/.github/workflows/test-sqlite-support.yml
@@ -25,7 +25,7 @@ jobs:
           #"3.23.1" # 2018-04-10, before UPSERT
         ]
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/tmate-mac.yml b/.github/workflows/tmate-mac.yml
index fcee0f21..a033cd92 100644
--- a/.github/workflows/tmate-mac.yml
+++ b/.github/workflows/tmate-mac.yml
@@ -10,6 +10,6 @@ jobs:
   build:
     runs-on: macos-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v6
     - name: Setup tmate session
       uses: mxschmitt/action-tmate@v3
diff --git a/.github/workflows/tmate.yml b/.github/workflows/tmate.yml
index 123f6c71..72af1eec 100644
--- a/.github/workflows/tmate.yml
+++ b/.github/workflows/tmate.yml
@@ -11,7 +11,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v6
     - name: Setup tmate session
       uses: mxschmitt/action-tmate@v3
       env:

From c1b30818633e5cbb43d32bf163f99b0aacc391b7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 16 May 2026 16:44:28 -0700
Subject: [PATCH 008/386] Removed obsolete workflow

---
 .github/workflows/deploy-branch-preview.yml | 35 ---------------------
 1 file changed, 35 deletions(-)
 delete mode 100644 .github/workflows/deploy-branch-preview.yml

diff --git a/.github/workflows/deploy-branch-preview.yml b/.github/workflows/deploy-branch-preview.yml
deleted file mode 100644
index 4aa676da..00000000
--- a/.github/workflows/deploy-branch-preview.yml
+++ /dev/null
@@ -1,35 +0,0 @@
-name: Deploy a Datasette branch preview to Vercel
-
-on:
-  workflow_dispatch:
-    inputs:
-      branch:
-        description: "Branch to deploy"
-        required: true
-        type: string
-
-jobs:
-  deploy-branch-preview:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v6
-    - name: Set up Python 3.11
-      uses: actions/setup-python@v6
-      with:
-        python-version: "3.11"
-    - name: Install dependencies
-      run: |
-        pip install datasette-publish-vercel
-    - name: Deploy the preview
-      env:
-        VERCEL_TOKEN: ${{ secrets.BRANCH_PREVIEW_VERCEL_TOKEN }}
-      run: |
-        export BRANCH="${{ github.event.inputs.branch }}"
-        wget https://latest.datasette.io/fixtures.db
-        datasette publish vercel fixtures.db \
-          --branch $BRANCH \
-          --project "datasette-preview-$BRANCH" \
-          --token $VERCEL_TOKEN \
-          --scope datasette \
-          --about "Preview of $BRANCH" \
-          --about_url "https://github.com/simonw/datasette/tree/$BRANCH"

From 40e78e09277ae547dc63172f6b2bad50b0f24b64 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 16 May 2026 16:48:10 -0700
Subject: [PATCH 009/386] Change pull_request_target to pull_request event

---
 .github/workflows/documentation-links.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/documentation-links.yml b/.github/workflows/documentation-links.yml
index a54bd83a..b8fb8aaa 100644
--- a/.github/workflows/documentation-links.yml
+++ b/.github/workflows/documentation-links.yml
@@ -1,6 +1,6 @@
 name: Read the Docs Pull Request Preview
 on:
-  pull_request_target:
+  pull_request:
     types:
       - opened
 

From 7a914f8c656de2ffa3f662e49bc95b24dd36b854 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 20 May 2026 12:14:50 -0700
Subject: [PATCH 010/386] Clear stale tables/other resources when DB removed,
 closes #2723

---
 datasette/app.py          | 23 +++++++++++++++----
 docs/changelog.rst        |  2 +-
 tests/test_internal_db.py | 48 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 67 insertions(+), 6 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 358081ef..218d40c6 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -618,11 +618,24 @@ class Datasette:
         stale_databases = set(current_schema_versions.keys()) - set(
             self.databases.keys()
         )
-        for stale_db_name in stale_databases:
-            await internal_db.execute_write(
-                "DELETE FROM catalog_databases WHERE database_name = ?",
-                [stale_db_name],
-            )
+        if stale_databases:
+
+            def delete_stale_database_catalog(conn):
+                for stale_db_name in stale_databases:
+                    for table in (
+                        "catalog_columns",
+                        "catalog_foreign_keys",
+                        "catalog_indexes",
+                        "catalog_views",
+                        "catalog_tables",
+                        "catalog_databases",
+                    ):
+                        conn.execute(
+                            "DELETE FROM {} WHERE database_name = ?".format(table),
+                            [stale_db_name],
+                        )
+
+            await internal_db.execute_write_fn(delete_stale_database_catalog)
         for database_name, db in self.databases.items():
             schema_version = (await db.execute("PRAGMA schema_version")).first()[0]
             # Compare schema versions to see if we should skip it
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 5b637797..eb408287 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -10,7 +10,7 @@ Unreleased
 ----------
 
 - Dropped Janus as a dependency, previously used to manage the write queue. This should not have any impact on plugin developers or end-users. (:issue:`1752`)
-
+- Fixed a bug where stale tables and other related resources were not removed from ``catalog_*`` tables when a database was removed. (:issue:`2723`)
 
 .. _v1_0_a29:
 
diff --git a/tests/test_internal_db.py b/tests/test_internal_db.py
index 7a0d1630..ec013b43 100644
--- a/tests/test_internal_db.py
+++ b/tests/test_internal_db.py
@@ -139,3 +139,51 @@ async def test_stale_catalog_entry_database_fix(tmp_path):
         f"Index page should return 200, not {response.status_code}. "
         "This fails due to stale catalog entries causing KeyError."
     )
+
+
+@pytest.mark.asyncio
+async def test_stale_catalog_child_entries_removed_for_missing_database(tmp_path):
+    from datasette.app import Datasette
+
+    import sqlite3
+
+    internal_db_path = str(tmp_path / "internal.db")
+    alpha_db_path = str(tmp_path / "alpha.db")
+    bravo_db_path = str(tmp_path / "bravo.db")
+
+    for db_path, table_name in (
+        (alpha_db_path, "alpha_table"),
+        (bravo_db_path, "bravo_table"),
+        (bravo_db_path, "bravo_table_2"),
+    ):
+        conn = sqlite3.connect(db_path)
+        conn.execute(f"CREATE TABLE {table_name} (id INTEGER PRIMARY KEY)")
+        conn.close()
+
+    ds1 = Datasette(files=[alpha_db_path, bravo_db_path], internal=internal_db_path)
+    await ds1.invoke_startup()
+
+    catalog_tables = await ds1.get_internal_database().execute("""
+        SELECT database_name, table_name
+        FROM catalog_tables
+        ORDER BY database_name, table_name
+        """)
+    assert [tuple(row) for row in catalog_tables.rows] == [
+        ("alpha", "alpha_table"),
+        ("bravo", "bravo_table"),
+        ("bravo", "bravo_table_2"),
+    ]
+
+    ds1.close()
+
+    ds2 = Datasette(files=[alpha_db_path], internal=internal_db_path)
+    await ds2.invoke_startup()
+
+    catalog_tables = await ds2.get_internal_database().execute("""
+        SELECT database_name, table_name
+        FROM catalog_tables
+        ORDER BY database_name, table_name
+        """)
+    assert [tuple(row) for row in catalog_tables.rows] == [("alpha", "alpha_table")]
+
+    ds2.close()

From 5d6de0154d18d0ed07e7ac7cf02cd3c37324ddbc Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 20 May 2026 12:18:01 -0700
Subject: [PATCH 011/386] Bump Black to black==26.3.1

Refs https://github.com/advisories/GHSA-3936-cmfr-pm3m
---
 pyproject.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pyproject.toml b/pyproject.toml
index c50c720a..38085476 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -62,7 +62,7 @@ dev = [
     "pytest-xdist>=2.2.1",
     "pytest-asyncio>=1.2.0",
     "beautifulsoup4>=4.8.1",
-    "black==26.1.0",
+    "black==26.3.1",
     "blacken-docs==1.20.0",
     "pytest-timeout>=1.4.2",
     "trustme>=0.7",

From bbbc1cd59620c7c53a2eff6138ef338c8901ba6e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 20 May 2026 12:33:33 -0700
Subject: [PATCH 012/386] Remove height: 100% to fix Safari bug, closes #2724

---
 datasette/static/navigation-search.js | 1 -
 docs/changelog.rst                    | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/datasette/static/navigation-search.js b/datasette/static/navigation-search.js
index 95e7dfc5..d2c300e2 100644
--- a/datasette/static/navigation-search.js
+++ b/datasette/static/navigation-search.js
@@ -54,7 +54,6 @@ class NavigationSearch extends HTMLElement {
                 .search-container {
                     display: flex;
                     flex-direction: column;
-                    height: 100%;
                 }
 
                 .search-input-wrapper {
diff --git a/docs/changelog.rst b/docs/changelog.rst
index eb408287..56c49ea3 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -11,6 +11,7 @@ Unreleased
 
 - Dropped Janus as a dependency, previously used to manage the write queue. This should not have any impact on plugin developers or end-users. (:issue:`1752`)
 - Fixed a bug where stale tables and other related resources were not removed from ``catalog_*`` tables when a database was removed. (:issue:`2723`)
+- Fixed a Safari bug with the table search mechanism triggered by pressing ``/``. (:issue:`2724`)
 
 .. _v1_0_a29:
 

From 54b272baf61cb014e6d262fea1b01dc84981c1d0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 20 May 2026 12:39:54 -0700
Subject: [PATCH 013/386] Remove existing stale catalog_ tables, refs #2723

Now if there are any existing stale records in internal.db
those will be removed as well.
---
 datasette/app.py          | 30 ++++++++++++++++----------
 tests/test_internal_db.py | 45 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 64 insertions(+), 11 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 218d40c6..b1f9b2f7 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -614,22 +614,30 @@ class Datasette:
                 "select database_name, schema_version from catalog_databases"
             )
         }
-        # Delete stale entries for databases that are no longer attached
-        stale_databases = set(current_schema_versions.keys()) - set(
-            self.databases.keys()
+        catalog_table_names = (
+            "catalog_columns",
+            "catalog_foreign_keys",
+            "catalog_indexes",
+            "catalog_views",
+            "catalog_tables",
+            "catalog_databases",
         )
+        # Delete stale entries for databases that are no longer attached
+        catalog_database_names = set(current_schema_versions.keys())
+        for table in catalog_table_names[:-1]:
+            catalog_database_names.update(
+                row["database_name"]
+                for row in await internal_db.execute(
+                    "select distinct database_name from {}".format(table)
+                )
+                if row["database_name"] is not None
+            )
+        stale_databases = catalog_database_names - set(self.databases.keys())
         if stale_databases:
 
             def delete_stale_database_catalog(conn):
                 for stale_db_name in stale_databases:
-                    for table in (
-                        "catalog_columns",
-                        "catalog_foreign_keys",
-                        "catalog_indexes",
-                        "catalog_views",
-                        "catalog_tables",
-                        "catalog_databases",
-                    ):
+                    for table in catalog_table_names:
                         conn.execute(
                             "DELETE FROM {} WHERE database_name = ?".format(table),
                             [stale_db_name],
diff --git a/tests/test_internal_db.py b/tests/test_internal_db.py
index ec013b43..dcf14126 100644
--- a/tests/test_internal_db.py
+++ b/tests/test_internal_db.py
@@ -187,3 +187,48 @@ async def test_stale_catalog_child_entries_removed_for_missing_database(tmp_path
     assert [tuple(row) for row in catalog_tables.rows] == [("alpha", "alpha_table")]
 
     ds2.close()
+
+
+@pytest.mark.asyncio
+async def test_orphan_stale_catalog_child_entries_removed(tmp_path):
+    from datasette.app import Datasette
+
+    import sqlite3
+
+    internal_db_path = str(tmp_path / "internal.db")
+    alpha_db_path = str(tmp_path / "alpha.db")
+
+    conn = sqlite3.connect(alpha_db_path)
+    conn.execute("CREATE TABLE alpha_table (id INTEGER PRIMARY KEY)")
+    conn.close()
+
+    ds1 = Datasette(files=[alpha_db_path], internal=internal_db_path)
+    await ds1.invoke_startup()
+    ds1.close()
+
+    # Simulate the state left behind by old cleanup code: the parent database
+    # row was deleted, but child catalog rows survived because foreign key
+    # enforcement is not enabled for these internal catalog writes.
+    conn = sqlite3.connect(internal_db_path)
+    conn.execute("DELETE FROM catalog_databases WHERE database_name = 'fixtures'")
+    conn.execute("""
+        INSERT INTO catalog_tables (database_name, table_name, rootpage, sql)
+        VALUES ('fixtures', 'stale_table', 1, 'CREATE TABLE stale_table (id INTEGER)')
+    """)
+    conn.commit()
+    conn.close()
+
+    ds2 = Datasette(files=[alpha_db_path], internal=internal_db_path)
+    await ds2.invoke_startup()
+
+    catalog_tables = await ds2.get_internal_database().execute("""
+        SELECT database_name, table_name
+        FROM catalog_tables
+        ORDER BY database_name, table_name
+        """)
+    assert [tuple(row) for row in catalog_tables.rows] == [("alpha", "alpha_table")]
+
+    response = await ds2.client.get("/-/tables.json")
+    assert response.status_code == 200
+
+    ds2.close()

From d3330695fa42ad1cdb2f2b1b80470e95bea8ed12 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 20 May 2026 13:23:05 -0700
Subject: [PATCH 014/386] Always show 'Jump to...' menu item, closes #2725

---
 datasette/static/app.css              | 26 ++++++++++++++++++++++++++
 datasette/static/navigation-search.js | 13 ++++++++++++-
 datasette/templates/base.html         |  7 +++----
 docs/changelog.rst                    |  1 +
 tests/test_html.py                    | 18 +++++++++++++++---
 5 files changed, 57 insertions(+), 8 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 1ce84bc8..c21d0dc4 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -362,6 +362,32 @@ form.nav-menu-logout {
 .nav-menu-inner a {
     display: block;
 }
+.nav-menu-inner button.button-as-link {
+    display: block;
+    width: 100%;
+    text-align: left;
+    font: inherit;
+}
+.nav-menu-inner .keyboard-shortcut {
+    float: right;
+    box-sizing: border-box;
+    min-width: 1.4em;
+    margin-left: 0.75rem;
+    padding: 0 0.35em;
+    border: 1px solid rgba(255,255,244,0.6);
+    border-radius: 3px;
+    background: rgba(255,255,244,0.12);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.85em;
+    line-height: 1.35;
+    text-align: center;
+    text-decoration: none;
+}
+@media (max-width: 640px) {
+    .nav-menu-inner .keyboard-shortcut {
+        display: none;
+    }
+}
 
 /* Table/database actions menu */
 .page-action-menu {
diff --git a/datasette/static/navigation-search.js b/datasette/static/navigation-search.js
index d2c300e2..09d58898 100644
--- a/datasette/static/navigation-search.js
+++ b/datasette/static/navigation-search.js
@@ -199,6 +199,15 @@ class NavigationSearch extends HTMLElement {
       }
     });
 
+    document.addEventListener("click", (e) => {
+      const trigger = e.target.closest("[data-navigation-search-open]");
+      if (trigger) {
+        e.preventDefault();
+        trigger.closest("details")?.removeAttribute("open");
+        this.openMenu();
+      }
+    });
+
     // Input event
     input.addEventListener("input", (e) => {
       this.handleSearch(e.target.value);
@@ -390,7 +399,9 @@ class NavigationSearch extends HTMLElement {
     const dialog = this.shadowRoot.querySelector("dialog");
     const input = this.shadowRoot.querySelector(".search-input");
 
-    dialog.showModal();
+    if (!dialog.open) {
+      dialog.showModal();
+    }
     input.value = "";
     input.focus();
 
diff --git a/datasette/templates/base.html b/datasette/templates/base.html
index 21f8c693..b4fecf70 100644
--- a/datasette/templates/base.html
+++ b/datasette/templates/base.html
@@ -20,7 +20,7 @@
 <body class="{% block body_class %}{% endblock %}">
 <div class="not-footer">
 <header class="hd"><nav>{% block nav %}{% block crumbs %}{{ crumbs.nav(request=request) }}{% endblock %}
-    {% set links = menu_links() %}{% if links or show_logout %}
+    {% set links = menu_links() %}
     <details class="nav-menu details-menu">
         <summary><svg aria-labelledby="nav-menu-svg-title" role="img"
             fill="currentColor" stroke="currentColor" xmlns="http://www.w3.org/2000/svg"
@@ -29,19 +29,18 @@
                 <path fill-rule="evenodd" d="M1 2.75A.75.75 0 011.75 2h12.5a.75.75 0 110 1.5H1.75A.75.75 0 011 2.75zm0 5A.75.75 0 011.75 7h12.5a.75.75 0 110 1.5H1.75A.75.75 0 011 7.75zM1.75 12a.75.75 0 100 1.5h12.5a.75.75 0 100-1.5H1.75z"></path>
         </svg></summary>
         <div class="nav-menu-inner">
-            {% if links %}
             <ul>
+                <li><button type="button" class="button-as-link" data-navigation-search-open>Jump to... <kbd class="keyboard-shortcut" aria-hidden="true" title="Keyboard shortcut: press / to open Jump to">/</kbd></button></li>
                 {% for link in links %}
                 <li><a href="{{ link.href }}">{{ link.label }}</a></li>
                 {% endfor %}
             </ul>
-            {% endif %}
             {% if show_logout %}
             <form class="nav-menu-logout" action="{{ urls.logout() }}" method="post">
                 <button class="button-as-link">Log out</button>
             </form>{% endif %}
         </div>
-    </details>{% endif %}
+    </details>
     {% if actor %}
     <div class="actor">
         <strong>{{ display_actor(actor) }}</strong>
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 56c49ea3..f2ba23ec 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -12,6 +12,7 @@ Unreleased
 - Dropped Janus as a dependency, previously used to manage the write queue. This should not have any impact on plugin developers or end-users. (:issue:`1752`)
 - Fixed a bug where stale tables and other related resources were not removed from ``catalog_*`` tables when a database was removed. (:issue:`2723`)
 - Fixed a Safari bug with the table search mechanism triggered by pressing ``/``. (:issue:`2724`)
+- New "Jump to..." menu item, always visible, for triggering the previously undocumented ``/`` menu. (:issue:`2725`)
 
 .. _v1_0_a29:
 
diff --git a/tests/test_html.py b/tests/test_html.py
index 7425692d..64b4075a 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -1008,10 +1008,22 @@ async def test_navigation_menu_links(
         kwargs["actor"] = {"id": actor_id}
     html = (await ds_client.get("/", **kwargs)).text
     soup = Soup(html, "html.parser")
-    details = soup.find("nav").find("details")
+    details = soup.find("nav").find("details", {"class": "nav-menu"})
+    assert details is not None
+    search_button = details.find("button", {"data-navigation-search-open": True})
+    assert search_button is not None
+    assert search_button.text.strip() == "Jump to... /"
+    assert search_button.find("kbd", {"class": "keyboard-shortcut"}).text == "/"
+    assert search_button.find("kbd")["aria-hidden"] == "true"
+    assert (
+        search_button.find("kbd")["title"]
+        == "Keyboard shortcut: press / to open Jump to"
+    )
+    assert details.find("li").find("button") == search_button
     if not actor_id:
-        # Should not show a menu
-        assert details is None
+        # The app menu is always visible, but anonymous users do not see logout
+        # or debug links.
+        assert details.find("form") is None
         return
     # They are logged in: should show a menu
     assert details is not None

From fae847ac1017bb76044fd3aad703d5b9725c12ed Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 21 May 2026 15:02:14 -0700
Subject: [PATCH 015/386] Prototype of new /-/jump menu plus plugin hook

---
 datasette/app.py                         |  47 +++-
 datasette/handle_exception.py            |   3 +
 datasette/hookspecs.py                   |  10 +
 datasette/jump.py                        |  33 +++
 datasette/static/navigation-search.js    | 240 ++++++++++++++++++---
 datasette/templates/base.html            |  11 +-
 datasette/views/special.py               | 259 ++++++++++++++++++-----
 docs/introspection.rst                   |  51 +++--
 tests/test_allowed_resources.py          |  20 +-
 tests/test_html.py                       |   7 +
 tests/test_internal_db.py                |   2 +-
 tests/test_internals_datasette_client.py |   8 +-
 tests/test_jump.py                       | 224 ++++++++++++++++++++
 tests/test_navigation_search_js.py       | 199 +++++++++++++++++
 tests/test_search_tables.py              |  21 +-
 15 files changed, 1005 insertions(+), 130 deletions(-)
 create mode 100644 datasette/jump.py
 create mode 100644 tests/test_jump.py
 create mode 100644 tests/test_navigation_search_js.py

diff --git a/datasette/app.py b/datasette/app.py
index b1f9b2f7..c9605af3 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -58,7 +58,7 @@ from .views.special import (
     AllowedResourcesView,
     PermissionRulesView,
     PermissionCheckView,
-    TablesView,
+    JumpView,
     InstanceSchemaView,
     DatabaseSchemaView,
     TableSchemaView,
@@ -1219,13 +1219,24 @@ class Datasette:
 
         return db_plugin_config
 
+    def static_hash(self, filename):
+        if not hasattr(self, "_static_hashes"):
+            self._static_hashes = {}
+        path = os.path.join(str(app_root), "datasette/static", filename)
+        signature = (os.path.getmtime(path), os.path.getsize(path))
+        cached = self._static_hashes.get(filename)
+        if cached and cached["signature"] == signature:
+            return cached["hash"]
+        with open(path) as fp:
+            static_hash = hashlib.sha1(fp.read().encode("utf8")).hexdigest()[:6]
+        self._static_hashes[filename] = {
+            "signature": signature,
+            "hash": static_hash,
+        }
+        return static_hash
+
     def app_css_hash(self):
-        if not hasattr(self, "_app_css_hash"):
-            with open(os.path.join(str(app_root), "datasette/static/app.css")) as fp:
-                self._app_css_hash = hashlib.sha1(fp.read().encode("utf8")).hexdigest()[
-                    :6
-                ]
-        return self._app_css_hash
+        return self.static_hash("app.css")
 
     async def get_canned_queries(self, database_name, actor):
         queries = {}
@@ -2028,6 +2039,22 @@ class Datasette:
                     links.extend(extra_links)
             return links
 
+        async def jump_start():
+            html_bits = []
+            for hook in pm.hook.jump_start(
+                datasette=self,
+                actor=request.actor if request else None,
+                request=request or None,
+            ):
+                extra_html = await await_me_maybe(hook)
+                if not extra_html:
+                    continue
+                if isinstance(extra_html, (list, tuple)):
+                    html_bits.extend(extra_html)
+                else:
+                    html_bits.append(extra_html)
+            return Markup("").join(Markup(html) for html in html_bits)
+
         template_context = {
             **context,
             **{
@@ -2036,11 +2063,13 @@ class Datasette:
                 "urls": self.urls,
                 "actor": request.actor if request else None,
                 "menu_links": menu_links,
+                "jump_start": jump_start,
                 "display_actor": display_actor,
                 "show_logout": request is not None
                 and "ds_actor" in request.cookies
                 and request.actor,
                 "app_css_hash": self.app_css_hash(),
+                "navigation_search_js_hash": self.static_hash("navigation-search.js"),
                 "zip": zip,
                 "body_scripts": body_scripts,
                 "format_bytes": format_bytes,
@@ -2222,8 +2251,8 @@ class Datasette:
             r"/-/api$",
         )
         add_route(
-            TablesView.as_view(self),
-            r"/-/tables(\.(?P<format>json))?$",
+            JumpView.as_view(self),
+            r"/-/jump(\.(?P<format>json))?$",
         )
         add_route(
             InstanceSchemaView.as_view(self),
diff --git a/datasette/handle_exception.py b/datasette/handle_exception.py
index 96398a4c..25ec26d9 100644
--- a/datasette/handle_exception.py
+++ b/datasette/handle_exception.py
@@ -67,6 +67,9 @@ def handle_exception(datasette, request, exception):
                         info,
                         urls=datasette.urls,
                         app_css_hash=datasette.app_css_hash(),
+                        navigation_search_js_hash=datasette.static_hash(
+                            "navigation-search.js"
+                        ),
                         menu_links=lambda: [],
                     )
                 ),
diff --git a/datasette/hookspecs.py b/datasette/hookspecs.py
index 27e20bd4..a4d8143b 100644
--- a/datasette/hookspecs.py
+++ b/datasette/hookspecs.py
@@ -157,6 +157,16 @@ def menu_links(datasette, actor, request):
     """Links for the navigation menu"""
 
 
+@hookspec
+def jump_items_sql(datasette, actor, request):
+    """SQL fragments for extra items in the jump menu, optionally with display_name"""
+
+
+@hookspec
+def jump_start(datasette, actor, request):
+    """HTML to display in the jump menu before the user types"""
+
+
 @hookspec
 def row_actions(datasette, actor, request, database, table, row):
     """Links for the row actions menu"""
diff --git a/datasette/jump.py b/datasette/jump.py
new file mode 100644
index 00000000..96e18547
--- /dev/null
+++ b/datasette/jump.py
@@ -0,0 +1,33 @@
+from __future__ import annotations
+
+import re
+from dataclasses import dataclass
+from typing import Any
+
+
+@dataclass
+class JumpSQL:
+    sql: str
+    params: dict[str, Any] | None = None
+    has_display_name: bool = False
+
+
+_PARAM_RE = re.compile(r"(?<!:):([A-Za-z_][A-Za-z0-9_]*)")
+
+
+def namespace_sql_params(sql: str, params: dict[str, Any], prefix: str):
+    """Rename named SQL parameters so UNION fragments cannot collide."""
+    if not params:
+        return sql, {}
+
+    renamed = {key: f"{prefix}_{key}" for key in params}
+
+    def replace(match):
+        key = match.group(1)
+        if key not in renamed:
+            return match.group(0)
+        return f":{renamed[key]}"
+
+    return _PARAM_RE.sub(replace, sql), {
+        renamed[key]: value for key, value in params.items()
+    }
diff --git a/datasette/static/navigation-search.js b/datasette/static/navigation-search.js
index 09d58898..49cc172c 100644
--- a/datasette/static/navigation-search.js
+++ b/datasette/static/navigation-search.js
@@ -100,16 +100,65 @@ class NavigationSearch extends HTMLElement {
                     background-color: #dbeafe;
                 }
 
+                .jump-start-content {
+                    border-bottom: 1px solid #e5e7eb;
+                    margin-bottom: 0.5rem;
+                    padding: 0.5rem 0.5rem 1rem;
+                }
+
+                .jump-start-content:empty {
+                    display: none;
+                }
+
                 .result-name {
                     font-weight: 500;
                     color: #111827;
                 }
 
+                .result-label {
+                    font-size: 0.875rem;
+                    color: #4b5563;
+                }
+
+                .result-description {
+                    color: #4b5563;
+                    font-size: 0.75rem;
+                    font-weight: 600;
+                    text-transform: uppercase;
+                }
+
                 .result-url {
                     font-size: 0.875rem;
                     color: #6b7280;
                 }
 
+                .results-heading {
+                    color: #4b5563;
+                    font-size: 0.75rem;
+                    font-weight: 600;
+                    letter-spacing: 0;
+                    padding: 0.5rem 1rem 0.25rem;
+                    text-transform: uppercase;
+                }
+
+                .recent-actions {
+                    padding: 0.25rem 1rem 0.75rem;
+                }
+
+                .clear-recent {
+                    background: transparent;
+                    border: 0;
+                    color: #2563eb;
+                    cursor: pointer;
+                    font: inherit;
+                    font-size: 0.875rem;
+                    padding: 0;
+                }
+
+                .clear-recent:hover {
+                    text-decoration: underline;
+                }
+
                 .no-results {
                     padding: 2rem;
                     text-align: center;
@@ -168,8 +217,8 @@ class NavigationSearch extends HTMLElement {
                         <input 
                             type="text" 
                             class="search-input" 
-                            placeholder="Search..."
-                            aria-label="Search navigation"
+                            placeholder="Jump to..."
+                            aria-label="Jump to"
                             autocomplete="off"
                             spellcheck="false"
                         >
@@ -231,6 +280,13 @@ class NavigationSearch extends HTMLElement {
 
     // Click on result item
     resultsContainer.addEventListener("click", (e) => {
+      const clearRecent = e.target.closest("[data-clear-recent-items]");
+      if (clearRecent) {
+        e.preventDefault();
+        this.clearRecentItems();
+        return;
+      }
+
       const item = e.target.closest(".result-item");
       if (item) {
         const index = parseInt(item.dataset.index);
@@ -306,12 +362,13 @@ class NavigationSearch extends HTMLElement {
 
   filterLocalItems(query) {
     if (!query.trim()) {
-      this.matches = [];
+      this.matches = this.allItems || [];
     } else {
       const lowerQuery = query.toLowerCase();
       this.matches = (this.allItems || []).filter(
         (item) =>
           item.name.toLowerCase().includes(lowerQuery) ||
+          (item.display_name || "").toLowerCase().includes(lowerQuery) ||
           item.url.toLowerCase().includes(lowerQuery),
       );
     }
@@ -319,43 +376,165 @@ class NavigationSearch extends HTMLElement {
     this.renderResults();
   }
 
-  renderResults() {
-    const container = this.shadowRoot.querySelector(".results-container");
-    const input = this.shadowRoot.querySelector(".search-input");
+  recentItemsStorageKey() {
+    return "datasette.navigationSearch.recentItems";
+  }
 
-    if (this.matches.length === 0) {
-      const message = input.value.trim()
-        ? "No results found"
-        : "Start typing to search...";
-      container.innerHTML = `<div class="no-results">${message}</div>`;
+  loadRecentItems() {
+    if (typeof localStorage === "undefined") {
+      return [];
+    }
+
+    try {
+      const raw = localStorage.getItem(this.recentItemsStorageKey());
+      if (!raw) {
+        return [];
+      }
+      const parsed = JSON.parse(raw);
+      if (!Array.isArray(parsed)) {
+        return [];
+      }
+      return parsed
+        .filter((item) => item && item.name && item.url)
+        .map((item) => ({
+          name: String(item.name),
+          display_name: item.display_name ? String(item.display_name) : "",
+          url: String(item.url),
+          type: item.type ? String(item.type) : "",
+          description: item.description ? String(item.description) : "",
+        }))
+        .slice(0, 5);
+    } catch (e) {
+      return [];
+    }
+  }
+
+  saveRecentItem(match) {
+    if (typeof localStorage === "undefined" || !match || !match.name || !match.url) {
       return;
     }
 
-    container.innerHTML = this.matches
-      .map(
-        (match, index) => `
-            <div 
-                class="result-item ${
-                  index === this.selectedIndex ? "selected" : ""
-                }" 
+    try {
+      const item = {
+        name: String(match.name),
+        display_name: match.display_name ? String(match.display_name) : "",
+        url: String(match.url),
+        type: match.type ? String(match.type) : "",
+        description: match.description ? String(match.description) : "",
+      };
+      const recentItems = this.loadRecentItems().filter(
+        (recentItem) => recentItem.url !== item.url,
+      );
+      localStorage.setItem(
+        this.recentItemsStorageKey(),
+        JSON.stringify([item, ...recentItems].slice(0, 5)),
+      );
+    } catch (e) {
+      // localStorage may be unavailable, full, or disabled.
+    }
+  }
+
+  clearRecentItems() {
+    if (typeof localStorage === "undefined") {
+      return;
+    }
+
+    try {
+      localStorage.removeItem(this.recentItemsStorageKey());
+    } catch (e) {
+      localStorage.setItem(this.recentItemsStorageKey(), "[]");
+    }
+    this.renderResults();
+  }
+
+  startContentHtml() {
+    const template = this.querySelector("template[data-jump-start]");
+    return template ? template.innerHTML.trim() : "";
+  }
+
+  resultItemHtml(match, index) {
+    const displayName = match.display_name || match.name;
+    const label =
+      match.display_name && match.display_name !== match.name
+        ? `<div class="result-label">${this.escapeHtml(match.name)}</div>`
+        : "";
+    const description = match.description
+      ? `<div class="result-description">${this.escapeHtml(
+          match.description,
+        )}</div>`
+      : "";
+    return `
+            <div
+                class="result-item ${index === this.selectedIndex ? "selected" : ""}"
                 data-index="${index}"
                 role="option"
                 aria-selected="${index === this.selectedIndex}"
             >
                 <div>
-                    <div class="result-name">${this.escapeHtml(
-                      match.name,
-                    )}</div>
+                    ${description}
+                    <div class="result-name">${this.escapeHtml(displayName)}</div>
+                    ${label}
                     <div class="result-url">${this.escapeHtml(match.url)}</div>
                 </div>
             </div>
-        `,
+        `;
+  }
+
+  renderResults() {
+    const container = this.shadowRoot.querySelector(".results-container");
+    const input = this.shadowRoot.querySelector(".search-input");
+    const showStartContent = !input.value.trim();
+    const startContent = showStartContent ? this.startContentHtml() : "";
+    const startBlock = startContent
+      ? `<div class="jump-start-content">${startContent}</div>`
+      : "";
+    const recentItems = showStartContent ? this.loadRecentItems() : [];
+    const defaultMatches = showStartContent ? [] : this.matches;
+    const renderedMatches = [...recentItems, ...defaultMatches];
+    this.renderedMatches = renderedMatches;
+
+    if (renderedMatches.length) {
+      if (
+        this.selectedIndex < 0 ||
+        this.selectedIndex >= renderedMatches.length
+      ) {
+        this.selectedIndex = 0;
+      }
+    } else {
+      this.selectedIndex = -1;
+    }
+
+    if (renderedMatches.length === 0) {
+      if (startBlock) {
+        container.innerHTML = startBlock;
+      } else if (showStartContent) {
+        container.innerHTML = "";
+      } else {
+        const message = input.value.trim()
+          ? "No results found"
+          : "Start typing to search...";
+        container.innerHTML = `<div class="no-results">${message}</div>`;
+      }
+      return;
+    }
+
+    const recentHtml = recentItems.length
+      ? `<div class="results-heading">Recent</div>${recentItems
+          .map((match, index) => this.resultItemHtml(match, index))
+          .join("")}<div class="recent-actions"><button type="button" class="clear-recent" data-clear-recent-items>Clear recent</button></div>`
+      : "";
+    const defaultHtml = defaultMatches
+      .map((match, index) =>
+        this.resultItemHtml(match, recentItems.length + index),
       )
       .join("");
+    container.innerHTML = startBlock + recentHtml + defaultHtml;
 
     // Scroll selected item into view
     if (this.selectedIndex >= 0) {
-      const selectedItem = container.children[this.selectedIndex];
+      const selectedItem = container.querySelector(
+        `.result-item[data-index="${this.selectedIndex}"]`,
+      );
       if (selectedItem) {
         selectedItem.scrollIntoView({ block: "nearest" });
       }
@@ -363,22 +542,27 @@ class NavigationSearch extends HTMLElement {
   }
 
   moveSelection(direction) {
+    const matches = this.renderedMatches || this.matches;
     const newIndex = this.selectedIndex + direction;
-    if (newIndex >= 0 && newIndex < this.matches.length) {
+    if (newIndex >= 0 && newIndex < matches.length) {
       this.selectedIndex = newIndex;
       this.renderResults();
     }
   }
 
   selectCurrentItem() {
-    if (this.selectedIndex >= 0 && this.selectedIndex < this.matches.length) {
+    const matches = this.renderedMatches || this.matches;
+    if (this.selectedIndex >= 0 && this.selectedIndex < matches.length) {
       this.selectItem(this.selectedIndex);
     }
   }
 
   selectItem(index) {
-    const match = this.matches[index];
+    const matches = this.renderedMatches || this.matches;
+    const match = matches[index];
     if (match) {
+      this.saveRecentItem(match);
+
       // Dispatch custom event
       this.dispatchEvent(
         new CustomEvent("select", {
@@ -405,7 +589,7 @@ class NavigationSearch extends HTMLElement {
     input.value = "";
     input.focus();
 
-    // Reset state - start with no items shown
+    // Reset state, then populate the default jump list.
     this.matches = [];
     this.selectedIndex = -1;
     this.renderResults();
@@ -418,7 +602,7 @@ class NavigationSearch extends HTMLElement {
 
   escapeHtml(text) {
     const div = document.createElement("div");
-    div.textContent = text;
+    div.textContent = text == null ? "" : text;
     return div.innerHTML;
   }
 }
diff --git a/datasette/templates/base.html b/datasette/templates/base.html
index b4fecf70..6a55bd1f 100644
--- a/datasette/templates/base.html
+++ b/datasette/templates/base.html
@@ -70,7 +70,14 @@
 {% endfor %}
 
 {% if select_templates %}<!-- Templates considered: {{ select_templates|join(", ") }} -->{% endif %}
-<script src="{{ urls.static('navigation-search.js') }}" defer></script>
-<navigation-search url="/-/tables"></navigation-search>
+<script src="{{ urls.static('navigation-search.js') }}{% if navigation_search_js_hash is defined %}?{{ navigation_search_js_hash }}{% endif %}" defer></script>
+{% if jump_start is defined %}
+{% set jump_start_html = jump_start() %}
+{% else %}
+{% set jump_start_html = "" %}
+{% endif %}
+<navigation-search url="/-/jump">{% if jump_start_html %}
+    <template data-jump-start>{{ jump_start_html }}</template>
+{% endif %}</navigation-search>
 </body>
 </html>
diff --git a/datasette/views/special.py b/datasette/views/special.py
index b28e9257..990714cf 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -1,11 +1,14 @@
 import json
 import logging
+from datasette.jump import JumpSQL, namespace_sql_params
+from datasette.plugins import pm
 from datasette.events import LogoutEvent, LoginEvent, CreateTokenEvent
 from datasette.resources import DatabaseResource, TableResource
 from datasette.utils.asgi import Response, Forbidden
 from datasette.utils import (
     actor_matches_allow,
     add_cors_headers,
+    await_me_maybe,
     tilde_encode,
     tilde_decode,
 )
@@ -910,75 +913,231 @@ class ApiExplorerView(BaseView):
         )
 
 
-class TablesView(BaseView):
+class JumpView(BaseView):
     """
-    Simple endpoint that uses the new allowed_resources() API.
-    Returns JSON list of all tables the actor can view.
-
-    Supports ?q=foo+bar to filter tables matching .*foo.*bar.* pattern,
-    ordered by shortest name first.
+    Endpoint for the jump menu. Returns JSON navigation items the actor can use.
     """
 
-    name = "tables"
+    name = "jump"
     has_json_alternate = False
 
-    async def get(self, request):
-        # Get search query parameter
-        q = request.args.get("q", "").strip()
+    async def _query_display_names_sql(self, request):
+        selects = []
+        params = {}
+        for database_name in self.ds.databases.keys():
+            queries = await self.ds.get_canned_queries(database_name, request.actor)
+            for query_name, query in queries.items():
+                display_name = query.get("title") if isinstance(query, dict) else None
+                if not display_name:
+                    continue
+                index = len(selects)
+                params[f"display_database_{index}"] = database_name
+                params[f"display_query_{index}"] = query_name
+                params[f"display_name_{index}"] = str(display_name)
+                selects.append(f"""
+                SELECT
+                    :display_database_{index} AS database_name,
+                    :display_query_{index} AS query_name,
+                    :display_name_{index} AS display_name
+                """)
+        if not selects:
+            return (
+                "SELECT NULL AS database_name, NULL AS query_name, NULL AS display_name WHERE 0",
+                {},
+            )
+        return " UNION ALL ".join(selects), params
 
-        # Get SQL for allowed resources using the permission system
-        permission_sql, params = await self.ds.allowed_resources_sql(
+    async def _core_fragments(self, request):
+        database_sql, database_params = await self.ds.allowed_resources_sql(
+            action="view-database", actor=request.actor
+        )
+        table_sql, table_params = await self.ds.allowed_resources_sql(
             action="view-table", actor=request.actor
         )
+        query_sql, query_params = await self.ds.allowed_resources_sql(
+            action="view-query", actor=request.actor
+        )
+        query_display_names_sql, query_display_names_params = (
+            await self._query_display_names_sql(request)
+        )
+        return [
+            JumpSQL(
+                sql=f"""
+                WITH allowed_databases AS (
+                    {database_sql}
+                )
+                SELECT
+                    'database' AS type,
+                    parent AS label,
+                    'Database' AS description,
+                    NULL AS url,
+                    parent AS database_name,
+                    NULL AS resource_name,
+                    parent AS search_text,
+                    10 AS sort_key,
+                    'datasette' AS source,
+                    NULL AS display_name
+                FROM allowed_databases
+                """,
+                params=database_params,
+                has_display_name=True,
+            ),
+            JumpSQL(
+                sql=f"""
+                WITH allowed_tables AS (
+                    {table_sql}
+                )
+                SELECT
+                    CASE WHEN catalog_views.view_name IS NULL THEN 'table' ELSE 'view' END AS type,
+                    allowed_tables.parent || ': ' || allowed_tables.child AS label,
+                    CASE WHEN catalog_views.view_name IS NULL THEN 'Table' ELSE 'View' END AS description,
+                    NULL AS url,
+                    allowed_tables.parent AS database_name,
+                    allowed_tables.child AS resource_name,
+                    allowed_tables.parent || ' ' || allowed_tables.child AS search_text,
+                    CASE WHEN catalog_views.view_name IS NULL THEN 20 ELSE 25 END AS sort_key,
+                    'datasette' AS source,
+                    NULL AS display_name
+                FROM allowed_tables
+                LEFT JOIN catalog_views
+                    ON catalog_views.database_name = allowed_tables.parent
+                   AND catalog_views.view_name = allowed_tables.child
+                """,
+                params=table_params,
+                has_display_name=True,
+            ),
+            JumpSQL(
+                sql=f"""
+                WITH allowed_queries AS (
+                    {query_sql}
+                ),
+                query_display_names AS (
+                    {query_display_names_sql}
+                )
+                SELECT
+                    'query' AS type,
+                    allowed_queries.parent || ': ' || allowed_queries.child AS label,
+                    'Canned query' AS description,
+                    NULL AS url,
+                    allowed_queries.parent AS database_name,
+                    allowed_queries.child AS resource_name,
+                    allowed_queries.parent || ' ' || allowed_queries.child || ' ' || COALESCE(query_display_names.display_name, '') AS search_text,
+                    30 AS sort_key,
+                    'datasette' AS source,
+                    query_display_names.display_name AS display_name
+                FROM allowed_queries
+                LEFT JOIN query_display_names
+                    ON query_display_names.database_name = allowed_queries.parent
+                   AND query_display_names.query_name = allowed_queries.child
+                """,
+                params={**query_params, **query_display_names_params},
+                has_display_name=True,
+            ),
+        ]
 
-        # Build query based on whether we have a search query
-        if q:
-            # Build SQL LIKE pattern from search terms
-            # Split search terms by whitespace and build pattern: %term1%term2%term3%
-            terms = q.split()
-            pattern = "%" + "%".join(terms) + "%"
+    async def _plugin_fragments(self, request):
+        fragments = []
+        for hook in pm.hook.jump_items_sql(
+            datasette=self.ds,
+            actor=request.actor,
+            request=request,
+        ):
+            value = await await_me_maybe(hook)
+            if value is None:
+                continue
+            if isinstance(value, JumpSQL):
+                fragments.append(value)
+            elif isinstance(value, (list, tuple)):
+                for fragment in value:
+                    if fragment is not None:
+                        assert isinstance(
+                            fragment, JumpSQL
+                        ), "jump_items_sql must return JumpSQL instances"
+                        fragments.append(fragment)
+            else:
+                raise TypeError("jump_items_sql must return JumpSQL instances")
+        return fragments
 
-            # Build query with CTE to filter by search pattern
-            sql = f"""
-            WITH allowed_tables AS (
-                {permission_sql}
+    def _url_for_row(self, row):
+        if row["url"]:
+            return row["url"]
+        if row["type"] == "database":
+            return self.ds.urls.database(row["database_name"])
+        if row["type"] in ("table", "view"):
+            return self.ds.urls.table(row["database_name"], row["resource_name"])
+        if row["type"] == "query":
+            return self.ds.urls.query(row["database_name"], row["resource_name"])
+        return ""
+
+    async def get(self, request):
+        q = request.args.get("q", "").strip()
+        terms = q.split()
+        pattern = "%" + "%".join(terms) + "%" if terms else "%"
+        fragments = await self._core_fragments(request)
+        fragments.extend(await self._plugin_fragments(request))
+
+        union_parts = []
+        all_params = {"q": q, "pattern": pattern}
+        for index, fragment in enumerate(fragments):
+            fragment_sql, fragment_params = namespace_sql_params(
+                fragment.sql,
+                fragment.params or {},
+                f"jump_{index}",
             )
-            SELECT parent, child
-            FROM allowed_tables
-            WHERE child LIKE :pattern COLLATE NOCASE
-            ORDER BY length(child), child
-            """
-            all_params = {**params, "pattern": pattern}
-        else:
-            # No search query - return all tables, ordered by name
-            # Fetch 101 to detect if we need to truncate
-            sql = f"""
-            WITH allowed_tables AS (
-                {permission_sql}
-            )
-            SELECT parent, child
-            FROM allowed_tables
-            ORDER BY parent, child
-            LIMIT 101
-            """
-            all_params = params
+            union_parts.append(f"""
+                SELECT
+                    type,
+                    label,
+                    description,
+                    url,
+                    database_name,
+                    resource_name,
+                    search_text,
+                    sort_key,
+                    source,
+                    {"display_name" if fragment.has_display_name else "NULL AS display_name"}
+                FROM (
+                    {fragment_sql}
+                )
+            """)
+            all_params.update(fragment_params)
 
-        # Execute against internal database
+        sql = f"""
+        WITH jump_items AS (
+            {" UNION ALL ".join(union_parts)}
+        )
+        SELECT *
+        FROM jump_items
+        WHERE :q = ''
+           OR search_text LIKE :pattern COLLATE NOCASE
+        ORDER BY
+            CASE
+                WHEN lower(COALESCE(display_name, label)) = lower(:q) THEN 0
+                WHEN lower(COALESCE(display_name, label)) LIKE lower(:q || '%') THEN 1
+                ELSE 2
+            END,
+            sort_key,
+            length(COALESCE(display_name, label)),
+            label
+        LIMIT 101
+        """
         result = await self.ds.get_internal_database().execute(sql, all_params)
-
-        # Build response with truncation
         rows = list(result.rows)
         truncated = len(rows) > 100
         if truncated:
             rows = rows[:100]
 
-        matches = [
-            {
-                "name": f"{row['parent']}: {row['child']}",
-                "url": self.ds.urls.table(row["parent"], row["child"]),
+        matches = []
+        for row in rows:
+            match = {
+                "name": row["label"],
+                "url": self._url_for_row(row),
+                "type": row["type"],
+                "description": row["description"],
             }
-            for row in rows
-        ]
+            if row["display_name"]:
+                match["display_name"] = row["display_name"]
+            matches.append(match)
 
         return Response.json({"matches": matches, "truncated": truncated})
 
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 19c6bffb..9f0358ac 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -144,46 +144,65 @@ Shows currently attached databases. `Databases example <https://latest.datasette
         }
     ]
 
-.. _TablesView:
+.. _JumpView:
 
-/-/tables
----------
+/-/jump
+-------
 
-Returns a JSON list of all tables that the current actor has permission to view. This endpoint uses the resource-based permission system and respects database and table-level access controls.
+Returns a JSON list of items that the current actor has permission to view for Datasette's jump menu. By default this includes visible databases, tables, views and canned queries, and plugins can contribute additional items.
 
-The endpoint supports a ``?q=`` query parameter for filtering tables by name using case-insensitive regex matching.
+The endpoint supports a ``?q=`` query parameter for filtering items by name.
+Canned queries with a configured ``title`` also include a ``display_name`` in
+their results, and can be found by searching for that title. Plugins can provide
+the same extra field from ``jump_items_sql`` by returning a ``display_name``
+column and setting ``JumpSQL(..., has_display_name=True)``.
 
-`Tables example <https://latest.datasette.io/-/tables>`_:
+`Jump example <https://latest.datasette.io/-/jump>`_:
 
 .. code-block:: json
 
     {
         "matches": [
             {
-                "name": "fixtures/facetable",
-                "url": "/fixtures/facetable"
+                "name": "fixtures",
+                "url": "/fixtures",
+                "type": "database",
+                "description": "Database"
             },
             {
-                "name": "fixtures/searchable",
-                "url": "/fixtures/searchable"
+                "name": "fixtures: facetable",
+                "url": "/fixtures/facetable",
+                "type": "table",
+                "description": "Table"
+            },
+            {
+                "name": "fixtures: recent_releases",
+                "display_name": "Recent Datasette releases",
+                "url": "/fixtures/recent_releases",
+                "type": "query",
+                "description": "Canned query"
             }
-        ]
+        ],
+        "truncated": false
     }
 
-Search example with ``?q=facet`` returns only tables matching ``.*facet.*``:
+Search example with ``?q=facet`` returns only items matching ``.*facet.*``:
 
 .. code-block:: json
 
     {
         "matches": [
             {
-                "name": "fixtures/facetable",
-                "url": "/fixtures/facetable"
+                "name": "fixtures: facetable",
+                "url": "/fixtures/facetable",
+                "type": "table",
+                "description": "Table"
             }
-        ]
+        ],
+        "truncated": false
     }
 
-When multiple search terms are provided (e.g., ``?q=user+profile``), tables must match the pattern ``.*user.*profile.*``. Results are ordered by shortest table name first.
+When multiple search terms are provided (e.g., ``?q=user+profile``), items must match the pattern ``.*user.*profile.*``. Results are ordered by relevance, then by item type and shortest display name.
 
 .. _JsonDataView_threads:
 
diff --git a/tests/test_allowed_resources.py b/tests/test_allowed_resources.py
index 08adbe48..8048ae2c 100644
--- a/tests/test_allowed_resources.py
+++ b/tests/test_allowed_resources.py
@@ -52,7 +52,7 @@ async def test_ds():
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_global_access(test_ds):
-    """Test /-/tables with global access permissions"""
+    """Test allowed_resources() with global access permissions"""
 
     def rules_callback(datasette, actor, action):
         if actor and actor.get("id") == "alice":
@@ -91,7 +91,7 @@ async def test_tables_endpoint_global_access(test_ds):
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_database_restriction(test_ds):
-    """Test /-/tables with database-level restriction"""
+    """Test allowed_resources() with database-level restriction"""
 
     def rules_callback(datasette, actor, action):
         if actor and actor.get("role") == "analyst":
@@ -133,7 +133,7 @@ async def test_tables_endpoint_database_restriction(test_ds):
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_table_exception(test_ds):
-    """Test /-/tables with table-level exception (deny database, allow specific table)"""
+    """Test allowed_resources() with table-level exception (deny database, allow specific table)"""
 
     def rules_callback(datasette, actor, action):
         if actor and actor.get("id") == "carol":
@@ -217,7 +217,7 @@ async def test_tables_endpoint_deny_overrides_allow(test_ds):
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_no_permissions():
-    """Test /-/tables when user has no custom permissions (only defaults)"""
+    """Test allowed_resources() when user has no custom permissions (only defaults)"""
 
     ds = Datasette()
     await ds.invoke_startup()
@@ -241,7 +241,7 @@ async def test_tables_endpoint_no_permissions():
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_specific_table_only(test_ds):
-    """Test /-/tables when only specific tables are allowed (no parent/global rules)"""
+    """Test allowed_resources() when only specific tables are allowed (no parent/global rules)"""
 
     def rules_callback(datasette, actor, action):
         if actor and actor.get("id") == "dave":
@@ -283,7 +283,7 @@ async def test_tables_endpoint_specific_table_only(test_ds):
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_empty_result(test_ds):
-    """Test /-/tables when all tables are explicitly denied"""
+    """Test allowed_resources() when all tables are explicitly denied"""
 
     def rules_callback(datasette, actor, action):
         if actor and actor.get("id") == "blocked":
@@ -314,7 +314,7 @@ async def test_tables_endpoint_empty_result(test_ds):
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_no_query_returns_all():
-    """Test /-/tables without query parameter returns all tables"""
+    """Test allowed_resources() without query parameter returns all tables"""
     ds = Datasette()
     await ds.invoke_startup()
 
@@ -338,7 +338,7 @@ async def test_tables_endpoint_no_query_returns_all():
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_truncation():
-    """Test /-/tables truncates at 100 tables and sets truncated flag"""
+    """Test allowed_resources() truncates at 100 tables and sets truncated flag"""
     ds = Datasette()
     await ds.invoke_startup()
 
@@ -359,7 +359,7 @@ async def test_tables_endpoint_truncation():
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_search_single_term():
-    """Test /-/tables?q=user to filter tables matching 'user'"""
+    """Test allowed_resources()?q=user to filter tables matching 'user'"""
 
     ds = Datasette()
     await ds.invoke_startup()
@@ -396,7 +396,7 @@ async def test_tables_endpoint_search_single_term():
 
 @pytest.mark.asyncio
 async def test_tables_endpoint_search_multiple_terms():
-    """Test /-/tables?q=user+profile to filter tables matching .*user.*profile.*"""
+    """Test allowed_resources()?q=user+profile to filter tables matching .*user.*profile.*"""
 
     ds = Datasette()
     await ds.invoke_startup()
diff --git a/tests/test_html.py b/tests/test_html.py
index 64b4075a..ac77f10f 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -1019,6 +1019,13 @@ async def test_navigation_menu_links(
         search_button.find("kbd")["title"]
         == "Keyboard shortcut: press / to open Jump to"
     )
+    navigation_search_script = soup.find(
+        "script", {"src": re.compile(r"navigation-search\.js")}
+    )
+    assert navigation_search_script["src"] == (
+        "/-/static/navigation-search.js?"
+        + ds_client.ds.static_hash("navigation-search.js")
+    )
     assert details.find("li").find("button") == search_button
     if not actor_id:
         # The app menu is always visible, but anonymous users do not see logout
diff --git a/tests/test_internal_db.py b/tests/test_internal_db.py
index dcf14126..26d63a92 100644
--- a/tests/test_internal_db.py
+++ b/tests/test_internal_db.py
@@ -228,7 +228,7 @@ async def test_orphan_stale_catalog_child_entries_removed(tmp_path):
         """)
     assert [tuple(row) for row in catalog_tables.rows] == [("alpha", "alpha_table")]
 
-    response = await ds2.client.get("/-/tables.json")
+    response = await ds2.client.get("/-/jump.json")
     assert response.status_code == 200
 
     ds2.close()
diff --git a/tests/test_internals_datasette_client.py b/tests/test_internals_datasette_client.py
index ccac280b..543077a5 100644
--- a/tests/test_internals_datasette_client.py
+++ b/tests/test_internals_datasette_client.py
@@ -195,7 +195,7 @@ async def test_skip_permission_checks_with_admin_actor(datasette_with_permission
 
 @pytest.mark.asyncio
 async def test_skip_permission_checks_shows_denied_tables():
-    """Test that skip_permission_checks=True shows tables from denied databases in /-/tables.json"""
+    """Test that skip_permission_checks=True shows tables from denied databases in /-/jump.json"""
     ds = Datasette(
         config={
             "databases": {
@@ -211,8 +211,8 @@ async def test_skip_permission_checks_shows_denied_tables():
     await db.execute_write("INSERT INTO test_table (id, name) VALUES (1, 'Alice')")
     await ds._refresh_schemas()
 
-    # Without skip_permission_checks, tables from denied database should not appear in /-/tables.json
-    response = await ds.client.get("/-/tables.json")
+    # Without skip_permission_checks, tables from denied database should not appear in /-/jump.json
+    response = await ds.client.get("/-/jump.json")
     assert response.status_code == 200
     data = response.json()
     table_names = [match["name"] for match in data["matches"]]
@@ -221,7 +221,7 @@ async def test_skip_permission_checks_shows_denied_tables():
     assert len(fixtures_tables) == 0
 
     # With skip_permission_checks=True, tables from denied database SHOULD appear
-    response = await ds.client.get("/-/tables.json", skip_permission_checks=True)
+    response = await ds.client.get("/-/jump.json", skip_permission_checks=True)
     assert response.status_code == 200
     data = response.json()
     table_names = [match["name"] for match in data["matches"]]
diff --git a/tests/test_jump.py b/tests/test_jump.py
new file mode 100644
index 00000000..55325b95
--- /dev/null
+++ b/tests/test_jump.py
@@ -0,0 +1,224 @@
+import pytest
+import pytest_asyncio
+from markupsafe import Markup
+
+from datasette import hookimpl
+from datasette.app import Datasette
+from datasette.plugins import pm
+
+
+@pytest_asyncio.fixture
+async def ds_for_jump():
+    ds = Datasette(
+        config={
+            "databases": {
+                "content": {
+                    "allow": {"id": "*"},
+                    "tables": {
+                        "articles": {"allow": {"id": "editor"}},
+                        "comments": {"allow": True},
+                    },
+                    "queries": {
+                        "recent_comments": {
+                            "sql": "select * from comments",
+                            "allow": {"id": "*"},
+                            "title": "Recent comments",
+                        },
+                        "release_notes": {
+                            "sql": "select 1",
+                            "allow": {"id": "*"},
+                            "title": "Recent Datasette releases",
+                        },
+                        "editor_report": {
+                            "sql": "select * from articles",
+                            "allow": {"id": "editor"},
+                        },
+                    },
+                },
+                "private": {
+                    "allow": False,
+                    "queries": {
+                        "private_report": "select 1",
+                    },
+                },
+            }
+        }
+    )
+    await ds.invoke_startup()
+
+    content_db = ds.add_memory_database("jump_test_content", name="content")
+    await content_db.execute_write(
+        "CREATE TABLE IF NOT EXISTS articles (id INTEGER PRIMARY KEY, title TEXT)"
+    )
+    await content_db.execute_write(
+        "CREATE TABLE IF NOT EXISTS comments (id INTEGER PRIMARY KEY, body TEXT)"
+    )
+    await content_db.execute_write(
+        "CREATE TABLE IF NOT EXISTS users (id INTEGER PRIMARY KEY, name TEXT)"
+    )
+    await content_db.execute_write(
+        "CREATE VIEW IF NOT EXISTS comment_summary AS SELECT body FROM comments"
+    )
+
+    private_db = ds.add_memory_database("jump_test_private", name="private")
+    await private_db.execute_write(
+        "CREATE TABLE IF NOT EXISTS secrets (id INTEGER PRIMARY KEY, data TEXT)"
+    )
+
+    public_db = ds.add_memory_database("jump_test_public", name="public")
+    await public_db.execute_write(
+        "CREATE TABLE IF NOT EXISTS articles (id INTEGER PRIMARY KEY, content TEXT)"
+    )
+
+    await ds._refresh_schemas()
+    return ds
+
+
+@pytest.mark.asyncio
+async def test_jump_searches_tables_databases_views_and_canned_queries(ds_for_jump):
+    response = await ds_for_jump.client.get(
+        "/-/jump.json?q=content", actor={"id": "user"}
+    )
+    assert response.status_code == 200
+    data = response.json()
+
+    matches_by_type_and_name = {
+        (match["type"], match["name"]): match for match in data["matches"]
+    }
+    assert ("database", "content") in matches_by_type_and_name
+    assert ("table", "content: comments") in matches_by_type_and_name
+    assert ("view", "content: comment_summary") in matches_by_type_and_name
+    assert ("query", "content: recent_comments") in matches_by_type_and_name
+    assert matches_by_type_and_name[("database", "content")]["url"] == "/content"
+    assert (
+        matches_by_type_and_name[("query", "content: recent_comments")]["display_name"]
+        == "Recent comments"
+    )
+    assert (
+        matches_by_type_and_name[("query", "content: recent_comments")]["url"]
+        == "/content/recent_comments"
+    )
+
+
+@pytest.mark.asyncio
+async def test_jump_searches_and_displays_canned_query_titles(ds_for_jump):
+    response = await ds_for_jump.client.get(
+        "/-/jump.json?q=datasette", actor={"id": "user"}
+    )
+    assert response.status_code == 200
+    data = response.json()
+
+    assert data["matches"] == [
+        {
+            "name": "content: release_notes",
+            "display_name": "Recent Datasette releases",
+            "url": "/content/release_notes",
+            "type": "query",
+            "description": "Canned query",
+        }
+    ]
+
+
+@pytest.mark.asyncio
+async def test_jump_respects_resource_permissions(ds_for_jump):
+    regular = await ds_for_jump.client.get(
+        "/-/jump.json?q=articles", actor={"id": "regular"}
+    )
+    editor = await ds_for_jump.client.get(
+        "/-/jump.json?q=articles", actor={"id": "editor"}
+    )
+    private = await ds_for_jump.client.get(
+        "/-/jump.json?q=secrets", actor={"id": "editor"}
+    )
+
+    assert {match["name"] for match in regular.json()["matches"]} == {
+        "public: articles"
+    }
+    assert {match["name"] for match in editor.json()["matches"]} == {
+        "content: articles",
+        "public: articles",
+    }
+    assert private.json()["matches"] == []
+
+
+@pytest.mark.asyncio
+async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
+    from datasette.jump import JumpSQL
+
+    class JumpPlugin:
+        @hookimpl
+        def jump_items_sql(self, datasette, actor, request):
+            return JumpSQL(
+                sql="""
+                SELECT
+                    'plugin' AS type,
+                    'plugin-dashboard: ' || :actor_id AS label,
+                    'Plugin supplied item' AS description,
+                    '/-/plugin-dashboard' AS url,
+                    NULL AS database_name,
+                    NULL AS resource_name,
+                    'plugin dashboard ' || :actor_id AS search_text,
+                    80 AS sort_key,
+                    'test-plugin' AS source,
+                    'Plugin dashboard for ' || :actor_id AS display_name
+                """,
+                params={"actor_id": actor["id"] if actor else "anonymous"},
+                has_display_name=True,
+            )
+
+    plugin = JumpPlugin()
+    pm.register(plugin, name="test-jump-plugin")
+    try:
+        response = await ds_for_jump.client.get(
+            "/-/jump.json?q=dashboard", actor={"id": "alice"}
+        )
+    finally:
+        pm.unregister(name="test-jump-plugin")
+
+    assert response.status_code == 200
+    plugin_matches = [
+        match for match in response.json()["matches"] if match["type"] == "plugin"
+    ]
+    assert plugin_matches == [
+        {
+            "name": "plugin-dashboard: alice",
+            "display_name": "Plugin dashboard for alice",
+            "url": "/-/plugin-dashboard",
+            "type": "plugin",
+            "description": "Plugin supplied item",
+        }
+    ]
+
+
+@pytest.mark.asyncio
+async def test_jump_start_hook_renders_empty_state_template(ds_for_jump):
+    class JumpStartPlugin:
+        @hookimpl
+        def jump_start(self, datasette, actor, request):
+            if not actor:
+                return None
+            return Markup(
+                '<section class="agent-jump-start">'
+                "<h3>Agent chat</h3>"
+                '<a href="/-/agent/new">Start a new agent chat</a>'
+                "</section>"
+            )
+
+    plugin = JumpStartPlugin()
+    pm.register(plugin, name="test-jump-start-plugin")
+    try:
+        anonymous = await ds_for_jump.client.get("/")
+        authenticated = await ds_for_jump.client.get("/", actor={"id": "alice"})
+    finally:
+        pm.unregister(name="test-jump-start-plugin")
+
+    assert 'url="/-/jump"' in authenticated.text
+    assert "<template data-jump-start>" not in anonymous.text
+    assert "<template data-jump-start>" in authenticated.text
+    assert "Start a new agent chat" in authenticated.text
+
+
+@pytest.mark.asyncio
+async def test_tables_endpoint_removed(ds_for_jump):
+    response = await ds_for_jump.client.get("/-/tables.json")
+    assert response.status_code == 404
diff --git a/tests/test_navigation_search_js.py b/tests/test_navigation_search_js.py
new file mode 100644
index 00000000..3096d9a0
--- /dev/null
+++ b/tests/test_navigation_search_js.py
@@ -0,0 +1,199 @@
+import json
+import subprocess
+import textwrap
+
+
+def test_navigation_search_tracks_and_renders_recent_items():
+    script = textwrap.dedent("""
+        const fs = require("fs");
+        const vm = require("vm");
+
+        class FakeElement {
+          constructor() {
+            this.innerHTML = "";
+            this.value = "";
+            this.dataset = {};
+            this.open = false;
+          }
+          addEventListener() {}
+          close() { this.open = false; }
+          focus() {}
+          querySelector() {
+            return { scrollIntoView() {} };
+          }
+          showModal() { this.open = true; }
+        }
+
+        class FakeShadowRoot {
+          constructor() {
+            this.innerHTML = "";
+            this.dialog = new FakeElement();
+            this.input = new FakeElement();
+            this.results = new FakeElement();
+          }
+          querySelector(selector) {
+            if (selector == "dialog") return this.dialog;
+            if (selector == ".search-input") return this.input;
+            if (selector == ".results-container") return this.results;
+            return new FakeElement();
+          }
+        }
+
+        global.HTMLElement = class {
+          constructor() {
+            this.attributes = {};
+          }
+          attachShadow() {
+            this.shadowRoot = new FakeShadowRoot();
+            return this.shadowRoot;
+          }
+          dispatchEvent() {}
+          getAttribute(name) {
+            return this.attributes[name] || null;
+          }
+          querySelector() {
+            return null;
+          }
+          setAttribute(name, value) {
+            this.attributes[name] = value;
+          }
+        };
+        global.CustomEvent = class {
+          constructor(name, options) {
+            this.name = name;
+            this.options = options;
+          }
+        };
+        global.customElements = {
+          registry: new Map(),
+          define(name, cls) {
+            this.registry.set(name, cls);
+          },
+        };
+        global.document = {
+          addEventListener() {},
+          activeElement: null,
+          createElement() {
+            return {
+              set textContent(value) {
+                this.innerHTML = String(value)
+                  .replace(/&/g, "&amp;")
+                  .replace(/</g, "&lt;")
+                  .replace(/>/g, "&gt;")
+                  .replace(/"/g, "&quot;");
+              },
+            };
+          },
+        };
+        global.localStorage = {
+          store: {},
+          getItem(key) {
+            return Object.prototype.hasOwnProperty.call(this.store, key)
+              ? this.store[key]
+              : null;
+          },
+          setItem(key, value) {
+            this.store[key] = String(value);
+          },
+          removeItem(key) {
+            delete this.store[key];
+          },
+        };
+        global.window = { location: { href: "" } };
+
+        vm.runInThisContext(
+          fs.readFileSync("datasette/static/navigation-search.js", "utf8"),
+          { filename: "navigation-search.js" }
+        );
+
+        const Component = customElements.registry.get("navigation-search");
+        const element = new Component();
+        const items = Array.from({ length: 6 }, (_, index) => ({
+          name: `Item ${index + 1}`,
+          url: `/item-${index + 1}`,
+          type: "table",
+          description: "Table",
+        }));
+        items[5].name = "content: recent_datasette_releases";
+        items[5].display_name = "Recent Datasette releases";
+
+        for (const item of items) {
+          element.matches = [item];
+          element.renderedMatches = [item];
+          element.selectedIndex = 0;
+          element.selectCurrentItem();
+        }
+
+        const stored = JSON.parse(
+          Object.values(localStorage.store).find((value) => value.includes("/item-6"))
+        );
+        if (stored.length !== 5) {
+          throw new Error(`Expected 5 recent items, got ${stored.length}`);
+        }
+        if (stored[0].url !== "/item-6" || stored[4].url !== "/item-2") {
+          throw new Error(`Unexpected recent order: ${JSON.stringify(stored)}`);
+        }
+        if (stored[0].display_name !== "Recent Datasette releases") {
+          throw new Error(`Missing display_name in recent item: ${JSON.stringify(stored[0])}`);
+        }
+
+        element.matches = [
+          items[5],
+          items[4],
+          {
+            name: "Other",
+            url: "/other",
+            type: "database",
+            description: "Database",
+          },
+        ];
+        element.shadowRoot.input.value = "";
+        element.renderResults();
+
+        const html = element.shadowRoot.results.innerHTML;
+        if (!html.includes("Recent")) {
+          throw new Error(`Missing Recent heading: ${html}`);
+        }
+        if (!html.includes("Recent Datasette releases") || !html.includes("Item 5")) {
+          throw new Error(`Missing recent items: ${html}`);
+        }
+        if (!html.includes("content: recent_datasette_releases")) {
+          throw new Error(`Missing canonical item name for display_name item: ${html}`);
+        }
+        if (!html.includes("Item 4") || !html.includes("Item 2")) {
+          throw new Error(`Expected all stored recent items in empty state: ${html}`);
+        }
+        if (html.includes("Other")) {
+          throw new Error(`Rendered non-recent item in empty state: ${html}`);
+        }
+        if (!html.includes("Clear recent")) {
+          throw new Error(`Missing Clear recent control: ${html}`);
+        }
+
+        element.clearRecentItems();
+        if (localStorage.getItem(element.recentItemsStorageKey()) !== null) {
+          throw new Error("Expected recent items to be cleared");
+        }
+        element.renderResults();
+        if (element.shadowRoot.results.innerHTML.includes("Clear recent")) {
+          throw new Error("Clear recent should disappear after clearing");
+        }
+
+        process.stdout.write(JSON.stringify(stored));
+        """)
+    result = subprocess.run(
+        ["node", "-e", script],
+        cwd=".",
+        text=True,
+        capture_output=True,
+        check=False,
+    )
+    assert result.returncode == 0, result.stderr
+    assert [item["url"] for item in json.loads(result.stdout)] == [
+        "/item-6",
+        "/item-5",
+        "/item-4",
+        "/item-3",
+        "/item-2",
+    ]
+    assert json.loads(result.stdout)[0]["display_name"] == "Recent Datasette releases"
diff --git a/tests/test_search_tables.py b/tests/test_search_tables.py
index b901c0b3..ce774327 100644
--- a/tests/test_search_tables.py
+++ b/tests/test_search_tables.py
@@ -33,7 +33,7 @@ async def ds_with_tables():
     await ds.invoke_startup()
 
     # Add content database with some tables
-    content_db = ds.add_memory_database("content")
+    content_db = ds.add_memory_database("search_tables_content", name="content")
     await content_db.execute_write(
         "CREATE TABLE IF NOT EXISTS articles (id INTEGER PRIMARY KEY, title TEXT)"
     )
@@ -45,27 +45,28 @@ async def ds_with_tables():
     )
 
     # Add private database with a table
-    private_db = ds.add_memory_database("private")
+    private_db = ds.add_memory_database("search_tables_private", name="private")
     await private_db.execute_write(
         "CREATE TABLE IF NOT EXISTS secrets (id INTEGER PRIMARY KEY, data TEXT)"
     )
 
     # Add another public database
-    public_db = ds.add_memory_database("public")
+    public_db = ds.add_memory_database("search_tables_public", name="public")
     await public_db.execute_write(
         "CREATE TABLE IF NOT EXISTS articles (id INTEGER PRIMARY KEY, content TEXT)"
     )
+    await ds._refresh_schemas()
 
     return ds
 
 
-# /-/tables.json tests
+# /-/jump.json table search tests
 @pytest.mark.asyncio
 async def test_tables_basic_search(ds_with_tables):
     """Test basic table search functionality."""
     # Search for "articles" - should find it in both content and public databases
     # but only return public.articles for anonymous user (content.articles requires auth)
-    response = await ds_with_tables.client.get("/-/tables.json?q=articles")
+    response = await ds_with_tables.client.get("/-/jump.json?q=articles")
     assert response.status_code == 200
     data = response.json()
 
@@ -85,7 +86,7 @@ async def test_tables_search_with_auth(ds_with_tables):
     """Test that authenticated users see more tables."""
     # Editor user should see content.articles
     response = await ds_with_tables.client.get(
-        "/-/tables.json?q=articles",
+        "/-/jump.json?q=articles",
         actor={"id": "editor"},
     )
     assert response.status_code == 200
@@ -103,7 +104,7 @@ async def test_tables_search_partial_match(ds_with_tables):
     """Test that search matches partial table names."""
     # Search for "com" should match "comments"
     response = await ds_with_tables.client.get(
-        "/-/tables.json?q=com",
+        "/-/jump.json?q=com",
         actor={"id": "user"},
     )
     assert response.status_code == 200
@@ -119,7 +120,7 @@ async def test_tables_search_respects_database_permissions(ds_with_tables):
     # Search for "secrets" which is in the private database
     # Even authenticated users shouldn't see it because database is denied
     response = await ds_with_tables.client.get(
-        "/-/tables.json?q=secrets",
+        "/-/jump.json?q=secrets",
         actor={"id": "user"},
     )
     assert response.status_code == 200
@@ -134,7 +135,7 @@ async def test_tables_search_respects_table_permissions(ds_with_tables):
     """Test that tables with specific permissions are filtered correctly."""
     # Regular authenticated user searching for "users"
     response = await ds_with_tables.client.get(
-        "/-/tables.json?q=users",
+        "/-/jump.json?q=users",
         actor={"id": "regular"},
     )
     assert response.status_code == 200
@@ -149,7 +150,7 @@ async def test_tables_search_respects_table_permissions(ds_with_tables):
 async def test_tables_search_response_structure(ds_with_tables):
     """Test that response has correct structure."""
     response = await ds_with_tables.client.get(
-        "/-/tables.json?q=users",
+        "/-/jump.json?q=users",
         actor={"id": "user"},
     )
     assert response.status_code == 200

From 1000d50220faef339ee688aae9150e83a205be3a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 21 May 2026 23:05:37 -0700
Subject: [PATCH 016/386] datasette.fixtures module, closes #2733

https://gist.github.com/simonw/613be79094d491dd08f45e05f4f70691
---
 datasette/fixtures.py       | 415 ++++++++++++++++++++++++++++++++++++
 datasette/utils/__init__.py |  12 +-
 docs/changelog.rst          |   1 +
 docs/testing_plugins.rst    |  42 ++++
 tests/conftest.py           |   9 +-
 tests/fixtures.py           | 401 ++--------------------------------
 tests/test_docs.py          |  18 +-
 tests/test_fixtures.py      |  49 +++++
 tests/test_plugins.py       |   2 +-
 tests/test_table_api.py     |   3 +-
 10 files changed, 545 insertions(+), 407 deletions(-)
 create mode 100644 datasette/fixtures.py
 create mode 100644 tests/test_fixtures.py

diff --git a/datasette/fixtures.py b/datasette/fixtures.py
new file mode 100644
index 00000000..7c85e16a
--- /dev/null
+++ b/datasette/fixtures.py
@@ -0,0 +1,415 @@
+from datasette.utils.sqlite import sqlite3
+from datasette.utils import documented
+import itertools
+import random
+import string
+
+__all__ = [
+    "EXTRA_DATABASE_SQL",
+    "TABLES",
+    "TABLE_PARAMETERIZED_SQL",
+    "generate_compound_rows",
+    "generate_sortable_rows",
+    "populate_extra_database",
+    "populate_fixture_database",
+    "write_extra_database",
+    "write_fixture_database",
+]
+
+
+def generate_compound_rows(num):
+    """Generate rows for the compound_three_primary_keys fixture table."""
+    for a, b, c in itertools.islice(
+        itertools.product(string.ascii_lowercase, repeat=3), num
+    ):
+        yield a, b, c, f"{a}-{b}-{c}"
+
+
+def generate_sortable_rows(num):
+    """Generate rows for the sortable fixture table."""
+    rand = random.Random(42)
+    for a, b in itertools.islice(
+        itertools.product(string.ascii_lowercase, repeat=2), num
+    ):
+        yield {
+            "pk1": a,
+            "pk2": b,
+            "content": f"{a}-{b}",
+            "sortable": rand.randint(-100, 100),
+            "sortable_with_nulls": rand.choice([None, rand.random(), rand.random()]),
+            "sortable_with_nulls_2": rand.choice([None, rand.random(), rand.random()]),
+            "text": rand.choice(["$null", "$blah"]),
+        }
+
+
+TABLES = (
+    """
+CREATE TABLE simple_primary_key (
+  id integer primary key,
+  content text
+);
+
+CREATE TABLE primary_key_multiple_columns (
+  id varchar(30) primary key,
+  content text,
+  content2 text
+);
+
+CREATE TABLE primary_key_multiple_columns_explicit_label (
+  id varchar(30) primary key,
+  content text,
+  content2 text
+);
+
+CREATE TABLE compound_primary_key (
+  pk1 varchar(30),
+  pk2 varchar(30),
+  content text,
+  PRIMARY KEY (pk1, pk2)
+);
+
+INSERT INTO compound_primary_key VALUES ('a', 'b', 'c');
+INSERT INTO compound_primary_key VALUES ('a/b', '.c-d', 'c');
+INSERT INTO compound_primary_key VALUES ('d', 'e', 'RENDER_CELL_DEMO');
+
+CREATE TABLE compound_three_primary_keys (
+  pk1 varchar(30),
+  pk2 varchar(30),
+  pk3 varchar(30),
+  content text,
+  PRIMARY KEY (pk1, pk2, pk3)
+);
+CREATE INDEX idx_compound_three_primary_keys_content ON compound_three_primary_keys(content);
+
+CREATE TABLE foreign_key_references (
+  pk varchar(30) primary key,
+  foreign_key_with_label integer,
+  foreign_key_with_blank_label integer,
+  foreign_key_with_no_label varchar(30),
+  foreign_key_compound_pk1 varchar(30),
+  foreign_key_compound_pk2 varchar(30),
+  FOREIGN KEY (foreign_key_with_label) REFERENCES simple_primary_key(id),
+  FOREIGN KEY (foreign_key_with_blank_label) REFERENCES simple_primary_key(id),
+  FOREIGN KEY (foreign_key_with_no_label) REFERENCES primary_key_multiple_columns(id)
+  FOREIGN KEY (foreign_key_compound_pk1, foreign_key_compound_pk2) REFERENCES compound_primary_key(pk1, pk2)
+);
+
+CREATE TABLE sortable (
+  pk1 varchar(30),
+  pk2 varchar(30),
+  content text,
+  sortable integer,
+  sortable_with_nulls real,
+  sortable_with_nulls_2 real,
+  text text,
+  PRIMARY KEY (pk1, pk2)
+);
+
+CREATE TABLE no_primary_key (
+  content text,
+  a text,
+  b text,
+  c text
+);
+
+CREATE TABLE [123_starts_with_digits] (
+  content text
+);
+
+CREATE VIEW paginated_view AS
+    SELECT
+        content,
+        '- ' || content || ' -' AS content_extra
+    FROM no_primary_key;
+
+CREATE TABLE "Table With Space In Name" (
+  pk varchar(30) primary key,
+  content text
+);
+
+CREATE TABLE "table/with/slashes.csv" (
+  pk varchar(30) primary key,
+  content text
+);
+
+CREATE TABLE "complex_foreign_keys" (
+  pk varchar(30) primary key,
+  f1 integer,
+  f2 integer,
+  f3 integer,
+  FOREIGN KEY ("f1") REFERENCES [simple_primary_key](id),
+  FOREIGN KEY ("f2") REFERENCES [simple_primary_key](id),
+  FOREIGN KEY ("f3") REFERENCES [simple_primary_key](id)
+);
+
+CREATE TABLE "custom_foreign_key_label" (
+  pk varchar(30) primary key,
+  foreign_key_with_custom_label text,
+  FOREIGN KEY ("foreign_key_with_custom_label") REFERENCES [primary_key_multiple_columns_explicit_label](id)
+);
+
+CREATE TABLE tags (
+    tag TEXT PRIMARY KEY
+);
+
+CREATE TABLE searchable (
+  pk integer primary key,
+  text1 text,
+  text2 text,
+  [name with . and spaces] text
+);
+
+CREATE TABLE searchable_tags (
+    searchable_id integer,
+    tag text,
+    PRIMARY KEY (searchable_id, tag),
+    FOREIGN KEY (searchable_id) REFERENCES searchable(pk),
+    FOREIGN KEY (tag) REFERENCES tags(tag)
+);
+
+INSERT INTO searchable VALUES (1, 'barry cat', 'terry dog', 'panther');
+INSERT INTO searchable VALUES (2, 'terry dog', 'sara weasel', 'puma');
+
+INSERT INTO tags VALUES ("canine");
+INSERT INTO tags VALUES ("feline");
+
+INSERT INTO searchable_tags (searchable_id, tag) VALUES
+    (1, "feline"),
+    (2, "canine")
+;
+
+CREATE VIRTUAL TABLE "searchable_fts"
+    USING FTS5 (text1, text2, [name with . and spaces], content="searchable", content_rowid="pk");
+INSERT INTO "searchable_fts" (searchable_fts) VALUES ('rebuild');
+
+CREATE TABLE [select] (
+  [group] text,
+  [having] text,
+  [and] text,
+  [json] text
+);
+INSERT INTO [select] VALUES ('group', 'having', 'and',
+    '{"href": "http://example.com/", "label":"Example"}'
+);
+
+CREATE TABLE infinity (
+    value REAL
+);
+INSERT INTO infinity VALUES
+    (1e999),
+    (-1e999),
+    (1.5)
+;
+
+CREATE TABLE facet_cities (
+    id integer primary key,
+    name text
+);
+INSERT INTO facet_cities (id, name) VALUES
+    (1, 'San Francisco'),
+    (2, 'Los Angeles'),
+    (3, 'Detroit'),
+    (4, 'Memnonia')
+;
+
+CREATE TABLE facetable (
+    pk integer primary key,
+    created text,
+    planet_int integer,
+    on_earth integer,
+    state text,
+    _city_id integer,
+    _neighborhood text,
+    tags text,
+    complex_array text,
+    distinct_some_null,
+    n text,
+    FOREIGN KEY ("_city_id") REFERENCES [facet_cities](id)
+);
+INSERT INTO facetable
+    (created, planet_int, on_earth, state, _city_id, _neighborhood, tags, complex_array, distinct_some_null, n)
+VALUES
+    ("2019-01-14 08:00:00", 1, 1, 'CA', 1, 'Mission', '["tag1", "tag2"]', '[{"foo": "bar"}]', 'one', 'n1'),
+    ("2019-01-14 08:00:00", 1, 1, 'CA', 1, 'Dogpatch', '["tag1", "tag3"]', '[]', 'two', 'n2'),
+    ("2019-01-14 08:00:00", 1, 1, 'CA', 1, 'SOMA', '[]', '[]', null, null),
+    ("2019-01-14 08:00:00", 1, 1, 'CA', 1, 'Tenderloin', '[]', '[]', null, null),
+    ("2019-01-15 08:00:00", 1, 1, 'CA', 1, 'Bernal Heights', '[]', '[]', null, null),
+    ("2019-01-15 08:00:00", 1, 1, 'CA', 1, 'Hayes Valley', '[]', '[]', null, null),
+    ("2019-01-15 08:00:00", 1, 1, 'CA', 2, 'Hollywood', '[]', '[]', null, null),
+    ("2019-01-15 08:00:00", 1, 1, 'CA', 2, 'Downtown', '[]', '[]', null, null),
+    ("2019-01-16 08:00:00", 1, 1, 'CA', 2, 'Los Feliz', '[]', '[]', null, null),
+    ("2019-01-16 08:00:00", 1, 1, 'CA', 2, 'Koreatown', '[]', '[]', null, null),
+    ("2019-01-16 08:00:00", 1, 1, 'MI', 3, 'Downtown', '[]', '[]', null, null),
+    ("2019-01-17 08:00:00", 1, 1, 'MI', 3, 'Greektown', '[]', '[]', null, null),
+    ("2019-01-17 08:00:00", 1, 1, 'MI', 3, 'Corktown', '[]', '[]', null, null),
+    ("2019-01-17 08:00:00", 1, 1, 'MI', 3, 'Mexicantown', '[]', '[]', null, null),
+    ("2019-01-17 08:00:00", 2, 0, 'MC', 4, 'Arcadia Planitia', '[]', '[]', null, null)
+;
+
+CREATE TABLE binary_data (
+    data BLOB
+);
+
+-- Many 2 Many demo: roadside attractions!
+
+CREATE TABLE roadside_attractions (
+    pk integer primary key,
+    name text,
+    address text,
+    url text,
+    latitude real,
+    longitude real
+);
+INSERT INTO roadside_attractions VALUES (
+    1, "The Mystery Spot", "465 Mystery Spot Road, Santa Cruz, CA 95065", "https://www.mysteryspot.com/",
+    37.0167, -122.0024
+);
+INSERT INTO roadside_attractions VALUES (
+    2, "Winchester Mystery House", "525 South Winchester Boulevard, San Jose, CA 95128", "https://winchestermysteryhouse.com/",
+    37.3184, -121.9511
+);
+INSERT INTO roadside_attractions VALUES (
+    3, "Burlingame Museum of PEZ Memorabilia", "214 California Drive, Burlingame, CA 94010", null,
+    37.5793, -122.3442
+);
+INSERT INTO roadside_attractions VALUES (
+    4, "Bigfoot Discovery Museum", "5497 Highway 9, Felton, CA 95018", "https://www.bigfootdiscoveryproject.com/",
+    37.0414, -122.0725
+);
+
+CREATE TABLE attraction_characteristic (
+    pk integer primary key,
+    name text
+);
+INSERT INTO attraction_characteristic VALUES (
+    1, "Museum"
+);
+INSERT INTO attraction_characteristic VALUES (
+    2, "Paranormal"
+);
+
+CREATE TABLE roadside_attraction_characteristics (
+    attraction_id INTEGER REFERENCES roadside_attractions(pk),
+    characteristic_id INTEGER REFERENCES attraction_characteristic(pk)
+);
+INSERT INTO roadside_attraction_characteristics VALUES (
+    1, 2
+);
+INSERT INTO roadside_attraction_characteristics VALUES (
+    2, 2
+);
+INSERT INTO roadside_attraction_characteristics VALUES (
+    4, 2
+);
+INSERT INTO roadside_attraction_characteristics VALUES (
+    3, 1
+);
+INSERT INTO roadside_attraction_characteristics VALUES (
+    4, 1
+);
+
+INSERT INTO simple_primary_key VALUES (1, 'hello');
+INSERT INTO simple_primary_key VALUES (2, 'world');
+INSERT INTO simple_primary_key VALUES (3, '');
+INSERT INTO simple_primary_key VALUES (4, 'RENDER_CELL_DEMO');
+INSERT INTO simple_primary_key VALUES (5, 'RENDER_CELL_ASYNC');
+
+INSERT INTO primary_key_multiple_columns VALUES (1, 'hey', 'world');
+INSERT INTO primary_key_multiple_columns_explicit_label VALUES (1, 'hey', 'world2');
+
+INSERT INTO foreign_key_references VALUES (1, 1, 3, 1, 'a', 'b');
+INSERT INTO foreign_key_references VALUES (2, null, null, null, null, null);
+
+INSERT INTO complex_foreign_keys VALUES (1, 1, 2, 1);
+INSERT INTO custom_foreign_key_label VALUES (1, 1);
+
+INSERT INTO [table/with/slashes.csv] VALUES (3, 'hey');
+
+CREATE VIEW simple_view AS
+    SELECT content, upper(content) AS upper_content FROM simple_primary_key;
+
+CREATE VIEW searchable_view AS
+    SELECT * from searchable;
+
+CREATE VIEW searchable_view_configured_by_metadata AS
+    SELECT * from searchable;
+
+"""
+    + "\n".join(
+        [
+            'INSERT INTO no_primary_key VALUES ({i}, "a{i}", "b{i}", "c{i}");'.format(
+                i=i + 1
+            )
+            for i in range(201)
+        ]
+    )
+    + '\nINSERT INTO no_primary_key VALUES ("RENDER_CELL_DEMO", "a202", "b202", "c202");\n'
+    + "\n".join(
+        [
+            'INSERT INTO compound_three_primary_keys VALUES ("{a}", "{b}", "{c}", "{content}");'.format(
+                a=a, b=b, c=c, content=content
+            )
+            for a, b, c, content in generate_compound_rows(1001)
+        ]
+    )
+    + "\n".join(["""INSERT INTO sortable VALUES (
+        "{pk1}", "{pk2}", "{content}", {sortable},
+        {sortable_with_nulls}, {sortable_with_nulls_2}, "{text}");
+    """.format(**row).replace("None", "null") for row in generate_sortable_rows(201)])
+)
+
+TABLE_PARAMETERIZED_SQL = [
+    ("insert into binary_data (data) values (?);", [b"\x15\x1c\x02\xc7\xad\x05\xfe"]),
+    ("insert into binary_data (data) values (?);", [b"\x15\x1c\x03\xc7\xad\x05\xfe"]),
+    ("insert into binary_data (data) values (null);", []),
+]
+
+EXTRA_DATABASE_SQL = """
+CREATE TABLE searchable (
+  pk integer primary key,
+  text1 text,
+  text2 text
+);
+
+CREATE VIEW searchable_view AS SELECT * FROM searchable;
+
+INSERT INTO searchable VALUES (1, 'barry cat', 'terry dog');
+INSERT INTO searchable VALUES (2, 'terry dog', 'sara weasel');
+
+CREATE VIRTUAL TABLE "searchable_fts"
+    USING FTS3 (text1, text2, content="searchable");
+INSERT INTO "searchable_fts" (rowid, text1, text2)
+    SELECT rowid, text1, text2 FROM searchable;
+"""
+
+
+@documented(label="datasette_fixtures_populate_fixture_database")
+def populate_fixture_database(conn):
+    """Populate a SQLite connection with Datasette's test fixture tables."""
+    conn.executescript(TABLES)
+    for sql, params in TABLE_PARAMETERIZED_SQL:
+        with conn:
+            conn.execute(sql, params)
+
+
+def populate_extra_database(conn):
+    """Populate a SQLite connection with the extra database used in tests."""
+    conn.executescript(EXTRA_DATABASE_SQL)
+
+
+def write_fixture_database(db_filename):
+    """Write Datasette's test fixture tables to a SQLite database file."""
+    conn = sqlite3.connect(db_filename)
+    try:
+        populate_fixture_database(conn)
+    finally:
+        conn.close()
+
+
+def write_extra_database(db_filename):
+    """Write the extra test database tables to a SQLite database file."""
+    conn = sqlite3.connect(db_filename)
+    try:
+        populate_extra_database(conn)
+    finally:
+        conn.close()
diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 1fea992e..9d189459 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -155,9 +155,15 @@ Column = namedtuple(
 functions_marked_as_documented = []
 
 
-def documented(fn):
-    functions_marked_as_documented.append(fn)
-    return fn
+def documented(fn=None, *, label=None):
+    def decorate(fn):
+        fn._datasette_docs_label = label or "internals_utils_{}".format(fn.__name__)
+        functions_marked_as_documented.append(fn)
+        return fn
+
+    if fn is None:
+        return decorate
+    return decorate(fn)
 
 
 @documented
diff --git a/docs/changelog.rst b/docs/changelog.rst
index f2ba23ec..51188461 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -13,6 +13,7 @@ Unreleased
 - Fixed a bug where stale tables and other related resources were not removed from ``catalog_*`` tables when a database was removed. (:issue:`2723`)
 - Fixed a Safari bug with the table search mechanism triggered by pressing ``/``. (:issue:`2724`)
 - New "Jump to..." menu item, always visible, for triggering the previously undocumented ``/`` menu. (:issue:`2725`)
+- New documented :ref:`datasette.fixtures.populate_fixture_database(conn) <datasette_fixtures_populate_fixture_database>` helper for creating the fixture database tables used by Datasette's own tests, intended for plugin test suites.
 
 .. _v1_0_a29:
 
diff --git a/docs/testing_plugins.rst b/docs/testing_plugins.rst
index b82a6e0c..15891963 100644
--- a/docs/testing_plugins.rst
+++ b/docs/testing_plugins.rst
@@ -82,6 +82,48 @@ This method registers any :ref:`plugin_hook_startup` or :ref:`plugin_hook_prepar
 
 If you are using ``await datasette.client.get()`` and similar methods then you don't need to worry about this - Datasette automatically calls ``invoke_startup()`` the first time it handles a request.
 
+.. _testing_plugins_datasette_fixtures_database:
+
+Using Datasette's fixtures database
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Datasette's own test suite uses a SQLite database with tables that exercise features such as compound primary keys, foreign keys, sortable columns, facets, full-text search and binary data.
+
+You can use those same tables in your plugin tests using the ``populate_fixture_database(conn)`` helper in ``datasette.fixtures``:
+
+Be aware that future Datasette releases may change details of these tables, so try not to rely on their exact structure in your own tests.
+
+.. _datasette_fixtures_populate_fixture_database:
+
+``populate_fixture_database(conn)``
+    Populates an existing SQLite connection with the fixture tables.
+
+For an in-memory test database:
+
+.. code-block:: python
+
+    from datasette.app import Datasette
+    from datasette.fixtures import populate_fixture_database
+    import pytest
+    import pytest_asyncio
+
+
+    @pytest_asyncio.fixture
+    async def datasette():
+        datasette = Datasette()
+        db = datasette.add_memory_database("fixtures")
+        await db.execute_write_fn(populate_fixture_database)
+        await datasette.invoke_startup()
+        return datasette
+
+
+    @pytest.mark.asyncio
+    async def test_facetable(datasette):
+        response = await datasette.client.get(
+            "/fixtures/facetable.json?_shape=array"
+        )
+        assert response.status_code == 200
+
 .. _testing_plugins_autoclose:
 
 Automatic cleanup of Datasette instances
diff --git a/tests/conftest.py b/tests/conftest.py
index 4ea89458..b9b3c35e 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -72,7 +72,7 @@ async def ds_client():
             "num_sql_threads": 1,
         },
     )
-    from .fixtures import TABLES, TABLE_PARAMETERIZED_SQL
+    from datasette.fixtures import populate_fixture_database
 
     # Use a unique memory_name to avoid collisions between different
     # Datasette instances in the same process, but use "fixtures" for routing
@@ -82,10 +82,7 @@ async def ds_client():
 
     def prepare(conn):
         if not conn.execute("select count(*) from sqlite_master").fetchone()[0]:
-            conn.executescript(TABLES)
-            for sql, params in TABLE_PARAMETERIZED_SQL:
-                with conn:
-                    conn.execute(sql, params)
+            populate_fixture_database(conn)
 
     await db.execute_write_fn(prepare)
     await ds.invoke_startup()
@@ -264,8 +261,6 @@ from .fixtures import (  # noqa: E402, F401
     app_client_with_cors,
     app_client_with_dot,
     app_client_with_trace,
-    generate_compound_rows,
-    generate_sortable_rows,
     make_app_client,
     TEMP_PLUGIN_SECRET_FILE,
 )
diff --git a/tests/fixtures.py b/tests/fixtures.py
index f61ec0c7..71884294 100644
--- a/tests/fixtures.py
+++ b/tests/fixtures.py
@@ -1,15 +1,16 @@
 from datasette.app import Datasette
-from datasette.utils.sqlite import sqlite3
+from datasette.fixtures import (
+    EXTRA_DATABASE_SQL,
+    write_extra_database,
+    write_fixture_database,
+)
 from datasette.utils.testing import TestClient
 import click
 import contextlib
-import itertools
 import json
 import os
 import pathlib
 import pytest
-import random
-import string
 import tempfile
 import textwrap
 
@@ -128,19 +129,18 @@ def make_app_client(
         else:
             files = [filepath]
             immutables = []
-        conn = sqlite3.connect(filepath)
-        conn.executescript(TABLES)
-        for sql, params in TABLE_PARAMETERIZED_SQL:
-            with conn:
-                conn.execute(sql, params)
-        # Close the connection to avoid "too many open files" errors
-        conn.close()
+        write_fixture_database(filepath)
         if extra_databases is not None:
             for extra_filename, extra_sql in extra_databases.items():
                 extra_filepath = os.path.join(tmpdir, extra_filename)
-                c2 = sqlite3.connect(extra_filepath)
-                c2.executescript(extra_sql)
-                c2.close()
+                if extra_sql == EXTRA_DATABASE_SQL:
+                    write_extra_database(extra_filepath)
+                else:
+                    from datasette.utils.sqlite import sqlite3
+
+                    c2 = sqlite3.connect(extra_filepath)
+                    c2.executescript(extra_sql)
+                    c2.close()
                 # Insert at start to help test /-/databases ordering:
                 files.insert(0, extra_filepath)
         os.chdir(os.path.dirname(filepath))
@@ -279,29 +279,6 @@ def app_client_immutable_and_inspect_file():
         yield client
 
 
-def generate_compound_rows(num):
-    for a, b, c in itertools.islice(
-        itertools.product(string.ascii_lowercase, repeat=3), num
-    ):
-        yield a, b, c, f"{a}-{b}-{c}"
-
-
-def generate_sortable_rows(num):
-    rand = random.Random(42)
-    for a, b in itertools.islice(
-        itertools.product(string.ascii_lowercase, repeat=2), num
-    ):
-        yield {
-            "pk1": a,
-            "pk2": b,
-            "content": f"{a}-{b}",
-            "sortable": rand.randint(-100, 100),
-            "sortable_with_nulls": rand.choice([None, rand.random(), rand.random()]),
-            "sortable_with_nulls_2": rand.choice([None, rand.random(), rand.random()]),
-            "text": rand.choice(["$null", "$blah"]),
-        }
-
-
 CONFIG = {
     "plugins": {
         "name-of-plugin": {"depth": "root"},
@@ -399,345 +376,6 @@ METADATA = {
     },
 }
 
-TABLES = (
-    """
-CREATE TABLE simple_primary_key (
-  id integer primary key,
-  content text
-);
-
-CREATE TABLE primary_key_multiple_columns (
-  id varchar(30) primary key,
-  content text,
-  content2 text
-);
-
-CREATE TABLE primary_key_multiple_columns_explicit_label (
-  id varchar(30) primary key,
-  content text,
-  content2 text
-);
-
-CREATE TABLE compound_primary_key (
-  pk1 varchar(30),
-  pk2 varchar(30),
-  content text,
-  PRIMARY KEY (pk1, pk2)
-);
-
-INSERT INTO compound_primary_key VALUES ('a', 'b', 'c');
-INSERT INTO compound_primary_key VALUES ('a/b', '.c-d', 'c');
-INSERT INTO compound_primary_key VALUES ('d', 'e', 'RENDER_CELL_DEMO');
-
-CREATE TABLE compound_three_primary_keys (
-  pk1 varchar(30),
-  pk2 varchar(30),
-  pk3 varchar(30),
-  content text,
-  PRIMARY KEY (pk1, pk2, pk3)
-);
-CREATE INDEX idx_compound_three_primary_keys_content ON compound_three_primary_keys(content);
-
-CREATE TABLE foreign_key_references (
-  pk varchar(30) primary key,
-  foreign_key_with_label integer,
-  foreign_key_with_blank_label integer,
-  foreign_key_with_no_label varchar(30),
-  foreign_key_compound_pk1 varchar(30),
-  foreign_key_compound_pk2 varchar(30),
-  FOREIGN KEY (foreign_key_with_label) REFERENCES simple_primary_key(id),
-  FOREIGN KEY (foreign_key_with_blank_label) REFERENCES simple_primary_key(id),
-  FOREIGN KEY (foreign_key_with_no_label) REFERENCES primary_key_multiple_columns(id)
-  FOREIGN KEY (foreign_key_compound_pk1, foreign_key_compound_pk2) REFERENCES compound_primary_key(pk1, pk2)
-);
-
-CREATE TABLE sortable (
-  pk1 varchar(30),
-  pk2 varchar(30),
-  content text,
-  sortable integer,
-  sortable_with_nulls real,
-  sortable_with_nulls_2 real,
-  text text,
-  PRIMARY KEY (pk1, pk2)
-);
-
-CREATE TABLE no_primary_key (
-  content text,
-  a text,
-  b text,
-  c text
-);
-
-CREATE TABLE [123_starts_with_digits] (
-  content text
-);
-
-CREATE VIEW paginated_view AS
-    SELECT
-        content,
-        '- ' || content || ' -' AS content_extra
-    FROM no_primary_key;
-
-CREATE TABLE "Table With Space In Name" (
-  pk varchar(30) primary key,
-  content text
-);
-
-CREATE TABLE "table/with/slashes.csv" (
-  pk varchar(30) primary key,
-  content text
-);
-
-CREATE TABLE "complex_foreign_keys" (
-  pk varchar(30) primary key,
-  f1 integer,
-  f2 integer,
-  f3 integer,
-  FOREIGN KEY ("f1") REFERENCES [simple_primary_key](id),
-  FOREIGN KEY ("f2") REFERENCES [simple_primary_key](id),
-  FOREIGN KEY ("f3") REFERENCES [simple_primary_key](id)
-);
-
-CREATE TABLE "custom_foreign_key_label" (
-  pk varchar(30) primary key,
-  foreign_key_with_custom_label text,
-  FOREIGN KEY ("foreign_key_with_custom_label") REFERENCES [primary_key_multiple_columns_explicit_label](id)
-);
-
-CREATE TABLE tags (
-    tag TEXT PRIMARY KEY
-);
-
-CREATE TABLE searchable (
-  pk integer primary key,
-  text1 text,
-  text2 text,
-  [name with . and spaces] text
-);
-
-CREATE TABLE searchable_tags (
-    searchable_id integer,
-    tag text,
-    PRIMARY KEY (searchable_id, tag),
-    FOREIGN KEY (searchable_id) REFERENCES searchable(pk),
-    FOREIGN KEY (tag) REFERENCES tags(tag)
-);
-
-INSERT INTO searchable VALUES (1, 'barry cat', 'terry dog', 'panther');
-INSERT INTO searchable VALUES (2, 'terry dog', 'sara weasel', 'puma');
-
-INSERT INTO tags VALUES ("canine");
-INSERT INTO tags VALUES ("feline");
-
-INSERT INTO searchable_tags (searchable_id, tag) VALUES
-    (1, "feline"),
-    (2, "canine")
-;
-
-CREATE VIRTUAL TABLE "searchable_fts"
-    USING FTS5 (text1, text2, [name with . and spaces], content="searchable", content_rowid="pk");
-INSERT INTO "searchable_fts" (searchable_fts) VALUES ('rebuild');
-
-CREATE TABLE [select] (
-  [group] text,
-  [having] text,
-  [and] text,
-  [json] text
-);
-INSERT INTO [select] VALUES ('group', 'having', 'and',
-    '{"href": "http://example.com/", "label":"Example"}'
-);
-
-CREATE TABLE infinity (
-    value REAL
-);
-INSERT INTO infinity VALUES
-    (1e999),
-    (-1e999),
-    (1.5)
-;
-
-CREATE TABLE facet_cities (
-    id integer primary key,
-    name text
-);
-INSERT INTO facet_cities (id, name) VALUES
-    (1, 'San Francisco'),
-    (2, 'Los Angeles'),
-    (3, 'Detroit'),
-    (4, 'Memnonia')
-;
-
-CREATE TABLE facetable (
-    pk integer primary key,
-    created text,
-    planet_int integer,
-    on_earth integer,
-    state text,
-    _city_id integer,
-    _neighborhood text,
-    tags text,
-    complex_array text,
-    distinct_some_null,
-    n text,
-    FOREIGN KEY ("_city_id") REFERENCES [facet_cities](id)
-);
-INSERT INTO facetable
-    (created, planet_int, on_earth, state, _city_id, _neighborhood, tags, complex_array, distinct_some_null, n)
-VALUES
-    ("2019-01-14 08:00:00", 1, 1, 'CA', 1, 'Mission', '["tag1", "tag2"]', '[{"foo": "bar"}]', 'one', 'n1'),
-    ("2019-01-14 08:00:00", 1, 1, 'CA', 1, 'Dogpatch', '["tag1", "tag3"]', '[]', 'two', 'n2'),
-    ("2019-01-14 08:00:00", 1, 1, 'CA', 1, 'SOMA', '[]', '[]', null, null),
-    ("2019-01-14 08:00:00", 1, 1, 'CA', 1, 'Tenderloin', '[]', '[]', null, null),
-    ("2019-01-15 08:00:00", 1, 1, 'CA', 1, 'Bernal Heights', '[]', '[]', null, null),
-    ("2019-01-15 08:00:00", 1, 1, 'CA', 1, 'Hayes Valley', '[]', '[]', null, null),
-    ("2019-01-15 08:00:00", 1, 1, 'CA', 2, 'Hollywood', '[]', '[]', null, null),
-    ("2019-01-15 08:00:00", 1, 1, 'CA', 2, 'Downtown', '[]', '[]', null, null),
-    ("2019-01-16 08:00:00", 1, 1, 'CA', 2, 'Los Feliz', '[]', '[]', null, null),
-    ("2019-01-16 08:00:00", 1, 1, 'CA', 2, 'Koreatown', '[]', '[]', null, null),
-    ("2019-01-16 08:00:00", 1, 1, 'MI', 3, 'Downtown', '[]', '[]', null, null),
-    ("2019-01-17 08:00:00", 1, 1, 'MI', 3, 'Greektown', '[]', '[]', null, null),
-    ("2019-01-17 08:00:00", 1, 1, 'MI', 3, 'Corktown', '[]', '[]', null, null),
-    ("2019-01-17 08:00:00", 1, 1, 'MI', 3, 'Mexicantown', '[]', '[]', null, null),
-    ("2019-01-17 08:00:00", 2, 0, 'MC', 4, 'Arcadia Planitia', '[]', '[]', null, null)
-;
-
-CREATE TABLE binary_data (
-    data BLOB
-);
-
--- Many 2 Many demo: roadside attractions!
-
-CREATE TABLE roadside_attractions (
-    pk integer primary key,
-    name text,
-    address text,
-    url text,
-    latitude real,
-    longitude real
-);
-INSERT INTO roadside_attractions VALUES (
-    1, "The Mystery Spot", "465 Mystery Spot Road, Santa Cruz, CA 95065", "https://www.mysteryspot.com/",
-    37.0167, -122.0024
-);
-INSERT INTO roadside_attractions VALUES (
-    2, "Winchester Mystery House", "525 South Winchester Boulevard, San Jose, CA 95128", "https://winchestermysteryhouse.com/",
-    37.3184, -121.9511
-);
-INSERT INTO roadside_attractions VALUES (
-    3, "Burlingame Museum of PEZ Memorabilia", "214 California Drive, Burlingame, CA 94010", null,
-    37.5793, -122.3442
-);
-INSERT INTO roadside_attractions VALUES (
-    4, "Bigfoot Discovery Museum", "5497 Highway 9, Felton, CA 95018", "https://www.bigfootdiscoveryproject.com/",
-    37.0414, -122.0725
-);
-
-CREATE TABLE attraction_characteristic (
-    pk integer primary key,
-    name text
-);
-INSERT INTO attraction_characteristic VALUES (
-    1, "Museum"
-);
-INSERT INTO attraction_characteristic VALUES (
-    2, "Paranormal"
-);
-
-CREATE TABLE roadside_attraction_characteristics (
-    attraction_id INTEGER REFERENCES roadside_attractions(pk),
-    characteristic_id INTEGER REFERENCES attraction_characteristic(pk)
-);
-INSERT INTO roadside_attraction_characteristics VALUES (
-    1, 2
-);
-INSERT INTO roadside_attraction_characteristics VALUES (
-    2, 2
-);
-INSERT INTO roadside_attraction_characteristics VALUES (
-    4, 2
-);
-INSERT INTO roadside_attraction_characteristics VALUES (
-    3, 1
-);
-INSERT INTO roadside_attraction_characteristics VALUES (
-    4, 1
-);
-
-INSERT INTO simple_primary_key VALUES (1, 'hello');
-INSERT INTO simple_primary_key VALUES (2, 'world');
-INSERT INTO simple_primary_key VALUES (3, '');
-INSERT INTO simple_primary_key VALUES (4, 'RENDER_CELL_DEMO');
-INSERT INTO simple_primary_key VALUES (5, 'RENDER_CELL_ASYNC');
-
-INSERT INTO primary_key_multiple_columns VALUES (1, 'hey', 'world');
-INSERT INTO primary_key_multiple_columns_explicit_label VALUES (1, 'hey', 'world2');
-
-INSERT INTO foreign_key_references VALUES (1, 1, 3, 1, 'a', 'b');
-INSERT INTO foreign_key_references VALUES (2, null, null, null, null, null);
-
-INSERT INTO complex_foreign_keys VALUES (1, 1, 2, 1);
-INSERT INTO custom_foreign_key_label VALUES (1, 1);
-
-INSERT INTO [table/with/slashes.csv] VALUES (3, 'hey');
-
-CREATE VIEW simple_view AS
-    SELECT content, upper(content) AS upper_content FROM simple_primary_key;
-
-CREATE VIEW searchable_view AS
-    SELECT * from searchable;
-
-CREATE VIEW searchable_view_configured_by_metadata AS
-    SELECT * from searchable;
-
-"""
-    + "\n".join(
-        [
-            'INSERT INTO no_primary_key VALUES ({i}, "a{i}", "b{i}", "c{i}");'.format(
-                i=i + 1
-            )
-            for i in range(201)
-        ]
-    )
-    + '\nINSERT INTO no_primary_key VALUES ("RENDER_CELL_DEMO", "a202", "b202", "c202");\n'
-    + "\n".join(
-        [
-            'INSERT INTO compound_three_primary_keys VALUES ("{a}", "{b}", "{c}", "{content}");'.format(
-                a=a, b=b, c=c, content=content
-            )
-            for a, b, c, content in generate_compound_rows(1001)
-        ]
-    )
-    + "\n".join(["""INSERT INTO sortable VALUES (
-        "{pk1}", "{pk2}", "{content}", {sortable},
-        {sortable_with_nulls}, {sortable_with_nulls_2}, "{text}");
-    """.format(**row).replace("None", "null") for row in generate_sortable_rows(201)])
-)
-TABLE_PARAMETERIZED_SQL = [
-    ("insert into binary_data (data) values (?);", [b"\x15\x1c\x02\xc7\xad\x05\xfe"]),
-    ("insert into binary_data (data) values (?);", [b"\x15\x1c\x03\xc7\xad\x05\xfe"]),
-    ("insert into binary_data (data) values (null);", []),
-]
-
-EXTRA_DATABASE_SQL = """
-CREATE TABLE searchable (
-  pk integer primary key,
-  text1 text,
-  text2 text
-);
-
-CREATE VIEW searchable_view AS SELECT * FROM searchable;
-
-INSERT INTO searchable VALUES (1, 'barry cat', 'terry dog');
-INSERT INTO searchable VALUES (2, 'terry dog', 'sara weasel');
-
-CREATE VIRTUAL TABLE "searchable_fts"
-    USING FTS3 (text1, text2, content="searchable");
-INSERT INTO "searchable_fts" (rowid, text1, text2)
-    SELECT rowid, text1, text2 FROM searchable;
-"""
-
 
 def assert_permissions_checked(datasette, actions):
     # actions is a list of "action" or (action, resource) tuples
@@ -819,12 +457,7 @@ def cli(db_filename, config, metadata, plugins_path, recreate, extra_db_filename
             )
         else:
             pathlib.Path(db_filename).unlink()
-    conn = sqlite3.connect(db_filename)
-    conn.executescript(TABLES)
-    for sql, params in TABLE_PARAMETERIZED_SQL:
-        with conn:
-            conn.execute(sql, params)
-    conn.close()
+    write_fixture_database(db_filename)
     print(f"Test tables written to {db_filename}")
     if metadata:
         with open(metadata, "w") as fp:
@@ -851,9 +484,7 @@ def cli(db_filename, config, metadata, plugins_path, recreate, extra_db_filename
                 )
             else:
                 pathlib.Path(extra_db_filename).unlink()
-        conn = sqlite3.connect(extra_db_filename)
-        conn.executescript(EXTRA_DATABASE_SQL)
-        conn.close()
+        write_extra_database(extra_db_filename)
         print(f"Test tables written to {extra_db_filename}")
 
 
diff --git a/tests/test_docs.py b/tests/test_docs.py
index b94a6f23..396ba1a2 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -3,6 +3,7 @@ Tests to ensure certain things are documented.
 """
 
 from datasette import app, utils
+import datasette.fixtures  # noqa: F401
 from datasette.app import Datasette
 from datasette.filters import Filters
 from pathlib import Path
@@ -95,20 +96,17 @@ def test_table_filters_are_documented(documented_table_filters, subtests):
 
 
 @pytest.fixture(scope="session")
-def documented_fns():
-    internals_rst = (docs_path / "internals.rst").read_text()
-    # Any line that starts .. _internals_utils_X
-    lines = internals_rst.split("\n")
-    prefix = ".. _internals_utils_"
-    return {
-        line.split(prefix)[1].split(":")[0] for line in lines if line.startswith(prefix)
-    }
+def documented_labels():
+    labels = set()
+    for filename in docs_path.glob("*.rst"):
+        labels.update(get_labels(filename.name))
+    return labels
 
 
-def test_functions_marked_with_documented_are_documented(documented_fns, subtests):
+def test_functions_marked_with_documented_are_documented(documented_labels, subtests):
     for fn in utils.functions_marked_as_documented:
         with subtests.test(fn=fn.__name__):
-            assert fn.__name__ in documented_fns
+            assert fn._datasette_docs_label in documented_labels
 
 
 def test_rst_heading_underlines_match_title_length():
diff --git a/tests/test_fixtures.py b/tests/test_fixtures.py
new file mode 100644
index 00000000..45f9854b
--- /dev/null
+++ b/tests/test_fixtures.py
@@ -0,0 +1,49 @@
+from datasette.fixtures import (
+    populate_extra_database,
+    populate_fixture_database,
+    write_extra_database,
+    write_fixture_database,
+)
+from datasette.utils.sqlite import sqlite3
+
+
+def count(conn, table):
+    return conn.execute(f"select count(*) from [{table}]").fetchone()[0]
+
+
+def test_populate_fixture_database():
+    conn = sqlite3.connect(":memory:")
+    try:
+        populate_fixture_database(conn)
+        assert count(conn, "facetable") == 15
+        assert count(conn, "compound_three_primary_keys") == 1001
+        assert count(conn, "binary_data") == 3
+    finally:
+        conn.close()
+
+
+def test_write_fixture_database(tmp_path):
+    db_path = tmp_path / "fixtures.db"
+    write_fixture_database(db_path)
+    conn = sqlite3.connect(db_path)
+    try:
+        assert count(conn, "sortable") == 201
+    finally:
+        conn.close()
+
+
+def test_extra_database_helpers(tmp_path):
+    conn = sqlite3.connect(":memory:")
+    try:
+        populate_extra_database(conn)
+        assert count(conn, "searchable") == 2
+    finally:
+        conn.close()
+
+    db_path = tmp_path / "extra.db"
+    write_extra_database(db_path)
+    conn = sqlite3.connect(db_path)
+    try:
+        assert count(conn, "searchable") == 2
+    finally:
+        conn.close()
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index 7ebd57f3..d87f577a 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -1,7 +1,6 @@
 from bs4 import BeautifulSoup as Soup
 from .fixtures import (
     make_app_client,
-    TABLES,
     TEMP_PLUGIN_SECRET_FILE,
     PLUGINS_DIR,
     TestClient as _TestClient,
@@ -9,6 +8,7 @@ from .fixtures import (
 from click.testing import CliRunner
 from datasette.app import Datasette
 from datasette import cli, hookimpl
+from datasette.fixtures import TABLES
 from datasette.filters import FilterArguments
 from datasette.plugins import get_plugins, DEFAULT_PLUGINS, pm
 from datasette.permissions import PermissionSQL, Action
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 51e40ad1..ceeb646d 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -1,6 +1,7 @@
 from datasette.utils import detect_json1
 from datasette.utils.sqlite import sqlite_version
-from .fixtures import generate_compound_rows, generate_sortable_rows, make_app_client
+from datasette.fixtures import generate_compound_rows, generate_sortable_rows
+from .fixtures import make_app_client
 import json
 import pytest
 import urllib

From 6057c76165d9dd3d2166824b12665814d07785de Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 21 May 2026 23:28:35 -0700
Subject: [PATCH 017/386] Initial docs for jump_items_sql and jump_start hooks

Refs #2731
---
 docs/plugin_hooks.rst | 114 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 114 insertions(+)

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 54dde20c..041f3d9d 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1881,6 +1881,120 @@ Using :ref:`internals_datasette_urls` here ensures that links in the menu will t
 
 Examples: `datasette-search-all <https://datasette.io/plugins/datasette-search-all>`_, `datasette-graphql <https://datasette.io/plugins/datasette-graphql>`_
 
+.. _plugin_hook_jump_items_sql:
+
+jump_items_sql(datasette, actor, request)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+``datasette`` - :ref:`internals_datasette`
+    You can use this to access plugin configuration options via ``datasette.plugin_config(your_plugin_name)``, or to execute SQL queries.
+
+``actor`` - dictionary or None
+    The currently authenticated :ref:`actor <authentication_actor>`.
+
+``request`` - :ref:`internals_request` or None
+    The current HTTP request. This can be ``None`` if the request object is not available.
+
+This hook allows plugins to add extra results to Datasette's ``/`` jump menu, which is powered by the ``/-/jump`` JSON endpoint.
+
+Return a ``datasette.jump.JumpSQL`` object, or a list of ``JumpSQL`` objects. Each ``JumpSQL`` object wraps a SQL query to be combined with Datasette's own databases, tables, views and canned query results.
+
+The SQL query must return these columns:
+
+``type``
+    A short type string for the result, for example ``"app"`` or ``"dashboard"``.
+
+``label``
+    The stable name for the result. This is returned as ``name`` in the JSON API and is used for sorting.
+
+``description``
+    A short description shown above the item in the jump menu.
+
+``url``
+    The URL to navigate to when the item is selected.
+
+``database_name``
+    The database name for Datasette resources, or ``NULL`` for custom plugin results.
+
+``resource_name``
+    The table, view or query name for Datasette resources, or ``NULL`` for custom plugin results.
+
+``search_text``
+    Text that should be searched by the ``?q=`` parameter.
+
+``sort_key``
+    A numeric value used to order results.
+
+``source``
+    A string identifying the plugin that supplied the result.
+
+If the SQL query also returns a ``display_name`` column, set ``has_display_name=True`` on the ``JumpSQL`` object. Datasette will return that value as ``display_name`` in the JSON API, and the jump menu will show it as the primary readable label with ``name`` shown underneath.
+
+This example adds a "Plugin dashboard" result for signed-in users:
+
+.. code-block:: python
+
+    from datasette import hookimpl
+    from datasette.jump import JumpSQL
+
+
+    @hookimpl
+    def jump_items_sql(actor):
+        if not actor:
+            return None
+        return JumpSQL(
+            sql="""
+            SELECT
+                'dashboard' AS type,
+                'plugin-dashboard' AS label,
+                'Dashboard' AS description,
+                '/-/plugin-dashboard' AS url,
+                NULL AS database_name,
+                NULL AS resource_name,
+                'plugin dashboard' AS search_text,
+                80 AS sort_key,
+                'my-plugin' AS source,
+                'Plugin dashboard' AS display_name
+            """,
+            has_display_name=True,
+        )
+
+Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before combining SQL fragments from different plugins.
+
+.. _plugin_hook_jump_start:
+
+jump_start(datasette, actor, request)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+``datasette`` - :ref:`internals_datasette`
+    You can use this to access plugin configuration options via ``datasette.plugin_config(your_plugin_name)``, or to execute SQL queries.
+
+``actor`` - dictionary or None
+    The currently authenticated :ref:`actor <authentication_actor>`.
+
+``request`` - :ref:`internals_request` or None
+    The current HTTP request. This can be ``None`` if the request object is not available.
+
+This hook allows plugins to add custom HTML to the default blank state of Datasette's ``/`` jump menu, before the user starts typing a search.
+
+The hook can return a string, a ``markupsafe.Markup`` object, or an awaitable function that returns either of those. Return ``None`` to add nothing.
+
+This example shows a link for starting a new chat if the user is signed in:
+
+.. code-block:: python
+
+    from datasette import hookimpl
+    from markupsafe import Markup
+
+
+    @hookimpl
+    def jump_start(actor):
+        if not actor:
+            return None
+        return Markup(
+            '<p><a href="/-/agent/new">Start a new chat</a></p>'
+        )
+
 .. _plugin_actions:
 
 Action hooks

From 8568320a23b492392646e326514e4edad83391d9 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 22 May 2026 20:48:42 -0700
Subject: [PATCH 018/386] Replace jump_start() hook with JavaScript
 makeJumpSections() hook

---
 datasette/app.py                      |  17 ---
 datasette/hookspecs.py                |   7 +-
 datasette/jump.py                     |   1 -
 datasette/static/datasette-manager.js |  14 ++-
 datasette/static/navigation-search.js |  51 +++++++-
 datasette/templates/base.html         |   9 +-
 datasette/views/special.py            |   5 +-
 docs/changelog.rst                    |   2 +-
 docs/introspection.rst                |   2 +-
 docs/javascript_plugins.rst           |  42 +++++++
 docs/plugin_hooks.rst                 |  40 +-----
 tests/test_jump.py                    |  30 -----
 tests/test_navigation_search_js.py    | 175 ++++++++++++++++++++++++++
 tests/test_plugins.py                 |   5 +
 14 files changed, 288 insertions(+), 112 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index c9605af3..088403e0 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2039,22 +2039,6 @@ class Datasette:
                     links.extend(extra_links)
             return links
 
-        async def jump_start():
-            html_bits = []
-            for hook in pm.hook.jump_start(
-                datasette=self,
-                actor=request.actor if request else None,
-                request=request or None,
-            ):
-                extra_html = await await_me_maybe(hook)
-                if not extra_html:
-                    continue
-                if isinstance(extra_html, (list, tuple)):
-                    html_bits.extend(extra_html)
-                else:
-                    html_bits.append(extra_html)
-            return Markup("").join(Markup(html) for html in html_bits)
-
         template_context = {
             **context,
             **{
@@ -2063,7 +2047,6 @@ class Datasette:
                 "urls": self.urls,
                 "actor": request.actor if request else None,
                 "menu_links": menu_links,
-                "jump_start": jump_start,
                 "display_actor": display_actor,
                 "show_logout": request is not None
                 and "ds_actor" in request.cookies
diff --git a/datasette/hookspecs.py b/datasette/hookspecs.py
index a4d8143b..cf95abcb 100644
--- a/datasette/hookspecs.py
+++ b/datasette/hookspecs.py
@@ -159,12 +159,7 @@ def menu_links(datasette, actor, request):
 
 @hookspec
 def jump_items_sql(datasette, actor, request):
-    """SQL fragments for extra items in the jump menu, optionally with display_name"""
-
-
-@hookspec
-def jump_start(datasette, actor, request):
-    """HTML to display in the jump menu before the user types"""
+    """SQL fragments for extra items in the jump menu"""
 
 
 @hookspec
diff --git a/datasette/jump.py b/datasette/jump.py
index 96e18547..6ec7ae13 100644
--- a/datasette/jump.py
+++ b/datasette/jump.py
@@ -9,7 +9,6 @@ from typing import Any
 class JumpSQL:
     sql: str
     params: dict[str, Any] | None = None
-    has_display_name: bool = False
 
 
 _PARAM_RE = re.compile(r"(?<!:):([A-Za-z_][A-Za-z0-9_]*)")
diff --git a/datasette/static/datasette-manager.js b/datasette/static/datasette-manager.js
index d2347ab3..e75f7aae 100644
--- a/datasette/static/datasette-manager.js
+++ b/datasette/static/datasette-manager.js
@@ -82,6 +82,19 @@ const datasetteManager = {
     return columnActions;
   },
 
+  makeJumpSections: (context) => {
+    let jumpSections = [];
+
+    datasetteManager.plugins.forEach((plugin) => {
+      if (plugin.makeJumpSections) {
+        const sections = plugin.makeJumpSections(context) || [];
+        jumpSections.push(...sections);
+      }
+    });
+
+    return jumpSections;
+  },
+
   /**
    * In MVP, each plugin can only have 1 instance.
    * In future, panels could be repeated. We omit that for now since so many plugins depend on
@@ -192,7 +205,6 @@ const initializeDatasette = () => {
   // DATASETTE_EVENTS.INIT event to avoid the habit of reading from the window.
 
   window.__DATASETTE__ = datasetteManager;
-  console.debug("Datasette Manager Created!");
 
   const initDatasetteEvent = new CustomEvent(DATASETTE_EVENTS.INIT, {
     detail: datasetteManager,
diff --git a/datasette/static/navigation-search.js b/datasette/static/navigation-search.js
index 49cc172c..9e24681b 100644
--- a/datasette/static/navigation-search.js
+++ b/datasette/static/navigation-search.js
@@ -447,9 +447,46 @@ class NavigationSearch extends HTMLElement {
     this.renderResults();
   }
 
-  startContentHtml() {
-    const template = this.querySelector("template[data-jump-start]");
-    return template ? template.innerHTML.trim() : "";
+  jumpSections() {
+    const manager = window.__DATASETTE__;
+    if (!manager || typeof manager.makeJumpSections !== "function") {
+      return [];
+    }
+    const sections = manager.makeJumpSections({
+      navigationSearch: this,
+    });
+    return Array.isArray(sections)
+      ? sections.filter(
+          (section) => section && typeof section.render === "function",
+        )
+      : [];
+  }
+
+  jumpSectionsHtml(jumpSections) {
+    return jumpSections
+      .map((section, index) => {
+        const id = section.id
+          ? ` data-jump-section-id="${this.escapeHtml(section.id)}"`
+          : "";
+        return `<div class="jump-start-content" data-jump-section-index="${index}"${id}></div>`;
+      })
+      .join("");
+  }
+
+  renderJumpSections(container, jumpSections) {
+    jumpSections.forEach((section, index) => {
+      const node = container.querySelector(
+        `[data-jump-section-index="${index}"]`,
+      );
+      if (!node) {
+        return;
+      }
+      section.render(node, {
+        navigationSearch: this,
+        container,
+        input: this.shadowRoot.querySelector(".search-input"),
+      });
+    });
   }
 
   resultItemHtml(match, index) {
@@ -484,9 +521,9 @@ class NavigationSearch extends HTMLElement {
     const container = this.shadowRoot.querySelector(".results-container");
     const input = this.shadowRoot.querySelector(".search-input");
     const showStartContent = !input.value.trim();
-    const startContent = showStartContent ? this.startContentHtml() : "";
-    const startBlock = startContent
-      ? `<div class="jump-start-content">${startContent}</div>`
+    const jumpSections = showStartContent ? this.jumpSections() : [];
+    const startBlock = showStartContent
+      ? this.jumpSectionsHtml(jumpSections)
       : "";
     const recentItems = showStartContent ? this.loadRecentItems() : [];
     const defaultMatches = showStartContent ? [] : this.matches;
@@ -507,6 +544,7 @@ class NavigationSearch extends HTMLElement {
     if (renderedMatches.length === 0) {
       if (startBlock) {
         container.innerHTML = startBlock;
+        this.renderJumpSections(container, jumpSections);
       } else if (showStartContent) {
         container.innerHTML = "";
       } else {
@@ -529,6 +567,7 @@ class NavigationSearch extends HTMLElement {
       )
       .join("");
     container.innerHTML = startBlock + recentHtml + defaultHtml;
+    this.renderJumpSections(container, jumpSections);
 
     // Scroll selected item into view
     if (this.selectedIndex >= 0) {
diff --git a/datasette/templates/base.html b/datasette/templates/base.html
index 6a55bd1f..02365e68 100644
--- a/datasette/templates/base.html
+++ b/datasette/templates/base.html
@@ -71,13 +71,6 @@
 
 {% if select_templates %}<!-- Templates considered: {{ select_templates|join(", ") }} -->{% endif %}
 <script src="{{ urls.static('navigation-search.js') }}{% if navigation_search_js_hash is defined %}?{{ navigation_search_js_hash }}{% endif %}" defer></script>
-{% if jump_start is defined %}
-{% set jump_start_html = jump_start() %}
-{% else %}
-{% set jump_start_html = "" %}
-{% endif %}
-<navigation-search url="/-/jump">{% if jump_start_html %}
-    <template data-jump-start>{{ jump_start_html }}</template>
-{% endif %}</navigation-search>
+<navigation-search url="/-/jump"></navigation-search>
 </body>
 </html>
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 990714cf..cb6524dc 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -980,7 +980,6 @@ class JumpView(BaseView):
                 FROM allowed_databases
                 """,
                 params=database_params,
-                has_display_name=True,
             ),
             JumpSQL(
                 sql=f"""
@@ -1004,7 +1003,6 @@ class JumpView(BaseView):
                    AND catalog_views.view_name = allowed_tables.child
                 """,
                 params=table_params,
-                has_display_name=True,
             ),
             JumpSQL(
                 sql=f"""
@@ -1031,7 +1029,6 @@ class JumpView(BaseView):
                    AND query_display_names.query_name = allowed_queries.child
                 """,
                 params={**query_params, **query_display_names_params},
-                has_display_name=True,
             ),
         ]
 
@@ -1095,7 +1092,7 @@ class JumpView(BaseView):
                     search_text,
                     sort_key,
                     source,
-                    {"display_name" if fragment.has_display_name else "NULL AS display_name"}
+                    display_name
                 FROM (
                     {fragment_sql}
                 )
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 51188461..5d52d04d 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -274,7 +274,7 @@ Other changes
 ~~~~~~~~~~~~~
 
 - The internal ``catalog_views`` table now tracks SQLite views alongside tables in the introspection database. (:issue:`2495`)
-- Hitting the ``/`` brings up a search interface for navigating to tables that the current user can view. A new ``/-/tables`` endpoint supports this functionality. (:issue:`2523`)
+- Hitting the ``/`` brings up a search interface for navigating to databases, tables, views, canned queries and plugin-provided items that the current user can view. A new ``/-/jump`` endpoint supports this functionality, and JavaScript plugins can add custom blank-state sections using ``makeJumpSections()``. (:issue:`2523`)
 - Datasette attempts to detect some configuration errors on startup.
 - Datasette now supports Python 3.14 and no longer tests against Python 3.9.
 
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 9f0358ac..a5a9753a 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -155,7 +155,7 @@ The endpoint supports a ``?q=`` query parameter for filtering items by name.
 Canned queries with a configured ``title`` also include a ``display_name`` in
 their results, and can be found by searching for that title. Plugins can provide
 the same extra field from ``jump_items_sql`` by returning a ``display_name``
-column and setting ``JumpSQL(..., has_display_name=True)``.
+column.
 
 `Jump example <https://latest.datasette.io/-/jump>`_:
 
diff --git a/docs/javascript_plugins.rst b/docs/javascript_plugins.rst
index e7ee6817..805938c0 100644
--- a/docs/javascript_plugins.rst
+++ b/docs/javascript_plugins.rst
@@ -58,6 +58,48 @@ JavaScript plugins are blocks of code that can be registered with Datasette usin
 
 The ``implementation`` object passed to this method should include a ``version`` key defining the plugin version, and one or more of the following named functions providing the implementation of the plugin:
 
+.. _javascript_plugins_makeJumpSections:
+
+makeJumpSections()
+~~~~~~~~~~~~~~~~~~
+
+This method should return a JavaScript array of objects defining additional sections to be added to the blank state of the ``/`` jump menu, before the user starts typing a search.
+
+Each object should have the following:
+
+``id`` - string
+    A unique string ID for the section, for example ``agent-chat``
+``render(node, context)`` - function
+    A function that will be called with a DOM node to render the section into
+
+The ``context`` object has the following keys:
+
+``navigationSearch``
+    The ``<navigation-search>`` custom element instance.
+
+This example shows how a plugin might add a button for starting a new chat:
+
+.. code-block:: javascript
+
+    document.addEventListener('datasette_init', function(ev) {
+      ev.detail.registerPlugin('agent-plugin', {
+        version: 0.1,
+        makeJumpSections: () => {
+          return [
+            {
+              id: 'agent-chat',
+              render: node => {
+                node.innerHTML = '<button type="button">Start a new chat</button>';
+                node.querySelector('button').addEventListener('click', () => {
+                  location.href = '/-/agent/new';
+                });
+              }
+            }
+          ];
+        }
+      });
+    });
+
 .. _javascript_plugins_makeAboveTablePanelConfigs:
 
 makeAboveTablePanelConfigs()
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 041f3d9d..c3ce3ed9 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1928,7 +1928,8 @@ The SQL query must return these columns:
 ``source``
     A string identifying the plugin that supplied the result.
 
-If the SQL query also returns a ``display_name`` column, set ``has_display_name=True`` on the ``JumpSQL`` object. Datasette will return that value as ``display_name`` in the JSON API, and the jump menu will show it as the primary readable label with ``name`` shown underneath.
+``display_name``
+    A human-readable label for the result, or ``NULL``. Datasette returns this as ``display_name`` in the JSON API, and the jump menu shows it as the primary readable label with ``name`` shown underneath.
 
 This example adds a "Plugin dashboard" result for signed-in users:
 
@@ -1955,46 +1956,11 @@ This example adds a "Plugin dashboard" result for signed-in users:
                 80 AS sort_key,
                 'my-plugin' AS source,
                 'Plugin dashboard' AS display_name
-            """,
-            has_display_name=True,
+            """
         )
 
 Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before combining SQL fragments from different plugins.
 
-.. _plugin_hook_jump_start:
-
-jump_start(datasette, actor, request)
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-``datasette`` - :ref:`internals_datasette`
-    You can use this to access plugin configuration options via ``datasette.plugin_config(your_plugin_name)``, or to execute SQL queries.
-
-``actor`` - dictionary or None
-    The currently authenticated :ref:`actor <authentication_actor>`.
-
-``request`` - :ref:`internals_request` or None
-    The current HTTP request. This can be ``None`` if the request object is not available.
-
-This hook allows plugins to add custom HTML to the default blank state of Datasette's ``/`` jump menu, before the user starts typing a search.
-
-The hook can return a string, a ``markupsafe.Markup`` object, or an awaitable function that returns either of those. Return ``None`` to add nothing.
-
-This example shows a link for starting a new chat if the user is signed in:
-
-.. code-block:: python
-
-    from datasette import hookimpl
-    from markupsafe import Markup
-
-
-    @hookimpl
-    def jump_start(actor):
-        if not actor:
-            return None
-        return Markup(
-            '<p><a href="/-/agent/new">Start a new chat</a></p>'
-        )
-
 .. _plugin_actions:
 
 Action hooks
diff --git a/tests/test_jump.py b/tests/test_jump.py
index 55325b95..acffe4a9 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -1,6 +1,5 @@
 import pytest
 import pytest_asyncio
-from markupsafe import Markup
 
 from datasette import hookimpl
 from datasette.app import Datasette
@@ -163,7 +162,6 @@ async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
                     'Plugin dashboard for ' || :actor_id AS display_name
                 """,
                 params={"actor_id": actor["id"] if actor else "anonymous"},
-                has_display_name=True,
             )
 
     plugin = JumpPlugin()
@@ -190,34 +188,6 @@ async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
     ]
 
 
-@pytest.mark.asyncio
-async def test_jump_start_hook_renders_empty_state_template(ds_for_jump):
-    class JumpStartPlugin:
-        @hookimpl
-        def jump_start(self, datasette, actor, request):
-            if not actor:
-                return None
-            return Markup(
-                '<section class="agent-jump-start">'
-                "<h3>Agent chat</h3>"
-                '<a href="/-/agent/new">Start a new agent chat</a>'
-                "</section>"
-            )
-
-    plugin = JumpStartPlugin()
-    pm.register(plugin, name="test-jump-start-plugin")
-    try:
-        anonymous = await ds_for_jump.client.get("/")
-        authenticated = await ds_for_jump.client.get("/", actor={"id": "alice"})
-    finally:
-        pm.unregister(name="test-jump-start-plugin")
-
-    assert 'url="/-/jump"' in authenticated.text
-    assert "<template data-jump-start>" not in anonymous.text
-    assert "<template data-jump-start>" in authenticated.text
-    assert "Start a new agent chat" in authenticated.text
-
-
 @pytest.mark.asyncio
 async def test_tables_endpoint_removed(ds_for_jump):
     response = await ds_for_jump.client.get("/-/tables.json")
diff --git a/tests/test_navigation_search_js.py b/tests/test_navigation_search_js.py
index 3096d9a0..590985c9 100644
--- a/tests/test_navigation_search_js.py
+++ b/tests/test_navigation_search_js.py
@@ -197,3 +197,178 @@ def test_navigation_search_tracks_and_renders_recent_items():
         "/item-2",
     ]
     assert json.loads(result.stdout)[0]["display_name"] == "Recent Datasette releases"
+
+
+def test_navigation_search_renders_jump_sections_from_javascript_plugins():
+    script = textwrap.dedent("""
+        const fs = require("fs");
+        const vm = require("vm");
+
+        const documentListeners = {};
+
+        class FakeElement {
+          constructor(tagName = "div", parent = null) {
+            this._innerHTML = "";
+            this.value = "";
+            this.dataset = {};
+            this.open = false;
+            this.parent = parent;
+            this.tagName = tagName.toUpperCase();
+          }
+          set textContent(value) {
+            this.innerHTML = String(value)
+              .replace(/&/g, "&amp;")
+              .replace(/</g, "&lt;")
+              .replace(/>/g, "&gt;")
+              .replace(/"/g, "&quot;");
+          }
+          get innerHTML() {
+            return this._innerHTML;
+          }
+          set innerHTML(value) {
+            this._innerHTML = String(value);
+            if (this.parent) {
+              this.parent._innerHTML += this._innerHTML;
+            }
+          }
+          addEventListener() {}
+          appendChild(child) {
+            this._innerHTML += child.innerHTML || "";
+            return child;
+          }
+          close() { this.open = false; }
+          focus() {}
+          querySelector(selector) {
+            if (selector.startsWith("[data-jump-section-index=")) {
+              return new FakeElement("div", this);
+            }
+            return { scrollIntoView() {} };
+          }
+          showModal() { this.open = true; }
+        }
+
+        class FakeShadowRoot {
+          constructor() {
+            this.innerHTML = "";
+            this.dialog = new FakeElement("dialog");
+            this.input = new FakeElement("input");
+            this.results = new FakeElement("div");
+          }
+          querySelector(selector) {
+            if (selector == "dialog") return this.dialog;
+            if (selector == ".search-input") return this.input;
+            if (selector == ".results-container") return this.results;
+            return new FakeElement();
+          }
+        }
+
+        global.HTMLElement = class {
+          constructor() {
+            this.attributes = {};
+          }
+          attachShadow() {
+            this.shadowRoot = new FakeShadowRoot();
+            return this.shadowRoot;
+          }
+          dispatchEvent() {}
+          getAttribute(name) {
+            return this.attributes[name] || null;
+          }
+          querySelector() {
+            return null;
+          }
+          setAttribute(name, value) {
+            this.attributes[name] = value;
+          }
+        };
+        global.CustomEvent = class {
+          constructor(name, options) {
+            this.name = name;
+            this.type = name;
+            this.detail = options ? options.detail : undefined;
+          }
+        };
+        global.customElements = {
+          registry: new Map(),
+          define(name, cls) {
+            this.registry.set(name, cls);
+          },
+        };
+        global.document = {
+          addEventListener(name, callback) {
+            documentListeners[name] = documentListeners[name] || [];
+            documentListeners[name].push(callback);
+          },
+          activeElement: null,
+          createElement(tagName) {
+            return new FakeElement(tagName);
+          },
+          dispatchEvent(event) {
+            for (const callback of documentListeners[event.type] || []) {
+              callback(event);
+            }
+          },
+          querySelectorAll() {
+            return [];
+          },
+        };
+        global.localStorage = {
+          getItem() { return null; },
+          setItem() {},
+          removeItem() {},
+        };
+        global.window = { datasetteVersion: "test", location: { href: "" } };
+
+        vm.runInThisContext(
+          fs.readFileSync("datasette/static/datasette-manager.js", "utf8"),
+          { filename: "datasette-manager.js" }
+        );
+        for (const callback of documentListeners.DOMContentLoaded || []) {
+          callback();
+        }
+        window.__DATASETTE__.registerPlugin("agent", {
+          version: "0.1",
+          makeJumpSections() {
+            return [
+              {
+                id: "agent-chat",
+                render(node, context) {
+                  if (!context.navigationSearch) {
+                    throw new Error("Expected navigationSearch in render context");
+                  }
+                  node.innerHTML = [
+                    '<section class="agent-jump-start">',
+                    '<button>Start a new agent chat</button>',
+                    '</section>',
+                  ].join('');
+                },
+              },
+            ];
+          },
+        });
+
+        vm.runInThisContext(
+          fs.readFileSync("datasette/static/navigation-search.js", "utf8"),
+          { filename: "navigation-search.js" }
+        );
+
+        const Component = customElements.registry.get("navigation-search");
+        const element = new Component();
+        element.shadowRoot.input.value = "";
+        element.renderResults();
+
+        const html = element.shadowRoot.results.innerHTML;
+        if (!html.includes("Start a new agent chat")) {
+          throw new Error(`Missing jump section content: ${html}`);
+        }
+        process.stdout.write("ok");
+        """)
+    result = subprocess.run(
+        ["node", "-e", script],
+        cwd=".",
+        text=True,
+        capture_output=True,
+        check=False,
+    )
+    assert result.returncode == 0, result.stderr
+    assert result.stdout.endswith("ok")
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index d87f577a..c5b9aef0 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -43,6 +43,11 @@ def test_plugin_hooks_have_tests(plugin_hook):
     assert ok, f"Plugin hook is missing tests: {plugin_hook}"
 
 
+def test_hook_jump_items_sql():
+    # Detailed behavior is covered in tests/test_jump.py.
+    assert "jump_items_sql" in dir(pm.hook)
+
+
 @pytest.mark.asyncio
 async def test_hook_plugins_dir_plugin_prepare_connection(ds_client):
     response = await ds_client.get(

From 0eb78dec9a90c334c9e887a698cdcacf64ec8326 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 22 May 2026 21:19:13 -0700
Subject: [PATCH 019/386] Ran Prettier

npx prettier 'datasette/static/*[!.min|bundle].js' --write
---
 datasette/static/navigation-search.js | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/datasette/static/navigation-search.js b/datasette/static/navigation-search.js
index 9e24681b..34ed2fc3 100644
--- a/datasette/static/navigation-search.js
+++ b/datasette/static/navigation-search.js
@@ -410,7 +410,12 @@ class NavigationSearch extends HTMLElement {
   }
 
   saveRecentItem(match) {
-    if (typeof localStorage === "undefined" || !match || !match.name || !match.url) {
+    if (
+      typeof localStorage === "undefined" ||
+      !match ||
+      !match.name ||
+      !match.url
+    ) {
       return;
     }
 
@@ -559,7 +564,9 @@ class NavigationSearch extends HTMLElement {
     const recentHtml = recentItems.length
       ? `<div class="results-heading">Recent</div>${recentItems
           .map((match, index) => this.resultItemHtml(match, index))
-          .join("")}<div class="recent-actions"><button type="button" class="clear-recent" data-clear-recent-items>Clear recent</button></div>`
+          .join(
+            "",
+          )}<div class="recent-actions"><button type="button" class="clear-recent" data-clear-recent-items>Clear recent</button></div>`
       : "";
     const defaultHtml = defaultMatches
       .map((match, index) =>

From d44cfc3a55ae5b1466696147994e11a9ed00bf9a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 22 May 2026 21:22:10 -0700
Subject: [PATCH 020/386] Fix for failing JS test

---
 tests/test_navigation_search_js.py | 31 +++++++++++++++++++++++-------
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/tests/test_navigation_search_js.py b/tests/test_navigation_search_js.py
index 590985c9..acb1b85e 100644
--- a/tests/test_navigation_search_js.py
+++ b/tests/test_navigation_search_js.py
@@ -1,12 +1,18 @@
 import json
+from pathlib import Path
 import subprocess
 import textwrap
 
 
+REPO_ROOT = Path(__file__).resolve().parents[1]
+STATIC_DIR = REPO_ROOT / "datasette" / "static"
+
+
 def test_navigation_search_tracks_and_renders_recent_items():
     script = textwrap.dedent("""
         const fs = require("fs");
         const vm = require("vm");
+        const navigationSearchJs = __NAVIGATION_SEARCH_JS__;
 
         class FakeElement {
           constructor() {
@@ -102,7 +108,7 @@ def test_navigation_search_tracks_and_renders_recent_items():
         global.window = { location: { href: "" } };
 
         vm.runInThisContext(
-          fs.readFileSync("datasette/static/navigation-search.js", "utf8"),
+          fs.readFileSync(navigationSearchJs, "utf8"),
           { filename: "navigation-search.js" }
         );
 
@@ -180,10 +186,13 @@ def test_navigation_search_tracks_and_renders_recent_items():
         }
 
         process.stdout.write(JSON.stringify(stored));
-        """)
+        """).replace(
+        "__NAVIGATION_SEARCH_JS__",
+        json.dumps(str(STATIC_DIR / "navigation-search.js")),
+    )
     result = subprocess.run(
         ["node", "-e", script],
-        cwd=".",
+        cwd=REPO_ROOT,
         text=True,
         capture_output=True,
         check=False,
@@ -203,6 +212,8 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins():
     script = textwrap.dedent("""
         const fs = require("fs");
         const vm = require("vm");
+        const datasetteManagerJs = __DATASETTE_MANAGER_JS__;
+        const navigationSearchJs = __NAVIGATION_SEARCH_JS__;
 
         const documentListeners = {};
 
@@ -320,7 +331,7 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins():
         global.window = { datasetteVersion: "test", location: { href: "" } };
 
         vm.runInThisContext(
-          fs.readFileSync("datasette/static/datasette-manager.js", "utf8"),
+          fs.readFileSync(datasetteManagerJs, "utf8"),
           { filename: "datasette-manager.js" }
         );
         for (const callback of documentListeners.DOMContentLoaded || []) {
@@ -348,7 +359,7 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins():
         });
 
         vm.runInThisContext(
-          fs.readFileSync("datasette/static/navigation-search.js", "utf8"),
+          fs.readFileSync(navigationSearchJs, "utf8"),
           { filename: "navigation-search.js" }
         );
 
@@ -362,10 +373,16 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins():
           throw new Error(`Missing jump section content: ${html}`);
         }
         process.stdout.write("ok");
-        """)
+        """).replace(
+        "__DATASETTE_MANAGER_JS__",
+        json.dumps(str(STATIC_DIR / "datasette-manager.js")),
+    ).replace(
+        "__NAVIGATION_SEARCH_JS__",
+        json.dumps(str(STATIC_DIR / "navigation-search.js")),
+    )
     result = subprocess.run(
         ["node", "-e", script],
-        cwd=".",
+        cwd=REPO_ROOT,
         text=True,
         capture_output=True,
         check=False,

From fba67250d1c4e7f6a7c47726ec998c79fb78ef95 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 22 May 2026 21:27:04 -0700
Subject: [PATCH 021/386] Ran Black

---
 tests/test_navigation_search_js.py | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/tests/test_navigation_search_js.py b/tests/test_navigation_search_js.py
index acb1b85e..b487357d 100644
--- a/tests/test_navigation_search_js.py
+++ b/tests/test_navigation_search_js.py
@@ -3,7 +3,6 @@ from pathlib import Path
 import subprocess
 import textwrap
 
-
 REPO_ROOT = Path(__file__).resolve().parents[1]
 STATIC_DIR = REPO_ROOT / "datasette" / "static"
 
@@ -209,7 +208,8 @@ def test_navigation_search_tracks_and_renders_recent_items():
 
 
 def test_navigation_search_renders_jump_sections_from_javascript_plugins():
-    script = textwrap.dedent("""
+    script = (
+        textwrap.dedent("""
         const fs = require("fs");
         const vm = require("vm");
         const datasetteManagerJs = __DATASETTE_MANAGER_JS__;
@@ -373,12 +373,15 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins():
           throw new Error(`Missing jump section content: ${html}`);
         }
         process.stdout.write("ok");
-        """).replace(
-        "__DATASETTE_MANAGER_JS__",
-        json.dumps(str(STATIC_DIR / "datasette-manager.js")),
-    ).replace(
-        "__NAVIGATION_SEARCH_JS__",
-        json.dumps(str(STATIC_DIR / "navigation-search.js")),
+        """)
+        .replace(
+            "__DATASETTE_MANAGER_JS__",
+            json.dumps(str(STATIC_DIR / "datasette-manager.js")),
+        )
+        .replace(
+            "__NAVIGATION_SEARCH_JS__",
+            json.dumps(str(STATIC_DIR / "navigation-search.js")),
+        )
     )
     result = subprocess.run(
         ["node", "-e", script],

From f46c245563ed7a50627dfcaf21824993d31025bf Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 08:58:51 -0700
Subject: [PATCH 022/386] blacken-docs

---
 docs/plugin_hooks.rst | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index c3ce3ed9..b855d8b2 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1943,8 +1943,7 @@ This example adds a "Plugin dashboard" result for signed-in users:
     def jump_items_sql(actor):
         if not actor:
             return None
-        return JumpSQL(
-            sql="""
+        return JumpSQL(sql="""
             SELECT
                 'dashboard' AS type,
                 'plugin-dashboard' AS label,
@@ -1956,8 +1955,7 @@ This example adds a "Plugin dashboard" result for signed-in users:
                 80 AS sort_key,
                 'my-plugin' AS source,
                 'Plugin dashboard' AS display_name
-            """
-        )
+            """)
 
 Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before combining SQL fragments from different plugins.
 

From 9e7419db8deb42c6236b6d6a142f6b225e010573 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 09:07:00 -0700
Subject: [PATCH 023/386] Remove navigation_search_js_hash mechanism

Codex added this because CSS was not reloading in dev.
---
 datasette/app.py              | 1 -
 datasette/handle_exception.py | 3 ---
 datasette/templates/base.html | 2 +-
 tests/test_html.py            | 5 +----
 4 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 088403e0..75f05d88 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2052,7 +2052,6 @@ class Datasette:
                 and "ds_actor" in request.cookies
                 and request.actor,
                 "app_css_hash": self.app_css_hash(),
-                "navigation_search_js_hash": self.static_hash("navigation-search.js"),
                 "zip": zip,
                 "body_scripts": body_scripts,
                 "format_bytes": format_bytes,
diff --git a/datasette/handle_exception.py b/datasette/handle_exception.py
index 25ec26d9..96398a4c 100644
--- a/datasette/handle_exception.py
+++ b/datasette/handle_exception.py
@@ -67,9 +67,6 @@ def handle_exception(datasette, request, exception):
                         info,
                         urls=datasette.urls,
                         app_css_hash=datasette.app_css_hash(),
-                        navigation_search_js_hash=datasette.static_hash(
-                            "navigation-search.js"
-                        ),
                         menu_links=lambda: [],
                     )
                 ),
diff --git a/datasette/templates/base.html b/datasette/templates/base.html
index 02365e68..819715ba 100644
--- a/datasette/templates/base.html
+++ b/datasette/templates/base.html
@@ -70,7 +70,7 @@
 {% endfor %}
 
 {% if select_templates %}<!-- Templates considered: {{ select_templates|join(", ") }} -->{% endif %}
-<script src="{{ urls.static('navigation-search.js') }}{% if navigation_search_js_hash is defined %}?{{ navigation_search_js_hash }}{% endif %}" defer></script>
+<script src="{{ urls.static('navigation-search.js') }}" defer></script>
 <navigation-search url="/-/jump"></navigation-search>
 </body>
 </html>
diff --git a/tests/test_html.py b/tests/test_html.py
index ac77f10f..4da321d2 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -1022,10 +1022,7 @@ async def test_navigation_menu_links(
     navigation_search_script = soup.find(
         "script", {"src": re.compile(r"navigation-search\.js")}
     )
-    assert navigation_search_script["src"] == (
-        "/-/static/navigation-search.js?"
-        + ds_client.ds.static_hash("navigation-search.js")
-    )
+    assert navigation_search_script["src"] == "/-/static/navigation-search.js"
     assert details.find("li").find("button") == search_button
     if not actor_id:
         # The app menu is always visible, but anonymous users do not see logout

From 865f35ff10e03e8596b0267a9e49c05949fd4115 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 09:10:25 -0700
Subject: [PATCH 024/386] Move default Jump items to
 datasette.default_jump_items plugin

---
 datasette/default_jump_items.py | 119 ++++++++++++++++++++++++++++++++
 datasette/plugins.py            |   1 +
 datasette/views/special.py      | 116 +------------------------------
 3 files changed, 122 insertions(+), 114 deletions(-)
 create mode 100644 datasette/default_jump_items.py

diff --git a/datasette/default_jump_items.py b/datasette/default_jump_items.py
new file mode 100644
index 00000000..74d8a87f
--- /dev/null
+++ b/datasette/default_jump_items.py
@@ -0,0 +1,119 @@
+from datasette import hookimpl
+from datasette.jump import JumpSQL
+
+
+async def _query_display_names_sql(datasette, actor):
+    selects = []
+    params = {}
+    for database_name in datasette.databases.keys():
+        queries = await datasette.get_canned_queries(database_name, actor)
+        for query_name, query in queries.items():
+            display_name = query.get("title") if isinstance(query, dict) else None
+            if not display_name:
+                continue
+            index = len(selects)
+            params[f"display_database_{index}"] = database_name
+            params[f"display_query_{index}"] = query_name
+            params[f"display_name_{index}"] = str(display_name)
+            selects.append(f"""
+            SELECT
+                :display_database_{index} AS database_name,
+                :display_query_{index} AS query_name,
+                :display_name_{index} AS display_name
+            """)
+    if not selects:
+        return (
+            "SELECT NULL AS database_name, NULL AS query_name, NULL AS display_name WHERE 0",
+            {},
+        )
+    return " UNION ALL ".join(selects), params
+
+
+@hookimpl
+def jump_items_sql(datasette, actor, request):
+    async def inner():
+        database_sql, database_params = await datasette.allowed_resources_sql(
+            action="view-database", actor=actor
+        )
+        table_sql, table_params = await datasette.allowed_resources_sql(
+            action="view-table", actor=actor
+        )
+        query_sql, query_params = await datasette.allowed_resources_sql(
+            action="view-query", actor=actor
+        )
+        query_display_names_sql, query_display_names_params = (
+            await _query_display_names_sql(datasette, actor)
+        )
+        return [
+            JumpSQL(
+                sql=f"""
+                WITH allowed_databases AS (
+                    {database_sql}
+                )
+                SELECT
+                    'database' AS type,
+                    parent AS label,
+                    'Database' AS description,
+                    NULL AS url,
+                    parent AS database_name,
+                    NULL AS resource_name,
+                    parent AS search_text,
+                    10 AS sort_key,
+                    'datasette' AS source,
+                    NULL AS display_name
+                FROM allowed_databases
+                """,
+                params=database_params,
+            ),
+            JumpSQL(
+                sql=f"""
+                WITH allowed_tables AS (
+                    {table_sql}
+                )
+                SELECT
+                    CASE WHEN catalog_views.view_name IS NULL THEN 'table' ELSE 'view' END AS type,
+                    allowed_tables.parent || ': ' || allowed_tables.child AS label,
+                    CASE WHEN catalog_views.view_name IS NULL THEN 'Table' ELSE 'View' END AS description,
+                    NULL AS url,
+                    allowed_tables.parent AS database_name,
+                    allowed_tables.child AS resource_name,
+                    allowed_tables.parent || ' ' || allowed_tables.child AS search_text,
+                    CASE WHEN catalog_views.view_name IS NULL THEN 20 ELSE 25 END AS sort_key,
+                    'datasette' AS source,
+                    NULL AS display_name
+                FROM allowed_tables
+                LEFT JOIN catalog_views
+                    ON catalog_views.database_name = allowed_tables.parent
+                   AND catalog_views.view_name = allowed_tables.child
+                """,
+                params=table_params,
+            ),
+            JumpSQL(
+                sql=f"""
+                WITH allowed_queries AS (
+                    {query_sql}
+                ),
+                query_display_names AS (
+                    {query_display_names_sql}
+                )
+                SELECT
+                    'query' AS type,
+                    allowed_queries.parent || ': ' || allowed_queries.child AS label,
+                    'Canned query' AS description,
+                    NULL AS url,
+                    allowed_queries.parent AS database_name,
+                    allowed_queries.child AS resource_name,
+                    allowed_queries.parent || ' ' || allowed_queries.child || ' ' || COALESCE(query_display_names.display_name, '') AS search_text,
+                    30 AS sort_key,
+                    'datasette' AS source,
+                    query_display_names.display_name AS display_name
+                FROM allowed_queries
+                LEFT JOIN query_display_names
+                    ON query_display_names.database_name = allowed_queries.parent
+                   AND query_display_names.query_name = allowed_queries.child
+                """,
+                params={**query_params, **query_display_names_params},
+            ),
+        ]
+
+    return inner
diff --git a/datasette/plugins.py b/datasette/plugins.py
index b01b386c..15041e59 100644
--- a/datasette/plugins.py
+++ b/datasette/plugins.py
@@ -29,6 +29,7 @@ DEFAULT_PLUGINS = (
     "datasette.default_magic_parameters",
     "datasette.blob_renderer",
     "datasette.default_menu_links",
+    "datasette.default_jump_items",
     "datasette.handle_exception",
     "datasette.forbidden",
     "datasette.events",
diff --git a/datasette/views/special.py b/datasette/views/special.py
index cb6524dc..2022e4a7 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -921,118 +921,7 @@ class JumpView(BaseView):
     name = "jump"
     has_json_alternate = False
 
-    async def _query_display_names_sql(self, request):
-        selects = []
-        params = {}
-        for database_name in self.ds.databases.keys():
-            queries = await self.ds.get_canned_queries(database_name, request.actor)
-            for query_name, query in queries.items():
-                display_name = query.get("title") if isinstance(query, dict) else None
-                if not display_name:
-                    continue
-                index = len(selects)
-                params[f"display_database_{index}"] = database_name
-                params[f"display_query_{index}"] = query_name
-                params[f"display_name_{index}"] = str(display_name)
-                selects.append(f"""
-                SELECT
-                    :display_database_{index} AS database_name,
-                    :display_query_{index} AS query_name,
-                    :display_name_{index} AS display_name
-                """)
-        if not selects:
-            return (
-                "SELECT NULL AS database_name, NULL AS query_name, NULL AS display_name WHERE 0",
-                {},
-            )
-        return " UNION ALL ".join(selects), params
-
-    async def _core_fragments(self, request):
-        database_sql, database_params = await self.ds.allowed_resources_sql(
-            action="view-database", actor=request.actor
-        )
-        table_sql, table_params = await self.ds.allowed_resources_sql(
-            action="view-table", actor=request.actor
-        )
-        query_sql, query_params = await self.ds.allowed_resources_sql(
-            action="view-query", actor=request.actor
-        )
-        query_display_names_sql, query_display_names_params = (
-            await self._query_display_names_sql(request)
-        )
-        return [
-            JumpSQL(
-                sql=f"""
-                WITH allowed_databases AS (
-                    {database_sql}
-                )
-                SELECT
-                    'database' AS type,
-                    parent AS label,
-                    'Database' AS description,
-                    NULL AS url,
-                    parent AS database_name,
-                    NULL AS resource_name,
-                    parent AS search_text,
-                    10 AS sort_key,
-                    'datasette' AS source,
-                    NULL AS display_name
-                FROM allowed_databases
-                """,
-                params=database_params,
-            ),
-            JumpSQL(
-                sql=f"""
-                WITH allowed_tables AS (
-                    {table_sql}
-                )
-                SELECT
-                    CASE WHEN catalog_views.view_name IS NULL THEN 'table' ELSE 'view' END AS type,
-                    allowed_tables.parent || ': ' || allowed_tables.child AS label,
-                    CASE WHEN catalog_views.view_name IS NULL THEN 'Table' ELSE 'View' END AS description,
-                    NULL AS url,
-                    allowed_tables.parent AS database_name,
-                    allowed_tables.child AS resource_name,
-                    allowed_tables.parent || ' ' || allowed_tables.child AS search_text,
-                    CASE WHEN catalog_views.view_name IS NULL THEN 20 ELSE 25 END AS sort_key,
-                    'datasette' AS source,
-                    NULL AS display_name
-                FROM allowed_tables
-                LEFT JOIN catalog_views
-                    ON catalog_views.database_name = allowed_tables.parent
-                   AND catalog_views.view_name = allowed_tables.child
-                """,
-                params=table_params,
-            ),
-            JumpSQL(
-                sql=f"""
-                WITH allowed_queries AS (
-                    {query_sql}
-                ),
-                query_display_names AS (
-                    {query_display_names_sql}
-                )
-                SELECT
-                    'query' AS type,
-                    allowed_queries.parent || ': ' || allowed_queries.child AS label,
-                    'Canned query' AS description,
-                    NULL AS url,
-                    allowed_queries.parent AS database_name,
-                    allowed_queries.child AS resource_name,
-                    allowed_queries.parent || ' ' || allowed_queries.child || ' ' || COALESCE(query_display_names.display_name, '') AS search_text,
-                    30 AS sort_key,
-                    'datasette' AS source,
-                    query_display_names.display_name AS display_name
-                FROM allowed_queries
-                LEFT JOIN query_display_names
-                    ON query_display_names.database_name = allowed_queries.parent
-                   AND query_display_names.query_name = allowed_queries.child
-                """,
-                params={**query_params, **query_display_names_params},
-            ),
-        ]
-
-    async def _plugin_fragments(self, request):
+    async def _fragments(self, request):
         fragments = []
         for hook in pm.hook.jump_items_sql(
             datasette=self.ds,
@@ -1070,8 +959,7 @@ class JumpView(BaseView):
         q = request.args.get("q", "").strip()
         terms = q.split()
         pattern = "%" + "%".join(terms) + "%" if terms else "%"
-        fragments = await self._core_fragments(request)
-        fragments.extend(await self._plugin_fragments(request))
+        fragments = await self._fragments(request)
 
         union_parts = []
         all_params = {"q": q, "pattern": pattern}

From 09ccab97ccebb7e5570879acdb8b7717c274aa5c Mon Sep 17 00:00:00 2001
From: Copilot <198982749+Copilot@users.noreply.github.com>
Date: Sat, 23 May 2026 09:34:03 -0700
Subject: [PATCH 025/386] Run cog to update generated plugin docs (#2734)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
---
 docs/plugins.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/docs/plugins.rst b/docs/plugins.rst
index d9938dba..90bc9d35 100644
--- a/docs/plugins.rst
+++ b/docs/plugins.rst
@@ -216,6 +216,15 @@ If you run ``datasette plugins --all`` it will include default plugins that ship
                 "register_column_types"
             ]
         },
+        {
+            "name": "datasette.default_jump_items",
+            "static": false,
+            "templates": false,
+            "version": null,
+            "hooks": [
+                "jump_items_sql"
+            ]
+        },
         {
             "name": "datasette.default_magic_parameters",
             "static": false,

From 1590444fa34c132eaecf49391033925b8fb123a8 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 16:42:29 -0700
Subject: [PATCH 026/386] Simplify by removing _query_display_names_sql

See https://github.com/simonw/datasette/pull/2732/changes#r3293627533
---
 datasette/default_jump_items.py | 42 +++------------------------------
 docs/introspection.rst          |  7 ++----
 tests/test_jump.py              | 15 ++++++------
 3 files changed, 12 insertions(+), 52 deletions(-)

diff --git a/datasette/default_jump_items.py b/datasette/default_jump_items.py
index 74d8a87f..bacc3649 100644
--- a/datasette/default_jump_items.py
+++ b/datasette/default_jump_items.py
@@ -2,33 +2,6 @@ from datasette import hookimpl
 from datasette.jump import JumpSQL
 
 
-async def _query_display_names_sql(datasette, actor):
-    selects = []
-    params = {}
-    for database_name in datasette.databases.keys():
-        queries = await datasette.get_canned_queries(database_name, actor)
-        for query_name, query in queries.items():
-            display_name = query.get("title") if isinstance(query, dict) else None
-            if not display_name:
-                continue
-            index = len(selects)
-            params[f"display_database_{index}"] = database_name
-            params[f"display_query_{index}"] = query_name
-            params[f"display_name_{index}"] = str(display_name)
-            selects.append(f"""
-            SELECT
-                :display_database_{index} AS database_name,
-                :display_query_{index} AS query_name,
-                :display_name_{index} AS display_name
-            """)
-    if not selects:
-        return (
-            "SELECT NULL AS database_name, NULL AS query_name, NULL AS display_name WHERE 0",
-            {},
-        )
-    return " UNION ALL ".join(selects), params
-
-
 @hookimpl
 def jump_items_sql(datasette, actor, request):
     async def inner():
@@ -41,9 +14,6 @@ def jump_items_sql(datasette, actor, request):
         query_sql, query_params = await datasette.allowed_resources_sql(
             action="view-query", actor=actor
         )
-        query_display_names_sql, query_display_names_params = (
-            await _query_display_names_sql(datasette, actor)
-        )
         return [
             JumpSQL(
                 sql=f"""
@@ -92,9 +62,6 @@ def jump_items_sql(datasette, actor, request):
                 sql=f"""
                 WITH allowed_queries AS (
                     {query_sql}
-                ),
-                query_display_names AS (
-                    {query_display_names_sql}
                 )
                 SELECT
                     'query' AS type,
@@ -103,16 +70,13 @@ def jump_items_sql(datasette, actor, request):
                     NULL AS url,
                     allowed_queries.parent AS database_name,
                     allowed_queries.child AS resource_name,
-                    allowed_queries.parent || ' ' || allowed_queries.child || ' ' || COALESCE(query_display_names.display_name, '') AS search_text,
+                    allowed_queries.parent || ' ' || allowed_queries.child AS search_text,
                     30 AS sort_key,
                     'datasette' AS source,
-                    query_display_names.display_name AS display_name
+                    NULL AS display_name
                 FROM allowed_queries
-                LEFT JOIN query_display_names
-                    ON query_display_names.database_name = allowed_queries.parent
-                   AND query_display_names.query_name = allowed_queries.child
                 """,
-                params={**query_params, **query_display_names_params},
+                params=query_params,
             ),
         ]
 
diff --git a/docs/introspection.rst b/docs/introspection.rst
index a5a9753a..b6ee1690 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -152,10 +152,8 @@ Shows currently attached databases. `Databases example <https://latest.datasette
 Returns a JSON list of items that the current actor has permission to view for Datasette's jump menu. By default this includes visible databases, tables, views and canned queries, and plugins can contribute additional items.
 
 The endpoint supports a ``?q=`` query parameter for filtering items by name.
-Canned queries with a configured ``title`` also include a ``display_name`` in
-their results, and can be found by searching for that title. Plugins can provide
-the same extra field from ``jump_items_sql`` by returning a ``display_name``
-column.
+Plugins can provide an optional ``display_name`` field from
+``jump_items_sql`` by returning a ``display_name`` column.
 
 `Jump example <https://latest.datasette.io/-/jump>`_:
 
@@ -177,7 +175,6 @@ column.
             },
             {
                 "name": "fixtures: recent_releases",
-                "display_name": "Recent Datasette releases",
                 "url": "/fixtures/recent_releases",
                 "type": "query",
                 "description": "Canned query"
diff --git a/tests/test_jump.py b/tests/test_jump.py
index acffe4a9..27238695 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -89,10 +89,6 @@ async def test_jump_searches_tables_databases_views_and_canned_queries(ds_for_ju
     assert ("view", "content: comment_summary") in matches_by_type_and_name
     assert ("query", "content: recent_comments") in matches_by_type_and_name
     assert matches_by_type_and_name[("database", "content")]["url"] == "/content"
-    assert (
-        matches_by_type_and_name[("query", "content: recent_comments")]["display_name"]
-        == "Recent comments"
-    )
     assert (
         matches_by_type_and_name[("query", "content: recent_comments")]["url"]
         == "/content/recent_comments"
@@ -100,17 +96,20 @@ async def test_jump_searches_tables_databases_views_and_canned_queries(ds_for_ju
 
 
 @pytest.mark.asyncio
-async def test_jump_searches_and_displays_canned_query_titles(ds_for_jump):
+async def test_jump_uses_canned_query_names_not_titles(ds_for_jump):
     response = await ds_for_jump.client.get(
         "/-/jump.json?q=datasette", actor={"id": "user"}
     )
     assert response.status_code == 200
-    data = response.json()
+    assert response.json()["matches"] == []
 
-    assert data["matches"] == [
+    response = await ds_for_jump.client.get(
+        "/-/jump.json?q=release", actor={"id": "user"}
+    )
+    assert response.status_code == 200
+    assert response.json()["matches"] == [
         {
             "name": "content: release_notes",
-            "display_name": "Recent Datasette releases",
             "url": "/content/release_notes",
             "type": "query",
             "description": "Canned query",

From be1b5b2b5ca526bc3441864e0d2b7986012ea300 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 16:57:09 -0700
Subject: [PATCH 027/386] Move debug links into jump menu

---
 datasette/default_debug_menu.py | 36 ++++++++++++++++
 datasette/default_menu_links.py | 41 ------------------
 datasette/jump.py               | 43 +++++++++++++++++++
 datasette/plugins.py            |  2 +-
 docs/authentication.rst         |  2 +-
 docs/changelog.rst              |  7 +++-
 docs/introspection.rst          |  2 -
 docs/plugin_hooks.rst           | 25 ++++++-----
 docs/plugins.rst                |  4 +-
 tests/test_html.py              |  2 +-
 tests/test_jump.py              | 73 ++++++++++++++++++++++++++++++++-
 tests/test_permissions.py       |  1 -
 12 files changed, 173 insertions(+), 65 deletions(-)
 create mode 100644 datasette/default_debug_menu.py
 delete mode 100644 datasette/default_menu_links.py

diff --git a/datasette/default_debug_menu.py b/datasette/default_debug_menu.py
new file mode 100644
index 00000000..d1c2cd6c
--- /dev/null
+++ b/datasette/default_debug_menu.py
@@ -0,0 +1,36 @@
+from datasette import hookimpl
+from datasette.jump import JumpSQL
+
+DEBUG_MENU_ITEMS = (
+    ("/-/databases", "Databases"),
+    ("/-/plugins", "Installed plugins"),
+    ("/-/versions", "Version info"),
+    ("/-/settings", "Settings"),
+    ("/-/permissions", "Debug permissions"),
+    ("/-/messages", "Debug messages"),
+    ("/-/allow-debug", "Debug allow rules"),
+    ("/-/threads", "Debug threads"),
+    ("/-/actor", "Debug actor"),
+    ("/-/patterns", "Pattern portfolio"),
+)
+
+
+@hookimpl
+def jump_items_sql(datasette, actor, request):
+    async def inner():
+        if not await datasette.allowed(action="debug-menu", actor=actor):
+            return []
+
+        return [
+            JumpSQL.menu_item(
+                label=label,
+                url=datasette.urls.path(path),
+                description="Debug menu",
+                source="datasette.default_debug_menu",
+                sort_key=70 + index,
+                item_type="debug",
+            )
+            for index, (path, label) in enumerate(DEBUG_MENU_ITEMS)
+        ]
+
+    return inner
diff --git a/datasette/default_menu_links.py b/datasette/default_menu_links.py
deleted file mode 100644
index 85032387..00000000
--- a/datasette/default_menu_links.py
+++ /dev/null
@@ -1,41 +0,0 @@
-from datasette import hookimpl
-
-
-@hookimpl
-def menu_links(datasette, actor):
-    async def inner():
-        if not await datasette.allowed(action="debug-menu", actor=actor):
-            return []
-
-        return [
-            {"href": datasette.urls.path("/-/databases"), "label": "Databases"},
-            {
-                "href": datasette.urls.path("/-/plugins"),
-                "label": "Installed plugins",
-            },
-            {
-                "href": datasette.urls.path("/-/versions"),
-                "label": "Version info",
-            },
-            {
-                "href": datasette.urls.path("/-/settings"),
-                "label": "Settings",
-            },
-            {
-                "href": datasette.urls.path("/-/permissions"),
-                "label": "Debug permissions",
-            },
-            {
-                "href": datasette.urls.path("/-/messages"),
-                "label": "Debug messages",
-            },
-            {
-                "href": datasette.urls.path("/-/allow-debug"),
-                "label": "Debug allow rules",
-            },
-            {"href": datasette.urls.path("/-/threads"), "label": "Debug threads"},
-            {"href": datasette.urls.path("/-/actor"), "label": "Debug actor"},
-            {"href": datasette.urls.path("/-/patterns"), "label": "Pattern portfolio"},
-        ]
-
-    return inner
diff --git a/datasette/jump.py b/datasette/jump.py
index 6ec7ae13..7ef5ce2b 100644
--- a/datasette/jump.py
+++ b/datasette/jump.py
@@ -10,6 +10,49 @@ class JumpSQL:
     sql: str
     params: dict[str, Any] | None = None
 
+    @classmethod
+    def menu_item(
+        cls,
+        *,
+        label: str,
+        url: str,
+        description: str = "Menu item",
+        source: str = "datasette",
+        sort_key: int = 50,
+        search_text: str | None = None,
+        display_name: str | None = None,
+        item_type: str = "menu",
+    ) -> "JumpSQL":
+        if search_text is None:
+            search_text = " ".join(
+                text for text in (label, display_name, description) if text is not None
+            )
+        return cls(
+            sql="""
+            SELECT
+                :type AS type,
+                :label AS label,
+                :description AS description,
+                :url AS url,
+                NULL AS database_name,
+                NULL AS resource_name,
+                :search_text AS search_text,
+                :sort_key AS sort_key,
+                :source AS source,
+                :display_name AS display_name
+            """,
+            params={
+                "type": item_type,
+                "label": label,
+                "description": description,
+                "url": url,
+                "search_text": search_text,
+                "sort_key": sort_key,
+                "source": source,
+                "display_name": display_name,
+            },
+        )
+
 
 _PARAM_RE = re.compile(r"(?<!:):([A-Za-z_][A-Za-z0-9_]*)")
 
diff --git a/datasette/plugins.py b/datasette/plugins.py
index 15041e59..f532ac60 100644
--- a/datasette/plugins.py
+++ b/datasette/plugins.py
@@ -28,7 +28,7 @@ DEFAULT_PLUGINS = (
     "datasette.default_column_types",
     "datasette.default_magic_parameters",
     "datasette.blob_renderer",
-    "datasette.default_menu_links",
+    "datasette.default_debug_menu",
     "datasette.default_jump_items",
     "datasette.handle_exception",
     "datasette.forbidden",
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 7fa3a241..7daefab7 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1398,4 +1398,4 @@ Actor is allowed to view the ``/-/permissions`` debug tools.
 debug-menu
 ----------
 
-Controls if the various debug pages are displayed in the navigation menu.
+Controls if the various debug pages are displayed in the jump menu.
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 5d52d04d..d2479590 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -13,6 +13,11 @@ Unreleased
 - Fixed a bug where stale tables and other related resources were not removed from ``catalog_*`` tables when a database was removed. (:issue:`2723`)
 - Fixed a Safari bug with the table search mechanism triggered by pressing ``/``. (:issue:`2724`)
 - New "Jump to..." menu item, always visible, for triggering the previously undocumented ``/`` menu. (:issue:`2725`)
+- The ``/`` jump-to search interface now covers databases, views, canned queries and plugin-provided items in addition to tables. The endpoint backing it has been renamed from ``/-/tables`` to ``/-/jump``.
+- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL that queries the internal catalog.
+- ``datasette.jump.JumpSQL.menu_item()`` is a shortcut for adding individual jump menu items that are not backed by resources in the internal catalog.
+- New :ref:`javascript_plugins_makeJumpSections` JavaScript plugin hook, allowing plugins to add custom blank-state sections to the jump-to menu before the user has typed a query.
+- Debug menu links now appear in the jump-to menu instead of the top-right app menu.
 - New documented :ref:`datasette.fixtures.populate_fixture_database(conn) <datasette_fixtures_populate_fixture_database>` helper for creating the fixture database tables used by Datasette's own tests, intended for plugin test suites.
 
 .. _v1_0_a29:
@@ -274,7 +279,7 @@ Other changes
 ~~~~~~~~~~~~~
 
 - The internal ``catalog_views`` table now tracks SQLite views alongside tables in the introspection database. (:issue:`2495`)
-- Hitting the ``/`` brings up a search interface for navigating to databases, tables, views, canned queries and plugin-provided items that the current user can view. A new ``/-/jump`` endpoint supports this functionality, and JavaScript plugins can add custom blank-state sections using ``makeJumpSections()``. (:issue:`2523`)
+- Hitting the ``/`` brings up a search interface for navigating to tables that the current user can view. A new ``/-/tables`` endpoint supports this functionality. (:issue:`2523`)
 - Datasette attempts to detect some configuration errors on startup.
 - Datasette now supports Python 3.14 and no longer tests against Python 3.9.
 
diff --git a/docs/introspection.rst b/docs/introspection.rst
index b6ee1690..8476c22a 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -152,8 +152,6 @@ Shows currently attached databases. `Databases example <https://latest.datasette
 Returns a JSON list of items that the current actor has permission to view for Datasette's jump menu. By default this includes visible databases, tables, views and canned queries, and plugins can contribute additional items.
 
 The endpoint supports a ``?q=`` query parameter for filtering items by name.
-Plugins can provide an optional ``display_name`` field from
-``jump_items_sql`` by returning a ``display_name`` column.
 
 `Jump example <https://latest.datasette.io/-/jump>`_:
 
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index b855d8b2..71d429ac 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1943,22 +1943,21 @@ This example adds a "Plugin dashboard" result for signed-in users:
     def jump_items_sql(actor):
         if not actor:
             return None
-        return JumpSQL(sql="""
-            SELECT
-                'dashboard' AS type,
-                'plugin-dashboard' AS label,
-                'Dashboard' AS description,
-                '/-/plugin-dashboard' AS url,
-                NULL AS database_name,
-                NULL AS resource_name,
-                'plugin dashboard' AS search_text,
-                80 AS sort_key,
-                'my-plugin' AS source,
-                'Plugin dashboard' AS display_name
-            """)
+        return JumpSQL.menu_item(
+            item_type="dashboard",
+            label="plugin-dashboard",
+            description="Dashboard",
+            url="/-/plugin-dashboard",
+            search_text="plugin dashboard",
+            sort_key=80,
+            source="my-plugin",
+            display_name="Plugin dashboard",
+        )
 
 Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before combining SQL fragments from different plugins.
 
+``JumpSQL.menu_item(...)`` is a shortcut for adding a single jump menu item that is not backed by a resource in Datasette's internal catalog tables. It returns ``NULL`` for ``database_name`` and ``resource_name`` and accepts the keyword arguments shown above.
+
 .. _plugin_actions:
 
 Action hooks
diff --git a/docs/plugins.rst b/docs/plugins.rst
index 90bc9d35..e79acfe0 100644
--- a/docs/plugins.rst
+++ b/docs/plugins.rst
@@ -235,12 +235,12 @@ If you run ``datasette plugins --all`` it will include default plugins that ship
             ]
         },
         {
-            "name": "datasette.default_menu_links",
+            "name": "datasette.default_debug_menu",
             "static": false,
             "templates": false,
             "version": null,
             "hooks": [
-                "menu_links"
+                "jump_items_sql"
             ]
         },
         {
diff --git a/tests/test_html.py b/tests/test_html.py
index 4da321d2..efc1040d 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -994,7 +994,7 @@ def test_edit_sql_link_not_shown_if_user_lacks_permission(has_permission):
     [
         (None, None, None),
         ("test", None, ["/-/permissions"]),
-        ("root", ["/-/permissions", "/-/allow-debug"], None),
+        ("root", None, ["/-/permissions", "/-/allow-debug"]),
     ],
 )
 async def test_navigation_menu_links(
diff --git a/tests/test_jump.py b/tests/test_jump.py
index 27238695..af8f4856 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -3,6 +3,7 @@ import pytest_asyncio
 
 from datasette import hookimpl
 from datasette.app import Datasette
+from datasette.jump import JumpSQL
 from datasette.plugins import pm
 
 
@@ -140,9 +141,77 @@ async def test_jump_respects_resource_permissions(ds_for_jump):
 
 
 @pytest.mark.asyncio
-async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
-    from datasette.jump import JumpSQL
+async def test_jump_sql_menu_item_helper(ds_for_jump):
+    fragment = JumpSQL.menu_item(
+        label="Plugin dashboard",
+        url="/-/plugin-dashboard",
+        description="Plugin tool",
+        source="test-plugin",
+        sort_key=70,
+        search_text="dashboard plugin",
+        display_name="Plugin Dashboard",
+        item_type="plugin",
+    )
+    result = await ds_for_jump.get_internal_database().execute(
+        fragment.sql, fragment.params
+    )
+    assert dict(result.first()) == {
+        "type": "plugin",
+        "label": "Plugin dashboard",
+        "description": "Plugin tool",
+        "url": "/-/plugin-dashboard",
+        "database_name": None,
+        "resource_name": None,
+        "search_text": "dashboard plugin",
+        "sort_key": 70,
+        "source": "test-plugin",
+        "display_name": "Plugin Dashboard",
+    }
 
+
+@pytest.mark.asyncio
+async def test_debug_menu_items_are_in_jump_for_debug_menu_permission():
+    ds = Datasette(
+        config={
+            "permissions": {
+                "debug-menu": {"id": "debugger"},
+            }
+        }
+    )
+    await ds.invoke_startup()
+    response = await ds.client.get("/-/jump.json?q=debug", actor={"id": "debugger"})
+    assert response.status_code == 200
+    debug_matches = [
+        match for match in response.json()["matches"] if match["type"] == "debug"
+    ]
+    assert {match["name"]: match["url"] for match in debug_matches} == {
+        "Databases": "/-/databases",
+        "Installed plugins": "/-/plugins",
+        "Version info": "/-/versions",
+        "Settings": "/-/settings",
+        "Debug permissions": "/-/permissions",
+        "Debug messages": "/-/messages",
+        "Debug allow rules": "/-/allow-debug",
+        "Debug threads": "/-/threads",
+        "Debug actor": "/-/actor",
+        "Pattern portfolio": "/-/patterns",
+    }
+    assert {match["description"] for match in debug_matches} == {"Debug menu"}
+
+
+@pytest.mark.asyncio
+async def test_debug_menu_items_are_hidden_without_debug_menu_permission():
+    ds = Datasette()
+    await ds.invoke_startup()
+    response = await ds.client.get("/-/jump.json?q=debug", actor={"id": "regular"})
+    assert response.status_code == 200
+    assert [
+        match for match in response.json()["matches"] if match["type"] == "debug"
+    ] == []
+
+
+@pytest.mark.asyncio
+async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
     class JumpPlugin:
         @hookimpl
         def jump_items_sql(self, datasette, actor, request):
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 0c09e773..8166532f 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -430,7 +430,6 @@ async def test_permissions_debug(ds_client, filter_):
             "result": True,
             "actor": {"id": "root"},
         },
-        {"action": "debug-menu", "result": False, "actor": None},
         {
             "action": "view-instance",
             "result": True,

From 9c1f8621eb9f339fc0ba59bb6e6ca2cb77942fb0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 16:59:45 -0700
Subject: [PATCH 028/386] Request is always set for jump_items_sql() hook

---
 docs/plugin_hooks.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 71d429ac..5a0c8af1 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1892,8 +1892,8 @@ jump_items_sql(datasette, actor, request)
 ``actor`` - dictionary or None
     The currently authenticated :ref:`actor <authentication_actor>`.
 
-``request`` - :ref:`internals_request` or None
-    The current HTTP request. This can be ``None`` if the request object is not available.
+``request`` - :ref:`internals_request`
+    The current HTTP request.
 
 This hook allows plugins to add extra results to Datasette's ``/`` jump menu, which is powered by the ``/-/jump`` JSON endpoint.
 

From 0f7e4410c11108de4de30e7892bbb48058dbdd24 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 17:07:47 -0700
Subject: [PATCH 029/386] Better test name

---
 tests/test_allowed_resources.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test_allowed_resources.py b/tests/test_allowed_resources.py
index 8048ae2c..e247aa78 100644
--- a/tests/test_allowed_resources.py
+++ b/tests/test_allowed_resources.py
@@ -51,7 +51,7 @@ async def test_ds():
 
 
 @pytest.mark.asyncio
-async def test_tables_endpoint_global_access(test_ds):
+async def test_tables_allowed_resources_global_access(test_ds):
     """Test allowed_resources() with global access permissions"""
 
     def rules_callback(datasette, actor, action):

From 21a79b34b8eab84f6f9668f1b92d559ad8124f06 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 20:28:02 -0700
Subject: [PATCH 030/386] Improvements to Jump SQL columns

- Removed database_name and resource_name
- url can now optionally return JSON to reuse datasette.urls. methods
- description is now used as a truncated text description
---
 datasette/default_debug_menu.py       | 65 ++++++++++++++++++++-----
 datasette/default_jump_items.py       | 29 ++++++-----
 datasette/jump.py                     |  2 -
 datasette/static/navigation-search.js | 24 ++++++++-
 datasette/views/special.py            | 41 +++++++++++-----
 docs/changelog.rst                    |  5 +-
 docs/introspection.rst                | 10 ++--
 docs/plugin_hooks.rst                 | 16 ++----
 docs/plugins.rst                      | 18 +++----
 tests/test_jump.py                    | 70 ++++++++++++++++++++++++---
 10 files changed, 207 insertions(+), 73 deletions(-)

diff --git a/datasette/default_debug_menu.py b/datasette/default_debug_menu.py
index d1c2cd6c..e9576d99 100644
--- a/datasette/default_debug_menu.py
+++ b/datasette/default_debug_menu.py
@@ -2,16 +2,56 @@ from datasette import hookimpl
 from datasette.jump import JumpSQL
 
 DEBUG_MENU_ITEMS = (
-    ("/-/databases", "Databases"),
-    ("/-/plugins", "Installed plugins"),
-    ("/-/versions", "Version info"),
-    ("/-/settings", "Settings"),
-    ("/-/permissions", "Debug permissions"),
-    ("/-/messages", "Debug messages"),
-    ("/-/allow-debug", "Debug allow rules"),
-    ("/-/threads", "Debug threads"),
-    ("/-/actor", "Debug actor"),
-    ("/-/patterns", "Pattern portfolio"),
+    (
+        "/-/databases",
+        "Databases",
+        "List of databases known to this Datasette instance.",
+    ),
+    (
+        "/-/plugins",
+        "Installed plugins",
+        "Review loaded plugins, their versions and their registered hooks.",
+    ),
+    (
+        "/-/versions",
+        "Version info",
+        "Check the Python, SQLite and dependency versions used by this server.",
+    ),
+    (
+        "/-/settings",
+        "Settings",
+        "Inspect the active Datasette settings and configuration values.",
+    ),
+    (
+        "/-/permissions",
+        "Debug permissions",
+        "Test permission checks for actors, actions and resources.",
+    ),
+    (
+        "/-/messages",
+        "Debug messages",
+        "Try out temporary flash messages shown to users.",
+    ),
+    (
+        "/-/allow-debug",
+        "Debug allow rules",
+        "Explore how allow blocks match actors against permission rules.",
+    ),
+    (
+        "/-/threads",
+        "Debug threads",
+        "Inspect worker threads and database tasks.",
+    ),
+    (
+        "/-/actor",
+        "Debug actor",
+        "View the actor object for the current signed-in user.",
+    ),
+    (
+        "/-/patterns",
+        "Pattern portfolio",
+        "Browse Datasette UI patterns.",
+    ),
 )
 
 
@@ -25,12 +65,13 @@ def jump_items_sql(datasette, actor, request):
             JumpSQL.menu_item(
                 label=label,
                 url=datasette.urls.path(path),
-                description="Debug menu",
+                description=description,
                 source="datasette.default_debug_menu",
                 sort_key=70 + index,
+                search_text=f"debug {label} {description}",
                 item_type="debug",
             )
-            for index, (path, label) in enumerate(DEBUG_MENU_ITEMS)
+            for index, (path, label, description) in enumerate(DEBUG_MENU_ITEMS)
         ]
 
     return inner
diff --git a/datasette/default_jump_items.py b/datasette/default_jump_items.py
index bacc3649..844fb6b6 100644
--- a/datasette/default_jump_items.py
+++ b/datasette/default_jump_items.py
@@ -23,10 +23,11 @@ def jump_items_sql(datasette, actor, request):
                 SELECT
                     'database' AS type,
                     parent AS label,
-                    'Database' AS description,
-                    NULL AS url,
-                    parent AS database_name,
-                    NULL AS resource_name,
+                    NULL AS description,
+                    json_object(
+                        'method', 'database',
+                        'database', parent
+                    ) AS url,
                     parent AS search_text,
                     10 AS sort_key,
                     'datasette' AS source,
@@ -43,10 +44,12 @@ def jump_items_sql(datasette, actor, request):
                 SELECT
                     CASE WHEN catalog_views.view_name IS NULL THEN 'table' ELSE 'view' END AS type,
                     allowed_tables.parent || ': ' || allowed_tables.child AS label,
-                    CASE WHEN catalog_views.view_name IS NULL THEN 'Table' ELSE 'View' END AS description,
-                    NULL AS url,
-                    allowed_tables.parent AS database_name,
-                    allowed_tables.child AS resource_name,
+                    NULL AS description,
+                    json_object(
+                        'method', 'table',
+                        'database', allowed_tables.parent,
+                        'table', allowed_tables.child
+                    ) AS url,
                     allowed_tables.parent || ' ' || allowed_tables.child AS search_text,
                     CASE WHEN catalog_views.view_name IS NULL THEN 20 ELSE 25 END AS sort_key,
                     'datasette' AS source,
@@ -66,10 +69,12 @@ def jump_items_sql(datasette, actor, request):
                 SELECT
                     'query' AS type,
                     allowed_queries.parent || ': ' || allowed_queries.child AS label,
-                    'Canned query' AS description,
-                    NULL AS url,
-                    allowed_queries.parent AS database_name,
-                    allowed_queries.child AS resource_name,
+                    NULL AS description,
+                    json_object(
+                        'method', 'query',
+                        'database', allowed_queries.parent,
+                        'query', allowed_queries.child
+                    ) AS url,
                     allowed_queries.parent || ' ' || allowed_queries.child AS search_text,
                     30 AS sort_key,
                     'datasette' AS source,
diff --git a/datasette/jump.py b/datasette/jump.py
index 7ef5ce2b..5a67d49e 100644
--- a/datasette/jump.py
+++ b/datasette/jump.py
@@ -34,8 +34,6 @@ class JumpSQL:
                 :label AS label,
                 :description AS description,
                 :url AS url,
-                NULL AS database_name,
-                NULL AS resource_name,
                 :search_text AS search_text,
                 :sort_key AS sort_key,
                 :source AS source,
diff --git a/datasette/static/navigation-search.js b/datasette/static/navigation-search.js
index 34ed2fc3..29a2f143 100644
--- a/datasette/static/navigation-search.js
+++ b/datasette/static/navigation-search.js
@@ -100,6 +100,11 @@ class NavigationSearch extends HTMLElement {
                     background-color: #dbeafe;
                 }
 
+                .result-item > div {
+                    flex: 1;
+                    min-width: 0;
+                }
+
                 .jump-start-content {
                     border-bottom: 1px solid #e5e7eb;
                     margin-bottom: 0.5rem;
@@ -120,7 +125,7 @@ class NavigationSearch extends HTMLElement {
                     color: #4b5563;
                 }
 
-                .result-description {
+                .result-type {
                     color: #4b5563;
                     font-size: 0.75rem;
                     font-weight: 600;
@@ -132,6 +137,17 @@ class NavigationSearch extends HTMLElement {
                     color: #6b7280;
                 }
 
+                .result-description {
+                    color: #374151;
+                    display: -webkit-box;
+                    font-size: 0.8125rem;
+                    line-height: 1.35;
+                    margin-top: 0.35rem;
+                    overflow: hidden;
+                    -webkit-box-orient: vertical;
+                    -webkit-line-clamp: 2;
+                }
+
                 .results-heading {
                     color: #4b5563;
                     font-size: 0.75rem;
@@ -500,6 +516,9 @@ class NavigationSearch extends HTMLElement {
       match.display_name && match.display_name !== match.name
         ? `<div class="result-label">${this.escapeHtml(match.name)}</div>`
         : "";
+    const type = match.type
+      ? `<div class="result-type">${this.escapeHtml(match.type)}</div>`
+      : "";
     const description = match.description
       ? `<div class="result-description">${this.escapeHtml(
           match.description,
@@ -513,10 +532,11 @@ class NavigationSearch extends HTMLElement {
                 aria-selected="${index === this.selectedIndex}"
             >
                 <div>
-                    ${description}
+                    ${type}
                     <div class="result-name">${this.escapeHtml(displayName)}</div>
                     ${label}
                     <div class="result-url">${this.escapeHtml(match.url)}</div>
+                    ${description}
                 </div>
             </div>
         `;
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 2022e4a7..5b468f51 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -944,16 +944,33 @@ class JumpView(BaseView):
                 raise TypeError("jump_items_sql must return JumpSQL instances")
         return fragments
 
-    def _url_for_row(self, row):
-        if row["url"]:
-            return row["url"]
-        if row["type"] == "database":
-            return self.ds.urls.database(row["database_name"])
-        if row["type"] in ("table", "view"):
-            return self.ds.urls.table(row["database_name"], row["resource_name"])
-        if row["type"] == "query":
-            return self.ds.urls.query(row["database_name"], row["resource_name"])
-        return ""
+    def _resolve_url(self, url):
+        if not url or url.startswith("/"):
+            return url
+
+        descriptor = json.loads(url)
+        if not isinstance(descriptor, dict):
+            raise TypeError("jump item url JSON must be an object")
+        method_name = descriptor.get("method")
+        if not isinstance(method_name, str) or not method_name:
+            raise TypeError("jump item url JSON must include a method")
+        if method_name.startswith("_"):
+            raise AttributeError(f"datasette.urls has no method named {method_name!r}")
+        try:
+            method = getattr(self.ds.urls, method_name)
+        except AttributeError as ex:
+            raise AttributeError(
+                f"datasette.urls has no method named {method_name!r}"
+            ) from ex
+        if not callable(method):
+            raise TypeError(f"datasette.urls.{method_name} is not callable")
+        kwargs = {key: value for key, value in descriptor.items() if key != "method"}
+        try:
+            return method(**kwargs)
+        except TypeError as ex:
+            raise TypeError(
+                f"Invalid arguments for datasette.urls.{method_name}(): {ex}"
+            ) from ex
 
     async def get(self, request):
         q = request.args.get("q", "").strip()
@@ -975,8 +992,6 @@ class JumpView(BaseView):
                     label,
                     description,
                     url,
-                    database_name,
-                    resource_name,
                     search_text,
                     sort_key,
                     source,
@@ -1016,7 +1031,7 @@ class JumpView(BaseView):
         for row in rows:
             match = {
                 "name": row["label"],
-                "url": self._url_for_row(row),
+                "url": self._resolve_url(row["url"]),
                 "type": row["type"],
                 "description": row["description"],
             }
diff --git a/docs/changelog.rst b/docs/changelog.rst
index d2479590..84015b46 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -14,10 +14,11 @@ Unreleased
 - Fixed a Safari bug with the table search mechanism triggered by pressing ``/``. (:issue:`2724`)
 - New "Jump to..." menu item, always visible, for triggering the previously undocumented ``/`` menu. (:issue:`2725`)
 - The ``/`` jump-to search interface now covers databases, views, canned queries and plugin-provided items in addition to tables. The endpoint backing it has been renamed from ``/-/tables`` to ``/-/jump``.
-- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL that queries the internal catalog.
+- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL that queries the internal catalog. Each row returned by this hook includes a ``url`` value, which can be a string starting with ``/`` or a JSON object describing a call to one of the :ref:`internals_datasette_urls` methods.
 - ``datasette.jump.JumpSQL.menu_item()`` is a shortcut for adding individual jump menu items that are not backed by resources in the internal catalog.
 - New :ref:`javascript_plugins_makeJumpSections` JavaScript plugin hook, allowing plugins to add custom blank-state sections to the jump-to menu before the user has typed a query.
-- Debug menu links now appear in the jump-to menu instead of the top-right app menu.
+- Jump menu results now show their ``type`` as a category label, and can show optional longer ``description`` text for individual results.
+- Debug menu links now appear in the jump-to menu instead of the top-right app menu, with descriptions for each debug item.
 - New documented :ref:`datasette.fixtures.populate_fixture_database(conn) <datasette_fixtures_populate_fixture_database>` helper for creating the fixture database tables used by Datasette's own tests, intended for plugin test suites.
 
 .. _v1_0_a29:
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 8476c22a..d2eb8efd 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -151,6 +151,8 @@ Shows currently attached databases. `Databases example <https://latest.datasette
 
 Returns a JSON list of items that the current actor has permission to view for Datasette's jump menu. By default this includes visible databases, tables, views and canned queries, and plugins can contribute additional items.
 
+Each item includes a ``type`` string used as a category label in the menu. Items can also include an optional ``description`` with longer text describing that individual result.
+
 The endpoint supports a ``?q=`` query parameter for filtering items by name.
 
 `Jump example <https://latest.datasette.io/-/jump>`_:
@@ -163,19 +165,19 @@ The endpoint supports a ``?q=`` query parameter for filtering items by name.
                 "name": "fixtures",
                 "url": "/fixtures",
                 "type": "database",
-                "description": "Database"
+                "description": null
             },
             {
                 "name": "fixtures: facetable",
                 "url": "/fixtures/facetable",
                 "type": "table",
-                "description": "Table"
+                "description": null
             },
             {
                 "name": "fixtures: recent_releases",
                 "url": "/fixtures/recent_releases",
                 "type": "query",
-                "description": "Canned query"
+                "description": null
             }
         ],
         "truncated": false
@@ -191,7 +193,7 @@ Search example with ``?q=facet`` returns only items matching ``.*facet.*``:
                 "name": "fixtures: facetable",
                 "url": "/fixtures/facetable",
                 "type": "table",
-                "description": "Table"
+                "description": null
             }
         ],
         "truncated": false
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 5a0c8af1..c0b188cb 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1902,22 +1902,16 @@ Return a ``datasette.jump.JumpSQL`` object, or a list of ``JumpSQL`` objects. Ea
 The SQL query must return these columns:
 
 ``type``
-    A short type string for the result, for example ``"app"`` or ``"dashboard"``.
+    A short type string for the result, for example ``"app"`` or ``"dashboard"``. The jump menu displays this above the item as a category label.
 
 ``label``
     The stable name for the result. This is returned as ``name`` in the JSON API and is used for sorting.
 
 ``description``
-    A short description shown above the item in the jump menu.
+    Optional longer text describing this individual item, or ``NULL``. The jump menu displays this below the item's URL when it is present.
 
 ``url``
-    The URL to navigate to when the item is selected.
-
-``database_name``
-    The database name for Datasette resources, or ``NULL`` for custom plugin results.
-
-``resource_name``
-    The table, view or query name for Datasette resources, or ``NULL`` for custom plugin results.
+    The URL to navigate to when the item is selected. This can be either a string starting with ``/`` or a JSON object describing a call to one of the :ref:`internals_datasette_urls` methods. For example, ``json_object('method', 'table', 'database', 'fixtures', 'table', 'facetable')`` calls ``datasette.urls.table(database='fixtures', table='facetable')``. Unknown methods or invalid named arguments will result in an error.
 
 ``search_text``
     Text that should be searched by the ``?q=`` parameter.
@@ -1946,7 +1940,7 @@ This example adds a "Plugin dashboard" result for signed-in users:
         return JumpSQL.menu_item(
             item_type="dashboard",
             label="plugin-dashboard",
-            description="Dashboard",
+            description="Review plugin status and configuration.",
             url="/-/plugin-dashboard",
             search_text="plugin dashboard",
             sort_key=80,
@@ -1956,7 +1950,7 @@ This example adds a "Plugin dashboard" result for signed-in users:
 
 Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before combining SQL fragments from different plugins.
 
-``JumpSQL.menu_item(...)`` is a shortcut for adding a single jump menu item that is not backed by a resource in Datasette's internal catalog tables. It returns ``NULL`` for ``database_name`` and ``resource_name`` and accepts the keyword arguments shown above.
+``JumpSQL.menu_item(...)`` is a shortcut for adding a single jump menu item from Python code. It accepts the keyword arguments shown above.
 
 .. _plugin_actions:
 
diff --git a/docs/plugins.rst b/docs/plugins.rst
index e79acfe0..77958205 100644
--- a/docs/plugins.rst
+++ b/docs/plugins.rst
@@ -216,6 +216,15 @@ If you run ``datasette plugins --all`` it will include default plugins that ship
                 "register_column_types"
             ]
         },
+        {
+            "name": "datasette.default_debug_menu",
+            "static": false,
+            "templates": false,
+            "version": null,
+            "hooks": [
+                "jump_items_sql"
+            ]
+        },
         {
             "name": "datasette.default_jump_items",
             "static": false,
@@ -234,15 +243,6 @@ If you run ``datasette plugins --all`` it will include default plugins that ship
                 "register_magic_parameters"
             ]
         },
-        {
-            "name": "datasette.default_debug_menu",
-            "static": false,
-            "templates": false,
-            "version": null,
-            "hooks": [
-                "jump_items_sql"
-            ]
-        },
         {
             "name": "datasette.default_permissions",
             "static": false,
diff --git a/tests/test_jump.py b/tests/test_jump.py
index af8f4856..3c5cf1a1 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -5,6 +5,7 @@ from datasette import hookimpl
 from datasette.app import Datasette
 from datasette.jump import JumpSQL
 from datasette.plugins import pm
+from datasette.views.special import JumpView
 
 
 @pytest_asyncio.fixture
@@ -113,7 +114,7 @@ async def test_jump_uses_canned_query_names_not_titles(ds_for_jump):
             "name": "content: release_notes",
             "url": "/content/release_notes",
             "type": "query",
-            "description": "Canned query",
+            "description": None,
         }
     ]
 
@@ -160,8 +161,6 @@ async def test_jump_sql_menu_item_helper(ds_for_jump):
         "label": "Plugin dashboard",
         "description": "Plugin tool",
         "url": "/-/plugin-dashboard",
-        "database_name": None,
-        "resource_name": None,
         "search_text": "dashboard plugin",
         "sort_key": 70,
         "source": "test-plugin",
@@ -196,7 +195,13 @@ async def test_debug_menu_items_are_in_jump_for_debug_menu_permission():
         "Debug actor": "/-/actor",
         "Pattern portfolio": "/-/patterns",
     }
-    assert {match["description"] for match in debug_matches} == {"Debug menu"}
+    descriptions_by_name = {
+        match["name"]: match["description"] for match in debug_matches
+    }
+    assert all(descriptions_by_name.values())
+    assert descriptions_by_name["Databases"] == (
+        "Inspect the databases, tables, views and columns known to this Datasette instance."
+    )
 
 
 @pytest.mark.asyncio
@@ -222,8 +227,6 @@ async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
                     'plugin-dashboard: ' || :actor_id AS label,
                     'Plugin supplied item' AS description,
                     '/-/plugin-dashboard' AS url,
-                    NULL AS database_name,
-                    NULL AS resource_name,
                     'plugin dashboard ' || :actor_id AS search_text,
                     80 AS sort_key,
                     'test-plugin' AS source,
@@ -256,6 +259,61 @@ async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
     ]
 
 
+@pytest.mark.asyncio
+async def test_jump_resolves_url_descriptors_from_sql(ds_for_jump):
+    class JumpPlugin:
+        @hookimpl
+        def jump_items_sql(self, datasette, actor, request):
+            return JumpSQL(sql="""
+                SELECT
+                    'plugin' AS type,
+                    'Table descriptor' AS label,
+                    NULL AS description,
+                    json_object(
+                        'method', 'table',
+                        'database', 'content',
+                        'table', 'comments'
+                    ) AS url,
+                    'table descriptor comments' AS search_text,
+                    80 AS sort_key,
+                    'test-plugin' AS source,
+                    NULL AS display_name
+                """)
+
+    plugin = JumpPlugin()
+    pm.register(plugin, name="test-jump-url-descriptor-plugin")
+    try:
+        response = await ds_for_jump.client.get(
+            "/-/jump.json?q=descriptor", actor={"id": "alice"}
+        )
+    finally:
+        pm.unregister(name="test-jump-url-descriptor-plugin")
+
+    assert response.status_code == 200
+    plugin_matches = [
+        match for match in response.json()["matches"] if match["type"] == "plugin"
+    ]
+    assert plugin_matches == [
+        {
+            "name": "Table descriptor",
+            "url": "/content/comments",
+            "type": "plugin",
+            "description": None,
+        }
+    ]
+
+
+@pytest.mark.asyncio
+async def test_jump_url_descriptor_errors(ds_for_jump):
+    view = JumpView(ds_for_jump)
+    with pytest.raises(AttributeError):
+        view._resolve_url('{"method": "not_a_url_method"}')
+    with pytest.raises(TypeError):
+        view._resolve_url(
+            '{"method": "table", "database_name": "content", "table_name": "comments"}'
+        )
+
+
 @pytest.mark.asyncio
 async def test_tables_endpoint_removed(ds_for_jump):
     response = await ds_for_jump.client.get("/-/tables.json")

From c73ed1ee4e619ee9da002443da3e29e0bc93de4f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 20:30:56 -0700
Subject: [PATCH 031/386] Fixed a test I broke

---
 tests/test_jump.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test_jump.py b/tests/test_jump.py
index 3c5cf1a1..3282a7c0 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -200,7 +200,7 @@ async def test_debug_menu_items_are_in_jump_for_debug_menu_permission():
     }
     assert all(descriptions_by_name.values())
     assert descriptions_by_name["Databases"] == (
-        "Inspect the databases, tables, views and columns known to this Datasette instance."
+        "List of databases known to this Datasette instance"
     )
 
 

From cef6aa85b6a67f29e97d898873fcb8097ca68141 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 20:41:32 -0700
Subject: [PATCH 032/386] Remove source and source_key columns from JumpSQL

Refs https://github.com/simonw/datasette/pull/2732#issuecomment-4527290391
---
 datasette/default_debug_menu.py |  4 +---
 datasette/default_jump_items.py |  6 ------
 datasette/jump.py               |  6 ------
 datasette/views/special.py      | 10 +++++++---
 docs/plugin_hooks.rst           |  8 --------
 tests/test_jump.py              | 10 +---------
 6 files changed, 9 insertions(+), 35 deletions(-)

diff --git a/datasette/default_debug_menu.py b/datasette/default_debug_menu.py
index e9576d99..6127b2a6 100644
--- a/datasette/default_debug_menu.py
+++ b/datasette/default_debug_menu.py
@@ -66,12 +66,10 @@ def jump_items_sql(datasette, actor, request):
                 label=label,
                 url=datasette.urls.path(path),
                 description=description,
-                source="datasette.default_debug_menu",
-                sort_key=70 + index,
                 search_text=f"debug {label} {description}",
                 item_type="debug",
             )
-            for index, (path, label, description) in enumerate(DEBUG_MENU_ITEMS)
+            for path, label, description in DEBUG_MENU_ITEMS
         ]
 
     return inner
diff --git a/datasette/default_jump_items.py b/datasette/default_jump_items.py
index 844fb6b6..d215e7ec 100644
--- a/datasette/default_jump_items.py
+++ b/datasette/default_jump_items.py
@@ -29,8 +29,6 @@ def jump_items_sql(datasette, actor, request):
                         'database', parent
                     ) AS url,
                     parent AS search_text,
-                    10 AS sort_key,
-                    'datasette' AS source,
                     NULL AS display_name
                 FROM allowed_databases
                 """,
@@ -51,8 +49,6 @@ def jump_items_sql(datasette, actor, request):
                         'table', allowed_tables.child
                     ) AS url,
                     allowed_tables.parent || ' ' || allowed_tables.child AS search_text,
-                    CASE WHEN catalog_views.view_name IS NULL THEN 20 ELSE 25 END AS sort_key,
-                    'datasette' AS source,
                     NULL AS display_name
                 FROM allowed_tables
                 LEFT JOIN catalog_views
@@ -76,8 +72,6 @@ def jump_items_sql(datasette, actor, request):
                         'query', allowed_queries.child
                     ) AS url,
                     allowed_queries.parent || ' ' || allowed_queries.child AS search_text,
-                    30 AS sort_key,
-                    'datasette' AS source,
                     NULL AS display_name
                 FROM allowed_queries
                 """,
diff --git a/datasette/jump.py b/datasette/jump.py
index 5a67d49e..17c86bfd 100644
--- a/datasette/jump.py
+++ b/datasette/jump.py
@@ -17,8 +17,6 @@ class JumpSQL:
         label: str,
         url: str,
         description: str = "Menu item",
-        source: str = "datasette",
-        sort_key: int = 50,
         search_text: str | None = None,
         display_name: str | None = None,
         item_type: str = "menu",
@@ -35,8 +33,6 @@ class JumpSQL:
                 :description AS description,
                 :url AS url,
                 :search_text AS search_text,
-                :sort_key AS sort_key,
-                :source AS source,
                 :display_name AS display_name
             """,
             params={
@@ -45,8 +41,6 @@ class JumpSQL:
                 "description": description,
                 "url": url,
                 "search_text": search_text,
-                "sort_key": sort_key,
-                "source": source,
                 "display_name": display_name,
             },
         )
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 5b468f51..272273aa 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -993,8 +993,6 @@ class JumpView(BaseView):
                     description,
                     url,
                     search_text,
-                    sort_key,
-                    source,
                     display_name
                 FROM (
                     {fragment_sql}
@@ -1016,7 +1014,13 @@ class JumpView(BaseView):
                 WHEN lower(COALESCE(display_name, label)) LIKE lower(:q || '%') THEN 1
                 ELSE 2
             END,
-            sort_key,
+            CASE type
+                WHEN 'database' THEN 10
+                WHEN 'table' THEN 20
+                WHEN 'view' THEN 25
+                WHEN 'query' THEN 30
+                ELSE 50
+            END,
             length(COALESCE(display_name, label)),
             label
         LIMIT 101
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index c0b188cb..4d8e980f 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1916,12 +1916,6 @@ The SQL query must return these columns:
 ``search_text``
     Text that should be searched by the ``?q=`` parameter.
 
-``sort_key``
-    A numeric value used to order results.
-
-``source``
-    A string identifying the plugin that supplied the result.
-
 ``display_name``
     A human-readable label for the result, or ``NULL``. Datasette returns this as ``display_name`` in the JSON API, and the jump menu shows it as the primary readable label with ``name`` shown underneath.
 
@@ -1943,8 +1937,6 @@ This example adds a "Plugin dashboard" result for signed-in users:
             description="Review plugin status and configuration.",
             url="/-/plugin-dashboard",
             search_text="plugin dashboard",
-            sort_key=80,
-            source="my-plugin",
             display_name="Plugin dashboard",
         )
 
diff --git a/tests/test_jump.py b/tests/test_jump.py
index 3282a7c0..adb8626c 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -147,8 +147,6 @@ async def test_jump_sql_menu_item_helper(ds_for_jump):
         label="Plugin dashboard",
         url="/-/plugin-dashboard",
         description="Plugin tool",
-        source="test-plugin",
-        sort_key=70,
         search_text="dashboard plugin",
         display_name="Plugin Dashboard",
         item_type="plugin",
@@ -162,8 +160,6 @@ async def test_jump_sql_menu_item_helper(ds_for_jump):
         "description": "Plugin tool",
         "url": "/-/plugin-dashboard",
         "search_text": "dashboard plugin",
-        "sort_key": 70,
-        "source": "test-plugin",
         "display_name": "Plugin Dashboard",
     }
 
@@ -200,7 +196,7 @@ async def test_debug_menu_items_are_in_jump_for_debug_menu_permission():
     }
     assert all(descriptions_by_name.values())
     assert descriptions_by_name["Databases"] == (
-        "List of databases known to this Datasette instance"
+        "List of databases known to this Datasette instance."
     )
 
 
@@ -228,8 +224,6 @@ async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
                     'Plugin supplied item' AS description,
                     '/-/plugin-dashboard' AS url,
                     'plugin dashboard ' || :actor_id AS search_text,
-                    80 AS sort_key,
-                    'test-plugin' AS source,
                     'Plugin dashboard for ' || :actor_id AS display_name
                 """,
                 params={"actor_id": actor["id"] if actor else "anonymous"},
@@ -275,8 +269,6 @@ async def test_jump_resolves_url_descriptors_from_sql(ds_for_jump):
                         'table', 'comments'
                     ) AS url,
                     'table descriptor comments' AS search_text,
-                    80 AS sort_key,
-                    'test-plugin' AS source,
                     NULL AS display_name
                 """)
 

From c980234c41a9bc7a188f17c7f07e48ef1a7640a7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 21:00:04 -0700
Subject: [PATCH 033/386] JumpSQL(database=) parameter

Refs https://github.com/simonw/datasette/pull/2732#issuecomment-4527304912
---
 datasette/jump.py          |   3 +-
 datasette/views/special.py |  76 ++++++++++++++----
 docs/changelog.rst         |   2 +-
 docs/plugin_hooks.rst      |  10 ++-
 tests/test_jump.py         | 153 +++++++++++++++++++++++++++++++++++++
 5 files changed, 225 insertions(+), 19 deletions(-)

diff --git a/datasette/jump.py b/datasette/jump.py
index 17c86bfd..d138e827 100644
--- a/datasette/jump.py
+++ b/datasette/jump.py
@@ -9,6 +9,7 @@ from typing import Any
 class JumpSQL:
     sql: str
     params: dict[str, Any] | None = None
+    database: str | None = None
 
     @classmethod
     def menu_item(
@@ -50,7 +51,7 @@ _PARAM_RE = re.compile(r"(?<!:):([A-Za-z_][A-Za-z0-9_]*)")
 
 
 def namespace_sql_params(sql: str, params: dict[str, Any], prefix: str):
-    """Rename named SQL parameters so UNION fragments cannot collide."""
+    """Rename named SQL parameters so UNION query parameters cannot collide."""
     if not params:
         return sql, {}
 
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 272273aa..31e7f0c2 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -972,15 +972,28 @@ class JumpView(BaseView):
                 f"Invalid arguments for datasette.urls.{method_name}(): {ex}"
             ) from ex
 
-    async def get(self, request):
-        q = request.args.get("q", "").strip()
-        terms = q.split()
-        pattern = "%" + "%".join(terms) + "%" if terms else "%"
-        fragments = await self._fragments(request)
+    def _sort_key(self, row, q):
+        display_label = row["display_name"] or row["label"]
+        display_label_lower = display_label.lower()
+        q_lower = q.lower()
+        if display_label_lower == q_lower:
+            relevance = 0
+        elif display_label_lower.startswith(q_lower):
+            relevance = 1
+        else:
+            relevance = 2
+        type_sort = {
+            "database": 10,
+            "table": 20,
+            "view": 25,
+            "query": 30,
+        }.get(row["type"], 50)
+        return (relevance, type_sort, len(display_label), row["label"])
 
+    async def _rows_for_database(self, database_name, indexed_fragments, q, pattern):
+        params = {"q": q, "pattern": pattern}
         union_parts = []
-        all_params = {"q": q, "pattern": pattern}
-        for index, fragment in enumerate(fragments):
+        for index, fragment in indexed_fragments:
             fragment_sql, fragment_params = namespace_sql_params(
                 fragment.sql,
                 fragment.params or {},
@@ -998,13 +1011,18 @@ class JumpView(BaseView):
                     {fragment_sql}
                 )
             """)
-            all_params.update(fragment_params)
-
+            params.update(fragment_params)
         sql = f"""
         WITH jump_items AS (
             {" UNION ALL ".join(union_parts)}
         )
-        SELECT *
+        SELECT
+            type,
+            label,
+            description,
+            url,
+            search_text,
+            display_name
         FROM jump_items
         WHERE :q = ''
            OR search_text LIKE :pattern COLLATE NOCASE
@@ -1025,10 +1043,40 @@ class JumpView(BaseView):
             label
         LIMIT 101
         """
-        result = await self.ds.get_internal_database().execute(sql, all_params)
-        rows = list(result.rows)
-        truncated = len(rows) > 100
-        if truncated:
+        db = (
+            self.ds.get_internal_database()
+            if database_name is None
+            else self.ds.get_database(database_name)
+        )
+        result = await db.execute(sql, params)
+        return list(result.rows)
+
+    async def get(self, request):
+        q = request.args.get("q", "").strip()
+        terms = q.split()
+        pattern = "%" + "%".join(terms) + "%" if terms else "%"
+        fragments = await self._fragments(request)
+
+        fragments_by_database = {}
+        for index, fragment in enumerate(fragments):
+            fragments_by_database.setdefault(fragment.database, []).append(
+                (index, fragment)
+            )
+
+        rows = []
+        truncated = False
+        for database_name, indexed_fragments in fragments_by_database.items():
+            database_rows = await self._rows_for_database(
+                database_name, indexed_fragments, q, pattern
+            )
+            if len(database_rows) > 100:
+                truncated = True
+                database_rows = database_rows[:100]
+            rows.extend(database_rows)
+        rows.sort(key=lambda row: self._sort_key(row, q))
+
+        if len(rows) > 100:
+            truncated = True
             rows = rows[:100]
 
         matches = []
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 84015b46..a51684ab 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -14,7 +14,7 @@ Unreleased
 - Fixed a Safari bug with the table search mechanism triggered by pressing ``/``. (:issue:`2724`)
 - New "Jump to..." menu item, always visible, for triggering the previously undocumented ``/`` menu. (:issue:`2725`)
 - The ``/`` jump-to search interface now covers databases, views, canned queries and plugin-provided items in addition to tables. The endpoint backing it has been renamed from ``/-/tables`` to ``/-/jump``.
-- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL that queries the internal catalog. Each row returned by this hook includes a ``url`` value, which can be a string starting with ``/`` or a JSON object describing a call to one of the :ref:`internals_datasette_urls` methods.
+- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL. ``JumpSQL`` queries run against Datasette's internal database by default, or can target another database using the optional ``database=`` argument. Datasette groups these queries by database and executes one ``UNION ALL`` query for each database. Each row returned by this hook includes a ``url`` value, which can be a string starting with ``/`` or a JSON object describing a call to one of the :ref:`internals_datasette_urls` methods.
 - ``datasette.jump.JumpSQL.menu_item()`` is a shortcut for adding individual jump menu items that are not backed by resources in the internal catalog.
 - New :ref:`javascript_plugins_makeJumpSections` JavaScript plugin hook, allowing plugins to add custom blank-state sections to the jump-to menu before the user has typed a query.
 - Jump menu results now show their ``type`` as a category label, and can show optional longer ``description`` text for individual results.
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 4d8e980f..e2789112 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1884,7 +1884,7 @@ Examples: `datasette-search-all <https://datasette.io/plugins/datasette-search-a
 .. _plugin_hook_jump_items_sql:
 
 jump_items_sql(datasette, actor, request)
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+-----------------------------------------
 
 ``datasette`` - :ref:`internals_datasette`
     You can use this to access plugin configuration options via ``datasette.plugin_config(your_plugin_name)``, or to execute SQL queries.
@@ -1897,7 +1897,11 @@ jump_items_sql(datasette, actor, request)
 
 This hook allows plugins to add extra results to Datasette's ``/`` jump menu, which is powered by the ``/-/jump`` JSON endpoint.
 
-Return a ``datasette.jump.JumpSQL`` object, or a list of ``JumpSQL`` objects. Each ``JumpSQL`` object wraps a SQL query to be combined with Datasette's own databases, tables, views and canned query results.
+Return a ``datasette.jump.JumpSQL`` object, or a list of ``JumpSQL`` objects. Each ``JumpSQL`` object wraps a SQL query to be searched alongside Datasette's own databases, tables, views and canned query results.
+
+``JumpSQL`` queries run against Datasette's internal database by default. To run a query against another database, pass its name as the optional ``database=`` argument. For example, ``JumpSQL(database="content", sql="...")`` runs against the ``content`` database.
+
+Datasette groups ``JumpSQL`` queries by database and executes one ``UNION ALL`` query for each database.
 
 The SQL query must return these columns:
 
@@ -1940,7 +1944,7 @@ This example adds a "Plugin dashboard" result for signed-in users:
             display_name="Plugin dashboard",
         )
 
-Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before combining SQL fragments from different plugins.
+Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before adding the SQL fragment to the per-database ``UNION ALL`` query.
 
 ``JumpSQL.menu_item(...)`` is a shortcut for adding a single jump menu item from Python code. It accepts the keyword arguments shown above.
 
diff --git a/tests/test_jump.py b/tests/test_jump.py
index adb8626c..f60af0fd 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -143,6 +143,10 @@ async def test_jump_respects_resource_permissions(ds_for_jump):
 
 @pytest.mark.asyncio
 async def test_jump_sql_menu_item_helper(ds_for_jump):
+    assert JumpSQL("SELECT 1").database is None
+    assert JumpSQL("SELECT 1", database="content").database == "content"
+    assert JumpSQL("SELECT 1", None, "content").database == "content"
+
     fragment = JumpSQL.menu_item(
         label="Plugin dashboard",
         url="/-/plugin-dashboard",
@@ -253,6 +257,155 @@ async def test_jump_uses_plugin_sql_with_namespaced_parameters(ds_for_jump):
     ]
 
 
+@pytest.mark.asyncio
+async def test_jump_sql_unions_fragments_by_database(ds_for_jump, monkeypatch):
+    class JumpPlugin:
+        @hookimpl
+        def jump_items_sql(self, datasette, actor, request):
+            return [
+                JumpSQL(sql="""
+                    SELECT
+                        'plugin' AS type,
+                        'first-unioned-item' AS label,
+                        NULL AS description,
+                        '/-/first-unioned-item' AS url,
+                        'unioned item' AS search_text,
+                        NULL AS display_name
+                    """),
+                JumpSQL(sql="""
+                    SELECT
+                        'plugin' AS type,
+                        'second-unioned-item' AS label,
+                        NULL AS description,
+                        '/-/second-unioned-item' AS url,
+                        'unioned item' AS search_text,
+                        NULL AS display_name
+                    """),
+                JumpSQL(
+                    """
+                    SELECT
+                        'plugin' AS type,
+                        'content-first-unioned-item' AS label,
+                        NULL AS description,
+                        '/-/content-first-unioned-item' AS url,
+                        'unioned item' AS search_text,
+                        NULL AS display_name
+                    """,
+                    None,
+                    "content",
+                ),
+                JumpSQL(
+                    database="content",
+                    sql="""
+                    SELECT
+                        'plugin' AS type,
+                        'content-second-unioned-item' AS label,
+                        NULL AS description,
+                        '/-/content-second-unioned-item' AS url,
+                        'unioned item' AS search_text,
+                        NULL AS display_name
+                    """,
+                ),
+            ]
+
+    internal_db = ds_for_jump.get_internal_database()
+    original_execute = internal_db.execute
+    internal_jump_query_sql = []
+
+    async def internal_execute_with_recording(sql, *args, **kwargs):
+        if "unioned-item" in sql:
+            internal_jump_query_sql.append(sql)
+        return await original_execute(sql, *args, **kwargs)
+
+    monkeypatch.setattr(internal_db, "execute", internal_execute_with_recording)
+
+    content_db = ds_for_jump.get_database("content")
+    original_content_execute = content_db.execute
+    content_jump_query_sql = []
+
+    async def content_execute_with_recording(sql, *args, **kwargs):
+        if "unioned-item" in sql:
+            content_jump_query_sql.append(sql)
+        return await original_content_execute(sql, *args, **kwargs)
+
+    monkeypatch.setattr(content_db, "execute", content_execute_with_recording)
+
+    plugin = JumpPlugin()
+    pm.register(plugin, name="test-jump-union-plugin")
+    try:
+        response = await ds_for_jump.client.get(
+            "/-/jump.json?q=unioned", actor={"id": "alice"}
+        )
+    finally:
+        pm.unregister(name="test-jump-union-plugin")
+
+    assert response.status_code == 200
+    assert len(internal_jump_query_sql) == 1
+    assert " UNION ALL " in internal_jump_query_sql[0]
+    assert len(content_jump_query_sql) == 1
+    assert " UNION ALL " in content_jump_query_sql[0]
+    assert {match["name"] for match in response.json()["matches"]} == {
+        "content-first-unioned-item",
+        "content-second-unioned-item",
+        "first-unioned-item",
+        "second-unioned-item",
+    }
+
+
+@pytest.mark.asyncio
+async def test_jump_sql_can_query_named_database(ds_for_jump):
+    content_db = ds_for_jump.get_database("content")
+    await content_db.execute_write(
+        "INSERT INTO comments (id, body) VALUES (1001, 'Named database jump target')"
+    )
+
+    class JumpPlugin:
+        @hookimpl
+        def jump_items_sql(self, datasette, actor, request):
+            return JumpSQL(
+                database="content",
+                sql="""
+                SELECT
+                    'comment' AS type,
+                    body AS label,
+                    'Comment from content database' AS description,
+                    json_object(
+                        'method', 'table',
+                        'database', 'content',
+                        'table', 'comments'
+                    ) AS url,
+                    body AS search_text,
+                    body AS display_name
+                FROM comments
+                WHERE id = :comment_id
+                """,
+                params={"comment_id": 1001},
+            )
+
+    plugin = JumpPlugin()
+    pm.register(plugin, name="test-jump-content-db-plugin")
+    try:
+        response = await ds_for_jump.client.get(
+            "/-/jump.json?q=named+database", actor={"id": "alice"}
+        )
+    finally:
+        pm.unregister(name="test-jump-content-db-plugin")
+
+    assert response.status_code == 200
+    plugin_matches = [
+        match for match in response.json()["matches"] if match["type"] == "comment"
+    ]
+    assert plugin_matches == [
+        {
+            "name": "Named database jump target",
+            "display_name": "Named database jump target",
+            "url": "/content/comments",
+            "type": "comment",
+            "description": "Comment from content database",
+        }
+    ]
+
+
 @pytest.mark.asyncio
 async def test_jump_resolves_url_descriptors_from_sql(ds_for_jump):
     class JumpPlugin:

From c1525cb467c6fe9b83329d130d3576c49149dc5a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 21:01:18 -0700
Subject: [PATCH 034/386] Improved examples in JumpSQL docs

---
 docs/plugin_hooks.rst | 43 ++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 38 insertions(+), 5 deletions(-)

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index e2789112..8f585cb1 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1897,7 +1897,7 @@ jump_items_sql(datasette, actor, request)
 
 This hook allows plugins to add extra results to Datasette's ``/`` jump menu, which is powered by the ``/-/jump`` JSON endpoint.
 
-Return a ``datasette.jump.JumpSQL`` object, or a list of ``JumpSQL`` objects. Each ``JumpSQL`` object wraps a SQL query to be searched alongside Datasette's own databases, tables, views and canned query results.
+Return a ``datasette.jump.JumpSQL`` object, or a list of ``JumpSQL`` objects. Each ``JumpSQL`` object wraps a SQL query to be searched alongside Datasette's own databases, tables, views and canned query results. The hook can also be an ``async def`` function, or return an awaitable that resolves to one of these values.
 
 ``JumpSQL`` queries run against Datasette's internal database by default. To run a query against another database, pass its name as the optional ``database=`` argument. For example, ``JumpSQL(database="content", sql="...")`` runs against the ``content`` database.
 
@@ -1923,7 +1923,9 @@ The SQL query must return these columns:
 ``display_name``
     A human-readable label for the result, or ``NULL``. Datasette returns this as ``display_name`` in the JSON API, and the jump menu shows it as the primary readable label with ``name`` shown underneath.
 
-This example adds a "Plugin dashboard" result for signed-in users:
+Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before adding the SQL fragment to the per-database ``UNION ALL`` query.
+
+This example returns a SQL fragment that searches rows from a ``dashboards`` table in the ``content`` database. The ``url`` column uses ``json_object()`` to describe a call to ``datasette.urls.row(database='content', table='dashboards', row_path=slug)``:
 
 .. code-block:: python
 
@@ -1932,7 +1934,40 @@ This example adds a "Plugin dashboard" result for signed-in users:
 
 
     @hookimpl
-    def jump_items_sql(actor):
+    def jump_items_sql(datasette, actor, request):
+        if not actor:
+            return None
+        return JumpSQL(
+            sql="""
+            SELECT
+                'dashboard' AS type,
+                slug AS label,
+                description AS description,
+                json_object(
+                    'method', 'row',
+                    'database', 'content',
+                    'table', 'dashboards',
+                    'row_path', slug
+                ) AS url,
+                slug || ' ' || COALESCE(title, '') || ' ' || COALESCE(description, '') AS search_text,
+                title AS display_name
+            FROM dashboards
+            WHERE owner_id = :actor_id
+            """,
+            params={"actor_id": actor["id"]},
+            database="content",
+        )
+
+This example uses the ``JumpSQL.menu_item()`` shortcut to add a single "Plugin dashboard" result for signed-in users:
+
+.. code-block:: python
+
+    from datasette import hookimpl
+    from datasette.jump import JumpSQL
+
+
+    @hookimpl
+    def jump_items_sql(datasette, actor, request):
         if not actor:
             return None
         return JumpSQL.menu_item(
@@ -1944,8 +1979,6 @@ This example adds a "Plugin dashboard" result for signed-in users:
             display_name="Plugin dashboard",
         )
 
-Use ``params=`` to pass SQL parameters. Datasette will automatically namespace those parameters before adding the SQL fragment to the per-database ``UNION ALL`` query.
-
 ``JumpSQL.menu_item(...)`` is a shortcut for adding a single jump menu item from Python code. It accepts the keyword arguments shown above.
 
 .. _plugin_actions:

From b9cb8e9a30417b66ad0f1ad04c926c3f2e6cf164 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 23 May 2026 21:14:35 -0700
Subject: [PATCH 035/386] Tweaked JumpSQL changelog, refs #2731

---
 docs/changelog.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index a51684ab..37dd4e9d 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -14,10 +14,9 @@ Unreleased
 - Fixed a Safari bug with the table search mechanism triggered by pressing ``/``. (:issue:`2724`)
 - New "Jump to..." menu item, always visible, for triggering the previously undocumented ``/`` menu. (:issue:`2725`)
 - The ``/`` jump-to search interface now covers databases, views, canned queries and plugin-provided items in addition to tables. The endpoint backing it has been renamed from ``/-/tables`` to ``/-/jump``.
-- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL. ``JumpSQL`` queries run against Datasette's internal database by default, or can target another database using the optional ``database=`` argument. Datasette groups these queries by database and executes one ``UNION ALL`` query for each database. Each row returned by this hook includes a ``url`` value, which can be a string starting with ``/`` or a JSON object describing a call to one of the :ref:`internals_datasette_urls` methods.
+- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL. ``JumpSQL`` queries run against Datasette's internal database by default, or can target another database using the optional ``database=`` argument.
 - ``datasette.jump.JumpSQL.menu_item()`` is a shortcut for adding individual jump menu items that are not backed by resources in the internal catalog.
 - New :ref:`javascript_plugins_makeJumpSections` JavaScript plugin hook, allowing plugins to add custom blank-state sections to the jump-to menu before the user has typed a query.
-- Jump menu results now show their ``type`` as a category label, and can show optional longer ``description`` text for individual results.
 - Debug menu links now appear in the jump-to menu instead of the top-right app menu, with descriptions for each debug item.
 - New documented :ref:`datasette.fixtures.populate_fixture_database(conn) <datasette_fixtures_populate_fixture_database>` helper for creating the fixture database tables used by Datasette's own tests, intended for plugin test suites.
 

From b013aa1f7f133c93f7e2947d0224b4cd9fcd520a Mon Sep 17 00:00:00 2001
From: wheelman <alcaminohot09@gmail.com>
Date: Sun, 24 May 2026 09:51:13 +0530
Subject: [PATCH 036/386] Add CORS headers to /db?sql= query redirect (#2730)

Closes #2728
---
 datasette/views/database.py |  6 ++++--
 tests/test_api.py           | 11 +++++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index faf870d0..0cf93832 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -61,8 +61,10 @@ class DatabaseView(View):
             if request.url_vars.get("format"):
                 redirect_url += "." + request.url_vars.get("format")
             redirect_url += "?" + request.query_string
-            return Response.redirect(redirect_url)
-            return await QueryView()(request, datasette)
+            response = Response.redirect(redirect_url)
+            if datasette.cors:
+                add_cors_headers(response.headers)
+            return response
 
         if format_ not in ("html", "json"):
             raise NotFound("Invalid format: {}".format(format_))
diff --git a/tests/test_api.py b/tests/test_api.py
index 392030d6..f6187529 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -717,6 +717,17 @@ def test_cors(
     assert "Access-Control-Max-Age" not in response.headers
 
 
+def test_cors_query_redirect(app_client_with_cors):
+    # /db?sql= redirects to /db/-/query - the redirect itself needs CORS
+    # headers, otherwise browsers refuse to follow it cross-origin
+    response = app_client_with_cors.get(
+        "/fixtures?sql=select+1", follow_redirects=False
+    )
+    assert response.status == 302
+    assert response.headers["Location"] == "/fixtures/-/query?sql=select+1"
+    assert response.headers["Access-Control-Allow-Origin"] == "*"
+
+
 @pytest.mark.parametrize(
     "path",
     (

From d11326b250fee1ee3e2782dfc830c59b9b11756d Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 07:55:40 -0700
Subject: [PATCH 037/386] Fixes for jump to menu accessibility

VoiceOver demo video: https://github.com/simonw/datasette/pull/2737#issuecomment-4527447724

HTML explainer: https://gisthost.github.io/?cbdea138b932cdc9cac6dd1e4681a20b

Closes #2736
---
 datasette/static/navigation-search.js | 267 ++++++++++++++++++++++++--
 datasette/templates/base.html         |   2 +-
 2 files changed, 251 insertions(+), 18 deletions(-)

diff --git a/datasette/static/navigation-search.js b/datasette/static/navigation-search.js
index 29a2f143..ec2d23d8 100644
--- a/datasette/static/navigation-search.js
+++ b/datasette/static/navigation-search.js
@@ -1,10 +1,22 @@
+let navigationSearchInstanceCounter = 0;
+
 class NavigationSearch extends HTMLElement {
   constructor() {
     super();
+    this.instanceId = ++navigationSearchInstanceCounter;
+    this.inputId = `navigation-search-input-${this.instanceId}`;
+    this.instructionsId = `navigation-search-instructions-${this.instanceId}`;
+    this.listboxId = `navigation-search-results-${this.instanceId}`;
+    this.recentHeadingId = `navigation-search-recent-${this.instanceId}`;
+    this.statusId = `navigation-search-status-${this.instanceId}`;
+    this.titleId = `navigation-search-title-${this.instanceId}`;
     this.attachShadow({ mode: "open" });
     this.selectedIndex = -1;
     this.matches = [];
+    this.renderedMatches = [];
     this.debounceTimer = null;
+    this.restoreFocusTarget = null;
+    this.shouldRestoreFocus = true;
 
     this.render();
     this.setupEventListeners();
@@ -59,10 +71,15 @@ class NavigationSearch extends HTMLElement {
                 .search-input-wrapper {
                     padding: 1.25rem;
                     border-bottom: 1px solid #e5e7eb;
+                    display: flex;
+                    gap: 0.5rem;
+                    align-items: center;
                 }
 
                 .search-input {
                     width: 100%;
+                    flex: 1;
+                    min-width: 0;
                     padding: 0.75rem 1rem;
                     font-size: 1rem;
                     border: 2px solid #e5e7eb;
@@ -76,12 +93,36 @@ class NavigationSearch extends HTMLElement {
                     border-color: #2563eb;
                 }
 
+                .close-search {
+                    background: transparent;
+                    border: 1px solid transparent;
+                    border-radius: 0.375rem;
+                    color: #4b5563;
+                    cursor: pointer;
+                    flex: 0 0 auto;
+                    font: inherit;
+                    font-size: 1.5rem;
+                    height: 2.75rem;
+                    line-height: 1;
+                    width: 2.75rem;
+                }
+
+                .close-search:hover,
+                .close-search:focus {
+                    background-color: #f3f4f6;
+                    border-color: #d1d5db;
+                }
+
                 .results-container {
                     overflow-y: auto;
                     height: calc(80vh - 180px);
                     padding: 0.5rem;
                 }
 
+                .results-list:empty {
+                    display: none;
+                }
+
                 .result-item {
                     padding: 0.875rem 1rem;
                     cursor: pointer;
@@ -200,6 +241,18 @@ class NavigationSearch extends HTMLElement {
                     font-family: monospace;
                 }
 
+                .visually-hidden {
+                    border: 0;
+                    clip: rect(0 0 0 0);
+                    height: 1px;
+                    margin: -1px;
+                    overflow: hidden;
+                    padding: 0;
+                    position: absolute;
+                    white-space: nowrap;
+                    width: 1px;
+                }
+
                 /* Mobile optimizations */
                 @media (max-width: 640px) {
                     dialog {
@@ -227,19 +280,29 @@ class NavigationSearch extends HTMLElement {
                 }
             </style>
 
-            <dialog>
+            <dialog aria-modal="true" aria-labelledby="${this.titleId}">
                 <div class="search-container">
+                    <h2 id="${this.titleId}" class="visually-hidden">Jump to</h2>
+                    <p id="${this.instructionsId}" class="visually-hidden">Type to search. Use up and down arrow keys to move through results, Enter to select a result, and Escape to close this menu.</p>
+                    <div id="${this.statusId}" class="visually-hidden" aria-live="polite" aria-atomic="true"></div>
                     <div class="search-input-wrapper">
                         <input 
+                            id="${this.inputId}"
                             type="text" 
                             class="search-input" 
                             placeholder="Jump to..."
                             aria-label="Jump to"
+                            aria-describedby="${this.instructionsId}"
+                            role="combobox"
+                            aria-autocomplete="list"
+                            aria-controls="${this.listboxId}"
+                            aria-expanded="false"
                             autocomplete="off"
                             spellcheck="false"
                         >
+                        <button type="button" class="close-search" aria-label="Close jump menu">&times;</button>
                     </div>
-                    <div class="results-container" role="listbox"></div>
+                    <div class="results-container"></div>
                     <div class="hint-text">
                         <span><kbd>↑</kbd> <kbd>↓</kbd> Navigate</span>
                         <span><kbd>Enter</kbd> Select</span>
@@ -253,6 +316,7 @@ class NavigationSearch extends HTMLElement {
   setupEventListeners() {
     const dialog = this.shadowRoot.querySelector("dialog");
     const input = this.shadowRoot.querySelector(".search-input");
+    const closeButton = this.shadowRoot.querySelector(".close-search");
     const resultsContainer =
       this.shadowRoot.querySelector(".results-container");
 
@@ -268,8 +332,10 @@ class NavigationSearch extends HTMLElement {
       const trigger = e.target.closest("[data-navigation-search-open]");
       if (trigger) {
         e.preventDefault();
-        trigger.closest("details")?.removeAttribute("open");
-        this.openMenu();
+        const details = trigger.closest("details");
+        const restoreTarget = details?.querySelector("summary") || trigger;
+        details?.removeAttribute("open");
+        this.openMenu(restoreTarget);
       }
     });
 
@@ -294,6 +360,10 @@ class NavigationSearch extends HTMLElement {
       }
     });
 
+    closeButton.addEventListener("click", () => {
+      this.closeMenu();
+    });
+
     // Click on result item
     resultsContainer.addEventListener("click", (e) => {
       const clearRecent = e.target.closest("[data-clear-recent-items]");
@@ -317,6 +387,15 @@ class NavigationSearch extends HTMLElement {
       }
     });
 
+    dialog.addEventListener("cancel", (e) => {
+      e.preventDefault();
+      this.closeMenu();
+    });
+
+    dialog.addEventListener("close", () => {
+      this.onMenuClosed();
+    });
+
     // Initial load
     this.loadInitialData();
   }
@@ -331,6 +410,106 @@ class NavigationSearch extends HTMLElement {
     );
   }
 
+  setElementAttribute(element, name, value) {
+    if (!element) {
+      return;
+    }
+    if (typeof element.setAttribute === "function") {
+      element.setAttribute(name, value);
+    } else {
+      element[name] = String(value);
+    }
+  }
+
+  removeElementAttribute(element, name) {
+    if (!element) {
+      return;
+    }
+    if (typeof element.removeAttribute === "function") {
+      element.removeAttribute(name);
+    } else {
+      delete element[name];
+    }
+  }
+
+  focusRestoreTarget(trigger) {
+    if (trigger && typeof trigger.focus === "function") {
+      return trigger;
+    }
+    if (
+      document.activeElement &&
+      typeof document.activeElement.focus === "function"
+    ) {
+      return document.activeElement;
+    }
+    return null;
+  }
+
+  setNavigationTriggersExpanded(expanded) {
+    if (typeof document.querySelectorAll !== "function") {
+      return;
+    }
+    document
+      .querySelectorAll("[data-navigation-search-open]")
+      .forEach((trigger) => {
+        this.setElementAttribute(
+          trigger,
+          "aria-expanded",
+          expanded ? "true" : "false",
+        );
+      });
+  }
+
+  resultOptionId(index) {
+    return `${this.listboxId}-option-${index}`;
+  }
+
+  updateComboboxState() {
+    const dialog = this.shadowRoot.querySelector("dialog");
+    const input = this.shadowRoot.querySelector(".search-input");
+    const matches = this.renderedMatches || [];
+    this.setElementAttribute(
+      input,
+      "aria-expanded",
+      dialog && dialog.open && matches.length > 0 ? "true" : "false",
+    );
+
+    if (
+      dialog &&
+      dialog.open &&
+      this.selectedIndex >= 0 &&
+      this.selectedIndex < matches.length
+    ) {
+      this.setElementAttribute(
+        input,
+        "aria-activedescendant",
+        this.resultOptionId(this.selectedIndex),
+      );
+    } else {
+      this.removeElementAttribute(input, "aria-activedescendant");
+    }
+  }
+
+  setStatus(message) {
+    const status = this.shadowRoot.querySelector(`#${this.statusId}`);
+    if (status) {
+      status.textContent = message || "";
+    }
+  }
+
+  resultsStatus(count, truncated) {
+    if (truncated) {
+      return "More than 100 results. Keep typing to narrow the list.";
+    }
+    if (count === 0) {
+      return "No results found.";
+    }
+    if (count === 1) {
+      return "1 result.";
+    }
+    return `${count} results.`;
+  }
+
   loadInitialData() {
     const itemsAttr = this.getAttribute("items");
     if (itemsAttr) {
@@ -347,6 +526,11 @@ class NavigationSearch extends HTMLElement {
 
   handleSearch(query) {
     clearTimeout(this.debounceTimer);
+    if (query.trim()) {
+      this.setStatus("Searching...");
+    } else {
+      this.setStatus("");
+    }
 
     this.debounceTimer = setTimeout(() => {
       const url = this.getAttribute("url");
@@ -369,10 +553,16 @@ class NavigationSearch extends HTMLElement {
       this.matches = data.matches || [];
       this.selectedIndex = this.matches.length > 0 ? 0 : -1;
       this.renderResults();
+      if (query.trim()) {
+        this.setStatus(this.resultsStatus(this.matches.length, data.truncated));
+      } else {
+        this.setStatus("");
+      }
     } catch (e) {
       console.error("Failed to fetch search results:", e);
       this.matches = [];
       this.renderResults();
+      this.setStatus("Search failed.");
     }
   }
 
@@ -390,6 +580,11 @@ class NavigationSearch extends HTMLElement {
     }
     this.selectedIndex = this.matches.length > 0 ? 0 : -1;
     this.renderResults();
+    if (query.trim()) {
+      this.setStatus(this.resultsStatus(this.matches.length, false));
+    } else {
+      this.setStatus("");
+    }
   }
 
   recentItemsStorageKey() {
@@ -466,6 +661,7 @@ class NavigationSearch extends HTMLElement {
       localStorage.setItem(this.recentItemsStorageKey(), "[]");
     }
     this.renderResults();
+    this.setStatus("Recent items cleared.");
   }
 
   jumpSections() {
@@ -526,6 +722,7 @@ class NavigationSearch extends HTMLElement {
       : "";
     return `
             <div
+                id="${this.resultOptionId(index)}"
                 class="result-item ${index === this.selectedIndex ? "selected" : ""}"
                 data-index="${index}"
                 role="option"
@@ -554,6 +751,7 @@ class NavigationSearch extends HTMLElement {
     const defaultMatches = showStartContent ? [] : this.matches;
     const renderedMatches = [...recentItems, ...defaultMatches];
     this.renderedMatches = renderedMatches;
+    const emptyListbox = `<div id="${this.listboxId}" class="results-list" role="listbox" aria-label="Jump results"></div>`;
 
     if (renderedMatches.length) {
       if (
@@ -568,33 +766,43 @@ class NavigationSearch extends HTMLElement {
 
     if (renderedMatches.length === 0) {
       if (startBlock) {
-        container.innerHTML = startBlock;
+        container.innerHTML = startBlock + emptyListbox;
         this.renderJumpSections(container, jumpSections);
       } else if (showStartContent) {
-        container.innerHTML = "";
+        container.innerHTML = emptyListbox;
       } else {
         const message = input.value.trim()
           ? "No results found"
           : "Start typing to search...";
-        container.innerHTML = `<div class="no-results">${message}</div>`;
+        container.innerHTML = `${emptyListbox}<div class="no-results">${message}</div>`;
       }
+      this.updateComboboxState();
       return;
     }
 
-    const recentHtml = recentItems.length
-      ? `<div class="results-heading">Recent</div>${recentItems
+    const recentHeading = recentItems.length
+      ? `<div class="results-heading" id="${this.recentHeadingId}">Recent</div>`
+      : "";
+    const recentGroup = recentItems.length
+      ? `<div role="group" aria-labelledby="${this.recentHeadingId}">${recentItems
           .map((match, index) => this.resultItemHtml(match, index))
-          .join(
-            "",
-          )}<div class="recent-actions"><button type="button" class="clear-recent" data-clear-recent-items>Clear recent</button></div>`
+          .join("")}</div>`
+      : "";
+    const recentActions = recentItems.length
+      ? `<div class="recent-actions"><button type="button" class="clear-recent" data-clear-recent-items>Clear recent</button></div>`
       : "";
     const defaultHtml = defaultMatches
       .map((match, index) =>
         this.resultItemHtml(match, recentItems.length + index),
       )
       .join("");
-    container.innerHTML = startBlock + recentHtml + defaultHtml;
+    container.innerHTML =
+      startBlock +
+      recentHeading +
+      `<div id="${this.listboxId}" class="results-list" role="listbox" aria-label="Jump results">${recentGroup}${defaultHtml}</div>` +
+      recentActions;
     this.renderJumpSections(container, jumpSections);
+    this.updateComboboxState();
 
     // Scroll selected item into view
     if (this.selectedIndex >= 0) {
@@ -641,17 +849,20 @@ class NavigationSearch extends HTMLElement {
       // Navigate to URL
       window.location.href = match.url;
 
-      this.closeMenu();
+      this.closeMenu({ restoreFocus: false });
     }
   }
 
-  openMenu() {
+  openMenu(trigger) {
     const dialog = this.shadowRoot.querySelector("dialog");
     const input = this.shadowRoot.querySelector(".search-input");
 
+    this.restoreFocusTarget = this.focusRestoreTarget(trigger);
+    this.shouldRestoreFocus = true;
     if (!dialog.open) {
       dialog.showModal();
     }
+    this.setNavigationTriggersExpanded(true);
     input.value = "";
     input.focus();
 
@@ -659,11 +870,33 @@ class NavigationSearch extends HTMLElement {
     this.matches = [];
     this.selectedIndex = -1;
     this.renderResults();
+    this.setStatus("");
   }
 
-  closeMenu() {
+  closeMenu(options = {}) {
     const dialog = this.shadowRoot.querySelector("dialog");
-    dialog.close();
+    this.shouldRestoreFocus = options.restoreFocus !== false;
+    if (dialog.open) {
+      dialog.close();
+    } else {
+      this.onMenuClosed();
+    }
+  }
+
+  onMenuClosed() {
+    const input = this.shadowRoot.querySelector(".search-input");
+    this.setElementAttribute(input, "aria-expanded", "false");
+    this.removeElementAttribute(input, "aria-activedescendant");
+    this.setNavigationTriggersExpanded(false);
+    this.setStatus("");
+    if (
+      this.shouldRestoreFocus &&
+      this.restoreFocusTarget &&
+      typeof this.restoreFocusTarget.focus === "function"
+    ) {
+      this.restoreFocusTarget.focus();
+    }
+    this.restoreFocusTarget = null;
   }
 
   escapeHtml(text) {
diff --git a/datasette/templates/base.html b/datasette/templates/base.html
index 819715ba..e1767deb 100644
--- a/datasette/templates/base.html
+++ b/datasette/templates/base.html
@@ -30,7 +30,7 @@
         </svg></summary>
         <div class="nav-menu-inner">
             <ul>
-                <li><button type="button" class="button-as-link" data-navigation-search-open>Jump to... <kbd class="keyboard-shortcut" aria-hidden="true" title="Keyboard shortcut: press / to open Jump to">/</kbd></button></li>
+                <li><button type="button" class="button-as-link" data-navigation-search-open aria-haspopup="dialog" aria-expanded="false" aria-keyshortcuts="/">Jump to... <kbd class="keyboard-shortcut" aria-hidden="true" title="Keyboard shortcut: press / to open Jump to">/</kbd></button></li>
                 {% for link in links %}
                 <li><a href="{{ link.href }}">{{ link.label }}</a></li>
                 {% endfor %}

From 312740b97c93cadaeb1c46e92bce39afe9ecbbe4 Mon Sep 17 00:00:00 2001
From: pintaste <7534292+pintaste@users.noreply.github.com>
Date: Mon, 25 May 2026 05:11:04 +0800
Subject: [PATCH 038/386] Keyboard navigation and ARIA attributes for actions
 menus (#2727)

- Add aria-haspopup="menu" and aria-expanded to summary element
- Add role="menu" to dropdown ul, role="menuitem" and tabindex="-1" to links
- Sync aria-expanded via toggle event listener
- Focus first menu item when menu opens
- Add ArrowDown/ArrowUp navigation between menu items
- Add Escape key to close menu and return focus to summary

Refs #2738
---
 datasette/templates/_action_menu.html      |  6 +--
 datasette/templates/_close_open_menus.html | 46 ++++++++++++++++++++++
 2 files changed, 49 insertions(+), 3 deletions(-)

diff --git a/datasette/templates/_action_menu.html b/datasette/templates/_action_menu.html
index 7d1d4a55..1ae8c173 100644
--- a/datasette/templates/_action_menu.html
+++ b/datasette/templates/_action_menu.html
@@ -1,7 +1,7 @@
 {% if action_links %}
 <div class="page-action-menu">
 <details class="actions-menu-links details-menu">
-    <summary>
+    <summary aria-haspopup="menu" aria-expanded="false">
         <div class="icon-text">
             <svg class="icon" aria-labelledby="actions-menu-links-title" role="img" style="color: #fff" xmlns="http://www.w3.org/2000/svg" width="28" height="28" viewBox="0 0 28 28" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
                 <title id="actions-menu-links-title">{{ action_title }}</title>
@@ -13,9 +13,9 @@
     </summary>
     <div class="dropdown-menu">
         <div class="hook"></div>
-        <ul>
+        <ul role="menu">
             {% for link in action_links %}
-            <li><a href="{{ link.href }}">{{ link.label }}
+            <li role="none"><a href="{{ link.href }}" role="menuitem" tabindex="-1">{{ link.label }}
             {% if link.description %}
                 <p class="dropdown-description">{{ link.description }}</p>
             {% endif %}</a>
diff --git a/datasette/templates/_close_open_menus.html b/datasette/templates/_close_open_menus.html
index 3302d77d..a24633d0 100644
--- a/datasette/templates/_close_open_menus.html
+++ b/datasette/templates/_close_open_menus.html
@@ -13,4 +13,50 @@ document.body.addEventListener('click', (ev) => {
         (details) => details.open && details != detailsClickedWithin
     ).forEach(details => details.open = false);
 });
+
+/* Sync aria-expanded and add keyboard navigation for details-menu elements */
+document.querySelectorAll('details.details-menu').forEach(function(details) {
+    var summary = details.querySelector('summary');
+    details.addEventListener('toggle', function() {
+        if (summary) {
+            summary.setAttribute('aria-expanded', details.open ? 'true' : 'false');
+        }
+        if (details.open) {
+            /* Focus first menu item when menu opens */
+            var firstItem = details.querySelector('[role="menuitem"]');
+            if (firstItem) { firstItem.focus(); }
+        }
+    });
+});
+
+document.body.addEventListener('keydown', function(ev) {
+    /* Keyboard navigation for open details-menu elements */
+    var openDetails = Array.from(document.querySelectorAll('details.details-menu[open]'));
+    if (!openDetails.length) { return; }
+
+    if (ev.key === 'Escape') {
+        openDetails.forEach(function(details) {
+            details.open = false;
+            var summary = details.querySelector('summary');
+            if (summary) { summary.focus(); }
+        });
+        return;
+    }
+
+    if (ev.key === 'ArrowDown' || ev.key === 'ArrowUp') {
+        var focused = document.activeElement;
+        openDetails.forEach(function(details) {
+            var items = Array.from(details.querySelectorAll('[role="menuitem"]'));
+            if (!items.length) { return; }
+            var idx = items.indexOf(focused);
+            if (idx === -1) { return; }
+            ev.preventDefault();
+            if (ev.key === 'ArrowDown') {
+                items[(idx + 1) % items.length].focus();
+            } else {
+                items[(idx - 1 + items.length) % items.length].focus();
+            }
+        });
+    }
+});
 </script>

From 857af9293c7b5cab2b430c92b15ed16fc4e481fa Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 14:17:45 -0700
Subject: [PATCH 039/386] Release 1.0a30

Refs #1752, #2723, #2725, #2727
---
 datasette/version.py |  2 +-
 docs/changelog.rst   | 14 ++++++++------
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/datasette/version.py b/datasette/version.py
index e661e76d..494d2dc0 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a29"
+__version__ = "1.0a30"
 __version_info__ = tuple(__version__.split("."))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 37dd4e9d..65530452 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,21 +4,23 @@
 Changelog
 =========
 
-.. _unreleased:
+.. _v1_0_a30:
 
-Unreleased
-----------
+1.0a30 (2026-05-24)
+-------------------
+
+The "Jump to" menu, activated by hitting ``/`` or through the application menu, can now be extended by plugins.
 
-- Dropped Janus as a dependency, previously used to manage the write queue. This should not have any impact on plugin developers or end-users. (:issue:`1752`)
-- Fixed a bug where stale tables and other related resources were not removed from ``catalog_*`` tables when a database was removed. (:issue:`2723`)
-- Fixed a Safari bug with the table search mechanism triggered by pressing ``/``. (:issue:`2724`)
 - New "Jump to..." menu item, always visible, for triggering the previously undocumented ``/`` menu. (:issue:`2725`)
 - The ``/`` jump-to search interface now covers databases, views, canned queries and plugin-provided items in addition to tables. The endpoint backing it has been renamed from ``/-/tables`` to ``/-/jump``.
 - New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL. ``JumpSQL`` queries run against Datasette's internal database by default, or can target another database using the optional ``database=`` argument.
 - ``datasette.jump.JumpSQL.menu_item()`` is a shortcut for adding individual jump menu items that are not backed by resources in the internal catalog.
 - New :ref:`javascript_plugins_makeJumpSections` JavaScript plugin hook, allowing plugins to add custom blank-state sections to the jump-to menu before the user has typed a query.
 - Debug menu links now appear in the jump-to menu instead of the top-right app menu, with descriptions for each debug item.
+- Dropped Janus as a dependency, previously used to manage the write queue. This should not have any impact on plugin developers or end-users. (:issue:`1752`)
+- Fixed a bug where stale tables and other related resources were not removed from ``catalog_*`` tables when a database was removed. (:issue:`2723`)
 - New documented :ref:`datasette.fixtures.populate_fixture_database(conn) <datasette_fixtures_populate_fixture_database>` helper for creating the fixture database tables used by Datasette's own tests, intended for plugin test suites.
+- Keyboard accessibility and ARIA roles for actions menus, thanks `pintaste <https://github.com/pintaste>`__. (:pr:`2727`)
 
 .. _v1_0_a29:
 

From 6aaed2d9b5996151014f45cc7257a6b2c2c434b8 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 15:28:13 -0700
Subject: [PATCH 040/386] 2-space indent for HTML version of special JSON views

PR #2739
---
 datasette/views/special.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/datasette/views/special.py b/datasette/views/special.py
index 31e7f0c2..6c82983c 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -67,7 +67,7 @@ class JsonDataView(BaseView):
             context = {
                 "filename": self.filename,
                 "data": data,
-                "data_json": json.dumps(data, indent=4, default=repr),
+                "data_json": json.dumps(data, indent=2, default=repr),
             }
             # Add has_debug_permission if this view requires permissions-debug
             if self.permission == "permissions-debug":

From f3a34c5012e4a2013bc4995a8fc6eda0b2cc9601 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 15:42:49 -0700
Subject: [PATCH 041/386] Enable root permissions for latest.datasette.io

Refs #2740
---
 .github/workflows/deploy-latest.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/deploy-latest.yml b/.github/workflows/deploy-latest.yml
index 18c01fdc..7d8dd37d 100644
--- a/.github/workflows/deploy-latest.yml
+++ b/.github/workflows/deploy-latest.yml
@@ -116,7 +116,7 @@ jobs:
             --plugins-dir=plugins \
             --branch=$GITHUB_SHA \
             --version-note=$GITHUB_SHA \
-            --extra-options="--setting template_debug 1 --setting trace_debug 1 --crossdb" \
+            --extra-options="--setting template_debug 1 --setting trace_debug 1 --crossdb --root" \
             --install 'datasette-ephemeral-tables>=0.2.2' \
             --service "datasette-latest$SUFFIX" \
             --secret $LATEST_DATASETTE_SECRET

From f403ea4e53c50319967796128ba73c54fba05edd Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 16:47:49 -0700
Subject: [PATCH 042/386] No need to alias description as description

---
 docs/plugin_hooks.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 8f585cb1..2b8f5eb2 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1942,7 +1942,7 @@ This example returns a SQL fragment that searches rows from a ``dashboards`` tab
             SELECT
                 'dashboard' AS type,
                 slug AS label,
-                description AS description,
+                description,
                 json_object(
                     'method', 'row',
                     'database', 'content',

From 6cafdcb6fa57cabe5352a471b6d4b469072beb72 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 21:18:50 -0700
Subject: [PATCH 043/386] Added missing issue reference

---
 docs/changelog.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 65530452..329b4769 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -13,7 +13,7 @@ The "Jump to" menu, activated by hitting ``/`` or through the application menu,
 
 - New "Jump to..." menu item, always visible, for triggering the previously undocumented ``/`` menu. (:issue:`2725`)
 - The ``/`` jump-to search interface now covers databases, views, canned queries and plugin-provided items in addition to tables. The endpoint backing it has been renamed from ``/-/tables`` to ``/-/jump``.
-- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL. ``JumpSQL`` queries run against Datasette's internal database by default, or can target another database using the optional ``database=`` argument.
+- New :ref:`plugin_hook_jump_items_sql` plugin hook, allowing plugins to contribute additional items to the jump-to menu by returning SQL. ``JumpSQL`` queries run against Datasette's internal database by default, or can target another database using the optional ``database=`` argument. (:issue:`2731`)
 - ``datasette.jump.JumpSQL.menu_item()`` is a shortcut for adding individual jump menu items that are not backed by resources in the internal catalog.
 - New :ref:`javascript_plugins_makeJumpSections` JavaScript plugin hook, allowing plugins to add custom blank-state sections to the jump-to menu before the user has typed a query.
 - Debug menu links now appear in the jump-to menu instead of the top-right app menu, with descriptions for each debug item.

From a855a1acec758d18b5e3b217e03c3534e979157a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 22:29:49 -0700
Subject: [PATCH 044/386] Database.analyze_sql(sql) method

Experimental, we may need this for the upcoming canned query
work so that we can tell if a user should be able to save
a writable canned query by confirming they have the right
permissions to update the affected tables.

Refs #2735
---
 datasette/database.py            |   8 ++
 datasette/utils/sql_analysis.py  |  99 ++++++++++++++++
 tests/test_internals_database.py |  48 ++++++++
 tests/test_utils_sql_analysis.py | 195 +++++++++++++++++++++++++++++++
 4 files changed, 350 insertions(+)
 create mode 100644 datasette/utils/sql_analysis.py
 create mode 100644 tests/test_utils_sql_analysis.py

diff --git a/datasette/database.py b/datasette/database.py
index 66d50ffa..e7e9527e 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -25,6 +25,7 @@ from .utils import (
     table_columns,
     table_column_details,
 )
+from .utils.sql_analysis import SQLAnalysis, analyze_sql_tables
 from .utils.sqlite import sqlite_version
 from .inspect import inspect_hash
 
@@ -301,6 +302,13 @@ class Database:
             # Threaded mode - send to write thread
             return await self._send_to_write_thread(fn, isolated_connection=True)
 
+    async def analyze_sql(self, sql, params=None) -> SQLAnalysis:
+        self._check_not_closed()
+
+        return await self.execute_isolated_fn(
+            lambda conn: analyze_sql_tables(conn, sql, params, database_name=self.name)
+        )
+
     async def execute_write_fn(self, fn, block=True, transaction=True, request=None):
         self._check_not_closed()
         pending_events = []
diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
new file mode 100644
index 00000000..b5317b62
--- /dev/null
+++ b/datasette/utils/sql_analysis.py
@@ -0,0 +1,99 @@
+from dataclasses import dataclass
+from typing import Literal
+
+from datasette.utils.sqlite import sqlite3
+
+SQLTableOperation = Literal["read", "insert", "update", "delete"]
+
+
+@dataclass(frozen=True)
+class SQLTableAccess:
+    operation: SQLTableOperation
+    database: str | None
+    table: str
+    sqlite_schema: str | None
+    columns: tuple[str, ...] = ()
+    source: str | None = None
+
+
+@dataclass(frozen=True)
+class SQLAnalysis:
+    table_accesses: tuple[SQLTableAccess, ...]
+
+
+_ACTION_TO_OPERATION: dict[int, SQLTableOperation] = {
+    sqlite3.SQLITE_READ: "read",
+    sqlite3.SQLITE_INSERT: "insert",
+    sqlite3.SQLITE_UPDATE: "update",
+    sqlite3.SQLITE_DELETE: "delete",
+}
+
+
+def analyze_sql_tables(
+    conn,
+    sql: str,
+    params=None,
+    *,
+    database_name: str | None = None,
+    schema_to_database: dict[str, str] | None = None,
+) -> SQLAnalysis:
+    """
+    Return tables accessed by a SQL statement according to SQLite's authorizer.
+
+    This function is synchronous and connection-based. It temporarily installs a
+    SQLite authorizer, prepares ``EXPLAIN <sql>``, and returns the table access
+    callbacks observed while SQLite compiles the statement.
+    """
+    accesses: dict[
+        tuple[SQLTableOperation, str | None, str, str | None, str | None], set[str]
+    ] = {}
+
+    def database_for_schema(sqlite_schema):
+        if schema_to_database and sqlite_schema in schema_to_database:
+            return schema_to_database[sqlite_schema]
+        if sqlite_schema == "main" and database_name is not None:
+            return database_name
+        return sqlite_schema
+
+    def authorizer(action, arg1, arg2, sqlite_schema, source):
+        operation = _ACTION_TO_OPERATION.get(action)
+        if operation is None or arg1 is None:
+            return sqlite3.SQLITE_OK
+
+        key = (
+            operation,
+            database_for_schema(sqlite_schema),
+            arg1,
+            sqlite_schema,
+            source,
+        )
+        columns = accesses.setdefault(key, set())
+        if operation in ("read", "update") and arg2 is not None:
+            columns.add(arg2)
+        return sqlite3.SQLITE_OK
+
+    conn.set_authorizer(authorizer)
+    try:
+        conn.execute("EXPLAIN " + sql, params if params is not None else {}).fetchall()
+    finally:
+        conn.set_authorizer(None)
+
+    return SQLAnalysis(
+        table_accesses=tuple(
+            SQLTableAccess(
+                operation=operation,
+                database=database,
+                table=table,
+                sqlite_schema=sqlite_schema,
+                columns=tuple(sorted(columns)),
+                source=source,
+            )
+            for (
+                operation,
+                database,
+                table,
+                sqlite_schema,
+                source,
+            ), columns in accesses.items()
+        )
+    )
diff --git a/tests/test_internals_database.py b/tests/test_internals_database.py
index 75ae8d39..5481a398 100644
--- a/tests/test_internals_database.py
+++ b/tests/test_internals_database.py
@@ -688,6 +688,54 @@ async def test_execute_isolated(db, disable_threads):
     assert not await db.execute_isolated_fn(table_exists_checker("created_by_isolated"))
 
 
+@pytest.mark.asyncio
+async def test_analyze_sql():
+    ds = Datasette(memory=True)
+    db = ds.add_memory_database("test_analyze_sql", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+
+    analysis = await db.analyze_sql("select name from dogs where id = ?", (1,))
+
+    assert [
+        (
+            access.operation,
+            access.database,
+            access.sqlite_schema,
+            access.table,
+            access.columns,
+            access.source,
+        )
+        for access in analysis.table_accesses
+    ] == [
+        ("read", "data", "main", "dogs", ("id", "name"), None),
+    ]
+
+
+@pytest.mark.asyncio
+async def test_analyze_sql_insert_select():
+    ds = Datasette(memory=True)
+    db = ds.add_memory_database("test_analyze_sql_insert_select", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await db.execute_write("create table cats (id integer primary key, name text)")
+
+    analysis = await db.analyze_sql("insert into dogs (name) select name from cats")
+
+    assert {
+        (
+            access.operation,
+            access.database,
+            access.sqlite_schema,
+            access.table,
+            access.columns,
+            access.source,
+        )
+        for access in analysis.table_accesses
+    } == {
+        ("insert", "data", "main", "dogs", (), None),
+        ("read", "data", "main", "cats", ("name",), None),
+    }
+
+
 @pytest.mark.asyncio
 async def test_mtime_ns(db):
     assert isinstance(db.mtime_ns, int)
diff --git a/tests/test_utils_sql_analysis.py b/tests/test_utils_sql_analysis.py
new file mode 100644
index 00000000..c82fb04f
--- /dev/null
+++ b/tests/test_utils_sql_analysis.py
@@ -0,0 +1,195 @@
+import pytest
+
+from datasette.utils.sqlite import sqlite3
+from datasette.utils.sql_analysis import analyze_sql_tables
+
+
+@pytest.fixture
+def conn():
+    conn = sqlite3.connect(":memory:")
+    conn.executescript("""
+        create table dogs (id integer primary key, name text, age integer);
+        create table cats (id integer primary key, name text);
+        create table log (message text);
+        create view dog_names as select id, name from dogs;
+        create trigger dogs_after_insert after insert on dogs begin
+            update cats set name = new.name where id = new.id;
+            insert into log (message) values (new.name);
+        end;
+        create trigger dog_names_instead_of_update instead of update on dog_names begin
+            update dogs set name = new.name where id = old.id;
+        end;
+        """)
+    try:
+        yield conn
+    finally:
+        conn.close()
+
+
+def as_tuples(analysis):
+    return [
+        (
+            access.operation,
+            access.database,
+            access.sqlite_schema,
+            access.table,
+            access.columns,
+            access.source,
+        )
+        for access in analysis.table_accesses
+    ]
+
+
+def test_analyze_select_tables(conn):
+    analysis = analyze_sql_tables(
+        conn,
+        "select dogs.name, cats.name from dogs join cats on dogs.id = cats.id where dogs.age > ?",
+        (2,),
+        database_name="data",
+    )
+
+    assert set(as_tuples(analysis)) == {
+        ("read", "data", "main", "cats", ("id", "name"), None),
+        ("read", "data", "main", "dogs", ("age", "id", "name"), None),
+    }
+
+
+def test_analyze_uses_sqlite_schema_as_default_database(conn):
+    analysis = analyze_sql_tables(conn, "select name from dogs")
+
+    assert set(as_tuples(analysis)) == {
+        ("read", "main", "main", "dogs", ("name",), None),
+    }
+
+
+def test_analyze_insert_tables(conn):
+    analysis = analyze_sql_tables(
+        conn,
+        "insert into dogs (name, age) values (:name, :age)",
+        {"name": "Cleo", "age": 4},
+        database_name="data",
+    )
+
+    assert set(as_tuples(analysis)) == {
+        ("insert", "data", "main", "dogs", (), None),
+        ("read", "data", "main", "dogs", ("id", "name"), "dogs_after_insert"),
+        ("update", "data", "main", "cats", ("name",), "dogs_after_insert"),
+        ("read", "data", "main", "cats", ("id",), "dogs_after_insert"),
+        ("insert", "data", "main", "log", (), "dogs_after_insert"),
+    }
+
+
+def test_analyze_update_tables(conn):
+    analysis = analyze_sql_tables(
+        conn,
+        "update dogs set age = age + 1 where name = ?",
+        ("Cleo",),
+        database_name="data",
+    )
+
+    assert set(as_tuples(analysis)) == {
+        ("update", "data", "main", "dogs", ("age",), None),
+        ("read", "data", "main", "dogs", ("age", "name"), None),
+    }
+
+
+def test_analyze_delete_tables(conn):
+    analysis = analyze_sql_tables(
+        conn,
+        "delete from dogs where name = ?",
+        ("Cleo",),
+        database_name="data",
+    )
+
+    assert set(as_tuples(analysis)) == {
+        ("delete", "data", "main", "dogs", (), None),
+        ("read", "data", "main", "dogs", ("name",), None),
+    }
+
+
+def test_analyze_insert_select_with_cte(conn):
+    analysis = analyze_sql_tables(
+        conn,
+        """
+        with old_dogs as (
+            select name from dogs where age > :age
+        )
+        insert into cats (name)
+        select name from old_dogs
+        """,
+        {"age": 10},
+        database_name="data",
+    )
+
+    assert set(as_tuples(analysis)) == {
+        ("insert", "data", "main", "cats", (), None),
+        ("read", "data", "main", "dogs", ("age", "name"), "old_dogs"),
+    }
+
+
+def test_analyze_view_with_instead_of_trigger(conn):
+    analysis = analyze_sql_tables(
+        conn,
+        "update dog_names set name = :name where id = :id",
+        {"name": "Zelda", "id": 1},
+        database_name="data",
+    )
+
+    assert set(as_tuples(analysis)) == {
+        ("update", "data", "main", "dog_names", ("name",), None),
+        ("read", "data", "main", "dogs", ("id", "name"), "dog_names"),
+        ("read", "data", "main", "dog_names", ("id", "name"), "dog_names"),
+        (
+            "read",
+            "data",
+            "main",
+            "dog_names",
+            ("id", "name"),
+            "dog_names_instead_of_update",
+        ),
+        ("update", "data", "main", "dogs", ("name",), "dog_names_instead_of_update"),
+        ("read", "data", "main", "dogs", ("id",), "dog_names_instead_of_update"),
+    }
+
+
+def test_analyze_attached_database_tables(conn):
+    conn.execute("attach database ':memory:' as extra")
+    conn.execute("create table extra.people (id integer primary key, name text)")
+
+    analysis = analyze_sql_tables(
+        conn,
+        "insert into extra.people (name) select name from dogs",
+        database_name="data",
+        schema_to_database={"extra": "extra_db"},
+    )
+
+    assert set(as_tuples(analysis)) == {
+        ("insert", "extra_db", "extra", "people", (), None),
+        ("read", "data", "main", "dogs", ("name",), None),
+    }
+
+
+def test_analyze_invalid_sql_cleans_up_authorizer(conn):
+    with pytest.raises(sqlite3.OperationalError):
+        analyze_sql_tables(conn, "insert into missing_table values (1)")
+
+    conn.execute("select name from dogs").fetchall()
+
+
+def test_analyze_clears_authorizer_on_error():
+    class FakeConnection:
+        def __init__(self):
+            self.authorizers = []
+
+        def set_authorizer(self, authorizer):
+            self.authorizers.append(authorizer)
+
+        def execute(self, sql, params):
+            raise sqlite3.OperationalError("bad SQL")
+
+    conn = FakeConnection()
+
+    with pytest.raises(sqlite3.OperationalError):
+        analyze_sql_tables(conn, "bad SQL")
+
+    assert conn.authorizers[-1] is None

From daeeca6c6b8f1e46cde33f8ee84b6d73b4478b86 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 22:35:18 -0700
Subject: [PATCH 045/386] Plan internal query storage and management

Refs #2735
---
 queries-plan.md | 440 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 440 insertions(+)
 create mode 100644 queries-plan.md

diff --git a/queries-plan.md b/queries-plan.md
new file mode 100644
index 00000000..283ca866
--- /dev/null
+++ b/queries-plan.md
@@ -0,0 +1,440 @@
+# Queries in the internal database
+
+Plan for <https://github.com/simonw/datasette/issues/2735>.
+
+## Goal
+
+Move named query definitions into Datasette's internal database, so hundreds or thousands of queries can be listed, searched, permission-filtered, managed, and executed efficiently.
+
+Terminology change: these are now "queries", not "canned queries". Legacy code and documentation can mention the old name only when describing compatibility or migration.
+
+## Decisions so far
+
+- Internal table name: `queries`.
+- Query definitions should use real columns, not a JSON blob for all options.
+- Query parameter names live in a `parameters` text column as a JSON array. No default values for parameters in this pass.
+- No `queries_database_published_idx` index.
+- User-created queries require `execute-sql` and `insert-query` on the database. Writable queries additionally require matching table write permissions discovered by `Database.analyze_sql()`.
+- `publish-query` is the permission for creating or updating a query so users without `execute-sql` can execute it.
+- Add `update-query` and `delete-query`, so administrators can manage queries created by other users.
+- Remove the old `canned_queries()` hook from core. If we want compatibility later, build a separate `datasette-old-canned-queries` plugin.
+- Writable user-created queries can be supported using `Database.analyze_sql()`, provided we fail closed when analysis cannot prove the required permissions.
+
+## Current shape
+
+- Query definitions currently come from `datasette.yaml` or the `canned_queries()` plugin hook.
+- `Datasette.get_canned_queries(database_name, actor)` calls that hook every time it needs query definitions.
+- `QueryResource.resources_sql()` currently enumerates databases and calls the hook for each one, because permissions and `/-/jump` need query resources.
+- Query pages execute if the actor has `view-query` for `QueryResource(database, query)`.
+- Arbitrary SQL executes if the actor has `execute-sql` for `DatabaseResource(database)`.
+
+The main performance and architecture win is making query resource enumeration a direct SQL query against the internal database.
+
+## Proposed internal schema
+
+Start with one `queries` table.
+
+```sql
+CREATE TABLE IF NOT EXISTS queries (
+    database_name TEXT NOT NULL,
+    name TEXT NOT NULL,
+    sql TEXT NOT NULL,
+    title TEXT,
+    description TEXT,
+    description_html TEXT,
+    hide_sql INTEGER NOT NULL DEFAULT 0 CHECK (hide_sql IN (0, 1)),
+    fragment TEXT,
+    parameters TEXT NOT NULL DEFAULT '[]',
+    is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
+    published INTEGER NOT NULL DEFAULT 0 CHECK (published IN (0, 1)),
+    source TEXT NOT NULL DEFAULT 'user',
+    owner_id TEXT,
+    on_success_message TEXT,
+    on_success_message_sql TEXT,
+    on_success_redirect TEXT,
+    on_error_message TEXT,
+    on_error_redirect TEXT,
+    created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    PRIMARY KEY (database_name, name),
+    CHECK (is_write = 0 OR published = 0)
+);
+
+CREATE INDEX IF NOT EXISTS queries_owner_idx
+    ON queries(owner_id);
+```
+
+Column notes:
+
+- `database_name`, `name`, and `sql` are the routing and execution core.
+- Display fields become columns: `title`, `description`, `description_html`, `hide_sql`, and `fragment`.
+- `parameters` is a JSON array of parameter names, stored as text. This preserves explicit parameter order, but does not support labels or default values.
+- Existing writable query behavior gets columns too: `is_write`, success/error messages, success/error redirects, and `on_success_message_sql`.
+- `published` only applies to read-only queries. A writable query can still be public through explicit `view-query` permissions, but the "publish for users without execute-sql" shortcut should be read-only.
+- `source` distinguishes `user`, `config`, and `plugin` rows.
+- `owner_id` is the actor id for user-created rows. It is `NULL` for config/plugin rows.
+
+No separate index is needed on `(database_name, name)` because the primary key already creates one. Do not add a `queries_database_published_idx` index for now.
+
+`QueryResource.resources_sql()` can become:
+
+```sql
+SELECT q.database_name AS parent, q.name AS child
+FROM queries q
+JOIN catalog_databases cd ON cd.database_name = q.database_name
+```
+
+The join keeps persisted queries for detached databases from appearing as live resources.
+
+## Config and plugin migration
+
+`datasette.yaml` can continue to support `databases: {db}: queries:` blocks, but core should import them directly into the internal `queries` tables at startup:
+
+1. Ensure the internal schema exists.
+2. Delete previous `source='config'` rows.
+3. Read configured query blocks for each live database.
+4. Normalize string definitions to `{"sql": ...}`.
+5. Insert rows into `queries`, storing explicit `params` as JSON in `parameters`.
+
+Plugins should move to:
+
+```python
+await datasette.add_query(...)
+await datasette.remove_query(...)
+```
+
+Remove the old `canned_queries()` hookspec and all core calls to it. If compatibility is needed, build `datasette-old-canned-queries` later as a plugin that restores the hook and imports old hook results using `datasette.add_query()`.
+
+## Permission model
+
+Add core actions:
+
+- `insert-query`, database-level, for creating queries in a database.
+- `publish-query`, database-level, for marking read-only queries as executable by actors who lack `execute-sql`.
+- `update-query`, query-level, for modifying existing query definitions.
+- `delete-query`, query-level, for deleting existing query definitions.
+
+User-created query creation requires:
+
+- `execute-sql` on `DatabaseResource(database)`
+- `insert-query` on `DatabaseResource(database)`
+- If analysis shows the query is writable, the table-level write permissions described in the writable query section.
+
+Setting `published=1` requires:
+
+- `publish-query` on `DatabaseResource(database)`
+- The query must be read-only according to `Database.analyze_sql()`.
+
+Updating an existing query requires:
+
+- `update-query` on `QueryResource(database, query)` or default owner permission for a user-owned row.
+- If the SQL changes, also require `execute-sql` on the database.
+- If the changed SQL is writable, also require the table-level write permissions described in the writable query section.
+- If `published` changes from `0` to `1`, also require `publish-query` on the database.
+
+Deleting an existing query requires:
+
+- `delete-query` on `QueryResource(database, query)` or default owner permission for a user-owned row.
+
+Default owner permissions:
+
+- For `source='user' AND owner_id = actor.id`, grant `update-query` and `delete-query`.
+- Do not automatically grant execution if the user no longer has the execution permission described below.
+
+## Executing queries
+
+Default execution rule for read-only queries:
+
+- If `published=0`, the actor needs `execute-sql` on the database.
+- If `published=1`, the actor can execute the query without `execute-sql`.
+
+Default execution rule for user-created writable queries:
+
+- `published` must be `0`.
+- The actor must have `view-query`.
+- The actor must currently have every write permission required by fresh `Database.analyze_sql()` results for the query SQL.
+
+Implementation:
+
+- Remove `view-query` from the broad `DEFAULT_ALLOW_ACTIONS` set.
+- Replace it with query-aware default `view-query` permission SQL.
+- For `published=1 AND is_write=0`, emit a child-level `view-query` allow.
+- For `published=0 AND is_write=0`, emit child-level `view-query` allows for queries whose parent database is in the actor's `execute-sql` allowed resources.
+- For `is_write=1 AND source='user'`, emit `view-query` only for the owner or actors with explicit `view-query` permission, then have `QueryView` perform the fresh analysis/table-permission check before execution.
+- For trusted writable queries, preserve current behavior by emitting child-level `view-query` allows for `is_write=1 AND source IN ('config', 'plugin')` when Datasette is not running with `--default-deny`.
+
+For read-only queries this keeps `QueryView` simple: it checks `view-query` for the query resource, and the default permission hook encodes the relationship with `execute-sql`. User-created writable queries need one additional runtime permission check because their required table permissions are derived from fresh SQL analysis.
+
+Explicit deny rules should still be able to block a published query.
+
+## Writable queries
+
+Writable user-created queries should be in scope, guarded by `Database.analyze_sql()`.
+
+The secure rule: a user can create, update, or execute a writable user-created query only if they currently have the corresponding write permissions for every table the SQL can affect.
+
+`Database.analyze_sql(sql, params=None)` runs the SQL through SQLite's authorizer on an isolated connection and returns a `SQLAnalysis` object containing `SQLTableAccess` rows:
+
+- `operation`: `read`, `insert`, `update`, or `delete`
+- `database`: Datasette database name for `main`, or SQLite schema name where no Datasette mapping exists
+- `table`: affected table or view
+- `columns`: read/updated columns where SQLite reports them
+- `source`: trigger/view/CTE source when SQLite reports one
+
+Validation flow for user-created queries:
+
+1. Derive named parameters from the SQL and pass harmless placeholder values into `db.analyze_sql()` so SQLite can prepare statements with bindings.
+2. If analysis raises a SQLite error, reject the query.
+3. If every table access is `read`, treat the query as read-only and require `execute-sql` plus `insert-query`/`update-query` as described above.
+4. If any table access is `insert`, `update`, or `delete`, treat the query as writable and force `published=0`.
+5. Reject writable user-created queries that access a database other than the database they are being saved against, until `analyze_sql()` can reliably map attached SQLite schemas back to Datasette database names.
+6. For every write access returned by analysis, require the corresponding permission on `TableResource(access.database, access.table)`:
+   - `insert` -> `insert-row`
+   - `update` -> `update-row`
+   - `delete` -> `delete-row`
+7. Include write accesses reported from triggers and views, since those are real side effects.
+8. Re-run the same analysis and permission checks when SQL changes through `update_query()` or `POST .../-/update`.
+9. Re-run analysis before executing user-created writable queries, so schema or trigger changes cannot leave a previously saved query with stale permission assumptions.
+
+The user-facing API should not trust a submitted `is_write` value. It should derive `is_write` from analysis.
+
+Trusted configuration and plugin code can still call `datasette.add_query(..., is_write=True, ...)`. Those are treated as deployment/admin-authored queries. They keep the existing execution model: they require `view-query`, and the default `view-query` hook should preserve current default-open behavior for trusted writable queries while still respecting `--default-deny`.
+
+Fail closed cases for user-created writable queries:
+
+- Analysis fails.
+- Analysis reports any write operation that cannot be mapped to a Datasette table resource.
+- Analysis reports writes outside the target database.
+- The actor lacks any required table write permission.
+- `published=1` is requested.
+
+This gives us writable user-created queries without letting `execute-sql` alone become a path to create arbitrary write endpoints.
+
+## HTTP API sketch
+
+JSON endpoints should follow Datasette's existing write API style: use `POST` plus action paths such as `/-/insert`, `/-/update`, and `/-/delete`, not HTTP `PATCH` or `DELETE`.
+
+Endpoints:
+
+- `GET /{database}/-/queries` lists query definitions the actor can view or manage, probably paginated.
+- `POST /{database}/-/queries/-/insert` creates a query.
+- `GET /{database}/{query}/-/definition` returns one query definition without executing it.
+- `POST /{database}/{query}/-/update` updates one query.
+- `POST /{database}/{query}/-/delete` deletes one query.
+
+Create request:
+
+```json
+{
+  "query": {
+    "name": "top_customers",
+    "sql": "select * from customers order by revenue desc limit 20",
+    "title": "Top customers",
+    "description": "Highest revenue customers",
+    "published": false,
+    "parameters": ["region"]
+  }
+}
+```
+
+Successful create returns `201` and the created query definition:
+
+```json
+{
+  "ok": true,
+  "query": {
+    "database": "fixtures",
+    "name": "top_customers",
+    "sql": "select * from customers order by revenue desc limit 20",
+    "title": "Top customers",
+    "description": "Highest revenue customers",
+    "published": false,
+    "parameters": ["region"]
+  }
+}
+```
+
+Update request, imitating `RowUpdateView`:
+
+```json
+{
+  "update": {
+    "title": "Top customers by revenue",
+    "published": true
+  },
+  "return": true
+}
+```
+
+Successful update returns `{"ok": true}` by default. With `"return": true`, return the updated query definition:
+
+```json
+{
+  "ok": true,
+  "query": {
+    "database": "fixtures",
+    "name": "top_customers",
+    "sql": "select * from customers order by revenue desc limit 20",
+    "title": "Top customers by revenue",
+    "published": true
+  }
+}
+```
+
+Delete request:
+
+```http
+POST /{database}/{query}/-/delete
+Content-Type: application/json
+```
+
+Successful delete returns:
+
+```json
+{
+  "ok": true
+}
+```
+
+Validation:
+
+- Update bodies must be dictionaries containing an `update` dictionary, with optional `return`; invalid keys return `{"ok": false, "errors": [...]}`.
+- Validate route-safe query names.
+- Reject names that collide with a table or view in the same database, since table routes currently win over query routes.
+- Analyze user-created SQL with `Database.analyze_sql()`.
+- Use `validate_sql_select(sql)` as the read-only fast path when analysis shows only reads, but do not require it for writable queries that pass analysis and permission checks.
+- Reject magic parameters such as `:_actor_id`, `:_cookie_*`, and `:_header_*` for user-created queries.
+- Reject client-supplied `is_write`; derive it from analysis.
+- Reject writable-only success/error fields for read-only queries.
+
+## Python API sketch
+
+Add methods on `Datasette`:
+
+```python
+await datasette.add_query(
+    database,
+    name,
+    sql,
+    title=None,
+    description=None,
+    description_html=None,
+    hide_sql=False,
+    fragment=None,
+    parameters=None,
+    is_write=False,
+    published=False,
+    source="plugin",
+    owner_id=None,
+    on_success_message=None,
+    on_success_message_sql=None,
+    on_success_redirect=None,
+    on_error_message=None,
+    on_error_redirect=None,
+    replace=True,
+)
+
+await datasette.update_query(
+    database,
+    name,
+    *,
+    sql=UNCHANGED,
+    title=UNCHANGED,
+    description=UNCHANGED,
+    description_html=UNCHANGED,
+    hide_sql=UNCHANGED,
+    fragment=UNCHANGED,
+    parameters=UNCHANGED,
+    is_write=UNCHANGED,
+    published=UNCHANGED,
+    source=UNCHANGED,
+    owner_id=UNCHANGED,
+    on_success_message=UNCHANGED,
+    on_success_message_sql=UNCHANGED,
+    on_success_redirect=UNCHANGED,
+    on_error_message=UNCHANGED,
+    on_error_redirect=UNCHANGED,
+)
+
+await datasette.remove_query(database, name, source=None)
+
+await datasette.get_query(database, name)
+await datasette.get_queries(database)
+```
+
+`update_query()` should use an internal sentinel default such as `UNCHANGED = object()` so callers can distinguish "leave this column alone" from "set this column to `NULL`":
+
+```python
+await datasette.update_query(
+    "fixtures",
+    "top_customers",
+    on_success_redirect=None,
+)
+```
+
+That call should set `on_success_redirect` to SQL `NULL`; omitting `on_success_redirect` should leave the existing value unchanged.
+
+Implementation detail: build the `UPDATE` statement dynamically from fields whose value is not `UNCHANGED`, validate non-nullable fields before writing, and update `updated_at` whenever at least one field changes.
+
+The read methods should reconstruct the existing dictionary shape used by query execution and templates, with `name`, `sql`, display fields, write fields, `params`, `published`, `owner_id`, and `source`. `parameters` should be returned as the decoded JSON array and exposed as `params` where existing query execution code expects that key.
+
+## Query page save UI
+
+On `/{database}/-/query`, if the actor has both `execute-sql` and `insert-query`, show a save control for valid read-only SQL. That page already executes read-only arbitrary SQL, so the first UI can stay read-only even though the JSON API can accept writable SQL after `Database.analyze_sql()` validation.
+
+The save form should call `POST /{database}/-/queries/-/insert` and default to `published=false`.
+
+If the actor also has `publish-query`, include a publish control. The UI copy should make it clear that publishing allows people without arbitrary SQL permission to run this query.
+
+## Dedicated create query UI
+
+Add `/{database}/-/queries/-/create` for the fuller query authoring flow, including writable queries.
+
+This page should require `execute-sql` and `insert-query` to access. It should provide a SQL editor and a mode control:
+
+- Read-only
+- Writable
+
+Read-only mode can share the same fields as the arbitrary SQL save flow: name, title, description, parameters, and optional published status if the actor has `publish-query`.
+
+Writable mode should always run `Database.analyze_sql()` and show an analysis panel before saving:
+
+- detected operation
+- database and table
+- required permission
+- whether the actor has that permission
+- source, when the operation comes from a trigger or view
+
+The Save button should be disabled until analysis succeeds and every required table write permission is allowed. Writable mode should not show a publish control, because user-created writable queries cannot be published.
+
+The existing edit-SQL flow from query pages can continue to point back to arbitrary SQL. A later enhancement can add "update this query" when the actor owns it or has `update-query`.
+
+## Test plan
+
+- Internal schema creates `queries`.
+- Query parameters are stored in the `queries.parameters` text column as a JSON array of names.
+- Config `queries:` blocks import into internal tables.
+- Legacy string query definitions normalize to SQL rows.
+- The old `canned_queries()` hook is no longer called by core.
+- `QueryResource.resources_sql()` returns rows from `queries`.
+- Database page and `/-/jump` list queries from the internal DB.
+- `view-query` is no longer globally default-allowed; default query permissions come from the query-aware hook.
+- Unpublished read-only query requires `execute-sql` to execute.
+- Published read-only query can be executed without `execute-sql`.
+- Setting `published=true` requires `publish-query`.
+- User-created query requires both `execute-sql` and `insert-query`.
+- User-created writable query creation uses `Database.analyze_sql()` and requires matching `insert-row`, `update-row`, and/or `delete-row` permissions for every reported write access.
+- `/{database}/-/queries/-/create` provides the writable-query authoring UI with an analysis panel and disabled save until all required write permissions pass.
+- User-created writable query execution re-runs `Database.analyze_sql()` and re-checks table write permissions.
+- User-created writable query cannot be published.
+- Query update uses `POST /{database}/{query}/-/update` with an `{"update": {...}}` body.
+- Query delete uses `POST /{database}/{query}/-/delete`.
+- There are no `PATCH` or HTTP `DELETE` routes for query management.
+- `datasette.update_query(..., field=None)` writes `NULL`, while omitted fields are left unchanged.
+- Owner gets default `update-query` and `delete-query` for their own user-created rows.
+- Admin can manage other users' queries with `update-query` and `delete-query`.
+- User API rejects magic parameters.
+- User API rejects writable queries if analysis fails, reports writes outside the target database, or reports writes the actor is not allowed to perform.
+- Trusted config/plugin writable queries still execute through `view-query`.
+- Trusted config/plugin writable queries are not default-allowed under `--default-deny`.
+- Persisted internal DB does not expose queries for detached databases.

From 7e1abd0da4cc57be64685b6ea717457ceefbabb3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 22:37:34 -0700
Subject: [PATCH 046/386] Add internal query storage APIs

Refs #2735
---
 datasette/app.py               | 200 +++++++++++++++++++++++++++++++++
 datasette/utils/internal_db.py |  28 +++++
 tests/test_queries.py          | 123 ++++++++++++++++++++
 3 files changed, 351 insertions(+)
 create mode 100644 tests/test_queries.py

diff --git a/datasette/app.py b/datasette/app.py
index 75f05d88..518215fd 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -268,6 +268,7 @@ DEFAULT_SETTINGS = {option.name: option.default for option in SETTINGS}
 FAVICON_PATH = app_root / "datasette" / "static" / "favicon.png"
 
 DEFAULT_NOT_SET = object()
+UNCHANGED = object()
 
 
 ResourcesSQL = collections.namedtuple("ResourcesSQL", ("sql", "params"))
@@ -1007,6 +1008,205 @@ class Datasette:
             [database_name, resource_name, column_name, key, value],
         )
 
+    @staticmethod
+    def _query_row_to_dict(row):
+        if row is None:
+            return None
+        parameters = json.loads(row["parameters"] or "[]")
+        is_write = bool(row["is_write"])
+        return {
+            "database": row["database_name"],
+            "name": row["name"],
+            "sql": row["sql"],
+            "title": row["title"],
+            "description": row["description"],
+            "description_html": row["description_html"],
+            "hide_sql": bool(row["hide_sql"]),
+            "fragment": row["fragment"],
+            "params": parameters,
+            "parameters": parameters,
+            "is_write": is_write,
+            "write": is_write,
+            "published": bool(row["published"]),
+            "source": row["source"],
+            "owner_id": row["owner_id"],
+            "on_success_message": row["on_success_message"],
+            "on_success_message_sql": row["on_success_message_sql"],
+            "on_success_redirect": row["on_success_redirect"],
+            "on_error_message": row["on_error_message"],
+            "on_error_redirect": row["on_error_redirect"],
+        }
+
+    async def add_query(
+        self,
+        database,
+        name,
+        sql,
+        *,
+        title=None,
+        description=None,
+        description_html=None,
+        hide_sql=False,
+        fragment=None,
+        parameters=None,
+        is_write=False,
+        published=False,
+        source="plugin",
+        owner_id=None,
+        on_success_message=None,
+        on_success_message_sql=None,
+        on_success_redirect=None,
+        on_error_message=None,
+        on_error_redirect=None,
+        replace=True,
+    ):
+        parameters_json = json.dumps(list(parameters or []))
+        sql_statement = """
+            INSERT INTO queries (
+                database_name, name, sql, title, description, description_html,
+                hide_sql, fragment, parameters, is_write, published, source,
+                owner_id, on_success_message, on_success_message_sql,
+                on_success_redirect, on_error_message, on_error_redirect
+            ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+        """
+        if replace:
+            sql_statement += """
+                ON CONFLICT(database_name, name) DO UPDATE SET
+                    sql = excluded.sql,
+                    title = excluded.title,
+                    description = excluded.description,
+                    description_html = excluded.description_html,
+                    hide_sql = excluded.hide_sql,
+                    fragment = excluded.fragment,
+                    parameters = excluded.parameters,
+                    is_write = excluded.is_write,
+                    published = excluded.published,
+                    source = excluded.source,
+                    owner_id = excluded.owner_id,
+                    on_success_message = excluded.on_success_message,
+                    on_success_message_sql = excluded.on_success_message_sql,
+                    on_success_redirect = excluded.on_success_redirect,
+                    on_error_message = excluded.on_error_message,
+                    on_error_redirect = excluded.on_error_redirect,
+                    updated_at = CURRENT_TIMESTAMP
+            """
+        await self.get_internal_database().execute_write(
+            sql_statement,
+            [
+                database,
+                name,
+                sql,
+                title,
+                description,
+                description_html,
+                int(bool(hide_sql)),
+                fragment,
+                parameters_json,
+                int(bool(is_write)),
+                int(bool(published)),
+                source,
+                owner_id,
+                on_success_message,
+                on_success_message_sql,
+                on_success_redirect,
+                on_error_message,
+                on_error_redirect,
+            ],
+        )
+
+    async def update_query(
+        self,
+        database,
+        name,
+        *,
+        sql=UNCHANGED,
+        title=UNCHANGED,
+        description=UNCHANGED,
+        description_html=UNCHANGED,
+        hide_sql=UNCHANGED,
+        fragment=UNCHANGED,
+        parameters=UNCHANGED,
+        is_write=UNCHANGED,
+        published=UNCHANGED,
+        source=UNCHANGED,
+        owner_id=UNCHANGED,
+        on_success_message=UNCHANGED,
+        on_success_message_sql=UNCHANGED,
+        on_success_redirect=UNCHANGED,
+        on_error_message=UNCHANGED,
+        on_error_redirect=UNCHANGED,
+    ):
+        fields = {
+            "sql": sql,
+            "title": title,
+            "description": description,
+            "description_html": description_html,
+            "hide_sql": hide_sql,
+            "fragment": fragment,
+            "parameters": parameters,
+            "is_write": is_write,
+            "published": published,
+            "source": source,
+            "owner_id": owner_id,
+            "on_success_message": on_success_message,
+            "on_success_message_sql": on_success_message_sql,
+            "on_success_redirect": on_success_redirect,
+            "on_error_message": on_error_message,
+            "on_error_redirect": on_error_redirect,
+        }
+        updates = []
+        params = []
+        for field, value in fields.items():
+            if value is UNCHANGED:
+                continue
+            if field in {"hide_sql", "is_write", "published"}:
+                value = int(bool(value))
+            elif field == "parameters":
+                value = json.dumps(list(value or []))
+            updates.append(f"{field} = ?")
+            params.append(value)
+        if not updates:
+            return
+        updates.append("updated_at = CURRENT_TIMESTAMP")
+        params.extend([database, name])
+        await self.get_internal_database().execute_write(
+            """
+            UPDATE queries
+            SET {}
+            WHERE database_name = ? AND name = ?
+            """.format(", ".join(updates)),
+            params,
+        )
+
+    async def remove_query(self, database, name, source=None):
+        sql = "DELETE FROM queries WHERE database_name = ? AND name = ?"
+        params = [database, name]
+        if source is not None:
+            sql += " AND source = ?"
+            params.append(source)
+        await self.get_internal_database().execute_write(sql, params)
+
+    async def get_query(self, database, name):
+        rows = await self.get_internal_database().execute(
+            """
+            SELECT * FROM queries
+            WHERE database_name = ? AND name = ?
+            """,
+            [database, name],
+        )
+        return self._query_row_to_dict(rows.first())
+
+    async def get_queries(self, database):
+        rows = await self.get_internal_database().execute(
+            """
+            SELECT * FROM queries
+            WHERE database_name = ?
+            ORDER BY name
+            """,
+            [database],
+        )
+        return {row["name"]: self._query_row_to_dict(row) for row in rows}
+
     # Column types API
 
     async def _get_resource_column_details(self, database: str, resource: str):
diff --git a/datasette/utils/internal_db.py b/datasette/utils/internal_db.py
index df149928..9008c083 100644
--- a/datasette/utils/internal_db.py
+++ b/datasette/utils/internal_db.py
@@ -112,6 +112,34 @@ async def initialize_metadata_tables(db):
             config TEXT,
             PRIMARY KEY (database_name, resource_name, column_name)
         );
+
+        CREATE TABLE IF NOT EXISTS queries (
+            database_name TEXT NOT NULL,
+            name TEXT NOT NULL,
+            sql TEXT NOT NULL,
+            title TEXT,
+            description TEXT,
+            description_html TEXT,
+            hide_sql INTEGER NOT NULL DEFAULT 0 CHECK (hide_sql IN (0, 1)),
+            fragment TEXT,
+            parameters TEXT NOT NULL DEFAULT '[]',
+            is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
+            published INTEGER NOT NULL DEFAULT 0 CHECK (published IN (0, 1)),
+            source TEXT NOT NULL DEFAULT 'user',
+            owner_id TEXT,
+            on_success_message TEXT,
+            on_success_message_sql TEXT,
+            on_success_redirect TEXT,
+            on_error_message TEXT,
+            on_error_redirect TEXT,
+            created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+            updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+            PRIMARY KEY (database_name, name),
+            CHECK (is_write = 0 OR published = 0)
+        );
+
+        CREATE INDEX IF NOT EXISTS queries_owner_idx
+            ON queries(owner_id);
             """))
 
 
diff --git a/tests/test_queries.py b/tests/test_queries.py
new file mode 100644
index 00000000..d30fcfe7
--- /dev/null
+++ b/tests/test_queries.py
@@ -0,0 +1,123 @@
+import pytest
+
+from datasette.app import Datasette
+
+
+@pytest.mark.asyncio
+async def test_queries_internal_table_schema():
+    ds = Datasette(memory=True)
+    await ds.invoke_startup()
+    internal_db = ds.get_internal_database()
+
+    columns = [
+        row["name"]
+        for row in (
+            await internal_db.execute("select name from pragma_table_info('queries')")
+        )
+    ]
+
+    assert columns == [
+        "database_name",
+        "name",
+        "sql",
+        "title",
+        "description",
+        "description_html",
+        "hide_sql",
+        "fragment",
+        "parameters",
+        "is_write",
+        "published",
+        "source",
+        "owner_id",
+        "on_success_message",
+        "on_success_message_sql",
+        "on_success_redirect",
+        "on_error_message",
+        "on_error_redirect",
+        "created_at",
+        "updated_at",
+    ]
+
+
+@pytest.mark.asyncio
+async def test_add_get_and_remove_query():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("query_api", name="data")
+    await ds.invoke_startup()
+
+    await ds.add_query(
+        "data",
+        "top_customers",
+        "select * from customers where region = :region",
+        title="Top customers",
+        description="Customers by region",
+        hide_sql=True,
+        fragment="chart",
+        parameters=["region"],
+        published=True,
+        source="user",
+        owner_id="alice",
+    )
+
+    query = await ds.get_query("data", "top_customers")
+    assert query == {
+        "database": "data",
+        "name": "top_customers",
+        "sql": "select * from customers where region = :region",
+        "title": "Top customers",
+        "description": "Customers by region",
+        "description_html": None,
+        "hide_sql": True,
+        "fragment": "chart",
+        "params": ["region"],
+        "parameters": ["region"],
+        "is_write": False,
+        "write": False,
+        "published": True,
+        "source": "user",
+        "owner_id": "alice",
+        "on_success_message": None,
+        "on_success_message_sql": None,
+        "on_success_redirect": None,
+        "on_error_message": None,
+        "on_error_redirect": None,
+    }
+
+    assert await ds.get_queries("data") == {"top_customers": query}
+
+    await ds.remove_query("data", "top_customers")
+    assert await ds.get_query("data", "top_customers") is None
+    assert await ds.get_queries("data") == {}
+
+
+@pytest.mark.asyncio
+async def test_update_query_only_updates_provided_fields():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("query_api_update", name="data")
+    await ds.invoke_startup()
+
+    await ds.add_query(
+        "data",
+        "redirect",
+        "select 1",
+        title="Original",
+        on_success_redirect="/original",
+        parameters=["one"],
+    )
+
+    await ds.update_query(
+        "data",
+        "redirect",
+        title="Updated",
+        parameters=[],
+        on_success_redirect=None,
+    )
+
+    query = await ds.get_query("data", "redirect")
+    assert query["title"] == "Updated"
+    assert query["parameters"] == []
+    assert query["params"] == []
+    assert query["on_success_redirect"] is None
+    assert query["sql"] == "select 1"
+    assert query["published"] is False

From b4c63966f81599b635a702fd7d971837d01c8bca Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 22:40:22 -0700
Subject: [PATCH 047/386] Load saved queries into permission resources

Refs #2735
---
 datasette/app.py                          | 51 +++++++++-----
 datasette/default_permissions/__init__.py |  1 +
 datasette/default_permissions/defaults.py | 56 ++++++++++++++-
 datasette/resources.py                    | 46 ++----------
 tests/test_queries.py                     | 85 +++++++++++++++++++++++
 5 files changed, 179 insertions(+), 60 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 518215fd..d64337d1 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -572,6 +572,35 @@ class Datasette:
             # TODO(alex) is metadata.json was loaded in, and --internal is not memory, then log
             # a warning to user that they should delete their metadata.json file
 
+    async def apply_queries_config(self):
+        # Apply configured query entries from datasette.yaml to the internal table.
+        await self.get_internal_database().execute_write(
+            "DELETE FROM queries WHERE source = 'config'"
+        )
+        for dbname, db_config in ((self.config or {}).get("databases") or {}).items():
+            for query_name, query_config in (db_config.get("queries") or {}).items():
+                if not isinstance(query_config, dict):
+                    query_config = {"sql": query_config}
+                await self.add_query(
+                    dbname,
+                    query_name,
+                    query_config["sql"],
+                    title=query_config.get("title"),
+                    description=query_config.get("description"),
+                    description_html=query_config.get("description_html"),
+                    hide_sql=bool(query_config.get("hide_sql")),
+                    fragment=query_config.get("fragment"),
+                    parameters=query_config.get("params"),
+                    is_write=bool(query_config.get("write")),
+                    published=bool(query_config.get("published")),
+                    source="config",
+                    on_success_message=query_config.get("on_success_message"),
+                    on_success_message_sql=query_config.get("on_success_message_sql"),
+                    on_success_redirect=query_config.get("on_success_redirect"),
+                    on_error_message=query_config.get("on_error_message"),
+                    on_error_redirect=query_config.get("on_error_redirect"),
+                )
+
     def get_jinja_environment(self, request: Request = None) -> Environment:
         environment = self._jinja_env
         if request:
@@ -732,6 +761,7 @@ class Datasette:
             await await_me_maybe(hook)
         # Ensure internal tables and metadata are populated before startup hooks
         await self._refresh_schemas()
+        await self.apply_queries_config()
         # Load column_types from config into internal DB
         await self._apply_column_types_config()
         for hook in pm.hook.startup(datasette=self):
@@ -1439,27 +1469,10 @@ class Datasette:
         return self.static_hash("app.css")
 
     async def get_canned_queries(self, database_name, actor):
-        queries = {}
-        for more_queries in pm.hook.canned_queries(
-            datasette=self,
-            database=database_name,
-            actor=actor,
-        ):
-            more_queries = await await_me_maybe(more_queries)
-            queries.update(more_queries or {})
-        # Fix any {"name": "select ..."} queries to be {"name": {"sql": "select ..."}}
-        for key in queries:
-            if not isinstance(queries[key], dict):
-                queries[key] = {"sql": queries[key]}
-            # Also make sure "name" is available:
-            queries[key]["name"] = key
-        return queries
+        return await self.get_queries(database_name)
 
     async def get_canned_query(self, database_name, query_name, actor):
-        queries = await self.get_canned_queries(database_name, actor)
-        query = queries.get(query_name)
-        if query:
-            return query
+        return await self.get_query(database_name, query_name)
 
     def _prepare_connection(self, conn, database):
         conn.row_factory = sqlite3.Row
diff --git a/datasette/default_permissions/__init__.py b/datasette/default_permissions/__init__.py
index 9e3bb648..5a53dbe7 100644
--- a/datasette/default_permissions/__init__.py
+++ b/datasette/default_permissions/__init__.py
@@ -35,6 +35,7 @@ from .config import config_permissions_sql as config_permissions_sql
 from .defaults import (
     default_allow_sql_check as default_allow_sql_check,
     default_action_permissions_sql as default_action_permissions_sql,
+    default_query_permissions_sql as default_query_permissions_sql,
     DEFAULT_ALLOW_ACTIONS as DEFAULT_ALLOW_ACTIONS,
 )
 
diff --git a/datasette/default_permissions/defaults.py b/datasette/default_permissions/defaults.py
index 4c74219d..2613c4f4 100644
--- a/datasette/default_permissions/defaults.py
+++ b/datasette/default_permissions/defaults.py
@@ -21,7 +21,6 @@ DEFAULT_ALLOW_ACTIONS = frozenset(
         "view-database",
         "view-database-download",
         "view-table",
-        "view-query",
         "execute-sql",
     }
 )
@@ -67,3 +66,58 @@ async def default_action_permissions_sql(
         return PermissionSQL.allow(reason=reason)
 
     return None
+
+
+@hookimpl(specname="permission_resources_sql")
+async def default_query_permissions_sql(
+    datasette: "Datasette",
+    actor: Optional[dict],
+    action: str,
+) -> Optional[PermissionSQL]:
+    if action != "view-query":
+        return None
+
+    execute_sql = await datasette.allowed_resources_sql(
+        action="execute-sql", actor=actor
+    )
+    sql = execute_sql.sql
+    params = {}
+    for key, value in execute_sql.params.items():
+        new_key = f"query_execute_sql_{key}"
+        sql = sql.replace(f":{key}", f":{new_key}")
+        params[new_key] = value
+
+    trusted_writable_sql = ""
+    if not datasette.default_deny:
+        trusted_writable_sql = """
+            UNION ALL
+            SELECT database_name AS parent, name AS child, 1 AS allow,
+              'trusted writable query' AS reason
+            FROM queries
+            WHERE is_write = 1
+              AND source IN ('config', 'plugin')
+        """
+
+    return PermissionSQL(
+        sql=f"""
+        WITH execute_sql_allowed AS (
+            {sql}
+        )
+        SELECT database_name AS parent, name AS child, 1 AS allow,
+          'published query' AS reason
+        FROM queries
+        WHERE is_write = 0
+          AND published = 1
+        UNION ALL
+        SELECT q.database_name AS parent, q.name AS child, 1 AS allow,
+          'execute-sql allows query' AS reason
+        FROM queries q
+        JOIN execute_sql_allowed es
+          ON es.parent = q.database_name
+         AND es.child IS NULL
+        WHERE q.is_write = 0
+          AND q.published = 0
+        {trusted_writable_sql}
+        """,
+        params=params,
+    )
diff --git a/datasette/resources.py b/datasette/resources.py
index 236b3598..91a46d36 100644
--- a/datasette/resources.py
+++ b/datasette/resources.py
@@ -41,7 +41,7 @@ class TableResource(Resource):
 
 
 class QueryResource(Resource):
-    """A canned query in a database."""
+    """A saved query in a database."""
 
     name = "query"
     parent_class = DatabaseResource
@@ -51,42 +51,8 @@ class QueryResource(Resource):
 
     @classmethod
     async def resources_sql(cls, datasette, actor=None) -> str:
-        from datasette.plugins import pm
-        from datasette.utils import await_me_maybe
-
-        # Get all databases from catalog
-        db = datasette.get_internal_database()
-        result = await db.execute("SELECT database_name FROM catalog_databases")
-        databases = [row[0] for row in result.rows]
-
-        # Gather canned queries for this actor from all databases.
-        # This keeps allowed_resources("view-query", actor=...) consistent with
-        # actor-specific canned_queries() implementations.
-        query_pairs = []
-        for database_name in databases:
-            # Call the hook to get queries (including from config via default plugin)
-            for queries_result in pm.hook.canned_queries(
-                datasette=datasette,
-                database=database_name,
-                actor=actor,
-            ):
-                queries = await await_me_maybe(queries_result)
-                if queries:
-                    for query_name in queries.keys():
-                        query_pairs.append((database_name, query_name))
-
-        # Build SQL
-        if not query_pairs:
-            return "SELECT NULL AS parent, NULL AS child WHERE 0"
-
-        # Generate UNION ALL query
-        selects = []
-        for db_name, query_name in query_pairs:
-            # Escape single quotes by doubling them
-            db_escaped = db_name.replace("'", "''")
-            query_escaped = query_name.replace("'", "''")
-            selects.append(
-                f"SELECT '{db_escaped}' AS parent, '{query_escaped}' AS child"
-            )
-
-        return " UNION ALL ".join(selects)
+        return """
+            SELECT q.database_name AS parent, q.name AS child
+            FROM queries q
+            JOIN catalog_databases cd ON cd.database_name = q.database_name
+        """
diff --git a/tests/test_queries.py b/tests/test_queries.py
index d30fcfe7..dcebc2cd 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1,6 +1,7 @@
 import pytest
 
 from datasette.app import Datasette
+from datasette.resources import DatabaseResource, QueryResource
 
 
 @pytest.mark.asyncio
@@ -121,3 +122,87 @@ async def test_update_query_only_updates_provided_fields():
     assert query["on_success_redirect"] is None
     assert query["sql"] == "select 1"
     assert query["published"] is False
+
+
+@pytest.mark.asyncio
+async def test_config_queries_imported_to_internal_table():
+    ds = Datasette(
+        memory=True,
+        config={
+            "databases": {
+                "data": {
+                    "queries": {
+                        "configured": {
+                            "sql": "select :name as name",
+                            "title": "Configured query",
+                            "params": ["name"],
+                        }
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("query_config", name="data")
+    await ds.invoke_startup()
+
+    assert await ds.get_query("data", "configured") == {
+        "database": "data",
+        "name": "configured",
+        "sql": "select :name as name",
+        "title": "Configured query",
+        "description": None,
+        "description_html": None,
+        "hide_sql": False,
+        "fragment": None,
+        "params": ["name"],
+        "parameters": ["name"],
+        "is_write": False,
+        "write": False,
+        "published": False,
+        "source": "config",
+        "owner_id": None,
+        "on_success_message": None,
+        "on_success_message_sql": None,
+        "on_success_redirect": None,
+        "on_error_message": None,
+        "on_error_redirect": None,
+    }
+
+
+@pytest.mark.asyncio
+async def test_query_resources_come_from_internal_table():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("query_resources", name="data")
+    await ds.invoke_startup()
+    await ds.add_query("data", "internal_query", "select 1", source="user")
+
+    page = await ds.allowed_resources("view-query", actor=None)
+
+    assert [(r.parent, r.child) for r in page.resources] == [
+        ("data", "internal_query")
+    ]
+
+
+@pytest.mark.asyncio
+async def test_unpublished_query_requires_execute_sql_but_published_does_not():
+    ds = Datasette(memory=True, settings={"default_allow_sql": False})
+    ds.add_memory_database("query_permissions", name="data")
+    await ds.invoke_startup()
+    await ds.add_query("data", "unpublished", "select 1", published=False)
+    await ds.add_query("data", "published", "select 1", published=True)
+
+    assert not await ds.allowed(
+        action="execute-sql",
+        resource=DatabaseResource("data"),
+        actor=None,
+    )
+    assert not await ds.allowed(
+        action="view-query",
+        resource=QueryResource("data", "unpublished"),
+        actor=None,
+    )
+    assert await ds.allowed(
+        action="view-query",
+        resource=QueryResource("data", "published"),
+        actor=None,
+    )

From 221be2632e6516e70796c234a1f649018412cdf7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 22:41:56 -0700
Subject: [PATCH 048/386] Add query management actions and write analysis

Refs #2735
---
 datasette/app.py             | 30 +++++++++++++++
 datasette/default_actions.py | 26 +++++++++++++
 tests/test_queries.py        | 73 ++++++++++++++++++++++++++++++++++++
 3 files changed, 129 insertions(+)

diff --git a/datasette/app.py b/datasette/app.py
index d64337d1..9b7fa61e 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -93,6 +93,7 @@ from .utils import (
     module_from_path,
     move_plugins_and_allow,
     move_table_config,
+    named_parameters,
     parse_metadata,
     resolve_env_secrets,
     resolve_routes,
@@ -1237,6 +1238,35 @@ class Datasette:
         )
         return {row["name"]: self._query_row_to_dict(row) for row in rows}
 
+    async def ensure_query_write_permissions(self, database, sql, *, actor=None):
+        write_actions = {
+            "insert": "insert-row",
+            "update": "update-row",
+            "delete": "delete-row",
+        }
+        db = self.get_database(database)
+        params = {name: "" for name in named_parameters(sql)}
+        try:
+            analysis = await db.analyze_sql(sql, params)
+        except sqlite3.DatabaseError as ex:
+            raise Forbidden(f"Could not analyze query: {ex}") from ex
+
+        for access in analysis.table_accesses:
+            action = write_actions.get(access.operation)
+            if action is None:
+                continue
+            if access.database != database:
+                raise Forbidden("Writable queries may not write to attached databases")
+            if not await self.allowed(
+                action=action,
+                resource=TableResource(database=access.database, table=access.table),
+                actor=actor,
+            ):
+                raise Forbidden(
+                    f"Permission denied: need {action} on {access.database}/{access.table}"
+                )
+        return analysis
+
     # Column types API
 
     async def _get_resource_column_details(self, database: str, resource: str):
diff --git a/datasette/default_actions.py b/datasette/default_actions.py
index 149a4e5f..e0e0aee5 100644
--- a/datasette/default_actions.py
+++ b/datasette/default_actions.py
@@ -54,6 +54,20 @@ def register_actions():
             description="Create tables",
             resource_class=DatabaseResource,
         ),
+        Action(
+            name="insert-query",
+            abbr="iq",
+            description="Create saved queries",
+            resource_class=DatabaseResource,
+            also_requires="execute-sql",
+        ),
+        Action(
+            name="publish-query",
+            abbr="pq",
+            description="Publish saved queries for actors without execute-sql",
+            resource_class=DatabaseResource,
+            also_requires="insert-query",
+        ),
         # Table-level actions (child-level)
         Action(
             name="view-table",
@@ -104,4 +118,16 @@ def register_actions():
             description="View named query results",
             resource_class=QueryResource,
         ),
+        Action(
+            name="update-query",
+            abbr="uq",
+            description="Update saved queries",
+            resource_class=QueryResource,
+        ),
+        Action(
+            name="delete-query",
+            abbr="dq",
+            description="Delete saved queries",
+            resource_class=QueryResource,
+        ),
     )
diff --git a/tests/test_queries.py b/tests/test_queries.py
index dcebc2cd..01174a18 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -2,6 +2,7 @@ import pytest
 
 from datasette.app import Datasette
 from datasette.resources import DatabaseResource, QueryResource
+from datasette.utils.asgi import Forbidden
 
 
 @pytest.mark.asyncio
@@ -206,3 +207,75 @@ async def test_unpublished_query_requires_execute_sql_but_published_does_not():
         resource=QueryResource("data", "published"),
         actor=None,
     )
+
+
+@pytest.mark.asyncio
+async def test_query_actions_are_registered():
+    ds = Datasette()
+    await ds.invoke_startup()
+
+    assert ds.get_action("insert-query").resource_class is DatabaseResource
+    assert ds.get_action("publish-query").resource_class is DatabaseResource
+    assert ds.get_action("update-query").resource_class is QueryResource
+    assert ds.get_action("delete-query").resource_class is QueryResource
+
+
+@pytest.mark.asyncio
+async def test_analyze_write_query_requires_table_permissions():
+    ds = Datasette(memory=True, default_deny=True)
+    db = ds.add_memory_database("query_write_permissions", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    actor = {"id": "writer"}
+    await ds.add_query(
+        "data",
+        "write_dog",
+        "insert into dogs (name) values (:name)",
+        is_write=True,
+        source="user",
+        owner_id="writer",
+    )
+
+    with pytest.raises(Forbidden):
+        await ds.ensure_query_write_permissions(
+            "data",
+            "insert into dogs (name) values (:name)",
+            actor=actor,
+        )
+
+    ds.config = {
+        "databases": {
+            "data": {
+                "tables": {
+                    "dogs": {
+                        "permissions": {
+                            "insert-row": {"id": "writer"},
+                        }
+                    }
+                }
+            }
+        }
+    }
+
+    await ds.ensure_query_write_permissions(
+        "data",
+        "insert into dogs (name) values (:name)",
+        actor=actor,
+    )
+
+
+@pytest.mark.asyncio
+async def test_analyze_write_query_rejects_writes_to_attached_databases():
+    ds = Datasette(memory=True, default_deny=True)
+    db = ds.add_memory_database("query_attached_writes", name="data")
+    await db.execute_write("attach database ':memory:' as extra")
+    await db.execute_write("create table extra.cats (id integer primary key)")
+    await ds.invoke_startup()
+
+    with pytest.raises(Forbidden):
+        await ds.ensure_query_write_permissions(
+            "data",
+            "insert into extra.cats (id) values (1)",
+            actor={"id": "writer"},
+        )

From 4b5fac9cf7e6de589290007bf6633561eeb3f786 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 22:52:06 -0700
Subject: [PATCH 049/386] Add query management API and create UI

Refs #2735
---
 datasette/app.py                      |  37 +-
 datasette/templates/query.html        |   1 +
 datasette/templates/query_create.html |  71 ++++
 datasette/utils/actions_sql.py        |   8 +
 datasette/views/database.py           | 528 +++++++++++++++++++++++++-
 docs/authentication.rst               |  50 ++-
 tests/test_queries.py                 | 217 ++++++++++-
 7 files changed, 904 insertions(+), 8 deletions(-)
 create mode 100644 datasette/templates/query_create.html

diff --git a/datasette/app.py b/datasette/app.py
index 9b7fa61e..ce85f447 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -43,7 +43,18 @@ from jinja2.exceptions import TemplateNotFound
 from .events import Event
 from .column_types import SQLiteType
 from .views import Context
-from .views.database import database_download, DatabaseView, TableCreateView, QueryView
+from .views.database import (
+    database_download,
+    DatabaseView,
+    TableCreateView,
+    QueryView,
+    QueryCreateView,
+    QueryDeleteView,
+    QueryDefinitionView,
+    QueryInsertView,
+    QueryListView,
+    QueryUpdateView,
+)
 from .views.index import IndexView
 from .views.special import (
     JsonDataView,
@@ -2524,6 +2535,18 @@ class Datasette:
             r"/(?P<database>[^\/\.]+)(\.(?P<format>\w+))?$",
         )
         add_route(TableCreateView.as_view(self), r"/(?P<database>[^\/\.]+)/-/create$")
+        add_route(
+            QueryListView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/queries$",
+        )
+        add_route(
+            QueryCreateView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/queries/-/create$",
+        )
+        add_route(
+            QueryInsertView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/queries/-/insert$",
+        )
         add_route(
             DatabaseSchemaView.as_view(self),
             r"/(?P<database>[^\/\.]+)/-/schema(\.(?P<format>json|md))?$",
@@ -2532,6 +2555,18 @@ class Datasette:
             wrap_view(QueryView, self),
             r"/(?P<database>[^\/\.]+)/-/query(\.(?P<format>\w+))?$",
         )
+        add_route(
+            QueryDefinitionView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/(?P<query>[^\/\.]+)/-/definition$",
+        )
+        add_route(
+            QueryUpdateView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/(?P<query>[^\/\.]+)/-/update$",
+        )
+        add_route(
+            QueryDeleteView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/(?P<query>[^\/\.]+)/-/delete$",
+        )
         add_route(
             wrap_view(table_view, self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)(\.(?P<format>\w+))?$",
diff --git a/datasette/templates/query.html b/datasette/templates/query.html
index 8b405da5..7c251e2c 100644
--- a/datasette/templates/query.html
+++ b/datasette/templates/query.html
@@ -67,6 +67,7 @@
         {% if not hide_sql %}<button id="sql-format" type="button" hidden>Format SQL</button>{% endif %}
         <input type="submit" value="Run SQL"{% if canned_query_write and db_is_immutable %} disabled{% endif %}>
         {{ show_hide_hidden }}
+        {% if save_query_url %}<a href="{{ save_query_url }}" class="save-query">Save query</a>{% endif %}
         {% if canned_query and edit_sql_url %}<a href="{{ edit_sql_url }}" class="canned-query-edit-sql">Edit SQL</a>{% endif %}
     </p>
 </form>
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
new file mode 100644
index 00000000..0e6a7b37
--- /dev/null
+++ b/datasette/templates/query_create.html
@@ -0,0 +1,71 @@
+{% extends "base.html" %}
+
+{% block title %}Create query{% endblock %}
+
+{% block extra_head %}
+{{- super() -}}
+{% include "_codemirror.html" %}
+{% endblock %}
+
+{% block body_class %}query-create db-{{ database|to_css_class }}{% endblock %}
+
+{% block crumbs %}
+{{ crumbs.nav(request=request, database=database) }}
+{% endblock %}
+
+{% block content %}
+
+<h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Create query</h1>
+
+<form class="sql core" action="{{ urls.database(database) }}/-/queries/-/insert" method="post">
+    <p><label for="query-name">Name</label> <input id="query-name" name="name" type="text"></p>
+    <p><label for="query-title">Title</label> <input id="query-title" name="title" type="text"></p>
+    <p><label for="query-description">Description</label><br><textarea id="query-description" name="description" rows="3"></textarea></p>
+    <p>
+        <label><input type="radio" name="mode" value="read-only" checked> Read-only</label>
+        <label><input type="radio" name="mode" value="writable"> Writable</label>
+    </p>
+    <p><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
+    <p><label for="query-parameters">Parameters</label> <input id="query-parameters" name="parameters" type="text" value="{{ parameter_names|join(', ') }}"></p>
+    {% if can_publish %}
+        <p><label><input type="checkbox" name="published" value="1"> Published</label></p>
+    {% endif %}
+
+    <h2>Analysis</h2>
+    {% if analysis_error %}
+        <p class="message-error">{{ analysis_error }}</p>
+    {% elif analysis_rows %}
+        <div class="table-wrapper"><table>
+            <thead>
+                <tr>
+                    <th scope="col">Operation</th>
+                    <th scope="col">Database</th>
+                    <th scope="col">Table</th>
+                    <th scope="col">required permission</th>
+                    <th scope="col">Allowed</th>
+                    <th scope="col">Source</th>
+                </tr>
+            </thead>
+            <tbody>
+                {% for row in analysis_rows %}
+                    <tr>
+                        <td>{{ row.operation }}</td>
+                        <td>{{ row.database }}</td>
+                        <td>{{ row.table }}</td>
+                        <td>{{ row.required_permission }}</td>
+                        <td>{% if row.allowed is none %}{% elif row.allowed %}yes{% else %}no{% endif %}</td>
+                        <td>{{ row.source or "" }}</td>
+                    </tr>
+                {% endfor %}
+            </tbody>
+        </table></div>
+    {% else %}
+        <p>Analysis will show each affected table and required permission.</p>
+    {% endif %}
+
+    <p><input type="submit" value="Save query"{% if save_disabled %} disabled{% endif %}></p>
+</form>
+
+{% include "_codemirror_foot.html" %}
+
+{% endblock %}
diff --git a/datasette/utils/actions_sql.py b/datasette/utils/actions_sql.py
index e679ae76..891ee913 100644
--- a/datasette/utils/actions_sql.py
+++ b/datasette/utils/actions_sql.py
@@ -241,6 +241,14 @@ async def _build_single_action_sql(
                     "),",
                 ]
             )
+        else:
+            query_parts.extend(
+                [
+                    "anon_rules AS (",
+                    "  SELECT NULL AS parent, NULL AS child, 0 AS allow, NULL AS reason WHERE 0",
+                    "),",
+                ]
+            )
 
     # Continue with the cascading logic
     query_parts.extend(
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 0cf93832..f40c434c 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -12,7 +12,7 @@ import textwrap
 
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.database import QueryInterrupted
-from datasette.resources import DatabaseResource, QueryResource
+from datasette.resources import DatabaseResource, QueryResource, TableResource
 from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
@@ -302,6 +302,9 @@ class QueryContext(Context):
     allow_execute_sql: bool = field(
         metadata={"help": "Boolean indicating if custom SQL can be executed"}
     )
+    save_query_url: str = field(
+        metadata={"help": "URL to save the current arbitrary SQL as a query"}
+    )
     tables: list = field(metadata={"help": "List of table objects in the database"})
     named_parameter_values: dict = field(
         metadata={"help": "Dictionary of parameter names/values"}
@@ -417,6 +420,510 @@ async def database_download(request, datasette):
     )
 
 
+_query_name_re = re.compile(r"^[^/\.\n]+$")
+
+_query_fields = {
+    "sql",
+    "title",
+    "description",
+    "description_html",
+    "hide_sql",
+    "fragment",
+    "parameters",
+    "params",
+    "published",
+    "on_success_message",
+    "on_success_message_sql",
+    "on_success_redirect",
+    "on_error_message",
+    "on_error_redirect",
+}
+
+_query_create_fields = _query_fields | {"name", "mode", "csrftoken"}
+_query_update_fields = _query_fields
+_query_write_fields = {
+    "on_success_message",
+    "on_success_message_sql",
+    "on_success_redirect",
+    "on_error_message",
+    "on_error_redirect",
+}
+
+
+class QueryValidationError(Exception):
+    def __init__(self, message, status=400):
+        self.message = message
+        self.status = status
+
+
+def _actor_id(actor):
+    if isinstance(actor, dict):
+        return actor.get("id")
+    return None
+
+
+def _as_bool(value):
+    if isinstance(value, bool):
+        return value
+    if value is None:
+        return False
+    if isinstance(value, int):
+        return bool(value)
+    if isinstance(value, str):
+        return value.lower() in {"1", "true", "t", "yes", "on"}
+    return bool(value)
+
+
+def _derived_query_parameters(sql):
+    parameters = []
+    seen = set()
+    for parameter in derive_named_parameters(sql):
+        if parameter.startswith("_"):
+            raise QueryValidationError("Magic parameters are not allowed")
+        if parameter not in seen:
+            parameters.append(parameter)
+            seen.add(parameter)
+    return parameters
+
+
+def _coerce_query_parameters(value, derived):
+    if value is None:
+        return derived
+    if isinstance(value, str):
+        parameters = [
+            parameter.strip()
+            for parameter in re.split(r"[\s,]+", value)
+            if parameter.strip()
+        ]
+    elif isinstance(value, list):
+        parameters = value
+    else:
+        raise QueryValidationError("parameters must be a list of strings")
+    if not all(isinstance(parameter, str) for parameter in parameters):
+        raise QueryValidationError("parameters must be a list of strings")
+    if any(parameter.startswith("_") for parameter in parameters):
+        raise QueryValidationError("Magic parameters are not allowed")
+    if set(parameters) != set(derived):
+        raise QueryValidationError("parameters must match SQL named parameters")
+    return parameters
+
+
+async def _json_or_form_payload(request):
+    content_type = request.headers.get("content-type", "")
+    if content_type.startswith("application/json"):
+        body = await request.post_body()
+        try:
+            return json.loads(body or b"{}"), True
+        except json.JSONDecodeError as e:
+            raise QueryValidationError("Invalid JSON: {}".format(e))
+    return await request.post_vars(), False
+
+
+async def _check_query_name(db, name, *, existing=False):
+    if not name or not isinstance(name, str):
+        raise QueryValidationError("Query name is required")
+    if not _query_name_re.match(name):
+        raise QueryValidationError("Invalid query name")
+    if not existing and (await db.table_exists(name) or await db.view_exists(name)):
+        raise QueryValidationError("Query name conflicts with a table or view")
+
+
+async def _analyze_user_query(datasette, db, sql, *, actor, published):
+    if not sql or not isinstance(sql, str):
+        raise QueryValidationError("SQL is required")
+    derived = _derived_query_parameters(sql)
+    params = {parameter: "" for parameter in derived}
+    try:
+        analysis = await db.analyze_sql(sql, params)
+    except sqlite3.DatabaseError as ex:
+        raise QueryValidationError("Could not analyze query: {}".format(ex)) from ex
+
+    is_write = any(
+        access.operation in {"insert", "update", "delete"}
+        for access in analysis.table_accesses
+    )
+    if is_write:
+        if published:
+            raise QueryValidationError("Writable queries cannot be published")
+        try:
+            await datasette.ensure_query_write_permissions(db.name, sql, actor=actor)
+        except Forbidden as ex:
+            raise QueryValidationError(str(ex), status=403) from ex
+    else:
+        try:
+            validate_sql_select(sql)
+        except InvalidSql as ex:
+            raise QueryValidationError(str(ex)) from ex
+    return is_write, derived, analysis
+
+
+def _analysis_rows(analysis):
+    write_actions = {
+        "insert": "insert-row",
+        "update": "update-row",
+        "delete": "delete-row",
+    }
+    return [
+        {
+            "operation": access.operation,
+            "database": access.database,
+            "table": access.table,
+            "required_permission": write_actions.get(access.operation, ""),
+            "source": access.source,
+        }
+        for access in analysis.table_accesses
+    ]
+
+
+def _apply_query_data_types(data):
+    typed = dict(data)
+    for key in ("hide_sql", "published"):
+        if key in typed:
+            typed[key] = _as_bool(typed[key])
+    return typed
+
+
+async def _prepare_query_create(datasette, request, db, data):
+    invalid_keys = set(data) - _query_create_fields
+    if invalid_keys:
+        raise QueryValidationError("Invalid keys: {}".format(", ".join(invalid_keys)))
+
+    data = _apply_query_data_types(data)
+    name = data.get("name")
+    await _check_query_name(db, name)
+    if await datasette.get_query(db.name, name) is not None:
+        raise QueryValidationError("Query already exists")
+
+    published = _as_bool(data.get("published"))
+    is_write, derived, analysis = await _analyze_user_query(
+        datasette,
+        db,
+        data.get("sql"),
+        actor=request.actor,
+        published=published,
+    )
+    if published and not await datasette.allowed(
+        action="publish-query",
+        resource=DatabaseResource(db.name),
+        actor=request.actor,
+    ):
+        raise QueryValidationError("Permission denied: need publish-query", status=403)
+    if not is_write and any(data.get(field) for field in _query_write_fields):
+        raise QueryValidationError("Writable query fields require writable SQL")
+
+    parameters = _coerce_query_parameters(
+        data.get("parameters", data.get("params")),
+        derived,
+    )
+    return {
+        "name": name,
+        "sql": data["sql"],
+        "title": data.get("title"),
+        "description": data.get("description"),
+        "description_html": data.get("description_html"),
+        "hide_sql": _as_bool(data.get("hide_sql")),
+        "fragment": data.get("fragment"),
+        "parameters": parameters,
+        "is_write": is_write,
+        "published": published,
+        "source": "user",
+        "owner_id": _actor_id(request.actor),
+        "on_success_message": data.get("on_success_message"),
+        "on_success_message_sql": data.get("on_success_message_sql"),
+        "on_success_redirect": data.get("on_success_redirect"),
+        "on_error_message": data.get("on_error_message"),
+        "on_error_redirect": data.get("on_error_redirect"),
+        "analysis": analysis,
+    }
+
+
+async def _prepare_query_update(datasette, request, db, existing, update):
+    invalid_keys = set(update) - _query_update_fields
+    if invalid_keys:
+        raise QueryValidationError("Invalid keys: {}".format(", ".join(invalid_keys)))
+
+    update = _apply_query_data_types(update)
+    sql = update.get("sql", existing["sql"])
+    published = update.get("published", existing["published"])
+    query_is_write = existing["is_write"]
+    derived = _derived_query_parameters(sql)
+    parameters = None
+
+    if "sql" in update:
+        query_is_write, derived, _ = await _analyze_user_query(
+            datasette,
+            db,
+            sql,
+            actor=request.actor,
+            published=published,
+        )
+    elif published and query_is_write:
+        raise QueryValidationError("Writable queries cannot be published")
+    if published and not existing["published"]:
+        if not await datasette.allowed(
+            action="publish-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            raise QueryValidationError(
+                "Permission denied: need publish-query", status=403
+            )
+
+    if "parameters" in update or "params" in update:
+        parameters = _coerce_query_parameters(
+            update.get("parameters", update.get("params")),
+            derived,
+        )
+    elif "sql" in update:
+        parameters = derived
+
+    if not query_is_write and any(update.get(field) for field in _query_write_fields):
+        raise QueryValidationError("Writable query fields require writable SQL")
+
+    field_values = {
+        "sql": sql,
+        "title": update.get("title"),
+        "description": update.get("description"),
+        "description_html": update.get("description_html"),
+        "hide_sql": update.get("hide_sql"),
+        "fragment": update.get("fragment"),
+        "parameters": parameters,
+        "is_write": query_is_write,
+        "published": published,
+        "on_success_message": update.get("on_success_message"),
+        "on_success_message_sql": update.get("on_success_message_sql"),
+        "on_success_redirect": update.get("on_success_redirect"),
+        "on_error_message": update.get("on_error_message"),
+        "on_error_redirect": update.get("on_error_redirect"),
+    }
+    update_kwargs = {}
+    for field, value in field_values.items():
+        if field in update:
+            update_kwargs[field] = value
+    if parameters is not None:
+        update_kwargs["parameters"] = parameters
+    if "sql" in update:
+        update_kwargs["is_write"] = query_is_write
+    return update_kwargs
+
+
+class QueryListView(BaseView):
+    name = "query-list"
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        page = await self.ds.allowed_resources(
+            "view-query",
+            request.actor,
+            parent=db.name,
+            limit=1000,
+        )
+        all_queries = await self.ds.get_queries(db.name)
+        queries = [
+            all_queries[resource.child]
+            for resource in page.resources
+            if resource.child in all_queries
+        ]
+        return Response.json({"ok": True, "database": db.name, "queries": queries})
+
+
+class QueryCreateView(BaseView):
+    name = "query-create"
+    has_json_alternate = False
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        await self.ds.ensure_permission(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        )
+        await self.ds.ensure_permission(
+            action="insert-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        )
+
+        sql = request.args.get("sql") or ""
+        analysis_error = None
+        analysis_rows = []
+        parameter_names = []
+        if sql:
+            try:
+                parameter_names = _derived_query_parameters(sql)
+                params = {parameter: "" for parameter in parameter_names}
+                analysis = await db.analyze_sql(sql, params)
+                rows = _analysis_rows(analysis)
+                for row in rows:
+                    permission = row["required_permission"]
+                    if permission:
+                        row["allowed"] = await self.ds.allowed(
+                            action=permission,
+                            resource=TableResource(row["database"], row["table"]),
+                            actor=request.actor,
+                        )
+                    else:
+                        row["allowed"] = None
+                analysis_rows = rows
+            except (QueryValidationError, sqlite3.DatabaseError) as ex:
+                analysis_error = getattr(ex, "message", str(ex))
+
+        return await self.render(
+            ["query_create.html"],
+            request,
+            {
+                "database": db.name,
+                "database_color": db.color,
+                "sql": sql,
+                "parameter_names": parameter_names,
+                "can_publish": await self.ds.allowed(
+                    action="publish-query",
+                    resource=DatabaseResource(db.name),
+                    actor=request.actor,
+                ),
+                "analysis_error": analysis_error,
+                "analysis_rows": analysis_rows,
+                "save_disabled": bool(
+                    analysis_error
+                    or any(row["allowed"] is False for row in analysis_rows)
+                ),
+            },
+        )
+
+
+class QueryInsertView(BaseView):
+    name = "query-insert"
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need execute-sql"], 403)
+        if not await self.ds.allowed(
+            action="insert-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need insert-query"], 403)
+
+        try:
+            data, is_json = await _json_or_form_payload(request)
+            if not isinstance(data, dict):
+                raise QueryValidationError("JSON must be a dictionary")
+            query_data = data.get("query") if is_json else data
+            if not isinstance(query_data, dict):
+                raise QueryValidationError("JSON must contain a query dictionary")
+            prepared = await _prepare_query_create(self.ds, request, db, query_data)
+        except QueryValidationError as ex:
+            return _error([ex.message], ex.status)
+
+        prepared.pop("analysis")
+        name = prepared.pop("name")
+        try:
+            await self.ds.add_query(db.name, name, replace=False, **prepared)
+        except sqlite3.IntegrityError as ex:
+            return _error([str(ex)], 400)
+
+        query = await self.ds.get_query(db.name, name)
+        if is_json:
+            return Response.json({"ok": True, "query": query}, status=201)
+        self.ds.add_message(request, "Query saved", self.ds.INFO)
+        return Response.redirect(self.ds.urls.path(self.ds.urls.table(db.name, name)))
+
+
+class QueryDefinitionView(BaseView):
+    name = "query-definition"
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        query_name = tilde_decode(request.url_vars["query"])
+        query = await self.ds.get_query(db.name, query_name)
+        if query is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        if not await self.ds.allowed(
+            action="view-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied"], 403)
+        return Response.json({"ok": True, "query": query})
+
+
+class QueryUpdateView(BaseView):
+    name = "query-update"
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        query_name = tilde_decode(request.url_vars["query"])
+        existing = await self.ds.get_query(db.name, query_name)
+        if existing is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        if not await self.ds.allowed(
+            action="update-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need update-query"], 403)
+
+        try:
+            data, _ = await _json_or_form_payload(request)
+            if not isinstance(data, dict):
+                raise QueryValidationError("JSON must be a dictionary")
+            invalid_keys = set(data) - {"update", "return"}
+            if invalid_keys:
+                raise QueryValidationError(
+                    "Invalid keys: {}".format(", ".join(invalid_keys))
+                )
+            update = data.get("update")
+            if not isinstance(update, dict):
+                raise QueryValidationError("JSON must contain an update dictionary")
+            if "sql" in update and not await self.ds.allowed(
+                action="execute-sql",
+                resource=DatabaseResource(db.name),
+                actor=request.actor,
+            ):
+                raise QueryValidationError(
+                    "Permission denied: need execute-sql", status=403
+                )
+            update_kwargs = await _prepare_query_update(
+                self.ds, request, db, existing, update
+            )
+        except QueryValidationError as ex:
+            return _error([ex.message], ex.status)
+
+        await self.ds.update_query(db.name, query_name, **update_kwargs)
+        if data.get("return"):
+            return Response.json(
+                {
+                    "ok": True,
+                    "query": await self.ds.get_query(db.name, query_name),
+                }
+            )
+        return Response.json({"ok": True})
+
+
+class QueryDeleteView(BaseView):
+    name = "query-delete"
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        query_name = tilde_decode(request.url_vars["query"])
+        existing = await self.ds.get_query(db.name, query_name)
+        if existing is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        if not await self.ds.allowed(
+            action="delete-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need delete-query"], 403)
+        await self.ds.remove_query(db.name, query_name)
+        return Response.json({"ok": True})
+
+
 class QueryView(View):
     async def post(self, request, datasette):
         from datasette.app import TableNotFound
@@ -741,6 +1248,11 @@ class QueryView(View):
                 resource=DatabaseResource(database=database),
                 actor=request.actor,
             )
+            allow_insert_query = await datasette.allowed(
+                action="insert-query",
+                resource=DatabaseResource(database=database),
+                actor=request.actor,
+            )
 
             show_hide_hidden = ""
             if canned_query and canned_query.get("hide_sql"):
@@ -790,6 +1302,19 @@ class QueryView(View):
                         }
                     )
                 )
+            save_query_url = None
+            if (
+                not canned_query
+                and allow_execute_sql
+                and allow_insert_query
+                and is_validated_sql
+                and ":_" not in sql
+            ):
+                save_query_url = (
+                    datasette.urls.database(database)
+                    + "/-/queries/-/create?"
+                    + urlencode({"sql": sql})
+                )
 
             async def query_actions():
                 query_actions = []
@@ -827,6 +1352,7 @@ class QueryView(View):
                         show_hide_text=show_hide_text,
                         editable=not canned_query,
                         allow_execute_sql=allow_execute_sql,
+                        save_query_url=save_query_url,
                         tables=await get_tables(datasette, request, db, allowed_dict),
                         named_parameter_values=named_parameter_values,
                         edit_sql_url=edit_sql_url,
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 7daefab7..543f069b 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1285,12 +1285,56 @@ Actor is allowed to view a table (or view) page, e.g. https://latest.datasette.i
 view-query
 ----------
 
-Actor is allowed to view (and execute) a :ref:`canned query <canned_queries>` page, e.g. https://latest.datasette.io/fixtures/pragma_cache_size - this includes executing :ref:`canned_queries_writable`.
+Actor is allowed to view (and execute) a saved query page, e.g. https://latest.datasette.io/fixtures/pragma_cache_size - this includes executing :ref:`canned_queries_writable`.
 
 ``resource`` - ``datasette.resources.QueryResource(database, query)``
     ``database`` is the name of the database (string)
-    
-    ``query`` is the name of the canned query (string)
+
+    ``query`` is the name of the query (string)
+
+.. _actions_insert_query:
+
+insert-query
+------------
+
+Actor is allowed to create saved queries in a database.
+
+``resource`` - ``datasette.resources.DatabaseResource(database)``
+    ``database`` is the name of the database (string)
+
+.. _actions_publish_query:
+
+publish-query
+-------------
+
+Actor is allowed to publish a saved read-only query so actors without ``execute-sql`` can run it.
+
+``resource`` - ``datasette.resources.DatabaseResource(database)``
+    ``database`` is the name of the database (string)
+
+.. _actions_update_query:
+
+update-query
+------------
+
+Actor is allowed to update a saved query.
+
+``resource`` - ``datasette.resources.QueryResource(database, query)``
+    ``database`` is the name of the database (string)
+
+    ``query`` is the name of the query (string)
+
+.. _actions_delete_query:
+
+delete-query
+------------
+
+Actor is allowed to delete a saved query.
+
+``resource`` - ``datasette.resources.QueryResource(database, query)``
+    ``database`` is the name of the database (string)
+
+    ``query`` is the name of the query (string)
 
 .. _actions_insert_row:
 
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 01174a18..8e802b75 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -179,9 +179,7 @@ async def test_query_resources_come_from_internal_table():
 
     page = await ds.allowed_resources("view-query", actor=None)
 
-    assert [(r.parent, r.child) for r in page.resources] == [
-        ("data", "internal_query")
-    ]
+    assert [(r.parent, r.child) for r in page.resources] == [("data", "internal_query")]
 
 
 @pytest.mark.asyncio
@@ -279,3 +277,216 @@ async def test_analyze_write_query_rejects_writes_to_attached_databases():
             "insert into extra.cats (id) values (1)",
             actor={"id": "writer"},
         )
+
+
+@pytest.mark.asyncio
+async def test_query_insert_api_creates_read_only_query():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_insert_api", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/queries/-/insert",
+        actor={"id": "root"},
+        json={
+            "query": {
+                "name": "by_name",
+                "sql": "select * from dogs where name = :name",
+                "title": "By name",
+            }
+        },
+    )
+
+    assert response.status_code == 201
+    data = response.json()
+    assert data["ok"] is True
+    assert data["query"]["name"] == "by_name"
+    assert data["query"]["parameters"] == ["name"]
+    assert data["query"]["is_write"] is False
+    assert data["query"]["source"] == "user"
+    assert data["query"]["owner_id"] == "root"
+
+
+@pytest.mark.asyncio
+async def test_query_list_and_definition_api():
+    ds = Datasette(memory=True)
+    ds.root_enabled = True
+    ds.add_memory_database("query_list_api", name="data")
+    await ds.invoke_startup()
+    await ds.add_query("data", "listed", "select 1", title="Listed", published=True)
+
+    list_response = await ds.client.get(
+        "/data/-/queries",
+        actor={"id": "root"},
+    )
+    definition_response = await ds.client.get(
+        "/data/listed/-/definition",
+        actor={"id": "root"},
+    )
+
+    assert list_response.status_code == 200
+    assert list_response.json()["queries"][0]["name"] == "listed"
+    assert definition_response.status_code == 200
+    assert definition_response.json()["query"]["title"] == "Listed"
+
+
+@pytest.mark.asyncio
+async def test_query_insert_api_publish_requires_publish_query():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-sql": {"id": "writer"},
+                        "insert-query": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("query_publish_api", name="data")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/queries/-/insert",
+        actor={"id": "writer"},
+        json={"query": {"name": "public", "sql": "select 1", "published": True}},
+    )
+
+    assert response.status_code == 403
+    assert response.json()["errors"] == ["Permission denied: need publish-query"]
+
+
+@pytest.mark.asyncio
+async def test_query_insert_api_creates_writable_query():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_write_api", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/queries/-/insert",
+        actor={"id": "root"},
+        json={
+            "query": {
+                "name": "insert_dog",
+                "sql": "insert into dogs (name) values (:name)",
+            }
+        },
+    )
+
+    assert response.status_code == 201
+    query = response.json()["query"]
+    assert query["is_write"] is True
+    assert query["published"] is False
+    assert query["parameters"] == ["name"]
+
+    bad_response = await ds.client.post(
+        "/data/-/queries/-/insert",
+        actor={"id": "root"},
+        json={
+            "query": {
+                "name": "published_insert",
+                "sql": "insert into dogs (name) values (:name)",
+                "published": True,
+            }
+        },
+    )
+
+    assert bad_response.status_code == 400
+    assert bad_response.json()["errors"] == ["Writable queries cannot be published"]
+
+
+@pytest.mark.asyncio
+async def test_query_update_and_delete_api():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    ds.add_memory_database("query_update_api", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "editable",
+        "select 1",
+        title="Original",
+        source="user",
+        owner_id="root",
+    )
+
+    update_response = await ds.client.post(
+        "/data/editable/-/update",
+        actor={"id": "root"},
+        json={
+            "update": {
+                "title": "Updated",
+                "description": "Fresh",
+                "on_success_redirect": None,
+            },
+            "return": True,
+        },
+    )
+
+    assert update_response.status_code == 200
+    updated = update_response.json()["query"]
+    assert updated["title"] == "Updated"
+    assert updated["description"] == "Fresh"
+    assert updated["on_success_redirect"] is None
+
+    delete_response = await ds.client.post(
+        "/data/editable/-/delete",
+        actor={"id": "root"},
+        json={},
+    )
+
+    assert delete_response.status_code == 200
+    assert delete_response.json() == {"ok": True}
+    assert await ds.get_query("data", "editable") is None
+
+
+@pytest.mark.asyncio
+async def test_query_insert_api_rejects_magic_parameters():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    ds.add_memory_database("query_magic_api", name="data")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/queries/-/insert",
+        actor={"id": "root"},
+        json={"query": {"name": "magic", "sql": "select :_actor_id"}},
+    )
+
+    assert response.status_code == 400
+    assert response.json()["errors"] == ["Magic parameters are not allowed"]
+
+
+@pytest.mark.asyncio
+async def test_create_query_ui_and_arbitrary_sql_save_link():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_create_ui", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    create_response = await ds.client.get(
+        "/data/-/queries/-/create?sql=select+*+from+dogs",
+        actor={"id": "root"},
+    )
+    query_response = await ds.client.get(
+        "/data/-/query?sql=select+*+from+dogs",
+        actor={"id": "root"},
+    )
+
+    assert create_response.status_code == 200
+    assert "Create query" in create_response.text
+    assert "Read-only" in create_response.text
+    assert "Writable" in create_response.text
+    assert "required permission" in create_response.text
+    assert query_response.status_code == 200
+    assert "Save query" in query_response.text
+    assert "/data/-/queries/-/create?sql=select+%2A+from+dogs" in query_response.text

From 040e42ddca047a2e616d412b733fd36de233d2b2 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 22:58:50 -0700
Subject: [PATCH 050/386] Enforce query ownership and remove canned query hook

Refs #2735
---
 datasette/default_permissions/__init__.py | 16 -----
 datasette/default_permissions/defaults.py | 30 ++++++++
 datasette/hookspecs.py                    |  5 --
 datasette/views/database.py               | 12 ++++
 tests/fixtures.py                         |  2 -
 tests/plugins/my_plugin.py                |  5 --
 tests/plugins/my_plugin_2.py              | 26 +++----
 tests/test_canned_queries.py              | 34 +++++----
 tests/test_permissions.py                 | 40 ++++-------
 tests/test_plugins.py                     | 27 ++------
 tests/test_queries.py                     | 84 +++++++++++++++++++++++
 11 files changed, 182 insertions(+), 99 deletions(-)

diff --git a/datasette/default_permissions/__init__.py b/datasette/default_permissions/__init__.py
index 5a53dbe7..a9f2d8bd 100644
--- a/datasette/default_permissions/__init__.py
+++ b/datasette/default_permissions/__init__.py
@@ -17,13 +17,6 @@ UNION/INTERSECT operations. The order of evaluation is:
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING
-
-if TYPE_CHECKING:
-    from datasette.app import Datasette
-
-from datasette import hookimpl
-
 # Re-export all hooks and public utilities
 from .restrictions import (
     actor_restrictions_sql as actor_restrictions_sql,
@@ -38,12 +31,3 @@ from .defaults import (
     default_query_permissions_sql as default_query_permissions_sql,
     DEFAULT_ALLOW_ACTIONS as DEFAULT_ALLOW_ACTIONS,
 )
-
-
-@hookimpl
-def canned_queries(datasette: "Datasette", database: str, actor) -> dict:
-    """Return canned queries defined in datasette.yaml configuration."""
-    queries = (
-        ((datasette.config or {}).get("databases") or {}).get(database) or {}
-    ).get("queries") or {}
-    return queries
diff --git a/datasette/default_permissions/defaults.py b/datasette/default_permissions/defaults.py
index 2613c4f4..9737de96 100644
--- a/datasette/default_permissions/defaults.py
+++ b/datasette/default_permissions/defaults.py
@@ -74,6 +74,22 @@ async def default_query_permissions_sql(
     actor: Optional[dict],
     action: str,
 ) -> Optional[PermissionSQL]:
+    actor_id = actor.get("id") if isinstance(actor, dict) else None
+
+    if action in {"update-query", "delete-query"}:
+        if actor_id is None:
+            return None
+        return PermissionSQL(
+            sql="""
+            SELECT database_name AS parent, name AS child, 1 AS allow,
+              'query owner' AS reason
+            FROM queries
+            WHERE source = 'user'
+              AND owner_id = :query_owner_id
+            """,
+            params={"query_owner_id": actor_id},
+        )
+
     if action != "view-query":
         return None
 
@@ -98,6 +114,19 @@ async def default_query_permissions_sql(
               AND source IN ('config', 'plugin')
         """
 
+    user_writable_sql = ""
+    if actor_id is not None:
+        params["query_owner_id"] = actor_id
+        user_writable_sql = """
+            UNION ALL
+            SELECT database_name AS parent, name AS child, 1 AS allow,
+              'query owner' AS reason
+            FROM queries
+            WHERE is_write = 1
+              AND source = 'user'
+              AND owner_id = :query_owner_id
+        """
+
     return PermissionSQL(
         sql=f"""
         WITH execute_sql_allowed AS (
@@ -118,6 +147,7 @@ async def default_query_permissions_sql(
         WHERE q.is_write = 0
           AND q.published = 0
         {trusted_writable_sql}
+        {user_writable_sql}
         """,
         params=params,
     )
diff --git a/datasette/hookspecs.py b/datasette/hookspecs.py
index cf95abcb..a4067eaa 100644
--- a/datasette/hookspecs.py
+++ b/datasette/hookspecs.py
@@ -137,11 +137,6 @@ def permission_resources_sql(datasette, actor, action):
     """
 
 
-@hookspec
-def canned_queries(datasette, database, actor):
-    """Return a dictionary of canned query definitions or an awaitable function that returns them"""
-
-
 @hookspec
 def register_magic_parameters(datasette):
     """Return a list of (name, function) magic parameter functions"""
diff --git a/datasette/views/database.py b/datasette/views/database.py
index f40c434c..2cdaab9f 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -945,6 +945,18 @@ class QueryView(View):
             # That should not have happened
             raise DatasetteError("Unexpected table found on POST", status=404)
 
+        if not await datasette.allowed(
+            action="view-query",
+            resource=QueryResource(database=db.name, query=canned_query["name"]),
+            actor=request.actor,
+        ):
+            raise Forbidden("You do not have permission to view this query")
+
+        if canned_query.get("write") and canned_query.get("source") == "user":
+            await datasette.ensure_query_write_permissions(
+                db.name, canned_query["sql"], actor=request.actor
+            )
+
         # If database is immutable, return an error
         if not db.is_mutable:
             raise Forbidden("Database is immutable")
diff --git a/tests/fixtures.py b/tests/fixtures.py
index 71884294..8ab3633f 100644
--- a/tests/fixtures.py
+++ b/tests/fixtures.py
@@ -35,7 +35,6 @@ EXPECTED_PLUGINS = [
         "hooks": [
             "actor_from_request",
             "asgi_wrapper",
-            "canned_queries",
             "database_actions",
             "extra_body_script",
             "extra_css_urls",
@@ -68,7 +67,6 @@ EXPECTED_PLUGINS = [
         "hooks": [
             "actor_from_request",
             "asgi_wrapper",
-            "canned_queries",
             "extra_js_urls",
             "extra_template_vars",
             "handle_exception",
diff --git a/tests/plugins/my_plugin.py b/tests/plugins/my_plugin.py
index 4e401c07..1dd9ed3e 100644
--- a/tests/plugins/my_plugin.py
+++ b/tests/plugins/my_plugin.py
@@ -314,11 +314,6 @@ def startup(datasette):
     _ = (Response, Forbidden, NotFound, hookimpl, actor_matches_allow)
 
 
-@hookimpl
-def canned_queries(datasette, database, actor):
-    return {"from_hook": f"select 1, '{actor['id'] if actor else 'null'}' as actor_id"}
-
-
 @hookimpl
 def register_magic_parameters():
     from uuid import uuid4
diff --git a/tests/plugins/my_plugin_2.py b/tests/plugins/my_plugin_2.py
index 9e8d9b2b..e3d3e760 100644
--- a/tests/plugins/my_plugin_2.py
+++ b/tests/plugins/my_plugin_2.py
@@ -139,20 +139,20 @@ def startup(datasette):
         datasette._startup_catalog_databases = [
             row["database_name"] for row in catalog_rows
         ]
-
-    return inner
-
-
-@hookimpl
-def canned_queries(datasette, database):
-    async def inner():
-        return {
-            "from_async_hook": "select {}".format(
-                (
-                    await datasette.get_database(database).execute("select 1 + 1")
-                ).first()[0]
+        for database in datasette.databases:
+            await datasette.add_query(
+                database,
+                "from_hook",
+                "select 1, 'null' as actor_id",
+                source="plugin",
+            )
+            result = await datasette.get_database(database).execute("select 1 + 1")
+            await datasette.add_query(
+                database,
+                "from_async_hook",
+                "select {}".format(result.first()[0]),
+                source="plugin",
             )
-        }
 
     return inner
 
diff --git a/tests/test_canned_queries.py b/tests/test_canned_queries.py
index 5e36a87a..e06ad189 100644
--- a/tests/test_canned_queries.py
+++ b/tests/test_canned_queries.py
@@ -1,10 +1,16 @@
 from bs4 import BeautifulSoup as Soup
+from asgiref.sync import async_to_sync
 import json
 import pytest
 import re
 from .fixtures import make_app_client
 
 
+def update_query(client, name, **kwargs):
+    async_to_sync(client.ds.invoke_startup)()
+    async_to_sync(client.ds.update_query)("data", name, **kwargs)
+
+
 @pytest.fixture
 def canned_write_client(tmpdir):
     template_dir = tmpdir / "canned_write_templates"
@@ -153,9 +159,7 @@ def test_insert_error(canned_write_client):
     )
     assert [["UNIQUE constraint failed: names.rowid", 3]] == messages
     # How about with a custom error message?
-    canned_write_client.ds.config["databases"]["data"]["queries"][
-        "add_name_specify_id"
-    ]["on_error_message"] = "ERROR"
+    update_query(canned_write_client, "add_name_specify_id", on_error_message="ERROR")
     response = canned_write_client.post(
         "/data/add_name_specify_id",
         {"rowid": 1, "name": "Should fail"},
@@ -327,12 +331,16 @@ def magic_parameters_client():
     ],
 )
 def test_magic_parameters(magic_parameters_client, magic_parameter, expected_re):
-    magic_parameters_client.ds.config["databases"]["data"]["queries"]["runme_post"][
-        "sql"
-    ] = f"insert into logs (line) values (:{magic_parameter})"
-    magic_parameters_client.ds.config["databases"]["data"]["queries"]["runme_get"][
-        "sql"
-    ] = f"select :{magic_parameter} as result"
+    update_query(
+        magic_parameters_client,
+        "runme_post",
+        sql=f"insert into logs (line) values (:{magic_parameter})",
+    )
+    update_query(
+        magic_parameters_client,
+        "runme_get",
+        sql=f"select :{magic_parameter} as result",
+    )
     cookies = {
         "ds_actor": magic_parameters_client.actor_cookie({"id": "root"}),
         "foo": "bar",
@@ -366,9 +374,11 @@ def test_magic_parameters(magic_parameters_client, magic_parameter, expected_re)
 @pytest.mark.parametrize("use_csrf", [True, False])
 @pytest.mark.parametrize("return_json", [True, False])
 def test_magic_parameters_csrf_json(magic_parameters_client, use_csrf, return_json):
-    magic_parameters_client.ds.config["databases"]["data"]["queries"]["runme_post"][
-        "sql"
-    ] = "insert into logs (line) values (:_header_host)"
+    update_query(
+        magic_parameters_client,
+        "runme_post",
+        sql="insert into logs (line) values (:_header_host)",
+    )
     qs = ""
     if return_json:
         qs = "?_json=1"
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 8166532f..04800ed3 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -1,4 +1,5 @@
 import collections
+from asgiref.sync import async_to_sync
 from datasette.app import Datasette
 from datasette.cli import cli
 from datasette.default_permissions import restrictions_allow_action
@@ -609,6 +610,10 @@ def test_padlocks_on_database_page(cascade_app_client):
     previous_config = cascade_app_client.ds.config
     try:
         cascade_app_client.ds.config = config
+        async_to_sync(cascade_app_client.ds.invoke_startup)()
+        async_to_sync(cascade_app_client.ds.add_query)(
+            "fixtures", "query_two", "select 2", source="config"
+        )
         response = cascade_app_client.get(
             "/fixtures",
             cookies={"ds_actor": cascade_app_client.actor_cookie({"id": "test"})},
@@ -624,6 +629,7 @@ def test_padlocks_on_database_page(cascade_app_client):
         assert ">simple_view</a></li>" in response.text
     finally:
         cascade_app_client.ds.config = previous_config
+        async_to_sync(cascade_app_client.ds.remove_query)("fixtures", "query_two")
 
 
 @pytest.mark.asyncio
@@ -954,39 +960,20 @@ async def test_permissions_in_config(
 
 
 @pytest.mark.asyncio
-async def test_allowed_resources_view_query_includes_actor_specific_canned_queries():
-    """
-    Actor-specific canned queries should be listed by allowed_resources("view-query").
-
-    This test is intentionally explicit about the previous bug:
-    - the canned query only exists for actor "alice"
-    - the permission rule only allows actor "alice" to view it
-    - allowed() succeeds for that specific query resource
-    - allowed_resources("view-query", actor) must include the same query
-
-    Before the fix, QueryResource.resources_sql() called canned_queries(..., actor=None),
-    so the query was omitted from resource enumeration and allowed_resources() returned
-    an empty list even though allowed() returned True.
-    """
+async def test_allowed_resources_view_query_includes_actor_specific_query_permissions():
     from datasette import hookimpl
     from datasette.permissions import PermissionSQL
     from datasette.resources import QueryResource
 
-    class ActorSpecificQueryPlugin:
-        __name__ = "ActorSpecificQueryPlugin"
-
-        @hookimpl
-        def canned_queries(self, datasette, database, actor):
-            if database == "testdb" and actor and actor.get("id") == "alice":
-                return {"user_only": {"sql": "select 1 as n"}}
-            return {}
+    class ActorSpecificQueryPermissionPlugin:
+        __name__ = "ActorSpecificQueryPermissionPlugin"
 
         @hookimpl
         def permission_resources_sql(self, datasette, actor, action):
             if action == "view-query" and actor and actor.get("id") == "alice":
                 return PermissionSQL(sql="""
                         SELECT 'testdb' AS parent, 'user_only' AS child, 1 AS allow,
-                               'alice can view her actor-specific canned query' AS reason
+                               'alice can view this query' AS reason
                     """)
             return None
 
@@ -994,9 +981,10 @@ async def test_allowed_resources_view_query_includes_actor_specific_canned_queri
     await ds.invoke_startup()
     ds.add_memory_database("testdb")
     await ds._refresh_schemas()
+    await ds.add_query("testdb", "user_only", "select 1 as n")
 
-    plugin = ActorSpecificQueryPlugin()
-    ds.pm.register(plugin, name="actor_specific_query_plugin")
+    plugin = ActorSpecificQueryPermissionPlugin()
+    ds.pm.register(plugin, name="actor_specific_query_permission_plugin")
 
     try:
         actor = {"id": "alice"}
@@ -1012,7 +1000,7 @@ async def test_allowed_resources_view_query_includes_actor_specific_canned_queri
             ("testdb", "user_only")
         ]
     finally:
-        ds.pm.unregister(name="actor_specific_query_plugin")
+        ds.pm.unregister(name="actor_specific_query_permission_plugin")
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index c5b9aef0..b5a13ae5 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -885,40 +885,27 @@ async def test_hook_startup_catalog_populated(ds_client):
 
 
 @pytest.mark.asyncio
-async def test_hook_canned_queries(ds_client):
+async def test_plugin_startup_queries(ds_client):
     queries = (await ds_client.get("/fixtures.json")).json()["queries"]
     queries_by_name = {q["name"]: q for q in queries}
-    assert {
-        "sql": "select 2",
-        "name": "from_async_hook",
-        "private": False,
-    } == queries_by_name["from_async_hook"]
-    assert {
-        "sql": "select 1, 'null' as actor_id",
-        "name": "from_hook",
-        "private": False,
-    } == queries_by_name["from_hook"]
+    assert queries_by_name["from_async_hook"]["sql"] == "select 2"
+    assert queries_by_name["from_async_hook"]["private"] is False
+    assert queries_by_name["from_hook"]["sql"] == "select 1, 'null' as actor_id"
+    assert queries_by_name["from_hook"]["private"] is False
 
 
 @pytest.mark.asyncio
-async def test_hook_canned_queries_non_async(ds_client):
+async def test_plugin_startup_query_from_hook(ds_client):
     response = await ds_client.get("/fixtures/from_hook.json?_shape=array")
     assert [{"1": 1, "actor_id": "null"}] == response.json()
 
 
 @pytest.mark.asyncio
-async def test_hook_canned_queries_async(ds_client):
+async def test_plugin_startup_query_from_async_hook(ds_client):
     response = await ds_client.get("/fixtures/from_async_hook.json?_shape=array")
     assert [{"2": 2}] == response.json()
 
 
-@pytest.mark.asyncio
-async def test_hook_canned_queries_actor(ds_client):
-    assert (
-        await ds_client.get("/fixtures/from_hook.json?_bot=1&_shape=array")
-    ).json() == [{"1": 1, "actor_id": "bot"}]
-
-
 def test_hook_register_magic_parameters(restore_working_directory):
     with make_app_client(
         extra_databases={"data.db": "create table logs (line text)"},
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 8e802b75..c6685d6c 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -490,3 +490,87 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
     assert query_response.status_code == 200
     assert "Save query" in query_response.text
     assert "/data/-/queries/-/create?sql=select+%2A+from+dogs" in query_response.text
+
+
+@pytest.mark.asyncio
+async def test_query_owner_gets_update_delete_and_writable_view_defaults():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.add_memory_database("query_owner_defaults", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "insert_dog",
+        "insert into dogs (name) values (:name)",
+        is_write=True,
+        source="user",
+        owner_id="alice",
+    )
+
+    for action in ("view-query", "update-query", "delete-query"):
+        assert await ds.allowed(
+            action=action,
+            resource=QueryResource("data", "insert_dog"),
+            actor={"id": "alice"},
+        )
+        assert not await ds.allowed(
+            action=action,
+            resource=QueryResource("data", "insert_dog"),
+            actor={"id": "bob"},
+        )
+
+
+@pytest.mark.asyncio
+async def test_user_writable_query_execution_rechecks_table_permissions():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "tables": {
+                        "dogs": {
+                            "permissions": {
+                                "insert-row": {"id": "alice"},
+                            }
+                        }
+                    }
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("query_write_execution", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "insert_dog",
+        "insert into dogs (name) values (:name)",
+        is_write=True,
+        source="user",
+        owner_id="alice",
+    )
+    await ds.add_query(
+        "data",
+        "insert_cat",
+        "insert into dogs (name) values (:name)",
+        is_write=True,
+        source="user",
+        owner_id="bob",
+    )
+
+    allowed_response = await ds.client.post(
+        "/data/insert_dog?_json=1",
+        actor={"id": "alice"},
+        data={"name": "Cleo"},
+    )
+    denied_response = await ds.client.post(
+        "/data/insert_cat?_json=1",
+        actor={"id": "bob"},
+        data={"name": "Milo"},
+    )
+
+    assert allowed_response.status_code == 200
+    assert allowed_response.json()["ok"] is True
+    assert denied_response.status_code == 403
+    rows = (await db.execute("select name from dogs")).dicts()
+    assert rows == [{"name": "Cleo"}]

From 3b26b7aff03ed78fae6a17a5a65edc5b83415dee Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 23:00:00 -0700
Subject: [PATCH 051/386] Document canned query hook removal

Refs #2735
---
 docs/plugin_hooks.rst | 73 ++-----------------------------------------
 docs/plugins.rst      |  1 -
 2 files changed, 2 insertions(+), 72 deletions(-)

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 2b8f5eb2..b2676b3e 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1212,77 +1212,8 @@ Examples: `datasette-saved-queries <https://datasette.io/plugins/datasette-saved
 canned_queries(datasette, database, actor)
 ------------------------------------------
 
-``datasette`` - :ref:`internals_datasette`
-    You can use this to access plugin configuration options via ``datasette.plugin_config(your_plugin_name)``, or to execute SQL queries.
-
-``database`` - string
-    The name of the database.
-
-``actor`` - dictionary or None
-    The currently authenticated :ref:`actor <authentication_actor>`.
-
-Use this hook to return a dictionary of additional :ref:`canned query <canned_queries>` definitions for the specified database. The return value should be the same shape as the JSON described in the :ref:`canned query <canned_queries>` documentation.
-
-.. code-block:: python
-
-    from datasette import hookimpl
-
-
-    @hookimpl
-    def canned_queries(datasette, database):
-        if database == "mydb":
-            return {
-                "my_query": {
-                    "sql": "select * from my_table where id > :min_id"
-                }
-            }
-
-The hook can alternatively return an awaitable function that returns a list. Here's an example that returns queries that have been stored in the ``saved_queries`` database table, if one exists:
-
-.. code-block:: python
-
-    from datasette import hookimpl
-
-
-    @hookimpl
-    def canned_queries(datasette, database):
-        async def inner():
-            db = datasette.get_database(database)
-            if await db.table_exists("saved_queries"):
-                results = await db.execute(
-                    "select name, sql from saved_queries"
-                )
-                return {
-                    result["name"]: {"sql": result["sql"]}
-                    for result in results
-                }
-
-        return inner
-
-The actor parameter can be used to include the currently authenticated actor in your decision. Here's an example that returns saved queries that were saved by that actor:
-
-.. code-block:: python
-
-    from datasette import hookimpl
-
-
-    @hookimpl
-    def canned_queries(datasette, database, actor):
-        async def inner():
-            db = datasette.get_database(database)
-            if actor is not None and await db.table_exists(
-                "saved_queries"
-            ):
-                results = await db.execute(
-                    "select name, sql from saved_queries where actor_id = :id",
-                    {"id": actor["id"]},
-                )
-                return {
-                    result["name"]: {"sql": result["sql"]}
-                    for result in results
-                }
-
-        return inner
+This hook has been removed. Plugins that need to add saved queries should use
+the :ref:`plugin_hook_startup` hook and call ``await datasette.add_query(...)``.
 
 Example: `datasette-saved-queries <https://datasette.io/plugins/datasette-saved-queries>`__
 
diff --git a/docs/plugins.rst b/docs/plugins.rst
index 77958205..8fa49d6d 100644
--- a/docs/plugins.rst
+++ b/docs/plugins.rst
@@ -249,7 +249,6 @@ If you run ``datasette plugins --all`` it will include default plugins that ship
             "templates": false,
             "version": null,
             "hooks": [
-                "canned_queries",
                 "permission_resources_sql"
             ]
         },

From 2d77e3334b48417c5e27355bb4016c7c76acf30e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 24 May 2026 23:06:01 -0700
Subject: [PATCH 052/386] Clean up query management test coverage

Refs #2735
---
 datasette/views/database.py  |  6 ++--
 docs/json_api.rst            | 42 +++++++++++++++++++++++
 tests/plugins/my_plugin_2.py | 14 --------
 tests/test_canned_queries.py |  4 ---
 tests/test_html.py           |  2 --
 tests/test_permissions.py    |  1 -
 tests/test_plugins.py        | 65 ++++++++++++++++++++++++++++--------
 7 files changed, 96 insertions(+), 38 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index 2cdaab9f..d521f7ad 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -697,9 +697,9 @@ async def _prepare_query_update(datasette, request, db, existing, update):
         "on_error_redirect": update.get("on_error_redirect"),
     }
     update_kwargs = {}
-    for field, value in field_values.items():
-        if field in update:
-            update_kwargs[field] = value
+    for field_name, value in field_values.items():
+        if field_name in update:
+            update_kwargs[field_name] = value
     if parameters is not None:
         update_kwargs["parameters"] = parameters
     if "sql" in update:
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 48c70af6..d5cd231c 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -505,6 +505,48 @@ The JSON write API
 
 Datasette provides a write API for JSON data. This is a POST-only API that requires an authenticated API token, see :ref:`CreateTokenView`. The token will need to have the specified :ref:`authentication_permissions`.
 
+.. _QueryListView:
+
+Listing saved queries
+~~~~~~~~~~~~~~~~~~~~~
+
+``GET /<database>/-/queries`` returns saved query definitions the actor can view.
+
+.. _QueryCreateView:
+
+Creating saved queries in the UI
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+``GET /<database>/-/queries/-/create`` provides a form for creating saved queries.
+
+.. _QueryInsertView:
+
+Creating saved queries
+~~~~~~~~~~~~~~~~~~~~~~
+
+``POST /<database>/-/queries/-/insert`` creates a saved query. This requires ``execute-sql`` and ``insert-query`` for the database.
+
+.. _QueryDefinitionView:
+
+Getting a saved query definition
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+``GET /<database>/<query>/-/definition`` returns a saved query definition without executing it.
+
+.. _QueryUpdateView:
+
+Updating saved queries
+~~~~~~~~~~~~~~~~~~~~~~
+
+``POST /<database>/<query>/-/update`` updates a saved query using a JSON body with an ``"update"`` object.
+
+.. _QueryDeleteView:
+
+Deleting saved queries
+~~~~~~~~~~~~~~~~~~~~~~
+
+``POST /<database>/<query>/-/delete`` deletes a saved query.
+
 .. _TableInsertView:
 
 Inserting rows
diff --git a/tests/plugins/my_plugin_2.py b/tests/plugins/my_plugin_2.py
index e3d3e760..864637a6 100644
--- a/tests/plugins/my_plugin_2.py
+++ b/tests/plugins/my_plugin_2.py
@@ -139,20 +139,6 @@ def startup(datasette):
         datasette._startup_catalog_databases = [
             row["database_name"] for row in catalog_rows
         ]
-        for database in datasette.databases:
-            await datasette.add_query(
-                database,
-                "from_hook",
-                "select 1, 'null' as actor_id",
-                source="plugin",
-            )
-            result = await datasette.get_database(database).execute("select 1 + 1")
-            await datasette.add_query(
-                database,
-                "from_async_hook",
-                "select {}".format(result.first()[0]),
-                source="plugin",
-            )
 
     return inner
 
diff --git a/tests/test_canned_queries.py b/tests/test_canned_queries.py
index e06ad189..c46fd86f 100644
--- a/tests/test_canned_queries.py
+++ b/tests/test_canned_queries.py
@@ -254,10 +254,8 @@ def test_canned_query_permissions_on_database_page(canned_write_client):
     }
     assert query_names == {
         "add_name_specify_id_with_error_in_on_success_message_sql",
-        "from_hook",
         "update_name",
         "add_name_specify_id",
-        "from_async_hook",
         "canned_read",
         "add_name",
     }
@@ -284,8 +282,6 @@ def test_canned_query_permissions_on_database_page(canned_write_client):
         },
         {"name": "canned_read", "private": False},
         {"name": "delete_name", "private": True},
-        {"name": "from_async_hook", "private": False},
-        {"name": "from_hook", "private": False},
         {"name": "update_name", "private": False},
     ]
 
diff --git a/tests/test_html.py b/tests/test_html.py
index efc1040d..e5f00e17 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -158,8 +158,6 @@ async def test_database_page(ds_client):
     queries_ul = soup.find("h2", string="Queries").find_next_sibling("ul")
     assert queries_ul is not None
     assert [
-        ("/fixtures/from_async_hook", "from_async_hook"),
-        ("/fixtures/from_hook", "from_hook"),
         ("/fixtures/magic_parameters", "magic_parameters"),
         ("/fixtures/neighborhood_search#fragment-goes-here", "Search neighborhoods"),
         ("/fixtures/pragma_cache_size", "pragma_cache_size"),
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 04800ed3..22f294bb 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -622,7 +622,6 @@ def test_padlocks_on_database_page(cascade_app_client):
         assert ">123_starts_with_digits</a></h3>" in response.text
         assert ">Table With Space In Name</a> 🔒</h3>" in response.text
         # Queries
-        assert ">from_async_hook</a> 🔒</li>" in response.text
         assert ">query_two</a></li>" in response.text
         # Views
         assert ">paginated_view</a> 🔒</li>" in response.text
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index b5a13ae5..f7adbd66 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -885,24 +885,61 @@ async def test_hook_startup_catalog_populated(ds_client):
 
 
 @pytest.mark.asyncio
-async def test_plugin_startup_queries(ds_client):
-    queries = (await ds_client.get("/fixtures.json")).json()["queries"]
+async def test_plugin_startup_can_add_queries():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("plugin_startup_queries", name="data")
+
+    class AddQueriesPlugin:
+        __name__ = "AddQueriesPlugin"
+
+        @hookimpl
+        def startup(self, datasette):
+            async def inner():
+                result = await datasette.get_database("data").execute("select 1 + 1")
+                await datasette.add_query(
+                    "data",
+                    "from_startup",
+                    "select {}".format(result.first()[0]),
+                    source="plugin",
+                )
+
+            return inner
+
+    ds.pm.register(AddQueriesPlugin(), name="add_queries_plugin")
+    try:
+        response = await ds.client.get("/data.json")
+    finally:
+        ds.pm.unregister(name="add_queries_plugin")
+
+    queries = response.json()["queries"]
     queries_by_name = {q["name"]: q for q in queries}
-    assert queries_by_name["from_async_hook"]["sql"] == "select 2"
-    assert queries_by_name["from_async_hook"]["private"] is False
-    assert queries_by_name["from_hook"]["sql"] == "select 1, 'null' as actor_id"
-    assert queries_by_name["from_hook"]["private"] is False
+    assert queries_by_name["from_startup"]["sql"] == "select 2"
+    assert queries_by_name["from_startup"]["private"] is False
 
 
 @pytest.mark.asyncio
-async def test_plugin_startup_query_from_hook(ds_client):
-    response = await ds_client.get("/fixtures/from_hook.json?_shape=array")
-    assert [{"1": 1, "actor_id": "null"}] == response.json()
+async def test_plugin_startup_query_can_execute():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("plugin_startup_query_execute", name="data")
 
+    class AddQueryPlugin:
+        __name__ = "AddQueryPlugin"
+
+        @hookimpl
+        def startup(self, datasette):
+            async def inner():
+                await datasette.add_query(
+                    "data", "from_startup", "select 2", source="plugin"
+                )
+
+            return inner
+
+    ds.pm.register(AddQueryPlugin(), name="add_query_plugin")
+    try:
+        response = await ds.client.get("/data/from_startup.json?_shape=array")
+    finally:
+        ds.pm.unregister(name="add_query_plugin")
 
-@pytest.mark.asyncio
-async def test_plugin_startup_query_from_async_hook(ds_client):
-    response = await ds_client.get("/fixtures/from_async_hook.json?_shape=array")
     assert [{"2": 2}] == response.json()
 
 
@@ -1514,9 +1551,9 @@ async def test_hook_top_query(ds_client):
 async def test_hook_top_canned_query(ds_client):
     try:
         pm.register(SlotPlugin(), name="SlotPlugin")
-        response = await ds_client.get("/fixtures/from_hook?z=xyz")
+        response = await ds_client.get("/fixtures/magic_parameters?z=xyz")
         assert response.status_code == 200
-        assert "Xtop_query:fixtures:from_hook:xyz" in response.text
+        assert "Xtop_query:fixtures:magic_parameters:xyz" in response.text
     finally:
         pm.unregister(name="SlotPlugin")
 

From ef43c103880fe819206f4e0dd12fa62add1c927c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 08:30:49 -0700
Subject: [PATCH 053/386] Add arbitrary write SQL execution page

Refs #2735
---
 datasette/app.py                       |  21 +-
 datasette/default_actions.py           |   7 +
 datasette/templates/execute_write.html |  71 +++++++
 datasette/templates/query_create.html  |   3 +
 datasette/views/database.py            | 266 +++++++++++++++++++++++--
 docs/authentication.rst                |  12 +-
 docs/json_api.rst                      |   9 +
 tests/test_queries.py                  | 122 ++++++++++++
 8 files changed, 487 insertions(+), 24 deletions(-)
 create mode 100644 datasette/templates/execute_write.html

diff --git a/datasette/app.py b/datasette/app.py
index ce85f447..409aed23 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -46,6 +46,7 @@ from .views import Context
 from .views.database import (
     database_download,
     DatabaseView,
+    ExecuteWriteView,
     TableCreateView,
     QueryView,
     QueryCreateView,
@@ -1249,18 +1250,22 @@ class Datasette:
         )
         return {row["name"]: self._query_row_to_dict(row) for row in rows}
 
-    async def ensure_query_write_permissions(self, database, sql, *, actor=None):
+    async def ensure_query_write_permissions(
+        self, database, sql, *, actor=None, params=None, analysis=None
+    ):
         write_actions = {
             "insert": "insert-row",
             "update": "update-row",
             "delete": "delete-row",
         }
         db = self.get_database(database)
-        params = {name: "" for name in named_parameters(sql)}
-        try:
-            analysis = await db.analyze_sql(sql, params)
-        except sqlite3.DatabaseError as ex:
-            raise Forbidden(f"Could not analyze query: {ex}") from ex
+        if analysis is None:
+            if params is None:
+                params = {name: "" for name in named_parameters(sql)}
+            try:
+                analysis = await db.analyze_sql(sql, params)
+            except sqlite3.DatabaseError as ex:
+                raise Forbidden(f"Could not analyze query: {ex}") from ex
 
         for access in analysis.table_accesses:
             action = write_actions.get(access.operation)
@@ -2547,6 +2552,10 @@ class Datasette:
             QueryInsertView.as_view(self),
             r"/(?P<database>[^\/\.]+)/-/queries/-/insert$",
         )
+        add_route(
+            ExecuteWriteView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/execute-write$",
+        )
         add_route(
             DatabaseSchemaView.as_view(self),
             r"/(?P<database>[^\/\.]+)/-/schema(\.(?P<format>json|md))?$",
diff --git a/datasette/default_actions.py b/datasette/default_actions.py
index e0e0aee5..6787b80e 100644
--- a/datasette/default_actions.py
+++ b/datasette/default_actions.py
@@ -48,6 +48,13 @@ def register_actions():
             resource_class=DatabaseResource,
             also_requires="view-database",
         ),
+        Action(
+            name="execute-write-sql",
+            abbr="ews",
+            description="Execute writable SQL queries",
+            resource_class=DatabaseResource,
+            also_requires="view-database",
+        ),
         Action(
             name="create-table",
             abbr="ct",
diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
new file mode 100644
index 00000000..5b4f30d9
--- /dev/null
+++ b/datasette/templates/execute_write.html
@@ -0,0 +1,71 @@
+{% extends "base.html" %}
+
+{% block title %}Execute write SQL{% endblock %}
+
+{% block extra_head %}
+{{- super() -}}
+{% include "_codemirror.html" %}
+{% endblock %}
+
+{% block body_class %}execute-write db-{{ database|to_css_class }}{% endblock %}
+
+{% block crumbs %}
+{{ crumbs.nav(request=request, database=database) }}
+{% endblock %}
+
+{% block content %}
+
+<h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Execute write SQL</h1>
+
+{% if execution_message %}
+    <p class="{% if execution_ok %}message-info{% else %}message-error{% endif %}">{{ execution_message }}</p>
+{% endif %}
+
+<form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post">
+    <p><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
+
+    {% if parameter_names %}
+        <h2>Parameters</h2>
+        {% for parameter in parameter_names %}
+            <p><label for="qp{{ loop.index }}">{{ parameter }}</label> <input type="text" id="qp{{ loop.index }}" name="{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}"></p>
+        {% endfor %}
+    {% endif %}
+
+    <h2>Analysis</h2>
+    {% if analysis_error %}
+        <p class="message-error">{{ analysis_error }}</p>
+    {% elif analysis_rows %}
+        <div class="table-wrapper"><table>
+            <thead>
+                <tr>
+                    <th scope="col">Operation</th>
+                    <th scope="col">Database</th>
+                    <th scope="col">Table</th>
+                    <th scope="col">required permission</th>
+                    <th scope="col">Allowed</th>
+                    <th scope="col">Source</th>
+                </tr>
+            </thead>
+            <tbody>
+                {% for row in analysis_rows %}
+                    <tr>
+                        <td>{{ row.operation }}</td>
+                        <td>{{ row.database }}</td>
+                        <td>{{ row.table }}</td>
+                        <td>{{ row.required_permission }}</td>
+                        <td>{% if row.allowed is none %}{% elif row.allowed %}yes{% else %}no{% endif %}</td>
+                        <td>{{ row.source or "" }}</td>
+                    </tr>
+                {% endfor %}
+            </tbody>
+        </table></div>
+    {% else %}
+        <p>Analysis will show each affected table and required permission.</p>
+    {% endif %}
+
+    <p><input type="submit" value="Execute"{% if execute_disabled %} disabled{% endif %}></p>
+</form>
+
+{% include "_codemirror_foot.html" %}
+
+{% endblock %}
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index 0e6a7b37..1b3d30a8 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -30,6 +30,9 @@
     {% if can_publish %}
         <p><label><input type="checkbox" name="published" value="1"> Published</label></p>
     {% endif %}
+    {% if sql and analysis_is_write %}
+        <p><a href="{{ urls.database(database) }}/-/execute-write?{{ {'sql': sql}|urlencode|safe }}">Execute write SQL</a></p>
+    {% endif %}
 
     <h2>Analysis</h2>
     {% if analysis_error %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index d521f7ad..a90d889e 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -508,6 +508,27 @@ def _coerce_query_parameters(value, derived):
     return parameters
 
 
+def _analysis_is_write(analysis):
+    return any(
+        access.operation in {"insert", "update", "delete"}
+        for access in analysis.table_accesses
+    )
+
+
+def _block_framing(response):
+    response.headers["Content-Security-Policy"] = "frame-ancestors 'none'"
+    response.headers["X-Frame-Options"] = "DENY"
+    return response
+
+
+def _wants_json(request, is_json, data):
+    return (
+        is_json
+        or request.headers.get("accept") == "application/json"
+        or (isinstance(data, dict) and data.get("_json"))
+    )
+
+
 async def _json_or_form_payload(request):
     content_type = request.headers.get("content-type", "")
     if content_type.startswith("application/json"):
@@ -538,15 +559,14 @@ async def _analyze_user_query(datasette, db, sql, *, actor, published):
     except sqlite3.DatabaseError as ex:
         raise QueryValidationError("Could not analyze query: {}".format(ex)) from ex
 
-    is_write = any(
-        access.operation in {"insert", "update", "delete"}
-        for access in analysis.table_accesses
-    )
+    is_write = _analysis_is_write(analysis)
     if is_write:
         if published:
             raise QueryValidationError("Writable queries cannot be published")
         try:
-            await datasette.ensure_query_write_permissions(db.name, sql, actor=actor)
+            await datasette.ensure_query_write_permissions(
+                db.name, sql, actor=actor, analysis=analysis
+            )
         except Forbidden as ex:
             raise QueryValidationError(str(ex), status=403) from ex
     else:
@@ -575,6 +595,69 @@ def _analysis_rows(analysis):
     ]
 
 
+async def _analysis_rows_with_permissions(datasette, analysis, actor):
+    rows = _analysis_rows(analysis)
+    for row in rows:
+        permission = row["required_permission"]
+        if permission:
+            row["allowed"] = await datasette.allowed(
+                action=permission,
+                resource=TableResource(row["database"], row["table"]),
+                actor=actor,
+            )
+        else:
+            row["allowed"] = None
+    return rows
+
+
+def _coerce_execute_write_payload(data, is_json):
+    if not isinstance(data, dict):
+        raise QueryValidationError("JSON must be a dictionary")
+    if is_json:
+        invalid_keys = set(data) - {"sql", "params"}
+        if invalid_keys:
+            raise QueryValidationError(
+                "Invalid keys: {}".format(", ".join(sorted(invalid_keys)))
+            )
+        params = data.get("params") or {}
+    else:
+        params = {
+            key: value
+            for key, value in data.items()
+            if key not in {"sql", "csrftoken", "_json"}
+        }
+    if not isinstance(params, dict):
+        raise QueryValidationError("params must be a dictionary")
+    return data.get("sql"), params
+
+
+async def _prepare_execute_write(datasette, db, sql, params, actor):
+    if not sql or not isinstance(sql, str):
+        raise QueryValidationError("SQL is required")
+    parameter_names = _derived_query_parameters(sql)
+    extra_params = set(params) - set(parameter_names)
+    if extra_params:
+        raise QueryValidationError(
+            "Unknown parameters: {}".format(", ".join(sorted(extra_params)))
+        )
+    params = {name: params.get(name, "") for name in parameter_names}
+    try:
+        analysis = await db.analyze_sql(sql, params)
+    except sqlite3.DatabaseError as ex:
+        raise QueryValidationError("Could not analyze query: {}".format(ex)) from ex
+    if not _analysis_is_write(analysis):
+        raise QueryValidationError(
+            "Use /-/query for read-only SQL; this endpoint only executes writes"
+        )
+    try:
+        await datasette.ensure_query_write_permissions(
+            db.name, sql, actor=actor, analysis=analysis
+        )
+    except Forbidden as ex:
+        raise QueryValidationError(str(ex), status=403) from ex
+    return parameter_names, params, analysis
+
+
 def _apply_query_data_types(data):
     typed = dict(data)
     for key in ("hide_sql", "published"):
@@ -707,6 +790,160 @@ async def _prepare_query_update(datasette, request, db, existing, update):
     return update_kwargs
 
 
+class ExecuteWriteView(BaseView):
+    name = "execute-write"
+    has_json_alternate = False
+
+    async def _render_form(
+        self,
+        request,
+        db,
+        *,
+        sql="",
+        parameter_values=None,
+        analysis=None,
+        analysis_error=None,
+        execution_message=None,
+        execution_ok=None,
+        status=200,
+    ):
+        parameter_values = parameter_values or {}
+        parameter_names = []
+        analysis_rows = []
+        if sql and analysis_error is None:
+            try:
+                parameter_names = _derived_query_parameters(sql)
+                if analysis is None:
+                    params = {parameter: "" for parameter in parameter_names}
+                    analysis = await db.analyze_sql(sql, params)
+                if _analysis_is_write(analysis):
+                    analysis_rows = await _analysis_rows_with_permissions(
+                        self.ds, analysis, request.actor
+                    )
+                else:
+                    analysis_error = (
+                        "Use /-/query for read-only SQL; "
+                        "this endpoint only executes writes"
+                    )
+            except (QueryValidationError, sqlite3.DatabaseError) as ex:
+                analysis_error = getattr(ex, "message", str(ex))
+
+        response = await self.render(
+            ["execute_write.html"],
+            request,
+            {
+                "database": db.name,
+                "database_color": db.color,
+                "sql": sql,
+                "parameter_names": parameter_names,
+                "parameter_values": parameter_values,
+                "analysis_error": analysis_error,
+                "analysis_rows": analysis_rows,
+                "execution_message": execution_message,
+                "execution_ok": execution_ok,
+                "execute_disabled": bool(
+                    (not sql)
+                    or analysis_error
+                    or any(row["allowed"] is False for row in analysis_rows)
+                ),
+            },
+        )
+        response.status = status
+        return _block_framing(response)
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        await self.ds.ensure_permission(
+            action="execute-write-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        )
+        return await self._render_form(
+            request,
+            db,
+            sql=request.args.get("sql") or "",
+        )
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-write-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(
+                _error(["Permission denied: need execute-write-sql"], 403)
+            )
+        if not db.is_mutable:
+            return _block_framing(_error(["Database is immutable"], 403))
+
+        data = {}
+        is_json = request.headers.get("content-type", "").startswith("application/json")
+        sql = ""
+        provided_params = {}
+        try:
+            data, is_json = await _json_or_form_payload(request)
+            sql, provided_params = _coerce_execute_write_payload(data, is_json)
+            parameter_names, params, analysis = await _prepare_execute_write(
+                self.ds, db, sql, provided_params, request.actor
+            )
+        except QueryValidationError as ex:
+            if _wants_json(request, is_json, data):
+                return _block_framing(_error([ex.message], ex.status))
+            return await self._render_form(
+                request,
+                db,
+                sql=sql or "",
+                parameter_values=provided_params,
+                analysis_error=ex.message,
+                execution_message=ex.message,
+                execution_ok=False,
+                status=ex.status,
+            )
+
+        try:
+            cursor = await db.execute_write(sql, params, request=request)
+        except sqlite3.DatabaseError as ex:
+            message = str(ex)
+            if _wants_json(request, is_json, data):
+                return _block_framing(_error([message], 400))
+            return await self._render_form(
+                request,
+                db,
+                sql=sql,
+                parameter_values=params,
+                analysis=analysis,
+                execution_message=message,
+                execution_ok=False,
+                status=400,
+            )
+
+        message = "Query executed, {} row{} affected".format(
+            cursor.rowcount, "" if cursor.rowcount == 1 else "s"
+        )
+        if _wants_json(request, is_json, data):
+            return _block_framing(
+                Response.json(
+                    {
+                        "ok": True,
+                        "message": message,
+                        "rowcount": cursor.rowcount,
+                        "analysis": _analysis_rows(analysis),
+                    }
+                )
+            )
+
+        return await self._render_form(
+            request,
+            db,
+            sql=sql,
+            parameter_values={name: params.get(name, "") for name in parameter_names},
+            analysis=analysis,
+            execution_message=message,
+            execution_ok=True,
+        )
+
+
 class QueryListView(BaseView):
     name = "query-list"
 
@@ -753,18 +990,9 @@ class QueryCreateView(BaseView):
                 parameter_names = _derived_query_parameters(sql)
                 params = {parameter: "" for parameter in parameter_names}
                 analysis = await db.analyze_sql(sql, params)
-                rows = _analysis_rows(analysis)
-                for row in rows:
-                    permission = row["required_permission"]
-                    if permission:
-                        row["allowed"] = await self.ds.allowed(
-                            action=permission,
-                            resource=TableResource(row["database"], row["table"]),
-                            actor=request.actor,
-                        )
-                    else:
-                        row["allowed"] = None
-                analysis_rows = rows
+                analysis_rows = await _analysis_rows_with_permissions(
+                    self.ds, analysis, request.actor
+                )
             except (QueryValidationError, sqlite3.DatabaseError) as ex:
                 analysis_error = getattr(ex, "message", str(ex))
 
@@ -783,6 +1011,10 @@ class QueryCreateView(BaseView):
                 ),
                 "analysis_error": analysis_error,
                 "analysis_rows": analysis_rows,
+                "analysis_is_write": bool(
+                    analysis_rows
+                    and any(row["required_permission"] for row in analysis_rows)
+                ),
                 "save_disabled": bool(
                     analysis_error
                     or any(row["allowed"] is False for row in analysis_rows)
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 543f069b..b6a4cb7e 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1423,13 +1423,23 @@ Actor is allowed to drop a database table.
 execute-sql
 -----------
 
-Actor is allowed to run arbitrary SQL queries against a specific database, e.g. https://latest.datasette.io/fixtures/-/query?sql=select+100
+Actor is allowed to run arbitrary read-only SQL queries against a specific database, e.g. https://latest.datasette.io/fixtures/-/query?sql=select+100
 
 ``resource`` - ``datasette.resources.DatabaseResource(database)``
     ``database`` is the name of the database (string)
 
 See also :ref:`the default_allow_sql setting <setting_default_allow_sql>`.
 
+.. _actions_execute_write_sql:
+
+execute-write-sql
+-----------------
+
+Actor is allowed to run arbitrary writable SQL queries against a specific database, subject to table-level write permissions such as ``insert-row``, ``update-row`` and ``delete-row``.
+
+``resource`` - ``datasette.resources.DatabaseResource(database)``
+    ``database`` is the name of the database (string)
+
 .. _actions_permissions_debug:
 
 permissions-debug
diff --git a/docs/json_api.rst b/docs/json_api.rst
index d5cd231c..e4c9e86e 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -526,6 +526,15 @@ Creating saved queries
 
 ``POST /<database>/-/queries/-/insert`` creates a saved query. This requires ``execute-sql`` and ``insert-query`` for the database.
 
+.. _ExecuteWriteView:
+
+Executing write SQL
+~~~~~~~~~~~~~~~~~~~
+
+``GET /<database>/-/execute-write`` displays a form for executing writable SQL. A ``?sql=`` query string pre-populates the form without executing it.
+
+``POST /<database>/-/execute-write`` executes writable SQL. This requires ``execute-write-sql`` for the database plus the relevant table-level write permissions.
+
 .. _QueryDefinitionView:
 
 Getting a saved query definition
diff --git a/tests/test_queries.py b/tests/test_queries.py
index c6685d6c..05bc5ee1 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -212,6 +212,7 @@ async def test_query_actions_are_registered():
     ds = Datasette()
     await ds.invoke_startup()
 
+    assert ds.get_action("execute-write-sql").resource_class is DatabaseResource
     assert ds.get_action("insert-query").resource_class is DatabaseResource
     assert ds.get_action("publish-query").resource_class is DatabaseResource
     assert ds.get_action("update-query").resource_class is QueryResource
@@ -492,6 +493,127 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
     assert "/data/-/queries/-/create?sql=select+%2A+from+dogs" in query_response.text
 
 
+@pytest.mark.asyncio
+async def test_execute_write_get_prepopulates_without_executing():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_get", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.get(
+        "/data/-/execute-write?sql=insert+into+dogs+(name)+values+('Cleo')",
+        actor={"id": "root"},
+    )
+
+    assert response.status_code == 200
+    assert response.headers["content-security-policy"] == "frame-ancestors 'none'"
+    assert response.headers["x-frame-options"] == "DENY"
+    assert "Execute write SQL" in response.text
+    assert 'action="/data/-/execute-write"' in response.text
+    assert "insert into dogs (name) values (&#39;Cleo&#39;)" in response.text
+    assert (await db.execute("select count(*) from dogs")).first()[0] == 0
+
+
+@pytest.mark.asyncio
+async def test_execute_write_post_requires_database_and_table_permissions():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_permissions", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    no_database_permission = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "outsider"},
+        json={
+            "sql": "insert into dogs (name) values (:name)",
+            "params": {"name": "Cleo"},
+        },
+    )
+    no_table_permission = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={
+            "sql": "insert into dogs (name) values (:name)",
+            "params": {"name": "Cleo"},
+        },
+    )
+
+    assert no_database_permission.status_code == 403
+    assert no_database_permission.json()["errors"] == [
+        "Permission denied: need execute-write-sql"
+    ]
+    assert no_table_permission.status_code == 403
+    assert no_table_permission.json()["errors"] == [
+        "Permission denied: need insert-row on data/dogs"
+    ]
+
+    ds.config = {
+        "databases": {
+            "data": {
+                "permissions": {
+                    "view-database": {"id": "writer"},
+                    "execute-write-sql": {"id": "writer"},
+                },
+                "tables": {
+                    "dogs": {
+                        "permissions": {
+                            "insert-row": {"id": "writer"},
+                        }
+                    }
+                },
+            }
+        }
+    }
+    allowed = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={
+            "sql": "insert into dogs (name) values (:name)",
+            "params": {"name": "Cleo"},
+        },
+    )
+
+    assert allowed.status_code == 200
+    assert allowed.json()["ok"] is True
+    assert allowed.json()["rowcount"] == 1
+    assert allowed.json()["analysis"][0]["operation"] == "insert"
+    assert (await db.execute("select name from dogs")).first()[0] == "Cleo"
+
+
+@pytest.mark.asyncio
+async def test_execute_write_post_rejects_read_only_sql():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_read_only", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        json={"sql": "select * from dogs"},
+    )
+
+    assert response.status_code == 400
+    assert response.json()["errors"] == [
+        "Use /-/query for read-only SQL; this endpoint only executes writes"
+    ]
+
+
 @pytest.mark.asyncio
 async def test_query_owner_gets_update_delete_and_writable_view_defaults():
     ds = Datasette(memory=True, default_deny=True)

From b7505a9fc22fd96f0c6aad60c8b149bc1978d7b0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 08:49:18 -0700
Subject: [PATCH 054/386] Add execute write SQL database action

Refs #2735
---
 datasette/default_database_actions.py | 22 +++++++++++++++++
 datasette/plugins.py                  |  1 +
 tests/test_queries.py                 | 34 +++++++++++++++++++++++++++
 3 files changed, 57 insertions(+)
 create mode 100644 datasette/default_database_actions.py

diff --git a/datasette/default_database_actions.py b/datasette/default_database_actions.py
new file mode 100644
index 00000000..78055392
--- /dev/null
+++ b/datasette/default_database_actions.py
@@ -0,0 +1,22 @@
+from datasette import hookimpl
+from datasette.resources import DatabaseResource
+
+
+@hookimpl
+def database_actions(datasette, actor, database, request):
+    async def inner():
+        if not await datasette.allowed(
+            action="execute-write-sql",
+            resource=DatabaseResource(database),
+            actor=actor,
+        ):
+            return []
+        return [
+            {
+                "href": datasette.urls.database(database) + "/-/execute-write",
+                "label": "Execute write SQL",
+                "description": "Run writable SQL with table permission checks.",
+            }
+        ]
+
+    return inner
diff --git a/datasette/plugins.py b/datasette/plugins.py
index f532ac60..5a31cdad 100644
--- a/datasette/plugins.py
+++ b/datasette/plugins.py
@@ -30,6 +30,7 @@ DEFAULT_PLUGINS = (
     "datasette.blob_renderer",
     "datasette.default_debug_menu",
     "datasette.default_jump_items",
+    "datasette.default_database_actions",
     "datasette.handle_exception",
     "datasette.forbidden",
     "datasette.events",
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 05bc5ee1..1c9175cc 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -515,6 +515,40 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert (await db.execute("select count(*) from dogs")).first()[0] == 0
 
 
+@pytest.mark.asyncio
+async def test_database_action_menu_links_to_execute_write_for_permitted_actor():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {
+                            "id": ["writer", "viewer"],
+                        },
+                        "execute-write-sql": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("execute_write_menu", name="data")
+    await ds.invoke_startup()
+
+    anonymous_response = await ds.client.get("/data")
+    viewer_response = await ds.client.get("/data", actor={"id": "viewer"})
+    writer_response = await ds.client.get("/data", actor={"id": "writer"})
+
+    assert anonymous_response.status_code == 403
+    assert viewer_response.status_code == 200
+    assert "Execute write SQL" not in viewer_response.text
+    assert writer_response.status_code == 200
+    assert "Database actions" in writer_response.text
+    assert 'href="/data/-/execute-write"' in writer_response.text
+    assert "Execute write SQL" in writer_response.text
+
+
 @pytest.mark.asyncio
 async def test_execute_write_post_requires_database_and_table_permissions():
     ds = Datasette(

From e0d39ba69f677be1af1cf580beb83dbc56c8ef87 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 09:41:32 -0700
Subject: [PATCH 055/386] Store query options as JSON

Refs #2735
---
 datasette/app.py               | 105 ++++++++++++++++++++++++---------
 datasette/utils/internal_db.py |   8 +--
 docs/internals.rst             |  20 +++++++
 queries-plan.md                |  19 +++---
 tests/test_queries.py          |  45 +++++++++++---
 5 files changed, 143 insertions(+), 54 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 409aed23..023568dd 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -283,6 +283,16 @@ FAVICON_PATH = app_root / "datasette" / "static" / "favicon.png"
 DEFAULT_NOT_SET = object()
 UNCHANGED = object()
 
+QUERY_OPTION_FIELDS = (
+    "hide_sql",
+    "fragment",
+    "on_success_message",
+    "on_success_message_sql",
+    "on_success_redirect",
+    "on_error_message",
+    "on_error_redirect",
+)
+
 
 ResourcesSQL = collections.namedtuple("ResourcesSQL", ("sql", "params"))
 
@@ -1056,6 +1066,7 @@ class Datasette:
         if row is None:
             return None
         parameters = json.loads(row["parameters"] or "[]")
+        options = json.loads(row["options"] or "{}")
         is_write = bool(row["is_write"])
         return {
             "database": row["database_name"],
@@ -1064,8 +1075,8 @@ class Datasette:
             "title": row["title"],
             "description": row["description"],
             "description_html": row["description_html"],
-            "hide_sql": bool(row["hide_sql"]),
-            "fragment": row["fragment"],
+            "hide_sql": bool(options.get("hide_sql")),
+            "fragment": options.get("fragment"),
             "params": parameters,
             "parameters": parameters,
             "is_write": is_write,
@@ -1073,13 +1084,25 @@ class Datasette:
             "published": bool(row["published"]),
             "source": row["source"],
             "owner_id": row["owner_id"],
-            "on_success_message": row["on_success_message"],
-            "on_success_message_sql": row["on_success_message_sql"],
-            "on_success_redirect": row["on_success_redirect"],
-            "on_error_message": row["on_error_message"],
-            "on_error_redirect": row["on_error_redirect"],
+            "on_success_message": options.get("on_success_message"),
+            "on_success_message_sql": options.get("on_success_message_sql"),
+            "on_success_redirect": options.get("on_success_redirect"),
+            "on_error_message": options.get("on_error_message"),
+            "on_error_redirect": options.get("on_error_redirect"),
         }
 
+    @staticmethod
+    def _query_options_json(options):
+        options_dict = {}
+        for field in QUERY_OPTION_FIELDS:
+            value = options.get(field)
+            if field == "hide_sql":
+                if value:
+                    options_dict[field] = True
+            elif value is not None:
+                options_dict[field] = value
+        return json.dumps(options_dict, sort_keys=True)
+
     async def add_query(
         self,
         database,
@@ -1104,13 +1127,22 @@ class Datasette:
         replace=True,
     ):
         parameters_json = json.dumps(list(parameters or []))
+        options_json = self._query_options_json(
+            {
+                "hide_sql": hide_sql,
+                "fragment": fragment,
+                "on_success_message": on_success_message,
+                "on_success_message_sql": on_success_message_sql,
+                "on_success_redirect": on_success_redirect,
+                "on_error_message": on_error_message,
+                "on_error_redirect": on_error_redirect,
+            }
+        )
         sql_statement = """
             INSERT INTO queries (
                 database_name, name, sql, title, description, description_html,
-                hide_sql, fragment, parameters, is_write, published, source,
-                owner_id, on_success_message, on_success_message_sql,
-                on_success_redirect, on_error_message, on_error_redirect
-            ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+                options, parameters, is_write, published, source, owner_id
+            ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
         """
         if replace:
             sql_statement += """
@@ -1119,18 +1151,12 @@ class Datasette:
                     title = excluded.title,
                     description = excluded.description,
                     description_html = excluded.description_html,
-                    hide_sql = excluded.hide_sql,
-                    fragment = excluded.fragment,
+                    options = excluded.options,
                     parameters = excluded.parameters,
                     is_write = excluded.is_write,
                     published = excluded.published,
                     source = excluded.source,
                     owner_id = excluded.owner_id,
-                    on_success_message = excluded.on_success_message,
-                    on_success_message_sql = excluded.on_success_message_sql,
-                    on_success_redirect = excluded.on_success_redirect,
-                    on_error_message = excluded.on_error_message,
-                    on_error_redirect = excluded.on_error_redirect,
                     updated_at = CURRENT_TIMESTAMP
             """
         await self.get_internal_database().execute_write(
@@ -1142,18 +1168,12 @@ class Datasette:
                 title,
                 description,
                 description_html,
-                int(bool(hide_sql)),
-                fragment,
+                options_json,
                 parameters_json,
                 int(bool(is_write)),
                 int(bool(published)),
                 source,
                 owner_id,
-                on_success_message,
-                on_success_message_sql,
-                on_success_redirect,
-                on_error_message,
-                on_error_redirect,
             ],
         )
 
@@ -1184,13 +1204,15 @@ class Datasette:
             "title": title,
             "description": description,
             "description_html": description_html,
-            "hide_sql": hide_sql,
-            "fragment": fragment,
             "parameters": parameters,
             "is_write": is_write,
             "published": published,
             "source": source,
             "owner_id": owner_id,
+        }
+        option_fields = {
+            "hide_sql": hide_sql,
+            "fragment": fragment,
             "on_success_message": on_success_message,
             "on_success_message_sql": on_success_message_sql,
             "on_success_redirect": on_success_redirect,
@@ -1202,12 +1224,39 @@ class Datasette:
         for field, value in fields.items():
             if value is UNCHANGED:
                 continue
-            if field in {"hide_sql", "is_write", "published"}:
+            if field in {"is_write", "published"}:
                 value = int(bool(value))
             elif field == "parameters":
                 value = json.dumps(list(value or []))
             updates.append(f"{field} = ?")
             params.append(value)
+        changed_options = {
+            field: value
+            for field, value in option_fields.items()
+            if value is not UNCHANGED
+        }
+        if changed_options:
+            rows = await self.get_internal_database().execute(
+                """
+                SELECT options FROM queries
+                WHERE database_name = ? AND name = ?
+                """,
+                [database, name],
+            )
+            row = rows.first()
+            options = json.loads(row["options"] or "{}") if row is not None else {}
+            for field, value in changed_options.items():
+                if field == "hide_sql":
+                    if value:
+                        options[field] = True
+                    else:
+                        options.pop(field, None)
+                elif value is None:
+                    options.pop(field, None)
+                else:
+                    options[field] = value
+            updates.append("options = ?")
+            params.append(json.dumps(options, sort_keys=True))
         if not updates:
             return
         updates.append("updated_at = CURRENT_TIMESTAMP")
diff --git a/datasette/utils/internal_db.py b/datasette/utils/internal_db.py
index 9008c083..854e8784 100644
--- a/datasette/utils/internal_db.py
+++ b/datasette/utils/internal_db.py
@@ -120,18 +120,12 @@ async def initialize_metadata_tables(db):
             title TEXT,
             description TEXT,
             description_html TEXT,
-            hide_sql INTEGER NOT NULL DEFAULT 0 CHECK (hide_sql IN (0, 1)),
-            fragment TEXT,
+            options TEXT NOT NULL DEFAULT '{}',
             parameters TEXT NOT NULL DEFAULT '[]',
             is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
             published INTEGER NOT NULL DEFAULT 0 CHECK (published IN (0, 1)),
             source TEXT NOT NULL DEFAULT 'user',
             owner_id TEXT,
-            on_success_message TEXT,
-            on_success_message_sql TEXT,
-            on_success_redirect TEXT,
-            on_error_message TEXT,
-            on_error_redirect TEXT,
             created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
             updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
             PRIMARY KEY (database_name, name),
diff --git a/docs/internals.rst b/docs/internals.rst
index e0123a7b..a0845ade 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -2148,6 +2148,26 @@ The internal database schema is as follows:
         config TEXT,
         PRIMARY KEY (database_name, resource_name, column_name)
     );
+    CREATE TABLE queries (
+        database_name TEXT NOT NULL,
+        name TEXT NOT NULL,
+        sql TEXT NOT NULL,
+        title TEXT,
+        description TEXT,
+        description_html TEXT,
+        options TEXT NOT NULL DEFAULT '{}',
+        parameters TEXT NOT NULL DEFAULT '[]',
+        is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
+        published INTEGER NOT NULL DEFAULT 0 CHECK (published IN (0, 1)),
+        source TEXT NOT NULL DEFAULT 'user',
+        owner_id TEXT,
+        created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+        updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+        PRIMARY KEY (database_name, name),
+        CHECK (is_write = 0 OR published = 0)
+    );
+    CREATE INDEX queries_owner_idx
+        ON queries(owner_id);
 
 .. [[[end]]]
 
diff --git a/queries-plan.md b/queries-plan.md
index 283ca866..dbc46101 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -42,18 +42,12 @@ CREATE TABLE IF NOT EXISTS queries (
     title TEXT,
     description TEXT,
     description_html TEXT,
-    hide_sql INTEGER NOT NULL DEFAULT 0 CHECK (hide_sql IN (0, 1)),
-    fragment TEXT,
+    options TEXT NOT NULL DEFAULT '{}',
     parameters TEXT NOT NULL DEFAULT '[]',
     is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
     published INTEGER NOT NULL DEFAULT 0 CHECK (published IN (0, 1)),
     source TEXT NOT NULL DEFAULT 'user',
     owner_id TEXT,
-    on_success_message TEXT,
-    on_success_message_sql TEXT,
-    on_success_redirect TEXT,
-    on_error_message TEXT,
-    on_error_redirect TEXT,
     created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
     PRIMARY KEY (database_name, name),
@@ -67,9 +61,10 @@ CREATE INDEX IF NOT EXISTS queries_owner_idx
 Column notes:
 
 - `database_name`, `name`, and `sql` are the routing and execution core.
-- Display fields become columns: `title`, `description`, `description_html`, `hide_sql`, and `fragment`.
+- Display fields become columns: `title`, `description`, and `description_html`.
+- Less common presentation and writable-query behavior lives in `options`, stored as a JSON object. That covers `hide_sql`, `fragment`, `on_success_message`, `on_success_message_sql`, `on_success_redirect`, `on_error_message`, and `on_error_redirect`.
 - `parameters` is a JSON array of parameter names, stored as text. This preserves explicit parameter order, but does not support labels or default values.
-- Existing writable query behavior gets columns too: `is_write`, success/error messages, success/error redirects, and `on_success_message_sql`.
+- Existing writable query behavior gets `is_write` as a column. Success/error messages, success/error redirects, and `on_success_message_sql` are stored in `options`.
 - `published` only applies to read-only queries. A writable query can still be public through explicit `view-query` permissions, but the "publish for users without execute-sql" shortcut should be read-only.
 - `source` distinguishes `user`, `config`, and `plugin` rows.
 - `owner_id` is the actor id for user-created rows. It is `NULL` for config/plugin rows.
@@ -372,11 +367,11 @@ await datasette.update_query(
 )
 ```
 
-That call should set `on_success_redirect` to SQL `NULL`; omitting `on_success_redirect` should leave the existing value unchanged.
+For column-backed fields, `None` should write SQL `NULL`. For option fields, `None` should remove that key from the JSON object so `get_query()` returns `None`; omitting the field should leave the existing option unchanged.
 
 Implementation detail: build the `UPDATE` statement dynamically from fields whose value is not `UNCHANGED`, validate non-nullable fields before writing, and update `updated_at` whenever at least one field changes.
 
-The read methods should reconstruct the existing dictionary shape used by query execution and templates, with `name`, `sql`, display fields, write fields, `params`, `published`, `owner_id`, and `source`. `parameters` should be returned as the decoded JSON array and exposed as `params` where existing query execution code expects that key.
+The read methods should reconstruct the existing dictionary shape used by query execution and templates, with `name`, `sql`, display fields, write fields, `params`, `published`, `owner_id`, and `source`. `parameters` should be returned as the decoded JSON array and exposed as `params` where existing query execution code expects that key. Option values should be unpacked from the `options` JSON object and returned as the same top-level keys accepted by `add_query()` and `update_query()`.
 
 ## Query page save UI
 
@@ -430,7 +425,7 @@ The existing edit-SQL flow from query pages can continue to point back to arbitr
 - Query update uses `POST /{database}/{query}/-/update` with an `{"update": {...}}` body.
 - Query delete uses `POST /{database}/{query}/-/delete`.
 - There are no `PATCH` or HTTP `DELETE` routes for query management.
-- `datasette.update_query(..., field=None)` writes `NULL`, while omitted fields are left unchanged.
+- `datasette.update_query(..., field=None)` writes `NULL` for column-backed fields and removes JSON keys for option fields, while omitted fields are left unchanged.
 - Owner gets default `update-query` and `delete-query` for their own user-created rows.
 - Admin can manage other users' queries with `update-query` and `delete-query`.
 - User API rejects magic parameters.
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 1c9175cc..edb9484a 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1,3 +1,5 @@
+import json
+
 import pytest
 
 from datasette.app import Datasette
@@ -25,18 +27,12 @@ async def test_queries_internal_table_schema():
         "title",
         "description",
         "description_html",
-        "hide_sql",
-        "fragment",
+        "options",
         "parameters",
         "is_write",
         "published",
         "source",
         "owner_id",
-        "on_success_message",
-        "on_success_message_sql",
-        "on_success_redirect",
-        "on_error_message",
-        "on_error_redirect",
         "created_at",
         "updated_at",
     ]
@@ -62,6 +58,20 @@ async def test_add_get_and_remove_query():
         owner_id="alice",
     )
 
+    options_row = (
+        await ds.get_internal_database().execute(
+            """
+            SELECT options FROM queries
+            WHERE database_name = ? AND name = ?
+            """,
+            ["data", "top_customers"],
+        )
+    ).first()
+    assert json.loads(options_row["options"]) == {
+        "fragment": "chart",
+        "hide_sql": True,
+    }
+
     query = await ds.get_query("data", "top_customers")
     assert query == {
         "database": "data",
@@ -108,6 +118,17 @@ async def test_update_query_only_updates_provided_fields():
         parameters=["one"],
     )
 
+    options_row = (
+        await ds.get_internal_database().execute(
+            """
+            SELECT options FROM queries
+            WHERE database_name = ? AND name = ?
+            """,
+            ["data", "redirect"],
+        )
+    ).first()
+    assert json.loads(options_row["options"]) == {"on_success_redirect": "/original"}
+
     await ds.update_query(
         "data",
         "redirect",
@@ -123,6 +144,16 @@ async def test_update_query_only_updates_provided_fields():
     assert query["on_success_redirect"] is None
     assert query["sql"] == "select 1"
     assert query["published"] is False
+    options_row = (
+        await ds.get_internal_database().execute(
+            """
+            SELECT options FROM queries
+            WHERE database_name = ? AND name = ?
+            """,
+            ["data", "redirect"],
+        )
+    ).first()
+    assert json.loads(options_row["options"]) == {}
 
 
 @pytest.mark.asyncio

From e62a5ea3378095832b0388ac5c6014c23127a577 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 09:46:39 -0700
Subject: [PATCH 056/386] Rename query publication flag

Refs #2735
---
 datasette/app.py                          | 18 ++++-----
 datasette/default_permissions/defaults.py |  4 +-
 datasette/templates/query_create.html     |  2 +-
 datasette/utils/internal_db.py            |  4 +-
 datasette/views/database.py               | 26 ++++++-------
 docs/internals.rst                        |  4 +-
 queries-plan.md                           | 46 +++++++++++------------
 tests/test_queries.py                     | 22 +++++------
 8 files changed, 63 insertions(+), 63 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 023568dd..40877802 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -615,7 +615,7 @@ class Datasette:
                     fragment=query_config.get("fragment"),
                     parameters=query_config.get("params"),
                     is_write=bool(query_config.get("write")),
-                    published=bool(query_config.get("published")),
+                    is_published=bool(query_config.get("is_published")),
                     source="config",
                     on_success_message=query_config.get("on_success_message"),
                     on_success_message_sql=query_config.get("on_success_message_sql"),
@@ -1081,7 +1081,7 @@ class Datasette:
             "parameters": parameters,
             "is_write": is_write,
             "write": is_write,
-            "published": bool(row["published"]),
+            "is_published": bool(row["is_published"]),
             "source": row["source"],
             "owner_id": row["owner_id"],
             "on_success_message": options.get("on_success_message"),
@@ -1116,7 +1116,7 @@ class Datasette:
         fragment=None,
         parameters=None,
         is_write=False,
-        published=False,
+        is_published=False,
         source="plugin",
         owner_id=None,
         on_success_message=None,
@@ -1141,7 +1141,7 @@ class Datasette:
         sql_statement = """
             INSERT INTO queries (
                 database_name, name, sql, title, description, description_html,
-                options, parameters, is_write, published, source, owner_id
+                options, parameters, is_write, is_published, source, owner_id
             ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
         """
         if replace:
@@ -1154,7 +1154,7 @@ class Datasette:
                     options = excluded.options,
                     parameters = excluded.parameters,
                     is_write = excluded.is_write,
-                    published = excluded.published,
+                    is_published = excluded.is_published,
                     source = excluded.source,
                     owner_id = excluded.owner_id,
                     updated_at = CURRENT_TIMESTAMP
@@ -1171,7 +1171,7 @@ class Datasette:
                 options_json,
                 parameters_json,
                 int(bool(is_write)),
-                int(bool(published)),
+                int(bool(is_published)),
                 source,
                 owner_id,
             ],
@@ -1190,7 +1190,7 @@ class Datasette:
         fragment=UNCHANGED,
         parameters=UNCHANGED,
         is_write=UNCHANGED,
-        published=UNCHANGED,
+        is_published=UNCHANGED,
         source=UNCHANGED,
         owner_id=UNCHANGED,
         on_success_message=UNCHANGED,
@@ -1206,7 +1206,7 @@ class Datasette:
             "description_html": description_html,
             "parameters": parameters,
             "is_write": is_write,
-            "published": published,
+            "is_published": is_published,
             "source": source,
             "owner_id": owner_id,
         }
@@ -1224,7 +1224,7 @@ class Datasette:
         for field, value in fields.items():
             if value is UNCHANGED:
                 continue
-            if field in {"is_write", "published"}:
+            if field in {"is_write", "is_published"}:
                 value = int(bool(value))
             elif field == "parameters":
                 value = json.dumps(list(value or []))
diff --git a/datasette/default_permissions/defaults.py b/datasette/default_permissions/defaults.py
index 9737de96..58deea01 100644
--- a/datasette/default_permissions/defaults.py
+++ b/datasette/default_permissions/defaults.py
@@ -136,7 +136,7 @@ async def default_query_permissions_sql(
           'published query' AS reason
         FROM queries
         WHERE is_write = 0
-          AND published = 1
+          AND is_published = 1
         UNION ALL
         SELECT q.database_name AS parent, q.name AS child, 1 AS allow,
           'execute-sql allows query' AS reason
@@ -145,7 +145,7 @@ async def default_query_permissions_sql(
           ON es.parent = q.database_name
          AND es.child IS NULL
         WHERE q.is_write = 0
-          AND q.published = 0
+          AND q.is_published = 0
         {trusted_writable_sql}
         {user_writable_sql}
         """,
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index 1b3d30a8..fb2599d2 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -28,7 +28,7 @@
     <p><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
     <p><label for="query-parameters">Parameters</label> <input id="query-parameters" name="parameters" type="text" value="{{ parameter_names|join(', ') }}"></p>
     {% if can_publish %}
-        <p><label><input type="checkbox" name="published" value="1"> Published</label></p>
+        <p><label><input type="checkbox" name="is_published" value="1"> Published</label></p>
     {% endif %}
     {% if sql and analysis_is_write %}
         <p><a href="{{ urls.database(database) }}/-/execute-write?{{ {'sql': sql}|urlencode|safe }}">Execute write SQL</a></p>
diff --git a/datasette/utils/internal_db.py b/datasette/utils/internal_db.py
index 854e8784..0f84e886 100644
--- a/datasette/utils/internal_db.py
+++ b/datasette/utils/internal_db.py
@@ -123,13 +123,13 @@ async def initialize_metadata_tables(db):
             options TEXT NOT NULL DEFAULT '{}',
             parameters TEXT NOT NULL DEFAULT '[]',
             is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
-            published INTEGER NOT NULL DEFAULT 0 CHECK (published IN (0, 1)),
+            is_published INTEGER NOT NULL DEFAULT 0 CHECK (is_published IN (0, 1)),
             source TEXT NOT NULL DEFAULT 'user',
             owner_id TEXT,
             created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
             updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
             PRIMARY KEY (database_name, name),
-            CHECK (is_write = 0 OR published = 0)
+            CHECK (is_write = 0 OR is_published = 0)
         );
 
         CREATE INDEX IF NOT EXISTS queries_owner_idx
diff --git a/datasette/views/database.py b/datasette/views/database.py
index a90d889e..ed38189b 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -431,7 +431,7 @@ _query_fields = {
     "fragment",
     "parameters",
     "params",
-    "published",
+    "is_published",
     "on_success_message",
     "on_success_message_sql",
     "on_success_redirect",
@@ -549,7 +549,7 @@ async def _check_query_name(db, name, *, existing=False):
         raise QueryValidationError("Query name conflicts with a table or view")
 
 
-async def _analyze_user_query(datasette, db, sql, *, actor, published):
+async def _analyze_user_query(datasette, db, sql, *, actor, is_published):
     if not sql or not isinstance(sql, str):
         raise QueryValidationError("SQL is required")
     derived = _derived_query_parameters(sql)
@@ -561,7 +561,7 @@ async def _analyze_user_query(datasette, db, sql, *, actor, published):
 
     is_write = _analysis_is_write(analysis)
     if is_write:
-        if published:
+        if is_published:
             raise QueryValidationError("Writable queries cannot be published")
         try:
             await datasette.ensure_query_write_permissions(
@@ -660,7 +660,7 @@ async def _prepare_execute_write(datasette, db, sql, params, actor):
 
 def _apply_query_data_types(data):
     typed = dict(data)
-    for key in ("hide_sql", "published"):
+    for key in ("hide_sql", "is_published"):
         if key in typed:
             typed[key] = _as_bool(typed[key])
     return typed
@@ -677,15 +677,15 @@ async def _prepare_query_create(datasette, request, db, data):
     if await datasette.get_query(db.name, name) is not None:
         raise QueryValidationError("Query already exists")
 
-    published = _as_bool(data.get("published"))
+    is_published = _as_bool(data.get("is_published"))
     is_write, derived, analysis = await _analyze_user_query(
         datasette,
         db,
         data.get("sql"),
         actor=request.actor,
-        published=published,
+        is_published=is_published,
     )
-    if published and not await datasette.allowed(
+    if is_published and not await datasette.allowed(
         action="publish-query",
         resource=DatabaseResource(db.name),
         actor=request.actor,
@@ -708,7 +708,7 @@ async def _prepare_query_create(datasette, request, db, data):
         "fragment": data.get("fragment"),
         "parameters": parameters,
         "is_write": is_write,
-        "published": published,
+        "is_published": is_published,
         "source": "user",
         "owner_id": _actor_id(request.actor),
         "on_success_message": data.get("on_success_message"),
@@ -727,7 +727,7 @@ async def _prepare_query_update(datasette, request, db, existing, update):
 
     update = _apply_query_data_types(update)
     sql = update.get("sql", existing["sql"])
-    published = update.get("published", existing["published"])
+    is_published = update.get("is_published", existing["is_published"])
     query_is_write = existing["is_write"]
     derived = _derived_query_parameters(sql)
     parameters = None
@@ -738,11 +738,11 @@ async def _prepare_query_update(datasette, request, db, existing, update):
             db,
             sql,
             actor=request.actor,
-            published=published,
+            is_published=is_published,
         )
-    elif published and query_is_write:
+    elif is_published and query_is_write:
         raise QueryValidationError("Writable queries cannot be published")
-    if published and not existing["published"]:
+    if is_published and not existing["is_published"]:
         if not await datasette.allowed(
             action="publish-query",
             resource=DatabaseResource(db.name),
@@ -772,7 +772,7 @@ async def _prepare_query_update(datasette, request, db, existing, update):
         "fragment": update.get("fragment"),
         "parameters": parameters,
         "is_write": query_is_write,
-        "published": published,
+        "is_published": is_published,
         "on_success_message": update.get("on_success_message"),
         "on_success_message_sql": update.get("on_success_message_sql"),
         "on_success_redirect": update.get("on_success_redirect"),
diff --git a/docs/internals.rst b/docs/internals.rst
index a0845ade..892cf64c 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -2158,13 +2158,13 @@ The internal database schema is as follows:
         options TEXT NOT NULL DEFAULT '{}',
         parameters TEXT NOT NULL DEFAULT '[]',
         is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
-        published INTEGER NOT NULL DEFAULT 0 CHECK (published IN (0, 1)),
+        is_published INTEGER NOT NULL DEFAULT 0 CHECK (is_published IN (0, 1)),
         source TEXT NOT NULL DEFAULT 'user',
         owner_id TEXT,
         created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
         updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
         PRIMARY KEY (database_name, name),
-        CHECK (is_write = 0 OR published = 0)
+        CHECK (is_write = 0 OR is_published = 0)
     );
     CREATE INDEX queries_owner_idx
         ON queries(owner_id);
diff --git a/queries-plan.md b/queries-plan.md
index dbc46101..0fbddecd 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -13,7 +13,7 @@ Terminology change: these are now "queries", not "canned queries". Legacy code a
 - Internal table name: `queries`.
 - Query definitions should use real columns, not a JSON blob for all options.
 - Query parameter names live in a `parameters` text column as a JSON array. No default values for parameters in this pass.
-- No `queries_database_published_idx` index.
+- No `queries_database_is_published_idx` index.
 - User-created queries require `execute-sql` and `insert-query` on the database. Writable queries additionally require matching table write permissions discovered by `Database.analyze_sql()`.
 - `publish-query` is the permission for creating or updating a query so users without `execute-sql` can execute it.
 - Add `update-query` and `delete-query`, so administrators can manage queries created by other users.
@@ -45,13 +45,13 @@ CREATE TABLE IF NOT EXISTS queries (
     options TEXT NOT NULL DEFAULT '{}',
     parameters TEXT NOT NULL DEFAULT '[]',
     is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
-    published INTEGER NOT NULL DEFAULT 0 CHECK (published IN (0, 1)),
+    is_published INTEGER NOT NULL DEFAULT 0 CHECK (is_published IN (0, 1)),
     source TEXT NOT NULL DEFAULT 'user',
     owner_id TEXT,
     created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
     PRIMARY KEY (database_name, name),
-    CHECK (is_write = 0 OR published = 0)
+    CHECK (is_write = 0 OR is_published = 0)
 );
 
 CREATE INDEX IF NOT EXISTS queries_owner_idx
@@ -65,11 +65,11 @@ Column notes:
 - Less common presentation and writable-query behavior lives in `options`, stored as a JSON object. That covers `hide_sql`, `fragment`, `on_success_message`, `on_success_message_sql`, `on_success_redirect`, `on_error_message`, and `on_error_redirect`.
 - `parameters` is a JSON array of parameter names, stored as text. This preserves explicit parameter order, but does not support labels or default values.
 - Existing writable query behavior gets `is_write` as a column. Success/error messages, success/error redirects, and `on_success_message_sql` are stored in `options`.
-- `published` only applies to read-only queries. A writable query can still be public through explicit `view-query` permissions, but the "publish for users without execute-sql" shortcut should be read-only.
+- `is_published` only applies to read-only queries. A writable query can still be public through explicit `view-query` permissions, but the "publish for users without execute-sql" shortcut should be read-only.
 - `source` distinguishes `user`, `config`, and `plugin` rows.
 - `owner_id` is the actor id for user-created rows. It is `NULL` for config/plugin rows.
 
-No separate index is needed on `(database_name, name)` because the primary key already creates one. Do not add a `queries_database_published_idx` index for now.
+No separate index is needed on `(database_name, name)` because the primary key already creates one. Do not add a `queries_database_is_published_idx` index for now.
 
 `QueryResource.resources_sql()` can become:
 
@@ -115,7 +115,7 @@ User-created query creation requires:
 - `insert-query` on `DatabaseResource(database)`
 - If analysis shows the query is writable, the table-level write permissions described in the writable query section.
 
-Setting `published=1` requires:
+Setting `is_published=1` requires:
 
 - `publish-query` on `DatabaseResource(database)`
 - The query must be read-only according to `Database.analyze_sql()`.
@@ -125,7 +125,7 @@ Updating an existing query requires:
 - `update-query` on `QueryResource(database, query)` or default owner permission for a user-owned row.
 - If the SQL changes, also require `execute-sql` on the database.
 - If the changed SQL is writable, also require the table-level write permissions described in the writable query section.
-- If `published` changes from `0` to `1`, also require `publish-query` on the database.
+- If `is_published` changes from `0` to `1`, also require `publish-query` on the database.
 
 Deleting an existing query requires:
 
@@ -140,12 +140,12 @@ Default owner permissions:
 
 Default execution rule for read-only queries:
 
-- If `published=0`, the actor needs `execute-sql` on the database.
-- If `published=1`, the actor can execute the query without `execute-sql`.
+- If `is_published=0`, the actor needs `execute-sql` on the database.
+- If `is_published=1`, the actor can execute the query without `execute-sql`.
 
 Default execution rule for user-created writable queries:
 
-- `published` must be `0`.
+- `is_published` must be `0`.
 - The actor must have `view-query`.
 - The actor must currently have every write permission required by fresh `Database.analyze_sql()` results for the query SQL.
 
@@ -153,8 +153,8 @@ Implementation:
 
 - Remove `view-query` from the broad `DEFAULT_ALLOW_ACTIONS` set.
 - Replace it with query-aware default `view-query` permission SQL.
-- For `published=1 AND is_write=0`, emit a child-level `view-query` allow.
-- For `published=0 AND is_write=0`, emit child-level `view-query` allows for queries whose parent database is in the actor's `execute-sql` allowed resources.
+- For `is_published=1 AND is_write=0`, emit a child-level `view-query` allow.
+- For `is_published=0 AND is_write=0`, emit child-level `view-query` allows for queries whose parent database is in the actor's `execute-sql` allowed resources.
 - For `is_write=1 AND source='user'`, emit `view-query` only for the owner or actors with explicit `view-query` permission, then have `QueryView` perform the fresh analysis/table-permission check before execution.
 - For trusted writable queries, preserve current behavior by emitting child-level `view-query` allows for `is_write=1 AND source IN ('config', 'plugin')` when Datasette is not running with `--default-deny`.
 
@@ -181,7 +181,7 @@ Validation flow for user-created queries:
 1. Derive named parameters from the SQL and pass harmless placeholder values into `db.analyze_sql()` so SQLite can prepare statements with bindings.
 2. If analysis raises a SQLite error, reject the query.
 3. If every table access is `read`, treat the query as read-only and require `execute-sql` plus `insert-query`/`update-query` as described above.
-4. If any table access is `insert`, `update`, or `delete`, treat the query as writable and force `published=0`.
+4. If any table access is `insert`, `update`, or `delete`, treat the query as writable and force `is_published=0`.
 5. Reject writable user-created queries that access a database other than the database they are being saved against, until `analyze_sql()` can reliably map attached SQLite schemas back to Datasette database names.
 6. For every write access returned by analysis, require the corresponding permission on `TableResource(access.database, access.table)`:
    - `insert` -> `insert-row`
@@ -201,7 +201,7 @@ Fail closed cases for user-created writable queries:
 - Analysis reports any write operation that cannot be mapped to a Datasette table resource.
 - Analysis reports writes outside the target database.
 - The actor lacks any required table write permission.
-- `published=1` is requested.
+- `is_published=1` is requested.
 
 This gives us writable user-created queries without letting `execute-sql` alone become a path to create arbitrary write endpoints.
 
@@ -226,7 +226,7 @@ Create request:
     "sql": "select * from customers order by revenue desc limit 20",
     "title": "Top customers",
     "description": "Highest revenue customers",
-    "published": false,
+    "is_published": false,
     "parameters": ["region"]
   }
 }
@@ -243,7 +243,7 @@ Successful create returns `201` and the created query definition:
     "sql": "select * from customers order by revenue desc limit 20",
     "title": "Top customers",
     "description": "Highest revenue customers",
-    "published": false,
+    "is_published": false,
     "parameters": ["region"]
   }
 }
@@ -255,7 +255,7 @@ Update request, imitating `RowUpdateView`:
 {
   "update": {
     "title": "Top customers by revenue",
-    "published": true
+    "is_published": true
   },
   "return": true
 }
@@ -271,7 +271,7 @@ Successful update returns `{"ok": true}` by default. With `"return": true`, retu
     "name": "top_customers",
     "sql": "select * from customers order by revenue desc limit 20",
     "title": "Top customers by revenue",
-    "published": true
+    "is_published": true
   }
 }
 ```
@@ -318,7 +318,7 @@ await datasette.add_query(
     fragment=None,
     parameters=None,
     is_write=False,
-    published=False,
+    is_published=False,
     source="plugin",
     owner_id=None,
     on_success_message=None,
@@ -341,7 +341,7 @@ await datasette.update_query(
     fragment=UNCHANGED,
     parameters=UNCHANGED,
     is_write=UNCHANGED,
-    published=UNCHANGED,
+    is_published=UNCHANGED,
     source=UNCHANGED,
     owner_id=UNCHANGED,
     on_success_message=UNCHANGED,
@@ -371,13 +371,13 @@ For column-backed fields, `None` should write SQL `NULL`. For option fields, `No
 
 Implementation detail: build the `UPDATE` statement dynamically from fields whose value is not `UNCHANGED`, validate non-nullable fields before writing, and update `updated_at` whenever at least one field changes.
 
-The read methods should reconstruct the existing dictionary shape used by query execution and templates, with `name`, `sql`, display fields, write fields, `params`, `published`, `owner_id`, and `source`. `parameters` should be returned as the decoded JSON array and exposed as `params` where existing query execution code expects that key. Option values should be unpacked from the `options` JSON object and returned as the same top-level keys accepted by `add_query()` and `update_query()`.
+The read methods should reconstruct the existing dictionary shape used by query execution and templates, with `name`, `sql`, display fields, write fields, `params`, `is_published`, `owner_id`, and `source`. `parameters` should be returned as the decoded JSON array and exposed as `params` where existing query execution code expects that key. Option values should be unpacked from the `options` JSON object and returned as the same top-level keys accepted by `add_query()` and `update_query()`.
 
 ## Query page save UI
 
 On `/{database}/-/query`, if the actor has both `execute-sql` and `insert-query`, show a save control for valid read-only SQL. That page already executes read-only arbitrary SQL, so the first UI can stay read-only even though the JSON API can accept writable SQL after `Database.analyze_sql()` validation.
 
-The save form should call `POST /{database}/-/queries/-/insert` and default to `published=false`.
+The save form should call `POST /{database}/-/queries/-/insert` and default to `is_published=false`.
 
 If the actor also has `publish-query`, include a publish control. The UI copy should make it clear that publishing allows people without arbitrary SQL permission to run this query.
 
@@ -416,7 +416,7 @@ The existing edit-SQL flow from query pages can continue to point back to arbitr
 - `view-query` is no longer globally default-allowed; default query permissions come from the query-aware hook.
 - Unpublished read-only query requires `execute-sql` to execute.
 - Published read-only query can be executed without `execute-sql`.
-- Setting `published=true` requires `publish-query`.
+- Setting `is_published=true` requires `publish-query`.
 - User-created query requires both `execute-sql` and `insert-query`.
 - User-created writable query creation uses `Database.analyze_sql()` and requires matching `insert-row`, `update-row`, and/or `delete-row` permissions for every reported write access.
 - `/{database}/-/queries/-/create` provides the writable-query authoring UI with an analysis panel and disabled save until all required write permissions pass.
diff --git a/tests/test_queries.py b/tests/test_queries.py
index edb9484a..df4131b9 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -30,7 +30,7 @@ async def test_queries_internal_table_schema():
         "options",
         "parameters",
         "is_write",
-        "published",
+        "is_published",
         "source",
         "owner_id",
         "created_at",
@@ -53,7 +53,7 @@ async def test_add_get_and_remove_query():
         hide_sql=True,
         fragment="chart",
         parameters=["region"],
-        published=True,
+        is_published=True,
         source="user",
         owner_id="alice",
     )
@@ -86,7 +86,7 @@ async def test_add_get_and_remove_query():
         "parameters": ["region"],
         "is_write": False,
         "write": False,
-        "published": True,
+        "is_published": True,
         "source": "user",
         "owner_id": "alice",
         "on_success_message": None,
@@ -143,7 +143,7 @@ async def test_update_query_only_updates_provided_fields():
     assert query["params"] == []
     assert query["on_success_redirect"] is None
     assert query["sql"] == "select 1"
-    assert query["published"] is False
+    assert query["is_published"] is False
     options_row = (
         await ds.get_internal_database().execute(
             """
@@ -190,7 +190,7 @@ async def test_config_queries_imported_to_internal_table():
         "parameters": ["name"],
         "is_write": False,
         "write": False,
-        "published": False,
+        "is_published": False,
         "source": "config",
         "owner_id": None,
         "on_success_message": None,
@@ -218,8 +218,8 @@ async def test_unpublished_query_requires_execute_sql_but_published_does_not():
     ds = Datasette(memory=True, settings={"default_allow_sql": False})
     ds.add_memory_database("query_permissions", name="data")
     await ds.invoke_startup()
-    await ds.add_query("data", "unpublished", "select 1", published=False)
-    await ds.add_query("data", "published", "select 1", published=True)
+    await ds.add_query("data", "unpublished", "select 1", is_published=False)
+    await ds.add_query("data", "published", "select 1", is_published=True)
 
     assert not await ds.allowed(
         action="execute-sql",
@@ -347,7 +347,7 @@ async def test_query_list_and_definition_api():
     ds.root_enabled = True
     ds.add_memory_database("query_list_api", name="data")
     await ds.invoke_startup()
-    await ds.add_query("data", "listed", "select 1", title="Listed", published=True)
+    await ds.add_query("data", "listed", "select 1", title="Listed", is_published=True)
 
     list_response = await ds.client.get(
         "/data/-/queries",
@@ -387,7 +387,7 @@ async def test_query_insert_api_publish_requires_publish_query():
     response = await ds.client.post(
         "/data/-/queries/-/insert",
         actor={"id": "writer"},
-        json={"query": {"name": "public", "sql": "select 1", "published": True}},
+        json={"query": {"name": "public", "sql": "select 1", "is_published": True}},
     )
 
     assert response.status_code == 403
@@ -416,7 +416,7 @@ async def test_query_insert_api_creates_writable_query():
     assert response.status_code == 201
     query = response.json()["query"]
     assert query["is_write"] is True
-    assert query["published"] is False
+    assert query["is_published"] is False
     assert query["parameters"] == ["name"]
 
     bad_response = await ds.client.post(
@@ -426,7 +426,7 @@ async def test_query_insert_api_creates_writable_query():
             "query": {
                 "name": "published_insert",
                 "sql": "insert into dogs (name) values (:name)",
-                "published": True,
+                "is_published": True,
             }
         },
     )

From 2d07c3b99e654b54c604df4af601ebe27f52b017 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 09:47:12 -0700
Subject: [PATCH 057/386] Ran cog

---
 datasette/utils/internal_db.py | 3 +--
 docs/plugins.rst               | 9 +++++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/datasette/utils/internal_db.py b/datasette/utils/internal_db.py
index 0f84e886..9c693b0a 100644
--- a/datasette/utils/internal_db.py
+++ b/datasette/utils/internal_db.py
@@ -128,8 +128,7 @@ async def initialize_metadata_tables(db):
             owner_id TEXT,
             created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
             updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
-            PRIMARY KEY (database_name, name),
-            CHECK (is_write = 0 OR is_published = 0)
+            PRIMARY KEY (database_name, name)
         );
 
         CREATE INDEX IF NOT EXISTS queries_owner_idx
diff --git a/docs/plugins.rst b/docs/plugins.rst
index 8fa49d6d..d578e9e2 100644
--- a/docs/plugins.rst
+++ b/docs/plugins.rst
@@ -216,6 +216,15 @@ If you run ``datasette plugins --all`` it will include default plugins that ship
                 "register_column_types"
             ]
         },
+        {
+            "name": "datasette.default_database_actions",
+            "static": false,
+            "templates": false,
+            "version": null,
+            "hooks": [
+                "database_actions"
+            ]
+        },
         {
             "name": "datasette.default_debug_menu",
             "static": false,

From 539ff9ddfcdec0283758138987ddb362485e6ad7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 09:49:21 -0700
Subject: [PATCH 058/386] Drop query publication check from docs

Refs #2735
---
 docs/internals.rst | 3 +--
 queries-plan.md    | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/docs/internals.rst b/docs/internals.rst
index 892cf64c..b5da7cbf 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -2163,8 +2163,7 @@ The internal database schema is as follows:
         owner_id TEXT,
         created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
         updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
-        PRIMARY KEY (database_name, name),
-        CHECK (is_write = 0 OR is_published = 0)
+        PRIMARY KEY (database_name, name)
     );
     CREATE INDEX queries_owner_idx
         ON queries(owner_id);
diff --git a/queries-plan.md b/queries-plan.md
index 0fbddecd..a58ace70 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -50,8 +50,7 @@ CREATE TABLE IF NOT EXISTS queries (
     owner_id TEXT,
     created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
-    PRIMARY KEY (database_name, name),
-    CHECK (is_write = 0 OR is_published = 0)
+    PRIMARY KEY (database_name, name)
 );
 
 CREATE INDEX IF NOT EXISTS queries_owner_idx

From 4a70b893559897034625bd797c8fccc80116844a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 10:11:46 -0700
Subject: [PATCH 059/386] Add cursor-paginated query browser

Refs #2735
---
 datasette/app.py                    | 129 +++++++++++++++++++++++++---
 datasette/templates/database.html   |   3 +
 datasette/templates/query_list.html |  55 ++++++++++++
 datasette/views/database.py         | 125 ++++++++++++++++++++-------
 docs/json_api.rst                   |   2 +-
 queries-plan.md                     |  18 +++-
 tests/test_queries.py               | 107 +++++++++++++++++++++--
 7 files changed, 389 insertions(+), 50 deletions(-)
 create mode 100644 datasette/templates/query_list.html

diff --git a/datasette/app.py b/datasette/app.py
index 40877802..bdbf9389 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -1288,16 +1288,122 @@ class Datasette:
         )
         return self._query_row_to_dict(rows.first())
 
-    async def get_queries(self, database):
-        rows = await self.get_internal_database().execute(
-            """
-            SELECT * FROM queries
-            WHERE database_name = ?
-            ORDER BY name
-            """,
-            [database],
+    async def list_queries(
+        self,
+        database,
+        *,
+        actor=None,
+        limit=50,
+        cursor=None,
+        q=None,
+        is_write=None,
+        is_published=None,
+        source=None,
+        owner_id=None,
+        include_private=False,
+    ):
+        limit = min(max(1, int(limit)), 1000)
+        allowed_sql, allowed_params = await self.allowed_resources_sql(
+            action="view-query",
+            actor=actor,
+            parent=database,
+            include_is_private=include_private,
         )
-        return {row["name"]: self._query_row_to_dict(row) for row in rows}
+        params = dict(allowed_params)
+        params.update({"query_database": database, "limit": limit + 1})
+        sort_key_sql = "lower(coalesce(nullif(q.title, ''), q.name))"
+        where_clauses = ["q.database_name = :query_database"]
+
+        if cursor:
+            try:
+                components = urlsafe_components(cursor)
+            except ValueError:
+                components = []
+            if len(components) == 2:
+                where_clauses.append("""
+                    (
+                        {sort_key_sql} > :cursor_sort_key
+                        OR (
+                            {sort_key_sql} = :cursor_sort_key
+                            AND q.name > :cursor_name
+                        )
+                    )
+                    """.format(sort_key_sql=sort_key_sql))
+                params["cursor_sort_key"] = components[0]
+                params["cursor_name"] = components[1]
+
+        if q:
+            where_clauses.append("""
+                (
+                    q.name LIKE :query_search
+                    OR q.title LIKE :query_search
+                    OR q.description LIKE :query_search
+                    OR q.sql LIKE :query_search
+                )
+                """)
+            params["query_search"] = "%{}%".format(q)
+        if is_write is not None:
+            where_clauses.append("q.is_write = :query_is_write")
+            params["query_is_write"] = int(bool(is_write))
+        if is_published is not None:
+            where_clauses.append("q.is_published = :query_is_published")
+            params["query_is_published"] = int(bool(is_published))
+        if source is not None:
+            where_clauses.append("q.source = :query_source")
+            params["query_source"] = source
+        if owner_id is not None:
+            where_clauses.append("q.owner_id = :query_owner_id")
+            params["query_owner_id"] = owner_id
+
+        private_select = ", allowed.is_private AS private" if include_private else ""
+        rows = list(
+            (
+                await self.get_internal_database().execute(
+                    """
+                    SELECT q.*, {sort_key_sql} AS sort_key{private_select}
+                    FROM queries q
+                    JOIN (
+                        {allowed_sql}
+                    ) allowed
+                      ON allowed.parent = q.database_name
+                     AND allowed.child = q.name
+                    WHERE {where}
+                    ORDER BY sort_key, q.name
+                    LIMIT :limit
+                    """.format(
+                        allowed_sql=allowed_sql,
+                        private_select=private_select,
+                        sort_key_sql=sort_key_sql,
+                        where=" AND ".join(where_clauses),
+                    ),
+                    params,
+                )
+            ).rows
+        )
+        has_more = len(rows) > limit
+        if has_more:
+            rows = rows[:limit]
+
+        queries = []
+        for row in rows:
+            query = self._query_row_to_dict(row)
+            if include_private:
+                query["private"] = bool(row["private"])
+            queries.append(query)
+
+        next_token = None
+        if has_more and rows:
+            last_row = rows[-1]
+            next_token = "{},{}".format(
+                tilde_encode(last_row["sort_key"]),
+                tilde_encode(last_row["name"]),
+            )
+        return {
+            "queries": queries,
+            "next": next_token,
+            "has_more": has_more,
+            "limit": limit,
+        }
 
     async def ensure_query_write_permissions(
         self, database, sql, *, actor=None, params=None, analysis=None
@@ -1564,7 +1670,8 @@ class Datasette:
         return self.static_hash("app.css")
 
     async def get_canned_queries(self, database_name, actor):
-        return await self.get_queries(database_name)
+        page = await self.list_queries(database_name, actor=actor, limit=1000)
+        return {query["name"]: query for query in page["queries"]}
 
     async def get_canned_query(self, database_name, query_name, actor):
         return await self.get_query(database_name, query_name)
@@ -2591,7 +2698,7 @@ class Datasette:
         add_route(TableCreateView.as_view(self), r"/(?P<database>[^\/\.]+)/-/create$")
         add_route(
             QueryListView.as_view(self),
-            r"/(?P<database>[^\/\.]+)/-/queries$",
+            r"/(?P<database>[^\/\.]+)/-/queries(\.(?P<format>json))?$",
         )
         add_route(
             QueryCreateView.as_view(self),
diff --git a/datasette/templates/database.html b/datasette/templates/database.html
index 42b4ca0b..a39d6ad7 100644
--- a/datasette/templates/database.html
+++ b/datasette/templates/database.html
@@ -53,6 +53,9 @@
             <li><a href="{{ urls.query(database, query.name) }}{% if query.fragment %}#{{ query.fragment }}{% endif %}" title="{{ query.description or query.sql }}">{{ query.title or query.name }}</a>{% if query.private %} 🔒{% endif %}</li>
         {% endfor %}
     </ul>
+    {% if queries_more %}
+        <p><a href="{{ urls.database(database) }}/-/queries">View all queries</a></p>
+    {% endif %}
 {% endif %}
 
 {% if tables %}
diff --git a/datasette/templates/query_list.html b/datasette/templates/query_list.html
new file mode 100644
index 00000000..ef5da0d5
--- /dev/null
+++ b/datasette/templates/query_list.html
@@ -0,0 +1,55 @@
+{% extends "base.html" %}
+
+{% block title %}{{ database }}: queries{% endblock %}
+
+{% block body_class %}query-list db-{{ database|to_css_class }}{% endblock %}
+
+{% block crumbs %}
+{{ crumbs.nav(request=request, database=database) }}
+{% endblock %}
+
+{% block content %}
+
+<h1>Queries</h1>
+
+<form action="{{ urls.database(database) }}/-/queries" method="get">
+    <p>
+        <label for="query-search">Search</label>
+        <input id="query-search" type="search" name="q" value="{{ filters.q }}">
+        <button type="submit">Search</button>
+    </p>
+    <p>
+        <label for="query-is-write">Mode</label>
+        <select id="query-is-write" name="is_write">
+            <option value=""{% if not filters.is_write %} selected{% endif %}>Any</option>
+            <option value="0"{% if filters.is_write == "0" %} selected{% endif %}>Read-only</option>
+            <option value="1"{% if filters.is_write == "1" %} selected{% endif %}>Writable</option>
+        </select>
+        <label for="query-is-published">Publication</label>
+        <select id="query-is-published" name="is_published">
+            <option value=""{% if not filters.is_published %} selected{% endif %}>Any</option>
+            <option value="1"{% if filters.is_published == "1" %} selected{% endif %}>Published</option>
+            <option value="0"{% if filters.is_published == "0" %} selected{% endif %}>Unpublished</option>
+        </select>
+    </p>
+</form>
+
+{% if queries %}
+    <ul class="bullets">
+        {% for query in queries %}
+            <li>
+                <a href="{{ urls.query(database, query.name) }}{% if query.fragment %}#{{ query.fragment }}{% endif %}" title="{{ query.description or query.sql }}">{{ query.title or query.name }}</a>{% if query.private %} 🔒{% endif %}
+                {% if query.is_write %}<span>Writable</span>{% endif %}
+                {% if query.is_published %}<span>Published</span>{% endif %}
+            </li>
+        {% endfor %}
+    </ul>
+{% else %}
+    <p>No queries found.</p>
+{% endif %}
+
+{% if next_url %}
+    <p><a href="{{ next_url }}">Next page</a></p>
+{% endif %}
+
+{% endblock %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index ed38189b..edbc315e 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -92,24 +92,14 @@ class DatabaseView(View):
 
         tables = await get_tables(datasette, request, db, allowed_dict)
 
-        # Get allowed queries using the new permission system
-        allowed_query_page = await datasette.allowed_resources(
-            "view-query",
-            request.actor,
-            parent=database,
-            include_is_private=True,
-            limit=1000,
+        queries_page = await datasette.list_queries(
+            database,
+            actor=request.actor,
+            limit=20,
+            include_private=True,
         )
-
-        # Build canned_queries list by looking up each allowed query
-        all_queries = await datasette.get_canned_queries(database, request.actor)
-        canned_queries = []
-        for query_resource in allowed_query_page.resources:
-            query_name = query_resource.child
-            if query_name in all_queries:
-                canned_queries.append(
-                    dict(all_queries[query_name], private=query_resource.private)
-                )
+        canned_queries = queries_page["queries"]
+        queries_more = queries_page["has_more"]
 
         async def database_actions():
             links = []
@@ -141,6 +131,7 @@ class DatabaseView(View):
             "hidden_count": len([t for t in tables if t["hidden"]]),
             "views": sql_views,
             "queries": canned_queries,
+            "queries_more": queries_more,
             "allow_execute_sql": allow_execute_sql,
             "table_columns": (
                 await _table_columns(datasette, database) if allow_execute_sql else {}
@@ -174,6 +165,7 @@ class DatabaseView(View):
                     hidden_count=len([t for t in tables if t["hidden"]]),
                     views=sql_views,
                     queries=canned_queries,
+                    queries_more=queries_more,
                     allow_execute_sql=allow_execute_sql,
                     table_columns=(
                         await _table_columns(datasette, database)
@@ -222,6 +214,9 @@ class DatabaseContext(Context):
     hidden_count: int = field(metadata={"help": "Count of hidden tables"})
     views: list = field(metadata={"help": "List of view objects in the database"})
     queries: list = field(metadata={"help": "List of canned query objects"})
+    queries_more: bool = field(
+        metadata={"help": "Boolean indicating if more saved queries are available"}
+    )
     allow_execute_sql: bool = field(
         metadata={"help": "Boolean indicating if custom SQL can be executed"}
     )
@@ -474,6 +469,31 @@ def _as_bool(value):
     return bool(value)
 
 
+def _as_optional_bool(value, name):
+    if value is None or value == "":
+        return None
+    if isinstance(value, bool):
+        return value
+    if isinstance(value, int):
+        return bool(value)
+    if isinstance(value, str):
+        lowered = value.lower()
+        if lowered in {"1", "true", "t", "yes", "on"}:
+            return True
+        if lowered in {"0", "false", "f", "no", "off"}:
+            return False
+    raise QueryValidationError("{} must be 0 or 1".format(name))
+
+
+def _query_list_limit(value):
+    if value in (None, ""):
+        return 50
+    try:
+        return min(max(1, int(value)), 1000)
+    except ValueError as ex:
+        raise QueryValidationError("_size must be an integer") from ex
+
+
 def _derived_query_parameters(sql):
     parameters = []
     seen = set()
@@ -949,19 +969,66 @@ class QueryListView(BaseView):
 
     async def get(self, request):
         db = await self.ds.resolve_database(request)
-        page = await self.ds.allowed_resources(
-            "view-query",
-            request.actor,
-            parent=db.name,
-            limit=1000,
+        format_ = request.url_vars.get("format") or "html"
+        try:
+            limit = _query_list_limit(request.args.get("_size"))
+            is_write = _as_optional_bool(request.args.get("is_write"), "is_write")
+            is_published = _as_optional_bool(
+                request.args.get("is_published"), "is_published"
+            )
+        except QueryValidationError as ex:
+            return _error([ex.message], ex.status)
+
+        page = await self.ds.list_queries(
+            db.name,
+            actor=request.actor,
+            limit=limit,
+            cursor=request.args.get("_next"),
+            q=request.args.get("q") or None,
+            is_write=is_write,
+            is_published=is_published,
+            source=request.args.get("source") or None,
+            owner_id=request.args.get("owner_id") or None,
+            include_private=True,
+        )
+        next_url = None
+        if page["next"]:
+            pairs = [
+                (key, value)
+                for key, value in parse_qsl(
+                    request.query_string, keep_blank_values=True
+                )
+                if key != "_next"
+            ]
+            pairs.append(("_next", page["next"]))
+            next_url = "{}?{}".format(
+                self.ds.urls.database(db.name) + "/-/queries",
+                urlencode(pairs),
+            )
+
+        data = {
+            "ok": True,
+            "database": db.name,
+            "queries": page["queries"],
+            "next": page["next"],
+            "next_url": next_url,
+            "has_more": page["has_more"],
+            "limit": page["limit"],
+            "filters": {
+                "q": request.args.get("q") or "",
+                "is_write": request.args.get("is_write") or "",
+                "is_published": request.args.get("is_published") or "",
+                "source": request.args.get("source") or "",
+                "owner_id": request.args.get("owner_id") or "",
+            },
+        }
+        if format_ == "json":
+            return Response.json(data)
+        return await self.render(
+            ["query_list.html"],
+            request,
+            data,
         )
-        all_queries = await self.ds.get_queries(db.name)
-        queries = [
-            all_queries[resource.child]
-            for resource in page.resources
-            if resource.child in all_queries
-        ]
-        return Response.json({"ok": True, "database": db.name, "queries": queries})
 
 
 class QueryCreateView(BaseView):
diff --git a/docs/json_api.rst b/docs/json_api.rst
index e4c9e86e..ece430c2 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -510,7 +510,7 @@ Datasette provides a write API for JSON data. This is a POST-only API that requi
 Listing saved queries
 ~~~~~~~~~~~~~~~~~~~~~
 
-``GET /<database>/-/queries`` returns saved query definitions the actor can view.
+``GET /<database>/-/queries.json`` returns saved query definitions the actor can view. Use ``?_size=50`` to set the page size and ``?_next=...`` with the cursor returned by the previous page to fetch the next page.
 
 .. _QueryCreateView:
 
diff --git a/queries-plan.md b/queries-plan.md
index a58ace70..671fc29c 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -210,7 +210,7 @@ JSON endpoints should follow Datasette's existing write API style: use `POST` pl
 
 Endpoints:
 
-- `GET /{database}/-/queries` lists query definitions the actor can view or manage, probably paginated.
+- `GET /{database}/-/queries` shows a searchable HTML query browser. `GET /{database}/-/queries.json` returns query definitions the actor can view, using cursor pagination with `_next` and `_size`.
 - `POST /{database}/-/queries/-/insert` creates a query.
 - `GET /{database}/{query}/-/definition` returns one query definition without executing it.
 - `POST /{database}/{query}/-/update` updates one query.
@@ -353,9 +353,21 @@ await datasette.update_query(
 await datasette.remove_query(database, name, source=None)
 
 await datasette.get_query(database, name)
-await datasette.get_queries(database)
+await datasette.list_queries(
+    database,
+    actor=None,
+    limit=50,
+    cursor=None,
+    q=None,
+    is_write=None,
+    is_published=None,
+    source=None,
+    owner_id=None,
+)
 ```
 
+`list_queries()` should return a bounded page shaped like `{"queries": [...], "next": "...", "has_more": true, "limit": 50}`. The `next` value is an opaque cursor token, not an offset.
+
 `update_query()` should use an internal sentinel default such as `UNCHANGED = object()` so callers can distinguish "leave this column alone" from "set this column to `NULL`":
 
 ```python
@@ -380,6 +392,8 @@ The save form should call `POST /{database}/-/queries/-/insert` and default to `
 
 If the actor also has `publish-query`, include a publish control. The UI copy should make it clear that publishing allows people without arbitrary SQL permission to run this query.
 
+On `/{database}`, show a preview of the first 20 visible queries using `list_queries(..., limit=20)`. If the page has `has_more`, show a link to `/{database}/-/queries` rather than rendering hundreds or thousands of query links inline. The full `/{database}/-/queries` page provides search, filters, and cursor pagination.
+
 ## Dedicated create query UI
 
 Add `/{database}/-/queries/-/create` for the fuller query authoring flow, including writable queries.
diff --git a/tests/test_queries.py b/tests/test_queries.py
index df4131b9..dd906faf 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -7,6 +7,20 @@ from datasette.resources import DatabaseResource, QueryResource
 from datasette.utils.asgi import Forbidden
 
 
+async def add_numbered_queries(ds, database, count):
+    for i in range(1, count + 1):
+        await ds.add_query(
+            database,
+            "demo_query_{:02d}".format(i),
+            "select {} as query_number".format(i),
+            title="Demo query {:02d}".format(i),
+            description="Seeded demo query number {:02d}".format(i),
+            is_published=True,
+            source="user",
+            owner_id="root",
+        )
+
+
 @pytest.mark.asyncio
 async def test_queries_internal_table_schema():
     ds = Datasette(memory=True)
@@ -96,11 +110,15 @@ async def test_add_get_and_remove_query():
         "on_error_redirect": None,
     }
 
-    assert await ds.get_queries("data") == {"top_customers": query}
+    queries_page = await ds.list_queries("data", actor=None)
+    assert queries_page["queries"] == [query]
+    assert queries_page["next"] is None
 
     await ds.remove_query("data", "top_customers")
     assert await ds.get_query("data", "top_customers") is None
-    assert await ds.get_queries("data") == {}
+    queries_page = await ds.list_queries("data", actor=None)
+    assert queries_page["queries"] == []
+    assert queries_page["next"] is None
 
 
 @pytest.mark.asyncio
@@ -238,6 +256,24 @@ async def test_unpublished_query_requires_execute_sql_but_published_does_not():
     )
 
 
+@pytest.mark.asyncio
+async def test_database_page_query_preview_is_limited():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("query_preview", name="data")
+    await ds.invoke_startup()
+    await add_numbered_queries(ds, "data", 25)
+
+    html_response = await ds.client.get("/data")
+    json_response = await ds.client.get("/data.json")
+
+    assert html_response.status_code == 200
+    assert "Demo query 20" in html_response.text
+    assert "Demo query 21" not in html_response.text
+    assert 'href="/data/-/queries"' in html_response.text
+    assert len(json_response.json()["queries"]) == 20
+    assert json_response.json()["queries_more"] is True
+
+
 @pytest.mark.asyncio
 async def test_query_actions_are_registered():
     ds = Datasette()
@@ -347,21 +383,78 @@ async def test_query_list_and_definition_api():
     ds.root_enabled = True
     ds.add_memory_database("query_list_api", name="data")
     await ds.invoke_startup()
-    await ds.add_query("data", "listed", "select 1", title="Listed", is_published=True)
+    await add_numbered_queries(ds, "data", 12)
 
     list_response = await ds.client.get(
-        "/data/-/queries",
+        "/data/-/queries.json?_size=5",
+        actor={"id": "root"},
+    )
+    next_response = await ds.client.get(
+        "/data/-/queries.json?_size=5&_next={}".format(list_response.json()["next"]),
         actor={"id": "root"},
     )
     definition_response = await ds.client.get(
-        "/data/listed/-/definition",
+        "/data/demo_query_01/-/definition",
         actor={"id": "root"},
     )
 
     assert list_response.status_code == 200
-    assert list_response.json()["queries"][0]["name"] == "listed"
+    assert [query["name"] for query in list_response.json()["queries"]] == [
+        "demo_query_01",
+        "demo_query_02",
+        "demo_query_03",
+        "demo_query_04",
+        "demo_query_05",
+    ]
+    assert list_response.json()["next"]
+    assert [query["name"] for query in next_response.json()["queries"]] == [
+        "demo_query_06",
+        "demo_query_07",
+        "demo_query_08",
+        "demo_query_09",
+        "demo_query_10",
+    ]
     assert definition_response.status_code == 200
-    assert definition_response.json()["query"]["title"] == "Listed"
+    assert definition_response.json()["query"]["title"] == "Demo query 01"
+
+
+@pytest.mark.asyncio
+async def test_query_list_search_filter_and_html():
+    ds = Datasette(memory=True)
+    ds.root_enabled = True
+    ds.add_memory_database("query_list_html", name="data")
+    await ds.invoke_startup()
+    await add_numbered_queries(ds, "data", 3)
+    await ds.add_query(
+        "data",
+        "private_query",
+        "select 'private'",
+        title="Private query",
+        is_published=False,
+        source="user",
+        owner_id="root",
+    )
+
+    html_response = await ds.client.get(
+        "/data/-/queries?q=02",
+        actor={"id": "root"},
+    )
+    json_response = await ds.client.get(
+        "/data/-/queries.json?q=02",
+        actor={"id": "root"},
+    )
+    filtered_response = await ds.client.get(
+        "/data/-/queries.json?is_published=0",
+        actor={"id": "root"},
+    )
+
+    assert html_response.status_code == 200
+    assert "Demo query 02" in html_response.text
+    assert "Demo query 01" not in html_response.text
+    assert json_response.json()["queries"][0]["name"] == "demo_query_02"
+    assert [query["name"] for query in filtered_response.json()["queries"]] == [
+        "private_query"
+    ]
 
 
 @pytest.mark.asyncio

From 310c36ae94c54d4b859925d4977554c2a2618534 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 10:18:36 -0700
Subject: [PATCH 060/386] Limit database query preview to five

Refs #2735
---
 datasette/views/database.py  |  2 +-
 queries-plan.md              |  2 +-
 tests/test_canned_queries.py | 35 ++++++++++++++++++++++++++++++-----
 tests/test_queries.py        |  6 +++---
 4 files changed, 35 insertions(+), 10 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index edbc315e..353cfcf2 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -95,7 +95,7 @@ class DatabaseView(View):
         queries_page = await datasette.list_queries(
             database,
             actor=request.actor,
-            limit=20,
+            limit=5,
             include_private=True,
         )
         canned_queries = queries_page["queries"]
diff --git a/queries-plan.md b/queries-plan.md
index 671fc29c..82ef3260 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -392,7 +392,7 @@ The save form should call `POST /{database}/-/queries/-/insert` and default to `
 
 If the actor also has `publish-query`, include a publish control. The UI copy should make it clear that publishing allows people without arbitrary SQL permission to run this query.
 
-On `/{database}`, show a preview of the first 20 visible queries using `list_queries(..., limit=20)`. If the page has `has_more`, show a link to `/{database}/-/queries` rather than rendering hundreds or thousands of query links inline. The full `/{database}/-/queries` page provides search, filters, and cursor pagination.
+On `/{database}`, show a preview of the first 5 visible queries using `list_queries(..., limit=5)`. If the page has `has_more`, show a link to `/{database}/-/queries` rather than rendering hundreds or thousands of query links inline. The full `/{database}/-/queries` page provides search, filters, and cursor pagination.
 
 ## Dedicated create query UI
 
diff --git a/tests/test_canned_queries.py b/tests/test_canned_queries.py
index c46fd86f..a9d22036 100644
--- a/tests/test_canned_queries.py
+++ b/tests/test_canned_queries.py
@@ -248,10 +248,9 @@ def test_json_response(canned_write_client, headers, body, querystring):
 
 
 def test_canned_query_permissions_on_database_page(canned_write_client):
-    # Without auth only shows three queries
-    query_names = {
-        q["name"] for q in canned_write_client.get("/data.json").json["queries"]
-    }
+    # Without auth shows the five public queries
+    anon_response = canned_write_client.get("/data.json")
+    query_names = {q["name"] for q in anon_response.json["queries"]}
     assert query_names == {
         "add_name_specify_id_with_error_in_on_success_message_sql",
         "update_name",
@@ -259,8 +258,9 @@ def test_canned_query_permissions_on_database_page(canned_write_client):
         "canned_read",
         "add_name",
     }
+    assert anon_response.json["queries_more"] is False
 
-    # With auth shows four
+    # With auth the database page preview shows the first five queries
     response = canned_write_client.get(
         "/data.json",
         cookies={"ds_actor": canned_write_client.actor_cookie({"id": "root"})},
@@ -273,6 +273,31 @@ def test_canned_query_permissions_on_database_page(canned_write_client):
         ],
         key=lambda q: q["name"],
     )
+    assert query_names_and_private == [
+        {"name": "add_name", "private": False},
+        {"name": "add_name_specify_id", "private": False},
+        {
+            "name": "add_name_specify_id_with_error_in_on_success_message_sql",
+            "private": False,
+        },
+        {"name": "canned_read", "private": False},
+        {"name": "delete_name", "private": True},
+    ]
+    assert response.json["queries_more"] is True
+
+    # The full query list endpoint includes the remaining query
+    response = canned_write_client.get(
+        "/data/-/queries.json?_size=10",
+        cookies={"ds_actor": canned_write_client.actor_cookie({"id": "root"})},
+    )
+    assert response.status == 200
+    query_names_and_private = sorted(
+        [
+            {"name": q["name"], "private": q["private"]}
+            for q in response.json["queries"]
+        ],
+        key=lambda q: q["name"],
+    )
     assert query_names_and_private == [
         {"name": "add_name", "private": False},
         {"name": "add_name_specify_id", "private": False},
diff --git a/tests/test_queries.py b/tests/test_queries.py
index dd906faf..2b46e00f 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -267,10 +267,10 @@ async def test_database_page_query_preview_is_limited():
     json_response = await ds.client.get("/data.json")
 
     assert html_response.status_code == 200
-    assert "Demo query 20" in html_response.text
-    assert "Demo query 21" not in html_response.text
+    assert "Demo query 05" in html_response.text
+    assert "Demo query 06" not in html_response.text
     assert 'href="/data/-/queries"' in html_response.text
-    assert len(json_response.json()["queries"]) == 20
+    assert len(json_response.json()["queries"]) == 5
     assert json_response.json()["queries_more"] is True
 
 

From 6eee6c81e8c21737e2391af55baf24866429038d Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 10:24:42 -0700
Subject: [PATCH 061/386] Add global query browser

Refs #2735
---
 datasette/app.py                    | 57 +++++++++++++++++++-----
 datasette/templates/query_list.html | 11 +++--
 datasette/views/database.py         | 27 ++++++++++--
 docs/json_api.rst                   |  3 +-
 queries-plan.md                     |  6 +--
 tests/test_queries.py               | 67 +++++++++++++++++++++++++++++
 6 files changed, 149 insertions(+), 22 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index bdbf9389..c047fde9 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -52,6 +52,7 @@ from .views.database import (
     QueryCreateView,
     QueryDeleteView,
     QueryDefinitionView,
+    GlobalQueryListView,
     QueryInsertView,
     QueryListView,
     QueryUpdateView,
@@ -1290,7 +1291,7 @@ class Datasette:
 
     async def list_queries(
         self,
-        database,
+        database=None,
         *,
         actor=None,
         limit=50,
@@ -1310,16 +1311,40 @@ class Datasette:
             include_is_private=include_private,
         )
         params = dict(allowed_params)
-        params.update({"query_database": database, "limit": limit + 1})
+        params.update({"limit": limit + 1})
         sort_key_sql = "lower(coalesce(nullif(q.title, ''), q.name))"
-        where_clauses = ["q.database_name = :query_database"]
+        where_clauses = []
+        order_by = "q.database_name, sort_key, q.name"
+        if database is not None:
+            params["query_database"] = database
+            where_clauses.append("q.database_name = :query_database")
+            order_by = "sort_key, q.name"
 
         if cursor:
             try:
                 components = urlsafe_components(cursor)
             except ValueError:
                 components = []
-            if len(components) == 2:
+            if database is None and len(components) == 3:
+                where_clauses.append("""
+                    (
+                        q.database_name > :cursor_database
+                        OR (
+                            q.database_name = :cursor_database
+                            AND (
+                                {sort_key_sql} > :cursor_sort_key
+                                OR (
+                                    {sort_key_sql} = :cursor_sort_key
+                                    AND q.name > :cursor_name
+                                )
+                            )
+                        )
+                    )
+                    """.format(sort_key_sql=sort_key_sql))
+                params["cursor_database"] = components[0]
+                params["cursor_sort_key"] = components[1]
+                params["cursor_name"] = components[2]
+            elif database is not None and len(components) == 2:
                 where_clauses.append("""
                     (
                         {sort_key_sql} > :cursor_sort_key
@@ -1368,13 +1393,14 @@ class Datasette:
                       ON allowed.parent = q.database_name
                      AND allowed.child = q.name
                     WHERE {where}
-                    ORDER BY sort_key, q.name
+                    ORDER BY {order_by}
                     LIMIT :limit
                     """.format(
                         allowed_sql=allowed_sql,
                         private_select=private_select,
                         sort_key_sql=sort_key_sql,
-                        where=" AND ".join(where_clauses),
+                        where=" AND ".join(where_clauses) or "1 = 1",
+                        order_by=order_by,
                     ),
                     params,
                 )
@@ -1394,10 +1420,17 @@ class Datasette:
         next_token = None
         if has_more and rows:
             last_row = rows[-1]
-            next_token = "{},{}".format(
-                tilde_encode(last_row["sort_key"]),
-                tilde_encode(last_row["name"]),
-            )
+            if database is None:
+                next_token = "{},{},{}".format(
+                    tilde_encode(last_row["database_name"]),
+                    tilde_encode(last_row["sort_key"]),
+                    tilde_encode(last_row["name"]),
+                )
+            else:
+                next_token = "{},{}".format(
+                    tilde_encode(last_row["sort_key"]),
+                    tilde_encode(last_row["name"]),
+                )
         return {
             "queries": queries,
             "next": next_token,
@@ -2651,6 +2684,10 @@ class Datasette:
             JumpView.as_view(self),
             r"/-/jump(\.(?P<format>json))?$",
         )
+        add_route(
+            GlobalQueryListView.as_view(self),
+            r"/-/queries(\.(?P<format>json))?$",
+        )
         add_route(
             InstanceSchemaView.as_view(self),
             r"/-/schema(\.(?P<format>json|md))?$",
diff --git a/datasette/templates/query_list.html b/datasette/templates/query_list.html
index ef5da0d5..af974550 100644
--- a/datasette/templates/query_list.html
+++ b/datasette/templates/query_list.html
@@ -1,8 +1,8 @@
 {% extends "base.html" %}
 
-{% block title %}{{ database }}: queries{% endblock %}
+{% block title %}{% if database %}{{ database }}: {% endif %}queries{% endblock %}
 
-{% block body_class %}query-list db-{{ database|to_css_class }}{% endblock %}
+{% block body_class %}query-list{% if database %} db-{{ database|to_css_class }}{% endif %}{% endblock %}
 
 {% block crumbs %}
 {{ crumbs.nav(request=request, database=database) }}
@@ -12,7 +12,7 @@
 
 <h1>Queries</h1>
 
-<form action="{{ urls.database(database) }}/-/queries" method="get">
+<form action="{{ query_list_path }}" method="get">
     <p>
         <label for="query-search">Search</label>
         <input id="query-search" type="search" name="q" value="{{ filters.q }}">
@@ -38,7 +38,10 @@
     <ul class="bullets">
         {% for query in queries %}
             <li>
-                <a href="{{ urls.query(database, query.name) }}{% if query.fragment %}#{{ query.fragment }}{% endif %}" title="{{ query.description or query.sql }}">{{ query.title or query.name }}</a>{% if query.private %} 🔒{% endif %}
+                {% if show_database %}
+                    <a href="{{ urls.database(query.database) }}">{{ query.database }}</a>:
+                {% endif %}
+                <a href="{{ urls.query(query.database, query.name) }}{% if query.fragment %}#{{ query.fragment }}{% endif %}" title="{{ query.description or query.sql }}">{{ query.title or query.name }}</a>{% if query.private %} 🔒{% endif %}
                 {% if query.is_write %}<span>Writable</span>{% endif %}
                 {% if query.is_published %}<span>Published</span>{% endif %}
             </li>
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 353cfcf2..1576b6a9 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -967,8 +967,14 @@ class ExecuteWriteView(BaseView):
 class QueryListView(BaseView):
     name = "query-list"
 
+    async def database_name(self, request):
+        return (await self.ds.resolve_database(request)).name
+
+    def query_list_path(self, database):
+        return self.ds.urls.database(database) + "/-/queries"
+
     async def get(self, request):
-        db = await self.ds.resolve_database(request)
+        database = await self.database_name(request)
         format_ = request.url_vars.get("format") or "html"
         try:
             limit = _query_list_limit(request.args.get("_size"))
@@ -980,7 +986,7 @@ class QueryListView(BaseView):
             return _error([ex.message], ex.status)
 
         page = await self.ds.list_queries(
-            db.name,
+            database,
             actor=request.actor,
             limit=limit,
             cursor=request.args.get("_next"),
@@ -991,6 +997,7 @@ class QueryListView(BaseView):
             owner_id=request.args.get("owner_id") or None,
             include_private=True,
         )
+        query_list_path = self.query_list_path(database)
         next_url = None
         if page["next"]:
             pairs = [
@@ -1002,18 +1009,20 @@ class QueryListView(BaseView):
             ]
             pairs.append(("_next", page["next"]))
             next_url = "{}?{}".format(
-                self.ds.urls.database(db.name) + "/-/queries",
+                query_list_path,
                 urlencode(pairs),
             )
 
         data = {
             "ok": True,
-            "database": db.name,
+            "database": database,
             "queries": page["queries"],
             "next": page["next"],
             "next_url": next_url,
             "has_more": page["has_more"],
             "limit": page["limit"],
+            "query_list_path": query_list_path,
+            "show_database": database is None,
             "filters": {
                 "q": request.args.get("q") or "",
                 "is_write": request.args.get("is_write") or "",
@@ -1031,6 +1040,16 @@ class QueryListView(BaseView):
         )
 
 
+class GlobalQueryListView(QueryListView):
+    name = "global-query-list"
+
+    async def database_name(self, request):
+        return None
+
+    def query_list_path(self, database):
+        return self.ds.urls.path("/-/queries")
+
+
 class QueryCreateView(BaseView):
     name = "query-create"
     has_json_alternate = False
diff --git a/docs/json_api.rst b/docs/json_api.rst
index ece430c2..f44a39fe 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -505,12 +505,13 @@ The JSON write API
 
 Datasette provides a write API for JSON data. This is a POST-only API that requires an authenticated API token, see :ref:`CreateTokenView`. The token will need to have the specified :ref:`authentication_permissions`.
 
+.. _GlobalQueryListView:
 .. _QueryListView:
 
 Listing saved queries
 ~~~~~~~~~~~~~~~~~~~~~
 
-``GET /<database>/-/queries.json`` returns saved query definitions the actor can view. Use ``?_size=50`` to set the page size and ``?_next=...`` with the cursor returned by the previous page to fetch the next page.
+``GET /-/queries.json`` returns saved query definitions across every database that the actor can view. ``GET /<database>/-/queries.json`` returns saved query definitions for a specific database. Use ``?_size=50`` to set the page size and ``?_next=...`` with the cursor returned by the previous page to fetch the next page.
 
 .. _QueryCreateView:
 
diff --git a/queries-plan.md b/queries-plan.md
index 82ef3260..a708e887 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -210,7 +210,7 @@ JSON endpoints should follow Datasette's existing write API style: use `POST` pl
 
 Endpoints:
 
-- `GET /{database}/-/queries` shows a searchable HTML query browser. `GET /{database}/-/queries.json` returns query definitions the actor can view, using cursor pagination with `_next` and `_size`.
+- `GET /-/queries` and `GET /{database}/-/queries` show searchable HTML query browsers. `GET /-/queries.json` lists query definitions across every database the actor can view; `GET /{database}/-/queries.json` scopes that list to one database. Both JSON endpoints use cursor pagination with `_next` and `_size`.
 - `POST /{database}/-/queries/-/insert` creates a query.
 - `GET /{database}/{query}/-/definition` returns one query definition without executing it.
 - `POST /{database}/{query}/-/update` updates one query.
@@ -366,7 +366,7 @@ await datasette.list_queries(
 )
 ```
 
-`list_queries()` should return a bounded page shaped like `{"queries": [...], "next": "...", "has_more": true, "limit": 50}`. The `next` value is an opaque cursor token, not an offset.
+`list_queries()` should return a bounded page shaped like `{"queries": [...], "next": "...", "has_more": true, "limit": 50}`. The `next` value is an opaque cursor token, not an offset. Passing `database=None` lists visible queries across all live databases, still filtered through `view-query` permission SQL.
 
 `update_query()` should use an internal sentinel default such as `UNCHANGED = object()` so callers can distinguish "leave this column alone" from "set this column to `NULL`":
 
@@ -392,7 +392,7 @@ The save form should call `POST /{database}/-/queries/-/insert` and default to `
 
 If the actor also has `publish-query`, include a publish control. The UI copy should make it clear that publishing allows people without arbitrary SQL permission to run this query.
 
-On `/{database}`, show a preview of the first 5 visible queries using `list_queries(..., limit=5)`. If the page has `has_more`, show a link to `/{database}/-/queries` rather than rendering hundreds or thousands of query links inline. The full `/{database}/-/queries` page provides search, filters, and cursor pagination.
+On `/{database}`, show a preview of the first 5 visible queries using `list_queries(..., limit=5)`. If the page has `has_more`, show a link to `/{database}/-/queries` rather than rendering hundreds or thousands of query links inline. The full `/{database}/-/queries` page provides search, filters, and cursor pagination. The global `/-/queries` page reuses the same interface and shows the database for each query.
 
 ## Dedicated create query UI
 
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 2b46e00f..bc04bb51 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -457,6 +457,73 @@ async def test_query_list_search_filter_and_html():
     ]
 
 
+@pytest.mark.asyncio
+async def test_global_query_list_api_and_html():
+    ds = Datasette(memory=True)
+    ds.root_enabled = True
+    ds.add_memory_database("query_list_global_alpha", name="alpha")
+    ds.add_memory_database("query_list_global_beta", name="beta")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "alpha",
+        "alpha_first",
+        "select 1",
+        title="Alpha first",
+        is_published=True,
+        source="user",
+        owner_id="root",
+    )
+    await ds.add_query(
+        "alpha",
+        "alpha_second",
+        "select 2",
+        title="Alpha second",
+        is_published=True,
+        source="user",
+        owner_id="root",
+    )
+    await ds.add_query(
+        "beta",
+        "beta_first",
+        "select 3",
+        title="Beta first",
+        is_published=True,
+        source="user",
+        owner_id="root",
+    )
+
+    list_response = await ds.client.get(
+        "/-/queries.json?_size=2",
+        actor={"id": "root"},
+    )
+    next_response = await ds.client.get(
+        "/-/queries.json?_size=2&_next={}".format(list_response.json()["next"]),
+        actor={"id": "root"},
+    )
+    html_response = await ds.client.get(
+        "/-/queries?q=Beta",
+        actor={"id": "root"},
+    )
+
+    assert list_response.status_code == 200
+    assert [
+        (query["database"], query["name"]) for query in list_response.json()["queries"]
+    ] == [
+        ("alpha", "alpha_first"),
+        ("alpha", "alpha_second"),
+    ]
+    assert list_response.json()["next"]
+    assert [
+        (query["database"], query["name"]) for query in next_response.json()["queries"]
+    ] == [
+        ("beta", "beta_first"),
+    ]
+    assert html_response.status_code == 200
+    assert 'href="/beta">beta</a>:' in html_response.text
+    assert "Beta first" in html_response.text
+    assert "Alpha first" not in html_response.text
+
+
 @pytest.mark.asyncio
 async def test_query_insert_api_publish_requires_publish_query():
     ds = Datasette(

From f0b59971f7c8c0f4435a18b4f4e9c8053c2683fe Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 10:39:56 -0700
Subject: [PATCH 062/386] Delete unnecessary test

---
 tests/test_utils_sql_analysis.py | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tests/test_utils_sql_analysis.py b/tests/test_utils_sql_analysis.py
index c82fb04f..5730cd0d 100644
--- a/tests/test_utils_sql_analysis.py
+++ b/tests/test_utils_sql_analysis.py
@@ -169,13 +169,6 @@ def test_analyze_attached_database_tables(conn):
     }
 
 
-def test_analyze_invalid_sql_cleans_up_authorizer(conn):
-    with pytest.raises(sqlite3.OperationalError):
-        analyze_sql_tables(conn, "insert into missing_table values (1)")
-
-    conn.execute("select name from dogs").fetchall()
-
-
 def test_analyze_clears_authorizer_on_error():
     class FakeConnection:
         def __init__(self):

From 2b5b4ed66b86bae0080e9d8f4881cad8e57bbdb3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 11:11:08 -0700
Subject: [PATCH 063/386] Much improved "Write to this database" UI

- Start with a template option, letting you pick table and operation
- SQL textarea defaults to 4 empty lines at start
- Query operations table is simpler and looks nicer

Refs #2742
---
 datasette/templates/execute_write.html | 240 +++++++++++++++++++++++--
 datasette/views/database.py            |  13 +-
 tests/test_queries.py                  |  32 +++-
 3 files changed, 271 insertions(+), 14 deletions(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 5b4f30d9..90845910 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -1,10 +1,80 @@
 {% extends "base.html" %}
 
-{% block title %}Execute write SQL{% endblock %}
+{% block title %}Write to this database{% endblock %}
 
 {% block extra_head %}
 {{- super() -}}
 {% include "_codemirror.html" %}
+<style>
+.execute-write-template-menu {
+    margin: 0.9rem 0 0.8rem;
+}
+.execute-write-template-menu summary {
+    cursor: pointer;
+    font-weight: 600;
+    margin-bottom: 0.35rem;
+}
+.execute-write-template-controls {
+    align-items: center;
+    display: flex;
+    flex-wrap: wrap;
+    gap: 0.4rem;
+    margin: 0.4rem 0 0.7rem;
+}
+.execute-write-template-menu .execute-write-template-controls label {
+    margin-right: 0.25rem;
+    width: auto;
+}
+.execute-write-template-controls select,
+.execute-write-template-controls button[type=button] {
+    box-sizing: border-box;
+    font-size: 0.78rem;
+    height: 2rem;
+    line-height: 1.1;
+    padding: 0.35rem 0.55rem;
+}
+.execute-write-template-controls select {
+    background-color: #fff;
+    border: 1px solid #777;
+    border-radius: 0.25rem;
+    min-width: 13rem;
+}
+.execute-write-analysis {
+    border-collapse: collapse;
+    font-size: 0.9rem;
+    margin: 0.25rem 0 1rem;
+    min-width: 44rem;
+}
+.execute-write-analysis th,
+.execute-write-analysis td {
+    border-bottom: 1px solid #d7dde5;
+    padding: 0.45rem 0.7rem;
+    text-align: left;
+    vertical-align: top;
+}
+.execute-write-analysis th {
+    background-color: #edf6fb;
+    border-top: 1px solid #d7dde5;
+    color: #39445a;
+    font-weight: 700;
+}
+.execute-write-analysis tbody tr:nth-child(even) {
+    background-color: rgba(39, 104, 144, 0.05);
+}
+.execute-write-analysis code {
+    background: transparent;
+    font-size: 0.9em;
+    white-space: nowrap;
+}
+.execute-write-analysis-allowed {
+    color: #267a3e;
+    font-weight: 700;
+}
+.execute-write-analysis-denied {
+    color: #b00020;
+    font-weight: 700;
+}
+</style>
 {% endblock %}
 
 {% block body_class %}execute-write db-{{ database|to_css_class }}{% endblock %}
@@ -15,13 +85,34 @@
 
 {% block content %}
 
-<h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Execute write SQL</h1>
+<h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Write to this database</h1>
+
+<p>Execute SQL to insert, update or delete rows in this database.</p>
 
 {% if execution_message %}
     <p class="{% if execution_ok %}message-info{% else %}message-error{% endif %}">{{ execution_message }}</p>
 {% endif %}
 
 <form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post">
+    {% if write_template_tables %}
+        <div class="execute-write-template-menu">
+            <details>
+                <summary>Start with a template</summary>
+                <p class="execute-write-template-controls">
+                    <label for="execute-write-template-table">Table</label>
+                    <select id="execute-write-template-table">
+                        {% for table_name, columns in write_template_tables|dictsort %}
+                            <option value="{{ table_name }}">{{ table_name }}</option>
+                        {% endfor %}
+                    </select>
+                    <button type="button" data-sql-template="insert">Insert row</button>
+                    <button type="button" data-sql-template="update">Update rows</button>
+                    <button type="button" data-sql-template="delete">Delete rows</button>
+                </p>
+            </details>
+        </div>
+    {% endif %}
+
     <p><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
 
     {% if parameter_names %}
@@ -31,30 +122,28 @@
         {% endfor %}
     {% endif %}
 
-    <h2>Analysis</h2>
+    <h2>Query operations</h2>
     {% if analysis_error %}
         <p class="message-error">{{ analysis_error }}</p>
     {% elif analysis_rows %}
-        <div class="table-wrapper"><table>
+        <div class="table-wrapper"><table class="execute-write-analysis">
             <thead>
                 <tr>
                     <th scope="col">Operation</th>
                     <th scope="col">Database</th>
                     <th scope="col">Table</th>
-                    <th scope="col">required permission</th>
+                    <th scope="col">Required permission</th>
                     <th scope="col">Allowed</th>
-                    <th scope="col">Source</th>
                 </tr>
             </thead>
             <tbody>
                 {% for row in analysis_rows %}
                     <tr>
-                        <td>{{ row.operation }}</td>
-                        <td>{{ row.database }}</td>
-                        <td>{{ row.table }}</td>
-                        <td>{{ row.required_permission }}</td>
-                        <td>{% if row.allowed is none %}{% elif row.allowed %}yes{% else %}no{% endif %}</td>
-                        <td>{{ row.source or "" }}</td>
+                        <td><code>{{ row.operation }}</code></td>
+                        <td><code>{{ row.database }}</code></td>
+                        <td><code>{{ row.table }}</code></td>
+                        <td>{% if row.required_permission %}<code>{{ row.required_permission }}</code>{% endif %}</td>
+                        <td>{% if row.allowed is none %}{% elif row.allowed %}<span class="execute-write-analysis-allowed">yes</span>{% else %}<span class="execute-write-analysis-denied">no</span>{% endif %}</td>
                     </tr>
                 {% endfor %}
             </tbody>
@@ -66,6 +155,133 @@
     <p><input type="submit" value="Execute"{% if execute_disabled %} disabled{% endif %}></p>
 </form>
 
+<script>
+const executeWriteSqlInput = document.querySelector("textarea#sql-editor");
+if (executeWriteSqlInput && !executeWriteSqlInput.value) {
+  executeWriteSqlInput.value = "\n\n\n";
+}
+</script>
+
 {% include "_codemirror_foot.html" %}
 
+{% if write_template_tables %}
+<script>
+window.addEventListener("DOMContentLoaded", () => {
+  const tableColumns = {{ write_template_tables|tojson(2) }};
+  const tableSelect = document.querySelector("#execute-write-template-table");
+  const templateButtons = document.querySelectorAll("[data-sql-template]");
+
+  function quoteIdentifier(identifier) {
+    return `"${identifier.replace(/"/g, '""')}"`;
+  }
+
+  function parameterNames(columns) {
+    const seen = new Set();
+    const names = {};
+    columns.forEach((column) => {
+      let base = column
+        .toLowerCase()
+        .replace(/[^a-z0-9_]+/g, "_")
+        .replace(/^_+|_+$/g, "");
+      if (!base) {
+        base = "value";
+      }
+      if (/^[0-9]/.test(base)) {
+        base = `p_${base}`;
+      }
+      let name = base;
+      let index = 2;
+      while (seen.has(name)) {
+        name = `${base}_${index}`;
+        index += 1;
+      }
+      seen.add(name);
+      names[column] = name;
+    });
+    return names;
+  }
+
+  function preferredWhereColumn(table, columns) {
+    const lowerTableId = `${table.toLowerCase()}_id`;
+    return (
+      columns.find((column) => column.toLowerCase() === "id") ||
+      columns.find((column) => column.toLowerCase() === lowerTableId) ||
+      columns[0]
+    );
+  }
+
+  function insertSql(table, columns) {
+    const names = parameterNames(columns);
+    return [
+      `insert into ${quoteIdentifier(table)} (`,
+      columns.map((column) => `  ${quoteIdentifier(column)}`).join(",\n"),
+      ")",
+      "values (",
+      columns.map((column) => `  :${names[column]}`).join(",\n"),
+      ")",
+    ].join("\n");
+  }
+
+  function updateSql(table, columns) {
+    const names = parameterNames(columns);
+    const whereColumn = preferredWhereColumn(table, columns);
+    const setColumns = columns.filter((column) => column !== whereColumn);
+    if (!setColumns.length) {
+      return [
+        `update ${quoteIdentifier(table)}`,
+        `set ${quoteIdentifier(whereColumn)} = :new_${names[whereColumn]}`,
+        `where ${quoteIdentifier(whereColumn)} = :${names[whereColumn]}`,
+      ].join("\n");
+    }
+    return [
+      `update ${quoteIdentifier(table)}`,
+      "set " +
+        setColumns
+          .map((column, index) => {
+            const indent = index ? "    " : "";
+            return `${indent}${quoteIdentifier(column)} = :${names[column]}`;
+          })
+          .join(",\n"),
+      `where ${quoteIdentifier(whereColumn)} = :${names[whereColumn]}`,
+    ].join("\n");
+  }
+
+  function deleteSql(table, columns) {
+    const names = parameterNames(columns);
+    const whereColumn = preferredWhereColumn(table, columns);
+    return [
+      `delete from ${quoteIdentifier(table)}`,
+      `where ${quoteIdentifier(whereColumn)} = :${names[whereColumn]}`,
+    ].join("\n");
+  }
+
+  function templateSql(operation, table, columns) {
+    if (operation === "insert") {
+      return insertSql(table, columns);
+    }
+    if (operation === "update") {
+      return updateSql(table, columns);
+    }
+    return deleteSql(table, columns);
+  }
+
+  templateButtons.forEach((button) => {
+    button.addEventListener("click", () => {
+      const table = tableSelect.value;
+      const columns = tableColumns[table] || [];
+      if (!columns.length) {
+        return;
+      }
+      const url = new URL(window.location.href);
+      url.searchParams.set(
+        "sql",
+        templateSql(button.dataset.sqlTemplate, table, columns)
+      );
+      window.location.href = url.toString();
+    });
+  });
+});
+</script>
+{% endif %}
+
 {% endblock %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 1576b6a9..fb3bdfdb 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -830,6 +830,13 @@ class ExecuteWriteView(BaseView):
         parameter_values = parameter_values or {}
         parameter_names = []
         analysis_rows = []
+        table_columns = await _table_columns(self.ds, db.name)
+        hidden_table_names = set(await db.hidden_table_names())
+        write_template_tables = {
+            table: columns
+            for table, columns in table_columns.items()
+            if columns and table not in hidden_table_names
+        }
         if sql and analysis_error is None:
             try:
                 parameter_names = _derived_query_parameters(sql)
@@ -858,7 +865,9 @@ class ExecuteWriteView(BaseView):
                 "parameter_names": parameter_names,
                 "parameter_values": parameter_values,
                 "analysis_error": analysis_error,
-                "analysis_rows": analysis_rows,
+                "analysis_rows": [
+                    row for row in analysis_rows if row["operation"] != "read"
+                ],
                 "execution_message": execution_message,
                 "execution_ok": execution_ok,
                 "execute_disabled": bool(
@@ -866,6 +875,8 @@ class ExecuteWriteView(BaseView):
                     or analysis_error
                     or any(row["allowed"] is False for row in analysis_rows)
                 ),
+                "table_columns": table_columns,
+                "write_template_tables": write_template_tables,
             },
         )
         response.status = status
diff --git a/tests/test_queries.py b/tests/test_queries.py
index bc04bb51..684454fc 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -690,6 +690,14 @@ async def test_execute_write_get_prepopulates_without_executing():
     ds.root_enabled = True
     db = ds.add_memory_database("execute_write_get", name="data")
     await db.execute_write("create table dogs (id integer primary key, name text)")
+    await db.execute_write("create table cats (id integer primary key, name text)")
+    await db.execute_write("create table log (message text)")
+    await db.execute_write("""
+        create trigger dogs_after_insert after insert on dogs begin
+            update cats set name = new.name where id = new.id;
+            insert into log (message) values (new.name);
+        end
+    """)
     await ds.invoke_startup()
 
     response = await ds.client.get(
@@ -700,11 +708,33 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert response.status_code == 200
     assert response.headers["content-security-policy"] == "frame-ancestors 'none'"
     assert response.headers["x-frame-options"] == "DENY"
-    assert "Execute write SQL" in response.text
+    assert "Write to this database" in response.text
+    assert (
+        "Execute SQL to insert, update or delete rows in this database."
+        in response.text
+    )
+    assert "<h2>Query operations</h2>" in response.text
+    assert "<summary>Start with a template</summary>" in response.text
+    assert '<option value="dogs">dogs</option>' in response.text
+    assert 'data-sql-template="insert"' in response.text
+    assert 'data-sql-template="update"' in response.text
+    assert 'data-sql-template="delete"' in response.text
+    assert '<table class="execute-write-analysis">' in response.text
+    assert '<th scope="col">Required permission</th>' in response.text
+    assert "<td><code>insert</code></td>" in response.text
+    assert "<td><code>update</code></td>" in response.text
+    assert "<td><code>read</code></td>" not in response.text
     assert 'action="/data/-/execute-write"' in response.text
     assert "insert into dogs (name) values (&#39;Cleo&#39;)" in response.text
     assert (await db.execute("select count(*) from dogs")).first()[0] == 0
 
+    empty_response = await ds.client.get(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+    )
+    assert '<textarea id="sql-editor" name="sql"></textarea>' in empty_response.text
+    assert 'executeWriteSqlInput.value = "\\n\\n\\n";' in empty_response.text
+
 
 @pytest.mark.asyncio
 async def test_database_action_menu_links_to_execute_write_for_permitted_actor():

From 1bce34a33869709e1dea21b6182327a105895285 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 11:22:24 -0700
Subject: [PATCH 064/386] If just a single insert, link to row page

Refs #2742
---
 datasette/templates/execute_write.html |  2 +-
 datasette/views/database.py            | 49 ++++++++++++++++++++++++++
 tests/test_queries.py                  | 42 ++++++++++++++++++++++
 3 files changed, 92 insertions(+), 1 deletion(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 90845910..705181d8 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -90,7 +90,7 @@
 <p>Execute SQL to insert, update or delete rows in this database.</p>
 
 {% if execution_message %}
-    <p class="{% if execution_ok %}message-info{% else %}message-error{% endif %}">{{ execution_message }}</p>
+    <p class="{% if execution_ok %}message-info{% else %}message-error{% endif %}">{{ execution_message }}{% for link in execution_links %} <a href="{{ link.href }}">{{ link.label }}</a>{% endfor %}</p>
 {% endif %}
 
 <form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post">
diff --git a/datasette/views/database.py b/datasette/views/database.py
index fb3bdfdb..2b3920f7 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -18,8 +18,10 @@ from datasette.utils import (
     await_me_maybe,
     call_with_supported_arguments,
     named_parameters as derive_named_parameters,
+    escape_sqlite,
     format_bytes,
     make_slot_function,
+    path_from_row_pks,
     tilde_decode,
     to_css_class,
     validate_sql_select,
@@ -678,6 +680,43 @@ async def _prepare_execute_write(datasette, db, sql, params, actor):
     return parameter_names, params, analysis
 
 
+async def _inserted_row_url(datasette, db, analysis, cursor):
+    if cursor.rowcount != 1:
+        return None
+    lastrowid = getattr(cursor, "lastrowid", None)
+    if lastrowid is None:
+        return None
+    direct_inserts = [
+        access
+        for access in analysis.table_accesses
+        if access.operation == "insert"
+        and access.source is None
+        and access.database == db.name
+    ]
+    if len(direct_inserts) != 1:
+        return None
+    table = direct_inserts[0].table
+    pks = await db.primary_keys(table)
+    use_rowid = not pks
+    select = (
+        "rowid"
+        if use_rowid
+        else ", ".join(escape_sqlite(primary_key) for primary_key in pks)
+    )
+    try:
+        result = await db.execute(
+            "select {} from {} where rowid = ?".format(select, escape_sqlite(table)),
+            [lastrowid],
+        )
+    except sqlite3.DatabaseError:
+        return None
+    row = result.first()
+    if row is None:
+        return None
+    row_path = path_from_row_pks(row, pks, use_rowid)
+    return datasette.urls.row(db.name, table, row_path)
+
+
 def _apply_query_data_types(data):
     typed = dict(data)
     for key in ("hide_sql", "is_published"):
@@ -824,10 +863,12 @@ class ExecuteWriteView(BaseView):
         analysis=None,
         analysis_error=None,
         execution_message=None,
+        execution_links=None,
         execution_ok=None,
         status=200,
     ):
         parameter_values = parameter_values or {}
+        execution_links = execution_links or []
         parameter_names = []
         analysis_rows = []
         table_columns = await _table_columns(self.ds, db.name)
@@ -869,6 +910,7 @@ class ExecuteWriteView(BaseView):
                     row for row in analysis_rows if row["operation"] != "read"
                 ],
                 "execution_message": execution_message,
+                "execution_links": execution_links,
                 "execution_ok": execution_ok,
                 "execute_disabled": bool(
                     (not sql)
@@ -964,6 +1006,12 @@ class ExecuteWriteView(BaseView):
                 )
             )
 
+        inserted_row_url = await _inserted_row_url(self.ds, db, analysis, cursor)
+        execution_links = (
+            [{"href": inserted_row_url, "label": "View row"}]
+            if inserted_row_url
+            else []
+        )
         return await self._render_form(
             request,
             db,
@@ -971,6 +1019,7 @@ class ExecuteWriteView(BaseView):
             parameter_values={name: params.get(name, "") for name in parameter_names},
             analysis=analysis,
             execution_message=message,
+            execution_links=execution_links,
             execution_ok=True,
         )
 
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 684454fc..ed981ee7 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -849,6 +849,48 @@ async def test_execute_write_post_requires_database_and_table_permissions():
     assert (await db.execute("select name from dogs")).first()[0] == "Cleo"
 
 
+@pytest.mark.asyncio
+async def test_execute_write_insert_links_to_inserted_row():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_insert_link", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await db.execute_write("create table log (id integer primary key, message text)")
+    await db.execute_write("insert into log (message) values ('existing')")
+    await db.execute_write("""
+        create trigger dogs_after_insert after insert on dogs begin
+            insert into log (message) values (new.name);
+        end
+    """)
+    await ds.invoke_startup()
+
+    insert_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        data={
+            "sql": "insert into dogs (name) values (:name)",
+            "name": "Cleo",
+        },
+    )
+    update_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        data={
+            "sql": "update dogs set name = :name where id = :id",
+            "name": "Cleo 2",
+            "id": "1",
+        },
+    )
+
+    assert insert_response.status_code == 200
+    assert "Query executed, 1 row affected" in insert_response.text
+    assert '<a href="/data/dogs/1">View row</a>' in insert_response.text
+    assert "/data/log/2" not in insert_response.text
+    assert update_response.status_code == 200
+    assert "Query executed, 1 row affected" in update_response.text
+    assert "View row" not in update_response.text
+
+
 @pytest.mark.asyncio
 async def test_execute_write_post_rejects_read_only_sql():
     ds = Datasette(memory=True, default_deny=True)

From 66bbbbc947bd4d7305761a627dc2f1949949c0a5 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 11:35:09 -0700
Subject: [PATCH 065/386] Support multi-line parameters on /db/-/execute-write

Refs https://github.com/simonw/datasette/issues/2742#issuecomment-4536317049

Each paramater input now has an expand/collapse button toggle to turn into a textarea.

If you paste text that includes at least one newline it toggles automatically.
---
 datasette/templates/execute_write.html | 94 +++++++++++++++++++++++++-
 tests/test_queries.py                  |  1 +
 2 files changed, 94 insertions(+), 1 deletion(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 705181d8..a560e920 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -74,6 +74,25 @@
     color: #b00020;
     font-weight: 700;
 }
+form.sql .execute-write-parameter-row textarea[data-parameter-control] {
+    border: 1px solid #ccc;
+    border-radius: 3px;
+    box-sizing: content-box;
+    display: inline-block;
+    font-family: Helvetica, sans-serif;
+    font-size: 1em;
+    min-height: 7rem;
+    padding: 9px 4px;
+    vertical-align: top;
+    width: 60%;
+}
+form.sql.core button.execute-write-parameter-toggle[type=button] {
+    font-size: 0.72rem;
+    height: 1.8rem;
+    line-height: 1;
+    margin-left: 0.35rem;
+    padding: 0.25rem 0.45rem;
+}
 </style>
 {% endblock %}
 
@@ -118,7 +137,7 @@
     {% if parameter_names %}
         <h2>Parameters</h2>
         {% for parameter in parameter_names %}
-            <p><label for="qp{{ loop.index }}">{{ parameter }}</label> <input type="text" id="qp{{ loop.index }}" name="{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}"></p>
+            <p class="execute-write-parameter-row"><label for="qp{{ loop.index }}">{{ parameter }}</label> <input type="text" id="qp{{ loop.index }}" name="{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}" data-parameter-control> <button type="button" class="execute-write-parameter-toggle" data-parameter-toggle aria-controls="qp{{ loop.index }}" aria-expanded="false">Expand</button></p>
         {% endfor %}
     {% endif %}
 
@@ -164,6 +183,79 @@ if (executeWriteSqlInput && !executeWriteSqlInput.value) {
 
 {% include "_codemirror_foot.html" %}
 
+<script>
+window.addEventListener("DOMContentLoaded", () => {
+  function replaceParameterControl(control, button, expand, value, selectionStart) {
+    const replacement = document.createElement(expand ? "textarea" : "input");
+    replacement.id = control.id;
+    replacement.name = control.name;
+    replacement.value = value === undefined ? control.value : value;
+    replacement.setAttribute("data-parameter-control", "");
+    if (expand) {
+      replacement.rows = 5;
+      button.textContent = "Collapse";
+      button.setAttribute("aria-expanded", "true");
+    } else {
+      replacement.type = "text";
+      button.textContent = "Expand";
+      button.setAttribute("aria-expanded", "false");
+    }
+    control.replaceWith(replacement);
+    replacement.focus();
+    if (selectionStart !== undefined && replacement.setSelectionRange) {
+      replacement.setSelectionRange(selectionStart, selectionStart);
+    }
+  }
+
+  document.querySelectorAll("[data-parameter-toggle]").forEach((button) => {
+    button.addEventListener("click", () => {
+      const control = document.getElementById(button.getAttribute("aria-controls"));
+      if (!control) {
+        return;
+      }
+      const expanded = control.tagName.toLowerCase() === "textarea";
+      replaceParameterControl(control, button, !expanded);
+    });
+  });
+
+  document
+    .querySelector("form.sql.core")
+    .addEventListener("paste", (event) => {
+      const control = event.target;
+      if (
+        !(control instanceof HTMLInputElement) ||
+        !control.matches("[data-parameter-control]")
+      ) {
+        return;
+      }
+      const pasted = event.clipboardData ? event.clipboardData.getData("text") : "";
+      if (!/[\r\n]/.test(pasted)) {
+        return;
+      }
+      const button = document.querySelector(
+        `[data-parameter-toggle][aria-controls="${control.id}"]`
+      );
+      if (!button) {
+        return;
+      }
+      event.preventDefault();
+      const selectionStart = control.selectionStart ?? control.value.length;
+      const selectionEnd = control.selectionEnd ?? selectionStart;
+      const value =
+        control.value.slice(0, selectionStart) +
+        pasted +
+        control.value.slice(selectionEnd);
+      replaceParameterControl(
+        control,
+        button,
+        true,
+        value,
+        selectionStart + pasted.length
+      );
+    });
+});
+</script>
+
 {% if write_template_tables %}
 <script>
 window.addEventListener("DOMContentLoaded", () => {
diff --git a/tests/test_queries.py b/tests/test_queries.py
index ed981ee7..a6080958 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -719,6 +719,7 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'data-sql-template="insert"' in response.text
     assert 'data-sql-template="update"' in response.text
     assert 'data-sql-template="delete"' in response.text
+    assert 'addEventListener("paste"' in response.text
     assert '<table class="execute-write-analysis">' in response.text
     assert '<th scope="col">Required permission</th>' in response.text
     assert "<td><code>insert</code></td>" in response.text

From abb17ba77384bff0ff6eaf782a9a62e381b50b95 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 11:42:26 -0700
Subject: [PATCH 066/386] Improved the look of the parameters table

Refs #2742

It now adapts better to different sizes of column labels.
---
 datasette/templates/execute_write.html | 48 ++++++++++++++++++++++----
 1 file changed, 42 insertions(+), 6 deletions(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index a560e920..6ffb844f 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -8,6 +8,7 @@
 <style>
 .execute-write-template-menu {
     margin: 0.9rem 0 0.8rem;
+    max-width: 52rem;
 }
 .execute-write-template-menu summary {
     cursor: pointer;
@@ -77,22 +78,57 @@
 form.sql .execute-write-parameter-row textarea[data-parameter-control] {
     border: 1px solid #ccc;
     border-radius: 3px;
-    box-sizing: content-box;
-    display: inline-block;
+    box-sizing: border-box;
+    display: block;
     font-family: Helvetica, sans-serif;
     font-size: 1em;
     min-height: 7rem;
     padding: 9px 4px;
-    vertical-align: top;
-    width: 60%;
+    width: 100%;
+}
+form.sql .execute-write-parameter-row {
+    align-items: start;
+    column-gap: 0.6rem;
+    display: grid;
+    grid-template-columns: minmax(8rem, 11rem) minmax(16rem, 1fr) auto;
+    margin: 0 0 0.65rem;
+    max-width: 52rem;
+}
+form.sql .execute-write-parameter-row label {
+    overflow-wrap: anywhere;
+    padding-top: 0.55rem;
+    width: auto;
+}
+form.sql .execute-write-parameter-row input[data-parameter-control] {
+    box-sizing: border-box;
+    width: 100%;
 }
 form.sql.core button.execute-write-parameter-toggle[type=button] {
     font-size: 0.72rem;
     height: 1.8rem;
     line-height: 1;
-    margin-left: 0.35rem;
+    margin: 0.25rem 0 0;
     padding: 0.25rem 0.45rem;
 }
+@media (max-width: 480px) {
+    form.sql .execute-write-parameter-row {
+        grid-template-columns: 1fr;
+        row-gap: 0.25rem;
+    }
+    form.sql .execute-write-parameter-row label {
+        padding-top: 0;
+    }
+    form.sql.core button.execute-write-parameter-toggle[type=button] {
+        justify-self: start;
+        margin-top: 0;
+    }
+}
+form.sql .execute-write-editor {
+    max-width: 52rem;
+}
+form.sql .execute-write-editor textarea#sql-editor {
+    width: 100%;
+}
 </style>
 {% endblock %}
 
@@ -132,7 +168,7 @@ form.sql.core button.execute-write-parameter-toggle[type=button] {
         </div>
     {% endif %}
 
-    <p><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
+    <p class="execute-write-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
 
     {% if parameter_names %}
         <h2>Parameters</h2>

From e1261442c09fcd92588b7df180d04c7d057d5fd5 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 12:08:22 -0700
Subject: [PATCH 067/386] Update parameters/query operations as user edits the
 write query

Refs #2742
---
 datasette/app.py                       |   5 +
 datasette/templates/execute_write.html | 428 ++++++++++++++++++++-----
 datasette/views/database.py            |  72 +++++
 docs/json_api.rst                      |   3 +
 tests/test_queries.py                  |  49 +++
 5 files changed, 480 insertions(+), 77 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index c047fde9..d6f8933f 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -46,6 +46,7 @@ from .views import Context
 from .views.database import (
     database_download,
     DatabaseView,
+    ExecuteWriteAnalyzeView,
     ExecuteWriteView,
     TableCreateView,
     QueryView,
@@ -2745,6 +2746,10 @@ class Datasette:
             QueryInsertView.as_view(self),
             r"/(?P<database>[^\/\.]+)/-/queries/-/insert$",
         )
+        add_route(
+            ExecuteWriteAnalyzeView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/execute-write/-/analyze$",
+        )
         add_route(
             ExecuteWriteView.as_view(self),
             r"/(?P<database>[^\/\.]+)/-/execute-write$",
diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 6ffb844f..5037d006 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -148,7 +148,7 @@ form.sql .execute-write-editor textarea#sql-editor {
     <p class="{% if execution_ok %}message-info{% else %}message-error{% endif %}">{{ execution_message }}{% for link in execution_links %} <a href="{{ link.href }}">{{ link.label }}</a>{% endfor %}</p>
 {% endif %}
 
-<form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post">
+<form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post" data-analyze-url="{{ urls.database(database) }}/-/execute-write/-/analyze">
     {% if write_template_tables %}
         <div class="execute-write-template-menu">
             <details>
@@ -170,44 +170,48 @@ form.sql .execute-write-editor textarea#sql-editor {
 
     <p class="execute-write-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
 
-    {% if parameter_names %}
-        <h2>Parameters</h2>
-        {% for parameter in parameter_names %}
-            <p class="execute-write-parameter-row"><label for="qp{{ loop.index }}">{{ parameter }}</label> <input type="text" id="qp{{ loop.index }}" name="{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}" data-parameter-control> <button type="button" class="execute-write-parameter-toggle" data-parameter-toggle aria-controls="qp{{ loop.index }}" aria-expanded="false">Expand</button></p>
-        {% endfor %}
-    {% endif %}
+    <div id="execute-write-parameters-section">
+        {% if parameter_names %}
+            <h2>Parameters</h2>
+            {% for parameter in parameter_names %}
+                <p class="execute-write-parameter-row"><label for="qp{{ loop.index }}">{{ parameter }}</label> <input type="text" id="qp{{ loop.index }}" name="{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}" data-parameter-control> <button type="button" class="execute-write-parameter-toggle" data-parameter-toggle aria-controls="qp{{ loop.index }}" aria-expanded="false">Expand</button></p>
+            {% endfor %}
+        {% endif %}
+    </div>
 
-    <h2>Query operations</h2>
-    {% if analysis_error %}
-        <p class="message-error">{{ analysis_error }}</p>
-    {% elif analysis_rows %}
-        <div class="table-wrapper"><table class="execute-write-analysis">
-            <thead>
-                <tr>
-                    <th scope="col">Operation</th>
-                    <th scope="col">Database</th>
-                    <th scope="col">Table</th>
-                    <th scope="col">Required permission</th>
-                    <th scope="col">Allowed</th>
-                </tr>
-            </thead>
-            <tbody>
-                {% for row in analysis_rows %}
+    <div id="execute-write-analysis-section">
+        <h2>Query operations</h2>
+        {% if analysis_error %}
+            <p class="message-error">{{ analysis_error }}</p>
+        {% elif analysis_rows %}
+            <div class="table-wrapper"><table class="execute-write-analysis">
+                <thead>
                     <tr>
-                        <td><code>{{ row.operation }}</code></td>
-                        <td><code>{{ row.database }}</code></td>
-                        <td><code>{{ row.table }}</code></td>
-                        <td>{% if row.required_permission %}<code>{{ row.required_permission }}</code>{% endif %}</td>
-                        <td>{% if row.allowed is none %}{% elif row.allowed %}<span class="execute-write-analysis-allowed">yes</span>{% else %}<span class="execute-write-analysis-denied">no</span>{% endif %}</td>
+                        <th scope="col">Operation</th>
+                        <th scope="col">Database</th>
+                        <th scope="col">Table</th>
+                        <th scope="col">Required permission</th>
+                        <th scope="col">Allowed</th>
                     </tr>
-                {% endfor %}
-            </tbody>
-        </table></div>
-    {% else %}
-        <p>Analysis will show each affected table and required permission.</p>
-    {% endif %}
+                </thead>
+                <tbody>
+                    {% for row in analysis_rows %}
+                        <tr>
+                            <td><code>{{ row.operation }}</code></td>
+                            <td><code>{{ row.database }}</code></td>
+                            <td><code>{{ row.table }}</code></td>
+                            <td>{% if row.required_permission %}<code>{{ row.required_permission }}</code>{% endif %}</td>
+                            <td>{% if row.allowed is none %}{% elif row.allowed %}<span class="execute-write-analysis-allowed">yes</span>{% else %}<span class="execute-write-analysis-denied">no</span>{% endif %}</td>
+                        </tr>
+                    {% endfor %}
+                </tbody>
+            </table></div>
+        {% else %}
+            <p>Analysis will show each affected table and required permission.</p>
+        {% endif %}
+    </div>
 
-    <p><input type="submit" value="Execute"{% if execute_disabled %} disabled{% endif %}></p>
+    <p><input type="submit" value="Execute" data-execute-write-submit{% if execute_disabled %} disabled{% endif %}></p>
 </form>
 
 <script>
@@ -221,6 +225,40 @@ if (executeWriteSqlInput && !executeWriteSqlInput.value) {
 
 <script>
 window.addEventListener("DOMContentLoaded", () => {
+  const form = document.querySelector("form.sql.core");
+  const parametersSection = document.querySelector(
+    "#execute-write-parameters-section"
+  );
+  const analysisSection = document.querySelector("#execute-write-analysis-section");
+  const submitButton = form
+    ? form.querySelector("[data-execute-write-submit]")
+    : null;
+  const sqlInput = document.querySelector("textarea#sql-editor");
+  let parameterState = new Map();
+  let refreshTimer = null;
+  let refreshSequence = 0;
+
+  function currentSql() {
+    if (window.editor) {
+      return window.editor.state.doc.toString();
+    }
+    return sqlInput ? sqlInput.value : "";
+  }
+
+  function controlState(control) {
+    return {
+      value: control.value,
+      expanded: control.tagName.toLowerCase() === "textarea",
+    };
+  }
+
+  function syncParameterState() {
+    parameterState = new Map();
+    document.querySelectorAll("[data-parameter-control]").forEach((control) => {
+      parameterState.set(control.name, controlState(control));
+    });
+  }
+
   function replaceParameterControl(control, button, expand, value, selectionStart) {
     const replacement = document.createElement(expand ? "textarea" : "input");
     replacement.id = control.id;
@@ -241,54 +279,290 @@ window.addEventListener("DOMContentLoaded", () => {
     if (selectionStart !== undefined && replacement.setSelectionRange) {
       replacement.setSelectionRange(selectionStart, selectionStart);
     }
+    parameterState.set(replacement.name, controlState(replacement));
   }
 
-  document.querySelectorAll("[data-parameter-toggle]").forEach((button) => {
-    button.addEventListener("click", () => {
-      const control = document.getElementById(button.getAttribute("aria-controls"));
-      if (!control) {
+  function createControl(parameter, id, state) {
+    const control = document.createElement(state.expanded ? "textarea" : "input");
+    control.id = id;
+    control.name = parameter;
+    control.value = state.value;
+    control.setAttribute("data-parameter-control", "");
+    if (state.expanded) {
+      control.rows = 5;
+    } else {
+      control.type = "text";
+    }
+    return control;
+  }
+
+  function renderExecuteWriteParameters(parameters) {
+    if (!parametersSection) {
+      return;
+    }
+    syncParameterState();
+    const previousState = parameterState;
+    const nextState = new Map();
+    parametersSection.replaceChildren();
+    if (!parameters.length) {
+      parameterState = nextState;
+      return;
+    }
+
+    const heading = document.createElement("h2");
+    heading.textContent = "Parameters";
+    parametersSection.appendChild(heading);
+
+    parameters.forEach((parameter, index) => {
+      const id = `qp${index + 1}`;
+      const state = previousState.get(parameter) || {
+        value: "",
+        expanded: false,
+      };
+      nextState.set(parameter, state);
+
+      const row = document.createElement("p");
+      row.className = "execute-write-parameter-row";
+
+      const label = document.createElement("label");
+      label.htmlFor = id;
+      label.textContent = parameter;
+
+      const control = createControl(parameter, id, state);
+
+      const button = document.createElement("button");
+      button.type = "button";
+      button.className = "execute-write-parameter-toggle";
+      button.setAttribute("data-parameter-toggle", "");
+      button.setAttribute("aria-controls", id);
+      button.setAttribute("aria-expanded", state.expanded ? "true" : "false");
+      button.textContent = state.expanded ? "Collapse" : "Expand";
+
+      row.append(label, control, button);
+      parametersSection.appendChild(row);
+    });
+
+    parameterState = nextState;
+  }
+
+  function appendCodeCell(row, value) {
+    const cell = document.createElement("td");
+    if (value) {
+      const code = document.createElement("code");
+      code.textContent = value;
+      cell.appendChild(code);
+    }
+    row.appendChild(cell);
+  }
+
+  function renderExecuteWriteAnalysis(data) {
+    if (!analysisSection) {
+      return;
+    }
+    analysisSection.replaceChildren();
+
+    const heading = document.createElement("h2");
+    heading.textContent = "Query operations";
+    analysisSection.appendChild(heading);
+
+    if (data.analysis_error) {
+      const error = document.createElement("p");
+      error.className = "message-error";
+      error.textContent = data.analysis_error;
+      analysisSection.appendChild(error);
+      return;
+    }
+
+    const rows = data.analysis_rows || [];
+    if (!rows.length) {
+      const empty = document.createElement("p");
+      empty.textContent =
+        "Analysis will show each affected table and required permission.";
+      analysisSection.appendChild(empty);
+      return;
+    }
+
+    const wrapper = document.createElement("div");
+    wrapper.className = "table-wrapper";
+    const table = document.createElement("table");
+    table.className = "execute-write-analysis";
+    const thead = document.createElement("thead");
+    const headerRow = document.createElement("tr");
+    [
+      "Operation",
+      "Database",
+      "Table",
+      "Required permission",
+      "Allowed",
+    ].forEach((label) => {
+      const th = document.createElement("th");
+      th.scope = "col";
+      th.textContent = label;
+      headerRow.appendChild(th);
+    });
+    thead.appendChild(headerRow);
+    table.appendChild(thead);
+
+    const tbody = document.createElement("tbody");
+    rows.forEach((analysisRow) => {
+      const row = document.createElement("tr");
+      appendCodeCell(row, analysisRow.operation);
+      appendCodeCell(row, analysisRow.database);
+      appendCodeCell(row, analysisRow.table);
+      appendCodeCell(row, analysisRow.required_permission);
+
+      const allowedCell = document.createElement("td");
+      if (analysisRow.allowed !== null && analysisRow.allowed !== undefined) {
+        const allowed = document.createElement("span");
+        allowed.className = analysisRow.allowed
+          ? "execute-write-analysis-allowed"
+          : "execute-write-analysis-denied";
+        allowed.textContent = analysisRow.allowed ? "yes" : "no";
+        allowedCell.appendChild(allowed);
+      }
+      row.appendChild(allowedCell);
+      tbody.appendChild(row);
+    });
+    table.appendChild(tbody);
+    wrapper.appendChild(table);
+    analysisSection.appendChild(wrapper);
+  }
+
+  async function refreshExecuteWriteAnalysis() {
+    if (!form || !form.dataset.analyzeUrl) {
+      return;
+    }
+    const sequence = ++refreshSequence;
+    try {
+      const response = await fetch(form.dataset.analyzeUrl, {
+        method: "POST",
+        headers: {
+          accept: "application/json",
+          "content-type": "application/json",
+        },
+        body: JSON.stringify({ sql: currentSql() }),
+      });
+      const data = await response.json();
+      if (sequence !== refreshSequence) {
         return;
       }
-      const expanded = control.tagName.toLowerCase() === "textarea";
-      replaceParameterControl(control, button, !expanded);
-    });
+      if (!response.ok) {
+        throw new Error((data.errors || [response.statusText]).join("; "));
+      }
+      renderExecuteWriteParameters(data.parameters || []);
+      renderExecuteWriteAnalysis(data);
+      if (submitButton) {
+        submitButton.disabled = data.execute_disabled;
+      }
+    } catch (error) {
+      if (sequence !== refreshSequence) {
+        return;
+      }
+      renderExecuteWriteAnalysis({
+        analysis_error: error.message,
+        analysis_rows: [],
+      });
+      if (submitButton) {
+        submitButton.disabled = true;
+      }
+    }
+  }
+
+  function scheduleExecuteWriteAnalysisRefresh() {
+    clearTimeout(refreshTimer);
+    refreshTimer = setTimeout(refreshExecuteWriteAnalysis, 350);
+  }
+
+  function wrapEditorDispatch() {
+    if (!window.editor || window.editor.executeWriteRefreshWrapped) {
+      return false;
+    }
+    const editor = window.editor;
+    const originalDispatch = editor.dispatch.bind(editor);
+    editor.dispatch = (...transactions) => {
+      const before = editor.state.doc.toString();
+      originalDispatch(...transactions);
+      if (editor.state.doc.toString() !== before) {
+        scheduleExecuteWriteAnalysisRefresh();
+      }
+    };
+    editor.executeWriteRefreshWrapped = true;
+    return true;
+  }
+
+  if (!wrapEditorDispatch()) {
+    setTimeout(wrapEditorDispatch, 0);
+  }
+
+  const editorElement = document.querySelector(".execute-write-editor .cm-content");
+  if (editorElement) {
+    editorElement.addEventListener("input", scheduleExecuteWriteAnalysisRefresh);
+  } else if (sqlInput) {
+    sqlInput.addEventListener("input", scheduleExecuteWriteAnalysisRefresh);
+  }
+
+  if (!form) {
+    return;
+  }
+
+  form.addEventListener("click", (event) => {
+    const button = event.target.closest
+      ? event.target.closest("[data-parameter-toggle]")
+      : null;
+    if (!button || !form.contains(button)) {
+      return;
+    }
+    const control = document.getElementById(button.getAttribute("aria-controls"));
+    if (!control) {
+      return;
+    }
+    const expanded = control.tagName.toLowerCase() === "textarea";
+    replaceParameterControl(control, button, !expanded);
   });
 
-  document
-    .querySelector("form.sql.core")
-    .addEventListener("paste", (event) => {
-      const control = event.target;
-      if (
-        !(control instanceof HTMLInputElement) ||
-        !control.matches("[data-parameter-control]")
-      ) {
-        return;
-      }
-      const pasted = event.clipboardData ? event.clipboardData.getData("text") : "";
-      if (!/[\r\n]/.test(pasted)) {
-        return;
-      }
-      const button = document.querySelector(
-        `[data-parameter-toggle][aria-controls="${control.id}"]`
-      );
-      if (!button) {
-        return;
-      }
-      event.preventDefault();
-      const selectionStart = control.selectionStart ?? control.value.length;
-      const selectionEnd = control.selectionEnd ?? selectionStart;
-      const value =
-        control.value.slice(0, selectionStart) +
-        pasted +
-        control.value.slice(selectionEnd);
-      replaceParameterControl(
-        control,
-        button,
-        true,
-        value,
-        selectionStart + pasted.length
-      );
-    });
+  form.addEventListener("input", (event) => {
+    const control = event.target;
+    if (!control.matches || !control.matches("[data-parameter-control]")) {
+      return;
+    }
+    parameterState.set(control.name, controlState(control));
+  });
+
+  form.addEventListener("paste", (event) => {
+    const control = event.target;
+    if (
+      !(control instanceof HTMLInputElement) ||
+      !control.matches("[data-parameter-control]")
+    ) {
+      return;
+    }
+    const pasted = event.clipboardData ? event.clipboardData.getData("text") : "";
+    if (!/[\r\n]/.test(pasted)) {
+      return;
+    }
+    const button = document.querySelector(
+      `[data-parameter-toggle][aria-controls="${control.id}"]`
+    );
+    if (!button) {
+      return;
+    }
+    event.preventDefault();
+    const selectionStart = control.selectionStart ?? control.value.length;
+    const selectionEnd = control.selectionEnd ?? selectionStart;
+    const value =
+      control.value.slice(0, selectionStart) +
+      pasted +
+      control.value.slice(selectionEnd);
+    replaceParameterControl(
+      control,
+      button,
+      true,
+      value,
+      selectionStart + pasted.length
+    );
+  });
+
+  syncParameterState();
 });
 </script>
 
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 2b3920f7..e4eaee30 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -680,6 +680,39 @@ async def _prepare_execute_write(datasette, db, sql, params, actor):
     return parameter_names, params, analysis
 
 
+async def _execute_write_analysis_data(datasette, db, sql, actor):
+    parameter_names = []
+    analysis_rows = []
+    analysis_error = None
+    if sql:
+        try:
+            parameter_names = _derived_query_parameters(sql)
+            params = {parameter: "" for parameter in parameter_names}
+            analysis = await db.analyze_sql(sql, params)
+            if _analysis_is_write(analysis):
+                analysis_rows = await _analysis_rows_with_permissions(
+                    datasette, analysis, actor
+                )
+            else:
+                analysis_error = (
+                    "Use /-/query for read-only SQL; "
+                    "this endpoint only executes writes"
+                )
+        except (QueryValidationError, sqlite3.DatabaseError) as ex:
+            analysis_error = getattr(ex, "message", str(ex))
+    return {
+        "ok": analysis_error is None,
+        "parameters": parameter_names,
+        "analysis_error": analysis_error,
+        "analysis_rows": [row for row in analysis_rows if row["operation"] != "read"],
+        "execute_disabled": bool(
+            (not sql)
+            or analysis_error
+            or any(row["allowed"] is False for row in analysis_rows)
+        ),
+    }
+
+
 async def _inserted_row_url(datasette, db, analysis, cursor):
     if cursor.rowcount != 1:
         return None
@@ -1024,6 +1057,45 @@ class ExecuteWriteView(BaseView):
         )
 
 
+class ExecuteWriteAnalyzeView(BaseView):
+    name = "execute-write-analyze"
+    has_json_alternate = False
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-write-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(
+                _error(["Permission denied: need execute-write-sql"], 403)
+            )
+
+        try:
+            data, _ = await _json_or_form_payload(request)
+        except QueryValidationError as ex:
+            return _block_framing(_error([ex.message], ex.status))
+        if not isinstance(data, dict):
+            return _block_framing(_error(["JSON must be a dictionary"], 400))
+        invalid_keys = set(data) - {"sql"}
+        if invalid_keys:
+            return _block_framing(
+                _error(
+                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
+                    400,
+                )
+            )
+        sql = data.get("sql") or ""
+        if not isinstance(sql, str):
+            return _block_framing(_error(["sql must be a string"], 400))
+        return _block_framing(
+            Response.json(
+                await _execute_write_analysis_data(self.ds, db, sql, request.actor)
+            )
+        )
+
+
 class QueryListView(BaseView):
     name = "query-list"
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index f44a39fe..2f581661 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -528,6 +528,7 @@ Creating saved queries
 ``POST /<database>/-/queries/-/insert`` creates a saved query. This requires ``execute-sql`` and ``insert-query`` for the database.
 
 .. _ExecuteWriteView:
+.. _ExecuteWriteAnalyzeView:
 
 Executing write SQL
 ~~~~~~~~~~~~~~~~~~~
@@ -536,6 +537,8 @@ Executing write SQL
 
 ``POST /<database>/-/execute-write`` executes writable SQL. This requires ``execute-write-sql`` for the database plus the relevant table-level write permissions.
 
+``POST /<database>/-/execute-write/-/analyze`` accepts ``{"sql": "..."}`` and returns the derived parameters plus the write operations that SQL would need in order to execute.
+
 .. _QueryDefinitionView:
 
 Getting a saved query definition
diff --git a/tests/test_queries.py b/tests/test_queries.py
index a6080958..6d2c0b25 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -719,7 +719,9 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'data-sql-template="insert"' in response.text
     assert 'data-sql-template="update"' in response.text
     assert 'data-sql-template="delete"' in response.text
+    assert 'data-analyze-url="/data/-/execute-write/-/analyze"' in response.text
     assert 'addEventListener("paste"' in response.text
+    assert "refreshExecuteWriteAnalysis" in response.text
     assert '<table class="execute-write-analysis">' in response.text
     assert '<th scope="col">Required permission</th>' in response.text
     assert "<td><code>insert</code></td>" in response.text
@@ -737,6 +739,53 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'executeWriteSqlInput.value = "\\n\\n\\n";' in empty_response.text
 
 
+@pytest.mark.asyncio
+async def test_execute_write_analyze_endpoint_uses_sql_only():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_analyze", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/execute-write/-/analyze",
+        actor={"id": "root"},
+        json={"sql": "insert into dogs (name) values (:name)"},
+    )
+    read_only_response = await ds.client.post(
+        "/data/-/execute-write/-/analyze",
+        actor={"id": "root"},
+        json={"sql": "select * from dogs where name = :name"},
+    )
+
+    assert response.status_code == 200
+    data = response.json()
+    assert data["ok"] is True
+    assert data["parameters"] == ["name"]
+    assert data["analysis_error"] is None
+    assert data["execute_disabled"] is False
+    assert data["analysis_rows"] == [
+        {
+            "operation": "insert",
+            "database": "data",
+            "table": "dogs",
+            "required_permission": "insert-row",
+            "source": None,
+            "allowed": True,
+        }
+    ]
+    assert "params" not in data
+
+    assert read_only_response.status_code == 200
+    read_only_data = read_only_response.json()
+    assert read_only_data["ok"] is False
+    assert read_only_data["parameters"] == ["name"]
+    assert read_only_data["analysis_error"] == (
+        "Use /-/query for read-only SQL; this endpoint only executes writes"
+    )
+    assert read_only_data["execute_disabled"] is True
+
+
 @pytest.mark.asyncio
 async def test_database_action_menu_links_to_execute_write_for_permitted_actor():
     ds = Datasette(

From de55a76d402a6326c60a5f4cd1a03c7476613f0b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 12:33:57 -0700
Subject: [PATCH 068/386] Fix 500 error when accessing query page without ?sql=
 parameter (#2744)

Closes #2743
---
 datasette/templates/query.html |  4 ++--
 datasette/views/database.py    | 43 ++++++++++++++++++----------------
 docs/changelog.rst             |  7 ++++++
 tests/plugins/my_plugin.py     |  4 ++--
 tests/test_html.py             | 16 +++++++++++++
 5 files changed, 50 insertions(+), 24 deletions(-)

diff --git a/datasette/templates/query.html b/datasette/templates/query.html
index 8b405da5..5f85ac6b 100644
--- a/datasette/templates/query.html
+++ b/datasette/templates/query.html
@@ -46,14 +46,14 @@
     {% if not hide_sql %}
         {% if editable and allow_execute_sql %}
             <p><textarea id="sql-editor" name="sql"{% if query and query.sql %} style="height: {{ query.sql.split("\n")|length + 2 }}em"{% endif %}
-            >{% if query and query.sql %}{{ query.sql }}{% else %}select * from {{ tables[0].name|escape_sqlite }}{% endif %}</textarea></p>
+            >{% if query and query.sql %}{{ query.sql }}{% elif tables %}select * from {{ tables[0].name|escape_sqlite }}{% endif %}</textarea></p>
         {% else %}
             <pre id="sql-query">{% if query %}{{ query.sql }}{% endif %}</pre>
         {% endif %}
     {% else %}
         {% if not canned_query %}
             <input type="hidden" name="sql"
-                value="{% if query and query.sql %}{{ query.sql }}{% else %}select * from {{ tables[0].name|escape_sqlite }}{% endif %}"
+                value="{% if query and query.sql %}{{ query.sql }}{% elif tables %}select * from {{ tables[0].name|escape_sqlite }}{% endif %}"
             >
         {% endif %}
     {% endif %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 0cf93832..8e4ea85a 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -577,7 +577,7 @@ class QueryView(View):
         named_parameters = []
         if canned_query and canned_query.get("params"):
             named_parameters = canned_query["params"]
-        if not named_parameters:
+        if not named_parameters and sql:
             named_parameters = derive_named_parameters(sql)
         named_parameter_values = {
             named_parameter: params.get(named_parameter) or ""
@@ -602,7 +602,7 @@ class QueryView(View):
 
         params_for_query = params
 
-        if not canned_query_write:
+        if sql and not canned_query_write:
             try:
                 if not canned_query:
                     # For regular queries we only allow SELECT, plus other rules
@@ -646,6 +646,8 @@ class QueryView(View):
 
         # Handle formats from plugins
         if format_ == "csv":
+            if not sql:
+                raise DatasetteError("?sql= is required", status=400)
 
             async def fetch_data_for_csv(request, _next=None):
                 results = await db.execute(sql, params, truncate=True)
@@ -771,25 +773,26 @@ class QueryView(View):
             # - No magic parameters, so no :_ in the SQL string
             edit_sql_url = None
             is_validated_sql = False
-            try:
-                validate_sql_select(sql)
-                is_validated_sql = True
-            except InvalidSql:
-                pass
-            if allow_execute_sql and is_validated_sql and ":_" not in sql:
-                edit_sql_url = (
-                    datasette.urls.database(database)
-                    + "/-/query"
-                    + "?"
-                    + urlencode(
-                        {
-                            **{
-                                "sql": sql,
-                            },
-                            **named_parameter_values,
-                        }
+            if sql:
+                try:
+                    validate_sql_select(sql)
+                    is_validated_sql = True
+                except InvalidSql:
+                    pass
+                if allow_execute_sql and is_validated_sql and ":_" not in sql:
+                    edit_sql_url = (
+                        datasette.urls.database(database)
+                        + "/-/query"
+                        + "?"
+                        + urlencode(
+                            {
+                                **{
+                                    "sql": sql,
+                                },
+                                **named_parameter_values,
+                            }
+                        )
                     )
-                )
 
             async def query_actions():
                 query_actions = []
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 329b4769..dfb2a736 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,6 +4,13 @@
 Changelog
 =========
 
+.. _v1_0_unreleased:
+
+Unreleased
+----------
+
+- Fixed a bug where visiting ``/<database>/-/query`` without a ``?sql=`` parameter returned a 500 error. (:issue:`2743`)
+
 .. _v1_0_a30:
 
 1.0a30 (2026-05-24)
diff --git a/tests/plugins/my_plugin.py b/tests/plugins/my_plugin.py
index 4e401c07..f682e8b9 100644
--- a/tests/plugins/my_plugin.py
+++ b/tests/plugins/my_plugin.py
@@ -387,8 +387,8 @@ def view_actions(datasette, database, view, actor):
 
 @hookimpl
 def query_actions(datasette, database, query_name, sql):
-    # Don't explain an explain
-    if sql.lower().startswith("explain"):
+    # Don't explain an explain (or a missing query)
+    if not sql or sql.lower().startswith("explain"):
         return
     return [
         {
diff --git a/tests/test_html.py b/tests/test_html.py
index efc1040d..d20796c9 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -241,6 +241,22 @@ def test_query_page_truncates():
         ]
 
 
+@pytest.mark.asyncio
+async def test_query_page_with_no_sql(ds_client):
+    # https://github.com/simonw/datasette/issues/2743
+    response = await ds_client.get("/fixtures/-/query")
+    assert response.status_code == 200
+    assert '<textarea id="sql-editor" name="sql"' in response.text
+    assert 'class="rows-and-columns"' not in response.text
+
+
+@pytest.mark.asyncio
+async def test_query_csv_with_no_sql_is_400(ds_client):
+    # https://github.com/simonw/datasette/issues/2743
+    response = await ds_client.get("/fixtures/-/query.csv")
+    assert response.status_code == 400
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "path,expected_classes",

From 1f7c26ffeaaa41d069afa9603c37dd7f92f633b7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 12:45:42 -0700
Subject: [PATCH 069/386] Refactor to share JS/HTML between execute and
 execute-write

Refs #2742
---
 datasette/app.py                              |   5 +
 .../templates/_sql_parameter_scripts.html     | 286 ++++++++++++++++
 .../templates/_sql_parameter_styles.html      |  58 ++++
 datasette/templates/_sql_parameters.html      |   9 +
 datasette/templates/database.html             |  15 +-
 datasette/templates/execute_write.html        | 314 +-----------------
 datasette/templates/query.html                |  21 +-
 datasette/views/database.py                   |  42 ++-
 docs/json_api.rst                             |   5 +-
 tests/test_canned_queries.py                  |   5 +-
 tests/test_html.py                            |  16 +-
 tests/test_queries.py                         |  48 ++-
 12 files changed, 494 insertions(+), 330 deletions(-)
 create mode 100644 datasette/templates/_sql_parameter_scripts.html
 create mode 100644 datasette/templates/_sql_parameter_styles.html
 create mode 100644 datasette/templates/_sql_parameters.html

diff --git a/datasette/app.py b/datasette/app.py
index d6f8933f..90e41521 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -56,6 +56,7 @@ from .views.database import (
     GlobalQueryListView,
     QueryInsertView,
     QueryListView,
+    QueryParametersView,
     QueryUpdateView,
 )
 from .views.index import IndexView
@@ -2758,6 +2759,10 @@ class Datasette:
             DatabaseSchemaView.as_view(self),
             r"/(?P<database>[^\/\.]+)/-/schema(\.(?P<format>json|md))?$",
         )
+        add_route(
+            QueryParametersView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/query/-/parameters$",
+        )
         add_route(
             wrap_view(QueryView, self),
             r"/(?P<database>[^\/\.]+)/-/query(\.(?P<format>\w+))?$",
diff --git a/datasette/templates/_sql_parameter_scripts.html b/datasette/templates/_sql_parameter_scripts.html
new file mode 100644
index 00000000..68e46069
--- /dev/null
+++ b/datasette/templates/_sql_parameter_scripts.html
@@ -0,0 +1,286 @@
+<script>
+window.datasetteSqlParameters = (() => {
+  if (
+    window.datasetteSqlParameters &&
+    window.datasetteSqlParameters.setupSqlParameterRefresh
+  ) {
+    return window.datasetteSqlParameters;
+  }
+
+  function currentSql(form) {
+    if (window.editor) {
+      return window.editor.state.doc.toString();
+    }
+    const sqlInput = form.querySelector("textarea#sql-editor, input[name=sql]");
+    return sqlInput ? sqlInput.value : "";
+  }
+
+  function controlState(control) {
+    return {
+      value: control.value,
+      expanded: control.tagName.toLowerCase() === "textarea",
+    };
+  }
+
+  function syncParameterState(manager) {
+    manager.parameterState = new Map();
+    manager.section
+      .querySelectorAll("[data-parameter-control]")
+      .forEach((control) => {
+        manager.parameterState.set(control.name, controlState(control));
+      });
+  }
+
+  function createControl(parameter, id, state) {
+    const control = document.createElement(state.expanded ? "textarea" : "input");
+    control.id = id;
+    control.name = parameter;
+    control.value = state.value;
+    control.setAttribute("data-parameter-control", "");
+    if (state.expanded) {
+      control.rows = 5;
+    } else {
+      control.type = "text";
+    }
+    return control;
+  }
+
+  function replaceParameterControl(
+    manager,
+    control,
+    button,
+    expand,
+    value,
+    selectionStart
+  ) {
+    const replacement = createControl(control.name, control.id, {
+      value: value === undefined ? control.value : value,
+      expanded: expand,
+    });
+    button.textContent = expand ? "Collapse" : "Expand";
+    button.setAttribute("aria-expanded", expand ? "true" : "false");
+    control.replaceWith(replacement);
+    replacement.focus();
+    if (selectionStart !== undefined && replacement.setSelectionRange) {
+      replacement.setSelectionRange(selectionStart, selectionStart);
+    }
+    manager.parameterState.set(replacement.name, controlState(replacement));
+  }
+
+  function renderParameters(manager, parameters) {
+    syncParameterState(manager);
+    const previousState = manager.parameterState;
+    const nextState = new Map();
+    manager.section.replaceChildren();
+    if (!parameters.length) {
+      manager.parameterState = nextState;
+      return;
+    }
+
+    const heading = document.createElement("h2");
+    heading.textContent = "Parameters";
+    manager.section.appendChild(heading);
+
+    parameters.forEach((parameter, index) => {
+      const id = `qp${index + 1}`;
+      const state = previousState.get(parameter) || {
+        value: "",
+        expanded: false,
+      };
+      if (!manager.allowExpand) {
+        state.expanded = false;
+      }
+      nextState.set(parameter, state);
+
+      const row = document.createElement("p");
+      row.className = "sql-parameter-row";
+
+      const label = document.createElement("label");
+      label.htmlFor = id;
+      label.textContent = parameter;
+
+      const control = createControl(parameter, id, state);
+
+      row.append(label, control);
+      if (manager.allowExpand) {
+        const button = document.createElement("button");
+        button.type = "button";
+        button.className = "sql-parameter-toggle";
+        button.setAttribute("data-parameter-toggle", "");
+        button.setAttribute("aria-controls", id);
+        button.setAttribute("aria-expanded", state.expanded ? "true" : "false");
+        button.textContent = state.expanded ? "Collapse" : "Expand";
+        row.append(" ", button);
+      }
+      manager.section.appendChild(row);
+    });
+
+    manager.parameterState = nextState;
+  }
+
+  function bindParameterControls(manager) {
+    manager.form.addEventListener("input", (event) => {
+      const control = event.target;
+      if (!control.matches || !control.matches("[data-parameter-control]")) {
+        return;
+      }
+      manager.parameterState.set(control.name, controlState(control));
+    });
+
+    if (!manager.allowExpand) {
+      return;
+    }
+
+    manager.form.addEventListener("click", (event) => {
+      const button = event.target.closest
+        ? event.target.closest("[data-parameter-toggle]")
+        : null;
+      if (!button || !manager.form.contains(button)) {
+        return;
+      }
+      const control = document.getElementById(button.getAttribute("aria-controls"));
+      if (!control) {
+        return;
+      }
+      const expanded = control.tagName.toLowerCase() === "textarea";
+      replaceParameterControl(manager, control, button, !expanded);
+    });
+
+    manager.form.addEventListener("paste", (event) => {
+      const control = event.target;
+      if (
+        !(control instanceof HTMLInputElement) ||
+        !control.matches("[data-parameter-control]")
+      ) {
+        return;
+      }
+      const pasted = event.clipboardData ? event.clipboardData.getData("text") : "";
+      if (!/[\r\n]/.test(pasted)) {
+        return;
+      }
+      const button = document.querySelector(
+        `[data-parameter-toggle][aria-controls="${control.id}"]`
+      );
+      if (!button) {
+        return;
+      }
+      event.preventDefault();
+      const selectionStart = control.selectionStart ?? control.value.length;
+      const selectionEnd = control.selectionEnd ?? selectionStart;
+      const value =
+        control.value.slice(0, selectionStart) +
+        pasted +
+        control.value.slice(selectionEnd);
+      replaceParameterControl(
+        manager,
+        control,
+        button,
+        true,
+        value,
+        selectionStart + pasted.length
+      );
+    });
+  }
+
+  function bindEditorChanges(form, callback) {
+    const editorElement = form.querySelector(".cm-content");
+    if (editorElement) {
+      editorElement.addEventListener("input", callback);
+    }
+    if (!window.editor) {
+      const sqlInput = form.querySelector("textarea#sql-editor");
+      if (sqlInput) {
+        sqlInput.addEventListener("input", callback);
+      }
+      return;
+    }
+    if (!window.editor.datasetteSqlParameterCallbacks) {
+      const editor = window.editor;
+      const originalDispatch = editor.dispatch.bind(editor);
+      editor.datasetteSqlParameterCallbacks = [];
+      editor.dispatch = (...transactions) => {
+        const before = editor.state.doc.toString();
+        originalDispatch(...transactions);
+        if (editor.state.doc.toString() !== before) {
+          editor.datasetteSqlParameterCallbacks.forEach((listener) => listener());
+        }
+      };
+    }
+    window.editor.datasetteSqlParameterCallbacks.push(callback);
+  }
+
+  function setupSqlParameterRefresh(options) {
+    const form =
+      options.form || document.querySelector("form.sql.core[data-parameters-url]");
+    if (!form) {
+      return null;
+    }
+    const section =
+      options.section || form.querySelector("[data-sql-parameters-section]");
+    if (!section) {
+      return null;
+    }
+    const manager = {
+      form,
+      section,
+      allowExpand:
+        options.allowExpand === undefined
+          ? section.dataset.allowExpand === "1"
+          : options.allowExpand,
+      parameterState: new Map(),
+    };
+    bindParameterControls(manager);
+    syncParameterState(manager);
+
+    const url = options.url || form.dataset.parametersUrl;
+    let refreshTimer = null;
+    let refreshSequence = 0;
+
+    async function refreshParameters() {
+      if (!url) {
+        return;
+      }
+      const sequence = ++refreshSequence;
+      try {
+        const requestUrl = new URL(url, window.location.href);
+        requestUrl.searchParams.set("sql", currentSql(form));
+        const response = await fetch(requestUrl, {
+          headers: { accept: "application/json" },
+        });
+        const data = await response.json();
+        if (sequence !== refreshSequence) {
+          return;
+        }
+        if (!response.ok) {
+          throw new Error((data.errors || [response.statusText]).join("; "));
+        }
+        renderParameters(manager, data.parameters || []);
+        if (options.onData) {
+          options.onData(data, manager);
+        }
+      } catch (error) {
+        if (sequence !== refreshSequence) {
+          return;
+        }
+        if (options.onError) {
+          options.onError(error, manager);
+        }
+      }
+    }
+
+    function scheduleRefresh() {
+      clearTimeout(refreshTimer);
+      refreshTimer = setTimeout(refreshParameters, options.debounceMs || 350);
+    }
+
+    bindEditorChanges(form, scheduleRefresh);
+    return {
+      currentSql: () => currentSql(form),
+      refreshParameters,
+      renderParameters: (parameters) => renderParameters(manager, parameters),
+    };
+  }
+
+  return { setupSqlParameterRefresh };
+})();
+</script>
diff --git a/datasette/templates/_sql_parameter_styles.html b/datasette/templates/_sql_parameter_styles.html
new file mode 100644
index 00000000..bc6838f5
--- /dev/null
+++ b/datasette/templates/_sql_parameter_styles.html
@@ -0,0 +1,58 @@
+<style>
+form.sql .sql-editor {
+    max-width: 52rem;
+}
+form.sql .sql-editor textarea#sql-editor {
+    width: 100%;
+}
+form.sql .sql-parameters-section {
+    max-width: 52rem;
+}
+form.sql .sql-parameter-row {
+    align-items: start;
+    column-gap: 0.6rem;
+    display: grid;
+    grid-template-columns: minmax(8rem, 11rem) minmax(16rem, 1fr) auto;
+    margin: 0 0 0.65rem;
+    max-width: 52rem;
+}
+form.sql .sql-parameter-row label {
+    overflow-wrap: anywhere;
+    padding-top: 0.55rem;
+    width: auto;
+}
+form.sql .sql-parameter-row input[data-parameter-control],
+form.sql .sql-parameter-row textarea[data-parameter-control] {
+    box-sizing: border-box;
+    width: 100%;
+}
+form.sql .sql-parameter-row textarea[data-parameter-control] {
+    border: 1px solid #ccc;
+    border-radius: 3px;
+    display: block;
+    font-family: Helvetica, sans-serif;
+    font-size: 1em;
+    min-height: 7rem;
+    padding: 9px 4px;
+}
+form.sql.core button.sql-parameter-toggle[type=button] {
+    font-size: 0.72rem;
+    height: 1.8rem;
+    line-height: 1;
+    margin: 0.25rem 0 0;
+    padding: 0.25rem 0.45rem;
+}
+@media (max-width: 480px) {
+    form.sql .sql-parameter-row {
+        grid-template-columns: 1fr;
+        row-gap: 0.25rem;
+    }
+    form.sql .sql-parameter-row label {
+        padding-top: 0;
+    }
+    form.sql.core button.sql-parameter-toggle[type=button] {
+        justify-self: start;
+        margin-top: 0;
+    }
+}
+</style>
diff --git a/datasette/templates/_sql_parameters.html b/datasette/templates/_sql_parameters.html
new file mode 100644
index 00000000..58801d40
--- /dev/null
+++ b/datasette/templates/_sql_parameters.html
@@ -0,0 +1,9 @@
+<div id="{{ sql_parameters_section_id|default("sql-parameters-section") }}" class="sql-parameters-section" data-sql-parameters-section{% if sql_parameters_allow_expand|default(false) %} data-allow-expand="1"{% endif %}>
+    {% if parameter_names %}
+        <h2>Parameters</h2>
+        {% for parameter in parameter_names %}
+            {% set parameter_id = (sql_parameter_id_prefix|default("qp")) ~ loop.index %}
+            <p class="sql-parameter-row"><label for="{{ parameter_id }}">{{ parameter }}</label> <input type="text" id="{{ parameter_id }}" name="{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}" data-parameter-control>{% if sql_parameters_allow_expand|default(false) %} <button type="button" class="sql-parameter-toggle" data-parameter-toggle aria-controls="{{ parameter_id }}" aria-expanded="false">Expand</button>{% endif %}</p>
+        {% endfor %}
+    {% endif %}
+</div>
diff --git a/datasette/templates/database.html b/datasette/templates/database.html
index a39d6ad7..0c9ec94c 100644
--- a/datasette/templates/database.html
+++ b/datasette/templates/database.html
@@ -5,6 +5,7 @@
 {% block extra_head %}
 {{- super() -}}
 {% include "_codemirror.html" %}
+{% include "_sql_parameter_styles.html" %}
 {% endblock %}
 
 {% block body_class %}db db-{{ database|to_css_class }}{% endblock %}
@@ -25,9 +26,13 @@
 {% block description_source_license %}{% include "_description_source_license.html" %}{% endblock %}
 
 {% if allow_execute_sql %}
-    <form class="sql core" action="{{ urls.database(database) }}/-/query" method="get">
+    <form class="sql core" action="{{ urls.database(database) }}/-/query" method="get" data-parameters-url="{{ urls.database(database) }}/-/query/-/parameters">
         <h3>Custom SQL query</h3>
-        <p><textarea id="sql-editor" name="sql">{% if tables %}select * from {{ tables[0].name|escape_sqlite }}{% else %}select sqlite_version(){% endif %}</textarea></p>
+        <p class="sql-editor"><textarea id="sql-editor" name="sql">{% if tables %}select * from {{ tables[0].name|escape_sqlite }}{% else %}select sqlite_version(){% endif %}</textarea></p>
+        {% set parameter_names = [] %}
+        {% set parameter_values = {} %}
+        {% set sql_parameters_allow_expand = false %}
+        {% include "_sql_parameters.html" %}
         <p>
             <button id="sql-format" type="button" hidden>Format SQL</button>
             <input type="submit" value="Run SQL">
@@ -90,5 +95,11 @@
 {% endif %}
 
 {% include "_codemirror_foot.html" %}
+{% include "_sql_parameter_scripts.html" %}
+<script>
+window.addEventListener("DOMContentLoaded", () => {
+  window.datasetteSqlParameters.setupSqlParameterRefresh({});
+});
+</script>
 
 {% endblock %}
diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 5037d006..9b522f66 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -75,61 +75,8 @@
     color: #b00020;
     font-weight: 700;
 }
-form.sql .execute-write-parameter-row textarea[data-parameter-control] {
-    border: 1px solid #ccc;
-    border-radius: 3px;
-    box-sizing: border-box;
-    display: block;
-    font-family: Helvetica, sans-serif;
-    font-size: 1em;
-    min-height: 7rem;
-    padding: 9px 4px;
-    width: 100%;
-}
-form.sql .execute-write-parameter-row {
-    align-items: start;
-    column-gap: 0.6rem;
-    display: grid;
-    grid-template-columns: minmax(8rem, 11rem) minmax(16rem, 1fr) auto;
-    margin: 0 0 0.65rem;
-    max-width: 52rem;
-}
-form.sql .execute-write-parameter-row label {
-    overflow-wrap: anywhere;
-    padding-top: 0.55rem;
-    width: auto;
-}
-form.sql .execute-write-parameter-row input[data-parameter-control] {
-    box-sizing: border-box;
-    width: 100%;
-}
-form.sql.core button.execute-write-parameter-toggle[type=button] {
-    font-size: 0.72rem;
-    height: 1.8rem;
-    line-height: 1;
-    margin: 0.25rem 0 0;
-    padding: 0.25rem 0.45rem;
-}
-@media (max-width: 480px) {
-    form.sql .execute-write-parameter-row {
-        grid-template-columns: 1fr;
-        row-gap: 0.25rem;
-    }
-    form.sql .execute-write-parameter-row label {
-        padding-top: 0;
-    }
-    form.sql.core button.execute-write-parameter-toggle[type=button] {
-        justify-self: start;
-        margin-top: 0;
-    }
-}
-form.sql .execute-write-editor {
-    max-width: 52rem;
-}
-form.sql .execute-write-editor textarea#sql-editor {
-    width: 100%;
-}
 </style>
+{% include "_sql_parameter_styles.html" %}
 {% endblock %}
 
 {% block body_class %}execute-write db-{{ database|to_css_class }}{% endblock %}
@@ -168,16 +115,11 @@ form.sql .execute-write-editor textarea#sql-editor {
         </div>
     {% endif %}
 
-    <p class="execute-write-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
+    <p class="sql-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
 
-    <div id="execute-write-parameters-section">
-        {% if parameter_names %}
-            <h2>Parameters</h2>
-            {% for parameter in parameter_names %}
-                <p class="execute-write-parameter-row"><label for="qp{{ loop.index }}">{{ parameter }}</label> <input type="text" id="qp{{ loop.index }}" name="{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}" data-parameter-control> <button type="button" class="execute-write-parameter-toggle" data-parameter-toggle aria-controls="qp{{ loop.index }}" aria-expanded="false">Expand</button></p>
-            {% endfor %}
-        {% endif %}
-    </div>
+    {% set sql_parameters_section_id = "execute-write-parameters-section" %}
+    {% set sql_parameters_allow_expand = true %}
+    {% include "_sql_parameters.html" %}
 
     <div id="execute-write-analysis-section">
         <h2>Query operations</h2>
@@ -222,128 +164,15 @@ if (executeWriteSqlInput && !executeWriteSqlInput.value) {
 </script>
 
 {% include "_codemirror_foot.html" %}
+{% include "_sql_parameter_scripts.html" %}
 
 <script>
 window.addEventListener("DOMContentLoaded", () => {
   const form = document.querySelector("form.sql.core");
-  const parametersSection = document.querySelector(
-    "#execute-write-parameters-section"
-  );
   const analysisSection = document.querySelector("#execute-write-analysis-section");
   const submitButton = form
     ? form.querySelector("[data-execute-write-submit]")
     : null;
-  const sqlInput = document.querySelector("textarea#sql-editor");
-  let parameterState = new Map();
-  let refreshTimer = null;
-  let refreshSequence = 0;
-
-  function currentSql() {
-    if (window.editor) {
-      return window.editor.state.doc.toString();
-    }
-    return sqlInput ? sqlInput.value : "";
-  }
-
-  function controlState(control) {
-    return {
-      value: control.value,
-      expanded: control.tagName.toLowerCase() === "textarea",
-    };
-  }
-
-  function syncParameterState() {
-    parameterState = new Map();
-    document.querySelectorAll("[data-parameter-control]").forEach((control) => {
-      parameterState.set(control.name, controlState(control));
-    });
-  }
-
-  function replaceParameterControl(control, button, expand, value, selectionStart) {
-    const replacement = document.createElement(expand ? "textarea" : "input");
-    replacement.id = control.id;
-    replacement.name = control.name;
-    replacement.value = value === undefined ? control.value : value;
-    replacement.setAttribute("data-parameter-control", "");
-    if (expand) {
-      replacement.rows = 5;
-      button.textContent = "Collapse";
-      button.setAttribute("aria-expanded", "true");
-    } else {
-      replacement.type = "text";
-      button.textContent = "Expand";
-      button.setAttribute("aria-expanded", "false");
-    }
-    control.replaceWith(replacement);
-    replacement.focus();
-    if (selectionStart !== undefined && replacement.setSelectionRange) {
-      replacement.setSelectionRange(selectionStart, selectionStart);
-    }
-    parameterState.set(replacement.name, controlState(replacement));
-  }
-
-  function createControl(parameter, id, state) {
-    const control = document.createElement(state.expanded ? "textarea" : "input");
-    control.id = id;
-    control.name = parameter;
-    control.value = state.value;
-    control.setAttribute("data-parameter-control", "");
-    if (state.expanded) {
-      control.rows = 5;
-    } else {
-      control.type = "text";
-    }
-    return control;
-  }
-
-  function renderExecuteWriteParameters(parameters) {
-    if (!parametersSection) {
-      return;
-    }
-    syncParameterState();
-    const previousState = parameterState;
-    const nextState = new Map();
-    parametersSection.replaceChildren();
-    if (!parameters.length) {
-      parameterState = nextState;
-      return;
-    }
-
-    const heading = document.createElement("h2");
-    heading.textContent = "Parameters";
-    parametersSection.appendChild(heading);
-
-    parameters.forEach((parameter, index) => {
-      const id = `qp${index + 1}`;
-      const state = previousState.get(parameter) || {
-        value: "",
-        expanded: false,
-      };
-      nextState.set(parameter, state);
-
-      const row = document.createElement("p");
-      row.className = "execute-write-parameter-row";
-
-      const label = document.createElement("label");
-      label.htmlFor = id;
-      label.textContent = parameter;
-
-      const control = createControl(parameter, id, state);
-
-      const button = document.createElement("button");
-      button.type = "button";
-      button.className = "execute-write-parameter-toggle";
-      button.setAttribute("data-parameter-toggle", "");
-      button.setAttribute("aria-controls", id);
-      button.setAttribute("aria-expanded", state.expanded ? "true" : "false");
-      button.textContent = state.expanded ? "Collapse" : "Expand";
-
-      row.append(label, control, button);
-      parametersSection.appendChild(row);
-    });
-
-    parameterState = nextState;
-  }
 
   function appendCodeCell(row, value) {
     const cell = document.createElement("td");
@@ -428,36 +257,17 @@ window.addEventListener("DOMContentLoaded", () => {
     analysisSection.appendChild(wrapper);
   }
 
-  async function refreshExecuteWriteAnalysis() {
-    if (!form || !form.dataset.analyzeUrl) {
-      return;
-    }
-    const sequence = ++refreshSequence;
-    try {
-      const response = await fetch(form.dataset.analyzeUrl, {
-        method: "POST",
-        headers: {
-          accept: "application/json",
-          "content-type": "application/json",
-        },
-        body: JSON.stringify({ sql: currentSql() }),
-      });
-      const data = await response.json();
-      if (sequence !== refreshSequence) {
-        return;
-      }
-      if (!response.ok) {
-        throw new Error((data.errors || [response.statusText]).join("; "));
-      }
-      renderExecuteWriteParameters(data.parameters || []);
+  window.datasetteSqlParameters.setupSqlParameterRefresh({
+    form,
+    url: form.dataset.analyzeUrl,
+    allowExpand: true,
+    onData(data) {
       renderExecuteWriteAnalysis(data);
       if (submitButton) {
         submitButton.disabled = data.execute_disabled;
       }
-    } catch (error) {
-      if (sequence !== refreshSequence) {
-        return;
-      }
+    },
+    onError(error) {
       renderExecuteWriteAnalysis({
         analysis_error: error.message,
         analysis_rows: [],
@@ -465,104 +275,8 @@ window.addEventListener("DOMContentLoaded", () => {
       if (submitButton) {
         submitButton.disabled = true;
       }
-    }
-  }
-
-  function scheduleExecuteWriteAnalysisRefresh() {
-    clearTimeout(refreshTimer);
-    refreshTimer = setTimeout(refreshExecuteWriteAnalysis, 350);
-  }
-
-  function wrapEditorDispatch() {
-    if (!window.editor || window.editor.executeWriteRefreshWrapped) {
-      return false;
-    }
-    const editor = window.editor;
-    const originalDispatch = editor.dispatch.bind(editor);
-    editor.dispatch = (...transactions) => {
-      const before = editor.state.doc.toString();
-      originalDispatch(...transactions);
-      if (editor.state.doc.toString() !== before) {
-        scheduleExecuteWriteAnalysisRefresh();
-      }
-    };
-    editor.executeWriteRefreshWrapped = true;
-    return true;
-  }
-
-  if (!wrapEditorDispatch()) {
-    setTimeout(wrapEditorDispatch, 0);
-  }
-
-  const editorElement = document.querySelector(".execute-write-editor .cm-content");
-  if (editorElement) {
-    editorElement.addEventListener("input", scheduleExecuteWriteAnalysisRefresh);
-  } else if (sqlInput) {
-    sqlInput.addEventListener("input", scheduleExecuteWriteAnalysisRefresh);
-  }
-
-  if (!form) {
-    return;
-  }
-
-  form.addEventListener("click", (event) => {
-    const button = event.target.closest
-      ? event.target.closest("[data-parameter-toggle]")
-      : null;
-    if (!button || !form.contains(button)) {
-      return;
-    }
-    const control = document.getElementById(button.getAttribute("aria-controls"));
-    if (!control) {
-      return;
-    }
-    const expanded = control.tagName.toLowerCase() === "textarea";
-    replaceParameterControl(control, button, !expanded);
+    },
   });
-
-  form.addEventListener("input", (event) => {
-    const control = event.target;
-    if (!control.matches || !control.matches("[data-parameter-control]")) {
-      return;
-    }
-    parameterState.set(control.name, controlState(control));
-  });
-
-  form.addEventListener("paste", (event) => {
-    const control = event.target;
-    if (
-      !(control instanceof HTMLInputElement) ||
-      !control.matches("[data-parameter-control]")
-    ) {
-      return;
-    }
-    const pasted = event.clipboardData ? event.clipboardData.getData("text") : "";
-    if (!/[\r\n]/.test(pasted)) {
-      return;
-    }
-    const button = document.querySelector(
-      `[data-parameter-toggle][aria-controls="${control.id}"]`
-    );
-    if (!button) {
-      return;
-    }
-    event.preventDefault();
-    const selectionStart = control.selectionStart ?? control.value.length;
-    const selectionEnd = control.selectionEnd ?? selectionStart;
-    const value =
-      control.value.slice(0, selectionStart) +
-      pasted +
-      control.value.slice(selectionEnd);
-    replaceParameterControl(
-      control,
-      button,
-      true,
-      value,
-      selectionStart + pasted.length
-    );
-  });
-
-  syncParameterState();
 });
 </script>
 
diff --git a/datasette/templates/query.html b/datasette/templates/query.html
index 7c251e2c..3bcc7178 100644
--- a/datasette/templates/query.html
+++ b/datasette/templates/query.html
@@ -14,6 +14,7 @@
 </style>
 {% endif %}
 {% include "_codemirror.html" %}
+{% include "_sql_parameter_styles.html" %}
 {% endblock %}
 
 {% block body_class %}query db-{{ database|to_css_class }}{% if canned_query %} query-{{ canned_query|to_css_class }}{% endif %}{% endblock %}
@@ -36,7 +37,7 @@
 
 {% block description_source_license %}{% include "_description_source_license.html" %}{% endblock %}
 
-<form class="sql core" action="{{ urls.database(database) }}{% if canned_query %}/{{ canned_query }}{% endif %}" method="{% if canned_query_write %}post{% else %}get{% endif %}">
+<form class="sql core" action="{{ urls.database(database) }}{% if canned_query %}/{{ canned_query }}{% endif %}" method="{% if canned_query_write %}post{% else %}get{% endif %}" data-parameters-url="{{ urls.database(database) }}/-/query/-/parameters">
     <h3>Custom SQL query{% if display_rows %} returning {% if truncated %}more than {% endif %}{{ "{:,}".format(display_rows|length) }} row{% if display_rows|length == 1 %}{% else %}s{% endif %}{% endif %}{% if not query_error %}
         <span class="show-hide-sql">(<a href="{{ show_hide_link }}">{{ show_hide_text }}</a>)</span>
     {% endif %}</h3>
@@ -45,7 +46,7 @@
     {% endif %}
     {% if not hide_sql %}
         {% if editable and allow_execute_sql %}
-            <p><textarea id="sql-editor" name="sql"{% if query and query.sql %} style="height: {{ query.sql.split("\n")|length + 2 }}em"{% endif %}
+            <p class="sql-editor"><textarea id="sql-editor" name="sql"{% if query and query.sql %} style="height: {{ query.sql.split("\n")|length + 2 }}em"{% endif %}
             >{% if query and query.sql %}{{ query.sql }}{% else %}select * from {{ tables[0].name|escape_sqlite }}{% endif %}</textarea></p>
         {% else %}
             <pre id="sql-query">{% if query %}{{ query.sql }}{% endif %}</pre>
@@ -57,12 +58,10 @@
             >
         {% endif %}
     {% endif %}
-    {% if named_parameter_values %}
-        <h3>Query parameters</h3>
-        {% for name, value in named_parameter_values.items() %}
-            <p><label for="qp{{ loop.index }}">{{ name }}</label> <input type="text" id="qp{{ loop.index }}" name="{{ name }}" value="{{ value }}"></p>
-        {% endfor %}
-    {% endif %}
+    {% set parameter_names = named_parameter_values.keys()|list %}
+    {% set parameter_values = named_parameter_values %}
+    {% set sql_parameters_allow_expand = false %}
+    {% include "_sql_parameters.html" %}
     <p>
         {% if not hide_sql %}<button id="sql-format" type="button" hidden>Format SQL</button>{% endif %}
         <input type="submit" value="Run SQL"{% if canned_query_write and db_is_immutable %} disabled{% endif %}>
@@ -97,5 +96,11 @@
 {% endif %}
 
 {% include "_codemirror_foot.html" %}
+{% include "_sql_parameter_scripts.html" %}
+<script>
+window.addEventListener("DOMContentLoaded", () => {
+  window.datasetteSqlParameters.setupSqlParameterRefresh({});
+});
+</script>
 
 {% endblock %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index e4eaee30..278f7e8c 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -1061,7 +1061,7 @@ class ExecuteWriteAnalyzeView(BaseView):
     name = "execute-write-analyze"
     has_json_alternate = False
 
-    async def post(self, request):
+    async def get(self, request):
         db = await self.ds.resolve_database(request)
         if not await self.ds.allowed(
             action="execute-write-sql",
@@ -1072,13 +1072,7 @@ class ExecuteWriteAnalyzeView(BaseView):
                 _error(["Permission denied: need execute-write-sql"], 403)
             )
 
-        try:
-            data, _ = await _json_or_form_payload(request)
-        except QueryValidationError as ex:
-            return _block_framing(_error([ex.message], ex.status))
-        if not isinstance(data, dict):
-            return _block_framing(_error(["JSON must be a dictionary"], 400))
-        invalid_keys = set(data) - {"sql"}
+        invalid_keys = set(request.args) - {"sql"}
         if invalid_keys:
             return _block_framing(
                 _error(
@@ -1086,9 +1080,7 @@ class ExecuteWriteAnalyzeView(BaseView):
                     400,
                 )
             )
-        sql = data.get("sql") or ""
-        if not isinstance(sql, str):
-            return _block_framing(_error(["sql must be a string"], 400))
+        sql = request.args.get("sql") or ""
         return _block_framing(
             Response.json(
                 await _execute_write_analysis_data(self.ds, db, sql, request.actor)
@@ -1096,6 +1088,34 @@ class ExecuteWriteAnalyzeView(BaseView):
         )
 
 
+class QueryParametersView(BaseView):
+    name = "query-parameters"
+    has_json_alternate = False
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(_error(["Permission denied: need execute-sql"], 403))
+
+        invalid_keys = set(request.args) - {"sql"}
+        if invalid_keys:
+            return _block_framing(
+                _error(
+                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
+                    400,
+                )
+            )
+        try:
+            parameters = _derived_query_parameters(request.args.get("sql") or "")
+        except QueryValidationError as ex:
+            return _block_framing(_error([ex.message], ex.status))
+        return _block_framing(Response.json({"ok": True, "parameters": parameters}))
+
+
 class QueryListView(BaseView):
     name = "query-list"
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 2f581661..91ed5306 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -527,17 +527,20 @@ Creating saved queries
 
 ``POST /<database>/-/queries/-/insert`` creates a saved query. This requires ``execute-sql`` and ``insert-query`` for the database.
 
+.. _QueryParametersView:
 .. _ExecuteWriteView:
 .. _ExecuteWriteAnalyzeView:
 
 Executing write SQL
 ~~~~~~~~~~~~~~~~~~~
 
+``GET /<database>/-/query/-/parameters?sql=...`` returns the named parameters used by a SQL query. This requires ``execute-sql`` for the database.
+
 ``GET /<database>/-/execute-write`` displays a form for executing writable SQL. A ``?sql=`` query string pre-populates the form without executing it.
 
 ``POST /<database>/-/execute-write`` executes writable SQL. This requires ``execute-write-sql`` for the database plus the relevant table-level write permissions.
 
-``POST /<database>/-/execute-write/-/analyze`` accepts ``{"sql": "..."}`` and returns the derived parameters plus the write operations that SQL would need in order to execute.
+``GET /<database>/-/execute-write/-/analyze?sql=...`` returns the derived parameters plus the write operations that SQL would need in order to execute.
 
 .. _QueryDefinitionView:
 
diff --git a/tests/test_canned_queries.py b/tests/test_canned_queries.py
index a9d22036..ae2c74e0 100644
--- a/tests/test_canned_queries.py
+++ b/tests/test_canned_queries.py
@@ -200,7 +200,10 @@ def test_error_in_on_success_message_sql(canned_write_client):
 
 def test_custom_params(canned_write_client):
     response = canned_write_client.get("/data/update_name?extra=foo")
-    assert '<input type="text" id="qp3" name="extra" value="foo">' in response.text
+    assert (
+        '<input type="text" id="qp3" name="extra" value="foo" data-parameter-control>'
+        in response.text
+    )
 
 
 def test_canned_query_pages_no_vary_header(canned_write_client):
diff --git a/tests/test_html.py b/tests/test_html.py
index e5f00e17..b49391a6 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -326,17 +326,29 @@ async def test_query_parameter_form_fields(ds_client):
     response = await ds_client.get("/fixtures/-/query?sql=select+:name")
     assert response.status_code == 200
     assert (
-        '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="">'
+        '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="" data-parameter-control>'
         in response.text
     )
+    assert 'data-parameters-url="/fixtures/-/query/-/parameters"' in response.text
+    assert 'id="sql-parameters-section"' in response.text
+    assert "setupSqlParameterRefresh" in response.text
     response2 = await ds_client.get("/fixtures/-/query?sql=select+:name&name=hello")
     assert response2.status_code == 200
     assert (
-        '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="hello">'
+        '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="hello" data-parameter-control>'
         in response2.text
     )
 
 
+@pytest.mark.asyncio
+async def test_database_page_sql_parameter_refresh_markup(ds_client):
+    response = await ds_client.get("/fixtures")
+    assert response.status_code == 200
+    assert 'data-parameters-url="/fixtures/-/query/-/parameters"' in response.text
+    assert 'id="sql-parameters-section"' in response.text
+    assert "setupSqlParameterRefresh" in response.text
+
+
 @pytest.mark.asyncio
 async def test_row_html_simple_primary_key(ds_client):
     response = await ds_client.get("/fixtures/simple_primary_key/1")
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 6d2c0b25..23820cf3 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -721,7 +721,7 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'data-sql-template="delete"' in response.text
     assert 'data-analyze-url="/data/-/execute-write/-/analyze"' in response.text
     assert 'addEventListener("paste"' in response.text
-    assert "refreshExecuteWriteAnalysis" in response.text
+    assert "setupSqlParameterRefresh" in response.text
     assert '<table class="execute-write-analysis">' in response.text
     assert '<th scope="col">Required permission</th>' in response.text
     assert "<td><code>insert</code></td>" in response.text
@@ -747,15 +747,15 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
     await db.execute_write("create table dogs (id integer primary key, name text)")
     await ds.invoke_startup()
 
-    response = await ds.client.post(
+    response = await ds.client.get(
         "/data/-/execute-write/-/analyze",
         actor={"id": "root"},
-        json={"sql": "insert into dogs (name) values (:name)"},
+        params={"sql": "insert into dogs (name) values (:name)"},
     )
-    read_only_response = await ds.client.post(
+    read_only_response = await ds.client.get(
         "/data/-/execute-write/-/analyze",
         actor={"id": "root"},
-        json={"sql": "select * from dogs where name = :name"},
+        params={"sql": "select * from dogs where name = :name"},
     )
 
     assert response.status_code == 200
@@ -786,6 +786,44 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
     assert read_only_data["execute_disabled"] is True
 
 
+@pytest.mark.asyncio
+async def test_query_parameters_endpoint_uses_get_sql_only():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_parameters", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.get(
+        "/data/-/query/-/parameters",
+        actor={"id": "root"},
+        params={
+            "sql": "select * from dogs where name = :name and id = :id",
+        },
+    )
+    permission_denied_response = await ds.client.get(
+        "/data/-/query/-/parameters",
+        actor={"id": "not-root"},
+        params={"sql": "select * from dogs where name = :name"},
+    )
+    magic_parameter_response = await ds.client.get(
+        "/data/-/query/-/parameters",
+        actor={"id": "root"},
+        params={"sql": "select :_actor_id"},
+    )
+
+    assert response.status_code == 200
+    assert response.json() == {"ok": True, "parameters": ["name", "id"]}
+    assert permission_denied_response.status_code == 403
+    assert permission_denied_response.json()["errors"] == [
+        "Permission denied: need execute-sql"
+    ]
+    assert magic_parameter_response.status_code == 400
+    assert magic_parameter_response.json()["errors"] == [
+        "Magic parameters are not allowed"
+    ]
+
+
 @pytest.mark.asyncio
 async def test_database_action_menu_links_to_execute_write_for_permitted_actor():
     ds = Datasette(

From 4208ded249b28f8b0918ce80d289bfc88f9e8921 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 12:46:21 -0700
Subject: [PATCH 070/386] No execute-write on immutable databases

Refs https://github.com/simonw/datasette/issues/2742#issuecomment-4536690161
---
 datasette/default_database_actions.py |  2 ++
 datasette/views/database.py           |  7 ++++
 tests/test_queries.py                 | 46 +++++++++++++++++++++++++++
 3 files changed, 55 insertions(+)

diff --git a/datasette/default_database_actions.py b/datasette/default_database_actions.py
index 78055392..e0cb3cdf 100644
--- a/datasette/default_database_actions.py
+++ b/datasette/default_database_actions.py
@@ -5,6 +5,8 @@ from datasette.resources import DatabaseResource
 @hookimpl
 def database_actions(datasette, actor, database, request):
     async def inner():
+        if not datasette.get_database(database).is_mutable:
+            return []
         if not await datasette.allowed(
             action="execute-write-sql",
             resource=DatabaseResource(database),
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 278f7e8c..de02cd0f 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -964,6 +964,13 @@ class ExecuteWriteView(BaseView):
             resource=DatabaseResource(db.name),
             actor=request.actor,
         )
+        if not db.is_mutable:
+            return _block_framing(
+                _error(
+                    ["Cannot execute write SQL because this database is immutable."],
+                    403,
+                )
+            )
         return await self._render_form(
             request,
             db,
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 23820cf3..c31d7205 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -858,6 +858,52 @@ async def test_database_action_menu_links_to_execute_write_for_permitted_actor()
     assert "Execute write SQL" in writer_response.text
 
 
+@pytest.mark.asyncio
+async def test_database_action_menu_hides_execute_write_for_immutable_database():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_menu_immutable", name="data")
+    db.is_mutable = False
+    await ds.invoke_startup()
+
+    response = await ds.client.get("/data", actor={"id": "writer"})
+
+    assert response.status_code == 200
+    assert "Execute write SQL" not in response.text
+    assert 'href="/data/-/execute-write"' not in response.text
+
+
+@pytest.mark.asyncio
+async def test_execute_write_get_rejects_immutable_database():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_get_immutable", name="data")
+    db.is_mutable = False
+    await ds.invoke_startup()
+
+    response = await ds.client.get(
+        "/data/-/execute-write?sql=insert+into+dogs+(name)+values+('Cleo')",
+        actor={"id": "root"},
+    )
+
+    assert response.status_code == 403
+    assert response.json()["errors"] == [
+        "Cannot execute write SQL because this database is immutable."
+    ]
+
+
 @pytest.mark.asyncio
 async def test_execute_write_post_requires_database_and_table_permissions():
     ds = Datasette(

From 8ab8999ba97e0ec1d113ee8d3954d6431f39fa28 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 12:55:36 -0700
Subject: [PATCH 071/386] Big visual improvement to /-/queries pages

Including /db/-/queries

Refs https://github.com/simonw/datasette/issues/2735#issuecomment-4536860239
---
 datasette/templates/query_list.html | 226 ++++++++++++++++++++++++----
 datasette/views/database.py         |  12 +-
 tests/test_queries.py               |  25 ++-
 3 files changed, 229 insertions(+), 34 deletions(-)

diff --git a/datasette/templates/query_list.html b/datasette/templates/query_list.html
index af974550..dbd607ab 100644
--- a/datasette/templates/query_list.html
+++ b/datasette/templates/query_list.html
@@ -2,6 +2,155 @@
 
 {% block title %}{% if database %}{{ database }}: {% endif %}queries{% endblock %}
 
+{% block extra_head %}
+{{- super() -}}
+<style>
+.query-list-page {
+    max-width: 64rem;
+}
+.query-list-filters {
+    margin: 0.5rem 0 1rem;
+}
+.query-list-search {
+    align-items: center;
+    display: flex;
+    flex-wrap: wrap;
+    gap: 0.45rem;
+    margin: 0 0 0.75rem;
+}
+.query-list-search label {
+    width: auto;
+}
+.query-list-search input[type=search] {
+    box-sizing: border-box;
+    flex: 1 1 18rem;
+    max-width: 24rem;
+}
+.query-list-search button[type=submit] {
+    font-size: 0.78rem;
+    height: 2rem;
+    line-height: 1.1;
+    padding: 0.35rem 0.65rem;
+}
+.query-list-filter-groups {
+    align-items: flex-start;
+    display: flex;
+    flex-wrap: wrap;
+    gap: 0.8rem 1.4rem;
+}
+.query-list-filter-group {
+    border: 0;
+    display: flex;
+    flex-wrap: wrap;
+    gap: 0.35rem;
+    margin: 0;
+    min-width: 0;
+    padding: 0;
+}
+.query-list-filter-group legend {
+    font-weight: 700;
+    margin: 0 0.45rem 0 0;
+    padding: 0;
+}
+.query-list-filter-group label {
+    align-items: center;
+    border: 1px solid #c8d1dc;
+    border-radius: 0.25rem;
+    cursor: pointer;
+    display: inline-flex;
+    font-size: 0.82rem;
+    gap: 0.3rem;
+    line-height: 1.1;
+    padding: 0.35rem 0.55rem;
+}
+.query-list-filter-group input {
+    margin: 0;
+}
+.query-list-filter-group input:checked + span {
+    font-weight: 700;
+}
+.query-list-results {
+    border-collapse: collapse;
+    font-size: 0.9rem;
+    margin: 0.25rem 0 1rem;
+    min-width: 36rem;
+    width: 100%;
+}
+.query-list-results th,
+.query-list-results td {
+    border-bottom: 1px solid #d7dde5;
+    padding: 0.45rem 0.7rem;
+    text-align: left;
+    vertical-align: top;
+}
+.query-list-results th {
+    background-color: #edf6fb;
+    border-top: 1px solid #d7dde5;
+    color: #39445a;
+    font-weight: 700;
+}
+.query-list-results tbody tr:nth-child(even) {
+    background-color: rgba(39, 104, 144, 0.05);
+}
+.query-list-results a.query-list-title {
+    font-weight: 700;
+}
+.query-list-description {
+    color: #4f5b6d;
+    font-size: 0.78rem;
+    margin: 0.15rem 0 0;
+}
+.query-list-pill {
+    background-color: #eef1f5;
+    border: 1px solid #d7dde5;
+    border-radius: 0.25rem;
+    color: #39445a;
+    display: inline-block;
+    font-size: 0.75rem;
+    font-weight: 700;
+    line-height: 1;
+    padding: 0.25rem 0.4rem;
+    white-space: nowrap;
+}
+.query-list-pill-write {
+    background-color: #fff4db;
+    border-color: #e2b64e;
+}
+.query-list-pill-published {
+    background-color: #e7f5ec;
+    border-color: #9ecfab;
+    color: #267a3e;
+}
+.query-list-pill-unpublished {
+    background-color: #f7edf0;
+    border-color: #dbb8c1;
+}
+.query-list-pagination a {
+    border: 1px solid #007bff;
+    border-radius: 0.25rem;
+    display: inline-block;
+    padding: 0.45rem 0.7rem;
+}
+.query-list-pagination-bottom {
+    margin-top: 0.75rem;
+}
+@media (max-width: 700px) {
+    .query-list-search input[type=search] {
+        max-width: none;
+    }
+    .query-list-filter-group {
+        display: block;
+    }
+    .query-list-filter-group legend {
+        margin-bottom: 0.3rem;
+    }
+    .query-list-filter-group label {
+        margin: 0 0.25rem 0.35rem 0;
+    }
+}
+</style>
+{% endblock %}
+
 {% block body_class %}query-list{% if database %} db-{{ database|to_css_class }}{% endif %}{% endblock %}
 
 {% block crumbs %}
@@ -10,49 +159,66 @@
 
 {% block content %}
 
-<h1>Queries</h1>
+<div class="query-list-page">
 
-<form action="{{ query_list_path }}" method="get">
-    <p>
+<h1 style="padding-left: 10px; border-left: 10px solid #{% if database_color %}{{ database_color }}{% else %}666{% endif %}">Queries</h1>
+
+<form class="query-list-filters core" action="{{ query_list_path }}" method="get">
+    <p class="query-list-search">
         <label for="query-search">Search</label>
         <input id="query-search" type="search" name="q" value="{{ filters.q }}">
         <button type="submit">Search</button>
     </p>
-    <p>
-        <label for="query-is-write">Mode</label>
-        <select id="query-is-write" name="is_write">
-            <option value=""{% if not filters.is_write %} selected{% endif %}>Any</option>
-            <option value="0"{% if filters.is_write == "0" %} selected{% endif %}>Read-only</option>
-            <option value="1"{% if filters.is_write == "1" %} selected{% endif %}>Writable</option>
-        </select>
-        <label for="query-is-published">Publication</label>
-        <select id="query-is-published" name="is_published">
-            <option value=""{% if not filters.is_published %} selected{% endif %}>Any</option>
-            <option value="1"{% if filters.is_published == "1" %} selected{% endif %}>Published</option>
-            <option value="0"{% if filters.is_published == "0" %} selected{% endif %}>Unpublished</option>
-        </select>
-    </p>
+    <div class="query-list-filter-groups">
+        <fieldset class="query-list-filter-group">
+            <legend>Mode</legend>
+            <label><input type="radio" name="is_write" value=""{% if not filters.is_write %} checked{% endif %}> <span>Any</span></label>
+            <label><input type="radio" name="is_write" value="0"{% if filters.is_write == "0" %} checked{% endif %}> <span>Read-only</span></label>
+            <label><input type="radio" name="is_write" value="1"{% if filters.is_write == "1" %} checked{% endif %}> <span>Writable</span></label>
+        </fieldset>
+        <fieldset class="query-list-filter-group">
+            <legend>Publication</legend>
+            <label><input type="radio" name="is_published" value=""{% if not filters.is_published %} checked{% endif %}> <span>Any</span></label>
+            <label><input type="radio" name="is_published" value="1"{% if filters.is_published == "1" %} checked{% endif %}> <span>Published</span></label>
+            <label><input type="radio" name="is_published" value="0"{% if filters.is_published == "0" %} checked{% endif %}> <span>Unpublished</span></label>
+        </fieldset>
+    </div>
 </form>
 
 {% if queries %}
-    <ul class="bullets">
-        {% for query in queries %}
-            <li>
-                {% if show_database %}
-                    <a href="{{ urls.database(query.database) }}">{{ query.database }}</a>:
-                {% endif %}
-                <a href="{{ urls.query(query.database, query.name) }}{% if query.fragment %}#{{ query.fragment }}{% endif %}" title="{{ query.description or query.sql }}">{{ query.title or query.name }}</a>{% if query.private %} 🔒{% endif %}
-                {% if query.is_write %}<span>Writable</span>{% endif %}
-                {% if query.is_published %}<span>Published</span>{% endif %}
-            </li>
-        {% endfor %}
-    </ul>
+    <div class="table-wrapper"><table class="query-list-results">
+        <thead>
+            <tr>
+                {% if show_database %}<th scope="col">Database</th>{% endif %}
+                <th scope="col">Query</th>
+                <th scope="col">Mode</th>
+                <th scope="col">Publication</th>
+            </tr>
+        </thead>
+        <tbody>
+            {% for query in queries %}
+                <tr>
+                    {% if show_database %}
+                        <td><a class="query-list-database" href="{{ urls.database(query.database) }}">{{ query.database }}</a></td>
+                    {% endif %}
+                    <td>
+                        <a class="query-list-title" href="{{ urls.query(query.database, query.name) }}{% if query.fragment %}#{{ query.fragment }}{% endif %}" title="{{ query.description or query.sql }}">{{ query.title or query.name }}</a>{% if query.private %} 🔒{% endif %}
+                        {% if query.description %}<p class="query-list-description">{{ query.description }}</p>{% endif %}
+                    </td>
+                    <td>{% if query.is_write %}<span class="query-list-pill query-list-pill-write">Writable</span>{% else %}<span class="query-list-pill">Read-only</span>{% endif %}</td>
+                    <td>{% if query.is_published %}<span class="query-list-pill query-list-pill-published">Published</span>{% else %}<span class="query-list-pill query-list-pill-unpublished">Unpublished</span>{% endif %}</td>
+                </tr>
+            {% endfor %}
+        </tbody>
+    </table></div>
 {% else %}
     <p>No queries found.</p>
 {% endif %}
 
 {% if next_url %}
-    <p><a href="{{ next_url }}">Next page</a></p>
+    <nav class="query-list-pagination query-list-pagination-bottom" aria-label="Query pagination"><a href="{{ next_url }}">Next page</a></nav>
 {% endif %}
 
+</div>
+
 {% endblock %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index de02cd0f..3c660bc7 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -487,9 +487,9 @@ def _as_optional_bool(value, name):
     raise QueryValidationError("{} must be 0 or 1".format(name))
 
 
-def _query_list_limit(value):
+def _query_list_limit(value, default=50):
     if value in (None, ""):
-        return 50
+        return default
     try:
         return min(max(1, int(value)), 1000)
     except ValueError as ex:
@@ -1136,7 +1136,10 @@ class QueryListView(BaseView):
         database = await self.database_name(request)
         format_ = request.url_vars.get("format") or "html"
         try:
-            limit = _query_list_limit(request.args.get("_size"))
+            limit = _query_list_limit(
+                request.args.get("_size"),
+                default=20 if format_ == "html" else 50,
+            )
             is_write = _as_optional_bool(request.args.get("is_write"), "is_write")
             is_published = _as_optional_bool(
                 request.args.get("is_published"), "is_published"
@@ -1175,6 +1178,9 @@ class QueryListView(BaseView):
         data = {
             "ok": True,
             "database": database,
+            "database_color": (
+                self.ds.get_database(database).color if database is not None else None
+            ),
             "queries": page["queries"],
             "next": page["next"],
             "next_url": next_url,
diff --git a/tests/test_queries.py b/tests/test_queries.py
index c31d7205..b7416ac7 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -451,12 +451,34 @@ async def test_query_list_search_filter_and_html():
     assert html_response.status_code == 200
     assert "Demo query 02" in html_response.text
     assert "Demo query 01" not in html_response.text
+    assert 'class="query-list-results"' in html_response.text
+    assert "<legend>Mode</legend>" in html_response.text
+    assert 'type="radio" name="is_published" value="1"' in html_response.text
     assert json_response.json()["queries"][0]["name"] == "demo_query_02"
     assert [query["name"] for query in filtered_response.json()["queries"]] == [
         "private_query"
     ]
 
 
+@pytest.mark.asyncio
+async def test_query_list_html_defaults_to_twenty_and_shows_pagination():
+    ds = Datasette(memory=True)
+    ds.root_enabled = True
+    ds.add_memory_database("query_list_html_pagination", name="data")
+    await ds.invoke_startup()
+    await add_numbered_queries(ds, "data", 25)
+
+    response = await ds.client.get("/data/-/queries", actor={"id": "root"})
+    json_response = await ds.client.get("/data/-/queries.json", actor={"id": "root"})
+
+    assert response.status_code == 200
+    assert response.text.count('aria-label="Query pagination"') == 1
+    assert "Demo query 20" in response.text
+    assert "Demo query 21" not in response.text
+    assert 'href="/data/-/queries?_next=' in response.text
+    assert len(json_response.json()["queries"]) == 25
+
+
 @pytest.mark.asyncio
 async def test_global_query_list_api_and_html():
     ds = Datasette(memory=True)
@@ -519,7 +541,8 @@ async def test_global_query_list_api_and_html():
         ("beta", "beta_first"),
     ]
     assert html_response.status_code == 200
-    assert 'href="/beta">beta</a>:' in html_response.text
+    assert '<th scope="col">Database</th>' in html_response.text
+    assert 'class="query-list-database" href="/beta">beta</a>' in html_response.text
     assert "Beta first" in html_response.text
     assert "Alpha first" not in html_response.text
 

From f1dd86ebfb01644fead19f9f007b9b76f863d72e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 25 May 2026 14:05:26 -0700
Subject: [PATCH 072/386] Tweak URL designs of new endpoints

---
 datasette/app.py                       |  6 +++---
 datasette/templates/database.html      |  2 +-
 datasette/templates/execute_write.html |  2 +-
 datasette/templates/query.html         |  2 +-
 datasette/templates/query_create.html  |  2 +-
 docs/json_api.rst                      |  6 +++---
 queries-plan.md                        |  4 ++--
 tests/test_html.py                     |  4 ++--
 tests/test_queries.py                  | 22 +++++++++++-----------
 9 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 90e41521..232aa0cf 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2745,11 +2745,11 @@ class Datasette:
         )
         add_route(
             QueryInsertView.as_view(self),
-            r"/(?P<database>[^\/\.]+)/-/queries/-/insert$",
+            r"/(?P<database>[^\/\.]+)/-/queries/insert$",
         )
         add_route(
             ExecuteWriteAnalyzeView.as_view(self),
-            r"/(?P<database>[^\/\.]+)/-/execute-write/-/analyze$",
+            r"/(?P<database>[^\/\.]+)/-/execute-write/analyze$",
         )
         add_route(
             ExecuteWriteView.as_view(self),
@@ -2761,7 +2761,7 @@ class Datasette:
         )
         add_route(
             QueryParametersView.as_view(self),
-            r"/(?P<database>[^\/\.]+)/-/query/-/parameters$",
+            r"/(?P<database>[^\/\.]+)/-/query/parameters$",
         )
         add_route(
             wrap_view(QueryView, self),
diff --git a/datasette/templates/database.html b/datasette/templates/database.html
index 0c9ec94c..62f9c620 100644
--- a/datasette/templates/database.html
+++ b/datasette/templates/database.html
@@ -26,7 +26,7 @@
 {% block description_source_license %}{% include "_description_source_license.html" %}{% endblock %}
 
 {% if allow_execute_sql %}
-    <form class="sql core" action="{{ urls.database(database) }}/-/query" method="get" data-parameters-url="{{ urls.database(database) }}/-/query/-/parameters">
+    <form class="sql core" action="{{ urls.database(database) }}/-/query" method="get" data-parameters-url="{{ urls.database(database) }}/-/query/parameters">
         <h3>Custom SQL query</h3>
         <p class="sql-editor"><textarea id="sql-editor" name="sql">{% if tables %}select * from {{ tables[0].name|escape_sqlite }}{% else %}select sqlite_version(){% endif %}</textarea></p>
         {% set parameter_names = [] %}
diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 9b522f66..46f58c3b 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -95,7 +95,7 @@
     <p class="{% if execution_ok %}message-info{% else %}message-error{% endif %}">{{ execution_message }}{% for link in execution_links %} <a href="{{ link.href }}">{{ link.label }}</a>{% endfor %}</p>
 {% endif %}
 
-<form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post" data-analyze-url="{{ urls.database(database) }}/-/execute-write/-/analyze">
+<form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post" data-analyze-url="{{ urls.database(database) }}/-/execute-write/analyze">
     {% if write_template_tables %}
         <div class="execute-write-template-menu">
             <details>
diff --git a/datasette/templates/query.html b/datasette/templates/query.html
index 3bcc7178..f74d21f1 100644
--- a/datasette/templates/query.html
+++ b/datasette/templates/query.html
@@ -37,7 +37,7 @@
 
 {% block description_source_license %}{% include "_description_source_license.html" %}{% endblock %}
 
-<form class="sql core" action="{{ urls.database(database) }}{% if canned_query %}/{{ canned_query }}{% endif %}" method="{% if canned_query_write %}post{% else %}get{% endif %}" data-parameters-url="{{ urls.database(database) }}/-/query/-/parameters">
+<form class="sql core" action="{{ urls.database(database) }}{% if canned_query %}/{{ canned_query }}{% endif %}" method="{% if canned_query_write %}post{% else %}get{% endif %}" data-parameters-url="{{ urls.database(database) }}/-/query/parameters">
     <h3>Custom SQL query{% if display_rows %} returning {% if truncated %}more than {% endif %}{{ "{:,}".format(display_rows|length) }} row{% if display_rows|length == 1 %}{% else %}s{% endif %}{% endif %}{% if not query_error %}
         <span class="show-hide-sql">(<a href="{{ show_hide_link }}">{{ show_hide_text }}</a>)</span>
     {% endif %}</h3>
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index fb2599d2..3c027def 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -17,7 +17,7 @@
 
 <h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Create query</h1>
 
-<form class="sql core" action="{{ urls.database(database) }}/-/queries/-/insert" method="post">
+<form class="sql core" action="{{ urls.database(database) }}/-/queries/insert" method="post">
     <p><label for="query-name">Name</label> <input id="query-name" name="name" type="text"></p>
     <p><label for="query-title">Title</label> <input id="query-title" name="title" type="text"></p>
     <p><label for="query-description">Description</label><br><textarea id="query-description" name="description" rows="3"></textarea></p>
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 91ed5306..dd54c459 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -525,7 +525,7 @@ Creating saved queries in the UI
 Creating saved queries
 ~~~~~~~~~~~~~~~~~~~~~~
 
-``POST /<database>/-/queries/-/insert`` creates a saved query. This requires ``execute-sql`` and ``insert-query`` for the database.
+``POST /<database>/-/queries/insert`` creates a saved query. This requires ``execute-sql`` and ``insert-query`` for the database.
 
 .. _QueryParametersView:
 .. _ExecuteWriteView:
@@ -534,13 +534,13 @@ Creating saved queries
 Executing write SQL
 ~~~~~~~~~~~~~~~~~~~
 
-``GET /<database>/-/query/-/parameters?sql=...`` returns the named parameters used by a SQL query. This requires ``execute-sql`` for the database.
+``GET /<database>/-/query/parameters?sql=...`` returns the named parameters used by a SQL query. This requires ``execute-sql`` for the database.
 
 ``GET /<database>/-/execute-write`` displays a form for executing writable SQL. A ``?sql=`` query string pre-populates the form without executing it.
 
 ``POST /<database>/-/execute-write`` executes writable SQL. This requires ``execute-write-sql`` for the database plus the relevant table-level write permissions.
 
-``GET /<database>/-/execute-write/-/analyze?sql=...`` returns the derived parameters plus the write operations that SQL would need in order to execute.
+``GET /<database>/-/execute-write/analyze?sql=...`` returns the derived parameters plus the write operations that SQL would need in order to execute.
 
 .. _QueryDefinitionView:
 
diff --git a/queries-plan.md b/queries-plan.md
index a708e887..72427df2 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -211,7 +211,7 @@ JSON endpoints should follow Datasette's existing write API style: use `POST` pl
 Endpoints:
 
 - `GET /-/queries` and `GET /{database}/-/queries` show searchable HTML query browsers. `GET /-/queries.json` lists query definitions across every database the actor can view; `GET /{database}/-/queries.json` scopes that list to one database. Both JSON endpoints use cursor pagination with `_next` and `_size`.
-- `POST /{database}/-/queries/-/insert` creates a query.
+- `POST /{database}/-/queries/insert` creates a query.
 - `GET /{database}/{query}/-/definition` returns one query definition without executing it.
 - `POST /{database}/{query}/-/update` updates one query.
 - `POST /{database}/{query}/-/delete` deletes one query.
@@ -388,7 +388,7 @@ The read methods should reconstruct the existing dictionary shape used by query
 
 On `/{database}/-/query`, if the actor has both `execute-sql` and `insert-query`, show a save control for valid read-only SQL. That page already executes read-only arbitrary SQL, so the first UI can stay read-only even though the JSON API can accept writable SQL after `Database.analyze_sql()` validation.
 
-The save form should call `POST /{database}/-/queries/-/insert` and default to `is_published=false`.
+The save form should call `POST /{database}/-/queries/insert` and default to `is_published=false`.
 
 If the actor also has `publish-query`, include a publish control. The UI copy should make it clear that publishing allows people without arbitrary SQL permission to run this query.
 
diff --git a/tests/test_html.py b/tests/test_html.py
index b49391a6..8cda6dba 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -329,7 +329,7 @@ async def test_query_parameter_form_fields(ds_client):
         '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="" data-parameter-control>'
         in response.text
     )
-    assert 'data-parameters-url="/fixtures/-/query/-/parameters"' in response.text
+    assert 'data-parameters-url="/fixtures/-/query/parameters"' in response.text
     assert 'id="sql-parameters-section"' in response.text
     assert "setupSqlParameterRefresh" in response.text
     response2 = await ds_client.get("/fixtures/-/query?sql=select+:name&name=hello")
@@ -344,7 +344,7 @@ async def test_query_parameter_form_fields(ds_client):
 async def test_database_page_sql_parameter_refresh_markup(ds_client):
     response = await ds_client.get("/fixtures")
     assert response.status_code == 200
-    assert 'data-parameters-url="/fixtures/-/query/-/parameters"' in response.text
+    assert 'data-parameters-url="/fixtures/-/query/parameters"' in response.text
     assert 'id="sql-parameters-section"' in response.text
     assert "setupSqlParameterRefresh" in response.text
 
diff --git a/tests/test_queries.py b/tests/test_queries.py
index b7416ac7..57920584 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -356,7 +356,7 @@ async def test_query_insert_api_creates_read_only_query():
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/-/insert",
+        "/data/-/queries/insert",
         actor={"id": "root"},
         json={
             "query": {
@@ -568,7 +568,7 @@ async def test_query_insert_api_publish_requires_publish_query():
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/-/insert",
+        "/data/-/queries/insert",
         actor={"id": "writer"},
         json={"query": {"name": "public", "sql": "select 1", "is_published": True}},
     )
@@ -586,7 +586,7 @@ async def test_query_insert_api_creates_writable_query():
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/-/insert",
+        "/data/-/queries/insert",
         actor={"id": "root"},
         json={
             "query": {
@@ -603,7 +603,7 @@ async def test_query_insert_api_creates_writable_query():
     assert query["parameters"] == ["name"]
 
     bad_response = await ds.client.post(
-        "/data/-/queries/-/insert",
+        "/data/-/queries/insert",
         actor={"id": "root"},
         json={
             "query": {
@@ -671,7 +671,7 @@ async def test_query_insert_api_rejects_magic_parameters():
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/-/insert",
+        "/data/-/queries/insert",
         actor={"id": "root"},
         json={"query": {"name": "magic", "sql": "select :_actor_id"}},
     )
@@ -742,7 +742,7 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'data-sql-template="insert"' in response.text
     assert 'data-sql-template="update"' in response.text
     assert 'data-sql-template="delete"' in response.text
-    assert 'data-analyze-url="/data/-/execute-write/-/analyze"' in response.text
+    assert 'data-analyze-url="/data/-/execute-write/analyze"' in response.text
     assert 'addEventListener("paste"' in response.text
     assert "setupSqlParameterRefresh" in response.text
     assert '<table class="execute-write-analysis">' in response.text
@@ -771,12 +771,12 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
     await ds.invoke_startup()
 
     response = await ds.client.get(
-        "/data/-/execute-write/-/analyze",
+        "/data/-/execute-write/analyze",
         actor={"id": "root"},
         params={"sql": "insert into dogs (name) values (:name)"},
     )
     read_only_response = await ds.client.get(
-        "/data/-/execute-write/-/analyze",
+        "/data/-/execute-write/analyze",
         actor={"id": "root"},
         params={"sql": "select * from dogs where name = :name"},
     )
@@ -818,19 +818,19 @@ async def test_query_parameters_endpoint_uses_get_sql_only():
     await ds.invoke_startup()
 
     response = await ds.client.get(
-        "/data/-/query/-/parameters",
+        "/data/-/query/parameters",
         actor={"id": "root"},
         params={
             "sql": "select * from dogs where name = :name and id = :id",
         },
     )
     permission_denied_response = await ds.client.get(
-        "/data/-/query/-/parameters",
+        "/data/-/query/parameters",
         actor={"id": "not-root"},
         params={"sql": "select * from dogs where name = :name"},
     )
     magic_parameter_response = await ds.client.get(
-        "/data/-/query/-/parameters",
+        "/data/-/query/parameters",
         actor={"id": "root"},
         params={"sql": "select :_actor_id"},
     )

From 4a1a4d7807fb99203b9053b6d270b265df61f0af Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 11:59:49 -0700
Subject: [PATCH 073/386] Query is_trusted and is_private properties

Refs https://github.com/simonw/datasette/issues/2735#issuecomment-4547270516

Diff explanation: https://gist.github.com/simonw/1e4de6c4b041a51968eb273ee96dec1f
---
 datasette/app.py                          |  39 ++--
 datasette/default_actions.py              |   7 -
 datasette/default_permissions/defaults.py | 100 +++++----
 datasette/templates/query_create.html     |   4 +-
 datasette/templates/query_list.html       |  65 +++++-
 datasette/utils/internal_db.py            |   3 +-
 datasette/views/database.py               |  79 ++++---
 docs/authentication.rst                   |  10 -
 docs/internals.rst                        |   3 +-
 queries-plan.md                           |  84 ++++----
 tests/test_queries.py                     | 245 ++++++++++++++++++----
 11 files changed, 421 insertions(+), 218 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 232aa0cf..3329ee7e 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -618,7 +618,8 @@ class Datasette:
                     fragment=query_config.get("fragment"),
                     parameters=query_config.get("params"),
                     is_write=bool(query_config.get("write")),
-                    is_published=bool(query_config.get("is_published")),
+                    is_private=bool(query_config.get("is_private")),
+                    is_trusted=bool(query_config.get("is_trusted", True)),
                     source="config",
                     on_success_message=query_config.get("on_success_message"),
                     on_success_message_sql=query_config.get("on_success_message_sql"),
@@ -1084,7 +1085,8 @@ class Datasette:
             "parameters": parameters,
             "is_write": is_write,
             "write": is_write,
-            "is_published": bool(row["is_published"]),
+            "is_private": bool(row["is_private"]),
+            "is_trusted": bool(row["is_trusted"]),
             "source": row["source"],
             "owner_id": row["owner_id"],
             "on_success_message": options.get("on_success_message"),
@@ -1119,7 +1121,8 @@ class Datasette:
         fragment=None,
         parameters=None,
         is_write=False,
-        is_published=False,
+        is_private=False,
+        is_trusted=False,
         source="plugin",
         owner_id=None,
         on_success_message=None,
@@ -1144,8 +1147,8 @@ class Datasette:
         sql_statement = """
             INSERT INTO queries (
                 database_name, name, sql, title, description, description_html,
-                options, parameters, is_write, is_published, source, owner_id
-            ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+                options, parameters, is_write, is_private, is_trusted, source, owner_id
+            ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
         """
         if replace:
             sql_statement += """
@@ -1157,7 +1160,8 @@ class Datasette:
                     options = excluded.options,
                     parameters = excluded.parameters,
                     is_write = excluded.is_write,
-                    is_published = excluded.is_published,
+                    is_private = excluded.is_private,
+                    is_trusted = excluded.is_trusted,
                     source = excluded.source,
                     owner_id = excluded.owner_id,
                     updated_at = CURRENT_TIMESTAMP
@@ -1174,7 +1178,8 @@ class Datasette:
                 options_json,
                 parameters_json,
                 int(bool(is_write)),
-                int(bool(is_published)),
+                int(bool(is_private)),
+                int(bool(is_trusted)),
                 source,
                 owner_id,
             ],
@@ -1193,7 +1198,8 @@ class Datasette:
         fragment=UNCHANGED,
         parameters=UNCHANGED,
         is_write=UNCHANGED,
-        is_published=UNCHANGED,
+        is_private=UNCHANGED,
+        is_trusted=UNCHANGED,
         source=UNCHANGED,
         owner_id=UNCHANGED,
         on_success_message=UNCHANGED,
@@ -1209,7 +1215,8 @@ class Datasette:
             "description_html": description_html,
             "parameters": parameters,
             "is_write": is_write,
-            "is_published": is_published,
+            "is_private": is_private,
+            "is_trusted": is_trusted,
             "source": source,
             "owner_id": owner_id,
         }
@@ -1227,7 +1234,7 @@ class Datasette:
         for field, value in fields.items():
             if value is UNCHANGED:
                 continue
-            if field in {"is_write", "is_published"}:
+            if field in {"is_write", "is_private", "is_trusted"}:
                 value = int(bool(value))
             elif field == "parameters":
                 value = json.dumps(list(value or []))
@@ -1300,7 +1307,8 @@ class Datasette:
         cursor=None,
         q=None,
         is_write=None,
-        is_published=None,
+        is_private=None,
+        is_trusted=None,
         source=None,
         owner_id=None,
         include_private=False,
@@ -1372,9 +1380,12 @@ class Datasette:
         if is_write is not None:
             where_clauses.append("q.is_write = :query_is_write")
             params["query_is_write"] = int(bool(is_write))
-        if is_published is not None:
-            where_clauses.append("q.is_published = :query_is_published")
-            params["query_is_published"] = int(bool(is_published))
+        if is_private is not None:
+            where_clauses.append("q.is_private = :query_is_private")
+            params["query_is_private"] = int(bool(is_private))
+        if is_trusted is not None:
+            where_clauses.append("q.is_trusted = :query_is_trusted")
+            params["query_is_trusted"] = int(bool(is_trusted))
         if source is not None:
             where_clauses.append("q.source = :query_source")
             params["query_source"] = source
diff --git a/datasette/default_actions.py b/datasette/default_actions.py
index 6787b80e..6a1f77b8 100644
--- a/datasette/default_actions.py
+++ b/datasette/default_actions.py
@@ -68,13 +68,6 @@ def register_actions():
             resource_class=DatabaseResource,
             also_requires="execute-sql",
         ),
-        Action(
-            name="publish-query",
-            abbr="pq",
-            description="Publish saved queries for actors without execute-sql",
-            resource_class=DatabaseResource,
-            also_requires="insert-query",
-        ),
         # Table-level actions (child-level)
         Action(
             name="view-table",
diff --git a/datasette/default_permissions/defaults.py b/datasette/default_permissions/defaults.py
index 58deea01..dfd8d3e9 100644
--- a/datasette/default_permissions/defaults.py
+++ b/datasette/default_permissions/defaults.py
@@ -26,6 +26,32 @@ DEFAULT_ALLOW_ACTIONS = frozenset(
 )
 
 
+def _configured_query_restriction_selects(datasette: "Datasette") -> tuple[list[str], dict]:
+    selects = []
+    params = {}
+    for index, (database_name, db_config) in enumerate(
+        ((datasette.config or {}).get("databases") or {}).items()
+    ):
+        for query_name, query_config in (db_config.get("queries") or {}).items():
+            if isinstance(query_config, dict) and query_config.get("is_private"):
+                continue
+            parent_param = f"query_config_parent_{index}_{len(selects)}"
+            child_param = f"query_config_child_{index}_{len(selects)}"
+            selects.append(
+                f"""
+                SELECT :{parent_param} AS parent, :{child_param} AS child
+                WHERE NOT EXISTS (
+                    SELECT 1 FROM queries
+                    WHERE database_name = :{parent_param}
+                      AND name = :{child_param}
+                )
+                """
+            )
+            params[parent_param] = database_name
+            params[child_param] = query_name
+    return selects, params
+
+
 @hookimpl(specname="permission_resources_sql")
 async def default_allow_sql_check(
     datasette: "Datasette",
@@ -93,61 +119,45 @@ async def default_query_permissions_sql(
     if action != "view-query":
         return None
 
-    execute_sql = await datasette.allowed_resources_sql(
-        action="execute-sql", actor=actor
-    )
-    sql = execute_sql.sql
-    params = {}
-    for key, value in execute_sql.params.items():
-        new_key = f"query_execute_sql_{key}"
-        sql = sql.replace(f":{key}", f":{new_key}")
-        params[new_key] = value
-
-    trusted_writable_sql = ""
+    params = {"query_owner_id": actor_id}
+    rule_sqls = []
     if not datasette.default_deny:
-        trusted_writable_sql = """
-            UNION ALL
+        rule_sqls.append(
+            """
             SELECT database_name AS parent, name AS child, 1 AS allow,
-              'trusted writable query' AS reason
+              'non-private query' AS reason
             FROM queries
-            WHERE is_write = 1
-              AND source IN ('config', 'plugin')
-        """
+            WHERE is_private = 0
+            """
+        )
 
-    user_writable_sql = ""
     if actor_id is not None:
-        params["query_owner_id"] = actor_id
-        user_writable_sql = """
-            UNION ALL
+        rule_sqls.append(
+            """
             SELECT database_name AS parent, name AS child, 1 AS allow,
               'query owner' AS reason
             FROM queries
-            WHERE is_write = 1
-              AND source = 'user'
-              AND owner_id = :query_owner_id
+            WHERE owner_id = :query_owner_id
+            """
+        )
+
+    config_restriction_selects, config_restriction_params = (
+        _configured_query_restriction_selects(datasette)
+    )
+
+    restriction_sqls = [
         """
+        SELECT database_name AS parent, name AS child
+        FROM queries
+        WHERE is_private = 0
+           OR owner_id = :query_owner_id
+        """
+    ]
+    restriction_sqls.extend(config_restriction_selects)
+    params.update(config_restriction_params)
 
     return PermissionSQL(
-        sql=f"""
-        WITH execute_sql_allowed AS (
-            {sql}
-        )
-        SELECT database_name AS parent, name AS child, 1 AS allow,
-          'published query' AS reason
-        FROM queries
-        WHERE is_write = 0
-          AND is_published = 1
-        UNION ALL
-        SELECT q.database_name AS parent, q.name AS child, 1 AS allow,
-          'execute-sql allows query' AS reason
-        FROM queries q
-        JOIN execute_sql_allowed es
-          ON es.parent = q.database_name
-         AND es.child IS NULL
-        WHERE q.is_write = 0
-          AND q.is_published = 0
-        {trusted_writable_sql}
-        {user_writable_sql}
-        """,
+        sql="\nUNION ALL\n".join(rule_sqls) if rule_sqls else None,
+        restriction_sql="\nUNION ALL\n".join(restriction_sqls),
         params=params,
     )
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index 3c027def..686d971e 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -27,9 +27,7 @@
     </p>
     <p><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
     <p><label for="query-parameters">Parameters</label> <input id="query-parameters" name="parameters" type="text" value="{{ parameter_names|join(', ') }}"></p>
-    {% if can_publish %}
-        <p><label><input type="checkbox" name="is_published" value="1"> Published</label></p>
-    {% endif %}
+    <p><label><input type="checkbox" name="is_private" value="1" checked> Private</label></p>
     {% if sql and analysis_is_write %}
         <p><a href="{{ urls.database(database) }}/-/execute-write?{{ {'sql': sql}|urlencode|safe }}">Execute write SQL</a></p>
     {% endif %}
diff --git a/datasette/templates/query_list.html b/datasette/templates/query_list.html
index dbd607ab..25259b3d 100644
--- a/datasette/templates/query_list.html
+++ b/datasette/templates/query_list.html
@@ -73,7 +73,7 @@
     border-collapse: collapse;
     font-size: 0.9rem;
     margin: 0.25rem 0 1rem;
-    min-width: 36rem;
+    min-width: 42rem;
     width: 100%;
 }
 .query-list-results th,
@@ -100,6 +100,16 @@
     font-size: 0.78rem;
     margin: 0.15rem 0 0;
 }
+.query-list-owner {
+    color: #39445a;
+    font-family: var(--font-monospace, monospace);
+    white-space: nowrap;
+}
+.query-list-flags {
+    display: flex;
+    flex-wrap: wrap;
+    gap: 0.3rem;
+}
 .query-list-pill {
     background-color: #eef1f5;
     border: 1px solid #d7dde5;
@@ -116,15 +126,36 @@
     background-color: #fff4db;
     border-color: #e2b64e;
 }
-.query-list-pill-published {
+.query-list-pill-public {
     background-color: #e7f5ec;
     border-color: #9ecfab;
     color: #267a3e;
 }
-.query-list-pill-unpublished {
+.query-list-pill-private {
     background-color: #f7edf0;
     border-color: #dbb8c1;
 }
+.query-list-pill-trusted {
+    background-color: #e7f5ec;
+    border-color: #9ecfab;
+    color: #267a3e;
+}
+.query-list-empty {
+    color: #6b7280;
+}
+.query-list-footnotes {
+    border-top: 1px solid #d7dde5;
+    color: #4f5b6d;
+    font-size: 0.82rem;
+    margin: 0.35rem 0 1rem;
+    padding-top: 0.55rem;
+}
+.query-list-footnotes p {
+    margin: 0.25rem 0;
+}
+.query-list-footnotes .query-list-pill {
+    margin-right: 0.35rem;
+}
 .query-list-pagination a {
     border: 1px solid #007bff;
     border-radius: 0.25rem;
@@ -177,10 +208,10 @@
             <label><input type="radio" name="is_write" value="1"{% if filters.is_write == "1" %} checked{% endif %}> <span>Writable</span></label>
         </fieldset>
         <fieldset class="query-list-filter-group">
-            <legend>Publication</legend>
-            <label><input type="radio" name="is_published" value=""{% if not filters.is_published %} checked{% endif %}> <span>Any</span></label>
-            <label><input type="radio" name="is_published" value="1"{% if filters.is_published == "1" %} checked{% endif %}> <span>Published</span></label>
-            <label><input type="radio" name="is_published" value="0"{% if filters.is_published == "0" %} checked{% endif %}> <span>Unpublished</span></label>
+            <legend>Visibility</legend>
+            <label><input type="radio" name="is_private" value=""{% if not filters.is_private %} checked{% endif %}> <span>Any</span></label>
+            <label><input type="radio" name="is_private" value="0"{% if filters.is_private == "0" %} checked{% endif %}> <span>Normal</span></label>
+            <label><input type="radio" name="is_private" value="1"{% if filters.is_private == "1" %} checked{% endif %}> <span>Private</span></label>
         </fieldset>
     </div>
 </form>
@@ -191,8 +222,8 @@
             <tr>
                 {% if show_database %}<th scope="col">Database</th>{% endif %}
                 <th scope="col">Query</th>
-                <th scope="col">Mode</th>
-                <th scope="col">Publication</th>
+                <th scope="col">Owner</th>
+                <th scope="col">Flags</th>
             </tr>
         </thead>
         <tbody>
@@ -205,12 +236,24 @@
                         <a class="query-list-title" href="{{ urls.query(query.database, query.name) }}{% if query.fragment %}#{{ query.fragment }}{% endif %}" title="{{ query.description or query.sql }}">{{ query.title or query.name }}</a>{% if query.private %} 🔒{% endif %}
                         {% if query.description %}<p class="query-list-description">{{ query.description }}</p>{% endif %}
                     </td>
-                    <td>{% if query.is_write %}<span class="query-list-pill query-list-pill-write">Writable</span>{% else %}<span class="query-list-pill">Read-only</span>{% endif %}</td>
-                    <td>{% if query.is_published %}<span class="query-list-pill query-list-pill-published">Published</span>{% else %}<span class="query-list-pill query-list-pill-unpublished">Unpublished</span>{% endif %}</td>
+                    <td class="query-list-owner">{% if query.owner_id is not none %}{{ query.owner_id }}{% else %}<span class="query-list-empty">-</span>{% endif %}</td>
+                    <td>
+                        <span class="query-list-flags">
+                            {% if query.is_write %}<span class="query-list-pill query-list-pill-write">Writable</span>{% else %}<span class="query-list-pill">Read-only</span>{% endif %}
+                            {% if query.is_private %}<span class="query-list-pill query-list-pill-private">Private</span>{% endif %}
+                            {% if query.is_trusted %}<span class="query-list-pill query-list-pill-trusted">Trusted</span>{% endif %}
+                        </span>
+                    </td>
                 </tr>
             {% endfor %}
         </tbody>
     </table></div>
+    {% if show_private_note or show_trusted_note %}
+        <div class="query-list-footnotes">
+            {% if show_private_note %}<p><span class="query-list-pill query-list-pill-private">Private</span>Only the owning actor can view this query.</p>{% endif %}
+            {% if show_trusted_note %}<p><span class="query-list-pill query-list-pill-trusted">Trusted</span>Execution skips the usual SQL and write permission checks after view-query allows access.</p>{% endif %}
+        </div>
+    {% endif %}
 {% else %}
     <p>No queries found.</p>
 {% endif %}
diff --git a/datasette/utils/internal_db.py b/datasette/utils/internal_db.py
index 9c693b0a..bf172667 100644
--- a/datasette/utils/internal_db.py
+++ b/datasette/utils/internal_db.py
@@ -123,7 +123,8 @@ async def initialize_metadata_tables(db):
             options TEXT NOT NULL DEFAULT '{}',
             parameters TEXT NOT NULL DEFAULT '[]',
             is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
-            is_published INTEGER NOT NULL DEFAULT 0 CHECK (is_published IN (0, 1)),
+            is_private INTEGER NOT NULL DEFAULT 0 CHECK (is_private IN (0, 1)),
+            is_trusted INTEGER NOT NULL DEFAULT 0 CHECK (is_trusted IN (0, 1)),
             source TEXT NOT NULL DEFAULT 'user',
             owner_id TEXT,
             created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 3c660bc7..91e9c350 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -428,7 +428,7 @@ _query_fields = {
     "fragment",
     "parameters",
     "params",
-    "is_published",
+    "is_private",
     "on_success_message",
     "on_success_message_sql",
     "on_success_redirect",
@@ -571,7 +571,7 @@ async def _check_query_name(db, name, *, existing=False):
         raise QueryValidationError("Query name conflicts with a table or view")
 
 
-async def _analyze_user_query(datasette, db, sql, *, actor, is_published):
+async def _analyze_user_query(datasette, db, sql, *, actor):
     if not sql or not isinstance(sql, str):
         raise QueryValidationError("SQL is required")
     derived = _derived_query_parameters(sql)
@@ -583,8 +583,6 @@ async def _analyze_user_query(datasette, db, sql, *, actor, is_published):
 
     is_write = _analysis_is_write(analysis)
     if is_write:
-        if is_published:
-            raise QueryValidationError("Writable queries cannot be published")
         try:
             await datasette.ensure_query_write_permissions(
                 db.name, sql, actor=actor, analysis=analysis
@@ -680,6 +678,26 @@ async def _prepare_execute_write(datasette, db, sql, params, actor):
     return parameter_names, params, analysis
 
 
+async def _ensure_stored_query_execution_permissions(datasette, db, query, actor):
+    if query.get("is_trusted"):
+        return
+    if query.get("write"):
+        await datasette.ensure_permission(
+            action="execute-write-sql",
+            resource=DatabaseResource(db.name),
+            actor=actor,
+        )
+        await datasette.ensure_query_write_permissions(
+            db.name, query["sql"], actor=actor
+        )
+    else:
+        await datasette.ensure_permission(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=actor,
+        )
+
+
 async def _execute_write_analysis_data(datasette, db, sql, actor):
     parameter_names = []
     analysis_rows = []
@@ -752,7 +770,7 @@ async def _inserted_row_url(datasette, db, analysis, cursor):
 
 def _apply_query_data_types(data):
     typed = dict(data)
-    for key in ("hide_sql", "is_published"):
+    for key in ("hide_sql", "is_private"):
         if key in typed:
             typed[key] = _as_bool(typed[key])
     return typed
@@ -769,20 +787,12 @@ async def _prepare_query_create(datasette, request, db, data):
     if await datasette.get_query(db.name, name) is not None:
         raise QueryValidationError("Query already exists")
 
-    is_published = _as_bool(data.get("is_published"))
     is_write, derived, analysis = await _analyze_user_query(
         datasette,
         db,
         data.get("sql"),
         actor=request.actor,
-        is_published=is_published,
     )
-    if is_published and not await datasette.allowed(
-        action="publish-query",
-        resource=DatabaseResource(db.name),
-        actor=request.actor,
-    ):
-        raise QueryValidationError("Permission denied: need publish-query", status=403)
     if not is_write and any(data.get(field) for field in _query_write_fields):
         raise QueryValidationError("Writable query fields require writable SQL")
 
@@ -800,7 +810,8 @@ async def _prepare_query_create(datasette, request, db, data):
         "fragment": data.get("fragment"),
         "parameters": parameters,
         "is_write": is_write,
-        "is_published": is_published,
+        "is_private": _as_bool(data.get("is_private", True)),
+        "is_trusted": False,
         "source": "user",
         "owner_id": _actor_id(request.actor),
         "on_success_message": data.get("on_success_message"),
@@ -819,7 +830,6 @@ async def _prepare_query_update(datasette, request, db, existing, update):
 
     update = _apply_query_data_types(update)
     sql = update.get("sql", existing["sql"])
-    is_published = update.get("is_published", existing["is_published"])
     query_is_write = existing["is_write"]
     derived = _derived_query_parameters(sql)
     parameters = None
@@ -830,19 +840,7 @@ async def _prepare_query_update(datasette, request, db, existing, update):
             db,
             sql,
             actor=request.actor,
-            is_published=is_published,
         )
-    elif is_published and query_is_write:
-        raise QueryValidationError("Writable queries cannot be published")
-    if is_published and not existing["is_published"]:
-        if not await datasette.allowed(
-            action="publish-query",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ):
-            raise QueryValidationError(
-                "Permission denied: need publish-query", status=403
-            )
 
     if "parameters" in update or "params" in update:
         parameters = _coerce_query_parameters(
@@ -864,7 +862,7 @@ async def _prepare_query_update(datasette, request, db, existing, update):
         "fragment": update.get("fragment"),
         "parameters": parameters,
         "is_write": query_is_write,
-        "is_published": is_published,
+        "is_private": update.get("is_private"),
         "on_success_message": update.get("on_success_message"),
         "on_success_message_sql": update.get("on_success_message_sql"),
         "on_success_redirect": update.get("on_success_redirect"),
@@ -1141,8 +1139,8 @@ class QueryListView(BaseView):
                 default=20 if format_ == "html" else 50,
             )
             is_write = _as_optional_bool(request.args.get("is_write"), "is_write")
-            is_published = _as_optional_bool(
-                request.args.get("is_published"), "is_published"
+            is_private = _as_optional_bool(
+                request.args.get("is_private"), "is_private"
             )
         except QueryValidationError as ex:
             return _error([ex.message], ex.status)
@@ -1154,7 +1152,7 @@ class QueryListView(BaseView):
             cursor=request.args.get("_next"),
             q=request.args.get("q") or None,
             is_write=is_write,
-            is_published=is_published,
+            is_private=is_private,
             source=request.args.get("source") or None,
             owner_id=request.args.get("owner_id") or None,
             include_private=True,
@@ -1186,12 +1184,14 @@ class QueryListView(BaseView):
             "next_url": next_url,
             "has_more": page["has_more"],
             "limit": page["limit"],
+            "show_private_note": any(query["is_private"] for query in page["queries"]),
+            "show_trusted_note": any(query["is_trusted"] for query in page["queries"]),
             "query_list_path": query_list_path,
             "show_database": database is None,
             "filters": {
                 "q": request.args.get("q") or "",
                 "is_write": request.args.get("is_write") or "",
-                "is_published": request.args.get("is_published") or "",
+                "is_private": request.args.get("is_private") or "",
                 "source": request.args.get("source") or "",
                 "owner_id": request.args.get("owner_id") or "",
             },
@@ -1255,11 +1255,6 @@ class QueryCreateView(BaseView):
                 "database_color": db.color,
                 "sql": sql,
                 "parameter_names": parameter_names,
-                "can_publish": await self.ds.allowed(
-                    action="publish-query",
-                    resource=DatabaseResource(db.name),
-                    actor=request.actor,
-                ),
                 "analysis_error": analysis_error,
                 "analysis_rows": analysis_rows,
                 "analysis_is_write": bool(
@@ -1435,9 +1430,9 @@ class QueryView(View):
         ):
             raise Forbidden("You do not have permission to view this query")
 
-        if canned_query.get("write") and canned_query.get("source") == "user":
-            await datasette.ensure_query_write_permissions(
-                db.name, canned_query["sql"], actor=request.actor
+        if canned_query.get("write"):
+            await _ensure_stored_query_execution_permissions(
+                datasette, db, canned_query, request.actor
             )
 
         # If database is immutable, return an error
@@ -1558,6 +1553,10 @@ class QueryView(View):
             )
             if not visible:
                 raise Forbidden("You do not have permission to view this query")
+            if not canned_query_write:
+                await _ensure_stored_query_execution_permissions(
+                    datasette, db, canned_query, request.actor
+                )
 
         else:
             await datasette.ensure_permission(
diff --git a/docs/authentication.rst b/docs/authentication.rst
index b6a4cb7e..6e835c8d 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1299,16 +1299,6 @@ insert-query
 
 Actor is allowed to create saved queries in a database.
 
-``resource`` - ``datasette.resources.DatabaseResource(database)``
-    ``database`` is the name of the database (string)
-
-.. _actions_publish_query:
-
-publish-query
--------------
-
-Actor is allowed to publish a saved read-only query so actors without ``execute-sql`` can run it.
-
 ``resource`` - ``datasette.resources.DatabaseResource(database)``
     ``database`` is the name of the database (string)
 
diff --git a/docs/internals.rst b/docs/internals.rst
index b5da7cbf..c76de487 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -2158,7 +2158,8 @@ The internal database schema is as follows:
         options TEXT NOT NULL DEFAULT '{}',
         parameters TEXT NOT NULL DEFAULT '[]',
         is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
-        is_published INTEGER NOT NULL DEFAULT 0 CHECK (is_published IN (0, 1)),
+        is_private INTEGER NOT NULL DEFAULT 0 CHECK (is_private IN (0, 1)),
+        is_trusted INTEGER NOT NULL DEFAULT 0 CHECK (is_trusted IN (0, 1)),
         source TEXT NOT NULL DEFAULT 'user',
         owner_id TEXT,
         created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
diff --git a/queries-plan.md b/queries-plan.md
index 72427df2..f4b8049c 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -13,9 +13,9 @@ Terminology change: these are now "queries", not "canned queries". Legacy code a
 - Internal table name: `queries`.
 - Query definitions should use real columns, not a JSON blob for all options.
 - Query parameter names live in a `parameters` text column as a JSON array. No default values for parameters in this pass.
-- No `queries_database_is_published_idx` index.
-- User-created queries require `execute-sql` and `insert-query` on the database. Writable queries additionally require matching table write permissions discovered by `Database.analyze_sql()`.
-- `publish-query` is the permission for creating or updating a query so users without `execute-sql` can execute it.
+- No separate index is needed for the privacy/trust flags yet.
+- User-created queries require `execute-sql` and `insert-query` on the database. They default to private, and writable queries additionally require matching table write permissions discovered by `Database.analyze_sql()`.
+- Configured queries default to trusted, which means actors who can view them can execute them without also holding `execute-sql` or the relevant write permissions. Config can opt out with `is_trusted: false`.
 - Add `update-query` and `delete-query`, so administrators can manage queries created by other users.
 - Remove the old `canned_queries()` hook from core. If we want compatibility later, build a separate `datasette-old-canned-queries` plugin.
 - Writable user-created queries can be supported using `Database.analyze_sql()`, provided we fail closed when analysis cannot prove the required permissions.
@@ -45,7 +45,8 @@ CREATE TABLE IF NOT EXISTS queries (
     options TEXT NOT NULL DEFAULT '{}',
     parameters TEXT NOT NULL DEFAULT '[]',
     is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
-    is_published INTEGER NOT NULL DEFAULT 0 CHECK (is_published IN (0, 1)),
+    is_private INTEGER NOT NULL DEFAULT 0 CHECK (is_private IN (0, 1)),
+    is_trusted INTEGER NOT NULL DEFAULT 0 CHECK (is_trusted IN (0, 1)),
     source TEXT NOT NULL DEFAULT 'user',
     owner_id TEXT,
     created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
@@ -64,11 +65,12 @@ Column notes:
 - Less common presentation and writable-query behavior lives in `options`, stored as a JSON object. That covers `hide_sql`, `fragment`, `on_success_message`, `on_success_message_sql`, `on_success_redirect`, `on_error_message`, and `on_error_redirect`.
 - `parameters` is a JSON array of parameter names, stored as text. This preserves explicit parameter order, but does not support labels or default values.
 - Existing writable query behavior gets `is_write` as a column. Success/error messages, success/error redirects, and `on_success_message_sql` are stored in `options`.
-- `is_published` only applies to read-only queries. A writable query can still be public through explicit `view-query` permissions, but the "publish for users without execute-sql" shortcut should be read-only.
+- `is_private` means the query is only visible to its owning actor. This is enforced as a permission restriction, so broader `view-query` grants do not expose private rows.
+- `is_trusted` means execution skips the usual `execute-sql` or write-permission checks after `view-query` has allowed access.
 - `source` distinguishes `user`, `config`, and `plugin` rows.
 - `owner_id` is the actor id for user-created rows. It is `NULL` for config/plugin rows.
 
-No separate index is needed on `(database_name, name)` because the primary key already creates one. Do not add a `queries_database_is_published_idx` index for now.
+No separate index is needed on `(database_name, name)` because the primary key already creates one.
 
 `QueryResource.resources_sql()` can become:
 
@@ -104,7 +106,6 @@ Remove the old `canned_queries()` hookspec and all core calls to it. If compatib
 Add core actions:
 
 - `insert-query`, database-level, for creating queries in a database.
-- `publish-query`, database-level, for marking read-only queries as executable by actors who lack `execute-sql`.
 - `update-query`, query-level, for modifying existing query definitions.
 - `delete-query`, query-level, for deleting existing query definitions.
 
@@ -114,17 +115,11 @@ User-created query creation requires:
 - `insert-query` on `DatabaseResource(database)`
 - If analysis shows the query is writable, the table-level write permissions described in the writable query section.
 
-Setting `is_published=1` requires:
-
-- `publish-query` on `DatabaseResource(database)`
-- The query must be read-only according to `Database.analyze_sql()`.
-
 Updating an existing query requires:
 
 - `update-query` on `QueryResource(database, query)` or default owner permission for a user-owned row.
 - If the SQL changes, also require `execute-sql` on the database.
 - If the changed SQL is writable, also require the table-level write permissions described in the writable query section.
-- If `is_published` changes from `0` to `1`, also require `publish-query` on the database.
 
 Deleting an existing query requires:
 
@@ -133,18 +128,18 @@ Deleting an existing query requires:
 Default owner permissions:
 
 - For `source='user' AND owner_id = actor.id`, grant `update-query` and `delete-query`.
-- Do not automatically grant execution if the user no longer has the execution permission described below.
+- For `source='user' AND owner_id = actor.id`, grant `view-query`. If the query is private, restriction SQL ensures no other actor sees it through a broader grant.
 
 ## Executing queries
 
 Default execution rule for read-only queries:
 
-- If `is_published=0`, the actor needs `execute-sql` on the database.
-- If `is_published=1`, the actor can execute the query without `execute-sql`.
+- If `is_trusted=0`, the actor needs `execute-sql` on the database.
+- If `is_trusted=1`, the actor can execute the query without `execute-sql`, provided `view-query` allows access.
 
 Default execution rule for user-created writable queries:
 
-- `is_published` must be `0`.
+- `is_trusted` must be `0`.
 - The actor must have `view-query`.
 - The actor must currently have every write permission required by fresh `Database.analyze_sql()` results for the query SQL.
 
@@ -152,14 +147,14 @@ Implementation:
 
 - Remove `view-query` from the broad `DEFAULT_ALLOW_ACTIONS` set.
 - Replace it with query-aware default `view-query` permission SQL.
-- For `is_published=1 AND is_write=0`, emit a child-level `view-query` allow.
-- For `is_published=0 AND is_write=0`, emit child-level `view-query` allows for queries whose parent database is in the actor's `execute-sql` allowed resources.
-- For `is_write=1 AND source='user'`, emit `view-query` only for the owner or actors with explicit `view-query` permission, then have `QueryView` perform the fresh analysis/table-permission check before execution.
-- For trusted writable queries, preserve current behavior by emitting child-level `view-query` allows for `is_write=1 AND source IN ('config', 'plugin')` when Datasette is not running with `--default-deny`.
+- Emit default `view-query` allows for non-private rows when Datasette is not running with `--default-deny`.
+- Emit default `view-query` allows for the owning actor.
+- Use `restriction_sql` to limit private rows to their owner even when broader `view-query` permissions exist.
+- Have `QueryView` perform the fresh `execute-sql` or table-permission check before execution unless the row has `is_trusted=1`.
 
-For read-only queries this keeps `QueryView` simple: it checks `view-query` for the query resource, and the default permission hook encodes the relationship with `execute-sql`. User-created writable queries need one additional runtime permission check because their required table permissions are derived from fresh SQL analysis.
+For read-only queries this keeps `QueryView` explicit: it checks `view-query` for the query resource, then checks `execute-sql` unless the row is trusted. User-created writable queries need one additional runtime permission check because their required table permissions are derived from fresh SQL analysis.
 
-Explicit deny rules should still be able to block a published query.
+Explicit deny rules should still be able to block a query, and `--default-deny` still blocks trusted queries unless something grants `view-query`.
 
 ## Writable queries
 
@@ -180,7 +175,7 @@ Validation flow for user-created queries:
 1. Derive named parameters from the SQL and pass harmless placeholder values into `db.analyze_sql()` so SQLite can prepare statements with bindings.
 2. If analysis raises a SQLite error, reject the query.
 3. If every table access is `read`, treat the query as read-only and require `execute-sql` plus `insert-query`/`update-query` as described above.
-4. If any table access is `insert`, `update`, or `delete`, treat the query as writable and force `is_published=0`.
+4. If any table access is `insert`, `update`, or `delete`, treat the query as writable and force `is_trusted=0`.
 5. Reject writable user-created queries that access a database other than the database they are being saved against, until `analyze_sql()` can reliably map attached SQLite schemas back to Datasette database names.
 6. For every write access returned by analysis, require the corresponding permission on `TableResource(access.database, access.table)`:
    - `insert` -> `insert-row`
@@ -200,7 +195,7 @@ Fail closed cases for user-created writable queries:
 - Analysis reports any write operation that cannot be mapped to a Datasette table resource.
 - Analysis reports writes outside the target database.
 - The actor lacks any required table write permission.
-- `is_published=1` is requested.
+- `is_trusted=1` is requested through the user-facing API.
 
 This gives us writable user-created queries without letting `execute-sql` alone become a path to create arbitrary write endpoints.
 
@@ -225,7 +220,7 @@ Create request:
     "sql": "select * from customers order by revenue desc limit 20",
     "title": "Top customers",
     "description": "Highest revenue customers",
-    "is_published": false,
+    "is_private": true,
     "parameters": ["region"]
   }
 }
@@ -242,7 +237,8 @@ Successful create returns `201` and the created query definition:
     "sql": "select * from customers order by revenue desc limit 20",
     "title": "Top customers",
     "description": "Highest revenue customers",
-    "is_published": false,
+    "is_private": true,
+    "is_trusted": false,
     "parameters": ["region"]
   }
 }
@@ -254,7 +250,7 @@ Update request, imitating `RowUpdateView`:
 {
   "update": {
     "title": "Top customers by revenue",
-    "is_published": true
+    "is_private": false
   },
   "return": true
 }
@@ -270,7 +266,8 @@ Successful update returns `{"ok": true}` by default. With `"return": true`, retu
     "name": "top_customers",
     "sql": "select * from customers order by revenue desc limit 20",
     "title": "Top customers by revenue",
-    "is_published": true
+    "is_private": false,
+    "is_trusted": false
   }
 }
 ```
@@ -317,7 +314,8 @@ await datasette.add_query(
     fragment=None,
     parameters=None,
     is_write=False,
-    is_published=False,
+    is_private=False,
+    is_trusted=False,
     source="plugin",
     owner_id=None,
     on_success_message=None,
@@ -340,7 +338,8 @@ await datasette.update_query(
     fragment=UNCHANGED,
     parameters=UNCHANGED,
     is_write=UNCHANGED,
-    is_published=UNCHANGED,
+    is_private=UNCHANGED,
+    is_trusted=UNCHANGED,
     source=UNCHANGED,
     owner_id=UNCHANGED,
     on_success_message=UNCHANGED,
@@ -360,7 +359,8 @@ await datasette.list_queries(
     cursor=None,
     q=None,
     is_write=None,
-    is_published=None,
+    is_private=None,
+    is_trusted=None,
     source=None,
     owner_id=None,
 )
@@ -382,15 +382,13 @@ For column-backed fields, `None` should write SQL `NULL`. For option fields, `No
 
 Implementation detail: build the `UPDATE` statement dynamically from fields whose value is not `UNCHANGED`, validate non-nullable fields before writing, and update `updated_at` whenever at least one field changes.
 
-The read methods should reconstruct the existing dictionary shape used by query execution and templates, with `name`, `sql`, display fields, write fields, `params`, `is_published`, `owner_id`, and `source`. `parameters` should be returned as the decoded JSON array and exposed as `params` where existing query execution code expects that key. Option values should be unpacked from the `options` JSON object and returned as the same top-level keys accepted by `add_query()` and `update_query()`.
+The read methods should reconstruct the existing dictionary shape used by query execution and templates, with `name`, `sql`, display fields, write fields, `params`, `is_private`, `is_trusted`, `owner_id`, and `source`. `parameters` should be returned as the decoded JSON array and exposed as `params` where existing query execution code expects that key. Option values should be unpacked from the `options` JSON object and returned as the same top-level keys accepted by `add_query()` and `update_query()`.
 
 ## Query page save UI
 
 On `/{database}/-/query`, if the actor has both `execute-sql` and `insert-query`, show a save control for valid read-only SQL. That page already executes read-only arbitrary SQL, so the first UI can stay read-only even though the JSON API can accept writable SQL after `Database.analyze_sql()` validation.
 
-The save form should call `POST /{database}/-/queries/insert` and default to `is_published=false`.
-
-If the actor also has `publish-query`, include a publish control. The UI copy should make it clear that publishing allows people without arbitrary SQL permission to run this query.
+The save form should call `POST /{database}/-/queries/insert` and default to `is_private=true`.
 
 On `/{database}`, show a preview of the first 5 visible queries using `list_queries(..., limit=5)`. If the page has `has_more`, show a link to `/{database}/-/queries` rather than rendering hundreds or thousands of query links inline. The full `/{database}/-/queries` page provides search, filters, and cursor pagination. The global `/-/queries` page reuses the same interface and shows the database for each query.
 
@@ -403,7 +401,7 @@ This page should require `execute-sql` and `insert-query` to access. It should p
 - Read-only
 - Writable
 
-Read-only mode can share the same fields as the arbitrary SQL save flow: name, title, description, parameters, and optional published status if the actor has `publish-query`.
+Read-only mode can share the same fields as the arbitrary SQL save flow: name, title, description, parameters, and privacy status.
 
 Writable mode should always run `Database.analyze_sql()` and show an analysis panel before saving:
 
@@ -413,7 +411,7 @@ Writable mode should always run `Database.analyze_sql()` and show an analysis pa
 - whether the actor has that permission
 - source, when the operation comes from a trigger or view
 
-The Save button should be disabled until analysis succeeds and every required table write permission is allowed. Writable mode should not show a publish control, because user-created writable queries cannot be published.
+The Save button should be disabled until analysis succeeds and every required table write permission is allowed.
 
 The existing edit-SQL flow from query pages can continue to point back to arbitrary SQL. A later enhancement can add "update this query" when the actor owns it or has `update-query`.
 
@@ -427,14 +425,16 @@ The existing edit-SQL flow from query pages can continue to point back to arbitr
 - `QueryResource.resources_sql()` returns rows from `queries`.
 - Database page and `/-/jump` list queries from the internal DB.
 - `view-query` is no longer globally default-allowed; default query permissions come from the query-aware hook.
-- Unpublished read-only query requires `execute-sql` to execute.
-- Published read-only query can be executed without `execute-sql`.
-- Setting `is_published=true` requires `publish-query`.
+- Private query is only visible to its owner, even when a broader `view-query` rule applies.
+- Non-trusted read-only query requires `execute-sql` to execute.
+- Trusted read-only query can be executed without `execute-sql` after `view-query` passes.
+- Config queries default to trusted and can opt out with `is_trusted: false`.
+- User API rejects client-supplied `is_trusted`.
 - User-created query requires both `execute-sql` and `insert-query`.
 - User-created writable query creation uses `Database.analyze_sql()` and requires matching `insert-row`, `update-row`, and/or `delete-row` permissions for every reported write access.
 - `/{database}/-/queries/-/create` provides the writable-query authoring UI with an analysis panel and disabled save until all required write permissions pass.
 - User-created writable query execution re-runs `Database.analyze_sql()` and re-checks table write permissions.
-- User-created writable query cannot be published.
+- User-created writable query cannot be trusted through the user API.
 - Query update uses `POST /{database}/{query}/-/update` with an `{"update": {...}}` body.
 - Query delete uses `POST /{database}/{query}/-/delete`.
 - There are no `PATCH` or HTTP `DELETE` routes for query management.
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 57920584..c97b5733 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -15,7 +15,6 @@ async def add_numbered_queries(ds, database, count):
             "select {} as query_number".format(i),
             title="Demo query {:02d}".format(i),
             description="Seeded demo query number {:02d}".format(i),
-            is_published=True,
             source="user",
             owner_id="root",
         )
@@ -44,7 +43,8 @@ async def test_queries_internal_table_schema():
         "options",
         "parameters",
         "is_write",
-        "is_published",
+        "is_private",
+        "is_trusted",
         "source",
         "owner_id",
         "created_at",
@@ -67,7 +67,7 @@ async def test_add_get_and_remove_query():
         hide_sql=True,
         fragment="chart",
         parameters=["region"],
-        is_published=True,
+        is_trusted=True,
         source="user",
         owner_id="alice",
     )
@@ -100,7 +100,8 @@ async def test_add_get_and_remove_query():
         "parameters": ["region"],
         "is_write": False,
         "write": False,
-        "is_published": True,
+        "is_private": False,
+        "is_trusted": True,
         "source": "user",
         "owner_id": "alice",
         "on_success_message": None,
@@ -161,7 +162,8 @@ async def test_update_query_only_updates_provided_fields():
     assert query["params"] == []
     assert query["on_success_redirect"] is None
     assert query["sql"] == "select 1"
-    assert query["is_published"] is False
+    assert query["is_private"] is False
+    assert query["is_trusted"] is False
     options_row = (
         await ds.get_internal_database().execute(
             """
@@ -208,7 +210,8 @@ async def test_config_queries_imported_to_internal_table():
         "parameters": ["name"],
         "is_write": False,
         "write": False,
-        "is_published": False,
+        "is_private": False,
+        "is_trusted": True,
         "source": "config",
         "owner_id": None,
         "on_success_message": None,
@@ -232,30 +235,171 @@ async def test_query_resources_come_from_internal_table():
 
 
 @pytest.mark.asyncio
-async def test_unpublished_query_requires_execute_sql_but_published_does_not():
-    ds = Datasette(memory=True, settings={"default_allow_sql": False})
+async def test_default_deny_blocks_view_query_even_for_trusted_query():
+    ds = Datasette(memory=True, default_deny=True)
     ds.add_memory_database("query_permissions", name="data")
     await ds.invoke_startup()
-    await ds.add_query("data", "unpublished", "select 1", is_published=False)
-    await ds.add_query("data", "published", "select 1", is_published=True)
+    await ds.add_query("data", "trusted", "select 1", is_trusted=True)
 
     assert not await ds.allowed(
-        action="execute-sql",
-        resource=DatabaseResource("data"),
+        action="view-query",
+        resource=QueryResource("data", "trusted"),
         actor=None,
     )
+
+
+@pytest.mark.asyncio
+async def test_private_query_restriction_blocks_broad_view_query_permission():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-query": {"id": "*"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("private_query_permissions", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "private_report",
+        "select 1",
+        is_private=True,
+        source="user",
+        owner_id="alice",
+    )
+    await ds.add_query(
+        "data",
+        "shared_report",
+        "select 2",
+        is_private=False,
+        source="user",
+        owner_id="alice",
+    )
+
+    assert await ds.allowed(
+        action="view-query",
+        resource=QueryResource("data", "private_report"),
+        actor={"id": "alice"},
+    )
     assert not await ds.allowed(
         action="view-query",
-        resource=QueryResource("data", "unpublished"),
-        actor=None,
+        resource=QueryResource("data", "private_report"),
+        actor={"id": "bob"},
     )
     assert await ds.allowed(
         action="view-query",
-        resource=QueryResource("data", "published"),
-        actor=None,
+        resource=QueryResource("data", "shared_report"),
+        actor={"id": "bob"},
     )
 
 
+@pytest.mark.asyncio
+async def test_config_query_restriction_does_not_override_private_internal_query():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.add_memory_database("private_query_with_config_name", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "private_report",
+        "select 1",
+        is_private=True,
+        source="user",
+        owner_id="alice",
+    )
+    ds.config = {
+        "databases": {
+            "data": {
+                "permissions": {"view-query": {"id": "*"}},
+                "queries": {"private_report": {"sql": "select 2"}},
+            }
+        }
+    }
+
+    assert not await ds.allowed(
+        action="view-query",
+        resource=QueryResource("data", "private_report"),
+        actor={"id": "bob"},
+    )
+
+
+@pytest.mark.asyncio
+async def test_untrusted_shared_query_execution_requires_execute_sql():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "viewer"},
+                        "view-query": {"id": "viewer"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("untrusted_query_execution", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "shared_report",
+        "select 1 as one",
+        is_private=False,
+        is_trusted=False,
+        source="user",
+        owner_id="alice",
+    )
+
+    denied = await ds.client.get("/data/shared_report.json", actor={"id": "viewer"})
+    assert denied.status_code == 403
+
+    ds.config["databases"]["data"]["permissions"]["execute-sql"] = {"id": "viewer"}
+    allowed = await ds.client.get("/data/shared_report.json", actor={"id": "viewer"})
+    assert allowed.status_code == 200
+    assert allowed.json()["rows"] == [{"one": 1}]
+
+
+@pytest.mark.asyncio
+async def test_config_queries_are_trusted_by_default_but_can_opt_out():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-query": {"id": "viewer"},
+                    },
+                    "queries": {
+                        "trusted_report": {"sql": "select 1 as one"},
+                        "untrusted_report": {
+                            "sql": "select 2 as two",
+                            "is_trusted": False,
+                        },
+                    },
+                }
+            }
+        },
+    )
+    ds.add_memory_database("trusted_query_config", name="data")
+    await ds.invoke_startup()
+
+    trusted = await ds.client.get("/data/trusted_report.json", actor={"id": "viewer"})
+    untrusted = await ds.client.get(
+        "/data/untrusted_report.json", actor={"id": "viewer"}
+    )
+
+    assert trusted.status_code == 200
+    assert trusted.json()["rows"] == [{"one": 1}]
+    assert untrusted.status_code == 403
+
+
 @pytest.mark.asyncio
 async def test_database_page_query_preview_is_limited():
     ds = Datasette(memory=True)
@@ -281,7 +425,6 @@ async def test_query_actions_are_registered():
 
     assert ds.get_action("execute-write-sql").resource_class is DatabaseResource
     assert ds.get_action("insert-query").resource_class is DatabaseResource
-    assert ds.get_action("publish-query").resource_class is DatabaseResource
     assert ds.get_action("update-query").resource_class is QueryResource
     assert ds.get_action("delete-query").resource_class is QueryResource
 
@@ -430,21 +573,33 @@ async def test_query_list_search_filter_and_html():
         "private_query",
         "select 'private'",
         title="Private query",
-        is_published=False,
+        is_private=True,
         source="user",
         owner_id="root",
     )
+    await ds.add_query(
+        "data",
+        "trusted_query",
+        "select 'trusted'",
+        title="Trusted query",
+        is_trusted=True,
+        source="config",
+    )
 
     html_response = await ds.client.get(
         "/data/-/queries?q=02",
         actor={"id": "root"},
     )
+    flags_response = await ds.client.get(
+        "/data/-/queries",
+        actor={"id": "root"},
+    )
     json_response = await ds.client.get(
         "/data/-/queries.json?q=02",
         actor={"id": "root"},
     )
     filtered_response = await ds.client.get(
-        "/data/-/queries.json?is_published=0",
+        "/data/-/queries.json?is_private=1",
         actor={"id": "root"},
     )
 
@@ -453,7 +608,22 @@ async def test_query_list_search_filter_and_html():
     assert "Demo query 01" not in html_response.text
     assert 'class="query-list-results"' in html_response.text
     assert "<legend>Mode</legend>" in html_response.text
-    assert 'type="radio" name="is_published" value="1"' in html_response.text
+    assert 'type="radio" name="is_private" value="1"' in html_response.text
+    assert "Only the owning actor can view this query." not in html_response.text
+    assert (
+        "Execution skips the usual SQL and write permission checks"
+        not in html_response.text
+    )
+    assert flags_response.status_code == 200
+    assert '<th scope="col">Owner</th>' in flags_response.text
+    assert '<th scope="col">Flags</th>' in flags_response.text
+    assert '<th scope="col">Mode</th>' not in flags_response.text
+    assert 'class="query-list-owner">root</td>' in flags_response.text
+    assert 'class="query-list-pill">Read-only</span>' in flags_response.text
+    assert 'class="query-list-pill query-list-pill-private">Private</span>' in flags_response.text
+    assert 'class="query-list-pill query-list-pill-trusted">Trusted</span>' in flags_response.text
+    assert "Only the owning actor can view this query." in flags_response.text
+    assert "Execution skips the usual SQL and write permission checks" in flags_response.text
     assert json_response.json()["queries"][0]["name"] == "demo_query_02"
     assert [query["name"] for query in filtered_response.json()["queries"]] == [
         "private_query"
@@ -491,7 +661,6 @@ async def test_global_query_list_api_and_html():
         "alpha_first",
         "select 1",
         title="Alpha first",
-        is_published=True,
         source="user",
         owner_id="root",
     )
@@ -500,7 +669,6 @@ async def test_global_query_list_api_and_html():
         "alpha_second",
         "select 2",
         title="Alpha second",
-        is_published=True,
         source="user",
         owner_id="root",
     )
@@ -509,7 +677,6 @@ async def test_global_query_list_api_and_html():
         "beta_first",
         "select 3",
         title="Beta first",
-        is_published=True,
         source="user",
         owner_id="root",
     )
@@ -548,7 +715,7 @@ async def test_global_query_list_api_and_html():
 
 
 @pytest.mark.asyncio
-async def test_query_insert_api_publish_requires_publish_query():
+async def test_query_insert_api_rejects_is_trusted():
     ds = Datasette(
         memory=True,
         default_deny=True,
@@ -564,17 +731,17 @@ async def test_query_insert_api_publish_requires_publish_query():
             }
         },
     )
-    ds.add_memory_database("query_publish_api", name="data")
+    ds.add_memory_database("query_trusted_api", name="data")
     await ds.invoke_startup()
 
     response = await ds.client.post(
         "/data/-/queries/insert",
         actor={"id": "writer"},
-        json={"query": {"name": "public", "sql": "select 1", "is_published": True}},
+        json={"query": {"name": "trusted", "sql": "select 1", "is_trusted": True}},
     )
 
-    assert response.status_code == 403
-    assert response.json()["errors"] == ["Permission denied: need publish-query"]
+    assert response.status_code == 400
+    assert response.json()["errors"] == ["Invalid keys: is_trusted"]
 
 
 @pytest.mark.asyncio
@@ -599,24 +766,10 @@ async def test_query_insert_api_creates_writable_query():
     assert response.status_code == 201
     query = response.json()["query"]
     assert query["is_write"] is True
-    assert query["is_published"] is False
+    assert query["is_private"] is True
+    assert query["is_trusted"] is False
     assert query["parameters"] == ["name"]
 
-    bad_response = await ds.client.post(
-        "/data/-/queries/insert",
-        actor={"id": "root"},
-        json={
-            "query": {
-                "name": "published_insert",
-                "sql": "insert into dogs (name) values (:name)",
-                "is_published": True,
-            }
-        },
-    )
-
-    assert bad_response.status_code == 400
-    assert bad_response.json()["errors"] == ["Writable queries cannot be published"]
-
 
 @pytest.mark.asyncio
 async def test_query_update_and_delete_api():
@@ -1103,6 +1256,10 @@ async def test_user_writable_query_execution_rechecks_table_permissions():
         config={
             "databases": {
                 "data": {
+                    "permissions": {
+                        "view-database": {"id": ["alice", "bob"]},
+                        "execute-write-sql": {"id": ["alice", "bob"]},
+                    },
                     "tables": {
                         "dogs": {
                             "permissions": {

From 1cd162e9da48b924c289ec9343e9d801b51a89f9 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 12:07:30 -0700
Subject: [PATCH 074/386] Removed some no-longer-necessary code, simplified

view-query is back in the default allow actions now. We have
other mechanisms that work for controlling visibility, and
the fact that queries default to running with the permissions
of the actor makes this safe.
---
 datasette/default_permissions/defaults.py | 55 +++--------------------
 tests/test_permissions.py                 |  9 +++-
 tests/test_queries.py                     | 39 ++++++++++++++++
 3 files changed, 51 insertions(+), 52 deletions(-)

diff --git a/datasette/default_permissions/defaults.py b/datasette/default_permissions/defaults.py
index dfd8d3e9..ed0a6d66 100644
--- a/datasette/default_permissions/defaults.py
+++ b/datasette/default_permissions/defaults.py
@@ -21,37 +21,12 @@ DEFAULT_ALLOW_ACTIONS = frozenset(
         "view-database",
         "view-database-download",
         "view-table",
+        "view-query",
         "execute-sql",
     }
 )
 
 
-def _configured_query_restriction_selects(datasette: "Datasette") -> tuple[list[str], dict]:
-    selects = []
-    params = {}
-    for index, (database_name, db_config) in enumerate(
-        ((datasette.config or {}).get("databases") or {}).items()
-    ):
-        for query_name, query_config in (db_config.get("queries") or {}).items():
-            if isinstance(query_config, dict) and query_config.get("is_private"):
-                continue
-            parent_param = f"query_config_parent_{index}_{len(selects)}"
-            child_param = f"query_config_child_{index}_{len(selects)}"
-            selects.append(
-                f"""
-                SELECT :{parent_param} AS parent, :{child_param} AS child
-                WHERE NOT EXISTS (
-                    SELECT 1 FROM queries
-                    WHERE database_name = :{parent_param}
-                      AND name = :{child_param}
-                )
-                """
-            )
-            params[parent_param] = database_name
-            params[child_param] = query_name
-    return selects, params
-
-
 @hookimpl(specname="permission_resources_sql")
 async def default_allow_sql_check(
     datasette: "Datasette",
@@ -121,16 +96,6 @@ async def default_query_permissions_sql(
 
     params = {"query_owner_id": actor_id}
     rule_sqls = []
-    if not datasette.default_deny:
-        rule_sqls.append(
-            """
-            SELECT database_name AS parent, name AS child, 1 AS allow,
-              'non-private query' AS reason
-            FROM queries
-            WHERE is_private = 0
-            """
-        )
-
     if actor_id is not None:
         rule_sqls.append(
             """
@@ -141,23 +106,13 @@ async def default_query_permissions_sql(
             """
         )
 
-    config_restriction_selects, config_restriction_params = (
-        _configured_query_restriction_selects(datasette)
-    )
-
-    restriction_sqls = [
-        """
+    return PermissionSQL(
+        sql="\nUNION ALL\n".join(rule_sqls) if rule_sqls else None,
+        restriction_sql="""
         SELECT database_name AS parent, name AS child
         FROM queries
         WHERE is_private = 0
            OR owner_id = :query_owner_id
-        """
-    ]
-    restriction_sqls.extend(config_restriction_selects)
-    params.update(config_restriction_params)
-
-    return PermissionSQL(
-        sql="\nUNION ALL\n".join(rule_sqls) if rule_sqls else None,
-        restriction_sql="\nUNION ALL\n".join(restriction_sqls),
+        """,
         params=params,
     )
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 22f294bb..4f342d8f 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -937,16 +937,20 @@ async def test_permissions_in_config(
     updated_config = copy.deepcopy(previous_config)
     updated_config.update(config)
     perms_ds.config = updated_config
+    await perms_ds.apply_queries_config()
     try:
         # Convert old-style resource to Resource object
-        from datasette.resources import DatabaseResource, TableResource
+        from datasette.resources import DatabaseResource, QueryResource, TableResource
 
         resource_obj = None
         if resource:
             if isinstance(resource, str):
                 resource_obj = DatabaseResource(database=resource)
             elif isinstance(resource, tuple) and len(resource) == 2:
-                resource_obj = TableResource(database=resource[0], table=resource[1])
+                if action == "view-query":
+                    resource_obj = QueryResource(database=resource[0], query=resource[1])
+                else:
+                    resource_obj = TableResource(database=resource[0], table=resource[1])
 
         result = await perms_ds.allowed(
             action=action, resource=resource_obj, actor=actor
@@ -956,6 +960,7 @@ async def test_permissions_in_config(
             assert result == expected_result
     finally:
         perms_ds.config = previous_config
+        await perms_ds.apply_queries_config()
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_queries.py b/tests/test_queries.py
index c97b5733..dde57dea 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -248,6 +248,45 @@ async def test_default_deny_blocks_view_query_even_for_trusted_query():
     )
 
 
+@pytest.mark.asyncio
+async def test_view_query_default_allow_still_respects_private_restriction():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("default_view_query_permissions", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "private_report",
+        "select 1",
+        is_private=True,
+        source="user",
+        owner_id="alice",
+    )
+    await ds.add_query(
+        "data",
+        "shared_report",
+        "select 2",
+        is_private=False,
+        source="user",
+        owner_id="alice",
+    )
+
+    assert await ds.allowed(
+        action="view-query",
+        resource=QueryResource("data", "shared_report"),
+        actor=None,
+    )
+    assert await ds.allowed(
+        action="view-query",
+        resource=QueryResource("data", "private_report"),
+        actor={"id": "alice"},
+    )
+    assert not await ds.allowed(
+        action="view-query",
+        resource=QueryResource("data", "private_report"),
+        actor={"id": "bob"},
+    )
+
+
 @pytest.mark.asyncio
 async def test_private_query_restriction_blocks_broad_view_query_permission():
     ds = Datasette(

From 1ac4265ffd295ea62008b13b3e37af96f5450be4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 12:12:59 -0700
Subject: [PATCH 075/386] Require permissions for untrusted stored query
 execution, refs #2735

---
 datasette/views/database.py |  7 +++----
 docs/authentication.rst     |  2 +-
 queries-plan.md             |  8 +++-----
 tests/test_queries.py       | 12 ++++++++++--
 4 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index 91e9c350..bd939d87 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -1430,10 +1430,9 @@ class QueryView(View):
         ):
             raise Forbidden("You do not have permission to view this query")
 
-        if canned_query.get("write"):
-            await _ensure_stored_query_execution_permissions(
-                datasette, db, canned_query, request.actor
-            )
+        await _ensure_stored_query_execution_permissions(
+            datasette, db, canned_query, request.actor
+        )
 
         # If database is immutable, return an error
         if not db.is_mutable:
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 6e835c8d..453aaa19 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1285,7 +1285,7 @@ Actor is allowed to view a table (or view) page, e.g. https://latest.datasette.i
 view-query
 ----------
 
-Actor is allowed to view (and execute) a saved query page, e.g. https://latest.datasette.io/fixtures/pragma_cache_size - this includes executing :ref:`canned_queries_writable`.
+Actor is allowed to view a saved query page, e.g. https://latest.datasette.io/fixtures/pragma_cache_size. Executing an untrusted saved query also requires ``execute-sql`` or the relevant write permissions; trusted saved queries can execute with ``view-query`` alone.
 
 ``resource`` - ``datasette.resources.QueryResource(database, query)``
     ``database`` is the name of the database (string)
diff --git a/queries-plan.md b/queries-plan.md
index f4b8049c..da6b7c92 100644
--- a/queries-plan.md
+++ b/queries-plan.md
@@ -25,7 +25,7 @@ Terminology change: these are now "queries", not "canned queries". Legacy code a
 - Query definitions currently come from `datasette.yaml` or the `canned_queries()` plugin hook.
 - `Datasette.get_canned_queries(database_name, actor)` calls that hook every time it needs query definitions.
 - `QueryResource.resources_sql()` currently enumerates databases and calls the hook for each one, because permissions and `/-/jump` need query resources.
-- Query pages execute if the actor has `view-query` for `QueryResource(database, query)`.
+- Query pages are visible if the actor has `view-query` for `QueryResource(database, query)`. Executing an untrusted stored query also checks `execute-sql` or the relevant write permissions.
 - Arbitrary SQL executes if the actor has `execute-sql` for `DatabaseResource(database)`.
 
 The main performance and architecture win is making query resource enumeration a direct SQL query against the internal database.
@@ -145,9 +145,7 @@ Default execution rule for user-created writable queries:
 
 Implementation:
 
-- Remove `view-query` from the broad `DEFAULT_ALLOW_ACTIONS` set.
-- Replace it with query-aware default `view-query` permission SQL.
-- Emit default `view-query` allows for non-private rows when Datasette is not running with `--default-deny`.
+- Keep `view-query` in the broad `DEFAULT_ALLOW_ACTIONS` set, so saved queries remain visible by default in all-public Datasette.
 - Emit default `view-query` allows for the owning actor.
 - Use `restriction_sql` to limit private rows to their owner even when broader `view-query` permissions exist.
 - Have `QueryView` perform the fresh `execute-sql` or table-permission check before execution unless the row has `is_trusted=1`.
@@ -424,7 +422,7 @@ The existing edit-SQL flow from query pages can continue to point back to arbitr
 - The old `canned_queries()` hook is no longer called by core.
 - `QueryResource.resources_sql()` returns rows from `queries`.
 - Database page and `/-/jump` list queries from the internal DB.
-- `view-query` is no longer globally default-allowed; default query permissions come from the query-aware hook.
+- `view-query` remains globally default-allowed, with `restriction_sql` narrowing private queries to their owner.
 - Private query is only visible to its owner, even when a broader `view-query` rule applies.
 - Non-trusted read-only query requires `execute-sql` to execute.
 - Trusted read-only query can be executed without `execute-sql` after `view-query` passes.
diff --git a/tests/test_queries.py b/tests/test_queries.py
index dde57dea..997f8b39 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -395,8 +395,16 @@ async def test_untrusted_shared_query_execution_requires_execute_sql():
         owner_id="alice",
     )
 
-    denied = await ds.client.get("/data/shared_report.json", actor={"id": "viewer"})
-    assert denied.status_code == 403
+    denied_get = await ds.client.get(
+        "/data/shared_report.json", actor={"id": "viewer"}
+    )
+    denied_post = await ds.client.post(
+        "/data/shared_report",
+        actor={"id": "viewer"},
+        data={},
+    )
+    assert denied_get.status_code == 403
+    assert denied_post.status_code == 403
 
     ds.config["databases"]["data"]["permissions"]["execute-sql"] = {"id": "viewer"}
     allowed = await ds.client.get("/data/shared_report.json", actor={"id": "viewer"})

From 866852eff603c219b8bf7d13f2a69b5ff032fa67 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 12:46:18 -0700
Subject: [PATCH 076/386] Clarifying comments

---
 datasette/default_permissions/defaults.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/datasette/default_permissions/defaults.py b/datasette/default_permissions/defaults.py
index ed0a6d66..32ad4ef1 100644
--- a/datasette/default_permissions/defaults.py
+++ b/datasette/default_permissions/defaults.py
@@ -80,6 +80,7 @@ async def default_query_permissions_sql(
     if action in {"update-query", "delete-query"}:
         if actor_id is None:
             return None
+        # Query owner can update/delete query
         return PermissionSQL(
             sql="""
             SELECT database_name AS parent, name AS child, 1 AS allow,
@@ -97,15 +98,15 @@ async def default_query_permissions_sql(
     params = {"query_owner_id": actor_id}
     rule_sqls = []
     if actor_id is not None:
-        rule_sqls.append(
-            """
+        # Query owner can view-query
+        rule_sqls.append("""
             SELECT database_name AS parent, name AS child, 1 AS allow,
               'query owner' AS reason
             FROM queries
             WHERE owner_id = :query_owner_id
-            """
-        )
+            """)
 
+    # restriction_sql enforces private queries ONLY visible to owner
     return PermissionSQL(
         sql="\nUNION ALL\n".join(rule_sqls) if rule_sqls else None,
         restriction_sql="""

From 71c76e38534378cbce8576771238a788feccf3ad Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 13:08:19 -0700
Subject: [PATCH 077/386] Better faceting on /-/queries

Ref https://github.com/simonw/datasette/pull/2741#issuecomment-4548321815
---
 datasette/app.py                    |  69 +++++++++++++++++
 datasette/templates/query_list.html |  94 +++++++++++++----------
 datasette/views/database.py         |  99 +++++++++++++++++++++++-
 tests/test_permissions.py           |   8 +-
 tests/test_queries.py               | 115 +++++++++++++++++++++++++---
 5 files changed, 330 insertions(+), 55 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 3329ee7e..1acdfcd8 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -1298,6 +1298,75 @@ class Datasette:
         )
         return self._query_row_to_dict(rows.first())
 
+    async def count_queries(
+        self,
+        database=None,
+        *,
+        actor=None,
+        q=None,
+        is_write=None,
+        is_private=None,
+        is_trusted=None,
+        source=None,
+        owner_id=None,
+    ):
+        allowed_sql, allowed_params = await self.allowed_resources_sql(
+            action="view-query",
+            actor=actor,
+            parent=database,
+        )
+        params = dict(allowed_params)
+        where_clauses = []
+        if database is not None:
+            params["query_database"] = database
+            where_clauses.append("q.database_name = :query_database")
+
+        if q:
+            where_clauses.append("""
+                (
+                    q.name LIKE :query_search
+                    OR q.title LIKE :query_search
+                    OR q.description LIKE :query_search
+                    OR q.sql LIKE :query_search
+                )
+                """)
+            params["query_search"] = "%{}%".format(q)
+        if is_write is not None:
+            where_clauses.append("q.is_write = :query_is_write")
+            params["query_is_write"] = int(bool(is_write))
+        if is_private is not None:
+            where_clauses.append("q.is_private = :query_is_private")
+            params["query_is_private"] = int(bool(is_private))
+        if is_trusted is not None:
+            where_clauses.append("q.is_trusted = :query_is_trusted")
+            params["query_is_trusted"] = int(bool(is_trusted))
+        if source is not None:
+            where_clauses.append("q.source = :query_source")
+            params["query_source"] = source
+        if owner_id is not None:
+            where_clauses.append("q.owner_id = :query_owner_id")
+            params["query_owner_id"] = owner_id
+
+        row = (
+            await self.get_internal_database().execute(
+                """
+                SELECT count(*) AS count
+                FROM queries q
+                JOIN (
+                    {allowed_sql}
+                ) allowed
+                  ON allowed.parent = q.database_name
+                 AND allowed.child = q.name
+                WHERE {where}
+                """.format(
+                    allowed_sql=allowed_sql,
+                    where=" AND ".join(where_clauses) or "1 = 1",
+                ),
+                params,
+            )
+        ).first()
+        return row["count"]
+
     async def list_queries(
         self,
         database=None,
diff --git a/datasette/templates/query_list.html b/datasette/templates/query_list.html
index 25259b3d..fa4859b1 100644
--- a/datasette/templates/query_list.html
+++ b/datasette/templates/query_list.html
@@ -9,7 +9,7 @@
     max-width: 64rem;
 }
 .query-list-filters {
-    margin: 0.5rem 0 1rem;
+    margin: 0.5rem 0 0.75rem;
 }
 .query-list-search {
     align-items: center;
@@ -32,43 +32,63 @@
     line-height: 1.1;
     padding: 0.35rem 0.65rem;
 }
-.query-list-filter-groups {
+.query-list-facets {
     align-items: flex-start;
     display: flex;
     flex-wrap: wrap;
-    gap: 0.8rem 1.4rem;
+    gap: 1rem 1.6rem;
+    margin: 0 0 1rem;
 }
-.query-list-filter-group {
-    border: 0;
+.query-list-facet {
+    margin: 0;
+}
+.query-list-facet h2 {
+    font-size: 0.9rem;
+    line-height: 1.2;
+    margin: 0 0 0.35rem;
+}
+.query-list-facet ul {
     display: flex;
     flex-wrap: wrap;
     gap: 0.35rem;
     margin: 0;
-    min-width: 0;
     padding: 0;
+    list-style: none;
 }
-.query-list-filter-group legend {
-    font-weight: 700;
-    margin: 0 0.45rem 0 0;
-    padding: 0;
-}
-.query-list-filter-group label {
+.query-list-facet-link,
+.query-list-facet-link:link,
+.query-list-facet-link:visited,
+.query-list-facet-link:hover,
+.query-list-facet-link:focus,
+.query-list-facet-link:active {
     align-items: center;
     border: 1px solid #c8d1dc;
     border-radius: 0.25rem;
-    cursor: pointer;
+    color: #39445a;
     display: inline-flex;
     font-size: 0.82rem;
-    gap: 0.3rem;
+    gap: 0.4rem;
     line-height: 1.1;
     padding: 0.35rem 0.55rem;
+    text-decoration: none;
 }
-.query-list-filter-group input {
-    margin: 0;
+.query-list-facet-link:hover {
+    border-color: #7ca5c8;
+    color: #1f5d85;
 }
-.query-list-filter-group input:checked + span {
+.query-list-facet-link-active {
+    background-color: #edf6fb;
+    border-color: #6d9fc0;
     font-weight: 700;
 }
+.query-list-facet-disabled {
+    color: #7b8794;
+    cursor: default;
+}
+.query-list-facet-count {
+    color: #4f5b6d;
+    font-variant-numeric: tabular-nums;
+}
 .query-list-results {
     border-collapse: collapse;
     font-size: 0.9rem;
@@ -169,15 +189,6 @@
     .query-list-search input[type=search] {
         max-width: none;
     }
-    .query-list-filter-group {
-        display: block;
-    }
-    .query-list-filter-group legend {
-        margin-bottom: 0.3rem;
-    }
-    .query-list-filter-group label {
-        margin: 0 0.25rem 0.35rem 0;
-    }
 }
 </style>
 {% endblock %}
@@ -198,24 +209,27 @@
     <p class="query-list-search">
         <label for="query-search">Search</label>
         <input id="query-search" type="search" name="q" value="{{ filters.q }}">
+        {% if filters.is_write %}<input type="hidden" name="is_write" value="{{ filters.is_write }}">{% endif %}
+        {% if filters.is_private %}<input type="hidden" name="is_private" value="{{ filters.is_private }}">{% endif %}
+        {% if filters.source %}<input type="hidden" name="source" value="{{ filters.source }}">{% endif %}
+        {% if filters.owner_id %}<input type="hidden" name="owner_id" value="{{ filters.owner_id }}">{% endif %}
         <button type="submit">Search</button>
     </p>
-    <div class="query-list-filter-groups">
-        <fieldset class="query-list-filter-group">
-            <legend>Mode</legend>
-            <label><input type="radio" name="is_write" value=""{% if not filters.is_write %} checked{% endif %}> <span>Any</span></label>
-            <label><input type="radio" name="is_write" value="0"{% if filters.is_write == "0" %} checked{% endif %}> <span>Read-only</span></label>
-            <label><input type="radio" name="is_write" value="1"{% if filters.is_write == "1" %} checked{% endif %}> <span>Writable</span></label>
-        </fieldset>
-        <fieldset class="query-list-filter-group">
-            <legend>Visibility</legend>
-            <label><input type="radio" name="is_private" value=""{% if not filters.is_private %} checked{% endif %}> <span>Any</span></label>
-            <label><input type="radio" name="is_private" value="0"{% if filters.is_private == "0" %} checked{% endif %}> <span>Normal</span></label>
-            <label><input type="radio" name="is_private" value="1"{% if filters.is_private == "1" %} checked{% endif %}> <span>Private</span></label>
-        </fieldset>
-    </div>
 </form>
 
+<nav class="query-list-facets" aria-label="Query filters">
+    {% for facet in facets %}
+        <section class="query-list-facet">
+            <h2>{{ facet.title }}</h2>
+            <ul>
+                {% for item in facet["items"] %}
+                    <li>{% if item.href %}<a class="query-list-facet-link{% if item.active %} query-list-facet-link-active{% endif %}" href="{{ item.href }}"{% if item.active %} aria-current="true"{% endif %}>{% else %}<span class="query-list-facet-link query-list-facet-disabled">{% endif %}<span>{{ item.label }}</span><span class="query-list-facet-count">{{ item.count }}</span>{% if item.href %}</a>{% else %}</span>{% endif %}</li>
+                {% endfor %}
+            </ul>
+        </section>
+    {% endfor %}
+</nav>
+
 {% if queries %}
     <div class="table-wrapper"><table class="query-list-results">
         <thead>
diff --git a/datasette/views/database.py b/datasette/views/database.py
index bd939d87..2e77d36b 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -1121,6 +1121,21 @@ class QueryParametersView(BaseView):
         return _block_framing(Response.json({"ok": True, "parameters": parameters}))
 
 
+def _query_list_url(path, query_string, *, set_args=None, remove_args=None):
+    set_args = set_args or {}
+    remove_args = set(remove_args or ())
+    skip = set(set_args) | remove_args | {"_next"}
+    pairs = [
+        (key, value)
+        for key, value in parse_qsl(query_string, keep_blank_values=True)
+        if key not in skip
+    ]
+    for key, value in set_args.items():
+        if value not in (None, ""):
+            pairs.append((key, value))
+    return path + (("?" + urlencode(pairs)) if pairs else "")
+
+
 class QueryListView(BaseView):
     name = "query-list"
 
@@ -1139,9 +1154,7 @@ class QueryListView(BaseView):
                 default=20 if format_ == "html" else 50,
             )
             is_write = _as_optional_bool(request.args.get("is_write"), "is_write")
-            is_private = _as_optional_bool(
-                request.args.get("is_private"), "is_private"
-            )
+            is_private = _as_optional_bool(request.args.get("is_private"), "is_private")
         except QueryValidationError as ex:
             return _error([ex.message], ex.status)
 
@@ -1173,6 +1186,80 @@ class QueryListView(BaseView):
                 urlencode(pairs),
             )
 
+        current_filters = {
+            "actor": request.actor,
+            "q": request.args.get("q") or None,
+            "is_write": is_write,
+            "is_private": is_private,
+            "source": request.args.get("source") or None,
+            "owner_id": request.args.get("owner_id") or None,
+        }
+
+        async def facet_count(field, value):
+            if current_filters[field] is not None and current_filters[field] != value:
+                return 0
+            filters = dict(current_filters)
+            filters[field] = value
+            return await self.ds.count_queries(database, **filters)
+
+        def facet_href(field, value):
+            if current_filters[field] == value:
+                return _query_list_url(
+                    query_list_path,
+                    request.query_string,
+                    remove_args=[field],
+                )
+            if current_filters[field] is not None:
+                return None
+            return _query_list_url(
+                query_list_path,
+                request.query_string,
+                set_args={field: str(int(value))},
+            )
+
+        async def facet_item(label, field, value):
+            count = await facet_count(field, value)
+            active = current_filters[field] == value
+            if not active and not count:
+                return None
+            return {
+                "label": label,
+                "count": count,
+                "href": facet_href(field, value) if active or count else None,
+                "active": active,
+            }
+
+        async def facet_items(items):
+            return [
+                item
+                for item in [
+                    await facet_item(label, field, value)
+                    for label, field, value in items
+                ]
+                if item is not None
+            ]
+
+        facets = [
+            {
+                "title": "Mode",
+                "items": await facet_items(
+                    [
+                        ("Read-only", "is_write", False),
+                        ("Writable", "is_write", True),
+                    ]
+                ),
+            },
+            {
+                "title": "Visibility",
+                "items": await facet_items(
+                    [
+                        ("Not private", "is_private", False),
+                        ("Private", "is_private", True),
+                    ]
+                ),
+            },
+        ]
+
         data = {
             "ok": True,
             "database": database,
@@ -1188,6 +1275,7 @@ class QueryListView(BaseView):
             "show_trusted_note": any(query["is_trusted"] for query in page["queries"]),
             "query_list_path": query_list_path,
             "show_database": database is None,
+            "facets": facets,
             "filters": {
                 "q": request.args.get("q") or "",
                 "is_write": request.args.get("is_write") or "",
@@ -1715,6 +1803,9 @@ class QueryView(View):
                 }
             )
             metadata = await datasette.get_database_metadata(database)
+            if canned_query:
+                metadata = dict(canned_query)
+                metadata.pop("source", None)
 
             renderers = {}
             for key, (_, can_render) in datasette.renderers.items():
@@ -1865,7 +1956,7 @@ class QueryView(View):
                             )
                         ),
                         show_hide_hidden=markupsafe.Markup(show_hide_hidden),
-                        metadata=canned_query or metadata,
+                        metadata=metadata,
                         alternate_url_json=alternate_url_json,
                         select_templates=[
                             f"{'*' if template_name == template.name else ''}{template_name}"
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 4f342d8f..eb6cee9f 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -948,9 +948,13 @@ async def test_permissions_in_config(
                 resource_obj = DatabaseResource(database=resource)
             elif isinstance(resource, tuple) and len(resource) == 2:
                 if action == "view-query":
-                    resource_obj = QueryResource(database=resource[0], query=resource[1])
+                    resource_obj = QueryResource(
+                        database=resource[0], query=resource[1]
+                    )
                 else:
-                    resource_obj = TableResource(database=resource[0], table=resource[1])
+                    resource_obj = TableResource(
+                        database=resource[0], table=resource[1]
+                    )
 
         result = await perms_ds.allowed(
             action=action, resource=resource_obj, actor=actor
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 997f8b39..36f7107a 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -395,9 +395,7 @@ async def test_untrusted_shared_query_execution_requires_execute_sql():
         owner_id="alice",
     )
 
-    denied_get = await ds.client.get(
-        "/data/shared_report.json", actor={"id": "viewer"}
-    )
+    denied_get = await ds.client.get("/data/shared_report.json", actor={"id": "viewer"})
     denied_post = await ds.client.post(
         "/data/shared_report",
         actor={"id": "viewer"},
@@ -608,6 +606,27 @@ async def test_query_list_and_definition_api():
     assert definition_response.json()["query"]["title"] == "Demo query 01"
 
 
+@pytest.mark.asyncio
+async def test_query_page_does_not_show_internal_source():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("query_page_source", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "stored_report",
+        "select 1 as one",
+        title="Stored report",
+        source="user",
+        owner_id="root",
+    )
+
+    response = await ds.client.get("/data/stored_report", actor={"id": "root"})
+
+    assert response.status_code == 200
+    assert "Stored report" in response.text
+    assert "Data source:" not in response.text
+
+
 @pytest.mark.asyncio
 async def test_query_list_search_filter_and_html():
     ds = Datasette(memory=True)
@@ -632,6 +651,15 @@ async def test_query_list_search_filter_and_html():
         is_trusted=True,
         source="config",
     )
+    await ds.add_query(
+        "data",
+        "writable_query",
+        "insert into dogs (name) values (:name)",
+        title="Writable query",
+        is_write=True,
+        source="user",
+        owner_id="root",
+    )
 
     html_response = await ds.client.get(
         "/data/-/queries?q=02",
@@ -649,13 +677,21 @@ async def test_query_list_search_filter_and_html():
         "/data/-/queries.json?is_private=1",
         actor={"id": "root"},
     )
+    filtered_write_response = await ds.client.get(
+        "/data/-/queries?is_write=1",
+        actor={"id": "root"},
+    )
+    filtered_private_response = await ds.client.get(
+        "/data/-/queries?is_private=1",
+        actor={"id": "root"},
+    )
 
     assert html_response.status_code == 200
     assert "Demo query 02" in html_response.text
     assert "Demo query 01" not in html_response.text
     assert 'class="query-list-results"' in html_response.text
-    assert "<legend>Mode</legend>" in html_response.text
-    assert 'type="radio" name="is_private" value="1"' in html_response.text
+    assert 'class="query-list-facets"' in html_response.text
+    assert 'type="radio"' not in html_response.text
     assert "Only the owning actor can view this query." not in html_response.text
     assert (
         "Execution skips the usual SQL and write permission checks"
@@ -667,14 +703,75 @@ async def test_query_list_search_filter_and_html():
     assert '<th scope="col">Mode</th>' not in flags_response.text
     assert 'class="query-list-owner">root</td>' in flags_response.text
     assert 'class="query-list-pill">Read-only</span>' in flags_response.text
-    assert 'class="query-list-pill query-list-pill-private">Private</span>' in flags_response.text
-    assert 'class="query-list-pill query-list-pill-trusted">Trusted</span>' in flags_response.text
+    assert (
+        'class="query-list-pill query-list-pill-write">Writable</span>'
+        in flags_response.text
+    )
+    assert (
+        'class="query-list-pill query-list-pill-private">Private</span>'
+        in flags_response.text
+    )
+    assert (
+        'class="query-list-pill query-list-pill-trusted">Trusted</span>'
+        in flags_response.text
+    )
+    assert (
+        'href="/data/-/queries?is_write=0"><span>Read-only</span><span class="query-list-facet-count">5</span>'
+        in flags_response.text
+    )
+    assert (
+        'href="/data/-/queries?is_write=1"><span>Writable</span><span class="query-list-facet-count">1</span>'
+        in flags_response.text
+    )
+    assert (
+        'href="/data/-/queries?is_private=0"><span>Not private</span><span class="query-list-facet-count">5</span>'
+        in flags_response.text
+    )
+    assert (
+        'href="/data/-/queries?is_private=1"><span>Private</span><span class="query-list-facet-count">1</span>'
+        in flags_response.text
+    )
     assert "Only the owning actor can view this query." in flags_response.text
-    assert "Execution skips the usual SQL and write permission checks" in flags_response.text
+    assert (
+        "Execution skips the usual SQL and write permission checks"
+        in flags_response.text
+    )
     assert json_response.json()["queries"][0]["name"] == "demo_query_02"
     assert [query["name"] for query in filtered_response.json()["queries"]] == [
         "private_query"
     ]
+    assert "Writable query" in filtered_write_response.text
+    assert "Demo query 01" not in filtered_write_response.text
+    assert (
+        'query-list-facet-link query-list-facet-link-active" href="/data/-/queries"'
+        in filtered_write_response.text
+    )
+    assert (
+        '<span class="query-list-facet-link query-list-facet-disabled"><span>Read-only</span><span class="query-list-facet-count">0</span></span>'
+        not in filtered_write_response.text
+    )
+    assert (
+        'href="/data/-/queries?is_write=1&amp;is_private=0"><span>Not private</span><span class="query-list-facet-count">1</span>'
+        in filtered_write_response.text
+    )
+    assert (
+        '<span class="query-list-facet-link query-list-facet-disabled"><span>Private</span><span class="query-list-facet-count">0</span></span>'
+        not in filtered_write_response.text
+    )
+    assert "Private query" in filtered_private_response.text
+    assert "Demo query 01" not in filtered_private_response.text
+    assert (
+        'href="/data/-/queries?is_private=1&amp;is_write=0"><span>Read-only</span><span class="query-list-facet-count">1</span>'
+        in filtered_private_response.text
+    )
+    assert (
+        '<span class="query-list-facet-link query-list-facet-disabled"><span>Writable</span><span class="query-list-facet-count">0</span></span>'
+        not in filtered_private_response.text
+    )
+    assert (
+        '<span class="query-list-facet-link query-list-facet-disabled"><span>Not private</span><span class="query-list-facet-count">0</span></span>'
+        not in filtered_private_response.text
+    )
 
 
 @pytest.mark.asyncio
@@ -1313,7 +1410,7 @@ async def test_user_writable_query_execution_rechecks_table_permissions():
                                 "insert-row": {"id": "alice"},
                             }
                         }
-                    }
+                    },
                 }
             }
         },

From 0fcaa5792ba73143661515af0088d7e5d968e96c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 13:12:07 -0700
Subject: [PATCH 078/386] Style query operations on create query

Made it consistent with the SQL write page.
---
 .../_execute_write_analysis_styles.html       | 37 +++++++++++++++++++
 datasette/templates/execute_write.html        | 36 +-----------------
 datasette/templates/query_create.html         | 19 +++++-----
 tests/test_queries.py                         |  6 ++-
 4 files changed, 52 insertions(+), 46 deletions(-)
 create mode 100644 datasette/templates/_execute_write_analysis_styles.html

diff --git a/datasette/templates/_execute_write_analysis_styles.html b/datasette/templates/_execute_write_analysis_styles.html
new file mode 100644
index 00000000..f20e67b2
--- /dev/null
+++ b/datasette/templates/_execute_write_analysis_styles.html
@@ -0,0 +1,37 @@
+<style>
+.execute-write-analysis {
+    border-collapse: collapse;
+    font-size: 0.9rem;
+    margin: 0.25rem 0 1rem;
+    min-width: 44rem;
+}
+.execute-write-analysis th,
+.execute-write-analysis td {
+    border-bottom: 1px solid #d7dde5;
+    padding: 0.45rem 0.7rem;
+    text-align: left;
+    vertical-align: top;
+}
+.execute-write-analysis th {
+    background-color: #edf6fb;
+    border-top: 1px solid #d7dde5;
+    color: #39445a;
+    font-weight: 700;
+}
+.execute-write-analysis tbody tr:nth-child(even) {
+    background-color: rgba(39, 104, 144, 0.05);
+}
+.execute-write-analysis code {
+    background: transparent;
+    font-size: 0.9em;
+    white-space: nowrap;
+}
+.execute-write-analysis-allowed {
+    color: #267a3e;
+    font-weight: 700;
+}
+.execute-write-analysis-denied {
+    color: #b00020;
+    font-weight: 700;
+}
+</style>
diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 46f58c3b..414d4af7 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -40,42 +40,8 @@
     border-radius: 0.25rem;
     min-width: 13rem;
 }
-.execute-write-analysis {
-    border-collapse: collapse;
-    font-size: 0.9rem;
-    margin: 0.25rem 0 1rem;
-    min-width: 44rem;
-}
-.execute-write-analysis th,
-.execute-write-analysis td {
-    border-bottom: 1px solid #d7dde5;
-    padding: 0.45rem 0.7rem;
-    text-align: left;
-    vertical-align: top;
-}
-.execute-write-analysis th {
-    background-color: #edf6fb;
-    border-top: 1px solid #d7dde5;
-    color: #39445a;
-    font-weight: 700;
-}
-.execute-write-analysis tbody tr:nth-child(even) {
-    background-color: rgba(39, 104, 144, 0.05);
-}
-.execute-write-analysis code {
-    background: transparent;
-    font-size: 0.9em;
-    white-space: nowrap;
-}
-.execute-write-analysis-allowed {
-    color: #267a3e;
-    font-weight: 700;
-}
-.execute-write-analysis-denied {
-    color: #b00020;
-    font-weight: 700;
-}
 </style>
+{% include "_execute_write_analysis_styles.html" %}
 {% include "_sql_parameter_styles.html" %}
 {% endblock %}
 
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index 686d971e..2d8a9122 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -5,6 +5,7 @@
 {% block extra_head %}
 {{- super() -}}
 {% include "_codemirror.html" %}
+{% include "_execute_write_analysis_styles.html" %}
 {% endblock %}
 
 {% block body_class %}query-create db-{{ database|to_css_class }}{% endblock %}
@@ -32,30 +33,28 @@
         <p><a href="{{ urls.database(database) }}/-/execute-write?{{ {'sql': sql}|urlencode|safe }}">Execute write SQL</a></p>
     {% endif %}
 
-    <h2>Analysis</h2>
+    <h2>Query operations</h2>
     {% if analysis_error %}
         <p class="message-error">{{ analysis_error }}</p>
     {% elif analysis_rows %}
-        <div class="table-wrapper"><table>
+        <div class="table-wrapper"><table class="execute-write-analysis">
             <thead>
                 <tr>
                     <th scope="col">Operation</th>
                     <th scope="col">Database</th>
                     <th scope="col">Table</th>
-                    <th scope="col">required permission</th>
+                    <th scope="col">Required permission</th>
                     <th scope="col">Allowed</th>
-                    <th scope="col">Source</th>
                 </tr>
             </thead>
             <tbody>
                 {% for row in analysis_rows %}
                     <tr>
-                        <td>{{ row.operation }}</td>
-                        <td>{{ row.database }}</td>
-                        <td>{{ row.table }}</td>
-                        <td>{{ row.required_permission }}</td>
-                        <td>{% if row.allowed is none %}{% elif row.allowed %}yes{% else %}no{% endif %}</td>
-                        <td>{{ row.source or "" }}</td>
+                        <td><code>{{ row.operation }}</code></td>
+                        <td><code>{{ row.database }}</code></td>
+                        <td><code>{{ row.table }}</code></td>
+                        <td>{% if row.required_permission %}<code>{{ row.required_permission }}</code>{% endif %}</td>
+                        <td>{% if row.allowed is none %}{% elif row.allowed %}<span class="execute-write-analysis-allowed">yes</span>{% else %}<span class="execute-write-analysis-denied">no</span>{% endif %}</td>
                     </tr>
                 {% endfor %}
             </tbody>
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 36f7107a..c27c23da 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -998,7 +998,11 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
     assert "Create query" in create_response.text
     assert "Read-only" in create_response.text
     assert "Writable" in create_response.text
-    assert "required permission" in create_response.text
+    assert "<h2>Query operations</h2>" in create_response.text
+    assert '<table class="execute-write-analysis">' in create_response.text
+    assert '<th scope="col">Required permission</th>' in create_response.text
+    assert '<th scope="col">Source</th>' not in create_response.text
+    assert "<td><code>read</code></td>" in create_response.text
     assert query_response.status_code == 200
     assert "Save query" in query_response.text
     assert "/data/-/queries/-/create?sql=select+%2A+from+dogs" in query_response.text

From 70b23ff4a55528083512fab96aa50725f415cbe4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 13:47:24 -0700
Subject: [PATCH 079/386] Tweaked save query link

---
 datasette/templates/query.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/datasette/templates/query.html b/datasette/templates/query.html
index f74d21f1..1900bd31 100644
--- a/datasette/templates/query.html
+++ b/datasette/templates/query.html
@@ -66,7 +66,7 @@
         {% if not hide_sql %}<button id="sql-format" type="button" hidden>Format SQL</button>{% endif %}
         <input type="submit" value="Run SQL"{% if canned_query_write and db_is_immutable %} disabled{% endif %}>
         {{ show_hide_hidden }}
-        {% if save_query_url %}<a href="{{ save_query_url }}" class="save-query">Save query</a>{% endif %}
+        {% if save_query_url %}<a href="{{ save_query_url }}" class="save-query">Save this query</a>{% endif %}
         {% if canned_query and edit_sql_url %}<a href="{{ edit_sql_url }}" class="canned-query-edit-sql">Edit SQL</a>{% endif %}
     </p>
 </form>

From eb7c25c57cf914629c08eaa477d0709b0f41efeb Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 13:48:40 -0700
Subject: [PATCH 080/386] Major redesign of create saved query UI

https://github.com/simonw/datasette/pull/2741#issuecomment-4548707129
---
 datasette/app.py                              |   6 +-
 datasette/static/app.css                      |   4 +
 .../_execute_write_analysis_scripts.html      | 111 +++++++
 .../_execute_write_analysis_styles.html       |   4 +
 .../templates/_sql_parameter_scripts.html     |  17 +-
 datasette/templates/execute_write.html        |  88 +-----
 datasette/templates/query_create.html         | 296 +++++++++++++++---
 datasette/views/database.py                   | 181 ++++++++---
 tests/test_queries.py                         | 170 +++++++++-
 9 files changed, 705 insertions(+), 172 deletions(-)
 create mode 100644 datasette/templates/_execute_write_analysis_scripts.html

diff --git a/datasette/app.py b/datasette/app.py
index 1acdfcd8..8936b099 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -50,7 +50,7 @@ from .views.database import (
     ExecuteWriteView,
     TableCreateView,
     QueryView,
-    QueryCreateView,
+    QueryCreateAnalyzeView,
     QueryDeleteView,
     QueryDefinitionView,
     GlobalQueryListView,
@@ -2820,8 +2820,8 @@ class Datasette:
             r"/(?P<database>[^\/\.]+)/-/queries(\.(?P<format>json))?$",
         )
         add_route(
-            QueryCreateView.as_view(self),
-            r"/(?P<database>[^\/\.]+)/-/queries/-/create$",
+            QueryCreateAnalyzeView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/queries/analyze$",
         )
         add_route(
             QueryInsertView.as_view(self),
diff --git a/datasette/static/app.css b/datasette/static/app.css
index c21d0dc4..4f4db133 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1414,6 +1414,10 @@ svg.dropdown-menu-icon {
     position: relative;
     top: 1px;
 }
+.save-query {
+    display: inline-block;
+    margin-left: 0.45em;
+}
 
 .blob-download {
     display: block;
diff --git a/datasette/templates/_execute_write_analysis_scripts.html b/datasette/templates/_execute_write_analysis_scripts.html
new file mode 100644
index 00000000..a19bae13
--- /dev/null
+++ b/datasette/templates/_execute_write_analysis_scripts.html
@@ -0,0 +1,111 @@
+<script>
+window.datasetteSqlAnalysis = (() => {
+  if (
+    window.datasetteSqlAnalysis &&
+    window.datasetteSqlAnalysis.renderAnalysis
+  ) {
+    return window.datasetteSqlAnalysis;
+  }
+
+  function appendCodeCell(row, value, emptyText) {
+    const cell = document.createElement("td");
+    if (value) {
+      const code = document.createElement("code");
+      code.textContent = value;
+      cell.appendChild(code);
+    } else if (emptyText) {
+      appendNotApplicable(cell);
+    }
+    row.appendChild(cell);
+  }
+
+  function appendNotApplicable(cell) {
+    const notApplicable = document.createElement("span");
+    notApplicable.className = "execute-write-analysis-na";
+    notApplicable.textContent = "n/a";
+    cell.appendChild(notApplicable);
+  }
+
+  function renderAnalysis(section, data) {
+    if (!section) {
+      return;
+    }
+    section.replaceChildren();
+    if (data.has_sql === false) {
+      section.hidden = true;
+      return;
+    }
+    section.hidden = false;
+
+    const heading = document.createElement("h2");
+    heading.textContent = "Query operations";
+    section.appendChild(heading);
+
+    if (data.analysis_error) {
+      const error = document.createElement("p");
+      error.className = "message-error";
+      error.textContent = data.analysis_error;
+      section.appendChild(error);
+      return;
+    }
+
+    const rows = data.analysis_rows || [];
+    if (!rows.length) {
+      const empty = document.createElement("p");
+      empty.textContent =
+        "Analysis will show each affected table and required permission.";
+      section.appendChild(empty);
+      return;
+    }
+
+    const wrapper = document.createElement("div");
+    wrapper.className = "table-wrapper";
+    const table = document.createElement("table");
+    table.className = "execute-write-analysis";
+    const thead = document.createElement("thead");
+    const headerRow = document.createElement("tr");
+    [
+      "Operation",
+      "Database",
+      "Table",
+      "Required permission",
+      "Allowed",
+    ].forEach((label) => {
+      const th = document.createElement("th");
+      th.scope = "col";
+      th.textContent = label;
+      headerRow.appendChild(th);
+    });
+    thead.appendChild(headerRow);
+    table.appendChild(thead);
+
+    const tbody = document.createElement("tbody");
+    rows.forEach((analysisRow) => {
+      const row = document.createElement("tr");
+      appendCodeCell(row, analysisRow.operation);
+      appendCodeCell(row, analysisRow.database);
+      appendCodeCell(row, analysisRow.table);
+      appendCodeCell(row, analysisRow.required_permission, "n/a");
+
+      const allowedCell = document.createElement("td");
+      if (analysisRow.allowed !== null && analysisRow.allowed !== undefined) {
+        const allowed = document.createElement("span");
+        allowed.className = analysisRow.allowed
+          ? "execute-write-analysis-allowed"
+          : "execute-write-analysis-denied";
+        allowed.textContent = analysisRow.allowed ? "yes" : "no";
+        allowedCell.appendChild(allowed);
+      } else {
+        appendNotApplicable(allowedCell);
+      }
+      row.appendChild(allowedCell);
+      tbody.appendChild(row);
+    });
+    table.appendChild(tbody);
+    wrapper.appendChild(table);
+    section.appendChild(wrapper);
+  }
+
+  return { renderAnalysis };
+})();
+</script>
diff --git a/datasette/templates/_execute_write_analysis_styles.html b/datasette/templates/_execute_write_analysis_styles.html
index f20e67b2..165cfe9f 100644
--- a/datasette/templates/_execute_write_analysis_styles.html
+++ b/datasette/templates/_execute_write_analysis_styles.html
@@ -34,4 +34,8 @@
     color: #b00020;
     font-weight: 700;
 }
+.execute-write-analysis-na {
+    color: #687386;
+    font-style: italic;
+}
 </style>
diff --git a/datasette/templates/_sql_parameter_scripts.html b/datasette/templates/_sql_parameter_scripts.html
index 68e46069..159a141c 100644
--- a/datasette/templates/_sql_parameter_scripts.html
+++ b/datasette/templates/_sql_parameter_scripts.html
@@ -215,9 +215,10 @@ window.datasetteSqlParameters = (() => {
     if (!form) {
       return null;
     }
+    const shouldRenderParameters = options.renderParameters !== false;
     const section =
       options.section || form.querySelector("[data-sql-parameters-section]");
-    if (!section) {
+    if (shouldRenderParameters && !section) {
       return null;
     }
     const manager = {
@@ -225,12 +226,16 @@ window.datasetteSqlParameters = (() => {
       section,
       allowExpand:
         options.allowExpand === undefined
-          ? section.dataset.allowExpand === "1"
+          ? section
+            ? section.dataset.allowExpand === "1"
+            : false
           : options.allowExpand,
       parameterState: new Map(),
     };
-    bindParameterControls(manager);
-    syncParameterState(manager);
+    if (section) {
+      bindParameterControls(manager);
+      syncParameterState(manager);
+    }
 
     const url = options.url || form.dataset.parametersUrl;
     let refreshTimer = null;
@@ -254,7 +259,9 @@ window.datasetteSqlParameters = (() => {
         if (!response.ok) {
           throw new Error((data.errors || [response.statusText]).join("; "));
         }
-        renderParameters(manager, data.parameters || []);
+        if (shouldRenderParameters) {
+          renderParameters(manager, data.parameters || []);
+        }
         if (options.onData) {
           options.onData(data, manager);
         }
diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 414d4af7..7a627a7a 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -131,6 +131,7 @@ if (executeWriteSqlInput && !executeWriteSqlInput.value) {
 
 {% include "_codemirror_foot.html" %}
 {% include "_sql_parameter_scripts.html" %}
+{% include "_execute_write_analysis_scripts.html" %}
 
 <script>
 window.addEventListener("DOMContentLoaded", () => {
@@ -140,101 +141,18 @@ window.addEventListener("DOMContentLoaded", () => {
     ? form.querySelector("[data-execute-write-submit]")
     : null;
 
-  function appendCodeCell(row, value) {
-    const cell = document.createElement("td");
-    if (value) {
-      const code = document.createElement("code");
-      code.textContent = value;
-      cell.appendChild(code);
-    }
-    row.appendChild(cell);
-  }
-
-  function renderExecuteWriteAnalysis(data) {
-    if (!analysisSection) {
-      return;
-    }
-    analysisSection.replaceChildren();
-
-    const heading = document.createElement("h2");
-    heading.textContent = "Query operations";
-    analysisSection.appendChild(heading);
-
-    if (data.analysis_error) {
-      const error = document.createElement("p");
-      error.className = "message-error";
-      error.textContent = data.analysis_error;
-      analysisSection.appendChild(error);
-      return;
-    }
-
-    const rows = data.analysis_rows || [];
-    if (!rows.length) {
-      const empty = document.createElement("p");
-      empty.textContent =
-        "Analysis will show each affected table and required permission.";
-      analysisSection.appendChild(empty);
-      return;
-    }
-
-    const wrapper = document.createElement("div");
-    wrapper.className = "table-wrapper";
-    const table = document.createElement("table");
-    table.className = "execute-write-analysis";
-    const thead = document.createElement("thead");
-    const headerRow = document.createElement("tr");
-    [
-      "Operation",
-      "Database",
-      "Table",
-      "Required permission",
-      "Allowed",
-    ].forEach((label) => {
-      const th = document.createElement("th");
-      th.scope = "col";
-      th.textContent = label;
-      headerRow.appendChild(th);
-    });
-    thead.appendChild(headerRow);
-    table.appendChild(thead);
-
-    const tbody = document.createElement("tbody");
-    rows.forEach((analysisRow) => {
-      const row = document.createElement("tr");
-      appendCodeCell(row, analysisRow.operation);
-      appendCodeCell(row, analysisRow.database);
-      appendCodeCell(row, analysisRow.table);
-      appendCodeCell(row, analysisRow.required_permission);
-
-      const allowedCell = document.createElement("td");
-      if (analysisRow.allowed !== null && analysisRow.allowed !== undefined) {
-        const allowed = document.createElement("span");
-        allowed.className = analysisRow.allowed
-          ? "execute-write-analysis-allowed"
-          : "execute-write-analysis-denied";
-        allowed.textContent = analysisRow.allowed ? "yes" : "no";
-        allowedCell.appendChild(allowed);
-      }
-      row.appendChild(allowedCell);
-      tbody.appendChild(row);
-    });
-    table.appendChild(tbody);
-    wrapper.appendChild(table);
-    analysisSection.appendChild(wrapper);
-  }
-
   window.datasetteSqlParameters.setupSqlParameterRefresh({
     form,
     url: form.dataset.analyzeUrl,
     allowExpand: true,
     onData(data) {
-      renderExecuteWriteAnalysis(data);
+      window.datasetteSqlAnalysis.renderAnalysis(analysisSection, data);
       if (submitButton) {
         submitButton.disabled = data.execute_disabled;
       }
     },
     onError(error) {
-      renderExecuteWriteAnalysis({
+      window.datasetteSqlAnalysis.renderAnalysis(analysisSection, {
         analysis_error: error.message,
         analysis_rows: [],
       });
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index 2d8a9122..cdf91799 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -6,6 +6,136 @@
 {{- super() -}}
 {% include "_codemirror.html" %}
 {% include "_execute_write_analysis_styles.html" %}
+<style>
+.query-create-page {
+    max-width: 64rem;
+}
+.query-create-form {
+    --query-create-label-width: clamp(7rem, 18vw, 10rem);
+    --query-create-column-gap: 0.8rem;
+    --query-create-control-width: minmax(16rem, 1fr);
+}
+.query-create-fields {
+    margin: 0 0 0.85rem;
+    max-width: 52rem;
+}
+.query-create-field {
+    align-items: start;
+    column-gap: var(--query-create-column-gap);
+    display: grid;
+    grid-template-columns: var(--query-create-label-width) var(--query-create-control-width);
+    margin: 0 0 0.65rem;
+}
+.query-create-field label {
+    padding-top: 0.55rem;
+    width: auto;
+}
+.query-create-field input[type=text],
+.query-create-field textarea {
+    box-sizing: border-box;
+    width: 100%;
+}
+form.sql .query-create-field textarea {
+    width: 100%;
+}
+.query-create-url-control {
+    align-items: center;
+    box-sizing: border-box;
+    display: grid;
+    gap: 0.35rem;
+    grid-template-columns: max-content minmax(12rem, 1fr);
+    width: 100%;
+}
+.query-create-url-prefix {
+    color: #4f5b6d;
+    font-family: var(--font-monospace, monospace);
+    white-space: nowrap;
+}
+.query-create-url-control input[type=text] {
+    border: 1px solid #ccc;
+    border-radius: 3px;
+}
+.query-create-field textarea {
+    border: 1px solid #ccc;
+    border-radius: 3px;
+    display: block;
+    font-family: Helvetica, sans-serif;
+    font-size: 1em;
+    min-height: 5rem;
+    padding: 9px 4px;
+    resize: vertical;
+}
+form.sql .query-create-sql {
+    column-gap: var(--query-create-column-gap);
+    display: grid;
+    grid-template-columns: var(--query-create-label-width) var(--query-create-control-width);
+    margin: 0.9rem 0 0.75rem;
+    max-width: 52rem;
+}
+.query-create-sql .cm-editor,
+form.sql .query-create-sql textarea#sql-editor {
+    grid-column: 2;
+    width: 100%;
+}
+.query-create-options {
+    align-items: center;
+    display: flex;
+    flex-wrap: wrap;
+    gap: 0.8rem 1.4rem;
+    margin: 0 0 0.9rem calc(var(--query-create-label-width) + var(--query-create-column-gap));
+    max-width: calc(52rem - var(--query-create-label-width) - var(--query-create-column-gap));
+}
+.query-create-options label {
+    align-items: center;
+    display: inline-flex;
+    gap: 0.35rem;
+    width: auto;
+}
+.query-create-options input[type=checkbox] {
+    margin: 0;
+}
+.query-create-option-note {
+    color: #4f5b6d;
+    flex-basis: 100%;
+    font-size: 0.82rem;
+    margin: -0.45rem 0 0;
+}
+.query-create-action {
+    margin: 0.35rem 0 1rem;
+}
+.query-create-analysis {
+    margin-top: 0.8rem;
+}
+.query-create-submit {
+    margin-left: calc(var(--query-create-label-width) + var(--query-create-column-gap));
+    margin-bottom: 0.9rem;
+    margin-top: 1rem;
+}
+@media (max-width: 560px) {
+    .query-create-form {
+        --query-create-label-width: 1fr;
+        --query-create-column-gap: 0;
+    }
+    .query-create-field {
+        grid-template-columns: 1fr;
+        row-gap: 0.25rem;
+    }
+    .query-create-field label {
+        padding-top: 0;
+    }
+    form.sql .query-create-sql {
+        grid-template-columns: 1fr;
+    }
+    .query-create-sql .cm-editor,
+    form.sql .query-create-sql textarea#sql-editor {
+        grid-column: 1;
+    }
+    .query-create-options,
+    .query-create-submit {
+        margin-left: 0;
+    }
+}
+</style>
 {% endblock %}
 
 {% block body_class %}query-create db-{{ database|to_css_class }}{% endblock %}
@@ -16,56 +146,140 @@
 
 {% block content %}
 
+<div class="query-create-page">
+
 <h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Create query</h1>
 
-<form class="sql core" action="{{ urls.database(database) }}/-/queries/insert" method="post">
-    <p><label for="query-name">Name</label> <input id="query-name" name="name" type="text"></p>
-    <p><label for="query-title">Title</label> <input id="query-title" name="title" type="text"></p>
-    <p><label for="query-description">Description</label><br><textarea id="query-description" name="description" rows="3"></textarea></p>
-    <p>
-        <label><input type="radio" name="mode" value="read-only" checked> Read-only</label>
-        <label><input type="radio" name="mode" value="writable"> Writable</label>
+<form class="sql core query-create-form" action="{{ urls.database(database) }}/-/queries/insert" method="post" data-analyze-url="{{ urls.database(database) }}/-/queries/analyze">
+    <div class="query-create-fields">
+        <p class="query-create-field"><label for="query-title">Title</label> <input id="query-title" name="title" type="text" value="{{ title or "" }}"></p>
+        <p class="query-create-field"><label for="query-url-slug">URL</label> <span class="query-create-url-control"><span class="query-create-url-prefix">{{ urls.database(database) }}/</span><input id="query-url-slug" name="name" type="text" value="{{ name or "" }}"></span></p>
+        <p class="query-create-field"><label for="query-description">Description</label> <textarea id="query-description" name="description" rows="3">{{ description or "" }}</textarea></p>
+    </div>
+
+    <p class="query-create-sql sql-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
+
+    <p class="query-create-options">
+        <input type="hidden" name="is_private" value="0">
+        <label><input type="checkbox" name="is_private" value="1"{% if is_private %} checked{% endif %}> Private</label>
+        <label><input type="checkbox" data-query-create-writable{% if analysis_is_write %} checked{% endif %} disabled> Writable</label>
+        <span class="query-create-option-note">Queries marked private can only be seen by you, their creator.</span>
     </p>
-    <p><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
-    <p><label for="query-parameters">Parameters</label> <input id="query-parameters" name="parameters" type="text" value="{{ parameter_names|join(', ') }}"></p>
-    <p><label><input type="checkbox" name="is_private" value="1" checked> Private</label></p>
     {% if sql and analysis_is_write %}
-        <p><a href="{{ urls.database(database) }}/-/execute-write?{{ {'sql': sql}|urlencode|safe }}">Execute write SQL</a></p>
+        <p class="query-create-action"><a href="{{ urls.database(database) }}/-/execute-write?{{ {'sql': sql}|urlencode|safe }}">Execute write SQL</a></p>
     {% endif %}
 
-    <h2>Query operations</h2>
-    {% if analysis_error %}
-        <p class="message-error">{{ analysis_error }}</p>
-    {% elif analysis_rows %}
-        <div class="table-wrapper"><table class="execute-write-analysis">
-            <thead>
-                <tr>
-                    <th scope="col">Operation</th>
-                    <th scope="col">Database</th>
-                    <th scope="col">Table</th>
-                    <th scope="col">Required permission</th>
-                    <th scope="col">Allowed</th>
-                </tr>
-            </thead>
-            <tbody>
-                {% for row in analysis_rows %}
-                    <tr>
-                        <td><code>{{ row.operation }}</code></td>
-                        <td><code>{{ row.database }}</code></td>
-                        <td><code>{{ row.table }}</code></td>
-                        <td>{% if row.required_permission %}<code>{{ row.required_permission }}</code>{% endif %}</td>
-                        <td>{% if row.allowed is none %}{% elif row.allowed %}<span class="execute-write-analysis-allowed">yes</span>{% else %}<span class="execute-write-analysis-denied">no</span>{% endif %}</td>
-                    </tr>
-                {% endfor %}
-            </tbody>
-        </table></div>
-    {% else %}
-        <p>Analysis will show each affected table and required permission.</p>
-    {% endif %}
+    <p class="query-create-submit"><input type="submit" value="Save query" data-query-create-submit{% if save_disabled %} disabled{% endif %}></p>
 
-    <p><input type="submit" value="Save query"{% if save_disabled %} disabled{% endif %}></p>
+    <div class="query-create-analysis" id="query-create-analysis-section"{% if not has_sql %} hidden{% endif %}>
+        {% if has_sql %}
+            <h2>Query operations</h2>
+            {% if analysis_error %}
+                <p class="message-error">{{ analysis_error }}</p>
+            {% elif analysis_rows %}
+                <div class="table-wrapper"><table class="execute-write-analysis">
+                    <thead>
+                        <tr>
+                            <th scope="col">Operation</th>
+                            <th scope="col">Database</th>
+                            <th scope="col">Table</th>
+                            <th scope="col">Required permission</th>
+                            <th scope="col">Allowed</th>
+                        </tr>
+                    </thead>
+                    <tbody>
+                        {% for row in analysis_rows %}
+                            <tr>
+                                <td><code>{{ row.operation }}</code></td>
+                                <td><code>{{ row.database }}</code></td>
+                                <td><code>{{ row.table }}</code></td>
+                                <td>{% if row.required_permission %}<code>{{ row.required_permission }}</code>{% else %}<span class="execute-write-analysis-na">n/a</span>{% endif %}</td>
+                                <td>{% if row.allowed is none %}<span class="execute-write-analysis-na">n/a</span>{% elif row.allowed %}<span class="execute-write-analysis-allowed">yes</span>{% else %}<span class="execute-write-analysis-denied">no</span>{% endif %}</td>
+                            </tr>
+                        {% endfor %}
+                    </tbody>
+                </table></div>
+            {% else %}
+                <p>Analysis will show each affected table and required permission.</p>
+            {% endif %}
+        {% endif %}
+    </div>
 </form>
 
+</div>
+
 {% include "_codemirror_foot.html" %}
+{% include "_sql_parameter_scripts.html" %}
+{% include "_execute_write_analysis_scripts.html" %}
+
+<script>
+window.addEventListener("DOMContentLoaded", () => {
+  const titleInput = document.querySelector("#query-title");
+  const urlInput = document.querySelector("#query-url-slug");
+  let urlEdited = Boolean(urlInput && urlInput.value);
+
+  function slugify(value) {
+    return value
+      .normalize("NFKD")
+      .replace(/[\u0300-\u036f]/g, "")
+      .toLowerCase()
+      .trim()
+      .replace(/[^a-z0-9_-]+/g, "-")
+      .replace(/-+/g, "-")
+      .replace(/^-|-$/g, "");
+  }
+
+  if (titleInput && urlInput) {
+    titleInput.addEventListener("input", () => {
+      if (!urlEdited) {
+        urlInput.value = slugify(titleInput.value);
+      }
+    });
+    urlInput.addEventListener("input", () => {
+      urlEdited = true;
+    });
+  }
+});
+</script>
+
+<script>
+window.addEventListener("DOMContentLoaded", () => {
+  const form = document.querySelector("form.sql.core");
+  const analysisSection = document.querySelector("#query-create-analysis-section");
+  const submitButton = form
+    ? form.querySelector("[data-query-create-submit]")
+    : null;
+  const writableCheckbox = form
+    ? form.querySelector("[data-query-create-writable]")
+    : null;
+
+  window.datasetteSqlParameters.setupSqlParameterRefresh({
+    form,
+    url: form.dataset.analyzeUrl,
+    renderParameters: false,
+    onData(data) {
+      window.datasetteSqlAnalysis.renderAnalysis(analysisSection, data);
+      if (submitButton) {
+        submitButton.disabled = data.save_disabled;
+      }
+      if (writableCheckbox) {
+        writableCheckbox.checked = data.analysis_is_write;
+      }
+    },
+    onError(error) {
+      window.datasetteSqlAnalysis.renderAnalysis(analysisSection, {
+        analysis_error: error.message,
+        analysis_rows: [],
+      });
+      if (submitButton) {
+        submitButton.disabled = true;
+      }
+      if (writableCheckbox) {
+        writableCheckbox.checked = false;
+      }
+    },
+  });
+});
+</script>
 
 {% endblock %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 2e77d36b..aafcf40b 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -551,6 +551,17 @@ def _wants_json(request, is_json, data):
     )
 
 
+def _query_create_form_error_message(message):
+    return {
+        "Query name is required": "URL is required",
+        "Invalid query name": "Invalid URL",
+        "Query name conflicts with a table or view": (
+            "URL conflicts with an existing table or view"
+        ),
+        "Query already exists": "A query already exists at that URL",
+    }.get(message, message)
+
+
 async def _json_or_form_payload(request):
     content_type = request.headers.get("content-type", "")
     if content_type.startswith("application/json"):
@@ -731,6 +742,54 @@ async def _execute_write_analysis_data(datasette, db, sql, actor):
     }
 
 
+async def _query_create_analysis_data(datasette, db, sql, actor):
+    has_sql = bool(sql and sql.strip())
+    parameter_names = []
+    analysis_rows = []
+    analysis_error = None
+    if has_sql:
+        try:
+            parameter_names = _derived_query_parameters(sql)
+            params = {parameter: "" for parameter in parameter_names}
+            analysis = await db.analyze_sql(sql, params)
+            analysis_rows = await _analysis_rows_with_permissions(
+                datasette, analysis, actor
+            )
+        except (QueryValidationError, sqlite3.DatabaseError) as ex:
+            analysis_error = getattr(ex, "message", str(ex))
+    return {
+        "ok": analysis_error is None,
+        "parameters": parameter_names,
+        "analysis_error": analysis_error,
+        "analysis_rows": analysis_rows,
+        "has_sql": has_sql,
+        "analysis_is_write": bool(
+            analysis_rows and any(row["required_permission"] for row in analysis_rows)
+        ),
+        "save_disabled": bool(
+            (not has_sql)
+            or analysis_error
+            or any(row["allowed"] is False for row in analysis_rows)
+        ),
+    }
+
+
+async def _query_create_form_context(
+    datasette, request, db, *, sql="", name="", title="", description="", is_private=True
+):
+    analysis_data = await _query_create_analysis_data(datasette, db, sql, request.actor)
+    return {
+        "database": db.name,
+        "database_color": db.color,
+        "sql": sql,
+        "name": name,
+        "title": title,
+        "description": description,
+        "is_private": is_private,
+        **analysis_data,
+    }
+
+
 async def _inserted_row_url(datasette, db, analysis, cursor):
     if cursor.rowcount != 1:
         return None
@@ -1307,6 +1366,35 @@ class QueryCreateView(BaseView):
     name = "query-create"
     has_json_alternate = False
 
+    async def _render_form(
+        self,
+        request,
+        db,
+        *,
+        sql="",
+        name="",
+        title="",
+        description="",
+        is_private=True,
+        status=200,
+    ):
+        response = await self.render(
+            ["query_create.html"],
+            request,
+            await _query_create_form_context(
+                self.ds,
+                request,
+                db,
+                sql=sql,
+                name=name,
+                title=title,
+                description=description,
+                is_private=is_private,
+            ),
+        )
+        response.status = status
+        return response
+
     async def get(self, request):
         db = await self.ds.resolve_database(request)
         await self.ds.ensure_permission(
@@ -1320,46 +1408,61 @@ class QueryCreateView(BaseView):
             actor=request.actor,
         )
 
-        sql = request.args.get("sql") or ""
-        analysis_error = None
-        analysis_rows = []
-        parameter_names = []
-        if sql:
-            try:
-                parameter_names = _derived_query_parameters(sql)
-                params = {parameter: "" for parameter in parameter_names}
-                analysis = await db.analyze_sql(sql, params)
-                analysis_rows = await _analysis_rows_with_permissions(
-                    self.ds, analysis, request.actor
-                )
-            except (QueryValidationError, sqlite3.DatabaseError) as ex:
-                analysis_error = getattr(ex, "message", str(ex))
+        return await self._render_form(request, db, sql=request.args.get("sql") or "")
 
-        return await self.render(
-            ["query_create.html"],
-            request,
-            {
-                "database": db.name,
-                "database_color": db.color,
-                "sql": sql,
-                "parameter_names": parameter_names,
-                "analysis_error": analysis_error,
-                "analysis_rows": analysis_rows,
-                "analysis_is_write": bool(
-                    analysis_rows
-                    and any(row["required_permission"] for row in analysis_rows)
-                ),
-                "save_disabled": bool(
-                    analysis_error
-                    or any(row["allowed"] is False for row in analysis_rows)
-                ),
-            },
+
+class QueryCreateAnalyzeView(BaseView):
+    name = "query-create-analyze"
+    has_json_alternate = False
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(_error(["Permission denied: need execute-sql"], 403))
+        if not await self.ds.allowed(
+            action="insert-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(_error(["Permission denied: need insert-query"], 403))
+
+        invalid_keys = set(request.args) - {"sql"}
+        if invalid_keys:
+            return _block_framing(
+                _error(
+                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
+                    400,
+                )
+            )
+        sql = request.args.get("sql") or ""
+        return _block_framing(
+            Response.json(
+                await _query_create_analysis_data(self.ds, db, sql, request.actor)
+            )
         )
 
 
-class QueryInsertView(BaseView):
+class QueryInsertView(QueryCreateView):
     name = "query-insert"
 
+    async def _error_response(self, request, db, query_data, message, status):
+        message = _query_create_form_error_message(message)
+        self.ds.add_message(request, message, self.ds.ERROR)
+        return await self._render_form(
+            request,
+            db,
+            sql=query_data.get("sql") or "",
+            name=query_data.get("name") or "",
+            title=query_data.get("title") or "",
+            description=query_data.get("description") or "",
+            is_private=_as_bool(query_data.get("is_private", True)),
+            status=status,
+        )
+
     async def post(self, request):
         db = await self.ds.resolve_database(request)
         if not await self.ds.allowed(
@@ -1375,6 +1478,8 @@ class QueryInsertView(BaseView):
         ):
             return _error(["Permission denied: need insert-query"], 403)
 
+        is_json = False
+        query_data = {}
         try:
             data, is_json = await _json_or_form_payload(request)
             if not isinstance(data, dict):
@@ -1384,6 +1489,10 @@ class QueryInsertView(BaseView):
                 raise QueryValidationError("JSON must contain a query dictionary")
             prepared = await _prepare_query_create(self.ds, request, db, query_data)
         except QueryValidationError as ex:
+            if not is_json and isinstance(query_data, dict):
+                return await self._error_response(
+                    request, db, query_data, ex.message, ex.status
+                )
             return _error([ex.message], ex.status)
 
         prepared.pop("analysis")
@@ -1391,6 +1500,8 @@ class QueryInsertView(BaseView):
         try:
             await self.ds.add_query(db.name, name, replace=False, **prepared)
         except sqlite3.IntegrityError as ex:
+            if not is_json and isinstance(query_data, dict):
+                return await self._error_response(request, db, query_data, str(ex), 400)
             return _error([str(ex)], 400)
 
         query = await self.ds.get_query(db.name, name)
@@ -1896,7 +2007,7 @@ class QueryView(View):
             ):
                 save_query_url = (
                     datasette.urls.database(database)
-                    + "/-/queries/-/create?"
+                    + "/-/queries/insert?"
                     + urlencode({"sql": sql})
                 )
 
diff --git a/tests/test_queries.py b/tests/test_queries.py
index c27c23da..32cdfae3 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -986,6 +986,14 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
     await ds.invoke_startup()
 
     create_response = await ds.client.get(
+        "/data/-/queries/insert?sql=select+*+from+dogs",
+        actor={"id": "root"},
+    )
+    blank_create_response = await ds.client.get(
+        "/data/-/queries/insert",
+        actor={"id": "root"},
+    )
+    old_create_response = await ds.client.get(
         "/data/-/queries/-/create?sql=select+*+from+dogs",
         actor={"id": "root"},
     )
@@ -996,16 +1004,171 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
 
     assert create_response.status_code == 200
     assert "Create query" in create_response.text
-    assert "Read-only" in create_response.text
     assert "Writable" in create_response.text
+    assert 'type="radio"' not in create_response.text
+    assert 'name="parameters"' not in create_response.text
+    assert 'id="query-parameters"' not in create_response.text
+    assert 'class="query-create-field"' in create_response.text
+    assert '<label for="query-name">Name</label>' not in create_response.text
+    assert '<label for="query-title">Title</label>' in create_response.text
+    assert '<label for="query-url-slug">URL</label>' in create_response.text
+    assert '<span class="query-create-url-prefix">/data/</span>' in create_response.text
+    assert (
+        '<input id="query-url-slug" name="name" type="text" value="">'
+        in create_response.text
+    )
+    assert 'function slugify(value)' in create_response.text
+    assert 'data-analyze-url="/data/-/queries/analyze"' in create_response.text
+    assert "setupSqlParameterRefresh" in create_response.text
+    assert "renderParameters: false" in create_response.text
+    assert "datasetteSqlAnalysis.renderAnalysis" in create_response.text
+    assert "data-query-create-submit" in create_response.text
+    assert "data-query-create-writable" in create_response.text
+    assert (
+        "Queries marked private can only be seen by you, their creator."
+        in create_response.text
+    )
     assert "<h2>Query operations</h2>" in create_response.text
     assert '<table class="execute-write-analysis">' in create_response.text
     assert '<th scope="col">Required permission</th>' in create_response.text
     assert '<th scope="col">Source</th>' not in create_response.text
     assert "<td><code>read</code></td>" in create_response.text
+    assert (
+        create_response.text.count(
+            '<td><span class="execute-write-analysis-na">n/a</span></td>'
+        )
+        == 2
+    )
+    assert create_response.text.index('value="Save query"') < create_response.text.index(
+        "<h2>Query operations</h2>"
+    )
+    assert blank_create_response.status_code == 200
+    assert (
+        '<div class="query-create-analysis" id="query-create-analysis-section" hidden>'
+        in blank_create_response.text
+    )
+    assert "<h2>Query operations</h2>" not in blank_create_response.text
+    assert (
+        "<p>Analysis will show each affected table and required permission.</p>"
+        not in blank_create_response.text
+    )
     assert query_response.status_code == 200
-    assert "Save query" in query_response.text
-    assert "/data/-/queries/-/create?sql=select+%2A+from+dogs" in query_response.text
+    assert "Save this query" in query_response.text
+    assert "/data/-/queries/insert?sql=select+%2A+from+dogs" in query_response.text
+    assert old_create_response.status_code == 404
+
+
+@pytest.mark.asyncio
+async def test_create_query_analyze_endpoint_uses_sql_only():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_create_analyze", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.get(
+        "/data/-/queries/analyze",
+        actor={"id": "root"},
+        params={"sql": "select * from dogs where name = :name"},
+    )
+    write_response = await ds.client.get(
+        "/data/-/queries/analyze",
+        actor={"id": "root"},
+        params={"sql": "insert into dogs (name) values (:name)"},
+    )
+    blank_response = await ds.client.get(
+        "/data/-/queries/analyze",
+        actor={"id": "root"},
+        params={"sql": ""},
+    )
+    old_analyze_response = await ds.client.get(
+        "/data/-/queries/-/create/analyze",
+        actor={"id": "root"},
+        params={"sql": "select * from dogs"},
+    )
+
+    assert response.status_code == 200
+    data = response.json()
+    assert data["ok"] is True
+    assert data["parameters"] == ["name"]
+    assert data["analysis_error"] is None
+    assert data["has_sql"] is True
+    assert data["analysis_is_write"] is False
+    assert data["save_disabled"] is False
+    assert data["analysis_rows"] == [
+        {
+            "operation": "read",
+            "database": "data",
+            "table": "dogs",
+            "required_permission": "",
+            "source": None,
+            "allowed": None,
+        }
+    ]
+
+    assert write_response.status_code == 200
+    write_data = write_response.json()
+    assert write_data["parameters"] == ["name"]
+    assert write_data["has_sql"] is True
+    assert write_data["analysis_is_write"] is True
+    assert write_data["save_disabled"] is False
+    assert write_data["analysis_rows"][0]["operation"] == "insert"
+
+    assert blank_response.status_code == 200
+    blank_data = blank_response.json()
+    assert blank_data["has_sql"] is False
+    assert blank_data["parameters"] == []
+    assert blank_data["analysis_rows"] == []
+    assert blank_data["save_disabled"] is True
+    assert old_analyze_response.status_code == 404
+
+
+@pytest.mark.asyncio
+async def test_create_query_form_error_redisplays_form_with_values():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_create_form_error", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/queries/insert",
+        actor={"id": "root"},
+        data={
+            "name": "dogs",
+            "title": "Dog lookup",
+            "description": "Find dogs by name",
+            "sql": "select * from dogs where name = :name",
+            "is_private": "1",
+        },
+    )
+
+    assert response.status_code == 400
+    assert response.headers["content-type"].startswith("text/html")
+    assert "URL conflicts with an existing table or view" in response.text
+    assert "Query name conflicts with a table or view" not in response.text
+    assert '{"ok": false' not in response.text
+    assert 'value="Dog lookup"' in response.text
+    assert 'value="dogs"' in response.text
+    assert ">Find dogs by name</textarea>" in response.text
+    assert "select * from dogs where name = :name" in response.text
+    assert 'name="is_private" value="1" checked' in response.text
+
+    public_response = await ds.client.post(
+        "/data/-/queries/insert",
+        actor={"id": "root"},
+        data={
+            "name": "dogs",
+            "title": "Public dog lookup",
+            "description": "Keep this public setting",
+            "sql": "select * from dogs",
+            "is_private": "0",
+        },
+    )
+
+    assert public_response.status_code == 400
+    assert 'name="is_private" value="1" checked' not in public_response.text
+    assert 'name="is_private" value="0"' in public_response.text
 
 
 @pytest.mark.asyncio
@@ -1046,6 +1209,7 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'data-analyze-url="/data/-/execute-write/analyze"' in response.text
     assert 'addEventListener("paste"' in response.text
     assert "setupSqlParameterRefresh" in response.text
+    assert "datasetteSqlAnalysis.renderAnalysis" in response.text
     assert '<table class="execute-write-analysis">' in response.text
     assert '<th scope="col">Required permission</th>' in response.text
     assert "<td><code>insert</code></td>" in response.text

From 5dca2dc9beea96c52e6a9c806df66c9a1f2f7874 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 13:54:47 -0700
Subject: [PATCH 081/386] Show query count on database page

---
 datasette/templates/database.html |  2 +-
 datasette/views/database.py       | 18 +++++++++++++++++-
 tests/test_queries.py             | 11 ++++++-----
 3 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/datasette/templates/database.html b/datasette/templates/database.html
index 62f9c620..371f6a22 100644
--- a/datasette/templates/database.html
+++ b/datasette/templates/database.html
@@ -59,7 +59,7 @@
         {% endfor %}
     </ul>
     {% if queries_more %}
-        <p><a href="{{ urls.database(database) }}/-/queries">View all queries</a></p>
+        <p><a href="{{ urls.database(database) }}/-/queries">View {{ "{:,}".format(queries_count) }} quer{% if queries_count == 1 %}y{% else %}ies{% endif %}</a></p>
     {% endif %}
 {% endif %}
 
diff --git a/datasette/views/database.py b/datasette/views/database.py
index feb38619..d40d69d1 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -102,6 +102,11 @@ class DatabaseView(View):
         )
         canned_queries = queries_page["queries"]
         queries_more = queries_page["has_more"]
+        queries_count = (
+            await datasette.count_queries(database, actor=request.actor)
+            if queries_more
+            else len(canned_queries)
+        )
 
         async def database_actions():
             links = []
@@ -134,6 +139,7 @@ class DatabaseView(View):
             "views": sql_views,
             "queries": canned_queries,
             "queries_more": queries_more,
+            "queries_count": queries_count,
             "allow_execute_sql": allow_execute_sql,
             "table_columns": (
                 await _table_columns(datasette, database) if allow_execute_sql else {}
@@ -168,6 +174,7 @@ class DatabaseView(View):
                     views=sql_views,
                     queries=canned_queries,
                     queries_more=queries_more,
+                    queries_count=queries_count,
                     allow_execute_sql=allow_execute_sql,
                     table_columns=(
                         await _table_columns(datasette, database)
@@ -219,6 +226,7 @@ class DatabaseContext(Context):
     queries_more: bool = field(
         metadata={"help": "Boolean indicating if more saved queries are available"}
     )
+    queries_count: int = field(metadata={"help": "Count of visible saved queries"})
     allow_execute_sql: bool = field(
         metadata={"help": "Boolean indicating if custom SQL can be executed"}
     )
@@ -775,7 +783,15 @@ async def _query_create_analysis_data(datasette, db, sql, actor):
 
 
 async def _query_create_form_context(
-    datasette, request, db, *, sql="", name="", title="", description="", is_private=True
+    datasette,
+    request,
+    db,
+    *,
+    sql="",
+    name="",
+    title="",
+    description="",
+    is_private=True,
 ):
     analysis_data = await _query_create_analysis_data(datasette, db, sql, request.actor)
     return {
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 32cdfae3..09b41645 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -458,9 +458,10 @@ async def test_database_page_query_preview_is_limited():
     assert html_response.status_code == 200
     assert "Demo query 05" in html_response.text
     assert "Demo query 06" not in html_response.text
-    assert 'href="/data/-/queries"' in html_response.text
+    assert '<a href="/data/-/queries">View 25 queries</a>' in html_response.text
     assert len(json_response.json()["queries"]) == 5
     assert json_response.json()["queries_more"] is True
+    assert json_response.json()["queries_count"] == 25
 
 
 @pytest.mark.asyncio
@@ -1017,7 +1018,7 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
         '<input id="query-url-slug" name="name" type="text" value="">'
         in create_response.text
     )
-    assert 'function slugify(value)' in create_response.text
+    assert "function slugify(value)" in create_response.text
     assert 'data-analyze-url="/data/-/queries/analyze"' in create_response.text
     assert "setupSqlParameterRefresh" in create_response.text
     assert "renderParameters: false" in create_response.text
@@ -1039,9 +1040,9 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
         )
         == 2
     )
-    assert create_response.text.index('value="Save query"') < create_response.text.index(
-        "<h2>Query operations</h2>"
-    )
+    assert create_response.text.index(
+        'value="Save query"'
+    ) < create_response.text.index("<h2>Query operations</h2>")
     assert blank_create_response.status_code == 200
     assert (
         '<div class="query-create-analysis" id="query-create-analysis-section" hidden>'

From f7e9dbc27efe31968a9d673322c5a86a45b93ef4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 14:02:37 -0700
Subject: [PATCH 082/386] Tweaked design of create query page

---
 datasette/templates/query_create.html | 37 +++++++++++++++++++--------
 tests/test_queries.py                 | 24 +++++++++++++++--
 2 files changed, 49 insertions(+), 12 deletions(-)

diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index cdf91799..cb14ada4 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -94,12 +94,18 @@ form.sql .query-create-sql textarea#sql-editor {
 .query-create-options input[type=checkbox] {
     margin: 0;
 }
-.query-create-option-note {
+.query-create-option-note,
+.query-create-analysis-note {
     color: #4f5b6d;
     flex-basis: 100%;
     font-size: 0.82rem;
+}
+.query-create-option-note {
     margin: -0.45rem 0 0;
 }
+.query-create-analysis-note {
+    margin: 0;
+}
 .query-create-action {
     margin: 0.35rem 0 1rem;
 }
@@ -160,9 +166,9 @@ form.sql .query-create-sql textarea#sql-editor {
     <p class="query-create-sql sql-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
 
     <p class="query-create-options">
+        <span class="query-create-analysis-note" data-query-create-analysis-note aria-live="polite">{% if analysis_error %}This query cannot be saved until the SQL is valid.{% elif not has_sql %}Enter SQL to analyze this query.{% elif analysis_is_write %}This query updates data in the database.{% else %}This is a read-only query.{% endif %}</span>
         <input type="hidden" name="is_private" value="0">
         <label><input type="checkbox" name="is_private" value="1"{% if is_private %} checked{% endif %}> Private</label>
-        <label><input type="checkbox" data-query-create-writable{% if analysis_is_write %} checked{% endif %} disabled> Writable</label>
         <span class="query-create-option-note">Queries marked private can only be seen by you, their creator.</span>
     </p>
     {% if sql and analysis_is_write %}
@@ -249,10 +255,25 @@ window.addEventListener("DOMContentLoaded", () => {
   const submitButton = form
     ? form.querySelector("[data-query-create-submit]")
     : null;
-  const writableCheckbox = form
-    ? form.querySelector("[data-query-create-writable]")
+  const analysisNote = form
+    ? form.querySelector("[data-query-create-analysis-note]")
     : null;
 
+  function updateAnalysisNote(data) {
+    if (!analysisNote) {
+      return;
+    }
+    if (data.analysis_error) {
+      analysisNote.textContent = "This query cannot be saved until the SQL is valid.";
+    } else if (data.has_sql === false) {
+      analysisNote.textContent = "Enter SQL to analyze this query.";
+    } else if (data.analysis_is_write) {
+      analysisNote.textContent = "This query updates data in the database.";
+    } else {
+      analysisNote.textContent = "This is a read-only query.";
+    }
+  }
+
   window.datasetteSqlParameters.setupSqlParameterRefresh({
     form,
     url: form.dataset.analyzeUrl,
@@ -262,9 +283,7 @@ window.addEventListener("DOMContentLoaded", () => {
       if (submitButton) {
         submitButton.disabled = data.save_disabled;
       }
-      if (writableCheckbox) {
-        writableCheckbox.checked = data.analysis_is_write;
-      }
+      updateAnalysisNote(data);
     },
     onError(error) {
       window.datasetteSqlAnalysis.renderAnalysis(analysisSection, {
@@ -274,9 +293,7 @@ window.addEventListener("DOMContentLoaded", () => {
       if (submitButton) {
         submitButton.disabled = true;
       }
-      if (writableCheckbox) {
-        writableCheckbox.checked = false;
-      }
+      updateAnalysisNote({ analysis_error: error.message });
     },
   });
 });
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 09b41645..f888dda0 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -990,6 +990,10 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
         "/data/-/queries/insert?sql=select+*+from+dogs",
         actor={"id": "root"},
     )
+    write_create_response = await ds.client.get(
+        "/data/-/queries/insert?sql=insert+into+dogs+(name)+values+('Cleo')",
+        actor={"id": "root"},
+    )
     blank_create_response = await ds.client.get(
         "/data/-/queries/insert",
         actor={"id": "root"},
@@ -1005,7 +1009,6 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
 
     assert create_response.status_code == 200
     assert "Create query" in create_response.text
-    assert "Writable" in create_response.text
     assert 'type="radio"' not in create_response.text
     assert 'name="parameters"' not in create_response.text
     assert 'id="query-parameters"' not in create_response.text
@@ -1024,11 +1027,22 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
     assert "renderParameters: false" in create_response.text
     assert "datasetteSqlAnalysis.renderAnalysis" in create_response.text
     assert "data-query-create-submit" in create_response.text
-    assert "data-query-create-writable" in create_response.text
+    assert "data-query-create-writable" not in create_response.text
+    assert "data-query-create-sql-type" not in create_response.text
+    assert "data-query-create-analysis-note" in create_response.text
+    assert "SQL type:" not in create_response.text
+    assert (
+        '<span class="query-create-analysis-note" data-query-create-analysis-note aria-live="polite">This is a read-only query.</span>'
+        in create_response.text
+    )
+    assert "disabled> Writable</label>" not in create_response.text
     assert (
         "Queries marked private can only be seen by you, their creator."
         in create_response.text
     )
+    assert create_response.text.index(
+        "This is a read-only query."
+    ) < create_response.text.index('<input type="hidden" name="is_private" value="0">')
     assert "<h2>Query operations</h2>" in create_response.text
     assert '<table class="execute-write-analysis">' in create_response.text
     assert '<th scope="col">Required permission</th>' in create_response.text
@@ -1053,6 +1067,12 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
         "<p>Analysis will show each affected table and required permission.</p>"
         not in blank_create_response.text
     )
+    assert "Enter SQL to analyze this query." in blank_create_response.text
+    assert write_create_response.status_code == 200
+    assert (
+        '<span class="query-create-analysis-note" data-query-create-analysis-note aria-live="polite">This query updates data in the database.</span>'
+        in write_create_response.text
+    )
     assert query_response.status_code == 200
     assert "Save this query" in query_response.text
     assert "/data/-/queries/insert?sql=select+%2A+from+dogs" in query_response.text

From 024b9117725bbed17396a5a4b3f48663c23337f5 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 14:09:53 -0700
Subject: [PATCH 083/386] Clarifying comment

https://github.com/simonw/datasette/pull/2741/changes#r3306856046
---
 datasette/default_permissions/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/datasette/default_permissions/__init__.py b/datasette/default_permissions/__init__.py
index a9f2d8bd..6cd46f04 100644
--- a/datasette/default_permissions/__init__.py
+++ b/datasette/default_permissions/__init__.py
@@ -26,6 +26,7 @@ from .restrictions import (
 from .root import root_user_permissions_sql as root_user_permissions_sql
 from .config import config_permissions_sql as config_permissions_sql
 from .defaults import (
+    # Avoid "datasette.default_permissions" does not explicitly export attribute
     default_allow_sql_check as default_allow_sql_check,
     default_action_permissions_sql as default_action_permissions_sql,
     default_query_permissions_sql as default_query_permissions_sql,

From ac6ee097dd06050188d44c6d4b17a98a12c7b481 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 14:10:48 -0700
Subject: [PATCH 084/386] Disallow update/delete of private queries

If a user does not own a private query they cannot update
or delete it either, even if they have global update-query.

https://github.com/simonw/datasette/pull/2741/changes#r3306417463
---
 datasette/default_permissions/defaults.py | 33 ++++-----
 tests/test_queries.py                     | 81 +++++++++++++++++++++++
 2 files changed, 95 insertions(+), 19 deletions(-)

diff --git a/datasette/default_permissions/defaults.py b/datasette/default_permissions/defaults.py
index 32ad4ef1..5bc74425 100644
--- a/datasette/default_permissions/defaults.py
+++ b/datasette/default_permissions/defaults.py
@@ -77,36 +77,31 @@ async def default_query_permissions_sql(
 ) -> Optional[PermissionSQL]:
     actor_id = actor.get("id") if isinstance(actor, dict) else None
 
-    if action in {"update-query", "delete-query"}:
-        if actor_id is None:
-            return None
-        # Query owner can update/delete query
-        return PermissionSQL(
-            sql="""
-            SELECT database_name AS parent, name AS child, 1 AS allow,
-              'query owner' AS reason
-            FROM queries
-            WHERE source = 'user'
-              AND owner_id = :query_owner_id
-            """,
-            params={"query_owner_id": actor_id},
-        )
-
-    if action != "view-query":
+    if action not in {"view-query", "update-query", "delete-query"}:
         return None
 
     params = {"query_owner_id": actor_id}
     rule_sqls = []
     if actor_id is not None:
-        # Query owner can view-query
-        rule_sqls.append("""
+        if action in {"update-query", "delete-query"}:
+            # Query owner can update/delete query
+            rule_sqls.append("""
+            SELECT database_name AS parent, name AS child, 1 AS allow,
+              'query owner' AS reason
+            FROM queries
+            WHERE source = 'user'
+              AND owner_id = :query_owner_id
+            """)
+        else:
+            # Query owner can view-query
+            rule_sqls.append("""
             SELECT database_name AS parent, name AS child, 1 AS allow,
               'query owner' AS reason
             FROM queries
             WHERE owner_id = :query_owner_id
             """)
 
-    # restriction_sql enforces private queries ONLY visible to owner
+    # restriction_sql enforces private queries ONLY visible/mutable by owner
     return PermissionSQL(
         sql="\nUNION ALL\n".join(rule_sqls) if rule_sqls else None,
         restriction_sql="""
diff --git a/tests/test_queries.py b/tests/test_queries.py
index f888dda0..26a0748c 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1581,6 +1581,87 @@ async def test_query_owner_gets_update_delete_and_writable_view_defaults():
         )
 
 
+@pytest.mark.asyncio
+async def test_private_query_restricts_broad_update_delete_permissions():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "update-query": {"id": "bob"},
+                        "delete-query": {"id": "bob"},
+                    },
+                },
+            },
+        },
+    )
+    ds.add_memory_database("query_broad_update_delete", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "alice_private",
+        "select 1",
+        is_private=True,
+        source="user",
+        owner_id="alice",
+    )
+    await ds.add_query(
+        "data",
+        "alice_public",
+        "select 2",
+        is_private=False,
+        source="user",
+        owner_id="alice",
+    )
+
+    for action in ("update-query", "delete-query"):
+        assert await ds.allowed(
+            action=action,
+            resource=QueryResource("data", "alice_private"),
+            actor={"id": "alice"},
+        )
+        assert not await ds.allowed(
+            action=action,
+            resource=QueryResource("data", "alice_private"),
+            actor={"id": "bob"},
+        )
+        assert await ds.allowed(
+            action=action,
+            resource=QueryResource("data", "alice_public"),
+            actor={"id": "bob"},
+        )
+
+    private_update_response = await ds.client.post(
+        "/data/alice_private/-/update",
+        actor={"id": "bob"},
+        json={"update": {"title": "Nope"}},
+    )
+    private_delete_response = await ds.client.post(
+        "/data/alice_private/-/delete",
+        actor={"id": "bob"},
+        json={},
+    )
+    public_update_response = await ds.client.post(
+        "/data/alice_public/-/update",
+        actor={"id": "bob"},
+        json={"update": {"title": "Bob can edit public queries"}},
+    )
+    public_delete_response = await ds.client.post(
+        "/data/alice_public/-/delete",
+        actor={"id": "bob"},
+        json={},
+    )
+
+    assert private_update_response.status_code == 403
+    assert private_delete_response.status_code == 403
+    assert public_update_response.status_code == 200
+    assert public_delete_response.status_code == 200
+    assert await ds.get_query("data", "alice_private") is not None
+    assert await ds.get_query("data", "alice_public") is None
+
+
 @pytest.mark.asyncio
 async def test_user_writable_query_execution_rechecks_table_permissions():
     ds = Datasette(

From 180a6a86fd77ac43f6cf3bfb7d7f9150003da419 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 14:16:10 -0700
Subject: [PATCH 085/386] Remove queries-plan.md

We do not need this any more. It can live
forever in Git history.
---
 queries-plan.md | 446 ------------------------------------------------
 1 file changed, 446 deletions(-)
 delete mode 100644 queries-plan.md

diff --git a/queries-plan.md b/queries-plan.md
deleted file mode 100644
index da6b7c92..00000000
--- a/queries-plan.md
+++ /dev/null
@@ -1,446 +0,0 @@
-# Queries in the internal database
-
-Plan for <https://github.com/simonw/datasette/issues/2735>.
-
-## Goal
-
-Move named query definitions into Datasette's internal database, so hundreds or thousands of queries can be listed, searched, permission-filtered, managed, and executed efficiently.
-
-Terminology change: these are now "queries", not "canned queries". Legacy code and documentation can mention the old name only when describing compatibility or migration.
-
-## Decisions so far
-
-- Internal table name: `queries`.
-- Query definitions should use real columns, not a JSON blob for all options.
-- Query parameter names live in a `parameters` text column as a JSON array. No default values for parameters in this pass.
-- No separate index is needed for the privacy/trust flags yet.
-- User-created queries require `execute-sql` and `insert-query` on the database. They default to private, and writable queries additionally require matching table write permissions discovered by `Database.analyze_sql()`.
-- Configured queries default to trusted, which means actors who can view them can execute them without also holding `execute-sql` or the relevant write permissions. Config can opt out with `is_trusted: false`.
-- Add `update-query` and `delete-query`, so administrators can manage queries created by other users.
-- Remove the old `canned_queries()` hook from core. If we want compatibility later, build a separate `datasette-old-canned-queries` plugin.
-- Writable user-created queries can be supported using `Database.analyze_sql()`, provided we fail closed when analysis cannot prove the required permissions.
-
-## Current shape
-
-- Query definitions currently come from `datasette.yaml` or the `canned_queries()` plugin hook.
-- `Datasette.get_canned_queries(database_name, actor)` calls that hook every time it needs query definitions.
-- `QueryResource.resources_sql()` currently enumerates databases and calls the hook for each one, because permissions and `/-/jump` need query resources.
-- Query pages are visible if the actor has `view-query` for `QueryResource(database, query)`. Executing an untrusted stored query also checks `execute-sql` or the relevant write permissions.
-- Arbitrary SQL executes if the actor has `execute-sql` for `DatabaseResource(database)`.
-
-The main performance and architecture win is making query resource enumeration a direct SQL query against the internal database.
-
-## Proposed internal schema
-
-Start with one `queries` table.
-
-```sql
-CREATE TABLE IF NOT EXISTS queries (
-    database_name TEXT NOT NULL,
-    name TEXT NOT NULL,
-    sql TEXT NOT NULL,
-    title TEXT,
-    description TEXT,
-    description_html TEXT,
-    options TEXT NOT NULL DEFAULT '{}',
-    parameters TEXT NOT NULL DEFAULT '[]',
-    is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
-    is_private INTEGER NOT NULL DEFAULT 0 CHECK (is_private IN (0, 1)),
-    is_trusted INTEGER NOT NULL DEFAULT 0 CHECK (is_trusted IN (0, 1)),
-    source TEXT NOT NULL DEFAULT 'user',
-    owner_id TEXT,
-    created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
-    updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
-    PRIMARY KEY (database_name, name)
-);
-
-CREATE INDEX IF NOT EXISTS queries_owner_idx
-    ON queries(owner_id);
-```
-
-Column notes:
-
-- `database_name`, `name`, and `sql` are the routing and execution core.
-- Display fields become columns: `title`, `description`, and `description_html`.
-- Less common presentation and writable-query behavior lives in `options`, stored as a JSON object. That covers `hide_sql`, `fragment`, `on_success_message`, `on_success_message_sql`, `on_success_redirect`, `on_error_message`, and `on_error_redirect`.
-- `parameters` is a JSON array of parameter names, stored as text. This preserves explicit parameter order, but does not support labels or default values.
-- Existing writable query behavior gets `is_write` as a column. Success/error messages, success/error redirects, and `on_success_message_sql` are stored in `options`.
-- `is_private` means the query is only visible to its owning actor. This is enforced as a permission restriction, so broader `view-query` grants do not expose private rows.
-- `is_trusted` means execution skips the usual `execute-sql` or write-permission checks after `view-query` has allowed access.
-- `source` distinguishes `user`, `config`, and `plugin` rows.
-- `owner_id` is the actor id for user-created rows. It is `NULL` for config/plugin rows.
-
-No separate index is needed on `(database_name, name)` because the primary key already creates one.
-
-`QueryResource.resources_sql()` can become:
-
-```sql
-SELECT q.database_name AS parent, q.name AS child
-FROM queries q
-JOIN catalog_databases cd ON cd.database_name = q.database_name
-```
-
-The join keeps persisted queries for detached databases from appearing as live resources.
-
-## Config and plugin migration
-
-`datasette.yaml` can continue to support `databases: {db}: queries:` blocks, but core should import them directly into the internal `queries` tables at startup:
-
-1. Ensure the internal schema exists.
-2. Delete previous `source='config'` rows.
-3. Read configured query blocks for each live database.
-4. Normalize string definitions to `{"sql": ...}`.
-5. Insert rows into `queries`, storing explicit `params` as JSON in `parameters`.
-
-Plugins should move to:
-
-```python
-await datasette.add_query(...)
-await datasette.remove_query(...)
-```
-
-Remove the old `canned_queries()` hookspec and all core calls to it. If compatibility is needed, build `datasette-old-canned-queries` later as a plugin that restores the hook and imports old hook results using `datasette.add_query()`.
-
-## Permission model
-
-Add core actions:
-
-- `insert-query`, database-level, for creating queries in a database.
-- `update-query`, query-level, for modifying existing query definitions.
-- `delete-query`, query-level, for deleting existing query definitions.
-
-User-created query creation requires:
-
-- `execute-sql` on `DatabaseResource(database)`
-- `insert-query` on `DatabaseResource(database)`
-- If analysis shows the query is writable, the table-level write permissions described in the writable query section.
-
-Updating an existing query requires:
-
-- `update-query` on `QueryResource(database, query)` or default owner permission for a user-owned row.
-- If the SQL changes, also require `execute-sql` on the database.
-- If the changed SQL is writable, also require the table-level write permissions described in the writable query section.
-
-Deleting an existing query requires:
-
-- `delete-query` on `QueryResource(database, query)` or default owner permission for a user-owned row.
-
-Default owner permissions:
-
-- For `source='user' AND owner_id = actor.id`, grant `update-query` and `delete-query`.
-- For `source='user' AND owner_id = actor.id`, grant `view-query`. If the query is private, restriction SQL ensures no other actor sees it through a broader grant.
-
-## Executing queries
-
-Default execution rule for read-only queries:
-
-- If `is_trusted=0`, the actor needs `execute-sql` on the database.
-- If `is_trusted=1`, the actor can execute the query without `execute-sql`, provided `view-query` allows access.
-
-Default execution rule for user-created writable queries:
-
-- `is_trusted` must be `0`.
-- The actor must have `view-query`.
-- The actor must currently have every write permission required by fresh `Database.analyze_sql()` results for the query SQL.
-
-Implementation:
-
-- Keep `view-query` in the broad `DEFAULT_ALLOW_ACTIONS` set, so saved queries remain visible by default in all-public Datasette.
-- Emit default `view-query` allows for the owning actor.
-- Use `restriction_sql` to limit private rows to their owner even when broader `view-query` permissions exist.
-- Have `QueryView` perform the fresh `execute-sql` or table-permission check before execution unless the row has `is_trusted=1`.
-
-For read-only queries this keeps `QueryView` explicit: it checks `view-query` for the query resource, then checks `execute-sql` unless the row is trusted. User-created writable queries need one additional runtime permission check because their required table permissions are derived from fresh SQL analysis.
-
-Explicit deny rules should still be able to block a query, and `--default-deny` still blocks trusted queries unless something grants `view-query`.
-
-## Writable queries
-
-Writable user-created queries should be in scope, guarded by `Database.analyze_sql()`.
-
-The secure rule: a user can create, update, or execute a writable user-created query only if they currently have the corresponding write permissions for every table the SQL can affect.
-
-`Database.analyze_sql(sql, params=None)` runs the SQL through SQLite's authorizer on an isolated connection and returns a `SQLAnalysis` object containing `SQLTableAccess` rows:
-
-- `operation`: `read`, `insert`, `update`, or `delete`
-- `database`: Datasette database name for `main`, or SQLite schema name where no Datasette mapping exists
-- `table`: affected table or view
-- `columns`: read/updated columns where SQLite reports them
-- `source`: trigger/view/CTE source when SQLite reports one
-
-Validation flow for user-created queries:
-
-1. Derive named parameters from the SQL and pass harmless placeholder values into `db.analyze_sql()` so SQLite can prepare statements with bindings.
-2. If analysis raises a SQLite error, reject the query.
-3. If every table access is `read`, treat the query as read-only and require `execute-sql` plus `insert-query`/`update-query` as described above.
-4. If any table access is `insert`, `update`, or `delete`, treat the query as writable and force `is_trusted=0`.
-5. Reject writable user-created queries that access a database other than the database they are being saved against, until `analyze_sql()` can reliably map attached SQLite schemas back to Datasette database names.
-6. For every write access returned by analysis, require the corresponding permission on `TableResource(access.database, access.table)`:
-   - `insert` -> `insert-row`
-   - `update` -> `update-row`
-   - `delete` -> `delete-row`
-7. Include write accesses reported from triggers and views, since those are real side effects.
-8. Re-run the same analysis and permission checks when SQL changes through `update_query()` or `POST .../-/update`.
-9. Re-run analysis before executing user-created writable queries, so schema or trigger changes cannot leave a previously saved query with stale permission assumptions.
-
-The user-facing API should not trust a submitted `is_write` value. It should derive `is_write` from analysis.
-
-Trusted configuration and plugin code can still call `datasette.add_query(..., is_write=True, ...)`. Those are treated as deployment/admin-authored queries. They keep the existing execution model: they require `view-query`, and the default `view-query` hook should preserve current default-open behavior for trusted writable queries while still respecting `--default-deny`.
-
-Fail closed cases for user-created writable queries:
-
-- Analysis fails.
-- Analysis reports any write operation that cannot be mapped to a Datasette table resource.
-- Analysis reports writes outside the target database.
-- The actor lacks any required table write permission.
-- `is_trusted=1` is requested through the user-facing API.
-
-This gives us writable user-created queries without letting `execute-sql` alone become a path to create arbitrary write endpoints.
-
-## HTTP API sketch
-
-JSON endpoints should follow Datasette's existing write API style: use `POST` plus action paths such as `/-/insert`, `/-/update`, and `/-/delete`, not HTTP `PATCH` or `DELETE`.
-
-Endpoints:
-
-- `GET /-/queries` and `GET /{database}/-/queries` show searchable HTML query browsers. `GET /-/queries.json` lists query definitions across every database the actor can view; `GET /{database}/-/queries.json` scopes that list to one database. Both JSON endpoints use cursor pagination with `_next` and `_size`.
-- `POST /{database}/-/queries/insert` creates a query.
-- `GET /{database}/{query}/-/definition` returns one query definition without executing it.
-- `POST /{database}/{query}/-/update` updates one query.
-- `POST /{database}/{query}/-/delete` deletes one query.
-
-Create request:
-
-```json
-{
-  "query": {
-    "name": "top_customers",
-    "sql": "select * from customers order by revenue desc limit 20",
-    "title": "Top customers",
-    "description": "Highest revenue customers",
-    "is_private": true,
-    "parameters": ["region"]
-  }
-}
-```
-
-Successful create returns `201` and the created query definition:
-
-```json
-{
-  "ok": true,
-  "query": {
-    "database": "fixtures",
-    "name": "top_customers",
-    "sql": "select * from customers order by revenue desc limit 20",
-    "title": "Top customers",
-    "description": "Highest revenue customers",
-    "is_private": true,
-    "is_trusted": false,
-    "parameters": ["region"]
-  }
-}
-```
-
-Update request, imitating `RowUpdateView`:
-
-```json
-{
-  "update": {
-    "title": "Top customers by revenue",
-    "is_private": false
-  },
-  "return": true
-}
-```
-
-Successful update returns `{"ok": true}` by default. With `"return": true`, return the updated query definition:
-
-```json
-{
-  "ok": true,
-  "query": {
-    "database": "fixtures",
-    "name": "top_customers",
-    "sql": "select * from customers order by revenue desc limit 20",
-    "title": "Top customers by revenue",
-    "is_private": false,
-    "is_trusted": false
-  }
-}
-```
-
-Delete request:
-
-```http
-POST /{database}/{query}/-/delete
-Content-Type: application/json
-```
-
-Successful delete returns:
-
-```json
-{
-  "ok": true
-}
-```
-
-Validation:
-
-- Update bodies must be dictionaries containing an `update` dictionary, with optional `return`; invalid keys return `{"ok": false, "errors": [...]}`.
-- Validate route-safe query names.
-- Reject names that collide with a table or view in the same database, since table routes currently win over query routes.
-- Analyze user-created SQL with `Database.analyze_sql()`.
-- Use `validate_sql_select(sql)` as the read-only fast path when analysis shows only reads, but do not require it for writable queries that pass analysis and permission checks.
-- Reject magic parameters such as `:_actor_id`, `:_cookie_*`, and `:_header_*` for user-created queries.
-- Reject client-supplied `is_write`; derive it from analysis.
-- Reject writable-only success/error fields for read-only queries.
-
-## Python API sketch
-
-Add methods on `Datasette`:
-
-```python
-await datasette.add_query(
-    database,
-    name,
-    sql,
-    title=None,
-    description=None,
-    description_html=None,
-    hide_sql=False,
-    fragment=None,
-    parameters=None,
-    is_write=False,
-    is_private=False,
-    is_trusted=False,
-    source="plugin",
-    owner_id=None,
-    on_success_message=None,
-    on_success_message_sql=None,
-    on_success_redirect=None,
-    on_error_message=None,
-    on_error_redirect=None,
-    replace=True,
-)
-
-await datasette.update_query(
-    database,
-    name,
-    *,
-    sql=UNCHANGED,
-    title=UNCHANGED,
-    description=UNCHANGED,
-    description_html=UNCHANGED,
-    hide_sql=UNCHANGED,
-    fragment=UNCHANGED,
-    parameters=UNCHANGED,
-    is_write=UNCHANGED,
-    is_private=UNCHANGED,
-    is_trusted=UNCHANGED,
-    source=UNCHANGED,
-    owner_id=UNCHANGED,
-    on_success_message=UNCHANGED,
-    on_success_message_sql=UNCHANGED,
-    on_success_redirect=UNCHANGED,
-    on_error_message=UNCHANGED,
-    on_error_redirect=UNCHANGED,
-)
-
-await datasette.remove_query(database, name, source=None)
-
-await datasette.get_query(database, name)
-await datasette.list_queries(
-    database,
-    actor=None,
-    limit=50,
-    cursor=None,
-    q=None,
-    is_write=None,
-    is_private=None,
-    is_trusted=None,
-    source=None,
-    owner_id=None,
-)
-```
-
-`list_queries()` should return a bounded page shaped like `{"queries": [...], "next": "...", "has_more": true, "limit": 50}`. The `next` value is an opaque cursor token, not an offset. Passing `database=None` lists visible queries across all live databases, still filtered through `view-query` permission SQL.
-
-`update_query()` should use an internal sentinel default such as `UNCHANGED = object()` so callers can distinguish "leave this column alone" from "set this column to `NULL`":
-
-```python
-await datasette.update_query(
-    "fixtures",
-    "top_customers",
-    on_success_redirect=None,
-)
-```
-
-For column-backed fields, `None` should write SQL `NULL`. For option fields, `None` should remove that key from the JSON object so `get_query()` returns `None`; omitting the field should leave the existing option unchanged.
-
-Implementation detail: build the `UPDATE` statement dynamically from fields whose value is not `UNCHANGED`, validate non-nullable fields before writing, and update `updated_at` whenever at least one field changes.
-
-The read methods should reconstruct the existing dictionary shape used by query execution and templates, with `name`, `sql`, display fields, write fields, `params`, `is_private`, `is_trusted`, `owner_id`, and `source`. `parameters` should be returned as the decoded JSON array and exposed as `params` where existing query execution code expects that key. Option values should be unpacked from the `options` JSON object and returned as the same top-level keys accepted by `add_query()` and `update_query()`.
-
-## Query page save UI
-
-On `/{database}/-/query`, if the actor has both `execute-sql` and `insert-query`, show a save control for valid read-only SQL. That page already executes read-only arbitrary SQL, so the first UI can stay read-only even though the JSON API can accept writable SQL after `Database.analyze_sql()` validation.
-
-The save form should call `POST /{database}/-/queries/insert` and default to `is_private=true`.
-
-On `/{database}`, show a preview of the first 5 visible queries using `list_queries(..., limit=5)`. If the page has `has_more`, show a link to `/{database}/-/queries` rather than rendering hundreds or thousands of query links inline. The full `/{database}/-/queries` page provides search, filters, and cursor pagination. The global `/-/queries` page reuses the same interface and shows the database for each query.
-
-## Dedicated create query UI
-
-Add `/{database}/-/queries/-/create` for the fuller query authoring flow, including writable queries.
-
-This page should require `execute-sql` and `insert-query` to access. It should provide a SQL editor and a mode control:
-
-- Read-only
-- Writable
-
-Read-only mode can share the same fields as the arbitrary SQL save flow: name, title, description, parameters, and privacy status.
-
-Writable mode should always run `Database.analyze_sql()` and show an analysis panel before saving:
-
-- detected operation
-- database and table
-- required permission
-- whether the actor has that permission
-- source, when the operation comes from a trigger or view
-
-The Save button should be disabled until analysis succeeds and every required table write permission is allowed.
-
-The existing edit-SQL flow from query pages can continue to point back to arbitrary SQL. A later enhancement can add "update this query" when the actor owns it or has `update-query`.
-
-## Test plan
-
-- Internal schema creates `queries`.
-- Query parameters are stored in the `queries.parameters` text column as a JSON array of names.
-- Config `queries:` blocks import into internal tables.
-- Legacy string query definitions normalize to SQL rows.
-- The old `canned_queries()` hook is no longer called by core.
-- `QueryResource.resources_sql()` returns rows from `queries`.
-- Database page and `/-/jump` list queries from the internal DB.
-- `view-query` remains globally default-allowed, with `restriction_sql` narrowing private queries to their owner.
-- Private query is only visible to its owner, even when a broader `view-query` rule applies.
-- Non-trusted read-only query requires `execute-sql` to execute.
-- Trusted read-only query can be executed without `execute-sql` after `view-query` passes.
-- Config queries default to trusted and can opt out with `is_trusted: false`.
-- User API rejects client-supplied `is_trusted`.
-- User-created query requires both `execute-sql` and `insert-query`.
-- User-created writable query creation uses `Database.analyze_sql()` and requires matching `insert-row`, `update-row`, and/or `delete-row` permissions for every reported write access.
-- `/{database}/-/queries/-/create` provides the writable-query authoring UI with an analysis panel and disabled save until all required write permissions pass.
-- User-created writable query execution re-runs `Database.analyze_sql()` and re-checks table write permissions.
-- User-created writable query cannot be trusted through the user API.
-- Query update uses `POST /{database}/{query}/-/update` with an `{"update": {...}}` body.
-- Query delete uses `POST /{database}/{query}/-/delete`.
-- There are no `PATCH` or HTTP `DELETE` routes for query management.
-- `datasette.update_query(..., field=None)` writes `NULL` for column-backed fields and removes JSON keys for option fields, while omitted fields are left unchanged.
-- Owner gets default `update-query` and `delete-query` for their own user-created rows.
-- Admin can manage other users' queries with `update-query` and `delete-query`.
-- User API rejects magic parameters.
-- User API rejects writable queries if analysis fails, reports writes outside the target database, or reports writes the actor is not allowed to perform.
-- Trusted config/plugin writable queries still execute through `view-query`.
-- Trusted config/plugin writable queries are not default-allowed under `--default-deny`.
-- Persisted internal DB does not expose queries for detached databases.

From 24887004cffd52fe801ecd73da78e13b246ddede Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 14:51:57 -0700
Subject: [PATCH 086/386] Rename insert-query to store-query

Also queries/insert to queries/store

Refs https://github.com/simonw/datasette/pull/2741#issuecomment-4549103663
---
 datasette/app.py                      |  6 ++---
 datasette/default_actions.py          |  6 ++---
 datasette/templates/query_create.html |  2 +-
 datasette/views/database.py           | 22 +++++++--------
 docs/authentication.rst               |  7 ++---
 docs/json_api.rst                     |  5 ++--
 tests/test_queries.py                 | 39 +++++++++++++++------------
 7 files changed, 47 insertions(+), 40 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 8936b099..42a2d27d 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -54,9 +54,9 @@ from .views.database import (
     QueryDeleteView,
     QueryDefinitionView,
     GlobalQueryListView,
-    QueryInsertView,
     QueryListView,
     QueryParametersView,
+    QueryStoreView,
     QueryUpdateView,
 )
 from .views.index import IndexView
@@ -2824,8 +2824,8 @@ class Datasette:
             r"/(?P<database>[^\/\.]+)/-/queries/analyze$",
         )
         add_route(
-            QueryInsertView.as_view(self),
-            r"/(?P<database>[^\/\.]+)/-/queries/insert$",
+            QueryStoreView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/queries/store$",
         )
         add_route(
             ExecuteWriteAnalyzeView.as_view(self),
diff --git a/datasette/default_actions.py b/datasette/default_actions.py
index 6a1f77b8..0f4c25fa 100644
--- a/datasette/default_actions.py
+++ b/datasette/default_actions.py
@@ -62,9 +62,9 @@ def register_actions():
             resource_class=DatabaseResource,
         ),
         Action(
-            name="insert-query",
-            abbr="iq",
-            description="Create saved queries",
+            name="store-query",
+            abbr="sq",
+            description="Create stored queries",
             resource_class=DatabaseResource,
             also_requires="execute-sql",
         ),
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index cb14ada4..f5dadbff 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -156,7 +156,7 @@ form.sql .query-create-sql textarea#sql-editor {
 
 <h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Create query</h1>
 
-<form class="sql core query-create-form" action="{{ urls.database(database) }}/-/queries/insert" method="post" data-analyze-url="{{ urls.database(database) }}/-/queries/analyze">
+<form class="sql core query-create-form" action="{{ urls.database(database) }}/-/queries/store" method="post" data-analyze-url="{{ urls.database(database) }}/-/queries/analyze">
     <div class="query-create-fields">
         <p class="query-create-field"><label for="query-title">Title</label> <input id="query-title" name="title" type="text" value="{{ title or "" }}"></p>
         <p class="query-create-field"><label for="query-url-slug">URL</label> <span class="query-create-url-control"><span class="query-create-url-prefix">{{ urls.database(database) }}/</span><input id="query-url-slug" name="name" type="text" value="{{ name or "" }}"></span></p>
diff --git a/datasette/views/database.py b/datasette/views/database.py
index d40d69d1..900b94ba 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -1419,7 +1419,7 @@ class QueryCreateView(BaseView):
             actor=request.actor,
         )
         await self.ds.ensure_permission(
-            action="insert-query",
+            action="store-query",
             resource=DatabaseResource(db.name),
             actor=request.actor,
         )
@@ -1440,11 +1440,11 @@ class QueryCreateAnalyzeView(BaseView):
         ):
             return _block_framing(_error(["Permission denied: need execute-sql"], 403))
         if not await self.ds.allowed(
-            action="insert-query",
+            action="store-query",
             resource=DatabaseResource(db.name),
             actor=request.actor,
         ):
-            return _block_framing(_error(["Permission denied: need insert-query"], 403))
+            return _block_framing(_error(["Permission denied: need store-query"], 403))
 
         invalid_keys = set(request.args) - {"sql"}
         if invalid_keys:
@@ -1462,8 +1462,8 @@ class QueryCreateAnalyzeView(BaseView):
         )
 
 
-class QueryInsertView(QueryCreateView):
-    name = "query-insert"
+class QueryStoreView(QueryCreateView):
+    name = "query-store"
 
     async def _error_response(self, request, db, query_data, message, status):
         message = _query_create_form_error_message(message)
@@ -1488,11 +1488,11 @@ class QueryInsertView(QueryCreateView):
         ):
             return _error(["Permission denied: need execute-sql"], 403)
         if not await self.ds.allowed(
-            action="insert-query",
+            action="store-query",
             resource=DatabaseResource(db.name),
             actor=request.actor,
         ):
-            return _error(["Permission denied: need insert-query"], 403)
+            return _error(["Permission denied: need store-query"], 403)
 
         is_json = False
         query_data = {}
@@ -1961,8 +1961,8 @@ class QueryView(View):
                 resource=DatabaseResource(database=database),
                 actor=request.actor,
             )
-            allow_insert_query = await datasette.allowed(
-                action="insert-query",
+            allow_store_query = await datasette.allowed(
+                action="store-query",
                 resource=DatabaseResource(database=database),
                 actor=request.actor,
             )
@@ -2020,13 +2020,13 @@ class QueryView(View):
             if (
                 not canned_query
                 and allow_execute_sql
-                and allow_insert_query
+                and allow_store_query
                 and is_validated_sql
                 and ":_" not in sql
             ):
                 save_query_url = (
                     datasette.urls.database(database)
-                    + "/-/queries/insert?"
+                    + "/-/queries/store?"
                     + urlencode({"sql": sql})
                 )
 
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 453aaa19..184fec5e 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1293,11 +1293,12 @@ Actor is allowed to view a saved query page, e.g. https://latest.datasette.io/fi
     ``query`` is the name of the query (string)
 
 .. _actions_insert_query:
+.. _actions_store_query:
 
-insert-query
-------------
+store-query
+-----------
 
-Actor is allowed to create saved queries in a database.
+Actor is allowed to create stored queries in a database.
 
 ``resource`` - ``datasette.resources.DatabaseResource(database)``
     ``database`` is the name of the database (string)
diff --git a/docs/json_api.rst b/docs/json_api.rst
index dd54c459..1a6c7021 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -518,14 +518,15 @@ Listing saved queries
 Creating saved queries in the UI
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-``GET /<database>/-/queries/-/create`` provides a form for creating saved queries.
+``GET /<database>/-/queries/store`` provides a form for creating stored queries.
 
+.. _QueryStoreView:
 .. _QueryInsertView:
 
 Creating saved queries
 ~~~~~~~~~~~~~~~~~~~~~~
 
-``POST /<database>/-/queries/insert`` creates a saved query. This requires ``execute-sql`` and ``insert-query`` for the database.
+``POST /<database>/-/queries/store`` creates a stored query. This requires ``execute-sql`` and ``store-query`` for the database.
 
 .. _QueryParametersView:
 .. _ExecuteWriteView:
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 26a0748c..5d4da9bb 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -470,7 +470,7 @@ async def test_query_actions_are_registered():
     await ds.invoke_startup()
 
     assert ds.get_action("execute-write-sql").resource_class is DatabaseResource
-    assert ds.get_action("insert-query").resource_class is DatabaseResource
+    assert ds.get_action("store-query").resource_class is DatabaseResource
     assert ds.get_action("update-query").resource_class is QueryResource
     assert ds.get_action("delete-query").resource_class is QueryResource
 
@@ -537,15 +537,15 @@ async def test_analyze_write_query_rejects_writes_to_attached_databases():
 
 
 @pytest.mark.asyncio
-async def test_query_insert_api_creates_read_only_query():
+async def test_query_store_api_creates_read_only_query():
     ds = Datasette(memory=True, default_deny=True)
     ds.root_enabled = True
-    db = ds.add_memory_database("query_insert_api", name="data")
+    db = ds.add_memory_database("query_store_api", name="data")
     await db.execute_write("create table dogs (id integer primary key, name text)")
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/insert",
+        "/data/-/queries/store",
         actor={"id": "root"},
         json={
             "query": {
@@ -860,7 +860,7 @@ async def test_global_query_list_api_and_html():
 
 
 @pytest.mark.asyncio
-async def test_query_insert_api_rejects_is_trusted():
+async def test_query_store_api_rejects_is_trusted():
     ds = Datasette(
         memory=True,
         default_deny=True,
@@ -870,7 +870,7 @@ async def test_query_insert_api_rejects_is_trusted():
                     "permissions": {
                         "view-database": {"id": "writer"},
                         "execute-sql": {"id": "writer"},
-                        "insert-query": {"id": "writer"},
+                        "store-query": {"id": "writer"},
                     }
                 }
             }
@@ -880,7 +880,7 @@ async def test_query_insert_api_rejects_is_trusted():
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/insert",
+        "/data/-/queries/store",
         actor={"id": "writer"},
         json={"query": {"name": "trusted", "sql": "select 1", "is_trusted": True}},
     )
@@ -890,7 +890,7 @@ async def test_query_insert_api_rejects_is_trusted():
 
 
 @pytest.mark.asyncio
-async def test_query_insert_api_creates_writable_query():
+async def test_query_store_api_creates_writable_query():
     ds = Datasette(memory=True, default_deny=True)
     ds.root_enabled = True
     db = ds.add_memory_database("query_write_api", name="data")
@@ -898,7 +898,7 @@ async def test_query_insert_api_creates_writable_query():
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/insert",
+        "/data/-/queries/store",
         actor={"id": "root"},
         json={
             "query": {
@@ -962,14 +962,14 @@ async def test_query_update_and_delete_api():
 
 
 @pytest.mark.asyncio
-async def test_query_insert_api_rejects_magic_parameters():
+async def test_query_store_api_rejects_magic_parameters():
     ds = Datasette(memory=True, default_deny=True)
     ds.root_enabled = True
     ds.add_memory_database("query_magic_api", name="data")
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/insert",
+        "/data/-/queries/store",
         actor={"id": "root"},
         json={"query": {"name": "magic", "sql": "select :_actor_id"}},
     )
@@ -987,15 +987,19 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
     await ds.invoke_startup()
 
     create_response = await ds.client.get(
-        "/data/-/queries/insert?sql=select+*+from+dogs",
+        "/data/-/queries/store?sql=select+*+from+dogs",
         actor={"id": "root"},
     )
     write_create_response = await ds.client.get(
-        "/data/-/queries/insert?sql=insert+into+dogs+(name)+values+('Cleo')",
+        "/data/-/queries/store?sql=insert+into+dogs+(name)+values+('Cleo')",
         actor={"id": "root"},
     )
     blank_create_response = await ds.client.get(
-        "/data/-/queries/insert",
+        "/data/-/queries/store",
+        actor={"id": "root"},
+    )
+    old_insert_response = await ds.client.get(
+        "/data/-/queries/insert?sql=select+*+from+dogs",
         actor={"id": "root"},
     )
     old_create_response = await ds.client.get(
@@ -1075,7 +1079,8 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
     )
     assert query_response.status_code == 200
     assert "Save this query" in query_response.text
-    assert "/data/-/queries/insert?sql=select+%2A+from+dogs" in query_response.text
+    assert "/data/-/queries/store?sql=select+%2A+from+dogs" in query_response.text
+    assert old_insert_response.status_code == 404
     assert old_create_response.status_code == 404
 
 
@@ -1153,7 +1158,7 @@ async def test_create_query_form_error_redisplays_form_with_values():
     await ds.invoke_startup()
 
     response = await ds.client.post(
-        "/data/-/queries/insert",
+        "/data/-/queries/store",
         actor={"id": "root"},
         data={
             "name": "dogs",
@@ -1176,7 +1181,7 @@ async def test_create_query_form_error_redisplays_form_with_values():
     assert 'name="is_private" value="1" checked' in response.text
 
     public_response = await ds.client.post(
-        "/data/-/queries/insert",
+        "/data/-/queries/store",
         actor={"id": "root"},
         data={
             "name": "dogs",

From 0cadd071871ef0b33e4ce3a23e316a104b3137c3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 14:53:31 -0700
Subject: [PATCH 087/386] No need to document QueryCreateAnalyzeView

---
 tests/test_docs.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/test_docs.py b/tests/test_docs.py
index 396ba1a2..0d0ef1e1 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -66,7 +66,14 @@ def documented_views():
             if first_word.endswith("View"):
                 view_labels.add(first_word)
     # We deliberately don't document these:
-    view_labels.update(("PatternPortfolioView", "AuthTokenView", "ApiExplorerView"))
+    view_labels.update(
+        (
+            "PatternPortfolioView",
+            "AuthTokenView",
+            "ApiExplorerView",
+            "QueryCreateAnalyzeView",
+        )
+    )
     return view_labels
 
 

From 4bf1c4b065fef64676abf5eabd04ff35e07188c5 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 14:54:35 -0700
Subject: [PATCH 088/386] Rename canned queries to queries/stored queries in
 docs

---
 datasette/default_actions.py |  4 +-
 datasette/hookspecs.py       |  4 +-
 datasette/resources.py       |  2 +-
 datasette/views/database.py  | 24 ++++-----
 datasette/views/table.py     |  4 +-
 docs/authentication.rst      | 16 +++---
 docs/configuration.rst       | 10 ++--
 docs/custom_templates.rst    |  8 +--
 docs/internals.rst           | 12 ++---
 docs/introspection.rst       |  2 +-
 docs/json_api.rst            | 32 ++++++------
 docs/pages.rst               |  4 +-
 docs/plugin_hooks.rst        | 16 +++---
 docs/spatialite.rst          |  2 +-
 docs/sql_queries.rst         | 95 ++++++++++++++++++++++++++----------
 tests/test_html.py           |  6 +--
 tests/test_permissions.py    |  4 +-
 17 files changed, 144 insertions(+), 101 deletions(-)

diff --git a/datasette/default_actions.py b/datasette/default_actions.py
index 0f4c25fa..2f78570b 100644
--- a/datasette/default_actions.py
+++ b/datasette/default_actions.py
@@ -121,13 +121,13 @@ def register_actions():
         Action(
             name="update-query",
             abbr="uq",
-            description="Update saved queries",
+            description="Update stored queries",
             resource_class=QueryResource,
         ),
         Action(
             name="delete-query",
             abbr="dq",
-            description="Delete saved queries",
+            description="Delete stored queries",
             resource_class=QueryResource,
         ),
     )
diff --git a/datasette/hookspecs.py b/datasette/hookspecs.py
index a4067eaa..22da02a4 100644
--- a/datasette/hookspecs.py
+++ b/datasette/hookspecs.py
@@ -174,7 +174,7 @@ def view_actions(datasette, actor, database, view, request):
 
 @hookspec
 def query_actions(datasette, actor, database, query_name, request, sql, params):
-    """Links for the query and canned query actions menu"""
+    """Links for the query and stored query actions menu"""
 
 
 @hookspec
@@ -229,7 +229,7 @@ def top_query(datasette, request, database, sql):
 
 @hookspec
 def top_canned_query(datasette, request, database, query_name):
-    """HTML to include at the top of the canned query page"""
+    """HTML to include at the top of the stored query page"""
 
 
 @hookspec
diff --git a/datasette/resources.py b/datasette/resources.py
index 91a46d36..ee2e6d98 100644
--- a/datasette/resources.py
+++ b/datasette/resources.py
@@ -41,7 +41,7 @@ class TableResource(Resource):
 
 
 class QueryResource(Resource):
-    """A saved query in a database."""
+    """A stored query in a database."""
 
     name = "query"
     parent_class = DatabaseResource
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 900b94ba..f30d3815 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -222,11 +222,11 @@ class DatabaseContext(Context):
     tables: list = field(metadata={"help": "List of table objects in the database"})
     hidden_count: int = field(metadata={"help": "Count of hidden tables"})
     views: list = field(metadata={"help": "List of view objects in the database"})
-    queries: list = field(metadata={"help": "List of canned query objects"})
+    queries: list = field(metadata={"help": "List of stored query objects"})
     queries_more: bool = field(
-        metadata={"help": "Boolean indicating if more saved queries are available"}
+        metadata={"help": "Boolean indicating if more stored queries are available"}
     )
-    queries_count: int = field(metadata={"help": "Count of visible saved queries"})
+    queries_count: int = field(metadata={"help": "Count of visible stored queries"})
     allow_execute_sql: bool = field(
         metadata={"help": "Boolean indicating if custom SQL can be executed"}
     )
@@ -272,7 +272,7 @@ class QueryContext(Context):
         metadata={"help": "The SQL query object containing the `sql` string"}
     )
     canned_query: str = field(
-        metadata={"help": "The name of the canned query if this is a canned query"}
+        metadata={"help": "The name of the stored query if this is a stored query"}
     )
     private: bool = field(
         metadata={"help": "Boolean indicating if this is a private database"}
@@ -282,11 +282,11 @@ class QueryContext(Context):
     # )
     canned_query_write: bool = field(
         metadata={
-            "help": "Boolean indicating if this is a canned query that allows writes"
+            "help": "Boolean indicating if this is a stored query that allows writes"
         }
     )
     metadata: dict = field(
-        metadata={"help": "Metadata about the database or the canned query"}
+        metadata={"help": "Metadata about the database or the stored query"}
     )
     db_is_immutable: bool = field(
         metadata={"help": "Boolean indicating if this database is immutable"}
@@ -315,7 +315,7 @@ class QueryContext(Context):
         metadata={"help": "Dictionary of parameter names/values"}
     )
     edit_sql_url: str = field(
-        metadata={"help": "URL to edit the SQL for a canned query"}
+        metadata={"help": "URL to edit the SQL for a stored query"}
     )
     display_rows: list = field(metadata={"help": "List of result rows to display"})
     columns: list = field(metadata={"help": "List of column names"})
@@ -1623,7 +1623,7 @@ class QueryView(View):
 
         db = await datasette.resolve_database(request)
 
-        # We must be a canned query
+        # We must be a stored query
         table_found = False
         try:
             await datasette.resolve_table(request)
@@ -1742,14 +1742,14 @@ class QueryView(View):
         # Create lookup dict for quick access
         allowed_dict = {r.child: r for r in allowed_tables_page.resources}
 
-        # Are we a canned query?
+        # Are we a stored query?
         canned_query = None
         canned_query_write = False
         if "table" in request.url_vars:
             try:
                 await datasette.resolve_table(request)
             except TableNotFound as table_not_found:
-                # Was this actually a canned query?
+                # Was this actually a stored query?
                 canned_query = await datasette.get_canned_query(
                     table_not_found.database_name, table_not_found.table, request.actor
                 )
@@ -1759,7 +1759,7 @@ class QueryView(View):
 
         private = False
         if canned_query:
-            # Respect canned query permissions
+            # Respect stored query permissions
             visible, private = await datasette.check_visibility(
                 request.actor,
                 action="view-query",
@@ -1823,7 +1823,7 @@ class QueryView(View):
                     # For regular queries we only allow SELECT, plus other rules
                     validate_sql_select(sql)
                 else:
-                    # Canned queries can run magic parameters
+                    # Stored queries can run magic parameters
                     params_for_query = MagicParameters(sql, params, request, datasette)
                     await params_for_query.execute_params()
                 results = await datasette.execute(
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 7027bb10..7b1a5a82 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -963,11 +963,11 @@ async def table_view_traced(datasette, request):
     try:
         resolved = await datasette.resolve_table(request)
     except TableNotFound as not_found:
-        # Was this actually a canned query?
+        # Was this actually a stored query?
         canned_query = await datasette.get_canned_query(
             not_found.database_name, not_found.table, request.actor
         )
-        # If this is a canned query, not a table, then dispatch to QueryView instead
+        # If this is a stored query, not a table, then dispatch to QueryView instead
         if canned_query:
             return await QueryView()(request, datasette)
         else:
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 184fec5e..22db41d8 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -468,7 +468,7 @@ You can control the following:
 * Access to the entire Datasette instance
 * Access to specific databases
 * Access to specific tables and views
-* Access to specific :ref:`canned_queries`
+* Access to specific :ref:`queries <canned_queries>`
 
 If a user has permission to view a table they will be able to view that table, independent of if they have permission to view the database or instance that the table exists within.
 
@@ -641,12 +641,12 @@ This works for SQL views as well - you can list their names in the ``"tables"``
 
 .. _authentication_permissions_query:
 
-Access to specific canned queries
----------------------------------
+Access to specific queries
+--------------------------
 
-:ref:`canned_queries` allow you to configure named SQL queries in your ``datasette.yaml`` that can be executed by users. These queries can be set up to both read and write to the database, so controlling who can execute them can be important.
+:ref:`Queries <canned_queries>` allow you to configure named SQL queries in your ``datasette.yaml`` that can be executed by users. These queries can be set up to both read and write to the database, so controlling who can execute them can be important.
 
-To limit access to the ``add_name`` canned query in your ``dogs.db`` database to just the :ref:`root user<authentication_root>`:
+To limit access to the ``add_name`` query in your ``dogs.db`` database to just the :ref:`root user<authentication_root>`:
 
 .. [[[cog
     config_example(cog, """
@@ -1285,7 +1285,7 @@ Actor is allowed to view a table (or view) page, e.g. https://latest.datasette.i
 view-query
 ----------
 
-Actor is allowed to view a saved query page, e.g. https://latest.datasette.io/fixtures/pragma_cache_size. Executing an untrusted saved query also requires ``execute-sql`` or the relevant write permissions; trusted saved queries can execute with ``view-query`` alone.
+Actor is allowed to view a stored query page, e.g. https://latest.datasette.io/fixtures/pragma_cache_size. Executing an untrusted stored query also requires ``execute-sql`` or the relevant write permissions; :ref:`trusted stored queries <trusted_stored_queries>` can execute with ``view-query`` alone.
 
 ``resource`` - ``datasette.resources.QueryResource(database, query)``
     ``database`` is the name of the database (string)
@@ -1308,7 +1308,7 @@ Actor is allowed to create stored queries in a database.
 update-query
 ------------
 
-Actor is allowed to update a saved query.
+Actor is allowed to update a stored query.
 
 ``resource`` - ``datasette.resources.QueryResource(database, query)``
     ``database`` is the name of the database (string)
@@ -1320,7 +1320,7 @@ Actor is allowed to update a saved query.
 delete-query
 ------------
 
-Actor is allowed to delete a saved query.
+Actor is allowed to delete a stored query.
 
 ``resource`` - ``datasette.resources.QueryResource(database, query)``
     ``database`` is the name of the database (string)
diff --git a/docs/configuration.rst b/docs/configuration.rst
index 8c8c8a67..cf9590b8 100644
--- a/docs/configuration.rst
+++ b/docs/configuration.rst
@@ -87,6 +87,7 @@ This is equivalent to a ``datasette.yaml`` file containing the following:
         }
 .. [[[end]]]
 
+
 .. _configuration_reference:
 
 ``datasette.yaml`` reference
@@ -435,10 +436,10 @@ Here is a simple example:
 
 .. _configuration_reference_canned_queries:
 
-Canned queries configuration
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Queries configuration
+~~~~~~~~~~~~~~~~~~~~~
 
-:ref:`Canned queries <canned_queries>` are named SQL queries that appear in the Datasette interface. They can be configured in ``datasette.yaml`` using the ``queries`` key at the database level:
+:ref:`Queries <canned_queries>` are named SQL queries that appear in the Datasette interface. They can be configured in ``datasette.yaml`` using the ``queries`` key at the database level:
 
 .. [[[cog
     from metadata_doc import config_example, config_example
@@ -483,7 +484,7 @@ Canned queries configuration
         }
 .. [[[end]]]
 
-See the :ref:`canned queries documentation <canned_queries>` for more, including how to configure :ref:`writable canned queries <canned_queries_writable>`.
+See the :ref:`queries documentation <canned_queries>` for more, including how to configure :ref:`writable queries <canned_queries_writable>`.
 
 .. _configuration_reference_css_js:
 
@@ -1211,4 +1212,3 @@ For column types that accept additional configuration, use an object with ``type
           }
         }
 .. [[[end]]]
-
diff --git a/docs/custom_templates.rst b/docs/custom_templates.rst
index 8cc40f0f..c324fb79 100644
--- a/docs/custom_templates.rst
+++ b/docs/custom_templates.rst
@@ -29,7 +29,7 @@ The custom SQL template (``/dbname?sql=...``) gets this:
 
     <body class="query db-dbname">
 
-A canned query template (``/dbname/queryname``) gets this:
+A stored query template (``/dbname/queryname``) gets this:
 
 .. code-block:: html
 
@@ -193,8 +193,8 @@ The lookup rules Datasette uses are as follows::
         query-mydatabase.html
         query.html
 
-    Canned query page (/mydatabase/canned-query):
-        query-mydatabase-canned-query.html
+    Stored query page (/mydatabase/query-name):
+        query-mydatabase-query-name.html
         query-mydatabase.html
         query.html
 
@@ -230,7 +230,7 @@ will look something like this::
 
     <!-- Templates considered: *query-mydb-tz.html, query-mydb.html, query.html -->
 
-This example is from the canned query page for a query called "tz" in the
+This example is from the stored query page for a query called "tz" in the
 database called "mydb". The asterisk shows which template was selected - so in
 this case, Datasette found a template file called ``query-mydb-tz.html`` and
 used that - but if that template had not been found, it would have tried for
diff --git a/docs/internals.rst b/docs/internals.rst
index c76de487..084922f8 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -725,7 +725,7 @@ The builder methods are:
 
 - ``allow_all(action)`` - allow an action across all databases and resources
 - ``allow_database(database, action)`` - allow an action on a specific database
-- ``allow_resource(database, resource, action)`` - allow an action on a specific resource (table, SQL view or :ref:`canned query <canned_queries>`) within a database
+- ``allow_resource(database, resource, action)`` - allow an action on a specific resource (table, SQL view or :ref:`stored query <stored_queries>`) within a database
 
 Each method returns the ``TokenRestrictions`` instance so calls can be chained.
 
@@ -837,10 +837,10 @@ await .get_resource_metadata(self, database_name, resource_name)
 ``database_name`` - string
     The name of the database to query.
 ``resource_name`` - string
-    The name of the resource (table, view, or canned query) inside ``database_name`` to query.
+    The name of the resource (table, view, or stored query) inside ``database_name`` to query.
 
 Returns metadata keys and values for the specified "resource" as a dictionary.
-A "resource" in this context can be a table, view, or canned query.
+A "resource" in this context can be a table, view, or stored query.
 Internally queries the ``metadata_resources`` table inside the :ref:`internal database <internals_internal>`.
 
 .. _datasette_get_column_metadata:
@@ -851,7 +851,7 @@ await .get_column_metadata(self, database_name, resource_name, column_name)
 ``database_name`` - string
     The name of the database to query.
 ``resource_name`` - string
-    The name of the resource (table, view, or canned query) inside ``database_name`` to query.
+    The name of the resource (table, view, or stored query) inside ``database_name`` to query.
 ``column_name`` - string
     The name of the column inside ``resource_name`` to query.
 
@@ -897,7 +897,7 @@ await .set_resource_metadata(self, database_name, resource_name, key, value)
 ``database_name`` - string
     The database the metadata entry belongs to.
 ``resource_name`` - string
-    The resource (table, view, or canned query) the metadata entry belongs to.
+    The resource (table, view, or stored query) the metadata entry belongs to.
 ``key`` - string
     The metadata entry key to insert (ex ``title``, ``description``, etc.)
 ``value`` - string
@@ -915,7 +915,7 @@ await .set_column_metadata(self, database_name, resource_name, column_name, key,
 ``database_name`` - string
     The database the metadata entry belongs to.
 ``resource_name`` - string
-    The resource (table, view, or canned query) the metadata entry belongs to.
+    The resource (table, view, or stored query) the metadata entry belongs to.
 ``column-name`` - string
     The column the metadata entry belongs to.
 ``key`` - string
diff --git a/docs/introspection.rst b/docs/introspection.rst
index d2eb8efd..7702a4b5 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -149,7 +149,7 @@ Shows currently attached databases. `Databases example <https://latest.datasette
 /-/jump
 -------
 
-Returns a JSON list of items that the current actor has permission to view for Datasette's jump menu. By default this includes visible databases, tables, views and canned queries, and plugins can contribute additional items.
+Returns a JSON list of items that the current actor has permission to view for Datasette's jump menu. By default this includes visible databases, tables, views and stored queries, and plugins can contribute additional items.
 
 Each item includes a ``type`` string used as a category label in the menu. Items can also include an optional ``description`` with longer text describing that individual result.
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 1a6c7021..a605c116 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -508,23 +508,23 @@ Datasette provides a write API for JSON data. This is a POST-only API that requi
 .. _GlobalQueryListView:
 .. _QueryListView:
 
-Listing saved queries
-~~~~~~~~~~~~~~~~~~~~~
+Listing stored queries
+~~~~~~~~~~~~~~~~~~~~~~
 
-``GET /-/queries.json`` returns saved query definitions across every database that the actor can view. ``GET /<database>/-/queries.json`` returns saved query definitions for a specific database. Use ``?_size=50`` to set the page size and ``?_next=...`` with the cursor returned by the previous page to fetch the next page.
+``GET /-/queries.json`` returns stored query definitions across every database that the actor can view. ``GET /<database>/-/queries.json`` returns stored query definitions for a specific database. Use ``?_size=50`` to set the page size and ``?_next=...`` with the cursor returned by the previous page to fetch the next page.
 
 .. _QueryCreateView:
 
-Creating saved queries in the UI
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Creating stored queries in the UI
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 ``GET /<database>/-/queries/store`` provides a form for creating stored queries.
 
 .. _QueryStoreView:
 .. _QueryInsertView:
 
-Creating saved queries
-~~~~~~~~~~~~~~~~~~~~~~
+Creating stored queries
+~~~~~~~~~~~~~~~~~~~~~~~
 
 ``POST /<database>/-/queries/store`` creates a stored query. This requires ``execute-sql`` and ``store-query`` for the database.
 
@@ -545,24 +545,24 @@ Executing write SQL
 
 .. _QueryDefinitionView:
 
-Getting a saved query definition
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Getting a stored query definition
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-``GET /<database>/<query>/-/definition`` returns a saved query definition without executing it.
+``GET /<database>/<query>/-/definition`` returns a stored query definition without executing it.
 
 .. _QueryUpdateView:
 
-Updating saved queries
-~~~~~~~~~~~~~~~~~~~~~~
+Updating stored queries
+~~~~~~~~~~~~~~~~~~~~~~~
 
-``POST /<database>/<query>/-/update`` updates a saved query using a JSON body with an ``"update"`` object.
+``POST /<database>/<query>/-/update`` updates a stored query using a JSON body with an ``"update"`` object.
 
 .. _QueryDeleteView:
 
-Deleting saved queries
-~~~~~~~~~~~~~~~~~~~~~~
+Deleting stored queries
+~~~~~~~~~~~~~~~~~~~~~~~
 
-``POST /<database>/<query>/-/delete`` deletes a saved query.
+``POST /<database>/<query>/-/delete`` deletes a stored query.
 
 .. _TableInsertView:
 
diff --git a/docs/pages.rst b/docs/pages.rst
index 34c851a5..e57c15e6 100644
--- a/docs/pages.rst
+++ b/docs/pages.rst
@@ -28,7 +28,7 @@ The index page can also be accessed at ``/-/``, useful for if the default index
 Database
 ========
 
-Each database has a page listing the tables, views and canned queries available for that database. If the :ref:`actions_execute_sql` permission is enabled (it's on by default) there will also be an interface for executing arbitrary SQL select queries against the data.
+Each database has a page listing the tables, views and stored queries available for that database. If the :ref:`actions_execute_sql` permission is enabled (it's on by default) there will also be an interface for executing arbitrary SQL select queries against the data.
 
 Examples:
 
@@ -68,7 +68,7 @@ This means you can link directly to a query by constructing the following URL:
 
 ``/database-name/-/query?sql=SELECT+*+FROM+table_name``
 
-Each configured :ref:`canned query <canned_queries>` has its own page, at ``/database-name/query-name``. Viewing this page will execute the query and display the results.
+Each configured :ref:`stored query <stored_queries>` has its own page, at ``/database-name/query-name``. Viewing this page will execute the query and display the results.
 
 In both cases adding a ``.json`` extension to the URL will return the results as JSON.
 
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index b2676b3e..264b473e 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -609,7 +609,7 @@ When a request is received, the ``"render"`` callback function is called with ze
     The SQL query that was executed.
 
 ``query_name`` - string or None
-    If this was the execution of a :ref:`canned query <canned_queries>`, the name of that query.
+    If this was the execution of a :ref:`stored query <stored_queries>`, the name of that query.
 
 ``database`` - string
     The name of the database.
@@ -1212,7 +1212,7 @@ Examples: `datasette-saved-queries <https://datasette.io/plugins/datasette-saved
 canned_queries(datasette, database, actor)
 ------------------------------------------
 
-This hook has been removed. Plugins that need to add saved queries should use
+This hook has been removed. Plugins that need to add stored queries should use
 the :ref:`plugin_hook_startup` hook and call ``await datasette.add_query(...)``.
 
 Example: `datasette-saved-queries <https://datasette.io/plugins/datasette-saved-queries>`__
@@ -1635,7 +1635,7 @@ register_magic_parameters(datasette)
 ``datasette`` - :ref:`internals_datasette`
     You can use this to access plugin configuration options via ``datasette.plugin_config(your_plugin_name)``.
 
-:ref:`canned_queries_magic_parameters` can be used to add automatic parameters to :ref:`canned queries <canned_queries>`. This plugin hook allows additional magic parameters to be defined by plugins.
+:ref:`canned_queries_magic_parameters` can be used to add automatic parameters to :ref:`configured queries <canned_queries>`. This plugin hook allows additional magic parameters to be defined by plugins.
 
 Magic parameters all take this format: ``_prefix_rest_of_parameter``. The prefix indicates which magic parameter function should be called - the rest of the parameter is passed as an argument to that function.
 
@@ -1828,7 +1828,7 @@ jump_items_sql(datasette, actor, request)
 
 This hook allows plugins to add extra results to Datasette's ``/`` jump menu, which is powered by the ``/-/jump`` JSON endpoint.
 
-Return a ``datasette.jump.JumpSQL`` object, or a list of ``JumpSQL`` objects. Each ``JumpSQL`` object wraps a SQL query to be searched alongside Datasette's own databases, tables, views and canned query results. The hook can also be an ``async def`` function, or return an awaitable that resolves to one of these values.
+Return a ``datasette.jump.JumpSQL`` object, or a list of ``JumpSQL`` objects. Each ``JumpSQL`` object wraps a SQL query to be searched alongside Datasette's own databases, tables, views and stored query results. The hook can also be an ``async def`` function, or return an awaitable that resolves to one of these values.
 
 ``JumpSQL`` queries run against Datasette's internal database by default. To run a query against another database, pass its name as the optional ``database=`` argument. For example, ``JumpSQL(database="content", sql="...")`` runs against the ``content`` database.
 
@@ -2004,7 +2004,7 @@ query_actions(datasette, actor, database, query_name, request, sql, params)
     The name of the database.
 
 ``query_name`` - string or None
-    The name of the canned query, or ``None`` if this is an arbitrary SQL query.
+    The name of the stored query, or ``None`` if this is an arbitrary SQL query.
 
 ``request`` - :ref:`internals_request`
     The current HTTP request.
@@ -2015,7 +2015,7 @@ query_actions(datasette, actor, database, query_name, request, sql, params)
 ``params`` - dictionary
     The parameters passed to the SQL query, if any.
 
-Populates a "Query actions" menu on the canned query and arbitrary SQL query pages.
+Populates a "Query actions" menu on the stored query and arbitrary SQL query pages.
 
 This example adds a new query action linking to a page for explaining a query:
 
@@ -2294,9 +2294,9 @@ top_canned_query(datasette, request, database, query_name)
     The name of the database.
 
 ``query_name`` - string
-    The name of the canned query.
+    The name of the stored query.
 
-Returns HTML to be displayed at the top of the canned query page.
+Returns HTML to be displayed at the top of the stored query page.
 
 .. _plugin_event_tracking:
 
diff --git a/docs/spatialite.rst b/docs/spatialite.rst
index c93c1e00..1999ab78 100644
--- a/docs/spatialite.rst
+++ b/docs/spatialite.rst
@@ -30,7 +30,7 @@ Warning
     The following steps are recommended:
 
     - Disable arbitrary SQL queries by untrusted users. See :ref:`authentication_permissions_execute_sql` for ways to do this. The easiest is to start Datasette with the ``datasette --setting default_allow_sql off`` option.
-    - Define :ref:`canned_queries` with the SQL queries that use SpatiaLite functions that you want people to be able to execute.
+    - Define :ref:`queries <canned_queries>` with the SQL queries that use SpatiaLite functions that you want people to be able to execute.
 
     The `Datasette SpatiaLite tutorial <https://datasette.io/tutorials/spatialite>`__ includes detailed instructions for running SpatiaLite safely using these techniques
 
diff --git a/docs/sql_queries.rst b/docs/sql_queries.rst
index 7c3cd4ac..d60656e3 100644
--- a/docs/sql_queries.rst
+++ b/docs/sql_queries.rst
@@ -68,10 +68,10 @@ You can also use the `sqlite-utils <https://sqlite-utils.datasette.io/>`__ tool
 
 .. _canned_queries:
 
-Canned queries
---------------
+Queries
+-------
 
-As an alternative to adding views to your database, you can define canned queries inside your ``datasette.yaml`` file. Here's an example:
+As an alternative to adding views to your database, you can define named queries inside your ``datasette.yaml`` file. Here's an example:
 
 .. [[[cog
     from metadata_doc import config_example, config_example
@@ -120,24 +120,67 @@ Then run Datasette like this::
 
     datasette sf-trees.db -m metadata.json
 
-Each canned query will be listed on the database index page, and will also get its own URL at::
+Each configured query will be listed on the database index page, and will also get its own URL at::
 
-    /database-name/canned-query-name
+    /database-name/query-name
 
 For the above example, that URL would be::
 
     /sf-trees/just_species
 
-You can optionally include ``"title"`` and ``"description"`` keys to show a title and description on the canned query page. As with regular table metadata you can alternatively specify ``"description_html"`` to have your description rendered as HTML (rather than having HTML special characters escaped).
+You can optionally include ``"title"`` and ``"description"`` keys to show a title and description on the query page. As with regular table metadata you can alternatively specify ``"description_html"`` to have your description rendered as HTML (rather than having HTML special characters escaped).
+
+.. _stored_queries:
+.. _saved_queries:
+
+Stored queries
+~~~~~~~~~~~~~~
+
+Datasette stores both configured queries and user-created queries in the ``queries`` table in the :ref:`internal database <internals_internal>`. Configured queries come from the ``queries`` section of ``datasette.yaml``. User-created stored queries can be created from the SQL query page by actors with the :ref:`actions_store_query` and :ref:`actions_execute_sql` permissions. Writable stored queries also require the permissions needed for the writes they perform.
+
+Stored queries created by users default to private. Private stored queries can only be viewed, updated or deleted by the actor that created them. Broad ``view-query``, ``update-query`` or ``delete-query`` permission grants still do not allow other actors to access another actor's private stored queries.
+
+Stored queries created by users are untrusted. This means they execute using the permissions of the actor who runs them, as if that actor had pasted the SQL into the regular custom SQL interface or write SQL interface. Read-only stored queries require ``execute-sql``. Writable stored queries require ``execute-write-sql`` plus the relevant table-level write permissions.
+
+.. _trusted_stored_queries:
+.. _trusted_saved_queries:
+
+Trusted stored queries
+++++++++++++++++++++++
+
+A trusted stored query can execute with ``view-query`` permission alone. It skips the additional ``execute-sql`` and write permission checks that are applied to untrusted stored queries.
+
+Trusted stored queries should only be used for SQL that has been reviewed by someone trusted to configure the Datasette instance. For that reason, trusted stored queries can only be added using configuration. Users cannot create trusted stored queries through the web interface or the stored query JSON API.
+
+Queries defined in ``datasette.yaml`` are trusted by default:
+
+.. code-block:: yaml
+
+    databases:
+      mydatabase:
+        queries:
+          report:
+            sql: select * from report
+
+You can opt out of this behavior for a configured query using ``is_trusted: false``:
+
+.. code-block:: yaml
+
+    databases:
+      mydatabase:
+        queries:
+          report:
+            sql: select * from report
+            is_trusted: false
 
 .. _canned_queries_named_parameters:
 
-Canned query parameters
-~~~~~~~~~~~~~~~~~~~~~~~
+Query parameters
+~~~~~~~~~~~~~~~~
 
-Canned queries support named parameters, so if you include those in the SQL you will then be able to enter them using the form fields on the canned query page or by adding them to the URL. This means canned queries can be used to create custom JSON APIs based on a carefully designed SQL statement.
+Configured queries support named parameters, so if you include those in the SQL you will then be able to enter them using the form fields on the query page or by adding them to the URL. This means configured queries can be used to create custom JSON APIs based on a carefully designed SQL statement.
 
-Here's an example of a canned query with a named parameter:
+Here's an example of a configured query with a named parameter:
 
 .. code-block:: sql
 
@@ -147,7 +190,7 @@ Here's an example of a canned query with a named parameter:
     where neighborhood like '%' || :text || '%'
     order by neighborhood;
 
-In the canned query configuration looks like this:
+The query configuration looks like this:
 
 
 .. [[[cog
@@ -204,7 +247,7 @@ In the canned query configuration looks like this:
 
 Note that we are using SQLite string concatenation here - the ``||`` operator - to add wildcard ``%`` characters to the string provided by the user.
 
-You can try this canned query out here:
+You can try this query out here:
 https://latest.datasette.io/fixtures/neighborhood_search?text=town
 
 In this example the ``:text`` named parameter is automatically extracted from the query using a regular expression.
@@ -272,15 +315,15 @@ You can alternatively provide an explicit list of named parameters using the ``"
 
 .. _canned_queries_options:
 
-Additional canned query options
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Additional query options
+~~~~~~~~~~~~~~~~~~~~~~~~
 
-Additional options can be specified for canned queries in the YAML or JSON configuration.
+Additional options can be specified for configured queries in the YAML or JSON configuration.
 
 hide_sql
 ++++++++
 
-Canned queries default to displaying their SQL query at the top of the page. If the query is extremely long you may want to hide it by default, with a "show" link that can be used to make it visible.
+Configured queries default to displaying their SQL query at the top of the page. If the query is extremely long you may want to hide it by default, with a "show" link that can be used to make it visible.
 
 Add the ``"hide_sql": true`` option to hide the SQL query by default.
 
@@ -289,7 +332,7 @@ fragment
 
 Some plugins, such as `datasette-vega <https://github.com/simonw/datasette-vega>`__, can be configured by including additional data in the fragment hash of the URL - the bit that comes after a ``#`` symbol.
 
-You can set a default fragment hash that will be included in the link to the canned query from the database index page using the ``"fragment"`` key.
+You can set a default fragment hash that will be included in the link to the query from the database index page using the ``"fragment"`` key.
 
 This example demonstrates both ``fragment`` and ``hide_sql``:
 
@@ -348,12 +391,12 @@ This example demonstrates both ``fragment`` and ``hide_sql``:
 
 .. _canned_queries_writable:
 
-Writable canned queries
-~~~~~~~~~~~~~~~~~~~~~~~
+Writable queries
+~~~~~~~~~~~~~~~~
 
-Canned queries by default are read-only. You can use the ``"write": true`` key to indicate that a canned query can write to the database.
+Configured queries are read-only by default. You can use the ``"write": true`` key to indicate that a query can write to the database.
 
-See :ref:`authentication_permissions_query` for details on how to add permission checks to canned queries, using the ``"allow"`` key.
+See :ref:`authentication_permissions_query` for details on how to add permission checks to queries, using the ``"allow"`` key.
 
 .. [[[cog
     config_example(cog, {
@@ -488,7 +531,7 @@ Magic parameters
 
 Named parameters that start with an underscore are special: they can be used to automatically add values created by Datasette that are not contained in the incoming form fields or query string.
 
-These magic parameters are only supported for canned queries: to avoid security issues (such as queries that extract the user's private cookies) they are not available to SQL that is executed by the user as a custom SQL query.
+These magic parameters are only supported for configured queries: to avoid security issues (such as queries that extract the user's private cookies) they are not available to SQL that is executed by the user as a custom SQL query.
 
 Available magic parameters are:
 
@@ -580,12 +623,12 @@ Additional custom magic parameters can be added by plugins using the :ref:`plugi
 
 .. _canned_queries_json_api:
 
-JSON API for writable canned queries
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+JSON API for writable queries
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-Writable canned queries can also be accessed using a JSON API. You can POST data to them using JSON, and you can request that their response is returned to you as JSON.
+Writable queries can also be accessed using a JSON API. You can POST data to them using JSON, and you can request that their response is returned to you as JSON.
 
-To submit JSON to a writable canned query, encode key/value parameters as a JSON document::
+To submit JSON to a writable query, encode key/value parameters as a JSON document::
 
     POST /mydatabase/add_message
 
diff --git a/tests/test_html.py b/tests/test_html.py
index 9e460da1..8edb9f6e 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -154,7 +154,7 @@ async def test_database_page(ds_client):
         ("/fixtures/simple_view", "simple_view"),
     ] == sorted([(a["href"], a.text) for a in views_ul.find_all("a")])
 
-    # And a list of canned queries
+    # And a list of stored queries
     queries_ul = soup.find("h2", string="Queries").find_next_sibling("ul")
     assert queries_ul is not None
     assert [
@@ -701,7 +701,7 @@ async def test_show_hide_sql_query(ds_client):
 
 @pytest.mark.asyncio
 async def test_canned_query_with_hide_has_no_hidden_sql(ds_client):
-    # For a canned query the show/hide should NOT have a hidden SQL field
+    # For a stored query the show/hide should NOT have a hidden SQL field
     # https://github.com/simonw/datasette/issues/1411
     response = await ds_client.get("/fixtures/pragma_cache_size?_hide_sql=1")
     soup = Soup(response.content, "html.parser")
@@ -1106,7 +1106,7 @@ async def test_trace_correctly_escaped(ds_client):
             "/fixtures/-/query?sql=select+*+from+facetable",
             "http://localhost/fixtures/-/query.json?sql=select+*+from+facetable",
         ),
-        # Canned query page
+        # Stored query page
         (
             "/fixtures/neighborhood_search?text=town",
             "http://localhost/fixtures/neighborhood_search.json?text=town",
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index eb6cee9f..0e38c876 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -890,7 +890,7 @@ PermConfigTestCase = collections.namedtuple(
             resource=("perms_ds_one", "t1"),
             expected_result=True,
         ),
-        # view-query on canned query, wrong actor
+        # view-query on stored query, wrong actor
         PermConfigTestCase(
             config={
                 "databases": {
@@ -909,7 +909,7 @@ PermConfigTestCase = collections.namedtuple(
             resource=("perms_ds_one", "q1"),
             expected_result=False,
         ),
-        # view-query on canned query, right actor
+        # view-query on stored query, right actor
         PermConfigTestCase(
             config={
                 "databases": {

From b1029acc68626c2fddf7b678adc3339be0fce6e0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:05:41 -0700
Subject: [PATCH 089/386] top_canned_query is now top_stored_query, closes
 #2747

---
 datasette/hookspecs.py         |  2 +-
 datasette/templates/query.html |  2 +-
 datasette/views/database.py    |  8 ++++----
 docs/changelog.rst             |  1 +
 docs/plugin_hooks.rst          |  4 ++--
 tests/test_plugins.py          | 10 ++++++----
 6 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/datasette/hookspecs.py b/datasette/hookspecs.py
index 22da02a4..dcd502af 100644
--- a/datasette/hookspecs.py
+++ b/datasette/hookspecs.py
@@ -228,7 +228,7 @@ def top_query(datasette, request, database, sql):
 
 
 @hookspec
-def top_canned_query(datasette, request, database, query_name):
+def top_stored_query(datasette, request, database, query_name):
     """HTML to include at the top of the stored query page"""
 
 
diff --git a/datasette/templates/query.html b/datasette/templates/query.html
index 785b05af..3f03424a 100644
--- a/datasette/templates/query.html
+++ b/datasette/templates/query.html
@@ -33,7 +33,7 @@
 {% set action_links, action_title = query_actions(), "Query actions" %}
 {% include "_action_menu.html" %}
 
-{% if canned_query %}{{ top_canned_query() }}{% else %}{{ top_query() }}{% endif %}
+{% if canned_query %}{{ top_stored_query() }}{% else %}{{ top_query() }}{% endif %}
 
 {% block description_source_license %}{% include "_description_source_license.html" %}{% endblock %}
 
diff --git a/datasette/views/database.py b/datasette/views/database.py
index f30d3815..def3c530 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -339,8 +339,8 @@ class QueryContext(Context):
     top_query: callable = field(
         metadata={"help": "Callable to render the top_query slot"}
     )
-    top_canned_query: callable = field(
-        metadata={"help": "Callable to render the top_canned_query slot"}
+    top_stored_query: callable = field(
+        metadata={"help": "Callable to render the top_stored_query slot"}
     )
     query_actions: callable = field(
         metadata={
@@ -2095,8 +2095,8 @@ class QueryView(View):
                         top_query=make_slot_function(
                             "top_query", datasette, request, database=database, sql=sql
                         ),
-                        top_canned_query=make_slot_function(
-                            "top_canned_query",
+                        top_stored_query=make_slot_function(
+                            "top_stored_query",
                             datasette,
                             request,
                             database=database,
diff --git a/docs/changelog.rst b/docs/changelog.rst
index dfb2a736..300ac02f 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -10,6 +10,7 @@ Unreleased
 ----------
 
 - Fixed a bug where visiting ``/<database>/-/query`` without a ``?sql=`` parameter returned a 500 error. (:issue:`2743`)
+- The ``top_canned_query()`` plugin hook has been renamed to :ref:`top_stored_query() <plugin_hook_top_stored_query>`. (:issue:`2747`)
 
 .. _v1_0_a30:
 
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 264b473e..4737ca03 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -2279,9 +2279,9 @@ top_query(datasette, request, database, sql)
 
 Returns HTML to be displayed at the top of the query results page.
 
-.. _plugin_hook_top_canned_query:
+.. _plugin_hook_top_stored_query:
 
-top_canned_query(datasette, request, database, query_name)
+top_stored_query(datasette, request, database, query_name)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 ``datasette`` - :ref:`internals_datasette`
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index f7adbd66..32276437 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -1486,8 +1486,10 @@ class SlotPlugin:
         return "Xtop_query:{}:{}:{}".format(database, sql, request.args["z"])
 
     @hookimpl
-    def top_canned_query(self, request, database, query_name):
-        return "Xtop_query:{}:{}:{}".format(database, query_name, request.args["z"])
+    def top_stored_query(self, request, database, query_name):
+        return "Xtop_stored_query:{}:{}:{}".format(
+            database, query_name, request.args["z"]
+        )
 
 
 @pytest.mark.asyncio
@@ -1548,12 +1550,12 @@ async def test_hook_top_query(ds_client):
 
 
 @pytest.mark.asyncio
-async def test_hook_top_canned_query(ds_client):
+async def test_hook_top_stored_query(ds_client):
     try:
         pm.register(SlotPlugin(), name="SlotPlugin")
         response = await ds_client.get("/fixtures/magic_parameters?z=xyz")
         assert response.status_code == 200
-        assert "Xtop_query:fixtures:magic_parameters:xyz" in response.text
+        assert "Xtop_stored_query:fixtures:magic_parameters:xyz" in response.text
     finally:
         pm.unregister(name="SlotPlugin")
 

From 2f73869c09962e320e5f40f4691df70618cd052e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:09:48 -0700
Subject: [PATCH 090/386] Document that canned_queries() has been removed

---
 docs/changelog.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 300ac02f..674ff5b3 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -11,6 +11,7 @@ Unreleased
 
 - Fixed a bug where visiting ``/<database>/-/query`` without a ``?sql=`` parameter returned a 500 error. (:issue:`2743`)
 - The ``top_canned_query()`` plugin hook has been renamed to :ref:`top_stored_query() <plugin_hook_top_stored_query>`. (:issue:`2747`)
+- The ``canned_queries()`` plugin hook has been removed. Plugins can use the new ``datasette.add_query()``, ``datasette.update_query()`` and ``datasette.remove_query()`` methods to managed stored queries instead.
 
 .. _v1_0_a30:
 

From 56b14f37d547e03ba902516ac9ae13ef52765f77 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:16:18 -0700
Subject: [PATCH 091/386] The stored queries do not live in that DB

---
 docs/authentication.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/authentication.rst b/docs/authentication.rst
index 22db41d8..86df7f04 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1298,7 +1298,7 @@ Actor is allowed to view a stored query page, e.g. https://latest.datasette.io/f
 store-query
 -----------
 
-Actor is allowed to create stored queries in a database.
+Actor is allowed to create stored queries against a database.
 
 ``resource`` - ``datasette.resources.DatabaseResource(database)``
     ``database`` is the name of the database (string)

From 02a1468f1b3c8c14fb80037686b43de856e49c1f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:17:51 -0700
Subject: [PATCH 092/386] Renamed canned queries to queries / stored queries in
 docs

And a few renames in code and YAML as well.
---
 .github/workflows/deploy-latest.yml |  33 +-
 datasette/app.py                    |   7 -
 datasette/facets.py                 |   2 +-
 datasette/static/app.css            |   2 +-
 datasette/templates/query.html      |  18 +-
 datasette/views/database.py         |  92 +++---
 datasette/views/table.py            |   6 +-
 docs/authentication.rst             |  10 +-
 docs/changelog.rst                  |  23 +-
 docs/configuration.rst              |   6 +-
 docs/plugin_hooks.rst               |  12 +-
 docs/spatialite.rst                 |   2 +-
 docs/sql_queries.rst                |  12 +-
 docs/upgrade-1.0a20.md              |   6 +-
 tests/test_canned_queries.py        | 473 ----------------------------
 tests/test_html.py                  |  12 +-
 tests/test_jump.py                  |   4 +-
 17 files changed, 115 insertions(+), 605 deletions(-)
 delete mode 100644 tests/test_canned_queries.py

diff --git a/.github/workflows/deploy-latest.yml b/.github/workflows/deploy-latest.yml
index 7d8dd37d..166d33d0 100644
--- a/.github/workflows/deploy-latest.yml
+++ b/.github/workflows/deploy-latest.yml
@@ -57,7 +57,7 @@ jobs:
             db.route = "alternative-route"
         ' > plugins/alternative_route.py
         cp fixtures.db fixtures2.db
-    - name: And the counters writable canned query demo
+    - name: And the counters writable stored query demo
       run: |
         cat > plugins/counters.py <<EOF
         from datasette import hookimpl
@@ -69,23 +69,22 @@ jobs:
                 await db.execute_write("insert or ignore into counters (name, value) values ('counter_a', 0)")
                 await db.execute_write("insert or ignore into counters (name, value) values ('counter_b', 0)")
                 await db.execute_write("insert or ignore into counters (name, value) values ('counter_c', 0)")
-            return inner
-        @hookimpl
-        def canned_queries(database):
-            if database == "counters":
-                queries = {}
                 for name in ("counter_a", "counter_b", "counter_c"):
-                    queries["increment_{}".format(name)] = {
-                        "sql": "update counters set value = value + 1 where name = '{}'".format(name),
-                        "on_success_message_sql": "select 'Counter {name} incremented to ' || value from counters where name = '{name}'".format(name=name),
-                        "write": True,
-                    }
-                    queries["decrement_{}".format(name)] = {
-                        "sql": "update counters set value = value - 1 where name = '{}'".format(name),
-                        "on_success_message_sql": "select 'Counter {name} decremented to ' || value from counters where name = '{name}'".format(name=name),
-                        "write": True,
-                    }
-                return queries
+                    await datasette.add_query(
+                        "counters",
+                        "increment_{}".format(name),
+                        "update counters set value = value + 1 where name = '{}'".format(name),
+                        on_success_message_sql="select 'Counter {name} incremented to ' || value from counters where name = '{name}'".format(name=name),
+                        is_write=True,
+                    )
+                    await datasette.add_query(
+                        "counters",
+                        "decrement_{}".format(name),
+                        "update counters set value = value - 1 where name = '{}'".format(name),
+                        on_success_message_sql="select 'Counter {name} decremented to ' || value from counters where name = '{name}'".format(name=name),
+                        is_write=True,
+                    )
+            return inner
         EOF
     # - name: Make some modifications to metadata.json
     #   run: |
diff --git a/datasette/app.py b/datasette/app.py
index 42a2d27d..52d100cc 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -1784,13 +1784,6 @@ class Datasette:
     def app_css_hash(self):
         return self.static_hash("app.css")
 
-    async def get_canned_queries(self, database_name, actor):
-        page = await self.list_queries(database_name, actor=actor, limit=1000)
-        return {query["name"]: query for query in page["queries"]}
-
-    async def get_canned_query(self, database_name, query_name, actor):
-        return await self.get_query(database_name, query_name)
-
     def _prepare_connection(self, conn, database):
         conn.row_factory = sqlite3.Row
         conn.text_factory = lambda x: str(x, "utf-8", "replace")
diff --git a/datasette/facets.py b/datasette/facets.py
index bc4b6904..abe0605e 100644
--- a/datasette/facets.py
+++ b/datasette/facets.py
@@ -83,7 +83,7 @@ class Facet:
         self.ds = ds
         self.request = request
         self.database = database
-        # For foreign key expansion. Can be None for e.g. canned SQL queries:
+        # For foreign key expansion. Can be None for e.g. stored SQL queries:
         self.table = table
         self.sql = sql or f"select * from [{table}]"
         self.params = params or []
diff --git a/datasette/static/app.css b/datasette/static/app.css
index 4f4db133..815f6db8 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1409,7 +1409,7 @@ svg.dropdown-menu-icon {
     border-bottom: 5px solid #666;
 }
 
-.canned-query-edit-sql {
+.stored-query-edit-sql {
     padding-left: 0.5em;
     position: relative;
     top: 1px;
diff --git a/datasette/templates/query.html b/datasette/templates/query.html
index 3f03424a..168a636b 100644
--- a/datasette/templates/query.html
+++ b/datasette/templates/query.html
@@ -17,7 +17,7 @@
 {% include "_sql_parameter_styles.html" %}
 {% endblock %}
 
-{% block body_class %}query db-{{ database|to_css_class }}{% if canned_query %} query-{{ canned_query|to_css_class }}{% endif %}{% endblock %}
+{% block body_class %}query db-{{ database|to_css_class }}{% if stored_query %} query-{{ stored_query|to_css_class }}{% endif %}{% endblock %}
 
 {% block crumbs %}
 {{ crumbs.nav(request=request, database=database) }}
@@ -25,19 +25,19 @@
 
 {% block content %}
 
-{% if canned_query_write and db_is_immutable %}
+{% if stored_query_write and db_is_immutable %}
     <p class="message-error">This query cannot be executed because the database is immutable.</p>
 {% endif %}
 
-<h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">{{ metadata.title or database }}{% if canned_query and not metadata.title %}: {{ canned_query }}{% endif %}{% if private %} 🔒{% endif %}</h1>
+<h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">{{ metadata.title or database }}{% if stored_query and not metadata.title %}: {{ stored_query }}{% endif %}{% if private %} 🔒{% endif %}</h1>
 {% set action_links, action_title = query_actions(), "Query actions" %}
 {% include "_action_menu.html" %}
 
-{% if canned_query %}{{ top_stored_query() }}{% else %}{{ top_query() }}{% endif %}
+{% if stored_query %}{{ top_stored_query() }}{% else %}{{ top_query() }}{% endif %}
 
 {% block description_source_license %}{% include "_description_source_license.html" %}{% endblock %}
 
-<form class="sql core" action="{{ urls.database(database) }}{% if canned_query %}/{{ canned_query }}{% endif %}" method="{% if canned_query_write %}post{% else %}get{% endif %}" data-parameters-url="{{ urls.database(database) }}/-/query/parameters">
+<form class="sql core" action="{{ urls.database(database) }}{% if stored_query %}/{{ stored_query }}{% endif %}" method="{% if stored_query_write %}post{% else %}get{% endif %}" data-parameters-url="{{ urls.database(database) }}/-/query/parameters">
     <h3>Custom SQL query{% if display_rows %} returning {% if truncated %}more than {% endif %}{{ "{:,}".format(display_rows|length) }} row{% if display_rows|length == 1 %}{% else %}s{% endif %}{% endif %}{% if not query_error %}
         <span class="show-hide-sql">(<a href="{{ show_hide_link }}">{{ show_hide_text }}</a>)</span>
     {% endif %}</h3>
@@ -52,7 +52,7 @@
             <pre id="sql-query">{% if query %}{{ query.sql }}{% endif %}</pre>
         {% endif %}
     {% else %}
-        {% if not canned_query %}
+        {% if not stored_query %}
             <input type="hidden" name="sql"
                 value="{% if query and query.sql %}{{ query.sql }}{% elif tables %}select * from {{ tables[0].name|escape_sqlite }}{% endif %}"
             >
@@ -64,10 +64,10 @@
     {% include "_sql_parameters.html" %}
     <p>
         {% if not hide_sql %}<button id="sql-format" type="button" hidden>Format SQL</button>{% endif %}
-        <input type="submit" value="Run SQL"{% if canned_query_write and db_is_immutable %} disabled{% endif %}>
+        <input type="submit" value="Run SQL"{% if stored_query_write and db_is_immutable %} disabled{% endif %}>
         {{ show_hide_hidden }}
         {% if save_query_url %}<a href="{{ save_query_url }}" class="save-query">Save this query</a>{% endif %}
-        {% if canned_query and edit_sql_url %}<a href="{{ edit_sql_url }}" class="canned-query-edit-sql">Edit SQL</a>{% endif %}
+        {% if stored_query and edit_sql_url %}<a href="{{ edit_sql_url }}" class="stored-query-edit-sql">Edit SQL</a>{% endif %}
     </p>
 </form>
 
@@ -90,7 +90,7 @@
     </tbody>
 </table></div>
 {% else %}
-    {% if not canned_query_write and not error %}
+    {% if not stored_query_write and not error %}
         <p class="zero-results">0 results</p>
     {% endif %}
 {% endif %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index def3c530..c36476f6 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -100,12 +100,12 @@ class DatabaseView(View):
             limit=5,
             include_private=True,
         )
-        canned_queries = queries_page["queries"]
+        stored_queries = queries_page["queries"]
         queries_more = queries_page["has_more"]
         queries_count = (
             await datasette.count_queries(database, actor=request.actor)
             if queries_more
-            else len(canned_queries)
+            else len(stored_queries)
         )
 
         async def database_actions():
@@ -137,7 +137,7 @@ class DatabaseView(View):
             "tables": tables,
             "hidden_count": len([t for t in tables if t["hidden"]]),
             "views": sql_views,
-            "queries": canned_queries,
+            "queries": stored_queries,
             "queries_more": queries_more,
             "queries_count": queries_count,
             "allow_execute_sql": allow_execute_sql,
@@ -172,7 +172,7 @@ class DatabaseView(View):
                     tables=tables,
                     hidden_count=len([t for t in tables if t["hidden"]]),
                     views=sql_views,
-                    queries=canned_queries,
+                    queries=stored_queries,
                     queries_more=queries_more,
                     queries_count=queries_count,
                     allow_execute_sql=allow_execute_sql,
@@ -271,7 +271,7 @@ class QueryContext(Context):
     query: dict = field(
         metadata={"help": "The SQL query object containing the `sql` string"}
     )
-    canned_query: str = field(
+    stored_query: str = field(
         metadata={"help": "The name of the stored query if this is a stored query"}
     )
     private: bool = field(
@@ -280,7 +280,7 @@ class QueryContext(Context):
     # urls: dict = field(
     #     metadata={"help": "Object containing URL helpers like `database()`"}
     # )
-    canned_query_write: bool = field(
+    stored_query_write: bool = field(
         metadata={
             "help": "Boolean indicating if this is a stored query that allows writes"
         }
@@ -1629,10 +1629,10 @@ class QueryView(View):
             await datasette.resolve_table(request)
             table_found = True
         except TableNotFound as table_not_found:
-            canned_query = await datasette.get_canned_query(
-                table_not_found.database_name, table_not_found.table, request.actor
+            stored_query = await datasette.get_query(
+                table_not_found.database_name, table_not_found.table
             )
-            if canned_query is None:
+            if stored_query is None:
                 raise
         if table_found:
             # That should not have happened
@@ -1640,13 +1640,13 @@ class QueryView(View):
 
         if not await datasette.allowed(
             action="view-query",
-            resource=QueryResource(database=db.name, query=canned_query["name"]),
+            resource=QueryResource(database=db.name, query=stored_query["name"]),
             actor=request.actor,
         ):
             raise Forbidden("You do not have permission to view this query")
 
         await _ensure_stored_query_execution_permissions(
-            datasette, db, canned_query, request.actor
+            datasette, db, stored_query, request.actor
         )
 
         # If database is immutable, return an error
@@ -1674,19 +1674,19 @@ class QueryView(View):
             or params.get("_json")
         )
         params_for_query = MagicParameters(
-            canned_query["sql"], params, request, datasette
+            stored_query["sql"], params, request, datasette
         )
         await params_for_query.execute_params()
         ok = None
         redirect_url = None
         try:
             cursor = await db.execute_write(
-                canned_query["sql"], params_for_query, request=request
+                stored_query["sql"], params_for_query, request=request
             )
             # success message can come from on_success_message or on_success_message_sql
             message = None
             message_type = datasette.INFO
-            on_success_message_sql = canned_query.get("on_success_message_sql")
+            on_success_message_sql = stored_query.get("on_success_message_sql")
             if on_success_message_sql:
                 try:
                     message_result = (
@@ -1698,18 +1698,18 @@ class QueryView(View):
                     message = "Error running on_success_message_sql: {}".format(ex)
                     message_type = datasette.ERROR
             if not message:
-                message = canned_query.get(
+                message = stored_query.get(
                     "on_success_message"
                 ) or "Query executed, {} row{} affected".format(
                     cursor.rowcount, "" if cursor.rowcount == 1 else "s"
                 )
 
-            redirect_url = canned_query.get("on_success_redirect")
+            redirect_url = stored_query.get("on_success_redirect")
             ok = True
         except Exception as ex:
-            message = canned_query.get("on_error_message") or str(ex)
+            message = stored_query.get("on_error_message") or str(ex)
             message_type = datasette.ERROR
-            redirect_url = canned_query.get("on_error_redirect")
+            redirect_url = stored_query.get("on_error_redirect")
             ok = False
         if should_return_json:
             return Response.json(
@@ -1743,33 +1743,33 @@ class QueryView(View):
         allowed_dict = {r.child: r for r in allowed_tables_page.resources}
 
         # Are we a stored query?
-        canned_query = None
-        canned_query_write = False
+        stored_query = None
+        stored_query_write = False
         if "table" in request.url_vars:
             try:
                 await datasette.resolve_table(request)
             except TableNotFound as table_not_found:
                 # Was this actually a stored query?
-                canned_query = await datasette.get_canned_query(
-                    table_not_found.database_name, table_not_found.table, request.actor
+                stored_query = await datasette.get_query(
+                    table_not_found.database_name, table_not_found.table
                 )
-                if canned_query is None:
+                if stored_query is None:
                     raise
-                canned_query_write = bool(canned_query.get("write"))
+                stored_query_write = bool(stored_query.get("write"))
 
         private = False
-        if canned_query:
+        if stored_query:
             # Respect stored query permissions
             visible, private = await datasette.check_visibility(
                 request.actor,
                 action="view-query",
-                resource=QueryResource(database=database, query=canned_query["name"]),
+                resource=QueryResource(database=database, query=stored_query["name"]),
             )
             if not visible:
                 raise Forbidden("You do not have permission to view this query")
-            if not canned_query_write:
+            if not stored_query_write:
                 await _ensure_stored_query_execution_permissions(
-                    datasette, db, canned_query, request.actor
+                    datasette, db, stored_query, request.actor
                 )
 
         else:
@@ -1783,15 +1783,15 @@ class QueryView(View):
         params = {key: request.args.get(key) for key in request.args}
         sql = None
 
-        if canned_query:
-            sql = canned_query["sql"]
+        if stored_query:
+            sql = stored_query["sql"]
         elif "sql" in params:
             sql = params.pop("sql")
 
         # Extract any :named parameters
         named_parameters = []
-        if canned_query and canned_query.get("params"):
-            named_parameters = canned_query["params"]
+        if stored_query and stored_query.get("params"):
+            named_parameters = stored_query["params"]
         if not named_parameters and sql:
             named_parameters = derive_named_parameters(sql)
         named_parameter_values = {
@@ -1817,9 +1817,9 @@ class QueryView(View):
 
         params_for_query = params
 
-        if sql and not canned_query_write:
+        if sql and not stored_query_write:
             try:
-                if not canned_query:
+                if not stored_query:
                     # For regular queries we only allow SELECT, plus other rules
                     validate_sql_select(sql)
                 else:
@@ -1879,7 +1879,7 @@ class QueryView(View):
                 columns=columns,
                 rows=rows,
                 sql=sql,
-                query_name=canned_query["name"] if canned_query else None,
+                query_name=stored_query["name"] if stored_query else None,
                 database=database,
                 table=None,
                 request=request,
@@ -1911,10 +1911,10 @@ class QueryView(View):
         elif format_ == "html":
             headers = {}
             templates = [f"query-{to_css_class(database)}.html", "query.html"]
-            if canned_query:
+            if stored_query:
                 templates.insert(
                     0,
-                    f"query-{to_css_class(database)}-{to_css_class(canned_query['name'])}.html",
+                    f"query-{to_css_class(database)}-{to_css_class(stored_query['name'])}.html",
                 )
 
             environment = datasette.get_jinja_environment(request)
@@ -1932,8 +1932,8 @@ class QueryView(View):
                 }
             )
             metadata = await datasette.get_database_metadata(database)
-            if canned_query:
-                metadata = dict(canned_query)
+            if stored_query:
+                metadata = dict(stored_query)
                 metadata.pop("source", None)
 
             renderers = {}
@@ -1968,7 +1968,7 @@ class QueryView(View):
             )
 
             show_hide_hidden = ""
-            if canned_query and canned_query.get("hide_sql"):
+            if stored_query and stored_query.get("hide_sql"):
                 if bool(params.get("_show_sql")):
                     show_hide_link = path_with_removed_args(request, {"_show_sql"})
                     show_hide_text = "hide"
@@ -2018,7 +2018,7 @@ class QueryView(View):
                     )
             save_query_url = None
             if (
-                not canned_query
+                not stored_query
                 and allow_execute_sql
                 and allow_store_query
                 and is_validated_sql
@@ -2036,7 +2036,7 @@ class QueryView(View):
                     datasette=datasette,
                     actor=request.actor,
                     database=database,
-                    query_name=canned_query["name"] if canned_query else None,
+                    query_name=stored_query["name"] if stored_query else None,
                     request=request,
                     sql=sql,
                     params=params,
@@ -2056,15 +2056,15 @@ class QueryView(View):
                             "sql": sql,
                             "params": params,
                         },
-                        canned_query=canned_query["name"] if canned_query else None,
+                        stored_query=stored_query["name"] if stored_query else None,
                         private=private,
-                        canned_query_write=canned_query_write,
+                        stored_query_write=stored_query_write,
                         db_is_immutable=not db.is_mutable,
                         error=query_error,
                         hide_sql=hide_sql,
                         show_hide_link=datasette.urls.path(show_hide_link),
                         show_hide_text=show_hide_text,
-                        editable=not canned_query,
+                        editable=not stored_query,
                         allow_execute_sql=allow_execute_sql,
                         save_query_url=save_query_url,
                         tables=await get_tables(datasette, request, db, allowed_dict),
@@ -2100,7 +2100,7 @@ class QueryView(View):
                             datasette,
                             request,
                             database=database,
-                            query_name=canned_query["name"] if canned_query else None,
+                            query_name=stored_query["name"] if stored_query else None,
                         ),
                         query_actions=query_actions,
                     ),
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 7b1a5a82..da69c6b5 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -964,11 +964,11 @@ async def table_view_traced(datasette, request):
         resolved = await datasette.resolve_table(request)
     except TableNotFound as not_found:
         # Was this actually a stored query?
-        canned_query = await datasette.get_canned_query(
-            not_found.database_name, not_found.table, request.actor
+        stored_query = await datasette.get_query(
+            not_found.database_name, not_found.table
         )
         # If this is a stored query, not a table, then dispatch to QueryView instead
-        if canned_query:
+        if stored_query:
             return await QueryView()(request, datasette)
         else:
             raise
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 86df7f04..cec47f97 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -121,7 +121,7 @@ This configuration will deny access to everyone except the user with ``id`` of `
 How permissions are resolved
 ----------------------------
 
-Datasette performs permission checks using the internal :ref:`datasette_allowed`, method which accepts keyword arguments for ``action``, ``resource`` and an optional ``actor``. 
+Datasette performs permission checks using the internal :ref:`datasette_allowed`, method which accepts keyword arguments for ``action``, ``resource`` and an optional ``actor``.
 
 ``resource`` should be an instance of the appropriate ``Resource`` subclass from :mod:`datasette.resources`—for example ``InstanceResource()``, ``DatabaseResource(database="...``)`` or ``TableResource(database="...", table="...")``. This defaults to ``InstanceResource()`` if not specified.
 
@@ -468,7 +468,7 @@ You can control the following:
 * Access to the entire Datasette instance
 * Access to specific databases
 * Access to specific tables and views
-* Access to specific :ref:`queries <canned_queries>`
+* Access to specific :ref:`queries <queries>`
 
 If a user has permission to view a table they will be able to view that table, independent of if they have permission to view the database or instance that the table exists within.
 
@@ -496,7 +496,7 @@ Here's how to restrict access to your entire Datasette instance to just the ``"i
             title: My private Datasette instance
             allow:
               id: root
-  
+
 
 .. tab:: datasette.json
 
@@ -644,7 +644,7 @@ This works for SQL views as well - you can list their names in the ``"tables"``
 Access to specific queries
 --------------------------
 
-:ref:`Queries <canned_queries>` allow you to configure named SQL queries in your ``datasette.yaml`` that can be executed by users. These queries can be set up to both read and write to the database, so controlling who can execute them can be important.
+:ref:`Queries <queries>` allow you to configure named SQL queries in your ``datasette.yaml`` that can be executed by users. These queries can be set up to both read and write to the database, so controlling who can execute them can be important.
 
 To limit access to the ``add_name`` query in your ``dogs.db`` database to just the :ref:`root user<authentication_root>`:
 
@@ -1020,7 +1020,7 @@ You can also restrict permissions such that they can only be used within specifi
 
 The resulting token will only be able to insert rows, and only to tables in the ``mydatabase`` database.
 
-Finally, you can restrict permissions to individual resources - tables, SQL views and :ref:`named queries <canned_queries>` - within a specific database::
+Finally, you can restrict permissions to individual resources - tables, SQL views and :ref:`named queries <queries>` - within a specific database::
 
     datasette create-token root --resource mydatabase mytable insert-row
 
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 674ff5b3..d15dec50 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -11,7 +11,8 @@ Unreleased
 
 - Fixed a bug where visiting ``/<database>/-/query`` without a ``?sql=`` parameter returned a 500 error. (:issue:`2743`)
 - The ``top_canned_query()`` plugin hook has been renamed to :ref:`top_stored_query() <plugin_hook_top_stored_query>`. (:issue:`2747`)
-- The ``canned_queries()`` plugin hook has been removed. Plugins can use the new ``datasette.add_query()``, ``datasette.update_query()`` and ``datasette.remove_query()`` methods to managed stored queries instead.
+- The ``canned_queries()`` plugin hook has been removed. Plugins can use the new ``datasette.add_query()``, ``datasette.update_query()`` and ``datasette.remove_query()`` methods to manage stored queries instead.
+- The ``datasette.get_canned_query()`` and ``datasette.get_canned_queries()`` methods have been removed. Plugins can use ``datasette.get_query()`` and ``datasette.list_queries()`` instead.
 
 .. _v1_0_a30:
 
@@ -658,7 +659,7 @@ For more information and workarounds, read `the security advisory <https://githu
 Also in this alpha:
 
 - The new ``datasette plugins --requirements`` option outputs a list of currently installed plugins in Python ``requirements.txt`` format, useful for duplicating that installation elsewhere. (:issue:`2133`)
-- :ref:`canned_queries_writable` can now define a ``on_success_message_sql`` field in their configuration, containing a SQL query that should be executed upon successful completion of the write operation in order to generate a message to be shown to the user. (:issue:`2138`)
+- :ref:`queries_writable` can now define a ``on_success_message_sql`` field in their configuration, containing a SQL query that should be executed upon successful completion of the write operation in order to generate a message to be shown to the user. (:issue:`2138`)
 - The automatically generated border color for a database is now shown in more places around the application. (:issue:`2119`)
 - Every instance of example shell script code in the documentation should now include a working copy button, free from additional syntax. (:issue:`2140`)
 
@@ -1052,7 +1053,7 @@ Other small fixes
 - The ``base.html`` template now wraps everything other than the ``<footer>`` in a ``<div class="not-footer">`` element, to help with advanced CSS customization. (:issue:`1446`)
 - The :ref:`render_cell() <plugin_hook_render_cell>` plugin hook can now return an awaitable function. This means the hook can execute SQL queries. (:issue:`1425`)
 - :ref:`plugin_register_routes` plugin hook now accepts an optional ``datasette`` argument. (:issue:`1404`)
-- New ``hide_sql`` canned query option for defaulting to hiding the SQL query used by a canned query, see :ref:`canned_queries_options`. (:issue:`1422`)
+- New ``hide_sql`` canned query option for defaulting to hiding the SQL query used by a canned query, see :ref:`queries_options`. (:issue:`1422`)
 - New ``--cpu`` option for :ref:`datasette publish cloudrun <publish_cloud_run>`. (:issue:`1420`)
 - If `Rich <https://github.com/willmcgugan/rich>`__ is installed in the same virtual environment as Datasette, it will be used to provide enhanced display of error tracebacks on the console. (:issue:`1416`)
 - ``datasette.utils`` :ref:`internals_utils_parse_metadata` function, used by the new `datasette-remote-metadata plugin <https://datasette.io/plugins/datasette-remote-metadata>`__, is now a documented API. (:issue:`1405`)
@@ -1426,7 +1427,7 @@ See also `Datasette 0.50: The annotated release notes <https://simonwillison.net
 
 See also `Datasette 0.49: The annotated release notes <https://simonwillison.net/2020/Sep/15/datasette-0-49/>`__.
 
-- Writable canned queries now expose a JSON API, see :ref:`canned_queries_json_api`. (:issue:`880`)
+- Writable canned queries now expose a JSON API, see :ref:`queries_json_api`. (:issue:`880`)
 - New mechanism for defining page templates with custom path parameters - a template file called ``pages/about/{slug}.html`` will be used to render any requests to ``/about/something``. See :ref:`custom_pages_parameters`. (:issue:`944`)
 - ``register_output_renderer()`` render functions can now return a ``Response``. (:issue:`953`)
 - New ``--upgrade`` option for ``datasette install``. (:issue:`945`)
@@ -1518,7 +1519,7 @@ Magic parameters for canned queries, a log out feature, improved plugin document
 Magic parameters for canned queries
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-Canned queries now support :ref:`canned_queries_magic_parameters`, which can be used to insert or select automatically generated values. For example::
+Canned queries now support :ref:`queries_magic_parameters`, which can be used to insert or select automatically generated values. For example::
 
     insert into logs
       (user_id, timestamp)
@@ -1549,7 +1550,7 @@ New plugin hooks
 
 - :ref:`plugin_hook_register_magic_parameters` can be used to define new types of magic canned query parameters.
 - :ref:`plugin_hook_startup` can run custom code when Datasette first starts up. `datasette-init <https://github.com/simonw/datasette-init>`__ is a new plugin that uses this hook to create database tables and views on startup if they have not yet been created. (:issue:`834`)
-- :ref:`plugin_hook_canned_queries` lets plugins provide additional canned queries beyond those defined in Datasette's metadata. See `datasette-saved-queries <https://github.com/simonw/datasette-saved-queries>`__ for an example of this hook in action. (:issue:`852`)
+- ``canned_queries()`` lets plugins provide additional canned queries beyond those defined in Datasette's metadata. See `datasette-saved-queries <https://github.com/simonw/datasette-saved-queries>`__ for an example of this hook in action. (:issue:`852`)
 - :ref:`plugin_hook_forbidden` is a hook for customizing how Datasette responds to 403 forbidden errors. (:issue:`812`)
 
 Smaller changes
@@ -1624,7 +1625,7 @@ A new debug page at ``/-/permissions`` shows recent permission checks, to help a
 Writable canned queries
 ~~~~~~~~~~~~~~~~~~~~~~~
 
-Datasette's :ref:`canned_queries` feature lets you define SQL queries in ``metadata.json`` which can then be executed by users visiting a specific URL. https://latest.datasette.io/fixtures/neighborhood_search for example.
+Datasette's :ref:`queries` feature lets you define SQL queries in ``metadata.json`` which can then be executed by users visiting a specific URL. https://latest.datasette.io/fixtures/neighborhood_search for example.
 
 Canned queries were previously restricted to ``SELECT``, but Datasette 0.44 introduces the ability for canned queries to execute ``INSERT`` or ``UPDATE`` queries as well, using the new ``"write": true`` property (:issue:`800`):
 
@@ -1643,7 +1644,7 @@ Canned queries were previously restricted to ``SELECT``, but Datasette 0.44 intr
         }
     }
 
-See :ref:`canned_queries_writable` for more details.
+See :ref:`queries_writable` for more details.
 
 Flash messages
 ~~~~~~~~~~~~~~
@@ -1698,7 +1699,7 @@ Smaller changes
 - New ``request.cookies`` property.
 - ``/-/plugins`` endpoint now shows a list of hooks implemented by each plugin, e.g. https://latest.datasette.io/-/plugins?all=1
 - ``request.post_vars()`` method no longer discards empty values.
-- New "params" canned query key for explicitly setting named parameters, see :ref:`canned_queries_named_parameters`. (:issue:`797`)
+- New "params" canned query key for explicitly setting named parameters, see :ref:`queries_named_parameters`. (:issue:`797`)
 - ``request.args`` is now a :ref:`MultiParams <internals_multiparams>` object.
 - Fixed a bug with the ``datasette plugins`` command. (:issue:`802`)
 - Nicer pattern for using ``make_app_client()`` in tests. (:issue:`395`)
@@ -1732,7 +1733,7 @@ The main focus of this release is a major upgrade to the :ref:`plugin_register_o
 * Visually distinguish float and integer columns - useful for figuring out why order-by-column might be returning unexpected results. (:issue:`729`)
 * The :ref:`internals_request`, which is passed to several plugin hooks, is now documented. (:issue:`706`)
 * New ``metadata.json`` option for setting a custom default page size for specific tables and views, see :ref:`table_configuration_size`. (:issue:`751`)
-* Canned queries can now be configured with a default URL fragment hash, useful when working with plugins such as `datasette-vega <https://github.com/simonw/datasette-vega>`__, see :ref:`canned_queries_options`. (:issue:`706`)
+* Canned queries can now be configured with a default URL fragment hash, useful when working with plugins such as `datasette-vega <https://github.com/simonw/datasette-vega>`__, see :ref:`queries_options`. (:issue:`706`)
 * Fixed a bug in ``datasette publish`` when running on operating systems where the ``/tmp`` directory lives in a different volume, using a backport of the Python 3.8 ``shutil.copytree()`` function. (:issue:`744`)
 * Every plugin hook is now covered by the unit tests, and a new unit test checks that each plugin hook has at least one corresponding test. (:issue:`771`, :issue:`773`)
 
@@ -2249,7 +2250,7 @@ A number of small new features:
 - Documentation for :ref:`datasette publish and datasette package <publishing>`, closes `#337 <https://github.com/simonw/datasette/issues/337>`_
 - Fixed compatibility with Python 3.7
 - ``datasette publish heroku`` now supports app names via the ``-n`` option, which can also be used to overwrite an existing application [Russ Garrett]
-- Title and description metadata can now be set for :ref:`canned SQL queries <canned_queries>`, closes `#342 <https://github.com/simonw/datasette/issues/342>`_
+- Title and description metadata can now be set for :ref:`canned SQL queries <queries>`, closes `#342 <https://github.com/simonw/datasette/issues/342>`_
 - New ``force_https_on`` config option, fixes ``https://`` API URLs when deploying to Zeit Now - closes `#333 <https://github.com/simonw/datasette/issues/333>`_
 - ``?_json_infinity=1`` query string argument for handling Infinity/-Infinity values in JSON, closes `#332 <https://github.com/simonw/datasette/issues/332>`_
 - URLs displayed in the results of custom SQL queries are now URLified, closes `#298 <https://github.com/simonw/datasette/issues/298>`_
diff --git a/docs/configuration.rst b/docs/configuration.rst
index cf9590b8..9213a640 100644
--- a/docs/configuration.rst
+++ b/docs/configuration.rst
@@ -434,12 +434,12 @@ Here is a simple example:
 
 :ref:`authentication_permissions_config` has the full details.
 
-.. _configuration_reference_canned_queries:
+.. _configuration_reference_queries:
 
 Queries configuration
 ~~~~~~~~~~~~~~~~~~~~~
 
-:ref:`Queries <canned_queries>` are named SQL queries that appear in the Datasette interface. They can be configured in ``datasette.yaml`` using the ``queries`` key at the database level:
+:ref:`Queries <queries>` are named SQL queries that appear in the Datasette interface. They can be configured in ``datasette.yaml`` using the ``queries`` key at the database level:
 
 .. [[[cog
     from metadata_doc import config_example, config_example
@@ -484,7 +484,7 @@ Queries configuration
         }
 .. [[[end]]]
 
-See the :ref:`queries documentation <canned_queries>` for more, including how to configure :ref:`writable queries <canned_queries_writable>`.
+See the :ref:`queries documentation <queries>` for more, including how to configure :ref:`writable queries <queries_writable>`.
 
 .. _configuration_reference_css_js:
 
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 4737ca03..2a0ddc93 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1207,16 +1207,6 @@ Potential use-cases:
 
 Examples: `datasette-saved-queries <https://datasette.io/plugins/datasette-saved-queries>`__, `datasette-init <https://datasette.io/plugins/datasette-init>`__
 
-.. _plugin_hook_canned_queries:
-
-canned_queries(datasette, database, actor)
-------------------------------------------
-
-This hook has been removed. Plugins that need to add stored queries should use
-the :ref:`plugin_hook_startup` hook and call ``await datasette.add_query(...)``.
-
-Example: `datasette-saved-queries <https://datasette.io/plugins/datasette-saved-queries>`__
-
 .. _plugin_hook_actor_from_request:
 
 actor_from_request(datasette, request)
@@ -1635,7 +1625,7 @@ register_magic_parameters(datasette)
 ``datasette`` - :ref:`internals_datasette`
     You can use this to access plugin configuration options via ``datasette.plugin_config(your_plugin_name)``.
 
-:ref:`canned_queries_magic_parameters` can be used to add automatic parameters to :ref:`configured queries <canned_queries>`. This plugin hook allows additional magic parameters to be defined by plugins.
+:ref:`queries_magic_parameters` can be used to add automatic parameters to :ref:`configured queries <queries>`. This plugin hook allows additional magic parameters to be defined by plugins.
 
 Magic parameters all take this format: ``_prefix_rest_of_parameter``. The prefix indicates which magic parameter function should be called - the rest of the parameter is passed as an argument to that function.
 
diff --git a/docs/spatialite.rst b/docs/spatialite.rst
index 1999ab78..bea679aa 100644
--- a/docs/spatialite.rst
+++ b/docs/spatialite.rst
@@ -30,7 +30,7 @@ Warning
     The following steps are recommended:
 
     - Disable arbitrary SQL queries by untrusted users. See :ref:`authentication_permissions_execute_sql` for ways to do this. The easiest is to start Datasette with the ``datasette --setting default_allow_sql off`` option.
-    - Define :ref:`queries <canned_queries>` with the SQL queries that use SpatiaLite functions that you want people to be able to execute.
+    - Define :ref:`queries <queries>` with the SQL queries that use SpatiaLite functions that you want people to be able to execute.
 
     The `Datasette SpatiaLite tutorial <https://datasette.io/tutorials/spatialite>`__ includes detailed instructions for running SpatiaLite safely using these techniques
 
diff --git a/docs/sql_queries.rst b/docs/sql_queries.rst
index d60656e3..f593a534 100644
--- a/docs/sql_queries.rst
+++ b/docs/sql_queries.rst
@@ -66,7 +66,7 @@ You can also use the `sqlite-utils <https://sqlite-utils.datasette.io/>`__ tool
 
     sqlite-utils create-view sf-trees.db demo_view "select qSpecies from Street_Tree_List"
 
-.. _canned_queries:
+.. _queries:
 
 Queries
 -------
@@ -173,7 +173,7 @@ You can opt out of this behavior for a configured query using ``is_trusted: fals
             sql: select * from report
             is_trusted: false
 
-.. _canned_queries_named_parameters:
+.. _queries_named_parameters:
 
 Query parameters
 ~~~~~~~~~~~~~~~~
@@ -313,7 +313,7 @@ You can alternatively provide an explicit list of named parameters using the ``"
         }
 .. [[[end]]]
 
-.. _canned_queries_options:
+.. _queries_options:
 
 Additional query options
 ~~~~~~~~~~~~~~~~~~~~~~~~
@@ -389,7 +389,7 @@ This example demonstrates both ``fragment`` and ``hide_sql``:
 
 `See here <https://latest.datasette.io/fixtures#queries>`__ for a demo of this in action.
 
-.. _canned_queries_writable:
+.. _queries_writable:
 
 Writable queries
 ~~~~~~~~~~~~~~~~
@@ -524,7 +524,7 @@ You can pre-populate form fields when the page first loads using a query string,
 
 If you specify a query in ``"on_success_message_sql"``, that query will be executed after the main query. The first column of the first row return by that query will be displayed as a success message. Named parameters from the main query will be made available to the success message query as well.
 
-.. _canned_queries_magic_parameters:
+.. _queries_magic_parameters:
 
 Magic parameters
 ~~~~~~~~~~~~~~~~
@@ -621,7 +621,7 @@ The form presented at ``/mydatabase/add_message`` will have just a field for ``m
 
 Additional custom magic parameters can be added by plugins using the :ref:`plugin_hook_register_magic_parameters` hook.
 
-.. _canned_queries_json_api:
+.. _queries_json_api:
 
 JSON API for writable queries
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
diff --git a/docs/upgrade-1.0a20.md b/docs/upgrade-1.0a20.md
index fbc3f4a8..b27d8bd5 100644
--- a/docs/upgrade-1.0a20.md
+++ b/docs/upgrade-1.0a20.md
@@ -244,7 +244,7 @@ except (KeyError, TypeError):
 New code:
 ```python
 try:
-    query_info = await datasette.get_canned_query(database, query_name, request.actor)
+    query_info = await datasette.get_query(database, query_name)
     if query_info and "title" in query_info:
         title = query_info["title"]
 except (KeyError, TypeError):
@@ -253,7 +253,7 @@ except (KeyError, TypeError):
 
 ### Update render functions to async
 
-If your plugin's render function needs to call `datasette.get_canned_query()` or other async Datasette methods, it must be declared as async:
+If your plugin's render function needs to call `datasette.get_query()` or other async Datasette methods, it must be declared as async:
 
 Old code:
 ```python
@@ -268,7 +268,7 @@ New code:
 async def render_atom(datasette, request, sql, columns, rows, database, table, query_name, view_name, data):
     # ...
     if query_name:
-        query_info = await datasette.get_canned_query(database, query_name, request.actor)
+        query_info = await datasette.get_query(database, query_name)
         if query_info and "title" in query_info:
             title = query_info["title"]
 ```
diff --git a/tests/test_canned_queries.py b/tests/test_canned_queries.py
deleted file mode 100644
index ae2c74e0..00000000
--- a/tests/test_canned_queries.py
+++ /dev/null
@@ -1,473 +0,0 @@
-from bs4 import BeautifulSoup as Soup
-from asgiref.sync import async_to_sync
-import json
-import pytest
-import re
-from .fixtures import make_app_client
-
-
-def update_query(client, name, **kwargs):
-    async_to_sync(client.ds.invoke_startup)()
-    async_to_sync(client.ds.update_query)("data", name, **kwargs)
-
-
-@pytest.fixture
-def canned_write_client(tmpdir):
-    template_dir = tmpdir / "canned_write_templates"
-    template_dir.mkdir()
-    (template_dir / "query-data-update_name.html").write_text(
-        """
-    {% extends "query.html" %}
-    {% block content %}!!!CUSTOM_UPDATE_NAME_TEMPLATE!!!{{ super() }}{% endblock %}
-    """,
-        "utf-8",
-    )
-    with make_app_client(
-        extra_databases={"data.db": "create table names (name text)"},
-        template_dir=str(template_dir),
-        config={
-            "databases": {
-                "data": {
-                    "queries": {
-                        "canned_read": {"sql": "select * from names"},
-                        "add_name": {
-                            "sql": "insert into names (name) values (:name)",
-                            "write": True,
-                            "on_success_redirect": "/data/add_name?success",
-                        },
-                        "add_name_specify_id": {
-                            "sql": "insert into names (rowid, name) values (:rowid, :name)",
-                            "on_success_message_sql": "select 'Name added: ' || :name || ' with rowid ' || :rowid",
-                            "write": True,
-                            "on_error_redirect": "/data/add_name_specify_id?error",
-                        },
-                        "add_name_specify_id_with_error_in_on_success_message_sql": {
-                            "sql": "insert into names (rowid, name) values (:rowid, :name)",
-                            "on_success_message_sql": "select this is bad SQL",
-                            "write": True,
-                        },
-                        "delete_name": {
-                            "sql": "delete from names where rowid = :rowid",
-                            "write": True,
-                            "on_success_message": "Name deleted",
-                            "allow": {"id": "root"},
-                        },
-                        "update_name": {
-                            "sql": "update names set name = :name where rowid = :rowid",
-                            "params": ["rowid", "name", "extra"],
-                            "write": True,
-                        },
-                    }
-                }
-            }
-        },
-    ) as client:
-        yield client
-
-
-@pytest.fixture
-def canned_write_immutable_client():
-    with make_app_client(
-        is_immutable=True,
-        config={
-            "databases": {
-                "fixtures": {
-                    "queries": {
-                        "add": {
-                            "sql": "insert into sortable (text) values (:text)",
-                            "write": True,
-                        },
-                    }
-                }
-            }
-        },
-    ) as client:
-        yield client
-
-
-@pytest.mark.asyncio
-async def test_canned_query_with_named_parameter(ds_client):
-    response = await ds_client.get(
-        "/fixtures/neighborhood_search.json?text=town&_shape=arrays"
-    )
-    assert response.json()["rows"] == [
-        ["Corktown", "Detroit", "MI"],
-        ["Downtown", "Los Angeles", "CA"],
-        ["Downtown", "Detroit", "MI"],
-        ["Greektown", "Detroit", "MI"],
-        ["Koreatown", "Los Angeles", "CA"],
-        ["Mexicantown", "Detroit", "MI"],
-    ]
-
-
-def test_insert(canned_write_client):
-    response = canned_write_client.post(
-        "/data/add_name",
-        {"name": "Hello"},
-        csrftoken_from=True,
-        cookies={"foo": "bar"},
-    )
-    messages = canned_write_client.ds.unsign(
-        response.cookies["ds_messages"], "messages"
-    )
-    assert messages == [["Query executed, 1 row affected", 1]]
-    assert response.status == 302
-    assert response.headers["Location"] == "/data/add_name?success"
-
-
-def test_insert_blocked_cross_site(canned_write_client):
-    # A cross-site POST (browser-originated) must be blocked
-    response = canned_write_client.post(
-        "/data/add_name",
-        {"name": "Hello"},
-        headers={"sec-fetch-site": "cross-site"},
-    )
-    assert 403 == response.status
-
-
-def test_insert_no_cookies_no_csrf(canned_write_client):
-    response = canned_write_client.post("/data/add_name", {"name": "Hello"})
-    assert 302 == response.status
-    assert "/data/add_name?success" == response.headers["Location"]
-
-
-def test_custom_success_message(canned_write_client):
-    response = canned_write_client.post(
-        "/data/delete_name",
-        {"rowid": 1},
-        cookies={"ds_actor": canned_write_client.actor_cookie({"id": "root"})},
-        csrftoken_from=True,
-    )
-    assert 302 == response.status
-    messages = canned_write_client.ds.unsign(
-        response.cookies["ds_messages"], "messages"
-    )
-    assert [["Name deleted", 1]] == messages
-
-
-def test_insert_error(canned_write_client):
-    canned_write_client.post("/data/add_name", {"name": "Hello"}, csrftoken_from=True)
-    response = canned_write_client.post(
-        "/data/add_name_specify_id",
-        {"rowid": 1, "name": "Should fail"},
-        csrftoken_from=True,
-    )
-    assert 302 == response.status
-    assert "/data/add_name_specify_id?error" == response.headers["Location"]
-    messages = canned_write_client.ds.unsign(
-        response.cookies["ds_messages"], "messages"
-    )
-    assert [["UNIQUE constraint failed: names.rowid", 3]] == messages
-    # How about with a custom error message?
-    update_query(canned_write_client, "add_name_specify_id", on_error_message="ERROR")
-    response = canned_write_client.post(
-        "/data/add_name_specify_id",
-        {"rowid": 1, "name": "Should fail"},
-        csrftoken_from=True,
-    )
-    assert [["ERROR", 3]] == canned_write_client.ds.unsign(
-        response.cookies["ds_messages"], "messages"
-    )
-
-
-def test_on_success_message_sql(canned_write_client):
-    response = canned_write_client.post(
-        "/data/add_name_specify_id",
-        {"rowid": 5, "name": "Should be OK"},
-        csrftoken_from=True,
-    )
-    assert response.status == 302
-    assert response.headers["Location"] == "/data/add_name_specify_id"
-    messages = canned_write_client.ds.unsign(
-        response.cookies["ds_messages"], "messages"
-    )
-    assert messages == [["Name added: Should be OK with rowid 5", 1]]
-
-
-def test_error_in_on_success_message_sql(canned_write_client):
-    response = canned_write_client.post(
-        "/data/add_name_specify_id_with_error_in_on_success_message_sql",
-        {"rowid": 1, "name": "Should fail"},
-        csrftoken_from=True,
-    )
-    messages = canned_write_client.ds.unsign(
-        response.cookies["ds_messages"], "messages"
-    )
-    assert messages == [
-        ["Error running on_success_message_sql: no such column: bad", 3]
-    ]
-
-
-def test_custom_params(canned_write_client):
-    response = canned_write_client.get("/data/update_name?extra=foo")
-    assert (
-        '<input type="text" id="qp3" name="extra" value="foo" data-parameter-control>'
-        in response.text
-    )
-
-
-def test_canned_query_pages_no_vary_header(canned_write_client):
-    # These pages no longer embed per-cookie CSRF tokens, so they must not
-    # set Vary: Cookie - they should be cacheable across users.
-    assert "vary" not in canned_write_client.get("/data").headers
-    assert "vary" not in canned_write_client.get("/data/update_name").headers
-
-
-def test_json_post_body(canned_write_client):
-    response = canned_write_client.post(
-        "/data/add_name",
-        body=json.dumps({"name": ["Hello", "there"]}),
-    )
-    assert 302 == response.status
-    assert "/data/add_name?success" == response.headers["Location"]
-    rows = canned_write_client.get("/data/names.json?_shape=array").json
-    assert rows == [{"rowid": 1, "name": "['Hello', 'there']"}]
-
-
-@pytest.mark.parametrize(
-    "headers,body,querystring",
-    (
-        (None, "name=NameGoesHere", "?_json=1"),
-        ({"Accept": "application/json"}, "name=NameGoesHere", None),
-        (None, "name=NameGoesHere&_json=1", None),
-        (None, '{"name": "NameGoesHere", "_json": 1}', None),
-    ),
-)
-def test_json_response(canned_write_client, headers, body, querystring):
-    response = canned_write_client.post(
-        "/data/add_name" + (querystring or ""),
-        body=body,
-        headers=headers,
-    )
-    assert 200 == response.status
-    assert response.headers["content-type"] == "application/json; charset=utf-8"
-    assert response.json == {
-        "ok": True,
-        "message": "Query executed, 1 row affected",
-        "redirect": "/data/add_name?success",
-    }
-    rows = canned_write_client.get("/data/names.json?_shape=array").json
-    assert rows == [{"rowid": 1, "name": "NameGoesHere"}]
-
-
-def test_canned_query_permissions_on_database_page(canned_write_client):
-    # Without auth shows the five public queries
-    anon_response = canned_write_client.get("/data.json")
-    query_names = {q["name"] for q in anon_response.json["queries"]}
-    assert query_names == {
-        "add_name_specify_id_with_error_in_on_success_message_sql",
-        "update_name",
-        "add_name_specify_id",
-        "canned_read",
-        "add_name",
-    }
-    assert anon_response.json["queries_more"] is False
-
-    # With auth the database page preview shows the first five queries
-    response = canned_write_client.get(
-        "/data.json",
-        cookies={"ds_actor": canned_write_client.actor_cookie({"id": "root"})},
-    )
-    assert response.status == 200
-    query_names_and_private = sorted(
-        [
-            {"name": q["name"], "private": q["private"]}
-            for q in response.json["queries"]
-        ],
-        key=lambda q: q["name"],
-    )
-    assert query_names_and_private == [
-        {"name": "add_name", "private": False},
-        {"name": "add_name_specify_id", "private": False},
-        {
-            "name": "add_name_specify_id_with_error_in_on_success_message_sql",
-            "private": False,
-        },
-        {"name": "canned_read", "private": False},
-        {"name": "delete_name", "private": True},
-    ]
-    assert response.json["queries_more"] is True
-
-    # The full query list endpoint includes the remaining query
-    response = canned_write_client.get(
-        "/data/-/queries.json?_size=10",
-        cookies={"ds_actor": canned_write_client.actor_cookie({"id": "root"})},
-    )
-    assert response.status == 200
-    query_names_and_private = sorted(
-        [
-            {"name": q["name"], "private": q["private"]}
-            for q in response.json["queries"]
-        ],
-        key=lambda q: q["name"],
-    )
-    assert query_names_and_private == [
-        {"name": "add_name", "private": False},
-        {"name": "add_name_specify_id", "private": False},
-        {
-            "name": "add_name_specify_id_with_error_in_on_success_message_sql",
-            "private": False,
-        },
-        {"name": "canned_read", "private": False},
-        {"name": "delete_name", "private": True},
-        {"name": "update_name", "private": False},
-    ]
-
-
-def test_canned_query_permissions(canned_write_client):
-    assert 403 == canned_write_client.get("/data/delete_name").status
-    assert 200 == canned_write_client.get("/data/update_name").status
-    cookies = {"ds_actor": canned_write_client.actor_cookie({"id": "root"})}
-    assert 200 == canned_write_client.get("/data/delete_name", cookies=cookies).status
-    assert 200 == canned_write_client.get("/data/update_name", cookies=cookies).status
-
-
-@pytest.fixture(scope="session")
-def magic_parameters_client():
-    with make_app_client(
-        extra_databases={"data.db": "create table logs (line text)"},
-        config={
-            "databases": {
-                "data": {
-                    "queries": {
-                        "runme_post": {"sql": "", "write": True},
-                        "runme_get": {"sql": ""},
-                    }
-                }
-            }
-        },
-    ) as client:
-        yield client
-
-
-@pytest.mark.parametrize(
-    "magic_parameter,expected_re",
-    [
-        ("_actor_id", "root"),
-        ("_header_host", "localhost"),
-        ("_header_not_a_thing", ""),
-        ("_cookie_foo", "bar"),
-        ("_now_epoch", r"^\d+$"),
-        ("_now_date_utc", r"^\d{4}-\d{2}-\d{2}$"),
-        ("_now_datetime_utc", r"^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$"),
-        ("_random_chars_1", r"^\w$"),
-        ("_random_chars_10", r"^\w{10}$"),
-    ],
-)
-def test_magic_parameters(magic_parameters_client, magic_parameter, expected_re):
-    update_query(
-        magic_parameters_client,
-        "runme_post",
-        sql=f"insert into logs (line) values (:{magic_parameter})",
-    )
-    update_query(
-        magic_parameters_client,
-        "runme_get",
-        sql=f"select :{magic_parameter} as result",
-    )
-    cookies = {
-        "ds_actor": magic_parameters_client.actor_cookie({"id": "root"}),
-        "foo": "bar",
-    }
-    # Test the GET version
-    get_response = magic_parameters_client.get(
-        "/data/runme_get.json?_shape=array", cookies=cookies
-    )
-    get_actual = get_response.json[0]["result"]
-    assert re.match(expected_re, str(get_actual))
-    # Test the form
-    form_response = magic_parameters_client.get("/data/runme_post")
-    soup = Soup(form_response.body, "html.parser")
-    # The magic parameter should not be represented as a form field
-    assert None is soup.find("input", {"name": magic_parameter})
-    # Submit the form to create a log line
-    response = magic_parameters_client.post(
-        "/data/runme_post?_json=1", {}, csrftoken_from=True, cookies=cookies
-    )
-    assert response.json == {
-        "ok": True,
-        "message": "Query executed, 1 row affected",
-        "redirect": None,
-    }
-    post_actual = magic_parameters_client.get(
-        "/data/logs.json?_sort_desc=rowid&_shape=array"
-    ).json[0]["line"]
-    assert re.match(expected_re, post_actual)
-
-
-@pytest.mark.parametrize("use_csrf", [True, False])
-@pytest.mark.parametrize("return_json", [True, False])
-def test_magic_parameters_csrf_json(magic_parameters_client, use_csrf, return_json):
-    update_query(
-        magic_parameters_client,
-        "runme_post",
-        sql="insert into logs (line) values (:_header_host)",
-    )
-    qs = ""
-    if return_json:
-        qs = "?_json=1"
-    response = magic_parameters_client.post(
-        f"/data/runme_post{qs}",
-        {},
-        csrftoken_from=use_csrf or None,
-    )
-    if return_json:
-        assert response.status == 200
-        assert response.json["ok"], response.json
-    else:
-        assert response.status == 302
-        messages = magic_parameters_client.ds.unsign(
-            response.cookies["ds_messages"], "messages"
-        )
-        assert [["Query executed, 1 row affected", 1]] == messages
-    post_actual = magic_parameters_client.get(
-        "/data/logs.json?_sort_desc=rowid&_shape=array"
-    ).json[0]["line"]
-    assert post_actual == "localhost"
-
-
-def test_magic_parameters_cannot_be_used_in_arbitrary_queries(magic_parameters_client):
-    response = magic_parameters_client.get(
-        "/data/-/query.json?sql=select+:_header_host&_shape=array"
-    )
-    assert 400 == response.status
-    assert response.json["error"].startswith("You did not supply a value for binding")
-
-
-def test_canned_write_custom_template(canned_write_client):
-    response = canned_write_client.get("/data/update_name")
-    assert response.status == 200
-    assert "!!!CUSTOM_UPDATE_NAME_TEMPLATE!!!" in response.text
-    assert (
-        "<!-- Templates considered: *query-data-update_name.html, query-data.html, query.html -->"
-        in response.text
-    )
-    # And test for link rel=alternate while we're here:
-    assert (
-        '<link rel="alternate" type="application/json+datasette" href="http://localhost/data/update_name.json">'
-        in response.text
-    )
-    assert (
-        response.headers["link"]
-        == '<http://localhost/data/update_name.json>; rel="alternate"; type="application/json+datasette"'
-    )
-
-
-def test_canned_write_query_disabled_for_immutable_database(
-    canned_write_immutable_client,
-):
-    response = canned_write_immutable_client.get("/fixtures/add")
-    assert response.status == 200
-    assert (
-        "This query cannot be executed because the database is immutable."
-        in response.text
-    )
-    assert '<input type="submit" value="Run SQL" disabled>' in response.text
-    # Submitting form should get a forbidden error
-    response = canned_write_immutable_client.post(
-        "/fixtures/add",
-        {"text": "text"},
-        csrftoken_from=True,
-    )
-    assert response.status == 403
-    assert "Database is immutable" in response.text
diff --git a/tests/test_html.py b/tests/test_html.py
index 8edb9f6e..a9de5e79 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -633,7 +633,7 @@ async def test_404_content_type(ds_client):
 
 
 @pytest.mark.asyncio
-async def test_canned_query_default_title(ds_client):
+async def test_stored_query_default_title(ds_client):
     response = await ds_client.get("/fixtures/magic_parameters")
     assert response.status_code == 200
     soup = Soup(response.content, "html.parser")
@@ -641,7 +641,7 @@ async def test_canned_query_default_title(ds_client):
 
 
 @pytest.mark.asyncio
-async def test_canned_query_with_custom_metadata(ds_client):
+async def test_stored_query_with_custom_metadata(ds_client):
     response = await ds_client.get("/fixtures/neighborhood_search?text=town")
     assert response.status_code == 200
     soup = Soup(response.content, "html.parser")
@@ -700,7 +700,7 @@ async def test_show_hide_sql_query(ds_client):
 
 
 @pytest.mark.asyncio
-async def test_canned_query_with_hide_has_no_hidden_sql(ds_client):
+async def test_stored_query_with_hide_has_no_hidden_sql(ds_client):
     # For a stored query the show/hide should NOT have a hidden SQL field
     # https://github.com/simonw/datasette/issues/1411
     response = await ds_client.get("/fixtures/pragma_cache_size?_hide_sql=1")
@@ -720,7 +720,7 @@ async def test_canned_query_with_hide_has_no_hidden_sql(ds_client):
         (True, "?_show_sql=1", "_show_sql", "/_memory/one", "hide"),
     ),
 )
-def test_canned_query_show_hide_metadata_option(
+def test_stored_query_show_hide_metadata_option(
     hide_sql,
     querystring,
     expected_hidden,
@@ -981,10 +981,10 @@ def test_base_url_affects_metadata_extra_css_urls(app_client_base_url_prefix):
         ("/fixtures/magic_parameters", None),
     ],
 )
-async def test_edit_sql_link_on_canned_queries(ds_client, path, expected):
+async def test_edit_sql_link_on_stored_queries(ds_client, path, expected):
     response = await ds_client.get(path)
     assert response.status_code == 200
-    expected_link = f'<a href="{expected}" class="canned-query-edit-sql">Edit SQL</a>'
+    expected_link = f'<a href="{expected}" class="stored-query-edit-sql">Edit SQL</a>'
     if expected:
         assert expected_link in response.text
     else:
diff --git a/tests/test_jump.py b/tests/test_jump.py
index f60af0fd..513a809f 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -76,7 +76,7 @@ async def ds_for_jump():
 
 
 @pytest.mark.asyncio
-async def test_jump_searches_tables_databases_views_and_canned_queries(ds_for_jump):
+async def test_jump_searches_tables_databases_views_and_stored_queries(ds_for_jump):
     response = await ds_for_jump.client.get(
         "/-/jump.json?q=content", actor={"id": "user"}
     )
@@ -98,7 +98,7 @@ async def test_jump_searches_tables_databases_views_and_canned_queries(ds_for_ju
 
 
 @pytest.mark.asyncio
-async def test_jump_uses_canned_query_names_not_titles(ds_for_jump):
+async def test_jump_uses_stored_query_names_not_titles(ds_for_jump):
     response = await ds_for_jump.client.get(
         "/-/jump.json?q=datasette", actor={"id": "user"}
     )

From cafb6b9dbd77e438b81a7784c4434957b73fb856 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:20:29 -0700
Subject: [PATCH 093/386] Need is_trusted=True for the counters demo

---
 .github/workflows/deploy-latest.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/deploy-latest.yml b/.github/workflows/deploy-latest.yml
index 166d33d0..b0640ae8 100644
--- a/.github/workflows/deploy-latest.yml
+++ b/.github/workflows/deploy-latest.yml
@@ -76,6 +76,7 @@ jobs:
                         "update counters set value = value + 1 where name = '{}'".format(name),
                         on_success_message_sql="select 'Counter {name} incremented to ' || value from counters where name = '{name}'".format(name=name),
                         is_write=True,
+                        is_trusted=True,
                     )
                     await datasette.add_query(
                         "counters",
@@ -83,6 +84,7 @@ jobs:
                         "update counters set value = value - 1 where name = '{}'".format(name),
                         on_success_message_sql="select 'Counter {name} decremented to ' || value from counters where name = '{name}'".format(name=name),
                         is_write=True,
+                        is_trusted=True,
                     )
             return inner
         EOF

From e2864fc895603c1fdf03d3c55812a0a6e56779ff Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:21:09 -0700
Subject: [PATCH 094/386] test_stored_queries.py

---
 tests/test_stored_queries.py | 473 +++++++++++++++++++++++++++++++++++
 1 file changed, 473 insertions(+)
 create mode 100644 tests/test_stored_queries.py

diff --git a/tests/test_stored_queries.py b/tests/test_stored_queries.py
new file mode 100644
index 00000000..2c648d5f
--- /dev/null
+++ b/tests/test_stored_queries.py
@@ -0,0 +1,473 @@
+from bs4 import BeautifulSoup as Soup
+from asgiref.sync import async_to_sync
+import json
+import pytest
+import re
+from .fixtures import make_app_client
+
+
+def update_query(client, name, **kwargs):
+    async_to_sync(client.ds.invoke_startup)()
+    async_to_sync(client.ds.update_query)("data", name, **kwargs)
+
+
+@pytest.fixture
+def stored_write_client(tmpdir):
+    template_dir = tmpdir / "stored_write_templates"
+    template_dir.mkdir()
+    (template_dir / "query-data-update_name.html").write_text(
+        """
+    {% extends "query.html" %}
+    {% block content %}!!!CUSTOM_UPDATE_NAME_TEMPLATE!!!{{ super() }}{% endblock %}
+    """,
+        "utf-8",
+    )
+    with make_app_client(
+        extra_databases={"data.db": "create table names (name text)"},
+        template_dir=str(template_dir),
+        config={
+            "databases": {
+                "data": {
+                    "queries": {
+                        "stored_read": {"sql": "select * from names"},
+                        "add_name": {
+                            "sql": "insert into names (name) values (:name)",
+                            "write": True,
+                            "on_success_redirect": "/data/add_name?success",
+                        },
+                        "add_name_specify_id": {
+                            "sql": "insert into names (rowid, name) values (:rowid, :name)",
+                            "on_success_message_sql": "select 'Name added: ' || :name || ' with rowid ' || :rowid",
+                            "write": True,
+                            "on_error_redirect": "/data/add_name_specify_id?error",
+                        },
+                        "add_name_specify_id_with_error_in_on_success_message_sql": {
+                            "sql": "insert into names (rowid, name) values (:rowid, :name)",
+                            "on_success_message_sql": "select this is bad SQL",
+                            "write": True,
+                        },
+                        "delete_name": {
+                            "sql": "delete from names where rowid = :rowid",
+                            "write": True,
+                            "on_success_message": "Name deleted",
+                            "allow": {"id": "root"},
+                        },
+                        "update_name": {
+                            "sql": "update names set name = :name where rowid = :rowid",
+                            "params": ["rowid", "name", "extra"],
+                            "write": True,
+                        },
+                    }
+                }
+            }
+        },
+    ) as client:
+        yield client
+
+
+@pytest.fixture
+def stored_write_immutable_client():
+    with make_app_client(
+        is_immutable=True,
+        config={
+            "databases": {
+                "fixtures": {
+                    "queries": {
+                        "add": {
+                            "sql": "insert into sortable (text) values (:text)",
+                            "write": True,
+                        },
+                    }
+                }
+            }
+        },
+    ) as client:
+        yield client
+
+
+@pytest.mark.asyncio
+async def test_stored_query_with_named_parameter(ds_client):
+    response = await ds_client.get(
+        "/fixtures/neighborhood_search.json?text=town&_shape=arrays"
+    )
+    assert response.json()["rows"] == [
+        ["Corktown", "Detroit", "MI"],
+        ["Downtown", "Los Angeles", "CA"],
+        ["Downtown", "Detroit", "MI"],
+        ["Greektown", "Detroit", "MI"],
+        ["Koreatown", "Los Angeles", "CA"],
+        ["Mexicantown", "Detroit", "MI"],
+    ]
+
+
+def test_insert(stored_write_client):
+    response = stored_write_client.post(
+        "/data/add_name",
+        {"name": "Hello"},
+        csrftoken_from=True,
+        cookies={"foo": "bar"},
+    )
+    messages = stored_write_client.ds.unsign(
+        response.cookies["ds_messages"], "messages"
+    )
+    assert messages == [["Query executed, 1 row affected", 1]]
+    assert response.status == 302
+    assert response.headers["Location"] == "/data/add_name?success"
+
+
+def test_insert_blocked_cross_site(stored_write_client):
+    # A cross-site POST (browser-originated) must be blocked
+    response = stored_write_client.post(
+        "/data/add_name",
+        {"name": "Hello"},
+        headers={"sec-fetch-site": "cross-site"},
+    )
+    assert 403 == response.status
+
+
+def test_insert_no_cookies_no_csrf(stored_write_client):
+    response = stored_write_client.post("/data/add_name", {"name": "Hello"})
+    assert 302 == response.status
+    assert "/data/add_name?success" == response.headers["Location"]
+
+
+def test_custom_success_message(stored_write_client):
+    response = stored_write_client.post(
+        "/data/delete_name",
+        {"rowid": 1},
+        cookies={"ds_actor": stored_write_client.actor_cookie({"id": "root"})},
+        csrftoken_from=True,
+    )
+    assert 302 == response.status
+    messages = stored_write_client.ds.unsign(
+        response.cookies["ds_messages"], "messages"
+    )
+    assert [["Name deleted", 1]] == messages
+
+
+def test_insert_error(stored_write_client):
+    stored_write_client.post("/data/add_name", {"name": "Hello"}, csrftoken_from=True)
+    response = stored_write_client.post(
+        "/data/add_name_specify_id",
+        {"rowid": 1, "name": "Should fail"},
+        csrftoken_from=True,
+    )
+    assert 302 == response.status
+    assert "/data/add_name_specify_id?error" == response.headers["Location"]
+    messages = stored_write_client.ds.unsign(
+        response.cookies["ds_messages"], "messages"
+    )
+    assert [["UNIQUE constraint failed: names.rowid", 3]] == messages
+    # How about with a custom error message?
+    update_query(stored_write_client, "add_name_specify_id", on_error_message="ERROR")
+    response = stored_write_client.post(
+        "/data/add_name_specify_id",
+        {"rowid": 1, "name": "Should fail"},
+        csrftoken_from=True,
+    )
+    assert [["ERROR", 3]] == stored_write_client.ds.unsign(
+        response.cookies["ds_messages"], "messages"
+    )
+
+
+def test_on_success_message_sql(stored_write_client):
+    response = stored_write_client.post(
+        "/data/add_name_specify_id",
+        {"rowid": 5, "name": "Should be OK"},
+        csrftoken_from=True,
+    )
+    assert response.status == 302
+    assert response.headers["Location"] == "/data/add_name_specify_id"
+    messages = stored_write_client.ds.unsign(
+        response.cookies["ds_messages"], "messages"
+    )
+    assert messages == [["Name added: Should be OK with rowid 5", 1]]
+
+
+def test_error_in_on_success_message_sql(stored_write_client):
+    response = stored_write_client.post(
+        "/data/add_name_specify_id_with_error_in_on_success_message_sql",
+        {"rowid": 1, "name": "Should fail"},
+        csrftoken_from=True,
+    )
+    messages = stored_write_client.ds.unsign(
+        response.cookies["ds_messages"], "messages"
+    )
+    assert messages == [
+        ["Error running on_success_message_sql: no such column: bad", 3]
+    ]
+
+
+def test_custom_params(stored_write_client):
+    response = stored_write_client.get("/data/update_name?extra=foo")
+    assert (
+        '<input type="text" id="qp3" name="extra" value="foo" data-parameter-control>'
+        in response.text
+    )
+
+
+def test_stored_query_pages_no_vary_header(stored_write_client):
+    # These pages no longer embed per-cookie CSRF tokens, so they must not
+    # set Vary: Cookie - they should be cacheable across users.
+    assert "vary" not in stored_write_client.get("/data").headers
+    assert "vary" not in stored_write_client.get("/data/update_name").headers
+
+
+def test_json_post_body(stored_write_client):
+    response = stored_write_client.post(
+        "/data/add_name",
+        body=json.dumps({"name": ["Hello", "there"]}),
+    )
+    assert 302 == response.status
+    assert "/data/add_name?success" == response.headers["Location"]
+    rows = stored_write_client.get("/data/names.json?_shape=array").json
+    assert rows == [{"rowid": 1, "name": "['Hello', 'there']"}]
+
+
+@pytest.mark.parametrize(
+    "headers,body,querystring",
+    (
+        (None, "name=NameGoesHere", "?_json=1"),
+        ({"Accept": "application/json"}, "name=NameGoesHere", None),
+        (None, "name=NameGoesHere&_json=1", None),
+        (None, '{"name": "NameGoesHere", "_json": 1}', None),
+    ),
+)
+def test_json_response(stored_write_client, headers, body, querystring):
+    response = stored_write_client.post(
+        "/data/add_name" + (querystring or ""),
+        body=body,
+        headers=headers,
+    )
+    assert 200 == response.status
+    assert response.headers["content-type"] == "application/json; charset=utf-8"
+    assert response.json == {
+        "ok": True,
+        "message": "Query executed, 1 row affected",
+        "redirect": "/data/add_name?success",
+    }
+    rows = stored_write_client.get("/data/names.json?_shape=array").json
+    assert rows == [{"rowid": 1, "name": "NameGoesHere"}]
+
+
+def test_stored_query_permissions_on_database_page(stored_write_client):
+    # Without auth shows the five public queries
+    anon_response = stored_write_client.get("/data.json")
+    query_names = {q["name"] for q in anon_response.json["queries"]}
+    assert query_names == {
+        "add_name_specify_id_with_error_in_on_success_message_sql",
+        "update_name",
+        "add_name_specify_id",
+        "stored_read",
+        "add_name",
+    }
+    assert anon_response.json["queries_more"] is False
+
+    # With auth the database page preview shows the first five queries
+    response = stored_write_client.get(
+        "/data.json",
+        cookies={"ds_actor": stored_write_client.actor_cookie({"id": "root"})},
+    )
+    assert response.status == 200
+    query_names_and_private = sorted(
+        [
+            {"name": q["name"], "private": q["private"]}
+            for q in response.json["queries"]
+        ],
+        key=lambda q: q["name"],
+    )
+    assert query_names_and_private == [
+        {"name": "add_name", "private": False},
+        {"name": "add_name_specify_id", "private": False},
+        {
+            "name": "add_name_specify_id_with_error_in_on_success_message_sql",
+            "private": False,
+        },
+        {"name": "delete_name", "private": True},
+        {"name": "stored_read", "private": False},
+    ]
+    assert response.json["queries_more"] is True
+
+    # The full query list endpoint includes the remaining query
+    response = stored_write_client.get(
+        "/data/-/queries.json?_size=10",
+        cookies={"ds_actor": stored_write_client.actor_cookie({"id": "root"})},
+    )
+    assert response.status == 200
+    query_names_and_private = sorted(
+        [
+            {"name": q["name"], "private": q["private"]}
+            for q in response.json["queries"]
+        ],
+        key=lambda q: q["name"],
+    )
+    assert query_names_and_private == [
+        {"name": "add_name", "private": False},
+        {"name": "add_name_specify_id", "private": False},
+        {
+            "name": "add_name_specify_id_with_error_in_on_success_message_sql",
+            "private": False,
+        },
+        {"name": "delete_name", "private": True},
+        {"name": "stored_read", "private": False},
+        {"name": "update_name", "private": False},
+    ]
+
+
+def test_stored_query_permissions(stored_write_client):
+    assert 403 == stored_write_client.get("/data/delete_name").status
+    assert 200 == stored_write_client.get("/data/update_name").status
+    cookies = {"ds_actor": stored_write_client.actor_cookie({"id": "root"})}
+    assert 200 == stored_write_client.get("/data/delete_name", cookies=cookies).status
+    assert 200 == stored_write_client.get("/data/update_name", cookies=cookies).status
+
+
+@pytest.fixture(scope="session")
+def magic_parameters_client():
+    with make_app_client(
+        extra_databases={"data.db": "create table logs (line text)"},
+        config={
+            "databases": {
+                "data": {
+                    "queries": {
+                        "runme_post": {"sql": "", "write": True},
+                        "runme_get": {"sql": ""},
+                    }
+                }
+            }
+        },
+    ) as client:
+        yield client
+
+
+@pytest.mark.parametrize(
+    "magic_parameter,expected_re",
+    [
+        ("_actor_id", "root"),
+        ("_header_host", "localhost"),
+        ("_header_not_a_thing", ""),
+        ("_cookie_foo", "bar"),
+        ("_now_epoch", r"^\d+$"),
+        ("_now_date_utc", r"^\d{4}-\d{2}-\d{2}$"),
+        ("_now_datetime_utc", r"^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$"),
+        ("_random_chars_1", r"^\w$"),
+        ("_random_chars_10", r"^\w{10}$"),
+    ],
+)
+def test_magic_parameters(magic_parameters_client, magic_parameter, expected_re):
+    update_query(
+        magic_parameters_client,
+        "runme_post",
+        sql=f"insert into logs (line) values (:{magic_parameter})",
+    )
+    update_query(
+        magic_parameters_client,
+        "runme_get",
+        sql=f"select :{magic_parameter} as result",
+    )
+    cookies = {
+        "ds_actor": magic_parameters_client.actor_cookie({"id": "root"}),
+        "foo": "bar",
+    }
+    # Test the GET version
+    get_response = magic_parameters_client.get(
+        "/data/runme_get.json?_shape=array", cookies=cookies
+    )
+    get_actual = get_response.json[0]["result"]
+    assert re.match(expected_re, str(get_actual))
+    # Test the form
+    form_response = magic_parameters_client.get("/data/runme_post")
+    soup = Soup(form_response.body, "html.parser")
+    # The magic parameter should not be represented as a form field
+    assert None is soup.find("input", {"name": magic_parameter})
+    # Submit the form to create a log line
+    response = magic_parameters_client.post(
+        "/data/runme_post?_json=1", {}, csrftoken_from=True, cookies=cookies
+    )
+    assert response.json == {
+        "ok": True,
+        "message": "Query executed, 1 row affected",
+        "redirect": None,
+    }
+    post_actual = magic_parameters_client.get(
+        "/data/logs.json?_sort_desc=rowid&_shape=array"
+    ).json[0]["line"]
+    assert re.match(expected_re, post_actual)
+
+
+@pytest.mark.parametrize("use_csrf", [True, False])
+@pytest.mark.parametrize("return_json", [True, False])
+def test_magic_parameters_csrf_json(magic_parameters_client, use_csrf, return_json):
+    update_query(
+        magic_parameters_client,
+        "runme_post",
+        sql="insert into logs (line) values (:_header_host)",
+    )
+    qs = ""
+    if return_json:
+        qs = "?_json=1"
+    response = magic_parameters_client.post(
+        f"/data/runme_post{qs}",
+        {},
+        csrftoken_from=use_csrf or None,
+    )
+    if return_json:
+        assert response.status == 200
+        assert response.json["ok"], response.json
+    else:
+        assert response.status == 302
+        messages = magic_parameters_client.ds.unsign(
+            response.cookies["ds_messages"], "messages"
+        )
+        assert [["Query executed, 1 row affected", 1]] == messages
+    post_actual = magic_parameters_client.get(
+        "/data/logs.json?_sort_desc=rowid&_shape=array"
+    ).json[0]["line"]
+    assert post_actual == "localhost"
+
+
+def test_magic_parameters_cannot_be_used_in_arbitrary_queries(magic_parameters_client):
+    response = magic_parameters_client.get(
+        "/data/-/query.json?sql=select+:_header_host&_shape=array"
+    )
+    assert 400 == response.status
+    assert response.json["error"].startswith("You did not supply a value for binding")
+
+
+def test_stored_write_custom_template(stored_write_client):
+    response = stored_write_client.get("/data/update_name")
+    assert response.status == 200
+    assert "!!!CUSTOM_UPDATE_NAME_TEMPLATE!!!" in response.text
+    assert (
+        "<!-- Templates considered: *query-data-update_name.html, query-data.html, query.html -->"
+        in response.text
+    )
+    # And test for link rel=alternate while we're here:
+    assert (
+        '<link rel="alternate" type="application/json+datasette" href="http://localhost/data/update_name.json">'
+        in response.text
+    )
+    assert (
+        response.headers["link"]
+        == '<http://localhost/data/update_name.json>; rel="alternate"; type="application/json+datasette"'
+    )
+
+
+def test_stored_write_query_disabled_for_immutable_database(
+    stored_write_immutable_client,
+):
+    response = stored_write_immutable_client.get("/fixtures/add")
+    assert response.status == 200
+    assert (
+        "This query cannot be executed because the database is immutable."
+        in response.text
+    )
+    assert '<input type="submit" value="Run SQL" disabled>' in response.text
+    # Submitting form should get a forbidden error
+    response = stored_write_immutable_client.post(
+        "/fixtures/add",
+        {"text": "text"},
+        csrftoken_from=True,
+    )
+    assert response.status == 403
+    assert "Database is immutable" in response.text

From ca4907ab6b01f5ba5fa241534be7c9557f269050 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:30:36 -0700
Subject: [PATCH 095/386] Make _save_queries_from_config a private method

---
 datasette/app.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 52d100cc..6b66a53b 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -598,7 +598,7 @@ class Datasette:
             # TODO(alex) is metadata.json was loaded in, and --internal is not memory, then log
             # a warning to user that they should delete their metadata.json file
 
-    async def apply_queries_config(self):
+    async def _save_queries_from_config(self):
         # Apply configured query entries from datasette.yaml to the internal table.
         await self.get_internal_database().execute_write(
             "DELETE FROM queries WHERE source = 'config'"
@@ -788,7 +788,7 @@ class Datasette:
             await await_me_maybe(hook)
         # Ensure internal tables and metadata are populated before startup hooks
         await self._refresh_schemas()
-        await self.apply_queries_config()
+        await self._save_queries_from_config()
         # Load column_types from config into internal DB
         await self._apply_column_types_config()
         for hook in pm.hook.startup(datasette=self):

From e89ffa0e0634a306be37bdd4894057329fee54a2 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:37:21 -0700
Subject: [PATCH 096/386] Fixed broken test caused by apply_queries_config()
 rename

---
 tests/test_permissions.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 0e38c876..e5e75432 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -937,7 +937,7 @@ async def test_permissions_in_config(
     updated_config = copy.deepcopy(previous_config)
     updated_config.update(config)
     perms_ds.config = updated_config
-    await perms_ds.apply_queries_config()
+    await perms_ds._save_queries_from_config()
     try:
         # Convert old-style resource to Resource object
         from datasette.resources import DatabaseResource, QueryResource, TableResource
@@ -964,7 +964,7 @@ async def test_permissions_in_config(
             assert result == expected_result
     finally:
         perms_ds.config = previous_config
-        await perms_ds.apply_queries_config()
+        await perms_ds._save_queries_from_config()
 
 
 @pytest.mark.asyncio

From 1bcd99df90d09049616fae411c2b6cddb6a82c7a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:42:36 -0700
Subject: [PATCH 097/386] Refactor code from datasette.app into
 datasette.stored_queries

The datasette/app.py file had grown a lot in this branch.
---
 datasette/app.py            | 537 ++++++-----------------------------
 datasette/stored_queries.py | 544 ++++++++++++++++++++++++++++++++++++
 2 files changed, 634 insertions(+), 447 deletions(-)
 create mode 100644 datasette/stored_queries.py

diff --git a/datasette/app.py b/datasette/app.py
index 6b66a53b..dd54446a 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -42,6 +42,7 @@ from jinja2.exceptions import TemplateNotFound
 
 from .events import Event
 from .column_types import SQLiteType
+from . import stored_queries
 from .views import Context
 from .views.database import (
     database_download,
@@ -108,7 +109,6 @@ from .utils import (
     module_from_path,
     move_plugins_and_allow,
     move_table_config,
-    named_parameters,
     parse_metadata,
     resolve_env_secrets,
     resolve_routes,
@@ -284,17 +284,6 @@ DEFAULT_SETTINGS = {option.name: option.default for option in SETTINGS}
 FAVICON_PATH = app_root / "datasette" / "static" / "favicon.png"
 
 DEFAULT_NOT_SET = object()
-UNCHANGED = object()
-
-QUERY_OPTION_FIELDS = (
-    "hide_sql",
-    "fragment",
-    "on_success_message",
-    "on_success_message_sql",
-    "on_success_redirect",
-    "on_error_message",
-    "on_error_redirect",
-)
 
 
 ResourcesSQL = collections.namedtuple("ResourcesSQL", ("sql", "params"))
@@ -599,34 +588,7 @@ class Datasette:
             # a warning to user that they should delete their metadata.json file
 
     async def _save_queries_from_config(self):
-        # Apply configured query entries from datasette.yaml to the internal table.
-        await self.get_internal_database().execute_write(
-            "DELETE FROM queries WHERE source = 'config'"
-        )
-        for dbname, db_config in ((self.config or {}).get("databases") or {}).items():
-            for query_name, query_config in (db_config.get("queries") or {}).items():
-                if not isinstance(query_config, dict):
-                    query_config = {"sql": query_config}
-                await self.add_query(
-                    dbname,
-                    query_name,
-                    query_config["sql"],
-                    title=query_config.get("title"),
-                    description=query_config.get("description"),
-                    description_html=query_config.get("description_html"),
-                    hide_sql=bool(query_config.get("hide_sql")),
-                    fragment=query_config.get("fragment"),
-                    parameters=query_config.get("params"),
-                    is_write=bool(query_config.get("write")),
-                    is_private=bool(query_config.get("is_private")),
-                    is_trusted=bool(query_config.get("is_trusted", True)),
-                    source="config",
-                    on_success_message=query_config.get("on_success_message"),
-                    on_success_message_sql=query_config.get("on_success_message_sql"),
-                    on_success_redirect=query_config.get("on_success_redirect"),
-                    on_error_message=query_config.get("on_error_message"),
-                    on_error_redirect=query_config.get("on_error_redirect"),
-                )
+        await stored_queries.save_queries_from_config(self)
 
     def get_jinja_environment(self, request: Request = None) -> Environment:
         environment = self._jinja_env
@@ -1067,46 +1029,11 @@ class Datasette:
 
     @staticmethod
     def _query_row_to_dict(row):
-        if row is None:
-            return None
-        parameters = json.loads(row["parameters"] or "[]")
-        options = json.loads(row["options"] or "{}")
-        is_write = bool(row["is_write"])
-        return {
-            "database": row["database_name"],
-            "name": row["name"],
-            "sql": row["sql"],
-            "title": row["title"],
-            "description": row["description"],
-            "description_html": row["description_html"],
-            "hide_sql": bool(options.get("hide_sql")),
-            "fragment": options.get("fragment"),
-            "params": parameters,
-            "parameters": parameters,
-            "is_write": is_write,
-            "write": is_write,
-            "is_private": bool(row["is_private"]),
-            "is_trusted": bool(row["is_trusted"]),
-            "source": row["source"],
-            "owner_id": row["owner_id"],
-            "on_success_message": options.get("on_success_message"),
-            "on_success_message_sql": options.get("on_success_message_sql"),
-            "on_success_redirect": options.get("on_success_redirect"),
-            "on_error_message": options.get("on_error_message"),
-            "on_error_redirect": options.get("on_error_redirect"),
-        }
+        return stored_queries.query_row_to_dict(row)
 
     @staticmethod
     def _query_options_json(options):
-        options_dict = {}
-        for field in QUERY_OPTION_FIELDS:
-            value = options.get(field)
-            if field == "hide_sql":
-                if value:
-                    options_dict[field] = True
-            elif value is not None:
-                options_dict[field] = value
-        return json.dumps(options_dict, sort_keys=True)
+        return stored_queries.query_options_json(options)
 
     async def add_query(
         self,
@@ -1132,57 +1059,28 @@ class Datasette:
         on_error_redirect=None,
         replace=True,
     ):
-        parameters_json = json.dumps(list(parameters or []))
-        options_json = self._query_options_json(
-            {
-                "hide_sql": hide_sql,
-                "fragment": fragment,
-                "on_success_message": on_success_message,
-                "on_success_message_sql": on_success_message_sql,
-                "on_success_redirect": on_success_redirect,
-                "on_error_message": on_error_message,
-                "on_error_redirect": on_error_redirect,
-            }
-        )
-        sql_statement = """
-            INSERT INTO queries (
-                database_name, name, sql, title, description, description_html,
-                options, parameters, is_write, is_private, is_trusted, source, owner_id
-            ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
-        """
-        if replace:
-            sql_statement += """
-                ON CONFLICT(database_name, name) DO UPDATE SET
-                    sql = excluded.sql,
-                    title = excluded.title,
-                    description = excluded.description,
-                    description_html = excluded.description_html,
-                    options = excluded.options,
-                    parameters = excluded.parameters,
-                    is_write = excluded.is_write,
-                    is_private = excluded.is_private,
-                    is_trusted = excluded.is_trusted,
-                    source = excluded.source,
-                    owner_id = excluded.owner_id,
-                    updated_at = CURRENT_TIMESTAMP
-            """
-        await self.get_internal_database().execute_write(
-            sql_statement,
-            [
-                database,
-                name,
-                sql,
-                title,
-                description,
-                description_html,
-                options_json,
-                parameters_json,
-                int(bool(is_write)),
-                int(bool(is_private)),
-                int(bool(is_trusted)),
-                source,
-                owner_id,
-            ],
+        return await stored_queries.add_query(
+            self,
+            database,
+            name,
+            sql,
+            title=title,
+            description=description,
+            description_html=description_html,
+            hide_sql=hide_sql,
+            fragment=fragment,
+            parameters=parameters,
+            is_write=is_write,
+            is_private=is_private,
+            is_trusted=is_trusted,
+            source=source,
+            owner_id=owner_id,
+            on_success_message=on_success_message,
+            on_success_message_sql=on_success_message_sql,
+            on_success_redirect=on_success_redirect,
+            on_error_message=on_error_message,
+            on_error_redirect=on_error_redirect,
+            replace=replace,
         )
 
     async def update_query(
@@ -1190,113 +1088,52 @@ class Datasette:
         database,
         name,
         *,
-        sql=UNCHANGED,
-        title=UNCHANGED,
-        description=UNCHANGED,
-        description_html=UNCHANGED,
-        hide_sql=UNCHANGED,
-        fragment=UNCHANGED,
-        parameters=UNCHANGED,
-        is_write=UNCHANGED,
-        is_private=UNCHANGED,
-        is_trusted=UNCHANGED,
-        source=UNCHANGED,
-        owner_id=UNCHANGED,
-        on_success_message=UNCHANGED,
-        on_success_message_sql=UNCHANGED,
-        on_success_redirect=UNCHANGED,
-        on_error_message=UNCHANGED,
-        on_error_redirect=UNCHANGED,
+        sql=stored_queries.UNCHANGED,
+        title=stored_queries.UNCHANGED,
+        description=stored_queries.UNCHANGED,
+        description_html=stored_queries.UNCHANGED,
+        hide_sql=stored_queries.UNCHANGED,
+        fragment=stored_queries.UNCHANGED,
+        parameters=stored_queries.UNCHANGED,
+        is_write=stored_queries.UNCHANGED,
+        is_private=stored_queries.UNCHANGED,
+        is_trusted=stored_queries.UNCHANGED,
+        source=stored_queries.UNCHANGED,
+        owner_id=stored_queries.UNCHANGED,
+        on_success_message=stored_queries.UNCHANGED,
+        on_success_message_sql=stored_queries.UNCHANGED,
+        on_success_redirect=stored_queries.UNCHANGED,
+        on_error_message=stored_queries.UNCHANGED,
+        on_error_redirect=stored_queries.UNCHANGED,
     ):
-        fields = {
-            "sql": sql,
-            "title": title,
-            "description": description,
-            "description_html": description_html,
-            "parameters": parameters,
-            "is_write": is_write,
-            "is_private": is_private,
-            "is_trusted": is_trusted,
-            "source": source,
-            "owner_id": owner_id,
-        }
-        option_fields = {
-            "hide_sql": hide_sql,
-            "fragment": fragment,
-            "on_success_message": on_success_message,
-            "on_success_message_sql": on_success_message_sql,
-            "on_success_redirect": on_success_redirect,
-            "on_error_message": on_error_message,
-            "on_error_redirect": on_error_redirect,
-        }
-        updates = []
-        params = []
-        for field, value in fields.items():
-            if value is UNCHANGED:
-                continue
-            if field in {"is_write", "is_private", "is_trusted"}:
-                value = int(bool(value))
-            elif field == "parameters":
-                value = json.dumps(list(value or []))
-            updates.append(f"{field} = ?")
-            params.append(value)
-        changed_options = {
-            field: value
-            for field, value in option_fields.items()
-            if value is not UNCHANGED
-        }
-        if changed_options:
-            rows = await self.get_internal_database().execute(
-                """
-                SELECT options FROM queries
-                WHERE database_name = ? AND name = ?
-                """,
-                [database, name],
-            )
-            row = rows.first()
-            options = json.loads(row["options"] or "{}") if row is not None else {}
-            for field, value in changed_options.items():
-                if field == "hide_sql":
-                    if value:
-                        options[field] = True
-                    else:
-                        options.pop(field, None)
-                elif value is None:
-                    options.pop(field, None)
-                else:
-                    options[field] = value
-            updates.append("options = ?")
-            params.append(json.dumps(options, sort_keys=True))
-        if not updates:
-            return
-        updates.append("updated_at = CURRENT_TIMESTAMP")
-        params.extend([database, name])
-        await self.get_internal_database().execute_write(
-            """
-            UPDATE queries
-            SET {}
-            WHERE database_name = ? AND name = ?
-            """.format(", ".join(updates)),
-            params,
+        return await stored_queries.update_query(
+            self,
+            database,
+            name,
+            sql=sql,
+            title=title,
+            description=description,
+            description_html=description_html,
+            hide_sql=hide_sql,
+            fragment=fragment,
+            parameters=parameters,
+            is_write=is_write,
+            is_private=is_private,
+            is_trusted=is_trusted,
+            source=source,
+            owner_id=owner_id,
+            on_success_message=on_success_message,
+            on_success_message_sql=on_success_message_sql,
+            on_success_redirect=on_success_redirect,
+            on_error_message=on_error_message,
+            on_error_redirect=on_error_redirect,
         )
 
     async def remove_query(self, database, name, source=None):
-        sql = "DELETE FROM queries WHERE database_name = ? AND name = ?"
-        params = [database, name]
-        if source is not None:
-            sql += " AND source = ?"
-            params.append(source)
-        await self.get_internal_database().execute_write(sql, params)
+        return await stored_queries.remove_query(self, database, name, source=source)
 
     async def get_query(self, database, name):
-        rows = await self.get_internal_database().execute(
-            """
-            SELECT * FROM queries
-            WHERE database_name = ? AND name = ?
-            """,
-            [database, name],
-        )
-        return self._query_row_to_dict(rows.first())
+        return await stored_queries.get_query(self, database, name)
 
     async def count_queries(
         self,
@@ -1310,62 +1147,17 @@ class Datasette:
         source=None,
         owner_id=None,
     ):
-        allowed_sql, allowed_params = await self.allowed_resources_sql(
-            action="view-query",
+        return await stored_queries.count_queries(
+            self,
+            database,
             actor=actor,
-            parent=database,
+            q=q,
+            is_write=is_write,
+            is_private=is_private,
+            is_trusted=is_trusted,
+            source=source,
+            owner_id=owner_id,
         )
-        params = dict(allowed_params)
-        where_clauses = []
-        if database is not None:
-            params["query_database"] = database
-            where_clauses.append("q.database_name = :query_database")
-
-        if q:
-            where_clauses.append("""
-                (
-                    q.name LIKE :query_search
-                    OR q.title LIKE :query_search
-                    OR q.description LIKE :query_search
-                    OR q.sql LIKE :query_search
-                )
-                """)
-            params["query_search"] = "%{}%".format(q)
-        if is_write is not None:
-            where_clauses.append("q.is_write = :query_is_write")
-            params["query_is_write"] = int(bool(is_write))
-        if is_private is not None:
-            where_clauses.append("q.is_private = :query_is_private")
-            params["query_is_private"] = int(bool(is_private))
-        if is_trusted is not None:
-            where_clauses.append("q.is_trusted = :query_is_trusted")
-            params["query_is_trusted"] = int(bool(is_trusted))
-        if source is not None:
-            where_clauses.append("q.source = :query_source")
-            params["query_source"] = source
-        if owner_id is not None:
-            where_clauses.append("q.owner_id = :query_owner_id")
-            params["query_owner_id"] = owner_id
-
-        row = (
-            await self.get_internal_database().execute(
-                """
-                SELECT count(*) AS count
-                FROM queries q
-                JOIN (
-                    {allowed_sql}
-                ) allowed
-                  ON allowed.parent = q.database_name
-                 AND allowed.child = q.name
-                WHERE {where}
-                """.format(
-                    allowed_sql=allowed_sql,
-                    where=" AND ".join(where_clauses) or "1 = 1",
-                ),
-                params,
-            )
-        ).first()
-        return row["count"]
 
     async def list_queries(
         self,
@@ -1382,176 +1174,27 @@ class Datasette:
         owner_id=None,
         include_private=False,
     ):
-        limit = min(max(1, int(limit)), 1000)
-        allowed_sql, allowed_params = await self.allowed_resources_sql(
-            action="view-query",
+        return await stored_queries.list_queries(
+            self,
+            database,
             actor=actor,
-            parent=database,
-            include_is_private=include_private,
+            limit=limit,
+            cursor=cursor,
+            q=q,
+            is_write=is_write,
+            is_private=is_private,
+            is_trusted=is_trusted,
+            source=source,
+            owner_id=owner_id,
+            include_private=include_private,
         )
-        params = dict(allowed_params)
-        params.update({"limit": limit + 1})
-        sort_key_sql = "lower(coalesce(nullif(q.title, ''), q.name))"
-        where_clauses = []
-        order_by = "q.database_name, sort_key, q.name"
-        if database is not None:
-            params["query_database"] = database
-            where_clauses.append("q.database_name = :query_database")
-            order_by = "sort_key, q.name"
-
-        if cursor:
-            try:
-                components = urlsafe_components(cursor)
-            except ValueError:
-                components = []
-            if database is None and len(components) == 3:
-                where_clauses.append("""
-                    (
-                        q.database_name > :cursor_database
-                        OR (
-                            q.database_name = :cursor_database
-                            AND (
-                                {sort_key_sql} > :cursor_sort_key
-                                OR (
-                                    {sort_key_sql} = :cursor_sort_key
-                                    AND q.name > :cursor_name
-                                )
-                            )
-                        )
-                    )
-                    """.format(sort_key_sql=sort_key_sql))
-                params["cursor_database"] = components[0]
-                params["cursor_sort_key"] = components[1]
-                params["cursor_name"] = components[2]
-            elif database is not None and len(components) == 2:
-                where_clauses.append("""
-                    (
-                        {sort_key_sql} > :cursor_sort_key
-                        OR (
-                            {sort_key_sql} = :cursor_sort_key
-                            AND q.name > :cursor_name
-                        )
-                    )
-                    """.format(sort_key_sql=sort_key_sql))
-                params["cursor_sort_key"] = components[0]
-                params["cursor_name"] = components[1]
-
-        if q:
-            where_clauses.append("""
-                (
-                    q.name LIKE :query_search
-                    OR q.title LIKE :query_search
-                    OR q.description LIKE :query_search
-                    OR q.sql LIKE :query_search
-                )
-                """)
-            params["query_search"] = "%{}%".format(q)
-        if is_write is not None:
-            where_clauses.append("q.is_write = :query_is_write")
-            params["query_is_write"] = int(bool(is_write))
-        if is_private is not None:
-            where_clauses.append("q.is_private = :query_is_private")
-            params["query_is_private"] = int(bool(is_private))
-        if is_trusted is not None:
-            where_clauses.append("q.is_trusted = :query_is_trusted")
-            params["query_is_trusted"] = int(bool(is_trusted))
-        if source is not None:
-            where_clauses.append("q.source = :query_source")
-            params["query_source"] = source
-        if owner_id is not None:
-            where_clauses.append("q.owner_id = :query_owner_id")
-            params["query_owner_id"] = owner_id
-
-        private_select = ", allowed.is_private AS private" if include_private else ""
-        rows = list(
-            (
-                await self.get_internal_database().execute(
-                    """
-                    SELECT q.*, {sort_key_sql} AS sort_key{private_select}
-                    FROM queries q
-                    JOIN (
-                        {allowed_sql}
-                    ) allowed
-                      ON allowed.parent = q.database_name
-                     AND allowed.child = q.name
-                    WHERE {where}
-                    ORDER BY {order_by}
-                    LIMIT :limit
-                    """.format(
-                        allowed_sql=allowed_sql,
-                        private_select=private_select,
-                        sort_key_sql=sort_key_sql,
-                        where=" AND ".join(where_clauses) or "1 = 1",
-                        order_by=order_by,
-                    ),
-                    params,
-                )
-            ).rows
-        )
-        has_more = len(rows) > limit
-        if has_more:
-            rows = rows[:limit]
-
-        queries = []
-        for row in rows:
-            query = self._query_row_to_dict(row)
-            if include_private:
-                query["private"] = bool(row["private"])
-            queries.append(query)
-
-        next_token = None
-        if has_more and rows:
-            last_row = rows[-1]
-            if database is None:
-                next_token = "{},{},{}".format(
-                    tilde_encode(last_row["database_name"]),
-                    tilde_encode(last_row["sort_key"]),
-                    tilde_encode(last_row["name"]),
-                )
-            else:
-                next_token = "{},{}".format(
-                    tilde_encode(last_row["sort_key"]),
-                    tilde_encode(last_row["name"]),
-                )
-        return {
-            "queries": queries,
-            "next": next_token,
-            "has_more": has_more,
-            "limit": limit,
-        }
 
     async def ensure_query_write_permissions(
         self, database, sql, *, actor=None, params=None, analysis=None
     ):
-        write_actions = {
-            "insert": "insert-row",
-            "update": "update-row",
-            "delete": "delete-row",
-        }
-        db = self.get_database(database)
-        if analysis is None:
-            if params is None:
-                params = {name: "" for name in named_parameters(sql)}
-            try:
-                analysis = await db.analyze_sql(sql, params)
-            except sqlite3.DatabaseError as ex:
-                raise Forbidden(f"Could not analyze query: {ex}") from ex
-
-        for access in analysis.table_accesses:
-            action = write_actions.get(access.operation)
-            if action is None:
-                continue
-            if access.database != database:
-                raise Forbidden("Writable queries may not write to attached databases")
-            if not await self.allowed(
-                action=action,
-                resource=TableResource(database=access.database, table=access.table),
-                actor=actor,
-            ):
-                raise Forbidden(
-                    f"Permission denied: need {action} on {access.database}/{access.table}"
-                )
-        return analysis
+        return await stored_queries.ensure_query_write_permissions(
+            self, database, sql, actor=actor, params=params, analysis=analysis
+        )
 
     # Column types API
 
diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
new file mode 100644
index 00000000..e88902e7
--- /dev/null
+++ b/datasette/stored_queries.py
@@ -0,0 +1,544 @@
+from __future__ import annotations
+
+import json
+
+from .resources import TableResource
+from .utils import named_parameters, sqlite3, tilde_encode, urlsafe_components
+from .utils.asgi import Forbidden
+
+
+UNCHANGED = object()
+
+QUERY_OPTION_FIELDS = (
+    "hide_sql",
+    "fragment",
+    "on_success_message",
+    "on_success_message_sql",
+    "on_success_redirect",
+    "on_error_message",
+    "on_error_redirect",
+)
+
+
+async def save_queries_from_config(datasette):
+    # Apply configured query entries from datasette.yaml to the internal table.
+    await datasette.get_internal_database().execute_write(
+        "DELETE FROM queries WHERE source = 'config'"
+    )
+    for dbname, db_config in ((datasette.config or {}).get("databases") or {}).items():
+        for query_name, query_config in (db_config.get("queries") or {}).items():
+            if not isinstance(query_config, dict):
+                query_config = {"sql": query_config}
+            await datasette.add_query(
+                dbname,
+                query_name,
+                query_config["sql"],
+                title=query_config.get("title"),
+                description=query_config.get("description"),
+                description_html=query_config.get("description_html"),
+                hide_sql=bool(query_config.get("hide_sql")),
+                fragment=query_config.get("fragment"),
+                parameters=query_config.get("params"),
+                is_write=bool(query_config.get("write")),
+                is_private=bool(query_config.get("is_private")),
+                is_trusted=bool(query_config.get("is_trusted", True)),
+                source="config",
+                on_success_message=query_config.get("on_success_message"),
+                on_success_message_sql=query_config.get("on_success_message_sql"),
+                on_success_redirect=query_config.get("on_success_redirect"),
+                on_error_message=query_config.get("on_error_message"),
+                on_error_redirect=query_config.get("on_error_redirect"),
+            )
+
+
+def query_row_to_dict(row):
+    if row is None:
+        return None
+    parameters = json.loads(row["parameters"] or "[]")
+    options = json.loads(row["options"] or "{}")
+    is_write = bool(row["is_write"])
+    return {
+        "database": row["database_name"],
+        "name": row["name"],
+        "sql": row["sql"],
+        "title": row["title"],
+        "description": row["description"],
+        "description_html": row["description_html"],
+        "hide_sql": bool(options.get("hide_sql")),
+        "fragment": options.get("fragment"),
+        "params": parameters,
+        "parameters": parameters,
+        "is_write": is_write,
+        "write": is_write,
+        "is_private": bool(row["is_private"]),
+        "is_trusted": bool(row["is_trusted"]),
+        "source": row["source"],
+        "owner_id": row["owner_id"],
+        "on_success_message": options.get("on_success_message"),
+        "on_success_message_sql": options.get("on_success_message_sql"),
+        "on_success_redirect": options.get("on_success_redirect"),
+        "on_error_message": options.get("on_error_message"),
+        "on_error_redirect": options.get("on_error_redirect"),
+    }
+
+
+def query_options_json(options):
+    options_dict = {}
+    for field in QUERY_OPTION_FIELDS:
+        value = options.get(field)
+        if field == "hide_sql":
+            if value:
+                options_dict[field] = True
+        elif value is not None:
+            options_dict[field] = value
+    return json.dumps(options_dict, sort_keys=True)
+
+
+async def add_query(
+    datasette,
+    database,
+    name,
+    sql,
+    *,
+    title=None,
+    description=None,
+    description_html=None,
+    hide_sql=False,
+    fragment=None,
+    parameters=None,
+    is_write=False,
+    is_private=False,
+    is_trusted=False,
+    source="plugin",
+    owner_id=None,
+    on_success_message=None,
+    on_success_message_sql=None,
+    on_success_redirect=None,
+    on_error_message=None,
+    on_error_redirect=None,
+    replace=True,
+):
+    parameters_json = json.dumps(list(parameters or []))
+    options_json = query_options_json(
+        {
+            "hide_sql": hide_sql,
+            "fragment": fragment,
+            "on_success_message": on_success_message,
+            "on_success_message_sql": on_success_message_sql,
+            "on_success_redirect": on_success_redirect,
+            "on_error_message": on_error_message,
+            "on_error_redirect": on_error_redirect,
+        }
+    )
+    sql_statement = """
+        INSERT INTO queries (
+            database_name, name, sql, title, description, description_html,
+            options, parameters, is_write, is_private, is_trusted, source, owner_id
+        ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+    """
+    if replace:
+        sql_statement += """
+            ON CONFLICT(database_name, name) DO UPDATE SET
+                sql = excluded.sql,
+                title = excluded.title,
+                description = excluded.description,
+                description_html = excluded.description_html,
+                options = excluded.options,
+                parameters = excluded.parameters,
+                is_write = excluded.is_write,
+                is_private = excluded.is_private,
+                is_trusted = excluded.is_trusted,
+                source = excluded.source,
+                owner_id = excluded.owner_id,
+                updated_at = CURRENT_TIMESTAMP
+        """
+    await datasette.get_internal_database().execute_write(
+        sql_statement,
+        [
+            database,
+            name,
+            sql,
+            title,
+            description,
+            description_html,
+            options_json,
+            parameters_json,
+            int(bool(is_write)),
+            int(bool(is_private)),
+            int(bool(is_trusted)),
+            source,
+            owner_id,
+        ],
+    )
+
+
+async def update_query(
+    datasette,
+    database,
+    name,
+    *,
+    sql=UNCHANGED,
+    title=UNCHANGED,
+    description=UNCHANGED,
+    description_html=UNCHANGED,
+    hide_sql=UNCHANGED,
+    fragment=UNCHANGED,
+    parameters=UNCHANGED,
+    is_write=UNCHANGED,
+    is_private=UNCHANGED,
+    is_trusted=UNCHANGED,
+    source=UNCHANGED,
+    owner_id=UNCHANGED,
+    on_success_message=UNCHANGED,
+    on_success_message_sql=UNCHANGED,
+    on_success_redirect=UNCHANGED,
+    on_error_message=UNCHANGED,
+    on_error_redirect=UNCHANGED,
+):
+    fields = {
+        "sql": sql,
+        "title": title,
+        "description": description,
+        "description_html": description_html,
+        "parameters": parameters,
+        "is_write": is_write,
+        "is_private": is_private,
+        "is_trusted": is_trusted,
+        "source": source,
+        "owner_id": owner_id,
+    }
+    option_fields = {
+        "hide_sql": hide_sql,
+        "fragment": fragment,
+        "on_success_message": on_success_message,
+        "on_success_message_sql": on_success_message_sql,
+        "on_success_redirect": on_success_redirect,
+        "on_error_message": on_error_message,
+        "on_error_redirect": on_error_redirect,
+    }
+    updates = []
+    params = []
+    for field, value in fields.items():
+        if value is UNCHANGED:
+            continue
+        if field in {"is_write", "is_private", "is_trusted"}:
+            value = int(bool(value))
+        elif field == "parameters":
+            value = json.dumps(list(value or []))
+        updates.append(f"{field} = ?")
+        params.append(value)
+    changed_options = {
+        field: value for field, value in option_fields.items() if value is not UNCHANGED
+    }
+    if changed_options:
+        rows = await datasette.get_internal_database().execute(
+            """
+            SELECT options FROM queries
+            WHERE database_name = ? AND name = ?
+            """,
+            [database, name],
+        )
+        row = rows.first()
+        options = json.loads(row["options"] or "{}") if row is not None else {}
+        for field, value in changed_options.items():
+            if field == "hide_sql":
+                if value:
+                    options[field] = True
+                else:
+                    options.pop(field, None)
+            elif value is None:
+                options.pop(field, None)
+            else:
+                options[field] = value
+        updates.append("options = ?")
+        params.append(json.dumps(options, sort_keys=True))
+    if not updates:
+        return
+    updates.append("updated_at = CURRENT_TIMESTAMP")
+    params.extend([database, name])
+    await datasette.get_internal_database().execute_write(
+        """
+        UPDATE queries
+        SET {}
+        WHERE database_name = ? AND name = ?
+        """.format(", ".join(updates)),
+        params,
+    )
+
+
+async def remove_query(datasette, database, name, source=None):
+    sql = "DELETE FROM queries WHERE database_name = ? AND name = ?"
+    params = [database, name]
+    if source is not None:
+        sql += " AND source = ?"
+        params.append(source)
+    await datasette.get_internal_database().execute_write(sql, params)
+
+
+async def get_query(datasette, database, name):
+    rows = await datasette.get_internal_database().execute(
+        """
+        SELECT * FROM queries
+        WHERE database_name = ? AND name = ?
+        """,
+        [database, name],
+    )
+    return query_row_to_dict(rows.first())
+
+
+async def count_queries(
+    datasette,
+    database=None,
+    *,
+    actor=None,
+    q=None,
+    is_write=None,
+    is_private=None,
+    is_trusted=None,
+    source=None,
+    owner_id=None,
+):
+    allowed_sql, allowed_params = await datasette.allowed_resources_sql(
+        action="view-query",
+        actor=actor,
+        parent=database,
+    )
+    params = dict(allowed_params)
+    where_clauses = []
+    if database is not None:
+        params["query_database"] = database
+        where_clauses.append("q.database_name = :query_database")
+
+    if q:
+        where_clauses.append("""
+            (
+                q.name LIKE :query_search
+                OR q.title LIKE :query_search
+                OR q.description LIKE :query_search
+                OR q.sql LIKE :query_search
+            )
+            """)
+        params["query_search"] = "%{}%".format(q)
+    if is_write is not None:
+        where_clauses.append("q.is_write = :query_is_write")
+        params["query_is_write"] = int(bool(is_write))
+    if is_private is not None:
+        where_clauses.append("q.is_private = :query_is_private")
+        params["query_is_private"] = int(bool(is_private))
+    if is_trusted is not None:
+        where_clauses.append("q.is_trusted = :query_is_trusted")
+        params["query_is_trusted"] = int(bool(is_trusted))
+    if source is not None:
+        where_clauses.append("q.source = :query_source")
+        params["query_source"] = source
+    if owner_id is not None:
+        where_clauses.append("q.owner_id = :query_owner_id")
+        params["query_owner_id"] = owner_id
+
+    row = (
+        await datasette.get_internal_database().execute(
+            """
+            SELECT count(*) AS count
+            FROM queries q
+            JOIN (
+                {allowed_sql}
+            ) allowed
+              ON allowed.parent = q.database_name
+             AND allowed.child = q.name
+            WHERE {where}
+            """.format(
+                allowed_sql=allowed_sql,
+                where=" AND ".join(where_clauses) or "1 = 1",
+            ),
+            params,
+        )
+    ).first()
+    return row["count"]
+
+
+async def list_queries(
+    datasette,
+    database=None,
+    *,
+    actor=None,
+    limit=50,
+    cursor=None,
+    q=None,
+    is_write=None,
+    is_private=None,
+    is_trusted=None,
+    source=None,
+    owner_id=None,
+    include_private=False,
+):
+    limit = min(max(1, int(limit)), 1000)
+    allowed_sql, allowed_params = await datasette.allowed_resources_sql(
+        action="view-query",
+        actor=actor,
+        parent=database,
+        include_is_private=include_private,
+    )
+    params = dict(allowed_params)
+    params.update({"limit": limit + 1})
+    sort_key_sql = "lower(coalesce(nullif(q.title, ''), q.name))"
+    where_clauses = []
+    order_by = "q.database_name, sort_key, q.name"
+    if database is not None:
+        params["query_database"] = database
+        where_clauses.append("q.database_name = :query_database")
+        order_by = "sort_key, q.name"
+
+    if cursor:
+        try:
+            components = urlsafe_components(cursor)
+        except ValueError:
+            components = []
+        if database is None and len(components) == 3:
+            where_clauses.append("""
+                (
+                    q.database_name > :cursor_database
+                    OR (
+                        q.database_name = :cursor_database
+                        AND (
+                            {sort_key_sql} > :cursor_sort_key
+                            OR (
+                                {sort_key_sql} = :cursor_sort_key
+                                AND q.name > :cursor_name
+                            )
+                        )
+                    )
+                )
+                """.format(sort_key_sql=sort_key_sql))
+            params["cursor_database"] = components[0]
+            params["cursor_sort_key"] = components[1]
+            params["cursor_name"] = components[2]
+        elif database is not None and len(components) == 2:
+            where_clauses.append("""
+                (
+                    {sort_key_sql} > :cursor_sort_key
+                    OR (
+                        {sort_key_sql} = :cursor_sort_key
+                        AND q.name > :cursor_name
+                    )
+                )
+                """.format(sort_key_sql=sort_key_sql))
+            params["cursor_sort_key"] = components[0]
+            params["cursor_name"] = components[1]
+
+    if q:
+        where_clauses.append("""
+            (
+                q.name LIKE :query_search
+                OR q.title LIKE :query_search
+                OR q.description LIKE :query_search
+                OR q.sql LIKE :query_search
+            )
+            """)
+        params["query_search"] = "%{}%".format(q)
+    if is_write is not None:
+        where_clauses.append("q.is_write = :query_is_write")
+        params["query_is_write"] = int(bool(is_write))
+    if is_private is not None:
+        where_clauses.append("q.is_private = :query_is_private")
+        params["query_is_private"] = int(bool(is_private))
+    if is_trusted is not None:
+        where_clauses.append("q.is_trusted = :query_is_trusted")
+        params["query_is_trusted"] = int(bool(is_trusted))
+    if source is not None:
+        where_clauses.append("q.source = :query_source")
+        params["query_source"] = source
+    if owner_id is not None:
+        where_clauses.append("q.owner_id = :query_owner_id")
+        params["query_owner_id"] = owner_id
+
+    private_select = ", allowed.is_private AS private" if include_private else ""
+    rows = list(
+        (
+            await datasette.get_internal_database().execute(
+                """
+                SELECT q.*, {sort_key_sql} AS sort_key{private_select}
+                FROM queries q
+                JOIN (
+                    {allowed_sql}
+                ) allowed
+                  ON allowed.parent = q.database_name
+                 AND allowed.child = q.name
+                WHERE {where}
+                ORDER BY {order_by}
+                LIMIT :limit
+                """.format(
+                    allowed_sql=allowed_sql,
+                    private_select=private_select,
+                    sort_key_sql=sort_key_sql,
+                    where=" AND ".join(where_clauses) or "1 = 1",
+                    order_by=order_by,
+                ),
+                params,
+            )
+        ).rows
+    )
+    has_more = len(rows) > limit
+    if has_more:
+        rows = rows[:limit]
+
+    queries = []
+    for row in rows:
+        query = query_row_to_dict(row)
+        if include_private:
+            query["private"] = bool(row["private"])
+        queries.append(query)
+
+    next_token = None
+    if has_more and rows:
+        last_row = rows[-1]
+        if database is None:
+            next_token = "{},{},{}".format(
+                tilde_encode(last_row["database_name"]),
+                tilde_encode(last_row["sort_key"]),
+                tilde_encode(last_row["name"]),
+            )
+        else:
+            next_token = "{},{}".format(
+                tilde_encode(last_row["sort_key"]),
+                tilde_encode(last_row["name"]),
+            )
+    return {
+        "queries": queries,
+        "next": next_token,
+        "has_more": has_more,
+        "limit": limit,
+    }
+
+
+async def ensure_query_write_permissions(
+    datasette, database, sql, *, actor=None, params=None, analysis=None
+):
+    write_actions = {
+        "insert": "insert-row",
+        "update": "update-row",
+        "delete": "delete-row",
+    }
+    db = datasette.get_database(database)
+    if analysis is None:
+        if params is None:
+            params = {name: "" for name in named_parameters(sql)}
+        try:
+            analysis = await db.analyze_sql(sql, params)
+        except sqlite3.DatabaseError as ex:
+            raise Forbidden(f"Could not analyze query: {ex}") from ex
+
+    for access in analysis.table_accesses:
+        action = write_actions.get(access.operation)
+        if action is None:
+            continue
+        if access.database != database:
+            raise Forbidden("Writable queries may not write to attached databases")
+        if not await datasette.allowed(
+            action=action,
+            resource=TableResource(database=access.database, table=access.table),
+            actor=actor,
+        ):
+            raise Forbidden(
+                f"Permission denied: need {action} on {access.database}/{access.table}"
+            )
+    return analysis

From 58e2e3a8ab9adfeda2686be5213eaf3f4118da33 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:43:34 -0700
Subject: [PATCH 098/386] Ran cog

---
 docs/authentication.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/authentication.rst b/docs/authentication.rst
index cec47f97..f8b1dc49 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -496,7 +496,7 @@ Here's how to restrict access to your entire Datasette instance to just the ``"i
             title: My private Datasette instance
             allow:
               id: root
-
+  
 
 .. tab:: datasette.json
 

From c3ceabae03c2c9cf78f63f7c12c8d90301097cb4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:51:40 -0700
Subject: [PATCH 099/386] Ran Black

---
 datasette/stored_queries.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index e88902e7..5b005c07 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -6,7 +6,6 @@ from .resources import TableResource
 from .utils import named_parameters, sqlite3, tilde_encode, urlsafe_components
 from .utils.asgi import Forbidden
 
-
 UNCHANGED = object()
 
 QUERY_OPTION_FIELDS = (

From d6de8e752083a014bdd7ffb701dc08519da82554 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:52:16 -0700
Subject: [PATCH 100/386] Link to save query from /-/execute-write

---
 datasette/templates/execute_write.html | 29 +++++++++++++++++++++++++-
 datasette/views/database.py            | 22 +++++++++++++++++++
 tests/test_queries.py                  | 17 +++++++++++++++
 3 files changed, 67 insertions(+), 1 deletion(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 7a627a7a..6b626f8d 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -119,7 +119,10 @@
         {% endif %}
     </div>
 
-    <p><input type="submit" value="Execute" data-execute-write-submit{% if execute_disabled %} disabled{% endif %}></p>
+    <p>
+        <input type="submit" value="Execute" data-execute-write-submit{% if execute_disabled %} disabled{% endif %}>
+        {% if save_query_base_url %}<a href="{{ save_query_url or save_query_base_url }}" class="save-query" data-save-query-link data-save-query-base-url="{{ save_query_base_url }}"{% if not save_query_url %} hidden{% endif %}>Save this query</a>{% endif %}
+    </p>
 </form>
 
 <script>
@@ -140,6 +143,26 @@ window.addEventListener("DOMContentLoaded", () => {
   const submitButton = form
     ? form.querySelector("[data-execute-write-submit]")
     : null;
+  const saveQueryLink = form
+    ? form.querySelector("[data-save-query-link]")
+    : null;
+
+  function updateSaveQueryLink(data) {
+    if (!saveQueryLink) {
+      return;
+    }
+    const sql = window.editor
+      ? window.editor.state.doc.toString()
+      : executeWriteSqlInput.value;
+    if (!sql.trim() || !data.ok || data.execute_disabled) {
+      saveQueryLink.hidden = true;
+      return;
+    }
+    const url = new URL(saveQueryLink.dataset.saveQueryBaseUrl, window.location.href);
+    url.searchParams.set("sql", sql);
+    saveQueryLink.href = url.pathname + url.search + url.hash;
+    saveQueryLink.hidden = false;
+  }
 
   window.datasetteSqlParameters.setupSqlParameterRefresh({
     form,
@@ -150,6 +173,7 @@ window.addEventListener("DOMContentLoaded", () => {
       if (submitButton) {
         submitButton.disabled = data.execute_disabled;
       }
+      updateSaveQueryLink(data);
     },
     onError(error) {
       window.datasetteSqlAnalysis.renderAnalysis(analysisSection, {
@@ -159,6 +183,9 @@ window.addEventListener("DOMContentLoaded", () => {
       if (submitButton) {
         submitButton.disabled = true;
       }
+      if (saveQueryLink) {
+        saveQueryLink.hidden = true;
+      }
     },
   });
 });
diff --git a/datasette/views/database.py b/datasette/views/database.py
index c36476f6..28a3b579 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -1002,6 +1002,26 @@ class ExecuteWriteView(BaseView):
             except (QueryValidationError, sqlite3.DatabaseError) as ex:
                 analysis_error = getattr(ex, "message", str(ex))
 
+        allow_save_query = await self.ds.allowed(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ) and await self.ds.allowed(
+            action="store-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        )
+        save_query_base_url = None
+        save_query_url = None
+        if allow_save_query:
+            save_query_base_url = self.ds.urls.database(db.name) + "/-/queries/store"
+            if (
+                sql
+                and analysis_error is None
+                and not any(row["allowed"] is False for row in analysis_rows)
+            ):
+                save_query_url = save_query_base_url + "?" + urlencode({"sql": sql})
+
         response = await self.render(
             ["execute_write.html"],
             request,
@@ -1025,6 +1045,8 @@ class ExecuteWriteView(BaseView):
                 ),
                 "table_columns": table_columns,
                 "write_template_tables": write_template_tables,
+                "save_query_url": save_query_url,
+                "save_query_base_url": save_query_base_url,
             },
         )
         response.status = status
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 5d4da9bb..4f2fd1ff 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1233,6 +1233,12 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'data-sql-template="update"' in response.text
     assert 'data-sql-template="delete"' in response.text
     assert 'data-analyze-url="/data/-/execute-write/analyze"' in response.text
+    assert 'data-save-query-base-url="/data/-/queries/store"' in response.text
+    assert "Save this query" in response.text
+    assert (
+        "/data/-/queries/store?sql=insert+into+dogs+%28name%29+values+%28%27Cleo%27%29"
+        in response.text
+    )
     assert 'addEventListener("paste"' in response.text
     assert "setupSqlParameterRefresh" in response.text
     assert "datasetteSqlAnalysis.renderAnalysis" in response.text
@@ -1251,6 +1257,17 @@ async def test_execute_write_get_prepopulates_without_executing():
     )
     assert '<textarea id="sql-editor" name="sql"></textarea>' in empty_response.text
     assert 'executeWriteSqlInput.value = "\\n\\n\\n";' in empty_response.text
+    assert "hidden>Save this query</a>" in empty_response.text
+
+    read_only_response = await ds.client.get(
+        "/data/-/execute-write?sql=select+*+from+dogs",
+        actor={"id": "root"},
+    )
+    assert (
+        "Use /-/query for read-only SQL; this endpoint only executes writes"
+        in read_only_response.text
+    )
+    assert "hidden>Save this query</a>" in read_only_response.text
 
 
 @pytest.mark.asyncio

From 7214cc37618cbce8a85bf4142cebca0c0dcf3c00 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 15:52:44 -0700
Subject: [PATCH 101/386] Remove obsolete label

---
 docs/authentication.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/docs/authentication.rst b/docs/authentication.rst
index f8b1dc49..96224ef9 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -496,7 +496,7 @@ Here's how to restrict access to your entire Datasette instance to just the ``"i
             title: My private Datasette instance
             allow:
               id: root
-  
+
 
 .. tab:: datasette.json
 
@@ -1292,7 +1292,6 @@ Actor is allowed to view a stored query page, e.g. https://latest.datasette.io/f
 
     ``query`` is the name of the query (string)
 
-.. _actions_insert_query:
 .. _actions_store_query:
 
 store-query

From cef52b1ffc545cd20897d97fe83e7bd4b54f5334 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 16:06:14 -0700
Subject: [PATCH 102/386] Break up giant views/database.py into smaller modules

---
 datasette/app.py                  |    5 +-
 datasette/views/database.py       | 1235 +----------------------------
 datasette/views/execute_write.py  |  257 ++++++
 datasette/views/query_helpers.py  |  558 +++++++++++++
 datasette/views/stored_queries.py |  470 +++++++++++
 docs/authentication.rst           |    2 +-
 6 files changed, 1291 insertions(+), 1236 deletions(-)
 create mode 100644 datasette/views/execute_write.py
 create mode 100644 datasette/views/query_helpers.py
 create mode 100644 datasette/views/stored_queries.py

diff --git a/datasette/app.py b/datasette/app.py
index dd54446a..96683895 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -47,10 +47,11 @@ from .views import Context
 from .views.database import (
     database_download,
     DatabaseView,
-    ExecuteWriteAnalyzeView,
-    ExecuteWriteView,
     TableCreateView,
     QueryView,
+)
+from .views.execute_write import ExecuteWriteAnalyzeView, ExecuteWriteView
+from .views.stored_queries import (
     QueryCreateAnalyzeView,
     QueryDeleteView,
     QueryDefinitionView,
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 28a3b579..f11a7d16 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -12,16 +12,14 @@ import textwrap
 
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.database import QueryInterrupted
-from datasette.resources import DatabaseResource, QueryResource, TableResource
+from datasette.resources import DatabaseResource, QueryResource
 from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
     call_with_supported_arguments,
     named_parameters as derive_named_parameters,
-    escape_sqlite,
     format_bytes,
     make_slot_function,
-    path_from_row_pks,
     tilde_decode,
     to_css_class,
     validate_sql_select,
@@ -37,6 +35,7 @@ from datasette.utils.asgi import AsgiFileDownload, NotFound, Response, Forbidden
 from datasette.plugins import pm
 
 from .base import BaseView, DatasetteError, View, _error, stream_csv
+from .query_helpers import _ensure_stored_query_execution_permissions, _table_columns
 from . import Context
 
 
@@ -425,1220 +424,6 @@ async def database_download(request, datasette):
     )
 
 
-_query_name_re = re.compile(r"^[^/\.\n]+$")
-
-_query_fields = {
-    "sql",
-    "title",
-    "description",
-    "description_html",
-    "hide_sql",
-    "fragment",
-    "parameters",
-    "params",
-    "is_private",
-    "on_success_message",
-    "on_success_message_sql",
-    "on_success_redirect",
-    "on_error_message",
-    "on_error_redirect",
-}
-
-_query_create_fields = _query_fields | {"name", "mode", "csrftoken"}
-_query_update_fields = _query_fields
-_query_write_fields = {
-    "on_success_message",
-    "on_success_message_sql",
-    "on_success_redirect",
-    "on_error_message",
-    "on_error_redirect",
-}
-
-
-class QueryValidationError(Exception):
-    def __init__(self, message, status=400):
-        self.message = message
-        self.status = status
-
-
-def _actor_id(actor):
-    if isinstance(actor, dict):
-        return actor.get("id")
-    return None
-
-
-def _as_bool(value):
-    if isinstance(value, bool):
-        return value
-    if value is None:
-        return False
-    if isinstance(value, int):
-        return bool(value)
-    if isinstance(value, str):
-        return value.lower() in {"1", "true", "t", "yes", "on"}
-    return bool(value)
-
-
-def _as_optional_bool(value, name):
-    if value is None or value == "":
-        return None
-    if isinstance(value, bool):
-        return value
-    if isinstance(value, int):
-        return bool(value)
-    if isinstance(value, str):
-        lowered = value.lower()
-        if lowered in {"1", "true", "t", "yes", "on"}:
-            return True
-        if lowered in {"0", "false", "f", "no", "off"}:
-            return False
-    raise QueryValidationError("{} must be 0 or 1".format(name))
-
-
-def _query_list_limit(value, default=50):
-    if value in (None, ""):
-        return default
-    try:
-        return min(max(1, int(value)), 1000)
-    except ValueError as ex:
-        raise QueryValidationError("_size must be an integer") from ex
-
-
-def _derived_query_parameters(sql):
-    parameters = []
-    seen = set()
-    for parameter in derive_named_parameters(sql):
-        if parameter.startswith("_"):
-            raise QueryValidationError("Magic parameters are not allowed")
-        if parameter not in seen:
-            parameters.append(parameter)
-            seen.add(parameter)
-    return parameters
-
-
-def _coerce_query_parameters(value, derived):
-    if value is None:
-        return derived
-    if isinstance(value, str):
-        parameters = [
-            parameter.strip()
-            for parameter in re.split(r"[\s,]+", value)
-            if parameter.strip()
-        ]
-    elif isinstance(value, list):
-        parameters = value
-    else:
-        raise QueryValidationError("parameters must be a list of strings")
-    if not all(isinstance(parameter, str) for parameter in parameters):
-        raise QueryValidationError("parameters must be a list of strings")
-    if any(parameter.startswith("_") for parameter in parameters):
-        raise QueryValidationError("Magic parameters are not allowed")
-    if set(parameters) != set(derived):
-        raise QueryValidationError("parameters must match SQL named parameters")
-    return parameters
-
-
-def _analysis_is_write(analysis):
-    return any(
-        access.operation in {"insert", "update", "delete"}
-        for access in analysis.table_accesses
-    )
-
-
-def _block_framing(response):
-    response.headers["Content-Security-Policy"] = "frame-ancestors 'none'"
-    response.headers["X-Frame-Options"] = "DENY"
-    return response
-
-
-def _wants_json(request, is_json, data):
-    return (
-        is_json
-        or request.headers.get("accept") == "application/json"
-        or (isinstance(data, dict) and data.get("_json"))
-    )
-
-
-def _query_create_form_error_message(message):
-    return {
-        "Query name is required": "URL is required",
-        "Invalid query name": "Invalid URL",
-        "Query name conflicts with a table or view": (
-            "URL conflicts with an existing table or view"
-        ),
-        "Query already exists": "A query already exists at that URL",
-    }.get(message, message)
-
-
-async def _json_or_form_payload(request):
-    content_type = request.headers.get("content-type", "")
-    if content_type.startswith("application/json"):
-        body = await request.post_body()
-        try:
-            return json.loads(body or b"{}"), True
-        except json.JSONDecodeError as e:
-            raise QueryValidationError("Invalid JSON: {}".format(e))
-    return await request.post_vars(), False
-
-
-async def _check_query_name(db, name, *, existing=False):
-    if not name or not isinstance(name, str):
-        raise QueryValidationError("Query name is required")
-    if not _query_name_re.match(name):
-        raise QueryValidationError("Invalid query name")
-    if not existing and (await db.table_exists(name) or await db.view_exists(name)):
-        raise QueryValidationError("Query name conflicts with a table or view")
-
-
-async def _analyze_user_query(datasette, db, sql, *, actor):
-    if not sql or not isinstance(sql, str):
-        raise QueryValidationError("SQL is required")
-    derived = _derived_query_parameters(sql)
-    params = {parameter: "" for parameter in derived}
-    try:
-        analysis = await db.analyze_sql(sql, params)
-    except sqlite3.DatabaseError as ex:
-        raise QueryValidationError("Could not analyze query: {}".format(ex)) from ex
-
-    is_write = _analysis_is_write(analysis)
-    if is_write:
-        try:
-            await datasette.ensure_query_write_permissions(
-                db.name, sql, actor=actor, analysis=analysis
-            )
-        except Forbidden as ex:
-            raise QueryValidationError(str(ex), status=403) from ex
-    else:
-        try:
-            validate_sql_select(sql)
-        except InvalidSql as ex:
-            raise QueryValidationError(str(ex)) from ex
-    return is_write, derived, analysis
-
-
-def _analysis_rows(analysis):
-    write_actions = {
-        "insert": "insert-row",
-        "update": "update-row",
-        "delete": "delete-row",
-    }
-    return [
-        {
-            "operation": access.operation,
-            "database": access.database,
-            "table": access.table,
-            "required_permission": write_actions.get(access.operation, ""),
-            "source": access.source,
-        }
-        for access in analysis.table_accesses
-    ]
-
-
-async def _analysis_rows_with_permissions(datasette, analysis, actor):
-    rows = _analysis_rows(analysis)
-    for row in rows:
-        permission = row["required_permission"]
-        if permission:
-            row["allowed"] = await datasette.allowed(
-                action=permission,
-                resource=TableResource(row["database"], row["table"]),
-                actor=actor,
-            )
-        else:
-            row["allowed"] = None
-    return rows
-
-
-def _coerce_execute_write_payload(data, is_json):
-    if not isinstance(data, dict):
-        raise QueryValidationError("JSON must be a dictionary")
-    if is_json:
-        invalid_keys = set(data) - {"sql", "params"}
-        if invalid_keys:
-            raise QueryValidationError(
-                "Invalid keys: {}".format(", ".join(sorted(invalid_keys)))
-            )
-        params = data.get("params") or {}
-    else:
-        params = {
-            key: value
-            for key, value in data.items()
-            if key not in {"sql", "csrftoken", "_json"}
-        }
-    if not isinstance(params, dict):
-        raise QueryValidationError("params must be a dictionary")
-    return data.get("sql"), params
-
-
-async def _prepare_execute_write(datasette, db, sql, params, actor):
-    if not sql or not isinstance(sql, str):
-        raise QueryValidationError("SQL is required")
-    parameter_names = _derived_query_parameters(sql)
-    extra_params = set(params) - set(parameter_names)
-    if extra_params:
-        raise QueryValidationError(
-            "Unknown parameters: {}".format(", ".join(sorted(extra_params)))
-        )
-    params = {name: params.get(name, "") for name in parameter_names}
-    try:
-        analysis = await db.analyze_sql(sql, params)
-    except sqlite3.DatabaseError as ex:
-        raise QueryValidationError("Could not analyze query: {}".format(ex)) from ex
-    if not _analysis_is_write(analysis):
-        raise QueryValidationError(
-            "Use /-/query for read-only SQL; this endpoint only executes writes"
-        )
-    try:
-        await datasette.ensure_query_write_permissions(
-            db.name, sql, actor=actor, analysis=analysis
-        )
-    except Forbidden as ex:
-        raise QueryValidationError(str(ex), status=403) from ex
-    return parameter_names, params, analysis
-
-
-async def _ensure_stored_query_execution_permissions(datasette, db, query, actor):
-    if query.get("is_trusted"):
-        return
-    if query.get("write"):
-        await datasette.ensure_permission(
-            action="execute-write-sql",
-            resource=DatabaseResource(db.name),
-            actor=actor,
-        )
-        await datasette.ensure_query_write_permissions(
-            db.name, query["sql"], actor=actor
-        )
-    else:
-        await datasette.ensure_permission(
-            action="execute-sql",
-            resource=DatabaseResource(db.name),
-            actor=actor,
-        )
-
-
-async def _execute_write_analysis_data(datasette, db, sql, actor):
-    parameter_names = []
-    analysis_rows = []
-    analysis_error = None
-    if sql:
-        try:
-            parameter_names = _derived_query_parameters(sql)
-            params = {parameter: "" for parameter in parameter_names}
-            analysis = await db.analyze_sql(sql, params)
-            if _analysis_is_write(analysis):
-                analysis_rows = await _analysis_rows_with_permissions(
-                    datasette, analysis, actor
-                )
-            else:
-                analysis_error = (
-                    "Use /-/query for read-only SQL; "
-                    "this endpoint only executes writes"
-                )
-        except (QueryValidationError, sqlite3.DatabaseError) as ex:
-            analysis_error = getattr(ex, "message", str(ex))
-    return {
-        "ok": analysis_error is None,
-        "parameters": parameter_names,
-        "analysis_error": analysis_error,
-        "analysis_rows": [row for row in analysis_rows if row["operation"] != "read"],
-        "execute_disabled": bool(
-            (not sql)
-            or analysis_error
-            or any(row["allowed"] is False for row in analysis_rows)
-        ),
-    }
-
-
-async def _query_create_analysis_data(datasette, db, sql, actor):
-    has_sql = bool(sql and sql.strip())
-    parameter_names = []
-    analysis_rows = []
-    analysis_error = None
-    if has_sql:
-        try:
-            parameter_names = _derived_query_parameters(sql)
-            params = {parameter: "" for parameter in parameter_names}
-            analysis = await db.analyze_sql(sql, params)
-            analysis_rows = await _analysis_rows_with_permissions(
-                datasette, analysis, actor
-            )
-        except (QueryValidationError, sqlite3.DatabaseError) as ex:
-            analysis_error = getattr(ex, "message", str(ex))
-    return {
-        "ok": analysis_error is None,
-        "parameters": parameter_names,
-        "analysis_error": analysis_error,
-        "analysis_rows": analysis_rows,
-        "has_sql": has_sql,
-        "analysis_is_write": bool(
-            analysis_rows and any(row["required_permission"] for row in analysis_rows)
-        ),
-        "save_disabled": bool(
-            (not has_sql)
-            or analysis_error
-            or any(row["allowed"] is False for row in analysis_rows)
-        ),
-    }
-
-
-async def _query_create_form_context(
-    datasette,
-    request,
-    db,
-    *,
-    sql="",
-    name="",
-    title="",
-    description="",
-    is_private=True,
-):
-    analysis_data = await _query_create_analysis_data(datasette, db, sql, request.actor)
-    return {
-        "database": db.name,
-        "database_color": db.color,
-        "sql": sql,
-        "name": name,
-        "title": title,
-        "description": description,
-        "is_private": is_private,
-        **analysis_data,
-    }
-
-
-async def _inserted_row_url(datasette, db, analysis, cursor):
-    if cursor.rowcount != 1:
-        return None
-    lastrowid = getattr(cursor, "lastrowid", None)
-    if lastrowid is None:
-        return None
-    direct_inserts = [
-        access
-        for access in analysis.table_accesses
-        if access.operation == "insert"
-        and access.source is None
-        and access.database == db.name
-    ]
-    if len(direct_inserts) != 1:
-        return None
-    table = direct_inserts[0].table
-    pks = await db.primary_keys(table)
-    use_rowid = not pks
-    select = (
-        "rowid"
-        if use_rowid
-        else ", ".join(escape_sqlite(primary_key) for primary_key in pks)
-    )
-    try:
-        result = await db.execute(
-            "select {} from {} where rowid = ?".format(select, escape_sqlite(table)),
-            [lastrowid],
-        )
-    except sqlite3.DatabaseError:
-        return None
-    row = result.first()
-    if row is None:
-        return None
-    row_path = path_from_row_pks(row, pks, use_rowid)
-    return datasette.urls.row(db.name, table, row_path)
-
-
-def _apply_query_data_types(data):
-    typed = dict(data)
-    for key in ("hide_sql", "is_private"):
-        if key in typed:
-            typed[key] = _as_bool(typed[key])
-    return typed
-
-
-async def _prepare_query_create(datasette, request, db, data):
-    invalid_keys = set(data) - _query_create_fields
-    if invalid_keys:
-        raise QueryValidationError("Invalid keys: {}".format(", ".join(invalid_keys)))
-
-    data = _apply_query_data_types(data)
-    name = data.get("name")
-    await _check_query_name(db, name)
-    if await datasette.get_query(db.name, name) is not None:
-        raise QueryValidationError("Query already exists")
-
-    is_write, derived, analysis = await _analyze_user_query(
-        datasette,
-        db,
-        data.get("sql"),
-        actor=request.actor,
-    )
-    if not is_write and any(data.get(field) for field in _query_write_fields):
-        raise QueryValidationError("Writable query fields require writable SQL")
-
-    parameters = _coerce_query_parameters(
-        data.get("parameters", data.get("params")),
-        derived,
-    )
-    return {
-        "name": name,
-        "sql": data["sql"],
-        "title": data.get("title"),
-        "description": data.get("description"),
-        "description_html": data.get("description_html"),
-        "hide_sql": _as_bool(data.get("hide_sql")),
-        "fragment": data.get("fragment"),
-        "parameters": parameters,
-        "is_write": is_write,
-        "is_private": _as_bool(data.get("is_private", True)),
-        "is_trusted": False,
-        "source": "user",
-        "owner_id": _actor_id(request.actor),
-        "on_success_message": data.get("on_success_message"),
-        "on_success_message_sql": data.get("on_success_message_sql"),
-        "on_success_redirect": data.get("on_success_redirect"),
-        "on_error_message": data.get("on_error_message"),
-        "on_error_redirect": data.get("on_error_redirect"),
-        "analysis": analysis,
-    }
-
-
-async def _prepare_query_update(datasette, request, db, existing, update):
-    invalid_keys = set(update) - _query_update_fields
-    if invalid_keys:
-        raise QueryValidationError("Invalid keys: {}".format(", ".join(invalid_keys)))
-
-    update = _apply_query_data_types(update)
-    sql = update.get("sql", existing["sql"])
-    query_is_write = existing["is_write"]
-    derived = _derived_query_parameters(sql)
-    parameters = None
-
-    if "sql" in update:
-        query_is_write, derived, _ = await _analyze_user_query(
-            datasette,
-            db,
-            sql,
-            actor=request.actor,
-        )
-
-    if "parameters" in update or "params" in update:
-        parameters = _coerce_query_parameters(
-            update.get("parameters", update.get("params")),
-            derived,
-        )
-    elif "sql" in update:
-        parameters = derived
-
-    if not query_is_write and any(update.get(field) for field in _query_write_fields):
-        raise QueryValidationError("Writable query fields require writable SQL")
-
-    field_values = {
-        "sql": sql,
-        "title": update.get("title"),
-        "description": update.get("description"),
-        "description_html": update.get("description_html"),
-        "hide_sql": update.get("hide_sql"),
-        "fragment": update.get("fragment"),
-        "parameters": parameters,
-        "is_write": query_is_write,
-        "is_private": update.get("is_private"),
-        "on_success_message": update.get("on_success_message"),
-        "on_success_message_sql": update.get("on_success_message_sql"),
-        "on_success_redirect": update.get("on_success_redirect"),
-        "on_error_message": update.get("on_error_message"),
-        "on_error_redirect": update.get("on_error_redirect"),
-    }
-    update_kwargs = {}
-    for field_name, value in field_values.items():
-        if field_name in update:
-            update_kwargs[field_name] = value
-    if parameters is not None:
-        update_kwargs["parameters"] = parameters
-    if "sql" in update:
-        update_kwargs["is_write"] = query_is_write
-    return update_kwargs
-
-
-class ExecuteWriteView(BaseView):
-    name = "execute-write"
-    has_json_alternate = False
-
-    async def _render_form(
-        self,
-        request,
-        db,
-        *,
-        sql="",
-        parameter_values=None,
-        analysis=None,
-        analysis_error=None,
-        execution_message=None,
-        execution_links=None,
-        execution_ok=None,
-        status=200,
-    ):
-        parameter_values = parameter_values or {}
-        execution_links = execution_links or []
-        parameter_names = []
-        analysis_rows = []
-        table_columns = await _table_columns(self.ds, db.name)
-        hidden_table_names = set(await db.hidden_table_names())
-        write_template_tables = {
-            table: columns
-            for table, columns in table_columns.items()
-            if columns and table not in hidden_table_names
-        }
-        if sql and analysis_error is None:
-            try:
-                parameter_names = _derived_query_parameters(sql)
-                if analysis is None:
-                    params = {parameter: "" for parameter in parameter_names}
-                    analysis = await db.analyze_sql(sql, params)
-                if _analysis_is_write(analysis):
-                    analysis_rows = await _analysis_rows_with_permissions(
-                        self.ds, analysis, request.actor
-                    )
-                else:
-                    analysis_error = (
-                        "Use /-/query for read-only SQL; "
-                        "this endpoint only executes writes"
-                    )
-            except (QueryValidationError, sqlite3.DatabaseError) as ex:
-                analysis_error = getattr(ex, "message", str(ex))
-
-        allow_save_query = await self.ds.allowed(
-            action="execute-sql",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ) and await self.ds.allowed(
-            action="store-query",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        )
-        save_query_base_url = None
-        save_query_url = None
-        if allow_save_query:
-            save_query_base_url = self.ds.urls.database(db.name) + "/-/queries/store"
-            if (
-                sql
-                and analysis_error is None
-                and not any(row["allowed"] is False for row in analysis_rows)
-            ):
-                save_query_url = save_query_base_url + "?" + urlencode({"sql": sql})
-
-        response = await self.render(
-            ["execute_write.html"],
-            request,
-            {
-                "database": db.name,
-                "database_color": db.color,
-                "sql": sql,
-                "parameter_names": parameter_names,
-                "parameter_values": parameter_values,
-                "analysis_error": analysis_error,
-                "analysis_rows": [
-                    row for row in analysis_rows if row["operation"] != "read"
-                ],
-                "execution_message": execution_message,
-                "execution_links": execution_links,
-                "execution_ok": execution_ok,
-                "execute_disabled": bool(
-                    (not sql)
-                    or analysis_error
-                    or any(row["allowed"] is False for row in analysis_rows)
-                ),
-                "table_columns": table_columns,
-                "write_template_tables": write_template_tables,
-                "save_query_url": save_query_url,
-                "save_query_base_url": save_query_base_url,
-            },
-        )
-        response.status = status
-        return _block_framing(response)
-
-    async def get(self, request):
-        db = await self.ds.resolve_database(request)
-        await self.ds.ensure_permission(
-            action="execute-write-sql",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        )
-        if not db.is_mutable:
-            return _block_framing(
-                _error(
-                    ["Cannot execute write SQL because this database is immutable."],
-                    403,
-                )
-            )
-        return await self._render_form(
-            request,
-            db,
-            sql=request.args.get("sql") or "",
-        )
-
-    async def post(self, request):
-        db = await self.ds.resolve_database(request)
-        if not await self.ds.allowed(
-            action="execute-write-sql",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ):
-            return _block_framing(
-                _error(["Permission denied: need execute-write-sql"], 403)
-            )
-        if not db.is_mutable:
-            return _block_framing(_error(["Database is immutable"], 403))
-
-        data = {}
-        is_json = request.headers.get("content-type", "").startswith("application/json")
-        sql = ""
-        provided_params = {}
-        try:
-            data, is_json = await _json_or_form_payload(request)
-            sql, provided_params = _coerce_execute_write_payload(data, is_json)
-            parameter_names, params, analysis = await _prepare_execute_write(
-                self.ds, db, sql, provided_params, request.actor
-            )
-        except QueryValidationError as ex:
-            if _wants_json(request, is_json, data):
-                return _block_framing(_error([ex.message], ex.status))
-            return await self._render_form(
-                request,
-                db,
-                sql=sql or "",
-                parameter_values=provided_params,
-                analysis_error=ex.message,
-                execution_message=ex.message,
-                execution_ok=False,
-                status=ex.status,
-            )
-
-        try:
-            cursor = await db.execute_write(sql, params, request=request)
-        except sqlite3.DatabaseError as ex:
-            message = str(ex)
-            if _wants_json(request, is_json, data):
-                return _block_framing(_error([message], 400))
-            return await self._render_form(
-                request,
-                db,
-                sql=sql,
-                parameter_values=params,
-                analysis=analysis,
-                execution_message=message,
-                execution_ok=False,
-                status=400,
-            )
-
-        message = "Query executed, {} row{} affected".format(
-            cursor.rowcount, "" if cursor.rowcount == 1 else "s"
-        )
-        if _wants_json(request, is_json, data):
-            return _block_framing(
-                Response.json(
-                    {
-                        "ok": True,
-                        "message": message,
-                        "rowcount": cursor.rowcount,
-                        "analysis": _analysis_rows(analysis),
-                    }
-                )
-            )
-
-        inserted_row_url = await _inserted_row_url(self.ds, db, analysis, cursor)
-        execution_links = (
-            [{"href": inserted_row_url, "label": "View row"}]
-            if inserted_row_url
-            else []
-        )
-        return await self._render_form(
-            request,
-            db,
-            sql=sql,
-            parameter_values={name: params.get(name, "") for name in parameter_names},
-            analysis=analysis,
-            execution_message=message,
-            execution_links=execution_links,
-            execution_ok=True,
-        )
-
-
-class ExecuteWriteAnalyzeView(BaseView):
-    name = "execute-write-analyze"
-    has_json_alternate = False
-
-    async def get(self, request):
-        db = await self.ds.resolve_database(request)
-        if not await self.ds.allowed(
-            action="execute-write-sql",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ):
-            return _block_framing(
-                _error(["Permission denied: need execute-write-sql"], 403)
-            )
-
-        invalid_keys = set(request.args) - {"sql"}
-        if invalid_keys:
-            return _block_framing(
-                _error(
-                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
-                    400,
-                )
-            )
-        sql = request.args.get("sql") or ""
-        return _block_framing(
-            Response.json(
-                await _execute_write_analysis_data(self.ds, db, sql, request.actor)
-            )
-        )
-
-
-class QueryParametersView(BaseView):
-    name = "query-parameters"
-    has_json_alternate = False
-
-    async def get(self, request):
-        db = await self.ds.resolve_database(request)
-        if not await self.ds.allowed(
-            action="execute-sql",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ):
-            return _block_framing(_error(["Permission denied: need execute-sql"], 403))
-
-        invalid_keys = set(request.args) - {"sql"}
-        if invalid_keys:
-            return _block_framing(
-                _error(
-                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
-                    400,
-                )
-            )
-        try:
-            parameters = _derived_query_parameters(request.args.get("sql") or "")
-        except QueryValidationError as ex:
-            return _block_framing(_error([ex.message], ex.status))
-        return _block_framing(Response.json({"ok": True, "parameters": parameters}))
-
-
-def _query_list_url(path, query_string, *, set_args=None, remove_args=None):
-    set_args = set_args or {}
-    remove_args = set(remove_args or ())
-    skip = set(set_args) | remove_args | {"_next"}
-    pairs = [
-        (key, value)
-        for key, value in parse_qsl(query_string, keep_blank_values=True)
-        if key not in skip
-    ]
-    for key, value in set_args.items():
-        if value not in (None, ""):
-            pairs.append((key, value))
-    return path + (("?" + urlencode(pairs)) if pairs else "")
-
-
-class QueryListView(BaseView):
-    name = "query-list"
-
-    async def database_name(self, request):
-        return (await self.ds.resolve_database(request)).name
-
-    def query_list_path(self, database):
-        return self.ds.urls.database(database) + "/-/queries"
-
-    async def get(self, request):
-        database = await self.database_name(request)
-        format_ = request.url_vars.get("format") or "html"
-        try:
-            limit = _query_list_limit(
-                request.args.get("_size"),
-                default=20 if format_ == "html" else 50,
-            )
-            is_write = _as_optional_bool(request.args.get("is_write"), "is_write")
-            is_private = _as_optional_bool(request.args.get("is_private"), "is_private")
-        except QueryValidationError as ex:
-            return _error([ex.message], ex.status)
-
-        page = await self.ds.list_queries(
-            database,
-            actor=request.actor,
-            limit=limit,
-            cursor=request.args.get("_next"),
-            q=request.args.get("q") or None,
-            is_write=is_write,
-            is_private=is_private,
-            source=request.args.get("source") or None,
-            owner_id=request.args.get("owner_id") or None,
-            include_private=True,
-        )
-        query_list_path = self.query_list_path(database)
-        next_url = None
-        if page["next"]:
-            pairs = [
-                (key, value)
-                for key, value in parse_qsl(
-                    request.query_string, keep_blank_values=True
-                )
-                if key != "_next"
-            ]
-            pairs.append(("_next", page["next"]))
-            next_url = "{}?{}".format(
-                query_list_path,
-                urlencode(pairs),
-            )
-
-        current_filters = {
-            "actor": request.actor,
-            "q": request.args.get("q") or None,
-            "is_write": is_write,
-            "is_private": is_private,
-            "source": request.args.get("source") or None,
-            "owner_id": request.args.get("owner_id") or None,
-        }
-
-        async def facet_count(field, value):
-            if current_filters[field] is not None and current_filters[field] != value:
-                return 0
-            filters = dict(current_filters)
-            filters[field] = value
-            return await self.ds.count_queries(database, **filters)
-
-        def facet_href(field, value):
-            if current_filters[field] == value:
-                return _query_list_url(
-                    query_list_path,
-                    request.query_string,
-                    remove_args=[field],
-                )
-            if current_filters[field] is not None:
-                return None
-            return _query_list_url(
-                query_list_path,
-                request.query_string,
-                set_args={field: str(int(value))},
-            )
-
-        async def facet_item(label, field, value):
-            count = await facet_count(field, value)
-            active = current_filters[field] == value
-            if not active and not count:
-                return None
-            return {
-                "label": label,
-                "count": count,
-                "href": facet_href(field, value) if active or count else None,
-                "active": active,
-            }
-
-        async def facet_items(items):
-            return [
-                item
-                for item in [
-                    await facet_item(label, field, value)
-                    for label, field, value in items
-                ]
-                if item is not None
-            ]
-
-        facets = [
-            {
-                "title": "Mode",
-                "items": await facet_items(
-                    [
-                        ("Read-only", "is_write", False),
-                        ("Writable", "is_write", True),
-                    ]
-                ),
-            },
-            {
-                "title": "Visibility",
-                "items": await facet_items(
-                    [
-                        ("Not private", "is_private", False),
-                        ("Private", "is_private", True),
-                    ]
-                ),
-            },
-        ]
-
-        data = {
-            "ok": True,
-            "database": database,
-            "database_color": (
-                self.ds.get_database(database).color if database is not None else None
-            ),
-            "queries": page["queries"],
-            "next": page["next"],
-            "next_url": next_url,
-            "has_more": page["has_more"],
-            "limit": page["limit"],
-            "show_private_note": any(query["is_private"] for query in page["queries"]),
-            "show_trusted_note": any(query["is_trusted"] for query in page["queries"]),
-            "query_list_path": query_list_path,
-            "show_database": database is None,
-            "facets": facets,
-            "filters": {
-                "q": request.args.get("q") or "",
-                "is_write": request.args.get("is_write") or "",
-                "is_private": request.args.get("is_private") or "",
-                "source": request.args.get("source") or "",
-                "owner_id": request.args.get("owner_id") or "",
-            },
-        }
-        if format_ == "json":
-            return Response.json(data)
-        return await self.render(
-            ["query_list.html"],
-            request,
-            data,
-        )
-
-
-class GlobalQueryListView(QueryListView):
-    name = "global-query-list"
-
-    async def database_name(self, request):
-        return None
-
-    def query_list_path(self, database):
-        return self.ds.urls.path("/-/queries")
-
-
-class QueryCreateView(BaseView):
-    name = "query-create"
-    has_json_alternate = False
-
-    async def _render_form(
-        self,
-        request,
-        db,
-        *,
-        sql="",
-        name="",
-        title="",
-        description="",
-        is_private=True,
-        status=200,
-    ):
-        response = await self.render(
-            ["query_create.html"],
-            request,
-            await _query_create_form_context(
-                self.ds,
-                request,
-                db,
-                sql=sql,
-                name=name,
-                title=title,
-                description=description,
-                is_private=is_private,
-            ),
-        )
-        response.status = status
-        return response
-
-    async def get(self, request):
-        db = await self.ds.resolve_database(request)
-        await self.ds.ensure_permission(
-            action="execute-sql",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        )
-        await self.ds.ensure_permission(
-            action="store-query",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        )
-
-        return await self._render_form(request, db, sql=request.args.get("sql") or "")
-
-
-class QueryCreateAnalyzeView(BaseView):
-    name = "query-create-analyze"
-    has_json_alternate = False
-
-    async def get(self, request):
-        db = await self.ds.resolve_database(request)
-        if not await self.ds.allowed(
-            action="execute-sql",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ):
-            return _block_framing(_error(["Permission denied: need execute-sql"], 403))
-        if not await self.ds.allowed(
-            action="store-query",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ):
-            return _block_framing(_error(["Permission denied: need store-query"], 403))
-
-        invalid_keys = set(request.args) - {"sql"}
-        if invalid_keys:
-            return _block_framing(
-                _error(
-                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
-                    400,
-                )
-            )
-        sql = request.args.get("sql") or ""
-        return _block_framing(
-            Response.json(
-                await _query_create_analysis_data(self.ds, db, sql, request.actor)
-            )
-        )
-
-
-class QueryStoreView(QueryCreateView):
-    name = "query-store"
-
-    async def _error_response(self, request, db, query_data, message, status):
-        message = _query_create_form_error_message(message)
-        self.ds.add_message(request, message, self.ds.ERROR)
-        return await self._render_form(
-            request,
-            db,
-            sql=query_data.get("sql") or "",
-            name=query_data.get("name") or "",
-            title=query_data.get("title") or "",
-            description=query_data.get("description") or "",
-            is_private=_as_bool(query_data.get("is_private", True)),
-            status=status,
-        )
-
-    async def post(self, request):
-        db = await self.ds.resolve_database(request)
-        if not await self.ds.allowed(
-            action="execute-sql",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ):
-            return _error(["Permission denied: need execute-sql"], 403)
-        if not await self.ds.allowed(
-            action="store-query",
-            resource=DatabaseResource(db.name),
-            actor=request.actor,
-        ):
-            return _error(["Permission denied: need store-query"], 403)
-
-        is_json = False
-        query_data = {}
-        try:
-            data, is_json = await _json_or_form_payload(request)
-            if not isinstance(data, dict):
-                raise QueryValidationError("JSON must be a dictionary")
-            query_data = data.get("query") if is_json else data
-            if not isinstance(query_data, dict):
-                raise QueryValidationError("JSON must contain a query dictionary")
-            prepared = await _prepare_query_create(self.ds, request, db, query_data)
-        except QueryValidationError as ex:
-            if not is_json and isinstance(query_data, dict):
-                return await self._error_response(
-                    request, db, query_data, ex.message, ex.status
-                )
-            return _error([ex.message], ex.status)
-
-        prepared.pop("analysis")
-        name = prepared.pop("name")
-        try:
-            await self.ds.add_query(db.name, name, replace=False, **prepared)
-        except sqlite3.IntegrityError as ex:
-            if not is_json and isinstance(query_data, dict):
-                return await self._error_response(request, db, query_data, str(ex), 400)
-            return _error([str(ex)], 400)
-
-        query = await self.ds.get_query(db.name, name)
-        if is_json:
-            return Response.json({"ok": True, "query": query}, status=201)
-        self.ds.add_message(request, "Query saved", self.ds.INFO)
-        return Response.redirect(self.ds.urls.path(self.ds.urls.table(db.name, name)))
-
-
-class QueryDefinitionView(BaseView):
-    name = "query-definition"
-
-    async def get(self, request):
-        db = await self.ds.resolve_database(request)
-        query_name = tilde_decode(request.url_vars["query"])
-        query = await self.ds.get_query(db.name, query_name)
-        if query is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
-        if not await self.ds.allowed(
-            action="view-query",
-            resource=QueryResource(db.name, query_name),
-            actor=request.actor,
-        ):
-            return _error(["Permission denied"], 403)
-        return Response.json({"ok": True, "query": query})
-
-
-class QueryUpdateView(BaseView):
-    name = "query-update"
-
-    async def post(self, request):
-        db = await self.ds.resolve_database(request)
-        query_name = tilde_decode(request.url_vars["query"])
-        existing = await self.ds.get_query(db.name, query_name)
-        if existing is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
-        if not await self.ds.allowed(
-            action="update-query",
-            resource=QueryResource(db.name, query_name),
-            actor=request.actor,
-        ):
-            return _error(["Permission denied: need update-query"], 403)
-
-        try:
-            data, _ = await _json_or_form_payload(request)
-            if not isinstance(data, dict):
-                raise QueryValidationError("JSON must be a dictionary")
-            invalid_keys = set(data) - {"update", "return"}
-            if invalid_keys:
-                raise QueryValidationError(
-                    "Invalid keys: {}".format(", ".join(invalid_keys))
-                )
-            update = data.get("update")
-            if not isinstance(update, dict):
-                raise QueryValidationError("JSON must contain an update dictionary")
-            if "sql" in update and not await self.ds.allowed(
-                action="execute-sql",
-                resource=DatabaseResource(db.name),
-                actor=request.actor,
-            ):
-                raise QueryValidationError(
-                    "Permission denied: need execute-sql", status=403
-                )
-            update_kwargs = await _prepare_query_update(
-                self.ds, request, db, existing, update
-            )
-        except QueryValidationError as ex:
-            return _error([ex.message], ex.status)
-
-        await self.ds.update_query(db.name, query_name, **update_kwargs)
-        if data.get("return"):
-            return Response.json(
-                {
-                    "ok": True,
-                    "query": await self.ds.get_query(db.name, query_name),
-                }
-            )
-        return Response.json({"ok": True})
-
-
-class QueryDeleteView(BaseView):
-    name = "query-delete"
-
-    async def post(self, request):
-        db = await self.ds.resolve_database(request)
-        query_name = tilde_decode(request.url_vars["query"])
-        existing = await self.ds.get_query(db.name, query_name)
-        if existing is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
-        if not await self.ds.allowed(
-            action="delete-query",
-            resource=QueryResource(db.name, query_name),
-            actor=request.actor,
-        ):
-            return _error(["Permission denied: need delete-query"], 403)
-        await self.ds.remove_query(db.name, query_name)
-        return Response.json({"ok": True})
-
-
 class QueryView(View):
     async def post(self, request, datasette):
         from datasette.app import TableNotFound
@@ -2435,22 +1220,6 @@ class TableCreateView(BaseView):
         return Response.json(details, status=201)
 
 
-async def _table_columns(datasette, database_name):
-    internal_db = datasette.get_internal_database()
-    result = await internal_db.execute(
-        "select table_name, name from catalog_columns where database_name = ?",
-        [database_name],
-    )
-    table_columns = {}
-    for row in result.rows:
-        table_columns.setdefault(row["table_name"], []).append(row["name"])
-    # Add views
-    db = datasette.get_database(database_name)
-    for view_name in await db.view_names():
-        table_columns[view_name] = []
-    return table_columns
-
-
 async def display_rows(datasette, database, request, rows, columns):
     display_rows = []
     truncate_cells = datasette.setting("truncate_cells_html")
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
new file mode 100644
index 00000000..0054300c
--- /dev/null
+++ b/datasette/views/execute_write.py
@@ -0,0 +1,257 @@
+from urllib.parse import urlencode
+
+from datasette.resources import DatabaseResource
+from datasette.utils import sqlite3
+from datasette.utils.asgi import Response
+
+from .base import BaseView, _error
+from .query_helpers import (
+    QueryValidationError,
+    _analysis_is_write,
+    _analysis_rows,
+    _analysis_rows_with_permissions,
+    _block_framing,
+    _coerce_execute_write_payload,
+    _derived_query_parameters,
+    _execute_write_analysis_data,
+    _inserted_row_url,
+    _json_or_form_payload,
+    _prepare_execute_write,
+    _table_columns,
+    _wants_json,
+)
+
+
+class ExecuteWriteView(BaseView):
+    name = "execute-write"
+    has_json_alternate = False
+
+    async def _render_form(
+        self,
+        request,
+        db,
+        *,
+        sql="",
+        parameter_values=None,
+        analysis=None,
+        analysis_error=None,
+        execution_message=None,
+        execution_links=None,
+        execution_ok=None,
+        status=200,
+    ):
+        parameter_values = parameter_values or {}
+        execution_links = execution_links or []
+        parameter_names = []
+        analysis_rows = []
+        table_columns = await _table_columns(self.ds, db.name)
+        hidden_table_names = set(await db.hidden_table_names())
+        write_template_tables = {
+            table: columns
+            for table, columns in table_columns.items()
+            if columns and table not in hidden_table_names
+        }
+        if sql and analysis_error is None:
+            try:
+                parameter_names = _derived_query_parameters(sql)
+                if analysis is None:
+                    params = {parameter: "" for parameter in parameter_names}
+                    analysis = await db.analyze_sql(sql, params)
+                if _analysis_is_write(analysis):
+                    analysis_rows = await _analysis_rows_with_permissions(
+                        self.ds, analysis, request.actor
+                    )
+                else:
+                    analysis_error = (
+                        "Use /-/query for read-only SQL; "
+                        "this endpoint only executes writes"
+                    )
+            except (QueryValidationError, sqlite3.DatabaseError) as ex:
+                analysis_error = getattr(ex, "message", str(ex))
+
+        allow_save_query = await self.ds.allowed(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ) and await self.ds.allowed(
+            action="store-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        )
+        save_query_base_url = None
+        save_query_url = None
+        if allow_save_query:
+            save_query_base_url = self.ds.urls.database(db.name) + "/-/queries/store"
+            if (
+                sql
+                and analysis_error is None
+                and not any(row["allowed"] is False for row in analysis_rows)
+            ):
+                save_query_url = save_query_base_url + "?" + urlencode({"sql": sql})
+
+        response = await self.render(
+            ["execute_write.html"],
+            request,
+            {
+                "database": db.name,
+                "database_color": db.color,
+                "sql": sql,
+                "parameter_names": parameter_names,
+                "parameter_values": parameter_values,
+                "analysis_error": analysis_error,
+                "analysis_rows": [
+                    row for row in analysis_rows if row["operation"] != "read"
+                ],
+                "execution_message": execution_message,
+                "execution_links": execution_links,
+                "execution_ok": execution_ok,
+                "execute_disabled": bool(
+                    (not sql)
+                    or analysis_error
+                    or any(row["allowed"] is False for row in analysis_rows)
+                ),
+                "table_columns": table_columns,
+                "write_template_tables": write_template_tables,
+                "save_query_url": save_query_url,
+                "save_query_base_url": save_query_base_url,
+            },
+        )
+        response.status = status
+        return _block_framing(response)
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        await self.ds.ensure_permission(
+            action="execute-write-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        )
+        if not db.is_mutable:
+            return _block_framing(
+                _error(
+                    ["Cannot execute write SQL because this database is immutable."],
+                    403,
+                )
+            )
+        return await self._render_form(
+            request,
+            db,
+            sql=request.args.get("sql") or "",
+        )
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-write-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(
+                _error(["Permission denied: need execute-write-sql"], 403)
+            )
+        if not db.is_mutable:
+            return _block_framing(_error(["Database is immutable"], 403))
+
+        data = {}
+        is_json = request.headers.get("content-type", "").startswith("application/json")
+        sql = ""
+        provided_params = {}
+        try:
+            data, is_json = await _json_or_form_payload(request)
+            sql, provided_params = _coerce_execute_write_payload(data, is_json)
+            parameter_names, params, analysis = await _prepare_execute_write(
+                self.ds, db, sql, provided_params, request.actor
+            )
+        except QueryValidationError as ex:
+            if _wants_json(request, is_json, data):
+                return _block_framing(_error([ex.message], ex.status))
+            return await self._render_form(
+                request,
+                db,
+                sql=sql or "",
+                parameter_values=provided_params,
+                analysis_error=ex.message,
+                execution_message=ex.message,
+                execution_ok=False,
+                status=ex.status,
+            )
+
+        try:
+            cursor = await db.execute_write(sql, params, request=request)
+        except sqlite3.DatabaseError as ex:
+            message = str(ex)
+            if _wants_json(request, is_json, data):
+                return _block_framing(_error([message], 400))
+            return await self._render_form(
+                request,
+                db,
+                sql=sql,
+                parameter_values=params,
+                analysis=analysis,
+                execution_message=message,
+                execution_ok=False,
+                status=400,
+            )
+
+        message = "Query executed, {} row{} affected".format(
+            cursor.rowcount, "" if cursor.rowcount == 1 else "s"
+        )
+        if _wants_json(request, is_json, data):
+            return _block_framing(
+                Response.json(
+                    {
+                        "ok": True,
+                        "message": message,
+                        "rowcount": cursor.rowcount,
+                        "analysis": _analysis_rows(analysis),
+                    }
+                )
+            )
+
+        inserted_row_url = await _inserted_row_url(self.ds, db, analysis, cursor)
+        execution_links = (
+            [{"href": inserted_row_url, "label": "View row"}]
+            if inserted_row_url
+            else []
+        )
+        return await self._render_form(
+            request,
+            db,
+            sql=sql,
+            parameter_values={name: params.get(name, "") for name in parameter_names},
+            analysis=analysis,
+            execution_message=message,
+            execution_links=execution_links,
+            execution_ok=True,
+        )
+
+
+class ExecuteWriteAnalyzeView(BaseView):
+    name = "execute-write-analyze"
+    has_json_alternate = False
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-write-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(
+                _error(["Permission denied: need execute-write-sql"], 403)
+            )
+
+        invalid_keys = set(request.args) - {"sql"}
+        if invalid_keys:
+            return _block_framing(
+                _error(
+                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
+                    400,
+                )
+            )
+        sql = request.args.get("sql") or ""
+        return _block_framing(
+            Response.json(
+                await _execute_write_analysis_data(self.ds, db, sql, request.actor)
+            )
+        )
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
new file mode 100644
index 00000000..d8763a6d
--- /dev/null
+++ b/datasette/views/query_helpers.py
@@ -0,0 +1,558 @@
+import json
+import re
+
+from datasette.resources import DatabaseResource, TableResource
+from datasette.utils import (
+    named_parameters as derive_named_parameters,
+    escape_sqlite,
+    path_from_row_pks,
+    sqlite3,
+    validate_sql_select,
+    InvalidSql,
+)
+from datasette.utils.asgi import Forbidden
+
+_query_name_re = re.compile(r"^[^/\.\n]+$")
+
+_query_fields = {
+    "sql",
+    "title",
+    "description",
+    "description_html",
+    "hide_sql",
+    "fragment",
+    "parameters",
+    "params",
+    "is_private",
+    "on_success_message",
+    "on_success_message_sql",
+    "on_success_redirect",
+    "on_error_message",
+    "on_error_redirect",
+}
+
+_query_create_fields = _query_fields | {"name", "mode", "csrftoken"}
+_query_update_fields = _query_fields
+_query_write_fields = {
+    "on_success_message",
+    "on_success_message_sql",
+    "on_success_redirect",
+    "on_error_message",
+    "on_error_redirect",
+}
+
+
+class QueryValidationError(Exception):
+    def __init__(self, message, status=400):
+        self.message = message
+        self.status = status
+
+
+def _actor_id(actor):
+    if isinstance(actor, dict):
+        return actor.get("id")
+    return None
+
+
+def _as_bool(value):
+    if isinstance(value, bool):
+        return value
+    if value is None:
+        return False
+    if isinstance(value, int):
+        return bool(value)
+    if isinstance(value, str):
+        return value.lower() in {"1", "true", "t", "yes", "on"}
+    return bool(value)
+
+
+def _as_optional_bool(value, name):
+    if value is None or value == "":
+        return None
+    if isinstance(value, bool):
+        return value
+    if isinstance(value, int):
+        return bool(value)
+    if isinstance(value, str):
+        lowered = value.lower()
+        if lowered in {"1", "true", "t", "yes", "on"}:
+            return True
+        if lowered in {"0", "false", "f", "no", "off"}:
+            return False
+    raise QueryValidationError("{} must be 0 or 1".format(name))
+
+
+def _query_list_limit(value, default=50):
+    if value in (None, ""):
+        return default
+    try:
+        return min(max(1, int(value)), 1000)
+    except ValueError as ex:
+        raise QueryValidationError("_size must be an integer") from ex
+
+
+def _derived_query_parameters(sql):
+    parameters = []
+    seen = set()
+    for parameter in derive_named_parameters(sql):
+        if parameter.startswith("_"):
+            raise QueryValidationError("Magic parameters are not allowed")
+        if parameter not in seen:
+            parameters.append(parameter)
+            seen.add(parameter)
+    return parameters
+
+
+def _coerce_query_parameters(value, derived):
+    if value is None:
+        return derived
+    if isinstance(value, str):
+        parameters = [
+            parameter.strip()
+            for parameter in re.split(r"[\s,]+", value)
+            if parameter.strip()
+        ]
+    elif isinstance(value, list):
+        parameters = value
+    else:
+        raise QueryValidationError("parameters must be a list of strings")
+    if not all(isinstance(parameter, str) for parameter in parameters):
+        raise QueryValidationError("parameters must be a list of strings")
+    if any(parameter.startswith("_") for parameter in parameters):
+        raise QueryValidationError("Magic parameters are not allowed")
+    if set(parameters) != set(derived):
+        raise QueryValidationError("parameters must match SQL named parameters")
+    return parameters
+
+
+def _analysis_is_write(analysis):
+    return any(
+        access.operation in {"insert", "update", "delete"}
+        for access in analysis.table_accesses
+    )
+
+
+def _block_framing(response):
+    response.headers["Content-Security-Policy"] = "frame-ancestors 'none'"
+    response.headers["X-Frame-Options"] = "DENY"
+    return response
+
+
+def _wants_json(request, is_json, data):
+    return (
+        is_json
+        or request.headers.get("accept") == "application/json"
+        or (isinstance(data, dict) and data.get("_json"))
+    )
+
+
+def _query_create_form_error_message(message):
+    return {
+        "Query name is required": "URL is required",
+        "Invalid query name": "Invalid URL",
+        "Query name conflicts with a table or view": (
+            "URL conflicts with an existing table or view"
+        ),
+        "Query already exists": "A query already exists at that URL",
+    }.get(message, message)
+
+
+async def _json_or_form_payload(request):
+    content_type = request.headers.get("content-type", "")
+    if content_type.startswith("application/json"):
+        body = await request.post_body()
+        try:
+            return json.loads(body or b"{}"), True
+        except json.JSONDecodeError as e:
+            raise QueryValidationError("Invalid JSON: {}".format(e))
+    return await request.post_vars(), False
+
+
+async def _check_query_name(db, name, *, existing=False):
+    if not name or not isinstance(name, str):
+        raise QueryValidationError("Query name is required")
+    if not _query_name_re.match(name):
+        raise QueryValidationError("Invalid query name")
+    if not existing and (await db.table_exists(name) or await db.view_exists(name)):
+        raise QueryValidationError("Query name conflicts with a table or view")
+
+
+async def _analyze_user_query(datasette, db, sql, *, actor):
+    if not sql or not isinstance(sql, str):
+        raise QueryValidationError("SQL is required")
+    derived = _derived_query_parameters(sql)
+    params = {parameter: "" for parameter in derived}
+    try:
+        analysis = await db.analyze_sql(sql, params)
+    except sqlite3.DatabaseError as ex:
+        raise QueryValidationError("Could not analyze query: {}".format(ex)) from ex
+
+    is_write = _analysis_is_write(analysis)
+    if is_write:
+        try:
+            await datasette.ensure_query_write_permissions(
+                db.name, sql, actor=actor, analysis=analysis
+            )
+        except Forbidden as ex:
+            raise QueryValidationError(str(ex), status=403) from ex
+    else:
+        try:
+            validate_sql_select(sql)
+        except InvalidSql as ex:
+            raise QueryValidationError(str(ex)) from ex
+    return is_write, derived, analysis
+
+
+def _analysis_rows(analysis):
+    write_actions = {
+        "insert": "insert-row",
+        "update": "update-row",
+        "delete": "delete-row",
+    }
+    return [
+        {
+            "operation": access.operation,
+            "database": access.database,
+            "table": access.table,
+            "required_permission": write_actions.get(access.operation, ""),
+            "source": access.source,
+        }
+        for access in analysis.table_accesses
+    ]
+
+
+async def _analysis_rows_with_permissions(datasette, analysis, actor):
+    rows = _analysis_rows(analysis)
+    for row in rows:
+        permission = row["required_permission"]
+        if permission:
+            row["allowed"] = await datasette.allowed(
+                action=permission,
+                resource=TableResource(row["database"], row["table"]),
+                actor=actor,
+            )
+        else:
+            row["allowed"] = None
+    return rows
+
+
+def _coerce_execute_write_payload(data, is_json):
+    if not isinstance(data, dict):
+        raise QueryValidationError("JSON must be a dictionary")
+    if is_json:
+        invalid_keys = set(data) - {"sql", "params"}
+        if invalid_keys:
+            raise QueryValidationError(
+                "Invalid keys: {}".format(", ".join(sorted(invalid_keys)))
+            )
+        params = data.get("params") or {}
+    else:
+        params = {
+            key: value
+            for key, value in data.items()
+            if key not in {"sql", "csrftoken", "_json"}
+        }
+    if not isinstance(params, dict):
+        raise QueryValidationError("params must be a dictionary")
+    return data.get("sql"), params
+
+
+async def _prepare_execute_write(datasette, db, sql, params, actor):
+    if not sql or not isinstance(sql, str):
+        raise QueryValidationError("SQL is required")
+    parameter_names = _derived_query_parameters(sql)
+    extra_params = set(params) - set(parameter_names)
+    if extra_params:
+        raise QueryValidationError(
+            "Unknown parameters: {}".format(", ".join(sorted(extra_params)))
+        )
+    params = {name: params.get(name, "") for name in parameter_names}
+    try:
+        analysis = await db.analyze_sql(sql, params)
+    except sqlite3.DatabaseError as ex:
+        raise QueryValidationError("Could not analyze query: {}".format(ex)) from ex
+    if not _analysis_is_write(analysis):
+        raise QueryValidationError(
+            "Use /-/query for read-only SQL; this endpoint only executes writes"
+        )
+    try:
+        await datasette.ensure_query_write_permissions(
+            db.name, sql, actor=actor, analysis=analysis
+        )
+    except Forbidden as ex:
+        raise QueryValidationError(str(ex), status=403) from ex
+    return parameter_names, params, analysis
+
+
+async def _ensure_stored_query_execution_permissions(datasette, db, query, actor):
+    if query.get("is_trusted"):
+        return
+    if query.get("write"):
+        await datasette.ensure_permission(
+            action="execute-write-sql",
+            resource=DatabaseResource(db.name),
+            actor=actor,
+        )
+        await datasette.ensure_query_write_permissions(
+            db.name, query["sql"], actor=actor
+        )
+    else:
+        await datasette.ensure_permission(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=actor,
+        )
+
+
+async def _execute_write_analysis_data(datasette, db, sql, actor):
+    parameter_names = []
+    analysis_rows = []
+    analysis_error = None
+    if sql:
+        try:
+            parameter_names = _derived_query_parameters(sql)
+            params = {parameter: "" for parameter in parameter_names}
+            analysis = await db.analyze_sql(sql, params)
+            if _analysis_is_write(analysis):
+                analysis_rows = await _analysis_rows_with_permissions(
+                    datasette, analysis, actor
+                )
+            else:
+                analysis_error = (
+                    "Use /-/query for read-only SQL; "
+                    "this endpoint only executes writes"
+                )
+        except (QueryValidationError, sqlite3.DatabaseError) as ex:
+            analysis_error = getattr(ex, "message", str(ex))
+    return {
+        "ok": analysis_error is None,
+        "parameters": parameter_names,
+        "analysis_error": analysis_error,
+        "analysis_rows": [row for row in analysis_rows if row["operation"] != "read"],
+        "execute_disabled": bool(
+            (not sql)
+            or analysis_error
+            or any(row["allowed"] is False for row in analysis_rows)
+        ),
+    }
+
+
+async def _query_create_analysis_data(datasette, db, sql, actor):
+    has_sql = bool(sql and sql.strip())
+    parameter_names = []
+    analysis_rows = []
+    analysis_error = None
+    if has_sql:
+        try:
+            parameter_names = _derived_query_parameters(sql)
+            params = {parameter: "" for parameter in parameter_names}
+            analysis = await db.analyze_sql(sql, params)
+            analysis_rows = await _analysis_rows_with_permissions(
+                datasette, analysis, actor
+            )
+        except (QueryValidationError, sqlite3.DatabaseError) as ex:
+            analysis_error = getattr(ex, "message", str(ex))
+    return {
+        "ok": analysis_error is None,
+        "parameters": parameter_names,
+        "analysis_error": analysis_error,
+        "analysis_rows": analysis_rows,
+        "has_sql": has_sql,
+        "analysis_is_write": bool(
+            analysis_rows and any(row["required_permission"] for row in analysis_rows)
+        ),
+        "save_disabled": bool(
+            (not has_sql)
+            or analysis_error
+            or any(row["allowed"] is False for row in analysis_rows)
+        ),
+    }
+
+
+async def _query_create_form_context(
+    datasette,
+    request,
+    db,
+    *,
+    sql="",
+    name="",
+    title="",
+    description="",
+    is_private=True,
+):
+    analysis_data = await _query_create_analysis_data(datasette, db, sql, request.actor)
+    return {
+        "database": db.name,
+        "database_color": db.color,
+        "sql": sql,
+        "name": name,
+        "title": title,
+        "description": description,
+        "is_private": is_private,
+        **analysis_data,
+    }
+
+
+async def _inserted_row_url(datasette, db, analysis, cursor):
+    if cursor.rowcount != 1:
+        return None
+    lastrowid = getattr(cursor, "lastrowid", None)
+    if lastrowid is None:
+        return None
+    direct_inserts = [
+        access
+        for access in analysis.table_accesses
+        if access.operation == "insert"
+        and access.source is None
+        and access.database == db.name
+    ]
+    if len(direct_inserts) != 1:
+        return None
+    table = direct_inserts[0].table
+    pks = await db.primary_keys(table)
+    use_rowid = not pks
+    select = (
+        "rowid"
+        if use_rowid
+        else ", ".join(escape_sqlite(primary_key) for primary_key in pks)
+    )
+    try:
+        result = await db.execute(
+            "select {} from {} where rowid = ?".format(select, escape_sqlite(table)),
+            [lastrowid],
+        )
+    except sqlite3.DatabaseError:
+        return None
+    row = result.first()
+    if row is None:
+        return None
+    row_path = path_from_row_pks(row, pks, use_rowid)
+    return datasette.urls.row(db.name, table, row_path)
+
+
+def _apply_query_data_types(data):
+    typed = dict(data)
+    for key in ("hide_sql", "is_private"):
+        if key in typed:
+            typed[key] = _as_bool(typed[key])
+    return typed
+
+
+async def _prepare_query_create(datasette, request, db, data):
+    invalid_keys = set(data) - _query_create_fields
+    if invalid_keys:
+        raise QueryValidationError("Invalid keys: {}".format(", ".join(invalid_keys)))
+
+    data = _apply_query_data_types(data)
+    name = data.get("name")
+    await _check_query_name(db, name)
+    if await datasette.get_query(db.name, name) is not None:
+        raise QueryValidationError("Query already exists")
+
+    is_write, derived, analysis = await _analyze_user_query(
+        datasette,
+        db,
+        data.get("sql"),
+        actor=request.actor,
+    )
+    if not is_write and any(data.get(field) for field in _query_write_fields):
+        raise QueryValidationError("Writable query fields require writable SQL")
+
+    parameters = _coerce_query_parameters(
+        data.get("parameters", data.get("params")),
+        derived,
+    )
+    return {
+        "name": name,
+        "sql": data["sql"],
+        "title": data.get("title"),
+        "description": data.get("description"),
+        "description_html": data.get("description_html"),
+        "hide_sql": _as_bool(data.get("hide_sql")),
+        "fragment": data.get("fragment"),
+        "parameters": parameters,
+        "is_write": is_write,
+        "is_private": _as_bool(data.get("is_private", True)),
+        "is_trusted": False,
+        "source": "user",
+        "owner_id": _actor_id(request.actor),
+        "on_success_message": data.get("on_success_message"),
+        "on_success_message_sql": data.get("on_success_message_sql"),
+        "on_success_redirect": data.get("on_success_redirect"),
+        "on_error_message": data.get("on_error_message"),
+        "on_error_redirect": data.get("on_error_redirect"),
+        "analysis": analysis,
+    }
+
+
+async def _prepare_query_update(datasette, request, db, existing, update):
+    invalid_keys = set(update) - _query_update_fields
+    if invalid_keys:
+        raise QueryValidationError("Invalid keys: {}".format(", ".join(invalid_keys)))
+
+    update = _apply_query_data_types(update)
+    sql = update.get("sql", existing["sql"])
+    query_is_write = existing["is_write"]
+    derived = _derived_query_parameters(sql)
+    parameters = None
+
+    if "sql" in update:
+        query_is_write, derived, _ = await _analyze_user_query(
+            datasette,
+            db,
+            sql,
+            actor=request.actor,
+        )
+
+    if "parameters" in update or "params" in update:
+        parameters = _coerce_query_parameters(
+            update.get("parameters", update.get("params")),
+            derived,
+        )
+    elif "sql" in update:
+        parameters = derived
+
+    if not query_is_write and any(update.get(field) for field in _query_write_fields):
+        raise QueryValidationError("Writable query fields require writable SQL")
+
+    field_values = {
+        "sql": sql,
+        "title": update.get("title"),
+        "description": update.get("description"),
+        "description_html": update.get("description_html"),
+        "hide_sql": update.get("hide_sql"),
+        "fragment": update.get("fragment"),
+        "parameters": parameters,
+        "is_write": query_is_write,
+        "is_private": update.get("is_private"),
+        "on_success_message": update.get("on_success_message"),
+        "on_success_message_sql": update.get("on_success_message_sql"),
+        "on_success_redirect": update.get("on_success_redirect"),
+        "on_error_message": update.get("on_error_message"),
+        "on_error_redirect": update.get("on_error_redirect"),
+    }
+    update_kwargs = {}
+    for field_name, value in field_values.items():
+        if field_name in update:
+            update_kwargs[field_name] = value
+    if parameters is not None:
+        update_kwargs["parameters"] = parameters
+    if "sql" in update:
+        update_kwargs["is_write"] = query_is_write
+    return update_kwargs
+
+
+async def _table_columns(datasette, database_name):
+    internal_db = datasette.get_internal_database()
+    result = await internal_db.execute(
+        "select table_name, name from catalog_columns where database_name = ?",
+        [database_name],
+    )
+    table_columns = {}
+    for row in result.rows:
+        table_columns.setdefault(row["table_name"], []).append(row["name"])
+    # Add views
+    db = datasette.get_database(database_name)
+    for view_name in await db.view_names():
+        table_columns[view_name] = []
+    return table_columns
diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
new file mode 100644
index 00000000..b3813f14
--- /dev/null
+++ b/datasette/views/stored_queries.py
@@ -0,0 +1,470 @@
+from urllib.parse import parse_qsl, urlencode
+
+from datasette.resources import DatabaseResource, QueryResource
+from datasette.utils import sqlite3, tilde_decode
+from datasette.utils.asgi import Response
+
+from .base import BaseView, _error
+from .query_helpers import (
+    QueryValidationError,
+    _as_bool,
+    _as_optional_bool,
+    _block_framing,
+    _derived_query_parameters,
+    _json_or_form_payload,
+    _prepare_query_create,
+    _prepare_query_update,
+    _query_create_analysis_data,
+    _query_create_form_context,
+    _query_create_form_error_message,
+    _query_list_limit,
+)
+
+
+class QueryParametersView(BaseView):
+    name = "query-parameters"
+    has_json_alternate = False
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(_error(["Permission denied: need execute-sql"], 403))
+
+        invalid_keys = set(request.args) - {"sql"}
+        if invalid_keys:
+            return _block_framing(
+                _error(
+                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
+                    400,
+                )
+            )
+        try:
+            parameters = _derived_query_parameters(request.args.get("sql") or "")
+        except QueryValidationError as ex:
+            return _block_framing(_error([ex.message], ex.status))
+        return _block_framing(Response.json({"ok": True, "parameters": parameters}))
+
+
+def _query_list_url(path, query_string, *, set_args=None, remove_args=None):
+    set_args = set_args or {}
+    remove_args = set(remove_args or ())
+    skip = set(set_args) | remove_args | {"_next"}
+    pairs = [
+        (key, value)
+        for key, value in parse_qsl(query_string, keep_blank_values=True)
+        if key not in skip
+    ]
+    for key, value in set_args.items():
+        if value not in (None, ""):
+            pairs.append((key, value))
+    return path + (("?" + urlencode(pairs)) if pairs else "")
+
+
+class QueryListView(BaseView):
+    name = "query-list"
+
+    async def database_name(self, request):
+        return (await self.ds.resolve_database(request)).name
+
+    def query_list_path(self, database):
+        return self.ds.urls.database(database) + "/-/queries"
+
+    async def get(self, request):
+        database = await self.database_name(request)
+        format_ = request.url_vars.get("format") or "html"
+        try:
+            limit = _query_list_limit(
+                request.args.get("_size"),
+                default=20 if format_ == "html" else 50,
+            )
+            is_write = _as_optional_bool(request.args.get("is_write"), "is_write")
+            is_private = _as_optional_bool(request.args.get("is_private"), "is_private")
+        except QueryValidationError as ex:
+            return _error([ex.message], ex.status)
+
+        page = await self.ds.list_queries(
+            database,
+            actor=request.actor,
+            limit=limit,
+            cursor=request.args.get("_next"),
+            q=request.args.get("q") or None,
+            is_write=is_write,
+            is_private=is_private,
+            source=request.args.get("source") or None,
+            owner_id=request.args.get("owner_id") or None,
+            include_private=True,
+        )
+        query_list_path = self.query_list_path(database)
+        next_url = None
+        if page["next"]:
+            pairs = [
+                (key, value)
+                for key, value in parse_qsl(
+                    request.query_string, keep_blank_values=True
+                )
+                if key != "_next"
+            ]
+            pairs.append(("_next", page["next"]))
+            next_url = "{}?{}".format(
+                query_list_path,
+                urlencode(pairs),
+            )
+
+        current_filters = {
+            "actor": request.actor,
+            "q": request.args.get("q") or None,
+            "is_write": is_write,
+            "is_private": is_private,
+            "source": request.args.get("source") or None,
+            "owner_id": request.args.get("owner_id") or None,
+        }
+
+        async def facet_count(field, value):
+            if current_filters[field] is not None and current_filters[field] != value:
+                return 0
+            filters = dict(current_filters)
+            filters[field] = value
+            return await self.ds.count_queries(database, **filters)
+
+        def facet_href(field, value):
+            if current_filters[field] == value:
+                return _query_list_url(
+                    query_list_path,
+                    request.query_string,
+                    remove_args=[field],
+                )
+            if current_filters[field] is not None:
+                return None
+            return _query_list_url(
+                query_list_path,
+                request.query_string,
+                set_args={field: str(int(value))},
+            )
+
+        async def facet_item(label, field, value):
+            count = await facet_count(field, value)
+            active = current_filters[field] == value
+            if not active and not count:
+                return None
+            return {
+                "label": label,
+                "count": count,
+                "href": facet_href(field, value) if active or count else None,
+                "active": active,
+            }
+
+        async def facet_items(items):
+            return [
+                item
+                for item in [
+                    await facet_item(label, field, value)
+                    for label, field, value in items
+                ]
+                if item is not None
+            ]
+
+        facets = [
+            {
+                "title": "Mode",
+                "items": await facet_items(
+                    [
+                        ("Read-only", "is_write", False),
+                        ("Writable", "is_write", True),
+                    ]
+                ),
+            },
+            {
+                "title": "Visibility",
+                "items": await facet_items(
+                    [
+                        ("Not private", "is_private", False),
+                        ("Private", "is_private", True),
+                    ]
+                ),
+            },
+        ]
+
+        data = {
+            "ok": True,
+            "database": database,
+            "database_color": (
+                self.ds.get_database(database).color if database is not None else None
+            ),
+            "queries": page["queries"],
+            "next": page["next"],
+            "next_url": next_url,
+            "has_more": page["has_more"],
+            "limit": page["limit"],
+            "show_private_note": any(query["is_private"] for query in page["queries"]),
+            "show_trusted_note": any(query["is_trusted"] for query in page["queries"]),
+            "query_list_path": query_list_path,
+            "show_database": database is None,
+            "facets": facets,
+            "filters": {
+                "q": request.args.get("q") or "",
+                "is_write": request.args.get("is_write") or "",
+                "is_private": request.args.get("is_private") or "",
+                "source": request.args.get("source") or "",
+                "owner_id": request.args.get("owner_id") or "",
+            },
+        }
+        if format_ == "json":
+            return Response.json(data)
+        return await self.render(
+            ["query_list.html"],
+            request,
+            data,
+        )
+
+
+class GlobalQueryListView(QueryListView):
+    name = "global-query-list"
+
+    async def database_name(self, request):
+        return None
+
+    def query_list_path(self, database):
+        return self.ds.urls.path("/-/queries")
+
+
+class QueryCreateView(BaseView):
+    name = "query-create"
+    has_json_alternate = False
+
+    async def _render_form(
+        self,
+        request,
+        db,
+        *,
+        sql="",
+        name="",
+        title="",
+        description="",
+        is_private=True,
+        status=200,
+    ):
+        response = await self.render(
+            ["query_create.html"],
+            request,
+            await _query_create_form_context(
+                self.ds,
+                request,
+                db,
+                sql=sql,
+                name=name,
+                title=title,
+                description=description,
+                is_private=is_private,
+            ),
+        )
+        response.status = status
+        return response
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        await self.ds.ensure_permission(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        )
+        await self.ds.ensure_permission(
+            action="store-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        )
+
+        return await self._render_form(request, db, sql=request.args.get("sql") or "")
+
+
+class QueryCreateAnalyzeView(BaseView):
+    name = "query-create-analyze"
+    has_json_alternate = False
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(_error(["Permission denied: need execute-sql"], 403))
+        if not await self.ds.allowed(
+            action="store-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _block_framing(_error(["Permission denied: need store-query"], 403))
+
+        invalid_keys = set(request.args) - {"sql"}
+        if invalid_keys:
+            return _block_framing(
+                _error(
+                    ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
+                    400,
+                )
+            )
+        sql = request.args.get("sql") or ""
+        return _block_framing(
+            Response.json(
+                await _query_create_analysis_data(self.ds, db, sql, request.actor)
+            )
+        )
+
+
+class QueryStoreView(QueryCreateView):
+    name = "query-store"
+
+    async def _error_response(self, request, db, query_data, message, status):
+        message = _query_create_form_error_message(message)
+        self.ds.add_message(request, message, self.ds.ERROR)
+        return await self._render_form(
+            request,
+            db,
+            sql=query_data.get("sql") or "",
+            name=query_data.get("name") or "",
+            title=query_data.get("title") or "",
+            description=query_data.get("description") or "",
+            is_private=_as_bool(query_data.get("is_private", True)),
+            status=status,
+        )
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        if not await self.ds.allowed(
+            action="execute-sql",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need execute-sql"], 403)
+        if not await self.ds.allowed(
+            action="store-query",
+            resource=DatabaseResource(db.name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need store-query"], 403)
+
+        is_json = False
+        query_data = {}
+        try:
+            data, is_json = await _json_or_form_payload(request)
+            if not isinstance(data, dict):
+                raise QueryValidationError("JSON must be a dictionary")
+            query_data = data.get("query") if is_json else data
+            if not isinstance(query_data, dict):
+                raise QueryValidationError("JSON must contain a query dictionary")
+            prepared = await _prepare_query_create(self.ds, request, db, query_data)
+        except QueryValidationError as ex:
+            if not is_json and isinstance(query_data, dict):
+                return await self._error_response(
+                    request, db, query_data, ex.message, ex.status
+                )
+            return _error([ex.message], ex.status)
+
+        prepared.pop("analysis")
+        name = prepared.pop("name")
+        try:
+            await self.ds.add_query(db.name, name, replace=False, **prepared)
+        except sqlite3.IntegrityError as ex:
+            if not is_json and isinstance(query_data, dict):
+                return await self._error_response(request, db, query_data, str(ex), 400)
+            return _error([str(ex)], 400)
+
+        query = await self.ds.get_query(db.name, name)
+        if is_json:
+            return Response.json({"ok": True, "query": query}, status=201)
+        self.ds.add_message(request, "Query saved", self.ds.INFO)
+        return Response.redirect(self.ds.urls.path(self.ds.urls.table(db.name, name)))
+
+
+class QueryDefinitionView(BaseView):
+    name = "query-definition"
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        query_name = tilde_decode(request.url_vars["query"])
+        query = await self.ds.get_query(db.name, query_name)
+        if query is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        if not await self.ds.allowed(
+            action="view-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied"], 403)
+        return Response.json({"ok": True, "query": query})
+
+
+class QueryUpdateView(BaseView):
+    name = "query-update"
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        query_name = tilde_decode(request.url_vars["query"])
+        existing = await self.ds.get_query(db.name, query_name)
+        if existing is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        if not await self.ds.allowed(
+            action="update-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need update-query"], 403)
+
+        try:
+            data, _ = await _json_or_form_payload(request)
+            if not isinstance(data, dict):
+                raise QueryValidationError("JSON must be a dictionary")
+            invalid_keys = set(data) - {"update", "return"}
+            if invalid_keys:
+                raise QueryValidationError(
+                    "Invalid keys: {}".format(", ".join(invalid_keys))
+                )
+            update = data.get("update")
+            if not isinstance(update, dict):
+                raise QueryValidationError("JSON must contain an update dictionary")
+            if "sql" in update and not await self.ds.allowed(
+                action="execute-sql",
+                resource=DatabaseResource(db.name),
+                actor=request.actor,
+            ):
+                raise QueryValidationError(
+                    "Permission denied: need execute-sql", status=403
+                )
+            update_kwargs = await _prepare_query_update(
+                self.ds, request, db, existing, update
+            )
+        except QueryValidationError as ex:
+            return _error([ex.message], ex.status)
+
+        await self.ds.update_query(db.name, query_name, **update_kwargs)
+        if data.get("return"):
+            return Response.json(
+                {
+                    "ok": True,
+                    "query": await self.ds.get_query(db.name, query_name),
+                }
+            )
+        return Response.json({"ok": True})
+
+
+class QueryDeleteView(BaseView):
+    name = "query-delete"
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        query_name = tilde_decode(request.url_vars["query"])
+        existing = await self.ds.get_query(db.name, query_name)
+        if existing is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        if not await self.ds.allowed(
+            action="delete-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need delete-query"], 403)
+        await self.ds.remove_query(db.name, query_name)
+        return Response.json({"ok": True})
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 96224ef9..f720c12f 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -496,7 +496,7 @@ Here's how to restrict access to your entire Datasette instance to just the ``"i
             title: My private Datasette instance
             allow:
               id: root
-
+  
 
 .. tab:: datasette.json
 

From 3c29b002cac641450cc5c9ce757c031cc2a05dec Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 16:07:53 -0700
Subject: [PATCH 103/386] Do not document unstable JSON APIs for stored queries

---
 docs/json_api.rst  | 59 ----------------------------------------------
 tests/test_docs.py |  9 +++++++
 2 files changed, 9 insertions(+), 59 deletions(-)

diff --git a/docs/json_api.rst b/docs/json_api.rst
index a605c116..48c70af6 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -505,65 +505,6 @@ The JSON write API
 
 Datasette provides a write API for JSON data. This is a POST-only API that requires an authenticated API token, see :ref:`CreateTokenView`. The token will need to have the specified :ref:`authentication_permissions`.
 
-.. _GlobalQueryListView:
-.. _QueryListView:
-
-Listing stored queries
-~~~~~~~~~~~~~~~~~~~~~~
-
-``GET /-/queries.json`` returns stored query definitions across every database that the actor can view. ``GET /<database>/-/queries.json`` returns stored query definitions for a specific database. Use ``?_size=50`` to set the page size and ``?_next=...`` with the cursor returned by the previous page to fetch the next page.
-
-.. _QueryCreateView:
-
-Creating stored queries in the UI
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-``GET /<database>/-/queries/store`` provides a form for creating stored queries.
-
-.. _QueryStoreView:
-.. _QueryInsertView:
-
-Creating stored queries
-~~~~~~~~~~~~~~~~~~~~~~~
-
-``POST /<database>/-/queries/store`` creates a stored query. This requires ``execute-sql`` and ``store-query`` for the database.
-
-.. _QueryParametersView:
-.. _ExecuteWriteView:
-.. _ExecuteWriteAnalyzeView:
-
-Executing write SQL
-~~~~~~~~~~~~~~~~~~~
-
-``GET /<database>/-/query/parameters?sql=...`` returns the named parameters used by a SQL query. This requires ``execute-sql`` for the database.
-
-``GET /<database>/-/execute-write`` displays a form for executing writable SQL. A ``?sql=`` query string pre-populates the form without executing it.
-
-``POST /<database>/-/execute-write`` executes writable SQL. This requires ``execute-write-sql`` for the database plus the relevant table-level write permissions.
-
-``GET /<database>/-/execute-write/analyze?sql=...`` returns the derived parameters plus the write operations that SQL would need in order to execute.
-
-.. _QueryDefinitionView:
-
-Getting a stored query definition
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-``GET /<database>/<query>/-/definition`` returns a stored query definition without executing it.
-
-.. _QueryUpdateView:
-
-Updating stored queries
-~~~~~~~~~~~~~~~~~~~~~~~
-
-``POST /<database>/<query>/-/update`` updates a stored query using a JSON body with an ``"update"`` object.
-
-.. _QueryDeleteView:
-
-Deleting stored queries
-~~~~~~~~~~~~~~~~~~~~~~~
-
-``POST /<database>/<query>/-/delete`` deletes a stored query.
-
 .. _TableInsertView:
 
 Inserting rows
diff --git a/tests/test_docs.py b/tests/test_docs.py
index 0d0ef1e1..9cf39f41 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -71,7 +71,16 @@ def documented_views():
             "PatternPortfolioView",
             "AuthTokenView",
             "ApiExplorerView",
+            "ExecuteWriteAnalyzeView",
+            "ExecuteWriteView",
+            "GlobalQueryListView",
             "QueryCreateAnalyzeView",
+            "QueryDeleteView",
+            "QueryDefinitionView",
+            "QueryListView",
+            "QueryParametersView",
+            "QueryStoreView",
+            "QueryUpdateView",
         )
     )
     return view_labels

From 2eb307b8c664d8a3cc41e54b5f301e44163dc861 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 16:10:05 -0700
Subject: [PATCH 104/386] Changelog updates for queries branch

Refs #2735, #2742
---
 docs/changelog.rst | 28 +++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index d15dec50..9da938b0 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -9,10 +9,32 @@ Changelog
 Unreleased
 ----------
 
-- Fixed a bug where visiting ``/<database>/-/query`` without a ``?sql=`` parameter returned a 500 error. (:issue:`2743`)
+Stored queries
+~~~~~~~~~~~~~~
+
+- The previous "canned queries" feature has been renamed and expanded into :ref:`stored queries <stored_queries>`. Queries configured in ``datasette.yaml`` are now loaded into a new ``queries`` table in Datasette's :ref:`internal database <internals_internal_schema>`, alongside user-created stored queries. (:issue:`2735`)
+- New stored query management APIs: ``datasette.add_query()``, ``datasette.update_query()``, ``datasette.remove_query()``, ``datasette.get_query()``, ``datasette.list_queries()`` and ``datasette.count_queries()``. These replace the removed ``datasette.get_canned_query()`` and ``datasette.get_canned_queries()`` methods. (:issue:`2735`)
+- Users with :ref:`store-query <actions_store_query>` and :ref:`execute-sql <actions_execute_sql>` permission can create stored queries from the SQL query page or the new ``GET /<database>/-/queries/store`` form. (:issue:`2735`)
+- The database page now shows a count and preview of stored queries, capped at five, and links to new paginated query browsers at ``/-/queries`` and ``/<database>/-/queries``. Those browsers support search. (:issue:`2735`)
+- Stored queries created by users default to private and untrusted. Private stored queries can only be viewed, updated or deleted by their owner, even if another actor has broad ``view-query``, ``update-query`` or ``delete-query`` permission. Untrusted stored queries execute using the permissions of the actor running them. See :ref:`stored_queries` and :ref:`trusted_stored_queries` for details. (:issue:`2735`)
+- New ``store-query``, ``update-query`` and ``delete-query`` permissions, plus updated semantics for :ref:`view-query <actions_view_query>`. Trusted stored queries can still execute with ``view-query`` alone; untrusted read queries also require :ref:`execute-sql <actions_execute_sql>` and untrusted writable queries require :ref:`execute-write-sql <actions_execute_write_sql>` plus the relevant table-level write permissions. (:issue:`2735`)
+
+Write SQL UI
+~~~~~~~~~~~~
+
+- New "Write to this database" interface at ``/<database>/-/execute-write`` for running arbitrary writable SQL against mutable databases. The form extracts named parameters, analyzes the SQL, shows the table operations that will be attempted and links to a newly inserted row when a single-row insert succeeds. (:issue:`2742`)
+- Added the new :ref:`execute-write-sql <actions_execute_write_sql>` permission for running arbitrary writable SQL. Execution is also gated by table-level permissions such as :ref:`insert-row <actions_insert_row>`, :ref:`update-row <actions_update_row>` and :ref:`delete-row <actions_delete_row>`, and writes to attached databases are rejected. (:issue:`2742`)
+
+Plugin API changes
+~~~~~~~~~~~~~~~~~~
+
 - The ``top_canned_query()`` plugin hook has been renamed to :ref:`top_stored_query() <plugin_hook_top_stored_query>`. (:issue:`2747`)
-- The ``canned_queries()`` plugin hook has been removed. Plugins can use the new ``datasette.add_query()``, ``datasette.update_query()`` and ``datasette.remove_query()`` methods to manage stored queries instead.
-- The ``datasette.get_canned_query()`` and ``datasette.get_canned_queries()`` methods have been removed. Plugins can use ``datasette.get_query()`` and ``datasette.list_queries()`` instead.
+- The ``canned_queries()`` plugin hook has been removed. Plugins can use the new stored query methods together with :ref:`startup() <plugin_hook_startup>` to register queries. (:issue:`2735`)
+
+Bug fixes
+~~~~~~~~~
+
+- Fixed a bug where visiting ``/<database>/-/query`` without a ``?sql=`` parameter returned a 500 error. (:issue:`2743`)
 
 .. _v1_0_a30:
 

From 56160e44fc590177bd3fc85bdfe614459b01851d Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 16:25:33 -0700
Subject: [PATCH 105/386] Trusted queries cannot be updated using the API

Refs https://github.com/simonw/datasette/pull/2741#issuecomment-4549620486
---
 datasette/views/stored_queries.py |  2 ++
 tests/test_queries.py             | 52 +++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)

diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
index b3813f14..1a2c5d00 100644
--- a/datasette/views/stored_queries.py
+++ b/datasette/views/stored_queries.py
@@ -413,6 +413,8 @@ class QueryUpdateView(BaseView):
             actor=request.actor,
         ):
             return _error(["Permission denied: need update-query"], 403)
+        if existing.get("is_trusted"):
+            return _error(["Trusted queries cannot be updated using the API"], 403)
 
         try:
             data, _ = await _json_or_form_payload(request)
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 4f2fd1ff..6b2262e0 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -961,6 +961,58 @@ async def test_query_update_and_delete_api():
     assert await ds.get_query("data", "editable") is None
 
 
+@pytest.mark.asyncio
+async def test_query_update_api_rejects_trusted_queries_but_internal_update_allowed():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "execute-sql": {"id": "editor"},
+                        "update-query": {"id": "editor"},
+                    },
+                    "queries": {
+                        "trusted_report": {
+                            "sql": "select 1 as one",
+                            "title": "Original",
+                        },
+                    },
+                }
+            }
+        },
+    )
+    ds.add_memory_database("query_update_trusted_api", name="data")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/trusted_report/-/update",
+        actor={"id": "editor"},
+        json={"update": {"sql": "select 2 as two", "title": "Edited"}},
+    )
+
+    assert response.status_code == 403
+    assert response.json()["errors"] == [
+        "Trusted queries cannot be updated using the API"
+    ]
+    query = await ds.get_query("data", "trusted_report")
+    assert query["is_trusted"] is True
+    assert query["sql"] == "select 1 as one"
+    assert query["title"] == "Original"
+
+    await ds.update_query(
+        "data",
+        "trusted_report",
+        sql="select 3 as three",
+        title="Internal",
+    )
+    query = await ds.get_query("data", "trusted_report")
+    assert query["is_trusted"] is True
+    assert query["sql"] == "select 3 as three"
+    assert query["title"] == "Internal"
+
+
 @pytest.mark.asyncio
 async def test_query_store_api_rejects_magic_parameters():
     ds = Datasette(memory=True, default_deny=True)

From ec438496a954dfb6a63f2d0c7b39ce8fe3a33b1b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 16:31:07 -0700
Subject: [PATCH 106/386] Get rid of the write/is_write dual properties

---
 datasette/stored_queries.py      | 4 +---
 datasette/views/database.py      | 2 +-
 datasette/views/query_helpers.py | 2 +-
 tests/test_queries.py            | 2 --
 4 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index 5b005c07..a28b71bf 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -55,7 +55,6 @@ def query_row_to_dict(row):
         return None
     parameters = json.loads(row["parameters"] or "[]")
     options = json.loads(row["options"] or "{}")
-    is_write = bool(row["is_write"])
     return {
         "database": row["database_name"],
         "name": row["name"],
@@ -67,8 +66,7 @@ def query_row_to_dict(row):
         "fragment": options.get("fragment"),
         "params": parameters,
         "parameters": parameters,
-        "is_write": is_write,
-        "write": is_write,
+        "is_write": bool(row["is_write"]),
         "is_private": bool(row["is_private"]),
         "is_trusted": bool(row["is_trusted"]),
         "source": row["source"],
diff --git a/datasette/views/database.py b/datasette/views/database.py
index f11a7d16..98ca989c 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -562,7 +562,7 @@ class QueryView(View):
                 )
                 if stored_query is None:
                     raise
-                stored_query_write = bool(stored_query.get("write"))
+                stored_query_write = bool(stored_query.get("is_write"))
 
         private = False
         if stored_query:
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index d8763a6d..9906ac67 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -287,7 +287,7 @@ async def _prepare_execute_write(datasette, db, sql, params, actor):
 async def _ensure_stored_query_execution_permissions(datasette, db, query, actor):
     if query.get("is_trusted"):
         return
-    if query.get("write"):
+    if query.get("is_write"):
         await datasette.ensure_permission(
             action="execute-write-sql",
             resource=DatabaseResource(db.name),
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 6b2262e0..ff9057ef 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -99,7 +99,6 @@ async def test_add_get_and_remove_query():
         "params": ["region"],
         "parameters": ["region"],
         "is_write": False,
-        "write": False,
         "is_private": False,
         "is_trusted": True,
         "source": "user",
@@ -209,7 +208,6 @@ async def test_config_queries_imported_to_internal_table():
         "params": ["name"],
         "parameters": ["name"],
         "is_write": False,
-        "write": False,
         "is_private": False,
         "is_trusted": True,
         "source": "config",

From 90e19a7d589f2ca8391044a35cf7be064b1a321f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 16:33:36 -0700
Subject: [PATCH 107/386] Docs for datasette methods for queries

Refs https://github.com/simonw/datasette/pull/2741#issuecomment-4549824373
---
 docs/changelog.rst |   2 +-
 docs/internals.rst | 202 ++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 199 insertions(+), 5 deletions(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 9da938b0..2ba713ee 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -29,7 +29,7 @@ Plugin API changes
 ~~~~~~~~~~~~~~~~~~
 
 - The ``top_canned_query()`` plugin hook has been renamed to :ref:`top_stored_query() <plugin_hook_top_stored_query>`. (:issue:`2747`)
-- The ``canned_queries()`` plugin hook has been removed. Plugins can use the new stored query methods together with :ref:`startup() <plugin_hook_startup>` to register queries. (:issue:`2735`)
+- The ``canned_queries()`` plugin hook has been removed. Plugins can use the new :ref:`stored query management methods <datasette_stored_queries>` together with :ref:`startup() <plugin_hook_startup>` to register queries. (:issue:`2735`)
 
 Bug fixes
 ~~~~~~~~~
diff --git a/docs/internals.rst b/docs/internals.rst
index 084922f8..66724aa9 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -927,6 +927,200 @@ Adds a new metadata entry for the specified column.
 Any previous column-level metadata entry with the same ``key`` will be overwritten.
 Internally upserts the value into the  the ``metadata_columns`` table inside the :ref:`internal database <internals_internal>`.
 
+.. _datasette_stored_queries:
+
+Stored queries
+--------------
+
+:ref:`Stored queries <stored_queries>` are stored in the ``queries`` table in the :ref:`internal database <internals_internal>`. Plugins can use the following methods to add, update, list and remove stored queries.
+
+.. _datasette_add_query:
+
+await .add_query(database, name, sql, ...)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Adds a stored query.
+
+.. code-block:: python
+
+    async def add_query(
+        self,
+        database,
+        name,
+        sql,
+        *,
+        title=None,
+        description=None,
+        description_html=None,
+        hide_sql=False,
+        fragment=None,
+        parameters=None,
+        is_write=False,
+        is_private=False,
+        is_trusted=False,
+        source="plugin",
+        owner_id=None,
+        on_success_message=None,
+        on_success_message_sql=None,
+        on_success_redirect=None,
+        on_error_message=None,
+        on_error_redirect=None,
+        replace=True,
+    ): ...
+
+``database`` - string
+    The name of the database this query should belong to.
+``name`` - string
+    The name of the stored query, used in the URL for that query.
+``sql`` - string
+    The SQL for the stored query.
+``title`` - string, optional
+    A display title for the query.
+``description`` - string, optional
+    A plain text description.
+``description_html`` - string, optional
+    An HTML description.
+``hide_sql`` - boolean, optional
+    Set to ``True`` to hide the SQL by default on the query page.
+``fragment`` - string, optional
+    A URL fragment to append to query links, for example ``"chart"``.
+``parameters`` - list of strings, optional
+    Explicit parameter names for the query form. If omitted, Datasette derives parameters from the SQL.
+``is_write`` - boolean, optional
+    Set to ``True`` for writable queries. They will the run against the SQLite write connection for the database.
+``is_private`` - boolean, optional
+    Set to ``True`` for private queries. Private queries can only be viewed, updated or deleted by their owner.
+``is_trusted`` - boolean, optional
+    Set to ``True`` for :ref:`trusted stored queries <trusted_stored_queries>`.
+``source`` - string, optional
+    Identifies where the query came from. Defaults to ``"plugin"``.
+``owner_id`` - string, optional
+    Actor ID of the query owner, used by private query permissions.
+``on_success_message``, ``on_success_message_sql``, ``on_success_redirect``, ``on_error_message``, ``on_error_redirect`` - strings, optional
+    Options for :ref:`writable queries <queries_writable>`.
+``replace`` - boolean, optional
+    Defaults to ``True``, which replaces any existing stored query with the same ``database`` and ``name``. Set this to ``False`` to raise a SQLite integrity error if the query already exists.
+
+Example:
+
+.. code-block:: python
+
+    await datasette.add_query(
+        database="fixtures",
+        name="recent_rows",
+        sql="select * from facetable order by created desc limit 10",
+        title="Recent rows",
+        source="my-plugin",
+    )
+
+.. _datasette_update_query:
+
+await .update_query(database, name, ...)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Updates fields for an existing stored query. Only keyword arguments that are provided will be changed.
+
+The available keyword arguments are the same as those for :ref:`datasette_add_query`, except for ``replace``. Pass ``None`` to clear optional text fields and options such as ``on_success_redirect``. Passing ``hide_sql=False`` removes the ``hide_sql`` option.
+
+Example:
+
+.. code-block:: python
+
+    await datasette.update_query(
+        database="fixtures",
+        name="recent_rows",
+        title="Latest rows",
+        is_private=True,
+        owner_id="alice",
+    )
+
+.. _datasette_get_query:
+
+await .get_query(database, name)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Returns a stored query dictionary, or ``None`` if the query does not exist.
+
+The dictionary contains ``database``, ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``params``, ``is_write``, ``is_private``, ``is_trusted``, ``source``, ``owner_id``, ``on_success_message``, ``on_success_message_sql``, ``on_success_redirect``, ``on_error_message`` and ``on_error_redirect``.
+
+``parameters`` and ``params`` contain the same list of explicit parameter names.
+
+.. _datasette_list_queries:
+
+await .list_queries(database=None, ...)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Lists stored queries visible to the specified actor.
+
+.. code-block:: python
+
+    async def list_queries(
+        self,
+        database=None,
+        *,
+        actor=None,
+        limit=50,
+        cursor=None,
+        q=None,
+        is_write=None,
+        is_private=None,
+        is_trusted=None,
+        source=None,
+        owner_id=None,
+        include_private=False,
+    ): ...
+
+``database`` - string, optional
+    Restrict results to a specific database. Omit this to list queries across all databases.
+``actor`` - dictionary, optional
+    The authenticated actor. Results are filtered using that actor's ``view-query`` permission.
+``limit`` - integer, optional
+    Number of queries to return. Values are clamped to the range 1-1000.
+``cursor`` - string, optional
+    Pagination cursor from the previous page's ``next`` value.
+``q`` - string, optional
+    Search string matched against query name, title, description and SQL.
+``is_write``, ``is_private``, ``is_trusted`` - boolean, optional
+    Filter by those stored query flags.
+``source`` - string, optional
+    Filter by query source.
+``owner_id`` - string, optional
+    Filter by owner actor ID.
+``include_private`` - boolean, optional
+    Set to ``True`` to include a ``private`` boolean in each returned query dictionary indicating if anonymous users would be unable to view that query.
+
+The return value is a dictionary with these keys:
+
+``queries`` - list of dictionaries
+    Stored query dictionaries, in the same format returned by :ref:`datasette_get_query`.
+``next`` - string or None
+    Pagination cursor for the next page, if one exists.
+``has_more`` - boolean
+    ``True`` if another page of results is available.
+``limit`` - integer
+    The limit used for this page.
+
+.. _datasette_count_queries:
+
+await .count_queries(database=None, ...)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Counts stored queries visible to the specified actor. This accepts the same filtering keyword arguments as :ref:`datasette_list_queries`, except for ``limit``, ``cursor`` and ``include_private``.
+
+.. _datasette_remove_query:
+
+await .remove_query(database, name, source=None)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Removes a stored query.
+
+``database`` - string
+    The database the query belongs to.
+``name`` - string
+    The query name.
+``source`` - string, optional
+    If provided, only a query with this source will be removed.
+
 .. _datasette_column_types:
 
 Column types
@@ -2239,8 +2433,8 @@ Note that the space character is a special case: it will be replaced with a ``+`
 
 .. _internals_utils_call_with_supported_arguments:
 
-call_with_supported_arguments(fn, **kwargs)
--------------------------------------------
+call_with_supported_arguments(fn, \*\*kwargs)
+---------------------------------------------
 
 Call ``fn``, passing it only those keyword arguments that match its function signature. This implements a dependency injection pattern - the caller provides all available arguments, and the function receives only the ones it declares as parameters.
 
@@ -2267,8 +2461,8 @@ This is useful in plugins that want to define callback functions that only decla
 
 .. _internals_utils_async_call_with_supported_arguments:
 
-await async_call_with_supported_arguments(fn, **kwargs)
--------------------------------------------------------
+await async_call_with_supported_arguments(fn, \*\*kwargs)
+---------------------------------------------------------
 
 Async version of :ref:`call_with_supported_arguments <internals_utils_call_with_supported_arguments>`. Use this for ``async def`` callback functions.
 

From 2fde692a3eab8a4d1569287020cba59ea5c1ca18 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 16:34:48 -0700
Subject: [PATCH 108/386] Disallow edits of dangerous
 decsription_html/on_success_message_sql

Refs https://github.com/simonw/datasette/pull/2741#issuecomment-4549891578
---
 datasette/views/query_helpers.py | 15 +++---
 tests/test_queries.py            | 81 +++++++++++++++++++++++++++++++-
 2 files changed, 85 insertions(+), 11 deletions(-)

diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 9906ac67..de732431 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -18,14 +18,12 @@ _query_fields = {
     "sql",
     "title",
     "description",
-    "description_html",
     "hide_sql",
     "fragment",
     "parameters",
     "params",
     "is_private",
     "on_success_message",
-    "on_success_message_sql",
     "on_success_redirect",
     "on_error_message",
     "on_error_redirect",
@@ -35,7 +33,6 @@ _query_create_fields = _query_fields | {"name", "mode", "csrftoken"}
 _query_update_fields = _query_fields
 _query_write_fields = {
     "on_success_message",
-    "on_success_message_sql",
     "on_success_redirect",
     "on_error_message",
     "on_error_redirect",
@@ -441,7 +438,9 @@ def _apply_query_data_types(data):
 async def _prepare_query_create(datasette, request, db, data):
     invalid_keys = set(data) - _query_create_fields
     if invalid_keys:
-        raise QueryValidationError("Invalid keys: {}".format(", ".join(invalid_keys)))
+        raise QueryValidationError(
+            "Invalid keys: {}".format(", ".join(sorted(invalid_keys)))
+        )
 
     data = _apply_query_data_types(data)
     name = data.get("name")
@@ -467,7 +466,6 @@ async def _prepare_query_create(datasette, request, db, data):
         "sql": data["sql"],
         "title": data.get("title"),
         "description": data.get("description"),
-        "description_html": data.get("description_html"),
         "hide_sql": _as_bool(data.get("hide_sql")),
         "fragment": data.get("fragment"),
         "parameters": parameters,
@@ -477,7 +475,6 @@ async def _prepare_query_create(datasette, request, db, data):
         "source": "user",
         "owner_id": _actor_id(request.actor),
         "on_success_message": data.get("on_success_message"),
-        "on_success_message_sql": data.get("on_success_message_sql"),
         "on_success_redirect": data.get("on_success_redirect"),
         "on_error_message": data.get("on_error_message"),
         "on_error_redirect": data.get("on_error_redirect"),
@@ -488,7 +485,9 @@ async def _prepare_query_create(datasette, request, db, data):
 async def _prepare_query_update(datasette, request, db, existing, update):
     invalid_keys = set(update) - _query_update_fields
     if invalid_keys:
-        raise QueryValidationError("Invalid keys: {}".format(", ".join(invalid_keys)))
+        raise QueryValidationError(
+            "Invalid keys: {}".format(", ".join(sorted(invalid_keys)))
+        )
 
     update = _apply_query_data_types(update)
     sql = update.get("sql", existing["sql"])
@@ -519,14 +518,12 @@ async def _prepare_query_update(datasette, request, db, existing, update):
         "sql": sql,
         "title": update.get("title"),
         "description": update.get("description"),
-        "description_html": update.get("description_html"),
         "hide_sql": update.get("hide_sql"),
         "fragment": update.get("fragment"),
         "parameters": parameters,
         "is_write": query_is_write,
         "is_private": update.get("is_private"),
         "on_success_message": update.get("on_success_message"),
-        "on_success_message_sql": update.get("on_success_message_sql"),
         "on_success_redirect": update.get("on_success_redirect"),
         "on_error_message": update.get("on_error_message"),
         "on_error_redirect": update.get("on_error_redirect"),
diff --git a/tests/test_queries.py b/tests/test_queries.py
index ff9057ef..70fb7a03 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -186,7 +186,9 @@ async def test_config_queries_imported_to_internal_table():
                         "configured": {
                             "sql": "select :name as name",
                             "title": "Configured query",
+                            "description_html": "<p>Configured HTML</p>",
                             "params": ["name"],
+                            "on_success_message_sql": "select 'Hello ' || :name",
                         }
                     }
                 }
@@ -202,7 +204,7 @@ async def test_config_queries_imported_to_internal_table():
         "sql": "select :name as name",
         "title": "Configured query",
         "description": None,
-        "description_html": None,
+        "description_html": "<p>Configured HTML</p>",
         "hide_sql": False,
         "fragment": None,
         "params": ["name"],
@@ -213,7 +215,7 @@ async def test_config_queries_imported_to_internal_table():
         "source": "config",
         "owner_id": None,
         "on_success_message": None,
-        "on_success_message_sql": None,
+        "on_success_message_sql": "select 'Hello ' || :name",
         "on_success_redirect": None,
         "on_error_message": None,
         "on_error_redirect": None,
@@ -887,6 +889,45 @@ async def test_query_store_api_rejects_is_trusted():
     assert response.json()["errors"] == ["Invalid keys: is_trusted"]
 
 
+@pytest.mark.asyncio
+async def test_query_store_rejects_config_only_fields():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    ds.add_memory_database("query_config_only_fields_api", name="data")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/queries/store",
+        actor={"id": "root"},
+        json={
+            "query": {
+                "name": "unsafe",
+                "sql": "select 1",
+                "description_html": "<script>window.XSS=1</script>",
+                "on_success_message_sql": "select 'secret'",
+            }
+        },
+    )
+    form_response = await ds.client.post(
+        "/data/-/queries/store",
+        actor={"id": "root"},
+        data={
+            "name": "unsafe_form",
+            "sql": "select 1",
+            "description_html": "<script>window.XSS=1</script>",
+        },
+    )
+
+    assert response.status_code == 400
+    assert response.json()["errors"] == [
+        "Invalid keys: description_html, on_success_message_sql"
+    ]
+    assert form_response.status_code == 400
+    assert "Invalid keys: description_html" in form_response.text
+    assert await ds.get_query("data", "unsafe") is None
+    assert await ds.get_query("data", "unsafe_form") is None
+
+
 @pytest.mark.asyncio
 async def test_query_store_api_creates_writable_query():
     ds = Datasette(memory=True, default_deny=True)
@@ -959,6 +1000,42 @@ async def test_query_update_and_delete_api():
     assert await ds.get_query("data", "editable") is None
 
 
+@pytest.mark.asyncio
+async def test_query_update_api_rejects_config_only_fields():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_update_config_only_fields", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "editable",
+        "insert into dogs (name) values (:name)",
+        is_write=True,
+        source="user",
+        owner_id="root",
+    )
+
+    response = await ds.client.post(
+        "/data/editable/-/update",
+        actor={"id": "root"},
+        json={
+            "update": {
+                "description_html": "<script>window.XSS=1</script>",
+                "on_success_message_sql": "select 'secret'",
+            }
+        },
+    )
+
+    assert response.status_code == 400
+    assert response.json()["errors"] == [
+        "Invalid keys: description_html, on_success_message_sql"
+    ]
+    query = await ds.get_query("data", "editable")
+    assert query["description_html"] is None
+    assert query["on_success_message_sql"] is None
+
+
 @pytest.mark.asyncio
 async def test_query_update_api_rejects_trusted_queries_but_internal_update_allowed():
     ds = Datasette(

From b1289a73f9869e83a433a088c2a6c48285e67f2d Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 16:51:00 -0700
Subject: [PATCH 109/386] stored_queries.StoredQuery dataclass

---
 datasette/app.py                  | 102 ++++++------
 datasette/stored_queries.py       | 258 ++++++++++++++++++++----------
 datasette/views/database.py       |  56 +++----
 datasette/views/query_helpers.py  |  19 +--
 datasette/views/stored_queries.py |  37 +++--
 docs/internals.rst                |  14 +-
 tests/test_queries.py             | 128 +++++++--------
 7 files changed, 357 insertions(+), 257 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 96683895..56b89789 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -1029,8 +1029,8 @@ class Datasette:
         )
 
     @staticmethod
-    def _query_row_to_dict(row):
-        return stored_queries.query_row_to_dict(row)
+    def _query_row_to_stored_query(row) -> stored_queries.StoredQuery | None:
+        return stored_queries.query_row_to_stored_query(row)
 
     @staticmethod
     def _query_options_json(options):
@@ -1038,28 +1038,28 @@ class Datasette:
 
     async def add_query(
         self,
-        database,
-        name,
-        sql,
+        database: str,
+        name: str,
+        sql: str,
         *,
-        title=None,
-        description=None,
-        description_html=None,
-        hide_sql=False,
-        fragment=None,
-        parameters=None,
-        is_write=False,
-        is_private=False,
-        is_trusted=False,
-        source="plugin",
-        owner_id=None,
-        on_success_message=None,
-        on_success_message_sql=None,
-        on_success_redirect=None,
-        on_error_message=None,
-        on_error_redirect=None,
-        replace=True,
-    ):
+        title: str | None = None,
+        description: str | None = None,
+        description_html: str | None = None,
+        hide_sql: bool = False,
+        fragment: str | None = None,
+        parameters: Iterable[str] | None = None,
+        is_write: bool = False,
+        is_private: bool = False,
+        is_trusted: bool = False,
+        source: str = "plugin",
+        owner_id: str | None = None,
+        on_success_message: str | None = None,
+        on_success_message_sql: str | None = None,
+        on_success_redirect: str | None = None,
+        on_error_message: str | None = None,
+        on_error_redirect: str | None = None,
+        replace: bool = True,
+    ) -> None:
         return await stored_queries.add_query(
             self,
             database,
@@ -1086,8 +1086,8 @@ class Datasette:
 
     async def update_query(
         self,
-        database,
-        name,
+        database: str,
+        name: str,
         *,
         sql=stored_queries.UNCHANGED,
         title=stored_queries.UNCHANGED,
@@ -1106,7 +1106,7 @@ class Datasette:
         on_success_redirect=stored_queries.UNCHANGED,
         on_error_message=stored_queries.UNCHANGED,
         on_error_redirect=stored_queries.UNCHANGED,
-    ):
+    ) -> None:
         return await stored_queries.update_query(
             self,
             database,
@@ -1130,24 +1130,28 @@ class Datasette:
             on_error_redirect=on_error_redirect,
         )
 
-    async def remove_query(self, database, name, source=None):
+    async def remove_query(
+        self, database: str, name: str, source: str | None = None
+    ) -> None:
         return await stored_queries.remove_query(self, database, name, source=source)
 
-    async def get_query(self, database, name):
+    async def get_query(
+        self, database: str, name: str
+    ) -> stored_queries.StoredQuery | None:
         return await stored_queries.get_query(self, database, name)
 
     async def count_queries(
         self,
-        database=None,
+        database: str | None = None,
         *,
-        actor=None,
-        q=None,
-        is_write=None,
-        is_private=None,
-        is_trusted=None,
-        source=None,
-        owner_id=None,
-    ):
+        actor: dict[str, Any] | None = None,
+        q: str | None = None,
+        is_write: bool | None = None,
+        is_private: bool | None = None,
+        is_trusted: bool | None = None,
+        source: str | None = None,
+        owner_id: str | None = None,
+    ) -> int:
         return await stored_queries.count_queries(
             self,
             database,
@@ -1162,19 +1166,19 @@ class Datasette:
 
     async def list_queries(
         self,
-        database=None,
+        database: str | None = None,
         *,
-        actor=None,
-        limit=50,
-        cursor=None,
-        q=None,
-        is_write=None,
-        is_private=None,
-        is_trusted=None,
-        source=None,
-        owner_id=None,
-        include_private=False,
-    ):
+        actor: dict[str, Any] | None = None,
+        limit: int = 50,
+        cursor: str | None = None,
+        q: str | None = None,
+        is_write: bool | None = None,
+        is_private: bool | None = None,
+        is_trusted: bool | None = None,
+        source: str | None = None,
+        owner_id: str | None = None,
+        include_private: bool = False,
+    ) -> stored_queries.StoredQueryPage:
         return await stored_queries.list_queries(
             self,
             database,
diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index a28b71bf..bcfdfdb4 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -1,6 +1,8 @@
 from __future__ import annotations
 
+from dataclasses import dataclass
 import json
+from typing import Any, Iterable
 
 from .resources import TableResource
 from .utils import named_parameters, sqlite3, tilde_encode, urlsafe_components
@@ -19,7 +21,76 @@ QUERY_OPTION_FIELDS = (
 )
 
 
-async def save_queries_from_config(datasette):
+@dataclass
+class StoredQuery:
+    database: str
+    name: str
+    sql: str
+    title: str | None
+    description: str | None
+    description_html: str | None
+    hide_sql: bool
+    fragment: str | None
+    parameters: list[str]
+    is_write: bool
+    is_private: bool
+    is_trusted: bool
+    source: str
+    owner_id: str | None
+    on_success_message: str | None
+    on_success_message_sql: str | None
+    on_success_redirect: str | None
+    on_error_message: str | None
+    on_error_redirect: str | None
+    private: bool | None = None
+
+
+@dataclass
+class StoredQueryPage:
+    queries: list[StoredQuery]
+    next: str | None
+    has_more: bool
+    limit: int
+
+
+def stored_query_to_dict(query: StoredQuery) -> dict[str, Any]:
+    data = {
+        "database": query.database,
+        "name": query.name,
+        "sql": query.sql,
+        "title": query.title,
+        "description": query.description,
+        "description_html": query.description_html,
+        "hide_sql": query.hide_sql,
+        "fragment": query.fragment,
+        "params": list(query.parameters),
+        "parameters": list(query.parameters),
+        "is_write": query.is_write,
+        "is_private": query.is_private,
+        "is_trusted": query.is_trusted,
+        "source": query.source,
+        "owner_id": query.owner_id,
+        "on_success_message": query.on_success_message,
+        "on_success_message_sql": query.on_success_message_sql,
+        "on_success_redirect": query.on_success_redirect,
+        "on_error_message": query.on_error_message,
+        "on_error_redirect": query.on_error_redirect,
+    }
+    if query.private is not None:
+        data["private"] = query.private
+    return data
+
+
+def stored_query_page_to_dict(page: StoredQueryPage) -> dict[str, Any]:
+    return {
+        "queries": [stored_query_to_dict(query) for query in page.queries],
+        "next": page.next,
+        "has_more": page.has_more,
+        "limit": page.limit,
+    }
+
+
+async def save_queries_from_config(datasette: Any) -> None:
     # Apply configured query entries from datasette.yaml to the internal table.
     await datasette.get_internal_database().execute_write(
         "DELETE FROM queries WHERE source = 'config'"
@@ -50,36 +121,38 @@ async def save_queries_from_config(datasette):
             )
 
 
-def query_row_to_dict(row):
+def query_row_to_stored_query(
+    row: Any, private: bool | None = None
+) -> StoredQuery | None:
     if row is None:
         return None
     parameters = json.loads(row["parameters"] or "[]")
     options = json.loads(row["options"] or "{}")
-    return {
-        "database": row["database_name"],
-        "name": row["name"],
-        "sql": row["sql"],
-        "title": row["title"],
-        "description": row["description"],
-        "description_html": row["description_html"],
-        "hide_sql": bool(options.get("hide_sql")),
-        "fragment": options.get("fragment"),
-        "params": parameters,
-        "parameters": parameters,
-        "is_write": bool(row["is_write"]),
-        "is_private": bool(row["is_private"]),
-        "is_trusted": bool(row["is_trusted"]),
-        "source": row["source"],
-        "owner_id": row["owner_id"],
-        "on_success_message": options.get("on_success_message"),
-        "on_success_message_sql": options.get("on_success_message_sql"),
-        "on_success_redirect": options.get("on_success_redirect"),
-        "on_error_message": options.get("on_error_message"),
-        "on_error_redirect": options.get("on_error_redirect"),
-    }
+    return StoredQuery(
+        database=row["database_name"],
+        name=row["name"],
+        sql=row["sql"],
+        title=row["title"],
+        description=row["description"],
+        description_html=row["description_html"],
+        hide_sql=bool(options.get("hide_sql")),
+        fragment=options.get("fragment"),
+        parameters=parameters,
+        is_write=bool(row["is_write"]),
+        is_private=bool(row["is_private"]),
+        is_trusted=bool(row["is_trusted"]),
+        source=row["source"],
+        owner_id=row["owner_id"],
+        on_success_message=options.get("on_success_message"),
+        on_success_message_sql=options.get("on_success_message_sql"),
+        on_success_redirect=options.get("on_success_redirect"),
+        on_error_message=options.get("on_error_message"),
+        on_error_redirect=options.get("on_error_redirect"),
+        private=private,
+    )
 
 
-def query_options_json(options):
+def query_options_json(options: dict[str, Any]) -> str:
     options_dict = {}
     for field in QUERY_OPTION_FIELDS:
         value = options.get(field)
@@ -92,29 +165,29 @@ def query_options_json(options):
 
 
 async def add_query(
-    datasette,
-    database,
-    name,
-    sql,
+    datasette: Any,
+    database: str,
+    name: str,
+    sql: str,
     *,
-    title=None,
-    description=None,
-    description_html=None,
-    hide_sql=False,
-    fragment=None,
-    parameters=None,
-    is_write=False,
-    is_private=False,
-    is_trusted=False,
-    source="plugin",
-    owner_id=None,
-    on_success_message=None,
-    on_success_message_sql=None,
-    on_success_redirect=None,
-    on_error_message=None,
-    on_error_redirect=None,
-    replace=True,
-):
+    title: str | None = None,
+    description: str | None = None,
+    description_html: str | None = None,
+    hide_sql: bool = False,
+    fragment: str | None = None,
+    parameters: Iterable[str] | None = None,
+    is_write: bool = False,
+    is_private: bool = False,
+    is_trusted: bool = False,
+    source: str = "plugin",
+    owner_id: str | None = None,
+    on_success_message: str | None = None,
+    on_success_message_sql: str | None = None,
+    on_success_redirect: str | None = None,
+    on_error_message: str | None = None,
+    on_error_redirect: str | None = None,
+    replace: bool = True,
+) -> None:
     parameters_json = json.dumps(list(parameters or []))
     options_json = query_options_json(
         {
@@ -170,9 +243,9 @@ async def add_query(
 
 
 async def update_query(
-    datasette,
-    database,
-    name,
+    datasette: Any,
+    database: str,
+    name: str,
     *,
     sql=UNCHANGED,
     title=UNCHANGED,
@@ -191,7 +264,7 @@ async def update_query(
     on_success_redirect=UNCHANGED,
     on_error_message=UNCHANGED,
     on_error_redirect=UNCHANGED,
-):
+) -> None:
     fields = {
         "sql": sql,
         "title": title,
@@ -263,7 +336,9 @@ async def update_query(
     )
 
 
-async def remove_query(datasette, database, name, source=None):
+async def remove_query(
+    datasette: Any, database: str, name: str, source: str | None = None
+) -> None:
     sql = "DELETE FROM queries WHERE database_name = ? AND name = ?"
     params = [database, name]
     if source is not None:
@@ -272,7 +347,7 @@ async def remove_query(datasette, database, name, source=None):
     await datasette.get_internal_database().execute_write(sql, params)
 
 
-async def get_query(datasette, database, name):
+async def get_query(datasette: Any, database: str, name: str) -> StoredQuery | None:
     rows = await datasette.get_internal_database().execute(
         """
         SELECT * FROM queries
@@ -280,21 +355,21 @@ async def get_query(datasette, database, name):
         """,
         [database, name],
     )
-    return query_row_to_dict(rows.first())
+    return query_row_to_stored_query(rows.first())
 
 
 async def count_queries(
-    datasette,
-    database=None,
+    datasette: Any,
+    database: str | None = None,
     *,
-    actor=None,
-    q=None,
-    is_write=None,
-    is_private=None,
-    is_trusted=None,
-    source=None,
-    owner_id=None,
-):
+    actor: dict[str, Any] | None = None,
+    q: str | None = None,
+    is_write: bool | None = None,
+    is_private: bool | None = None,
+    is_trusted: bool | None = None,
+    source: str | None = None,
+    owner_id: str | None = None,
+) -> int:
     allowed_sql, allowed_params = await datasette.allowed_resources_sql(
         action="view-query",
         actor=actor,
@@ -354,20 +429,20 @@ async def count_queries(
 
 
 async def list_queries(
-    datasette,
-    database=None,
+    datasette: Any,
+    database: str | None = None,
     *,
-    actor=None,
-    limit=50,
-    cursor=None,
-    q=None,
-    is_write=None,
-    is_private=None,
-    is_trusted=None,
-    source=None,
-    owner_id=None,
-    include_private=False,
-):
+    actor: dict[str, Any] | None = None,
+    limit: int = 50,
+    cursor: str | None = None,
+    q: str | None = None,
+    is_write: bool | None = None,
+    is_private: bool | None = None,
+    is_trusted: bool | None = None,
+    source: str | None = None,
+    owner_id: str | None = None,
+    include_private: bool = False,
+) -> StoredQueryPage:
     limit = min(max(1, int(limit)), 1000)
     allowed_sql, allowed_params = await datasette.allowed_resources_sql(
         action="view-query",
@@ -480,9 +555,10 @@ async def list_queries(
 
     queries = []
     for row in rows:
-        query = query_row_to_dict(row)
-        if include_private:
-            query["private"] = bool(row["private"])
+        query = query_row_to_stored_query(
+            row, private=bool(row["private"]) if include_private else None
+        )
+        assert query is not None
         queries.append(query)
 
     next_token = None
@@ -499,17 +575,23 @@ async def list_queries(
                 tilde_encode(last_row["sort_key"]),
                 tilde_encode(last_row["name"]),
             )
-    return {
-        "queries": queries,
-        "next": next_token,
-        "has_more": has_more,
-        "limit": limit,
-    }
+    return StoredQueryPage(
+        queries=queries,
+        next=next_token,
+        has_more=has_more,
+        limit=limit,
+    )
 
 
 async def ensure_query_write_permissions(
-    datasette, database, sql, *, actor=None, params=None, analysis=None
-):
+    datasette: Any,
+    database: str,
+    sql: str,
+    *,
+    actor: dict[str, Any] | None = None,
+    params: dict[str, Any] | None = None,
+    analysis: Any = None,
+) -> Any:
     write_actions = {
         "insert": "insert-row",
         "update": "update-row",
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 98ca989c..b558b002 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -13,6 +13,7 @@ import textwrap
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.database import QueryInterrupted
 from datasette.resources import DatabaseResource, QueryResource
+from datasette.stored_queries import stored_query_to_dict
 from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
@@ -99,8 +100,8 @@ class DatabaseView(View):
             limit=5,
             include_private=True,
         )
-        stored_queries = queries_page["queries"]
-        queries_more = queries_page["has_more"]
+        stored_queries = queries_page.queries
+        queries_more = queries_page.has_more
         queries_count = (
             await datasette.count_queries(database, actor=request.actor)
             if queries_more
@@ -136,7 +137,7 @@ class DatabaseView(View):
             "tables": tables,
             "hidden_count": len([t for t in tables if t["hidden"]]),
             "views": sql_views,
-            "queries": stored_queries,
+            "queries": [stored_query_to_dict(query) for query in stored_queries],
             "queries_more": queries_more,
             "queries_count": queries_count,
             "allow_execute_sql": allow_execute_sql,
@@ -447,7 +448,7 @@ class QueryView(View):
 
         if not await datasette.allowed(
             action="view-query",
-            resource=QueryResource(database=db.name, query=stored_query["name"]),
+            resource=QueryResource(database=db.name, query=stored_query.name),
             actor=request.actor,
         ):
             raise Forbidden("You do not have permission to view this query")
@@ -480,20 +481,18 @@ class QueryView(View):
             or request.args.get("_json")
             or params.get("_json")
         )
-        params_for_query = MagicParameters(
-            stored_query["sql"], params, request, datasette
-        )
+        params_for_query = MagicParameters(stored_query.sql, params, request, datasette)
         await params_for_query.execute_params()
         ok = None
         redirect_url = None
         try:
             cursor = await db.execute_write(
-                stored_query["sql"], params_for_query, request=request
+                stored_query.sql, params_for_query, request=request
             )
             # success message can come from on_success_message or on_success_message_sql
             message = None
             message_type = datasette.INFO
-            on_success_message_sql = stored_query.get("on_success_message_sql")
+            on_success_message_sql = stored_query.on_success_message_sql
             if on_success_message_sql:
                 try:
                     message_result = (
@@ -505,18 +504,19 @@ class QueryView(View):
                     message = "Error running on_success_message_sql: {}".format(ex)
                     message_type = datasette.ERROR
             if not message:
-                message = stored_query.get(
-                    "on_success_message"
-                ) or "Query executed, {} row{} affected".format(
-                    cursor.rowcount, "" if cursor.rowcount == 1 else "s"
+                message = (
+                    stored_query.on_success_message
+                    or "Query executed, {} row{} affected".format(
+                        cursor.rowcount, "" if cursor.rowcount == 1 else "s"
+                    )
                 )
 
-            redirect_url = stored_query.get("on_success_redirect")
+            redirect_url = stored_query.on_success_redirect
             ok = True
         except Exception as ex:
-            message = stored_query.get("on_error_message") or str(ex)
+            message = stored_query.on_error_message or str(ex)
             message_type = datasette.ERROR
-            redirect_url = stored_query.get("on_error_redirect")
+            redirect_url = stored_query.on_error_redirect
             ok = False
         if should_return_json:
             return Response.json(
@@ -562,7 +562,7 @@ class QueryView(View):
                 )
                 if stored_query is None:
                     raise
-                stored_query_write = bool(stored_query.get("is_write"))
+                stored_query_write = stored_query.is_write
 
         private = False
         if stored_query:
@@ -570,7 +570,7 @@ class QueryView(View):
             visible, private = await datasette.check_visibility(
                 request.actor,
                 action="view-query",
-                resource=QueryResource(database=database, query=stored_query["name"]),
+                resource=QueryResource(database=database, query=stored_query.name),
             )
             if not visible:
                 raise Forbidden("You do not have permission to view this query")
@@ -591,14 +591,14 @@ class QueryView(View):
         sql = None
 
         if stored_query:
-            sql = stored_query["sql"]
+            sql = stored_query.sql
         elif "sql" in params:
             sql = params.pop("sql")
 
         # Extract any :named parameters
         named_parameters = []
-        if stored_query and stored_query.get("params"):
-            named_parameters = stored_query["params"]
+        if stored_query and stored_query.parameters:
+            named_parameters = stored_query.parameters
         if not named_parameters and sql:
             named_parameters = derive_named_parameters(sql)
         named_parameter_values = {
@@ -686,7 +686,7 @@ class QueryView(View):
                 columns=columns,
                 rows=rows,
                 sql=sql,
-                query_name=stored_query["name"] if stored_query else None,
+                query_name=stored_query.name if stored_query else None,
                 database=database,
                 table=None,
                 request=request,
@@ -721,7 +721,7 @@ class QueryView(View):
             if stored_query:
                 templates.insert(
                     0,
-                    f"query-{to_css_class(database)}-{to_css_class(stored_query['name'])}.html",
+                    f"query-{to_css_class(database)}-{to_css_class(stored_query.name)}.html",
                 )
 
             environment = datasette.get_jinja_environment(request)
@@ -740,7 +740,7 @@ class QueryView(View):
             )
             metadata = await datasette.get_database_metadata(database)
             if stored_query:
-                metadata = dict(stored_query)
+                metadata = stored_query_to_dict(stored_query)
                 metadata.pop("source", None)
 
             renderers = {}
@@ -775,7 +775,7 @@ class QueryView(View):
             )
 
             show_hide_hidden = ""
-            if stored_query and stored_query.get("hide_sql"):
+            if stored_query and stored_query.hide_sql:
                 if bool(params.get("_show_sql")):
                     show_hide_link = path_with_removed_args(request, {"_show_sql"})
                     show_hide_text = "hide"
@@ -843,7 +843,7 @@ class QueryView(View):
                     datasette=datasette,
                     actor=request.actor,
                     database=database,
-                    query_name=stored_query["name"] if stored_query else None,
+                    query_name=stored_query.name if stored_query else None,
                     request=request,
                     sql=sql,
                     params=params,
@@ -863,7 +863,7 @@ class QueryView(View):
                             "sql": sql,
                             "params": params,
                         },
-                        stored_query=stored_query["name"] if stored_query else None,
+                        stored_query=stored_query.name if stored_query else None,
                         private=private,
                         stored_query_write=stored_query_write,
                         db_is_immutable=not db.is_mutable,
@@ -907,7 +907,7 @@ class QueryView(View):
                             datasette,
                             request,
                             database=database,
-                            query_name=stored_query["name"] if stored_query else None,
+                            query_name=stored_query.name if stored_query else None,
                         ),
                         query_actions=query_actions,
                     ),
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index de732431..46d71b8e 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -2,6 +2,7 @@ import json
 import re
 
 from datasette.resources import DatabaseResource, TableResource
+from datasette.stored_queries import StoredQuery
 from datasette.utils import (
     named_parameters as derive_named_parameters,
     escape_sqlite,
@@ -281,18 +282,18 @@ async def _prepare_execute_write(datasette, db, sql, params, actor):
     return parameter_names, params, analysis
 
 
-async def _ensure_stored_query_execution_permissions(datasette, db, query, actor):
-    if query.get("is_trusted"):
+async def _ensure_stored_query_execution_permissions(
+    datasette, db, query: StoredQuery, actor
+):
+    if query.is_trusted:
         return
-    if query.get("is_write"):
+    if query.is_write:
         await datasette.ensure_permission(
             action="execute-write-sql",
             resource=DatabaseResource(db.name),
             actor=actor,
         )
-        await datasette.ensure_query_write_permissions(
-            db.name, query["sql"], actor=actor
-        )
+        await datasette.ensure_query_write_permissions(db.name, query.sql, actor=actor)
     else:
         await datasette.ensure_permission(
             action="execute-sql",
@@ -482,7 +483,7 @@ async def _prepare_query_create(datasette, request, db, data):
     }
 
 
-async def _prepare_query_update(datasette, request, db, existing, update):
+async def _prepare_query_update(datasette, request, db, existing: StoredQuery, update):
     invalid_keys = set(update) - _query_update_fields
     if invalid_keys:
         raise QueryValidationError(
@@ -490,8 +491,8 @@ async def _prepare_query_update(datasette, request, db, existing, update):
         )
 
     update = _apply_query_data_types(update)
-    sql = update.get("sql", existing["sql"])
-    query_is_write = existing["is_write"]
+    sql = update.get("sql", existing.sql)
+    query_is_write = existing.is_write
     derived = _derived_query_parameters(sql)
     parameters = None
 
diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
index 1a2c5d00..8c4e849e 100644
--- a/datasette/views/stored_queries.py
+++ b/datasette/views/stored_queries.py
@@ -1,6 +1,7 @@
 from urllib.parse import parse_qsl, urlencode
 
 from datasette.resources import DatabaseResource, QueryResource
+from datasette.stored_queries import stored_query_to_dict
 from datasette.utils import sqlite3, tilde_decode
 from datasette.utils.asgi import Response
 
@@ -100,7 +101,7 @@ class QueryListView(BaseView):
         )
         query_list_path = self.query_list_path(database)
         next_url = None
-        if page["next"]:
+        if page.next:
             pairs = [
                 (key, value)
                 for key, value in parse_qsl(
@@ -108,7 +109,7 @@ class QueryListView(BaseView):
                 )
                 if key != "_next"
             ]
-            pairs.append(("_next", page["next"]))
+            pairs.append(("_next", page.next))
             next_url = "{}?{}".format(
                 query_list_path,
                 urlencode(pairs),
@@ -194,13 +195,13 @@ class QueryListView(BaseView):
             "database_color": (
                 self.ds.get_database(database).color if database is not None else None
             ),
-            "queries": page["queries"],
-            "next": page["next"],
+            "queries": page.queries,
+            "next": page.next,
             "next_url": next_url,
-            "has_more": page["has_more"],
-            "limit": page["limit"],
-            "show_private_note": any(query["is_private"] for query in page["queries"]),
-            "show_trusted_note": any(query["is_trusted"] for query in page["queries"]),
+            "has_more": page.has_more,
+            "limit": page.limit,
+            "show_private_note": any(query.is_private for query in page.queries),
+            "show_trusted_note": any(query.is_trusted for query in page.queries),
             "query_list_path": query_list_path,
             "show_database": database is None,
             "facets": facets,
@@ -213,7 +214,12 @@ class QueryListView(BaseView):
             },
         }
         if format_ == "json":
-            return Response.json(data)
+            return Response.json(
+                {
+                    **data,
+                    "queries": [stored_query_to_dict(query) for query in page.queries],
+                }
+            )
         return await self.render(
             ["query_list.html"],
             request,
@@ -374,8 +380,11 @@ class QueryStoreView(QueryCreateView):
             return _error([str(ex)], 400)
 
         query = await self.ds.get_query(db.name, name)
+        assert query is not None
         if is_json:
-            return Response.json({"ok": True, "query": query}, status=201)
+            return Response.json(
+                {"ok": True, "query": stored_query_to_dict(query)}, status=201
+            )
         self.ds.add_message(request, "Query saved", self.ds.INFO)
         return Response.redirect(self.ds.urls.path(self.ds.urls.table(db.name, name)))
 
@@ -395,7 +404,7 @@ class QueryDefinitionView(BaseView):
             actor=request.actor,
         ):
             return _error(["Permission denied"], 403)
-        return Response.json({"ok": True, "query": query})
+        return Response.json({"ok": True, "query": stored_query_to_dict(query)})
 
 
 class QueryUpdateView(BaseView):
@@ -413,7 +422,7 @@ class QueryUpdateView(BaseView):
             actor=request.actor,
         ):
             return _error(["Permission denied: need update-query"], 403)
-        if existing.get("is_trusted"):
+        if existing.is_trusted:
             return _error(["Trusted queries cannot be updated using the API"], 403)
 
         try:
@@ -444,10 +453,12 @@ class QueryUpdateView(BaseView):
 
         await self.ds.update_query(db.name, query_name, **update_kwargs)
         if data.get("return"):
+            query = await self.ds.get_query(db.name, query_name)
+            assert query is not None
             return Response.json(
                 {
                     "ok": True,
-                    "query": await self.ds.get_query(db.name, query_name),
+                    "query": stored_query_to_dict(query),
                 }
             )
         return Response.json({"ok": True})
diff --git a/docs/internals.rst b/docs/internals.rst
index 66724aa9..4980ee8b 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -1039,11 +1039,11 @@ Example:
 await .get_query(database, name)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-Returns a stored query dictionary, or ``None`` if the query does not exist.
+Returns a ``StoredQuery`` dataclass instance, or ``None`` if the query does not exist.
 
-The dictionary contains ``database``, ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``params``, ``is_write``, ``is_private``, ``is_trusted``, ``source``, ``owner_id``, ``on_success_message``, ``on_success_message_sql``, ``on_success_redirect``, ``on_error_message`` and ``on_error_redirect``.
+``StoredQuery`` has the following attributes: ``database``, ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``is_write``, ``is_private``, ``is_trusted``, ``source``, ``owner_id``, ``on_success_message``, ``on_success_message_sql``, ``on_success_redirect``, ``on_error_message`` and ``on_error_redirect``.
 
-``parameters`` and ``params`` contain the same list of explicit parameter names.
+``parameters`` is a list of explicit parameter names.
 
 .. _datasette_list_queries:
 
@@ -1087,12 +1087,12 @@ Lists stored queries visible to the specified actor.
 ``owner_id`` - string, optional
     Filter by owner actor ID.
 ``include_private`` - boolean, optional
-    Set to ``True`` to include a ``private`` boolean in each returned query dictionary indicating if anonymous users would be unable to view that query.
+    Set to ``True`` to populate a ``private`` boolean on each returned ``StoredQuery`` indicating if anonymous users would be unable to view that query.
 
-The return value is a dictionary with these keys:
+The return value is a ``StoredQueryPage`` dataclass instance with these attributes:
 
-``queries`` - list of dictionaries
-    Stored query dictionaries, in the same format returned by :ref:`datasette_get_query`.
+``queries`` - list of StoredQuery instances
+    Stored queries in the same format returned by :ref:`datasette_get_query`.
 ``next`` - string or None
     Pagination cursor for the next page, if one exists.
 ``has_more`` - boolean
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 70fb7a03..59fab8c0 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -4,6 +4,7 @@ import pytest
 
 from datasette.app import Datasette
 from datasette.resources import DatabaseResource, QueryResource
+from datasette.stored_queries import StoredQuery, StoredQueryPage
 from datasette.utils.asgi import Forbidden
 
 
@@ -87,38 +88,41 @@ async def test_add_get_and_remove_query():
     }
 
     query = await ds.get_query("data", "top_customers")
-    assert query == {
-        "database": "data",
-        "name": "top_customers",
-        "sql": "select * from customers where region = :region",
-        "title": "Top customers",
-        "description": "Customers by region",
-        "description_html": None,
-        "hide_sql": True,
-        "fragment": "chart",
-        "params": ["region"],
-        "parameters": ["region"],
-        "is_write": False,
-        "is_private": False,
-        "is_trusted": True,
-        "source": "user",
-        "owner_id": "alice",
-        "on_success_message": None,
-        "on_success_message_sql": None,
-        "on_success_redirect": None,
-        "on_error_message": None,
-        "on_error_redirect": None,
-    }
+    assert query == StoredQuery(
+        database="data",
+        name="top_customers",
+        sql="select * from customers where region = :region",
+        title="Top customers",
+        description="Customers by region",
+        description_html=None,
+        hide_sql=True,
+        fragment="chart",
+        parameters=["region"],
+        is_write=False,
+        is_private=False,
+        is_trusted=True,
+        source="user",
+        owner_id="alice",
+        on_success_message=None,
+        on_success_message_sql=None,
+        on_success_redirect=None,
+        on_error_message=None,
+        on_error_redirect=None,
+    )
 
     queries_page = await ds.list_queries("data", actor=None)
-    assert queries_page["queries"] == [query]
-    assert queries_page["next"] is None
+    assert queries_page == StoredQueryPage(
+        queries=[query],
+        next=None,
+        has_more=False,
+        limit=50,
+    )
 
     await ds.remove_query("data", "top_customers")
     assert await ds.get_query("data", "top_customers") is None
     queries_page = await ds.list_queries("data", actor=None)
-    assert queries_page["queries"] == []
-    assert queries_page["next"] is None
+    assert queries_page.queries == []
+    assert queries_page.next is None
 
 
 @pytest.mark.asyncio
@@ -156,13 +160,12 @@ async def test_update_query_only_updates_provided_fields():
     )
 
     query = await ds.get_query("data", "redirect")
-    assert query["title"] == "Updated"
-    assert query["parameters"] == []
-    assert query["params"] == []
-    assert query["on_success_redirect"] is None
-    assert query["sql"] == "select 1"
-    assert query["is_private"] is False
-    assert query["is_trusted"] is False
+    assert query.title == "Updated"
+    assert query.parameters == []
+    assert query.on_success_redirect is None
+    assert query.sql == "select 1"
+    assert query.is_private is False
+    assert query.is_trusted is False
     options_row = (
         await ds.get_internal_database().execute(
             """
@@ -198,28 +201,27 @@ async def test_config_queries_imported_to_internal_table():
     ds.add_memory_database("query_config", name="data")
     await ds.invoke_startup()
 
-    assert await ds.get_query("data", "configured") == {
-        "database": "data",
-        "name": "configured",
-        "sql": "select :name as name",
-        "title": "Configured query",
-        "description": None,
-        "description_html": "<p>Configured HTML</p>",
-        "hide_sql": False,
-        "fragment": None,
-        "params": ["name"],
-        "parameters": ["name"],
-        "is_write": False,
-        "is_private": False,
-        "is_trusted": True,
-        "source": "config",
-        "owner_id": None,
-        "on_success_message": None,
-        "on_success_message_sql": "select 'Hello ' || :name",
-        "on_success_redirect": None,
-        "on_error_message": None,
-        "on_error_redirect": None,
-    }
+    assert await ds.get_query("data", "configured") == StoredQuery(
+        database="data",
+        name="configured",
+        sql="select :name as name",
+        title="Configured query",
+        description=None,
+        description_html="<p>Configured HTML</p>",
+        hide_sql=False,
+        fragment=None,
+        parameters=["name"],
+        is_write=False,
+        is_private=False,
+        is_trusted=True,
+        source="config",
+        owner_id=None,
+        on_success_message=None,
+        on_success_message_sql="select 'Hello ' || :name",
+        on_success_redirect=None,
+        on_error_message=None,
+        on_error_redirect=None,
+    )
 
 
 @pytest.mark.asyncio
@@ -1032,8 +1034,8 @@ async def test_query_update_api_rejects_config_only_fields():
         "Invalid keys: description_html, on_success_message_sql"
     ]
     query = await ds.get_query("data", "editable")
-    assert query["description_html"] is None
-    assert query["on_success_message_sql"] is None
+    assert query.description_html is None
+    assert query.on_success_message_sql is None
 
 
 @pytest.mark.asyncio
@@ -1072,9 +1074,9 @@ async def test_query_update_api_rejects_trusted_queries_but_internal_update_allo
         "Trusted queries cannot be updated using the API"
     ]
     query = await ds.get_query("data", "trusted_report")
-    assert query["is_trusted"] is True
-    assert query["sql"] == "select 1 as one"
-    assert query["title"] == "Original"
+    assert query.is_trusted is True
+    assert query.sql == "select 1 as one"
+    assert query.title == "Original"
 
     await ds.update_query(
         "data",
@@ -1083,9 +1085,9 @@ async def test_query_update_api_rejects_trusted_queries_but_internal_update_allo
         title="Internal",
     )
     query = await ds.get_query("data", "trusted_report")
-    assert query["is_trusted"] is True
-    assert query["sql"] == "select 3 as three"
-    assert query["title"] == "Internal"
+    assert query.is_trusted is True
+    assert query.sql == "select 3 as three"
+    assert query.title == "Internal"
 
 
 @pytest.mark.asyncio

From 9f66cf72c1c9170f10e863d750ac4eee47113a7f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 21:42:50 -0700
Subject: [PATCH 110/386] Removed execute write SQL from query create page

---
 datasette/templates/query_create.html | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index f5dadbff..ec910456 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -106,9 +106,6 @@ form.sql .query-create-sql textarea#sql-editor {
 .query-create-analysis-note {
     margin: 0;
 }
-.query-create-action {
-    margin: 0.35rem 0 1rem;
-}
 .query-create-analysis {
     margin-top: 0.8rem;
 }
@@ -171,10 +168,6 @@ form.sql .query-create-sql textarea#sql-editor {
         <label><input type="checkbox" name="is_private" value="1"{% if is_private %} checked{% endif %}> Private</label>
         <span class="query-create-option-note">Queries marked private can only be seen by you, their creator.</span>
     </p>
-    {% if sql and analysis_is_write %}
-        <p class="query-create-action"><a href="{{ urls.database(database) }}/-/execute-write?{{ {'sql': sql}|urlencode|safe }}">Execute write SQL</a></p>
-    {% endif %}
-
     <p class="query-create-submit"><input type="submit" value="Save query" data-query-create-submit{% if save_disabled %} disabled{% endif %}></p>
 
     <div class="query-create-analysis" id="query-create-analysis-section"{% if not has_sql %} hidden{% endif %}>

From 737ff03efbb2bdc99b10d2654b7818526ec51e13 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 26 May 2026 22:11:06 -0700
Subject: [PATCH 111/386] Expanded analysis of SQL operations, refs #2748

---
 datasette/permissions.py         |  10 ++
 datasette/stored_queries.py      | 137 +++++++++++++--
 datasette/utils/sql_analysis.py  | 289 +++++++++++++++++++++++++++----
 datasette/views/execute_write.py |   9 +-
 datasette/views/query_helpers.py | 104 +++++++----
 tests/test_actions_sql.py        |  14 +-
 tests/test_internals_database.py |  34 ++--
 tests/test_queries.py            | 166 ++++++++++++++++++
 tests/test_utils_sql_analysis.py |  97 +++++++++--
 9 files changed, 740 insertions(+), 120 deletions(-)

diff --git a/datasette/permissions.py b/datasette/permissions.py
index 917c58ab..a9a3cc7c 100644
--- a/datasette/permissions.py
+++ b/datasette/permissions.py
@@ -58,6 +58,16 @@ class Resource(ABC):
         self.child = child
         self._private = None  # Sentinel to track if private was set
 
+    def __str__(self) -> str:
+        return "/".join(
+            str(part) for part in (self.parent, self.child) if part is not None
+        )
+
+    def __repr__(self) -> str:
+        return "{}(parent={!r}, child={!r})".format(
+            self.__class__.__name__, self.parent, self.child
+        )
+
     @property
     def private(self) -> bool:
         """
diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index bcfdfdb4..c4b083e5 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -2,11 +2,16 @@ from __future__ import annotations
 
 from dataclasses import dataclass
 import json
-from typing import Any, Iterable
+from typing import Any, Iterable, TYPE_CHECKING
 
-from .resources import TableResource
+from .resources import DatabaseResource, TableResource
+from .permissions import Resource
 from .utils import named_parameters, sqlite3, tilde_encode, urlsafe_components
 from .utils.asgi import Forbidden
+from .utils.sql_analysis import Operation, SQLAnalysis
+
+if TYPE_CHECKING:
+    from .app import Datasette
 
 UNCHANGED = object()
 
@@ -583,20 +588,94 @@ async def list_queries(
     )
 
 
-async def ensure_query_write_permissions(
-    datasette: Any,
-    database: str,
-    sql: str,
-    *,
-    actor: dict[str, Any] | None = None,
-    params: dict[str, Any] | None = None,
-    analysis: Any = None,
-) -> Any:
+PermissionRequirement = tuple[str, Resource]
+
+
+def permission_for_operation(operation: Operation) -> PermissionRequirement | None:
     write_actions = {
         "insert": "insert-row",
         "update": "update-row",
         "delete": "delete-row",
     }
+    action = write_actions.get(operation.operation)
+    if (
+        action
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return (
+            action,
+            TableResource(database=operation.database, table=operation.table),
+        )
+    if operation.operation == "create" and operation.target_type == "table":
+        if operation.database is None:
+            return None
+        return (
+            "create-table",
+            DatabaseResource(database=operation.database),
+        )
+    if (
+        operation.operation == "alter"
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return (
+            "alter-table",
+            TableResource(database=operation.database, table=operation.table),
+        )
+    if (
+        operation.operation == "drop"
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return (
+            "drop-table",
+            TableResource(database=operation.database, table=operation.table),
+        )
+    if (
+        operation.operation in {"create", "drop"}
+        and operation.target_type == "index"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return (
+            "alter-table",
+            TableResource(database=operation.database, table=operation.table),
+        )
+    return None
+
+
+def operation_is_write(operation: Operation) -> bool:
+    return operation.operation in {
+        "insert",
+        "update",
+        "delete",
+        "create",
+        "alter",
+        "drop",
+        "begin",
+        "commit",
+        "rollback",
+        "attach",
+        "detach",
+        "pragma",
+        "analyze",
+        "reindex",
+    }
+
+
+async def ensure_query_write_permissions(
+    datasette: Datasette,
+    database: str,
+    sql: str,
+    *,
+    actor: dict[str, object] | None = None,
+    params: dict[str, object] | None = None,
+    analysis: SQLAnalysis | None = None,
+) -> SQLAnalysis:
     db = datasette.get_database(database)
     if analysis is None:
         if params is None:
@@ -606,18 +685,38 @@ async def ensure_query_write_permissions(
         except sqlite3.DatabaseError as ex:
             raise Forbidden(f"Could not analyze query: {ex}") from ex
 
-    for access in analysis.table_accesses:
-        action = write_actions.get(access.operation)
-        if action is None:
+    has_semantic_schema_operation = any(
+        operation.operation in {"create", "alter", "drop"}
+        and operation.target_type in {"table", "index", "view", "trigger"}
+        for operation in analysis.operations
+    )
+    for operation in analysis.operations:
+        if operation.internal and has_semantic_schema_operation:
             continue
-        if access.database != database:
+        if has_semantic_schema_operation and operation.operation in {
+            "read",
+            "insert",
+            "update",
+            "delete",
+            "reindex",
+        }:
+            continue
+        permission = permission_for_operation(operation)
+        if permission is None:
+            if operation_is_write(operation):
+                raise Forbidden(
+                    "Unsupported SQL operation: {} {}".format(
+                        operation.operation, operation.target_type
+                    )
+                )
+            continue
+        action, resource = permission
+        if operation.database != database:
             raise Forbidden("Writable queries may not write to attached databases")
         if not await datasette.allowed(
             action=action,
-            resource=TableResource(database=access.database, table=access.table),
+            resource=resource,
             actor=actor,
         ):
-            raise Forbidden(
-                f"Permission denied: need {action} on {access.database}/{access.table}"
-            )
+            raise Forbidden(f"Permission denied: need {action} on {resource}")
     return analysis
diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index b5317b62..54f310fe 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -3,22 +3,66 @@ from typing import Literal
 
 from datasette.utils.sqlite import sqlite3
 
+SQLOperation = Literal[
+    "read",
+    "insert",
+    "update",
+    "delete",
+    "create",
+    "alter",
+    "drop",
+    "begin",
+    "commit",
+    "rollback",
+    "attach",
+    "detach",
+    "pragma",
+    "analyze",
+    "reindex",
+]
+SQLTargetType = Literal[
+    "table",
+    "index",
+    "view",
+    "trigger",
+    "schema",
+    "transaction",
+    "database",
+    "pragma",
+    "unknown",
+]
 SQLTableOperation = Literal["read", "insert", "update", "delete"]
 
 
 @dataclass(frozen=True)
-class SQLTableAccess:
-    operation: SQLTableOperation
+class Operation:
+    operation: SQLOperation
+    target_type: SQLTargetType
     database: str | None
-    table: str
+    table: str | None
     sqlite_schema: str | None
+    target: str | None = None
     columns: tuple[str, ...] = ()
     source: str | None = None
+    internal: bool = False
 
 
 @dataclass(frozen=True)
 class SQLAnalysis:
-    table_accesses: tuple[SQLTableAccess, ...]
+    operations: tuple[Operation, ...]
+
+
+# Hashable dict key for grouping repeated authorizer callbacks while collecting columns.
+@dataclass(frozen=True)
+class OperationKey:
+    operation: SQLOperation
+    target_type: SQLTargetType
+    database: str | None
+    table: str | None
+    sqlite_schema: str | None
+    target: str | None
+    source: str | None
+    internal: bool
 
 
 _ACTION_TO_OPERATION: dict[int, SQLTableOperation] = {
@@ -28,6 +72,36 @@ _ACTION_TO_OPERATION: dict[int, SQLTableOperation] = {
     sqlite3.SQLITE_DELETE: "delete",
 }
 
+# Values are (operation, target_type) pairs used to construct Operation objects.
+_CREATE_ACTIONS = {
+    sqlite3.SQLITE_CREATE_INDEX: ("create", "index"),
+    sqlite3.SQLITE_CREATE_TABLE: ("create", "table"),
+    sqlite3.SQLITE_CREATE_TRIGGER: ("create", "trigger"),
+    sqlite3.SQLITE_CREATE_VIEW: ("create", "view"),
+}
+_DROP_ACTIONS = {
+    sqlite3.SQLITE_DROP_INDEX: ("drop", "index"),
+    sqlite3.SQLITE_DROP_TABLE: ("drop", "table"),
+    sqlite3.SQLITE_DROP_TRIGGER: ("drop", "trigger"),
+    sqlite3.SQLITE_DROP_VIEW: ("drop", "view"),
+}
+for action_name, operation, target_type in (
+    ("SQLITE_CREATE_TEMP_INDEX", "create", "index"),
+    ("SQLITE_CREATE_TEMP_TABLE", "create", "table"),
+    ("SQLITE_CREATE_TEMP_TRIGGER", "create", "trigger"),
+    ("SQLITE_CREATE_TEMP_VIEW", "create", "view"),
+    ("SQLITE_DROP_TEMP_INDEX", "drop", "index"),
+    ("SQLITE_DROP_TEMP_TABLE", "drop", "table"),
+    ("SQLITE_DROP_TEMP_TRIGGER", "drop", "trigger"),
+    ("SQLITE_DROP_TEMP_VIEW", "drop", "view"),
+):
+    action_value = getattr(sqlite3, action_name, None)
+    if action_value is not None:
+        actions = _CREATE_ACTIONS if operation == "create" else _DROP_ACTIONS
+        actions[action_value] = (operation, target_type)
+
+_SQLITE_SCHEMA_TABLES = {"sqlite_master", "sqlite_schema"}
+
 
 def analyze_sql_tables(
     conn,
@@ -38,15 +112,13 @@ def analyze_sql_tables(
     schema_to_database: dict[str, str] | None = None,
 ) -> SQLAnalysis:
     """
-    Return tables accessed by a SQL statement according to SQLite's authorizer.
+    Return operations performed by a SQL statement according to SQLite's authorizer.
 
     This function is synchronous and connection-based. It temporarily installs a
-    SQLite authorizer, prepares ``EXPLAIN <sql>``, and returns the table access
+    SQLite authorizer, prepares ``EXPLAIN <sql>``, and returns the operation
     callbacks observed while SQLite compiles the statement.
     """
-    accesses: dict[
-        tuple[SQLTableOperation, str | None, str, str | None, str | None], set[str]
-    ] = {}
+    operations: dict[OperationKey, set[str]] = {}
 
     def database_for_schema(sqlite_schema):
         if schema_to_database and sqlite_schema in schema_to_database:
@@ -55,21 +127,166 @@ def analyze_sql_tables(
             return database_name
         return sqlite_schema
 
+    def record(
+        operation: SQLOperation,
+        target_type: SQLTargetType,
+        *,
+        database: str | None,
+        table: str | None,
+        sqlite_schema: str | None,
+        target: str | None,
+        source: str | None,
+        column: str | None = None,
+        internal: bool = False,
+    ):
+        key = OperationKey(
+            operation=operation,
+            target_type=target_type,
+            database=database,
+            table=table,
+            sqlite_schema=sqlite_schema,
+            target=target,
+            source=source,
+            internal=internal,
+        )
+        columns = operations.setdefault(key, set())
+        if column is not None:
+            columns.add(column)
+
     def authorizer(action, arg1, arg2, sqlite_schema, source):
         operation = _ACTION_TO_OPERATION.get(action)
-        if operation is None or arg1 is None:
+        if operation is not None and arg1 is not None:
+            target_type = "schema" if arg1 in _SQLITE_SCHEMA_TABLES else "table"
+            column = (
+                arg2 if operation in ("read", "update") and arg2 is not None else None
+            )
+            record(
+                operation,
+                target_type,
+                database=database_for_schema(sqlite_schema),
+                table=arg1 if target_type == "table" else None,
+                sqlite_schema=sqlite_schema,
+                target=arg1,
+                source=source,
+                column=column,
+                internal=target_type == "schema",
+            )
+            return sqlite3.SQLITE_OK
+
+        create_operation = _CREATE_ACTIONS.get(action)
+        if create_operation is not None and arg1 is not None:
+            operation, target_type = create_operation
+            related_table = arg2 if target_type in {"index", "trigger"} else arg1
+            record(
+                operation,
+                target_type,
+                database=database_for_schema(sqlite_schema),
+                table=related_table,
+                sqlite_schema=sqlite_schema,
+                target=arg1,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        drop_operation = _DROP_ACTIONS.get(action)
+        if drop_operation is not None and arg1 is not None:
+            operation, target_type = drop_operation
+            related_table = arg2 if target_type in {"index", "trigger"} else arg1
+            record(
+                operation,
+                target_type,
+                database=database_for_schema(sqlite_schema),
+                table=related_table,
+                sqlite_schema=sqlite_schema,
+                target=arg1,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_ALTER_TABLE and arg2 is not None:
+            record(
+                "alter",
+                "table",
+                database=database_for_schema(arg1),
+                table=arg2,
+                sqlite_schema=arg1,
+                target=arg2,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_TRANSACTION and arg1 is not None:
+            record(
+                arg1.lower(),
+                "transaction",
+                database=None,
+                table=None,
+                sqlite_schema=None,
+                target=arg1,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_ATTACH and arg1 is not None:
+            record(
+                "attach",
+                "database",
+                database=None,
+                table=None,
+                sqlite_schema=None,
+                target=arg1,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_DETACH and arg1 is not None:
+            record(
+                "detach",
+                "database",
+                database=None,
+                table=None,
+                sqlite_schema=None,
+                target=arg1,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_PRAGMA and arg1 is not None:
+            record(
+                "pragma",
+                "pragma",
+                database=None,
+                table=None,
+                sqlite_schema=sqlite_schema,
+                target=arg1,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_ANALYZE:
+            record(
+                "analyze",
+                "database" if arg1 is None else "table",
+                database=database_for_schema(sqlite_schema),
+                table=arg1,
+                sqlite_schema=sqlite_schema,
+                target=arg1,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_REINDEX and arg1 is not None:
+            record(
+                "reindex",
+                "index",
+                database=database_for_schema(sqlite_schema),
+                table=None,
+                sqlite_schema=sqlite_schema,
+                target=arg1,
+                source=source,
+            )
             return sqlite3.SQLITE_OK
 
-        key = (
-            operation,
-            database_for_schema(sqlite_schema),
-            arg1,
-            sqlite_schema,
-            source,
-        )
-        columns = accesses.setdefault(key, set())
-        if operation in ("read", "update") and arg2 is not None:
-            columns.add(arg2)
         return sqlite3.SQLITE_OK
 
     conn.set_authorizer(authorizer)
@@ -78,22 +295,26 @@ def analyze_sql_tables(
     finally:
         conn.set_authorizer(None)
 
+    has_schema_operation = any(
+        key.target_type in {"table", "index", "view", "trigger"}
+        and key.operation in {"create", "alter", "drop"}
+        for key in operations
+    )
+
     return SQLAnalysis(
-        table_accesses=tuple(
-            SQLTableAccess(
-                operation=operation,
-                database=database,
-                table=table,
-                sqlite_schema=sqlite_schema,
+        operations=tuple(
+            Operation(
+                operation=key.operation,
+                target_type=key.target_type,
+                database=key.database,
+                table=key.table,
+                sqlite_schema=key.sqlite_schema,
+                target=key.target,
                 columns=tuple(sorted(columns)),
-                source=source,
+                source=key.source,
+                internal=key.internal
+                or (has_schema_operation and key.target_type == "schema"),
             )
-            for (
-                operation,
-                database,
-                table,
-                sqlite_schema,
-                source,
-            ), columns in accesses.items()
+            for key, columns in operations.items()
         )
     )
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index 0054300c..cead8926 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -193,9 +193,12 @@ class ExecuteWriteView(BaseView):
                 status=400,
             )
 
-        message = "Query executed, {} row{} affected".format(
-            cursor.rowcount, "" if cursor.rowcount == 1 else "s"
-        )
+        if cursor.rowcount == -1:
+            message = "Query executed"
+        else:
+            message = "Query executed, {} row{} affected".format(
+                cursor.rowcount, "" if cursor.rowcount == 1 else "s"
+            )
         if _wants_json(request, is_json, data):
             return _block_framing(
                 Response.json(
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 46d71b8e..922f4e52 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -1,8 +1,12 @@
 import json
 import re
 
-from datasette.resources import DatabaseResource, TableResource
-from datasette.stored_queries import StoredQuery
+from datasette.resources import DatabaseResource
+from datasette.stored_queries import (
+    StoredQuery,
+    operation_is_write,
+    permission_for_operation,
+)
 from datasette.utils import (
     named_parameters as derive_named_parameters,
     escape_sqlite,
@@ -12,6 +16,7 @@ from datasette.utils import (
     InvalidSql,
 )
 from datasette.utils.asgi import Forbidden
+from datasette.utils.sql_analysis import Operation, SQLAnalysis
 
 _query_name_re = re.compile(r"^[^/\.\n]+$")
 
@@ -123,11 +128,8 @@ def _coerce_query_parameters(value, derived):
     return parameters
 
 
-def _analysis_is_write(analysis):
-    return any(
-        access.operation in {"insert", "update", "delete"}
-        for access in analysis.table_accesses
-    )
+def _analysis_is_write(analysis: SQLAnalysis) -> bool:
+    return any(operation_is_write(operation) for operation in analysis.operations)
 
 
 def _block_framing(response):
@@ -201,34 +203,66 @@ async def _analyze_user_query(datasette, db, sql, *, actor):
     return is_write, derived, analysis
 
 
-def _analysis_rows(analysis):
-    write_actions = {
-        "insert": "insert-row",
-        "update": "update-row",
-        "delete": "delete-row",
-    }
-    return [
-        {
-            "operation": access.operation,
-            "database": access.database,
-            "table": access.table,
-            "required_permission": write_actions.get(access.operation, ""),
-            "source": access.source,
-        }
-        for access in analysis.table_accesses
-    ]
+def _semantic_schema_operation_is_present(operations: tuple[Operation, ...]) -> bool:
+    return any(
+        operation.operation in {"create", "alter", "drop"}
+        and operation.target_type in {"table", "index", "view", "trigger"}
+        for operation in operations
+    )
 
 
-async def _analysis_rows_with_permissions(datasette, analysis, actor):
+def _display_operations(analysis: SQLAnalysis) -> list[Operation]:
+    has_semantic_schema_operation = _semantic_schema_operation_is_present(
+        analysis.operations
+    )
+    operations = []
+    for operation in analysis.operations:
+        if operation.internal and has_semantic_schema_operation:
+            continue
+        if has_semantic_schema_operation and operation.operation in {
+            "read",
+            "insert",
+            "update",
+            "delete",
+            "reindex",
+        }:
+            continue
+        operations.append(operation)
+    return operations
+
+
+def _analysis_rows(analysis: SQLAnalysis) -> list[dict[str, object]]:
+    rows = []
+    for operation in _display_operations(analysis):
+        permission = permission_for_operation(operation)
+        required_permission = permission[0] if permission else ""
+        rows.append(
+            {
+                "operation": operation.operation,
+                "database": operation.database,
+                "table": operation.table or operation.target,
+                "required_permission": required_permission,
+                "source": operation.source,
+            }
+        )
+    return rows
+
+
+async def _analysis_rows_with_permissions(
+    datasette, analysis: SQLAnalysis, actor
+) -> list[dict[str, object]]:
     rows = _analysis_rows(analysis)
-    for row in rows:
-        permission = row["required_permission"]
+    for row, operation in zip(rows, _display_operations(analysis)):
+        permission = permission_for_operation(operation)
         if permission:
+            action, resource = permission
             row["allowed"] = await datasette.allowed(
-                action=permission,
-                resource=TableResource(row["database"], row["table"]),
+                action=action,
+                resource=resource,
                 actor=actor,
             )
+        elif operation_is_write(operation):
+            row["allowed"] = False
         else:
             row["allowed"] = None
     return rows
@@ -398,15 +432,19 @@ async def _inserted_row_url(datasette, db, analysis, cursor):
     if lastrowid is None:
         return None
     direct_inserts = [
-        access
-        for access in analysis.table_accesses
-        if access.operation == "insert"
-        and access.source is None
-        and access.database == db.name
+        operation
+        for operation in analysis.operations
+        if operation.operation == "insert"
+        and operation.target_type == "table"
+        and not operation.internal
+        and operation.source is None
+        and operation.database == db.name
     ]
     if len(direct_inserts) != 1:
         return None
     table = direct_inserts[0].table
+    if table is None:
+        return None
     pks = await db.primary_keys(table)
     use_rowid = not pks
     select = (
diff --git a/tests/test_actions_sql.py b/tests/test_actions_sql.py
index 863d2529..a1fca971 100644
--- a/tests/test_actions_sql.py
+++ b/tests/test_actions_sql.py
@@ -12,10 +12,22 @@ import pytest
 import pytest_asyncio
 from datasette.app import Datasette
 from datasette.permissions import PermissionSQL
-from datasette.resources import TableResource
+from datasette.resources import DatabaseResource, QueryResource, TableResource
 from datasette import hookimpl
 
 
+def test_resource_string_representations():
+    assert str(DatabaseResource("content")) == "content"
+    assert repr(DatabaseResource("content")) == (
+        "DatabaseResource(parent='content', child=None)"
+    )
+    assert str(TableResource("content", "dogs")) == "content/dogs"
+    assert repr(TableResource("content", "dogs")) == (
+        "TableResource(parent='content', child='dogs')"
+    )
+    assert str(QueryResource("content", "insert-a-dog")) == "content/insert-a-dog"
+
+
 # Test plugin that provides permission rules
 class PermissionRulesPlugin:
     def __init__(self, rules_callback):
diff --git a/tests/test_internals_database.py b/tests/test_internals_database.py
index 5481a398..d6e130b4 100644
--- a/tests/test_internals_database.py
+++ b/tests/test_internals_database.py
@@ -698,14 +698,17 @@ async def test_analyze_sql():
 
     assert [
         (
-            access.operation,
-            access.database,
-            access.sqlite_schema,
-            access.table,
-            access.columns,
-            access.source,
+            operation.operation,
+            operation.database,
+            operation.sqlite_schema,
+            operation.table,
+            operation.columns,
+            operation.source,
         )
-        for access in analysis.table_accesses
+        for operation in analysis.operations
+        if operation.target_type == "table"
+        and operation.operation in {"read", "insert", "update", "delete"}
+        and not operation.internal
     ] == [
         ("read", "data", "main", "dogs", ("id", "name"), None),
     ]
@@ -722,14 +725,17 @@ async def test_analyze_sql_insert_select():
 
     assert {
         (
-            access.operation,
-            access.database,
-            access.sqlite_schema,
-            access.table,
-            access.columns,
-            access.source,
+            operation.operation,
+            operation.database,
+            operation.sqlite_schema,
+            operation.table,
+            operation.columns,
+            operation.source,
         )
-        for access in analysis.table_accesses
+        for operation in analysis.operations
+        if operation.target_type == "table"
+        and operation.operation in {"read", "insert", "update", "delete"}
+        and not operation.internal
     } == {
         ("insert", "data", "main", "dogs", (), None),
         ("read", "data", "main", "cats", ("name",), None),
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 59fab8c0..4b8a6486 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1643,6 +1643,172 @@ async def test_execute_write_post_requires_database_and_table_permissions():
     assert (await db.execute("select name from dogs")).first()[0] == "Cleo"
 
 
+@pytest.mark.asyncio
+async def test_execute_write_create_table_uses_create_table_permission():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "permissions": {
+                "insert-row": {"id": "row-writer"},
+                "update-row": {"id": "row-writer"},
+            },
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": ["creator", "row-writer"]},
+                        "execute-write-sql": {"id": ["creator", "row-writer"]},
+                        "create-table": {"id": "creator"},
+                    }
+                }
+            },
+        },
+    )
+    db = ds.add_memory_database("execute_write_create_table", name="data")
+    await ds.invoke_startup()
+
+    analysis_response = await ds.client.get(
+        "/data/-/execute-write/analyze",
+        actor={"id": "creator"},
+        params={"sql": "create table foobar (id integer primary key, name text)"},
+    )
+    allowed_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "creator"},
+        json={"sql": "create table foobar (id integer primary key, name text)"},
+    )
+    row_permission_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "row-writer"},
+        json={"sql": "create table should_not_exist (id integer primary key)"},
+    )
+
+    assert analysis_response.status_code == 200
+    analysis_data = analysis_response.json()
+    assert analysis_data["ok"] is True
+    assert analysis_data["execute_disabled"] is False
+    assert analysis_data["analysis_rows"] == [
+        {
+            "operation": "create",
+            "database": "data",
+            "table": "foobar",
+            "required_permission": "create-table",
+            "source": None,
+            "allowed": True,
+        }
+    ]
+
+    assert allowed_response.status_code == 200
+    assert allowed_response.json()["ok"] is True
+    assert allowed_response.json()["message"] == "Query executed"
+    assert await db.table_exists("foobar")
+
+    assert row_permission_response.status_code == 403
+    assert row_permission_response.json()["errors"] == [
+        "Permission denied: need create-table on data"
+    ]
+    assert not await db.table_exists("should_not_exist")
+
+
+@pytest.mark.asyncio
+async def test_execute_write_alter_and_drop_table_use_schema_permissions():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "permissions": {
+                "delete-row": {"id": "row-writer"},
+                "update-row": {"id": "row-writer"},
+            },
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": ["alterer", "dropper", "row-writer"]},
+                        "execute-write-sql": {
+                            "id": ["alterer", "dropper", "row-writer"]
+                        },
+                    },
+                    "tables": {
+                        "dogs": {
+                            "permissions": {
+                                "alter-table": {"id": "alterer"},
+                                "drop-table": {"id": "dropper"},
+                            }
+                        }
+                    },
+                }
+            },
+        },
+    )
+    db = ds.add_memory_database("execute_write_alter_drop_table", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await db.execute_write("create table cats (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    alter_allowed_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "alterer"},
+        json={"sql": "alter table dogs add column age integer"},
+    )
+    alter_row_permission_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "row-writer"},
+        json={"sql": "alter table cats add column age integer"},
+    )
+
+    assert alter_allowed_response.status_code == 200
+    assert "age" in [column.name for column in await db.table_column_details("dogs")]
+    assert alter_row_permission_response.status_code == 403
+    assert alter_row_permission_response.json()["errors"] == [
+        "Permission denied: need alter-table on data/cats"
+    ]
+    assert "age" not in [
+        column.name for column in await db.table_column_details("cats")
+    ]
+
+    create_index_allowed_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "alterer"},
+        json={"sql": "create index idx_dogs_name on dogs(name)"},
+    )
+    create_index_row_permission_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "row-writer"},
+        json={"sql": "create index idx_cats_name on cats(name)"},
+    )
+    drop_index_allowed_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "alterer"},
+        json={"sql": "drop index idx_dogs_name"},
+    )
+
+    assert create_index_allowed_response.status_code == 200
+    assert create_index_row_permission_response.status_code == 403
+    assert create_index_row_permission_response.json()["errors"] == [
+        "Permission denied: need alter-table on data/cats"
+    ]
+    assert drop_index_allowed_response.status_code == 200
+
+    drop_allowed_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "dropper"},
+        json={"sql": "drop table dogs"},
+    )
+    drop_row_permission_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "row-writer"},
+        json={"sql": "drop table cats"},
+    )
+
+    assert drop_allowed_response.status_code == 200
+    assert not await db.table_exists("dogs")
+    assert drop_row_permission_response.status_code == 403
+    assert drop_row_permission_response.json()["errors"] == [
+        "Permission denied: need drop-table on data/cats"
+    ]
+    assert await db.table_exists("cats")
+
+
 @pytest.mark.asyncio
 async def test_execute_write_insert_links_to_inserted_row():
     ds = Datasette(memory=True, default_deny=True)
diff --git a/tests/test_utils_sql_analysis.py b/tests/test_utils_sql_analysis.py
index 5730cd0d..5306a515 100644
--- a/tests/test_utils_sql_analysis.py
+++ b/tests/test_utils_sql_analysis.py
@@ -26,17 +26,20 @@ def conn():
         conn.close()
 
 
-def as_tuples(analysis):
+def table_operation_tuples(analysis):
     return [
         (
-            access.operation,
-            access.database,
-            access.sqlite_schema,
-            access.table,
-            access.columns,
-            access.source,
+            operation.operation,
+            operation.database,
+            operation.sqlite_schema,
+            operation.table,
+            operation.columns,
+            operation.source,
         )
-        for access in analysis.table_accesses
+        for operation in analysis.operations
+        if operation.target_type == "table"
+        and operation.operation in {"read", "insert", "update", "delete"}
+        and not operation.internal
     ]
 
 
@@ -48,7 +51,7 @@ def test_analyze_select_tables(conn):
         database_name="data",
     )
 
-    assert set(as_tuples(analysis)) == {
+    assert set(table_operation_tuples(analysis)) == {
         ("read", "data", "main", "cats", ("id", "name"), None),
         ("read", "data", "main", "dogs", ("age", "id", "name"), None),
     }
@@ -57,11 +60,73 @@ def test_analyze_select_tables(conn):
 def test_analyze_uses_sqlite_schema_as_default_database(conn):
     analysis = analyze_sql_tables(conn, "select name from dogs")
 
-    assert set(as_tuples(analysis)) == {
+    assert set(table_operation_tuples(analysis)) == {
         ("read", "main", "main", "dogs", ("name",), None),
     }
 
 
+def operation_dict(operation):
+    return {
+        "operation": operation.operation,
+        "target_type": operation.target_type,
+        "database": operation.database,
+        "sqlite_schema": operation.sqlite_schema,
+        "table": operation.table,
+        "target": operation.target,
+        "columns": operation.columns,
+        "source": operation.source,
+        "internal": operation.internal,
+    }
+
+
+def test_analyze_create_table_operation():
+    conn = sqlite3.connect(":memory:")
+    try:
+        analysis = analyze_sql_tables(
+            conn,
+            "create table foobar (id integer primary key, name text)",
+            database_name="data",
+        )
+    finally:
+        conn.close()
+
+    assert {
+        "operation": "create",
+        "target_type": "table",
+        "database": "data",
+        "sqlite_schema": "main",
+        "table": "foobar",
+        "target": "foobar",
+        "columns": (),
+        "source": None,
+        "internal": False,
+    } in [operation_dict(operation) for operation in analysis.operations]
+    assert not [
+        operation
+        for operation in analysis.operations
+        if operation.table in {"sqlite_master", "sqlite_schema"}
+        and not operation.internal
+    ]
+
+
+def test_analyze_transaction_operation(conn):
+    analysis = analyze_sql_tables(conn, "commit", database_name="data")
+
+    assert [operation_dict(operation) for operation in analysis.operations] == [
+        {
+            "operation": "commit",
+            "target_type": "transaction",
+            "database": None,
+            "sqlite_schema": None,
+            "table": None,
+            "target": "COMMIT",
+            "columns": (),
+            "source": None,
+            "internal": False,
+        }
+    ]
+
+
 def test_analyze_insert_tables(conn):
     analysis = analyze_sql_tables(
         conn,
@@ -70,7 +135,7 @@ def test_analyze_insert_tables(conn):
         database_name="data",
     )
 
-    assert set(as_tuples(analysis)) == {
+    assert set(table_operation_tuples(analysis)) == {
         ("insert", "data", "main", "dogs", (), None),
         ("read", "data", "main", "dogs", ("id", "name"), "dogs_after_insert"),
         ("update", "data", "main", "cats", ("name",), "dogs_after_insert"),
@@ -87,7 +152,7 @@ def test_analyze_update_tables(conn):
         database_name="data",
     )
 
-    assert set(as_tuples(analysis)) == {
+    assert set(table_operation_tuples(analysis)) == {
         ("update", "data", "main", "dogs", ("age",), None),
         ("read", "data", "main", "dogs", ("age", "name"), None),
     }
@@ -101,7 +166,7 @@ def test_analyze_delete_tables(conn):
         database_name="data",
     )
 
-    assert set(as_tuples(analysis)) == {
+    assert set(table_operation_tuples(analysis)) == {
         ("delete", "data", "main", "dogs", (), None),
         ("read", "data", "main", "dogs", ("name",), None),
     }
@@ -121,7 +186,7 @@ def test_analyze_insert_select_with_cte(conn):
         database_name="data",
     )
 
-    assert set(as_tuples(analysis)) == {
+    assert set(table_operation_tuples(analysis)) == {
         ("insert", "data", "main", "cats", (), None),
         ("read", "data", "main", "dogs", ("age", "name"), "old_dogs"),
     }
@@ -135,7 +200,7 @@ def test_analyze_view_with_instead_of_trigger(conn):
         database_name="data",
     )
 
-    assert set(as_tuples(analysis)) == {
+    assert set(table_operation_tuples(analysis)) == {
         ("update", "data", "main", "dog_names", ("name",), None),
         ("read", "data", "main", "dogs", ("id", "name"), "dog_names"),
         ("read", "data", "main", "dog_names", ("id", "name"), "dog_names"),
@@ -163,7 +228,7 @@ def test_analyze_attached_database_tables(conn):
         schema_to_database={"extra": "extra_db"},
     )
 
-    assert set(as_tuples(analysis)) == {
+    assert set(table_operation_tuples(analysis)) == {
         ("insert", "extra_db", "extra", "people", (), None),
         ("read", "data", "main", "dogs", ("name",), None),
     }

From 86d0e7335f98a88874df31ec0adb64967446dfac Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 27 May 2026 14:52:52 -0700
Subject: [PATCH 112/386] Deny unsupported write SQL operations by default

Require view-table permission for reads discovered inside write SQL analysis, including INSERT ... SELECT and CREATE TABLE ... AS SELECT.

Record additional SQLite authorizer callbacks as Operation values so unsupported functions, savepoints, virtual table DDL, and unknown callbacks are denied unless explicitly handled.
---
 datasette/stored_queries.py      |  43 +++----
 datasette/utils/sql_analysis.py  | 192 +++++++++++++++++++++++++++++--
 datasette/views/execute_write.py |   4 +-
 datasette/views/query_helpers.py |  32 ++----
 tests/test_queries.py            | 136 ++++++++++++++++++++--
 tests/test_utils_sql_analysis.py |  94 +++++++++++++++
 6 files changed, 433 insertions(+), 68 deletions(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index c4b083e5..4b0fe6a6 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -592,6 +592,16 @@ PermissionRequirement = tuple[str, Resource]
 
 
 def permission_for_operation(operation: Operation) -> PermissionRequirement | None:
+    if (
+        operation.operation == "read"
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return (
+            "view-table",
+            TableResource(database=operation.database, table=operation.table),
+        )
     write_actions = {
         "insert": "insert-row",
         "update": "update-row",
@@ -648,6 +658,10 @@ def permission_for_operation(operation: Operation) -> PermissionRequirement | No
     return None
 
 
+def operation_should_be_ignored(operation: Operation) -> bool:
+    return operation.internal or operation.operation == "select"
+
+
 def operation_is_write(operation: Operation) -> bool:
     return operation.operation in {
         "insert",
@@ -659,11 +673,13 @@ def operation_is_write(operation: Operation) -> bool:
         "begin",
         "commit",
         "rollback",
+        "savepoint",
         "attach",
         "detach",
         "pragma",
         "analyze",
         "reindex",
+        "unknown",
     }
 
 
@@ -685,34 +701,19 @@ async def ensure_query_write_permissions(
         except sqlite3.DatabaseError as ex:
             raise Forbidden(f"Could not analyze query: {ex}") from ex
 
-    has_semantic_schema_operation = any(
-        operation.operation in {"create", "alter", "drop"}
-        and operation.target_type in {"table", "index", "view", "trigger"}
-        for operation in analysis.operations
-    )
     for operation in analysis.operations:
-        if operation.internal and has_semantic_schema_operation:
-            continue
-        if has_semantic_schema_operation and operation.operation in {
-            "read",
-            "insert",
-            "update",
-            "delete",
-            "reindex",
-        }:
+        if operation_should_be_ignored(operation):
             continue
         permission = permission_for_operation(operation)
         if permission is None:
-            if operation_is_write(operation):
-                raise Forbidden(
-                    "Unsupported SQL operation: {} {}".format(
-                        operation.operation, operation.target_type
-                    )
+            raise Forbidden(
+                "Unsupported SQL operation: {} {}".format(
+                    operation.operation, operation.target_type
                 )
-            continue
+            )
         action, resource = permission
         if operation.database != database:
-            raise Forbidden("Writable queries may not write to attached databases")
+            raise Forbidden("Writable queries may not access attached databases")
         if not await datasette.allowed(
             action=action,
             resource=resource,
diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index 54f310fe..8963da77 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -8,30 +8,39 @@ SQLOperation = Literal[
     "insert",
     "update",
     "delete",
+    "select",
+    "function",
     "create",
     "alter",
     "drop",
     "begin",
     "commit",
     "rollback",
+    "savepoint",
     "attach",
     "detach",
     "pragma",
     "analyze",
     "reindex",
+    "unknown",
 ]
 SQLTargetType = Literal[
     "table",
     "index",
     "view",
     "trigger",
+    "virtual-table",
     "schema",
+    "statement",
     "transaction",
     "database",
     "pragma",
+    "function",
     "unknown",
 ]
 SQLTableOperation = Literal["read", "insert", "update", "delete"]
+SQLSchemaOperation = Literal["create", "drop"]
+SQLSchemaTargetType = Literal["index", "table", "trigger", "view", "virtual-table"]
 
 
 @dataclass(frozen=True)
@@ -73,19 +82,34 @@ _ACTION_TO_OPERATION: dict[int, SQLTableOperation] = {
 }
 
 # Values are (operation, target_type) pairs used to construct Operation objects.
-_CREATE_ACTIONS = {
+_CREATE_ACTIONS: dict[int, tuple[SQLSchemaOperation, SQLSchemaTargetType]] = {
     sqlite3.SQLITE_CREATE_INDEX: ("create", "index"),
     sqlite3.SQLITE_CREATE_TABLE: ("create", "table"),
     sqlite3.SQLITE_CREATE_TRIGGER: ("create", "trigger"),
     sqlite3.SQLITE_CREATE_VIEW: ("create", "view"),
 }
-_DROP_ACTIONS = {
+_DROP_ACTIONS: dict[int, tuple[SQLSchemaOperation, SQLSchemaTargetType]] = {
     sqlite3.SQLITE_DROP_INDEX: ("drop", "index"),
     sqlite3.SQLITE_DROP_TABLE: ("drop", "table"),
     sqlite3.SQLITE_DROP_TRIGGER: ("drop", "trigger"),
     sqlite3.SQLITE_DROP_VIEW: ("drop", "view"),
 }
-for action_name, operation, target_type in (
+
+
+def _add_schema_action(
+    action_name: str,
+    operation: SQLSchemaOperation,
+    target_type: SQLSchemaTargetType,
+) -> None:
+    action_value = getattr(sqlite3, action_name, None)
+    if action_value is not None:
+        actions = _CREATE_ACTIONS if operation == "create" else _DROP_ACTIONS
+        actions[action_value] = (operation, target_type)
+
+
+_TEMP_SCHEMA_ACTIONS: tuple[
+    tuple[str, SQLSchemaOperation, SQLSchemaTargetType], ...
+] = (
     ("SQLITE_CREATE_TEMP_INDEX", "create", "index"),
     ("SQLITE_CREATE_TEMP_TABLE", "create", "table"),
     ("SQLITE_CREATE_TEMP_TRIGGER", "create", "trigger"),
@@ -94,13 +118,76 @@ for action_name, operation, target_type in (
     ("SQLITE_DROP_TEMP_TABLE", "drop", "table"),
     ("SQLITE_DROP_TEMP_TRIGGER", "drop", "trigger"),
     ("SQLITE_DROP_TEMP_VIEW", "drop", "view"),
-):
-    action_value = getattr(sqlite3, action_name, None)
-    if action_value is not None:
-        actions = _CREATE_ACTIONS if operation == "create" else _DROP_ACTIONS
-        actions[action_value] = (operation, target_type)
+)
+for schema_action in _TEMP_SCHEMA_ACTIONS:
+    _add_schema_action(*schema_action)
 
-_SQLITE_SCHEMA_TABLES = {"sqlite_master", "sqlite_schema"}
+_VTABLE_SCHEMA_ACTIONS: tuple[
+    tuple[str, SQLSchemaOperation, SQLSchemaTargetType], ...
+] = (
+    ("SQLITE_CREATE_VTABLE", "create", "virtual-table"),
+    ("SQLITE_DROP_VTABLE", "drop", "virtual-table"),
+)
+for schema_action in _VTABLE_SCHEMA_ACTIONS:
+    _add_schema_action(*schema_action)
+
+_SQLITE_SCHEMA_TABLES = {
+    "sqlite_master",
+    "sqlite_schema",
+    "sqlite_temp_master",
+    "sqlite_temp_schema",
+}
+_SQLITE_INTERNAL_SCHEMA_FUNCTIONS = {
+    "length",
+    "like",
+    "printf",
+    "sqlite_drop_column",
+    "sqlite_rename_column",
+    "sqlite_rename_quotefix",
+    "sqlite_rename_table",
+    "sqlite_rename_test",
+    "substr",
+}
+
+_AUTHORIZER_ACTION_NAMES = {
+    getattr(sqlite3, name): name
+    for name in (
+        "SQLITE_CREATE_INDEX",
+        "SQLITE_CREATE_TABLE",
+        "SQLITE_CREATE_TEMP_INDEX",
+        "SQLITE_CREATE_TEMP_TABLE",
+        "SQLITE_CREATE_TEMP_TRIGGER",
+        "SQLITE_CREATE_TEMP_VIEW",
+        "SQLITE_CREATE_TRIGGER",
+        "SQLITE_CREATE_VIEW",
+        "SQLITE_DELETE",
+        "SQLITE_DROP_INDEX",
+        "SQLITE_DROP_TABLE",
+        "SQLITE_DROP_TEMP_INDEX",
+        "SQLITE_DROP_TEMP_TABLE",
+        "SQLITE_DROP_TEMP_TRIGGER",
+        "SQLITE_DROP_TEMP_VIEW",
+        "SQLITE_DROP_TRIGGER",
+        "SQLITE_DROP_VIEW",
+        "SQLITE_INSERT",
+        "SQLITE_PRAGMA",
+        "SQLITE_READ",
+        "SQLITE_SELECT",
+        "SQLITE_TRANSACTION",
+        "SQLITE_UPDATE",
+        "SQLITE_ATTACH",
+        "SQLITE_DETACH",
+        "SQLITE_ALTER_TABLE",
+        "SQLITE_REINDEX",
+        "SQLITE_ANALYZE",
+        "SQLITE_CREATE_VTABLE",
+        "SQLITE_DROP_VTABLE",
+        "SQLITE_FUNCTION",
+        "SQLITE_SAVEPOINT",
+        "SQLITE_RECURSIVE",
+    )
+    if hasattr(sqlite3, name)
+}
 
 
 def analyze_sql_tables(
@@ -287,6 +374,52 @@ def analyze_sql_tables(
             )
             return sqlite3.SQLITE_OK
 
+        if action == sqlite3.SQLITE_SELECT:
+            record(
+                "select",
+                "statement",
+                database=None,
+                table=None,
+                sqlite_schema=sqlite_schema,
+                target=None,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_FUNCTION and arg2 is not None:
+            record(
+                "function",
+                "function",
+                database=None,
+                table=None,
+                sqlite_schema=sqlite_schema,
+                target=arg2,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        if action == sqlite3.SQLITE_SAVEPOINT and arg1 is not None:
+            record(
+                "savepoint",
+                "transaction",
+                database=None,
+                table=None,
+                sqlite_schema=sqlite_schema,
+                target="{} {}".format(arg1, arg2) if arg2 is not None else arg1,
+                source=source,
+            )
+            return sqlite3.SQLITE_OK
+
+        action_name = _AUTHORIZER_ACTION_NAMES.get(action, "SQLITE_{}".format(action))
+        record(
+            "unknown",
+            "unknown",
+            database=database_for_schema(sqlite_schema),
+            table=None,
+            sqlite_schema=sqlite_schema,
+            target=action_name,
+            source=source,
+        )
         return sqlite3.SQLITE_OK
 
     conn.set_authorizer(authorizer)
@@ -296,10 +429,46 @@ def analyze_sql_tables(
         conn.set_authorizer(None)
 
     has_schema_operation = any(
-        key.target_type in {"table", "index", "view", "trigger"}
+        key.target_type in {"table", "index", "view", "trigger", "virtual-table"}
         and key.operation in {"create", "alter", "drop"}
         for key in operations
     )
+    dropped_tables = {
+        (key.database, key.table)
+        for key in operations
+        if key.operation == "drop" and key.target_type == "table"
+    }
+
+    def key_is_drop_table_delete(key: OperationKey) -> bool:
+        return (
+            key.operation == "delete"
+            and key.target_type == "table"
+            and (key.database, key.table) in dropped_tables
+        )
+
+    has_user_table_access_in_schema_operation = any(
+        key.operation in {"read", "insert", "update", "delete"}
+        and key.target_type == "table"
+        and not key.internal
+        and not key_is_drop_table_delete(key)
+        for key in operations
+    )
+
+    def operation_is_internal(key: OperationKey) -> bool:
+        if key.internal or (has_schema_operation and key.target_type == "schema"):
+            return True
+        if has_schema_operation and key.operation == "reindex":
+            return True
+        if (
+            has_schema_operation
+            and not has_user_table_access_in_schema_operation
+            and key.operation == "function"
+            and key.target in _SQLITE_INTERNAL_SCHEMA_FUNCTIONS
+        ):
+            return True
+        if key_is_drop_table_delete(key):
+            return True
+        return False
 
     return SQLAnalysis(
         operations=tuple(
@@ -312,8 +481,7 @@ def analyze_sql_tables(
                 target=key.target,
                 columns=tuple(sorted(columns)),
                 source=key.source,
-                internal=key.internal
-                or (has_schema_operation and key.target_type == "schema"),
+                internal=operation_is_internal(key),
             )
             for key, columns in operations.items()
         )
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index cead8926..19006ac5 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -99,9 +99,7 @@ class ExecuteWriteView(BaseView):
                 "parameter_names": parameter_names,
                 "parameter_values": parameter_values,
                 "analysis_error": analysis_error,
-                "analysis_rows": [
-                    row for row in analysis_rows if row["operation"] != "read"
-                ],
+                "analysis_rows": analysis_rows,
                 "execution_message": execution_message,
                 "execution_links": execution_links,
                 "execution_ok": execution_ok,
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 922f4e52..05a0d73e 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -5,6 +5,7 @@ from datasette.resources import DatabaseResource
 from datasette.stored_queries import (
     StoredQuery,
     operation_is_write,
+    operation_should_be_ignored,
     permission_for_operation,
 )
 from datasette.utils import (
@@ -203,29 +204,10 @@ async def _analyze_user_query(datasette, db, sql, *, actor):
     return is_write, derived, analysis
 
 
-def _semantic_schema_operation_is_present(operations: tuple[Operation, ...]) -> bool:
-    return any(
-        operation.operation in {"create", "alter", "drop"}
-        and operation.target_type in {"table", "index", "view", "trigger"}
-        for operation in operations
-    )
-
-
 def _display_operations(analysis: SQLAnalysis) -> list[Operation]:
-    has_semantic_schema_operation = _semantic_schema_operation_is_present(
-        analysis.operations
-    )
     operations = []
     for operation in analysis.operations:
-        if operation.internal and has_semantic_schema_operation:
-            continue
-        if has_semantic_schema_operation and operation.operation in {
-            "read",
-            "insert",
-            "update",
-            "delete",
-            "reindex",
-        }:
+        if operation_should_be_ignored(operation):
             continue
         operations.append(operation)
     return operations
@@ -252,6 +234,7 @@ async def _analysis_rows_with_permissions(
     datasette, analysis: SQLAnalysis, actor
 ) -> list[dict[str, object]]:
     rows = _analysis_rows(analysis)
+    is_write = _analysis_is_write(analysis)
     for row, operation in zip(rows, _display_operations(analysis)):
         permission = permission_for_operation(operation)
         if permission:
@@ -261,7 +244,7 @@ async def _analysis_rows_with_permissions(
                 resource=resource,
                 actor=actor,
             )
-        elif operation_is_write(operation):
+        elif is_write:
             row["allowed"] = False
         else:
             row["allowed"] = None
@@ -360,7 +343,7 @@ async def _execute_write_analysis_data(datasette, db, sql, actor):
         "ok": analysis_error is None,
         "parameters": parameter_names,
         "analysis_error": analysis_error,
-        "analysis_rows": [row for row in analysis_rows if row["operation"] != "read"],
+        "analysis_rows": analysis_rows,
         "execute_disabled": bool(
             (not sql)
             or analysis_error
@@ -374,6 +357,7 @@ async def _query_create_analysis_data(datasette, db, sql, actor):
     parameter_names = []
     analysis_rows = []
     analysis_error = None
+    analysis: SQLAnalysis | None = None
     if has_sql:
         try:
             parameter_names = _derived_query_parameters(sql)
@@ -390,9 +374,7 @@ async def _query_create_analysis_data(datasette, db, sql, actor):
         "analysis_error": analysis_error,
         "analysis_rows": analysis_rows,
         "has_sql": has_sql,
-        "analysis_is_write": bool(
-            analysis_rows and any(row["required_permission"] for row in analysis_rows)
-        ),
+        "analysis_is_write": _analysis_is_write(analysis) if analysis else False,
         "save_disabled": bool(
             (not has_sql)
             or analysis_error
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 4b8a6486..97ec973f 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1181,11 +1181,10 @@ async def test_create_query_ui_and_arbitrary_sql_save_link():
     assert '<th scope="col">Required permission</th>' in create_response.text
     assert '<th scope="col">Source</th>' not in create_response.text
     assert "<td><code>read</code></td>" in create_response.text
+    assert "<td><code>view-table</code></td>" in create_response.text
     assert (
-        create_response.text.count(
-            '<td><span class="execute-write-analysis-na">n/a</span></td>'
-        )
-        == 2
+        '<td><span class="execute-write-analysis-na">n/a</span></td>'
+        not in create_response.text
     )
     assert create_response.text.index(
         'value="Save query"'
@@ -1255,9 +1254,9 @@ async def test_create_query_analyze_endpoint_uses_sql_only():
             "operation": "read",
             "database": "data",
             "table": "dogs",
-            "required_permission": "",
+            "required_permission": "view-table",
             "source": None,
-            "allowed": None,
+            "allowed": True,
         }
     ]
 
@@ -1375,7 +1374,8 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert '<th scope="col">Required permission</th>' in response.text
     assert "<td><code>insert</code></td>" in response.text
     assert "<td><code>update</code></td>" in response.text
-    assert "<td><code>read</code></td>" not in response.text
+    assert "<td><code>read</code></td>" in response.text
+    assert "<td><code>view-table</code></td>" in response.text
     assert 'action="/data/-/execute-write"' in response.text
     assert "insert into dogs (name) values (&#39;Cleo&#39;)" in response.text
     assert (await db.execute("select count(*) from dogs")).first()[0] == 0
@@ -1643,6 +1643,127 @@ async def test_execute_write_post_requires_database_and_table_permissions():
     assert (await db.execute("select name from dogs")).first()[0] == "Cleo"
 
 
+@pytest.mark.asyncio
+async def test_execute_write_insert_select_requires_view_table_on_source():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    },
+                    "tables": {
+                        "secret": {
+                            "permissions": {"view-table": {"id": "someone-else"}}
+                        },
+                        "public_log": {"permissions": {"insert-row": {"id": "writer"}}},
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_insert_select_source", name="data")
+    await db.execute_write("create table secret (value text)")
+    await db.execute_write("create table public_log (value text)")
+    await db.execute_write("insert into secret values ('sensitive')")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={"sql": "insert into public_log(value) select value from secret"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Permission denied: need view-table on data/secret"
+    ]
+    assert (await db.execute("select value from public_log")).dicts() == []
+
+
+@pytest.mark.asyncio
+async def test_execute_write_create_table_as_select_requires_view_table_on_source():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "creator"},
+                        "execute-write-sql": {"id": "creator"},
+                        "create-table": {"id": "creator"},
+                    },
+                    "tables": {
+                        "secret": {
+                            "permissions": {"view-table": {"id": "someone-else"}}
+                        }
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_create_as_select_source", name="data")
+    await db.execute_write("create table secret (value text)")
+    await db.execute_write("insert into secret values ('sensitive')")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "creator"},
+        json={"sql": "create table copied_secret as select value from secret"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Permission denied: need view-table on data/secret"
+    ]
+    assert not await db.table_exists("copied_secret")
+
+
+@pytest.mark.asyncio
+async def test_execute_write_rejects_function_operations():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    },
+                    "tables": {
+                        "dogs": {
+                            "permissions": {
+                                "insert-row": {"id": "writer"},
+                            }
+                        }
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_function_operation", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={"sql": "insert into dogs (name) values (upper('cleo'))"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Unsupported SQL operation: function function"
+    ]
+    assert (await db.execute("select name from dogs")).dicts() == []
+
+
 @pytest.mark.asyncio
 async def test_execute_write_create_table_uses_create_table_permission():
     ds = Datasette(
@@ -1733,6 +1854,7 @@ async def test_execute_write_alter_and_drop_table_use_schema_permissions():
                             "permissions": {
                                 "alter-table": {"id": "alterer"},
                                 "drop-table": {"id": "dropper"},
+                                "view-table": {"id": "alterer"},
                             }
                         }
                     },
diff --git a/tests/test_utils_sql_analysis.py b/tests/test_utils_sql_analysis.py
index 5306a515..2ae11502 100644
--- a/tests/test_utils_sql_analysis.py
+++ b/tests/test_utils_sql_analysis.py
@@ -127,6 +127,100 @@ def test_analyze_transaction_operation(conn):
     ]
 
 
+def test_analyze_savepoint_operation(conn):
+    analysis = analyze_sql_tables(conn, "savepoint s", database_name="data")
+
+    assert [operation_dict(operation) for operation in analysis.operations] == [
+        {
+            "operation": "savepoint",
+            "target_type": "transaction",
+            "database": None,
+            "sqlite_schema": None,
+            "table": None,
+            "target": "BEGIN s",
+            "columns": (),
+            "source": None,
+            "internal": False,
+        }
+    ]
+
+
+def test_analyze_function_operation(conn):
+    analysis = analyze_sql_tables(
+        conn,
+        "insert into dogs (name) values (upper(:name))",
+        {"name": "Cleo"},
+        database_name="data",
+    )
+
+    assert {
+        (
+            operation.operation,
+            operation.target_type,
+            operation.target,
+            operation.database,
+            operation.table,
+        )
+        for operation in analysis.operations
+    } == {
+        ("insert", "table", "dogs", "data", "dogs"),
+        ("function", "function", "upper", None, None),
+        ("read", "table", "dogs", "data", "dogs"),
+        ("update", "table", "cats", "data", "cats"),
+        ("read", "table", "cats", "data", "cats"),
+        ("insert", "table", "log", "data", "log"),
+    }
+
+
+def test_analyze_create_virtual_table_operation():
+    conn = sqlite3.connect(":memory:")
+    try:
+        analysis = analyze_sql_tables(
+            conn,
+            "create virtual table docs using fts5(body)",
+            database_name="data",
+        )
+    finally:
+        conn.close()
+
+    assert {
+        "operation": "create",
+        "target_type": "virtual-table",
+        "database": "data",
+        "sqlite_schema": "main",
+        "table": "docs",
+        "target": "docs",
+        "columns": (),
+        "source": None,
+        "internal": False,
+    } in [operation_dict(operation) for operation in analysis.operations]
+
+
+def test_analyze_create_table_as_select_function_is_not_internal():
+    conn = sqlite3.connect(":memory:")
+    try:
+        conn.execute("create table secret(value text)")
+        analysis = analyze_sql_tables(
+            conn,
+            "create table copied as select substr(value, 1, 1) from secret",
+            database_name="data",
+        )
+    finally:
+        conn.close()
+
+    assert {
+        "operation": "function",
+        "target_type": "function",
+        "database": None,
+        "sqlite_schema": None,
+        "table": None,
+        "target": "substr",
+        "columns": (),
+        "source": None,
+        "internal": False,
+    } in [operation_dict(operation) for operation in analysis.operations]
+
+
 def test_analyze_insert_tables(conn):
     analysis = analyze_sql_tables(
         conn,

From 03b2c66f6312b8317d87eb4c1326977f6f63b26d Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 27 May 2026 15:17:10 -0700
Subject: [PATCH 113/386] Require full row mutation permissions for raw SQL

Raw SQL insert and update statements can have broader effects than their SQLite authorizer callbacks reveal. INSERT OR REPLACE and UPDATE OR REPLACE can delete conflicting rows while only surfacing insert or update operations.

Expand table insert and update operations to require insert-row, update-row, and delete-row together. Keep delete operations mapped to delete-row, and update the analysis UI/API to report and evaluate multiple required permissions for a single operation.

Refs https://github.com/simonw/datasette/pull/2749#issuecomment-4559083539
---
 datasette/stored_queries.py      | 108 ++++++++++++-----
 datasette/views/query_helpers.py |  27 +++--
 tests/test_queries.py            | 200 ++++++++++++++++++++++++++++++-
 3 files changed, 290 insertions(+), 45 deletions(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index 4b0fe6a6..cf44a9ff 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -588,10 +588,25 @@ async def list_queries(
     )
 
 
-PermissionRequirement = tuple[str, Resource]
+@dataclass(frozen=True)
+class PermissionRequirement:
+    action: str
+    resource: Resource
 
 
-def permission_for_operation(operation: Operation) -> PermissionRequirement | None:
+def row_mutation_requirements(
+    database: str, table: str
+) -> tuple[PermissionRequirement, ...]:
+    resource = TableResource(database=database, table=table)
+    return tuple(
+        PermissionRequirement(action=action, resource=resource)
+        for action in ("insert-row", "update-row", "delete-row")
+    )
+
+
+def permission_requirements_for_operation(
+    operation: Operation,
+) -> tuple[PermissionRequirement, ...]:
     if (
         operation.operation == "read"
         and operation.target_type == "table"
@@ -599,31 +614,45 @@ def permission_for_operation(operation: Operation) -> PermissionRequirement | No
         and operation.table is not None
     ):
         return (
-            "view-table",
-            TableResource(database=operation.database, table=operation.table),
+            PermissionRequirement(
+                action="view-table",
+                resource=TableResource(
+                    database=operation.database, table=operation.table
+                ),
+            ),
         )
-    write_actions = {
-        "insert": "insert-row",
-        "update": "update-row",
-        "delete": "delete-row",
-    }
-    action = write_actions.get(operation.operation)
     if (
-        action
+        operation.operation in {"insert", "update"}
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return row_mutation_requirements(
+            database=operation.database,
+            table=operation.table,
+        )
+    if (
+        operation.operation == "delete"
         and operation.target_type == "table"
         and operation.database is not None
         and operation.table is not None
     ):
         return (
-            action,
-            TableResource(database=operation.database, table=operation.table),
+            PermissionRequirement(
+                action="delete-row",
+                resource=TableResource(
+                    database=operation.database, table=operation.table
+                ),
+            ),
         )
     if operation.operation == "create" and operation.target_type == "table":
         if operation.database is None:
-            return None
+            return ()
         return (
-            "create-table",
-            DatabaseResource(database=operation.database),
+            PermissionRequirement(
+                action="create-table",
+                resource=DatabaseResource(database=operation.database),
+            ),
         )
     if (
         operation.operation == "alter"
@@ -632,8 +661,12 @@ def permission_for_operation(operation: Operation) -> PermissionRequirement | No
         and operation.table is not None
     ):
         return (
-            "alter-table",
-            TableResource(database=operation.database, table=operation.table),
+            PermissionRequirement(
+                action="alter-table",
+                resource=TableResource(
+                    database=operation.database, table=operation.table
+                ),
+            ),
         )
     if (
         operation.operation == "drop"
@@ -642,8 +675,12 @@ def permission_for_operation(operation: Operation) -> PermissionRequirement | No
         and operation.table is not None
     ):
         return (
-            "drop-table",
-            TableResource(database=operation.database, table=operation.table),
+            PermissionRequirement(
+                action="drop-table",
+                resource=TableResource(
+                    database=operation.database, table=operation.table
+                ),
+            ),
         )
     if (
         operation.operation in {"create", "drop"}
@@ -652,10 +689,14 @@ def permission_for_operation(operation: Operation) -> PermissionRequirement | No
         and operation.table is not None
     ):
         return (
-            "alter-table",
-            TableResource(database=operation.database, table=operation.table),
+            PermissionRequirement(
+                action="alter-table",
+                resource=TableResource(
+                    database=operation.database, table=operation.table
+                ),
+            ),
         )
-    return None
+    return ()
 
 
 def operation_should_be_ignored(operation: Operation) -> bool:
@@ -704,20 +745,23 @@ async def ensure_query_write_permissions(
     for operation in analysis.operations:
         if operation_should_be_ignored(operation):
             continue
-        permission = permission_for_operation(operation)
-        if permission is None:
+        permissions = permission_requirements_for_operation(operation)
+        if not permissions:
             raise Forbidden(
                 "Unsupported SQL operation: {} {}".format(
                     operation.operation, operation.target_type
                 )
             )
-        action, resource = permission
         if operation.database != database:
             raise Forbidden("Writable queries may not access attached databases")
-        if not await datasette.allowed(
-            action=action,
-            resource=resource,
-            actor=actor,
-        ):
-            raise Forbidden(f"Permission denied: need {action} on {resource}")
+        for permission in permissions:
+            if not await datasette.allowed(
+                action=permission.action,
+                resource=permission.resource,
+                actor=actor,
+            ):
+                raise Forbidden(
+                    f"Permission denied: need {permission.action} "
+                    f"on {permission.resource}"
+                )
     return analysis
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 05a0d73e..7f3ef1bc 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -6,7 +6,7 @@ from datasette.stored_queries import (
     StoredQuery,
     operation_is_write,
     operation_should_be_ignored,
-    permission_for_operation,
+    permission_requirements_for_operation,
 )
 from datasette.utils import (
     named_parameters as derive_named_parameters,
@@ -216,8 +216,10 @@ def _display_operations(analysis: SQLAnalysis) -> list[Operation]:
 def _analysis_rows(analysis: SQLAnalysis) -> list[dict[str, object]]:
     rows = []
     for operation in _display_operations(analysis):
-        permission = permission_for_operation(operation)
-        required_permission = permission[0] if permission else ""
+        permissions = permission_requirements_for_operation(operation)
+        required_permission = ", ".join(
+            permission.action for permission in permissions
+        )
         rows.append(
             {
                 "operation": operation.operation,
@@ -236,14 +238,17 @@ async def _analysis_rows_with_permissions(
     rows = _analysis_rows(analysis)
     is_write = _analysis_is_write(analysis)
     for row, operation in zip(rows, _display_operations(analysis)):
-        permission = permission_for_operation(operation)
-        if permission:
-            action, resource = permission
-            row["allowed"] = await datasette.allowed(
-                action=action,
-                resource=resource,
-                actor=actor,
-            )
+        permissions = permission_requirements_for_operation(operation)
+        if permissions:
+            row["allowed"] = True
+            for permission in permissions:
+                if not await datasette.allowed(
+                    action=permission.action,
+                    resource=permission.resource,
+                    actor=actor,
+                ):
+                    row["allowed"] = False
+                    break
         elif is_write:
             row["allowed"] = False
         else:
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 97ec973f..fcd19d1c 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -508,6 +508,8 @@ async def test_analyze_write_query_requires_table_permissions():
                     "dogs": {
                         "permissions": {
                             "insert-row": {"id": "writer"},
+                            "update-row": {"id": "writer"},
+                            "delete-row": {"id": "writer"},
                         }
                     }
                 }
@@ -1429,7 +1431,7 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
             "operation": "insert",
             "database": "data",
             "table": "dogs",
-            "required_permission": "insert-row",
+            "required_permission": "insert-row, update-row, delete-row",
             "source": None,
             "allowed": True,
         }
@@ -1627,6 +1629,40 @@ async def test_execute_write_post_requires_database_and_table_permissions():
             }
         }
     }
+    missing_update_permission = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={
+            "sql": "insert into dogs (name) values (:name)",
+            "params": {"name": "Cleo"},
+        },
+    )
+
+    assert missing_update_permission.status_code == 403
+    assert missing_update_permission.json()["errors"] == [
+        "Permission denied: need update-row on data/dogs"
+    ]
+
+    ds.config["databases"]["data"]["tables"]["dogs"]["permissions"][
+        "update-row"
+    ] = {"id": "writer"}
+    missing_delete_permission = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={
+            "sql": "insert into dogs (name) values (:name)",
+            "params": {"name": "Cleo"},
+        },
+    )
+
+    assert missing_delete_permission.status_code == 403
+    assert missing_delete_permission.json()["errors"] == [
+        "Permission denied: need delete-row on data/dogs"
+    ]
+
+    ds.config["databases"]["data"]["tables"]["dogs"]["permissions"][
+        "delete-row"
+    ] = {"id": "writer"}
     allowed = await ds.client.post(
         "/data/-/execute-write",
         actor={"id": "writer"},
@@ -1643,6 +1679,156 @@ async def test_execute_write_post_requires_database_and_table_permissions():
     assert (await db.execute("select name from dogs")).first()[0] == "Cleo"
 
 
+@pytest.mark.asyncio
+async def test_execute_write_insert_or_replace_requires_delete_row_permission():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    },
+                    "tables": {
+                        "users": {
+                            "permissions": {
+                                "insert-row": {"id": "writer"},
+                                "update-row": {"id": "writer"},
+                                "view-table": {"id": "writer"},
+                            }
+                        }
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_insert_or_replace", name="data")
+    await db.execute_write(
+        "create table users (id integer primary key, email text unique)"
+    )
+    await db.execute_write(
+        "insert into users (id, email) values "
+        "(1, 'a@example.com'), (2, 'b@example.com')"
+    )
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={
+            "sql": (
+                "insert or replace into users(id, email) "
+                "values (3, 'b@example.com')"
+            )
+        },
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Permission denied: need delete-row on data/users"
+    ]
+    assert (await db.execute("select id, email from users order by id")).dicts() == [
+        {"id": 1, "email": "a@example.com"},
+        {"id": 2, "email": "b@example.com"},
+    ]
+
+
+@pytest.mark.asyncio
+async def test_execute_write_update_or_replace_requires_delete_row_permission():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    },
+                    "tables": {
+                        "users": {
+                            "permissions": {
+                                "insert-row": {"id": "writer"},
+                                "update-row": {"id": "writer"},
+                                "view-table": {"id": "writer"},
+                            }
+                        }
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_update_or_replace", name="data")
+    await db.execute_write(
+        "create table users (id integer primary key, email text unique)"
+    )
+    await db.execute_write(
+        "insert into users (id, email) values "
+        "(1, 'a@example.com'), (2, 'b@example.com')"
+    )
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={"sql": "update or replace users set email = 'b@example.com' where id = 1"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Permission denied: need delete-row on data/users"
+    ]
+    assert (await db.execute("select id, email from users order by id")).dicts() == [
+        {"id": 1, "email": "a@example.com"},
+        {"id": 2, "email": "b@example.com"},
+    ]
+
+
+@pytest.mark.asyncio
+async def test_execute_write_update_requires_insert_row_permission():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    },
+                    "tables": {
+                        "users": {
+                            "permissions": {
+                                "update-row": {"id": "writer"},
+                                "delete-row": {"id": "writer"},
+                                "view-table": {"id": "writer"},
+                            }
+                        }
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_update_requires_insert", name="data")
+    await db.execute_write("create table users (id integer primary key, name text)")
+    await db.execute_write("insert into users (id, name) values (1, 'Alice')")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={"sql": "update users set name = 'Alicia' where id = 1"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Permission denied: need insert-row on data/users"
+    ]
+    assert (await db.execute("select name from users where id = 1")).first()[0] == "Alice"
+
+
 @pytest.mark.asyncio
 async def test_execute_write_insert_select_requires_view_table_on_source():
     ds = Datasette(
@@ -1659,7 +1845,13 @@ async def test_execute_write_insert_select_requires_view_table_on_source():
                         "secret": {
                             "permissions": {"view-table": {"id": "someone-else"}}
                         },
-                        "public_log": {"permissions": {"insert-row": {"id": "writer"}}},
+                        "public_log": {
+                            "permissions": {
+                                "insert-row": {"id": "writer"},
+                                "update-row": {"id": "writer"},
+                                "delete-row": {"id": "writer"},
+                            }
+                        },
                     },
                 }
             }
@@ -1740,6 +1932,8 @@ async def test_execute_write_rejects_function_operations():
                         "dogs": {
                             "permissions": {
                                 "insert-row": {"id": "writer"},
+                                "update-row": {"id": "writer"},
+                                "delete-row": {"id": "writer"},
                             }
                         }
                     },
@@ -2117,6 +2311,8 @@ async def test_user_writable_query_execution_rechecks_table_permissions():
                         "dogs": {
                             "permissions": {
                                 "insert-row": {"id": "alice"},
+                                "update-row": {"id": "alice"},
+                                "delete-row": {"id": "alice"},
                             }
                         }
                     },

From 1932f8429fd3259d48fb848fdf893f9a004276e9 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 27 May 2026 16:14:50 -0700
Subject: [PATCH 114/386] Deny user-authored schema table reads in write SQL

Stop marking sqlite_master and sqlite_schema reads as internal as soon as the SQLite authorizer reports them. The later DDL-aware pass still treats schema catalog access as internal when it accompanies semantic CREATE, ALTER, or DROP operations.

This makes explicit catalog reads in write SQL fall through to the deny-by-default path as unsupported read schema operations, preventing queries from copying private table definitions into writable tables.

Refs https://github.com/simonw/datasette/pull/2749#issuecomment-4559073803
---
 datasette/utils/sql_analysis.py  |  1 -
 datasette/views/query_helpers.py |  4 +-
 tests/test_queries.py            | 73 +++++++++++++++++++++++++++-----
 tests/test_utils_sql_analysis.py | 20 +++++++++
 4 files changed, 84 insertions(+), 14 deletions(-)

diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index 8963da77..91216501 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -256,7 +256,6 @@ def analyze_sql_tables(
                 target=arg1,
                 source=source,
                 column=column,
-                internal=target_type == "schema",
             )
             return sqlite3.SQLITE_OK
 
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 7f3ef1bc..0e3d4e01 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -217,9 +217,7 @@ def _analysis_rows(analysis: SQLAnalysis) -> list[dict[str, object]]:
     rows = []
     for operation in _display_operations(analysis):
         permissions = permission_requirements_for_operation(operation)
-        required_permission = ", ".join(
-            permission.action for permission in permissions
-        )
+        required_permission = ", ".join(permission.action for permission in permissions)
         rows.append(
             {
                 "operation": operation.operation,
diff --git a/tests/test_queries.py b/tests/test_queries.py
index fcd19d1c..40bc5052 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1643,9 +1643,9 @@ async def test_execute_write_post_requires_database_and_table_permissions():
         "Permission denied: need update-row on data/dogs"
     ]
 
-    ds.config["databases"]["data"]["tables"]["dogs"]["permissions"][
-        "update-row"
-    ] = {"id": "writer"}
+    ds.config["databases"]["data"]["tables"]["dogs"]["permissions"]["update-row"] = {
+        "id": "writer"
+    }
     missing_delete_permission = await ds.client.post(
         "/data/-/execute-write",
         actor={"id": "writer"},
@@ -1660,9 +1660,9 @@ async def test_execute_write_post_requires_database_and_table_permissions():
         "Permission denied: need delete-row on data/dogs"
     ]
 
-    ds.config["databases"]["data"]["tables"]["dogs"]["permissions"][
-        "delete-row"
-    ] = {"id": "writer"}
+    ds.config["databases"]["data"]["tables"]["dogs"]["permissions"]["delete-row"] = {
+        "id": "writer"
+    }
     allowed = await ds.client.post(
         "/data/-/execute-write",
         actor={"id": "writer"},
@@ -1719,8 +1719,7 @@ async def test_execute_write_insert_or_replace_requires_delete_row_permission():
         actor={"id": "writer"},
         json={
             "sql": (
-                "insert or replace into users(id, email) "
-                "values (3, 'b@example.com')"
+                "insert or replace into users(id, email) " "values (3, 'b@example.com')"
             )
         },
     )
@@ -1773,7 +1772,9 @@ async def test_execute_write_update_or_replace_requires_delete_row_permission():
     denied_response = await ds.client.post(
         "/data/-/execute-write",
         actor={"id": "writer"},
-        json={"sql": "update or replace users set email = 'b@example.com' where id = 1"},
+        json={
+            "sql": "update or replace users set email = 'b@example.com' where id = 1"
+        },
     )
 
     assert denied_response.status_code == 403
@@ -1826,7 +1827,9 @@ async def test_execute_write_update_requires_insert_row_permission():
     assert denied_response.json()["errors"] == [
         "Permission denied: need insert-row on data/users"
     ]
-    assert (await db.execute("select name from users where id = 1")).first()[0] == "Alice"
+    assert (await db.execute("select name from users where id = 1")).first()[
+        0
+    ] == "Alice"
 
 
 @pytest.mark.asyncio
@@ -1876,6 +1879,56 @@ async def test_execute_write_insert_select_requires_view_table_on_source():
     assert (await db.execute("select value from public_log")).dicts() == []
 
 
+@pytest.mark.asyncio
+async def test_execute_write_rejects_sqlite_master_reads():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    },
+                    "tables": {
+                        "secret": {
+                            "permissions": {"view-table": {"id": "someone-else"}}
+                        },
+                        "log": {
+                            "permissions": {
+                                "insert-row": {"id": "writer"},
+                                "update-row": {"id": "writer"},
+                                "delete-row": {"id": "writer"},
+                            }
+                        },
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_sqlite_master_read", name="data")
+    await db.execute_write("create table secret (value text)")
+    await db.execute_write("create table log (value text)")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={
+            "sql": (
+                "insert into log " "select sql from sqlite_master where name = 'secret'"
+            )
+        },
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Unsupported SQL operation: read schema"
+    ]
+    assert (await db.execute("select value from log")).dicts() == []
+
+
 @pytest.mark.asyncio
 async def test_execute_write_create_table_as_select_requires_view_table_on_source():
     ds = Datasette(
diff --git a/tests/test_utils_sql_analysis.py b/tests/test_utils_sql_analysis.py
index 2ae11502..f931be51 100644
--- a/tests/test_utils_sql_analysis.py
+++ b/tests/test_utils_sql_analysis.py
@@ -65,6 +65,26 @@ def test_analyze_uses_sqlite_schema_as_default_database(conn):
     }
 
 
+def test_analyze_user_schema_table_read_is_not_internal(conn):
+    analysis = analyze_sql_tables(
+        conn,
+        "insert into log select sql from sqlite_master where name = 'dogs'",
+        database_name="data",
+    )
+
+    assert {
+        "operation": "read",
+        "target_type": "schema",
+        "database": "data",
+        "sqlite_schema": "main",
+        "table": None,
+        "target": "sqlite_master",
+        "columns": ("name", "sql"),
+        "source": None,
+        "internal": False,
+    } in [operation_dict(operation) for operation in analysis.operations]
+
+
 def operation_dict(operation):
     return {
         "operation": operation.operation,

From 951f5a9f306ebe0bb8b3668ee698dc6cb6051d78 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 27 May 2026 16:30:05 -0700
Subject: [PATCH 115/386] Detect VACUUM in SQL analysis

Refs https://github.com/simonw/datasette/pull/2749#issuecomment-4559073803
---
 datasette/stored_queries.py      |  1 +
 datasette/utils/sql_analysis.py  | 33 +++++++++++++++++++++++-
 tests/test_queries.py            | 31 ++++++++++++++++++++++
 tests/test_utils_sql_analysis.py | 44 ++++++++++++++++++++++++++++++++
 4 files changed, 108 insertions(+), 1 deletion(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index cf44a9ff..6746124a 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -720,6 +720,7 @@ def operation_is_write(operation: Operation) -> bool:
         "pragma",
         "analyze",
         "reindex",
+        "vacuum",
         "unknown",
     }
 
diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index 91216501..f2eb903f 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -22,6 +22,7 @@ SQLOperation = Literal[
     "pragma",
     "analyze",
     "reindex",
+    "vacuum",
     "unknown",
 ]
 SQLTargetType = Literal[
@@ -423,10 +424,40 @@ def analyze_sql_tables(
 
     conn.set_authorizer(authorizer)
     try:
-        conn.execute("EXPLAIN " + sql, params if params is not None else {}).fetchall()
+        explain_rows = conn.execute(
+            "EXPLAIN " + sql, params if params is not None else {}
+        ).fetchall()
     finally:
         conn.set_authorizer(None)
 
+    if not operations:
+        vacuum_row = next((row for row in explain_rows if row[1] == "Vacuum"), None)
+        if vacuum_row is not None:
+            schema_by_index = {
+                row[0]: row[1] for row in conn.execute("PRAGMA database_list")
+            }
+            sqlite_schema = schema_by_index.get(vacuum_row[2])
+            database = database_for_schema(sqlite_schema)
+            record(
+                "vacuum",
+                "database",
+                database=database,
+                table=None,
+                sqlite_schema=sqlite_schema,
+                target=database,
+                source=None,
+            )
+        else:
+            record(
+                "unknown",
+                "statement",
+                database=database_name,
+                table=None,
+                sqlite_schema=None,
+                target=None,
+                source=None,
+            )
+
     has_schema_operation = any(
         key.target_type in {"table", "index", "view", "trigger", "virtual-table"}
         and key.operation in {"create", "alter", "drop"}
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 40bc5052..bf371a80 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -2011,6 +2011,37 @@ async def test_execute_write_rejects_function_operations():
     assert (await db.execute("select name from dogs")).dicts() == []
 
 
+@pytest.mark.asyncio
+async def test_execute_write_rejects_vacuum_operation():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("execute_write_vacuum_operation", name="data")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        json={"sql": "vacuum"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Unsupported SQL operation: vacuum database"
+    ]
+
+
 @pytest.mark.asyncio
 async def test_execute_write_create_table_uses_create_table_permission():
     ds = Datasette(
diff --git a/tests/test_utils_sql_analysis.py b/tests/test_utils_sql_analysis.py
index f931be51..df4b3625 100644
--- a/tests/test_utils_sql_analysis.py
+++ b/tests/test_utils_sql_analysis.py
@@ -129,6 +129,50 @@ def test_analyze_create_table_operation():
     ]
 
 
+def test_analyze_vacuum_operation():
+    conn = sqlite3.connect(":memory:")
+    try:
+        analysis = analyze_sql_tables(conn, "vacuum", database_name="data")
+    finally:
+        conn.close()
+
+    assert [operation_dict(operation) for operation in analysis.operations] == [
+        {
+            "operation": "vacuum",
+            "target_type": "database",
+            "database": "data",
+            "sqlite_schema": "main",
+            "table": None,
+            "target": "data",
+            "columns": (),
+            "source": None,
+            "internal": False,
+        }
+    ]
+
+
+def test_analyze_statement_with_no_authorizer_callbacks_is_unknown():
+    conn = sqlite3.connect(":memory:")
+    try:
+        analysis = analyze_sql_tables(conn, "reindex", database_name="data")
+    finally:
+        conn.close()
+
+    assert [operation_dict(operation) for operation in analysis.operations] == [
+        {
+            "operation": "unknown",
+            "target_type": "statement",
+            "database": "data",
+            "sqlite_schema": None,
+            "table": None,
+            "target": None,
+            "columns": (),
+            "source": None,
+            "internal": False,
+        }
+    ]
+
+
 def test_analyze_transaction_operation(conn):
     analysis = analyze_sql_tables(conn, "commit", database_name="data")
 

From 11bddc891918849e7c4a006c64d0217072aa499c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 27 May 2026 16:51:12 -0700
Subject: [PATCH 116/386] Deny VACUUM in user-authored SQL

Reject VACUUM explicitly during write-query permission analysis so arbitrary write SQL and untrusted stored write queries cannot run it, even when the actor has execute-write-sql.

Refs https://github.com/simonw/datasette/pull/2749#issuecomment-4559073803 (P3)
---
 datasette/stored_queries.py      |  16 ++++
 datasette/views/database.py      |  23 ++++-
 datasette/views/execute_write.py |   6 +-
 datasette/views/query_helpers.py |   9 +-
 tests/test_queries.py            | 153 ++++++++++++++++++++++++++++++-
 5 files changed, 199 insertions(+), 8 deletions(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index 6746124a..fd1cabf3 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -15,6 +15,13 @@ if TYPE_CHECKING:
 
 UNCHANGED = object()
 
+
+class QueryWriteRejected(Exception):
+    def __init__(self, message: str):
+        self.message = message
+        super().__init__(message)
+
+
 QUERY_OPTION_FIELDS = (
     "hide_sql",
     "fragment",
@@ -703,6 +710,12 @@ def operation_should_be_ignored(operation: Operation) -> bool:
     return operation.internal or operation.operation == "select"
 
 
+def operation_forbidden_message(operation: Operation) -> str | None:
+    if operation.operation == "vacuum":
+        return "VACUUM is not allowed in user-supplied SQL"
+    return None
+
+
 def operation_is_write(operation: Operation) -> bool:
     return operation.operation in {
         "insert",
@@ -746,6 +759,9 @@ async def ensure_query_write_permissions(
     for operation in analysis.operations:
         if operation_should_be_ignored(operation):
             continue
+        forbidden_message = operation_forbidden_message(operation)
+        if forbidden_message is not None:
+            raise QueryWriteRejected(forbidden_message)
         permissions = permission_requirements_for_operation(operation)
         if not permissions:
             raise Forbidden(
diff --git a/datasette/views/database.py b/datasette/views/database.py
index b558b002..ae1cf375 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -13,7 +13,7 @@ import textwrap
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.database import QueryInterrupted
 from datasette.resources import DatabaseResource, QueryResource
-from datasette.stored_queries import stored_query_to_dict
+from datasette.stored_queries import QueryWriteRejected, stored_query_to_dict
 from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
@@ -453,9 +453,24 @@ class QueryView(View):
         ):
             raise Forbidden("You do not have permission to view this query")
 
-        await _ensure_stored_query_execution_permissions(
-            datasette, db, stored_query, request.actor
-        )
+        try:
+            await _ensure_stored_query_execution_permissions(
+                datasette, db, stored_query, request.actor
+            )
+        except QueryWriteRejected as ex:
+            if request.headers.get("accept") == "application/json" or request.args.get(
+                "_json"
+            ):
+                return Response.json(
+                    {
+                        "ok": False,
+                        "message": ex.message,
+                        "redirect": None,
+                    },
+                    status=403,
+                )
+            datasette.add_message(request, ex.message, datasette.ERROR)
+            return Response.redirect(stored_query.on_error_redirect or request.path)
 
         # If database is immutable, return an error
         if not db.is_mutable:
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index 19006ac5..57c4d78e 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -163,13 +163,15 @@ class ExecuteWriteView(BaseView):
         except QueryValidationError as ex:
             if _wants_json(request, is_json, data):
                 return _block_framing(_error([ex.message], ex.status))
+            if ex.flash:
+                self.ds.add_message(request, ex.message, self.ds.ERROR)
             return await self._render_form(
                 request,
                 db,
                 sql=sql or "",
                 parameter_values=provided_params,
-                analysis_error=ex.message,
-                execution_message=ex.message,
+                analysis_error=None if ex.flash else ex.message,
+                execution_message=None if ex.flash else ex.message,
                 execution_ok=False,
                 status=ex.status,
             )
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 0e3d4e01..92328ff3 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -3,6 +3,7 @@ import re
 
 from datasette.resources import DatabaseResource
 from datasette.stored_queries import (
+    QueryWriteRejected,
     StoredQuery,
     operation_is_write,
     operation_should_be_ignored,
@@ -47,9 +48,11 @@ _query_write_fields = {
 
 
 class QueryValidationError(Exception):
-    def __init__(self, message, status=400):
+    def __init__(self, message, status=400, *, flash=False):
         self.message = message
         self.status = status
+        self.flash = flash
+        super().__init__(message)
 
 
 def _actor_id(actor):
@@ -194,6 +197,8 @@ async def _analyze_user_query(datasette, db, sql, *, actor):
             await datasette.ensure_query_write_permissions(
                 db.name, sql, actor=actor, analysis=analysis
             )
+        except QueryWriteRejected as ex:
+            raise QueryValidationError(ex.message, status=403, flash=True) from ex
         except Forbidden as ex:
             raise QueryValidationError(str(ex), status=403) from ex
     else:
@@ -297,6 +302,8 @@ async def _prepare_execute_write(datasette, db, sql, params, actor):
         await datasette.ensure_query_write_permissions(
             db.name, sql, actor=actor, analysis=analysis
         )
+    except QueryWriteRejected as ex:
+        raise QueryValidationError(ex.message, status=403, flash=True) from ex
     except Forbidden as ex:
         raise QueryValidationError(str(ex), status=403) from ex
     return parameter_names, params, analysis
diff --git a/tests/test_queries.py b/tests/test_queries.py
index bf371a80..b6e1637d 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -2038,10 +2038,161 @@ async def test_execute_write_rejects_vacuum_operation():
 
     assert denied_response.status_code == 403
     assert denied_response.json()["errors"] == [
-        "Unsupported SQL operation: vacuum database"
+        "VACUUM is not allowed in user-supplied SQL"
     ]
 
 
+@pytest.mark.asyncio
+async def test_execute_write_form_rejects_vacuum_operation_with_flash_error():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("execute_write_vacuum_operation_form", name="data")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "writer"},
+        data={"sql": "vacuum"},
+    )
+
+    assert denied_response.status_code == 403
+    assert (
+        '<p class="message-error">VACUUM is not allowed in user-supplied SQL</p>'
+        in denied_response.text
+    )
+    assert denied_response.text.count("VACUUM is not allowed in user-supplied SQL") == 1
+
+
+@pytest.mark.asyncio
+async def test_untrusted_stored_write_query_rejects_vacuum_operation():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "view-query": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("stored_query_vacuum_operation", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "vacuum_db",
+        "vacuum",
+        is_write=True,
+        is_trusted=False,
+        source="user",
+        owner_id="writer",
+    )
+
+    denied_response = await ds.client.post(
+        "/data/vacuum_db?_json=1",
+        actor={"id": "writer"},
+        data={},
+    )
+
+    assert denied_response.status_code == 403
+    assert "VACUUM is not allowed in user-supplied SQL" in denied_response.text
+
+
+@pytest.mark.asyncio
+async def test_untrusted_stored_write_query_rejects_vacuum_operation_with_flash_error():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "view-query": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("stored_query_vacuum_operation_form", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "vacuum_db",
+        "vacuum",
+        is_write=True,
+        is_trusted=False,
+        source="user",
+        owner_id="writer",
+    )
+
+    denied_response = await ds.client.post(
+        "/data/vacuum_db",
+        actor={"id": "writer"},
+        data={},
+    )
+
+    assert denied_response.status_code == 302
+    assert denied_response.headers["location"] == "/data/vacuum_db"
+    assert ds.unsign(denied_response.cookies["ds_messages"], "messages") == [
+        ["VACUUM is not allowed in user-supplied SQL", ds.ERROR]
+    ]
+
+
+@pytest.mark.asyncio
+async def test_trusted_stored_write_query_skips_vacuum_filtering():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "view-query": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    ds.add_memory_database("trusted_stored_query_vacuum", name="data")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "trusted_vacuum",
+        "vacuum",
+        is_write=True,
+        is_trusted=True,
+        source="config",
+    )
+
+    response = await ds.client.post(
+        "/data/trusted_vacuum?_json=1",
+        actor={"id": "writer"},
+        data={},
+    )
+
+    assert response.status_code == 200
+    assert response.json()["ok"] is True
+
+
 @pytest.mark.asyncio
 async def test_execute_write_create_table_uses_create_table_permission():
     ds = Datasette(

From 0c5053cdf64a0dc2d1e9808fa712b88233760512 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 27 May 2026 17:26:50 -0700
Subject: [PATCH 117/386] Docs for /<database>/-/execute-write JSON API

Closes #2750, refs #2742
---
 docs/json_api.rst | 62 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/docs/json_api.rst b/docs/json_api.rst
index 48c70af6..fffc16d7 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -505,6 +505,68 @@ The JSON write API
 
 Datasette provides a write API for JSON data. This is a POST-only API that requires an authenticated API token, see :ref:`CreateTokenView`. The token will need to have the specified :ref:`authentication_permissions`.
 
+.. _ExecuteWriteView:
+
+Executing write SQL
+~~~~~~~~~~~~~~~~~~~
+
+Actors with the :ref:`actions_execute_write_sql` permission can execute arbitrary writable SQL against a mutable database using ``/-/execute-write``.
+
+::
+
+    POST /<database>/-/execute-write
+    Content-Type: application/json
+    Authorization: Bearer dstok_<rest-of-token>
+
+The request body must include a ``"sql"`` string. Named SQL parameters can be provided using the optional ``"params"`` object:
+
+.. code-block:: json
+
+    {
+        "sql": "insert into dogs (name) values (:name)",
+        "params": {
+            "name": "Cleo"
+        }
+    }
+
+The SQL must be writable. Read-only ``select`` queries should use the regular :ref:`custom SQL query API <sql>` instead.
+
+Datasette analyzes the SQL before executing it. The actor must have ``execute-write-sql`` permission for the database, and must also have any permissions required by the operations in the SQL. For example, inserts and updates against a table require ``insert-row``, ``update-row`` and ``delete-row`` permissions for that table. Reads performed as part of the write, such as ``insert into dogs select ... from other_table``, require ``view-table`` permission on the source table.
+
+A successful response includes a message, the SQLite ``rowcount`` and a summary of the operations that were executed:
+
+The shape of the ``"analysis"`` block is not yet considered a stable API and may change in future Datasette releases.
+
+.. code-block:: json
+
+    {
+        "ok": true,
+        "message": "Query executed, 1 row affected",
+        "rowcount": 1,
+        "analysis": [
+            {
+                "operation": "insert",
+                "database": "data",
+                "table": "dogs",
+                "required_permission": "insert-row, update-row, delete-row",
+                "source": null
+            }
+        ]
+    }
+
+If SQLite reports ``-1`` for the row count, the message will be ``"Query executed"``.
+
+Errors use the standard Datasette error format:
+
+.. code-block:: json
+
+    {
+        "ok": false,
+        "errors": [
+            "Permission denied: need execute-write-sql"
+        ]
+    }
+
 .. _TableInsertView:
 
 Inserting rows

From bcd989f4f8802a73a60c75f9bda77649c1347986 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 08:36:59 -0700
Subject: [PATCH 118/386] Detect and disallow insert to virtual/shadow table

Refs https://github.com/simonw/datasette/pull/2749#issuecomment-4565727978
---
 datasette/stored_queries.py      |   5 +
 datasette/utils/sql_analysis.py  |  21 ++++-
 datasette/utils/sqlite.py        | 112 ++++++++++++++++++++++
 tests/test_queries.py            | 153 +++++++++++++++++++++++++++++++
 tests/test_utils.py              |  45 ++++++++-
 tests/test_utils_sql_analysis.py |  47 ++++++++++
 6 files changed, 381 insertions(+), 2 deletions(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index fd1cabf3..b5aea221 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -713,6 +713,11 @@ def operation_should_be_ignored(operation: Operation) -> bool:
 def operation_forbidden_message(operation: Operation) -> str | None:
     if operation.operation == "vacuum":
         return "VACUUM is not allowed in user-supplied SQL"
+    if operation.operation in {"insert", "update", "delete"}:
+        if operation.table_kind == "virtual":
+            return "Writes to virtual tables are not allowed in user-supplied SQL"
+        if operation.table_kind == "shadow":
+            return "Writes to shadow tables are not allowed in user-supplied SQL"
     return None
 
 
diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index f2eb903f..a71fa315 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -1,7 +1,7 @@
 from dataclasses import dataclass
 from typing import Literal
 
-from datasette.utils.sqlite import sqlite3
+from datasette.utils.sqlite import SQLiteTableType, sqlite3, sqlite_table_type
 
 SQLOperation = Literal[
     "read",
@@ -42,6 +42,7 @@ SQLTargetType = Literal[
 SQLTableOperation = Literal["read", "insert", "update", "delete"]
 SQLSchemaOperation = Literal["create", "drop"]
 SQLSchemaTargetType = Literal["index", "table", "trigger", "view", "virtual-table"]
+SQLTableKind = SQLiteTableType
 
 
 @dataclass(frozen=True)
@@ -51,6 +52,7 @@ class Operation:
     database: str | None
     table: str | None
     sqlite_schema: str | None
+    table_kind: SQLTableKind | None = None
     target: str | None = None
     columns: tuple[str, ...] = ()
     source: str | None = None
@@ -500,6 +502,22 @@ def analyze_sql_tables(
             return True
         return False
 
+    table_kind_cache: dict[tuple[str | None, str], SQLTableKind | None] = {}
+
+    def table_kind_for(key: OperationKey) -> SQLTableKind | None:
+        if (
+            key.target_type != "table"
+            or key.operation not in {"read", "insert", "update", "delete"}
+            or key.table is None
+        ):
+            return None
+        cache_key = (key.sqlite_schema, key.table)
+        if cache_key not in table_kind_cache:
+            table_kind_cache[cache_key] = sqlite_table_type(
+                conn, key.table, schema=key.sqlite_schema
+            )
+        return table_kind_cache[cache_key]
+
     return SQLAnalysis(
         operations=tuple(
             Operation(
@@ -508,6 +526,7 @@ def analyze_sql_tables(
                 database=key.database,
                 table=key.table,
                 sqlite_schema=key.sqlite_schema,
+                table_kind=table_kind_for(key),
                 target=key.target,
                 columns=tuple(sorted(columns)),
                 source=key.source,
diff --git a/datasette/utils/sqlite.py b/datasette/utils/sqlite.py
index d0a2d783..130c5f62 100644
--- a/datasette/utils/sqlite.py
+++ b/datasette/utils/sqlite.py
@@ -1,3 +1,6 @@
+import re
+from typing import Literal
+
 using_pysqlite3 = False
 try:
     import pysqlite3 as sqlite3
@@ -10,6 +13,18 @@ if hasattr(sqlite3, "enable_callback_tracebacks"):
     sqlite3.enable_callback_tracebacks(True)
 
 _cached_sqlite_version = None
+SQLiteTableType = Literal["table", "view", "virtual", "shadow"]
+_VIRTUAL_TABLE_MODULE_RE = re.compile(
+    r"\bCREATE\s+VIRTUAL\s+TABLE\b.*?\bUSING\s+([^\s(]+)",
+    re.IGNORECASE,
+)
+_VIRTUAL_TABLE_SHADOW_SUFFIXES = {
+    "fts3": ("_content", "_segdir", "_segments", "_stat", "_docsize"),
+    "fts4": ("_content", "_segdir", "_segments", "_stat", "_docsize"),
+    "fts5": ("_data", "_idx", "_docsize", "_content", "_config"),
+    "rtree": ("_node", "_parent", "_rowid"),
+    "rtree_i32": ("_node", "_parent", "_rowid"),
+}
 
 
 def sqlite_version():
@@ -36,5 +51,102 @@ def supports_table_xinfo():
     return sqlite_version() >= (3, 26, 0)
 
 
+def supports_table_list():
+    return sqlite_version() >= (3, 37, 0)
+
+
 def supports_generated_columns():
     return sqlite_version() >= (3, 31, 0)
+
+
+def sqlite_table_type(
+    conn,
+    table: str,
+    *,
+    schema: str | None = "main",
+) -> SQLiteTableType | None:
+    if supports_table_list():
+        try:
+            query = "select type from pragma_table_list where name = ?"
+            params: tuple[str, ...] = (table,)
+            if schema is not None:
+                query += " and schema = ?"
+                params = (table, schema)
+            row = conn.execute(query, params).fetchone()
+            if row is not None and row[0] in {"table", "view", "virtual", "shadow"}:
+                return row[0]
+        except sqlite3.DatabaseError:
+            pass
+    return _sqlite_table_type_from_schema(conn, table, schema=schema)
+
+
+def _sqlite_table_type_from_schema(
+    conn,
+    table: str,
+    *,
+    schema: str | None = "main",
+) -> SQLiteTableType | None:
+    schema_table = _sqlite_schema_table(schema)
+    try:
+        row = conn.execute(
+            "select type, sql from {} where name = ?".format(schema_table),
+            (table,),
+        ).fetchone()
+    except sqlite3.DatabaseError:
+        return None
+    if row is None:
+        return None
+    object_type, sql = row
+    if object_type == "view":
+        return "view"
+    if object_type != "table":
+        return None
+    if _virtual_table_module(sql) is not None:
+        return "virtual"
+    if _is_known_shadow_table(conn, table, schema=schema):
+        return "shadow"
+    return "table"
+
+
+def _is_known_shadow_table(
+    conn,
+    table: str,
+    *,
+    schema: str | None = "main",
+) -> bool:
+    schema_table = _sqlite_schema_table(schema)
+    try:
+        rows = conn.execute(
+            "select name, sql from {} where type = 'table'".format(schema_table)
+        ).fetchall()
+    except sqlite3.DatabaseError:
+        return False
+    for virtual_table, sql in rows:
+        module = _virtual_table_module(sql)
+        if module is None:
+            continue
+        for suffix in _VIRTUAL_TABLE_SHADOW_SUFFIXES.get(module, ()):
+            if table == virtual_table + suffix:
+                return True
+    return False
+
+
+def _sqlite_schema_table(schema: str | None) -> str:
+    if schema is None or schema == "main":
+        return "sqlite_master"
+    if schema == "temp":
+        return "sqlite_temp_master"
+    return "{}.sqlite_master".format(_quote_identifier(schema))
+
+
+def _quote_identifier(value: str) -> str:
+    return '"{}"'.format(value.replace('"', '""'))
+
+
+def _virtual_table_module(sql: str | None) -> str | None:
+    if not sql:
+        return None
+    match = _VIRTUAL_TABLE_MODULE_RE.search(sql)
+    if match is None:
+        return None
+    return match.group(1).strip("\"'[]`").lower()
diff --git a/tests/test_queries.py b/tests/test_queries.py
index b6e1637d..73f8f3cf 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -2193,6 +2193,159 @@ async def test_trusted_stored_write_query_skips_vacuum_filtering():
     assert response.json()["ok"] is True
 
 
+@pytest.mark.asyncio
+async def test_execute_write_rejects_virtual_table_control_insert():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_virtual_table_control", name="data")
+    await db.execute_write("""
+        create virtual table docs using fts5(title, body, content='')
+    """)
+    await db.execute_write("""
+        insert into docs(rowid, title, body) values (1, 'hello', 'world')
+    """)
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        json={"sql": "insert into docs(docs) values('delete-all')"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Writes to virtual tables are not allowed in user-supplied SQL"
+    ]
+    assert (
+        await db.execute("select count(*) from docs where docs match 'hello'")
+    ).first()[0] == 1
+
+
+@pytest.mark.asyncio
+async def test_execute_write_rejects_regular_virtual_table_insert():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_virtual_table_insert", name="data")
+    await db.execute_write("create virtual table docs using fts5(title, body)")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        json={"sql": "insert into docs(rowid, title, body) values (1, 'a', 'b')"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Writes to virtual tables are not allowed in user-supplied SQL"
+    ]
+    assert (await db.execute("select count(*) from docs")).first()[0] == 0
+
+
+@pytest.mark.asyncio
+async def test_execute_write_rejects_shadow_table_insert():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_shadow_table_insert", name="data")
+    await db.execute_write("create virtual table docs using fts5(title, body)")
+    await ds.invoke_startup()
+
+    denied_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        json={"sql": "insert into docs_config(k, v) values ('x', 1)"},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [
+        "Writes to shadow tables are not allowed in user-supplied SQL"
+    ]
+    assert (await db.execute("select count(*) from docs_config")).first()[0] == 1
+
+
+@pytest.mark.asyncio
+async def test_untrusted_stored_write_query_rejects_virtual_table_control_insert():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("stored_query_virtual_table_control", name="data")
+    await db.execute_write("""
+        create virtual table docs using fts5(title, body, content='')
+    """)
+    await db.execute_write("""
+        insert into docs(rowid, title, body) values (1, 'hello', 'world')
+    """)
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "delete_all_docs",
+        "insert into docs(docs) values('delete-all')",
+        is_write=True,
+        is_trusted=False,
+        source="user",
+        owner_id="root",
+    )
+
+    denied_response = await ds.client.post(
+        "/data/delete_all_docs?_json=1",
+        actor={"id": "root"},
+        data={},
+    )
+
+    assert denied_response.status_code == 403
+    assert denied_response.json()["message"] == (
+        "Writes to virtual tables are not allowed in user-supplied SQL"
+    )
+    assert (
+        await db.execute("select count(*) from docs where docs match 'hello'")
+    ).first()[0] == 1
+
+
+@pytest.mark.asyncio
+async def test_trusted_stored_write_query_can_write_virtual_table():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "view-query": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("trusted_stored_query_virtual_table", name="data")
+    await db.execute_write("""
+        create virtual table docs using fts5(title, body, content='')
+    """)
+    await db.execute_write("""
+        insert into docs(rowid, title, body) values (1, 'hello', 'world')
+    """)
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "trusted_delete_all",
+        "insert into docs(docs) values('delete-all')",
+        is_write=True,
+        is_trusted=True,
+        source="config",
+    )
+
+    response = await ds.client.post(
+        "/data/trusted_delete_all?_json=1",
+        actor={"id": "writer"},
+        data={},
+    )
+
+    assert response.status_code == 200
+    assert response.json()["ok"] is True
+    assert (
+        await db.execute("select count(*) from docs where docs match 'hello'")
+    ).first()[0] == 0
+
+
 @pytest.mark.asyncio
 async def test_execute_write_create_table_uses_create_table_permission():
     ds = Datasette(
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 3fcb623e..e142bb5b 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -5,7 +5,7 @@ Tests for various datasette helper functions.
 from datasette.app import Datasette
 from datasette import utils
 from datasette.utils.asgi import Request
-from datasette.utils.sqlite import sqlite3
+from datasette.utils.sqlite import sqlite3, sqlite_table_type
 import json
 import os
 import pathlib
@@ -226,6 +226,49 @@ def test_detect_fts_different_table_names(table):
     conn.close()
 
 
+@pytest.mark.parametrize("use_fallback", (False, True))
+def test_sqlite_table_type_detects_virtual_and_shadow_tables(monkeypatch, use_fallback):
+    if use_fallback:
+        monkeypatch.setattr("datasette.utils.sqlite.sqlite_version", lambda: (3, 25, 0))
+    conn = utils.sqlite3.connect(":memory:")
+    try:
+        conn.executescript("""
+            create table dogs(id integer primary key, name text);
+            create view dog_names as select name from dogs;
+            create virtual table search_index using fts5(title, body);
+            create virtual table boxes using rtree(id, minx, maxx, miny, maxy);
+        """)
+
+        assert sqlite_table_type(conn, "dogs") == "table"
+        assert sqlite_table_type(conn, "dog_names") == "view"
+        assert sqlite_table_type(conn, "search_index") == "virtual"
+        assert sqlite_table_type(conn, "search_index_config") == "shadow"
+        assert sqlite_table_type(conn, "boxes") == "virtual"
+        assert sqlite_table_type(conn, "boxes_node") == "shadow"
+        assert sqlite_table_type(conn, "missing") is None
+    finally:
+        conn.close()
+
+
+@pytest.mark.parametrize("use_fallback", (False, True))
+def test_sqlite_table_type_detects_attached_database_tables(monkeypatch, use_fallback):
+    if use_fallback:
+        monkeypatch.setattr("datasette.utils.sqlite.sqlite_version", lambda: (3, 25, 0))
+    conn = utils.sqlite3.connect(":memory:")
+    try:
+        conn.executescript("""
+            attach database ':memory:' as extra;
+            create table extra.cats(id integer primary key, name text);
+            create virtual table extra.cat_search using fts5(name);
+        """)
+
+        assert sqlite_table_type(conn, "cats", schema="extra") == "table"
+        assert sqlite_table_type(conn, "cat_search", schema="extra") == "virtual"
+        assert sqlite_table_type(conn, "cat_search_data", schema="extra") == "shadow"
+    finally:
+        conn.close()
+
+
 @pytest.mark.parametrize(
     "url,expected",
     [
diff --git a/tests/test_utils_sql_analysis.py b/tests/test_utils_sql_analysis.py
index df4b3625..979ff9e1 100644
--- a/tests/test_utils_sql_analysis.py
+++ b/tests/test_utils_sql_analysis.py
@@ -260,6 +260,53 @@ def test_analyze_create_virtual_table_operation():
     } in [operation_dict(operation) for operation in analysis.operations]
 
 
+def test_analyze_table_kind_for_regular_virtual_and_shadow_tables():
+    conn = sqlite3.connect(":memory:")
+    try:
+        conn.executescript("""
+            create table dogs (id integer primary key, name text);
+            create virtual table docs using fts5(title, body, content='');
+        """)
+
+        regular_analysis = analyze_sql_tables(
+            conn,
+            "insert into dogs (name) values ('Cleo')",
+            database_name="data",
+        )
+        virtual_analysis = analyze_sql_tables(
+            conn,
+            "insert into docs(docs) values('delete-all')",
+            database_name="data",
+        )
+        shadow_analysis = analyze_sql_tables(
+            conn,
+            "insert into docs_config(k, v) values ('x', 1)",
+            database_name="data",
+        )
+    finally:
+        conn.close()
+
+    regular_insert = next(
+        operation
+        for operation in regular_analysis.operations
+        if operation.operation == "insert" and operation.table == "dogs"
+    )
+    virtual_insert = next(
+        operation
+        for operation in virtual_analysis.operations
+        if operation.operation == "insert" and operation.table == "docs"
+    )
+    shadow_insert = next(
+        operation
+        for operation in shadow_analysis.operations
+        if operation.operation == "insert" and operation.table == "docs_config"
+    )
+
+    assert regular_insert.table_kind == "table"
+    assert virtual_insert.table_kind == "virtual"
+    assert shadow_insert.table_kind == "shadow"
+
+
 def test_analyze_create_table_as_select_function_is_not_internal():
     conn = sqlite3.connect(":memory:")
     try:

From aaf00e9ec22b77e53f291ccedcbf2f499cce9e2b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 08:42:06 -0700
Subject: [PATCH 119/386] Refactor hidden_table_names() to use new
 implemenatation

Refs https://github.com/simonw/datasette/pull/2749#issuecomment-4565727978
---
 datasette/database.py            | 80 +-------------------------------
 datasette/utils/sqlite.py        | 29 ++++++++++++
 tests/test_internals_database.py |  9 +---
 tests/test_utils.py              | 12 ++++-
 4 files changed, 43 insertions(+), 87 deletions(-)

diff --git a/datasette/database.py b/datasette/database.py
index e7e9527e..10417670 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -26,7 +26,7 @@ from .utils import (
     table_column_details,
 )
 from .utils.sql_analysis import SQLAnalysis, analyze_sql_tables
-from .utils.sqlite import sqlite_version
+from .utils.sqlite import sqlite_hidden_table_names
 from .inspect import inspect_hash
 
 connections = threading.local()
@@ -702,83 +702,7 @@ class Database:
                 t for t in db_config["tables"] if db_config["tables"][t].get("hidden")
             ]
 
-        if sqlite_version()[1] >= 37:
-            hidden_tables += [x[0] for x in await self.execute("""
-                      with shadow_tables as (
-                        select name
-                        from pragma_table_list
-                        where [type] = 'shadow'
-                        order by name
-                      ),
-                      core_tables as (
-                        select name
-                        from sqlite_master
-                        WHERE  name in ('sqlite_stat1', 'sqlite_stat2', 'sqlite_stat3', 'sqlite_stat4')
-                          OR substr(name, 1, 1) == '_'
-                      ),
-                      combined as (
-                        select name from shadow_tables
-                        union all
-                        select name from core_tables
-                      )
-                      select name from combined order by 1
-                    """)]
-        else:
-            hidden_tables += [x[0] for x in await self.execute("""
-                      WITH base AS (
-                        SELECT name
-                        FROM sqlite_master
-                        WHERE  name IN ('sqlite_stat1', 'sqlite_stat2', 'sqlite_stat3', 'sqlite_stat4')
-                          OR substr(name, 1, 1) == '_'
-                      ),
-                      fts_suffixes AS (
-                        SELECT column1 AS suffix
-                        FROM (VALUES ('_data'), ('_idx'), ('_docsize'), ('_content'), ('_config'))
-                      ),
-                      fts5_names AS (
-                        SELECT name
-                        FROM sqlite_master
-                        WHERE sql LIKE '%VIRTUAL TABLE%USING FTS%'
-                      ),
-                      fts5_shadow_tables AS (
-                        SELECT
-                          printf('%s%s', fts5_names.name, fts_suffixes.suffix) AS name
-                        FROM fts5_names
-                        JOIN fts_suffixes
-                      ),
-                      fts3_suffixes AS (
-                        SELECT column1 AS suffix
-                        FROM (VALUES ('_content'), ('_segdir'), ('_segments'), ('_stat'), ('_docsize'))
-                      ),
-                      fts3_names AS (
-                        SELECT name
-                        FROM sqlite_master
-                        WHERE sql LIKE '%VIRTUAL TABLE%USING FTS3%'
-                          OR sql LIKE '%VIRTUAL TABLE%USING FTS4%'
-                      ),
-                      fts3_shadow_tables AS (
-                        SELECT
-                          printf('%s%s', fts3_names.name, fts3_suffixes.suffix) AS name
-                        FROM fts3_names
-                        JOIN fts3_suffixes
-                      ),
-                      final AS (
-                        SELECT name FROM base
-                        UNION ALL
-                        SELECT name FROM fts5_shadow_tables
-                        UNION ALL
-                        SELECT name FROM fts3_shadow_tables
-                      )
-                      SELECT name FROM final ORDER BY 1
-                    """)]
-        # Also hide any FTS tables that have a content= argument
-        hidden_tables += [x[0] for x in await self.execute("""
-                  SELECT name
-                  FROM sqlite_master
-                  WHERE sql LIKE '%VIRTUAL TABLE%'
-                    AND sql LIKE '%USING FTS%'
-                    AND sql LIKE '%content=%'
-                """)]
+        hidden_tables += await self.execute_fn(sqlite_hidden_table_names)
 
         has_spatialite = await self.execute_fn(detect_spatialite)
         if has_spatialite:
diff --git a/datasette/utils/sqlite.py b/datasette/utils/sqlite.py
index 130c5f62..d3f52751 100644
--- a/datasette/utils/sqlite.py
+++ b/datasette/utils/sqlite.py
@@ -80,6 +80,28 @@ def sqlite_table_type(
     return _sqlite_table_type_from_schema(conn, table, schema=schema)
 
 
+def sqlite_hidden_table_names(conn, *, schema: str | None = "main") -> list[str]:
+    schema_table = _sqlite_schema_table(schema)
+    try:
+        rows = conn.execute(
+            "select name, sql from {} where type = 'table'".format(schema_table)
+        ).fetchall()
+    except sqlite3.DatabaseError:
+        return []
+    hidden_tables = []
+    content_fts_tables = []
+    for name, sql in rows:
+        if (
+            name in {"sqlite_stat1", "sqlite_stat2", "sqlite_stat3", "sqlite_stat4"}
+            or name.startswith("_")
+            or sqlite_table_type(conn, name, schema=schema) == "shadow"
+        ):
+            hidden_tables.append(name)
+        elif _is_fts_content_virtual_table(sql):
+            content_fts_tables.append(name)
+    return sorted(hidden_tables) + content_fts_tables
+
+
 def _sqlite_table_type_from_schema(
     conn,
     table: str,
@@ -150,3 +172,10 @@ def _virtual_table_module(sql: str | None) -> str | None:
     if match is None:
         return None
     return match.group(1).strip("\"'[]`").lower()
+
+
+def _is_fts_content_virtual_table(sql: str | None) -> bool:
+    return (
+        _virtual_table_module(sql) in {"fts3", "fts4", "fts5"}
+        and "content=" in sql.lower()
+    )
diff --git a/tests/test_internals_database.py b/tests/test_internals_database.py
index d6e130b4..88f9d571 100644
--- a/tests/test_internals_database.py
+++ b/tests/test_internals_database.py
@@ -8,7 +8,7 @@ from datasette.app import Datasette
 from datasette.database import Database, Results, MultipleValues
 from datasette.database import DatasetteClosedError
 from datasette.database import _deliver_write_result
-from datasette.utils.sqlite import sqlite3, sqlite_version
+from datasette.utils.sqlite import sqlite3
 from datasette.utils import Column
 import pytest
 import time
@@ -798,14 +798,7 @@ async def test_in_memory_databases_forbid_writes(app_client):
     assert await db.table_names() == ["foo"]
 
 
-def pragma_table_list_supported():
-    return sqlite_version()[1] >= 37
-
-
 @pytest.mark.asyncio
-@pytest.mark.skipif(
-    not pragma_table_list_supported(), reason="Requires PRAGMA table_list support"
-)
 async def test_hidden_tables(app_client):
     ds = app_client.ds
     db = ds.add_database(Database(ds, is_memory=True, is_mutable=True))
diff --git a/tests/test_utils.py b/tests/test_utils.py
index e142bb5b..90013537 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -5,7 +5,7 @@ Tests for various datasette helper functions.
 from datasette.app import Datasette
 from datasette import utils
 from datasette.utils.asgi import Request
-from datasette.utils.sqlite import sqlite3, sqlite_table_type
+from datasette.utils.sqlite import sqlite3, sqlite_hidden_table_names, sqlite_table_type
 import json
 import os
 import pathlib
@@ -246,6 +246,16 @@ def test_sqlite_table_type_detects_virtual_and_shadow_tables(monkeypatch, use_fa
         assert sqlite_table_type(conn, "boxes") == "virtual"
         assert sqlite_table_type(conn, "boxes_node") == "shadow"
         assert sqlite_table_type(conn, "missing") is None
+        assert sqlite_hidden_table_names(conn) == [
+            "boxes_node",
+            "boxes_parent",
+            "boxes_rowid",
+            "search_index_config",
+            "search_index_content",
+            "search_index_data",
+            "search_index_docsize",
+            "search_index_idx",
+        ]
     finally:
         conn.close()
 

From 2785fd29deef505f132902dcee86284e39e3fdcb Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 09:03:10 -0700
Subject: [PATCH 120/386] Fix tests I just broke

---
 datasette/utils/sql_analysis.py | 86 +++++++++++++++++++--------------
 datasette/utils/sqlite.py       |  2 +-
 tests/test_utils.py             | 14 ++++++
 3 files changed, 65 insertions(+), 37 deletions(-)

diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index a71fa315..b5d7ada8 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -193,6 +193,10 @@ _AUTHORIZER_ACTION_NAMES = {
 }
 
 
+def _allow_authorizer_action(*args):
+    return sqlite3.SQLITE_OK
+
+
 def analyze_sql_tables(
     conn,
     sql: str,
@@ -424,42 +428,59 @@ def analyze_sql_tables(
         )
         return sqlite3.SQLITE_OK
 
+    table_kind_cache: dict[tuple[str | None, str], SQLTableKind | None] = {}
+
     conn.set_authorizer(authorizer)
     try:
         explain_rows = conn.execute(
             "EXPLAIN " + sql, params if params is not None else {}
         ).fetchall()
+        # Passing None before these lookups leaves a failing callback installed
+        # on Python 3.10, so use a permissive callback until they are complete.
+        conn.set_authorizer(_allow_authorizer_action)
+
+        if not operations:
+            vacuum_row = next((row for row in explain_rows if row[1] == "Vacuum"), None)
+            if vacuum_row is not None:
+                schema_by_index = {
+                    row[0]: row[1] for row in conn.execute("PRAGMA database_list")
+                }
+                sqlite_schema = schema_by_index.get(vacuum_row[2])
+                database = database_for_schema(sqlite_schema)
+                record(
+                    "vacuum",
+                    "database",
+                    database=database,
+                    table=None,
+                    sqlite_schema=sqlite_schema,
+                    target=database,
+                    source=None,
+                )
+            else:
+                record(
+                    "unknown",
+                    "statement",
+                    database=database_name,
+                    table=None,
+                    sqlite_schema=None,
+                    target=None,
+                    source=None,
+                )
+
+        for key in operations:
+            if (
+                key.target_type == "table"
+                and key.operation in {"read", "insert", "update", "delete"}
+                and key.table is not None
+            ):
+                cache_key = (key.sqlite_schema, key.table)
+                if cache_key not in table_kind_cache:
+                    table_kind_cache[cache_key] = sqlite_table_type(
+                        conn, key.table, schema=key.sqlite_schema
+                    )
     finally:
         conn.set_authorizer(None)
 
-    if not operations:
-        vacuum_row = next((row for row in explain_rows if row[1] == "Vacuum"), None)
-        if vacuum_row is not None:
-            schema_by_index = {
-                row[0]: row[1] for row in conn.execute("PRAGMA database_list")
-            }
-            sqlite_schema = schema_by_index.get(vacuum_row[2])
-            database = database_for_schema(sqlite_schema)
-            record(
-                "vacuum",
-                "database",
-                database=database,
-                table=None,
-                sqlite_schema=sqlite_schema,
-                target=database,
-                source=None,
-            )
-        else:
-            record(
-                "unknown",
-                "statement",
-                database=database_name,
-                table=None,
-                sqlite_schema=None,
-                target=None,
-                source=None,
-            )
-
     has_schema_operation = any(
         key.target_type in {"table", "index", "view", "trigger", "virtual-table"}
         and key.operation in {"create", "alter", "drop"}
@@ -502,8 +523,6 @@ def analyze_sql_tables(
             return True
         return False
 
-    table_kind_cache: dict[tuple[str | None, str], SQLTableKind | None] = {}
-
     def table_kind_for(key: OperationKey) -> SQLTableKind | None:
         if (
             key.target_type != "table"
@@ -511,12 +530,7 @@ def analyze_sql_tables(
             or key.table is None
         ):
             return None
-        cache_key = (key.sqlite_schema, key.table)
-        if cache_key not in table_kind_cache:
-            table_kind_cache[cache_key] = sqlite_table_type(
-                conn, key.table, schema=key.sqlite_schema
-            )
-        return table_kind_cache[cache_key]
+        return table_kind_cache[(key.sqlite_schema, key.table)]
 
     return SQLAnalysis(
         operations=tuple(
diff --git a/datasette/utils/sqlite.py b/datasette/utils/sqlite.py
index d3f52751..5a7c6c38 100644
--- a/datasette/utils/sqlite.py
+++ b/datasette/utils/sqlite.py
@@ -16,7 +16,7 @@ _cached_sqlite_version = None
 SQLiteTableType = Literal["table", "view", "virtual", "shadow"]
 _VIRTUAL_TABLE_MODULE_RE = re.compile(
     r"\bCREATE\s+VIRTUAL\s+TABLE\b.*?\bUSING\s+([^\s(]+)",
-    re.IGNORECASE,
+    re.IGNORECASE | re.DOTALL,
 )
 _VIRTUAL_TABLE_SHADOW_SUFFIXES = {
     "fts3": ("_content", "_segdir", "_segments", "_stat", "_docsize"),
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 90013537..e83eed7a 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -279,6 +279,20 @@ def test_sqlite_table_type_detects_attached_database_tables(monkeypatch, use_fal
         conn.close()
 
 
+def test_sqlite_hidden_table_names_hides_multiline_content_fts_table():
+    conn = utils.sqlite3.connect(":memory:")
+    try:
+        conn.executescript("""
+            create table searchable(id integer primary key, body text);
+            create virtual table searchable_fts
+                using fts5(body, content='searchable', content_rowid='id');
+        """)
+
+        assert "searchable_fts" in sqlite_hidden_table_names(conn)
+    finally:
+        conn.close()
+
+
 @pytest.mark.parametrize(
     "url,expected",
     [

From 8bd7e165f465fe057beace2b17d52c0a347819f8 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 09:50:56 -0700
Subject: [PATCH 121/386] Refactored for code readability

---
 datasette/app.py                 |   5 +-
 datasette/stored_queries.py      | 211 +------------------------
 datasette/views/database.py      |   3 +-
 datasette/views/query_helpers.py |  27 ++--
 datasette/write_sql.py           | 255 +++++++++++++++++++++++++++++++
 tests/test_write_sql.py          |  59 +++++++
 6 files changed, 339 insertions(+), 221 deletions(-)
 create mode 100644 datasette/write_sql.py
 create mode 100644 tests/test_write_sql.py

diff --git a/datasette/app.py b/datasette/app.py
index 56b89789..e7f34e69 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -42,7 +42,7 @@ from jinja2.exceptions import TemplateNotFound
 
 from .events import Event
 from .column_types import SQLiteType
-from . import stored_queries
+from . import stored_queries, write_sql
 from .views import Context
 from .views.database import (
     database_download,
@@ -1197,7 +1197,8 @@ class Datasette:
     async def ensure_query_write_permissions(
         self, database, sql, *, actor=None, params=None, analysis=None
     ):
-        return await stored_queries.ensure_query_write_permissions(
+        # Raise Forbidden or QueryWriteRejected if SQL should not run
+        return await write_sql.ensure_query_write_permissions(
             self, database, sql, actor=actor, params=params, analysis=analysis
         )
 
diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index b5aea221..b6ac49b8 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -2,26 +2,13 @@ from __future__ import annotations
 
 from dataclasses import dataclass
 import json
-from typing import Any, Iterable, TYPE_CHECKING
+from typing import Any, Iterable
 
-from .resources import DatabaseResource, TableResource
-from .permissions import Resource
-from .utils import named_parameters, sqlite3, tilde_encode, urlsafe_components
-from .utils.asgi import Forbidden
-from .utils.sql_analysis import Operation, SQLAnalysis
-
-if TYPE_CHECKING:
-    from .app import Datasette
+from .utils import tilde_encode, urlsafe_components
 
 UNCHANGED = object()
 
 
-class QueryWriteRejected(Exception):
-    def __init__(self, message: str):
-        self.message = message
-        super().__init__(message)
-
-
 QUERY_OPTION_FIELDS = (
     "hide_sql",
     "fragment",
@@ -593,197 +580,3 @@ async def list_queries(
         has_more=has_more,
         limit=limit,
     )
-
-
-@dataclass(frozen=True)
-class PermissionRequirement:
-    action: str
-    resource: Resource
-
-
-def row_mutation_requirements(
-    database: str, table: str
-) -> tuple[PermissionRequirement, ...]:
-    resource = TableResource(database=database, table=table)
-    return tuple(
-        PermissionRequirement(action=action, resource=resource)
-        for action in ("insert-row", "update-row", "delete-row")
-    )
-
-
-def permission_requirements_for_operation(
-    operation: Operation,
-) -> tuple[PermissionRequirement, ...]:
-    if (
-        operation.operation == "read"
-        and operation.target_type == "table"
-        and operation.database is not None
-        and operation.table is not None
-    ):
-        return (
-            PermissionRequirement(
-                action="view-table",
-                resource=TableResource(
-                    database=operation.database, table=operation.table
-                ),
-            ),
-        )
-    if (
-        operation.operation in {"insert", "update"}
-        and operation.target_type == "table"
-        and operation.database is not None
-        and operation.table is not None
-    ):
-        return row_mutation_requirements(
-            database=operation.database,
-            table=operation.table,
-        )
-    if (
-        operation.operation == "delete"
-        and operation.target_type == "table"
-        and operation.database is not None
-        and operation.table is not None
-    ):
-        return (
-            PermissionRequirement(
-                action="delete-row",
-                resource=TableResource(
-                    database=operation.database, table=operation.table
-                ),
-            ),
-        )
-    if operation.operation == "create" and operation.target_type == "table":
-        if operation.database is None:
-            return ()
-        return (
-            PermissionRequirement(
-                action="create-table",
-                resource=DatabaseResource(database=operation.database),
-            ),
-        )
-    if (
-        operation.operation == "alter"
-        and operation.target_type == "table"
-        and operation.database is not None
-        and operation.table is not None
-    ):
-        return (
-            PermissionRequirement(
-                action="alter-table",
-                resource=TableResource(
-                    database=operation.database, table=operation.table
-                ),
-            ),
-        )
-    if (
-        operation.operation == "drop"
-        and operation.target_type == "table"
-        and operation.database is not None
-        and operation.table is not None
-    ):
-        return (
-            PermissionRequirement(
-                action="drop-table",
-                resource=TableResource(
-                    database=operation.database, table=operation.table
-                ),
-            ),
-        )
-    if (
-        operation.operation in {"create", "drop"}
-        and operation.target_type == "index"
-        and operation.database is not None
-        and operation.table is not None
-    ):
-        return (
-            PermissionRequirement(
-                action="alter-table",
-                resource=TableResource(
-                    database=operation.database, table=operation.table
-                ),
-            ),
-        )
-    return ()
-
-
-def operation_should_be_ignored(operation: Operation) -> bool:
-    return operation.internal or operation.operation == "select"
-
-
-def operation_forbidden_message(operation: Operation) -> str | None:
-    if operation.operation == "vacuum":
-        return "VACUUM is not allowed in user-supplied SQL"
-    if operation.operation in {"insert", "update", "delete"}:
-        if operation.table_kind == "virtual":
-            return "Writes to virtual tables are not allowed in user-supplied SQL"
-        if operation.table_kind == "shadow":
-            return "Writes to shadow tables are not allowed in user-supplied SQL"
-    return None
-
-
-def operation_is_write(operation: Operation) -> bool:
-    return operation.operation in {
-        "insert",
-        "update",
-        "delete",
-        "create",
-        "alter",
-        "drop",
-        "begin",
-        "commit",
-        "rollback",
-        "savepoint",
-        "attach",
-        "detach",
-        "pragma",
-        "analyze",
-        "reindex",
-        "vacuum",
-        "unknown",
-    }
-
-
-async def ensure_query_write_permissions(
-    datasette: Datasette,
-    database: str,
-    sql: str,
-    *,
-    actor: dict[str, object] | None = None,
-    params: dict[str, object] | None = None,
-    analysis: SQLAnalysis | None = None,
-) -> SQLAnalysis:
-    db = datasette.get_database(database)
-    if analysis is None:
-        if params is None:
-            params = {name: "" for name in named_parameters(sql)}
-        try:
-            analysis = await db.analyze_sql(sql, params)
-        except sqlite3.DatabaseError as ex:
-            raise Forbidden(f"Could not analyze query: {ex}") from ex
-
-    for operation in analysis.operations:
-        if operation_should_be_ignored(operation):
-            continue
-        forbidden_message = operation_forbidden_message(operation)
-        if forbidden_message is not None:
-            raise QueryWriteRejected(forbidden_message)
-        permissions = permission_requirements_for_operation(operation)
-        if not permissions:
-            raise Forbidden(
-                "Unsupported SQL operation: {} {}".format(
-                    operation.operation, operation.target_type
-                )
-            )
-        if operation.database != database:
-            raise Forbidden("Writable queries may not access attached databases")
-        for permission in permissions:
-            if not await datasette.allowed(
-                action=permission.action,
-                resource=permission.resource,
-                actor=actor,
-            ):
-                raise Forbidden(
-                    f"Permission denied: need {permission.action} "
-                    f"on {permission.resource}"
-                )
-    return analysis
diff --git a/datasette/views/database.py b/datasette/views/database.py
index ae1cf375..b4a964f1 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -13,7 +13,8 @@ import textwrap
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.database import QueryInterrupted
 from datasette.resources import DatabaseResource, QueryResource
-from datasette.stored_queries import QueryWriteRejected, stored_query_to_dict
+from datasette.stored_queries import stored_query_to_dict
+from datasette.write_sql import QueryWriteRejected
 from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 92328ff3..712832e8 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -3,11 +3,14 @@ import re
 
 from datasette.resources import DatabaseResource
 from datasette.stored_queries import (
-    QueryWriteRejected,
     StoredQuery,
+)
+from datasette.write_sql import (
+    IgnoreWriteSqlOperation,
+    QueryWriteRejected,
+    RequireWriteSqlPermissions,
+    decision_for_write_sql_operation,
     operation_is_write,
-    operation_should_be_ignored,
-    permission_requirements_for_operation,
 )
 from datasette.utils import (
     named_parameters as derive_named_parameters,
@@ -212,7 +215,9 @@ async def _analyze_user_query(datasette, db, sql, *, actor):
 def _display_operations(analysis: SQLAnalysis) -> list[Operation]:
     operations = []
     for operation in analysis.operations:
-        if operation_should_be_ignored(operation):
+        if isinstance(
+            decision_for_write_sql_operation(operation), IgnoreWriteSqlOperation
+        ):
             continue
         operations.append(operation)
     return operations
@@ -221,8 +226,12 @@ def _display_operations(analysis: SQLAnalysis) -> list[Operation]:
 def _analysis_rows(analysis: SQLAnalysis) -> list[dict[str, object]]:
     rows = []
     for operation in _display_operations(analysis):
-        permissions = permission_requirements_for_operation(operation)
-        required_permission = ", ".join(permission.action for permission in permissions)
+        decision = decision_for_write_sql_operation(operation)
+        required_permission = (
+            ", ".join(permission.action for permission in decision.permissions)
+            if isinstance(decision, RequireWriteSqlPermissions)
+            else ""
+        )
         rows.append(
             {
                 "operation": operation.operation,
@@ -241,10 +250,10 @@ async def _analysis_rows_with_permissions(
     rows = _analysis_rows(analysis)
     is_write = _analysis_is_write(analysis)
     for row, operation in zip(rows, _display_operations(analysis)):
-        permissions = permission_requirements_for_operation(operation)
-        if permissions:
+        decision = decision_for_write_sql_operation(operation)
+        if isinstance(decision, RequireWriteSqlPermissions):
             row["allowed"] = True
-            for permission in permissions:
+            for permission in decision.permissions:
                 if not await datasette.allowed(
                     action=permission.action,
                     resource=permission.resource,
diff --git a/datasette/write_sql.py b/datasette/write_sql.py
new file mode 100644
index 00000000..2e1b69af
--- /dev/null
+++ b/datasette/write_sql.py
@@ -0,0 +1,255 @@
+from __future__ import annotations
+
+from dataclasses import dataclass
+from typing import TYPE_CHECKING
+
+from .permissions import Resource
+from .resources import DatabaseResource, TableResource
+from .utils import named_parameters, sqlite3
+from .utils.asgi import Forbidden
+from .utils.sql_analysis import Operation, SQLAnalysis
+
+if TYPE_CHECKING:
+    from .app import Datasette
+
+
+class QueryWriteRejected(Exception):
+    def __init__(self, message: str):
+        self.message = message
+        super().__init__(message)
+
+
+@dataclass(frozen=True)
+class PermissionRequirement:
+    action: str
+    resource: Resource
+
+
+PermissionRequirements = tuple[PermissionRequirement, ...]
+
+
+class WriteSqlOperationDecision:
+    """What Datasette should do with one operation in user-supplied write SQL."""
+
+
+@dataclass(frozen=True)
+class IgnoreWriteSqlOperation(WriteSqlOperationDecision):
+    reason: str
+
+
+@dataclass(frozen=True)
+class RequireWriteSqlPermissions(WriteSqlOperationDecision):
+    permissions: PermissionRequirements
+
+
+@dataclass(frozen=True)
+class RejectWriteSqlOperation(WriteSqlOperationDecision):
+    message: str
+
+
+@dataclass(frozen=True)
+class UnsupportedWriteSqlOperation(WriteSqlOperationDecision):
+    message: str
+
+
+def row_mutation_requirements(database: str, table: str) -> PermissionRequirements:
+    resource = TableResource(database=database, table=table)
+    return tuple(
+        PermissionRequirement(action=action, resource=resource)
+        for action in ("insert-row", "update-row", "delete-row")
+    )
+
+
+def decision_for_write_sql_operation(
+    operation: Operation,
+) -> WriteSqlOperationDecision:
+    unsupported_message = (
+        f"Unsupported SQL operation: {operation.operation} {operation.target_type}"
+    )
+    if operation.internal:
+        return IgnoreWriteSqlOperation("internal SQLite operation")
+    if operation.operation == "select":
+        return IgnoreWriteSqlOperation("select statement")
+    if operation.operation == "vacuum":
+        return RejectWriteSqlOperation("VACUUM is not allowed in user-supplied SQL")
+    if operation.operation in {"insert", "update", "delete"}:
+        if operation.table_kind == "virtual":
+            return RejectWriteSqlOperation(
+                "Writes to virtual tables are not allowed in user-supplied SQL"
+            )
+        if operation.table_kind == "shadow":
+            return RejectWriteSqlOperation(
+                "Writes to shadow tables are not allowed in user-supplied SQL"
+            )
+    if operation.operation == "function":
+        # SQL functions currently have no Datasette permission mapping. They are
+        # rejected by the user-supplied write SQL allow-list as unsupported.
+        return UnsupportedWriteSqlOperation(unsupported_message)
+    if (
+        operation.operation == "read"
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return RequireWriteSqlPermissions(
+            (
+                PermissionRequirement(
+                    action="view-table",
+                    resource=TableResource(
+                        database=operation.database, table=operation.table
+                    ),
+                ),
+            )
+        )
+    if (
+        operation.operation in {"insert", "update"}
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return RequireWriteSqlPermissions(
+            row_mutation_requirements(
+                database=operation.database,
+                table=operation.table,
+            )
+        )
+    if (
+        operation.operation == "delete"
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return RequireWriteSqlPermissions(
+            (
+                PermissionRequirement(
+                    action="delete-row",
+                    resource=TableResource(
+                        database=operation.database, table=operation.table
+                    ),
+                ),
+            )
+        )
+    if operation.operation == "create" and operation.target_type == "table":
+        if operation.database is None:
+            return UnsupportedWriteSqlOperation(unsupported_message)
+        return RequireWriteSqlPermissions(
+            (
+                PermissionRequirement(
+                    action="create-table",
+                    resource=DatabaseResource(database=operation.database),
+                ),
+            )
+        )
+    if (
+        operation.operation == "alter"
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return RequireWriteSqlPermissions(
+            (
+                PermissionRequirement(
+                    action="alter-table",
+                    resource=TableResource(
+                        database=operation.database, table=operation.table
+                    ),
+                ),
+            )
+        )
+    if (
+        operation.operation == "drop"
+        and operation.target_type == "table"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return RequireWriteSqlPermissions(
+            (
+                PermissionRequirement(
+                    action="drop-table",
+                    resource=TableResource(
+                        database=operation.database, table=operation.table
+                    ),
+                ),
+            )
+        )
+    if (
+        operation.operation in {"create", "drop"}
+        and operation.target_type == "index"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return RequireWriteSqlPermissions(
+            (
+                PermissionRequirement(
+                    action="alter-table",
+                    resource=TableResource(
+                        database=operation.database, table=operation.table
+                    ),
+                ),
+            )
+        )
+    return UnsupportedWriteSqlOperation(unsupported_message)
+
+
+def operation_is_write(operation: Operation) -> bool:
+    return operation.operation in {
+        "insert",
+        "update",
+        "delete",
+        "create",
+        "alter",
+        "drop",
+        "begin",
+        "commit",
+        "rollback",
+        "savepoint",
+        "attach",
+        "detach",
+        "pragma",
+        "analyze",
+        "reindex",
+        "vacuum",
+        "unknown",
+    }
+
+
+async def ensure_query_write_permissions(
+    datasette: Datasette,
+    database: str,
+    sql: str,
+    *,
+    actor: dict[str, object] | None = None,
+    params: dict[str, object] | None = None,
+    analysis: SQLAnalysis | None = None,
+) -> SQLAnalysis:
+    db = datasette.get_database(database)
+    if analysis is None:
+        if params is None:
+            params = {name: "" for name in named_parameters(sql)}
+        try:
+            analysis = await db.analyze_sql(sql, params)
+        except sqlite3.DatabaseError as ex:
+            raise Forbidden(f"Could not analyze query: {ex}") from ex
+
+    for operation in analysis.operations:
+        decision = decision_for_write_sql_operation(operation)
+        if isinstance(decision, IgnoreWriteSqlOperation):
+            continue
+        if isinstance(decision, RejectWriteSqlOperation):
+            raise QueryWriteRejected(decision.message)
+        if isinstance(decision, UnsupportedWriteSqlOperation):
+            raise Forbidden(decision.message)
+        permissions = decision.permissions
+        if operation.database != database:
+            raise Forbidden("Writable queries may not access attached databases")
+        for permission in permissions:
+            if not await datasette.allowed(
+                action=permission.action,
+                resource=permission.resource,
+                actor=actor,
+            ):
+                raise Forbidden(
+                    f"Permission denied: need {permission.action} "
+                    f"on {permission.resource}"
+                )
+    return analysis
diff --git a/tests/test_write_sql.py b/tests/test_write_sql.py
new file mode 100644
index 00000000..cfaf0f53
--- /dev/null
+++ b/tests/test_write_sql.py
@@ -0,0 +1,59 @@
+from datasette.utils.sql_analysis import Operation
+from datasette.write_sql import (
+    IgnoreWriteSqlOperation,
+    RejectWriteSqlOperation,
+    RequireWriteSqlPermissions,
+    UnsupportedWriteSqlOperation,
+    WriteSqlOperationDecision,
+    decision_for_write_sql_operation,
+)
+
+
+def test_decision_for_write_sql_operation_ignores_internal_and_select_operations():
+    internal_decision = decision_for_write_sql_operation(
+        Operation("read", "schema", None, None, "main", internal=True)
+    )
+    select_decision = decision_for_write_sql_operation(
+        Operation("select", "statement", None, None, None)
+    )
+
+    assert isinstance(internal_decision, IgnoreWriteSqlOperation)
+    assert isinstance(internal_decision, WriteSqlOperationDecision)
+    assert isinstance(select_decision, IgnoreWriteSqlOperation)
+    assert isinstance(select_decision, WriteSqlOperationDecision)
+
+
+def test_decision_for_write_sql_operation_requires_table_write_permissions():
+    decision = decision_for_write_sql_operation(
+        Operation("insert", "table", "data", "dogs", None)
+    )
+
+    assert isinstance(decision, RequireWriteSqlPermissions)
+    assert [permission.action for permission in decision.permissions] == [
+        "insert-row",
+        "update-row",
+        "delete-row",
+    ]
+    assert [str(permission.resource) for permission in decision.permissions] == [
+        "data/dogs",
+        "data/dogs",
+        "data/dogs",
+    ]
+
+
+def test_decision_for_write_sql_operation_rejects_vacuum():
+    decision = decision_for_write_sql_operation(
+        Operation("vacuum", "statement", None, None, None)
+    )
+
+    assert isinstance(decision, RejectWriteSqlOperation)
+    assert decision.message == "VACUUM is not allowed in user-supplied SQL"
+
+
+def test_decision_for_write_sql_operation_reports_unsupported_functions():
+    decision = decision_for_write_sql_operation(
+        Operation("function", "function", None, None, None, target="upper")
+    )
+
+    assert isinstance(decision, UnsupportedWriteSqlOperation)
+    assert decision.message == "Unsupported SQL operation: function function"

From 51dab16149f8b345d46cf517fa03b95fc1028234 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 10:22:16 -0700
Subject: [PATCH 122/386] Allow SQL functions in SQL write queries

Closes #2751
---
 datasette/write_sql.py  |  4 +-
 docs/authentication.rst |  2 +-
 docs/json_api.rst       |  2 +-
 docs/sql_queries.rst    |  2 +-
 tests/test_queries.py   | 83 +++++++++++++++++++++++++++++++++++++----
 tests/test_write_sql.py | 13 ++++++-
 6 files changed, 91 insertions(+), 15 deletions(-)

diff --git a/datasette/write_sql.py b/datasette/write_sql.py
index 2e1b69af..cdc0c6d3 100644
--- a/datasette/write_sql.py
+++ b/datasette/write_sql.py
@@ -82,9 +82,7 @@ def decision_for_write_sql_operation(
                 "Writes to shadow tables are not allowed in user-supplied SQL"
             )
     if operation.operation == "function":
-        # SQL functions currently have no Datasette permission mapping. They are
-        # rejected by the user-supplied write SQL allow-list as unsupported.
-        return UnsupportedWriteSqlOperation(unsupported_message)
+        return IgnoreWriteSqlOperation("SQL function")
     if (
         operation.operation == "read"
         and operation.target_type == "table"
diff --git a/docs/authentication.rst b/docs/authentication.rst
index f720c12f..a0891900 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1425,7 +1425,7 @@ See also :ref:`the default_allow_sql setting <setting_default_allow_sql>`.
 execute-write-sql
 -----------------
 
-Actor is allowed to run arbitrary writable SQL queries against a specific database, subject to table-level write permissions such as ``insert-row``, ``update-row`` and ``delete-row``.
+Actor is allowed to run arbitrary writable SQL queries against a specific database, subject to table-level write permissions such as ``insert-row``, ``update-row`` and ``delete-row``. SQL functions are allowed and are not separately restricted by Datasette permissions.
 
 ``resource`` - ``datasette.resources.DatabaseResource(database)``
     ``database`` is the name of the database (string)
diff --git a/docs/json_api.rst b/docs/json_api.rst
index fffc16d7..d502299e 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -531,7 +531,7 @@ The request body must include a ``"sql"`` string. Named SQL parameters can be pr
 
 The SQL must be writable. Read-only ``select`` queries should use the regular :ref:`custom SQL query API <sql>` instead.
 
-Datasette analyzes the SQL before executing it. The actor must have ``execute-write-sql`` permission for the database, and must also have any permissions required by the operations in the SQL. For example, inserts and updates against a table require ``insert-row``, ``update-row`` and ``delete-row`` permissions for that table. Reads performed as part of the write, such as ``insert into dogs select ... from other_table``, require ``view-table`` permission on the source table.
+Datasette analyzes the SQL before executing it. The actor must have ``execute-write-sql`` permission for the database, and must also have any permissions required by the operations in the SQL. For example, inserts and updates against a table require ``insert-row``, ``update-row`` and ``delete-row`` permissions for that table. Reads performed as part of the write, such as ``insert into dogs select ... from other_table``, require ``view-table`` permission on the source table. SQL functions are allowed and are not separately restricted by Datasette permissions.
 
 A successful response includes a message, the SQLite ``rowcount`` and a summary of the operations that were executed:
 
diff --git a/docs/sql_queries.rst b/docs/sql_queries.rst
index f593a534..d427ea2b 100644
--- a/docs/sql_queries.rst
+++ b/docs/sql_queries.rst
@@ -140,7 +140,7 @@ Datasette stores both configured queries and user-created queries in the ``queri
 
 Stored queries created by users default to private. Private stored queries can only be viewed, updated or deleted by the actor that created them. Broad ``view-query``, ``update-query`` or ``delete-query`` permission grants still do not allow other actors to access another actor's private stored queries.
 
-Stored queries created by users are untrusted. This means they execute using the permissions of the actor who runs them, as if that actor had pasted the SQL into the regular custom SQL interface or write SQL interface. Read-only stored queries require ``execute-sql``. Writable stored queries require ``execute-write-sql`` plus the relevant table-level write permissions.
+Stored queries created by users are untrusted. This means they execute using the permissions of the actor who runs them, as if that actor had pasted the SQL into the regular custom SQL interface or write SQL interface. Read-only stored queries require ``execute-sql``. Writable stored queries require ``execute-write-sql`` plus the relevant table-level write permissions. SQL functions are allowed and are not separately restricted by Datasette permissions.
 
 .. _trusted_stored_queries:
 .. _trusted_saved_queries:
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 73f8f3cf..9c3ebcc8 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1414,6 +1414,11 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
         actor={"id": "root"},
         params={"sql": "insert into dogs (name) values (:name)"},
     )
+    function_response = await ds.client.get(
+        "/data/-/execute-write/analyze",
+        actor={"id": "root"},
+        params={"sql": "insert into dogs (name) values (upper(:name))"},
+    )
     read_only_response = await ds.client.get(
         "/data/-/execute-write/analyze",
         actor={"id": "root"},
@@ -1438,6 +1443,22 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
     ]
     assert "params" not in data
 
+    assert function_response.status_code == 200
+    function_data = function_response.json()
+    assert function_data["ok"] is True
+    assert function_data["parameters"] == ["name"]
+    assert function_data["execute_disabled"] is False
+    assert function_data["analysis_rows"] == [
+        {
+            "operation": "insert",
+            "database": "data",
+            "table": "dogs",
+            "required_permission": "insert-row, update-row, delete-row",
+            "source": None,
+            "allowed": True,
+        }
+    ]
+
     assert read_only_response.status_code == 200
     read_only_data = read_only_response.json()
     assert read_only_data["ok"] is False
@@ -1970,7 +1991,7 @@ async def test_execute_write_create_table_as_select_requires_view_table_on_sourc
 
 
 @pytest.mark.asyncio
-async def test_execute_write_rejects_function_operations():
+async def test_execute_write_allows_function_operations():
     ds = Datasette(
         memory=True,
         default_deny=True,
@@ -1998,17 +2019,65 @@ async def test_execute_write_rejects_function_operations():
     await db.execute_write("create table dogs (id integer primary key, name text)")
     await ds.invoke_startup()
 
-    denied_response = await ds.client.post(
+    response = await ds.client.post(
         "/data/-/execute-write",
         actor={"id": "writer"},
         json={"sql": "insert into dogs (name) values (upper('cleo'))"},
     )
 
-    assert denied_response.status_code == 403
-    assert denied_response.json()["errors"] == [
-        "Unsupported SQL operation: function function"
-    ]
-    assert (await db.execute("select name from dogs")).dicts() == []
+    assert response.status_code == 200
+    assert response.json()["ok"] is True
+    assert (await db.execute("select name from dogs")).dicts() == [{"name": "CLEO"}]
+
+
+@pytest.mark.asyncio
+async def test_untrusted_stored_write_query_allows_function_operations():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "view-query": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                    },
+                    "tables": {
+                        "dogs": {
+                            "permissions": {
+                                "insert-row": {"id": "writer"},
+                                "update-row": {"id": "writer"},
+                                "delete-row": {"id": "writer"},
+                            }
+                        }
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("stored_query_function_operation", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "insert_dog",
+        "insert into dogs (name) values (upper(:name))",
+        is_write=True,
+        is_trusted=False,
+        source="user",
+        owner_id="writer",
+    )
+
+    response = await ds.client.post(
+        "/data/insert_dog?_json=1",
+        actor={"id": "writer"},
+        data={"name": "cleo"},
+    )
+
+    assert response.status_code == 200
+    assert response.json()["ok"] is True
+    assert (await db.execute("select name from dogs")).dicts() == [{"name": "CLEO"}]
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_write_sql.py b/tests/test_write_sql.py
index cfaf0f53..6d95c3c4 100644
--- a/tests/test_write_sql.py
+++ b/tests/test_write_sql.py
@@ -50,10 +50,19 @@ def test_decision_for_write_sql_operation_rejects_vacuum():
     assert decision.message == "VACUUM is not allowed in user-supplied SQL"
 
 
-def test_decision_for_write_sql_operation_reports_unsupported_functions():
+def test_decision_for_write_sql_operation_ignores_functions():
     decision = decision_for_write_sql_operation(
         Operation("function", "function", None, None, None, target="upper")
     )
 
+    assert isinstance(decision, IgnoreWriteSqlOperation)
+    assert decision.reason == "SQL function"
+
+
+def test_decision_for_write_sql_operation_reports_unsupported_operations():
+    decision = decision_for_write_sql_operation(
+        Operation("unknown", "unknown", None, None, None)
+    )
+
     assert isinstance(decision, UnsupportedWriteSqlOperation)
-    assert decision.message == "Unsupported SQL operation: function function"
+    assert decision.message == "Unsupported SQL operation: unknown unknown"

From b2b20b36c52ea446fb05fe688b636b83d187e6a6 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 10:24:40 -0700
Subject: [PATCH 123/386] Document write SQL analyzer restrictions

Expand the unreleased changelog with the deny-by-default operation analysis model, SQL function handling, and the VACUUM and virtual/shadow table restrictions for user-supplied write SQL.

Clarify the /-/execute-write JSON API documentation with the same restrictions and DDL permission requirements.
---
 docs/changelog.rst | 2 ++
 docs/json_api.rst  | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 2ba713ee..a4be98b1 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -24,6 +24,8 @@ Write SQL UI
 
 - New "Write to this database" interface at ``/<database>/-/execute-write`` for running arbitrary writable SQL against mutable databases. The form extracts named parameters, analyzes the SQL, shows the table operations that will be attempted and links to a newly inserted row when a single-row insert succeeds. (:issue:`2742`)
 - Added the new :ref:`execute-write-sql <actions_execute_write_sql>` permission for running arbitrary writable SQL. Execution is also gated by table-level permissions such as :ref:`insert-row <actions_insert_row>`, :ref:`update-row <actions_update_row>` and :ref:`delete-row <actions_delete_row>`, and writes to attached databases are rejected. (:issue:`2742`)
+- The write SQL analyzer now uses a deny-by-default model for unsupported operations. Reads from source tables require :ref:`view-table <actions_view_table>` permission, schema changes require :ref:`create-table <actions_create_table>`, :ref:`alter-table <actions_alter_table>` or :ref:`drop-table <actions_drop_table>` as appropriate, and row mutation statements require the full ``insert-row``, ``update-row`` and ``delete-row`` permission set. SQL functions are allowed and are not separately permission-gated. (:issue:`2748`)
+- User-supplied write SQL now rejects ``VACUUM`` and writes to SQLite virtual tables or shadow tables. These restrictions also apply to untrusted stored write queries; trusted configured stored queries continue to skip these filters. (:issue:`2748`)
 
 Plugin API changes
 ~~~~~~~~~~~~~~~~~~
diff --git a/docs/json_api.rst b/docs/json_api.rst
index d502299e..db19afc2 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -531,7 +531,9 @@ The request body must include a ``"sql"`` string. Named SQL parameters can be pr
 
 The SQL must be writable. Read-only ``select`` queries should use the regular :ref:`custom SQL query API <sql>` instead.
 
-Datasette analyzes the SQL before executing it. The actor must have ``execute-write-sql`` permission for the database, and must also have any permissions required by the operations in the SQL. For example, inserts and updates against a table require ``insert-row``, ``update-row`` and ``delete-row`` permissions for that table. Reads performed as part of the write, such as ``insert into dogs select ... from other_table``, require ``view-table`` permission on the source table. SQL functions are allowed and are not separately restricted by Datasette permissions.
+Datasette analyzes the SQL before executing it. The actor must have ``execute-write-sql`` permission for the database, and must also have any permissions required by the operations in the SQL. For example, inserts and updates against a table require ``insert-row``, ``update-row`` and ``delete-row`` permissions for that table. Reads performed as part of the write, such as ``insert into dogs select ... from other_table``, require ``view-table`` permission on the source table. Schema changes require ``create-table``, ``alter-table`` or ``drop-table`` permissions as appropriate.
+
+Unsupported SQL operations are rejected by default. ``VACUUM`` is not allowed in arbitrary write SQL, and writes to SQLite virtual tables or shadow tables are rejected. SQL functions are allowed and are not separately restricted by Datasette permissions.
 
 A successful response includes a message, the SQLite ``rowcount`` and a summary of the operations that were executed:
 

From cbe9594a3dcac1f91a6baa7ac99a138c22a71a8a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 11:00:04 -0700
Subject: [PATCH 124/386] Use SQLiteTableType directly in SQL analysis

Remove the redundant SQLTableKind alias from the write SQL analysis model. Operation.table_kind and the analyzer cache now use the SQLite metadata classification type directly, making the source of table-kind values clearer.
---
 datasette/utils/sql_analysis.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index b5d7ada8..0a3a947c 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -42,7 +42,6 @@ SQLTargetType = Literal[
 SQLTableOperation = Literal["read", "insert", "update", "delete"]
 SQLSchemaOperation = Literal["create", "drop"]
 SQLSchemaTargetType = Literal["index", "table", "trigger", "view", "virtual-table"]
-SQLTableKind = SQLiteTableType
 
 
 @dataclass(frozen=True)
@@ -52,7 +51,7 @@ class Operation:
     database: str | None
     table: str | None
     sqlite_schema: str | None
-    table_kind: SQLTableKind | None = None
+    table_kind: SQLiteTableType | None = None
     target: str | None = None
     columns: tuple[str, ...] = ()
     source: str | None = None
@@ -428,7 +427,7 @@ def analyze_sql_tables(
         )
         return sqlite3.SQLITE_OK
 
-    table_kind_cache: dict[tuple[str | None, str], SQLTableKind | None] = {}
+    table_kind_cache: dict[tuple[str | None, str], SQLiteTableType | None] = {}
 
     conn.set_authorizer(authorizer)
     try:
@@ -523,7 +522,7 @@ def analyze_sql_tables(
             return True
         return False
 
-    def table_kind_for(key: OperationKey) -> SQLTableKind | None:
+    def table_kind_for(key: OperationKey) -> SQLiteTableType | None:
         if (
             key.target_type != "table"
             or key.operation not in {"read", "insert", "update", "delete"}

From 17f45b884b4b4844e9f0cce0fef402e888c690f0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 12:06:57 -0700
Subject: [PATCH 125/386] Clarify ignored write SQL operation tests

Split the combined ignored-operation decision test into separate internal-operation and select-statement cases.

Assert the decision reason for each case instead of checking the shared base class, so the tests document why those operations are ignored.
---
 tests/test_write_sql.py | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/tests/test_write_sql.py b/tests/test_write_sql.py
index 6d95c3c4..75d6b6e1 100644
--- a/tests/test_write_sql.py
+++ b/tests/test_write_sql.py
@@ -4,23 +4,26 @@ from datasette.write_sql import (
     RejectWriteSqlOperation,
     RequireWriteSqlPermissions,
     UnsupportedWriteSqlOperation,
-    WriteSqlOperationDecision,
     decision_for_write_sql_operation,
 )
 
 
-def test_decision_for_write_sql_operation_ignores_internal_and_select_operations():
-    internal_decision = decision_for_write_sql_operation(
+def test_decision_for_write_sql_operation_ignores_internal_operations():
+    decision = decision_for_write_sql_operation(
         Operation("read", "schema", None, None, "main", internal=True)
     )
-    select_decision = decision_for_write_sql_operation(
+
+    assert isinstance(decision, IgnoreWriteSqlOperation)
+    assert decision.reason == "internal SQLite operation"
+
+
+def test_decision_for_write_sql_operation_ignores_select_statement_operations():
+    decision = decision_for_write_sql_operation(
         Operation("select", "statement", None, None, None)
     )
 
-    assert isinstance(internal_decision, IgnoreWriteSqlOperation)
-    assert isinstance(internal_decision, WriteSqlOperationDecision)
-    assert isinstance(select_decision, IgnoreWriteSqlOperation)
-    assert isinstance(select_decision, WriteSqlOperationDecision)
+    assert isinstance(decision, IgnoreWriteSqlOperation)
+    assert decision.reason == "select statement"
 
 
 def test_decision_for_write_sql_operation_requires_table_write_permissions():

From 0b7c26c6c8bf4827c02aba9707b1db0eb63aeaa5 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 12:09:02 -0700
Subject: [PATCH 126/386] Refactored write decision tests

---
 tests/test_write_sql.py                     | 71 ----------------
 tests/test_write_sql_operation_decisions.py | 94 +++++++++++++++++++++
 2 files changed, 94 insertions(+), 71 deletions(-)
 delete mode 100644 tests/test_write_sql.py
 create mode 100644 tests/test_write_sql_operation_decisions.py

diff --git a/tests/test_write_sql.py b/tests/test_write_sql.py
deleted file mode 100644
index 75d6b6e1..00000000
--- a/tests/test_write_sql.py
+++ /dev/null
@@ -1,71 +0,0 @@
-from datasette.utils.sql_analysis import Operation
-from datasette.write_sql import (
-    IgnoreWriteSqlOperation,
-    RejectWriteSqlOperation,
-    RequireWriteSqlPermissions,
-    UnsupportedWriteSqlOperation,
-    decision_for_write_sql_operation,
-)
-
-
-def test_decision_for_write_sql_operation_ignores_internal_operations():
-    decision = decision_for_write_sql_operation(
-        Operation("read", "schema", None, None, "main", internal=True)
-    )
-
-    assert isinstance(decision, IgnoreWriteSqlOperation)
-    assert decision.reason == "internal SQLite operation"
-
-
-def test_decision_for_write_sql_operation_ignores_select_statement_operations():
-    decision = decision_for_write_sql_operation(
-        Operation("select", "statement", None, None, None)
-    )
-
-    assert isinstance(decision, IgnoreWriteSqlOperation)
-    assert decision.reason == "select statement"
-
-
-def test_decision_for_write_sql_operation_requires_table_write_permissions():
-    decision = decision_for_write_sql_operation(
-        Operation("insert", "table", "data", "dogs", None)
-    )
-
-    assert isinstance(decision, RequireWriteSqlPermissions)
-    assert [permission.action for permission in decision.permissions] == [
-        "insert-row",
-        "update-row",
-        "delete-row",
-    ]
-    assert [str(permission.resource) for permission in decision.permissions] == [
-        "data/dogs",
-        "data/dogs",
-        "data/dogs",
-    ]
-
-
-def test_decision_for_write_sql_operation_rejects_vacuum():
-    decision = decision_for_write_sql_operation(
-        Operation("vacuum", "statement", None, None, None)
-    )
-
-    assert isinstance(decision, RejectWriteSqlOperation)
-    assert decision.message == "VACUUM is not allowed in user-supplied SQL"
-
-
-def test_decision_for_write_sql_operation_ignores_functions():
-    decision = decision_for_write_sql_operation(
-        Operation("function", "function", None, None, None, target="upper")
-    )
-
-    assert isinstance(decision, IgnoreWriteSqlOperation)
-    assert decision.reason == "SQL function"
-
-
-def test_decision_for_write_sql_operation_reports_unsupported_operations():
-    decision = decision_for_write_sql_operation(
-        Operation("unknown", "unknown", None, None, None)
-    )
-
-    assert isinstance(decision, UnsupportedWriteSqlOperation)
-    assert decision.message == "Unsupported SQL operation: unknown unknown"
diff --git a/tests/test_write_sql_operation_decisions.py b/tests/test_write_sql_operation_decisions.py
new file mode 100644
index 00000000..cc19f701
--- /dev/null
+++ b/tests/test_write_sql_operation_decisions.py
@@ -0,0 +1,94 @@
+import pytest
+
+from datasette.utils.sql_analysis import Operation
+from datasette.write_sql import (
+    IgnoreWriteSqlOperation,
+    RejectWriteSqlOperation,
+    RequireWriteSqlPermissions,
+    UnsupportedWriteSqlOperation,
+    decision_for_write_sql_operation,
+)
+
+
+@pytest.mark.parametrize(
+    ("operation", "reason"),
+    (
+        pytest.param(
+            Operation("read", "schema", None, None, "main", internal=True),
+            "internal SQLite operation",
+            id="internal",
+        ),
+        pytest.param(
+            Operation("select", "statement", None, None, None),
+            "select statement",
+            id="select-statement",
+        ),
+        pytest.param(
+            Operation("function", "function", None, None, None, target="upper"),
+            "SQL function",
+            id="function",
+        ),
+    ),
+)
+def test_decision_for_write_sql_operation_ignores_operations(operation, reason):
+    decision = decision_for_write_sql_operation(operation)
+
+    assert isinstance(decision, IgnoreWriteSqlOperation)
+    assert decision.reason == reason
+
+
+@pytest.mark.parametrize("operation", ("insert", "update"))
+def test_decision_for_write_sql_operation_requires_table_write_permissions(operation):
+    decision = decision_for_write_sql_operation(
+        Operation(operation, "table", "data", "dogs", None)
+    )
+
+    assert isinstance(decision, RequireWriteSqlPermissions)
+    assert [permission.action for permission in decision.permissions] == [
+        "insert-row",
+        "update-row",
+        "delete-row",
+    ]
+    assert [str(permission.resource) for permission in decision.permissions] == [
+        "data/dogs",
+        "data/dogs",
+        "data/dogs",
+    ]
+
+
+@pytest.mark.parametrize(
+    ("operation", "message"),
+    (
+        pytest.param(
+            Operation("vacuum", "statement", None, None, None),
+            "VACUUM is not allowed in user-supplied SQL",
+            id="vacuum",
+        ),
+        pytest.param(
+            Operation("insert", "table", "data", "docs", None, table_kind="virtual"),
+            "Writes to virtual tables are not allowed in user-supplied SQL",
+            id="virtual-table",
+        ),
+        pytest.param(
+            Operation(
+                "insert", "table", "data", "docs_data", None, table_kind="shadow"
+            ),
+            "Writes to shadow tables are not allowed in user-supplied SQL",
+            id="shadow-table",
+        ),
+    ),
+)
+def test_decision_for_write_sql_operation_rejects_operations(operation, message):
+    decision = decision_for_write_sql_operation(operation)
+
+    assert isinstance(decision, RejectWriteSqlOperation)
+    assert decision.message == message
+
+
+def test_decision_for_write_sql_operation_reports_unsupported_operations():
+    decision = decision_for_write_sql_operation(
+        Operation("unknown", "unknown", None, None, None)
+    )
+
+    assert isinstance(decision, UnsupportedWriteSqlOperation)
+    assert decision.message == "Unsupported SQL operation: unknown unknown"

From cd838daef4d066e584b047164d8e2a5e96909511 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 15:22:21 -0700
Subject: [PATCH 127/386] Refactor tests a bit

---
 tests/test_queries.py | 449 +++++++++++++++++++++---------------------
 1 file changed, 225 insertions(+), 224 deletions(-)

diff --git a/tests/test_queries.py b/tests/test_queries.py
index 9c3ebcc8..216cb211 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1700,8 +1700,22 @@ async def test_execute_write_post_requires_database_and_table_permissions():
     assert (await db.execute("select name from dogs")).first()[0] == "Cleo"
 
 
+@pytest.mark.parametrize(
+    "database_name, sql",
+    (
+        (
+            "execute_write_insert_or_replace",
+            "insert or replace into users(id, email) values (3, 'b@example.com')",
+        ),
+        (
+            "execute_write_update_or_replace",
+            "update or replace users set email = 'b@example.com' where id = 1",
+        ),
+    ),
+    ids=("insert-or-replace", "update-or-replace"),
+)
 @pytest.mark.asyncio
-async def test_execute_write_insert_or_replace_requires_delete_row_permission():
+async def test_execute_write_replace_requires_delete_row_permission(database_name, sql):
     ds = Datasette(
         memory=True,
         default_deny=True,
@@ -1725,7 +1739,7 @@ async def test_execute_write_insert_or_replace_requires_delete_row_permission():
             }
         },
     )
-    db = ds.add_memory_database("execute_write_insert_or_replace", name="data")
+    db = ds.add_memory_database(database_name, name="data")
     await db.execute_write(
         "create table users (id integer primary key, email text unique)"
     )
@@ -1738,64 +1752,7 @@ async def test_execute_write_insert_or_replace_requires_delete_row_permission():
     denied_response = await ds.client.post(
         "/data/-/execute-write",
         actor={"id": "writer"},
-        json={
-            "sql": (
-                "insert or replace into users(id, email) " "values (3, 'b@example.com')"
-            )
-        },
-    )
-
-    assert denied_response.status_code == 403
-    assert denied_response.json()["errors"] == [
-        "Permission denied: need delete-row on data/users"
-    ]
-    assert (await db.execute("select id, email from users order by id")).dicts() == [
-        {"id": 1, "email": "a@example.com"},
-        {"id": 2, "email": "b@example.com"},
-    ]
-
-
-@pytest.mark.asyncio
-async def test_execute_write_update_or_replace_requires_delete_row_permission():
-    ds = Datasette(
-        memory=True,
-        default_deny=True,
-        config={
-            "databases": {
-                "data": {
-                    "permissions": {
-                        "view-database": {"id": "writer"},
-                        "execute-write-sql": {"id": "writer"},
-                    },
-                    "tables": {
-                        "users": {
-                            "permissions": {
-                                "insert-row": {"id": "writer"},
-                                "update-row": {"id": "writer"},
-                                "view-table": {"id": "writer"},
-                            }
-                        }
-                    },
-                }
-            }
-        },
-    )
-    db = ds.add_memory_database("execute_write_update_or_replace", name="data")
-    await db.execute_write(
-        "create table users (id integer primary key, email text unique)"
-    )
-    await db.execute_write(
-        "insert into users (id, email) values "
-        "(1, 'a@example.com'), (2, 'b@example.com')"
-    )
-    await ds.invoke_startup()
-
-    denied_response = await ds.client.post(
-        "/data/-/execute-write",
-        actor={"id": "writer"},
-        json={
-            "sql": "update or replace users set email = 'b@example.com' where id = 1"
-        },
+        json={"sql": sql},
     )
 
     assert denied_response.status_code == 403
@@ -2262,74 +2219,71 @@ async def test_trusted_stored_write_query_skips_vacuum_filtering():
     assert response.json()["ok"] is True
 
 
+@pytest.mark.parametrize(
+    (
+        "database_name",
+        "setup_sqls",
+        "write_sql",
+        "expected_error",
+        "verification_sql",
+        "expected_count",
+    ),
+    (
+        (
+            "execute_write_virtual_table_control",
+            (
+                "create virtual table docs using fts5(title, body, content='')",
+                "insert into docs(rowid, title, body) values (1, 'hello', 'world')",
+            ),
+            "insert into docs(docs) values('delete-all')",
+            "Writes to virtual tables are not allowed in user-supplied SQL",
+            "select count(*) from docs where docs match 'hello'",
+            1,
+        ),
+        (
+            "execute_write_virtual_table_insert",
+            ("create virtual table docs using fts5(title, body)",),
+            "insert into docs(rowid, title, body) values (1, 'a', 'b')",
+            "Writes to virtual tables are not allowed in user-supplied SQL",
+            "select count(*) from docs",
+            0,
+        ),
+        (
+            "execute_write_shadow_table_insert",
+            ("create virtual table docs using fts5(title, body)",),
+            "insert into docs_config(k, v) values ('x', 1)",
+            "Writes to shadow tables are not allowed in user-supplied SQL",
+            "select count(*) from docs_config",
+            1,
+        ),
+    ),
+    ids=("control-insert", "virtual-table", "shadow-table"),
+)
 @pytest.mark.asyncio
-async def test_execute_write_rejects_virtual_table_control_insert():
+async def test_execute_write_rejects_virtual_and_shadow_table_writes(
+    database_name,
+    setup_sqls,
+    write_sql,
+    expected_error,
+    verification_sql,
+    expected_count,
+):
     ds = Datasette(memory=True, default_deny=True)
     ds.root_enabled = True
-    db = ds.add_memory_database("execute_write_virtual_table_control", name="data")
-    await db.execute_write("""
-        create virtual table docs using fts5(title, body, content='')
-    """)
-    await db.execute_write("""
-        insert into docs(rowid, title, body) values (1, 'hello', 'world')
-    """)
+    db = ds.add_memory_database(database_name, name="data")
+    for setup_sql in setup_sqls:
+        await db.execute_write(setup_sql)
     await ds.invoke_startup()
 
     denied_response = await ds.client.post(
         "/data/-/execute-write",
         actor={"id": "root"},
-        json={"sql": "insert into docs(docs) values('delete-all')"},
+        json={"sql": write_sql},
     )
 
     assert denied_response.status_code == 403
-    assert denied_response.json()["errors"] == [
-        "Writes to virtual tables are not allowed in user-supplied SQL"
-    ]
-    assert (
-        await db.execute("select count(*) from docs where docs match 'hello'")
-    ).first()[0] == 1
-
-
-@pytest.mark.asyncio
-async def test_execute_write_rejects_regular_virtual_table_insert():
-    ds = Datasette(memory=True, default_deny=True)
-    ds.root_enabled = True
-    db = ds.add_memory_database("execute_write_virtual_table_insert", name="data")
-    await db.execute_write("create virtual table docs using fts5(title, body)")
-    await ds.invoke_startup()
-
-    denied_response = await ds.client.post(
-        "/data/-/execute-write",
-        actor={"id": "root"},
-        json={"sql": "insert into docs(rowid, title, body) values (1, 'a', 'b')"},
-    )
-
-    assert denied_response.status_code == 403
-    assert denied_response.json()["errors"] == [
-        "Writes to virtual tables are not allowed in user-supplied SQL"
-    ]
-    assert (await db.execute("select count(*) from docs")).first()[0] == 0
-
-
-@pytest.mark.asyncio
-async def test_execute_write_rejects_shadow_table_insert():
-    ds = Datasette(memory=True, default_deny=True)
-    ds.root_enabled = True
-    db = ds.add_memory_database("execute_write_shadow_table_insert", name="data")
-    await db.execute_write("create virtual table docs using fts5(title, body)")
-    await ds.invoke_startup()
-
-    denied_response = await ds.client.post(
-        "/data/-/execute-write",
-        actor={"id": "root"},
-        json={"sql": "insert into docs_config(k, v) values ('x', 1)"},
-    )
-
-    assert denied_response.status_code == 403
-    assert denied_response.json()["errors"] == [
-        "Writes to shadow tables are not allowed in user-supplied SQL"
-    ]
-    assert (await db.execute("select count(*) from docs_config")).first()[0] == 1
+    assert denied_response.json()["errors"] == [expected_error]
+    assert (await db.execute(verification_sql)).first()[0] == expected_count
 
 
 @pytest.mark.asyncio
@@ -2482,8 +2436,69 @@ async def test_execute_write_create_table_uses_create_table_permission():
     assert not await db.table_exists("should_not_exist")
 
 
+@pytest.mark.parametrize(
+    (
+        "database_name",
+        "allowed_actor",
+        "allowed_sql",
+        "denied_sql",
+        "expected_error",
+        "setup_sqls",
+        "expected_state",
+    ),
+    (
+        (
+            "execute_write_alter_table",
+            "alterer",
+            "alter table dogs add column age integer",
+            "alter table cats add column age integer",
+            "Permission denied: need alter-table on data/cats",
+            (),
+            "alter-table",
+        ),
+        (
+            "execute_write_create_index",
+            "alterer",
+            "create index idx_dogs_name on dogs(name)",
+            "create index idx_cats_name on cats(name)",
+            "Permission denied: need alter-table on data/cats",
+            (),
+            "create-index",
+        ),
+        (
+            "execute_write_drop_index",
+            "alterer",
+            "drop index idx_dogs_name",
+            "drop index idx_cats_name",
+            "Permission denied: need alter-table on data/cats",
+            (
+                "create index idx_dogs_name on dogs(name)",
+                "create index idx_cats_name on cats(name)",
+            ),
+            "drop-index",
+        ),
+        (
+            "execute_write_drop_table",
+            "dropper",
+            "drop table dogs",
+            "drop table cats",
+            "Permission denied: need drop-table on data/cats",
+            (),
+            "drop-table",
+        ),
+    ),
+    ids=("alter-table", "create-index", "drop-index", "drop-table"),
+)
 @pytest.mark.asyncio
-async def test_execute_write_alter_and_drop_table_use_schema_permissions():
+async def test_execute_write_schema_operations_use_schema_permissions(
+    database_name,
+    allowed_actor,
+    allowed_sql,
+    denied_sql,
+    expected_error,
+    setup_sqls,
+    expected_state,
+):
     ds = Datasette(
         memory=True,
         default_deny=True,
@@ -2513,73 +2528,53 @@ async def test_execute_write_alter_and_drop_table_use_schema_permissions():
             },
         },
     )
-    db = ds.add_memory_database("execute_write_alter_drop_table", name="data")
+    db = ds.add_memory_database(database_name, name="data")
     await db.execute_write("create table dogs (id integer primary key, name text)")
     await db.execute_write("create table cats (id integer primary key, name text)")
+    for setup_sql in setup_sqls:
+        await db.execute_write(setup_sql)
     await ds.invoke_startup()
 
-    alter_allowed_response = await ds.client.post(
+    async def index_exists(index_name):
+        row = (
+            await db.execute(
+                "select 1 from sqlite_master where type = 'index' and name = ?",
+                [index_name],
+            )
+        ).first()
+        return row is not None
+
+    allowed_response = await ds.client.post(
         "/data/-/execute-write",
-        actor={"id": "alterer"},
-        json={"sql": "alter table dogs add column age integer"},
+        actor={"id": allowed_actor},
+        json={"sql": allowed_sql},
     )
-    alter_row_permission_response = await ds.client.post(
+    denied_response = await ds.client.post(
         "/data/-/execute-write",
         actor={"id": "row-writer"},
-        json={"sql": "alter table cats add column age integer"},
+        json={"sql": denied_sql},
     )
 
-    assert alter_allowed_response.status_code == 200
-    assert "age" in [column.name for column in await db.table_column_details("dogs")]
-    assert alter_row_permission_response.status_code == 403
-    assert alter_row_permission_response.json()["errors"] == [
-        "Permission denied: need alter-table on data/cats"
-    ]
-    assert "age" not in [
-        column.name for column in await db.table_column_details("cats")
-    ]
+    assert allowed_response.status_code == 200
+    assert denied_response.status_code == 403
+    assert denied_response.json()["errors"] == [expected_error]
 
-    create_index_allowed_response = await ds.client.post(
-        "/data/-/execute-write",
-        actor={"id": "alterer"},
-        json={"sql": "create index idx_dogs_name on dogs(name)"},
-    )
-    create_index_row_permission_response = await ds.client.post(
-        "/data/-/execute-write",
-        actor={"id": "row-writer"},
-        json={"sql": "create index idx_cats_name on cats(name)"},
-    )
-    drop_index_allowed_response = await ds.client.post(
-        "/data/-/execute-write",
-        actor={"id": "alterer"},
-        json={"sql": "drop index idx_dogs_name"},
-    )
-
-    assert create_index_allowed_response.status_code == 200
-    assert create_index_row_permission_response.status_code == 403
-    assert create_index_row_permission_response.json()["errors"] == [
-        "Permission denied: need alter-table on data/cats"
-    ]
-    assert drop_index_allowed_response.status_code == 200
-
-    drop_allowed_response = await ds.client.post(
-        "/data/-/execute-write",
-        actor={"id": "dropper"},
-        json={"sql": "drop table dogs"},
-    )
-    drop_row_permission_response = await ds.client.post(
-        "/data/-/execute-write",
-        actor={"id": "row-writer"},
-        json={"sql": "drop table cats"},
-    )
-
-    assert drop_allowed_response.status_code == 200
-    assert not await db.table_exists("dogs")
-    assert drop_row_permission_response.status_code == 403
-    assert drop_row_permission_response.json()["errors"] == [
-        "Permission denied: need drop-table on data/cats"
-    ]
-    assert await db.table_exists("cats")
+    if expected_state == "alter-table":
+        assert "age" in [
+            column.name for column in await db.table_column_details("dogs")
+        ]
+        assert "age" not in [
+            column.name for column in await db.table_column_details("cats")
+        ]
+    elif expected_state == "create-index":
+        assert await index_exists("idx_dogs_name")
+        assert not await index_exists("idx_cats_name")
+    elif expected_state == "drop-index":
+        assert not await index_exists("idx_dogs_name")
+        assert await index_exists("idx_cats_name")
+    elif expected_state == "drop-table":
+        assert not await db.table_exists("dogs")
+        assert await db.table_exists("cats")
 
 
 @pytest.mark.asyncio
@@ -2644,8 +2639,9 @@ async def test_execute_write_post_rejects_read_only_sql():
     ]
 
 
+@pytest.mark.parametrize("action", ("view-query", "update-query", "delete-query"))
 @pytest.mark.asyncio
-async def test_query_owner_gets_update_delete_and_writable_view_defaults():
+async def test_query_owner_gets_update_delete_and_writable_view_defaults(action):
     ds = Datasette(memory=True, default_deny=True)
     ds.add_memory_database("query_owner_defaults", name="data")
     await ds.invoke_startup()
@@ -2658,21 +2654,35 @@ async def test_query_owner_gets_update_delete_and_writable_view_defaults():
         owner_id="alice",
     )
 
-    for action in ("view-query", "update-query", "delete-query"):
-        assert await ds.allowed(
-            action=action,
-            resource=QueryResource("data", "insert_dog"),
-            actor={"id": "alice"},
-        )
-        assert not await ds.allowed(
-            action=action,
-            resource=QueryResource("data", "insert_dog"),
-            actor={"id": "bob"},
-        )
+    assert await ds.allowed(
+        action=action,
+        resource=QueryResource("data", "insert_dog"),
+        actor={"id": "alice"},
+    )
+    assert not await ds.allowed(
+        action=action,
+        resource=QueryResource("data", "insert_dog"),
+        actor={"id": "bob"},
+    )
 
 
+@pytest.mark.parametrize(
+    "action, path_suffix, request_json, expected_public_title",
+    (
+        (
+            "update-query",
+            "-/update",
+            {"update": {"title": "Bob can edit public queries"}},
+            "Bob can edit public queries",
+        ),
+        ("delete-query", "-/delete", {}, None),
+    ),
+    ids=("update-query", "delete-query"),
+)
 @pytest.mark.asyncio
-async def test_private_query_restricts_broad_update_delete_permissions():
+async def test_private_query_restricts_broad_update_delete_permissions(
+    action, path_suffix, request_json, expected_public_title
+):
     ds = Datasette(
         memory=True,
         default_deny=True,
@@ -2706,50 +2716,41 @@ async def test_private_query_restricts_broad_update_delete_permissions():
         owner_id="alice",
     )
 
-    for action in ("update-query", "delete-query"):
-        assert await ds.allowed(
-            action=action,
-            resource=QueryResource("data", "alice_private"),
-            actor={"id": "alice"},
-        )
-        assert not await ds.allowed(
-            action=action,
-            resource=QueryResource("data", "alice_private"),
-            actor={"id": "bob"},
-        )
-        assert await ds.allowed(
-            action=action,
-            resource=QueryResource("data", "alice_public"),
-            actor={"id": "bob"},
-        )
-
-    private_update_response = await ds.client.post(
-        "/data/alice_private/-/update",
-        actor={"id": "bob"},
-        json={"update": {"title": "Nope"}},
+    assert await ds.allowed(
+        action=action,
+        resource=QueryResource("data", "alice_private"),
+        actor={"id": "alice"},
     )
-    private_delete_response = await ds.client.post(
-        "/data/alice_private/-/delete",
+    assert not await ds.allowed(
+        action=action,
+        resource=QueryResource("data", "alice_private"),
         actor={"id": "bob"},
-        json={},
     )
-    public_update_response = await ds.client.post(
-        "/data/alice_public/-/update",
+    assert await ds.allowed(
+        action=action,
+        resource=QueryResource("data", "alice_public"),
         actor={"id": "bob"},
-        json={"update": {"title": "Bob can edit public queries"}},
-    )
-    public_delete_response = await ds.client.post(
-        "/data/alice_public/-/delete",
-        actor={"id": "bob"},
-        json={},
     )
 
-    assert private_update_response.status_code == 403
-    assert private_delete_response.status_code == 403
-    assert public_update_response.status_code == 200
-    assert public_delete_response.status_code == 200
+    private_response = await ds.client.post(
+        "/data/alice_private/{}".format(path_suffix),
+        actor={"id": "bob"},
+        json=request_json,
+    )
+    public_response = await ds.client.post(
+        "/data/alice_public/{}".format(path_suffix),
+        actor={"id": "bob"},
+        json=request_json,
+    )
+
+    assert private_response.status_code == 403
+    assert public_response.status_code == 200
     assert await ds.get_query("data", "alice_private") is not None
-    assert await ds.get_query("data", "alice_public") is None
+    public_query = await ds.get_query("data", "alice_public")
+    if expected_public_title is None:
+        assert public_query is None
+    else:
+        assert public_query.title == expected_public_title
 
 
 @pytest.mark.asyncio

From b6e9b189905f6a03136e5998fdf39e1944a1e2a8 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 15:37:48 -0700
Subject: [PATCH 128/386] datasette.yml can no longer set a query to private

Private means it has an owner, and the config does not let
you say who the owner is - plus configured queries should
not be possible to edit or delete in the UI so having an
owner makes even less sense.

You can still make configured queries visible to specific
people using regular view-query permissions.
---
 datasette/stored_queries.py | 1 -
 tests/test_queries.py       | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index b6ac49b8..a6123daa 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -109,7 +109,6 @@ async def save_queries_from_config(datasette: Any) -> None:
                 fragment=query_config.get("fragment"),
                 parameters=query_config.get("params"),
                 is_write=bool(query_config.get("write")),
-                is_private=bool(query_config.get("is_private")),
                 is_trusted=bool(query_config.get("is_trusted", True)),
                 source="config",
                 on_success_message=query_config.get("on_success_message"),
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 216cb211..2aa5142b 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -191,6 +191,8 @@ async def test_config_queries_imported_to_internal_table():
                             "title": "Configured query",
                             "description_html": "<p>Configured HTML</p>",
                             "params": ["name"],
+                            # Configured queries are always public; this is ignored.
+                            "is_private": True,
                             "on_success_message_sql": "select 'Hello ' || :name",
                         }
                     }

From 74324cb8492be8aa8597e58fb6f690158128e6fc Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 15:46:27 -0700
Subject: [PATCH 129/386] Improved docs for user-facing SQL query pages

- /database-name/-/execute-write
- /-/queries
---
 docs/authentication.rst |  4 ++--
 docs/pages.rst          | 27 +++++++++++++++++++++++++++
 docs/sql_queries.rst    |  2 ++
 3 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/docs/authentication.rst b/docs/authentication.rst
index a0891900..5d831da0 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1413,7 +1413,7 @@ Actor is allowed to drop a database table.
 execute-sql
 -----------
 
-Actor is allowed to run arbitrary read-only SQL queries against a specific database, e.g. https://latest.datasette.io/fixtures/-/query?sql=select+100
+Actor is allowed to run arbitrary read-only SQL queries against a specific database using the :ref:`custom SQL query page <pages_custom_sql_queries>`, e.g. https://latest.datasette.io/fixtures/-/query?sql=select+100
 
 ``resource`` - ``datasette.resources.DatabaseResource(database)``
     ``database`` is the name of the database (string)
@@ -1425,7 +1425,7 @@ See also :ref:`the default_allow_sql setting <setting_default_allow_sql>`.
 execute-write-sql
 -----------------
 
-Actor is allowed to run arbitrary writable SQL queries against a specific database, subject to table-level write permissions such as ``insert-row``, ``update-row`` and ``delete-row``. SQL functions are allowed and are not separately restricted by Datasette permissions.
+Actor is allowed to run arbitrary writable SQL queries against a specific database using the :ref:`write SQL queries page <pages_execute_write>`, subject to table-level write permissions such as ``insert-row``, ``update-row`` and ``delete-row``. SQL functions are allowed and are not separately restricted by Datasette permissions.
 
 ``resource`` - ``datasette.resources.DatabaseResource(database)``
     ``database`` is the name of the database (string)
diff --git a/docs/pages.rst b/docs/pages.rst
index e57c15e6..a8ff7c37 100644
--- a/docs/pages.rst
+++ b/docs/pages.rst
@@ -62,6 +62,11 @@ The following tables are hidden by default:
 Queries
 =======
 
+.. _pages_custom_sql_queries:
+
+Custom SQL queries
+------------------
+
 The ``/database-name/-/query`` page can be used to execute an arbitrary SQL query against that database, if the :ref:`actions_execute_sql` permission is enabled. This query is passed as the ``?sql=`` query string parameter.
 
 This means you can link directly to a query by constructing the following URL:
@@ -72,6 +77,28 @@ Each configured :ref:`stored query <stored_queries>` has its own page, at ``/dat
 
 In both cases adding a ``.json`` extension to the URL will return the results as JSON.
 
+.. _pages_execute_write:
+
+Write SQL queries
+-----------------
+
+The ``/database-name/-/execute-write`` page can be used to execute SQL statements that write to a mutable database, if the :ref:`actions_execute_write_sql` permission is enabled.
+
+This page extracts named parameters from the SQL, shows the tables that will be affected and lists the permissions required before the query can be executed. It also includes templates for common ``INSERT``, ``UPDATE`` and ``DELETE`` statements.
+
+Datasette checks additional permissions based on the operations in the SQL. Row changes require the relevant table-level permissions such as :ref:`actions_insert_row`, :ref:`actions_update_row` and :ref:`actions_delete_row`; reads from source tables require :ref:`actions_view_table`; and schema changes require permissions such as :ref:`actions_create_table`, :ref:`actions_alter_table` or :ref:`actions_drop_table`.
+
+Use the :ref:`ExecuteWriteView` JSON API to execute writable SQL programmatically.
+
+.. _pages_stored_query_browser:
+
+Stored query browsers
+---------------------
+
+The ``/-/queries`` page lists stored queries across every database visible to the current actor. The ``/database-name/-/queries`` page lists stored queries for a single database.
+
+These pages support search, pagination and filters for read-only or writable queries and private or public queries. Adding a ``.json`` extension to either URL returns the same list as JSON.
+
 .. _TableView:
 
 Table
diff --git a/docs/sql_queries.rst b/docs/sql_queries.rst
index d427ea2b..c0ba67f0 100644
--- a/docs/sql_queries.rst
+++ b/docs/sql_queries.rst
@@ -7,6 +7,8 @@ Datasette treats SQLite database files as read-only and immutable. This means it
 
 The easiest way to execute custom SQL against Datasette is through the web UI. The database index page includes a SQL editor that lets you run any SELECT query you like. You can also construct queries using the filter interface on the tables page, then click "View and edit SQL" to open that query in the custom SQL editor.
 
+For mutable databases, actors with the appropriate permissions can use the :ref:`write SQL page <pages_execute_write>` to execute SQL statements that insert, update or delete rows.
+
 Note that this interface is only available if the :ref:`actions_execute_sql` permission is allowed. See :ref:`authentication_permissions_execute_sql`.
 
 Any Datasette SQL query is reflected in the URL of the page, allowing you to bookmark them, share them with others and navigate through previous queries using your browser back button.

From 6a998610eef6e69d439a654dd31087023d285452 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 15:52:51 -0700
Subject: [PATCH 130/386] datasette inspect now counts 10,000+ tables correctly
 (#2752)

Closes #2712

Refs https://github.com/simonw/datasette/pull/2721#issuecomment-4568966383
---
 datasette/cli.py   |  7 ++++---
 docs/changelog.rst |  1 +
 tests/test_cli.py  | 18 +++++++++++++++++-
 3 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/datasette/cli.py b/datasette/cli.py
index 93aa22ef..90a33e80 100644
--- a/datasette/cli.py
+++ b/datasette/cli.py
@@ -21,6 +21,7 @@ from .app import (
     SQLITE_LIMIT_ATTACHED,
     pm,
 )
+from .inspect import inspect_tables
 from .utils import (
     LoadExtension,
     StartupError,
@@ -154,14 +155,14 @@ async def inspect_(files, sqlite_extensions):
     app = Datasette([], immutables=files, sqlite_extensions=sqlite_extensions)
     data = {}
     for name, database in app.databases.items():
-        counts = await database.table_counts(limit=3600 * 1000)
+        tables = await database.execute_fn(lambda conn: inspect_tables(conn, {}))
         data[name] = {
             "hash": database.hash,
             "size": database.size,
             "file": database.path,
             "tables": {
-                table_name: {"count": table_count}
-                for table_name, table_count in counts.items()
+                table_name: {"count": table["count"]}
+                for table_name, table in tables.items()
             },
         }
     return data
diff --git a/docs/changelog.rst b/docs/changelog.rst
index a4be98b1..3882cc12 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -37,6 +37,7 @@ Bug fixes
 ~~~~~~~~~
 
 - Fixed a bug where visiting ``/<database>/-/query`` without a ``?sql=`` parameter returned a 500 error. (:issue:`2743`)
+- The ``datasette inspect`` command now correctly records row counts for tables with more than 10,000 rows. (:issue:`2712`)
 
 .. _v1_0_a30:
 
diff --git a/tests/test_cli.py b/tests/test_cli.py
index 1d3a2b28..f86d6909 100644
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -35,12 +35,28 @@ def test_inspect_cli(app_client):
         assert expected_count == database["tables"][table_name]["count"]
 
 
+def test_inspect_cli_counts_all_rows(tmp_path):
+    db_path = tmp_path / "big.db"
+    conn = sqlite3.connect(db_path)
+    with conn:
+        conn.execute("create table t (id integer primary key)")
+        conn.executemany("insert into t (id) values (?)", ((i,) for i in range(10002)))
+    conn.close()
+
+    runner = CliRunner()
+    result = runner.invoke(cli, ["inspect", str(db_path)])
+    assert result.exit_code == 0, result.output
+    data = json.loads(result.output)
+
+    assert data["big"]["tables"]["t"]["count"] == 10002
+
+
 def test_inspect_cli_writes_to_file(app_client):
     runner = CliRunner()
     result = runner.invoke(
         cli, ["inspect", "fixtures.db", "--inspect-file", "foo.json"]
     )
-    assert 0 == result.exit_code, result.output
+    assert result.exit_code == 0, result.output
     with open("foo.json") as fp:
         data = json.load(fp)
     assert ["fixtures"] == list(data.keys())

From e5b6166fa35558920342e74f5ec13078957e87bf Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 16:19:39 -0700
Subject: [PATCH 131/386] Nicer UI around Execute Write SQL denied

Refs https://github.com/simonw/datasette/issues/2753#issuecomment-4569117665
---
 datasette/templates/execute_write.html | 82 ++++++++++++++++++++------
 datasette/views/execute_write.py       | 17 +++---
 datasette/views/query_helpers.py       | 20 +++++--
 tests/test_queries.py                  | 75 ++++++++++++++++++++++-
 4 files changed, 160 insertions(+), 34 deletions(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 6b626f8d..ee251111 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -40,6 +40,26 @@
     border-radius: 0.25rem;
     min-width: 13rem;
 }
+.execute-write-submit-row {
+    align-items: center;
+    display: flex;
+    flex-wrap: wrap;
+    gap: 0.45rem 0.75rem;
+}
+.execute-write-submit-row [hidden] {
+    display: none;
+}
+form.sql.core input[data-execute-write-submit]:disabled {
+    background: #d0d7de;
+    border-color: #b6c0cc;
+    color: #5f6975;
+    cursor: not-allowed;
+    opacity: 1;
+}
+.execute-write-disabled-reason {
+    color: #4f5b6d;
+    font-size: 0.85rem;
+}
 </style>
 {% include "_execute_write_analysis_styles.html" %}
 {% include "_sql_parameter_styles.html" %}
@@ -119,9 +139,10 @@
         {% endif %}
     </div>
 
-    <p>
-        <input type="submit" value="Execute" data-execute-write-submit{% if execute_disabled %} disabled{% endif %}>
-        {% if save_query_base_url %}<a href="{{ save_query_url or save_query_base_url }}" class="save-query" data-save-query-link data-save-query-base-url="{{ save_query_base_url }}"{% if not save_query_url %} hidden{% endif %}>Save this query</a>{% endif %}
+    <p class="execute-write-submit-row"{% if save_query_base_url %} data-save-query-base-url="{{ save_query_base_url }}"{% endif %}>
+        <input type="submit" value="Execute" data-execute-write-submit aria-describedby="execute-write-disabled-reason"{% if execute_disabled %} disabled{% endif %}>
+        <span id="execute-write-disabled-reason" class="execute-write-disabled-reason" data-execute-write-disabled-reason aria-live="polite"{% if not execute_disabled_reason %} hidden{% endif %}>{{ execute_disabled_reason or "" }}</span>
+        {% if save_query_url %}<a href="{{ save_query_url }}" class="save-query" data-save-query-link>Save this query</a>{% endif %}
     </p>
 </form>
 
@@ -143,25 +164,55 @@ window.addEventListener("DOMContentLoaded", () => {
   const submitButton = form
     ? form.querySelector("[data-execute-write-submit]")
     : null;
-  const saveQueryLink = form
+  const submitDisabledReason = form
+    ? form.querySelector("[data-execute-write-disabled-reason]")
+    : null;
+  const submitRow = form
+    ? form.querySelector(".execute-write-submit-row")
+    : null;
+  let saveQueryLink = form
     ? form.querySelector("[data-save-query-link]")
     : null;
 
+  function updateSubmitState(data) {
+    if (submitButton) {
+      submitButton.disabled = data.execute_disabled;
+    }
+    if (!submitDisabledReason) {
+      return;
+    }
+    const reason = data.execute_disabled_reason || "";
+    submitDisabledReason.textContent = reason;
+    submitDisabledReason.hidden = !reason;
+  }
+
   function updateSaveQueryLink(data) {
-    if (!saveQueryLink) {
+    if (!submitRow || !submitRow.dataset.saveQueryBaseUrl) {
       return;
     }
     const sql = window.editor
       ? window.editor.state.doc.toString()
       : executeWriteSqlInput.value;
     if (!sql.trim() || !data.ok || data.execute_disabled) {
-      saveQueryLink.hidden = true;
+      if (saveQueryLink) {
+        saveQueryLink.remove();
+        saveQueryLink = null;
+      }
       return;
     }
-    const url = new URL(saveQueryLink.dataset.saveQueryBaseUrl, window.location.href);
+    if (!saveQueryLink) {
+      saveQueryLink = document.createElement("a");
+      saveQueryLink.className = "save-query";
+      saveQueryLink.setAttribute("data-save-query-link", "");
+      saveQueryLink.textContent = "Save this query";
+      submitRow.appendChild(saveQueryLink);
+    }
+    const url = new URL(
+      submitRow.dataset.saveQueryBaseUrl,
+      window.location.href
+    );
     url.searchParams.set("sql", sql);
     saveQueryLink.href = url.pathname + url.search + url.hash;
-    saveQueryLink.hidden = false;
   }
 
   window.datasetteSqlParameters.setupSqlParameterRefresh({
@@ -170,9 +221,7 @@ window.addEventListener("DOMContentLoaded", () => {
     allowExpand: true,
     onData(data) {
       window.datasetteSqlAnalysis.renderAnalysis(analysisSection, data);
-      if (submitButton) {
-        submitButton.disabled = data.execute_disabled;
-      }
+      updateSubmitState(data);
       updateSaveQueryLink(data);
     },
     onError(error) {
@@ -180,12 +229,11 @@ window.addEventListener("DOMContentLoaded", () => {
         analysis_error: error.message,
         analysis_rows: [],
       });
-      if (submitButton) {
-        submitButton.disabled = true;
-      }
-      if (saveQueryLink) {
-        saveQueryLink.hidden = true;
-      }
+      updateSubmitState({
+        execute_disabled: true,
+        execute_disabled_reason: error.message,
+      });
+      updateSaveQueryLink({ ok: false, execute_disabled: true });
     },
   });
 });
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index 57c4d78e..7b693978 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -14,6 +14,7 @@ from .query_helpers import (
     _coerce_execute_write_payload,
     _derived_query_parameters,
     _execute_write_analysis_data,
+    _execute_write_disabled_reason,
     _inserted_row_url,
     _json_or_form_payload,
     _prepare_execute_write,
@@ -80,13 +81,12 @@ class ExecuteWriteView(BaseView):
         )
         save_query_base_url = None
         save_query_url = None
+        execute_disabled_reason = _execute_write_disabled_reason(
+            sql, analysis_error, analysis_rows
+        )
         if allow_save_query:
             save_query_base_url = self.ds.urls.database(db.name) + "/-/queries/store"
-            if (
-                sql
-                and analysis_error is None
-                and not any(row["allowed"] is False for row in analysis_rows)
-            ):
+            if not execute_disabled_reason:
                 save_query_url = save_query_base_url + "?" + urlencode({"sql": sql})
 
         response = await self.render(
@@ -103,11 +103,8 @@ class ExecuteWriteView(BaseView):
                 "execution_message": execution_message,
                 "execution_links": execution_links,
                 "execution_ok": execution_ok,
-                "execute_disabled": bool(
-                    (not sql)
-                    or analysis_error
-                    or any(row["allowed"] is False for row in analysis_rows)
-                ),
+                "execute_disabled": bool(execute_disabled_reason),
+                "execute_disabled_reason": execute_disabled_reason,
                 "table_columns": table_columns,
                 "write_template_tables": write_template_tables,
                 "save_query_url": save_query_url,
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 712832e8..f30a30bc 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -268,6 +268,16 @@ async def _analysis_rows_with_permissions(
     return rows
 
 
+def _execute_write_disabled_reason(sql, analysis_error, analysis_rows):
+    if not (sql and sql.strip()):
+        return "Enter writable SQL before executing."
+    if analysis_error:
+        return analysis_error
+    if any(row.get("allowed") is False for row in analysis_rows):
+        return "You do not have permission for every operation listed above."
+    return None
+
+
 def _coerce_execute_write_payload(data, is_json):
     if not isinstance(data, dict):
         raise QueryValidationError("JSON must be a dictionary")
@@ -358,16 +368,16 @@ async def _execute_write_analysis_data(datasette, db, sql, actor):
                 )
         except (QueryValidationError, sqlite3.DatabaseError) as ex:
             analysis_error = getattr(ex, "message", str(ex))
+    execute_disabled_reason = _execute_write_disabled_reason(
+        sql, analysis_error, analysis_rows
+    )
     return {
         "ok": analysis_error is None,
         "parameters": parameter_names,
         "analysis_error": analysis_error,
         "analysis_rows": analysis_rows,
-        "execute_disabled": bool(
-            (not sql)
-            or analysis_error
-            or any(row["allowed"] is False for row in analysis_rows)
-        ),
+        "execute_disabled": bool(execute_disabled_reason),
+        "execute_disabled_reason": execute_disabled_reason,
     }
 
 
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 2aa5142b..87ecacde 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1374,6 +1374,10 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'addEventListener("paste"' in response.text
     assert "setupSqlParameterRefresh" in response.text
     assert "datasetteSqlAnalysis.renderAnalysis" in response.text
+    assert "input[data-execute-write-submit]:disabled" in response.text
+    assert (
+        'data-execute-write-disabled-reason aria-live="polite" hidden' in response.text
+    )
     assert '<table class="execute-write-analysis">' in response.text
     assert '<th scope="col">Required permission</th>' in response.text
     assert "<td><code>insert</code></td>" in response.text
@@ -1390,7 +1394,9 @@ async def test_execute_write_get_prepopulates_without_executing():
     )
     assert '<textarea id="sql-editor" name="sql"></textarea>' in empty_response.text
     assert 'executeWriteSqlInput.value = "\\n\\n\\n";' in empty_response.text
-    assert "hidden>Save this query</a>" in empty_response.text
+    assert "Enter writable SQL before executing." in empty_response.text
+    assert 'data-save-query-base-url="/data/-/queries/store"' in empty_response.text
+    assert '<a href="/data/-/queries/store' not in empty_response.text
 
     read_only_response = await ds.client.get(
         "/data/-/execute-write?sql=select+*+from+dogs",
@@ -1400,7 +1406,67 @@ async def test_execute_write_get_prepopulates_without_executing():
         "Use /-/query for read-only SQL; this endpoint only executes writes"
         in read_only_response.text
     )
-    assert "hidden>Save this query</a>" in read_only_response.text
+    assert (
+        '<input type="submit" value="Execute" data-execute-write-submit '
+        'aria-describedby="execute-write-disabled-reason" disabled>'
+    ) in read_only_response.text
+    assert 'data-save-query-base-url="/data/-/queries/store"' in read_only_response.text
+    assert '<a href="/data/-/queries/store' not in read_only_response.text
+
+
+@pytest.mark.asyncio
+async def test_execute_write_disabled_submit_explains_denied_operations():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": "writer"},
+                        "execute-sql": {"id": "writer"},
+                        "execute-write-sql": {"id": "writer"},
+                        "store-query": {"id": "writer"},
+                    }
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_denied_submit", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.get(
+        "/data/-/execute-write?sql=insert+into+dogs+(name)+values+('Cleo')",
+        actor={"id": "writer"},
+    )
+    analysis_response = await ds.client.get(
+        "/data/-/execute-write/analyze",
+        actor={"id": "writer"},
+        params={"sql": "insert into dogs (name) values ('Cleo')"},
+    )
+
+    assert response.status_code == 200
+    assert (
+        '<input type="submit" value="Execute" data-execute-write-submit '
+        'aria-describedby="execute-write-disabled-reason" disabled>'
+    ) in response.text
+    assert (
+        '<span id="execute-write-disabled-reason" '
+        'class="execute-write-disabled-reason" '
+        'data-execute-write-disabled-reason aria-live="polite">'
+        "You do not have permission for every operation listed above.</span>"
+    ) in response.text
+    assert '<span class="execute-write-analysis-denied">no</span>' in response.text
+    assert 'data-save-query-base-url="/data/-/queries/store"' in response.text
+    assert '<a href="/data/-/queries/store' not in response.text
+
+    assert analysis_response.status_code == 200
+    data = analysis_response.json()
+    assert data["execute_disabled"] is True
+    assert data["execute_disabled_reason"] == (
+        "You do not have permission for every operation listed above."
+    )
 
 
 @pytest.mark.asyncio
@@ -1433,6 +1499,7 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
     assert data["parameters"] == ["name"]
     assert data["analysis_error"] is None
     assert data["execute_disabled"] is False
+    assert data["execute_disabled_reason"] is None
     assert data["analysis_rows"] == [
         {
             "operation": "insert",
@@ -1450,6 +1517,7 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
     assert function_data["ok"] is True
     assert function_data["parameters"] == ["name"]
     assert function_data["execute_disabled"] is False
+    assert function_data["execute_disabled_reason"] is None
     assert function_data["analysis_rows"] == [
         {
             "operation": "insert",
@@ -1469,6 +1537,9 @@ async def test_execute_write_analyze_endpoint_uses_sql_only():
         "Use /-/query for read-only SQL; this endpoint only executes writes"
     )
     assert read_only_data["execute_disabled"] is True
+    assert read_only_data["execute_disabled_reason"] == (
+        "Use /-/query for read-only SQL; this endpoint only executes writes"
+    )
 
 
 @pytest.mark.asyncio

From 52729faa54dcdf93da55fba2c080ac9d9bafe10f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 16:20:28 -0700
Subject: [PATCH 132/386] /<database>/-/query.json and changelog docs

---
 docs/changelog.rst |  3 ++-
 docs/json_api.rst  | 21 ++++++++++++++++++++-
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 3882cc12..3501aa60 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -17,12 +17,13 @@ Stored queries
 - Users with :ref:`store-query <actions_store_query>` and :ref:`execute-sql <actions_execute_sql>` permission can create stored queries from the SQL query page or the new ``GET /<database>/-/queries/store`` form. (:issue:`2735`)
 - The database page now shows a count and preview of stored queries, capped at five, and links to new paginated query browsers at ``/-/queries`` and ``/<database>/-/queries``. Those browsers support search. (:issue:`2735`)
 - Stored queries created by users default to private and untrusted. Private stored queries can only be viewed, updated or deleted by their owner, even if another actor has broad ``view-query``, ``update-query`` or ``delete-query`` permission. Untrusted stored queries execute using the permissions of the actor running them. See :ref:`stored_queries` and :ref:`trusted_stored_queries` for details. (:issue:`2735`)
+- Configured queries from ``datasette.yaml`` are trusted by default, so they can execute with ``view-query`` permission alone. They can opt out of that behavior using ``is_trusted: false`` but cannot be made private; private queries are only available for user-created stored queries. (:issue:`2735`)
 - New ``store-query``, ``update-query`` and ``delete-query`` permissions, plus updated semantics for :ref:`view-query <actions_view_query>`. Trusted stored queries can still execute with ``view-query`` alone; untrusted read queries also require :ref:`execute-sql <actions_execute_sql>` and untrusted writable queries require :ref:`execute-write-sql <actions_execute_write_sql>` plus the relevant table-level write permissions. (:issue:`2735`)
 
 Write SQL UI
 ~~~~~~~~~~~~
 
-- New "Write to this database" interface at ``/<database>/-/execute-write`` for running arbitrary writable SQL against mutable databases. The form extracts named parameters, analyzes the SQL, shows the table operations that will be attempted and links to a newly inserted row when a single-row insert succeeds. (:issue:`2742`)
+- New "Write to this database" interface at ``/<database>/-/execute-write`` for running arbitrary writable SQL against mutable databases. The form extracts named parameters, analyzes the SQL, shows the table operations that will be attempted, includes starter templates for ``INSERT``, ``UPDATE`` and ``DELETE`` statements and links to a newly inserted row when a single-row insert succeeds. This is also available as a :ref:`JSON API <ExecuteWriteView>`. (:issue:`2742`)
 - Added the new :ref:`execute-write-sql <actions_execute_write_sql>` permission for running arbitrary writable SQL. Execution is also gated by table-level permissions such as :ref:`insert-row <actions_insert_row>`, :ref:`update-row <actions_update_row>` and :ref:`delete-row <actions_delete_row>`, and writes to attached databases are rejected. (:issue:`2742`)
 - The write SQL analyzer now uses a deny-by-default model for unsupported operations. Reads from source tables require :ref:`view-table <actions_view_table>` permission, schema changes require :ref:`create-table <actions_create_table>`, :ref:`alter-table <actions_alter_table>` or :ref:`drop-table <actions_drop_table>` as appropriate, and row mutation statements require the full ``insert-row``, ``update-row`` and ``delete-row`` permission set. SQL functions are allowed and are not separately permission-gated. (:issue:`2748`)
 - User-supplied write SQL now rejects ``VACUUM`` and writes to SQLite virtual tables or shadow tables. These restrictions also apply to untrusted stored write queries; trusted configured stored queries continue to skip these filters. (:issue:`2748`)
diff --git a/docs/json_api.rst b/docs/json_api.rst
index db19afc2..4bd76717 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -50,6 +50,25 @@ The ``"truncated"`` key lets you know if the query was truncated. This can happe
 
 For table pages, an additional key ``"next"`` may be present. This indicates that the next page in the pagination set can be retrieved using ``?_next=VALUE``.
 
+.. _json_api_custom_sql:
+
+Executing custom SQL
+--------------------
+
+Actors with the :ref:`actions_execute_sql` permission can execute read-only SQL against a database using ``/-/query.json``:
+
+::
+
+    GET /<database>/-/query.json?sql=select+*+from+dogs
+
+Values for named SQL parameters can be provided as additional query string parameters:
+
+::
+
+    GET /<database>/-/query.json?sql=select+*+from+dogs+where+name=:name&name=Cleo
+
+The response uses the same default representation described above.
+
 .. _json_api_shapes:
 
 Different shapes
@@ -529,7 +548,7 @@ The request body must include a ``"sql"`` string. Named SQL parameters can be pr
         }
     }
 
-The SQL must be writable. Read-only ``select`` queries should use the regular :ref:`custom SQL query API <sql>` instead.
+The SQL must be writable. Read-only ``select`` queries should use the regular :ref:`custom SQL query JSON API <json_api_custom_sql>` instead.
 
 Datasette analyzes the SQL before executing it. The actor must have ``execute-write-sql`` permission for the database, and must also have any permissions required by the operations in the SQL. For example, inserts and updates against a table require ``insert-row``, ``update-row`` and ``delete-row`` permissions for that table. Reads performed as part of the write, such as ``insert into dogs select ... from other_table``, require ``view-table`` permission on the source table. Schema changes require ``create-table``, ``alter-table`` or ``drop-table`` permissions as appropriate.
 

From 9e377e8b90b27ae21d3263d0bfe8d3808e2c6133 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 20:01:48 -0700
Subject: [PATCH 133/386] Only show valid SQL write templates

Closes #2753

Demo: https://github.com/simonw/datasette/issues/2753#issuecomment-4570071413
---
 datasette/templates/execute_write.html | 130 ++++-------------
 datasette/views/execute_write.py       | 192 ++++++++++++++++++++++++-
 tests/test_queries.py                  | 117 ++++++++++++++-
 3 files changed, 331 insertions(+), 108 deletions(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index ee251111..394261de 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -89,16 +89,18 @@ form.sql.core input[data-execute-write-submit]:disabled {
                 <p class="execute-write-template-controls">
                     <label for="execute-write-template-table">Table</label>
                     <select id="execute-write-template-table">
-                        {% for table_name, columns in write_template_tables|dictsort %}
-                            <option value="{{ table_name }}">{{ table_name }}</option>
+                        {% for table_name, table in write_template_tables|dictsort %}
+                            <option value="{{ table_name }}"{% for operation, template_sql in table.templates|dictsort %} data-template-{{ operation }}-sql="{{ template_sql }}"{% endfor %}>{{ table_name }}</option>
                         {% endfor %}
                     </select>
-                    <button type="button" data-sql-template="insert">Insert row</button>
-                    <button type="button" data-sql-template="update">Update rows</button>
-                    <button type="button" data-sql-template="delete">Delete rows</button>
+                    {% for operation in write_template_operations %}
+                        <button type="button" data-sql-template="{{ operation.name }}">{{ operation.label }}</button>
+                    {% endfor %}
                 </p>
             </details>
         </div>
+    {% else %}
+        <p class="message-warning execute-write-template-unavailable">You don't currently have permission to insert, edit or delete from any tables.</p>
     {% endif %}
 
     <p class="sql-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
@@ -242,119 +244,43 @@ window.addEventListener("DOMContentLoaded", () => {
 {% if write_template_tables %}
 <script>
 window.addEventListener("DOMContentLoaded", () => {
-  const tableColumns = {{ write_template_tables|tojson(2) }};
   const tableSelect = document.querySelector("#execute-write-template-table");
   const templateButtons = document.querySelectorAll("[data-sql-template]");
 
-  function quoteIdentifier(identifier) {
-    return `"${identifier.replace(/"/g, '""')}"`;
+  function dataKey(operation) {
+    return `template${operation.charAt(0).toUpperCase()}${operation.slice(1)}Sql`;
   }
 
-  function parameterNames(columns) {
-    const seen = new Set();
-    const names = {};
-    columns.forEach((column) => {
-      let base = column
-        .toLowerCase()
-        .replace(/[^a-z0-9_]+/g, "_")
-        .replace(/^_+|_+$/g, "");
-      if (!base) {
-        base = "value";
-      }
-      if (/^[0-9]/.test(base)) {
-        base = `p_${base}`;
-      }
-      let name = base;
-      let index = 2;
-      while (seen.has(name)) {
-        name = `${base}_${index}`;
-        index += 1;
-      }
-      seen.add(name);
-      names[column] = name;
+  function selectedOption() {
+    return tableSelect ? tableSelect.options[tableSelect.selectedIndex] : null;
+  }
+
+  function templateSql(operation) {
+    const option = selectedOption();
+    return option ? option.dataset[dataKey(operation)] || "" : "";
+  }
+
+  function updateTemplateButtons() {
+    templateButtons.forEach((button) => {
+      button.hidden = !templateSql(button.dataset.sqlTemplate);
     });
-    return names;
-  }
-
-  function preferredWhereColumn(table, columns) {
-    const lowerTableId = `${table.toLowerCase()}_id`;
-    return (
-      columns.find((column) => column.toLowerCase() === "id") ||
-      columns.find((column) => column.toLowerCase() === lowerTableId) ||
-      columns[0]
-    );
-  }
-
-  function insertSql(table, columns) {
-    const names = parameterNames(columns);
-    return [
-      `insert into ${quoteIdentifier(table)} (`,
-      columns.map((column) => `  ${quoteIdentifier(column)}`).join(",\n"),
-      ")",
-      "values (",
-      columns.map((column) => `  :${names[column]}`).join(",\n"),
-      ")",
-    ].join("\n");
-  }
-
-  function updateSql(table, columns) {
-    const names = parameterNames(columns);
-    const whereColumn = preferredWhereColumn(table, columns);
-    const setColumns = columns.filter((column) => column !== whereColumn);
-    if (!setColumns.length) {
-      return [
-        `update ${quoteIdentifier(table)}`,
-        `set ${quoteIdentifier(whereColumn)} = :new_${names[whereColumn]}`,
-        `where ${quoteIdentifier(whereColumn)} = :${names[whereColumn]}`,
-      ].join("\n");
-    }
-    return [
-      `update ${quoteIdentifier(table)}`,
-      "set " +
-        setColumns
-          .map((column, index) => {
-            const indent = index ? "    " : "";
-            return `${indent}${quoteIdentifier(column)} = :${names[column]}`;
-          })
-          .join(",\n"),
-      `where ${quoteIdentifier(whereColumn)} = :${names[whereColumn]}`,
-    ].join("\n");
-  }
-
-  function deleteSql(table, columns) {
-    const names = parameterNames(columns);
-    const whereColumn = preferredWhereColumn(table, columns);
-    return [
-      `delete from ${quoteIdentifier(table)}`,
-      `where ${quoteIdentifier(whereColumn)} = :${names[whereColumn]}`,
-    ].join("\n");
-  }
-
-  function templateSql(operation, table, columns) {
-    if (operation === "insert") {
-      return insertSql(table, columns);
-    }
-    if (operation === "update") {
-      return updateSql(table, columns);
-    }
-    return deleteSql(table, columns);
   }
 
   templateButtons.forEach((button) => {
     button.addEventListener("click", () => {
-      const table = tableSelect.value;
-      const columns = tableColumns[table] || [];
-      if (!columns.length) {
+      const sql = templateSql(button.dataset.sqlTemplate);
+      if (!sql) {
         return;
       }
       const url = new URL(window.location.href);
-      url.searchParams.set(
-        "sql",
-        templateSql(button.dataset.sqlTemplate, table, columns)
-      );
+      url.searchParams.set("sql", sql);
       window.location.href = url.toString();
     });
   });
+  if (tableSelect) {
+    tableSelect.addEventListener("change", updateTemplateButtons);
+  }
+  updateTemplateButtons();
 });
 </script>
 {% endif %}
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index 7b693978..cff20847 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -1,3 +1,4 @@
+import re
 from urllib.parse import urlencode
 
 from datasette.resources import DatabaseResource
@@ -22,6 +23,187 @@ from .query_helpers import (
     _wants_json,
 )
 
+WRITE_TEMPLATE_LABELS = {
+    "insert": "Insert row",
+    "update": "Update rows",
+    "delete": "Delete rows",
+}
+WRITE_TEMPLATE_OPERATIONS = tuple(WRITE_TEMPLATE_LABELS)
+
+
+def _parameter_names(columns):
+    seen = set()
+    names = {}
+    for column in columns:
+        base = re.sub(r"[^a-z0-9_]+", "_", column.lower())
+        base = base.strip("_") or "value"
+        if base[0].isdigit():
+            base = "p_{}".format(base)
+        name = base
+        index = 2
+        while name in seen:
+            name = "{}_{}".format(base, index)
+            index += 1
+        seen.add(name)
+        names[column] = name
+    return names
+
+
+def _quote_identifier(identifier):
+    return '"{}"'.format(identifier.replace('"', '""'))
+
+
+def _preferred_where_column(table, columns):
+    lower_table_id = "{}_id".format(table.lower())
+    return (
+        next((column for column in columns if column.lower() == "id"), None)
+        or next(
+            (column for column in columns if column.lower() == lower_table_id), None
+        )
+        or columns[0]
+    )
+
+
+def _auto_incrementing_primary_key(columns):
+    primary_keys = [column for column in columns if column.is_pk]
+    if len(primary_keys) != 1:
+        return None
+    primary_key = primary_keys[0]
+    if primary_key.type and primary_key.type.lower() == "integer":
+        return primary_key.name
+    return None
+
+
+def _insert_template_sql(table, columns):
+    column_names = [column.name for column in columns]
+    auto_pk = _auto_incrementing_primary_key(columns)
+    insert_columns = [column for column in column_names if column != auto_pk]
+    if not insert_columns:
+        return "insert into {}\ndefault values".format(_quote_identifier(table))
+    names = _parameter_names(insert_columns)
+    return "\n".join(
+        (
+            "insert into {} (".format(_quote_identifier(table)),
+            ",\n".join(
+                "  {}".format(_quote_identifier(column)) for column in insert_columns
+            ),
+            ")",
+            "values (",
+            ",\n".join("  :{}".format(names[column]) for column in insert_columns),
+            ")",
+        )
+    )
+
+
+def _update_template_sql(table, columns):
+    column_names = [column.name for column in columns]
+    names = _parameter_names(column_names)
+    where_column = _preferred_where_column(table, column_names)
+    set_columns = [column for column in column_names if column != where_column]
+    if not set_columns:
+        return "\n".join(
+            (
+                "update {}".format(_quote_identifier(table)),
+                "set {} = :new_{}".format(
+                    _quote_identifier(where_column), names[where_column]
+                ),
+                "where {} = :{}".format(
+                    _quote_identifier(where_column), names[where_column]
+                ),
+            )
+        )
+    return "\n".join(
+        (
+            "update {}".format(_quote_identifier(table)),
+            "set "
+            + ",\n".join(
+                "{}{} = :{}".format(
+                    "    " if index else "",
+                    _quote_identifier(column),
+                    names[column],
+                )
+                for index, column in enumerate(set_columns)
+            ),
+            "where {} = :{}".format(
+                _quote_identifier(where_column), names[where_column]
+            ),
+        )
+    )
+
+
+def _delete_template_sql(table, columns):
+    column_names = [column.name for column in columns]
+    names = _parameter_names(column_names)
+    where_column = _preferred_where_column(table, column_names)
+    return "\n".join(
+        (
+            "delete from {}".format(_quote_identifier(table)),
+            "where {} = :{}".format(
+                _quote_identifier(where_column), names[where_column]
+            ),
+        )
+    )
+
+
+def _template_sqls_for_table(table, columns):
+    return {
+        "insert": _insert_template_sql(table, columns),
+        "update": _update_template_sql(table, columns),
+        "delete": _delete_template_sql(table, columns),
+    }
+
+
+async def _template_sql_allowed(datasette, db, sql, actor):
+    params = {parameter: "" for parameter in _derived_query_parameters(sql)}
+    try:
+        analysis = await db.analyze_sql(sql, params)
+    except sqlite3.DatabaseError:
+        return False
+    if not _analysis_is_write(analysis):
+        return False
+    analysis_rows = await _analysis_rows_with_permissions(datasette, analysis, actor)
+    return _execute_write_disabled_reason(sql, None, analysis_rows) is None
+
+
+async def _write_template_tables(
+    datasette, db, table_columns, hidden_table_names, actor
+):
+    write_template_tables = {}
+    for table in table_columns:
+        if table in hidden_table_names or not table_columns[table]:
+            continue
+        column_details = [
+            column
+            for column in await db.table_column_details(table)
+            if not column.hidden
+        ]
+        if not column_details:
+            continue
+        templates = {}
+        for operation, sql in _template_sqls_for_table(table, column_details).items():
+            if await _template_sql_allowed(datasette, db, sql, actor):
+                templates[operation] = sql
+        if templates:
+            write_template_tables[table] = {
+                "templates": templates,
+            }
+    return write_template_tables
+
+
+def _write_template_operations(write_template_tables):
+    operations = []
+    for operation in WRITE_TEMPLATE_OPERATIONS:
+        if any(
+            operation in table["templates"] for table in write_template_tables.values()
+        ):
+            operations.append(
+                {
+                    "name": operation,
+                    "label": WRITE_TEMPLATE_LABELS[operation],
+                }
+            )
+    return operations
+
 
 class ExecuteWriteView(BaseView):
     name = "execute-write"
@@ -47,11 +229,10 @@ class ExecuteWriteView(BaseView):
         analysis_rows = []
         table_columns = await _table_columns(self.ds, db.name)
         hidden_table_names = set(await db.hidden_table_names())
-        write_template_tables = {
-            table: columns
-            for table, columns in table_columns.items()
-            if columns and table not in hidden_table_names
-        }
+        write_template_tables = await _write_template_tables(
+            self.ds, db, table_columns, hidden_table_names, request.actor
+        )
+        write_template_operations = _write_template_operations(write_template_tables)
         if sql and analysis_error is None:
             try:
                 parameter_names = _derived_query_parameters(sql)
@@ -107,6 +288,7 @@ class ExecuteWriteView(BaseView):
                 "execute_disabled_reason": execute_disabled_reason,
                 "table_columns": table_columns,
                 "write_template_tables": write_template_tables,
+                "write_template_operations": write_template_operations,
                 "save_query_url": save_query_url,
                 "save_query_base_url": save_query_base_url,
             },
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 87ecacde..89167a1d 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1,4 +1,6 @@
 import json
+import re
+from html import unescape
 
 import pytest
 
@@ -8,6 +10,19 @@ from datasette.stored_queries import StoredQuery, StoredQueryPage
 from datasette.utils.asgi import Forbidden
 
 
+def _template_option_attributes(html, table):
+    match = re.search(r'<option value="{}"([^>]*)>'.format(table), html)
+    assert match, "Could not find template option for {}".format(table)
+    return match.group(1)
+
+
+def _template_sql(html, table, operation):
+    attrs = _template_option_attributes(html, table)
+    match = re.search(r'data-template-{}-sql="([^"]*)"'.format(operation), attrs)
+    assert match, "Could not find {} template for {}".format(operation, table)
+    return unescape(match.group(1))
+
+
 async def add_numbered_queries(ds, database, count):
     for i in range(1, count + 1):
         await ds.add_query(
@@ -1360,7 +1375,8 @@ async def test_execute_write_get_prepopulates_without_executing():
     )
     assert "<h2>Query operations</h2>" in response.text
     assert "<summary>Start with a template</summary>" in response.text
-    assert '<option value="dogs">dogs</option>' in response.text
+    assert '<option value="dogs"' in response.text
+    assert "data-template-insert-sql=" in response.text
     assert 'data-sql-template="insert"' in response.text
     assert 'data-sql-template="update"' in response.text
     assert 'data-sql-template="delete"' in response.text
@@ -1469,6 +1485,105 @@ async def test_execute_write_disabled_submit_explains_denied_operations():
     )
 
 
+@pytest.mark.asyncio
+async def test_execute_write_templates_are_filtered_by_permission_and_server_generated():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": ["writer", "deleter", "viewer"]},
+                        "execute-write-sql": {"id": ["writer", "deleter", "viewer"]},
+                    },
+                    "tables": {
+                        "dogs": {
+                            "permissions": {
+                                "view-table": {"id": ["writer", "deleter"]},
+                                "insert-row": {"id": "writer"},
+                                "update-row": {"id": "writer"},
+                                "delete-row": {"id": ["writer", "deleter"]},
+                            }
+                        },
+                        "manual": {
+                            "permissions": {
+                                "view-table": {"id": "writer"},
+                                "insert-row": {"id": "writer"},
+                                "update-row": {"id": "writer"},
+                                "delete-row": {"id": "writer"},
+                            }
+                        },
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_templates", name="data")
+    await db.execute_write(
+        "create table dogs (id integer primary key, name text, age integer)"
+    )
+    await db.execute_write("create table manual (id text primary key, name text)")
+    await db.execute_write("create table cats (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    writer_response = await ds.client.get(
+        "/data/-/execute-write", actor={"id": "writer"}
+    )
+    deleter_response = await ds.client.get(
+        "/data/-/execute-write", actor={"id": "deleter"}
+    )
+    viewer_response = await ds.client.get(
+        "/data/-/execute-write", actor={"id": "viewer"}
+    )
+
+    assert writer_response.status_code == 200
+    assert "<summary>Start with a template</summary>" in writer_response.text
+    assert "You don't currently have permission" not in writer_response.text
+    assert '<option value="dogs"' in writer_response.text
+    assert '<option value="manual"' in writer_response.text
+    assert '<option value="cats"' not in writer_response.text
+    assert "function insertSql(" not in writer_response.text
+    assert "function updateSql(" not in writer_response.text
+    assert "function deleteSql(" not in writer_response.text
+
+    dogs_insert_sql = _template_sql(writer_response.text, "dogs", "insert")
+    assert '"id"' not in dogs_insert_sql
+    assert '"name"' in dogs_insert_sql
+    assert '"age"' in dogs_insert_sql
+    assert ":name" in dogs_insert_sql
+    assert ":age" in dogs_insert_sql
+
+    dogs_update_sql = _template_sql(writer_response.text, "dogs", "update")
+    assert 'where "id" = :id' in dogs_update_sql
+    assert '"id" = :new_id' not in dogs_update_sql
+
+    manual_insert_sql = _template_sql(writer_response.text, "manual", "insert")
+    assert '"id"' in manual_insert_sql
+    assert ":id" in manual_insert_sql
+
+    assert deleter_response.status_code == 200
+    assert "<summary>Start with a template</summary>" in deleter_response.text
+    assert '<option value="dogs"' in deleter_response.text
+    dogs_attrs = _template_option_attributes(deleter_response.text, "dogs")
+    assert "data-template-delete-sql" in dogs_attrs
+    assert "data-template-insert-sql" not in dogs_attrs
+    assert "data-template-update-sql" not in dogs_attrs
+    assert 'data-sql-template="delete"' in deleter_response.text
+    assert 'data-sql-template="insert"' not in deleter_response.text
+    assert 'data-sql-template="update"' not in deleter_response.text
+
+    assert viewer_response.status_code == 200
+    assert "<summary>Start with a template</summary>" not in viewer_response.text
+    assert (
+        "You don't currently have permission to insert, edit or delete from any tables."
+        in viewer_response.text
+    )
+    assert "data-template-insert-sql" not in viewer_response.text
+    assert "data-template-update-sql" not in viewer_response.text
+    assert "data-template-delete-sql" not in viewer_response.text
+
+
 @pytest.mark.asyncio
 async def test_execute_write_analyze_endpoint_uses_sql_only():
     ds = Datasette(memory=True, default_deny=True)

From 72cf476d1df758bb6cf929dfb19bbd04aafcaa85 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 20:28:24 -0700
Subject: [PATCH 134/386] Tidied up release notes ready to ship

Refs #2741, #2749
---
 docs/changelog.rst | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 3501aa60..3c4e9c11 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -9,16 +9,9 @@ Changelog
 Unreleased
 ----------
 
-Stored queries
-~~~~~~~~~~~~~~
+Datasette now offers users with the necessary permissions the ability to both **execute write queries** against their database and to **save stored queries** (renamed from "canned queries") both privately and for use by other members of their Datasette instance.
 
-- The previous "canned queries" feature has been renamed and expanded into :ref:`stored queries <stored_queries>`. Queries configured in ``datasette.yaml`` are now loaded into a new ``queries`` table in Datasette's :ref:`internal database <internals_internal_schema>`, alongside user-created stored queries. (:issue:`2735`)
-- New stored query management APIs: ``datasette.add_query()``, ``datasette.update_query()``, ``datasette.remove_query()``, ``datasette.get_query()``, ``datasette.list_queries()`` and ``datasette.count_queries()``. These replace the removed ``datasette.get_canned_query()`` and ``datasette.get_canned_queries()`` methods. (:issue:`2735`)
-- Users with :ref:`store-query <actions_store_query>` and :ref:`execute-sql <actions_execute_sql>` permission can create stored queries from the SQL query page or the new ``GET /<database>/-/queries/store`` form. (:issue:`2735`)
-- The database page now shows a count and preview of stored queries, capped at five, and links to new paginated query browsers at ``/-/queries`` and ``/<database>/-/queries``. Those browsers support search. (:issue:`2735`)
-- Stored queries created by users default to private and untrusted. Private stored queries can only be viewed, updated or deleted by their owner, even if another actor has broad ``view-query``, ``update-query`` or ``delete-query`` permission. Untrusted stored queries execute using the permissions of the actor running them. See :ref:`stored_queries` and :ref:`trusted_stored_queries` for details. (:issue:`2735`)
-- Configured queries from ``datasette.yaml`` are trusted by default, so they can execute with ``view-query`` permission alone. They can opt out of that behavior using ``is_trusted: false`` but cannot be made private; private queries are only available for user-created stored queries. (:issue:`2735`)
-- New ``store-query``, ``update-query`` and ``delete-query`` permissions, plus updated semantics for :ref:`view-query <actions_view_query>`. Trusted stored queries can still execute with ``view-query`` alone; untrusted read queries also require :ref:`execute-sql <actions_execute_sql>` and untrusted writable queries require :ref:`execute-write-sql <actions_execute_write_sql>` plus the relevant table-level write permissions. (:issue:`2735`)
+The ability to write is controlled by the new ``execute-write-sql`` permission, but the user also needs the relevant ``insert-row``/``update-row``/``delete-row``/``create-table``/etc permissions for the query they are trying to execute.
 
 Write SQL UI
 ~~~~~~~~~~~~
@@ -26,7 +19,18 @@ Write SQL UI
 - New "Write to this database" interface at ``/<database>/-/execute-write`` for running arbitrary writable SQL against mutable databases. The form extracts named parameters, analyzes the SQL, shows the table operations that will be attempted, includes starter templates for ``INSERT``, ``UPDATE`` and ``DELETE`` statements and links to a newly inserted row when a single-row insert succeeds. This is also available as a :ref:`JSON API <ExecuteWriteView>`. (:issue:`2742`)
 - Added the new :ref:`execute-write-sql <actions_execute_write_sql>` permission for running arbitrary writable SQL. Execution is also gated by table-level permissions such as :ref:`insert-row <actions_insert_row>`, :ref:`update-row <actions_update_row>` and :ref:`delete-row <actions_delete_row>`, and writes to attached databases are rejected. (:issue:`2742`)
 - The write SQL analyzer now uses a deny-by-default model for unsupported operations. Reads from source tables require :ref:`view-table <actions_view_table>` permission, schema changes require :ref:`create-table <actions_create_table>`, :ref:`alter-table <actions_alter_table>` or :ref:`drop-table <actions_drop_table>` as appropriate, and row mutation statements require the full ``insert-row``, ``update-row`` and ``delete-row`` permission set. SQL functions are allowed and are not separately permission-gated. (:issue:`2748`)
-- User-supplied write SQL now rejects ``VACUUM`` and writes to SQLite virtual tables or shadow tables. These restrictions also apply to untrusted stored write queries; trusted configured stored queries continue to skip these filters. (:issue:`2748`)
+- User-supplied write SQL rejects both ``VACUUM`` operations and writes to SQLite virtual or shadow tables. These restrictions also apply to untrusted stored write queries; trusted queries in ``datasette.yml`` skip these filters. (:issue:`2748`)
+
+Stored queries
+~~~~~~~~~~~~~~
+
+- The previous "canned queries" feature has been renamed and expanded into :ref:`stored queries <stored_queries>`. Queries configured in ``datasette.yaml`` are now loaded into a new ``queries`` table in Datasette's :ref:`internal database <internals_internal_schema>`, alongside user-created stored queries. (:issue:`2735`)
+- New stored query management API methods available to plugins: ``datasette.add_query()``, ``datasette.update_query()``, ``datasette.remove_query()``, ``datasette.get_query()``, ``datasette.list_queries()`` and ``datasette.count_queries()``. These replace the removed ``datasette.get_canned_query()`` and ``datasette.get_canned_queries()`` methods. (:issue:`2735`)
+- Users with :ref:`store-query <actions_store_query>` and :ref:`execute-sql <actions_execute_sql>` permission can create stored queries from the SQL query page or the new ``GET /<database>/-/queries/store`` form. (:issue:`2735`)
+- The database page now shows a count and preview of stored queries, capped at five, and links to new paginated query lists at ``/-/queries`` and ``/<database>/-/queries``. Those pages support search. (:issue:`2735`)
+- Stored queries created by users default to private and untrusted. Private stored queries can only be viewed, updated or deleted by their owner, even if another actor has broad ``view-query``, ``update-query`` or ``delete-query`` permission. Untrusted stored queries execute using the permissions of the actor running them. See :ref:`stored_queries` and :ref:`trusted_stored_queries` for details. (:issue:`2735`)
+- Configured queries from ``datasette.yaml`` are trusted by default, so they can execute with ``view-query`` permission alone. They can opt out of that behavior using ``is_trusted: false`` but cannot be made private; private queries are only available for user-created stored queries. (:issue:`2735`)
+- New ``store-query``, ``update-query`` and ``delete-query`` permissions, plus updated semantics for :ref:`view-query <actions_view_query>`. Trusted stored queries can still execute with ``view-query`` alone; untrusted read queries also require :ref:`execute-sql <actions_execute_sql>` and untrusted writable queries require :ref:`execute-write-sql <actions_execute_write_sql>` plus the relevant table-level write permissions. (:issue:`2735`)
 
 Plugin API changes
 ~~~~~~~~~~~~~~~~~~

From c1476a48d8ec0639018a1aa55187a30b62fc89c9 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 28 May 2026 20:29:57 -0700
Subject: [PATCH 135/386] Release 1.0a31

Refs #2712, #2735, #2742, #2743, #2747, #2748
---
 datasette/version.py | 2 +-
 docs/changelog.rst   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/datasette/version.py b/datasette/version.py
index 494d2dc0..76cabb1d 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a30"
+__version__ = "1.0a31"
 __version_info__ = tuple(__version__.split("."))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 3c4e9c11..4f9ffdbb 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,10 +4,10 @@
 Changelog
 =========
 
-.. _v1_0_unreleased:
+.. _v1_0_a31:
 
-Unreleased
-----------
+1.0a31 (2026-05-28)
+-------------------
 
 Datasette now offers users with the necessary permissions the ability to both **execute write queries** against their database and to **save stored queries** (renamed from "canned queries") both privately and for use by other members of their Datasette instance.
 

From 81a4df8a3e8a76d41c66f99488897a703eb3db86 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 30 May 2026 12:24:28 -0700
Subject: [PATCH 136/386] Fix for /-/jump with base_url set, closes #2757

---
 datasette/templates/base.html |  2 +-
 tests/test_html.py            | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/datasette/templates/base.html b/datasette/templates/base.html
index e1767deb..82ab48dd 100644
--- a/datasette/templates/base.html
+++ b/datasette/templates/base.html
@@ -71,6 +71,6 @@
 
 {% if select_templates %}<!-- Templates considered: {{ select_templates|join(", ") }} -->{% endif %}
 <script src="{{ urls.static('navigation-search.js') }}" defer></script>
-<navigation-search url="/-/jump"></navigation-search>
+<navigation-search url="{{ urls.path("/-/jump") }}"></navigation-search>
 </body>
 </html>
diff --git a/tests/test_html.py b/tests/test_html.py
index a9de5e79..96ee9c0c 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -943,6 +943,17 @@ def test_base_url_config(app_client_base_url_prefix, path, use_prefix):
                 indent=4,
                 default=repr,
             )
+    for el in soup.find_all("navigation-search"):
+        assert el["url"] == "/prefix/-/jump", json.dumps(
+            {
+                "path": path,
+                "path_to_get": path_to_get,
+                "url": el["url"],
+                "element": str(el),
+            },
+            indent=4,
+            default=repr,
+        )
 
 
 def test_base_url_affects_filter_redirects(app_client_base_url_prefix):

From d657fb4315e16acdbcf70640c27d21849f93cffa Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 30 May 2026 22:40:45 -0700
Subject: [PATCH 137/386] Fix double-prefixed export links with base_url

Use the router-stripped route_path when building request-derived export
URLs, so table, row, and query JSON/CSV links do not apply base_url twice.

Keep urls.path() behavior unchanged, and add coverage for both /prefix/
exports and a /data/ base_url with a data database.

Closes #2759
---
 datasette/utils/__init__.py  |  3 ++-
 datasette/views/base.py      | 20 +++++++++++---
 datasette/views/database.py  | 27 ++++++++++++++++---
 datasette/views/table.py     | 20 +++++++++++---
 tests/test_internals_urls.py |  2 ++
 tests/test_table_html.py     | 51 ++++++++++++++++++++++++++++++++++++
 tests/test_utils.py          |  6 +++++
 7 files changed, 118 insertions(+), 11 deletions(-)

diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 9d189459..2dff9667 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -837,7 +837,8 @@ def path_with_format(
     *, request=None, path=None, format=None, extra_qs=None, replace_format=None
 ):
     qs = extra_qs or {}
-    path = request.path if request else path
+    if path is None and request:
+        path = request.path
     if replace_format and path.endswith(f".{replace_format}"):
         path = path[: -(1 + len(replace_format))]
     if "." in path:
diff --git a/datasette/views/base.py b/datasette/views/base.py
index e4c1c738..2e2a5443 100644
--- a/datasette/views/base.py
+++ b/datasette/views/base.py
@@ -153,7 +153,13 @@ class BaseView:
         if self.has_json_alternate:
             alternate_url_json = self.ds.absolute_url(
                 request,
-                self.ds.urls.path(path_with_format(request=request, format="json")),
+                self.ds.urls.path(
+                    path_with_format(
+                        request=request,
+                        path=request.scope.get("route_path"),
+                        format="json",
+                    )
+                ),
             )
             template_context["alternate_url_json"] = alternate_url_json
             headers.update(
@@ -347,13 +353,21 @@ class DataView(BaseView):
                 if it_can_render:
                     renderers[key] = self.ds.urls.path(
                         path_with_format(
-                            request=request, format=key, extra_qs={**url_labels_extra}
+                            request=request,
+                            path=request.scope.get("route_path"),
+                            format=key,
+                            extra_qs={**url_labels_extra},
                         )
                     )
 
             url_csv_args = {"_size": "max", **url_labels_extra}
             url_csv = self.ds.urls.path(
-                path_with_format(request=request, format="csv", extra_qs=url_csv_args)
+                path_with_format(
+                    request=request,
+                    path=request.scope.get("route_path"),
+                    format="csv",
+                    extra_qs=url_csv_args,
+                )
             )
             url_csv_path = url_csv.split("?")[0]
             context = {
diff --git a/datasette/views/database.py b/datasette/views/database.py
index b4a964f1..3e3b05e3 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -157,7 +157,13 @@ class DatabaseView(View):
         assert format_ == "html"
         alternate_url_json = datasette.absolute_url(
             request,
-            datasette.urls.path(path_with_format(request=request, format="json")),
+            datasette.urls.path(
+                path_with_format(
+                    request=request,
+                    path=request.scope.get("route_path"),
+                    format="json",
+                )
+            ),
         )
         templates = (f"database-{to_css_class(database)}.html", "database.html")
         environment = datasette.get_jinja_environment(request)
@@ -744,7 +750,13 @@ class QueryView(View):
             template = environment.select_template(templates)
             alternate_url_json = datasette.absolute_url(
                 request,
-                datasette.urls.path(path_with_format(request=request, format="json")),
+                datasette.urls.path(
+                    path_with_format(
+                        request=request,
+                        path=request.scope.get("route_path"),
+                        format="json",
+                    )
+                ),
             )
             data = {}
             headers.update(
@@ -776,7 +788,11 @@ class QueryView(View):
                 it_can_render = await await_me_maybe(it_can_render)
                 if it_can_render:
                     renderers[key] = datasette.urls.path(
-                        path_with_format(request=request, format=key)
+                        path_with_format(
+                            request=request,
+                            path=request.scope.get("route_path"),
+                            format=key,
+                        )
                     )
 
             allow_execute_sql = await datasette.allowed(
@@ -905,7 +921,10 @@ class QueryView(View):
                         renderers=renderers,
                         url_csv=datasette.urls.path(
                             path_with_format(
-                                request=request, format="csv", extra_qs={"_size": "max"}
+                                request=request,
+                                path=request.scope.get("route_path"),
+                                format="csv",
+                                extra_qs={"_size": "max"},
                             )
                         ),
                         show_hide_hidden=markupsafe.Markup(show_hide_hidden),
diff --git a/datasette/views/table.py b/datasette/views/table.py
index da69c6b5..4df1e1b4 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1072,7 +1072,13 @@ async def table_view_traced(datasette, request):
         template = environment.select_template(templates)
         alternate_url_json = datasette.absolute_url(
             request,
-            datasette.urls.path(path_with_format(request=request, format="json")),
+            datasette.urls.path(
+                path_with_format(
+                    request=request,
+                    path=request.scope.get("route_path"),
+                    format="json",
+                )
+            ),
         )
         headers.update(
             {
@@ -1878,7 +1884,10 @@ async def table_view_data(
             if it_can_render:
                 renderers[key] = datasette.urls.path(
                     path_with_format(
-                        request=request, format=key, extra_qs={**url_labels_extra}
+                        request=request,
+                        path=request.scope.get("route_path"),
+                        format=key,
+                        extra_qs={**url_labels_extra},
                     )
                 )
         return renderers
@@ -2042,7 +2051,12 @@ async def table_view_data(
             url_labels_extra = {"_labels": "on"}
         url_csv_args = {"_size": "max", **url_labels_extra}
         url_csv = datasette.urls.path(
-            path_with_format(request=request, format="csv", extra_qs=url_csv_args)
+            path_with_format(
+                request=request,
+                path=request.scope.get("route_path"),
+                format="csv",
+                extra_qs=url_csv_args,
+            )
         )
         url_csv_path = url_csv.split("?")[0]
         data.update(
diff --git a/tests/test_internals_urls.py b/tests/test_internals_urls.py
index d60aafcf..fc7b0313 100644
--- a/tests/test_internals_urls.py
+++ b/tests/test_internals_urls.py
@@ -16,6 +16,8 @@ def ds():
         ("/prefix/", "/", "/prefix/"),
         ("/prefix/", "/foo", "/prefix/foo"),
         ("/prefix/", "foo", "/prefix/foo"),
+        ("/data/", "/data", "/data/data"),
+        ("/data/", "/data/foo", "/data/data/foo"),
     ],
 )
 def test_path(ds, base_url, path, expected):
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 86b9a4eb..2e671d55 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -510,6 +510,57 @@ async def test_table_csv_json_export_interface(ds_client):
     ] == inputs
 
 
+def test_base_url_export_links_are_not_double_prefixed(app_client_base_url_prefix):
+    for path, expected_json, expected_csv in (
+        (
+            "/prefix/fixtures/simple_primary_key?id__gt=2",
+            "/prefix/fixtures/simple_primary_key.json?id__gt=2",
+            "/prefix/fixtures/simple_primary_key.csv?id__gt=2&_size=max",
+        ),
+        (
+            "/prefix/fixtures/simple_primary_key/1",
+            "/prefix/fixtures/simple_primary_key/1.json",
+            None,
+        ),
+        (
+            "/prefix/fixtures/-/query?sql=select+1",
+            "/prefix/fixtures/-/query.json?sql=select+1",
+            "/prefix/fixtures/-/query.csv?sql=select+1&_size=max",
+        ),
+    ):
+        response = app_client_base_url_prefix.get(path)
+        assert response.status_code == 200
+        soup = Soup(response.text, "html.parser")
+        export_links = soup.find("p", {"class": "export-links"}) or next(
+            p for p in soup.find_all("p") if "This data as" in p.get_text()
+        )
+        hrefs = [a["href"] for a in export_links.find_all("a", href=True)]
+        assert expected_json in hrefs
+        if expected_csv:
+            assert expected_csv in hrefs
+        assert not [href for href in hrefs if href.startswith("/prefix/prefix/")]
+        assert response.headers["link"] == (
+            f"<http://localhost{expected_json}>; "
+            'rel="alternate"; type="application/json+datasette"'
+        )
+
+
+def test_base_url_export_links_when_database_matches_prefix():
+    with make_app_client(settings={"base_url": "/data/"}, filename="data.db") as client:
+        response = client.get("/data/data/simple_primary_key?id__gt=2")
+        assert response.status_code == 200
+        export_links = Soup(response.text, "html.parser").find(
+            "p", {"class": "export-links"}
+        )
+        hrefs = [a["href"] for a in export_links.find_all("a", href=True)]
+        assert "/data/data/simple_primary_key.json?id__gt=2" in hrefs
+        assert "/data/data/simple_primary_key.csv?id__gt=2&_size=max" in hrefs
+        assert response.headers["link"] == (
+            "<http://localhost/data/data/simple_primary_key.json?id__gt=2>; "
+            'rel="alternate"; type="application/json+datasette"'
+        )
+
+
 @pytest.mark.asyncio
 async def test_csv_json_export_links_include_labels_if_foreign_keys(ds_client):
     response = await ds_client.get("/fixtures/facetable")
diff --git a/tests/test_utils.py b/tests/test_utils.py
index e83eed7a..f6de3b46 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -453,6 +453,12 @@ def test_path_with_format(path, format, extra_qs, expected):
     assert expected == actual
 
 
+def test_path_with_format_can_override_request_path():
+    request = Request.fake("/prefix/foo?x=1")
+    actual = utils.path_with_format(request=request, path="/foo", format="json")
+    assert "/foo.json?x=1" == actual
+
+
 @pytest.mark.parametrize(
     "bytes,expected",
     [

From 1558ab79898469918d03b4e17480f9ff0817fc9e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 30 May 2026 22:46:45 -0700
Subject: [PATCH 138/386] Fix remaining base_url issues

---
 datasette/app.py                      | 17 +++---
 datasette/templates/api_explorer.html |  4 +-
 datasette/templates/patterns.html     | 84 +++++++++++++--------------
 datasette/views/database.py           |  6 +-
 datasette/views/special.py            |  5 +-
 tests/test_html.py                    | 25 +++++++-
 6 files changed, 85 insertions(+), 56 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index e7f34e69..8b8b601f 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2870,19 +2870,22 @@ def wrap_view_function(view_fn, datasette):
 
 
 def permanent_redirect(path, forward_query_string=False, forward_rest=False):
-    return wrap_view(
-        lambda request, send: Response.redirect(
+    def view(request, send):
+        redirect_path = (
             path
             + (request.url_vars["rest"] if forward_rest else "")
             + (
                 ("?" + request.query_string)
                 if forward_query_string and request.query_string
                 else ""
-            ),
-            status=301,
-        ),
-        datasette=None,
-    )
+            )
+        )
+        route_path = request.scope.get("route_path")
+        if route_path and request.path.endswith(route_path):
+            redirect_path = request.path[: -len(route_path)] + redirect_path
+        return Response.redirect(redirect_path, status=301)
+
+    return wrap_view(view, datasette=None)
 
 
 _curly_re = re.compile(r"({.*?})")
diff --git a/datasette/templates/api_explorer.html b/datasette/templates/api_explorer.html
index dc393c20..58e2a88c 100644
--- a/datasette/templates/api_explorer.html
+++ b/datasette/templates/api_explorer.html
@@ -19,7 +19,7 @@
 </p>
 <details open style="border: 2px solid #ccc; border-bottom: none; padding: 0.5em">
   <summary style="cursor: pointer;">GET</summary>
-  <form class="core" method="get" id="api-explorer-get" style="margin-top: 0.7em">
+  <form class="core" method="get" action="{{ urls.path('-/api') }}" id="api-explorer-get" style="margin-top: 0.7em">
     <div>
       <label for="path">API path:</label>
       <input type="text" id="path" name="path" style="width: 60%">
@@ -29,7 +29,7 @@
 </details>
 <details style="border: 2px solid #ccc; padding: 0.5em">
   <summary style="cursor: pointer">POST</summary>
-  <form class="core" method="post" id="api-explorer-post" style="margin-top: 0.7em">
+  <form class="core" method="post" action="{{ urls.path('-/api') }}" id="api-explorer-post" style="margin-top: 0.7em">
     <div>
       <label for="path">API path:</label>
       <input type="text" id="path" name="path" style="width: 60%">
diff --git a/datasette/templates/patterns.html b/datasette/templates/patterns.html
index 7770f7d4..a46478a7 100644
--- a/datasette/templates/patterns.html
+++ b/datasette/templates/patterns.html
@@ -11,7 +11,7 @@
 
 <header class="hd"><nav>
     <p class="crumbs">
-        <a href="/">home</a>
+        <a href="{{ base_url }}">home</a>
     </p>
     <details class="nav-menu details-menu">
         <summary><svg aria-labelledby="nav-menu-svg-title" role="img"
@@ -22,11 +22,11 @@
         </svg></summary>
         <div class="nav-menu-inner">
             <ul>
-                <li><a href="/-/databases">Databases</a></li>
-                <li><a href="/-/plugins">Installed plugins</a></li>
-                <li><a href="/-/versions">Version info</a></li>
+                <li><a href="{{ base_url }}-/databases">Databases</a></li>
+                <li><a href="{{ base_url }}-/plugins">Installed plugins</a></li>
+                <li><a href="{{ base_url }}-/versions">Version info</a></li>
             </ul>
-            <form class="nav-menu-logout" action="/-/logout" method="post">
+            <form class="nav-menu-logout" action="{{ base_url }}-/logout" method="post">
                 <button class="button-as-link">Log out</button>
             </form>
         </div>
@@ -48,9 +48,9 @@
 <header class="hd">
   <nav>
       <p class="crumbs">
-          <a href="/">home</a> /
-          <a href="/fixtures">fixtures</a> /
-          <a href="/fixtures/attraction_characteristic">attraction_characteristic</a>
+          <a href="{{ base_url }}">home</a> /
+          <a href="{{ base_url }}fixtures">fixtures</a> /
+          <a href="{{ base_url }}fixtures/attraction_characteristic">attraction_characteristic</a>
       </p>
       <div class="actor">
           <strong>testuser</strong>
@@ -80,16 +80,16 @@
             <a href="https://github.com/simonw/datasette">
         About Datasette</a>
     </p>
-    <h2 style="padding-left: 10px; border-left: 10px solid #9403e5"><a href="/fixtures">fixtures</a></h2>
+    <h2 style="padding-left: 10px; border-left: 10px solid #9403e5"><a href="{{ base_url }}fixtures">fixtures</a></h2>
     <p>
         1,258 rows in 24 tables, 206 rows in 5 hidden tables, 4 views
     </p>
-    <p><a href="/fixtures/compound_three_primary_keys" title="1001 rows">compound_three_primary_keys</a>, <a href="/fixtures/sortable" title="201 rows">sortable</a>, <a href="/fixtures/facetable" title="15 rows">facetable</a>, <a href="/fixtures/roadside_attraction_characteristics" title="5 rows">roadside_attraction_characteristics</a>, <a href="/fixtures/simple_primary_key" title="4 rows">simple_primary_key</a>, <a href="/fixtures">...</a></p>
-    <h2 style="padding-left: 10px; border-left: 10px solid #8d777f"><a href="/data">data</a></h2>
+    <p><a href="{{ base_url }}fixtures/compound_three_primary_keys" title="1001 rows">compound_three_primary_keys</a>, <a href="{{ base_url }}fixtures/sortable" title="201 rows">sortable</a>, <a href="{{ base_url }}fixtures/facetable" title="15 rows">facetable</a>, <a href="{{ base_url }}fixtures/roadside_attraction_characteristics" title="5 rows">roadside_attraction_characteristics</a>, <a href="{{ base_url }}fixtures/simple_primary_key" title="4 rows">simple_primary_key</a>, <a href="{{ base_url }}fixtures">...</a></p>
+    <h2 style="padding-left: 10px; border-left: 10px solid #8d777f"><a href="{{ base_url }}data">data</a></h2>
     <p>
         6 rows in 2 tables
     </p>
-    <p><a href="/data/names" title="6 rows">names</a>, <a href="/data/foo">foo</a></p>
+    <p><a href="{{ base_url }}data/names" title="6 rows">names</a>, <a href="{{ base_url }}data/foo">foo</a></p>
 </section>
 
 <h2 class="pattern-heading">.bd for /database</h2>
@@ -134,7 +134,7 @@
             <a href="https://github.com/simonw/datasette">
         About Datasette</a>
     </p>
-    <form class="sql" action="/fixtures" method="get">
+    <form class="sql" action="{{ base_url }}fixtures" method="get">
         <h3>Custom SQL query</h3>
         <p><textarea id="sql-editor" name="sql">select * from [123_starts_with_digits]</textarea></p>
         <p>
@@ -143,17 +143,17 @@
         </p>
     </form>
     <div class="db-table">
-        <h2><a href="/fixtures/123_starts_with_digits">123_starts_with_digits</a></h2>
+        <h2><a href="{{ base_url }}fixtures/123_starts_with_digits">123_starts_with_digits</a></h2>
         <p><em>content</em></p>
         <p>0 rows</p>
     </div>
     <div class="db-table">
-        <h2><a href="/fixtures/Table+With+Space+In+Name">Table With Space In Name</a></h2>
+        <h2><a href="{{ base_url }}fixtures/Table+With+Space+In+Name">Table With Space In Name</a></h2>
         <p><em>pk, content</em></p>
         <p>0 rows</p>
     </div>
     <div class="db-table">
-        <h2><a href="/fixtures/attraction_characteristic">attraction_characteristic</a></h2>
+        <h2><a href="{{ base_url }}fixtures/attraction_characteristic">attraction_characteristic</a></h2>
         <p><em>pk, name</em></p>
         <p>2 rows</p>
     </div>
@@ -202,7 +202,7 @@
     <h3>3 rows
         where characteristic_id = 2
     </h3>
-    <form class="filters" action="/fixtures/roadside_attraction_characteristics" method="get">
+    <form class="filters" action="{{ base_url }}fixtures/roadside_attraction_characteristics" method="get">
     <div class="search-row"><label for="_search">Search:</label><input id="_search" type="search" name="_search" value=""></div>
         <div class="filter-row">
             <div class="select-wrapper">
@@ -290,16 +290,16 @@
     <h3>2 extra where clauses</h3>
     <ul>
 
-        <li><code>planet_int=1</code> [<a href="/fixtures/facetable?_where=state%3D%27CA%27">remove</a>]</li>
+        <li><code>planet_int=1</code> [<a href="{{ base_url }}fixtures/facetable?_where=state%3D%27CA%27">remove</a>]</li>
 
-        <li><code>state='CA'</code> [<a href="/fixtures/facetable?_where=planet_int%3D1">remove</a>]</li>
+        <li><code>state='CA'</code> [<a href="{{ base_url }}fixtures/facetable?_where=planet_int%3D1">remove</a>]</li>
 
     </ul>
   </div>
 
-  <p><a class="not-underlined" title="select rowid, attraction_id, characteristic_id from roadside_attraction_characteristics where &#34;characteristic_id&#34; = :p0 order by rowid limit 101" href="/fixtures?sql=select+rowid%2C+attraction_id%2C+characteristic_id+from+roadside_attraction_characteristics+where+%22characteristic_id%22+%3D+%3Ap0+order+by+rowid+limit+101&amp;p0=2">&#x270e; <span class="underlined">View and edit SQL</span></a></p>
+  <p><a class="not-underlined" title="select rowid, attraction_id, characteristic_id from roadside_attraction_characteristics where &#34;characteristic_id&#34; = :p0 order by rowid limit 101" href="{{ base_url }}fixtures?sql=select+rowid%2C+attraction_id%2C+characteristic_id+from+roadside_attraction_characteristics+where+%22characteristic_id%22+%3D+%3Ap0+order+by+rowid+limit+101&amp;p0=2">&#x270e; <span class="underlined">View and edit SQL</span></a></p>
 
-  <p class="export-links">This data as <a href="/fixtures/roadside_attraction_characteristics.json?characteristic_id=2&amp;_labels=on">json</a>, <a href="/fixtures/roadside_attraction_characteristics.csv?characteristic_id=2&amp;_labels=on&amp;_size=max">CSV</a> (<a href="#export">advanced</a>)</p>
+  <p class="export-links">This data as <a href="{{ base_url }}fixtures/roadside_attraction_characteristics.json?characteristic_id=2&amp;_labels=on">json</a>, <a href="{{ base_url }}fixtures/roadside_attraction_characteristics.csv?characteristic_id=2&amp;_labels=on&amp;_size=max">CSV</a> (<a href="#export">advanced</a>)</p>
 
   <p class="suggested-facets">
         Suggested facets: <a href="http://latest.datasette.io/fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=city_id&amp;_facet=created&amp;_facet=complex_array&amp;_facet=tags#facet-tags">tags</a>, <a href="http://latest.datasette.io/fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=city_id&amp;_facet=created&amp;_facet=complex_array&amp;_facet_date=created#facet-created">created</a> (date), <a href="http://latest.datasette.io/fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=city_id&amp;_facet=created&amp;_facet=complex_array&amp;_facet_array=tags#facet-tags">tags</a> (array)
@@ -311,7 +311,7 @@
                 <p class="facet-info-name">
                     <strong>tags (array)</strong>
 
-                        <a href="/fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=city_id&amp;_facet=created" class="cross">✖</a>
+                        <a href="{{ base_url }}fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=city_id&amp;_facet=created" class="cross">✖</a>
 
                 </p>
                 <ul>
@@ -336,7 +336,7 @@
                 <p class="facet-info-name">
                     <strong>created</strong>
 
-                        <a href="/fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=city_id&amp;_facet_array=tags" class="cross">✖</a>
+                        <a href="{{ base_url }}fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=city_id&amp;_facet_array=tags" class="cross">✖</a>
 
                 </p>
                 <ul>
@@ -361,7 +361,7 @@
                 <p class="facet-info-name">
                     <strong>city_id</strong>
 
-                        <a href="/fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=created&amp;_facet_array=tags" class="cross">✖</a>
+                        <a href="{{ base_url }}fixtures/facetable?_where=planet_int%3D1&amp;_where=state%3D%27CA%27&amp;_facet=created&amp;_facet_array=tags" class="cross">✖</a>
 
                 </p>
                 <ul>
@@ -387,45 +387,45 @@
                                 Link
                         </th>
                     <th class="col-rowid" scope="col">
-                                            <a href="/fixtures/roadside_attraction_characteristics?characteristic_id=2&amp;_sort_desc=rowid" rel="nofollow">rowid&nbsp;▼</a>
+                                            <a href="{{ base_url }}fixtures/roadside_attraction_characteristics?characteristic_id=2&amp;_sort_desc=rowid" rel="nofollow">rowid&nbsp;▼</a>
                                 </th>
                     <th class="col-attraction_id" scope="col">
-                                            <a href="/fixtures/roadside_attraction_characteristics?characteristic_id=2&amp;_sort=attraction_id" rel="nofollow">attraction_id</a>
+                                            <a href="{{ base_url }}fixtures/roadside_attraction_characteristics?characteristic_id=2&amp;_sort=attraction_id" rel="nofollow">attraction_id</a>
                                 </th>
                     <th class="col-characteristic_id" scope="col">
-                                            <a href="/fixtures/roadside_attraction_characteristics?characteristic_id=2&amp;_sort=characteristic_id" rel="nofollow">characteristic_id</a>
+                                            <a href="{{ base_url }}fixtures/roadside_attraction_characteristics?characteristic_id=2&amp;_sort=characteristic_id" rel="nofollow">characteristic_id</a>
                                 </th>
             </tr>
         </thead>
         <tbody>
             <tr>
-                    <td class="col-Link"><a href="/fixtures/roadside_attraction_characteristics/1">1</a></td>
+                    <td class="col-Link"><a href="{{ base_url }}fixtures/roadside_attraction_characteristics/1">1</a></td>
                     <td class="col-rowid">1</td>
-                    <td class="col-attraction_id"><a href="/fixtures/roadside_attractions/1">The Mystery Spot</a>&nbsp;<em>1</em></td>
-                    <td class="col-characteristic_id"><a href="/fixtures/attraction_characteristic/2">Paranormal</a>&nbsp;<em>2</em></td>
+                    <td class="col-attraction_id"><a href="{{ base_url }}fixtures/roadside_attractions/1">The Mystery Spot</a>&nbsp;<em>1</em></td>
+                    <td class="col-characteristic_id"><a href="{{ base_url }}fixtures/attraction_characteristic/2">Paranormal</a>&nbsp;<em>2</em></td>
             </tr>
             <tr>
-                    <td class="col-Link"><a href="/fixtures/roadside_attraction_characteristics/2">2</a></td>
+                    <td class="col-Link"><a href="{{ base_url }}fixtures/roadside_attraction_characteristics/2">2</a></td>
                     <td class="col-rowid">2</td>
-                    <td class="col-attraction_id"><a href="/fixtures/roadside_attractions/2">Winchester Mystery House</a>&nbsp;<em>2</em></td>
-                    <td class="col-characteristic_id"><a href="/fixtures/attraction_characteristic/2">Paranormal</a>&nbsp;<em>2</em></td>
+                    <td class="col-attraction_id"><a href="{{ base_url }}fixtures/roadside_attractions/2">Winchester Mystery House</a>&nbsp;<em>2</em></td>
+                    <td class="col-characteristic_id"><a href="{{ base_url }}fixtures/attraction_characteristic/2">Paranormal</a>&nbsp;<em>2</em></td>
             </tr>
             <tr>
-                    <td class="col-Link"><a href="/fixtures/roadside_attraction_characteristics/3">3</a></td>
+                    <td class="col-Link"><a href="{{ base_url }}fixtures/roadside_attraction_characteristics/3">3</a></td>
                     <td class="col-rowid">3</td>
-                    <td class="col-attraction_id"><a href="/fixtures/roadside_attractions/4">Bigfoot Discovery Museum</a>&nbsp;<em>4</em></td>
-                    <td class="col-characteristic_id"><a href="/fixtures/attraction_characteristic/2">Paranormal</a>&nbsp;<em>2</em></td>
+                    <td class="col-attraction_id"><a href="{{ base_url }}fixtures/roadside_attractions/4">Bigfoot Discovery Museum</a>&nbsp;<em>4</em></td>
+                    <td class="col-characteristic_id"><a href="{{ base_url }}fixtures/attraction_characteristic/2">Paranormal</a>&nbsp;<em>2</em></td>
             </tr>
         </tbody>
     </table>
     <div id="export" class="advanced-export">
         <h3>Advanced export</h3>
         <p>JSON shape:
-            <a href="/fixtures/roadside_attraction_characteristics.json?characteristic_id=2&amp;_labels=on">default</a>,
-            <a href="/fixtures/roadside_attraction_characteristics.json?characteristic_id=2&amp;_labels=on&amp;_shape=array">array</a>,
-            <a href="/fixtures/roadside_attraction_characteristics.json?characteristic_id=2&amp;_labels=on&amp;_shape=array&amp;_nl=on">newline-delimited</a>
+            <a href="{{ base_url }}fixtures/roadside_attraction_characteristics.json?characteristic_id=2&amp;_labels=on">default</a>,
+            <a href="{{ base_url }}fixtures/roadside_attraction_characteristics.json?characteristic_id=2&amp;_labels=on&amp;_shape=array">array</a>,
+            <a href="{{ base_url }}fixtures/roadside_attraction_characteristics.json?characteristic_id=2&amp;_labels=on&amp;_shape=array&amp;_nl=on">newline-delimited</a>
         </p>
-        <form action="/fixtures/roadside_attraction_characteristics.csv" method="get">
+        <form action="{{ base_url }}fixtures/roadside_attraction_characteristics.csv" method="get">
             <p>
                 CSV options:
                 <label><input type="checkbox" name="_dl"> download file</label>
@@ -445,7 +445,7 @@
 <h2 class="pattern-heading">.bd for /database/table/row</h2>
 <section class="content">
     <h1 style="padding-left: 10px; border-left: 10px solid #ff0000">roadside_attractions: 2</h1>
-    <p>This data as <a href="/fixtures/roadside_attractions/2.json">json</a></p>
+    <p>This data as <a href="{{ base_url }}fixtures/roadside_attractions/2.json">json</a></p>
     <table class="rows-and-columns">
         <thead>
             <tr>
@@ -479,7 +479,7 @@
     <h2>Links from other tables</h2>
     <ul>
             <li>
-                <a href="/fixtures/roadside_attraction_characteristics?attraction_id=2">
+                <a href="{{ base_url }}fixtures/roadside_attraction_characteristics?attraction_id=2">
                     1 row</a>
                 from attraction_id in roadside_attraction_characteristics
             </li>
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 3e3b05e3..d6c88962 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -60,9 +60,11 @@ class DatabaseView(View):
 
         sql = (request.args.get("sql") or "").strip()
         if sql:
-            redirect_url = "/" + request.url_vars.get("database") + "/-/query"
+            redirect_url = datasette.urls.database(database) + "/-/query"
             if request.url_vars.get("format"):
-                redirect_url += "." + request.url_vars.get("format")
+                redirect_url = path_with_format(
+                    path=redirect_url, format=request.url_vars.get("format")
+                )
             redirect_url += "?" + request.query_string
             response = Response.redirect(redirect_url)
             if datasette.cors:
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 6c82983c..75c54c3c 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -892,14 +892,15 @@ class ApiExplorerView(BaseView):
             raise Forbidden("You do not have permission to view this instance")
 
         def api_path(link):
-            return "/-/api#{}".format(
+            return "{}#{}".format(
+                self.ds.urls.path("/-/api"),
                 urllib.parse.urlencode(
                     {
                         key: json.dumps(value, indent=2) if key == "json" else value
                         for key, value in link.items()
                         if key in ("path", "method", "json")
                     }
-                )
+                ),
             )
 
         return await self.render(
diff --git a/tests/test_html.py b/tests/test_html.py
index 96ee9c0c..bb7f612e 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -878,6 +878,8 @@ def test_debug_context_includes_extra_template_vars():
         "/fixtures/facetable",
         "/fixtures/facetable?_facet=state",
         "/fixtures/-/query?sql=select+1",
+        "/-/api",
+        "/-/patterns",
     ],
 )
 @pytest.mark.parametrize("use_prefix", (True, False))
@@ -932,7 +934,9 @@ def test_base_url_config(app_client_base_url_prefix, path, use_prefix):
         ):
             # If this has been made absolute it may start http://localhost/
             if href.startswith("http://localhost/"):
-                href = href[len("http://localost/") :]
+                href = href[len("http://localhost") :]
+            elif href.startswith(("http://", "https://")):
+                continue
             assert href.startswith("/prefix/"), json.dumps(
                 {
                     "path": path,
@@ -966,6 +970,25 @@ def test_base_url_affects_filter_redirects(app_client_base_url_prefix):
     )
 
 
+def test_base_url_affects_database_sql_redirect(app_client_base_url_prefix):
+    response = app_client_base_url_prefix.get(
+        "/prefix/fixtures?sql=select+1", follow_redirects=False
+    )
+    assert response.status_code == 302
+    assert response.headers["location"] == "/prefix/fixtures/-/query?sql=select+1"
+
+
+def test_base_url_affects_permanent_redirects():
+    with make_app_client(memory=True, settings={"base_url": "/prefix/"}) as client:
+        response = client.get("/prefix/-", follow_redirects=False)
+        assert response.status_code == 301
+        assert response.headers["location"] == "/prefix/-/"
+
+        response2 = client.get("/prefix/:memory:", follow_redirects=False)
+        assert response2.status_code == 301
+        assert response2.headers["location"] == "/prefix/_memory"
+
+
 def test_base_url_affects_metadata_extra_css_urls(app_client_base_url_prefix):
     html = app_client_base_url_prefix.get("/").text
     assert '<link rel="stylesheet" href="/prefix/static/extra-css-urls.css">' in html

From b1f3e4368c81490c1468b1c641e02fa15771b013 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 31 May 2026 16:15:34 -0700
Subject: [PATCH 139/386] Fixes for SQL write with RETURNING (#2763)

* Fix for execute write returning, closes #2762
* Fix stored write returning rowcount message
* Add configurable execute_write returning limit
* Return rows/truncated from execute query if it used RETURNING
* INSERT ... RETURNING shows rows in /-/execute-write
* Skip RETURNING tests if SQLite version does not support it

Screenshot: https://github.com/simonw/datasette/issues/2762#issuecomment-4588111545
---
 datasette/database.py                   |  57 ++++++-
 datasette/templates/_query_results.html |  20 +++
 datasette/templates/execute_write.html  |  11 ++
 datasette/templates/query.html          |  22 +--
 datasette/utils/sqlite.py               |  16 ++
 datasette/views/database.py             |  10 +-
 datasette/views/execute_write.py        |  59 +++++--
 docs/internals.rst                      |  29 +++-
 docs/json_api.rst                       |  42 ++++-
 tests/test_internals_database.py        | 181 ++++++++++++++++++++-
 tests/test_queries.py                   | 201 ++++++++++++++++++++++++
 tests/test_utils.py                     |  21 ++-
 12 files changed, 622 insertions(+), 47 deletions(-)
 create mode 100644 datasette/templates/_query_results.html

diff --git a/datasette/database.py b/datasette/database.py
index 10417670..0a32442c 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -31,6 +31,8 @@ from .inspect import inspect_hash
 
 connections = threading.local()
 
+EXECUTE_WRITE_RETURNING_LIMIT = 10
+
 AttachedDatabase = namedtuple("AttachedDatabase", ("seq", "name", "file"))
 
 
@@ -236,11 +238,24 @@ class Database:
                 except OSError:
                     pass
 
-    async def execute_write(self, sql, params=None, block=True, request=None):
+    async def execute_write(
+        self,
+        sql,
+        params=None,
+        block=True,
+        request=None,
+        return_all=False,
+        returning_limit=EXECUTE_WRITE_RETURNING_LIMIT,
+    ):
         self._check_not_closed()
+        if returning_limit < 0:
+            raise ValueError("returning_limit must be >= 0")
 
         def _inner(conn):
-            return conn.execute(sql, params or [])
+            cursor = conn.execute(sql, params or [])
+            return ExecuteWriteResult.from_cursor(
+                cursor, return_all=return_all, returning_limit=returning_limit
+            )
 
         with trace("sql", database=self.name, sql=sql.strip(), params=params):
             results = await self.execute_write_fn(_inner, block=block, request=request)
@@ -877,6 +892,44 @@ class MultipleValues(Exception):
     pass
 
 
+class ExecuteWriteResult:
+    def __init__(self, rowcount, lastrowid, description, rows, truncated):
+        self.rowcount = rowcount
+        self.lastrowid = lastrowid
+        self.description = description
+        self.truncated = truncated
+        self._rows = rows
+
+    @classmethod
+    def from_cursor(
+        cls, cursor, return_all=False, returning_limit=EXECUTE_WRITE_RETURNING_LIMIT
+    ):
+        rows = []
+        truncated = False
+        description = cursor.description
+        lastrowid = cursor.lastrowid
+        try:
+            if description is not None:
+                if return_all:
+                    rows = cursor.fetchall()
+                else:
+                    rows = cursor.fetchmany(returning_limit + 1)
+                    if len(rows) > returning_limit:
+                        rows = rows[:returning_limit]
+                        truncated = True
+            rowcount = cursor.rowcount
+        finally:
+            cursor.close()
+        if description is not None and not return_all and truncated:
+            rowcount = -1
+        return cls(rowcount, lastrowid, description, rows, truncated)
+
+    def fetchall(self):
+        rows = self._rows
+        self._rows = []
+        return rows
+
+
 class Results:
     def __init__(self, rows, truncated, description):
         self.rows = rows
diff --git a/datasette/templates/_query_results.html b/datasette/templates/_query_results.html
new file mode 100644
index 00000000..5e1e2f72
--- /dev/null
+++ b/datasette/templates/_query_results.html
@@ -0,0 +1,20 @@
+{% if display_rows %}
+<div class="table-wrapper"><table class="rows-and-columns">
+    <thead>
+        <tr>
+            {% for column in columns %}<th class="col-{{ column|to_css_class }}" scope="col">{{ column }}</th>{% endfor %}
+        </tr>
+    </thead>
+    <tbody>
+    {% for row in display_rows %}
+        <tr>
+            {% for column, td in zip(columns, row) %}
+                <td class="col-{{ column|to_css_class }}">{{ td }}</td>
+            {% endfor %}
+        </tr>
+    {% endfor %}
+    </tbody>
+</table></div>
+{% elif show_zero_results %}
+    <p class="zero-results">0 results</p>
+{% endif %}
diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 394261de..a93de3a6 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -81,6 +81,17 @@ form.sql.core input[data-execute-write-submit]:disabled {
     <p class="{% if execution_ok %}message-info{% else %}message-error{% endif %}">{{ execution_message }}{% for link in execution_links %} <a href="{{ link.href }}">{{ link.label }}</a>{% endfor %}</p>
 {% endif %}
 
+{% if execute_write_returns_rows %}
+    <h2>Returned rows</h2>
+    {% if execute_write_truncated %}
+        <p class="message-warning">Only the first {{ "{:,}".format(execute_write_display_rows|length) }} returned rows are shown.</p>
+    {% endif %}
+    {% set columns = execute_write_columns %}
+    {% set display_rows = execute_write_display_rows %}
+    {% set show_zero_results = true %}
+    {% include "_query_results.html" %}
+{% endif %}
+
 <form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post" data-analyze-url="{{ urls.database(database) }}/-/execute-write/analyze">
     {% if write_template_tables %}
         <div class="execute-write-template-menu">
diff --git a/datasette/templates/query.html b/datasette/templates/query.html
index 168a636b..8dd1037f 100644
--- a/datasette/templates/query.html
+++ b/datasette/templates/query.html
@@ -73,27 +73,9 @@
 
 {% if display_rows %}
 <p class="export-links">This data as {% for name, url in renderers.items() %}<a href="{{ url }}">{{ name }}</a>{{ ", " if not loop.last }}{% endfor %}, <a href="{{ url_csv }}">CSV</a></p>
-<div class="table-wrapper"><table class="rows-and-columns">
-    <thead>
-        <tr>
-            {% for column in columns %}<th class="col-{{ column|to_css_class }}" scope="col">{{ column }}</th>{% endfor %}
-        </tr>
-    </thead>
-    <tbody>
-    {% for row in display_rows %}
-        <tr>
-            {% for column, td in zip(columns, row) %}
-                <td class="col-{{ column|to_css_class }}">{{ td }}</td>
-            {% endfor %}
-        </tr>
-    {% endfor %}
-    </tbody>
-</table></div>
-{% else %}
-    {% if not stored_query_write and not error %}
-        <p class="zero-results">0 results</p>
-    {% endif %}
 {% endif %}
+{% set show_zero_results = not stored_query_write and not error %}
+{% include "_query_results.html" %}
 
 {% include "_codemirror_foot.html" %}
 {% include "_sql_parameter_scripts.html" %}
diff --git a/datasette/utils/sqlite.py b/datasette/utils/sqlite.py
index 5a7c6c38..4743ae4c 100644
--- a/datasette/utils/sqlite.py
+++ b/datasette/utils/sqlite.py
@@ -13,6 +13,7 @@ if hasattr(sqlite3, "enable_callback_tracebacks"):
     sqlite3.enable_callback_tracebacks(True)
 
 _cached_sqlite_version = None
+_cached_supports_returning = None
 SQLiteTableType = Literal["table", "view", "virtual", "shadow"]
 _VIRTUAL_TABLE_MODULE_RE = re.compile(
     r"\bCREATE\s+VIRTUAL\s+TABLE\b.*?\bUSING\s+([^\s(]+)",
@@ -59,6 +60,21 @@ def supports_generated_columns():
     return sqlite_version() >= (3, 31, 0)
 
 
+def supports_returning():
+    global _cached_supports_returning
+    if _cached_supports_returning is None:
+        conn = sqlite3.connect(":memory:")
+        try:
+            conn.execute("create table t (id integer primary key)")
+            conn.execute("insert into t default values returning id").fetchone()
+            _cached_supports_returning = True
+        except sqlite3.DatabaseError:
+            _cached_supports_returning = False
+        finally:
+            conn.close()
+    return _cached_supports_returning
+
+
 def sqlite_table_type(
     conn,
     table: str,
diff --git a/datasette/views/database.py b/datasette/views/database.py
index d6c88962..a1647ca9 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -528,12 +528,14 @@ class QueryView(View):
                     message = "Error running on_success_message_sql: {}".format(ex)
                     message_type = datasette.ERROR
             if not message:
-                message = (
-                    stored_query.on_success_message
-                    or "Query executed, {} row{} affected".format(
+                if stored_query.on_success_message:
+                    message = stored_query.on_success_message
+                elif cursor.rowcount == -1:
+                    message = "Query executed"
+                else:
+                    message = "Query executed, {} row{} affected".format(
                         cursor.rowcount, "" if cursor.rowcount == 1 else "s"
                     )
-                )
 
             redirect_url = stored_query.on_success_redirect
             ok = True
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index cff20847..c5d55b80 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -6,6 +6,7 @@ from datasette.utils import sqlite3
 from datasette.utils.asgi import Response
 
 from .base import BaseView, _error
+from .database import display_rows as display_query_rows
 from .query_helpers import (
     QueryValidationError,
     _analysis_is_write,
@@ -221,10 +222,16 @@ class ExecuteWriteView(BaseView):
         execution_message=None,
         execution_links=None,
         execution_ok=None,
+        execute_write_returns_rows=False,
+        execute_write_columns=None,
+        execute_write_display_rows=None,
+        execute_write_truncated=False,
         status=200,
     ):
         parameter_values = parameter_values or {}
         execution_links = execution_links or []
+        execute_write_columns = execute_write_columns or []
+        execute_write_display_rows = execute_write_display_rows or []
         parameter_names = []
         analysis_rows = []
         table_columns = await _table_columns(self.ds, db.name)
@@ -284,6 +291,10 @@ class ExecuteWriteView(BaseView):
                 "execution_message": execution_message,
                 "execution_links": execution_links,
                 "execution_ok": execution_ok,
+                "execute_write_returns_rows": execute_write_returns_rows,
+                "execute_write_columns": execute_write_columns,
+                "execute_write_display_rows": execute_write_display_rows,
+                "execute_write_truncated": execute_write_truncated,
                 "execute_disabled": bool(execute_disabled_reason),
                 "execute_disabled_reason": execute_disabled_reason,
                 "table_columns": table_columns,
@@ -355,11 +366,13 @@ class ExecuteWriteView(BaseView):
                 status=ex.status,
             )
 
+        wants_json = _wants_json(request, is_json, data)
         try:
-            cursor = await db.execute_write(sql, params, request=request)
+            execute_write_kwargs = {"request": request}
+            cursor = await db.execute_write(sql, params, **execute_write_kwargs)
         except sqlite3.DatabaseError as ex:
             message = str(ex)
-            if _wants_json(request, is_json, data):
+            if wants_json:
                 return _block_framing(_error([message], 400))
             return await self._render_form(
                 request,
@@ -378,17 +391,19 @@ class ExecuteWriteView(BaseView):
             message = "Query executed, {} row{} affected".format(
                 cursor.rowcount, "" if cursor.rowcount == 1 else "s"
             )
-        if _wants_json(request, is_json, data):
-            return _block_framing(
-                Response.json(
-                    {
-                        "ok": True,
-                        "message": message,
-                        "rowcount": cursor.rowcount,
-                        "analysis": _analysis_rows(analysis),
-                    }
-                )
-            )
+        if wants_json:
+            data = {
+                "ok": True,
+                "message": message,
+                "rowcount": cursor.rowcount,
+                "rows": [],
+                "truncated": False,
+                "analysis": _analysis_rows(analysis),
+            }
+            if cursor.description is not None:
+                data["rows"] = [dict(row) for row in cursor.fetchall()]
+                data["truncated"] = cursor.truncated
+            return _block_framing(Response.json(data))
 
         inserted_row_url = await _inserted_row_url(self.ds, db, analysis, cursor)
         execution_links = (
@@ -396,6 +411,20 @@ class ExecuteWriteView(BaseView):
             if inserted_row_url
             else []
         )
+        execute_write_returns_rows = cursor.description is not None
+        execute_write_columns = []
+        execute_write_display_rows = []
+        if execute_write_returns_rows:
+            execute_write_columns = [
+                description[0] for description in cursor.description
+            ]
+            execute_write_display_rows = await display_query_rows(
+                self.ds,
+                db.name,
+                request,
+                cursor.fetchall(),
+                execute_write_columns,
+            )
         return await self._render_form(
             request,
             db,
@@ -405,6 +434,10 @@ class ExecuteWriteView(BaseView):
             execution_message=message,
             execution_links=execution_links,
             execution_ok=True,
+            execute_write_returns_rows=execute_write_returns_rows,
+            execute_write_columns=execute_write_columns,
+            execute_write_display_rows=execute_write_display_rows,
+            execute_write_truncated=cursor.truncated,
         )
 
 
diff --git a/docs/internals.rst b/docs/internals.rst
index 4980ee8b..f269155a 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -1928,8 +1928,8 @@ Example usage:
 
 .. _database_execute_write:
 
-await db.execute_write(sql, params=None, block=True)
-----------------------------------------------------
+await db.execute_write(sql, params=None, block=True, request=None, return_all=False, returning_limit=10)
+--------------------------------------------------------------------------------------------------------
 
 SQLite only allows one database connection to write at a time. Datasette handles this for you by maintaining a queue of writes to be executed against a given database. Plugins can submit write operations to this queue and they will be executed in the order in which they are received.
 
@@ -1937,7 +1937,30 @@ This method can be used to queue up a non-SELECT SQL query to be executed agains
 
 You can pass additional SQL parameters as a tuple or dictionary.
 
-The method will block until the operation is completed, and the return value will be the return from calling ``conn.execute(...)`` using the underlying ``sqlite3`` Python library.
+The optional ``request=`` argument is used internally by Datasette to pass request context to :ref:`write_wrapper plugin hooks <plugin_hook_write_wrapper>`.
+
+The method will block until the operation is completed, and the return value will be an ``ExecuteWriteResult`` object. This imitates a subset of the ``sqlite3.Cursor`` object:
+
+``.rowcount``
+    The number of rows modified by the statement, or ``-1`` if that number is unavailable.
+
+``.lastrowid``
+    The row ID of the last modified row, as returned by ``sqlite3.Cursor.lastrowid``.
+
+``.description``
+    The same column metadata exposed by Python's `sqlite3.Cursor.description <https://docs.python.org/3/library/sqlite3.html#sqlite3.Cursor.description>`__: one tuple per returned column, or ``None`` if the statement does not return rows.
+
+``.truncated``
+    ``True`` if the statement returned more rows than ``returning_limit``.
+
+``.fetchall()``
+    Returns any rows buffered by Datasette from the statement, such as rows from SQLite's ``RETURNING`` clause. This may be limited by ``returning_limit`` unless ``return_all=True`` was used. This method empties the buffer, so calling it again will return an empty list.
+
+SQLite statements using ``RETURNING`` must have their rows consumed before the transaction can commit. Datasette will fetch up to ``returning_limit + 1`` rows before committing, store up to ``returning_limit`` rows on the result object and set ``.truncated`` if there were more. The default ``returning_limit`` is ``10``.
+
+When ``.truncated`` is ``True``, ``.rowcount`` will be ``-1``. SQLite only reports the final row count for a ``RETURNING`` statement after every returned row has been fetched, and Datasette has deliberately stopped fetching rows after ``returning_limit`` to avoid buffering a potentially large result in memory.
+
+If you need to retrieve every row returned by a statement, pass ``return_all=True``. This will buffer all returned rows in memory before committing.
 
 If you pass ``block=False`` this behavior changes to "fire and forget" - queries will be added to the write queue and executed in a separate thread while your code can continue to do other things. The method will return a UUID representing the queued task.
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 4bd76717..65031bf4 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -554,7 +554,8 @@ Datasette analyzes the SQL before executing it. The actor must have ``execute-wr
 
 Unsupported SQL operations are rejected by default. ``VACUUM`` is not allowed in arbitrary write SQL, and writes to SQLite virtual tables or shadow tables are rejected. SQL functions are allowed and are not separately restricted by Datasette permissions.
 
-A successful response includes a message, the SQLite ``rowcount`` and a summary of the operations that were executed:
+A successful response includes a message, the SQLite ``rowcount``, a ``"rows"``
+list, a ``"truncated"`` flag and a summary of the operations that were executed:
 
 The shape of the ``"analysis"`` block is not yet considered a stable API and may change in future Datasette releases.
 
@@ -564,6 +565,8 @@ The shape of the ``"analysis"`` block is not yet considered a stable API and may
         "ok": true,
         "message": "Query executed, 1 row affected",
         "rowcount": 1,
+        "rows": [],
+        "truncated": false,
         "analysis": [
             {
                 "operation": "insert",
@@ -577,6 +580,43 @@ The shape of the ``"analysis"`` block is not yet considered a stable API and may
 
 If SQLite reports ``-1`` for the row count, the message will be ``"Query executed"``.
 
+For most write statements ``"rows"`` will be an empty list and ``"truncated"``
+will be ``false``. If the SQL uses SQLite's ``RETURNING`` clause, ``"rows"``
+will contain returned rows using the same default representation as table and
+query JSON responses. ``"truncated"`` indicates if more rows were returned than
+the execute-write returning row limit, which defaults to 10:
+
+.. code-block:: json
+
+    {
+        "ok": true,
+        "message": "Query executed, 1 row affected",
+        "rowcount": 1,
+        "rows": [
+            {
+                "id": 1,
+                "name": "Cleo"
+            }
+        ],
+        "truncated": false,
+        "analysis": [
+            {
+                "operation": "insert",
+                "database": "data",
+                "table": "dogs",
+                "required_permission": "insert-row, update-row, delete-row",
+                "source": null
+            },
+            {
+                "operation": "read",
+                "database": "data",
+                "table": "dogs",
+                "required_permission": "view-table",
+                "source": null
+            }
+        ]
+    }
+
 Errors use the standard Datasette error format:
 
 .. code-block:: json
diff --git a/tests/test_internals_database.py b/tests/test_internals_database.py
index 88f9d571..bb209649 100644
--- a/tests/test_internals_database.py
+++ b/tests/test_internals_database.py
@@ -5,15 +5,19 @@ Tests for the datasette.database.Database class
 import asyncio
 from types import SimpleNamespace
 from datasette.app import Datasette
-from datasette.database import Database, Results, MultipleValues
+from datasette.database import Database, ExecuteWriteResult, Results, MultipleValues
 from datasette.database import DatasetteClosedError
 from datasette.database import _deliver_write_result
-from datasette.utils.sqlite import sqlite3
+from datasette.utils.sqlite import sqlite3, supports_returning
 from datasette.utils import Column
 import pytest
 import time
 import uuid
 
+requires_sqlite_returning = pytest.mark.skipif(
+    not supports_returning(), reason="SQLite does not support RETURNING"
+)
+
 
 @pytest.fixture
 def db(app_client):
@@ -469,13 +473,142 @@ async def test_view_names(db):
 
 @pytest.mark.asyncio
 async def test_execute_write_block_true(db):
-    await db.execute_write(
+    result = await db.execute_write(
         "update roadside_attractions set name = ? where pk = ?", ["Mystery!", 1]
     )
     rows = await db.execute("select name from roadside_attractions where pk = 1")
+    assert result.rowcount == 1
+    assert result.description is None
+    assert result.truncated is False
+    assert result.fetchall() == []
     assert "Mystery!" == rows.rows[0][0]
 
 
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_with_returning(db):
+    await db.execute_write(
+        "create table write_returning (id integer primary key, name text)"
+    )
+    result = await db.execute_write(
+        "insert into write_returning (name) values (?) returning id, name",
+        ["Cleo"],
+    )
+
+    assert result.rowcount == 1
+    assert result.lastrowid == 1
+    assert [column[0] for column in result.description] == ["id", "name"]
+    assert result.truncated is False
+    assert [dict(row) for row in result.fetchall()] == [{"id": 1, "name": "Cleo"}]
+    assert result.fetchall() == []
+    assert (await db.execute("select id, name from write_returning")).dicts() == [
+        {"id": 1, "name": "Cleo"}
+    ]
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_with_returning_default_limit(db):
+    await db.execute_write(
+        "create table write_returning_limit (id integer primary key)"
+    )
+    await db.execute_write_many(
+        "insert into write_returning_limit (id) values (?)",
+        [(i,) for i in range(1, 21)],
+    )
+
+    result = await db.execute_write(
+        "update write_returning_limit set id = id returning id"
+    )
+
+    assert result.rowcount == -1
+    assert result.truncated is True
+    assert len(result.fetchall()) == 10
+    assert (
+        await db.execute("select count(*) from write_returning_limit")
+    ).single_value() == 20
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_with_returning_custom_limit(db):
+    await db.execute_write(
+        "create table write_returning_custom (id integer primary key)"
+    )
+    await db.execute_write_many(
+        "insert into write_returning_custom (id) values (?)",
+        [(i,) for i in range(1, 6)],
+    )
+
+    result = await db.execute_write(
+        "update write_returning_custom set id = id returning id",
+        returning_limit=2,
+    )
+
+    assert result.rowcount == -1
+    assert result.truncated is True
+    assert [row["id"] for row in result.fetchall()] == [1, 2]
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_with_returning_exact_default_limit(db):
+    await db.execute_write(
+        "create table write_returning_exact_limit (id integer primary key)"
+    )
+    await db.execute_write_many(
+        "insert into write_returning_exact_limit (id) values (?)",
+        [(i,) for i in range(1, 11)],
+    )
+
+    result = await db.execute_write(
+        "update write_returning_exact_limit set id = id returning id"
+    )
+
+    assert result.rowcount == 10
+    assert result.truncated is False
+    assert len(result.fetchall()) == 10
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_with_returning_one_more_than_default_limit(db):
+    await db.execute_write(
+        "create table write_returning_one_more (id integer primary key)"
+    )
+    await db.execute_write_many(
+        "insert into write_returning_one_more (id) values (?)",
+        [(i,) for i in range(1, 12)],
+    )
+
+    result = await db.execute_write(
+        "update write_returning_one_more set id = id returning id"
+    )
+
+    assert result.rowcount == -1
+    assert result.truncated is True
+    assert len(result.fetchall()) == 10
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_with_returning_return_all(db):
+    await db.execute_write("create table write_returning_all (id integer primary key)")
+    await db.execute_write_many(
+        "insert into write_returning_all (id) values (?)",
+        [(i,) for i in range(1, 21)],
+    )
+
+    result = await db.execute_write(
+        "update write_returning_all set id = id returning id",
+        return_all=True,
+    )
+
+    assert result.rowcount == 20
+    assert result.truncated is False
+    assert [row["id"] for row in result.fetchall()] == list(range(1, 21))
+
+
 @pytest.mark.asyncio
 async def test_execute_write_block_false(db):
     await db.execute_write(
@@ -487,6 +620,48 @@ async def test_execute_write_block_false(db):
     assert "Mystery!" == rows.rows[0][0]
 
 
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_with_returning_block_false(db):
+    await db.execute_write(
+        "create table write_returning_block_false (id integer primary key, name text)"
+    )
+    task_id = await db.execute_write(
+        "insert into write_returning_block_false (name) values (?) returning id",
+        ["Cleo"],
+        block=False,
+    )
+
+    assert isinstance(task_id, uuid.UUID)
+    time.sleep(0.1)
+    assert (
+        await db.execute("select name from write_returning_block_false")
+    ).single_value() == "Cleo"
+
+
+def test_execute_write_result_closes_cursor_on_fetch_error():
+    class Cursor:
+        description = (("id", None, None, None, None, None, None),)
+        lastrowid = 1
+        rowcount = 0
+
+        def __init__(self):
+            self.closed = False
+
+        def fetchmany(self, size):
+            raise sqlite3.DatabaseError("fetch failed")
+
+        def close(self):
+            self.closed = True
+
+    cursor = Cursor()
+
+    with pytest.raises(sqlite3.DatabaseError):
+        ExecuteWriteResult.from_cursor(cursor)
+
+    assert cursor.closed is True
+
+
 @pytest.mark.asyncio
 async def test_execute_write_script(db):
     await db.execute_write_script(
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 89167a1d..cef06d7f 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -8,6 +8,11 @@ from datasette.app import Datasette
 from datasette.resources import DatabaseResource, QueryResource
 from datasette.stored_queries import StoredQuery, StoredQueryPage
 from datasette.utils.asgi import Forbidden
+from datasette.utils.sqlite import supports_returning
+
+requires_sqlite_returning = pytest.mark.skipif(
+    not supports_returning(), reason="SQLite does not support RETURNING"
+)
 
 
 def _template_option_attributes(html, table):
@@ -1884,10 +1889,144 @@ async def test_execute_write_post_requires_database_and_table_permissions():
     assert allowed.status_code == 200
     assert allowed.json()["ok"] is True
     assert allowed.json()["rowcount"] == 1
+    assert allowed.json()["rows"] == []
+    assert allowed.json()["truncated"] is False
     assert allowed.json()["analysis"][0]["operation"] == "insert"
     assert (await db.execute("select name from dogs")).first()[0] == "Cleo"
 
 
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_json_includes_returning_rows():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_returning_json", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        json={
+            "sql": "insert into dogs (name) values (:name) returning id, name",
+            "params": {"name": "Cleo"},
+        },
+    )
+
+    assert response.status_code == 200
+    data = response.json()
+    assert data["ok"] is True
+    assert data["message"] == "Query executed, 1 row affected"
+    assert data["rowcount"] == 1
+    assert data["rows"] == [{"id": 1, "name": "Cleo"}]
+    assert data["truncated"] is False
+    assert [row["operation"] for row in data["analysis"]] == ["insert", "read"]
+    assert (await db.execute("select id, name from dogs")).dicts() == [
+        {"id": 1, "name": "Cleo"}
+    ]
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_json_returning_rows_can_be_truncated():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_returning_json_truncated", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    for index in range(1, 12):
+        await db.execute_write(
+            "insert into dogs (name) values (?)", ["Dog {}".format(index)]
+        )
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        json={"sql": "update dogs set name = name || '!' returning id, name"},
+    )
+
+    assert response.status_code == 200
+    data = response.json()
+    assert data["ok"] is True
+    assert data["message"] == "Query executed"
+    assert data["rowcount"] == -1
+    assert data["rows"] == [
+        {"id": index, "name": "Dog {}!".format(index)} for index in range(1, 11)
+    ]
+    assert data["truncated"] is True
+    assert (await db.execute("select count(*) from dogs where name like '%!'")).first()[
+        0
+    ] == 11
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_html_displays_returning_rows():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_returning_html", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        data={
+            "sql": "insert into dogs (name) values (:name) returning id, name",
+            "name": "Cleo",
+        },
+    )
+    non_returning_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        data={"sql": "insert into dogs (name) values ('Pancakes')"},
+    )
+
+    assert response.status_code == 200
+    assert "Query executed, 1 row affected" in response.text
+    assert "<h2>Returned rows</h2>" in response.text
+    assert '<table class="rows-and-columns">' in response.text
+    assert '<th class="col-id" scope="col">id</th>' in response.text
+    assert '<th class="col-name" scope="col">name</th>' in response.text
+    assert '<td class="col-id">1</td>' in response.text
+    assert '<td class="col-name">Cleo</td>' in response.text
+
+    assert non_returning_response.status_code == 200
+    assert "Query executed, 1 row affected" in non_returning_response.text
+    assert "<h2>Returned rows</h2>" not in non_returning_response.text
+    assert '<p class="zero-results">0 results</p>' not in non_returning_response.text
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_execute_write_html_returning_rows_can_be_truncated():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_returning_html_truncated", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    for index in range(1, 12):
+        await db.execute_write(
+            "insert into dogs (name) values (?)", ["Dog {}".format(index)]
+        )
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        data={"sql": "update dogs set name = name || '!' returning id, name"},
+    )
+
+    assert response.status_code == 200
+    assert "<h2>Returned rows</h2>" in response.text
+    assert "Only the first 10 returned rows are shown." in response.text
+    assert '<td class="col-id">1</td>' in response.text
+    assert '<td class="col-name">Dog 1!</td>' in response.text
+    assert '<td class="col-id">10</td>' in response.text
+    assert '<td class="col-name">Dog 10!</td>' in response.text
+    assert '<td class="col-id">11</td>' not in response.text
+    assert '<td class="col-name">Dog 11!</td>' not in response.text
+
+
 @pytest.mark.parametrize(
     "database_name, sql",
     (
@@ -3002,3 +3141,65 @@ async def test_user_writable_query_execution_rechecks_table_permissions():
     assert denied_response.status_code == 403
     rows = (await db.execute("select name from dogs")).dicts()
     assert rows == [{"name": "Cleo"}]
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_stored_write_query_with_returning():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_write_returning", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "insert_dog",
+        "insert into dogs (name) values (:name) returning id, name",
+        is_write=True,
+        source="user",
+        owner_id="root",
+    )
+
+    response = await ds.client.post(
+        "/data/insert_dog?_json=1",
+        actor={"id": "root"},
+        data={"name": "Cleo"},
+    )
+
+    assert response.status_code == 200
+    assert response.json()["ok"] is True
+    assert (await db.execute("select id, name from dogs")).dicts() == [
+        {"id": 1, "name": "Cleo"}
+    ]
+
+
+@pytest.mark.asyncio
+@requires_sqlite_returning
+async def test_stored_write_query_with_truncated_returning_message():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_write_truncated_returning", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await db.execute_write_many(
+        "insert into dogs (name) values (?)",
+        [("Cleo",) for _ in range(20)],
+    )
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "update_dogs",
+        "update dogs set name = name returning id",
+        is_write=True,
+        source="user",
+        owner_id="root",
+    )
+
+    response = await ds.client.post(
+        "/data/update_dogs?_json=1",
+        actor={"id": "root"},
+        data={},
+    )
+
+    assert response.status_code == 200
+    assert response.json()["ok"] is True
+    assert response.json()["message"] == "Query executed"
diff --git a/tests/test_utils.py b/tests/test_utils.py
index f6de3b46..64607244 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -5,7 +5,12 @@ Tests for various datasette helper functions.
 from datasette.app import Datasette
 from datasette import utils
 from datasette.utils.asgi import Request
-from datasette.utils.sqlite import sqlite3, sqlite_hidden_table_names, sqlite_table_type
+from datasette.utils.sqlite import (
+    sqlite3,
+    sqlite_hidden_table_names,
+    sqlite_table_type,
+    supports_returning,
+)
 import json
 import os
 import pathlib
@@ -226,6 +231,20 @@ def test_detect_fts_different_table_names(table):
     conn.close()
 
 
+def test_supports_returning():
+    conn = utils.sqlite3.connect(":memory:")
+    try:
+        conn.execute("create table t (id integer primary key)")
+        conn.execute("insert into t default values returning id").fetchone()
+        expected = True
+    except sqlite3.DatabaseError:
+        expected = False
+    finally:
+        conn.close()
+
+    assert supports_returning() is expected
+
+
 @pytest.mark.parametrize("use_fallback", (False, True))
 def test_sqlite_table_type_detects_virtual_and_shadow_tables(monkeypatch, use_fallback):
     if use_fallback:

From f9f346558265892d7cbc7c009eb590dece02c67b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 31 May 2026 13:49:22 -0700
Subject: [PATCH 140/386] Better empty state message

Root user was being told they didn't have permission when actually
the problem was there were no tables at all.
---
 datasette/templates/execute_write.html | 2 +-
 tests/test_queries.py                  | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index a93de3a6..949850ed 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -111,7 +111,7 @@ form.sql.core input[data-execute-write-submit]:disabled {
             </details>
         </div>
     {% else %}
-        <p class="message-warning execute-write-template-unavailable">You don't currently have permission to insert, edit or delete from any tables.</p>
+        <p class="message-warning execute-write-template-unavailable">There are no tables that you can currently edit.</p>
     {% endif %}
 
     <p class="sql-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
diff --git a/tests/test_queries.py b/tests/test_queries.py
index cef06d7f..25e423d4 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1580,10 +1580,7 @@ async def test_execute_write_templates_are_filtered_by_permission_and_server_gen
 
     assert viewer_response.status_code == 200
     assert "<summary>Start with a template</summary>" not in viewer_response.text
-    assert (
-        "You don't currently have permission to insert, edit or delete from any tables."
-        in viewer_response.text
-    )
+    assert "There are no tables that you can currently edit." in viewer_response.text
     assert "data-template-insert-sql" not in viewer_response.text
     assert "data-template-update-sql" not in viewer_response.text
     assert "data-template-delete-sql" not in viewer_response.text

From 911954347e4ad55ba4f5cf6b576095299e3b76a5 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 31 May 2026 16:21:24 -0700
Subject: [PATCH 141/386] Release 1.0a32

Refs #2757, #2759, #2762, #2763
---
 datasette/version.py |  2 +-
 docs/changelog.rst   | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/datasette/version.py b/datasette/version.py
index 76cabb1d..1e8c61d5 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a31"
+__version__ = "1.0a32"
 __version_info__ = tuple(__version__.split("."))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 4f9ffdbb..d5f8fa14 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,6 +4,19 @@
 Changelog
 =========
 
+.. _v1_0_a32:
+
+1.0a32 (2026-05-31)
+-------------------
+
+SQLite INSERT ... RETURNING clauses are now supported by ``/db/-/execute-write``, plus several fixes relating to the :ref:`base_url setting <setting_base_url>`.
+
+- ``INSERT``/``UPDATE``/``DELETE`` statements that use SQLite's ``RETURNING`` clause now work correctly in the new ``/db/-/execute-write`` interface. Datasette fetches returned rows before committing the write transaction, displays them in the HTML UI and includes them in the ``"rows"`` key for the JSON API response. (:issue:`2762`, :pr:`2763`)
+- ``Database.execute_write()`` now returns an ``ExecuteWriteResult`` object instead of the raw ``sqlite3.Cursor`` returned by ``conn.execute()``. The new object exposes ``.rowcount``, ``.lastrowid``, ``.description``, ``.truncated`` and ``.fetchall()``, and adds ``return_all=`` and ``returning_limit=`` options for controlling how rows from ``RETURNING`` statements are buffered. (:pr:`2763`)
+- Fixed the ``/-/jump`` navigation search endpoint when Datasette is served with a configured ``base_url``. (:issue:`2757`)
+- Fixed JSON and CSV export links, plus ``Link:`` alternate headers, on table, row and query pages when ``base_url`` is configured. These could previously be prefixed twice. (:issue:`2759`)
+- Fixed several other ``base_url`` handling bugs, including the API explorer form actions and share links, the ``/-/patterns`` development page, permanent redirects such as ``/-`` to ``/-/`` and database query redirects from ``/<database>?sql=...`` to ``/<database>/-/query?sql=...``.
+
 .. _v1_0_a31:
 
 1.0a31 (2026-05-28)

From 6eaa9e31993d1b35a7252246aab31837a365ae56 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 8 Jun 2026 20:19:47 -0700
Subject: [PATCH 142/386] Web UI to edit and delete stored queries (#2764)

* Add web UI to edit and delete stored queries

Stored query pages now offer Edit and Delete actions in the query
actions menu, gated by the update-query and delete-query permissions.

- New QueryEditView (GET/POST at /<db>/<query>/-/edit) renders a
  pre-filled form for editing a query's title, description, SQL and
  privacy, reusing the create-query analysis UI. Changing the SQL still
  requires execute-sql; metadata-only edits do not.
- QueryDeleteView gains a GET confirmation page and HTML form POST that
  redirects to the query list, while keeping the existing JSON API.
- New default query_actions hook adds the Edit/Delete links for stored
  (non-config, non-trusted) queries the actor is allowed to manage.

Permission semantics (already enforced by default_query_permissions_sql)
are surfaced in the UI: owners can always edit/delete their queries;
non-private queries can be edited/deleted by any actor with the relevant
permission; private queries remain owner-only.

Shared the create-query form styles into _query_form_styles.html so the
edit form can reuse them.

Animated demo: https://github.com/simonw/datasette/pull/2764#issuecomment-4655694668

Closes #2760

https://claude.ai/code/session_019GU9g3pZAERukLKYNa4uAL
---
 datasette/app.py                            |   5 +
 datasette/default_query_actions.py          |  48 ++++
 datasette/plugins.py                        |   1 +
 datasette/templates/_query_form_styles.html | 138 ++++++++++++
 datasette/templates/query_create.html       | 134 +----------
 datasette/templates/query_delete.html       |  82 +++++++
 datasette/templates/query_edit.html         | 133 +++++++++++
 datasette/templates/query_list.html         |  50 ++---
 datasette/views/query_helpers.py            |  29 +++
 datasette/views/stored_queries.py           | 169 +++++++++++++-
 docs/changelog.rst                          |   7 +
 docs/plugins.rst                            |   9 +
 docs/sql_queries.rst                        |   9 +
 tests/test_docs.py                          |   1 +
 tests/test_queries.py                       | 233 ++++++++++++++++++++
 15 files changed, 886 insertions(+), 162 deletions(-)
 create mode 100644 datasette/default_query_actions.py
 create mode 100644 datasette/templates/_query_form_styles.html
 create mode 100644 datasette/templates/query_delete.html
 create mode 100644 datasette/templates/query_edit.html

diff --git a/datasette/app.py b/datasette/app.py
index 8b8b601f..81d23acb 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -55,6 +55,7 @@ from .views.stored_queries import (
     QueryCreateAnalyzeView,
     QueryDeleteView,
     QueryDefinitionView,
+    QueryEditView,
     GlobalQueryListView,
     QueryListView,
     QueryParametersView,
@@ -2493,6 +2494,10 @@ class Datasette:
             QueryDefinitionView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<query>[^\/\.]+)/-/definition$",
         )
+        add_route(
+            QueryEditView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/(?P<query>[^\/\.]+)/-/edit$",
+        )
         add_route(
             QueryUpdateView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<query>[^\/\.]+)/-/update$",
diff --git a/datasette/default_query_actions.py b/datasette/default_query_actions.py
new file mode 100644
index 00000000..2183e70b
--- /dev/null
+++ b/datasette/default_query_actions.py
@@ -0,0 +1,48 @@
+from datasette import hookimpl
+from datasette.resources import QueryResource
+
+
+@hookimpl
+def query_actions(datasette, actor, database, query_name, request):
+    # Only stored queries (with a name) can be edited or deleted
+    if not query_name:
+        return None
+
+    async def inner():
+        query = await datasette.get_query(database, query_name)
+        if query is None:
+            return []
+        # Config-defined and trusted queries are managed outside the UI
+        if query.source == "config" or query.is_trusted:
+            return []
+
+        links = []
+        if await datasette.allowed(
+            action="update-query",
+            resource=QueryResource(database, query_name),
+            actor=actor,
+        ):
+            links.append(
+                {
+                    "href": datasette.urls.table(database, query_name) + "/-/edit",
+                    "label": "Edit this query",
+                    "description": (
+                        "Change the title, description, SQL or visibility."
+                    ),
+                }
+            )
+        if await datasette.allowed(
+            action="delete-query",
+            resource=QueryResource(database, query_name),
+            actor=actor,
+        ):
+            links.append(
+                {
+                    "href": datasette.urls.table(database, query_name) + "/-/delete",
+                    "label": "Delete this query",
+                    "description": "Permanently remove this saved query.",
+                }
+            )
+        return links
+
+    return inner
diff --git a/datasette/plugins.py b/datasette/plugins.py
index 5a31cdad..f0fbc7f8 100644
--- a/datasette/plugins.py
+++ b/datasette/plugins.py
@@ -31,6 +31,7 @@ DEFAULT_PLUGINS = (
     "datasette.default_debug_menu",
     "datasette.default_jump_items",
     "datasette.default_database_actions",
+    "datasette.default_query_actions",
     "datasette.handle_exception",
     "datasette.forbidden",
     "datasette.events",
diff --git a/datasette/templates/_query_form_styles.html b/datasette/templates/_query_form_styles.html
new file mode 100644
index 00000000..cf2dd42c
--- /dev/null
+++ b/datasette/templates/_query_form_styles.html
@@ -0,0 +1,138 @@
+<style>
+.query-create-page {
+    max-width: 64rem;
+}
+.query-create-form {
+    --query-create-label-width: clamp(7rem, 18vw, 10rem);
+    --query-create-column-gap: 0.8rem;
+    --query-create-control-width: minmax(16rem, 1fr);
+}
+.query-create-fields {
+    margin: 0 0 0.85rem;
+    max-width: 52rem;
+}
+.query-create-field {
+    align-items: start;
+    column-gap: var(--query-create-column-gap);
+    display: grid;
+    grid-template-columns: var(--query-create-label-width) var(--query-create-control-width);
+    margin: 0 0 0.65rem;
+}
+.query-create-field label {
+    padding-top: 0.55rem;
+    width: auto;
+}
+.query-create-field input[type=text],
+.query-create-field textarea {
+    box-sizing: border-box;
+    width: 100%;
+}
+form.sql .query-create-field textarea {
+    width: 100%;
+}
+.query-create-url-control {
+    align-items: center;
+    box-sizing: border-box;
+    display: grid;
+    gap: 0.35rem;
+    grid-template-columns: max-content minmax(12rem, 1fr);
+    width: 100%;
+}
+.query-create-url-prefix {
+    color: #4f5b6d;
+    font-family: var(--font-monospace, monospace);
+    white-space: nowrap;
+}
+.query-create-url-control input[type=text] {
+    border: 1px solid #ccc;
+    border-radius: 3px;
+}
+.query-create-url-static {
+    color: #39445a;
+    font-family: var(--font-monospace, monospace);
+    word-break: break-all;
+}
+.query-create-field textarea {
+    border: 1px solid #ccc;
+    border-radius: 3px;
+    display: block;
+    font-family: Helvetica, sans-serif;
+    font-size: 1em;
+    min-height: 5rem;
+    padding: 9px 4px;
+    resize: vertical;
+}
+form.sql .query-create-sql {
+    column-gap: var(--query-create-column-gap);
+    display: grid;
+    grid-template-columns: var(--query-create-label-width) var(--query-create-control-width);
+    margin: 0.9rem 0 0.75rem;
+    max-width: 52rem;
+}
+.query-create-sql .cm-editor,
+form.sql .query-create-sql textarea#sql-editor {
+    grid-column: 2;
+    width: 100%;
+}
+.query-create-options {
+    align-items: center;
+    display: flex;
+    flex-wrap: wrap;
+    gap: 0.8rem 1.4rem;
+    margin: 0 0 0.9rem calc(var(--query-create-label-width) + var(--query-create-column-gap));
+    max-width: calc(52rem - var(--query-create-label-width) - var(--query-create-column-gap));
+}
+.query-create-options label {
+    align-items: center;
+    display: inline-flex;
+    gap: 0.35rem;
+    width: auto;
+}
+.query-create-options input[type=checkbox] {
+    margin: 0;
+}
+.query-create-option-note,
+.query-create-analysis-note {
+    color: #4f5b6d;
+    flex-basis: 100%;
+    font-size: 0.82rem;
+}
+.query-create-option-note {
+    margin: -0.45rem 0 0;
+}
+.query-create-analysis-note {
+    margin: 0;
+}
+.query-create-analysis {
+    margin-top: 0.8rem;
+}
+.query-create-submit {
+    margin-left: calc(var(--query-create-label-width) + var(--query-create-column-gap));
+    margin-bottom: 0.9rem;
+    margin-top: 1rem;
+}
+@media (max-width: 560px) {
+    .query-create-form {
+        --query-create-label-width: 1fr;
+        --query-create-column-gap: 0;
+    }
+    .query-create-field {
+        grid-template-columns: 1fr;
+        row-gap: 0.25rem;
+    }
+    .query-create-field label {
+        padding-top: 0;
+    }
+    form.sql .query-create-sql {
+        grid-template-columns: 1fr;
+    }
+    .query-create-sql .cm-editor,
+    form.sql .query-create-sql textarea#sql-editor {
+        grid-column: 1;
+    }
+    .query-create-options,
+    .query-create-submit {
+        margin-left: 0;
+    }
+}
+</style>
diff --git a/datasette/templates/query_create.html b/datasette/templates/query_create.html
index ec910456..f2016f27 100644
--- a/datasette/templates/query_create.html
+++ b/datasette/templates/query_create.html
@@ -6,139 +6,7 @@
 {{- super() -}}
 {% include "_codemirror.html" %}
 {% include "_execute_write_analysis_styles.html" %}
-<style>
-.query-create-page {
-    max-width: 64rem;
-}
-.query-create-form {
-    --query-create-label-width: clamp(7rem, 18vw, 10rem);
-    --query-create-column-gap: 0.8rem;
-    --query-create-control-width: minmax(16rem, 1fr);
-}
-.query-create-fields {
-    margin: 0 0 0.85rem;
-    max-width: 52rem;
-}
-.query-create-field {
-    align-items: start;
-    column-gap: var(--query-create-column-gap);
-    display: grid;
-    grid-template-columns: var(--query-create-label-width) var(--query-create-control-width);
-    margin: 0 0 0.65rem;
-}
-.query-create-field label {
-    padding-top: 0.55rem;
-    width: auto;
-}
-.query-create-field input[type=text],
-.query-create-field textarea {
-    box-sizing: border-box;
-    width: 100%;
-}
-form.sql .query-create-field textarea {
-    width: 100%;
-}
-.query-create-url-control {
-    align-items: center;
-    box-sizing: border-box;
-    display: grid;
-    gap: 0.35rem;
-    grid-template-columns: max-content minmax(12rem, 1fr);
-    width: 100%;
-}
-.query-create-url-prefix {
-    color: #4f5b6d;
-    font-family: var(--font-monospace, monospace);
-    white-space: nowrap;
-}
-.query-create-url-control input[type=text] {
-    border: 1px solid #ccc;
-    border-radius: 3px;
-}
-.query-create-field textarea {
-    border: 1px solid #ccc;
-    border-radius: 3px;
-    display: block;
-    font-family: Helvetica, sans-serif;
-    font-size: 1em;
-    min-height: 5rem;
-    padding: 9px 4px;
-    resize: vertical;
-}
-form.sql .query-create-sql {
-    column-gap: var(--query-create-column-gap);
-    display: grid;
-    grid-template-columns: var(--query-create-label-width) var(--query-create-control-width);
-    margin: 0.9rem 0 0.75rem;
-    max-width: 52rem;
-}
-.query-create-sql .cm-editor,
-form.sql .query-create-sql textarea#sql-editor {
-    grid-column: 2;
-    width: 100%;
-}
-.query-create-options {
-    align-items: center;
-    display: flex;
-    flex-wrap: wrap;
-    gap: 0.8rem 1.4rem;
-    margin: 0 0 0.9rem calc(var(--query-create-label-width) + var(--query-create-column-gap));
-    max-width: calc(52rem - var(--query-create-label-width) - var(--query-create-column-gap));
-}
-.query-create-options label {
-    align-items: center;
-    display: inline-flex;
-    gap: 0.35rem;
-    width: auto;
-}
-.query-create-options input[type=checkbox] {
-    margin: 0;
-}
-.query-create-option-note,
-.query-create-analysis-note {
-    color: #4f5b6d;
-    flex-basis: 100%;
-    font-size: 0.82rem;
-}
-.query-create-option-note {
-    margin: -0.45rem 0 0;
-}
-.query-create-analysis-note {
-    margin: 0;
-}
-.query-create-analysis {
-    margin-top: 0.8rem;
-}
-.query-create-submit {
-    margin-left: calc(var(--query-create-label-width) + var(--query-create-column-gap));
-    margin-bottom: 0.9rem;
-    margin-top: 1rem;
-}
-@media (max-width: 560px) {
-    .query-create-form {
-        --query-create-label-width: 1fr;
-        --query-create-column-gap: 0;
-    }
-    .query-create-field {
-        grid-template-columns: 1fr;
-        row-gap: 0.25rem;
-    }
-    .query-create-field label {
-        padding-top: 0;
-    }
-    form.sql .query-create-sql {
-        grid-template-columns: 1fr;
-    }
-    .query-create-sql .cm-editor,
-    form.sql .query-create-sql textarea#sql-editor {
-        grid-column: 1;
-    }
-    .query-create-options,
-    .query-create-submit {
-        margin-left: 0;
-    }
-}
-</style>
+{% include "_query_form_styles.html" %}
 {% endblock %}
 
 {% block body_class %}query-create db-{{ database|to_css_class }}{% endblock %}
diff --git a/datasette/templates/query_delete.html b/datasette/templates/query_delete.html
new file mode 100644
index 00000000..4d0699a7
--- /dev/null
+++ b/datasette/templates/query_delete.html
@@ -0,0 +1,82 @@
+{% extends "base.html" %}
+
+{% block title %}Delete query: {{ query.name }}{% endblock %}
+
+{% block extra_head %}
+{{- super() -}}
+<style>
+.query-delete-page {
+    max-width: 48rem;
+}
+.query-delete-summary {
+    background-color: #f7f7f9;
+    border: 1px solid #d7dde5;
+    border-radius: 4px;
+    margin: 0.75rem 0 1.25rem;
+    padding: 0.75rem 1rem;
+}
+.query-delete-summary dt {
+    color: #4f5b6d;
+    font-size: 0.82rem;
+    font-weight: 700;
+}
+.query-delete-summary dd {
+    margin: 0 0 0.6rem;
+}
+.query-delete-summary dd pre {
+    margin: 0.2rem 0 0;
+    white-space: pre-wrap;
+}
+.query-delete-actions {
+    align-items: center;
+    display: flex;
+    gap: 1rem;
+}
+.query-delete-form input[type=submit] {
+    background: linear-gradient(180deg, #d73a31 0%, #b42318 100%);
+    border-color: #b42318;
+    font-weight: 700;
+}
+.query-delete-form input[type=submit]:hover,
+.query-delete-form input[type=submit]:focus {
+    background: linear-gradient(180deg, #c3342b 0%, #971c14 100%);
+    border-color: #971c14;
+}
+</style>
+{% endblock %}
+
+{% block body_class %}query-delete db-{{ database|to_css_class }}{% endblock %}
+
+{% block crumbs %}
+{{ crumbs.nav(request=request, database=database) }}
+{% endblock %}
+
+{% block content %}
+
+<div class="query-delete-page">
+
+<h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Delete query: {{ query.title or query.name }}</h1>
+
+<p>Are you sure you want to delete this saved query? This cannot be undone.</p>
+
+<dl class="query-delete-summary">
+    <dt>URL</dt>
+    <dd><a href="{{ query_url }}">{{ query_url }}</a></dd>
+    {% if query.description %}
+        <dt>Description</dt>
+        <dd>{{ query.description }}</dd>
+    {% endif %}
+    <dt>SQL</dt>
+    <dd><pre>{{ query.sql }}</pre></dd>
+</dl>
+
+<form class="core query-delete-form" action="{{ query_url }}/-/delete" method="post">
+    <p class="query-delete-actions">
+        <input type="submit" value="Delete query">
+        <a href="{{ query_url }}">Cancel</a>
+    </p>
+</form>
+
+</div>
+
+{% endblock %}
diff --git a/datasette/templates/query_edit.html b/datasette/templates/query_edit.html
new file mode 100644
index 00000000..3eadf42a
--- /dev/null
+++ b/datasette/templates/query_edit.html
@@ -0,0 +1,133 @@
+{% extends "base.html" %}
+
+{% block title %}Edit query: {{ name }}{% endblock %}
+
+{% block extra_head %}
+{{- super() -}}
+{% include "_codemirror.html" %}
+{% include "_execute_write_analysis_styles.html" %}
+{% include "_query_form_styles.html" %}
+{% endblock %}
+
+{% block body_class %}query-edit db-{{ database|to_css_class }}{% endblock %}
+
+{% block crumbs %}
+{{ crumbs.nav(request=request, database=database) }}
+{% endblock %}
+
+{% block content %}
+
+<div class="query-create-page">
+
+<h1 style="padding-left: 10px; border-left: 10px solid #{{ database_color }}">Edit query: {{ title or name }}</h1>
+
+<form class="sql core query-create-form" action="{{ query_url }}/-/edit" method="post" data-analyze-url="{{ urls.database(database) }}/-/queries/analyze">
+    <div class="query-create-fields">
+        <p class="query-create-field"><label for="query-title">Title</label> <input id="query-title" name="title" type="text" value="{{ title or "" }}"></p>
+        <p class="query-create-field"><label>URL</label> <span class="query-create-url-static">{{ query_url }}</span></p>
+        <p class="query-create-field"><label for="query-description">Description</label> <textarea id="query-description" name="description" rows="3">{{ description or "" }}</textarea></p>
+    </div>
+
+    <p class="query-create-sql sql-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
+
+    <p class="query-create-options">
+        <span class="query-create-analysis-note" data-query-create-analysis-note aria-live="polite">{% if analysis_error %}This query cannot be saved until the SQL is valid.{% elif not has_sql %}Enter SQL to analyze this query.{% elif analysis_is_write %}This query updates data in the database.{% else %}This is a read-only query.{% endif %}</span>
+        <input type="hidden" name="is_private" value="0">
+        <label><input type="checkbox" name="is_private" value="1"{% if is_private %} checked{% endif %}> Private</label>
+        <span class="query-create-option-note">Queries marked private can only be seen and edited by you, their owner.</span>
+    </p>
+    <p class="query-create-submit"><input type="submit" value="Save changes" data-query-create-submit{% if save_disabled %} disabled{% endif %}> <a href="{{ query_url }}">Cancel</a></p>
+
+    <div class="query-create-analysis" id="query-create-analysis-section"{% if not has_sql %} hidden{% endif %}>
+        {% if has_sql %}
+            <h2>Query operations</h2>
+            {% if analysis_error %}
+                <p class="message-error">{{ analysis_error }}</p>
+            {% elif analysis_rows %}
+                <div class="table-wrapper"><table class="execute-write-analysis">
+                    <thead>
+                        <tr>
+                            <th scope="col">Operation</th>
+                            <th scope="col">Database</th>
+                            <th scope="col">Table</th>
+                            <th scope="col">Required permission</th>
+                            <th scope="col">Allowed</th>
+                        </tr>
+                    </thead>
+                    <tbody>
+                        {% for row in analysis_rows %}
+                            <tr>
+                                <td><code>{{ row.operation }}</code></td>
+                                <td><code>{{ row.database }}</code></td>
+                                <td><code>{{ row.table }}</code></td>
+                                <td>{% if row.required_permission %}<code>{{ row.required_permission }}</code>{% else %}<span class="execute-write-analysis-na">n/a</span>{% endif %}</td>
+                                <td>{% if row.allowed is none %}<span class="execute-write-analysis-na">n/a</span>{% elif row.allowed %}<span class="execute-write-analysis-allowed">yes</span>{% else %}<span class="execute-write-analysis-denied">no</span>{% endif %}</td>
+                            </tr>
+                        {% endfor %}
+                    </tbody>
+                </table></div>
+            {% else %}
+                <p>Analysis will show each affected table and required permission.</p>
+            {% endif %}
+        {% endif %}
+    </div>
+</form>
+
+</div>
+
+{% include "_codemirror_foot.html" %}
+{% include "_sql_parameter_scripts.html" %}
+{% include "_execute_write_analysis_scripts.html" %}
+
+<script>
+window.addEventListener("DOMContentLoaded", () => {
+  const form = document.querySelector("form.sql.core");
+  const analysisSection = document.querySelector("#query-create-analysis-section");
+  const submitButton = form
+    ? form.querySelector("[data-query-create-submit]")
+    : null;
+  const analysisNote = form
+    ? form.querySelector("[data-query-create-analysis-note]")
+    : null;
+
+  function updateAnalysisNote(data) {
+    if (!analysisNote) {
+      return;
+    }
+    if (data.analysis_error) {
+      analysisNote.textContent = "This query cannot be saved until the SQL is valid.";
+    } else if (data.has_sql === false) {
+      analysisNote.textContent = "Enter SQL to analyze this query.";
+    } else if (data.analysis_is_write) {
+      analysisNote.textContent = "This query updates data in the database.";
+    } else {
+      analysisNote.textContent = "This is a read-only query.";
+    }
+  }
+
+  window.datasetteSqlParameters.setupSqlParameterRefresh({
+    form,
+    url: form.dataset.analyzeUrl,
+    renderParameters: false,
+    onData(data) {
+      window.datasetteSqlAnalysis.renderAnalysis(analysisSection, data);
+      if (submitButton) {
+        submitButton.disabled = data.save_disabled;
+      }
+      updateAnalysisNote(data);
+    },
+    onError(error) {
+      window.datasetteSqlAnalysis.renderAnalysis(analysisSection, {
+        analysis_error: error.message,
+        analysis_rows: [],
+      });
+      if (submitButton) {
+        submitButton.disabled = true;
+      }
+      updateAnalysisNote({ analysis_error: error.message });
+    },
+  });
+});
+</script>
+
+{% endblock %}
diff --git a/datasette/templates/query_list.html b/datasette/templates/query_list.html
index fa4859b1..a8c9a391 100644
--- a/datasette/templates/query_list.html
+++ b/datasette/templates/query_list.html
@@ -205,32 +205,32 @@
 
 <h1 style="padding-left: 10px; border-left: 10px solid #{% if database_color %}{{ database_color }}{% else %}666{% endif %}">Queries</h1>
 
-<form class="query-list-filters core" action="{{ query_list_path }}" method="get">
-    <p class="query-list-search">
-        <label for="query-search">Search</label>
-        <input id="query-search" type="search" name="q" value="{{ filters.q }}">
-        {% if filters.is_write %}<input type="hidden" name="is_write" value="{{ filters.is_write }}">{% endif %}
-        {% if filters.is_private %}<input type="hidden" name="is_private" value="{{ filters.is_private }}">{% endif %}
-        {% if filters.source %}<input type="hidden" name="source" value="{{ filters.source }}">{% endif %}
-        {% if filters.owner_id %}<input type="hidden" name="owner_id" value="{{ filters.owner_id }}">{% endif %}
-        <button type="submit">Search</button>
-    </p>
-</form>
-
-<nav class="query-list-facets" aria-label="Query filters">
-    {% for facet in facets %}
-        <section class="query-list-facet">
-            <h2>{{ facet.title }}</h2>
-            <ul>
-                {% for item in facet["items"] %}
-                    <li>{% if item.href %}<a class="query-list-facet-link{% if item.active %} query-list-facet-link-active{% endif %}" href="{{ item.href }}"{% if item.active %} aria-current="true"{% endif %}>{% else %}<span class="query-list-facet-link query-list-facet-disabled">{% endif %}<span>{{ item.label }}</span><span class="query-list-facet-count">{{ item.count }}</span>{% if item.href %}</a>{% else %}</span>{% endif %}</li>
-                {% endfor %}
-            </ul>
-        </section>
-    {% endfor %}
-</nav>
-
 {% if queries %}
+    <form class="query-list-filters core" action="{{ query_list_path }}" method="get">
+        <p class="query-list-search">
+            <label for="query-search">Search</label>
+            <input id="query-search" type="search" name="q" value="{{ filters.q }}">
+            {% if filters.is_write %}<input type="hidden" name="is_write" value="{{ filters.is_write }}">{% endif %}
+            {% if filters.is_private %}<input type="hidden" name="is_private" value="{{ filters.is_private }}">{% endif %}
+            {% if filters.source %}<input type="hidden" name="source" value="{{ filters.source }}">{% endif %}
+            {% if filters.owner_id %}<input type="hidden" name="owner_id" value="{{ filters.owner_id }}">{% endif %}
+            <button type="submit">Search</button>
+        </p>
+    </form>
+
+    <nav class="query-list-facets" aria-label="Query filters">
+        {% for facet in facets %}
+            <section class="query-list-facet">
+                <h2>{{ facet.title }}</h2>
+                <ul>
+                    {% for item in facet["items"] %}
+                        <li>{% if item.href %}<a class="query-list-facet-link{% if item.active %} query-list-facet-link-active{% endif %}" href="{{ item.href }}"{% if item.active %} aria-current="true"{% endif %}>{% else %}<span class="query-list-facet-link query-list-facet-disabled">{% endif %}<span>{{ item.label }}</span><span class="query-list-facet-count">{{ item.count }}</span>{% if item.href %}</a>{% else %}</span>{% endif %}</li>
+                    {% endfor %}
+                </ul>
+            </section>
+        {% endfor %}
+    </nav>
+
     <div class="table-wrapper"><table class="query-list-results">
         <thead>
             <tr>
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index f30a30bc..9efe3f81 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -436,6 +436,35 @@ async def _query_create_form_context(
     }
 
 
+async def _query_edit_form_context(
+    datasette,
+    request,
+    db,
+    existing: StoredQuery,
+    *,
+    sql=None,
+    title=None,
+    description=None,
+    is_private=None,
+):
+    sql = existing.sql if sql is None else sql
+    title = existing.title if title is None else title
+    description = existing.description if description is None else description
+    is_private = existing.is_private if is_private is None else is_private
+    analysis_data = await _query_create_analysis_data(datasette, db, sql, request.actor)
+    return {
+        "database": db.name,
+        "database_color": db.color,
+        "name": existing.name,
+        "sql": sql,
+        "title": title or "",
+        "description": description or "",
+        "is_private": is_private,
+        "query_url": datasette.urls.table(db.name, existing.name),
+        **analysis_data,
+    }
+
+
 async def _inserted_row_url(datasette, db, analysis, cursor):
     if cursor.rowcount != 1:
         return None
diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
index 8c4e849e..2753f876 100644
--- a/datasette/views/stored_queries.py
+++ b/datasette/views/stored_queries.py
@@ -18,6 +18,7 @@ from .query_helpers import (
     _query_create_analysis_data,
     _query_create_form_context,
     _query_create_form_error_message,
+    _query_edit_form_context,
     _query_list_limit,
 )
 
@@ -464,13 +465,164 @@ class QueryUpdateView(BaseView):
         return Response.json({"ok": True})
 
 
-class QueryDeleteView(BaseView):
-    name = "query-delete"
+class QueryEditView(BaseView):
+    name = "query-edit"
+    has_json_alternate = False
 
-    async def post(self, request):
+    async def _load(self, request):
         db = await self.ds.resolve_database(request)
         query_name = tilde_decode(request.url_vars["query"])
         existing = await self.ds.get_query(db.name, query_name)
+        return db, query_name, existing
+
+    async def _render_form(
+        self,
+        request,
+        db,
+        existing,
+        *,
+        sql=None,
+        title=None,
+        description=None,
+        is_private=None,
+        status=200,
+    ):
+        response = await self.render(
+            ["query_edit.html"],
+            request,
+            await _query_edit_form_context(
+                self.ds,
+                request,
+                db,
+                existing,
+                sql=sql,
+                title=title,
+                description=description,
+                is_private=is_private,
+            ),
+        )
+        response.status = status
+        return response
+
+    async def get(self, request):
+        db, query_name, existing = await self._load(request)
+        if existing is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        await self.ds.ensure_permission(
+            action="update-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        )
+        if existing.is_trusted:
+            return _error(["Trusted queries cannot be edited"], 403)
+        return await self._render_form(request, db, existing)
+
+    async def post(self, request):
+        db, query_name, existing = await self._load(request)
+        if existing is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        if not await self.ds.allowed(
+            action="update-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need update-query"], 403)
+        if existing.is_trusted:
+            return _error(["Trusted queries cannot be edited"], 403)
+
+        data, _ = await _json_or_form_payload(request)
+        if not isinstance(data, dict):
+            return _error(["Invalid form submission"], 400)
+        sql = data.get("sql")
+        sql = existing.sql if sql is None else sql.strip()
+        title = data.get("title") or ""
+        description = data.get("description") or ""
+        is_private = _as_bool(data.get("is_private"))
+
+        update = {
+            "title": title,
+            "description": description,
+            "is_private": is_private,
+        }
+        if sql != existing.sql:
+            if not await self.ds.allowed(
+                action="execute-sql",
+                resource=DatabaseResource(db.name),
+                actor=request.actor,
+            ):
+                self.ds.add_message(
+                    request,
+                    "Permission denied: need execute-sql to change the SQL",
+                    self.ds.ERROR,
+                )
+                return await self._render_form(
+                    request,
+                    db,
+                    existing,
+                    sql=sql,
+                    title=title,
+                    description=description,
+                    is_private=is_private,
+                    status=403,
+                )
+            update["sql"] = sql
+
+        try:
+            update_kwargs = await _prepare_query_update(
+                self.ds, request, db, existing, update
+            )
+        except QueryValidationError as ex:
+            self.ds.add_message(request, ex.message, self.ds.ERROR)
+            return await self._render_form(
+                request,
+                db,
+                existing,
+                sql=sql,
+                title=title,
+                description=description,
+                is_private=is_private,
+                status=ex.status,
+            )
+
+        await self.ds.update_query(db.name, query_name, **update_kwargs)
+        self.ds.add_message(request, "Query updated", self.ds.INFO)
+        return Response.redirect(
+            self.ds.urls.path(self.ds.urls.table(db.name, query_name))
+        )
+
+
+class QueryDeleteView(BaseView):
+    name = "query-delete"
+    has_json_alternate = False
+
+    async def _load(self, request):
+        db = await self.ds.resolve_database(request)
+        query_name = tilde_decode(request.url_vars["query"])
+        existing = await self.ds.get_query(db.name, query_name)
+        return db, query_name, existing
+
+    async def get(self, request):
+        db, query_name, existing = await self._load(request)
+        if existing is None:
+            return _error(["Query not found: {}".format(query_name)], 404)
+        await self.ds.ensure_permission(
+            action="delete-query",
+            resource=QueryResource(db.name, query_name),
+            actor=request.actor,
+        )
+        return await self.render(
+            ["query_delete.html"],
+            request,
+            {
+                "database": db.name,
+                "database_color": db.color,
+                "query": stored_query_to_dict(existing),
+                "query_url": self.ds.urls.table(db.name, query_name),
+            },
+        )
+
+    async def post(self, request):
+        db, query_name, existing = await self._load(request)
         if existing is None:
             return _error(["Query not found: {}".format(query_name)], 404)
         if not await self.ds.allowed(
@@ -479,5 +631,14 @@ class QueryDeleteView(BaseView):
             actor=request.actor,
         ):
             return _error(["Permission denied: need delete-query"], 403)
+
+        data, is_json = await _json_or_form_payload(request)
         await self.ds.remove_query(db.name, query_name)
-        return Response.json({"ok": True})
+        if is_json:
+            return Response.json({"ok": True})
+        self.ds.add_message(
+            request,
+            "Query “{}” deleted".format(existing.title or query_name),
+            self.ds.INFO,
+        )
+        return Response.redirect(self.ds.urls.path(self.ds.urls.database(db.name)))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index d5f8fa14..75e4f3e8 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,6 +4,13 @@
 Changelog
 =========
 
+.. _v1_0_a33:
+
+1.0a33 (unreleased)
+-------------------
+
+- Stored queries can now be edited and deleted from the web interface. The stored query page gained a "Query actions" menu with **Edit this query** and **Delete this query** links for actors with the necessary permissions. The owner of a query can always edit or delete it; for queries that are not private, any actor with the :ref:`update-query <actions_update_query>` or :ref:`delete-query <actions_delete_query>` permission can do so too. Private queries remain editable and deletable only by their owner. See :ref:`stored_queries` for details. (:issue:`2735`)
+
 .. _v1_0_a32:
 
 1.0a32 (2026-05-31)
diff --git a/docs/plugins.rst b/docs/plugins.rst
index d578e9e2..c2eb282a 100644
--- a/docs/plugins.rst
+++ b/docs/plugins.rst
@@ -271,6 +271,15 @@ If you run ``datasette plugins --all`` it will include default plugins that ship
                 "register_token_handler"
             ]
         },
+        {
+            "name": "datasette.default_query_actions",
+            "static": false,
+            "templates": false,
+            "version": null,
+            "hooks": [
+                "query_actions"
+            ]
+        },
         {
             "name": "datasette.events",
             "static": false,
diff --git a/docs/sql_queries.rst b/docs/sql_queries.rst
index c0ba67f0..371348fb 100644
--- a/docs/sql_queries.rst
+++ b/docs/sql_queries.rst
@@ -142,6 +142,15 @@ Datasette stores both configured queries and user-created queries in the ``queri
 
 Stored queries created by users default to private. Private stored queries can only be viewed, updated or deleted by the actor that created them. Broad ``view-query``, ``update-query`` or ``delete-query`` permission grants still do not allow other actors to access another actor's private stored queries.
 
+Editing and deleting stored queries
++++++++++++++++++++++++++++++++++++
+
+The page for a stored query includes a "Query actions" menu with **Edit this query** and **Delete this query** links for actors who have permission to use them.
+
+The owner of a stored query can always edit and delete it. For queries that are not private, any actor granted the ``update-query`` or ``delete-query`` permission can edit or delete the query, even if they did not create it. Private queries can only be edited or deleted by their owner, regardless of any broad permission grants.
+
+Editing a query lets you change its title, description, SQL and whether it is private. Changing the SQL also requires the ``execute-sql`` permission (and the relevant write permissions for writable queries). The same operations are available through the JSON API by sending a ``POST`` to ``/<database>/<query>/-/update`` or ``/<database>/<query>/-/delete``. Trusted stored queries cannot be edited or deleted through the web interface or the JSON API.
+
 Stored queries created by users are untrusted. This means they execute using the permissions of the actor who runs them, as if that actor had pasted the SQL into the regular custom SQL interface or write SQL interface. Read-only stored queries require ``execute-sql``. Writable stored queries require ``execute-write-sql`` plus the relevant table-level write permissions. SQL functions are allowed and are not separately restricted by Datasette permissions.
 
 .. _trusted_stored_queries:
diff --git a/tests/test_docs.py b/tests/test_docs.py
index 9cf39f41..51caf595 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -77,6 +77,7 @@ def documented_views():
             "QueryCreateAnalyzeView",
             "QueryDeleteView",
             "QueryDefinitionView",
+            "QueryEditView",
             "QueryListView",
             "QueryParametersView",
             "QueryStoreView",
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 25e423d4..6e9bcbdb 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -3,6 +3,7 @@ import re
 from html import unescape
 
 import pytest
+from bs4 import BeautifulSoup as Soup
 
 from datasette.app import Datasette
 from datasette.resources import DatabaseResource, QueryResource
@@ -712,6 +713,10 @@ async def test_query_list_search_filter_and_html():
         "/data/-/queries?is_private=1",
         actor={"id": "root"},
     )
+    no_results_response = await ds.client.get(
+        "/data/-/queries?q=nope",
+        actor={"id": "root"},
+    )
 
     assert html_response.status_code == 200
     assert "Demo query 02" in html_response.text
@@ -799,6 +804,13 @@ async def test_query_list_search_filter_and_html():
         '<span class="query-list-facet-link query-list-facet-disabled"><span>Not private</span><span class="query-list-facet-count">0</span></span>'
         not in filtered_private_response.text
     )
+    assert no_results_response.status_code == 200
+    assert "No queries found." in no_results_response.text
+    assert 'class="query-list-filters core"' not in no_results_response.text
+    assert 'id="query-search"' not in no_results_response.text
+    assert 'class="query-list-facets"' not in no_results_response.text
+    assert "<h2>Mode</h2>" not in no_results_response.text
+    assert "<h2>Visibility</h2>" not in no_results_response.text
 
 
 @pytest.mark.asyncio
@@ -1114,6 +1126,227 @@ async def test_query_update_api_rejects_trusted_queries_but_internal_update_allo
     assert query.title == "Internal"
 
 
+async def _make_ds_with_user_query(name, *, is_private=False, owner_id="owner"):
+    ds = Datasette(memory=True, settings={"default_allow_sql": True})
+    db = ds.add_memory_database(name, name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "saved",
+        "select * from dogs",
+        title="Saved query",
+        description="A saved query",
+        source="user",
+        owner_id=owner_id,
+        is_private=is_private,
+    )
+    return ds
+
+
+@pytest.mark.asyncio
+async def test_query_edit_form_renders_and_updates_for_owner():
+    ds = await _make_ds_with_user_query("query_edit_owner")
+    actor = {"id": "owner"}
+
+    # GET renders the form pre-filled with existing values
+    get_response = await ds.client.get("/data/saved/-/edit", actor=actor)
+    assert get_response.status_code == 200
+    assert 'value="Saved query"' in get_response.text
+    assert ">A saved query</textarea>" in get_response.text
+    assert "select * from dogs" in get_response.text
+    # URL slug is shown but not editable
+    assert 'name="name"' not in get_response.text
+
+    # POST updates the query and redirects back to the query page
+    post_response = await ds.client.post(
+        "/data/saved/-/edit",
+        actor=actor,
+        data={
+            "title": "Updated title",
+            "description": "Updated description",
+            "sql": "select id from dogs",
+            "is_private": "1",
+        },
+    )
+    assert post_response.status_code == 302
+    assert post_response.headers["location"] == "/data/saved"
+
+    query = await ds.get_query("data", "saved")
+    assert query.title == "Updated title"
+    assert query.description == "Updated description"
+    assert query.sql == "select id from dogs"
+    assert query.is_private is True
+
+
+@pytest.mark.asyncio
+async def test_query_edit_metadata_only_does_not_require_execute_sql():
+    # An owner who can no longer execute SQL can still edit title/description
+    ds = await _make_ds_with_user_query("query_edit_metadata_only")
+    actor = {"id": "owner"}
+
+    post_response = await ds.client.post(
+        "/data/saved/-/edit",
+        actor=actor,
+        data={
+            "title": "Renamed",
+            "description": "A saved query",
+            "sql": "select * from dogs",
+        },
+    )
+    assert post_response.status_code == 302
+    query = await ds.get_query("data", "saved")
+    assert query.title == "Renamed"
+
+
+@pytest.mark.asyncio
+async def test_private_query_edit_delete_restricted_to_owner():
+    ds = await _make_ds_with_user_query(
+        "query_edit_private", is_private=True, owner_id="owner"
+    )
+
+    # A different actor cannot view, edit or delete the private query
+    other = {"id": "intruder"}
+    assert (await ds.client.get("/data/saved/-/edit", actor=other)).status_code == 403
+    assert (await ds.client.get("/data/saved/-/delete", actor=other)).status_code == 403
+    delete_attempt = await ds.client.post(
+        "/data/saved/-/delete",
+        actor=other,
+        data={},
+    )
+    assert delete_attempt.status_code == 403
+    assert await ds.get_query("data", "saved") is not None
+
+    # The owner can edit and delete
+    owner = {"id": "owner"}
+    assert (await ds.client.get("/data/saved/-/edit", actor=owner)).status_code == 200
+
+
+@pytest.mark.asyncio
+async def test_non_private_query_editable_by_permitted_non_owner():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "execute-sql": {"id": "editor"},
+                        "update-query": {"id": "editor"},
+                        "delete-query": {"id": "editor"},
+                    }
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("query_non_private_editor", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+    await ds.add_query(
+        "data",
+        "saved",
+        "select * from dogs",
+        title="Shared",
+        source="user",
+        owner_id="owner",
+        is_private=False,
+    )
+
+    editor = {"id": "editor"}
+    # Editor (not the owner) can edit because the query is not private
+    post_response = await ds.client.post(
+        "/data/saved/-/edit",
+        actor=editor,
+        data={
+            "title": "Edited by editor",
+            "description": "",
+            "sql": "select * from dogs",
+        },
+    )
+    assert post_response.status_code == 302
+    query = await ds.get_query("data", "saved")
+    assert query.title == "Edited by editor"
+
+    # Editor can also delete it
+    delete_response = await ds.client.post(
+        "/data/saved/-/delete",
+        actor=editor,
+        data={},
+    )
+    assert delete_response.status_code == 302
+    assert await ds.get_query("data", "saved") is None
+
+
+@pytest.mark.asyncio
+async def test_query_delete_confirmation_and_form_delete():
+    ds = await _make_ds_with_user_query("query_delete_form")
+    actor = {"id": "owner"}
+
+    get_response = await ds.client.get("/data/saved/-/delete", actor=actor)
+    assert get_response.status_code == 200
+    assert "Are you sure" in get_response.text
+    assert "select * from dogs" in get_response.text
+    soup = Soup(get_response.text, "html.parser")
+    form = soup.select_one("form.query-delete-form")
+    assert form is not None
+    assert "core" in form["class"]
+    assert form.select_one('input[type="submit"][value="Delete query"]') is not None
+
+    post_response = await ds.client.post(
+        "/data/saved/-/delete",
+        actor=actor,
+        data={},
+    )
+    assert post_response.status_code == 302
+    assert post_response.headers["location"] == "/data"
+    assert await ds.get_query("data", "saved") is None
+
+
+@pytest.mark.asyncio
+async def test_query_action_menu_shows_edit_and_delete_for_owner():
+    ds = await _make_ds_with_user_query("query_action_menu")
+
+    owner_response = await ds.client.get("/data/saved", actor={"id": "owner"})
+    assert owner_response.status_code == 200
+    assert "/data/saved/-/edit" in owner_response.text
+    assert "/data/saved/-/delete" in owner_response.text
+
+    # A different actor (the query is public) cannot edit/delete by default
+    other_response = await ds.client.get("/data/saved", actor={"id": "stranger"})
+    assert other_response.status_code == 200
+    assert "/data/saved/-/edit" not in other_response.text
+    assert "/data/saved/-/delete" not in other_response.text
+
+
+@pytest.mark.asyncio
+async def test_query_edit_rejected_for_trusted_query():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "execute-sql": {"id": "editor"},
+                        "update-query": {"id": "editor"},
+                    },
+                    "queries": {"trusted_report": {"sql": "select 1 as one"}},
+                }
+            }
+        },
+    )
+    ds.add_memory_database("query_edit_trusted", name="data")
+    await ds.invoke_startup()
+
+    response = await ds.client.get(
+        "/data/trusted_report/-/edit", actor={"id": "editor"}
+    )
+    assert response.status_code == 403
+    # Edit/delete links should not appear on a trusted/config query page
+    page = await ds.client.get("/data/trusted_report", actor={"id": "editor"})
+    assert "/data/trusted_report/-/edit" not in page.text
+
+
 @pytest.mark.asyncio
 async def test_query_store_api_rejects_magic_parameters():
     ds = Datasette(memory=True, default_deny=True)

From 03f1ffdf8fbf0ed7da46be48f3fcc3f4698e1e21 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 8 Jun 2026 20:45:01 -0700
Subject: [PATCH 143/386] Centralize JSON extra parsing

---
 datasette/extras.py      |  6 ++++++
 datasette/renderer.py    |  3 ++-
 datasette/views/table.py |  7 ++-----
 tests/test_table_api.py  | 11 +++++++++++
 4 files changed, 21 insertions(+), 6 deletions(-)
 create mode 100644 datasette/extras.py

diff --git a/datasette/extras.py b/datasette/extras.py
new file mode 100644
index 00000000..01a9fb4b
--- /dev/null
+++ b/datasette/extras.py
@@ -0,0 +1,6 @@
+def extra_names_from_request(request):
+    extra_bits = request.args.getlist("_extra")
+    extras = set()
+    for bit in extra_bits:
+        extras.update(part for part in bit.split(",") if part)
+    return extras
diff --git a/datasette/renderer.py b/datasette/renderer.py
index acf23e59..f40e3dbb 100644
--- a/datasette/renderer.py
+++ b/datasette/renderer.py
@@ -1,4 +1,5 @@
 import json
+from datasette.extras import extra_names_from_request
 from datasette.utils import (
     value_as_boolean,
     remove_infinites,
@@ -108,7 +109,7 @@ def json_renderer(request, args, data, error, truncated=None):
 
     # Don't include "columns" in output
     # https://github.com/simonw/datasette/issues/2136
-    if isinstance(data, dict) and "columns" not in request.args.getlist("_extra"):
+    if isinstance(data, dict) and "columns" not in extra_names_from_request(request):
         data.pop("columns", None)
 
     # Handle _nl option for _shape=array
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 4df1e1b4..9ba249f4 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -6,6 +6,7 @@ import urllib
 from asyncinject import Registry
 import markupsafe
 
+from datasette.extras import extra_names_from_request
 from datasette.plugins import pm
 from datasette.database import QueryInterrupted
 from datasette.events import (
@@ -850,11 +851,7 @@ class TableDropView(BaseView):
 
 
 def _get_extras(request):
-    extra_bits = request.args.getlist("_extra")
-    extras = set()
-    for bit in extra_bits:
-        extras.update(bit.split(","))
-    return extras
+    return extra_names_from_request(request)
 
 
 async def _columns_to_select(table_columns, pks, request):
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index ceeb646d..eeb3dc8b 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -1376,6 +1376,17 @@ async def test_table_extras(ds_client, extra, expected_json):
     assert response.json() == expected_json
 
 
+@pytest.mark.asyncio
+async def test_table_extra_columns_can_be_comma_separated(ds_client):
+    response = await ds_client.get(
+        "/fixtures/primary_key_multiple_columns.json?_extra=columns,count"
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert data["columns"] == ["id", "content", "content2"]
+    assert data["count"] == 1
+
+
 @pytest.mark.asyncio
 async def test_extra_render_cell():
     """Test that _extra=render_cell returns rendered HTML from render_cell plugin hook"""

From 17bbe6855c34630c14b077e08247d453d371cdea Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 8 Jun 2026 20:52:10 -0700
Subject: [PATCH 144/386] Refactor table JSON extras into classes

---
 datasette/extras.py             |  94 ++++
 datasette/views/table.py        | 584 ++-----------------------
 datasette/views/table_extras.py | 746 ++++++++++++++++++++++++++++++++
 3 files changed, 884 insertions(+), 540 deletions(-)
 create mode 100644 datasette/views/table_extras.py

diff --git a/datasette/extras.py b/datasette/extras.py
index 01a9fb4b..786ec4f4 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -1,6 +1,100 @@
+import re
+from enum import Enum
+from typing import ClassVar
+
+from asyncinject import Registry
+
+
 def extra_names_from_request(request):
     extra_bits = request.args.getlist("_extra")
     extras = set()
     for bit in extra_bits:
         extras.update(part for part in bit.split(",") if part)
     return extras
+
+
+class ExtraScope(Enum):
+    TABLE = "table"
+
+
+class Provider:
+    name: ClassVar[str | None] = None
+    scopes: ClassVar[frozenset[ExtraScope]] = frozenset()
+    public: ClassVar[bool] = False
+
+    @classmethod
+    def key(cls):
+        return cls.name or _camel_to_snake(cls.__name__)
+
+    @classmethod
+    def available_for(cls, scope):
+        return scope in cls.scopes
+
+    async def resolve(self, context):
+        raise NotImplementedError
+
+
+class Extra(Provider):
+    description: ClassVar[str | None] = None
+    public: ClassVar[bool] = True
+    stable: ClassVar[bool] = True
+    expensive: ClassVar[bool] = False
+    docs_note: ClassVar[str | None] = None
+
+    @classmethod
+    def documentation(cls):
+        return {
+            "name": cls.key(),
+            "description": cls.description,
+            "scopes": [
+                scope.value for scope in sorted(cls.scopes, key=lambda s: s.value)
+            ],
+            "stable": cls.stable,
+            "expensive": cls.expensive,
+            "docs_note": cls.docs_note,
+        }
+
+
+class ExtraRegistry:
+    def __init__(self, classes):
+        self.classes = list(classes)
+        self.classes_by_name = {cls.key(): cls for cls in self.classes}
+
+    def classes_for_scope(self, scope, include_internal=True):
+        classes = [
+            cls
+            for cls in self.classes
+            if cls.available_for(scope) and (include_internal or cls.public)
+        ]
+        return classes
+
+    def public_classes_for_scope(self, scope):
+        return self.classes_for_scope(scope, include_internal=False)
+
+    async def resolve(self, requested, context, scope):
+        registry = Registry()
+
+        async def context_provider():
+            return context
+
+        registry.register(context_provider, name="context")
+
+        for cls in self.classes_for_scope(scope):
+            registry.register(cls().resolve, name=cls.key())
+
+        public_names = {cls.key() for cls in self.public_classes_for_scope(scope)}
+        requested_public_names = [
+            name
+            for name in requested
+            if name in public_names and name in registry._registry
+        ]
+        resolved = await registry.resolve_multi(requested_public_names)
+        return {
+            name: resolved[name] for name in requested_public_names if name in resolved
+        }
+
+
+def _camel_to_snake(name):
+    name = re.sub(r"(Extra|Provider)$", "", name)
+    name = re.sub("(.)([A-Z][a-z]+)", r"\1_\2", name)
+    return re.sub("([a-z0-9])([A-Z])", r"\1_\2", name).lower()
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 9ba249f4..c2d520f8 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -3,12 +3,10 @@ import itertools
 import json
 import urllib
 
-from asyncinject import Registry
 import markupsafe
 
 from datasette.extras import extra_names_from_request
 from datasette.plugins import pm
-from datasette.database import QueryInterrupted
 from datasette.events import (
     AlterTableEvent,
     DropTableEvent,
@@ -47,6 +45,12 @@ from datasette.filters import Filters
 import sqlite_utils
 from .base import BaseView, DatasetteError, _error, stream_csv
 from .database import QueryView
+from .table_extras import (
+    TABLE_EXTRA_BUNDLES,
+    TableExtraContext,
+    resolve_table_extras,
+    table_extra_registry,
+)
 
 LINK_WITH_LABEL = (
     '<a href="{base_url}{database}/{table}/{link_id}">{label}</a>&nbsp;<em>{id}</em>'
@@ -1465,560 +1469,60 @@ async def table_view_data(
     if extra_extras:
         extras.update(extra_extras)
 
-    async def extra_count_sql():
-        return count_sql
-
-    async def extra_count():
-        "Total count of rows matching these filters"
-        # Calculate the total count for this query
-        count = None
-        if (
-            not db.is_mutable
-            and datasette.inspect_data
-            and count_sql == f"select count(*) from {table_name} "
-        ):
-            # We can use a previously cached table row count
-            try:
-                count = datasette.inspect_data[database_name]["tables"][table_name][
-                    "count"
-                ]
-            except KeyError:
-                pass
-
-        # Otherwise run a select count(*) ...
-        if count_sql and count is None and not nocount:
-            count_sql_limited = (
-                f"select count(*) from (select * {from_sql} limit 10001)"
-            )
-            try:
-                count_rows = list(await db.execute(count_sql_limited, from_sql_params))
-                count = count_rows[0][0]
-            except QueryInterrupted:
-                pass
-        return count
-
-    async def facet_instances(extra_count):
-        facet_instances = []
-        facet_classes = list(
-            itertools.chain.from_iterable(pm.hook.register_facet_classes())
-        )
-        for facet_class in facet_classes:
-            facet_instances.append(
-                facet_class(
-                    datasette,
-                    request,
-                    database_name,
-                    sql=sql_no_order_no_limit,
-                    params=params,
-                    table=table_name,
-                    table_config=table_metadata,
-                    row_count=extra_count,
-                )
-            )
-        return facet_instances
-
-    async def extra_facet_results(facet_instances):
-        "Results of facets calculated against this data"
-        facet_results = {}
-        facets_timed_out = []
-
-        if not nofacet:
-            # Run them in parallel
-            facet_awaitables = [facet.facet_results() for facet in facet_instances]
-            facet_awaitable_results = await run_sequential(*facet_awaitables)
-            for (
-                instance_facet_results,
-                instance_facets_timed_out,
-            ) in facet_awaitable_results:
-                for facet_info in instance_facet_results:
-                    base_key = facet_info["name"]
-                    key = base_key
-                    i = 1
-                    while key in facet_results:
-                        i += 1
-                        key = f"{base_key}_{i}"
-                    facet_results[key] = facet_info
-                facets_timed_out.extend(instance_facets_timed_out)
-
-        return {
-            "results": facet_results,
-            "timed_out": facets_timed_out,
-        }
-
-    async def extra_suggested_facets(facet_instances):
-        "Suggestions for facets that might return interesting results"
-        suggested_facets = []
-        # Calculate suggested facets
-        if (
-            datasette.setting("suggest_facets")
-            and datasette.setting("allow_facet")
-            and not _next
-            and not nofacet
-            and not nosuggest
-        ):
-            # Run them in parallel
-            facet_suggest_awaitables = [facet.suggest() for facet in facet_instances]
-            for suggest_result in await run_sequential(*facet_suggest_awaitables):
-                suggested_facets.extend(suggest_result)
-        return suggested_facets
-
     # Faceting
     if not datasette.setting("allow_facet") and any(
         arg.startswith("_facet") for arg in request.args
     ):
         raise BadRequest("_facet= is not allowed")
 
-    # human_description_en combines filters AND search, if provided
-    async def extra_human_description_en():
-        "Human-readable description of the filters"
-        human_description_en = filters.human_description_en(
-            extra=extra_human_descriptions
-        )
-        if sort or sort_desc:
-            human_description_en = " ".join(
-                [b for b in [human_description_en, sorted_by] if b]
-            )
-        return human_description_en
-
-    if sort or sort_desc:
-        sorted_by = "sorted by {}{}".format(
-            (sort or sort_desc), " descending" if sort_desc else ""
-        )
-
-    async def extra_next_url():
-        "Full URL for the next page of results"
-        return next_url
-
-    async def extra_columns():
-        "Column names returned by this query"
-        return columns
-
-    async def extra_all_columns():
-        "All columns in the table, regardless of _col/_nocol filtering"
-        return list(table_columns)
-
-    async def extra_primary_keys():
-        "Primary keys for this table"
-        return pks
-
-    async def extra_actions():
-        async def actions():
-            links = []
-            kwargs = {
-                "datasette": datasette,
-                "database": database_name,
-                "actor": request.actor,
-                "request": request,
-            }
-            if is_view:
-                kwargs["view"] = table_name
-                method = pm.hook.view_actions
-            else:
-                kwargs["table"] = table_name
-                method = pm.hook.table_actions
-            for hook in method(**kwargs):
-                extra_links = await await_me_maybe(hook)
-                if extra_links:
-                    links.extend(extra_links)
-            return links
-
-        return actions
-
-    async def extra_is_view():
-        return is_view
-
-    async def extra_debug():
-        "Extra debug information"
-        return {
-            "resolved": repr(resolved),
-            "url_vars": request.url_vars,
-            "nofacet": nofacet,
-            "nosuggest": nosuggest,
-        }
-
-    async def extra_request():
-        "Full information about the request"
-        return {
-            "url": request.url,
-            "path": request.path,
-            "full_path": request.full_path,
-            "host": request.host,
-            "args": request.args._data,
-        }
-
-    async def run_display_columns_and_rows():
-        display_columns, display_rows = await display_columns_and_rows(
-            datasette,
-            database_name,
-            table_name,
-            results.description,
-            rows,
-            link_column=not is_view,
-            truncate_cells=datasette.setting("truncate_cells_html"),
-            sortable_columns=sortable_columns,
-            request=request,
-        )
-        return {
-            "columns": display_columns,
-            "rows": display_rows,
-        }
-
-    async def extra_display_columns(run_display_columns_and_rows):
-        return run_display_columns_and_rows["columns"]
-
-    async def extra_display_rows(run_display_columns_and_rows):
-        return run_display_columns_and_rows["rows"]
-
-    async def extra_render_cell():
-        "Rendered HTML for each cell using the render_cell plugin hook"
-        pks_for_display = pks if pks else (["rowid"] if not is_view else [])
-        col_names = [col[0] for col in results.description]
-        ct_map = await datasette.get_column_types(database_name, table_name)
-        rendered_rows = []
-        for row in rows:
-            rendered_row = {}
-            for value, column in zip(row, col_names):
-                ct = ct_map.get(column)
-                plugin_display_value = None
-                # Try column type render_cell first
-                if ct:
-                    candidate = await ct.render_cell(
-                        value=value,
-                        column=column,
-                        table=table_name,
-                        database=database_name,
-                        datasette=datasette,
-                        request=request,
-                    )
-                    if candidate is not None:
-                        plugin_display_value = candidate
-                if plugin_display_value is None:
-                    for candidate in pm.hook.render_cell(
-                        row=row,
-                        value=value,
-                        column=column,
-                        table=table_name,
-                        pks=pks_for_display,
-                        database=database_name,
-                        datasette=datasette,
-                        request=request,
-                        column_type=ct,
-                    ):
-                        candidate = await await_me_maybe(candidate)
-                        if candidate is not None:
-                            plugin_display_value = candidate
-                            break
-                if plugin_display_value:
-                    rendered_row[column] = str(plugin_display_value)
-            rendered_rows.append(rendered_row)
-        return rendered_rows
-
-    async def extra_query():
-        "Details of the underlying SQL query"
-        return {
-            "sql": sql,
-            "params": params,
-        }
-
-    async def extra_column_types():
-        "Column type assignments for this table"
-        ct_map = await datasette.get_column_types(database_name, table_name)
-        return {
-            col_name: {
-                "type": ct.name,
-                "config": ct.config,
-            }
-            for col_name, ct in ct_map.items()
-        }
-
-    async def extra_set_column_type_ui():
-        "Column type UI metadata for this table"
-        if is_view:
-            return None
-
-        if not await datasette.allowed(
-            action="set-column-type",
-            resource=TableResource(database=database_name, table=table_name),
-            actor=request.actor,
-        ):
-            return None
-
-        column_details = await datasette._get_resource_column_details(
-            database_name, table_name
-        )
-        ct_map = await datasette.get_column_types(database_name, table_name)
-        columns = {}
-        for column_name, column_detail in column_details.items():
-            current = ct_map.get(column_name)
-            columns[column_name] = {
-                "current": (
-                    {"type": current.name, "config": current.config}
-                    if current is not None
-                    else None
-                ),
-                "options": [
-                    {
-                        "name": name,
-                        "description": ct_cls.description,
-                    }
-                    for name, ct_cls in sorted(datasette._column_types.items())
-                    if datasette._column_type_is_applicable(ct_cls, column_detail)
-                ],
-            }
-        return {
-            "path": "{}/-/set-column-type".format(
-                datasette.urls.table(database_name, table_name)
-            ),
-            "columns": columns,
-        }
-
-    async def extra_metadata():
-        "Metadata about the table and database"
-        tablemetadata = await datasette.get_resource_metadata(database_name, table_name)
-
-        rows = await datasette.get_internal_database().execute(
-            """
-              SELECT
-                column_name,
-                value
-              FROM metadata_columns
-              WHERE database_name = ?
-                AND resource_name = ?
-                AND key = 'description'
-            """,
-            [database_name, table_name],
-        )
-        tablemetadata["columns"] = dict(rows)
-        return tablemetadata
-
-    async def extra_database():
-        return database_name
-
-    async def extra_table():
-        return table_name
-
-    async def extra_database_color():
-        return db.color
-
-    async def extra_form_hidden_args():
-        form_hidden_args = []
-        for key in request.args:
-            if (
-                key.startswith("_")
-                and key not in ("_sort", "_sort_desc", "_search", "_next")
-                and "__" not in key
-            ):
-                for value in request.args.getlist(key):
-                    form_hidden_args.append((key, value))
-        return form_hidden_args
-
-    async def extra_filters():
-        return filters
-
-    async def extra_custom_table_templates():
-        return [
-            f"_table-{to_css_class(database_name)}-{to_css_class(table_name)}.html",
-            f"_table-table-{to_css_class(database_name)}-{to_css_class(table_name)}.html",
-            "_table.html",
-        ]
-
-    async def extra_sorted_facet_results(extra_facet_results):
-        facet_configs = table_metadata.get("facets", [])
-        if facet_configs:
-            # Build ordered list of facet names from metadata config
-            metadata_facet_names = []
-            for fc in facet_configs:
-                if isinstance(fc, str):
-                    metadata_facet_names.append(fc)
-                elif isinstance(fc, dict):
-                    metadata_facet_names.append(list(fc.values())[0])
-            metadata_order = {name: i for i, name in enumerate(metadata_facet_names)}
-            metadata_facets = []
-            request_facets = []
-            for f in extra_facet_results["results"].values():
-                if f["name"] in metadata_order:
-                    metadata_facets.append(f)
-                else:
-                    request_facets.append(f)
-            metadata_facets.sort(key=lambda f: metadata_order[f["name"]])
-            request_facets.sort(
-                key=lambda f: (len(f["results"]), f["name"]),
-                reverse=True,
-            )
-            return metadata_facets + request_facets
-        else:
-            return sorted(
-                extra_facet_results["results"].values(),
-                key=lambda f: (len(f["results"]), f["name"]),
-                reverse=True,
-            )
-
-    async def extra_table_definition():
-        return await db.get_table_definition(table_name)
-
-    async def extra_view_definition():
-        return await db.get_view_definition(table_name)
-
-    async def extra_renderers(extra_expandable_columns, extra_query):
-        renderers = {}
-        url_labels_extra = {}
-        if extra_expandable_columns:
-            url_labels_extra = {"_labels": "on"}
-        for key, (_, can_render) in datasette.renderers.items():
-            it_can_render = call_with_supported_arguments(
-                can_render,
-                datasette=datasette,
-                columns=columns or [],
-                rows=rows or [],
-                sql=extra_query.get("sql", None),
-                query_name=None,
-                database=database_name,
-                table=table_name,
-                request=request,
-                view_name="table",
-            )
-            it_can_render = await await_me_maybe(it_can_render)
-            if it_can_render:
-                renderers[key] = datasette.urls.path(
-                    path_with_format(
-                        request=request,
-                        path=request.scope.get("route_path"),
-                        format=key,
-                        extra_qs={**url_labels_extra},
-                    )
-                )
-        return renderers
-
-    async def extra_private():
-        return private
-
-    async def extra_expandable_columns():
-        expandables = []
-        db = datasette.databases[database_name]
-        for fk in await db.foreign_keys_for_table(table_name):
-            label_column = await db.label_column_for_table(fk["other_table"])
-            expandables.append((fk, label_column))
-        return expandables
-
-    async def extra_extras():
-        "Available ?_extra= blocks"
-        all_extras = [
-            (key[len("extra_") :], fn.__doc__)
-            for key, fn in registry._registry.items()
-            if key.startswith("extra_")
-        ]
-        return [
-            {
-                "name": name,
-                "description": doc,
-                "toggle_url": datasette.absolute_url(
-                    request,
-                    datasette.urls.path(
-                        path_with_added_args(request, {"_extra": name})
-                        if name not in extras
-                        else path_with_removed_args(request, {"_extra": name})
-                    ),
-                ),
-                "selected": name in extras,
-            }
-            for name, doc in all_extras
-        ]
-
-    async def extra_facets_timed_out(extra_facet_results):
-        return extra_facet_results["timed_out"]
-
-    bundles = {
-        "html": [
-            "suggested_facets",
-            "facet_results",
-            "facets_timed_out",
-            "count",
-            "count_sql",
-            "human_description_en",
-            "next_url",
-            "metadata",
-            "query",
-            "columns",
-            "display_columns",
-            "display_rows",
-            "database",
-            "table",
-            "database_color",
-            "actions",
-            "filters",
-            "renderers",
-            "custom_table_templates",
-            "sorted_facet_results",
-            "table_definition",
-            "view_definition",
-            "is_view",
-            "private",
-            "primary_keys",
-            "all_columns",
-            "expandable_columns",
-            "form_hidden_args",
-            "set_column_type_ui",
-        ]
-    }
-
-    for key, values in bundles.items():
+    for key, values in TABLE_EXTRA_BUNDLES.items():
         if f"_{key}" in extras:
             extras.update(values)
         extras.discard(f"_{key}")
 
-    registry = Registry(
-        extra_count,
-        extra_count_sql,
-        extra_facet_results,
-        extra_facets_timed_out,
-        extra_suggested_facets,
-        facet_instances,
-        extra_human_description_en,
-        extra_next_url,
-        extra_columns,
-        extra_all_columns,
-        extra_primary_keys,
-        run_display_columns_and_rows,
-        extra_display_columns,
-        extra_display_rows,
-        extra_render_cell,
-        extra_debug,
-        extra_request,
-        extra_query,
-        extra_column_types,
-        extra_set_column_type_ui,
-        extra_metadata,
-        extra_extras,
-        extra_database,
-        extra_table,
-        extra_database_color,
-        extra_actions,
-        extra_filters,
-        extra_renderers,
-        extra_custom_table_templates,
-        extra_sorted_facet_results,
-        extra_table_definition,
-        extra_view_definition,
-        extra_is_view,
-        extra_private,
-        extra_expandable_columns,
-        extra_form_hidden_args,
+    table_extra_context = TableExtraContext(
+        datasette=datasette,
+        request=request,
+        resolved=resolved,
+        db=db,
+        database_name=database_name,
+        table_name=table_name,
+        is_view=is_view,
+        private=private,
+        rows=rows,
+        columns=columns,
+        results_description=results.description,
+        table_columns=table_columns,
+        pks=pks,
+        count_sql=count_sql,
+        from_sql=from_sql,
+        from_sql_params=from_sql_params,
+        nocount=nocount,
+        nofacet=nofacet,
+        nosuggest=nosuggest,
+        next_arg=request.args.get("_next"),
+        next_value=next_value,
+        next_url=next_url,
+        sql=sql,
+        sql_no_order_no_limit=sql_no_order_no_limit,
+        params=params,
+        table_metadata=table_metadata,
+        filters=filters,
+        extra_human_descriptions=extra_human_descriptions,
+        sort=sort,
+        sort_desc=sort_desc,
+        sortable_columns=sortable_columns,
+        extras=extras,
+        extra_registry=table_extra_registry,
+        display_columns_and_rows=display_columns_and_rows,
+        run_sequential=run_sequential,
     )
 
-    results = await registry.resolve_multi(
-        ["extra_{}".format(extra) for extra in extras]
-    )
     data = {
         "ok": True,
         "next": next_value and str(next_value) or None,
     }
-    data.update(
-        {
-            key.replace("extra_", ""): value
-            for key, value in results.items()
-            if key.startswith("extra_") and key.replace("extra_", "") in extras
-        }
-    )
+    data.update(await resolve_table_extras(extras, table_extra_context))
     raw_sqlite_rows = rows[:page_size]
     # Apply transform_value for columns with assigned types
     ct_map = await datasette.get_column_types(database_name, table_name)
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
new file mode 100644
index 00000000..2ec2adf0
--- /dev/null
+++ b/datasette/views/table_extras.py
@@ -0,0 +1,746 @@
+import itertools
+from dataclasses import dataclass
+
+from datasette.database import QueryInterrupted
+from datasette.extras import Extra, ExtraRegistry, ExtraScope, Provider
+from datasette.plugins import pm
+from datasette.resources import TableResource
+from datasette.utils import (
+    await_me_maybe,
+    call_with_supported_arguments,
+    path_with_added_args,
+    path_with_format,
+    path_with_removed_args,
+    to_css_class,
+)
+
+
+@dataclass(frozen=True)
+class TableExtraContext:
+    datasette: object
+    request: object
+    resolved: object
+    db: object
+    database_name: str
+    table_name: str
+    is_view: bool
+    private: bool
+    rows: list
+    columns: list
+    results_description: list
+    table_columns: list
+    pks: list
+    count_sql: str
+    from_sql: str
+    from_sql_params: dict
+    nocount: object
+    nofacet: object
+    nosuggest: object
+    next_arg: object
+    next_value: object
+    next_url: str | None
+    sql: str
+    sql_no_order_no_limit: str
+    params: dict
+    table_metadata: dict
+    filters: object
+    extra_human_descriptions: list
+    sort: str | None
+    sort_desc: str | None
+    sortable_columns: set
+    extras: set
+    extra_registry: ExtraRegistry
+    display_columns_and_rows: object
+    run_sequential: object
+
+
+class CountSqlExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.count_sql
+
+
+class CountExtra(Extra):
+    description = "Total count of rows matching these filters"
+    scopes = frozenset({ExtraScope.TABLE})
+    expensive = True
+
+    async def resolve(self, context):
+        count = None
+        if (
+            not context.db.is_mutable
+            and context.datasette.inspect_data
+            and context.count_sql == f"select count(*) from {context.table_name} "
+        ):
+            try:
+                count = context.datasette.inspect_data[context.database_name]["tables"][
+                    context.table_name
+                ]["count"]
+            except KeyError:
+                pass
+
+        if context.count_sql and count is None and not context.nocount:
+            count_sql_limited = (
+                f"select count(*) from (select * {context.from_sql} limit 10001)"
+            )
+            try:
+                count_rows = list(
+                    await context.db.execute(count_sql_limited, context.from_sql_params)
+                )
+                count = count_rows[0][0]
+            except QueryInterrupted:
+                pass
+        return count
+
+
+class FacetInstancesProvider(Provider):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context, count):
+        facet_instances = []
+        facet_classes = list(
+            itertools.chain.from_iterable(pm.hook.register_facet_classes())
+        )
+        for facet_class in facet_classes:
+            facet_instances.append(
+                facet_class(
+                    context.datasette,
+                    context.request,
+                    context.database_name,
+                    sql=context.sql_no_order_no_limit,
+                    params=context.params,
+                    table=context.table_name,
+                    table_config=context.table_metadata,
+                    row_count=count,
+                )
+            )
+        return facet_instances
+
+
+class FacetResultsExtra(Extra):
+    description = "Results of facets calculated against this data"
+    scopes = frozenset({ExtraScope.TABLE})
+    expensive = True
+
+    async def resolve(self, context, facet_instances):
+        facet_results = {}
+        facets_timed_out = []
+
+        if not context.nofacet:
+            facet_awaitables = [facet.facet_results() for facet in facet_instances]
+            facet_awaitable_results = await context.run_sequential(*facet_awaitables)
+            for (
+                instance_facet_results,
+                instance_facets_timed_out,
+            ) in facet_awaitable_results:
+                for facet_info in instance_facet_results:
+                    base_key = facet_info["name"]
+                    key = base_key
+                    i = 1
+                    while key in facet_results:
+                        i += 1
+                        key = f"{base_key}_{i}"
+                    facet_results[key] = facet_info
+                facets_timed_out.extend(instance_facets_timed_out)
+
+        return {
+            "results": facet_results,
+            "timed_out": facets_timed_out,
+        }
+
+
+class FacetsTimedOutExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context, facet_results):
+        return facet_results["timed_out"]
+
+
+class SuggestedFacetsExtra(Extra):
+    description = "Suggestions for facets that might return interesting results"
+    scopes = frozenset({ExtraScope.TABLE})
+    expensive = True
+
+    async def resolve(self, context, facet_instances):
+        suggested_facets = []
+        if (
+            context.datasette.setting("suggest_facets")
+            and context.datasette.setting("allow_facet")
+            and not context.next_arg
+            and not context.nofacet
+            and not context.nosuggest
+        ):
+            facet_suggest_awaitables = [facet.suggest() for facet in facet_instances]
+            for suggest_result in await context.run_sequential(
+                *facet_suggest_awaitables
+            ):
+                suggested_facets.extend(suggest_result)
+        return suggested_facets
+
+
+class HumanDescriptionEnExtra(Extra):
+    description = "Human-readable description of the filters"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        human_description_en = context.filters.human_description_en(
+            extra=context.extra_human_descriptions
+        )
+        if context.sort or context.sort_desc:
+            sorted_by = "sorted by {}{}".format(
+                (context.sort or context.sort_desc),
+                " descending" if context.sort_desc else "",
+            )
+            human_description_en = " ".join(
+                [b for b in [human_description_en, sorted_by] if b]
+            )
+        return human_description_en
+
+
+class NextUrlExtra(Extra):
+    description = "Full URL for the next page of results"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.next_url
+
+
+class ColumnsExtra(Extra):
+    description = "Column names returned by this query"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.columns
+
+
+class AllColumnsExtra(Extra):
+    description = "All columns in the table, regardless of _col/_nocol filtering"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return list(context.table_columns)
+
+
+class PrimaryKeysExtra(Extra):
+    description = "Primary keys for this table"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.pks
+
+
+class ActionsExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        async def actions():
+            links = []
+            kwargs = {
+                "datasette": context.datasette,
+                "database": context.database_name,
+                "actor": context.request.actor,
+                "request": context.request,
+            }
+            if context.is_view:
+                kwargs["view"] = context.table_name
+                method = pm.hook.view_actions
+            else:
+                kwargs["table"] = context.table_name
+                method = pm.hook.table_actions
+            for hook in method(**kwargs):
+                extra_links = await await_me_maybe(hook)
+                if extra_links:
+                    links.extend(extra_links)
+            return links
+
+        return actions
+
+
+class IsViewExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.is_view
+
+
+class DebugExtra(Extra):
+    description = "Extra debug information"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return {
+            "resolved": repr(context.resolved),
+            "url_vars": context.request.url_vars,
+            "nofacet": context.nofacet,
+            "nosuggest": context.nosuggest,
+        }
+
+
+class RequestExtra(Extra):
+    description = "Full information about the request"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return {
+            "url": context.request.url,
+            "path": context.request.path,
+            "full_path": context.request.full_path,
+            "host": context.request.host,
+            "args": context.request.args._data,
+        }
+
+
+class DisplayColumnsAndRowsProvider(Provider):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        display_columns, display_rows = await context.display_columns_and_rows(
+            context.datasette,
+            context.database_name,
+            context.table_name,
+            context.results_description,
+            context.rows,
+            link_column=not context.is_view,
+            truncate_cells=context.datasette.setting("truncate_cells_html"),
+            sortable_columns=context.sortable_columns,
+            request=context.request,
+        )
+        return {
+            "columns": display_columns,
+            "rows": display_rows,
+        }
+
+
+class DisplayColumnsExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context, display_columns_and_rows):
+        return display_columns_and_rows["columns"]
+
+
+class DisplayRowsExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context, display_columns_and_rows):
+        return display_columns_and_rows["rows"]
+
+
+class RenderCellExtra(Extra):
+    description = "Rendered HTML for each cell using the render_cell plugin hook"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        pks_for_display = (
+            context.pks if context.pks else (["rowid"] if not context.is_view else [])
+        )
+        col_names = [col[0] for col in context.results_description]
+        ct_map = await context.datasette.get_column_types(
+            context.database_name, context.table_name
+        )
+        rendered_rows = []
+        for row in context.rows:
+            rendered_row = {}
+            for value, column in zip(row, col_names):
+                ct = ct_map.get(column)
+                plugin_display_value = None
+                if ct:
+                    candidate = await ct.render_cell(
+                        value=value,
+                        column=column,
+                        table=context.table_name,
+                        database=context.database_name,
+                        datasette=context.datasette,
+                        request=context.request,
+                    )
+                    if candidate is not None:
+                        plugin_display_value = candidate
+                if plugin_display_value is None:
+                    for candidate in pm.hook.render_cell(
+                        row=row,
+                        value=value,
+                        column=column,
+                        table=context.table_name,
+                        pks=pks_for_display,
+                        database=context.database_name,
+                        datasette=context.datasette,
+                        request=context.request,
+                        column_type=ct,
+                    ):
+                        candidate = await await_me_maybe(candidate)
+                        if candidate is not None:
+                            plugin_display_value = candidate
+                            break
+                if plugin_display_value:
+                    rendered_row[column] = str(plugin_display_value)
+            rendered_rows.append(rendered_row)
+        return rendered_rows
+
+
+class QueryExtra(Extra):
+    description = "Details of the underlying SQL query"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return {
+            "sql": context.sql,
+            "params": context.params,
+        }
+
+
+class ColumnTypesExtra(Extra):
+    description = "Column type assignments for this table"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        ct_map = await context.datasette.get_column_types(
+            context.database_name, context.table_name
+        )
+        return {
+            col_name: {
+                "type": ct.name,
+                "config": ct.config,
+            }
+            for col_name, ct in ct_map.items()
+        }
+
+
+class SetColumnTypeUiExtra(Extra):
+    description = "Column type UI metadata for this table"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        if context.is_view:
+            return None
+
+        if not await context.datasette.allowed(
+            action="set-column-type",
+            resource=TableResource(
+                database=context.database_name, table=context.table_name
+            ),
+            actor=context.request.actor,
+        ):
+            return None
+
+        column_details = await context.datasette._get_resource_column_details(
+            context.database_name, context.table_name
+        )
+        ct_map = await context.datasette.get_column_types(
+            context.database_name, context.table_name
+        )
+        columns = {}
+        for column_name, column_detail in column_details.items():
+            current = ct_map.get(column_name)
+            columns[column_name] = {
+                "current": (
+                    {"type": current.name, "config": current.config}
+                    if current is not None
+                    else None
+                ),
+                "options": [
+                    {
+                        "name": name,
+                        "description": ct_cls.description,
+                    }
+                    for name, ct_cls in sorted(context.datasette._column_types.items())
+                    if context.datasette._column_type_is_applicable(
+                        ct_cls, column_detail
+                    )
+                ],
+            }
+        return {
+            "path": "{}/-/set-column-type".format(
+                context.datasette.urls.table(context.database_name, context.table_name)
+            ),
+            "columns": columns,
+        }
+
+
+class MetadataExtra(Extra):
+    description = "Metadata about the table and database"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        tablemetadata = await context.datasette.get_resource_metadata(
+            context.database_name, context.table_name
+        )
+
+        rows = await context.datasette.get_internal_database().execute(
+            """
+              SELECT
+                column_name,
+                value
+              FROM metadata_columns
+              WHERE database_name = ?
+                AND resource_name = ?
+                AND key = 'description'
+            """,
+            [context.database_name, context.table_name],
+        )
+        tablemetadata["columns"] = dict(rows)
+        return tablemetadata
+
+
+class DatabaseExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.database_name
+
+
+class TableExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.table_name
+
+
+class DatabaseColorExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.db.color
+
+
+class FormHiddenArgsExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        form_hidden_args = []
+        for key in context.request.args:
+            if (
+                key.startswith("_")
+                and key not in ("_sort", "_sort_desc", "_search", "_next")
+                and "__" not in key
+            ):
+                for value in context.request.args.getlist(key):
+                    form_hidden_args.append((key, value))
+        return form_hidden_args
+
+
+class FiltersExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.filters
+
+
+class CustomTableTemplatesExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return [
+            f"_table-{to_css_class(context.database_name)}-{to_css_class(context.table_name)}.html",
+            f"_table-table-{to_css_class(context.database_name)}-{to_css_class(context.table_name)}.html",
+            "_table.html",
+        ]
+
+
+class SortedFacetResultsExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context, facet_results):
+        facet_configs = context.table_metadata.get("facets", [])
+        if facet_configs:
+            metadata_facet_names = []
+            for fc in facet_configs:
+                if isinstance(fc, str):
+                    metadata_facet_names.append(fc)
+                elif isinstance(fc, dict):
+                    metadata_facet_names.append(list(fc.values())[0])
+            metadata_order = {name: i for i, name in enumerate(metadata_facet_names)}
+            metadata_facets = []
+            request_facets = []
+            for f in facet_results["results"].values():
+                if f["name"] in metadata_order:
+                    metadata_facets.append(f)
+                else:
+                    request_facets.append(f)
+            metadata_facets.sort(key=lambda f: metadata_order[f["name"]])
+            request_facets.sort(
+                key=lambda f: (len(f["results"]), f["name"]),
+                reverse=True,
+            )
+            return metadata_facets + request_facets
+        else:
+            return sorted(
+                facet_results["results"].values(),
+                key=lambda f: (len(f["results"]), f["name"]),
+                reverse=True,
+            )
+
+
+class TableDefinitionExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return await context.db.get_table_definition(context.table_name)
+
+
+class ViewDefinitionExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return await context.db.get_view_definition(context.table_name)
+
+
+class RenderersExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context, expandable_columns, query):
+        renderers = {}
+        url_labels_extra = {}
+        if expandable_columns:
+            url_labels_extra = {"_labels": "on"}
+        for key, (_, can_render) in context.datasette.renderers.items():
+            it_can_render = call_with_supported_arguments(
+                can_render,
+                datasette=context.datasette,
+                columns=context.columns or [],
+                rows=context.rows or [],
+                sql=query.get("sql", None),
+                query_name=None,
+                database=context.database_name,
+                table=context.table_name,
+                request=context.request,
+                view_name="table",
+            )
+            it_can_render = await await_me_maybe(it_can_render)
+            if it_can_render:
+                renderers[key] = context.datasette.urls.path(
+                    path_with_format(
+                        request=context.request,
+                        path=context.request.scope.get("route_path"),
+                        format=key,
+                        extra_qs={**url_labels_extra},
+                    )
+                )
+        return renderers
+
+
+class PrivateExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        return context.private
+
+
+class ExpandableColumnsExtra(Extra):
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        expandables = []
+        db = context.datasette.databases[context.database_name]
+        for fk in await db.foreign_keys_for_table(context.table_name):
+            label_column = await db.label_column_for_table(fk["other_table"])
+            expandables.append((fk, label_column))
+        return expandables
+
+
+class ExtrasExtra(Extra):
+    description = "Available ?_extra= blocks"
+    scopes = frozenset({ExtraScope.TABLE})
+
+    async def resolve(self, context):
+        all_extras = [
+            (cls.key(), cls.description)
+            for cls in context.extra_registry.public_classes_for_scope(ExtraScope.TABLE)
+        ]
+        return [
+            {
+                "name": name,
+                "description": description,
+                "toggle_url": context.datasette.absolute_url(
+                    context.request,
+                    context.datasette.urls.path(
+                        path_with_added_args(context.request, {"_extra": name})
+                        if name not in context.extras
+                        else path_with_removed_args(context.request, {"_extra": name})
+                    ),
+                ),
+                "selected": name in context.extras,
+            }
+            for name, description in all_extras
+        ]
+
+
+TABLE_EXTRA_BUNDLES = {
+    "html": [
+        "suggested_facets",
+        "facet_results",
+        "facets_timed_out",
+        "count",
+        "count_sql",
+        "human_description_en",
+        "next_url",
+        "metadata",
+        "query",
+        "columns",
+        "display_columns",
+        "display_rows",
+        "database",
+        "table",
+        "database_color",
+        "actions",
+        "filters",
+        "renderers",
+        "custom_table_templates",
+        "sorted_facet_results",
+        "table_definition",
+        "view_definition",
+        "is_view",
+        "private",
+        "primary_keys",
+        "all_columns",
+        "expandable_columns",
+        "form_hidden_args",
+        "set_column_type_ui",
+    ]
+}
+
+
+TABLE_EXTRA_CLASSES = [
+    CountExtra,
+    CountSqlExtra,
+    FacetResultsExtra,
+    FacetsTimedOutExtra,
+    SuggestedFacetsExtra,
+    FacetInstancesProvider,
+    HumanDescriptionEnExtra,
+    NextUrlExtra,
+    ColumnsExtra,
+    AllColumnsExtra,
+    PrimaryKeysExtra,
+    DisplayColumnsAndRowsProvider,
+    DisplayColumnsExtra,
+    DisplayRowsExtra,
+    RenderCellExtra,
+    DebugExtra,
+    RequestExtra,
+    QueryExtra,
+    ColumnTypesExtra,
+    SetColumnTypeUiExtra,
+    MetadataExtra,
+    ExtrasExtra,
+    DatabaseExtra,
+    TableExtra,
+    DatabaseColorExtra,
+    ActionsExtra,
+    FiltersExtra,
+    RenderersExtra,
+    CustomTableTemplatesExtra,
+    SortedFacetResultsExtra,
+    TableDefinitionExtra,
+    ViewDefinitionExtra,
+    IsViewExtra,
+    PrivateExtra,
+    ExpandableColumnsExtra,
+    FormHiddenArgsExtra,
+]
+
+
+table_extra_registry = ExtraRegistry(TABLE_EXTRA_CLASSES)
+
+
+async def resolve_table_extras(extras, context):
+    return await table_extra_registry.resolve(extras, context, ExtraScope.TABLE)

From 111eeaf3702cd5ee417532beb80c746d49d92a11 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 8 Jun 2026 20:56:00 -0700
Subject: [PATCH 145/386] Document table JSON extras from metadata

---
 datasette/views/table_extras.py | 18 +++++++
 docs/json_api.rst               | 95 +++++++++++++++++++++++++++++++++
 docs/json_api_doc.py            | 20 +++++++
 3 files changed, 133 insertions(+)
 create mode 100644 docs/json_api_doc.py

diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index 2ec2adf0..e71c15d6 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -55,6 +55,7 @@ class TableExtraContext:
 
 
 class CountSqlExtra(Extra):
+    description = "SQL query used to calculate the total count"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -151,6 +152,7 @@ class FacetResultsExtra(Extra):
 
 
 class FacetsTimedOutExtra(Extra):
+    description = "Facet calculations that timed out"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, facet_results):
@@ -231,6 +233,7 @@ class PrimaryKeysExtra(Extra):
 
 
 class ActionsExtra(Extra):
+    description = "Table or view actions made available by plugin hooks"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -258,6 +261,7 @@ class ActionsExtra(Extra):
 
 
 class IsViewExtra(Extra):
+    description = "Whether this resource is a view instead of a table"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -313,6 +317,7 @@ class DisplayColumnsAndRowsProvider(Provider):
 
 
 class DisplayColumnsExtra(Extra):
+    description = "Column metadata used by the HTML table display"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, display_columns_and_rows):
@@ -320,6 +325,7 @@ class DisplayColumnsExtra(Extra):
 
 
 class DisplayRowsExtra(Extra):
+    description = "Row data formatted for the HTML table display"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, display_columns_and_rows):
@@ -482,6 +488,7 @@ class MetadataExtra(Extra):
 
 
 class DatabaseExtra(Extra):
+    description = "Database name"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -489,6 +496,7 @@ class DatabaseExtra(Extra):
 
 
 class TableExtra(Extra):
+    description = "Table name"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -496,6 +504,7 @@ class TableExtra(Extra):
 
 
 class DatabaseColorExtra(Extra):
+    description = "Color assigned to the database"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -503,6 +512,7 @@ class DatabaseColorExtra(Extra):
 
 
 class FormHiddenArgsExtra(Extra):
+    description = "Hidden form arguments used by the HTML table interface"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -519,6 +529,7 @@ class FormHiddenArgsExtra(Extra):
 
 
 class FiltersExtra(Extra):
+    description = "Filters object used by the HTML table interface"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -526,6 +537,7 @@ class FiltersExtra(Extra):
 
 
 class CustomTableTemplatesExtra(Extra):
+    description = "Custom template names considered for this table"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -537,6 +549,7 @@ class CustomTableTemplatesExtra(Extra):
 
 
 class SortedFacetResultsExtra(Extra):
+    description = "Facet results sorted for display"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, facet_results):
@@ -571,6 +584,7 @@ class SortedFacetResultsExtra(Extra):
 
 
 class TableDefinitionExtra(Extra):
+    description = "SQL definition for this table"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -578,6 +592,7 @@ class TableDefinitionExtra(Extra):
 
 
 class ViewDefinitionExtra(Extra):
+    description = "SQL definition for this view"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -585,6 +600,7 @@ class ViewDefinitionExtra(Extra):
 
 
 class RenderersExtra(Extra):
+    description = "Alternative output renderers available for this table"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, expandable_columns, query):
@@ -619,6 +635,7 @@ class RenderersExtra(Extra):
 
 
 class PrivateExtra(Extra):
+    description = "Whether this table is private to the current actor"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -626,6 +643,7 @@ class PrivateExtra(Extra):
 
 
 class ExpandableColumnsExtra(Extra):
+    description = "Foreign key columns that can be expanded with labels"
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 65031bf4..af60a527 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -235,6 +235,101 @@ query string arguments:
 
     Only available if the :ref:`setting_trace_debug` setting is enabled.
 
+.. _json_api_extra:
+
+Expanding table JSON responses
+------------------------------
+
+Table JSON responses can be expanded with one or more ``?_extra=`` parameters.
+These can be repeated or comma-separated:
+
+::
+
+    ?_extra=columns&_extra=count,next_url
+
+The available table extras are listed below.
+
+.. [[[cog
+    from json_api_doc import table_extras
+    table_extras(cog)
+.. ]]]
+
+.. list-table::
+   :header-rows: 1
+
+   * - Extra
+     - Description
+   * - ``count``
+     - Total count of rows matching these filters (May execute additional queries.)
+   * - ``count_sql``
+     - SQL query used to calculate the total count
+   * - ``facet_results``
+     - Results of facets calculated against this data (May execute additional queries.)
+   * - ``facets_timed_out``
+     - Facet calculations that timed out
+   * - ``suggested_facets``
+     - Suggestions for facets that might return interesting results (May execute additional queries.)
+   * - ``human_description_en``
+     - Human-readable description of the filters
+   * - ``next_url``
+     - Full URL for the next page of results
+   * - ``columns``
+     - Column names returned by this query
+   * - ``all_columns``
+     - All columns in the table, regardless of _col/_nocol filtering
+   * - ``primary_keys``
+     - Primary keys for this table
+   * - ``display_columns``
+     - Column metadata used by the HTML table display
+   * - ``display_rows``
+     - Row data formatted for the HTML table display
+   * - ``render_cell``
+     - Rendered HTML for each cell using the render_cell plugin hook
+   * - ``debug``
+     - Extra debug information
+   * - ``request``
+     - Full information about the request
+   * - ``query``
+     - Details of the underlying SQL query
+   * - ``column_types``
+     - Column type assignments for this table
+   * - ``set_column_type_ui``
+     - Column type UI metadata for this table
+   * - ``metadata``
+     - Metadata about the table and database
+   * - ``extras``
+     - Available ?_extra= blocks
+   * - ``database``
+     - Database name
+   * - ``table``
+     - Table name
+   * - ``database_color``
+     - Color assigned to the database
+   * - ``actions``
+     - Table or view actions made available by plugin hooks
+   * - ``filters``
+     - Filters object used by the HTML table interface
+   * - ``renderers``
+     - Alternative output renderers available for this table
+   * - ``custom_table_templates``
+     - Custom template names considered for this table
+   * - ``sorted_facet_results``
+     - Facet results sorted for display
+   * - ``table_definition``
+     - SQL definition for this table
+   * - ``view_definition``
+     - SQL definition for this view
+   * - ``is_view``
+     - Whether this resource is a view instead of a table
+   * - ``private``
+     - Whether this table is private to the current actor
+   * - ``expandable_columns``
+     - Foreign key columns that can be expanded with labels
+   * - ``form_hidden_args``
+     - Hidden form arguments used by the HTML table interface
+
+.. [[[end]]]
+
 .. _table_arguments:
 
 Table arguments
diff --git a/docs/json_api_doc.py b/docs/json_api_doc.py
new file mode 100644
index 00000000..f07c3ba7
--- /dev/null
+++ b/docs/json_api_doc.py
@@ -0,0 +1,20 @@
+def table_extras(cog):
+    from datasette.extras import ExtraScope
+    from datasette.views.table_extras import table_extra_registry
+
+    cog.out("\n.. list-table::\n")
+    cog.out("   :header-rows: 1\n\n")
+    cog.out("   * - Extra\n")
+    cog.out("     - Description\n")
+    for cls in table_extra_registry.public_classes_for_scope(ExtraScope.TABLE):
+        description = cls.description or ""
+        notes = []
+        if cls.expensive:
+            notes.append("May execute additional queries.")
+        if cls.docs_note:
+            notes.append(cls.docs_note)
+        if notes:
+            description = "{} ({})".format(description, " ".join(notes)).strip()
+        cog.out("   * - ``{}``\n".format(cls.key()))
+        cog.out("     - {}\n".format(description))
+    cog.out("\n")

From 79c8aff31df16e514616a7778fad1386ac9b4b2c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 8 Jun 2026 21:10:58 -0700
Subject: [PATCH 146/386] Add generated examples for table JSON extras

---
 datasette/extras.py             |  11 +
 datasette/views/table_extras.py |  87 +++++-
 docs/json_api.rst               | 470 +++++++++++++++++++++++++++-----
 docs/json_api_doc.py            |  64 ++++-
 tests/test_docs.py              |  10 +
 5 files changed, 561 insertions(+), 81 deletions(-)

diff --git a/datasette/extras.py b/datasette/extras.py
index 786ec4f4..d867f26c 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -1,4 +1,5 @@
 import re
+from dataclasses import dataclass
 from enum import Enum
 from typing import ClassVar
 
@@ -17,6 +18,14 @@ class ExtraScope(Enum):
     TABLE = "table"
 
 
+@dataclass(frozen=True)
+class ExtraExample:
+    path: str | None = None
+    key: str | None = None
+    value: object | None = None
+    note: str | None = None
+
+
 class Provider:
     name: ClassVar[str | None] = None
     scopes: ClassVar[frozenset[ExtraScope]] = frozenset()
@@ -36,6 +45,7 @@ class Provider:
 
 class Extra(Provider):
     description: ClassVar[str | None] = None
+    example: ClassVar[ExtraExample | None] = None
     public: ClassVar[bool] = True
     stable: ClassVar[bool] = True
     expensive: ClassVar[bool] = False
@@ -52,6 +62,7 @@ class Extra(Provider):
             "stable": cls.stable,
             "expensive": cls.expensive,
             "docs_note": cls.docs_note,
+            "example": cls.example,
         }
 
 
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index e71c15d6..0eefeaa9 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -2,7 +2,7 @@ import itertools
 from dataclasses import dataclass
 
 from datasette.database import QueryInterrupted
-from datasette.extras import Extra, ExtraRegistry, ExtraScope, Provider
+from datasette.extras import Extra, ExtraExample, ExtraRegistry, ExtraScope, Provider
 from datasette.plugins import pm
 from datasette.resources import TableResource
 from datasette.utils import (
@@ -56,6 +56,7 @@ class TableExtraContext:
 
 class CountSqlExtra(Extra):
     description = "SQL query used to calculate the total count"
+    example = ExtraExample("/fixtures/facetable.json?_size=0&_extra=count_sql")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -64,6 +65,7 @@ class CountSqlExtra(Extra):
 
 class CountExtra(Extra):
     description = "Total count of rows matching these filters"
+    example = ExtraExample("/fixtures/facetable.json?_extra=count")
     scopes = frozenset({ExtraScope.TABLE})
     expensive = True
 
@@ -121,6 +123,22 @@ class FacetInstancesProvider(Provider):
 
 class FacetResultsExtra(Extra):
     description = "Results of facets calculated against this data"
+    example = ExtraExample(
+        value={
+            "results": {
+                "state": {
+                    "name": "state",
+                    "type": "column",
+                    "results": [
+                        {"value": "CA", "label": "CA", "count": 10},
+                        {"value": "MI", "label": "MI", "count": 4},
+                    ],
+                }
+            },
+            "timed_out": [],
+        },
+        note="Shape abbreviated from /fixtures/facetable.json?_facet=state&_extra=facet_results.",
+    )
     scopes = frozenset({ExtraScope.TABLE})
     expensive = True
 
@@ -153,6 +171,9 @@ class FacetResultsExtra(Extra):
 
 class FacetsTimedOutExtra(Extra):
     description = "Facet calculations that timed out"
+    example = ExtraExample(
+        "/fixtures/facetable.json?_facet=state&_extra=facets_timed_out"
+    )
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, facet_results):
@@ -161,6 +182,15 @@ class FacetsTimedOutExtra(Extra):
 
 class SuggestedFacetsExtra(Extra):
     description = "Suggestions for facets that might return interesting results"
+    example = ExtraExample(
+        value=[
+            {
+                "name": "state",
+                "toggle_url": "http://localhost/fixtures/facetable.json?_extra=suggested_facets&_facet=state",
+            }
+        ],
+        note="Shape abbreviated from /fixtures/facetable.json?_extra=suggested_facets.",
+    )
     scopes = frozenset({ExtraScope.TABLE})
     expensive = True
 
@@ -183,6 +213,9 @@ class SuggestedFacetsExtra(Extra):
 
 class HumanDescriptionEnExtra(Extra):
     description = "Human-readable description of the filters"
+    example = ExtraExample(
+        "/fixtures/facetable.json?state=CA&_sort=pk&_extra=human_description_en"
+    )
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -202,6 +235,7 @@ class HumanDescriptionEnExtra(Extra):
 
 class NextUrlExtra(Extra):
     description = "Full URL for the next page of results"
+    example = ExtraExample("/fixtures/facetable.json?_size=1&_extra=next_url")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -210,6 +244,7 @@ class NextUrlExtra(Extra):
 
 class ColumnsExtra(Extra):
     description = "Column names returned by this query"
+    example = ExtraExample("/fixtures/facetable.json?_extra=columns")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -218,6 +253,7 @@ class ColumnsExtra(Extra):
 
 class AllColumnsExtra(Extra):
     description = "All columns in the table, regardless of _col/_nocol filtering"
+    example = ExtraExample("/fixtures/facetable.json?_col=pk&_extra=all_columns")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -226,6 +262,7 @@ class AllColumnsExtra(Extra):
 
 class PrimaryKeysExtra(Extra):
     description = "Primary keys for this table"
+    example = ExtraExample("/fixtures/facetable.json?_extra=primary_keys")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -262,6 +299,7 @@ class ActionsExtra(Extra):
 
 class IsViewExtra(Extra):
     description = "Whether this resource is a view instead of a table"
+    example = ExtraExample("/fixtures/simple_view.json?_extra=is_view")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -318,6 +356,28 @@ class DisplayColumnsAndRowsProvider(Provider):
 
 class DisplayColumnsExtra(Extra):
     description = "Column metadata used by the HTML table display"
+    example = ExtraExample(
+        value=[
+            {
+                "name": "pk",
+                "sortable": True,
+                "is_pk": True,
+                "type": "INTEGER",
+                "notnull": 0,
+            },
+            {
+                "name": "created",
+                "sortable": True,
+                "is_pk": False,
+                "type": "TEXT",
+                "notnull": 0,
+                "description": None,
+                "column_type": None,
+                "column_type_config": None,
+            },
+        ],
+        note="Shape abbreviated from /fixtures/facetable.json?_size=1&_extra=display_columns.",
+    )
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, display_columns_and_rows):
@@ -334,6 +394,13 @@ class DisplayRowsExtra(Extra):
 
 class RenderCellExtra(Extra):
     description = "Rendered HTML for each cell using the render_cell plugin hook"
+    example = ExtraExample(
+        value=[
+            {},
+            {"content": "<strong>Custom rendered HTML</strong>"},
+        ],
+        note="Only columns whose rendered value differs from the default are included.",
+    )
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -385,6 +452,7 @@ class RenderCellExtra(Extra):
 
 class QueryExtra(Extra):
     description = "Details of the underlying SQL query"
+    example = ExtraExample("/fixtures/facetable.json?_size=1&_extra=query")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -396,6 +464,7 @@ class QueryExtra(Extra):
 
 class ColumnTypesExtra(Extra):
     description = "Column type assignments for this table"
+    example = ExtraExample(value={})
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -464,6 +533,7 @@ class SetColumnTypeUiExtra(Extra):
 
 class MetadataExtra(Extra):
     description = "Metadata about the table and database"
+    example = ExtraExample("/fixtures/facetable.json?_extra=metadata")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -489,6 +559,7 @@ class MetadataExtra(Extra):
 
 class DatabaseExtra(Extra):
     description = "Database name"
+    example = ExtraExample("/fixtures/facetable.json?_extra=database")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -497,6 +568,7 @@ class DatabaseExtra(Extra):
 
 class TableExtra(Extra):
     description = "Table name"
+    example = ExtraExample("/fixtures/facetable.json?_extra=table")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -505,6 +577,7 @@ class TableExtra(Extra):
 
 class DatabaseColorExtra(Extra):
     description = "Color assigned to the database"
+    example = ExtraExample("/fixtures/facetable.json?_extra=database_color")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -513,6 +586,9 @@ class DatabaseColorExtra(Extra):
 
 class FormHiddenArgsExtra(Extra):
     description = "Hidden form arguments used by the HTML table interface"
+    example = ExtraExample(
+        "/fixtures/facetable.json?_facet=state&_size=1&_extra=form_hidden_args"
+    )
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -538,6 +614,7 @@ class FiltersExtra(Extra):
 
 class CustomTableTemplatesExtra(Extra):
     description = "Custom template names considered for this table"
+    example = ExtraExample("/fixtures/facetable.json?_extra=custom_table_templates")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -550,6 +627,9 @@ class CustomTableTemplatesExtra(Extra):
 
 class SortedFacetResultsExtra(Extra):
     description = "Facet results sorted for display"
+    example = ExtraExample(
+        "/fixtures/facetable.json?_facet=state&_extra=sorted_facet_results"
+    )
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, facet_results):
@@ -585,6 +665,7 @@ class SortedFacetResultsExtra(Extra):
 
 class TableDefinitionExtra(Extra):
     description = "SQL definition for this table"
+    example = ExtraExample("/fixtures/facetable.json?_extra=table_definition")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -593,6 +674,7 @@ class TableDefinitionExtra(Extra):
 
 class ViewDefinitionExtra(Extra):
     description = "SQL definition for this view"
+    example = ExtraExample("/fixtures/simple_view.json?_extra=view_definition")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -601,6 +683,7 @@ class ViewDefinitionExtra(Extra):
 
 class RenderersExtra(Extra):
     description = "Alternative output renderers available for this table"
+    example = ExtraExample("/fixtures/facetable.json?_extra=renderers")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context, expandable_columns, query):
@@ -636,6 +719,7 @@ class RenderersExtra(Extra):
 
 class PrivateExtra(Extra):
     description = "Whether this table is private to the current actor"
+    example = ExtraExample("/fixtures/facetable.json?_extra=private")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -644,6 +728,7 @@ class PrivateExtra(Extra):
 
 class ExpandableColumnsExtra(Extra):
     description = "Foreign key columns that can be expanded with labels"
+    example = ExtraExample("/fixtures/facetable.json?_extra=expandable_columns")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
diff --git a/docs/json_api.rst b/docs/json_api.rst
index af60a527..d12a388e 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -254,79 +254,405 @@ The available table extras are listed below.
     table_extras(cog)
 .. ]]]
 
-.. list-table::
-   :header-rows: 1
+``count``
+    Total count of rows matching these filters (May execute additional queries.)
 
-   * - Extra
-     - Description
-   * - ``count``
-     - Total count of rows matching these filters (May execute additional queries.)
-   * - ``count_sql``
-     - SQL query used to calculate the total count
-   * - ``facet_results``
-     - Results of facets calculated against this data (May execute additional queries.)
-   * - ``facets_timed_out``
-     - Facet calculations that timed out
-   * - ``suggested_facets``
-     - Suggestions for facets that might return interesting results (May execute additional queries.)
-   * - ``human_description_en``
-     - Human-readable description of the filters
-   * - ``next_url``
-     - Full URL for the next page of results
-   * - ``columns``
-     - Column names returned by this query
-   * - ``all_columns``
-     - All columns in the table, regardless of _col/_nocol filtering
-   * - ``primary_keys``
-     - Primary keys for this table
-   * - ``display_columns``
-     - Column metadata used by the HTML table display
-   * - ``display_rows``
-     - Row data formatted for the HTML table display
-   * - ``render_cell``
-     - Rendered HTML for each cell using the render_cell plugin hook
-   * - ``debug``
-     - Extra debug information
-   * - ``request``
-     - Full information about the request
-   * - ``query``
-     - Details of the underlying SQL query
-   * - ``column_types``
-     - Column type assignments for this table
-   * - ``set_column_type_ui``
-     - Column type UI metadata for this table
-   * - ``metadata``
-     - Metadata about the table and database
-   * - ``extras``
-     - Available ?_extra= blocks
-   * - ``database``
-     - Database name
-   * - ``table``
-     - Table name
-   * - ``database_color``
-     - Color assigned to the database
-   * - ``actions``
-     - Table or view actions made available by plugin hooks
-   * - ``filters``
-     - Filters object used by the HTML table interface
-   * - ``renderers``
-     - Alternative output renderers available for this table
-   * - ``custom_table_templates``
-     - Custom template names considered for this table
-   * - ``sorted_facet_results``
-     - Facet results sorted for display
-   * - ``table_definition``
-     - SQL definition for this table
-   * - ``view_definition``
-     - SQL definition for this view
-   * - ``is_view``
-     - Whether this resource is a view instead of a table
-   * - ``private``
-     - Whether this table is private to the current actor
-   * - ``expandable_columns``
-     - Foreign key columns that can be expanded with labels
-   * - ``form_hidden_args``
-     - Hidden form arguments used by the HTML table interface
+    ``GET /fixtures/facetable.json?_extra=count``
+
+    .. code-block:: json
+
+        15
+
+``count_sql``
+    SQL query used to calculate the total count
+
+    ``GET /fixtures/facetable.json?_size=0&_extra=count_sql``
+
+    .. code-block:: json
+
+        "select count(*) from facetable "
+
+``facet_results``
+    Results of facets calculated against this data (May execute additional queries.)
+
+    Shape abbreviated from /fixtures/facetable.json?_facet=state&_extra=facet_results.
+
+    .. code-block:: json
+
+        {
+          "results": {
+            "state": {
+              "name": "state",
+              "type": "column",
+              "results": [
+                {
+                  "value": "CA",
+                  "label": "CA",
+                  "count": 10
+                },
+                {
+                  "value": "MI",
+                  "label": "MI",
+                  "count": 4
+                }
+              ]
+            }
+          },
+          "timed_out": []
+        }
+
+``facets_timed_out``
+    Facet calculations that timed out
+
+    ``GET /fixtures/facetable.json?_facet=state&_extra=facets_timed_out``
+
+    .. code-block:: json
+
+        []
+
+``suggested_facets``
+    Suggestions for facets that might return interesting results (May execute additional queries.)
+
+    Shape abbreviated from /fixtures/facetable.json?_extra=suggested_facets.
+
+    .. code-block:: json
+
+        [
+          {
+            "name": "state",
+            "toggle_url": "http://localhost/fixtures/facetable.json?_extra=suggested_facets&_facet=state"
+          }
+        ]
+
+``human_description_en``
+    Human-readable description of the filters
+
+    ``GET /fixtures/facetable.json?state=CA&_sort=pk&_extra=human_description_en``
+
+    .. code-block:: json
+
+        "where state = \"CA\" sorted by pk"
+
+``next_url``
+    Full URL for the next page of results
+
+    ``GET /fixtures/facetable.json?_size=1&_extra=next_url``
+
+    .. code-block:: json
+
+        "http://localhost/fixtures/facetable.json?_size=1&_extra=next_url&_next=1"
+
+``columns``
+    Column names returned by this query
+
+    ``GET /fixtures/facetable.json?_extra=columns``
+
+    .. code-block:: json
+
+        [
+          "pk",
+          "created",
+          "planet_int",
+          "on_earth",
+          "state",
+          "_city_id",
+          "_neighborhood",
+          "tags",
+          "complex_array",
+          "distinct_some_null",
+          "n"
+        ]
+
+``all_columns``
+    All columns in the table, regardless of _col/_nocol filtering
+
+    ``GET /fixtures/facetable.json?_col=pk&_extra=all_columns``
+
+    .. code-block:: json
+
+        [
+          "pk",
+          "created",
+          "planet_int",
+          "on_earth",
+          "state",
+          "_city_id",
+          "_neighborhood",
+          "tags",
+          "complex_array",
+          "distinct_some_null",
+          "n"
+        ]
+
+``primary_keys``
+    Primary keys for this table
+
+    ``GET /fixtures/facetable.json?_extra=primary_keys``
+
+    .. code-block:: json
+
+        [
+          "pk"
+        ]
+
+``display_columns``
+    Column metadata used by the HTML table display
+
+    Shape abbreviated from /fixtures/facetable.json?_size=1&_extra=display_columns.
+
+    .. code-block:: json
+
+        [
+          {
+            "name": "pk",
+            "sortable": true,
+            "is_pk": true,
+            "type": "INTEGER",
+            "notnull": 0
+          },
+          {
+            "name": "created",
+            "sortable": true,
+            "is_pk": false,
+            "type": "TEXT",
+            "notnull": 0,
+            "description": null,
+            "column_type": null,
+            "column_type_config": null
+          }
+        ]
+
+``display_rows``
+    Row data formatted for the HTML table display
+
+``render_cell``
+    Rendered HTML for each cell using the render_cell plugin hook
+
+    Only columns whose rendered value differs from the default are included.
+
+    .. code-block:: json
+
+        [
+          {},
+          {
+            "content": "<strong>Custom rendered HTML</strong>"
+          }
+        ]
+
+``debug``
+    Extra debug information
+
+``request``
+    Full information about the request
+
+``query``
+    Details of the underlying SQL query
+
+    ``GET /fixtures/facetable.json?_size=1&_extra=query``
+
+    .. code-block:: json
+
+        {
+          "sql": "select pk, created, planet_int, on_earth, state, _city_id, _neighborhood, tags, complex_array, distinct_some_null, n from facetable order by pk limit 2",
+          "params": {}
+        }
+
+``column_types``
+    Column type assignments for this table
+
+    .. code-block:: json
+
+        {}
+
+``set_column_type_ui``
+    Column type UI metadata for this table
+
+``metadata``
+    Metadata about the table and database
+
+    ``GET /fixtures/facetable.json?_extra=metadata``
+
+    .. code-block:: json
+
+        {
+          "columns": {}
+        }
+
+``extras``
+    Available ?_extra= blocks
+
+``database``
+    Database name
+
+    ``GET /fixtures/facetable.json?_extra=database``
+
+    .. code-block:: json
+
+        "fixtures"
+
+``table``
+    Table name
+
+    ``GET /fixtures/facetable.json?_extra=table``
+
+    .. code-block:: json
+
+        "facetable"
+
+``database_color``
+    Color assigned to the database
+
+    ``GET /fixtures/facetable.json?_extra=database_color``
+
+    .. code-block:: json
+
+        "9403e5"
+
+``actions``
+    Table or view actions made available by plugin hooks
+
+``filters``
+    Filters object used by the HTML table interface
+
+``renderers``
+    Alternative output renderers available for this table
+
+    ``GET /fixtures/facetable.json?_extra=renderers``
+
+    .. code-block:: json
+
+        {
+          "json": "/fixtures/facetable.json?_extra=renderers&_format=json&_labels=on"
+        }
+
+``custom_table_templates``
+    Custom template names considered for this table
+
+    ``GET /fixtures/facetable.json?_extra=custom_table_templates``
+
+    .. code-block:: json
+
+        [
+          "_table-fixtures-facetable.html",
+          "_table-table-fixtures-facetable.html",
+          "_table.html"
+        ]
+
+``sorted_facet_results``
+    Facet results sorted for display
+
+    ``GET /fixtures/facetable.json?_facet=state&_extra=sorted_facet_results``
+
+    .. code-block:: json
+
+        [
+          {
+            "name": "state",
+            "type": "column",
+            "hideable": true,
+            "toggle_url": "/fixtures/facetable.json?_extra=sorted_facet_results",
+            "results": [
+              {
+                "value": "CA",
+                "label": "CA",
+                "count": 10,
+                "toggle_url": "http://localhost/fixtures/facetable.json?_facet=state&_extra=sorted_facet_results&state=CA",
+                "selected": false
+              },
+              {
+                "value": "MI",
+                "label": "MI",
+                "count": 4,
+                "toggle_url": "http://localhost/fixtures/facetable.json?_facet=state&_extra=sorted_facet_results&state=MI",
+                "selected": false
+              },
+              {
+                "value": "MC",
+                "label": "MC",
+                "count": 1,
+                "toggle_url": "http://localhost/fixtures/facetable.json?_facet=state&_extra=sorted_facet_results&state=MC",
+                "selected": false
+              }
+            ],
+            "truncated": false
+          }
+        ]
+
+``table_definition``
+    SQL definition for this table
+
+    ``GET /fixtures/facetable.json?_extra=table_definition``
+
+    .. code-block:: json
+
+        "CREATE TABLE facetable (\n    pk integer primary key,\n    created text,\n    planet_int integer,\n    on_earth integer,\n    state text,\n    _city_id integer,\n    _neighborhood text,\n    tags text,\n    complex_array text,\n    distinct_some_null,\n    n text,\n    FOREIGN KEY (\"_city_id\") REFERENCES [facet_cities](id)\n);"
+
+``view_definition``
+    SQL definition for this view
+
+    ``GET /fixtures/simple_view.json?_extra=view_definition``
+
+    .. code-block:: json
+
+        "CREATE VIEW simple_view AS\n    SELECT content, upper(content) AS upper_content FROM simple_primary_key;"
+
+``is_view``
+    Whether this resource is a view instead of a table
+
+    ``GET /fixtures/simple_view.json?_extra=is_view``
+
+    .. code-block:: json
+
+        true
+
+``private``
+    Whether this table is private to the current actor
+
+    ``GET /fixtures/facetable.json?_extra=private``
+
+    .. code-block:: json
+
+        false
+
+``expandable_columns``
+    Foreign key columns that can be expanded with labels
+
+    ``GET /fixtures/facetable.json?_extra=expandable_columns``
+
+    .. code-block:: json
+
+        [
+          [
+            {
+              "column": "_city_id",
+              "other_table": "facet_cities",
+              "other_column": "id"
+            },
+            "name"
+          ]
+        ]
+
+``form_hidden_args``
+    Hidden form arguments used by the HTML table interface
+
+    ``GET /fixtures/facetable.json?_facet=state&_size=1&_extra=form_hidden_args``
+
+    .. code-block:: json
+
+        [
+          [
+            "_facet",
+            "state"
+          ],
+          [
+            "_size",
+            "1"
+          ],
+          [
+            "_extra",
+            "form_hidden_args"
+          ]
+        ]
 
 .. [[[end]]]
 
diff --git a/docs/json_api_doc.py b/docs/json_api_doc.py
index f07c3ba7..69ec6e5e 100644
--- a/docs/json_api_doc.py
+++ b/docs/json_api_doc.py
@@ -1,12 +1,20 @@
+import asyncio
+import json
+import pathlib
+import tempfile
+import textwrap
+
+
 def table_extras(cog):
     from datasette.extras import ExtraScope
     from datasette.views.table_extras import table_extra_registry
 
-    cog.out("\n.. list-table::\n")
-    cog.out("   :header-rows: 1\n\n")
-    cog.out("   * - Extra\n")
-    cog.out("     - Description\n")
-    for cls in table_extra_registry.public_classes_for_scope(ExtraScope.TABLE):
+    classes = table_extra_registry.public_classes_for_scope(ExtraScope.TABLE)
+
+    live_examples = asyncio.run(_fetch_live_examples(classes))
+    cog.out("\n")
+    for cls in classes:
+        example = cls.example
         description = cls.description or ""
         notes = []
         if cls.expensive:
@@ -15,6 +23,46 @@ def table_extras(cog):
             notes.append(cls.docs_note)
         if notes:
             description = "{} ({})".format(description, " ".join(notes)).strip()
-        cog.out("   * - ``{}``\n".format(cls.key()))
-        cog.out("     - {}\n".format(description))
-    cog.out("\n")
+
+        cog.out("``{}``\n".format(cls.key()))
+        cog.out("    {}\n\n".format(description))
+        if example is None:
+            continue
+
+        if example.path:
+            value = live_examples[(example.path, example.key or cls.key())]
+            cog.out("    ``GET {}``\n\n".format(example.path))
+        else:
+            value = example.value
+        if example.note:
+            cog.out("    {}\n\n".format(example.note))
+        cog.out("    .. code-block:: json\n\n")
+        cog.out(textwrap.indent(json.dumps(value, indent=2), "        "))
+        cog.out("\n\n")
+
+
+async def _fetch_live_examples(classes):
+    from datasette.app import Datasette
+    from datasette.fixtures import write_fixture_database
+
+    examples = {}
+    with tempfile.TemporaryDirectory() as tmpdir:
+        db_path = pathlib.Path(tmpdir) / "fixtures.db"
+        write_fixture_database(db_path)
+        datasette = Datasette([str(db_path)], settings={"num_sql_threads": 1})
+        try:
+            for cls in classes:
+                example = cls.example
+                if example is None or not example.path:
+                    continue
+                key = example.key or cls.key()
+                response = await datasette.client.get(example.path)
+                assert response.status_code == 200, example.path
+                data = response.json()
+                assert key in data, "{} missing from {}".format(key, example.path)
+                examples[(example.path, key)] = data[key]
+        finally:
+            for db in datasette.databases.values():
+                if not db.is_memory:
+                    db.close()
+    return examples
diff --git a/tests/test_docs.py b/tests/test_docs.py
index 51caf595..784755e9 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -112,6 +112,16 @@ def test_table_filters_are_documented(documented_table_filters, subtests):
             assert f.key in documented_table_filters
 
 
+def test_table_extra_examples_are_documented():
+    from datasette.views.table_extras import CountExtra
+
+    assert CountExtra.example.path == "/fixtures/facetable.json?_extra=count"
+    content = (docs_path / "json_api.rst").read_text()
+    section = content.split(".. _json_api_extra:")[-1].split(".. _table_arguments:")[0]
+    assert "GET /fixtures/facetable.json?_extra=count" in section
+    assert ".. code-block:: json" in section
+
+
 @pytest.fixture(scope="session")
 def documented_labels():
     labels = set()

From 22f80b819625b9f6b5aa0661f58d97c89882a932 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 8 Jun 2026 21:13:53 -0700
Subject: [PATCH 147/386] Clarify render_cell JSON extra example

---
 datasette/views/table_extras.py | 20 +++++++++++++++-----
 docs/json_api.rst               | 26 +++++++++++++++++++-------
 tests/test_docs.py              |  8 ++++++++
 3 files changed, 42 insertions(+), 12 deletions(-)

diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index 0eefeaa9..b6e653c4 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -395,11 +395,21 @@ class DisplayRowsExtra(Extra):
 class RenderCellExtra(Extra):
     description = "Rendered HTML for each cell using the render_cell plugin hook"
     example = ExtraExample(
-        value=[
-            {},
-            {"content": "<strong>Custom rendered HTML</strong>"},
-        ],
-        note="Only columns whose rendered value differs from the default are included.",
+        value={
+            "rows": [
+                {"id": 1, "content": "hello"},
+                {"id": 4, "content": "RENDER_CELL_DEMO"},
+            ],
+            "render_cell": [
+                {},
+                {"content": "<strong>Custom rendered HTML</strong>"},
+            ],
+        },
+        note=(
+            "The ``render_cell`` array has one item per row, in the same order as "
+            "the ``rows`` array. Each object is keyed by column name. Only columns "
+            "whose rendered value differs from the default are included."
+        ),
     )
     scopes = frozenset({ExtraScope.TABLE})
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index d12a388e..24d59577 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -428,16 +428,28 @@ The available table extras are listed below.
 ``render_cell``
     Rendered HTML for each cell using the render_cell plugin hook
 
-    Only columns whose rendered value differs from the default are included.
+    The ``render_cell`` array has one item per row, in the same order as the ``rows`` array. Each object is keyed by column name. Only columns whose rendered value differs from the default are included.
 
     .. code-block:: json
 
-        [
-          {},
-          {
-            "content": "<strong>Custom rendered HTML</strong>"
-          }
-        ]
+        {
+          "rows": [
+            {
+              "id": 1,
+              "content": "hello"
+            },
+            {
+              "id": 4,
+              "content": "RENDER_CELL_DEMO"
+            }
+          ],
+          "render_cell": [
+            {},
+            {
+              "content": "<strong>Custom rendered HTML</strong>"
+            }
+          ]
+        }
 
 ``debug``
     Extra debug information
diff --git a/tests/test_docs.py b/tests/test_docs.py
index 784755e9..c4e0a849 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -122,6 +122,14 @@ def test_table_extra_examples_are_documented():
     assert ".. code-block:: json" in section
 
 
+def test_render_cell_extra_example_explains_row_and_column_mapping():
+    content = (docs_path / "json_api.rst").read_text()
+    section = content.split("``render_cell``")[-1].split("``query``")[0]
+    assert "same order as the ``rows`` array" in section
+    assert '"rows": [' in section
+    assert '"render_cell": [' in section
+
+
 @pytest.fixture(scope="session")
 def documented_labels():
     labels = set()

From 0fa872d43842d87af9e7b8c193f90addfcf164ba Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 8 Jun 2026 21:20:06 -0700
Subject: [PATCH 148/386] Add debug and request JSON extra examples

---
 datasette/views/table_extras.py |  2 ++
 docs/json_api.rst               | 31 +++++++++++++++++++++++++++++++
 tests/test_docs.py              | 13 +++++++++++++
 3 files changed, 46 insertions(+)

diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index b6e653c4..e888ee9f 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -308,6 +308,7 @@ class IsViewExtra(Extra):
 
 class DebugExtra(Extra):
     description = "Extra debug information"
+    example = ExtraExample("/fixtures/facetable.json?_extra=debug")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
@@ -321,6 +322,7 @@ class DebugExtra(Extra):
 
 class RequestExtra(Extra):
     description = "Full information about the request"
+    example = ExtraExample("/fixtures/facetable.json?_extra=request")
     scopes = frozenset({ExtraScope.TABLE})
 
     async def resolve(self, context):
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 24d59577..d418d16c 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -454,9 +454,40 @@ The available table extras are listed below.
 ``debug``
     Extra debug information
 
+    ``GET /fixtures/facetable.json?_extra=debug``
+
+    .. code-block:: json
+
+        {
+          "resolved": "ResolvedTable(db=<Database: fixtures (mutable, size=249856)>, table='facetable', is_view=False)",
+          "url_vars": {
+            "database": "fixtures",
+            "table": "facetable",
+            "format": "json"
+          },
+          "nofacet": null,
+          "nosuggest": null
+        }
+
 ``request``
     Full information about the request
 
+    ``GET /fixtures/facetable.json?_extra=request``
+
+    .. code-block:: json
+
+        {
+          "url": "http://localhost/fixtures/facetable.json?_extra=request",
+          "path": "/fixtures/facetable.json",
+          "full_path": "/fixtures/facetable.json?_extra=request",
+          "host": "localhost",
+          "args": {
+            "_extra": [
+              "request"
+            ]
+          }
+        }
+
 ``query``
     Details of the underlying SQL query
 
diff --git a/tests/test_docs.py b/tests/test_docs.py
index c4e0a849..3aa67730 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -130,6 +130,19 @@ def test_render_cell_extra_example_explains_row_and_column_mapping():
     assert '"render_cell": [' in section
 
 
+def test_debug_and_request_extra_examples_are_documented():
+    content = (docs_path / "json_api.rst").read_text()
+    section = content.split(".. _json_api_extra:")[-1].split(".. _table_arguments:")[0]
+
+    debug_section = section.split("``debug``")[-1].split("``request``")[0]
+    assert "GET /fixtures/facetable.json?_extra=debug" in debug_section
+    assert '"url_vars": {' in debug_section
+
+    request_section = section.split("``request``")[-1].split("``query``")[0]
+    assert "GET /fixtures/facetable.json?_extra=request" in request_section
+    assert '"full_path":' in request_section
+
+
 @pytest.fixture(scope="session")
 def documented_labels():
     labels = set()

From 4d6daa175a67c4c6e895fe8b32ae051b1e9136a7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 9 Jun 2026 02:56:27 -0700
Subject: [PATCH 149/386] Add row and query JSON extras

---
 datasette/extras.py             |   7 +
 datasette/views/database.py     |  46 +++-
 datasette/views/row.py          |  67 ++----
 datasette/views/table_extras.py | 258 ++++++++++++++++++---
 docs/json_api.rst               | 386 +++++++++++++++++++++++++++++++-
 docs/json_api_doc.py            | 141 ++++++++----
 tests/test_api.py               |  22 ++
 tests/test_docs.py              |  16 +-
 tests/test_table_api.py         |  49 ++++
 9 files changed, 862 insertions(+), 130 deletions(-)

diff --git a/datasette/extras.py b/datasette/extras.py
index d867f26c..f655e517 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -16,6 +16,8 @@ def extra_names_from_request(request):
 
 class ExtraScope(Enum):
     TABLE = "table"
+    ROW = "row"
+    QUERY = "query"
 
 
 @dataclass(frozen=True)
@@ -46,11 +48,16 @@ class Provider:
 class Extra(Provider):
     description: ClassVar[str | None] = None
     example: ClassVar[ExtraExample | None] = None
+    examples: ClassVar[dict[ExtraScope, ExtraExample | list[ExtraExample]]] = {}
     public: ClassVar[bool] = True
     stable: ClassVar[bool] = True
     expensive: ClassVar[bool] = False
     docs_note: ClassVar[str | None] = None
 
+    @classmethod
+    def example_for_scope(cls, scope):
+        return cls.examples.get(scope, cls.example)
+
     @classmethod
     def documentation(cls):
         return {
diff --git a/datasette/views/database.py b/datasette/views/database.py
index a1647ca9..96a58758 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -11,6 +11,7 @@ import sqlite_utils
 import textwrap
 
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
+from datasette.extras import extra_names_from_request
 from datasette.database import QueryInterrupted
 from datasette.resources import DatabaseResource, QueryResource
 from datasette.stored_queries import stored_query_to_dict
@@ -38,6 +39,11 @@ from datasette.plugins import pm
 
 from .base import BaseView, DatasetteError, View, _error, stream_csv
 from .query_helpers import _ensure_stored_query_execution_permissions, _table_columns
+from .table_extras import (
+    QueryExtraContext,
+    resolve_query_extras,
+    table_extra_registry,
+)
 from . import Context
 
 
@@ -692,6 +698,34 @@ class QueryView(View):
             except DatasetteError:
                 raise
 
+        extras = extra_names_from_request(request)
+        metadata = None
+        data = {"ok": True, "rows": rows, "columns": columns}
+        if extras:
+            metadata = await datasette.get_database_metadata(database)
+            if stored_query:
+                metadata = stored_query_to_dict(stored_query)
+                metadata.pop("source", None)
+            query_extra_context = QueryExtraContext(
+                datasette=datasette,
+                request=request,
+                db=db,
+                database_name=database,
+                private=private,
+                rows=rows,
+                columns=columns,
+                sql=sql,
+                params=params_for_query,
+                query_name=stored_query.name if stored_query else None,
+                stored_query=stored_query,
+                stored_query_write=stored_query_write,
+                error=query_error,
+                metadata=metadata,
+                extras=extras,
+                extra_registry=table_extra_registry,
+            )
+            data.update(await resolve_query_extras(extras, query_extra_context))
+
         # Handle formats from plugins
         if format_ == "csv":
             if not sql:
@@ -721,7 +755,7 @@ class QueryView(View):
                 error=query_error,
                 # These will be deprecated in Datasette 1.0:
                 args=request.args,
-                data={"ok": True, "rows": rows, "columns": columns},
+                data=data,
             )
             if asyncio.iscoroutine(result):
                 result = await result
@@ -770,11 +804,11 @@ class QueryView(View):
                     )
                 }
             )
-            metadata = await datasette.get_database_metadata(database)
-            if stored_query:
-                metadata = stored_query_to_dict(stored_query)
-                metadata.pop("source", None)
-
+            if metadata is None:
+                metadata = await datasette.get_database_metadata(database)
+                if stored_query:
+                    metadata = stored_query_to_dict(stored_query)
+                    metadata.pop("source", None)
             renderers = {}
             for key, (_, can_render) in datasette.renderers.items():
                 it_can_render = call_with_supported_arguments(
diff --git a/datasette/views/row.py b/datasette/views/row.py
index 4eacfe49..3fe213d7 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -15,6 +15,7 @@ import json
 import markupsafe
 import sqlite_utils
 from .table import display_columns_and_rows, _get_extras
+from .table_extras import RowExtraContext, resolve_row_extras, table_extra_registry
 
 
 class RowView(DataView):
@@ -172,52 +173,26 @@ class RowView(DataView):
             extras.add("foreign_key_tables")
 
         # Process extras
-        if "foreign_key_tables" in extras:
-            data["foreign_key_tables"] = await self.foreign_key_tables(
-                database, table, pk_values
-            )
-
-        if "render_cell" in extras:
-            # Call render_cell plugin hook for each cell
-            ct_map = await self.ds.get_column_types(database, table)
-            rendered_rows = []
-            for row in rows:
-                rendered_row = {}
-                for value, column in zip(row, columns):
-                    ct = ct_map.get(column)
-                    plugin_display_value = None
-                    # Try column type render_cell first
-                    if ct:
-                        candidate = await ct.render_cell(
-                            value=value,
-                            column=column,
-                            table=table,
-                            database=database,
-                            datasette=self.ds,
-                            request=request,
-                        )
-                        if candidate is not None:
-                            plugin_display_value = candidate
-                    if plugin_display_value is None:
-                        for candidate in pm.hook.render_cell(
-                            row=row,
-                            value=value,
-                            column=column,
-                            table=table,
-                            pks=resolved.pks,
-                            database=database,
-                            datasette=self.ds,
-                            request=request,
-                            column_type=ct,
-                        ):
-                            candidate = await await_me_maybe(candidate)
-                            if candidate is not None:
-                                plugin_display_value = candidate
-                                break
-                    if plugin_display_value:
-                        rendered_row[column] = str(plugin_display_value)
-                rendered_rows.append(rendered_row)
-            data["render_cell"] = rendered_rows
+        row_extra_context = RowExtraContext(
+            datasette=self.ds,
+            request=request,
+            resolved=resolved,
+            db=db,
+            database_name=database,
+            table_name=table,
+            private=private,
+            rows=rows,
+            columns=columns,
+            results_description=results.description,
+            pks=pks,
+            pk_values=pk_values,
+            sql=resolved.sql,
+            params=resolved.params,
+            extras=extras,
+            extra_registry=table_extra_registry,
+            foreign_key_tables=self.foreign_key_tables,
+        )
+        data.update(await resolve_row_extras(extras, row_extra_context))
 
         return (
             data,
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index e888ee9f..ec104be3 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -8,6 +8,7 @@ from datasette.resources import TableResource
 from datasette.utils import (
     await_me_maybe,
     call_with_supported_arguments,
+    named_parameters as derive_named_parameters,
     path_with_added_args,
     path_with_format,
     path_with_removed_args,
@@ -52,6 +53,50 @@ class TableExtraContext:
     extra_registry: ExtraRegistry
     display_columns_and_rows: object
     run_sequential: object
+    scope: ExtraScope = ExtraScope.TABLE
+
+
+@dataclass(frozen=True)
+class RowExtraContext:
+    datasette: object
+    request: object
+    resolved: object
+    db: object
+    database_name: str
+    table_name: str
+    private: bool
+    rows: list
+    columns: list
+    results_description: list
+    pks: list
+    pk_values: list
+    sql: str
+    params: dict
+    extras: set
+    extra_registry: ExtraRegistry
+    foreign_key_tables: object
+    scope: ExtraScope = ExtraScope.ROW
+
+
+@dataclass(frozen=True)
+class QueryExtraContext:
+    datasette: object
+    request: object
+    db: object
+    database_name: str
+    private: bool
+    rows: list
+    columns: list
+    sql: str | None
+    params: dict
+    query_name: str | None
+    stored_query: object
+    stored_query_write: bool
+    error: str | None
+    metadata: dict
+    extras: set
+    extra_registry: ExtraRegistry
+    scope: ExtraScope = ExtraScope.QUERY
 
 
 class CountSqlExtra(Extra):
@@ -245,7 +290,15 @@ class NextUrlExtra(Extra):
 class ColumnsExtra(Extra):
     description = "Column names returned by this query"
     example = ExtraExample("/fixtures/facetable.json?_extra=columns")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=columns"
+        ),
+        ExtraScope.QUERY: ExtraExample(
+            "/fixtures/-/query.json?sql=select+1+as+one&_extra=columns"
+        ),
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
         return context.columns
@@ -263,7 +316,12 @@ class AllColumnsExtra(Extra):
 class PrimaryKeysExtra(Extra):
     description = "Primary keys for this table"
     example = ExtraExample("/fixtures/facetable.json?_extra=primary_keys")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=primary_keys"
+        )
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW})
 
     async def resolve(self, context):
         return context.pks
@@ -309,21 +367,49 @@ class IsViewExtra(Extra):
 class DebugExtra(Extra):
     description = "Extra debug information"
     example = ExtraExample("/fixtures/facetable.json?_extra=debug")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=debug"
+        ),
+        ExtraScope.QUERY: ExtraExample(
+            "/fixtures/-/query.json?sql=select+1+as+one&_extra=debug"
+        ),
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
-        return {
-            "resolved": repr(context.resolved),
+        debug = {
             "url_vars": context.request.url_vars,
-            "nofacet": context.nofacet,
-            "nosuggest": context.nosuggest,
         }
+        if context.scope == ExtraScope.TABLE:
+            debug["resolved"] = repr(context.resolved)
+        elif context.scope == ExtraScope.ROW:
+            debug["resolved"] = {
+                "table": context.table_name,
+                "sql": context.sql,
+                "params": context.params,
+                "pks": context.pks,
+                "pk_values": context.pk_values,
+            }
+        if hasattr(context, "nofacet"):
+            debug["nofacet"] = context.nofacet
+        if hasattr(context, "nosuggest"):
+            debug["nosuggest"] = context.nosuggest
+        return debug
 
 
 class RequestExtra(Extra):
     description = "Full information about the request"
     example = ExtraExample("/fixtures/facetable.json?_extra=request")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=request"
+        ),
+        ExtraScope.QUERY: ExtraExample(
+            "/fixtures/-/query.json?sql=select+1+as+one&_extra=request"
+        ),
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
         return {
@@ -413,15 +499,48 @@ class RenderCellExtra(Extra):
             "whose rendered value differs from the default are included."
         ),
     )
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            value={
+                "rows": [{"id": 4, "content": "RENDER_CELL_DEMO"}],
+                "render_cell": [{"content": "<strong>Custom rendered HTML</strong>"}],
+            },
+            note=(
+                "The ``render_cell`` array has one item for the requested row. "
+                "The object is keyed by column name. Only columns whose rendered "
+                "value differs from the default are included."
+            ),
+        ),
+        ExtraScope.QUERY: ExtraExample(
+            value={
+                "rows": [{"content": "RENDER_CELL_DEMO"}],
+                "render_cell": [{"content": "<strong>Custom rendered HTML</strong>"}],
+            },
+            note=(
+                "The ``render_cell`` array has one item per query result row, in "
+                "the same order as the ``rows`` array. Each object is keyed by "
+                "column name. Only columns whose rendered value differs from the "
+                "default are included."
+            ),
+        ),
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
+        table_name = getattr(context, "table_name", None)
+        is_view = getattr(context, "is_view", False)
+        pks = getattr(context, "pks", [])
         pks_for_display = (
-            context.pks if context.pks else (["rowid"] if not context.is_view else [])
+            pks if pks else (["rowid"] if table_name and not is_view else [])
         )
-        col_names = [col[0] for col in context.results_description]
-        ct_map = await context.datasette.get_column_types(
-            context.database_name, context.table_name
+        if hasattr(context, "results_description"):
+            col_names = [col[0] for col in context.results_description]
+        else:
+            col_names = context.columns
+        ct_map = (
+            await context.datasette.get_column_types(context.database_name, table_name)
+            if table_name
+            else {}
         )
         rendered_rows = []
         for row in context.rows:
@@ -433,7 +552,7 @@ class RenderCellExtra(Extra):
                     candidate = await ct.render_cell(
                         value=value,
                         column=column,
-                        table=context.table_name,
+                        table=table_name,
                         database=context.database_name,
                         datasette=context.datasette,
                         request=context.request,
@@ -445,7 +564,7 @@ class RenderCellExtra(Extra):
                         row=row,
                         value=value,
                         column=column,
-                        table=context.table_name,
+                        table=table_name,
                         pks=pks_for_display,
                         database=context.database_name,
                         datasette=context.datasette,
@@ -465,19 +584,36 @@ class RenderCellExtra(Extra):
 class QueryExtra(Extra):
     description = "Details of the underlying SQL query"
     example = ExtraExample("/fixtures/facetable.json?_size=1&_extra=query")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=query"
+        ),
+        ExtraScope.QUERY: [
+            ExtraExample("/fixtures/-/query.json?sql=select+1+as+one&_extra=query"),
+            ExtraExample("/fixtures/neighborhood_search.json?text=town&_extra=query"),
+        ],
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
+        params = context.params
+        if context.scope == ExtraScope.QUERY and context.sql:
+            parameter_names = set(derive_named_parameters(context.sql))
+            params = {
+                key: value
+                for key, value in dict(context.params).items()
+                if key in parameter_names
+            }
         return {
             "sql": context.sql,
-            "params": context.params,
+            "params": params,
         }
 
 
 class ColumnTypesExtra(Extra):
     description = "Column type assignments for this table"
     example = ExtraExample(value={})
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW})
 
     async def resolve(self, context):
         ct_map = await context.datasette.get_column_types(
@@ -544,11 +680,22 @@ class SetColumnTypeUiExtra(Extra):
 
 
 class MetadataExtra(Extra):
-    description = "Metadata about the table and database"
+    description = "Metadata about the table, database or stored query"
     example = ExtraExample("/fixtures/facetable.json?_extra=metadata")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=metadata"
+        ),
+        ExtraScope.QUERY: ExtraExample(
+            "/fixtures/neighborhood_search.json?text=town&_extra=metadata"
+        ),
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
+        if context.scope == ExtraScope.QUERY:
+            return context.metadata
+
         tablemetadata = await context.datasette.get_resource_metadata(
             context.database_name, context.table_name
         )
@@ -572,7 +719,15 @@ class MetadataExtra(Extra):
 class DatabaseExtra(Extra):
     description = "Database name"
     example = ExtraExample("/fixtures/facetable.json?_extra=database")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=database"
+        ),
+        ExtraScope.QUERY: ExtraExample(
+            "/fixtures/-/query.json?sql=select+1+as+one&_extra=database"
+        ),
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
         return context.database_name
@@ -581,7 +736,10 @@ class DatabaseExtra(Extra):
 class TableExtra(Extra):
     description = "Table name"
     example = ExtraExample("/fixtures/facetable.json?_extra=table")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample("/fixtures/simple_primary_key/1.json?_extra=table")
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW})
 
     async def resolve(self, context):
         return context.table_name
@@ -590,7 +748,15 @@ class TableExtra(Extra):
 class DatabaseColorExtra(Extra):
     description = "Color assigned to the database"
     example = ExtraExample("/fixtures/facetable.json?_extra=database_color")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=database_color"
+        ),
+        ExtraScope.QUERY: ExtraExample(
+            "/fixtures/-/query.json?sql=select+1+as+one&_extra=database_color"
+        ),
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
         return context.db.color
@@ -703,6 +869,8 @@ class RenderersExtra(Extra):
         url_labels_extra = {}
         if expandable_columns:
             url_labels_extra = {"_labels": "on"}
+        table_name = getattr(context, "table_name", None)
+        view_name = "table" if context.scope == ExtraScope.TABLE else "database"
         for key, (_, can_render) in context.datasette.renderers.items():
             it_can_render = call_with_supported_arguments(
                 can_render,
@@ -710,11 +878,11 @@ class RenderersExtra(Extra):
                 columns=context.columns or [],
                 rows=context.rows or [],
                 sql=query.get("sql", None),
-                query_name=None,
+                query_name=getattr(context, "query_name", None),
                 database=context.database_name,
-                table=context.table_name,
+                table=table_name,
                 request=context.request,
-                view_name="table",
+                view_name=view_name,
             )
             it_can_render = await await_me_maybe(it_can_render)
             if it_can_render:
@@ -730,9 +898,17 @@ class RenderersExtra(Extra):
 
 
 class PrivateExtra(Extra):
-    description = "Whether this table is private to the current actor"
+    description = "Whether this resource is private to the current actor"
     example = ExtraExample("/fixtures/facetable.json?_extra=private")
-    scopes = frozenset({ExtraScope.TABLE})
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/simple_primary_key/1.json?_extra=private"
+        ),
+        ExtraScope.QUERY: ExtraExample(
+            "/fixtures/-/query.json?sql=select+1+as+one&_extra=private"
+        ),
+    }
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
         return context.private
@@ -752,14 +928,27 @@ class ExpandableColumnsExtra(Extra):
         return expandables
 
 
+class ForeignKeyTablesExtra(Extra):
+    description = "Tables that link to this row using foreign keys"
+    example = ExtraExample(
+        "/fixtures/simple_primary_key/1.json?_extra=foreign_key_tables"
+    )
+    scopes = frozenset({ExtraScope.ROW})
+
+    async def resolve(self, context):
+        return await context.foreign_key_tables(
+            context.database_name, context.table_name, context.pk_values
+        )
+
+
 class ExtrasExtra(Extra):
     description = "Available ?_extra= blocks"
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
         all_extras = [
             (cls.key(), cls.description)
-            for cls in context.extra_registry.public_classes_for_scope(ExtraScope.TABLE)
+            for cls in context.extra_registry.public_classes_for_scope(context.scope)
         ]
         return [
             {
@@ -850,6 +1039,7 @@ TABLE_EXTRA_CLASSES = [
     IsViewExtra,
     PrivateExtra,
     ExpandableColumnsExtra,
+    ForeignKeyTablesExtra,
     FormHiddenArgsExtra,
 ]
 
@@ -859,3 +1049,11 @@ table_extra_registry = ExtraRegistry(TABLE_EXTRA_CLASSES)
 
 async def resolve_table_extras(extras, context):
     return await table_extra_registry.resolve(extras, context, ExtraScope.TABLE)
+
+
+async def resolve_row_extras(extras, context):
+    return await table_extra_registry.resolve(extras, context, ExtraScope.ROW)
+
+
+async def resolve_query_extras(extras, context):
+    return await table_extra_registry.resolve(extras, context, ExtraScope.QUERY)
diff --git a/docs/json_api.rst b/docs/json_api.rst
index d418d16c..379d26a0 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -237,23 +237,26 @@ query string arguments:
 
 .. _json_api_extra:
 
-Expanding table JSON responses
-------------------------------
+Expanding JSON responses
+------------------------
 
-Table JSON responses can be expanded with one or more ``?_extra=`` parameters.
+Table, row and query JSON responses can be expanded with one or more ``?_extra=`` parameters.
 These can be repeated or comma-separated:
 
 ::
 
     ?_extra=columns&_extra=count,next_url
 
-The available table extras are listed below.
-
 .. [[[cog
     from json_api_doc import table_extras
     table_extras(cog)
 .. ]]]
 
+Table JSON responses
+~~~~~~~~~~~~~~~~~~~~
+
+The available table extras are listed below.
+
 ``count``
     Total count of rows matching these filters (May execute additional queries.)
 
@@ -459,12 +462,12 @@ The available table extras are listed below.
     .. code-block:: json
 
         {
-          "resolved": "ResolvedTable(db=<Database: fixtures (mutable, size=249856)>, table='facetable', is_view=False)",
           "url_vars": {
             "database": "fixtures",
             "table": "facetable",
             "format": "json"
           },
+          "resolved": "ResolvedTable(db=<Database: fixtures (mutable, size=249856)>, table='facetable', is_view=False)",
           "nofacet": null,
           "nosuggest": null
         }
@@ -511,7 +514,7 @@ The available table extras are listed below.
     Column type UI metadata for this table
 
 ``metadata``
-    Metadata about the table and database
+    Metadata about the table, database or stored query
 
     ``GET /fixtures/facetable.json?_extra=metadata``
 
@@ -649,7 +652,7 @@ The available table extras are listed below.
         true
 
 ``private``
-    Whether this table is private to the current actor
+    Whether this resource is private to the current actor
 
     ``GET /fixtures/facetable.json?_extra=private``
 
@@ -697,6 +700,373 @@ The available table extras are listed below.
           ]
         ]
 
+Row JSON responses
+~~~~~~~~~~~~~~~~~~
+
+The following extras are available for row JSON responses.
+
+``columns``
+    Column names returned by this query
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=columns``
+
+    .. code-block:: json
+
+        [
+          "id",
+          "content"
+        ]
+
+``primary_keys``
+    Primary keys for this table
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=primary_keys``
+
+    .. code-block:: json
+
+        [
+          "id"
+        ]
+
+``render_cell``
+    Rendered HTML for each cell using the render_cell plugin hook
+
+    The ``render_cell`` array has one item for the requested row. The object is keyed by column name. Only columns whose rendered value differs from the default are included.
+
+    .. code-block:: json
+
+        {
+          "rows": [
+            {
+              "id": 4,
+              "content": "RENDER_CELL_DEMO"
+            }
+          ],
+          "render_cell": [
+            {
+              "content": "<strong>Custom rendered HTML</strong>"
+            }
+          ]
+        }
+
+``debug``
+    Extra debug information
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=debug``
+
+    .. code-block:: json
+
+        {
+          "url_vars": {
+            "database": "fixtures",
+            "table": "simple_primary_key",
+            "pks": "1",
+            "format": "json"
+          },
+          "resolved": {
+            "table": "simple_primary_key",
+            "sql": "select * from simple_primary_key where \"id\"=:p0",
+            "params": {
+              "p0": "1"
+            },
+            "pks": [
+              "id"
+            ],
+            "pk_values": [
+              "1"
+            ]
+          }
+        }
+
+``request``
+    Full information about the request
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=request``
+
+    .. code-block:: json
+
+        {
+          "url": "http://localhost/fixtures/simple_primary_key/1.json?_extra=request",
+          "path": "/fixtures/simple_primary_key/1.json",
+          "full_path": "/fixtures/simple_primary_key/1.json?_extra=request",
+          "host": "localhost",
+          "args": {
+            "_extra": [
+              "request"
+            ]
+          }
+        }
+
+``query``
+    Details of the underlying SQL query
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=query``
+
+    .. code-block:: json
+
+        {
+          "sql": "select * from simple_primary_key where \"id\"=:p0",
+          "params": {
+            "p0": "1"
+          }
+        }
+
+``column_types``
+    Column type assignments for this table
+
+    .. code-block:: json
+
+        {}
+
+``metadata``
+    Metadata about the table, database or stored query
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=metadata``
+
+    .. code-block:: json
+
+        {
+          "columns": {}
+        }
+
+``extras``
+    Available ?_extra= blocks
+
+``database``
+    Database name
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=database``
+
+    .. code-block:: json
+
+        "fixtures"
+
+``table``
+    Table name
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=table``
+
+    .. code-block:: json
+
+        "simple_primary_key"
+
+``database_color``
+    Color assigned to the database
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=database_color``
+
+    .. code-block:: json
+
+        "9403e5"
+
+``private``
+    Whether this resource is private to the current actor
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=private``
+
+    .. code-block:: json
+
+        false
+
+``foreign_key_tables``
+    Tables that link to this row using foreign keys
+
+    ``GET /fixtures/simple_primary_key/1.json?_extra=foreign_key_tables``
+
+    .. code-block:: json
+
+        [
+          {
+            "other_table": "complex_foreign_keys",
+            "column": "id",
+            "other_column": "f1",
+            "count": 1,
+            "link": "/fixtures/complex_foreign_keys?f1=1"
+          },
+          {
+            "other_table": "complex_foreign_keys",
+            "column": "id",
+            "other_column": "f2",
+            "count": 0,
+            "link": "/fixtures/complex_foreign_keys?f2=1"
+          },
+          {
+            "other_table": "complex_foreign_keys",
+            "column": "id",
+            "other_column": "f3",
+            "count": 1,
+            "link": "/fixtures/complex_foreign_keys?f3=1"
+          },
+          {
+            "other_table": "foreign_key_references",
+            "column": "id",
+            "other_column": "foreign_key_with_blank_label",
+            "count": 0,
+            "link": "/fixtures/foreign_key_references?foreign_key_with_blank_label=1"
+          },
+          {
+            "other_table": "foreign_key_references",
+            "column": "id",
+            "other_column": "foreign_key_with_label",
+            "count": 1,
+            "link": "/fixtures/foreign_key_references?foreign_key_with_label=1"
+          }
+        ]
+
+Query JSON responses
+~~~~~~~~~~~~~~~~~~~~
+
+The following extras are available for arbitrary SQL query responses and stored, named query responses.
+
+``columns``
+    Column names returned by this query
+
+    ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=columns``
+
+    .. code-block:: json
+
+        [
+          "one"
+        ]
+
+``render_cell``
+    Rendered HTML for each cell using the render_cell plugin hook
+
+    The ``render_cell`` array has one item per query result row, in the same order as the ``rows`` array. Each object is keyed by column name. Only columns whose rendered value differs from the default are included.
+
+    .. code-block:: json
+
+        {
+          "rows": [
+            {
+              "content": "RENDER_CELL_DEMO"
+            }
+          ],
+          "render_cell": [
+            {
+              "content": "<strong>Custom rendered HTML</strong>"
+            }
+          ]
+        }
+
+``debug``
+    Extra debug information
+
+    ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=debug``
+
+    .. code-block:: json
+
+        {
+          "url_vars": {
+            "database": "fixtures",
+            "format": "json"
+          }
+        }
+
+``request``
+    Full information about the request
+
+    ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=request``
+
+    .. code-block:: json
+
+        {
+          "url": "http://localhost/fixtures/-/query.json?sql=select+1+as+one&_extra=request",
+          "path": "/fixtures/-/query.json",
+          "full_path": "/fixtures/-/query.json?sql=select+1+as+one&_extra=request",
+          "host": "localhost",
+          "args": {
+            "sql": [
+              "select 1 as one"
+            ],
+            "_extra": [
+              "request"
+            ]
+          }
+        }
+
+``query``
+    Details of the underlying SQL query
+
+    ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=query``
+
+    .. code-block:: json
+
+        {
+          "sql": "select 1 as one",
+          "params": {}
+        }
+
+    ``GET /fixtures/neighborhood_search.json?text=town&_extra=query``
+
+    .. code-block:: json
+
+        {
+          "sql": "\nselect _neighborhood, facet_cities.name, state\nfrom facetable\n    join facet_cities\n        on facetable._city_id = facet_cities.id\nwhere _neighborhood like '%' || :text || '%'\norder by _neighborhood;\n",
+          "params": {
+            "text": "town"
+          }
+        }
+
+``metadata``
+    Metadata about the table, database or stored query
+
+    ``GET /fixtures/neighborhood_search.json?text=town&_extra=metadata``
+
+    .. code-block:: json
+
+        {
+          "database": "fixtures",
+          "name": "neighborhood_search",
+          "sql": "\nselect _neighborhood, facet_cities.name, state\nfrom facetable\n    join facet_cities\n        on facetable._city_id = facet_cities.id\nwhere _neighborhood like '%' || :text || '%'\norder by _neighborhood;\n",
+          "title": "Search neighborhoods",
+          "description": null,
+          "description_html": null,
+          "hide_sql": false,
+          "fragment": null,
+          "params": [],
+          "parameters": [],
+          "is_write": false,
+          "is_private": false,
+          "is_trusted": true,
+          "owner_id": null,
+          "on_success_message": null,
+          "on_success_message_sql": null,
+          "on_success_redirect": null,
+          "on_error_message": null,
+          "on_error_redirect": null
+        }
+
+``extras``
+    Available ?_extra= blocks
+
+``database``
+    Database name
+
+    ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=database``
+
+    .. code-block:: json
+
+        "fixtures"
+
+``database_color``
+    Color assigned to the database
+
+    ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=database_color``
+
+    .. code-block:: json
+
+        "9403e5"
+
+``private``
+    Whether this resource is private to the current actor
+
+    ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=private``
+
+    .. code-block:: json
+
+        false
+
 .. [[[end]]]
 
 .. _table_arguments:
diff --git a/docs/json_api_doc.py b/docs/json_api_doc.py
index 69ec6e5e..44ef4a42 100644
--- a/docs/json_api_doc.py
+++ b/docs/json_api_doc.py
@@ -9,39 +9,80 @@ def table_extras(cog):
     from datasette.extras import ExtraScope
     from datasette.views.table_extras import table_extra_registry
 
-    classes = table_extra_registry.public_classes_for_scope(ExtraScope.TABLE)
+    scopes = [
+        (
+            ExtraScope.TABLE,
+            "Table JSON responses",
+            "The available table extras are listed below.",
+        ),
+        (
+            ExtraScope.ROW,
+            "Row JSON responses",
+            "The following extras are available for row JSON responses.",
+        ),
+        (
+            ExtraScope.QUERY,
+            "Query JSON responses",
+            (
+                "The following extras are available for arbitrary SQL query "
+                "responses and stored, named query responses."
+            ),
+        ),
+    ]
+    classes_by_scope = [
+        (scope, heading, intro, table_extra_registry.public_classes_for_scope(scope))
+        for scope, heading, intro in scopes
+    ]
 
-    live_examples = asyncio.run(_fetch_live_examples(classes))
+    live_examples = asyncio.run(
+        _fetch_live_examples(
+            [
+                (scope, cls)
+                for scope, _, _, classes in classes_by_scope
+                for cls in classes
+            ]
+        )
+    )
     cog.out("\n")
-    for cls in classes:
-        example = cls.example
-        description = cls.description or ""
-        notes = []
-        if cls.expensive:
-            notes.append("May execute additional queries.")
-        if cls.docs_note:
-            notes.append(cls.docs_note)
-        if notes:
-            description = "{} ({})".format(description, " ".join(notes)).strip()
+    for scope, heading, intro, classes in classes_by_scope:
+        cog.out("{}\n{}\n\n".format(heading, "~" * len(heading)))
+        cog.out("{}\n\n".format(intro))
+        for cls in classes:
+            examples = _examples_for_scope(cls, scope)
+            description = cls.description or ""
+            notes = []
+            if cls.expensive:
+                notes.append("May execute additional queries.")
+            if cls.docs_note:
+                notes.append(cls.docs_note)
+            if notes:
+                description = "{} ({})".format(description, " ".join(notes)).strip()
 
-        cog.out("``{}``\n".format(cls.key()))
-        cog.out("    {}\n\n".format(description))
-        if example is None:
-            continue
-
-        if example.path:
-            value = live_examples[(example.path, example.key or cls.key())]
-            cog.out("    ``GET {}``\n\n".format(example.path))
-        else:
-            value = example.value
-        if example.note:
-            cog.out("    {}\n\n".format(example.note))
-        cog.out("    .. code-block:: json\n\n")
-        cog.out(textwrap.indent(json.dumps(value, indent=2), "        "))
-        cog.out("\n\n")
+            cog.out("``{}``\n".format(cls.key()))
+            cog.out("    {}\n\n".format(description))
+            for example in examples:
+                if example.path:
+                    value = live_examples[(example.path, example.key or cls.key())]
+                    cog.out("    ``GET {}``\n\n".format(example.path))
+                else:
+                    value = example.value
+                if example.note:
+                    cog.out("    {}\n\n".format(example.note))
+                cog.out("    .. code-block:: json\n\n")
+                cog.out(textwrap.indent(json.dumps(value, indent=2), "        "))
+                cog.out("\n\n")
 
 
-async def _fetch_live_examples(classes):
+def _examples_for_scope(cls, scope):
+    examples = cls.example_for_scope(scope)
+    if examples is None:
+        return []
+    if isinstance(examples, list):
+        return examples
+    return [examples]
+
+
+async def _fetch_live_examples(scoped_classes):
     from datasette.app import Datasette
     from datasette.fixtures import write_fixture_database
 
@@ -49,18 +90,40 @@ async def _fetch_live_examples(classes):
     with tempfile.TemporaryDirectory() as tmpdir:
         db_path = pathlib.Path(tmpdir) / "fixtures.db"
         write_fixture_database(db_path)
-        datasette = Datasette([str(db_path)], settings={"num_sql_threads": 1})
+        datasette = Datasette(
+            [str(db_path)],
+            settings={"num_sql_threads": 1},
+            config={
+                "databases": {
+                    "fixtures": {
+                        "queries": {
+                            "neighborhood_search": {
+                                "sql": textwrap.dedent("""
+                                    select _neighborhood, facet_cities.name, state
+                                    from facetable
+                                        join facet_cities
+                                            on facetable._city_id = facet_cities.id
+                                    where _neighborhood like '%' || :text || '%'
+                                    order by _neighborhood;
+                                """),
+                                "title": "Search neighborhoods",
+                            }
+                        }
+                    }
+                }
+            },
+        )
         try:
-            for cls in classes:
-                example = cls.example
-                if example is None or not example.path:
-                    continue
-                key = example.key or cls.key()
-                response = await datasette.client.get(example.path)
-                assert response.status_code == 200, example.path
-                data = response.json()
-                assert key in data, "{} missing from {}".format(key, example.path)
-                examples[(example.path, key)] = data[key]
+            for scope, cls in scoped_classes:
+                for example in _examples_for_scope(cls, scope):
+                    if not example.path:
+                        continue
+                    key = example.key or cls.key()
+                    response = await datasette.client.get(example.path)
+                    assert response.status_code == 200, example.path
+                    data = response.json()
+                    assert key in data, "{} missing from {}".format(key, example.path)
+                    examples[(example.path, key)] = data[key]
         finally:
             for db in datasette.databases.values():
                 if not db.is_memory:
diff --git a/tests/test_api.py b/tests/test_api.py
index f6187529..e1385b6f 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -426,6 +426,28 @@ async def test_row_foreign_key_tables(ds_client):
     ]
 
 
+@pytest.mark.asyncio
+async def test_row_extras(ds_client):
+    response = await ds_client.get(
+        "/fixtures/simple_primary_key/1.json?_extra=database,table,primary_keys,query,request,debug,foreign_key_tables"
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert data["database"] == "fixtures"
+    assert data["table"] == "simple_primary_key"
+    assert data["primary_keys"] == ["id"]
+    assert data["query"]["sql"] == 'select * from simple_primary_key where "id"=:p0'
+    assert data["query"]["params"] == {"p0": "1"}
+    assert data["request"]["path"] == "/fixtures/simple_primary_key/1.json"
+    assert data["debug"]["url_vars"] == {
+        "database": "fixtures",
+        "table": "simple_primary_key",
+        "pks": "1",
+        "format": "json",
+    }
+    assert len(data["foreign_key_tables"]) == 5
+
+
 @pytest.mark.asyncio
 async def test_row_extra_render_cell():
     """Test that _extra=render_cell returns rendered HTML from render_cell plugin hook on row pages"""
diff --git a/tests/test_docs.py b/tests/test_docs.py
index 3aa67730..13b3a549 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -132,7 +132,7 @@ def test_render_cell_extra_example_explains_row_and_column_mapping():
 
 def test_debug_and_request_extra_examples_are_documented():
     content = (docs_path / "json_api.rst").read_text()
-    section = content.split(".. _json_api_extra:")[-1].split(".. _table_arguments:")[0]
+    section = content.split("Table JSON responses")[-1].split("Row JSON responses")[0]
 
     debug_section = section.split("``debug``")[-1].split("``request``")[0]
     assert "GET /fixtures/facetable.json?_extra=debug" in debug_section
@@ -143,6 +143,20 @@ def test_debug_and_request_extra_examples_are_documented():
     assert '"full_path":' in request_section
 
 
+def test_row_and_query_extra_sections_are_documented():
+    content = (docs_path / "json_api.rst").read_text()
+    assert "Row JSON responses" in content
+    assert (
+        "``GET /fixtures/simple_primary_key/1.json?_extra=foreign_key_tables``"
+        in content
+    )
+    assert "Query JSON responses" in content
+    assert "``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=query``" in content
+    assert (
+        "``GET /fixtures/neighborhood_search.json?text=town&_extra=query``" in content
+    )
+
+
 @pytest.fixture(scope="session")
 def documented_labels():
     labels = set()
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index eeb3dc8b..388e3979 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -68,6 +68,55 @@ async def test_table_shape_arrayfirst(ds_client):
     ]
 
 
+@pytest.mark.asyncio
+async def test_query_extras_for_arbitrary_sql(ds_client):
+    response = await ds_client.get(
+        "/fixtures/-/query.json?"
+        + urllib.parse.urlencode(
+            {
+                "sql": "select 1 as one",
+                "_extra": "columns,database,query,request,debug",
+            }
+        )
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert data["rows"] == [{"one": 1}]
+    assert data["columns"] == ["one"]
+    assert data["database"] == "fixtures"
+    assert data["query"]["sql"] == "select 1 as one"
+    assert data["request"]["path"] == "/fixtures/-/query.json"
+    assert data["debug"]["url_vars"] == {
+        "database": "fixtures",
+        "format": "json",
+    }
+
+
+@pytest.mark.asyncio
+async def test_query_extras_for_stored_query(ds_client):
+    response = await ds_client.get(
+        "/fixtures/neighborhood_search.json?"
+        + urllib.parse.urlencode(
+            {
+                "text": "town",
+                "_extra": "columns,database,query,request,debug",
+            }
+        )
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert data["columns"] == ["_neighborhood", "name", "state"]
+    assert data["database"] == "fixtures"
+    assert data["query"]["sql"].strip().startswith("select _neighborhood")
+    assert data["query"]["params"]["text"] == "town"
+    assert data["request"]["path"] == "/fixtures/neighborhood_search.json"
+    assert data["debug"]["url_vars"] == {
+        "database": "fixtures",
+        "table": "neighborhood_search",
+        "format": "json",
+    }
+
+
 @pytest.mark.asyncio
 async def test_table_shape_objects(ds_client):
     response = await ds_client.get("/fixtures/simple_primary_key.json?_shape=objects")

From d8605ef4c2c054610d2f4fbf1c00d182afa617e4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 19:58:00 -0700
Subject: [PATCH 150/386] Fix execute_isolated_fn() against immutable databases

execute_isolated_fn() always opened its temporary connection with
write=True, which is not allowed for immutable databases - so APIs
that rely on it, like SQL analysis when storing a query, failed.

An immutable database can never receive writes, so there is no write
queue to block: in that case the function now opens a read-only
connection and runs it on the executor, bypassing the write thread
entirely. Mutable databases keep the existing write-thread behavior.

Also fixed a latent bug in the write thread where a connect() failure
for an isolated task would crash the thread instead of delivering the
exception back to the caller.

Closes #2768

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/database.py            | 46 +++++++++++++++++++-------------
 tests/test_internals_database.py | 33 +++++++++++++++++++++++
 tests/test_queries.py            | 34 ++++++++++++++++++++++-
 3 files changed, 94 insertions(+), 19 deletions(-)

diff --git a/datasette/database.py b/datasette/database.py
index 0a32442c..6cd5d11e 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -298,13 +298,14 @@ class Database:
 
     async def execute_isolated_fn(self, fn):
         self._check_not_closed()
-        # Open a new connection just for the duration of this function
+        # Open a new connection just for the duration of this function,
         # blocking the write queue to avoid any writes occurring during it
-        if self.ds.executor is None:
-            # non-threaded mode
-            isolated_connection = self.connect(write=True)
+        write = self.is_mutable
+
+        def _run():
+            isolated_connection = self.connect(write=write)
             try:
-                result = fn(isolated_connection)
+                return fn(isolated_connection)
             finally:
                 isolated_connection.close()
                 try:
@@ -312,10 +313,18 @@ class Database:
                 except ValueError:
                     # Was probably a memory connection
                     pass
-            return result
-        else:
-            # Threaded mode - send to write thread
-            return await self._send_to_write_thread(fn, isolated_connection=True)
+
+        if self.ds.executor is None:
+            # non-threaded mode
+            return _run()
+        if not write:
+            # Immutable database - no writes can ever occur, so there is no
+            # write queue to block; run against a fresh read-only connection
+            return await asyncio.get_running_loop().run_in_executor(
+                self.ds.executor, _run
+            )
+        # Threaded mode - send to write thread
+        return await self._send_to_write_thread(fn, isolated_connection=True)
 
     async def analyze_sql(self, sql, params=None) -> SQLAnalysis:
         self._check_not_closed()
@@ -449,20 +458,21 @@ class Database:
             if conn_exception is not None:
                 exception = conn_exception
             elif task.isolated_connection:
-                isolated_connection = self.connect(write=True)
                 try:
-                    result = task.fn(isolated_connection)
+                    isolated_connection = self.connect(write=True)
+                    try:
+                        result = task.fn(isolated_connection)
+                    finally:
+                        isolated_connection.close()
+                        try:
+                            self._all_file_connections.remove(isolated_connection)
+                        except ValueError:
+                            # Was probably a memory connection
+                            pass
                 except Exception as e:
                     sys.stderr.write("{}\n".format(e))
                     sys.stderr.flush()
                     exception = e
-                finally:
-                    isolated_connection.close()
-                    try:
-                        self._all_file_connections.remove(isolated_connection)
-                    except ValueError:
-                        # Was probably a memory connection
-                        pass
             else:
                 try:
                     if task.transaction:
diff --git a/tests/test_internals_database.py b/tests/test_internals_database.py
index bb209649..bad4e8ca 100644
--- a/tests/test_internals_database.py
+++ b/tests/test_internals_database.py
@@ -863,6 +863,39 @@ async def test_execute_isolated(db, disable_threads):
     assert not await db.execute_isolated_fn(table_exists_checker("created_by_isolated"))
 
 
+@pytest.mark.asyncio
+async def test_execute_isolated_connect_failure_does_not_kill_write_thread():
+    # A connect() failure for an isolated task should be returned to the
+    # caller as an exception, not crash the write thread
+    class ConnectError(Exception):
+        pass
+
+    ds = Datasette(memory=True)
+    db = ds.add_memory_database("test_isolated_connect_failure")
+    # Start the write thread with a healthy dedicated write connection
+    await db.execute_write("create table dogs (id integer primary key)")
+
+    original_connect = db.connect
+
+    def broken_connect(write=False):
+        raise ConnectError("Could not connect")
+
+    db.connect = broken_connect
+    try:
+        with pytest.raises(ConnectError):
+            await asyncio.wait_for(db.execute_isolated_fn(lambda conn: None), timeout=2)
+    finally:
+        db.connect = original_connect
+
+    # Write thread should still be alive and processing tasks
+    assert db._write_thread.is_alive()
+    await db.execute_write("insert into dogs (id) values (1)")
+    count = await db.execute_isolated_fn(
+        lambda conn: conn.execute("select count(*) from dogs").fetchone()[0]
+    )
+    assert count == 1
+
+
 @pytest.mark.asyncio
 async def test_analyze_sql():
     ds = Datasette(memory=True)
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 6e9bcbdb..0354f73a 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -9,7 +9,7 @@ from datasette.app import Datasette
 from datasette.resources import DatabaseResource, QueryResource
 from datasette.stored_queries import StoredQuery, StoredQueryPage
 from datasette.utils.asgi import Forbidden
-from datasette.utils.sqlite import supports_returning
+from datasette.utils.sqlite import sqlite3, supports_returning
 
 requires_sqlite_returning = pytest.mark.skipif(
     not supports_returning(), reason="SQLite does not support RETURNING"
@@ -593,6 +593,38 @@ async def test_query_store_api_creates_read_only_query():
     assert data["query"]["owner_id"] == "root"
 
 
+@pytest.mark.asyncio
+async def test_query_store_api_creates_query_for_immutable_database(tmp_path):
+    db_path = tmp_path / "immutable.db"
+    conn = sqlite3.connect(str(db_path))
+    conn.execute("create table dogs (id integer primary key, name text)")
+    conn.commit()
+    conn.close()
+
+    ds = Datasette([], immutables=[str(db_path)], default_deny=True)
+    ds.root_enabled = True
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/immutable/-/queries/store",
+        actor={"id": "root"},
+        json={
+            "query": {
+                "name": "by_name",
+                "sql": "select * from dogs where name = :name",
+            }
+        },
+    )
+
+    ds.close()
+    assert response.status_code == 201
+    data = response.json()
+    assert data["ok"] is True
+    assert data["query"]["name"] == "by_name"
+    assert data["query"]["parameters"] == ["name"]
+    assert data["query"]["is_write"] is False
+
+
 @pytest.mark.asyncio
 async def test_query_list_and_definition_api():
     ds = Datasette(memory=True)

From 3c1012dcc2995d184ea24fe70e8ccd6580592aff Mon Sep 17 00:00:00 2001
From: Viraat Das <viraat.laldas@gmail.com>
Date: Wed, 10 Jun 2026 20:15:03 -0700
Subject: [PATCH 151/386] Fix write query failing when a named parameter is
 called :sql (#2765)

Closes #2761
---
 .../templates/_sql_parameter_scripts.html     | 34 ++++++++++++-----
 datasette/templates/_sql_parameters.html      |  5 ++-
 datasette/views/execute_write.py              |  2 +
 datasette/views/query_helpers.py              | 14 ++++---
 tests/test_api_write.py                       | 38 +++++++++++++++++++
 tests/test_html.py                            |  4 +-
 tests/test_stored_queries.py                  |  2 +-
 7 files changed, 79 insertions(+), 20 deletions(-)

diff --git a/datasette/templates/_sql_parameter_scripts.html b/datasette/templates/_sql_parameter_scripts.html
index 159a141c..9b83889e 100644
--- a/datasette/templates/_sql_parameter_scripts.html
+++ b/datasette/templates/_sql_parameter_scripts.html
@@ -27,16 +27,20 @@ window.datasetteSqlParameters = (() => {
     manager.section
       .querySelectorAll("[data-parameter-control]")
       .forEach((control) => {
-        manager.parameterState.set(control.name, controlState(control));
+        manager.parameterState.set(
+          control.dataset.parameterName,
+          controlState(control)
+        );
       });
   }
 
-  function createControl(parameter, id, state) {
+  function createControl(parameter, id, state, namePrefix) {
     const control = document.createElement(state.expanded ? "textarea" : "input");
     control.id = id;
-    control.name = parameter;
+    control.name = `${namePrefix || ""}${parameter}`;
     control.value = state.value;
     control.setAttribute("data-parameter-control", "");
+    control.dataset.parameterName = parameter;
     if (state.expanded) {
       control.rows = 5;
     } else {
@@ -53,10 +57,16 @@ window.datasetteSqlParameters = (() => {
     value,
     selectionStart
   ) {
-    const replacement = createControl(control.name, control.id, {
-      value: value === undefined ? control.value : value,
-      expanded: expand,
-    });
+    const parameter = control.dataset.parameterName;
+    const replacement = createControl(
+      parameter,
+      control.id,
+      {
+        value: value === undefined ? control.value : value,
+        expanded: expand,
+      },
+      manager.namePrefix
+    );
     button.textContent = expand ? "Collapse" : "Expand";
     button.setAttribute("aria-expanded", expand ? "true" : "false");
     control.replaceWith(replacement);
@@ -64,7 +74,7 @@ window.datasetteSqlParameters = (() => {
     if (selectionStart !== undefined && replacement.setSelectionRange) {
       replacement.setSelectionRange(selectionStart, selectionStart);
     }
-    manager.parameterState.set(replacement.name, controlState(replacement));
+    manager.parameterState.set(parameter, controlState(replacement));
   }
 
   function renderParameters(manager, parameters) {
@@ -99,7 +109,7 @@ window.datasetteSqlParameters = (() => {
       label.htmlFor = id;
       label.textContent = parameter;
 
-      const control = createControl(parameter, id, state);
+      const control = createControl(parameter, id, state, manager.namePrefix);
 
       row.append(label, control);
       if (manager.allowExpand) {
@@ -124,7 +134,10 @@ window.datasetteSqlParameters = (() => {
       if (!control.matches || !control.matches("[data-parameter-control]")) {
         return;
       }
-      manager.parameterState.set(control.name, controlState(control));
+      manager.parameterState.set(
+        control.dataset.parameterName,
+        controlState(control)
+      );
     });
 
     if (!manager.allowExpand) {
@@ -230,6 +243,7 @@ window.datasetteSqlParameters = (() => {
             ? section.dataset.allowExpand === "1"
             : false
           : options.allowExpand,
+      namePrefix: section ? section.dataset.parameterNamePrefix || "" : "",
       parameterState: new Map(),
     };
     if (section) {
diff --git a/datasette/templates/_sql_parameters.html b/datasette/templates/_sql_parameters.html
index 58801d40..b5c1bde8 100644
--- a/datasette/templates/_sql_parameters.html
+++ b/datasette/templates/_sql_parameters.html
@@ -1,9 +1,10 @@
-<div id="{{ sql_parameters_section_id|default("sql-parameters-section") }}" class="sql-parameters-section" data-sql-parameters-section{% if sql_parameters_allow_expand|default(false) %} data-allow-expand="1"{% endif %}>
+{% set sql_parameter_name_prefix = sql_parameter_name_prefix|default("") %}
+<div id="{{ sql_parameters_section_id|default("sql-parameters-section") }}" class="sql-parameters-section" data-sql-parameters-section{% if sql_parameter_name_prefix %} data-parameter-name-prefix="{{ sql_parameter_name_prefix }}"{% endif %}{% if sql_parameters_allow_expand|default(false) %} data-allow-expand="1"{% endif %}>
     {% if parameter_names %}
         <h2>Parameters</h2>
         {% for parameter in parameter_names %}
             {% set parameter_id = (sql_parameter_id_prefix|default("qp")) ~ loop.index %}
-            <p class="sql-parameter-row"><label for="{{ parameter_id }}">{{ parameter }}</label> <input type="text" id="{{ parameter_id }}" name="{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}" data-parameter-control>{% if sql_parameters_allow_expand|default(false) %} <button type="button" class="sql-parameter-toggle" data-parameter-toggle aria-controls="{{ parameter_id }}" aria-expanded="false">Expand</button>{% endif %}</p>
+            <p class="sql-parameter-row"><label for="{{ parameter_id }}">{{ parameter }}</label> <input type="text" id="{{ parameter_id }}" name="{{ sql_parameter_name_prefix }}{{ parameter }}" value="{{ parameter_values.get(parameter, "") }}" data-parameter-control data-parameter-name="{{ parameter }}">{% if sql_parameters_allow_expand|default(false) %} <button type="button" class="sql-parameter-toggle" data-parameter-toggle aria-controls="{{ parameter_id }}" aria-expanded="false">Expand</button>{% endif %}</p>
         {% endfor %}
     {% endif %}
 </div>
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index c5d55b80..2817f56e 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -9,6 +9,7 @@ from .base import BaseView, _error
 from .database import display_rows as display_query_rows
 from .query_helpers import (
     QueryValidationError,
+    SQL_PARAMETER_FORM_PREFIX,
     _analysis_is_write,
     _analysis_rows,
     _analysis_rows_with_permissions,
@@ -295,6 +296,7 @@ class ExecuteWriteView(BaseView):
                 "execute_write_columns": execute_write_columns,
                 "execute_write_display_rows": execute_write_display_rows,
                 "execute_write_truncated": execute_write_truncated,
+                "sql_parameter_name_prefix": SQL_PARAMETER_FORM_PREFIX,
                 "execute_disabled": bool(execute_disabled_reason),
                 "execute_disabled_reason": execute_disabled_reason,
                 "table_columns": table_columns,
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 9efe3f81..026a999f 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -49,6 +49,8 @@ _query_write_fields = {
     "on_error_redirect",
 }
 
+SQL_PARAMETER_FORM_PREFIX = "_sql_param_"
+
 
 class QueryValidationError(Exception):
     def __init__(self, message, status=400, *, flash=False):
@@ -289,11 +291,13 @@ def _coerce_execute_write_payload(data, is_json):
             )
         params = data.get("params") or {}
     else:
-        params = {
-            key: value
-            for key, value in data.items()
-            if key not in {"sql", "csrftoken", "_json"}
-        }
+        params = {}
+        for key, value in data.items():
+            if key in {"sql", "csrftoken", "_json"}:
+                continue
+            if key.startswith(SQL_PARAMETER_FORM_PREFIX):
+                key = key[len(SQL_PARAMETER_FORM_PREFIX) :]
+            params[key] = value
     if not isinstance(params, dict):
         raise QueryValidationError("params must be a dictionary")
     return data.get("sql"), params
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 64f91701..b7ceb6b2 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -794,6 +794,44 @@ async def test_update_row_alter(ds_write):
     assert response.json() == {"ok": True}
 
 
+@pytest.mark.asyncio
+async def test_execute_write_form_parameter_called_sql():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_parameter_sql", name="data")
+    await db.execute_write("create table docs (id integer primary key, title text)")
+    await db.execute_write("insert into docs (id, title) values (1, 'Initial')")
+    await ds.invoke_startup()
+
+    form_response = await ds.client.get(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        params={"sql": "update docs set title = :sql where id = :id"},
+    )
+    assert form_response.status_code == 200
+    assert 'data-parameter-name-prefix="_sql_param_"' in form_response.text
+    assert '<label for="qp1">sql</label>' in form_response.text
+    assert 'name="_sql_param_sql"' in form_response.text
+    assert 'data-parameter-name="sql"' in form_response.text
+    assert 'name="_sql_param_id"' in form_response.text
+
+    response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        data={
+            "sql": "update docs set title = :sql where id = :id",
+            "_sql_param_sql": "Updated",
+            "_sql_param_id": "1",
+        },
+    )
+
+    assert response.status_code == 200
+    assert "Query executed, 1 row affected" in response.text
+    assert (await db.execute("select title from docs where id = 1")).first()[
+        0
+    ] == "Updated"
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "input,expected_errors",
diff --git a/tests/test_html.py b/tests/test_html.py
index bb7f612e..20ab22bc 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -342,7 +342,7 @@ async def test_query_parameter_form_fields(ds_client):
     response = await ds_client.get("/fixtures/-/query?sql=select+:name")
     assert response.status_code == 200
     assert (
-        '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="" data-parameter-control>'
+        '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="" data-parameter-control data-parameter-name="name">'
         in response.text
     )
     assert 'data-parameters-url="/fixtures/-/query/parameters"' in response.text
@@ -351,7 +351,7 @@ async def test_query_parameter_form_fields(ds_client):
     response2 = await ds_client.get("/fixtures/-/query?sql=select+:name&name=hello")
     assert response2.status_code == 200
     assert (
-        '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="hello" data-parameter-control>'
+        '<label for="qp1">name</label> <input type="text" id="qp1" name="name" value="hello" data-parameter-control data-parameter-name="name">'
         in response2.text
     )
 
diff --git a/tests/test_stored_queries.py b/tests/test_stored_queries.py
index 2c648d5f..46420749 100644
--- a/tests/test_stored_queries.py
+++ b/tests/test_stored_queries.py
@@ -201,7 +201,7 @@ def test_error_in_on_success_message_sql(stored_write_client):
 def test_custom_params(stored_write_client):
     response = stored_write_client.get("/data/update_name?extra=foo")
     assert (
-        '<input type="text" id="qp3" name="extra" value="foo" data-parameter-control>'
+        '<input type="text" id="qp3" name="extra" value="foo" data-parameter-control data-parameter-name="extra">'
         in response.text
     )
 

From f4b450603559b6a6412ed67e9eb170255dd1ab6b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 21:49:23 -0700
Subject: [PATCH 152/386] Remove legacy ?_extras= row parameter

The pre-1.0 ?_extras= (plural) parameter was kept for backwards
compatibility with the old row JSON API. ?_extra= is the documented
mechanism now that row pages share the extras registry.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/row.py | 5 -----
 tests/test_api.py      | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/datasette/views/row.py b/datasette/views/row.py
index 3fe213d7..ce15a822 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -165,13 +165,8 @@ class RowView(DataView):
             "primary_key_values": pk_values,
         }
 
-        # Handle _extra parameter (new style)
         extras = _get_extras(request)
 
-        # Also support legacy _extras parameter for backward compatibility
-        if "foreign_key_tables" in (request.args.get("_extras") or "").split(","):
-            extras.add("foreign_key_tables")
-
         # Process extras
         row_extra_context = RowExtraContext(
             datasette=self.ds,
diff --git a/tests/test_api.py b/tests/test_api.py
index e1385b6f..f57d0206 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -383,7 +383,7 @@ async def test_row_strange_table_name(ds_client):
 @pytest.mark.asyncio
 async def test_row_foreign_key_tables(ds_client):
     response = await ds_client.get(
-        "/fixtures/simple_primary_key/1.json?_extras=foreign_key_tables"
+        "/fixtures/simple_primary_key/1.json?_extra=foreign_key_tables"
     )
     assert response.status_code == 200
     # Foreign keys are sorted by (other_table, column, other_column)

From d825d8c4f38d980356abc50c739a440585253062 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 21:53:41 -0700
Subject: [PATCH 153/386] Remove _get_extras() shim in favor of
 extra_names_from_request()

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/row.py   | 5 +++--
 datasette/views/table.py | 6 +-----
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/datasette/views/row.py b/datasette/views/row.py
index ce15a822..c6721ca0 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -14,7 +14,8 @@ from datasette.plugins import pm
 import json
 import markupsafe
 import sqlite_utils
-from .table import display_columns_and_rows, _get_extras
+from datasette.extras import extra_names_from_request
+from .table import display_columns_and_rows
 from .table_extras import RowExtraContext, resolve_row_extras, table_extra_registry
 
 
@@ -165,7 +166,7 @@ class RowView(DataView):
             "primary_key_values": pk_values,
         }
 
-        extras = _get_extras(request)
+        extras = extra_names_from_request(request)
 
         # Process extras
         row_extra_context = RowExtraContext(
diff --git a/datasette/views/table.py b/datasette/views/table.py
index c2d520f8..1b298c50 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -854,10 +854,6 @@ class TableDropView(BaseView):
         return Response.json({"ok": True}, status=200)
 
 
-def _get_extras(request):
-    return extra_names_from_request(request)
-
-
 async def _columns_to_select(table_columns, pks, request):
     columns = list(table_columns)
     if "_col" in request.args:
@@ -1461,7 +1457,7 @@ async def table_view_data(
     rows = rows[:page_size]
 
     # Resolve extras
-    extras = _get_extras(request)
+    extras = extra_names_from_request(request)
     if any(k for k in request.args.keys() if k == "_facet" or k.startswith("_facet_")):
         extras.add("facet_results")
     if request.args.get("_shape") == "object":

From df8a61450b478e66c458b3f05c286daeb2c2a6b0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 21:57:02 -0700
Subject: [PATCH 154/386] Remove hasattr/getattr probing from multi-scope
 extras

TableExtraContext, RowExtraContext and QueryExtraContext now share
normalized table_name, is_view, pks and query_name fields (defaulting
to None/False where inapplicable) so DebugExtra, RenderCellExtra and
RenderersExtra can read them directly. RenderCellExtra uses
context.columns in every scope - the table and row views both derive
columns from results.description so output is unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/row.py          |  1 -
 datasette/views/table_extras.py | 30 +++++++++++++-----------------
 2 files changed, 13 insertions(+), 18 deletions(-)

diff --git a/datasette/views/row.py b/datasette/views/row.py
index c6721ca0..e15dfce9 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -179,7 +179,6 @@ class RowView(DataView):
             private=private,
             rows=rows,
             columns=columns,
-            results_description=results.description,
             pks=pks,
             pk_values=pk_values,
             sql=resolved.sql,
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index ec104be3..63c87a6f 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -53,6 +53,7 @@ class TableExtraContext:
     extra_registry: ExtraRegistry
     display_columns_and_rows: object
     run_sequential: object
+    query_name: str | None = None
     scope: ExtraScope = ExtraScope.TABLE
 
 
@@ -67,7 +68,6 @@ class RowExtraContext:
     private: bool
     rows: list
     columns: list
-    results_description: list
     pks: list
     pk_values: list
     sql: str
@@ -75,6 +75,7 @@ class RowExtraContext:
     extras: set
     extra_registry: ExtraRegistry
     foreign_key_tables: object
+    is_view: bool = False
     scope: ExtraScope = ExtraScope.ROW
 
 
@@ -96,6 +97,9 @@ class QueryExtraContext:
     metadata: dict
     extras: set
     extra_registry: ExtraRegistry
+    table_name: str | None = None
+    is_view: bool = False
+    pks: list | None = None
     scope: ExtraScope = ExtraScope.QUERY
 
 
@@ -383,6 +387,8 @@ class DebugExtra(Extra):
         }
         if context.scope == ExtraScope.TABLE:
             debug["resolved"] = repr(context.resolved)
+            debug["nofacet"] = context.nofacet
+            debug["nosuggest"] = context.nosuggest
         elif context.scope == ExtraScope.ROW:
             debug["resolved"] = {
                 "table": context.table_name,
@@ -391,10 +397,6 @@ class DebugExtra(Extra):
                 "pks": context.pks,
                 "pk_values": context.pk_values,
             }
-        if hasattr(context, "nofacet"):
-            debug["nofacet"] = context.nofacet
-        if hasattr(context, "nosuggest"):
-            debug["nosuggest"] = context.nosuggest
         return debug
 
 
@@ -527,16 +529,10 @@ class RenderCellExtra(Extra):
     scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
-        table_name = getattr(context, "table_name", None)
-        is_view = getattr(context, "is_view", False)
-        pks = getattr(context, "pks", [])
-        pks_for_display = (
-            pks if pks else (["rowid"] if table_name and not is_view else [])
+        table_name = context.table_name
+        pks_for_display = context.pks or (
+            ["rowid"] if table_name and not context.is_view else []
         )
-        if hasattr(context, "results_description"):
-            col_names = [col[0] for col in context.results_description]
-        else:
-            col_names = context.columns
         ct_map = (
             await context.datasette.get_column_types(context.database_name, table_name)
             if table_name
@@ -545,7 +541,7 @@ class RenderCellExtra(Extra):
         rendered_rows = []
         for row in context.rows:
             rendered_row = {}
-            for value, column in zip(row, col_names):
+            for value, column in zip(row, context.columns):
                 ct = ct_map.get(column)
                 plugin_display_value = None
                 if ct:
@@ -869,7 +865,7 @@ class RenderersExtra(Extra):
         url_labels_extra = {}
         if expandable_columns:
             url_labels_extra = {"_labels": "on"}
-        table_name = getattr(context, "table_name", None)
+        table_name = context.table_name
         view_name = "table" if context.scope == ExtraScope.TABLE else "database"
         for key, (_, can_render) in context.datasette.renderers.items():
             it_can_render = call_with_supported_arguments(
@@ -878,7 +874,7 @@ class RenderersExtra(Extra):
                 columns=context.columns or [],
                 rows=context.rows or [],
                 sql=query.get("sql", None),
-                query_name=getattr(context, "query_name", None),
+                query_name=context.query_name,
                 database=context.database_name,
                 table=table_name,
                 request=context.request,

From ab62ec96d187fa05f7d672d48a0b3f962fb8c228 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 22:45:13 -0700
Subject: [PATCH 155/386] Fix _extra=private for arbitrary SQL query pages

QueryView hardcoded private=False unless the request was for a stored
query, so /db/-/query.json?_extra=private reported false even when
execute-sql was restricted to the authenticated actor. Use
check_visibility() like the table and row views do.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/database.py |  6 ++++--
 tests/test_table_api.py     | 23 +++++++++++++++++++++++
 2 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index 96a58758..e6efddea 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -612,11 +612,13 @@ class QueryView(View):
                 )
 
         else:
-            await datasette.ensure_permission(
+            visible, private = await datasette.check_visibility(
+                request.actor,
                 action="execute-sql",
                 resource=DatabaseResource(database=database),
-                actor=request.actor,
             )
+            if not visible:
+                raise Forbidden("execute-sql")
 
         # Flattened because of ?sql=&name1=value1&name2=value2 feature
         params = {key: request.args.get(key) for key in request.args}
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 388e3979..4ab2f596 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -117,6 +117,29 @@ async def test_query_extras_for_stored_query(ds_client):
     }
 
 
+def test_query_extra_private_for_arbitrary_sql():
+    with make_app_client(config={"allow_sql": {"id": "root"}}) as client:
+        cookies = {"ds_actor": client.actor_cookie({"id": "root"})}
+        response = client.get(
+            "/fixtures/-/query.json?sql=select+1+as+one&_extra=private",
+            cookies=cookies,
+        )
+        assert response.status == 200
+        assert response.json["private"] is True
+        # Anonymous users cannot execute SQL at all here
+        anon = client.get("/fixtures/-/query.json?sql=select+1+as+one")
+        assert anon.status == 403
+
+
+def test_query_extra_private_false_when_sql_is_public():
+    with make_app_client() as client:
+        response = client.get(
+            "/fixtures/-/query.json?sql=select+1+as+one&_extra=private"
+        )
+        assert response.status == 200
+        assert response.json["private"] is False
+
+
 @pytest.mark.asyncio
 async def test_table_shape_objects(ds_client):
     response = await ds_client.get("/fixtures/simple_primary_key.json?_shape=objects")

From 8f888515b618bc0eb18e23c861b938b6bbbbf5d2 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 22:47:26 -0700
Subject: [PATCH 156/386] Fix _extra=query to report the params that were
 actually bound

QueryExtra re-derived named parameters from the SQL with a regex,
which missed parameters declared in a stored query's params list,
reported magic _-prefixed parameters with raw querystring values that
were never bound, and echoed the entire querystring when no SQL was
present. QueryView now passes its named_parameter_values dict - the
parameters it actually bound - through QueryExtraContext.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/database.py     |  2 +-
 datasette/views/table_extras.py | 11 +---------
 tests/test_table_api.py         | 38 +++++++++++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 11 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index e6efddea..a719fa4f 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -717,7 +717,7 @@ class QueryView(View):
                 rows=rows,
                 columns=columns,
                 sql=sql,
-                params=params_for_query,
+                params=named_parameter_values,
                 query_name=stored_query.name if stored_query else None,
                 stored_query=stored_query,
                 stored_query_write=stored_query_write,
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index 63c87a6f..21a908a0 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -8,7 +8,6 @@ from datasette.resources import TableResource
 from datasette.utils import (
     await_me_maybe,
     call_with_supported_arguments,
-    named_parameters as derive_named_parameters,
     path_with_added_args,
     path_with_format,
     path_with_removed_args,
@@ -592,17 +591,9 @@ class QueryExtra(Extra):
     scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
 
     async def resolve(self, context):
-        params = context.params
-        if context.scope == ExtraScope.QUERY and context.sql:
-            parameter_names = set(derive_named_parameters(context.sql))
-            params = {
-                key: value
-                for key, value in dict(context.params).items()
-                if key in parameter_names
-            }
         return {
             "sql": context.sql,
-            "params": params,
+            "params": context.params,
         }
 
 
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 4ab2f596..cfa3b512 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -131,6 +131,44 @@ def test_query_extra_private_for_arbitrary_sql():
         assert anon.status == 403
 
 
+def test_query_extra_query_reports_bound_params():
+    config = {
+        "databases": {
+            "fixtures": {
+                "queries": {
+                    "declared_params": {
+                        "sql": "select 1 as one",
+                        "params": ["foo"],
+                    },
+                    "magic_host": {
+                        "sql": "select :_header_host as h",
+                    },
+                }
+            }
+        }
+    }
+    with make_app_client(config=config) as client:
+        # Declared parameters are reported even when the regex cannot find them
+        response = client.get("/fixtures/declared_params.json?foo=bar&_extra=query")
+        assert response.status == 200
+        assert response.json["query"]["params"] == {"foo": "bar"}
+        # Magic parameters are bound internally and should not be reported,
+        # especially not as a value taken from the querystring
+        response = client.get(
+            "/fixtures/magic_host.json?_extra=query&_header_host=spoofed"
+        )
+        assert response.status == 200
+        assert response.json["rows"] == [{"h": "localhost"}]
+        assert response.json["query"]["params"] == {}
+
+
+def test_query_extra_query_does_not_echo_querystring_without_sql():
+    with make_app_client() as client:
+        response = client.get("/fixtures/-/query.json?_extra=query&foo=bar")
+        assert response.status == 200
+        assert response.json["query"]["params"] == {}
+
+
 def test_query_extra_private_false_when_sql_is_public():
     with make_app_client() as client:
         response = client.get(

From b635dc53f42e06908c7510d743e85100a6488f22 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 22:50:44 -0700
Subject: [PATCH 157/386] Make filters, actions and display_rows extras
 internal

These three extras return values that exist for the HTML templates -
a Filters instance, an async function and markupsafe/sqlite3.Row data
- so requesting them on a .json page returned a 500 serialization
error, while the generated documentation and ?_extra=extras both
advertised them as API surface. They are now public=False: ignored
like any unknown name on JSON requests, omitted from the docs and the
extras list, and still resolved for the HTML view via the new
include_internal flag on ExtraRegistry.resolve().

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/extras.py             | 17 ++++++++---------
 datasette/views/table.py        |  9 ++++++++-
 datasette/views/table_extras.py | 12 ++++++++++--
 docs/json_api.rst               |  9 ---------
 tests/test_table_api.py         | 18 ++++++++++++++++++
 5 files changed, 44 insertions(+), 21 deletions(-)

diff --git a/datasette/extras.py b/datasette/extras.py
index f655e517..d5847937 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -89,7 +89,7 @@ class ExtraRegistry:
     def public_classes_for_scope(self, scope):
         return self.classes_for_scope(scope, include_internal=False)
 
-    async def resolve(self, requested, context, scope):
+    async def resolve(self, requested, context, scope, include_internal=False):
         registry = Registry()
 
         async def context_provider():
@@ -100,15 +100,14 @@ class ExtraRegistry:
         for cls in self.classes_for_scope(scope):
             registry.register(cls().resolve, name=cls.key())
 
-        public_names = {cls.key() for cls in self.public_classes_for_scope(scope)}
-        requested_public_names = [
-            name
-            for name in requested
-            if name in public_names and name in registry._registry
-        ]
-        resolved = await registry.resolve_multi(requested_public_names)
+        allowed_names = {
+            cls.key()
+            for cls in self.classes_for_scope(scope, include_internal=include_internal)
+        }
+        requested_names = [name for name in requested if name in allowed_names]
+        resolved = await registry.resolve_multi(requested_names)
         return {
-            name: resolved[name] for name in requested_public_names if name in resolved
+            name: resolved[name] for name in requested_names if name in resolved
         }
 
 
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 1b298c50..3cf8e6c6 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1518,7 +1518,14 @@ async def table_view_data(
         "ok": True,
         "next": next_value and str(next_value) or None,
     }
-    data.update(await resolve_table_extras(extras, table_extra_context))
+    data.update(
+        await resolve_table_extras(
+            extras,
+            table_extra_context,
+            # The HTML view needs extras that are not JSON serializable
+            include_internal=bool(extra_extras),
+        )
+    )
     raw_sqlite_rows = rows[:page_size]
     # Apply transform_value for columns with assigned types
     ct_map = await datasette.get_column_types(database_name, table_name)
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index 21a908a0..c98ae22c 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -333,6 +333,8 @@ class PrimaryKeysExtra(Extra):
 class ActionsExtra(Extra):
     description = "Table or view actions made available by plugin hooks"
     scopes = frozenset({ExtraScope.TABLE})
+    # Returns an async function for the HTML templates - not JSON serializable
+    public = False
 
     async def resolve(self, context):
         async def actions():
@@ -476,6 +478,8 @@ class DisplayColumnsExtra(Extra):
 class DisplayRowsExtra(Extra):
     description = "Row data formatted for the HTML table display"
     scopes = frozenset({ExtraScope.TABLE})
+    # Contains markupsafe/sqlite3.Row values - not JSON serializable
+    public = False
 
     async def resolve(self, context, display_columns_and_rows):
         return display_columns_and_rows["rows"]
@@ -772,6 +776,8 @@ class FormHiddenArgsExtra(Extra):
 class FiltersExtra(Extra):
     description = "Filters object used by the HTML table interface"
     scopes = frozenset({ExtraScope.TABLE})
+    # Returns a Filters instance for the HTML templates - not JSON serializable
+    public = False
 
     async def resolve(self, context):
         return context.filters
@@ -1034,8 +1040,10 @@ TABLE_EXTRA_CLASSES = [
 table_extra_registry = ExtraRegistry(TABLE_EXTRA_CLASSES)
 
 
-async def resolve_table_extras(extras, context):
-    return await table_extra_registry.resolve(extras, context, ExtraScope.TABLE)
+async def resolve_table_extras(extras, context, include_internal=False):
+    return await table_extra_registry.resolve(
+        extras, context, ExtraScope.TABLE, include_internal=include_internal
+    )
 
 
 async def resolve_row_extras(extras, context):
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 379d26a0..6b595577 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -425,9 +425,6 @@ The available table extras are listed below.
           }
         ]
 
-``display_rows``
-    Row data formatted for the HTML table display
-
 ``render_cell``
     Rendered HTML for each cell using the render_cell plugin hook
 
@@ -554,12 +551,6 @@ The available table extras are listed below.
 
         "9403e5"
 
-``actions``
-    Table or view actions made available by plugin hooks
-
-``filters``
-    Filters object used by the HTML table interface
-
 ``renderers``
     Alternative output renderers available for this table
 
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index cfa3b512..0cb67164 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -117,6 +117,24 @@ async def test_query_extras_for_stored_query(ds_client):
     }
 
 
+@pytest.mark.parametrize("extra", ["filters", "actions", "display_rows"])
+@pytest.mark.asyncio
+async def test_html_only_extras_are_not_available_via_json(ds_client, extra):
+    # These extras exist for the HTML view; their values are not JSON
+    # serializable so they are internal, not part of the JSON API
+    response = await ds_client.get(f"/fixtures/facetable.json?_extra={extra}")
+    assert response.status_code == 200
+    assert extra not in response.json()
+
+
+@pytest.mark.asyncio
+async def test_html_only_extras_are_not_advertised(ds_client):
+    response = await ds_client.get("/fixtures/facetable.json?_extra=extras")
+    assert response.status_code == 200
+    names = {e["name"] for e in response.json()["extras"]}
+    assert {"filters", "actions", "display_rows"}.isdisjoint(names)
+
+
 def test_query_extra_private_for_arbitrary_sql():
     with make_app_client(config={"allow_sql": {"id": "root"}}) as client:
         cookies = {"ds_actor": client.actor_cookie({"id": "root"})}

From bbf0424c4519441715f73ee6468e0c53cc959861 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 22:51:25 -0700
Subject: [PATCH 158/386] Changelog for row/query extras and related fixes

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 docs/changelog.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 75e4f3e8..19089dd1 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -10,6 +10,13 @@ Changelog
 -------------------
 
 - Stored queries can now be edited and deleted from the web interface. The stored query page gained a "Query actions" menu with **Edit this query** and **Delete this query** links for actors with the necessary permissions. The owner of a query can always edit or delete it; for queries that are not private, any actor with the :ref:`update-query <actions_update_query>` or :ref:`delete-query <actions_delete_query>` permission can do so too. Private queries remain editable and deletable only by their owner. See :ref:`stored_queries` for details. (:issue:`2735`)
+- Row and query JSON pages now support the same ``?_extra=`` mechanism as table pages. Row pages can request extras such as ``foreign_key_tables``, ``query``, ``metadata`` and ``database_color``; arbitrary SQL and stored query pages can request extras such as ``columns``, ``query``, ``metadata`` and ``private``. The implementation was refactored into a registry of extra classes shared by all three page types. See :ref:`json_api_extra` for the full list.
+- New generated reference documentation for every ``?_extra=`` parameter available on table, row and query JSON pages, with example output captured from a live Datasette instance at documentation build time. See :ref:`json_api_extra`.
+- ``?_extra=`` values can be separated by commas as well as repeated, e.g. ``?_extra=count,next_url``. Previously a comma-separated value that included ``columns`` failed to include the ``columns`` key in the response.
+- The ``?_extra=private`` extra on arbitrary SQL query pages now correctly reflects whether the SQL execution permission is private to the current actor - it previously always returned ``false``.
+- The ``?_extra=query`` extra on query pages now reports the named parameters that were actually bound when the query executed, including parameters declared in a stored query's ``params`` list. Magic ``_``-prefixed parameters are no longer echoed back with unbound values taken from the querystring.
+- Extras that exist to serve the HTML interface (``filters``, ``actions``, ``display_rows``) are no longer advertised or reachable through the JSON API, where requesting them previously returned a 500 serialization error.
+- The pre-1.0 ``?_extras=`` (plural) parameter on row pages has been removed - use ``?_extra=foreign_key_tables`` instead.
 
 .. _v1_0_a32:
 

From 6babd23cec9c41edd3d0ba2fab1c319905446b21 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 22:53:00 -0700
Subject: [PATCH 159/386] QueryView: only resolve extras for renderer formats,
 single metadata path

Extras were resolved before the format dispatch, so a .csv request
carrying ?_extra= parameters paid for extras (including per-cell
render_cell plugin calls) whose results were then discarded, and the
HTML path duplicated the stored-query metadata derivation. Extras now
resolve inside the renderer-dispatch branch only, and both consumers
share a query_metadata() helper that no longer fetches database
metadata just to throw it away for stored queries.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/database.py | 55 ++++++++++++++++++-------------------
 1 file changed, 26 insertions(+), 29 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index a719fa4f..ad3fb843 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -700,33 +700,12 @@ class QueryView(View):
             except DatasetteError:
                 raise
 
-        extras = extra_names_from_request(request)
-        metadata = None
-        data = {"ok": True, "rows": rows, "columns": columns}
-        if extras:
-            metadata = await datasette.get_database_metadata(database)
+        async def query_metadata():
             if stored_query:
                 metadata = stored_query_to_dict(stored_query)
                 metadata.pop("source", None)
-            query_extra_context = QueryExtraContext(
-                datasette=datasette,
-                request=request,
-                db=db,
-                database_name=database,
-                private=private,
-                rows=rows,
-                columns=columns,
-                sql=sql,
-                params=named_parameter_values,
-                query_name=stored_query.name if stored_query else None,
-                stored_query=stored_query,
-                stored_query_write=stored_query_write,
-                error=query_error,
-                metadata=metadata,
-                extras=extras,
-                extra_registry=table_extra_registry,
-            )
-            data.update(await resolve_query_extras(extras, query_extra_context))
+                return metadata
+            return await datasette.get_database_metadata(database)
 
         # Handle formats from plugins
         if format_ == "csv":
@@ -740,6 +719,28 @@ class QueryView(View):
 
             return await stream_csv(datasette, fetch_data_for_csv, request, db.name)
         elif format_ in datasette.renderers.keys():
+            data = {"ok": True, "rows": rows, "columns": columns}
+            extras = extra_names_from_request(request)
+            if extras:
+                query_extra_context = QueryExtraContext(
+                    datasette=datasette,
+                    request=request,
+                    db=db,
+                    database_name=database,
+                    private=private,
+                    rows=rows,
+                    columns=columns,
+                    sql=sql,
+                    params=named_parameter_values,
+                    query_name=stored_query.name if stored_query else None,
+                    stored_query=stored_query,
+                    stored_query_write=stored_query_write,
+                    error=query_error,
+                    metadata=await query_metadata(),
+                    extras=extras,
+                    extra_registry=table_extra_registry,
+                )
+                data.update(await resolve_query_extras(extras, query_extra_context))
             # Dispatch request to the correct output format renderer
             # (CSV is not handled here due to streaming)
             result = call_with_supported_arguments(
@@ -806,11 +807,7 @@ class QueryView(View):
                     )
                 }
             )
-            if metadata is None:
-                metadata = await datasette.get_database_metadata(database)
-                if stored_query:
-                    metadata = stored_query_to_dict(stored_query)
-                    metadata.pop("source", None)
+            metadata = await query_metadata()
             renderers = {}
             for key, (_, can_render) in datasette.renderers.items():
                 it_can_render = call_with_supported_arguments(

From a1b6a6976d0ddafba6b927ce9fb83e62cb9091c3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 22:55:28 -0700
Subject: [PATCH 160/386] Remove dead weight from the extras machinery

- TableExtraContext.next_value, RowExtraContext.resolved and
  QueryExtraContext.stored_query/stored_query_write/error had no
  readers - drop the fields and the arguments that populated them
- Extra.documentation() and the stable classvar were unused parallel
  descriptions of what the docs generator reads directly
- ExtraRegistry.resolve no longer carries an always-true membership
  guard (resolve_multi returns every requested registered name)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/extras.py             | 19 +------------------
 datasette/views/database.py     |  3 ---
 datasette/views/row.py          |  1 -
 datasette/views/table.py        |  1 -
 datasette/views/table_extras.py |  5 -----
 5 files changed, 1 insertion(+), 28 deletions(-)

diff --git a/datasette/extras.py b/datasette/extras.py
index d5847937..4aa93057 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -50,7 +50,6 @@ class Extra(Provider):
     example: ClassVar[ExtraExample | None] = None
     examples: ClassVar[dict[ExtraScope, ExtraExample | list[ExtraExample]]] = {}
     public: ClassVar[bool] = True
-    stable: ClassVar[bool] = True
     expensive: ClassVar[bool] = False
     docs_note: ClassVar[str | None] = None
 
@@ -58,20 +57,6 @@ class Extra(Provider):
     def example_for_scope(cls, scope):
         return cls.examples.get(scope, cls.example)
 
-    @classmethod
-    def documentation(cls):
-        return {
-            "name": cls.key(),
-            "description": cls.description,
-            "scopes": [
-                scope.value for scope in sorted(cls.scopes, key=lambda s: s.value)
-            ],
-            "stable": cls.stable,
-            "expensive": cls.expensive,
-            "docs_note": cls.docs_note,
-            "example": cls.example,
-        }
-
 
 class ExtraRegistry:
     def __init__(self, classes):
@@ -106,9 +91,7 @@ class ExtraRegistry:
         }
         requested_names = [name for name in requested if name in allowed_names]
         resolved = await registry.resolve_multi(requested_names)
-        return {
-            name: resolved[name] for name in requested_names if name in resolved
-        }
+        return {name: resolved[name] for name in requested_names}
 
 
 def _camel_to_snake(name):
diff --git a/datasette/views/database.py b/datasette/views/database.py
index ad3fb843..46e26496 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -733,9 +733,6 @@ class QueryView(View):
                     sql=sql,
                     params=named_parameter_values,
                     query_name=stored_query.name if stored_query else None,
-                    stored_query=stored_query,
-                    stored_query_write=stored_query_write,
-                    error=query_error,
                     metadata=await query_metadata(),
                     extras=extras,
                     extra_registry=table_extra_registry,
diff --git a/datasette/views/row.py b/datasette/views/row.py
index e15dfce9..c300758b 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -172,7 +172,6 @@ class RowView(DataView):
         row_extra_context = RowExtraContext(
             datasette=self.ds,
             request=request,
-            resolved=resolved,
             db=db,
             database_name=database,
             table_name=table,
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 3cf8e6c6..65388c9c 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1497,7 +1497,6 @@ async def table_view_data(
         nofacet=nofacet,
         nosuggest=nosuggest,
         next_arg=request.args.get("_next"),
-        next_value=next_value,
         next_url=next_url,
         sql=sql,
         sql_no_order_no_limit=sql_no_order_no_limit,
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index c98ae22c..493135f3 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -37,7 +37,6 @@ class TableExtraContext:
     nofacet: object
     nosuggest: object
     next_arg: object
-    next_value: object
     next_url: str | None
     sql: str
     sql_no_order_no_limit: str
@@ -60,7 +59,6 @@ class TableExtraContext:
 class RowExtraContext:
     datasette: object
     request: object
-    resolved: object
     db: object
     database_name: str
     table_name: str
@@ -90,9 +88,6 @@ class QueryExtraContext:
     sql: str | None
     params: dict
     query_name: str | None
-    stored_query: object
-    stored_query_write: bool
-    error: str | None
     metadata: dict
     extras: set
     extra_registry: ExtraRegistry

From cfafa5b37f5350303600e912955c43e210a113b7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 22:56:40 -0700
Subject: [PATCH 161/386] Use plain set literals for Extra scopes

frozenset({...}) was immutability ceremony for class attributes that
nothing mutates. scopes = {ExtraScope.TABLE} reads cleaner.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/extras.py             |  2 +-
 datasette/views/table_extras.py | 74 ++++++++++++++++-----------------
 2 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/datasette/extras.py b/datasette/extras.py
index 4aa93057..fee92939 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -30,7 +30,7 @@ class ExtraExample:
 
 class Provider:
     name: ClassVar[str | None] = None
-    scopes: ClassVar[frozenset[ExtraScope]] = frozenset()
+    scopes: ClassVar[set[ExtraScope]] = set()
     public: ClassVar[bool] = False
 
     @classmethod
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index 493135f3..ce1d7bdf 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -100,7 +100,7 @@ class QueryExtraContext:
 class CountSqlExtra(Extra):
     description = "SQL query used to calculate the total count"
     example = ExtraExample("/fixtures/facetable.json?_size=0&_extra=count_sql")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         return context.count_sql
@@ -109,7 +109,7 @@ class CountSqlExtra(Extra):
 class CountExtra(Extra):
     description = "Total count of rows matching these filters"
     example = ExtraExample("/fixtures/facetable.json?_extra=count")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
     expensive = True
 
     async def resolve(self, context):
@@ -141,7 +141,7 @@ class CountExtra(Extra):
 
 
 class FacetInstancesProvider(Provider):
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context, count):
         facet_instances = []
@@ -182,7 +182,7 @@ class FacetResultsExtra(Extra):
         },
         note="Shape abbreviated from /fixtures/facetable.json?_facet=state&_extra=facet_results.",
     )
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
     expensive = True
 
     async def resolve(self, context, facet_instances):
@@ -217,7 +217,7 @@ class FacetsTimedOutExtra(Extra):
     example = ExtraExample(
         "/fixtures/facetable.json?_facet=state&_extra=facets_timed_out"
     )
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context, facet_results):
         return facet_results["timed_out"]
@@ -234,7 +234,7 @@ class SuggestedFacetsExtra(Extra):
         ],
         note="Shape abbreviated from /fixtures/facetable.json?_extra=suggested_facets.",
     )
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
     expensive = True
 
     async def resolve(self, context, facet_instances):
@@ -259,7 +259,7 @@ class HumanDescriptionEnExtra(Extra):
     example = ExtraExample(
         "/fixtures/facetable.json?state=CA&_sort=pk&_extra=human_description_en"
     )
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         human_description_en = context.filters.human_description_en(
@@ -279,7 +279,7 @@ class HumanDescriptionEnExtra(Extra):
 class NextUrlExtra(Extra):
     description = "Full URL for the next page of results"
     example = ExtraExample("/fixtures/facetable.json?_size=1&_extra=next_url")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         return context.next_url
@@ -296,7 +296,7 @@ class ColumnsExtra(Extra):
             "/fixtures/-/query.json?sql=select+1+as+one&_extra=columns"
         ),
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         return context.columns
@@ -305,7 +305,7 @@ class ColumnsExtra(Extra):
 class AllColumnsExtra(Extra):
     description = "All columns in the table, regardless of _col/_nocol filtering"
     example = ExtraExample("/fixtures/facetable.json?_col=pk&_extra=all_columns")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         return list(context.table_columns)
@@ -319,7 +319,7 @@ class PrimaryKeysExtra(Extra):
             "/fixtures/simple_primary_key/1.json?_extra=primary_keys"
         )
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW}
 
     async def resolve(self, context):
         return context.pks
@@ -327,7 +327,7 @@ class PrimaryKeysExtra(Extra):
 
 class ActionsExtra(Extra):
     description = "Table or view actions made available by plugin hooks"
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
     # Returns an async function for the HTML templates - not JSON serializable
     public = False
 
@@ -358,7 +358,7 @@ class ActionsExtra(Extra):
 class IsViewExtra(Extra):
     description = "Whether this resource is a view instead of a table"
     example = ExtraExample("/fixtures/simple_view.json?_extra=is_view")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         return context.is_view
@@ -375,7 +375,7 @@ class DebugExtra(Extra):
             "/fixtures/-/query.json?sql=select+1+as+one&_extra=debug"
         ),
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         debug = {
@@ -407,7 +407,7 @@ class RequestExtra(Extra):
             "/fixtures/-/query.json?sql=select+1+as+one&_extra=request"
         ),
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         return {
@@ -420,7 +420,7 @@ class RequestExtra(Extra):
 
 
 class DisplayColumnsAndRowsProvider(Provider):
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         display_columns, display_rows = await context.display_columns_and_rows(
@@ -464,7 +464,7 @@ class DisplayColumnsExtra(Extra):
         ],
         note="Shape abbreviated from /fixtures/facetable.json?_size=1&_extra=display_columns.",
     )
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context, display_columns_and_rows):
         return display_columns_and_rows["columns"]
@@ -472,7 +472,7 @@ class DisplayColumnsExtra(Extra):
 
 class DisplayRowsExtra(Extra):
     description = "Row data formatted for the HTML table display"
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
     # Contains markupsafe/sqlite3.Row values - not JSON serializable
     public = False
 
@@ -524,7 +524,7 @@ class RenderCellExtra(Extra):
             ),
         ),
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         table_name = context.table_name
@@ -587,7 +587,7 @@ class QueryExtra(Extra):
             ExtraExample("/fixtures/neighborhood_search.json?text=town&_extra=query"),
         ],
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         return {
@@ -599,7 +599,7 @@ class QueryExtra(Extra):
 class ColumnTypesExtra(Extra):
     description = "Column type assignments for this table"
     example = ExtraExample(value={})
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW}
 
     async def resolve(self, context):
         ct_map = await context.datasette.get_column_types(
@@ -616,7 +616,7 @@ class ColumnTypesExtra(Extra):
 
 class SetColumnTypeUiExtra(Extra):
     description = "Column type UI metadata for this table"
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         if context.is_view:
@@ -676,7 +676,7 @@ class MetadataExtra(Extra):
             "/fixtures/neighborhood_search.json?text=town&_extra=metadata"
         ),
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         if context.scope == ExtraScope.QUERY:
@@ -713,7 +713,7 @@ class DatabaseExtra(Extra):
             "/fixtures/-/query.json?sql=select+1+as+one&_extra=database"
         ),
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         return context.database_name
@@ -725,7 +725,7 @@ class TableExtra(Extra):
     examples = {
         ExtraScope.ROW: ExtraExample("/fixtures/simple_primary_key/1.json?_extra=table")
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW}
 
     async def resolve(self, context):
         return context.table_name
@@ -742,7 +742,7 @@ class DatabaseColorExtra(Extra):
             "/fixtures/-/query.json?sql=select+1+as+one&_extra=database_color"
         ),
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         return context.db.color
@@ -753,7 +753,7 @@ class FormHiddenArgsExtra(Extra):
     example = ExtraExample(
         "/fixtures/facetable.json?_facet=state&_size=1&_extra=form_hidden_args"
     )
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         form_hidden_args = []
@@ -770,7 +770,7 @@ class FormHiddenArgsExtra(Extra):
 
 class FiltersExtra(Extra):
     description = "Filters object used by the HTML table interface"
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
     # Returns a Filters instance for the HTML templates - not JSON serializable
     public = False
 
@@ -781,7 +781,7 @@ class FiltersExtra(Extra):
 class CustomTableTemplatesExtra(Extra):
     description = "Custom template names considered for this table"
     example = ExtraExample("/fixtures/facetable.json?_extra=custom_table_templates")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         return [
@@ -796,7 +796,7 @@ class SortedFacetResultsExtra(Extra):
     example = ExtraExample(
         "/fixtures/facetable.json?_facet=state&_extra=sorted_facet_results"
     )
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context, facet_results):
         facet_configs = context.table_metadata.get("facets", [])
@@ -832,7 +832,7 @@ class SortedFacetResultsExtra(Extra):
 class TableDefinitionExtra(Extra):
     description = "SQL definition for this table"
     example = ExtraExample("/fixtures/facetable.json?_extra=table_definition")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         return await context.db.get_table_definition(context.table_name)
@@ -841,7 +841,7 @@ class TableDefinitionExtra(Extra):
 class ViewDefinitionExtra(Extra):
     description = "SQL definition for this view"
     example = ExtraExample("/fixtures/simple_view.json?_extra=view_definition")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         return await context.db.get_view_definition(context.table_name)
@@ -850,7 +850,7 @@ class ViewDefinitionExtra(Extra):
 class RenderersExtra(Extra):
     description = "Alternative output renderers available for this table"
     example = ExtraExample("/fixtures/facetable.json?_extra=renderers")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context, expandable_columns, query):
         renderers = {}
@@ -896,7 +896,7 @@ class PrivateExtra(Extra):
             "/fixtures/-/query.json?sql=select+1+as+one&_extra=private"
         ),
     }
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         return context.private
@@ -905,7 +905,7 @@ class PrivateExtra(Extra):
 class ExpandableColumnsExtra(Extra):
     description = "Foreign key columns that can be expanded with labels"
     example = ExtraExample("/fixtures/facetable.json?_extra=expandable_columns")
-    scopes = frozenset({ExtraScope.TABLE})
+    scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
         expandables = []
@@ -921,7 +921,7 @@ class ForeignKeyTablesExtra(Extra):
     example = ExtraExample(
         "/fixtures/simple_primary_key/1.json?_extra=foreign_key_tables"
     )
-    scopes = frozenset({ExtraScope.ROW})
+    scopes = {ExtraScope.ROW}
 
     async def resolve(self, context):
         return await context.foreign_key_tables(
@@ -931,7 +931,7 @@ class ForeignKeyTablesExtra(Extra):
 
 class ExtrasExtra(Extra):
     description = "Available ?_extra= blocks"
-    scopes = frozenset({ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY})
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
         all_extras = [

From 4edea3ad2637f4bf275f3a322e4c7747b964d907 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:04:12 -0700
Subject: [PATCH 162/386] Build extras registries once per scope instead of per
 request

ExtraRegistry.resolve() previously constructed a fresh asyncinject
Registry on every table, row and query request - instantiating all
~37 Extra classes and re-running inspect.signature reflection over
each resolve method every time. The Extra classes are stateless, so
the asyncinject Registry for each scope is now built lazily once and
shared, along with the allowed-name sets.

The per-request context reaches the shared registry through a
contextvars.ContextVar provider rather than resolve_multi(results=...)
seeding: asyncinject's parallel executor never schedules anything when
the only initially-ready node is an unregistered pre-seeded value, so
seeding would have stalled every resolution. asyncio tasks copy the
caller's context, which keeps concurrent resolves isolated - covered
by a new test.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/extras.py  | 63 ++++++++++++++++++++++++++++++++----------
 tests/test_extras.py | 65 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 113 insertions(+), 15 deletions(-)
 create mode 100644 tests/test_extras.py

diff --git a/datasette/extras.py b/datasette/extras.py
index fee92939..2c3450b2 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -1,3 +1,4 @@
+import contextvars
 import re
 from dataclasses import dataclass
 from enum import Enum
@@ -5,6 +6,11 @@ from typing import ClassVar
 
 from asyncinject import Registry
 
+# Per-request context for Extra.resolve(), so the asyncinject registries can
+# be shared across requests. asyncio tasks copy the caller's context, so
+# concurrent resolve() calls each see their own value.
+_resolve_context = contextvars.ContextVar("datasette_extras_context")
+
 
 def extra_names_from_request(request):
     extra_bits = request.args.getlist("_extra")
@@ -62,6 +68,13 @@ class ExtraRegistry:
     def __init__(self, classes):
         self.classes = list(classes)
         self.classes_by_name = {cls.key(): cls for cls in self.classes}
+        # Lazily-built shared state, keyed by scope. Safe to share across
+        # requests because Extra instances are stateless and asyncinject's
+        # Registry keeps per-call state local to each resolve_multi() call.
+        # If extras classes ever become registerable at runtime (e.g. via a
+        # plugin hook) these caches will need invalidating.
+        self._scope_registries = {}
+        self._allowed_names = {}
 
     def classes_for_scope(self, scope, include_internal=True):
         classes = [
@@ -74,23 +87,43 @@ class ExtraRegistry:
     def public_classes_for_scope(self, scope):
         return self.classes_for_scope(scope, include_internal=False)
 
+    def _registry_for_scope(self, scope):
+        registry = self._scope_registries.get(scope)
+        if registry is None:
+            registry = Registry()
+
+            async def context_provider():
+                return _resolve_context.get()
+
+            registry.register(context_provider, name="context")
+            for cls in self.classes_for_scope(scope):
+                registry.register(cls().resolve, name=cls.key())
+            self._scope_registries[scope] = registry
+        return registry
+
+    def _allowed_names_for_scope(self, scope, include_internal):
+        key = (scope, include_internal)
+        names = self._allowed_names.get(key)
+        if names is None:
+            names = {
+                cls.key()
+                for cls in self.classes_for_scope(
+                    scope, include_internal=include_internal
+                )
+            }
+            self._allowed_names[key] = names
+        return names
+
     async def resolve(self, requested, context, scope, include_internal=False):
-        registry = Registry()
-
-        async def context_provider():
-            return context
-
-        registry.register(context_provider, name="context")
-
-        for cls in self.classes_for_scope(scope):
-            registry.register(cls().resolve, name=cls.key())
-
-        allowed_names = {
-            cls.key()
-            for cls in self.classes_for_scope(scope, include_internal=include_internal)
-        }
+        allowed_names = self._allowed_names_for_scope(scope, include_internal)
         requested_names = [name for name in requested if name in allowed_names]
-        resolved = await registry.resolve_multi(requested_names)
+        token = _resolve_context.set(context)
+        try:
+            resolved = await self._registry_for_scope(scope).resolve_multi(
+                requested_names
+            )
+        finally:
+            _resolve_context.reset(token)
         return {name: resolved[name] for name in requested_names}
 
 
diff --git a/tests/test_extras.py b/tests/test_extras.py
new file mode 100644
index 00000000..ad8a9f00
--- /dev/null
+++ b/tests/test_extras.py
@@ -0,0 +1,65 @@
+import asyncio
+
+import pytest
+
+from datasette.extras import Extra, ExtraRegistry, ExtraScope
+
+
+class SlowValueExtra(Extra):
+    description = "Returns context['value'], optionally slowly"
+    scopes = {ExtraScope.TABLE}
+
+    async def resolve(self, context):
+        if context["slow"]:
+            await asyncio.sleep(0.05)
+        return context["value"]
+
+
+class DependentExtra(Extra):
+    description = "Depends on slow_value"
+    scopes = {ExtraScope.TABLE}
+
+    async def resolve(self, context, slow_value):
+        return slow_value + 1
+
+
+def test_registry_is_built_once_per_scope():
+    registry = ExtraRegistry([SlowValueExtra, DependentExtra])
+    first = registry._registry_for_scope(ExtraScope.TABLE)
+    second = registry._registry_for_scope(ExtraScope.TABLE)
+    assert first is second
+
+
+@pytest.mark.asyncio
+async def test_concurrent_resolves_do_not_share_state():
+    # The asyncinject registry is shared across requests - resolved values
+    # must not leak between concurrent resolve() calls with different contexts
+    registry = ExtraRegistry([SlowValueExtra, DependentExtra])
+    slow, fast = await asyncio.gather(
+        registry.resolve(
+            {"slow_value", "dependent"},
+            {"value": 100, "slow": True},
+            ExtraScope.TABLE,
+        ),
+        registry.resolve(
+            {"slow_value", "dependent"},
+            {"value": 200, "slow": False},
+            ExtraScope.TABLE,
+        ),
+    )
+    assert slow == {"slow_value": 100, "dependent": 101}
+    assert fast == {"slow_value": 200, "dependent": 201}
+
+
+@pytest.mark.asyncio
+async def test_table_row_and_query_scopes_use_separate_registries():
+    from datasette.views.table_extras import table_extra_registry
+
+    registries = {
+        scope: table_extra_registry._registry_for_scope(scope) for scope in ExtraScope
+    }
+    assert len(set(map(id, registries.values()))) == 3
+    # Scope-specific extras only registered where they belong
+    assert "count" in registries[ExtraScope.TABLE]._registry
+    assert "count" not in registries[ExtraScope.QUERY]._registry
+    assert "foreign_key_tables" in registries[ExtraScope.ROW]._registry

From 96226621325c5aa19e6a700efcd1b441006958fa Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:15:18 -0700
Subject: [PATCH 163/386] Fix SQL injection via bracket escape bypass in
 escape_sqlite() (#2677)

escape_sqlite() wrapped identifiers in [brackets] without escaping any ]
characters inside the string. Since SQLite does not support escaping ]
within bracket quoting, an identifier containing ] could break out and
inject arbitrary SQL. Fall back to double-quote quoting (doubling any
embedded ") when the identifier contains ].

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/utils/__init__.py |  4 ++++
 tests/test_utils.py         | 32 ++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+)

diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 2dff9667..55e539b9 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -410,6 +410,10 @@ def escape_css_string(s):
 def escape_sqlite(s):
     if _boring_keyword_re.match(s) and (s.lower() not in reserved_words):
         return s
+    elif "]" in s:
+        # SQLite does not support escaping ] inside [bracket] quoting, so fall
+        # back to double-quote quoting (doubling any embedded ") - #2677
+        return '"{}"'.format(s.replace('"', '""'))
     else:
         return f"[{s}]"
 
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 64607244..74f1963f 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -216,6 +216,38 @@ def test_detect_fts(open_quote, close_quote):
     conn.close()
 
 
+@pytest.mark.parametrize(
+    "identifier,expected",
+    (
+        ("plain", "plain"),
+        ("select", "[select]"),
+        ("has space", "[has space]"),
+        ("has'quote", "[has'quote]"),
+        # Identifiers containing ] must fall back to double-quote quoting
+        # (SQLite does not support escaping ] inside [brackets]) - #2677
+        ("has]bracket", '"has]bracket"'),
+        ('has"dquote]', '"has""dquote]"'),
+    ),
+)
+def test_escape_sqlite(identifier, expected):
+    assert utils.escape_sqlite(identifier) == expected
+
+
+def test_escape_sqlite_prevents_injection():
+    # https://github.com/simonw/datasette/issues/2677
+    conn = utils.sqlite3.connect(":memory:")
+    conn.execute("CREATE TABLE users (id INTEGER, password TEXT)")
+    conn.execute("INSERT INTO users VALUES (1, 'super_secret_password')")
+    malicious = "users] UNION SELECT password FROM users--"
+    conn.execute('CREATE TABLE "{}" (id INTEGER)'.format(malicious))
+    sql = "select count(*) from {}".format(utils.escape_sqlite(malicious))
+    results = conn.execute(sql).fetchall()
+    conn.close()
+    # The injected UNION must not execute - only the empty malicious table
+    # is queried, so we get a single count row and no leaked password
+    assert results == [(0,)]
+
+
 @pytest.mark.parametrize("table", ("regular", "has'single quote"))
 def test_detect_fts_different_table_names(table):
     sql = """

From 1c514d69f6cc09c820c119e7bbf4dc75235e90cc Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:17:16 -0700
Subject: [PATCH 164/386] Prevent open redirect via backslash in path (#2680)

asgi_send_redirect() only collapsed leading forward slashes, so a path
like /\example.com/ produced a Location of /\example.com. Browsers
normalise backslashes to forward slashes, turning that into the
protocol-relative //example.com and redirecting off-site. Collapse any
run of leading slashes and backslashes to a single slash.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/utils/asgi.py    |  8 +++++---
 tests/test_custom_pages.py | 21 +++++++++++++++++++++
 2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/datasette/utils/asgi.py b/datasette/utils/asgi.py
index 35f243b6..55eba1bb 100644
--- a/datasette/utils/asgi.py
+++ b/datasette/utils/asgi.py
@@ -330,9 +330,11 @@ async def asgi_send_html(send, html, status=200, headers=None):
 
 
 async def asgi_send_redirect(send, location, status=302):
-    # Prevent open redirect vulnerability: strip multiple leading slashes
-    # //example.com would be interpreted as a protocol-relative URL (e.g., https://example.com/)
-    location = re.sub(r"^/+", "/", location)
+    # Prevent open redirect vulnerability: collapse leading slashes and
+    # backslashes down to a single slash. //example.com is a protocol-relative
+    # URL, and browsers normalise backslashes to slashes so /\example.com would
+    # be treated as //example.com - https://github.com/simonw/datasette/issues/2680
+    location = re.sub(r"^[/\\]+", "/", location)
     await asgi_send(
         send,
         "",
diff --git a/tests/test_custom_pages.py b/tests/test_custom_pages.py
index 39a4c06b..86cdcc6b 100644
--- a/tests/test_custom_pages.py
+++ b/tests/test_custom_pages.py
@@ -104,3 +104,24 @@ def test_custom_route_pattern_with_slash_slash_302(custom_pages_client):
     response = custom_pages_client.get("//example.com/")
     assert response.status == 302
     assert response.headers["location"] == "/example.com"
+
+
+@pytest.mark.parametrize(
+    "path",
+    (
+        "/\\example.com/",
+        "/\\\\example.com/",
+        "/\\/example.com/",
+    ),
+)
+def test_redirect_does_not_allow_backslash_open_redirect(custom_pages_client, path):
+    # https://github.com/simonw/datasette/issues/2680
+    # Browsers normalise backslashes to forward slashes, so a Location of
+    # /\example.com would be treated as the protocol-relative //example.com
+    response = custom_pages_client.get(path)
+    assert response.status == 302
+    location = response.headers["location"]
+    assert location == "/example.com"
+    # Must not start with anything a browser reads as protocol-relative
+    assert not location.startswith("//")
+    assert not location.startswith("/\\")

From c31bb55011567d13f39d8096da4aef5b5a8a720a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:24:21 -0700
Subject: [PATCH 165/386] Add regression test for --default-deny index 500
 (#2644)

datasette --default-deny --root with no config file previously 500'd on
the instance and database index pages: rendering them computes is_private
(include_is_private=True), which references the anon_rules CTE, but that
CTE was only defined when anonymous permission rules existed.

This was fixed by the empty-anon_rules fallback added in 4b5fac9c; this
commit adds a regression test that fails without that fallback (SQLite
"no such table: anon_rules" -> 500).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 tests/test_default_deny.py | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tests/test_default_deny.py b/tests/test_default_deny.py
index 81e95b84..f1e43064 100644
--- a/tests/test_default_deny.py
+++ b/tests/test_default_deny.py
@@ -127,3 +127,23 @@ async def test_default_deny_basic_permissions():
 
     # Authenticated user without explicit permission should also be denied
     assert await ds.allowed(action="view-instance", actor={"id": "user"}) is False
+
+
+@pytest.mark.asyncio
+async def test_default_deny_root_no_config_index_does_not_500():
+    # https://github.com/simonw/datasette/issues/2644
+    # --default-deny --root with no config file must not 500 on the index
+    # pages. Rendering those pages computes is_private (include_is_private),
+    # which references the anon_rules CTE - that CTE must still be defined
+    # even when there are no anonymous permission rules at all.
+    ds = Datasette(default_deny=True)
+    ds.root_enabled = True
+    await ds.invoke_startup()
+    db = ds.add_memory_database("test_db_2644")
+    await db.execute_write("create table test_table (id integer primary key)")
+    await ds._refresh_schemas()
+
+    cookie = ds.sign({"a": {"id": "root"}}, "actor")
+    for path in ("/", "/test_db_2644", "/test_db_2644/test_table"):
+        response = await ds.client.get(path, cookies={"ds_actor": cookie})
+        assert response.status_code == 200, f"{path} returned {response.status_code}"

From d5141a5778ac5ce6a6f4cfda990b2ab556b7f9f2 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:27:13 -0700
Subject: [PATCH 166/386] Fix /-/check 500 for query actions (#2756)

_check_permission_for_actor() constructed child resources with
resource_class(database=parent, table=child), but QueryResource takes a
"query" argument, not "table", so /-/check?action=delete-query (and
view-query / update-query) raised TypeError. Construct the resource
positionally so it works for any child resource class.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/special.py |  8 +++++---
 tests/test_permissions.py  | 23 +++++++++++++++++++++++
 2 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/datasette/views/special.py b/datasette/views/special.py
index 75c54c3c..aa063ad6 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -497,11 +497,13 @@ async def _check_permission_for_actor(ds, action, parent, child, actor):
     if action_obj.resource_class is None:
         resource_obj = None
     elif action_obj.takes_parent and action_obj.takes_child:
-        # Child-level resource (e.g., TableResource, QueryResource)
-        resource_obj = action_obj.resource_class(database=parent, table=child)
+        # Child-level resource (e.g., TableResource, QueryResource). The child
+        # argument is named differently per resource class (table, query, ...),
+        # so pass positionally - https://github.com/simonw/datasette/issues/2756
+        resource_obj = action_obj.resource_class(parent, child)
     elif action_obj.takes_parent:
         # Parent-level resource (e.g., DatabaseResource)
-        resource_obj = action_obj.resource_class(database=parent)
+        resource_obj = action_obj.resource_class(parent)
     else:
         # This shouldn't happen given validation in Action.__post_init__
         return {"error": f"Invalid action configuration: {action}"}, 500
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index e5e75432..8323fe92 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -1733,6 +1733,29 @@ async def test_permission_check_view_requires_debug_permission():
     assert data["allowed"] is True
 
 
+@pytest.mark.asyncio
+@pytest.mark.parametrize("action", ("view-query", "update-query", "delete-query"))
+async def test_permission_check_view_query_actions(action):
+    # https://github.com/simonw/datasette/issues/2756
+    # QueryResource takes a "query" argument, not "table", so /-/check must
+    # not assume every child resource class accepts table=
+    ds = Datasette()
+    ds.root_enabled = True
+    root_token = await ds.create_token("root", handler="signed")
+    response = await ds.client.get(
+        f"/-/check.json?action={action}&parent=mydb&child=myquery",
+        headers={"Authorization": f"Bearer {root_token}"},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert data["action"] == action
+    assert data["resource"] == {
+        "parent": "mydb",
+        "child": "myquery",
+        "path": "/mydb/myquery",
+    }
+
+
 @pytest.mark.asyncio
 async def test_root_allow_block_with_table_restricted_actor():
     """

From 154ea483eaba7a636289a6972baeced7163acd60 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:30:12 -0700
Subject: [PATCH 167/386] Pass columns and rows to can_render for canned
 queries (#2711)

The HTML branch of QueryView built an empty data dict before looping
over register_output_renderer can_render callbacks, so renderers that
depend on the result columns or rows (e.g. datasette-atom,
datasette-ics) never appeared as export options for canned queries.
Populate data with the executed query's rows, columns, SQL and query
name.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/database.py | 10 +++++++++-
 tests/test_plugins.py       | 25 +++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index a1647ca9..66887f9b 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -762,7 +762,15 @@ class QueryView(View):
                     )
                 ),
             )
-            data = {}
+            data = {
+                "ok": query_error is None,
+                "rows": rows,
+                "columns": columns,
+                "query": {"sql": sql, "params": params},
+                "query_name": stored_query.name if stored_query else None,
+                "database": database,
+                "table": None,
+            }
             headers.update(
                 {
                     "Link": '<{}>; rel="alternate"; type="application/json+datasette"'.format(
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index 32276437..cf753c9e 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -626,6 +626,31 @@ async def test_hook_register_output_renderer_can_render(ds_client):
     }.items() <= ds_client.ds._can_render_saw.items()
 
 
+@pytest.mark.asyncio
+async def test_hook_register_output_renderer_can_render_canned_query(ds_client):
+    # https://github.com/simonw/datasette/issues/2711
+    # can_render for a canned query must be passed the query's columns, rows
+    # and SQL - previously it received an empty data dict, so renderers that
+    # depend on the columns (datasette-atom, datasette-ics) never showed up.
+    response = await ds_client.get("/fixtures/pragma_cache_size")
+    assert response.status_code == 200
+    saw = ds_client.ds._can_render_saw
+    assert saw["columns"] == ["cache_size"]
+    assert len(saw["rows"]) == 1
+    assert saw["sql"] == "PRAGMA cache_size;"
+    assert saw["query_name"] == "pragma_cache_size"
+    # The renderer's export link should therefore be offered
+    links = (
+        Soup(response.text, "html.parser")
+        .find("p", {"class": "export-links"})
+        .find_all("a")
+    )
+    actual = [link["href"] for link in links]
+    assert any(
+        href.startswith("/fixtures/pragma_cache_size.testall") for href in actual
+    )
+
+
 @pytest.mark.asyncio
 async def test_hook_prepare_jinja2_environment(ds_client):
     ds_client.ds._HELLO = "HI"

From 92848c06b8cf5b8bb6b93088bb547810f9fce8b6 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:43:32 -0700
Subject: [PATCH 168/386] Stop facet counts from wrapping (#2754)

ul.tight-bullets li uses word-break: break-all so long facet labels can
wrap, but that also let the count number break across lines. Wrap each
count in a span.facet-count with white-space: nowrap so the label can
still wrap while the count stays on one line.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/static/app.css                | 5 +++++
 datasette/templates/_facet_results.html | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 815f6db8..6d675d9f 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -706,6 +706,11 @@ button.core[type=button] {
     color: #666;
     padding-right: 0.25em;
 }
+/* The label may wrap (word-break: break-all on the li) but the count should
+   stay on one line - https://github.com/simonw/datasette/issues/2754 */
+.facet-count {
+    white-space: nowrap;
+}
 .facet-info li,
 .facet-info ul {
     margin: 0;
diff --git a/datasette/templates/_facet_results.html b/datasette/templates/_facet_results.html
index 034e9678..570bb37e 100644
--- a/datasette/templates/_facet_results.html
+++ b/datasette/templates/_facet_results.html
@@ -12,9 +12,9 @@
             <ul class="tight-bullets">
                 {% for facet_value in facet_info.results %}
                     {% if not facet_value.selected %}
-                        <li><a href="{{ facet_value.toggle_url }}" data-facet-value="{{ facet_value.value }}">{{ (facet_value.label | string()) or "-" }}</a> {{ "{:,}".format(facet_value.count) }}</li>
+                        <li><a href="{{ facet_value.toggle_url }}" data-facet-value="{{ facet_value.value }}">{{ (facet_value.label | string()) or "-" }}</a> <span class="facet-count">{{ "{:,}".format(facet_value.count) }}</span></li>
                     {% else %}
-                        <li>{{ facet_value.label or "-" }} &middot; {{ "{:,}".format(facet_value.count) }} <a href="{{ facet_value.toggle_url }}" class="cross">&#x2716;</a></li>
+                        <li>{{ facet_value.label or "-" }} &middot; <span class="facet-count">{{ "{:,}".format(facet_value.count) }}</span> <a href="{{ facet_value.toggle_url }}" class="cross">&#x2716;</a></li>
                     {% endif %}
                 {% endfor %}
                 {% if facet_info.truncated %}

From 9adb5416743a7312758e986c254baa1758228ad0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 06:42:08 -0700
Subject: [PATCH 169/386] Use asyncinject 0.7 results= seeding for per-request
 extras context

asyncinject 0.7 fixed the parallel executor stalling when every
initially-ready node is a seeded value, and made seeded values take
precedence over registered functions. That lets the shared per-scope
registries receive the per-request context directly via
resolve_multi(results={'context': ...}) instead of the
contextvars.ContextVar workaround.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/extras.py | 21 +++------------------
 pyproject.toml      |  2 +-
 2 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/datasette/extras.py b/datasette/extras.py
index 2c3450b2..5cab52a4 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -1,4 +1,3 @@
-import contextvars
 import re
 from dataclasses import dataclass
 from enum import Enum
@@ -6,11 +5,6 @@ from typing import ClassVar
 
 from asyncinject import Registry
 
-# Per-request context for Extra.resolve(), so the asyncinject registries can
-# be shared across requests. asyncio tasks copy the caller's context, so
-# concurrent resolve() calls each see their own value.
-_resolve_context = contextvars.ContextVar("datasette_extras_context")
-
 
 def extra_names_from_request(request):
     extra_bits = request.args.getlist("_extra")
@@ -91,11 +85,6 @@ class ExtraRegistry:
         registry = self._scope_registries.get(scope)
         if registry is None:
             registry = Registry()
-
-            async def context_provider():
-                return _resolve_context.get()
-
-            registry.register(context_provider, name="context")
             for cls in self.classes_for_scope(scope):
                 registry.register(cls().resolve, name=cls.key())
             self._scope_registries[scope] = registry
@@ -117,13 +106,9 @@ class ExtraRegistry:
     async def resolve(self, requested, context, scope, include_internal=False):
         allowed_names = self._allowed_names_for_scope(scope, include_internal)
         requested_names = [name for name in requested if name in allowed_names]
-        token = _resolve_context.set(context)
-        try:
-            resolved = await self._registry_for_scope(scope).resolve_multi(
-                requested_names
-            )
-        finally:
-            _resolve_context.reset(token)
+        resolved = await self._registry_for_scope(scope).resolve_multi(
+            requested_names, results={"context": context}
+        )
         return {name: resolved[name] for name in requested_names}
 
 
diff --git a/pyproject.toml b/pyproject.toml
index 38085476..0d136d60 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -36,7 +36,7 @@ dependencies = [
     "mergedeep>=1.1.1",
     "itsdangerous>=1.1",
     "sqlite-utils>=3.30",
-    "asyncinject>=0.6.1",
+    "asyncinject>=0.7",
     "setuptools",
     "pip",
 ]

From 648a34ce8196ecf02504c0daed594bd1cd540210 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 07:13:07 -0700
Subject: [PATCH 170/386] Fix for test I broke in 92848c06 refs #2754

---
 tests/test_table_html.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 2e671d55..63e233fa 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -349,7 +349,11 @@ async def test_facet_display(ds_client):
                     {
                         "name": a.text,
                         "qs": a["href"].split("?")[-1],
-                        "count": int(str(a.parent).split("</a>")[1].split("<")[0]),
+                        "count": int(
+                            a.parent.find(
+                                "span", {"class": "facet-count"}
+                            ).text.replace(",", "")
+                        ),
                     }
                     for a in div.find("ul").find_all("a")
                 ],
@@ -695,7 +699,7 @@ async def test_table_html_foreign_key_facets(ds_client):
     assert response.status_code == 200
     assert (
         '<li><a href="http://localhost/fixtures/foreign_key_references?_facet=foreign_key_with_blank_label&amp;foreign_key_with_blank_label=3"'
-        ' data-facet-value="3">-</a> 1</li>'
+        ' data-facet-value="3">-</a> <span class="facet-count">1</span></li>'
     ) in response.text
 
 

From 26f3b20e58bd2ad582d5fae326acf22b42627eb1 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 07:29:27 -0700
Subject: [PATCH 171/386] Fix to our pytest plugin to better support pytest-cov

Refs https://github.com/simonw/datasette/pulls#issuecomment-4681621052
---
 datasette/_pytest_plugin.py | 33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)

diff --git a/datasette/_pytest_plugin.py b/datasette/_pytest_plugin.py
index 5fb6b473..103c616d 100644
--- a/datasette/_pytest_plugin.py
+++ b/datasette/_pytest_plugin.py
@@ -19,23 +19,38 @@ import weakref
 
 import pytest
 
-from datasette.app import Datasette
-
 _active_instances: contextvars.ContextVar[list | None] = contextvars.ContextVar(
     "datasette_active_instances", default=None
 )
 
-_original_init = Datasette.__init__
+_original_init = None
 
 
-def _tracking_init(self, *args, **kwargs):
-    _original_init(self, *args, **kwargs)
-    instances = _active_instances.get()
-    if instances is not None:
-        instances.append(weakref.ref(self))
+def _install_tracking():
+    # datasette.app is imported lazily here rather than at module level:
+    # as a pytest11 entry point this module is imported during pytest
+    # startup, before pytest-cov starts measuring, so a module-level
+    # import would drag in all of datasette and make every import-time
+    # line in the package invisible to coverage
+    global _original_init
+    if _original_init is not None:
+        return
+    from datasette.app import Datasette
+
+    _original_init = Datasette.__init__
+
+    def _tracking_init(self, *args, **kwargs):
+        _original_init(self, *args, **kwargs)
+        instances = _active_instances.get()
+        if instances is not None:
+            instances.append(weakref.ref(self))
+
+    Datasette.__init__ = _tracking_init
 
 
-Datasette.__init__ = _tracking_init
+def pytest_configure(config):
+    if _enabled(config):
+        _install_tracking()
 
 
 def pytest_addoption(parser):

From 435ff7fa88fce25f5f2e4fa0aae8834deff7240c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:51:09 -0700
Subject: [PATCH 172/386] Context.documented_fields() and extras doc-metadata
 enforcement

- Context dataclasses now expose documented_fields(), returning
  ContextField(name, type_name, help) for each field
- ExtraRegistry.internal_classes_for_scope() returns the Extra classes
  that are available to HTML templates but excluded from JSON
- Tests enforce that every registered Extra has a description and every
  DatabaseContext/QueryContext field has help metadata

Refs #1510, #2127

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/extras.py            | 10 ++++++++++
 datasette/views/__init__.py    | 25 +++++++++++++++++++++++++
 tests/test_extras.py           | 32 ++++++++++++++++++++++++++++++++
 tests/test_template_context.py | 32 ++++++++++++++++++++++++++++++++
 4 files changed, 99 insertions(+)
 create mode 100644 tests/test_template_context.py

diff --git a/datasette/extras.py b/datasette/extras.py
index 5cab52a4..36014185 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -81,6 +81,16 @@ class ExtraRegistry:
     def public_classes_for_scope(self, scope):
         return self.classes_for_scope(scope, include_internal=False)
 
+    def internal_classes_for_scope(self, scope):
+        # Extras that are available to HTML templates but excluded from
+        # JSON responses - plain Providers are dependency plumbing and
+        # never surface as keys, so they are not included
+        return [
+            cls
+            for cls in self.classes_for_scope(scope)
+            if issubclass(cls, Extra) and not cls.public
+        ]
+
     def _registry_for_scope(self, scope):
         registry = self._scope_registries.get(scope)
         if registry is None:
diff --git a/datasette/views/__init__.py b/datasette/views/__init__.py
index 88106737..de851708 100644
--- a/datasette/views/__init__.py
+++ b/datasette/views/__init__.py
@@ -1,2 +1,27 @@
+from dataclasses import dataclass
+import dataclasses
+
+
+@dataclass(frozen=True)
+class ContextField:
+    name: str
+    type_name: str
+    help: str
+
+
 class Context:
     "Base class for all documented contexts"
+
+    @classmethod
+    def documented_fields(cls):
+        "List of ContextField describing the documented fields of this context"
+        documented = []
+        for f in dataclasses.fields(cls):
+            documented.append(
+                ContextField(
+                    name=f.name,
+                    type_name=getattr(f.type, "__name__", str(f.type)),
+                    help=f.metadata.get("help", ""),
+                )
+            )
+        return documented
diff --git a/tests/test_extras.py b/tests/test_extras.py
index ad8a9f00..73b4965e 100644
--- a/tests/test_extras.py
+++ b/tests/test_extras.py
@@ -23,6 +23,38 @@ class DependentExtra(Extra):
         return slow_value + 1
 
 
+class InternalOnlyExtra(Extra):
+    description = "Internal extra for HTML templates only"
+    scopes = {ExtraScope.TABLE}
+    public = False
+
+    async def resolve(self, context):
+        return "internal"
+
+
+def test_internal_classes_for_scope():
+    registry = ExtraRegistry([SlowValueExtra, DependentExtra, InternalOnlyExtra])
+    assert registry.internal_classes_for_scope(ExtraScope.TABLE) == [InternalOnlyExtra]
+    assert registry.public_classes_for_scope(ExtraScope.TABLE) == [
+        SlowValueExtra,
+        DependentExtra,
+    ]
+
+
+def _registered_extra_classes():
+    # Plain Providers are internal dependency plumbing, only Extra
+    # subclasses surface as documented JSON/template keys
+    from datasette.views.table_extras import table_extra_registry
+
+    return [cls for cls in table_extra_registry.classes if issubclass(cls, Extra)]
+
+
+@pytest.mark.parametrize("cls", _registered_extra_classes(), ids=lambda cls: cls.key())
+def test_registered_extras_have_descriptions(cls):
+    # Every registered extra is part of the documented template/JSON contract
+    assert cls.description, "{} is missing a description".format(cls.__name__)
+
+
 def test_registry_is_built_once_per_scope():
     registry = ExtraRegistry([SlowValueExtra, DependentExtra])
     first = registry._registry_for_scope(ExtraScope.TABLE)
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
new file mode 100644
index 00000000..4ce00a55
--- /dev/null
+++ b/tests/test_template_context.py
@@ -0,0 +1,32 @@
+"""
+Tests for the documented template context - the contract that custom
+template authors can rely on for Datasette 1.0.
+"""
+
+from dataclasses import dataclass, field
+
+import pytest
+
+from datasette.views import Context
+from datasette.views.database import DatabaseContext, QueryContext
+
+
+def test_documented_fields():
+    @dataclass
+    class DemoContext(Context):
+        name: str = field(metadata={"help": "The name"})
+        count: int = field(metadata={"help": "How many there are"})
+
+    fields = DemoContext.documented_fields()
+    assert [(f.name, f.type_name, f.help) for f in fields] == [
+        ("name", "str", "The name"),
+        ("count", "int", "How many there are"),
+    ]
+
+
+@pytest.mark.parametrize("klass", (DatabaseContext, QueryContext))
+def test_context_dataclass_fields_all_have_help(klass):
+    for context_field in klass.documented_fields():
+        assert context_field.help, "{}.{} is missing help metadata".format(
+            klass.__name__, context_field.name
+        )

From 6a1b237b39ca11ca8a876f912b23e27f281eb0f4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 10 Jun 2026 23:55:25 -0700
Subject: [PATCH 173/386] Documented template context manifest with contract
 tests

datasette/template_contexts.py is the source of truth for the template
context contract: the variables custom templates can rely on for the
database, query, table and row pages, plus the base context that
render_template() adds to every page.

Documentation for each key comes from the Context dataclass field help
(database, query), the Extra class description (table and row extras)
or inline docs in the manifest (keys added by view code).

Contract tests render each page with template_debug ?_context=1 and
assert the real context keys exactly match the documented set, in both
directions - an undocumented addition or a removed documented key both
fail.

Refs #1510, #2127

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/template_contexts.py | 240 +++++++++++++++++++++++++++++++++
 tests/test_template_context.py | 103 ++++++++++++++
 2 files changed, 343 insertions(+)
 create mode 100644 datasette/template_contexts.py

diff --git a/datasette/template_contexts.py b/datasette/template_contexts.py
new file mode 100644
index 00000000..1ff1e2a8
--- /dev/null
+++ b/datasette/template_contexts.py
@@ -0,0 +1,240 @@
+"""
+The documented template context for Datasette's core HTML pages.
+
+This module is the source of truth for the template context contract:
+the set of variables that custom templates can rely on for each page.
+It is consumed by the contract tests in tests/test_template_context.py,
+which assert that the real rendered context for each page exactly
+matches what is documented here, and by docs/template_context_doc.py
+which generates the documentation in docs/template_context.rst.
+
+Documentation for each key comes from one of three places:
+
+- Pages that render a Context dataclass (database, query) use the
+  ``help`` metadata on each dataclass field
+- Keys provided by registered extras use the ``description`` from the
+  Extra class
+- Keys added inline by view code are documented in this module
+"""
+
+from dataclasses import dataclass
+
+from datasette.extras import ExtraScope
+from datasette.views.database import DatabaseContext, QueryContext
+from datasette.views.table_extras import table_extra_registry
+
+
+@dataclass(frozen=True)
+class TemplateContextKey:
+    name: str
+    doc: str
+
+
+def _keys(**docs):
+    return tuple(TemplateContextKey(name, doc) for name, doc in docs.items())
+
+
+# Added by Datasette.render_template() to the context for every page,
+# including pages rendered by plugins
+BASE_CONTEXT_KEYS = _keys(
+    request="The current Request object, or None",
+    crumb_items="Async function returning breadcrumb navigation items for the current page",
+    urls="Object with methods for constructing URLs to pages within Datasette - see datasette.urls in the internals documentation",
+    actor="The currently authenticated actor dictionary, or None",
+    menu_links="Async function returning links for the Datasette application menu, including those added by plugins",
+    display_actor="Function returning a display string for an actor dictionary",
+    show_logout="True if the logout link should be shown in the navigation menu",
+    app_css_hash="Hash of Datasette's app.css contents, used for cache busting",
+    zip="Python's zip() builtin, made available to template logic",
+    body_scripts="List of script blocks for the page body contributed by plugins",
+    format_bytes="Function that formats a number of bytes as a human-readable size",
+    show_messages="Function returning any messages set for the current user, clearing them in the process",
+    extra_css_urls="List of {url, sri} dictionaries of extra CSS stylesheets to include on the page, from plugins and configuration",
+    extra_js_urls="List of {url, sri, module} dictionaries of extra JavaScript URLs to include on the page",
+    base_url="The configured base_url setting",
+    csrftoken="Function returning the CSRF token for the current request",
+    datasette_version="The version of Datasette that is running",
+)
+
+
+@dataclass(frozen=True)
+class PageContext:
+    # Identifier used in tests and documentation, e.g. "table"
+    name: str
+    title: str
+    description: str
+    # The default template used to render this page
+    template: str
+    # For pages rendered from a Context dataclass
+    context_class: type = None
+    # For pages whose context includes resolved extras
+    extras_scope: ExtraScope = None
+    extra_keys: tuple = ()
+    # Keys added inline by the view code, documented here
+    keys: tuple = ()
+
+    def documented_keys(self):
+        "Every page-specific documented key, excluding BASE_CONTEXT_KEYS"
+        documented = []
+        if self.context_class is not None:
+            documented.extend(
+                TemplateContextKey(f.name, f.help)
+                for f in self.context_class.documented_fields()
+            )
+        for name in self.extra_keys:
+            cls = table_extra_registry.classes_by_name[name]
+            documented.append(TemplateContextKey(name, cls.description or ""))
+        documented.extend(self.keys)
+        return sorted(documented, key=lambda key: key.name)
+
+
+_SHARED_DOCS = dict(
+    ok="True if the data for this page was retrieved without errors",
+    rows="The rows for this page, as a list of dictionaries mapping column name to value",
+    query_ms="Time taken by the SQL queries for this page, in milliseconds",
+    select_templates="List of template names that were considered for this page, the one used marked with an asterisk",
+    settings="Dictionary of Datasette's current settings",
+    alternate_url_json="URL for the JSON version of this page",
+    url_csv="URL for the CSV export of this page",
+    url_csv_path="Path portion of the CSV export URL",
+    url_csv_hidden_args="(name, value) pairs for hidden form fields used by the CSV export form",
+    renderers="Dictionary mapping output format names (e.g. json) to their URLs for this page",
+    display_columns="Column objects formatted for the HTML table display",
+    display_rows="Row data formatted for the HTML table display",
+    custom_table_templates="Custom template names that were considered for displaying this table",
+)
+
+
+def _shared(*names):
+    return tuple(TemplateContextKey(name, _SHARED_DOCS[name]) for name in names)
+
+
+PAGES = {
+    page.name: page
+    for page in (
+        PageContext(
+            name="database",
+            title="Database",
+            description="The page listing the tables, views and queries in a database, e.g. /fixtures",
+            template="database.html",
+            context_class=DatabaseContext,
+        ),
+        PageContext(
+            name="query",
+            title="Query",
+            description="The page for arbitrary SQL queries (/database/-/query?sql=...) and stored queries (/database/query-name)",
+            template="query.html",
+            context_class=QueryContext,
+        ),
+        PageContext(
+            name="table",
+            title="Table",
+            description="The page showing the rows in a table or SQL view, e.g. /fixtures/facetable",
+            template="table.html",
+            extras_scope=ExtraScope.TABLE,
+            extra_keys=(
+                "actions",
+                "all_columns",
+                "columns",
+                "count",
+                "count_sql",
+                "custom_table_templates",
+                "database",
+                "database_color",
+                "display_columns",
+                "display_rows",
+                "expandable_columns",
+                "facet_results",
+                "facets_timed_out",
+                "filters",
+                "form_hidden_args",
+                "human_description_en",
+                "is_view",
+                "metadata",
+                "next_url",
+                "primary_keys",
+                "private",
+                "query",
+                "renderers",
+                "set_column_type_ui",
+                "sorted_facet_results",
+                "suggested_facets",
+                "table",
+                "table_definition",
+                "view_definition",
+            ),
+            keys=_shared(
+                "ok",
+                "rows",
+                "query_ms",
+                "select_templates",
+                "settings",
+                "alternate_url_json",
+                "url_csv",
+                "url_csv_path",
+                "url_csv_hidden_args",
+            )
+            + _keys(
+                allow_execute_sql="True if the current actor can execute custom SQL against this database",
+                append_querystring="Function that appends additional querystring arguments to a URL",
+                count_limit="The maximum number of rows Datasette will count before showing an approximation",
+                datasette_allow_facet='The string "true" or "false" reflecting the allow_facet setting',
+                extra_wheres_for_ui="Extra where clauses from ?_where=, with links to remove them",
+                filter_columns="List of columns offered by the filter interface",
+                fix_path="Function that applies the base_url prefix to a path",
+                is_sortable="True if any of the displayed columns can be used to sort",
+                next="Pagination token for the next page, or None",
+                path_with_replaced_args="Function for building the current path with modified querystring arguments",
+                sort="Column the page is sorted by, or None",
+                sort_desc="Column the page is sorted by in descending order, or None",
+                supports_search="True if this table has full-text search configured",
+                top_table="Async function rendering the top_table plugin slot",
+            ),
+        ),
+        PageContext(
+            name="row",
+            title="Row",
+            description="The page showing an individual row, e.g. /fixtures/facetable/1",
+            template="row.html",
+            extras_scope=ExtraScope.ROW,
+            extra_keys=(
+                "columns",
+                "database",
+                "database_color",
+                "foreign_key_tables",
+                "metadata",
+                "primary_keys",
+                "private",
+                "table",
+            ),
+            keys=_shared(
+                "ok",
+                "rows",
+                "query_ms",
+                "select_templates",
+                "settings",
+                "alternate_url_json",
+                "url_csv",
+                "url_csv_path",
+                "url_csv_hidden_args",
+                "renderers",
+                "display_columns",
+                "display_rows",
+                "custom_table_templates",
+            )
+            + _keys(
+                primary_key_values="Values of the primary keys for this row, from the URL",
+                row_actions="Row actions made available by plugin hooks",
+                top_row="Async function rendering the top_row plugin slot",
+            ),
+        ),
+    )
+}
+
+
+def documented_context_keys(page_name):
+    "Set of every documented key for the named page, including base context keys"
+    page = PAGES[page_name]
+    return {key.name for key in BASE_CONTEXT_KEYS} | {
+        key.name for key in page.documented_keys()
+    }
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index 4ce00a55..04002f31 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -3,12 +3,23 @@ Tests for the documented template context - the contract that custom
 template authors can rely on for Datasette 1.0.
 """
 
+import html
+import json
 from dataclasses import dataclass, field
 
 import pytest
 
+from datasette.app import Datasette
+from datasette.extras import ExtraScope
+from datasette.fixtures import write_fixture_database
+from datasette.template_contexts import (
+    BASE_CONTEXT_KEYS,
+    PAGES,
+    documented_context_keys,
+)
 from datasette.views import Context
 from datasette.views.database import DatabaseContext, QueryContext
+from datasette.views.table_extras import table_extra_registry
 
 
 def test_documented_fields():
@@ -30,3 +41,95 @@ def test_context_dataclass_fields_all_have_help(klass):
         assert context_field.help, "{}.{} is missing help metadata".format(
             klass.__name__, context_field.name
         )
+
+
+@pytest.fixture(scope="module")
+def context_ds(tmp_path_factory):
+    db_path = tmp_path_factory.mktemp("template-context") / "fixtures.db"
+    write_fixture_database(db_path)
+    ds = Datasette(
+        [str(db_path)],
+        settings={"num_sql_threads": 1, "template_debug": True},
+        config={
+            "databases": {
+                "fixtures": {
+                    "queries": {
+                        "neighborhood_search": {
+                            "sql": (
+                                "select _neighborhood from facetable "
+                                "where _neighborhood like '%' || :text || '%'"
+                            ),
+                            "title": "Search neighborhoods",
+                        }
+                    }
+                }
+            }
+        },
+    )
+    yield ds
+    for db in ds.databases.values():
+        if not db.is_memory:
+            db.close()
+
+
+async def get_template_context(ds, path):
+    sep = "&" if "?" in path else "?"
+    response = await ds.client.get(path + sep + "_context=1")
+    assert response.status_code == 200, path
+    body = html.unescape(
+        response.text.removeprefix("<pre>").removesuffix("</pre>")
+    )
+    return json.loads(body)
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "page_name,path",
+    (
+        ("database", "/fixtures"),
+        ("table", "/fixtures/facetable"),
+        ("table", "/fixtures/facetable?_city_id__exact=1"),
+        ("row", "/fixtures/facetable/1"),
+        ("query", "/fixtures/-/query?sql=select+*+from+facetable"),
+        ("query", "/fixtures/neighborhood_search?text=cork"),
+    ),
+)
+async def test_template_context_matches_documented_contract(
+    context_ds, page_name, path
+):
+    # The full contract: every key in the rendered template context is
+    # documented, and every documented key is present in the context
+    documented = documented_context_keys(page_name)
+    actual = set(await get_template_context(context_ds, path))
+    undocumented = actual - documented
+    no_longer_present = documented - actual
+    assert not undocumented, (
+        "Undocumented keys in {} template context: {} - document them in "
+        "datasette/template_contexts.py".format(page_name, sorted(undocumented))
+    )
+    assert not no_longer_present, (
+        "Documented keys missing from {} template context: {} - this would "
+        "break custom templates".format(page_name, sorted(no_longer_present))
+    )
+
+
+def test_base_context_keys_all_have_docs():
+    for key in BASE_CONTEXT_KEYS:
+        assert key.doc, "Base context key {} is missing docs".format(key.name)
+
+
+@pytest.mark.parametrize("page", PAGES.values(), ids=lambda page: page.name)
+def test_page_documented_keys_all_have_docs(page):
+    for key in page.documented_keys():
+        assert key.doc, "{} page key {} is missing docs".format(page.name, key.name)
+
+
+@pytest.mark.parametrize("page", PAGES.values(), ids=lambda page: page.name)
+def test_page_extra_keys_are_registered_extras(page):
+    for name in page.extra_keys:
+        cls = table_extra_registry.classes_by_name.get(name)
+        assert cls is not None, "{} is not a registered extra".format(name)
+        assert page.extras_scope is not None
+        assert cls.available_for(page.extras_scope), (
+            "{} extra is not available for scope {}".format(name, page.extras_scope)
+        )

From a55ae2adfc9500dfbb028ac167c379d8207f4676 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 00:00:42 -0700
Subject: [PATCH 174/386] Generated template context documentation, closes
 #1510

docs/template_context.rst is generated by cog from the manifest in
datasette/template_contexts.py, following the json_api_doc.py pattern.
It documents the base context available on every page plus the
database, query, table and row pages, including the stability policy
for custom template authors.

Refs #2127

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/template_contexts.py |   8 +-
 docs/custom_templates.rst      |   5 +
 docs/index.rst                 |   1 +
 docs/template_context.rst      | 488 +++++++++++++++++++++++++++++++++
 docs/template_context_doc.py   |  54 ++++
 tests/test_template_context.py |  25 +-
 6 files changed, 571 insertions(+), 10 deletions(-)
 create mode 100644 docs/template_context.rst
 create mode 100644 docs/template_context_doc.py

diff --git a/datasette/template_contexts.py b/datasette/template_contexts.py
index 1ff1e2a8..e2854467 100644
--- a/datasette/template_contexts.py
+++ b/datasette/template_contexts.py
@@ -115,21 +115,21 @@ PAGES = {
         PageContext(
             name="database",
             title="Database",
-            description="The page listing the tables, views and queries in a database, e.g. /fixtures",
+            description="The page listing the tables, views and queries in a database, e.g. /fixtures.",
             template="database.html",
             context_class=DatabaseContext,
         ),
         PageContext(
             name="query",
             title="Query",
-            description="The page for arbitrary SQL queries (/database/-/query?sql=...) and stored queries (/database/query-name)",
+            description="The page for arbitrary SQL queries (/database/-/query?sql=...) and stored queries (/database/query-name).",
             template="query.html",
             context_class=QueryContext,
         ),
         PageContext(
             name="table",
             title="Table",
-            description="The page showing the rows in a table or SQL view, e.g. /fixtures/facetable",
+            description="The page showing the rows in a table or SQL view, e.g. /fixtures/facetable.",
             template="table.html",
             extras_scope=ExtraScope.TABLE,
             extra_keys=(
@@ -194,7 +194,7 @@ PAGES = {
         PageContext(
             name="row",
             title="Row",
-            description="The page showing an individual row, e.g. /fixtures/facetable/1",
+            description="The page showing an individual row, e.g. /fixtures/facetable/1.",
             template="row.html",
             extras_scope=ExtraScope.ROW,
             extra_keys=(
diff --git a/docs/custom_templates.rst b/docs/custom_templates.rst
index c324fb79..8066d28f 100644
--- a/docs/custom_templates.rst
+++ b/docs/custom_templates.rst
@@ -177,6 +177,11 @@ this::
 Datasette will now first look for templates in that directory, and fall back on
 the defaults if no matches are found.
 
+The variables made available to each template are documented on the
+:ref:`template_context` page. Variables documented there are a stable API:
+custom templates that use them will keep working in future Datasette
+releases, up until the next major version.
+
 It is also possible to over-ride templates on a per-database, per-row or per-
 table basis.
 
diff --git a/docs/index.rst b/docs/index.rst
index c76969bc..d494fd17 100644
--- a/docs/index.rst
+++ b/docs/index.rst
@@ -58,6 +58,7 @@ Contents
    settings
    introspection
    custom_templates
+   template_context
    plugins
    writing_plugins
    javascript_plugins
diff --git a/docs/template_context.rst b/docs/template_context.rst
new file mode 100644
index 00000000..a487a6e7
--- /dev/null
+++ b/docs/template_context.rst
@@ -0,0 +1,488 @@
+.. _template_context:
+
+Template context
+================
+
+This page documents the variables that are available to custom templates
+for each of Datasette's core pages. See :ref:`customization_custom_templates`
+for how to provide your own templates.
+
+The variables documented here are a stable contract: custom templates that
+use them will continue to work across Datasette releases, up until the next
+major version (Datasette 2.0). Anything present in the template context but
+not documented on this page is not part of that contract and may change or
+be removed in any release.
+
+You can inspect the full context for any page by starting Datasette with
+``--setting template_debug 1`` and adding ``?_context=1`` to the page URL.
+
+.. [[[cog
+    from template_context_doc import template_context
+    template_context(cog)
+.. ]]]
+
+Base context
+------------
+
+These variables are available on every page rendered by Datasette, including pages rendered by plugins that use :ref:`datasette.render_template() <datasette_render_template>`. Plugins can add additional variables using the :ref:`plugin_hook_extra_template_vars` hook.
+
+``request``
+    The current Request object, or None
+
+``crumb_items``
+    Async function returning breadcrumb navigation items for the current page
+
+``urls``
+    Object with methods for constructing URLs to pages within Datasette - see datasette.urls in the internals documentation
+
+``actor``
+    The currently authenticated actor dictionary, or None
+
+``menu_links``
+    Async function returning links for the Datasette application menu, including those added by plugins
+
+``display_actor``
+    Function returning a display string for an actor dictionary
+
+``show_logout``
+    True if the logout link should be shown in the navigation menu
+
+``app_css_hash``
+    Hash of Datasette's app.css contents, used for cache busting
+
+``zip``
+    Python's zip() builtin, made available to template logic
+
+``body_scripts``
+    List of script blocks for the page body contributed by plugins
+
+``format_bytes``
+    Function that formats a number of bytes as a human-readable size
+
+``show_messages``
+    Function returning any messages set for the current user, clearing them in the process
+
+``extra_css_urls``
+    List of {url, sri} dictionaries of extra CSS stylesheets to include on the page, from plugins and configuration
+
+``extra_js_urls``
+    List of {url, sri, module} dictionaries of extra JavaScript URLs to include on the page
+
+``base_url``
+    The configured base_url setting
+
+``csrftoken``
+    Function returning the CSRF token for the current request
+
+``datasette_version``
+    The version of Datasette that is running
+
+Database page
+-------------
+
+The page listing the tables, views and queries in a database, e.g. /fixtures. Rendered using the ``database.html`` template.
+
+``allow_download`` - ``bool``
+    Boolean indicating if database download is allowed
+
+``allow_execute_sql`` - ``bool``
+    Boolean indicating if custom SQL can be executed
+
+``alternate_url_json`` - ``str``
+    URL for the alternate JSON version of this page
+
+``attached_databases`` - ``list``
+    List of names of attached databases
+
+``count_limit`` - ``int``
+    The maximum number of rows to count
+
+``database`` - ``str``
+    The name of the database
+
+``database_actions`` - ``callable``
+    Callable returning list of action links for the database menu
+
+``database_color`` - ``str``
+    The color assigned to the database
+
+``editable`` - ``bool``
+    Boolean indicating if the database is editable
+
+``hidden_count`` - ``int``
+    Count of hidden tables
+
+``metadata`` - ``dict``
+    Metadata for the database
+
+``path`` - ``str``
+    The URL path to this database
+
+``private`` - ``bool``
+    Boolean indicating if this is a private database
+
+``queries`` - ``list``
+    List of stored query objects
+
+``queries_count`` - ``int``
+    Count of visible stored queries
+
+``queries_more`` - ``bool``
+    Boolean indicating if more stored queries are available
+
+``select_templates`` - ``list``
+    List of templates that were considered for rendering this page
+
+``show_hidden`` - ``str``
+    Value of _show_hidden query parameter
+
+``size`` - ``int``
+    The size of the database in bytes
+
+``table_columns`` - ``dict``
+    Dictionary mapping table names to their column lists
+
+``tables`` - ``list``
+    List of table objects in the database
+
+``top_database`` - ``callable``
+    Callable to render the top_database slot
+
+``views`` - ``list``
+    List of view objects in the database
+
+Query page
+----------
+
+The page for arbitrary SQL queries (/database/-/query?sql=...) and stored queries (/database/query-name). Rendered using the ``query.html`` template.
+
+``allow_execute_sql`` - ``bool``
+    Boolean indicating if custom SQL can be executed
+
+``alternate_url_json`` - ``str``
+    URL for alternate JSON version of this page
+
+``columns`` - ``list``
+    List of column names
+
+``database`` - ``str``
+    The name of the database being queried
+
+``database_color`` - ``str``
+    The color of the database
+
+``db_is_immutable`` - ``bool``
+    Boolean indicating if this database is immutable
+
+``display_rows`` - ``list``
+    List of result rows to display
+
+``edit_sql_url`` - ``str``
+    URL to edit the SQL for a stored query
+
+``editable`` - ``bool``
+    Boolean indicating if the SQL can be edited
+
+``error`` - ``str``
+    Any query error message
+
+``hide_sql`` - ``bool``
+    Boolean indicating if the SQL should be hidden
+
+``metadata`` - ``dict``
+    Metadata about the database or the stored query
+
+``named_parameter_values`` - ``dict``
+    Dictionary of parameter names/values
+
+``private`` - ``bool``
+    Boolean indicating if this is a private database
+
+``query`` - ``dict``
+    The SQL query object containing the `sql` string
+
+``query_actions`` - ``callable``
+    Callable returning a list of links for the query action menu
+
+``renderers`` - ``dict``
+    Dictionary of renderer name to URL
+
+``save_query_url`` - ``str``
+    URL to save the current arbitrary SQL as a query
+
+``select_templates`` - ``list``
+    List of templates that were considered for rendering this page
+
+``show_hide_hidden`` - ``str``
+    Hidden input field for the _show_sql parameter
+
+``show_hide_link`` - ``str``
+    The URL to toggle showing/hiding the SQL
+
+``show_hide_text`` - ``str``
+    The text for the show/hide SQL link
+
+``stored_query`` - ``str``
+    The name of the stored query if this is a stored query
+
+``stored_query_write`` - ``bool``
+    Boolean indicating if this is a stored query that allows writes
+
+``table_columns`` - ``dict``
+    Dictionary of table name to list of column names
+
+``tables`` - ``list``
+    List of table objects in the database
+
+``top_query`` - ``callable``
+    Callable to render the top_query slot
+
+``top_stored_query`` - ``callable``
+    Callable to render the top_stored_query slot
+
+``url_csv`` - ``str``
+    URL for CSV export
+
+Table page
+----------
+
+The page showing the rows in a table or SQL view, e.g. /fixtures/facetable. Rendered using the ``table.html`` template.
+
+Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
+
+``actions``
+    Table or view actions made available by plugin hooks
+
+``all_columns``
+    All columns in the table, regardless of _col/_nocol filtering
+
+``allow_execute_sql``
+    True if the current actor can execute custom SQL against this database
+
+``alternate_url_json``
+    URL for the JSON version of this page
+
+``append_querystring``
+    Function that appends additional querystring arguments to a URL
+
+``columns``
+    Column names returned by this query
+
+``count``
+    Total count of rows matching these filters
+
+``count_limit``
+    The maximum number of rows Datasette will count before showing an approximation
+
+``count_sql``
+    SQL query used to calculate the total count
+
+``custom_table_templates``
+    Custom template names considered for this table
+
+``database``
+    Database name
+
+``database_color``
+    Color assigned to the database
+
+``datasette_allow_facet``
+    The string "true" or "false" reflecting the allow_facet setting
+
+``display_columns``
+    Column metadata used by the HTML table display
+
+``display_rows``
+    Row data formatted for the HTML table display
+
+``expandable_columns``
+    Foreign key columns that can be expanded with labels
+
+``extra_wheres_for_ui``
+    Extra where clauses from ?_where=, with links to remove them
+
+``facet_results``
+    Results of facets calculated against this data
+
+``facets_timed_out``
+    Facet calculations that timed out
+
+``filter_columns``
+    List of columns offered by the filter interface
+
+``filters``
+    Filters object used by the HTML table interface
+
+``fix_path``
+    Function that applies the base_url prefix to a path
+
+``form_hidden_args``
+    Hidden form arguments used by the HTML table interface
+
+``human_description_en``
+    Human-readable description of the filters
+
+``is_sortable``
+    True if any of the displayed columns can be used to sort
+
+``is_view``
+    Whether this resource is a view instead of a table
+
+``metadata``
+    Metadata about the table, database or stored query
+
+``next``
+    Pagination token for the next page, or None
+
+``next_url``
+    Full URL for the next page of results
+
+``ok``
+    True if the data for this page was retrieved without errors
+
+``path_with_replaced_args``
+    Function for building the current path with modified querystring arguments
+
+``primary_keys``
+    Primary keys for this table
+
+``private``
+    Whether this resource is private to the current actor
+
+``query``
+    Details of the underlying SQL query
+
+``query_ms``
+    Time taken by the SQL queries for this page, in milliseconds
+
+``renderers``
+    Alternative output renderers available for this table
+
+``rows``
+    The rows for this page, as a list of dictionaries mapping column name to value
+
+``select_templates``
+    List of template names that were considered for this page, the one used marked with an asterisk
+
+``set_column_type_ui``
+    Column type UI metadata for this table
+
+``settings``
+    Dictionary of Datasette's current settings
+
+``sort``
+    Column the page is sorted by, or None
+
+``sort_desc``
+    Column the page is sorted by in descending order, or None
+
+``sorted_facet_results``
+    Facet results sorted for display
+
+``suggested_facets``
+    Suggestions for facets that might return interesting results
+
+``supports_search``
+    True if this table has full-text search configured
+
+``table``
+    Table name
+
+``table_definition``
+    SQL definition for this table
+
+``top_table``
+    Async function rendering the top_table plugin slot
+
+``url_csv``
+    URL for the CSV export of this page
+
+``url_csv_hidden_args``
+    (name, value) pairs for hidden form fields used by the CSV export form
+
+``url_csv_path``
+    Path portion of the CSV export URL
+
+``view_definition``
+    SQL definition for this view
+
+Row page
+--------
+
+The page showing an individual row, e.g. /fixtures/facetable/1. Rendered using the ``row.html`` template.
+
+Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
+
+``alternate_url_json``
+    URL for the JSON version of this page
+
+``columns``
+    Column names returned by this query
+
+``custom_table_templates``
+    Custom template names that were considered for displaying this table
+
+``database``
+    Database name
+
+``database_color``
+    Color assigned to the database
+
+``display_columns``
+    Column objects formatted for the HTML table display
+
+``display_rows``
+    Row data formatted for the HTML table display
+
+``foreign_key_tables``
+    Tables that link to this row using foreign keys
+
+``metadata``
+    Metadata about the table, database or stored query
+
+``ok``
+    True if the data for this page was retrieved without errors
+
+``primary_key_values``
+    Values of the primary keys for this row, from the URL
+
+``primary_keys``
+    Primary keys for this table
+
+``private``
+    Whether this resource is private to the current actor
+
+``query_ms``
+    Time taken by the SQL queries for this page, in milliseconds
+
+``renderers``
+    Dictionary mapping output format names (e.g. json) to their URLs for this page
+
+``row_actions``
+    Row actions made available by plugin hooks
+
+``rows``
+    The rows for this page, as a list of dictionaries mapping column name to value
+
+``select_templates``
+    List of template names that were considered for this page, the one used marked with an asterisk
+
+``settings``
+    Dictionary of Datasette's current settings
+
+``table``
+    Table name
+
+``top_row``
+    Async function rendering the top_row plugin slot
+
+``url_csv``
+    URL for the CSV export of this page
+
+``url_csv_hidden_args``
+    (name, value) pairs for hidden form fields used by the CSV export form
+
+``url_csv_path``
+    Path portion of the CSV export URL
+
+.. [[[end]]]
diff --git a/docs/template_context_doc.py b/docs/template_context_doc.py
new file mode 100644
index 00000000..1539dc5e
--- /dev/null
+++ b/docs/template_context_doc.py
@@ -0,0 +1,54 @@
+"""
+Cog helpers for generating docs/template_context.rst from the manifest
+in datasette/template_contexts.py - same pattern as json_api_doc.py.
+"""
+
+
+def template_context(cog):
+    from datasette.template_contexts import BASE_CONTEXT_KEYS, PAGES
+
+    cog.out("\n")
+    _section(
+        cog,
+        "Base context",
+        (
+            "These variables are available on every page rendered by "
+            "Datasette, including pages rendered by plugins that use "
+            ":ref:`datasette.render_template() <datasette_render_template>`. "
+            "Plugins can add additional variables using the "
+            ":ref:`plugin_hook_extra_template_vars` hook."
+        ),
+    )
+    _untyped_keys(cog, BASE_CONTEXT_KEYS)
+
+    for page in PAGES.values():
+        _section(
+            cog,
+            "{} page".format(page.title),
+            "{} Rendered using the ``{}`` template.".format(
+                page.description, page.template
+            ),
+        )
+        if page.context_class is not None:
+            for f in sorted(
+                page.context_class.documented_fields(), key=lambda f: f.name
+            ):
+                cog.out("``{}`` - ``{}``\n".format(f.name, f.type_name))
+                cog.out("    {}\n\n".format(f.help))
+        else:
+            cog.out(
+                "Many of these keys are shared with the :ref:`JSON API "
+                "<json_api>` for this page.\n\n"
+            )
+            _untyped_keys(cog, page.documented_keys())
+
+
+def _section(cog, title, intro):
+    cog.out("{}\n{}\n\n".format(title, "-" * len(title)))
+    cog.out("{}\n\n".format(intro))
+
+
+def _untyped_keys(cog, keys):
+    for key in keys:
+        cog.out("``{}``\n".format(key.name))
+        cog.out("    {}\n\n".format(key.doc))
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index 04002f31..73e1d6c1 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -5,6 +5,7 @@ template authors can rely on for Datasette 1.0.
 
 import html
 import json
+import pathlib
 from dataclasses import dataclass, field
 
 import pytest
@@ -76,9 +77,7 @@ async def get_template_context(ds, path):
     sep = "&" if "?" in path else "?"
     response = await ds.client.get(path + sep + "_context=1")
     assert response.status_code == 200, path
-    body = html.unescape(
-        response.text.removeprefix("<pre>").removesuffix("</pre>")
-    )
+    body = html.unescape(response.text.removeprefix("<pre>").removesuffix("</pre>"))
     return json.loads(body)
 
 
@@ -124,12 +123,26 @@ def test_page_documented_keys_all_have_docs(page):
         assert key.doc, "{} page key {} is missing docs".format(page.name, key.name)
 
 
+def test_template_context_docs_cover_every_documented_key():
+    docs_path = pathlib.Path(__file__).parent.parent / "docs" / "template_context.rst"
+    assert docs_path.exists(), "docs/template_context.rst is missing"
+    docs = docs_path.read_text()
+    for key in BASE_CONTEXT_KEYS:
+        assert "``{}``".format(key.name) in docs, key.name
+    for page in PAGES.values():
+        assert page.title in docs, page.title
+        for key in page.documented_keys():
+            assert "``{}``".format(key.name) in docs, "{} ({} page)".format(
+                key.name, page.name
+            )
+
+
 @pytest.mark.parametrize("page", PAGES.values(), ids=lambda page: page.name)
 def test_page_extra_keys_are_registered_extras(page):
     for name in page.extra_keys:
         cls = table_extra_registry.classes_by_name.get(name)
         assert cls is not None, "{} is not a registered extra".format(name)
         assert page.extras_scope is not None
-        assert cls.available_for(page.extras_scope), (
-            "{} extra is not available for scope {}".format(name, page.extras_scope)
-        )
+        assert cls.available_for(
+            page.extras_scope
+        ), "{} extra is not available for scope {}".format(name, page.extras_scope)

From 3ea7ed86065d3071fa76c755bdfa63e6776ea7cc Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 00:06:56 -0700
Subject: [PATCH 175/386] Isolate test plugins from template context contract
 tests

Datasette instances created with plugins_dir register their plugins on
the global plugin manager for the rest of the process, so the contract
tests could see extra_template_vars keys leaked from earlier test
modules (e.g. the session-scoped ds_client fixture). A fixture now
unregisters non-default plugins implementing extra_template_vars for
the duration of each contract test and restores them afterwards.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 tests/test_template_context.py | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index 73e1d6c1..3c6b13de 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -44,6 +44,27 @@ def test_context_dataclass_fields_all_have_help(klass):
         )
 
 
+@pytest.fixture
+def isolate_extra_template_vars_plugins():
+    # Datasette instances created with plugins_dir (e.g. the session-scoped
+    # ds_client fixture) register their plugins on the global plugin manager
+    # for the rest of the process. The contract documents plugin-free
+    # Datasette core, so unregister any non-default plugin that adds
+    # template variables via the extra_template_vars hook
+    from datasette.plugins import pm, DEFAULT_PLUGINS
+
+    hook_plugins = {impl.plugin for impl in pm.hook.extra_template_vars.get_hookimpls()}
+    removed = []
+    for plugin in list(pm.get_plugins()):
+        name = pm.get_name(plugin)
+        if name not in DEFAULT_PLUGINS and plugin in hook_plugins:
+            pm.unregister(plugin)
+            removed.append((plugin, name))
+    yield
+    for plugin, name in removed:
+        pm.register(plugin, name)
+
+
 @pytest.fixture(scope="module")
 def context_ds(tmp_path_factory):
     db_path = tmp_path_factory.mktemp("template-context") / "fixtures.db"
@@ -94,7 +115,7 @@ async def get_template_context(ds, path):
     ),
 )
 async def test_template_context_matches_documented_contract(
-    context_ds, page_name, path
+    context_ds, isolate_extra_template_vars_plugins, page_name, path
 ):
     # The full contract: every key in the rendered template context is
     # documented, and every documented key is present in the context

From 63995ce823124569968e9dfdcc94221c59a83810 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 06:51:54 -0700
Subject: [PATCH 176/386] extra_field() - Context fields documented by their
 Extra class

A Context dataclass field declared with extra_field() takes its
documentation from the description on the registered Extra of the same
name, validated against the class's extras_scope. This keeps doc
strings next to the resolve() code instead of duplicating them on the
dataclass, ahead of introducing TableContext and RowContext.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/__init__.py    | 47 +++++++++++++++++++++++++++++++++-
 tests/test_template_context.py | 45 ++++++++++++++++++++++++++++++++
 2 files changed, 91 insertions(+), 1 deletion(-)

diff --git a/datasette/views/__init__.py b/datasette/views/__init__.py
index de851708..238b9bb3 100644
--- a/datasette/views/__init__.py
+++ b/datasette/views/__init__.py
@@ -7,21 +7,66 @@ class ContextField:
     name: str
     type_name: str
     help: str
+    from_extra: bool = False
+
+
+def extra_field():
+    """
+    Declare a Context dataclass field whose value comes from a registered
+    Extra of the same name - its documentation is the Extra description,
+    so the doc string lives next to the resolve() code rather than being
+    duplicated on the dataclass.
+    """
+    return dataclasses.field(metadata={"from_extra": True})
 
 
 class Context:
     "Base class for all documented contexts"
 
+    # Set on subclasses whose extra_field() fields should be resolved
+    # against the extras registry for this scope
+    extras_scope = None
+
     @classmethod
     def documented_fields(cls):
         "List of ContextField describing the documented fields of this context"
         documented = []
         for f in dataclasses.fields(cls):
+            from_extra = bool(f.metadata.get("from_extra"))
+            if from_extra:
+                help_text = cls._extra_description(f.name)
+            else:
+                help_text = f.metadata.get("help", "")
             documented.append(
                 ContextField(
                     name=f.name,
                     type_name=getattr(f.type, "__name__", str(f.type)),
-                    help=f.metadata.get("help", ""),
+                    help=help_text,
+                    from_extra=from_extra,
                 )
             )
         return documented
+
+    @classmethod
+    def _extra_description(cls, name):
+        # Imported lazily - table_extras is not needed just to define
+        # Context subclasses
+        from datasette.views.table_extras import table_extra_registry
+
+        try:
+            extra_class = table_extra_registry.classes_by_name[name]
+        except KeyError:
+            raise KeyError(
+                "{}.{} is declared with extra_field() but there is no "
+                "registered extra of that name".format(cls.__name__, name)
+            )
+        if cls.extras_scope is not None and not extra_class.available_for(
+            cls.extras_scope
+        ):
+            raise ValueError(
+                "{}.{} is declared with extra_field() but the {} extra is "
+                "not available for scope {}".format(
+                    cls.__name__, name, name, cls.extras_scope
+                )
+            )
+        return extra_class.description or ""
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index 3c6b13de..c385097a 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -44,6 +44,51 @@ def test_context_dataclass_fields_all_have_help(klass):
         )
 
 
+def test_extra_field_documentation_comes_from_the_extra_class():
+    from datasette.views import extra_field
+    from datasette.views.table_extras import CountExtra
+
+    @dataclass
+    class DemoContext(Context):
+        extras_scope = ExtraScope.TABLE
+
+        count: int = extra_field()
+        name: str = field(metadata={"help": "The name"})
+
+    fields = {f.name: f for f in DemoContext.documented_fields()}
+    assert fields["count"].help == CountExtra.description
+    assert fields["count"].from_extra
+    assert fields["name"].help == "The name"
+    assert not fields["name"].from_extra
+
+
+def test_extra_field_must_match_a_registered_extra():
+    from datasette.views import extra_field
+
+    @dataclass
+    class BadContext(Context):
+        extras_scope = ExtraScope.TABLE
+
+        not_a_real_extra: str = extra_field()
+
+    with pytest.raises(KeyError):
+        BadContext.documented_fields()
+
+
+def test_extra_field_must_be_available_for_the_scope():
+    from datasette.views import extra_field
+
+    @dataclass
+    class WrongScopeContext(Context):
+        extras_scope = ExtraScope.ROW
+
+        # count is a TABLE-scope extra, not available for ROW
+        count: int = extra_field()
+
+    with pytest.raises(ValueError):
+        WrongScopeContext.documented_fields()
+
+
 @pytest.fixture
 def isolate_extra_template_vars_plugins():
     # Datasette instances created with plugins_dir (e.g. the session-scoped

From 8b89a3aca85bdf8eee93b9f4677dd85b2599dcb3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 06:57:51 -0700
Subject: [PATCH 177/386] TableContext - table page now renders a documented
 Context dataclass

The table HTML view constructs a TableContext instead of an ad-hoc
dict, matching how the database and query pages already work. Fields
resolved by registered extras are declared with extra_field() so their
documentation lives on the Extra classes in table_extras.py; fields
added by the view code carry help metadata next to the view.

render_template() now converts Context dataclasses shallowly instead
of via dataclasses.asdict(), which deep-copied every value and would
fail on values like sqlite3.Row.

Keys not declared on TableContext - extras requested with ?_extra= on
the HTML page, or extra filter context from filters_from_request
plugins - are now dropped from the HTML template context rather than
passed through undocumented.

Refs #2127

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/app.py                  |   6 +-
 datasette/views/table.py          | 136 +++++++++++++++++++++++++++++-
 tests/test_internals_datasette.py |  25 ++++++
 tests/test_template_context.py    |   8 ++
 4 files changed, 172 insertions(+), 3 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 81d23acb..275baae4 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2162,7 +2162,11 @@ class Datasette:
                 templates = [templates]
             template = self.get_jinja_environment(request).select_template(templates)
         if dataclasses.is_dataclass(context):
-            context = dataclasses.asdict(context)
+            # Shallow conversion - asdict() would deep-copy values, which
+            # is wasteful and fails on values like sqlite3.Row
+            context = {
+                f.name: getattr(context, f.name) for f in dataclasses.fields(context)
+            }
         body_scripts = []
         # pylint: disable=no-member
         for extra_script in pm.hook.extra_body_script(
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 65388c9c..356247ff 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -43,6 +43,10 @@ from datasette.utils import (
 from datasette.utils.asgi import BadRequest, Forbidden, NotFound, Response
 from datasette.filters import Filters
 import sqlite_utils
+from dataclasses import dataclass, field, fields
+
+from datasette.extras import ExtraScope
+from . import Context, extra_field
 from .base import BaseView, DatasetteError, _error, stream_csv
 from .database import QueryView
 from .table_extras import (
@@ -52,6 +56,129 @@ from .table_extras import (
     table_extra_registry,
 )
 
+
+@dataclass
+class TableContext(Context):
+    "The page showing the rows in a table or SQL view, e.g. /fixtures/facetable"
+
+    extras_scope = ExtraScope.TABLE
+
+    # Fields resolved by registered extras - their documentation comes
+    # from the description on each Extra class in table_extras.py
+    actions: callable = extra_field()
+    all_columns: list = extra_field()
+    columns: list = extra_field()
+    count: int = extra_field()
+    count_sql: str = extra_field()
+    custom_table_templates: list = extra_field()
+    database: str = extra_field()
+    database_color: str = extra_field()
+    display_columns: list = extra_field()
+    display_rows: list = extra_field()
+    expandable_columns: list = extra_field()
+    facet_results: dict = extra_field()
+    facets_timed_out: list = extra_field()
+    filters: Filters = extra_field()
+    form_hidden_args: list = extra_field()
+    human_description_en: str = extra_field()
+    is_view: bool = extra_field()
+    metadata: dict = extra_field()
+    next_url: str = extra_field()
+    primary_keys: list = extra_field()
+    private: bool = extra_field()
+    query: dict = extra_field()
+    renderers: dict = extra_field()
+    set_column_type_ui: dict = extra_field()
+    sorted_facet_results: list = extra_field()
+    suggested_facets: list = extra_field()
+    table: str = extra_field()
+    table_definition: str = extra_field()
+    view_definition: str = extra_field()
+
+    # Fields added by the view code
+    ok: bool = field(
+        metadata={"help": "True if the data for this page was retrieved without errors"}
+    )
+    next: str = field(metadata={"help": "Pagination token for the next page, or None"})
+    rows: list = field(
+        metadata={
+            "help": "The rows for this page, as a list of dictionaries mapping column name to value"
+        }
+    )
+    filter_columns: list = field(
+        metadata={"help": "List of columns offered by the filter interface"}
+    )
+    supports_search: bool = field(
+        metadata={"help": "True if this table has full-text search configured"}
+    )
+    extra_wheres_for_ui: list = field(
+        metadata={
+            "help": "Extra where clauses from ?_where=, with links to remove them"
+        }
+    )
+    url_csv: str = field(metadata={"help": "URL for the CSV export of this page"})
+    url_csv_path: str = field(metadata={"help": "Path portion of the CSV export URL"})
+    url_csv_hidden_args: list = field(
+        metadata={
+            "help": "(name, value) pairs for hidden form fields used by the CSV export form"
+        }
+    )
+    sort: str = field(metadata={"help": "Column the page is sorted by, or None"})
+    sort_desc: str = field(
+        metadata={"help": "Column the page is sorted by in descending order, or None"}
+    )
+    append_querystring: callable = field(
+        metadata={
+            "help": "Function that appends additional querystring arguments to a URL"
+        }
+    )
+    path_with_replaced_args: callable = field(
+        metadata={
+            "help": "Function for building the current path with modified querystring arguments"
+        }
+    )
+    fix_path: callable = field(
+        metadata={"help": "Function that applies the base_url prefix to a path"}
+    )
+    settings: dict = field(
+        metadata={"help": "Dictionary of Datasette's current settings"}
+    )
+    alternate_url_json: str = field(
+        metadata={"help": "URL for the JSON version of this page"}
+    )
+    datasette_allow_facet: str = field(
+        metadata={
+            "help": 'The string "true" or "false" reflecting the allow_facet setting'
+        }
+    )
+    is_sortable: bool = field(
+        metadata={"help": "True if any of the displayed columns can be used to sort"}
+    )
+    allow_execute_sql: bool = field(
+        metadata={
+            "help": "True if the current actor can execute custom SQL against this database"
+        }
+    )
+    query_ms: float = field(
+        metadata={
+            "help": "Time taken by the SQL queries for this page, in milliseconds"
+        }
+    )
+    select_templates: list = field(
+        metadata={
+            "help": "List of template names that were considered for this page, the one used marked with an asterisk"
+        }
+    )
+    top_table: callable = field(
+        metadata={"help": "Async function rendering the top_table plugin slot"}
+    )
+    count_limit: int = field(
+        metadata={
+            "help": "The maximum number of rows Datasette will count before showing an approximation"
+        }
+    )
+
+
 LINK_WITH_LABEL = (
     '<a href="{base_url}{database}/{table}/{link_id}">{label}</a>&nbsp;<em>{id}</em>'
 )
@@ -1084,11 +1211,16 @@ async def table_view_traced(datasette, request):
                 )
             }
         )
+        # Only keys declared on TableContext are part of the documented
+        # template contract - anything else in data (e.g. extras requested
+        # with ?_extra= on the HTML page, or extra filter context added by
+        # filters_from_request plugins) is dropped here
+        declared_fields = {f.name for f in fields(TableContext)}
         r = Response.html(
             await datasette.render_template(
                 template,
-                dict(
-                    data,
+                TableContext(
+                    **{k: v for k, v in data.items() if k in declared_fields},
                     append_querystring=append_querystring,
                     path_with_replaced_args=path_with_replaced_args,
                     fix_path=datasette.urls.path,
diff --git a/tests/test_internals_datasette.py b/tests/test_internals_datasette.py
index 3f867eb0..e9c78ecc 100644
--- a/tests/test_internals_datasette.py
+++ b/tests/test_internals_datasette.py
@@ -344,3 +344,28 @@ async def test_datasette_close_continues_past_db_error():
         ds.close()
     assert good._closed
     assert ds._internal_database._closed
+
+
+@pytest.mark.asyncio
+async def test_datasette_render_template_dataclass_values_not_deep_copied():
+    # display_rows can contain values like sqlite3.Row that cannot be
+    # deep-copied, so render_template must convert Context dataclasses
+    # shallowly - https://github.com/simonw/datasette/issues/2127
+    class RefusesDeepCopy:
+        def __deepcopy__(self, memo):
+            raise RuntimeError("deepcopy not supported")
+
+        def __str__(self):
+            return "shallow-copied-value"
+
+    @dataclasses.dataclass
+    class ExampleContext(Context):
+        title: str
+        status: int
+        error: RefusesDeepCopy
+
+    context = ExampleContext(title="Hello", status=200, error=RefusesDeepCopy())
+    ds = Datasette(memory=True)
+    await ds.invoke_startup()
+    rendered = await ds.render_template("error.html", context)
+    assert "shallow-copied-value" in rendered
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index c385097a..4f08c476 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -178,6 +178,14 @@ async def test_template_context_matches_documented_contract(
     )
 
 
+def test_table_context_fields_match_documented_contract():
+    from datasette.views.table import TableContext
+
+    assert {f.name for f in TableContext.documented_fields()} == {
+        key.name for key in PAGES["table"].documented_keys()
+    }
+
+
 def test_base_context_keys_all_have_docs():
     for key in BASE_CONTEXT_KEYS:
         assert key.doc, "Base context key {} is missing docs".format(key.name)

From 3cc0fc07b49da3c9757ad33c73187f4fe49af557 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 07:01:57 -0700
Subject: [PATCH 178/386] RowContext - row page now renders a documented
 Context dataclass

RowView declares context_class = RowContext; BaseView.render()
constructs the dataclass from the assembled context, dropping any keys
not declared on the class, after select_templates and
alternate_url_json have been added. Extras-named fields use
extra_field() so their documentation comes from the Extra classes;
view-added fields carry help metadata next to the view code.

Refs #2127

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/views/base.py        |  9 ++++
 datasette/views/row.py         | 81 +++++++++++++++++++++++++++++++++-
 tests/test_template_context.py |  8 ++++
 3 files changed, 97 insertions(+), 1 deletion(-)

diff --git a/datasette/views/base.py b/datasette/views/base.py
index 2e2a5443..a3a207bd 100644
--- a/datasette/views/base.py
+++ b/datasette/views/base.py
@@ -1,5 +1,6 @@
 import asyncio
 import csv
+import dataclasses
 import hashlib
 import sys
 import textwrap
@@ -88,6 +89,9 @@ class View:
 class BaseView:
     ds = None
     has_json_alternate = True
+    # Set to a Context subclass to render a documented template context -
+    # keys not declared on the class are dropped before rendering
+    context_class = None
 
     def __init__(self, datasette):
         self.ds = datasette
@@ -169,6 +173,11 @@ class BaseView:
                     )
                 }
             )
+        if self.context_class is not None:
+            declared = {f.name for f in dataclasses.fields(self.context_class)}
+            template_context = self.context_class(
+                **{k: v for k, v in template_context.items() if k in declared}
+            )
         return Response.html(
             await self.ds.render_template(
                 template,
diff --git a/datasette/views/row.py b/datasette/views/row.py
index c300758b..f7475117 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -11,16 +11,95 @@ from datasette.utils import (
     escape_sqlite,
 )
 from datasette.plugins import pm
+from dataclasses import dataclass, field
 import json
 import markupsafe
 import sqlite_utils
-from datasette.extras import extra_names_from_request
+from datasette.extras import extra_names_from_request, ExtraScope
+from . import Context, extra_field
 from .table import display_columns_and_rows
 from .table_extras import RowExtraContext, resolve_row_extras, table_extra_registry
 
 
+@dataclass
+class RowContext(Context):
+    "The page showing an individual row, e.g. /fixtures/facetable/1"
+
+    extras_scope = ExtraScope.ROW
+
+    # Fields resolved by registered extras - their documentation comes
+    # from the description on each Extra class in table_extras.py
+    columns: list = extra_field()
+    database: str = extra_field()
+    database_color: str = extra_field()
+    foreign_key_tables: list = extra_field()
+    metadata: dict = extra_field()
+    primary_keys: list = extra_field()
+    private: bool = extra_field()
+    table: str = extra_field()
+
+    # Fields added by the view code
+    ok: bool = field(
+        metadata={"help": "True if the data for this page was retrieved without errors"}
+    )
+    rows: list = field(
+        metadata={
+            "help": "The rows for this page, as a list of dictionaries mapping column name to value"
+        }
+    )
+    primary_key_values: list = field(
+        metadata={"help": "Values of the primary keys for this row, from the URL"}
+    )
+    query_ms: float = field(
+        metadata={
+            "help": "Time taken by the SQL queries for this page, in milliseconds"
+        }
+    )
+    display_columns: list = field(
+        metadata={"help": "Column objects formatted for the HTML table display"}
+    )
+    display_rows: list = field(
+        metadata={"help": "Row data formatted for the HTML table display"}
+    )
+    custom_table_templates: list = field(
+        metadata={
+            "help": "Custom template names that were considered for displaying this table"
+        }
+    )
+    row_actions: list = field(
+        metadata={"help": "Row actions made available by plugin hooks"}
+    )
+    top_row: callable = field(
+        metadata={"help": "Async function rendering the top_row plugin slot"}
+    )
+    renderers: dict = field(
+        metadata={
+            "help": "Dictionary mapping output format names (e.g. json) to their URLs for this page"
+        }
+    )
+    url_csv: str = field(metadata={"help": "URL for the CSV export of this page"})
+    url_csv_path: str = field(metadata={"help": "Path portion of the CSV export URL"})
+    url_csv_hidden_args: list = field(
+        metadata={
+            "help": "(name, value) pairs for hidden form fields used by the CSV export form"
+        }
+    )
+    settings: dict = field(
+        metadata={"help": "Dictionary of Datasette's current settings"}
+    )
+    select_templates: list = field(
+        metadata={
+            "help": "List of template names that were considered for this page, the one used marked with an asterisk"
+        }
+    )
+    alternate_url_json: str = field(
+        metadata={"help": "URL for the JSON version of this page"}
+    )
+
+
 class RowView(DataView):
     name = "row"
+    context_class = RowContext
 
     async def data(self, request, default_labels=False):
         resolved = await self.ds.resolve_row(request)
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index 4f08c476..0c694b2e 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -186,6 +186,14 @@ def test_table_context_fields_match_documented_contract():
     }
 
 
+def test_row_context_fields_match_documented_contract():
+    from datasette.views.row import RowContext
+
+    assert {f.name for f in RowContext.documented_fields()} == {
+        key.name for key in PAGES["row"].documented_keys()
+    }
+
+
 def test_base_context_keys_all_have_docs():
     for key in BASE_CONTEXT_KEYS:
         assert key.doc, "Base context key {} is missing docs".format(key.name)

From 8e01542fe98c237eff1390353c9c1287050f2edd Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 07:08:21 -0700
Subject: [PATCH 179/386] One consistent pattern: every page context is a
 Context dataclass

datasette/template_contexts.py is now a thin index with no
documentation strings of its own - the docs live next to the code:

- Each page's Context class (DatabaseContext, QueryContext,
  TableContext, RowContext) carries a docstring, its template name and
  help metadata on view-added fields, in the view module itself
- extra_field() fields document themselves from the Extra classes
- The keys render_template() adds to every page are documented in
  TEMPLATE_BASE_CONTEXT in app.py, next to the code that adds them,
  with the contract tests keeping the two in sync

docs/template_context.rst is regenerated from the dataclasses, so the
table and row pages now include field types like the others.

Refs #2127

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/app.py               |  28 ++++
 datasette/template_contexts.py | 250 ++++-----------------------------
 datasette/views/database.py    |   8 ++
 datasette/views/row.py         |   3 +-
 datasette/views/table.py       |   3 +-
 docs/template_context.rst      | 152 ++++++++++----------
 docs/template_context_doc.py   |  41 +++---
 tests/test_template_context.py |  78 +++-------
 8 files changed, 180 insertions(+), 383 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 275baae4..b683969a 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -313,6 +313,32 @@ def _to_string(value):
         return json.dumps(value, default=str)
 
 
+# Documentation for the variables Datasette.render_template() adds to the
+# context for every page. This is part of the documented template contract:
+# keys added in render_template() must be documented here - the contract
+# tests in tests/test_template_context.py enforce this, and the docs in
+# docs/template_context.rst are generated from it.
+TEMPLATE_BASE_CONTEXT = {
+    "request": "The current Request object, or None",
+    "crumb_items": "Async function returning breadcrumb navigation items for the current page",
+    "urls": "Object with methods for constructing URLs to pages within Datasette - see datasette.urls in the internals documentation",
+    "actor": "The currently authenticated actor dictionary, or None",
+    "menu_links": "Async function returning links for the Datasette application menu, including those added by plugins",
+    "display_actor": "Function returning a display string for an actor dictionary",
+    "show_logout": "True if the logout link should be shown in the navigation menu",
+    "app_css_hash": "Hash of Datasette's app.css contents, used for cache busting",
+    "zip": "Python's zip() builtin, made available to template logic",
+    "body_scripts": "List of script blocks for the page body contributed by plugins",
+    "format_bytes": "Function that formats a number of bytes as a human-readable size",
+    "show_messages": "Function returning any messages set for the current user, clearing them in the process",
+    "extra_css_urls": "List of {url, sri} dictionaries of extra CSS stylesheets to include on the page, from plugins and configuration",
+    "extra_js_urls": "List of {url, sri, module} dictionaries of extra JavaScript URLs to include on the page",
+    "base_url": "The configured base_url setting",
+    "csrftoken": "Function returning the CSRF token for the current request",
+    "datasette_version": "The version of Datasette that is running",
+}
+
+
 class Datasette:
     # Message constants:
     INFO = 1
@@ -2216,6 +2242,8 @@ class Datasette:
                     links.extend(extra_links)
             return links
 
+        # Keys added here must be documented in TEMPLATE_BASE_CONTEXT -
+        # the contract tests fail otherwise
         template_context = {
             **context,
             **{
diff --git a/datasette/template_contexts.py b/datasette/template_contexts.py
index e2854467..5fe6a80e 100644
--- a/datasette/template_contexts.py
+++ b/datasette/template_contexts.py
@@ -1,240 +1,40 @@
 """
-The documented template context for Datasette's core HTML pages.
+Index of the documented template contexts for Datasette's core HTML pages.
 
-This module is the source of truth for the template context contract:
-the set of variables that custom templates can rely on for each page.
-It is consumed by the contract tests in tests/test_template_context.py,
-which assert that the real rendered context for each page exactly
-matches what is documented here, and by docs/template_context_doc.py
-which generates the documentation in docs/template_context.rst.
+This module deliberately contains no documentation strings of its own -
+the documentation lives next to the code it describes:
 
-Documentation for each key comes from one of three places:
+- Every page renders a Context dataclass defined in its view module
+  (DatabaseContext, QueryContext in views/database.py, TableContext in
+  views/table.py, RowContext in views/row.py). Fields added by view code
+  carry ``help`` metadata; fields declared with extra_field() take their
+  documentation from the description on the matching Extra class in
+  views/table_extras.py.
+- The keys render_template() adds to every page are documented in
+  TEMPLATE_BASE_CONTEXT in datasette/app.py, next to the code that adds
+  them.
 
-- Pages that render a Context dataclass (database, query) use the
-  ``help`` metadata on each dataclass field
-- Keys provided by registered extras use the ``description`` from the
-  Extra class
-- Keys added inline by view code are documented in this module
+The contract tests in tests/test_template_context.py assert that the real
+rendered context for each page exactly matches what is documented, and
+docs/template_context_doc.py generates docs/template_context.rst from the
+same classes.
 """
 
-from dataclasses import dataclass
-
-from datasette.extras import ExtraScope
+from datasette.app import TEMPLATE_BASE_CONTEXT
 from datasette.views.database import DatabaseContext, QueryContext
-from datasette.views.table_extras import table_extra_registry
-
-
-@dataclass(frozen=True)
-class TemplateContextKey:
-    name: str
-    doc: str
-
-
-def _keys(**docs):
-    return tuple(TemplateContextKey(name, doc) for name, doc in docs.items())
-
-
-# Added by Datasette.render_template() to the context for every page,
-# including pages rendered by plugins
-BASE_CONTEXT_KEYS = _keys(
-    request="The current Request object, or None",
-    crumb_items="Async function returning breadcrumb navigation items for the current page",
-    urls="Object with methods for constructing URLs to pages within Datasette - see datasette.urls in the internals documentation",
-    actor="The currently authenticated actor dictionary, or None",
-    menu_links="Async function returning links for the Datasette application menu, including those added by plugins",
-    display_actor="Function returning a display string for an actor dictionary",
-    show_logout="True if the logout link should be shown in the navigation menu",
-    app_css_hash="Hash of Datasette's app.css contents, used for cache busting",
-    zip="Python's zip() builtin, made available to template logic",
-    body_scripts="List of script blocks for the page body contributed by plugins",
-    format_bytes="Function that formats a number of bytes as a human-readable size",
-    show_messages="Function returning any messages set for the current user, clearing them in the process",
-    extra_css_urls="List of {url, sri} dictionaries of extra CSS stylesheets to include on the page, from plugins and configuration",
-    extra_js_urls="List of {url, sri, module} dictionaries of extra JavaScript URLs to include on the page",
-    base_url="The configured base_url setting",
-    csrftoken="Function returning the CSRF token for the current request",
-    datasette_version="The version of Datasette that is running",
-)
-
-
-@dataclass(frozen=True)
-class PageContext:
-    # Identifier used in tests and documentation, e.g. "table"
-    name: str
-    title: str
-    description: str
-    # The default template used to render this page
-    template: str
-    # For pages rendered from a Context dataclass
-    context_class: type = None
-    # For pages whose context includes resolved extras
-    extras_scope: ExtraScope = None
-    extra_keys: tuple = ()
-    # Keys added inline by the view code, documented here
-    keys: tuple = ()
-
-    def documented_keys(self):
-        "Every page-specific documented key, excluding BASE_CONTEXT_KEYS"
-        documented = []
-        if self.context_class is not None:
-            documented.extend(
-                TemplateContextKey(f.name, f.help)
-                for f in self.context_class.documented_fields()
-            )
-        for name in self.extra_keys:
-            cls = table_extra_registry.classes_by_name[name]
-            documented.append(TemplateContextKey(name, cls.description or ""))
-        documented.extend(self.keys)
-        return sorted(documented, key=lambda key: key.name)
-
-
-_SHARED_DOCS = dict(
-    ok="True if the data for this page was retrieved without errors",
-    rows="The rows for this page, as a list of dictionaries mapping column name to value",
-    query_ms="Time taken by the SQL queries for this page, in milliseconds",
-    select_templates="List of template names that were considered for this page, the one used marked with an asterisk",
-    settings="Dictionary of Datasette's current settings",
-    alternate_url_json="URL for the JSON version of this page",
-    url_csv="URL for the CSV export of this page",
-    url_csv_path="Path portion of the CSV export URL",
-    url_csv_hidden_args="(name, value) pairs for hidden form fields used by the CSV export form",
-    renderers="Dictionary mapping output format names (e.g. json) to their URLs for this page",
-    display_columns="Column objects formatted for the HTML table display",
-    display_rows="Row data formatted for the HTML table display",
-    custom_table_templates="Custom template names that were considered for displaying this table",
-)
-
-
-def _shared(*names):
-    return tuple(TemplateContextKey(name, _SHARED_DOCS[name]) for name in names)
-
+from datasette.views.row import RowContext
+from datasette.views.table import TableContext
 
 PAGES = {
-    page.name: page
-    for page in (
-        PageContext(
-            name="database",
-            title="Database",
-            description="The page listing the tables, views and queries in a database, e.g. /fixtures.",
-            template="database.html",
-            context_class=DatabaseContext,
-        ),
-        PageContext(
-            name="query",
-            title="Query",
-            description="The page for arbitrary SQL queries (/database/-/query?sql=...) and stored queries (/database/query-name).",
-            template="query.html",
-            context_class=QueryContext,
-        ),
-        PageContext(
-            name="table",
-            title="Table",
-            description="The page showing the rows in a table or SQL view, e.g. /fixtures/facetable.",
-            template="table.html",
-            extras_scope=ExtraScope.TABLE,
-            extra_keys=(
-                "actions",
-                "all_columns",
-                "columns",
-                "count",
-                "count_sql",
-                "custom_table_templates",
-                "database",
-                "database_color",
-                "display_columns",
-                "display_rows",
-                "expandable_columns",
-                "facet_results",
-                "facets_timed_out",
-                "filters",
-                "form_hidden_args",
-                "human_description_en",
-                "is_view",
-                "metadata",
-                "next_url",
-                "primary_keys",
-                "private",
-                "query",
-                "renderers",
-                "set_column_type_ui",
-                "sorted_facet_results",
-                "suggested_facets",
-                "table",
-                "table_definition",
-                "view_definition",
-            ),
-            keys=_shared(
-                "ok",
-                "rows",
-                "query_ms",
-                "select_templates",
-                "settings",
-                "alternate_url_json",
-                "url_csv",
-                "url_csv_path",
-                "url_csv_hidden_args",
-            )
-            + _keys(
-                allow_execute_sql="True if the current actor can execute custom SQL against this database",
-                append_querystring="Function that appends additional querystring arguments to a URL",
-                count_limit="The maximum number of rows Datasette will count before showing an approximation",
-                datasette_allow_facet='The string "true" or "false" reflecting the allow_facet setting',
-                extra_wheres_for_ui="Extra where clauses from ?_where=, with links to remove them",
-                filter_columns="List of columns offered by the filter interface",
-                fix_path="Function that applies the base_url prefix to a path",
-                is_sortable="True if any of the displayed columns can be used to sort",
-                next="Pagination token for the next page, or None",
-                path_with_replaced_args="Function for building the current path with modified querystring arguments",
-                sort="Column the page is sorted by, or None",
-                sort_desc="Column the page is sorted by in descending order, or None",
-                supports_search="True if this table has full-text search configured",
-                top_table="Async function rendering the top_table plugin slot",
-            ),
-        ),
-        PageContext(
-            name="row",
-            title="Row",
-            description="The page showing an individual row, e.g. /fixtures/facetable/1.",
-            template="row.html",
-            extras_scope=ExtraScope.ROW,
-            extra_keys=(
-                "columns",
-                "database",
-                "database_color",
-                "foreign_key_tables",
-                "metadata",
-                "primary_keys",
-                "private",
-                "table",
-            ),
-            keys=_shared(
-                "ok",
-                "rows",
-                "query_ms",
-                "select_templates",
-                "settings",
-                "alternate_url_json",
-                "url_csv",
-                "url_csv_path",
-                "url_csv_hidden_args",
-                "renderers",
-                "display_columns",
-                "display_rows",
-                "custom_table_templates",
-            )
-            + _keys(
-                primary_key_values="Values of the primary keys for this row, from the URL",
-                row_actions="Row actions made available by plugin hooks",
-                top_row="Async function rendering the top_row plugin slot",
-            ),
-        ),
-    )
+    "database": DatabaseContext,
+    "query": QueryContext,
+    "table": TableContext,
+    "row": RowContext,
 }
 
 
 def documented_context_keys(page_name):
     "Set of every documented key for the named page, including base context keys"
-    page = PAGES[page_name]
-    return {key.name for key in BASE_CONTEXT_KEYS} | {
-        key.name for key in page.documented_keys()
+    return set(TEMPLATE_BASE_CONTEXT) | {
+        f.name for f in PAGES[page_name].documented_fields()
     }
diff --git a/datasette/views/database.py b/datasette/views/database.py
index f1756863..4f05c804 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -228,6 +228,10 @@ class DatabaseView(View):
 
 @dataclass
 class DatabaseContext(Context):
+    "The page listing the tables, views and queries in a database, e.g. /fixtures."
+
+    template = "database.html"
+
     database: str = field(metadata={"help": "The name of the database"})
     private: bool = field(
         metadata={"help": "Boolean indicating if this is a private database"}
@@ -281,6 +285,10 @@ class DatabaseContext(Context):
 
 @dataclass
 class QueryContext(Context):
+    "The page for arbitrary SQL queries (/database/-/query?sql=...) and stored queries (/database/query-name)."
+
+    template = "query.html"
+
     database: str = field(metadata={"help": "The name of the database being queried"})
     database_color: str = field(metadata={"help": "The color of the database"})
     query: dict = field(
diff --git a/datasette/views/row.py b/datasette/views/row.py
index f7475117..3ce02e21 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -23,8 +23,9 @@ from .table_extras import RowExtraContext, resolve_row_extras, table_extra_regis
 
 @dataclass
 class RowContext(Context):
-    "The page showing an individual row, e.g. /fixtures/facetable/1"
+    "The page showing an individual row, e.g. /fixtures/facetable/1."
 
+    template = "row.html"
     extras_scope = ExtraScope.ROW
 
     # Fields resolved by registered extras - their documentation comes
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 356247ff..8ad7fa8c 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -59,8 +59,9 @@ from .table_extras import (
 
 @dataclass
 class TableContext(Context):
-    "The page showing the rows in a table or SQL view, e.g. /fixtures/facetable"
+    "The page showing the rows in a table or SQL view, e.g. /fixtures/facetable."
 
+    template = "table.html"
     extras_scope = ExtraScope.TABLE
 
     # Fields resolved by registered extras - their documentation comes
diff --git a/docs/template_context.rst b/docs/template_context.rst
index a487a6e7..e0a34921 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -250,160 +250,160 @@ The page showing the rows in a table or SQL view, e.g. /fixtures/facetable. Rend
 
 Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
 
-``actions``
+``actions`` - ``callable``
     Table or view actions made available by plugin hooks
 
-``all_columns``
+``all_columns`` - ``list``
     All columns in the table, regardless of _col/_nocol filtering
 
-``allow_execute_sql``
+``allow_execute_sql`` - ``bool``
     True if the current actor can execute custom SQL against this database
 
-``alternate_url_json``
+``alternate_url_json`` - ``str``
     URL for the JSON version of this page
 
-``append_querystring``
+``append_querystring`` - ``callable``
     Function that appends additional querystring arguments to a URL
 
-``columns``
+``columns`` - ``list``
     Column names returned by this query
 
-``count``
+``count`` - ``int``
     Total count of rows matching these filters
 
-``count_limit``
+``count_limit`` - ``int``
     The maximum number of rows Datasette will count before showing an approximation
 
-``count_sql``
+``count_sql`` - ``str``
     SQL query used to calculate the total count
 
-``custom_table_templates``
+``custom_table_templates`` - ``list``
     Custom template names considered for this table
 
-``database``
+``database`` - ``str``
     Database name
 
-``database_color``
+``database_color`` - ``str``
     Color assigned to the database
 
-``datasette_allow_facet``
+``datasette_allow_facet`` - ``str``
     The string "true" or "false" reflecting the allow_facet setting
 
-``display_columns``
+``display_columns`` - ``list``
     Column metadata used by the HTML table display
 
-``display_rows``
+``display_rows`` - ``list``
     Row data formatted for the HTML table display
 
-``expandable_columns``
+``expandable_columns`` - ``list``
     Foreign key columns that can be expanded with labels
 
-``extra_wheres_for_ui``
+``extra_wheres_for_ui`` - ``list``
     Extra where clauses from ?_where=, with links to remove them
 
-``facet_results``
+``facet_results`` - ``dict``
     Results of facets calculated against this data
 
-``facets_timed_out``
+``facets_timed_out`` - ``list``
     Facet calculations that timed out
 
-``filter_columns``
+``filter_columns`` - ``list``
     List of columns offered by the filter interface
 
-``filters``
+``filters`` - ``Filters``
     Filters object used by the HTML table interface
 
-``fix_path``
+``fix_path`` - ``callable``
     Function that applies the base_url prefix to a path
 
-``form_hidden_args``
+``form_hidden_args`` - ``list``
     Hidden form arguments used by the HTML table interface
 
-``human_description_en``
+``human_description_en`` - ``str``
     Human-readable description of the filters
 
-``is_sortable``
+``is_sortable`` - ``bool``
     True if any of the displayed columns can be used to sort
 
-``is_view``
+``is_view`` - ``bool``
     Whether this resource is a view instead of a table
 
-``metadata``
+``metadata`` - ``dict``
     Metadata about the table, database or stored query
 
-``next``
+``next`` - ``str``
     Pagination token for the next page, or None
 
-``next_url``
+``next_url`` - ``str``
     Full URL for the next page of results
 
-``ok``
+``ok`` - ``bool``
     True if the data for this page was retrieved without errors
 
-``path_with_replaced_args``
+``path_with_replaced_args`` - ``callable``
     Function for building the current path with modified querystring arguments
 
-``primary_keys``
+``primary_keys`` - ``list``
     Primary keys for this table
 
-``private``
+``private`` - ``bool``
     Whether this resource is private to the current actor
 
-``query``
+``query`` - ``dict``
     Details of the underlying SQL query
 
-``query_ms``
+``query_ms`` - ``float``
     Time taken by the SQL queries for this page, in milliseconds
 
-``renderers``
+``renderers`` - ``dict``
     Alternative output renderers available for this table
 
-``rows``
+``rows`` - ``list``
     The rows for this page, as a list of dictionaries mapping column name to value
 
-``select_templates``
+``select_templates`` - ``list``
     List of template names that were considered for this page, the one used marked with an asterisk
 
-``set_column_type_ui``
+``set_column_type_ui`` - ``dict``
     Column type UI metadata for this table
 
-``settings``
+``settings`` - ``dict``
     Dictionary of Datasette's current settings
 
-``sort``
+``sort`` - ``str``
     Column the page is sorted by, or None
 
-``sort_desc``
+``sort_desc`` - ``str``
     Column the page is sorted by in descending order, or None
 
-``sorted_facet_results``
+``sorted_facet_results`` - ``list``
     Facet results sorted for display
 
-``suggested_facets``
+``suggested_facets`` - ``list``
     Suggestions for facets that might return interesting results
 
-``supports_search``
+``supports_search`` - ``bool``
     True if this table has full-text search configured
 
-``table``
+``table`` - ``str``
     Table name
 
-``table_definition``
+``table_definition`` - ``str``
     SQL definition for this table
 
-``top_table``
+``top_table`` - ``callable``
     Async function rendering the top_table plugin slot
 
-``url_csv``
+``url_csv`` - ``str``
     URL for the CSV export of this page
 
-``url_csv_hidden_args``
+``url_csv_hidden_args`` - ``list``
     (name, value) pairs for hidden form fields used by the CSV export form
 
-``url_csv_path``
+``url_csv_path`` - ``str``
     Path portion of the CSV export URL
 
-``view_definition``
+``view_definition`` - ``str``
     SQL definition for this view
 
 Row page
@@ -413,76 +413,76 @@ The page showing an individual row, e.g. /fixtures/facetable/1. Rendered using t
 
 Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
 
-``alternate_url_json``
+``alternate_url_json`` - ``str``
     URL for the JSON version of this page
 
-``columns``
+``columns`` - ``list``
     Column names returned by this query
 
-``custom_table_templates``
+``custom_table_templates`` - ``list``
     Custom template names that were considered for displaying this table
 
-``database``
+``database`` - ``str``
     Database name
 
-``database_color``
+``database_color`` - ``str``
     Color assigned to the database
 
-``display_columns``
+``display_columns`` - ``list``
     Column objects formatted for the HTML table display
 
-``display_rows``
+``display_rows`` - ``list``
     Row data formatted for the HTML table display
 
-``foreign_key_tables``
+``foreign_key_tables`` - ``list``
     Tables that link to this row using foreign keys
 
-``metadata``
+``metadata`` - ``dict``
     Metadata about the table, database or stored query
 
-``ok``
+``ok`` - ``bool``
     True if the data for this page was retrieved without errors
 
-``primary_key_values``
+``primary_key_values`` - ``list``
     Values of the primary keys for this row, from the URL
 
-``primary_keys``
+``primary_keys`` - ``list``
     Primary keys for this table
 
-``private``
+``private`` - ``bool``
     Whether this resource is private to the current actor
 
-``query_ms``
+``query_ms`` - ``float``
     Time taken by the SQL queries for this page, in milliseconds
 
-``renderers``
+``renderers`` - ``dict``
     Dictionary mapping output format names (e.g. json) to their URLs for this page
 
-``row_actions``
+``row_actions`` - ``list``
     Row actions made available by plugin hooks
 
-``rows``
+``rows`` - ``list``
     The rows for this page, as a list of dictionaries mapping column name to value
 
-``select_templates``
+``select_templates`` - ``list``
     List of template names that were considered for this page, the one used marked with an asterisk
 
-``settings``
+``settings`` - ``dict``
     Dictionary of Datasette's current settings
 
-``table``
+``table`` - ``str``
     Table name
 
-``top_row``
+``top_row`` - ``callable``
     Async function rendering the top_row plugin slot
 
-``url_csv``
+``url_csv`` - ``str``
     URL for the CSV export of this page
 
-``url_csv_hidden_args``
+``url_csv_hidden_args`` - ``list``
     (name, value) pairs for hidden form fields used by the CSV export form
 
-``url_csv_path``
+``url_csv_path`` - ``str``
     Path portion of the CSV export URL
 
 .. [[[end]]]
diff --git a/docs/template_context_doc.py b/docs/template_context_doc.py
index 1539dc5e..c3ec77e2 100644
--- a/docs/template_context_doc.py
+++ b/docs/template_context_doc.py
@@ -1,11 +1,12 @@
 """
-Cog helpers for generating docs/template_context.rst from the manifest
-in datasette/template_contexts.py - same pattern as json_api_doc.py.
+Cog helpers for generating docs/template_context.rst from the Context
+dataclasses and TEMPLATE_BASE_CONTEXT - same pattern as json_api_doc.py.
 """
 
 
 def template_context(cog):
-    from datasette.template_contexts import BASE_CONTEXT_KEYS, PAGES
+    from datasette.app import TEMPLATE_BASE_CONTEXT
+    from datasette.template_contexts import PAGES
 
     cog.out("\n")
     _section(
@@ -19,36 +20,26 @@ def template_context(cog):
             ":ref:`plugin_hook_extra_template_vars` hook."
         ),
     )
-    _untyped_keys(cog, BASE_CONTEXT_KEYS)
+    for name, doc in TEMPLATE_BASE_CONTEXT.items():
+        cog.out("``{}``\n".format(name))
+        cog.out("    {}\n\n".format(doc))
 
-    for page in PAGES.values():
-        _section(
-            cog,
-            "{} page".format(page.title),
-            "{} Rendered using the ``{}`` template.".format(
-                page.description, page.template
-            ),
+    for klass in PAGES.values():
+        title = "{} page".format(klass.__name__.removesuffix("Context"))
+        intro = "{} Rendered using the ``{}`` template.".format(
+            klass.__doc__, klass.template
         )
-        if page.context_class is not None:
-            for f in sorted(
-                page.context_class.documented_fields(), key=lambda f: f.name
-            ):
-                cog.out("``{}`` - ``{}``\n".format(f.name, f.type_name))
-                cog.out("    {}\n\n".format(f.help))
-        else:
+        _section(cog, title, intro)
+        if klass.extras_scope is not None:
             cog.out(
                 "Many of these keys are shared with the :ref:`JSON API "
                 "<json_api>` for this page.\n\n"
             )
-            _untyped_keys(cog, page.documented_keys())
+        for f in sorted(klass.documented_fields(), key=lambda f: f.name):
+            cog.out("``{}`` - ``{}``\n".format(f.name, f.type_name))
+            cog.out("    {}\n\n".format(f.help))
 
 
 def _section(cog, title, intro):
     cog.out("{}\n{}\n\n".format(title, "-" * len(title)))
     cog.out("{}\n\n".format(intro))
-
-
-def _untyped_keys(cog, keys):
-    for key in keys:
-        cog.out("``{}``\n".format(key.name))
-        cog.out("    {}\n\n".format(key.doc))
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index 0c694b2e..b970cb8a 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -10,17 +10,11 @@ from dataclasses import dataclass, field
 
 import pytest
 
-from datasette.app import Datasette
+from datasette.app import Datasette, TEMPLATE_BASE_CONTEXT
 from datasette.extras import ExtraScope
 from datasette.fixtures import write_fixture_database
-from datasette.template_contexts import (
-    BASE_CONTEXT_KEYS,
-    PAGES,
-    documented_context_keys,
-)
+from datasette.template_contexts import PAGES, documented_context_keys
 from datasette.views import Context
-from datasette.views.database import DatabaseContext, QueryContext
-from datasette.views.table_extras import table_extra_registry
 
 
 def test_documented_fields():
@@ -36,14 +30,20 @@ def test_documented_fields():
     ]
 
 
-@pytest.mark.parametrize("klass", (DatabaseContext, QueryContext))
-def test_context_dataclass_fields_all_have_help(klass):
+@pytest.mark.parametrize("klass", PAGES.values(), ids=lambda klass: klass.__name__)
+def test_context_class_fields_all_have_help(klass):
     for context_field in klass.documented_fields():
-        assert context_field.help, "{}.{} is missing help metadata".format(
+        assert context_field.help, "{}.{} is missing documentation".format(
             klass.__name__, context_field.name
         )
 
 
+@pytest.mark.parametrize("klass", PAGES.values(), ids=lambda klass: klass.__name__)
+def test_context_class_has_docstring_and_template(klass):
+    assert klass.__doc__, "{} is missing a docstring".format(klass.__name__)
+    assert klass.template, "{} is missing a template".format(klass.__name__)
+
+
 def test_extra_field_documentation_comes_from_the_extra_class():
     from datasette.views import extra_field
     from datasette.views.table_extras import CountExtra
@@ -169,8 +169,8 @@ async def test_template_context_matches_documented_contract(
     undocumented = actual - documented
     no_longer_present = documented - actual
     assert not undocumented, (
-        "Undocumented keys in {} template context: {} - document them in "
-        "datasette/template_contexts.py".format(page_name, sorted(undocumented))
+        "Undocumented keys in {} template context: {} - add them to the "
+        "page's Context class".format(page_name, sorted(undocumented))
     )
     assert not no_longer_present, (
         "Documented keys missing from {} template context: {} - this would "
@@ -178,53 +178,21 @@ async def test_template_context_matches_documented_contract(
     )
 
 
-def test_table_context_fields_match_documented_contract():
-    from datasette.views.table import TableContext
-
-    assert {f.name for f in TableContext.documented_fields()} == {
-        key.name for key in PAGES["table"].documented_keys()
-    }
-
-
-def test_row_context_fields_match_documented_contract():
-    from datasette.views.row import RowContext
-
-    assert {f.name for f in RowContext.documented_fields()} == {
-        key.name for key in PAGES["row"].documented_keys()
-    }
-
-
 def test_base_context_keys_all_have_docs():
-    for key in BASE_CONTEXT_KEYS:
-        assert key.doc, "Base context key {} is missing docs".format(key.name)
-
-
-@pytest.mark.parametrize("page", PAGES.values(), ids=lambda page: page.name)
-def test_page_documented_keys_all_have_docs(page):
-    for key in page.documented_keys():
-        assert key.doc, "{} page key {} is missing docs".format(page.name, key.name)
+    for name, doc in TEMPLATE_BASE_CONTEXT.items():
+        assert doc, "Base context key {} is missing docs".format(name)
 
 
 def test_template_context_docs_cover_every_documented_key():
     docs_path = pathlib.Path(__file__).parent.parent / "docs" / "template_context.rst"
     assert docs_path.exists(), "docs/template_context.rst is missing"
     docs = docs_path.read_text()
-    for key in BASE_CONTEXT_KEYS:
-        assert "``{}``".format(key.name) in docs, key.name
-    for page in PAGES.values():
-        assert page.title in docs, page.title
-        for key in page.documented_keys():
-            assert "``{}``".format(key.name) in docs, "{} ({} page)".format(
-                key.name, page.name
+    for name in TEMPLATE_BASE_CONTEXT:
+        assert "``{}``".format(name) in docs, name
+    for page_name, klass in PAGES.items():
+        title = "{} page".format(klass.__name__.removesuffix("Context"))
+        assert title in docs, title
+        for context_field in klass.documented_fields():
+            assert "``{}``".format(context_field.name) in docs, "{} ({} page)".format(
+                context_field.name, page_name
             )
-
-
-@pytest.mark.parametrize("page", PAGES.values(), ids=lambda page: page.name)
-def test_page_extra_keys_are_registered_extras(page):
-    for name in page.extra_keys:
-        cls = table_extra_registry.classes_by_name.get(name)
-        assert cls is not None, "{} is not a registered extra".format(name)
-        assert page.extras_scope is not None
-        assert cls.available_for(
-            page.extras_scope
-        ), "{} extra is not available for scope {}".format(name, page.extras_scope)

From 993169ae496aa0fa30271b6cb4dfc50202f6e7c1 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 08:24:37 -0700
Subject: [PATCH 180/386] Release 1.0a33

Refs #2735, #2677, #2680, #2711, #2756, #2761, #2768, #2754
---
 datasette/version.py |  2 +-
 docs/changelog.rst   | 40 ++++++++++++++++++++++++++++++++++------
 2 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/datasette/version.py b/datasette/version.py
index 1e8c61d5..9536d459 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a32"
+__version__ = "1.0a33"
 __version_info__ = tuple(__version__.split("."))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 19089dd1..48bef0bf 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -9,15 +9,43 @@ Changelog
 1.0a33 (unreleased)
 -------------------
 
-- Stored queries can now be edited and deleted from the web interface. The stored query page gained a "Query actions" menu with **Edit this query** and **Delete this query** links for actors with the necessary permissions. The owner of a query can always edit or delete it; for queries that are not private, any actor with the :ref:`update-query <actions_update_query>` or :ref:`delete-query <actions_delete_query>` permission can do so too. Private queries remain editable and deletable only by their owner. See :ref:`stored_queries` for details. (:issue:`2735`)
-- Row and query JSON pages now support the same ``?_extra=`` mechanism as table pages. Row pages can request extras such as ``foreign_key_tables``, ``query``, ``metadata`` and ``database_color``; arbitrary SQL and stored query pages can request extras such as ``columns``, ``query``, ``metadata`` and ``private``. The implementation was refactored into a registry of extra classes shared by all three page types. See :ref:`json_api_extra` for the full list.
-- New generated reference documentation for every ``?_extra=`` parameter available on table, row and query JSON pages, with example output captured from a live Datasette instance at documentation build time. See :ref:`json_api_extra`.
-- ``?_extra=`` values can be separated by commas as well as repeated, e.g. ``?_extra=count,next_url``. Previously a comma-separated value that included ``columns`` failed to include the ``columns`` key in the response.
-- The ``?_extra=private`` extra on arbitrary SQL query pages now correctly reflects whether the SQL execution permission is private to the current actor - it previously always returned ``false``.
-- The ``?_extra=query`` extra on query pages now reports the named parameters that were actually bound when the query executed, including parameters declared in a stored query's ``params`` list. Magic ``_``-prefixed parameters are no longer echoed back with unbound values taken from the querystring.
+Stored queries can now be edited and deleted through the web interface, and the JSON API ``?_extra=`` mechanism has been extended to cover row and query pages in addition to tables. This release also fixes two security issues: an identifier-quoting bug involving table and column names that contain ``]``, and an open redirect.
+
+Editing and deleting stored queries
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The stored query page gained a "Query actions" menu with **Edit this query** and **Delete this query** links for actors with the necessary permissions. The owner of a query can always edit or delete it; for queries that are not private, any actor with the :ref:`update-query <actions_update_query>` or :ref:`delete-query <actions_delete_query>` permission can do so too. Private queries remain editable and deletable only by their owner. See :ref:`stored_queries` for details. (:issue:`2735`)
+
+``?_extra=`` support for row and query pages
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Row and query JSON pages now support the same ``?_extra=`` mechanism as table pages. Row pages can request extras such as ``foreign_key_tables``, ``query``, ``metadata`` and ``database_color``; arbitrary SQL and stored query pages can request extras such as ``columns``, ``query``, ``metadata`` and ``private``. The implementation was refactored into a registry of extra classes shared by all three page types.
+
+New generated reference documentation describes every ``?_extra=`` parameter available on table, row and query JSON pages, with example output captured from a live Datasette instance at documentation build time. See :ref:`json_api_extra` for the full list.
+
+You can explore the new extras using this `Datasette extras API explorer tool <https://tools.simonwillison.net/datasette-extras-explorer>`__.
+
+Other improvements and fixes to the extras mechanism:
+
 - Extras that exist to serve the HTML interface (``filters``, ``actions``, ``display_rows``) are no longer advertised or reachable through the JSON API, where requesting them previously returned a 500 serialization error.
 - The pre-1.0 ``?_extras=`` (plural) parameter on row pages has been removed - use ``?_extra=foreign_key_tables`` instead.
 
+Security fixes
+~~~~~~~~~~~~~~
+
+- Fixed an identifier-quoting bug in ``datasette.utils.escape_sqlite()``. Datasette uses this helper when constructing SQL around table and column names; identifiers containing ``]`` could break out of SQLite bracket quoting and alter the generated SQL, for example by adding a ``UNION SELECT``. Identifiers containing ``]`` are now quoted using double quotes instead. (:issue:`2677`)
+- Fixed an open redirect vulnerability. Requesting a path such as ``/\example.com/`` produced a redirect with a ``Location: /\example.com`` header - browsers normalize backslashes to forward slashes, turning that into the protocol-relative URL ``//example.com`` and redirecting the user off-site. Any run of leading slashes and backslashes in a redirect path is now collapsed to a single slash. (:issue:`2680`)
+
+Bug fixes
+~~~~~~~~~
+
+- ``can_render()`` callbacks registered by the :ref:`register_output_renderer() <plugin_register_output_renderer>` plugin hook now receive the result ``rows`` and ``columns`` for stored queries. Previously renderers that inspect the available columns - such as `datasette-atom <https://github.com/simonw/datasette-atom>`__ and `datasette-ics <https://github.com/simonw/datasette-ics>`__ - never appeared as export options on stored query pages. (:issue:`2711`)
+- Fixed a 500 error from the :ref:`/-/check <PermissionCheckView>` permission debugging endpoint when checking query actions such as ``view-query``, ``update-query`` and ``delete-query``. (:issue:`2756`)
+- Write queries that use a named parameter called ``:sql`` no longer fail with an error. (:issue:`2761`)
+- :ref:`db.execute_isolated_fn() <database_execute_isolated_fn>` now works against immutable databases, using a read-only connection that bypasses the write thread. It previously always attempted to open a writable connection, which would fail - breaking features built on top of it, such as the SQL analysis step used when storing a query. An exception raised while opening the connection for an isolated function no longer crashes the write thread. (:issue:`2768`)
+- Facet counts are now displayed on the same line as the facet value instead of wrapping onto a second line. (:issue:`2754`)
+- Datasette's pytest plugin no longer imports the rest of Datasette at pytest startup time. This means plugin test suites using ``pytest-cov`` now correctly record coverage of code that runs when ``datasette`` modules are first imported.
+
 .. _v1_0_a32:
 
 1.0a32 (2026-05-31)

From 1d4212122e5597f2e13625193fb7d45b25928447 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 10:36:16 -0700
Subject: [PATCH 181/386] Add release date for 1.0a33

---
 docs/changelog.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 48bef0bf..c0bd7e6b 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -6,7 +6,7 @@ Changelog
 
 .. _v1_0_a33:
 
-1.0a33 (unreleased)
+1.0a33 (2026-06-11)
 -------------------
 
 Stored queries can now be edited and deleted through the web interface, and the JSON API ``?_extra=`` mechanism has been extended to cover row and query pages in addition to tables. This release also fixes two security issues: an identifier-quoting bug involving table and column names that contain ``]``, and an open redirect.

From fa86ac7b11c44ef80146db6eed25d88c954ee37a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 11 Jun 2026 19:41:24 -0700
Subject: [PATCH 182/386] Clearer examples and descriptions for JSON API extras
 (#2773)

Review of the generated ?_extra= documentation found several extras
with no example output or with examples that needed explanation:

- extras: now shows an abbreviated example of the toggle list and has
  a clearer description (which also improves the live API output)
- set_column_type_ui: example of the shape seen with set-column-type
  permission, plus a note that it is null otherwise
- column_types: live example generated from a table with an assigned
  column type instead of an empty {}
- metadata: live table example now demonstrates a table description
  and column descriptions; row and query examples gained explanatory
  notes
- expandable_columns, foreign_key_tables, facets_timed_out, next_url,
  renderers: notes explaining the shape of their output

Also added docs_note cross-references to the relevant documentation:
facets, pagination, render_cell and register_output_renderer plugin
hooks, column type configuration and API, metadata, custom templates,
permissions and foreign key label expansion. foreign_key_tables is
now flagged as potentially executing additional queries.

https://claude.ai/code/session_01EfjBe6E817m9XNFW7EX3Vm

Co-authored-by: Claude <noreply@anthropic.com>
---
 datasette/views/table_extras.py | 182 +++++++++++++++++++++++++--
 docs/json_api.rst               | 215 ++++++++++++++++++++++++++------
 docs/json_api_doc.py            |  19 ++-
 3 files changed, 367 insertions(+), 49 deletions(-)

diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index ce1d7bdf..948f3daa 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -184,6 +184,7 @@ class FacetResultsExtra(Extra):
     )
     scopes = {ExtraScope.TABLE}
     expensive = True
+    docs_note = "See :ref:`facets` for details of how facets work."
 
     async def resolve(self, context, facet_instances):
         facet_results = {}
@@ -215,7 +216,12 @@ class FacetResultsExtra(Extra):
 class FacetsTimedOutExtra(Extra):
     description = "Facet calculations that timed out"
     example = ExtraExample(
-        "/fixtures/facetable.json?_facet=state&_extra=facets_timed_out"
+        "/fixtures/facetable.json?_facet=state&_extra=facets_timed_out",
+        note=(
+            "A list of the names of any facets that exceeded the "
+            ":ref:`setting_facet_time_limit_ms` time limit - an empty list "
+            "if every facet calculation completed."
+        ),
     )
     scopes = {ExtraScope.TABLE}
 
@@ -236,6 +242,9 @@ class SuggestedFacetsExtra(Extra):
     )
     scopes = {ExtraScope.TABLE}
     expensive = True
+    docs_note = (
+        "Suggestions are controlled by the :ref:`setting_suggest_facets` setting."
+    )
 
     async def resolve(self, context, facet_instances):
         suggested_facets = []
@@ -278,7 +287,13 @@ class HumanDescriptionEnExtra(Extra):
 
 class NextUrlExtra(Extra):
     description = "Full URL for the next page of results"
-    example = ExtraExample("/fixtures/facetable.json?_size=1&_extra=next_url")
+    example = ExtraExample(
+        "/fixtures/facetable.json?_size=1&_extra=next_url",
+        note=(
+            "``null`` if there are no more pages of results. "
+            "See :ref:`json_api_pagination`."
+        ),
+    )
     scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
@@ -366,6 +381,10 @@ class IsViewExtra(Extra):
 
 class DebugExtra(Extra):
     description = "Extra debug information"
+    docs_note = (
+        "The contents of this block are not a stable part of the Datasette "
+        "API and may change without warning."
+    )
     example = ExtraExample("/fixtures/facetable.json?_extra=debug")
     examples = {
         ExtraScope.ROW: ExtraExample(
@@ -482,6 +501,10 @@ class DisplayRowsExtra(Extra):
 
 class RenderCellExtra(Extra):
     description = "Rendered HTML for each cell using the render_cell plugin hook"
+    docs_note = (
+        "See the :ref:`render_cell() plugin hook <plugin_hook_render_cell>` "
+        "documentation."
+    )
     example = ExtraExample(
         value={
             "rows": [
@@ -598,7 +621,28 @@ class QueryExtra(Extra):
 
 class ColumnTypesExtra(Extra):
     description = "Column type assignments for this table"
-    example = ExtraExample(value={})
+    docs_note = (
+        "An empty object if no column types have been assigned. Column types "
+        "can be assigned in :ref:`configuration "
+        "<table_configuration_column_types>` or using the :ref:`set column "
+        "type API <TableSetColumnTypeView>`."
+    )
+    example = ExtraExample(
+        "/fixtures/facetable.json?_size=0&_extra=column_types",
+        note=(
+            "This example is from an instance where the ``tags`` column has "
+            "been assigned the ``json`` column type."
+        ),
+    )
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/facetable/1.json?_extra=column_types",
+            note=(
+                "This example is from an instance where the ``tags`` column "
+                "has been assigned the ``json`` column type."
+            ),
+        )
+    }
     scopes = {ExtraScope.TABLE, ExtraScope.ROW}
 
     async def resolve(self, context):
@@ -615,7 +659,40 @@ class ColumnTypesExtra(Extra):
 
 
 class SetColumnTypeUiExtra(Extra):
-    description = "Column type UI metadata for this table"
+    description = "Information needed to build an interface for assigning column types"
+    docs_note = (
+        "``null`` unless the current actor is allowed to use the :ref:`set "
+        "column type API <TableSetColumnTypeView>` for this table."
+    )
+    example = ExtraExample(
+        value={
+            "path": "/fixtures/facetable/-/set-column-type",
+            "columns": {
+                "created": {
+                    "current": None,
+                    "options": [
+                        {"name": "email", "description": "Email address"},
+                        {"name": "json", "description": "JSON data"},
+                        {"name": "url", "description": "URL"},
+                    ],
+                },
+                "tags": {
+                    "current": {"type": "json", "config": None},
+                    "options": [
+                        {"name": "email", "description": "Email address"},
+                        {"name": "json", "description": "JSON data"},
+                        {"name": "url", "description": "URL"},
+                    ],
+                },
+            },
+        },
+        note=(
+            "Shape abbreviated to two columns, as seen by an actor with "
+            "``set-column-type`` permission. ``current`` is the column type "
+            "currently assigned to each column and ``options`` lists the "
+            "types that could be assigned to it."
+        ),
+    )
     scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
@@ -667,13 +744,33 @@ class SetColumnTypeUiExtra(Extra):
 
 class MetadataExtra(Extra):
     description = "Metadata about the table, database or stored query"
-    example = ExtraExample("/fixtures/facetable.json?_extra=metadata")
+    docs_note = "See :ref:`metadata` for how to attach metadata to tables."
+    example = ExtraExample(
+        "/fixtures/facetable.json?_extra=metadata",
+        note=(
+            "This example is from an instance where the ``facetable`` table "
+            "has a metadata ``description`` and a :ref:`column description "
+            "<metadata_column_descriptions>` for its ``state`` column. The "
+            "``columns`` object is empty for tables with no column "
+            "descriptions."
+        ),
+    )
     examples = {
         ExtraScope.ROW: ExtraExample(
-            "/fixtures/simple_primary_key/1.json?_extra=metadata"
+            "/fixtures/simple_primary_key/1.json?_extra=metadata",
+            note=(
+                "This table has no metadata, so only an empty ``columns`` "
+                "object is returned."
+            ),
         ),
         ExtraScope.QUERY: ExtraExample(
-            "/fixtures/neighborhood_search.json?text=town&_extra=metadata"
+            "/fixtures/neighborhood_search.json?text=town&_extra=metadata",
+            note=(
+                "For stored queries this returns the full configuration of "
+                "the query, including the :ref:`stored query options "
+                "<queries_options>`. For ``?sql=`` queries it returns an "
+                "empty object."
+            ),
         ),
     }
     scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
@@ -733,6 +830,10 @@ class TableExtra(Extra):
 
 class DatabaseColorExtra(Extra):
     description = "Color assigned to the database"
+    docs_note = (
+        "A six character hex color, without the leading ``#``, derived from "
+        "a hash of the database name and used in the Datasette interface."
+    )
     example = ExtraExample("/fixtures/facetable.json?_extra=database_color")
     examples = {
         ExtraScope.ROW: ExtraExample(
@@ -780,6 +881,11 @@ class FiltersExtra(Extra):
 
 class CustomTableTemplatesExtra(Extra):
     description = "Custom template names considered for this table"
+    docs_note = (
+        "The first template in this list that exists will be used to render "
+        "the table on the HTML version of this page. See "
+        ":ref:`customization_custom_templates`."
+    )
     example = ExtraExample("/fixtures/facetable.json?_extra=custom_table_templates")
     scopes = {ExtraScope.TABLE}
 
@@ -793,6 +899,12 @@ class CustomTableTemplatesExtra(Extra):
 
 class SortedFacetResultsExtra(Extra):
     description = "Facet results sorted for display"
+    docs_note = (
+        "The same data as ``facet_results``, as a list in the order used by "
+        "the HTML interface: facets from :ref:`facet configuration "
+        "<facets_metadata>` first, then other facets ordered by their number "
+        "of results."
+    )
     example = ExtraExample(
         "/fixtures/facetable.json?_facet=state&_extra=sorted_facet_results"
     )
@@ -849,7 +961,15 @@ class ViewDefinitionExtra(Extra):
 
 class RenderersExtra(Extra):
     description = "Alternative output renderers available for this table"
-    example = ExtraExample("/fixtures/facetable.json?_extra=renderers")
+    example = ExtraExample(
+        "/fixtures/facetable.json?_extra=renderers",
+        note=(
+            "Each key is the name of an output format, each value the URL "
+            "for this data in that format. Plugins can add additional "
+            "formats using the :ref:`register_output_renderer() plugin hook "
+            "<plugin_register_output_renderer>`."
+        ),
+    )
     scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context, expandable_columns, query):
@@ -887,6 +1007,10 @@ class RenderersExtra(Extra):
 
 class PrivateExtra(Extra):
     description = "Whether this resource is private to the current actor"
+    docs_note = (
+        "``true`` if the current actor can see this resource but an "
+        "anonymous user could not. See :ref:`authentication_permissions`."
+    )
     example = ExtraExample("/fixtures/facetable.json?_extra=private")
     examples = {
         ExtraScope.ROW: ExtraExample(
@@ -904,7 +1028,15 @@ class PrivateExtra(Extra):
 
 class ExpandableColumnsExtra(Extra):
     description = "Foreign key columns that can be expanded with labels"
-    example = ExtraExample("/fixtures/facetable.json?_extra=expandable_columns")
+    docs_note = "See :ref:`expand_foreign_keys` for how to expand these labels."
+    example = ExtraExample(
+        "/fixtures/facetable.json?_extra=expandable_columns",
+        note=(
+            "Each item is a ``[foreign_key, label_column]`` pair: the "
+            "foreign key relationship, then the column in the other table "
+            "that would be used as the label for each expanded value."
+        ),
+    )
     scopes = {ExtraScope.TABLE}
 
     async def resolve(self, context):
@@ -919,9 +1051,14 @@ class ExpandableColumnsExtra(Extra):
 class ForeignKeyTablesExtra(Extra):
     description = "Tables that link to this row using foreign keys"
     example = ExtraExample(
-        "/fixtures/simple_primary_key/1.json?_extra=foreign_key_tables"
+        "/fixtures/simple_primary_key/1.json?_extra=foreign_key_tables",
+        note=(
+            "``count`` is the number of rows in the other table that "
+            "reference this row, and ``link`` is a URL to browse those rows."
+        ),
     )
     scopes = {ExtraScope.ROW}
+    expensive = True
 
     async def resolve(self, context):
         return await context.foreign_key_tables(
@@ -930,7 +1067,30 @@ class ForeignKeyTablesExtra(Extra):
 
 
 class ExtrasExtra(Extra):
-    description = "Available ?_extra= blocks"
+    description = "List of ?_extra= blocks that can be used on this page"
+    example = ExtraExample(
+        value=[
+            {
+                "name": "count",
+                "description": "Total count of rows matching these filters",
+                "toggle_url": "http://localhost/fixtures/facetable.json?_extra=extras&_extra=count",
+                "selected": False,
+            },
+            {
+                "name": "extras",
+                "description": "List of ?_extra= blocks that can be used on this page",
+                "toggle_url": "http://localhost/fixtures/facetable.json",
+                "selected": True,
+            },
+        ],
+        note=(
+            "Shape abbreviated from /fixtures/facetable.json?_extra=extras - "
+            "the full response lists every extra described on this page. "
+            "``toggle_url`` is the current URL with that extra added or "
+            "removed, and ``selected`` is ``true`` for extras included in "
+            "the current request."
+        ),
+    )
     scopes = {ExtraScope.TABLE, ExtraScope.ROW, ExtraScope.QUERY}
 
     async def resolve(self, context):
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 6b595577..fbc3cf60 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -276,7 +276,7 @@ The available table extras are listed below.
         "select count(*) from facetable "
 
 ``facet_results``
-    Results of facets calculated against this data (May execute additional queries.)
+    Results of facets calculated against this data (May execute additional queries. See :ref:`facets` for details of how facets work.)
 
     Shape abbreviated from /fixtures/facetable.json?_facet=state&_extra=facet_results.
 
@@ -309,12 +309,14 @@ The available table extras are listed below.
 
     ``GET /fixtures/facetable.json?_facet=state&_extra=facets_timed_out``
 
+    A list of the names of any facets that exceeded the :ref:`setting_facet_time_limit_ms` time limit - an empty list if every facet calculation completed.
+
     .. code-block:: json
 
         []
 
 ``suggested_facets``
-    Suggestions for facets that might return interesting results (May execute additional queries.)
+    Suggestions for facets that might return interesting results (May execute additional queries. Suggestions are controlled by the :ref:`setting_suggest_facets` setting.)
 
     Shape abbreviated from /fixtures/facetable.json?_extra=suggested_facets.
 
@@ -341,6 +343,8 @@ The available table extras are listed below.
 
     ``GET /fixtures/facetable.json?_size=1&_extra=next_url``
 
+    ``null`` if there are no more pages of results. See :ref:`json_api_pagination`.
+
     .. code-block:: json
 
         "http://localhost/fixtures/facetable.json?_size=1&_extra=next_url&_next=1"
@@ -426,7 +430,7 @@ The available table extras are listed below.
         ]
 
 ``render_cell``
-    Rendered HTML for each cell using the render_cell plugin hook
+    Rendered HTML for each cell using the render_cell plugin hook (See the :ref:`render_cell() plugin hook <plugin_hook_render_cell>` documentation.)
 
     The ``render_cell`` array has one item per row, in the same order as the ``rows`` array. Each object is keyed by column name. Only columns whose rendered value differs from the default are included.
 
@@ -452,7 +456,7 @@ The available table extras are listed below.
         }
 
 ``debug``
-    Extra debug information
+    Extra debug information (The contents of this block are not a stable part of the Datasette API and may change without warning.)
 
     ``GET /fixtures/facetable.json?_extra=debug``
 
@@ -501,28 +505,108 @@ The available table extras are listed below.
         }
 
 ``column_types``
-    Column type assignments for this table
+    Column type assignments for this table (An empty object if no column types have been assigned. Column types can be assigned in :ref:`configuration <table_configuration_column_types>` or using the :ref:`set column type API <TableSetColumnTypeView>`.)
 
-    .. code-block:: json
+    ``GET /fixtures/facetable.json?_size=0&_extra=column_types``
 
-        {}
-
-``set_column_type_ui``
-    Column type UI metadata for this table
-
-``metadata``
-    Metadata about the table, database or stored query
-
-    ``GET /fixtures/facetable.json?_extra=metadata``
+    This example is from an instance where the ``tags`` column has been assigned the ``json`` column type.
 
     .. code-block:: json
 
         {
-          "columns": {}
+          "tags": {
+            "type": "json",
+            "config": null
+          }
+        }
+
+``set_column_type_ui``
+    Information needed to build an interface for assigning column types (``null`` unless the current actor is allowed to use the :ref:`set column type API <TableSetColumnTypeView>` for this table.)
+
+    Shape abbreviated to two columns, as seen by an actor with ``set-column-type`` permission. ``current`` is the column type currently assigned to each column and ``options`` lists the types that could be assigned to it.
+
+    .. code-block:: json
+
+        {
+          "path": "/fixtures/facetable/-/set-column-type",
+          "columns": {
+            "created": {
+              "current": null,
+              "options": [
+                {
+                  "name": "email",
+                  "description": "Email address"
+                },
+                {
+                  "name": "json",
+                  "description": "JSON data"
+                },
+                {
+                  "name": "url",
+                  "description": "URL"
+                }
+              ]
+            },
+            "tags": {
+              "current": {
+                "type": "json",
+                "config": null
+              },
+              "options": [
+                {
+                  "name": "email",
+                  "description": "Email address"
+                },
+                {
+                  "name": "json",
+                  "description": "JSON data"
+                },
+                {
+                  "name": "url",
+                  "description": "URL"
+                }
+              ]
+            }
+          }
+        }
+
+``metadata``
+    Metadata about the table, database or stored query (See :ref:`metadata` for how to attach metadata to tables.)
+
+    ``GET /fixtures/facetable.json?_extra=metadata``
+
+    This example is from an instance where the ``facetable`` table has a metadata ``description`` and a :ref:`column description <metadata_column_descriptions>` for its ``state`` column. The ``columns`` object is empty for tables with no column descriptions.
+
+    .. code-block:: json
+
+        {
+          "description": "A demo table of places, used to demonstrate facets",
+          "columns": {
+            "state": "Two letter US state code"
+          }
         }
 
 ``extras``
-    Available ?_extra= blocks
+    List of ?_extra= blocks that can be used on this page
+
+    Shape abbreviated from /fixtures/facetable.json?_extra=extras - the full response lists every extra described on this page. ``toggle_url`` is the current URL with that extra added or removed, and ``selected`` is ``true`` for extras included in the current request.
+
+    .. code-block:: json
+
+        [
+          {
+            "name": "count",
+            "description": "Total count of rows matching these filters",
+            "toggle_url": "http://localhost/fixtures/facetable.json?_extra=extras&_extra=count",
+            "selected": false
+          },
+          {
+            "name": "extras",
+            "description": "List of ?_extra= blocks that can be used on this page",
+            "toggle_url": "http://localhost/fixtures/facetable.json",
+            "selected": true
+          }
+        ]
 
 ``database``
     Database name
@@ -543,7 +627,7 @@ The available table extras are listed below.
         "facetable"
 
 ``database_color``
-    Color assigned to the database
+    Color assigned to the database (A six character hex color, without the leading ``#``, derived from a hash of the database name and used in the Datasette interface.)
 
     ``GET /fixtures/facetable.json?_extra=database_color``
 
@@ -556,6 +640,8 @@ The available table extras are listed below.
 
     ``GET /fixtures/facetable.json?_extra=renderers``
 
+    Each key is the name of an output format, each value the URL for this data in that format. Plugins can add additional formats using the :ref:`register_output_renderer() plugin hook <plugin_register_output_renderer>`.
+
     .. code-block:: json
 
         {
@@ -563,7 +649,7 @@ The available table extras are listed below.
         }
 
 ``custom_table_templates``
-    Custom template names considered for this table
+    Custom template names considered for this table (The first template in this list that exists will be used to render the table on the HTML version of this page. See :ref:`customization_custom_templates`.)
 
     ``GET /fixtures/facetable.json?_extra=custom_table_templates``
 
@@ -576,7 +662,7 @@ The available table extras are listed below.
         ]
 
 ``sorted_facet_results``
-    Facet results sorted for display
+    Facet results sorted for display (The same data as ``facet_results``, as a list in the order used by the HTML interface: facets from :ref:`facet configuration <facets_metadata>` first, then other facets ordered by their number of results.)
 
     ``GET /fixtures/facetable.json?_facet=state&_extra=sorted_facet_results``
 
@@ -643,7 +729,7 @@ The available table extras are listed below.
         true
 
 ``private``
-    Whether this resource is private to the current actor
+    Whether this resource is private to the current actor (``true`` if the current actor can see this resource but an anonymous user could not. See :ref:`authentication_permissions`.)
 
     ``GET /fixtures/facetable.json?_extra=private``
 
@@ -652,10 +738,12 @@ The available table extras are listed below.
         false
 
 ``expandable_columns``
-    Foreign key columns that can be expanded with labels
+    Foreign key columns that can be expanded with labels (See :ref:`expand_foreign_keys` for how to expand these labels.)
 
     ``GET /fixtures/facetable.json?_extra=expandable_columns``
 
+    Each item is a ``[foreign_key, label_column]`` pair: the foreign key relationship, then the column in the other table that would be used as the label for each expanded value.
+
     .. code-block:: json
 
         [
@@ -720,7 +808,7 @@ The following extras are available for row JSON responses.
         ]
 
 ``render_cell``
-    Rendered HTML for each cell using the render_cell plugin hook
+    Rendered HTML for each cell using the render_cell plugin hook (See the :ref:`render_cell() plugin hook <plugin_hook_render_cell>` documentation.)
 
     The ``render_cell`` array has one item for the requested row. The object is keyed by column name. Only columns whose rendered value differs from the default are included.
 
@@ -741,7 +829,7 @@ The following extras are available for row JSON responses.
         }
 
 ``debug``
-    Extra debug information
+    Extra debug information (The contents of this block are not a stable part of the Datasette API and may change without warning.)
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=debug``
 
@@ -803,17 +891,28 @@ The following extras are available for row JSON responses.
         }
 
 ``column_types``
-    Column type assignments for this table
+    Column type assignments for this table (An empty object if no column types have been assigned. Column types can be assigned in :ref:`configuration <table_configuration_column_types>` or using the :ref:`set column type API <TableSetColumnTypeView>`.)
+
+    ``GET /fixtures/facetable/1.json?_extra=column_types``
+
+    This example is from an instance where the ``tags`` column has been assigned the ``json`` column type.
 
     .. code-block:: json
 
-        {}
+        {
+          "tags": {
+            "type": "json",
+            "config": null
+          }
+        }
 
 ``metadata``
-    Metadata about the table, database or stored query
+    Metadata about the table, database or stored query (See :ref:`metadata` for how to attach metadata to tables.)
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=metadata``
 
+    This table has no metadata, so only an empty ``columns`` object is returned.
+
     .. code-block:: json
 
         {
@@ -821,7 +920,26 @@ The following extras are available for row JSON responses.
         }
 
 ``extras``
-    Available ?_extra= blocks
+    List of ?_extra= blocks that can be used on this page
+
+    Shape abbreviated from /fixtures/facetable.json?_extra=extras - the full response lists every extra described on this page. ``toggle_url`` is the current URL with that extra added or removed, and ``selected`` is ``true`` for extras included in the current request.
+
+    .. code-block:: json
+
+        [
+          {
+            "name": "count",
+            "description": "Total count of rows matching these filters",
+            "toggle_url": "http://localhost/fixtures/facetable.json?_extra=extras&_extra=count",
+            "selected": false
+          },
+          {
+            "name": "extras",
+            "description": "List of ?_extra= blocks that can be used on this page",
+            "toggle_url": "http://localhost/fixtures/facetable.json",
+            "selected": true
+          }
+        ]
 
 ``database``
     Database name
@@ -842,7 +960,7 @@ The following extras are available for row JSON responses.
         "simple_primary_key"
 
 ``database_color``
-    Color assigned to the database
+    Color assigned to the database (A six character hex color, without the leading ``#``, derived from a hash of the database name and used in the Datasette interface.)
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=database_color``
 
@@ -851,7 +969,7 @@ The following extras are available for row JSON responses.
         "9403e5"
 
 ``private``
-    Whether this resource is private to the current actor
+    Whether this resource is private to the current actor (``true`` if the current actor can see this resource but an anonymous user could not. See :ref:`authentication_permissions`.)
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=private``
 
@@ -860,10 +978,12 @@ The following extras are available for row JSON responses.
         false
 
 ``foreign_key_tables``
-    Tables that link to this row using foreign keys
+    Tables that link to this row using foreign keys (May execute additional queries.)
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=foreign_key_tables``
 
+    ``count`` is the number of rows in the other table that reference this row, and ``link`` is a URL to browse those rows.
+
     .. code-block:: json
 
         [
@@ -921,7 +1041,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         ]
 
 ``render_cell``
-    Rendered HTML for each cell using the render_cell plugin hook
+    Rendered HTML for each cell using the render_cell plugin hook (See the :ref:`render_cell() plugin hook <plugin_hook_render_cell>` documentation.)
 
     The ``render_cell`` array has one item per query result row, in the same order as the ``rows`` array. Each object is keyed by column name. Only columns whose rendered value differs from the default are included.
 
@@ -941,7 +1061,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         }
 
 ``debug``
-    Extra debug information
+    Extra debug information (The contents of this block are not a stable part of the Datasette API and may change without warning.)
 
     ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=debug``
 
@@ -1000,10 +1120,12 @@ The following extras are available for arbitrary SQL query responses and stored,
         }
 
 ``metadata``
-    Metadata about the table, database or stored query
+    Metadata about the table, database or stored query (See :ref:`metadata` for how to attach metadata to tables.)
 
     ``GET /fixtures/neighborhood_search.json?text=town&_extra=metadata``
 
+    For stored queries this returns the full configuration of the query, including the :ref:`stored query options <queries_options>`. For ``?sql=`` queries it returns an empty object.
+
     .. code-block:: json
 
         {
@@ -1029,7 +1151,26 @@ The following extras are available for arbitrary SQL query responses and stored,
         }
 
 ``extras``
-    Available ?_extra= blocks
+    List of ?_extra= blocks that can be used on this page
+
+    Shape abbreviated from /fixtures/facetable.json?_extra=extras - the full response lists every extra described on this page. ``toggle_url`` is the current URL with that extra added or removed, and ``selected`` is ``true`` for extras included in the current request.
+
+    .. code-block:: json
+
+        [
+          {
+            "name": "count",
+            "description": "Total count of rows matching these filters",
+            "toggle_url": "http://localhost/fixtures/facetable.json?_extra=extras&_extra=count",
+            "selected": false
+          },
+          {
+            "name": "extras",
+            "description": "List of ?_extra= blocks that can be used on this page",
+            "toggle_url": "http://localhost/fixtures/facetable.json",
+            "selected": true
+          }
+        ]
 
 ``database``
     Database name
@@ -1041,7 +1182,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         "fixtures"
 
 ``database_color``
-    Color assigned to the database
+    Color assigned to the database (A six character hex color, without the leading ``#``, derived from a hash of the database name and used in the Datasette interface.)
 
     ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=database_color``
 
@@ -1050,7 +1191,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         "9403e5"
 
 ``private``
-    Whether this resource is private to the current actor
+    Whether this resource is private to the current actor (``true`` if the current actor can see this resource but an anonymous user could not. See :ref:`authentication_permissions`.)
 
     ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=private``
 
diff --git a/docs/json_api_doc.py b/docs/json_api_doc.py
index 44ef4a42..422e67f4 100644
--- a/docs/json_api_doc.py
+++ b/docs/json_api_doc.py
@@ -93,9 +93,26 @@ async def _fetch_live_examples(scoped_classes):
         datasette = Datasette(
             [str(db_path)],
             settings={"num_sql_threads": 1},
+            metadata={
+                "databases": {
+                    "fixtures": {
+                        "tables": {
+                            "facetable": {
+                                "description": "A demo table of places, used to demonstrate facets",
+                                "columns": {"state": "Two letter US state code"},
+                            }
+                        }
+                    }
+                }
+            },
             config={
                 "databases": {
                     "fixtures": {
+                        "tables": {
+                            "facetable": {
+                                "column_types": {"tags": "json"},
+                            }
+                        },
                         "queries": {
                             "neighborhood_search": {
                                 "sql": textwrap.dedent("""
@@ -108,7 +125,7 @@ async def _fetch_live_examples(scoped_classes):
                                 """),
                                 "title": "Search neighborhoods",
                             }
-                        }
+                        },
                     }
                 }
             },

From 88878b418473dcb399de376658d2bd7423b66c97 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 12 Jun 2026 12:51:40 -0700
Subject: [PATCH 183/386] datasette.allowed_many() method

---
 datasette/app.py               | 101 +++++++---
 datasette/utils/actions_sql.py | 221 ++++++++++++++-------
 docs/internals.rst             |  33 ++++
 docs/plugin_hooks.rst          |   6 +
 tests/conftest.py              |  11 +-
 tests/test_allowed_many.py     | 341 +++++++++++++++++++++++++++++++++
 6 files changed, 613 insertions(+), 100 deletions(-)
 create mode 100644 tests/test_allowed_many.py

diff --git a/datasette/app.py b/datasette/app.py
index 81d23acb..a6696ad9 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2,7 +2,7 @@ from __future__ import annotations
 
 import asyncio
 import contextvars
-from typing import TYPE_CHECKING, Any, Dict, Iterable, List
+from typing import TYPE_CHECKING, Any, Dict, Iterable, List, Sequence
 
 if TYPE_CHECKING:
     from datasette.permissions import Resource
@@ -1817,46 +1817,97 @@ class Datasette:
             # For global actions, resource can be omitted:
             can_debug = await datasette.allowed(action="permissions-debug", actor=actor)
         """
-        from datasette.utils.actions_sql import check_permission_for_resource
+        results = await self.allowed_many(
+            actions=[action], resource=resource, actor=actor
+        )
+        return results[action]
 
-        # For global actions, resource remains None
+    async def allowed_many(
+        self,
+        *,
+        actions: Sequence[str],
+        resource: "Resource" = None,
+        actor: dict | None = None,
+    ) -> dict[str, bool]:
+        """
+        Check several actions against one resource for one actor.
 
-        # Check if this action has also_requires - if so, check that action first
-        action_obj = self.actions.get(action)
-        if action_obj and action_obj.also_requires:
-            # Must have the required action first
-            if not await self.allowed(
-                action=action_obj.also_requires,
-                resource=resource,
+        Resolves every action (plus any also_requires dependencies) with a
+        single internal database query, instead of one or two queries per
+        action.
+
+        Example:
+            from datasette.resources import TableResource
+            results = await datasette.allowed_many(
+                actions=["edit-schema", "drop-table", "insert-row"],
+                resource=TableResource(database="data", table="exercise"),
                 actor=actor,
-            ):
-                return False
+            )
+            # {"edit-schema": True, "drop-table": True, "insert-row": False}
+        """
+        from datasette.utils.actions_sql import check_permissions_for_actions
 
         # For global actions, resource is None
         parent = resource.parent if resource else None
         child = resource.child if resource else None
 
-        result = await check_permission_for_resource(
+        # Expand also_requires dependencies (transitively) so that each
+        # dependency is resolved within the same batch
+        expanded = []
+
+        def add_action(name):
+            if name in expanded:
+                return
+            action_obj = self.actions.get(name)
+            if action_obj is None:
+                raise ValueError(f"Unknown action: {name}")
+            expanded.append(name)
+            if action_obj.also_requires:
+                add_action(action_obj.also_requires)
+
+        requested = list(dict.fromkeys(actions))
+        for name in requested:
+            add_action(name)
+
+        raw = await check_permissions_for_actions(
             datasette=self,
             actor=actor,
-            action=action,
+            actions=expanded,
             parent=parent,
             child=child,
         )
+        final = {}
 
-        # Log the permission check for debugging
-        self._permission_checks.append(
-            PermissionCheck(
-                when=datetime.datetime.now(datetime.timezone.utc).isoformat(),
-                actor=actor,
-                action=action,
-                parent=parent,
-                child=child,
-                result=result,
+        def resolve(name):
+            # final verdict = own rules AND verdict of also_requires chain
+            if name in final:
+                return final[name]
+            result = raw[name]
+            action_obj = self.actions.get(name)
+            if result and action_obj.also_requires:
+                result = resolve(action_obj.also_requires)
+            final[name] = result
+            return result
+
+        for name in expanded:
+            resolve(name)
+
+        # Log every check for the debug page, dependencies before the
+        # actions that required them
+        when = datetime.datetime.now(datetime.timezone.utc).isoformat()
+        for name in reversed(expanded):
+            self._permission_checks.append(
+                PermissionCheck(
+                    when=when,
+                    actor=actor,
+                    action=name,
+                    parent=parent,
+                    child=child,
+                    result=final[name],
+                )
             )
-        )
 
-        return result
+        return {name: final[name] for name in requested}
 
     async def ensure_permission(
         self,
diff --git a/datasette/utils/actions_sql.py b/datasette/utils/actions_sql.py
index 891ee913..a422c1ed 100644
--- a/datasette/utils/actions_sql.py
+++ b/datasette/utils/actions_sql.py
@@ -21,6 +21,8 @@ The core pattern is:
 - Across levels, child beats parent beats global
 """
 
+import asyncio
+import re
 from typing import TYPE_CHECKING
 
 from datasette.utils.permissions import gather_permission_sql_from_hooks
@@ -495,6 +497,146 @@ async def build_permission_rules_sql(
     return rules_union, all_params, restriction_sqls
 
 
+async def check_permissions_for_actions(
+    *,
+    datasette: "Datasette",
+    actor: dict | None,
+    actions: list[str],
+    parent: str | None,
+    child: str | None,
+) -> dict[str, bool]:
+    """
+    Check several actions for one actor and resource in a single query.
+
+    Args:
+        datasette: The Datasette instance
+        actor: The actor dict (or None)
+        actions: List of action names to check
+        parent: The parent resource identifier (e.g., database name, or None)
+        child: The child resource identifier (e.g., table name, or None)
+
+    Returns:
+        Dict mapping each action name to True (allowed) or False (denied)
+
+    Each action contributes its own tagged block of permission rules
+    (gathered from the permission_resources_sql hook, with parameters
+    namespaced per action to avoid collisions) plus an optional
+    restriction allowlist CTE. One internal database query resolves
+    the winning rule per action using the same specificity-then-deny
+    ordering as the rest of the permission system.
+
+    Note: this resolves each action independently - also_requires
+    dependencies are handled by the caller (Datasette.allowed_many).
+    """
+    from datasette.utils.permissions import SKIP_PERMISSION_CHECKS
+
+    for action in actions:
+        if not datasette.actions.get(action):
+            raise ValueError(f"Unknown action: {action}")
+
+    # Dedupe while preserving order
+    unique_actions = list(dict.fromkeys(actions))
+    if not unique_actions:
+        return {}
+
+    # Gather hook results for each action concurrently - hooks within a
+    # single action still run sequentially, preserving existing semantics
+    gathered = await asyncio.gather(
+        *(
+            gather_permission_sql_from_hooks(
+                datasette=datasette, actor=actor, action=action
+            )
+            for action in unique_actions
+        )
+    )
+
+    if any(result is SKIP_PERMISSION_CHECKS for result in gathered):
+        return {action: True for action in unique_actions}
+
+    params = {"_check_parent": parent, "_check_child": child}
+    ctes = []
+    selects = []
+    verdicts = {}
+
+    for i, (action, permission_sqls) in enumerate(zip(unique_actions, gathered)):
+        prefix = f"a{i}_"
+        rule_parts = []
+        restriction_parts = []
+
+        for permission_sql in permission_sqls:
+            sql = permission_sql.sql
+            restriction_sql = permission_sql.restriction_sql
+            # Namespace this block's params so identical names used for
+            # different actions cannot collide
+            for key in permission_sql.params or {}:
+                new_key = prefix + key
+                params[new_key] = permission_sql.params[key]
+                pattern = re.compile(":" + re.escape(key) + r"(?![A-Za-z0-9_])")
+                if sql:
+                    sql = pattern.sub(":" + new_key, sql)
+                if restriction_sql:
+                    restriction_sql = pattern.sub(":" + new_key, restriction_sql)
+
+            if restriction_sql:
+                restriction_parts.append(restriction_sql)
+
+            # Skip plugins that only provide restriction_sql (no permission rules)
+            if sql is None:
+                continue
+            rule_parts.append(
+                f"SELECT parent, child, allow, reason, '{permission_sql.source}' AS source_plugin FROM (\n{sql}\n)"
+            )
+
+        if not rule_parts:
+            # No rules from any plugin - default deny. Restrictions can
+            # only restrict, never grant, so no SQL is needed at all
+            verdicts[action] = False
+            continue
+        ctes.append(f"a{i}_rules AS (\n" + "\nUNION ALL\n".join(rule_parts) + "\n)")
+
+        # Winning rule for this action: most specific depth first, then
+        # deny-beats-allow, then source_plugin as a stable tie-break
+        verdict_sql = f"""COALESCE((
+  SELECT allow FROM (
+    SELECT allow, source_plugin,
+      CASE
+        WHEN child IS NOT NULL THEN 2
+        WHEN parent IS NOT NULL THEN 1
+        ELSE 0
+      END AS depth
+    FROM a{i}_rules
+    WHERE (parent IS NULL OR parent = :_check_parent)
+      AND (child IS NULL OR child = :_check_child)
+    ORDER BY
+      depth DESC,
+      CASE WHEN allow = 0 THEN 0 ELSE 1 END,
+      source_plugin
+    LIMIT 1
+  )
+), 0)"""
+
+        if restriction_parts:
+            # Database-level restrictions (parent, NULL) match all children
+            restriction_intersect = "\nINTERSECT\n".join(
+                f"SELECT * FROM ({sql})" for sql in restriction_parts
+            )
+            ctes.append(f"a{i}_restriction AS (\n{restriction_intersect}\n)")
+            verdict_sql = f"""({verdict_sql}) AND EXISTS (
+  SELECT 1 FROM a{i}_restriction r
+  WHERE (r.parent = :_check_parent OR r.parent IS NULL)
+    AND (r.child = :_check_child OR r.child IS NULL)
+)"""
+
+        selects.append(f"SELECT {i} AS action_idx, ({verdict_sql}) AS is_allowed")
+
+    if selects:
+        query = "WITH\n" + ",\n".join(ctes) + "\n" + "\nUNION ALL\n".join(selects)
+        result = await datasette.get_internal_database().execute(query, params)
+        for row in result.rows:
+            verdicts[unique_actions[row[0]]] = bool(row[1])
+    return verdicts
+
+
 async def check_permission_for_resource(
     *,
     datasette: "Datasette",
@@ -515,77 +657,12 @@ async def check_permission_for_resource(
 
     Returns:
         True if the actor is allowed, False otherwise
-
-    This builds the cascading permission query and checks if the specific
-    resource is in the allowed set.
     """
-    rules_union, all_params, restriction_sqls = await build_permission_rules_sql(
-        datasette, actor, action
+    results = await check_permissions_for_actions(
+        datasette=datasette,
+        actor=actor,
+        actions=[action],
+        parent=parent,
+        child=child,
     )
-
-    # If no rules (empty SQL), default deny
-    if not rules_union:
-        return False
-
-    # Add parameters for the resource we're checking
-    all_params["_check_parent"] = parent
-    all_params["_check_child"] = child
-
-    # If there are restriction filters, check if the resource passes them first
-    if restriction_sqls:
-        # Check if resource is in restriction allowlist
-        # Database-level restrictions (parent, NULL) should match all children (parent, *)
-        # Wrap each restriction_sql in a subquery to avoid operator precedence issues
-        restriction_check = "\nINTERSECT\n".join(
-            f"SELECT * FROM ({sql})" for sql in restriction_sqls
-        )
-        restriction_query = f"""
-WITH restriction_list AS (
-    {restriction_check}
-)
-SELECT EXISTS (
-    SELECT 1 FROM restriction_list
-    WHERE (parent = :_check_parent OR parent IS NULL)
-      AND (child = :_check_child OR child IS NULL)
-) AS in_allowlist
-"""
-        result = await datasette.get_internal_database().execute(
-            restriction_query, all_params
-        )
-        if result.rows and not result.rows[0][0]:
-            # Resource not in restriction allowlist - deny
-            return False
-
-    query = f"""
-WITH
-all_rules AS (
-  {rules_union}
-),
-matched_rules AS (
-  SELECT ar.*,
-    CASE
-      WHEN ar.child IS NOT NULL THEN 2  -- child-level (most specific)
-      WHEN ar.parent IS NOT NULL THEN 1  -- parent-level
-      ELSE 0                             -- root/global
-    END AS depth
-  FROM all_rules ar
-  WHERE (ar.parent IS NULL OR ar.parent = :_check_parent)
-    AND (ar.child IS NULL OR ar.child = :_check_child)
-),
-winner AS (
-  SELECT *
-  FROM matched_rules
-  ORDER BY
-    depth DESC,                          -- specificity first (higher depth wins)
-    CASE WHEN allow=0 THEN 0 ELSE 1 END, -- then deny over allow
-    source_plugin                        -- stable tie-break
-  LIMIT 1
-)
-SELECT COALESCE((SELECT allow FROM winner), 0) AS is_allowed
-"""
-
-    # Execute the query against the internal database
-    result = await datasette.get_internal_database().execute(query, all_params)
-    if result.rows:
-        return bool(result.rows[0][0])
-    return False
+    return results[action]
diff --git a/docs/internals.rst b/docs/internals.rst
index f269155a..f3c1152a 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -512,6 +512,39 @@ Example usage:
 
 The method returns ``True`` if the permission is granted, ``False`` if denied.
 
+.. _datasette_allowed_many:
+
+await .allowed_many(\*, actions, resource, actor=None)
+------------------------------------------------------
+
+``actions`` - list of strings
+    The names of the actions to permission check.
+
+``resource`` - Resource object
+    A Resource object representing the database, table, or other resource that each action is checked against. Omit for global actions.
+
+``actor`` - dictionary, optional
+    The authenticated actor. This is usually ``request.actor``. Defaults to ``None`` for unauthenticated requests.
+
+Checks several actions against the same resource for the same actor, returning a dictionary mapping each action name to ``True`` or ``False``. The whole batch - including any actions pulled in through ``also_requires`` dependencies - is resolved with a single SQL query against the internal database, so this is much faster than calling :ref:`datasette.allowed() <datasette_allowed>` once per action.
+
+Example usage:
+
+.. code-block:: python
+
+    from datasette.resources import TableResource
+
+    results = await datasette.allowed_many(
+        actions=["insert-row", "delete-row", "drop-table"],
+        resource=TableResource(
+            database="fixtures", table="facetable"
+        ),
+        actor=request.actor,
+    )
+    # {"insert-row": True, "delete-row": True, "drop-table": False}
+
+Actions for which no plugin provides any permission rules are resolved to ``False`` directly, without being included in the SQL query at all.
+
 .. _datasette_allowed_resources:
 
 await .allowed_resources(action, actor=None, \*, parent=None, include_is_private=False, include_reasons=False, limit=100, next=None)
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 2a0ddc93..0a55f8ec 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1458,6 +1458,12 @@ to avoid conflicts with other plugins. The recommended convention is to prefix p
 plugin's source name (e.g., ``myplugin_user_id``). The system reserves these parameter names:
 ``:actor``, ``:actor_id``, ``:action``, and ``:filter_parent``.
 
+This hook may be called for many actions in rapid succession - for example
+:ref:`datasette.allowed_many() <datasette_allowed_many>` gathers rules for every action in its batch
+concurrently. Hook implementations must not assume that checks for different actions arrive one
+page-render apart, and expensive work (such as network calls) should be cached independently of the
+``action`` argument where possible.
+
 You can also use return ``PermissionSQL.allow(reason="reason goes here")`` or ``PermissionSQL.deny(reason="reason goes here")`` as shortcuts for simple root-level allow or deny rules. These will create SQL snippets that look like this:
 
 .. code-block:: sql
diff --git a/tests/conftest.py b/tests/conftest.py
index b9b3c35e..27d6fa77 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -146,6 +146,7 @@ def restore_working_directory(tmpdir, request):
 @pytest.fixture(scope="session", autouse=True)
 def check_actions_are_documented():
     from datasette.plugins import pm
+    from datasette.default_actions import register_actions as default_register_actions
 
     content = (
         pathlib.Path(__file__).parent.parent / "docs" / "authentication.rst"
@@ -154,6 +155,9 @@ def check_actions_are_documented():
     documented_actions = set(permissions_re.findall(content)).union(
         UNDOCUMENTED_PERMISSIONS
     )
+    # Only Datasette core actions need to be documented - actions registered
+    # by (test) plugins are checked for registration but not documentation
+    core_actions = {action.name for action in default_register_actions()}
 
     def before(hook_name, hook_impls, kwargs):
         if hook_name == "permission_resources_sql":
@@ -165,9 +169,10 @@ def check_actions_are_documented():
                 + " (or maybe a test forgot to do await ds.invoke_startup())"
             )
             action = kwargs.get("action").replace("-", "_")
-            assert (
-                action in documented_actions
-            ), "Undocumented permission action: {}".format(action)
+            if kwargs["action"] in core_actions:
+                assert (
+                    action in documented_actions
+                ), "Undocumented permission action: {}".format(action)
 
     pm.add_hookcall_monitoring(
         before=before, after=lambda outcome, hook_name, hook_impls, kwargs: None
diff --git a/tests/test_allowed_many.py b/tests/test_allowed_many.py
new file mode 100644
index 00000000..53d0ffd9
--- /dev/null
+++ b/tests/test_allowed_many.py
@@ -0,0 +1,341 @@
+"""
+Tests for the datasette.allowed_many() batch permission API, which
+resolves multiple actions against one resource in a single internal
+database query. datasette.allowed() is implemented on top of it, so
+both entry points share one resolution code path.
+"""
+
+import pytest
+import pytest_asyncio
+from datasette.app import Datasette
+from datasette.permissions import PermissionSQL, SkipPermissions
+from datasette.resources import DatabaseResource, TableResource
+from datasette import hookimpl
+
+
+@pytest_asyncio.fixture
+async def ds():
+    ds = Datasette()
+    await ds.invoke_startup()
+    db = ds.add_memory_database("analytics")
+    await db.execute_write("CREATE TABLE IF NOT EXISTS users (id INTEGER PRIMARY KEY)")
+    await db.execute_write("CREATE TABLE IF NOT EXISTS events (id INTEGER PRIMARY KEY)")
+    await ds._refresh_schemas()
+    return ds
+
+
+class MatrixRulesPlugin:
+    """Different rules per action for actor carol, to exercise resolution."""
+
+    @hookimpl
+    def permission_resources_sql(self, datasette, actor, action):
+        if not actor or actor.get("id") != "carol":
+            return None
+        if action == "view-table":
+            return PermissionSQL(sql="""
+                SELECT NULL AS parent, NULL AS child, 1 AS allow, 'global allow' AS reason
+                UNION ALL
+                SELECT 'analytics' AS parent, 'sensitive' AS child, 0 AS allow, 'deny sensitive' AS reason
+                """)
+        if action == "insert-row":
+            return PermissionSQL(
+                sql="SELECT 'analytics' AS parent, NULL AS child, 1 AS allow, 'analytics writes' AS reason"
+            )
+        # Everything else: no opinion (implicit deny unless defaults allow)
+        return None
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_basic(ds):
+    plugin = MatrixRulesPlugin()
+    ds.pm.register(plugin, name="matrix")
+    try:
+        results = await ds.allowed_many(
+            actions=["view-table", "insert-row", "drop-table"],
+            resource=TableResource("analytics", "users"),
+            actor={"id": "carol"},
+        )
+        assert results == {
+            "view-table": True,
+            "insert-row": True,
+            "drop-table": False,
+        }
+        # Child-level deny beats global allow
+        sensitive = await ds.allowed_many(
+            actions=["view-table"],
+            resource=TableResource("analytics", "sensitive"),
+            actor={"id": "carol"},
+        )
+        assert sensitive == {"view-table": False}
+    finally:
+        ds.pm.unregister(name="matrix")
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_matches_allowed(ds):
+    """Every action resolved by allowed_many() must match allowed()."""
+    plugin = MatrixRulesPlugin()
+    ds.pm.register(plugin, name="matrix")
+    try:
+        all_actions = list(ds.actions)
+        for resource in (
+            TableResource("analytics", "users"),
+            TableResource("analytics", "sensitive"),
+            DatabaseResource("analytics"),
+        ):
+            batched = await ds.allowed_many(
+                actions=all_actions, resource=resource, actor={"id": "carol"}
+            )
+            assert set(batched) == set(all_actions)
+            for action in all_actions:
+                individual = await ds.allowed(
+                    action=action, resource=resource, actor={"id": "carol"}
+                )
+                assert (
+                    batched[action] == individual
+                ), f"Mismatch for {action} on {resource}"
+    finally:
+        ds.pm.unregister(name="matrix")
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_unknown_action_raises(ds):
+    with pytest.raises(ValueError, match="Unknown action"):
+        await ds.allowed_many(
+            actions=["view-table", "no-such-action"],
+            resource=TableResource("analytics", "users"),
+            actor=None,
+        )
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_empty_actions(ds):
+    assert (
+        await ds.allowed_many(
+            actions=[], resource=TableResource("analytics", "users"), actor=None
+        )
+        == {}
+    )
+
+
+class AlsoRequiresRulesPlugin:
+    """dave: store-query allowed but execute-sql explicitly denied.
+    erin: store-query allowed (execute-sql stays default-allowed)."""
+
+    @hookimpl
+    def permission_resources_sql(self, datasette, actor, action):
+        actor_id = actor.get("id") if actor else None
+        if actor_id == "dave":
+            if action == "store-query":
+                return PermissionSQL(
+                    sql="SELECT NULL AS parent, NULL AS child, 1 AS allow, 'dave can store' AS reason"
+                )
+            if action == "execute-sql":
+                return PermissionSQL(
+                    sql="SELECT NULL AS parent, NULL AS child, 0 AS allow, 'dave no sql' AS reason"
+                )
+        if actor_id == "erin" and action == "store-query":
+            return PermissionSQL(
+                sql="SELECT NULL AS parent, NULL AS child, 1 AS allow, 'erin can store' AS reason"
+            )
+        return None
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_also_requires(ds):
+    # store-query also_requires execute-sql, which also_requires view-database
+    plugin = AlsoRequiresRulesPlugin()
+    ds.pm.register(plugin, name="also_requires")
+    try:
+        resource = DatabaseResource("analytics")
+        dave = await ds.allowed_many(
+            actions=["store-query", "execute-sql", "view-database"],
+            resource=resource,
+            actor={"id": "dave"},
+        )
+        # execute-sql denied, so store-query must be denied too
+        assert dave == {
+            "store-query": False,
+            "execute-sql": False,
+            "view-database": True,
+        }
+        erin = await ds.allowed_many(
+            actions=["store-query"], resource=resource, actor={"id": "erin"}
+        )
+        assert erin == {"store-query": True}
+        # Must match the single-check path
+        assert (
+            await ds.allowed(
+                action="store-query", resource=resource, actor={"id": "dave"}
+            )
+            is False
+        )
+        assert (
+            await ds.allowed(
+                action="store-query", resource=resource, actor={"id": "erin"}
+            )
+            is True
+        )
+    finally:
+        ds.pm.unregister(name="also_requires")
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_respects_restrictions(ds):
+    """Token-style _r restrictions are enforced within the batch."""
+    actor = {"id": "root", "_r": {"d": {"analytics": ["vt"]}}}
+    results = await ds.allowed_many(
+        actions=["view-table", "drop-table"],
+        resource=TableResource("analytics", "users"),
+        actor=actor,
+    )
+    # root could normally do both, but the token only allows view-table
+    # on the analytics database
+    assert results == {"view-table": True, "drop-table": False}
+    other_db = await ds.allowed_many(
+        actions=["view-table"],
+        resource=TableResource("production", "stuff"),
+        actor=actor,
+    )
+    assert other_db == {"view-table": False}
+    # Equivalence with allowed()
+    assert (
+        await ds.allowed(
+            action="view-table",
+            resource=TableResource("analytics", "users"),
+            actor=actor,
+        )
+        is True
+    )
+    assert (
+        await ds.allowed(
+            action="drop-table",
+            resource=TableResource("analytics", "users"),
+            actor=actor,
+        )
+        is False
+    )
+
+
+class ParamCollisionPlugin:
+    """Same parameter name with a different value for every action."""
+
+    @hookimpl
+    def permission_resources_sql(self, datasette, actor, action):
+        if not actor or actor.get("id") != "paula":
+            return None
+        flag = 1 if action in ("drop-table", "insert-row") else 0
+        return PermissionSQL(
+            sql="SELECT NULL AS parent, NULL AS child, :flag AS allow, 'flagged' AS reason",
+            params={"flag": flag},
+        )
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_namespaces_params_across_actions(ds):
+    """Many actions whose rules use identical param names must not collide."""
+    plugin = ParamCollisionPlugin()
+    ds.pm.register(plugin, name="collision")
+    try:
+        all_actions = list(ds.actions)
+        assert len(all_actions) >= 15
+        resource = TableResource("analytics", "users")
+        results = await ds.allowed_many(
+            actions=all_actions, resource=resource, actor={"id": "paula"}
+        )
+        # Spot-check: only the flagged actions resolve True
+        assert results["drop-table"] is True
+        assert results["create-table"] is False
+        # Full equivalence against single checks
+        for action in all_actions:
+            assert results[action] == await ds.allowed(
+                action=action, resource=resource, actor={"id": "paula"}
+            ), f"Mismatch for {action}"
+    finally:
+        ds.pm.unregister(name="collision")
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_single_internal_db_query(ds):
+    internal_db = ds.get_internal_database()
+    calls = []
+    original_execute = internal_db.execute
+
+    async def counting_execute(sql, params=None, **kwargs):
+        calls.append(sql)
+        return await original_execute(sql, params, **kwargs)
+
+    internal_db.execute = counting_execute
+    try:
+        results = await ds.allowed_many(
+            actions=["view-table", "insert-row", "delete-row", "drop-table"],
+            resource=TableResource("analytics", "users"),
+            actor={"id": "root", "_r": {"d": {"analytics": ["vt"]}}},
+        )
+        assert len(results) == 4
+        assert len(calls) == 1
+    finally:
+        internal_db.execute = original_execute
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_no_query_when_no_rules(ds):
+    """Actions with no rules from any plugin are denied without SQL.
+
+    Restrictions can only restrict, never grant, so an action with no
+    rule rows is always False - it should not contribute to the query,
+    and if no action has rules there should be no query at all."""
+    internal_db = ds.get_internal_database()
+    calls = []
+    original_execute = internal_db.execute
+
+    async def counting_execute(sql, params=None, **kwargs):
+        calls.append(sql)
+        return await original_execute(sql, params, **kwargs)
+
+    internal_db.execute = counting_execute
+    try:
+        # bob gets no rules at all for these write actions
+        results = await ds.allowed_many(
+            actions=["drop-table", "delete-row"],
+            resource=TableResource("analytics", "users"),
+            actor={"id": "bob"},
+        )
+        assert results == {"drop-table": False, "delete-row": False}
+        assert len(calls) == 0
+        # A mixed batch still needs exactly one query
+        calls.clear()
+        results = await ds.allowed_many(
+            actions=["view-table", "drop-table"],
+            resource=TableResource("analytics", "users"),
+            actor={"id": "bob"},
+        )
+        assert results == {"view-table": True, "drop-table": False}
+        assert len(calls) == 1
+    finally:
+        internal_db.execute = original_execute
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_global_actions_without_resource(ds):
+    results = await ds.allowed_many(
+        actions=["view-instance", "permissions-debug"],
+        actor={"id": "root"},
+    )
+    assert results["view-instance"] is True
+    # Equivalence with single checks for global actions
+    for action in ("view-instance", "permissions-debug"):
+        assert results[action] == await ds.allowed(action=action, actor={"id": "root"})
+    anon = await ds.allowed_many(actions=["permissions-debug"], actor=None)
+    assert anon == {"permissions-debug": False}
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_skip_permission_checks(ds):
+    with SkipPermissions():
+        results = await ds.allowed_many(
+            actions=["view-table", "drop-table"],
+            resource=TableResource("analytics", "users"),
+            actor=None,
+        )
+    assert results == {"view-table": True, "drop-table": True}

From bb59c61c9f9b6766199ce1434c7008739653f141 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 12 Jun 2026 13:11:09 -0700
Subject: [PATCH 184/386] Request-scoped permission check cache

Adds a per-request cache for permission check results, plus wiring that
resolves action permissions in bulk before plugin hooks need them:

- New _permission_check_cache contextvar, set to a fresh dict for each
  request by DatasetteRouter and reset when the request ends. Keys
  include the full serialized actor, so actors differing in any field
  (e.g. token restrictions) never share entries. SkipPermissions mode
  bypasses the cache entirely.
- datasette.allowed_many() now consults the cache and stores its
  results there, so repeated datasette.allowed() checks within one
  request resolve without further SQL.
- Table pages resolve all registered table-level actions against the
  current table and all database-level actions against its database
  (database pages likewise) in batched queries before invoking the
  table_actions/database_actions plugin hooks - allowed() calls made
  inside those hooks are then served from the cache with no plugin
  changes required. Actions with no permission rules from any plugin
  are resolved to False without touching the database.

Benchmarks (benchmarks/) with a simulated 12-plugin ecosystem making
18 checks per table page show 34 -> 13 internal-DB queries per page;
with 2ms-per-query internal DB latency (modelling Datasette Cloud)
table page time drops from 77.9ms to 27.6ms - the caching layer
accounts for ~91% of that improvement over allowed_many() alone.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 datasette/app.py                |  67 +++++--
 datasette/permissions.py        |   8 +
 datasette/views/database.py     |  13 ++
 datasette/views/table_extras.py |  26 ++-
 docs/internals.rst              |   4 +
 docs/plugin_hooks.rst           |   6 +-
 tests/test_allowed_many.py      | 340 +++++++++++++++++++++++++++++++-
 7 files changed, 443 insertions(+), 21 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index a6696ad9..9979b6c5 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -291,6 +291,15 @@ DEFAULT_NOT_SET = object()
 ResourcesSQL = collections.namedtuple("ResourcesSQL", ("sql", "params"))
 
 
+def _permission_cache_key(actor, action, parent, child):
+    # Key on the full serialized actor so actors differing in any field
+    # (e.g. token restrictions) never share cache entries
+    actor_key = (
+        json.dumps(actor, sort_keys=True, default=repr) if actor is not None else None
+    )
+    return (actor_key, action, parent, child)
+
+
 async def favicon(request, send):
     await asgi_send_file(
         send,
@@ -1834,7 +1843,9 @@ class Datasette:
 
         Resolves every action (plus any also_requires dependencies) with a
         single internal database query, instead of one or two queries per
-        action.
+        action. Results are stored in the request-scoped permission cache,
+        so subsequent datasette.allowed() calls for the same checks within
+        the same request are served from the cache.
 
         Example:
             from datasette.resources import TableResource
@@ -1846,6 +1857,10 @@ class Datasette:
             # {"edit-schema": True, "drop-table": True, "insert-row": False}
         """
         from datasette.utils.actions_sql import check_permissions_for_actions
+        from datasette.permissions import (
+            _permission_check_cache,
+            _skip_permission_checks,
+        )
 
         # For global actions, resource is None
         parent = resource.parent if resource else None
@@ -1869,14 +1884,30 @@ class Datasette:
         for name in requested:
             add_action(name)
 
-        raw = await check_permissions_for_actions(
-            datasette=self,
-            actor=actor,
-            actions=expanded,
-            parent=parent,
-            child=child,
-        )
+        # Consult the request-scoped cache, unless permission checks are
+        # being skipped (skip-mode verdicts must never be cached)
+        skip = _skip_permission_checks.get()
+        cache = None if skip else _permission_check_cache.get()
+
         final = {}
+        to_check = []
+        for name in expanded:
+            if cache is not None:
+                key = _permission_cache_key(actor, name, parent, child)
+                if key in cache:
+                    final[name] = cache[key]
+                    continue
+            to_check.append(name)
+
+        raw = {}
+        if to_check:
+            raw = await check_permissions_for_actions(
+                datasette=self,
+                actor=actor,
+                actions=to_check,
+                parent=parent,
+                child=child,
+            )
 
         def resolve(name):
             # final verdict = own rules AND verdict of also_requires chain
@@ -1892,8 +1923,13 @@ class Datasette:
         for name in expanded:
             resolve(name)
 
-        # Log every check for the debug page, dependencies before the
-        # actions that required them
+        # Cache the freshly computed checks
+        if cache is not None:
+            for name in to_check:
+                cache[_permission_cache_key(actor, name, parent, child)] = final[name]
+
+        # Log every check (including cache hits) for the debug page,
+        # dependencies before the actions that required them
         when = datetime.datetime.now(datetime.timezone.utc).isoformat()
         for name in reversed(expanded):
             self._permission_checks.append(
@@ -2663,7 +2699,16 @@ class DatasetteRouter:
         if raw_path:
             path = raw_path.decode("ascii")
         path = path.partition("?")[0]
-        return await self.route_path(scope, receive, send, path)
+        # Give each request a fresh permission check cache, so repeated
+        # datasette.allowed() checks within the request are memoized but
+        # results never persist beyond it
+        from datasette.permissions import _permission_check_cache
+
+        cache_token = _permission_check_cache.set({})
+        try:
+            return await self.route_path(scope, receive, send, path)
+        finally:
+            _permission_check_cache.reset(cache_token)
 
     async def route_path(self, scope, receive, send, path):
         # Strip off base_url if present before routing
diff --git a/datasette/permissions.py b/datasette/permissions.py
index a9a3cc7c..786dc026 100644
--- a/datasette/permissions.py
+++ b/datasette/permissions.py
@@ -8,6 +8,14 @@ _skip_permission_checks = contextvars.ContextVar(
     "skip_permission_checks", default=False
 )
 
+# Request-scoped cache of permission check results. The ASGI router sets
+# this to a fresh dict at the start of each request, so cached verdicts
+# never outlive a request or leak between actors. Keys are
+# (actor_json, action, parent, child) tuples, values are booleans.
+_permission_check_cache: contextvars.ContextVar[dict | None] = contextvars.ContextVar(
+    "permission_check_cache", default=None
+)
+
 
 class SkipPermissions:
     """Context manager to temporarily skip permission checks.
diff --git a/datasette/views/database.py b/datasette/views/database.py
index f1756863..6afd9734 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -118,6 +118,19 @@ class DatabaseView(View):
         )
 
         async def database_actions():
+            # Resolve the registered database-level actions for this
+            # database in one batched query, seeding the request permission
+            # cache so that allowed() calls made inside the plugin hooks
+            # below are served from the cache
+            await datasette.allowed_many(
+                actions=[
+                    name
+                    for name, action in datasette.actions.items()
+                    if action.resource_class is DatabaseResource
+                ],
+                resource=DatabaseResource(database),
+                actor=request.actor,
+            )
             links = []
             for hook in pm.hook.database_actions(
                 datasette=datasette,
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index 948f3daa..a0308e49 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -4,7 +4,7 @@ from dataclasses import dataclass
 from datasette.database import QueryInterrupted
 from datasette.extras import Extra, ExtraExample, ExtraRegistry, ExtraScope, Provider
 from datasette.plugins import pm
-from datasette.resources import TableResource
+from datasette.resources import DatabaseResource, TableResource
 from datasette.utils import (
     await_me_maybe,
     call_with_supported_arguments,
@@ -361,6 +361,30 @@ class ActionsExtra(Extra):
             else:
                 kwargs["table"] = context.table_name
                 method = pm.hook.table_actions
+                # Resolve the registered table-level actions for this table
+                # and the database-level actions for its database in two
+                # batched queries, seeding the request permission cache so
+                # that allowed() calls made inside the plugin hooks below
+                # are served from the cache
+                datasette = context.datasette
+                await datasette.allowed_many(
+                    actions=[
+                        name
+                        for name, action in datasette.actions.items()
+                        if action.resource_class is TableResource
+                    ],
+                    resource=TableResource(context.database_name, context.table_name),
+                    actor=context.request.actor,
+                )
+                await datasette.allowed_many(
+                    actions=[
+                        name
+                        for name, action in datasette.actions.items()
+                        if action.resource_class is DatabaseResource
+                    ],
+                    resource=DatabaseResource(context.database_name),
+                    actor=context.request.actor,
+                )
             for hook in method(**kwargs):
                 extra_links = await await_me_maybe(hook)
                 if extra_links:
diff --git a/docs/internals.rst b/docs/internals.rst
index f3c1152a..641286f8 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -512,6 +512,8 @@ Example usage:
 
 The method returns ``True`` if the permission is granted, ``False`` if denied.
 
+Results are cached for the duration of the current request, so checking the same ``(actor, action, resource)`` combination twice within one request only does the underlying permission resolution work once.
+
 .. _datasette_allowed_many:
 
 await .allowed_many(\*, actions, resource, actor=None)
@@ -543,6 +545,8 @@ Example usage:
     )
     # {"insert-row": True, "delete-row": True, "drop-table": False}
 
+Each result is stored in the per-request permission check cache, so subsequent ``datasette.allowed()`` calls for the same checks within the same request are served from that cache. Datasette uses this before running the ``table_actions`` and ``database_actions`` plugin hooks: it resolves every registered table-level action against the current table and every database-level action against its database first, which means ``allowed()`` calls made by those plugin hooks are usually served from the cache instead of triggering additional queries.
+
 Actions for which no plugin provides any permission rules are resolved to ``False`` directly, without being included in the SQL query at all.
 
 .. _datasette_allowed_resources:
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 0a55f8ec..580f7402 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1460,9 +1460,9 @@ plugin's source name (e.g., ``myplugin_user_id``). The system reserves these par
 
 This hook may be called for many actions in rapid succession - for example
 :ref:`datasette.allowed_many() <datasette_allowed_many>` gathers rules for every action in its batch
-concurrently. Hook implementations must not assume that checks for different actions arrive one
-page-render apart, and expensive work (such as network calls) should be cached independently of the
-``action`` argument where possible.
+concurrently before table and database pages render their action menus. Hook implementations must not
+assume that checks for different actions arrive one page-render apart, and expensive work (such as
+network calls) should be cached independently of the ``action`` argument where possible.
 
 You can also use return ``PermissionSQL.allow(reason="reason goes here")`` or ``PermissionSQL.deny(reason="reason goes here")`` as shortcuts for simple root-level allow or deny rules. These will create SQL snippets that look like this:
 
diff --git a/tests/test_allowed_many.py b/tests/test_allowed_many.py
index 53d0ffd9..3d0d0c9a 100644
--- a/tests/test_allowed_many.py
+++ b/tests/test_allowed_many.py
@@ -1,18 +1,52 @@
 """
-Tests for the datasette.allowed_many() batch permission API, which
-resolves multiple actions against one resource in a single internal
-database query. datasette.allowed() is implemented on top of it, so
-both entry points share one resolution code path.
+Tests for request-scoped permission check memoization and the
+datasette.allowed_many() batch permission API.
+
+Layer 1: per-request cache consulted by datasette.allowed()
+Layer 2: allowed_many() resolves multiple actions in one internal-DB query
+Layer 3: table/database views precompute all registered actions before
+         invoking table_actions/database_actions plugin hooks
 """
 
 import pytest
 import pytest_asyncio
 from datasette.app import Datasette
-from datasette.permissions import PermissionSQL, SkipPermissions
+from datasette.permissions import (
+    PermissionSQL,
+    SkipPermissions,
+    _permission_check_cache,
+)
 from datasette.resources import DatabaseResource, TableResource
 from datasette import hookimpl
 
 
+class CountingRulesPlugin:
+    """Counts permission_resources_sql gathers and grants rules for alice."""
+
+    def __init__(self):
+        self.calls = []
+
+    @hookimpl
+    def permission_resources_sql(self, datasette, actor, action):
+        actor_id = actor.get("id") if actor else None
+        self.calls.append((actor_id, action))
+        if actor_id == "alice":
+            return PermissionSQL(
+                sql="SELECT NULL AS parent, NULL AS child, 1 AS allow, 'alice allowed' AS reason"
+            )
+        return None
+
+    def count(self, actor_id=None, action=None):
+        return len(
+            [
+                (a, c)
+                for a, c in self.calls
+                if (actor_id is None or a == actor_id)
+                and (action is None or c == action)
+            ]
+        )
+
+
 @pytest_asyncio.fixture
 async def ds():
     ds = Datasette()
@@ -24,6 +58,154 @@ async def ds():
     return ds
 
 
+@pytest_asyncio.fixture
+async def counting_ds(ds):
+    plugin = CountingRulesPlugin()
+    ds.pm.register(plugin, name="counting")
+    try:
+        yield ds, plugin
+    finally:
+        ds.pm.unregister(name="counting")
+
+
+# ----------------------------------------------------------------------
+# Layer 1: request-scoped memoization
+# ----------------------------------------------------------------------
+
+
+@pytest.mark.asyncio
+async def test_allowed_memoized_when_cache_active(counting_ds):
+    ds, plugin = counting_ds
+    resource = TableResource("analytics", "users")
+    token = _permission_check_cache.set({})
+    try:
+        first = await ds.allowed(
+            action="view-table", resource=resource, actor={"id": "alice"}
+        )
+        gathers_after_first = plugin.count(actor_id="alice", action="view-table")
+        assert gathers_after_first > 0
+        second = await ds.allowed(
+            action="view-table", resource=resource, actor={"id": "alice"}
+        )
+        assert first is True
+        assert second is True
+        # The second identical check must not gather hooks again
+        assert plugin.count(actor_id="alice", action="view-table") == (
+            gathers_after_first
+        )
+    finally:
+        _permission_check_cache.reset(token)
+
+
+@pytest.mark.asyncio
+async def test_allowed_not_memoized_without_cache(counting_ds):
+    ds, plugin = counting_ds
+    resource = TableResource("analytics", "users")
+    assert _permission_check_cache.get() is None
+    await ds.allowed(action="view-table", resource=resource, actor={"id": "alice"})
+    first_count = plugin.count(actor_id="alice", action="view-table")
+    await ds.allowed(action="view-table", resource=resource, actor={"id": "alice"})
+    # No request cache active - hooks gathered again
+    assert plugin.count(actor_id="alice", action="view-table") == first_count * 2
+
+
+@pytest.mark.asyncio
+async def test_cache_keyed_on_full_actor_identity(counting_ds):
+    """Interleaved checks for different actors never share cache entries."""
+    # Uses drop-table because default permissions deny it to non-root actors
+    ds, plugin = counting_ds
+    resource = TableResource("analytics", "users")
+    token = _permission_check_cache.set({})
+    try:
+        assert (
+            await ds.allowed(
+                action="drop-table", resource=resource, actor={"id": "alice"}
+            )
+            is True
+        )
+        assert (
+            await ds.allowed(
+                action="drop-table", resource=resource, actor={"id": "bob"}
+            )
+            is False
+        )
+        # Repeat interleaved - cached results must stay correct per actor
+        assert (
+            await ds.allowed(
+                action="drop-table", resource=resource, actor={"id": "alice"}
+            )
+            is True
+        )
+        assert (
+            await ds.allowed(
+                action="drop-table", resource=resource, actor={"id": "bob"}
+            )
+            is False
+        )
+        # Actors differing in fields beyond id must not collide either
+        assert (
+            await ds.allowed(
+                action="drop-table",
+                resource=resource,
+                actor={"id": "alice", "_r": {"a": []}},
+            )
+            is False
+        )
+    finally:
+        _permission_check_cache.reset(token)
+
+
+@pytest.mark.asyncio
+async def test_cache_keyed_on_resource(counting_ds):
+    ds, plugin = counting_ds
+    token = _permission_check_cache.set({})
+    try:
+        await ds.allowed(
+            action="view-table",
+            resource=TableResource("analytics", "users"),
+            actor={"id": "alice"},
+        )
+        count = plugin.count(actor_id="alice", action="view-table")
+        # Different resource - must not be served from cache
+        await ds.allowed(
+            action="view-table",
+            resource=TableResource("analytics", "events"),
+            actor={"id": "alice"},
+        )
+        assert plugin.count(actor_id="alice", action="view-table") == count * 2
+    finally:
+        _permission_check_cache.reset(token)
+
+
+@pytest.mark.asyncio
+async def test_skip_permission_checks_bypasses_cache(counting_ds):
+    ds, plugin = counting_ds
+    resource = TableResource("analytics", "users")
+    token = _permission_check_cache.set({})
+    try:
+        with SkipPermissions():
+            assert (
+                await ds.allowed(
+                    action="drop-table", resource=resource, actor={"id": "bob"}
+                )
+                is True
+            )
+        # The skip-mode True must not have been cached
+        assert (
+            await ds.allowed(
+                action="drop-table", resource=resource, actor={"id": "bob"}
+            )
+            is False
+        )
+    finally:
+        _permission_check_cache.reset(token)
+
+
+# ----------------------------------------------------------------------
+# Layer 2: allowed_many()
+# ----------------------------------------------------------------------
+
+
 class MatrixRulesPlugin:
     """Different rules per action for actor carol, to exercise resolution."""
 
@@ -233,7 +415,7 @@ class ParamCollisionPlugin:
 
 @pytest.mark.asyncio
 async def test_allowed_many_namespaces_params_across_actions(ds):
-    """Many actions whose rules use identical param names must not collide."""
+    """40+ actions whose rules use identical param names must not collide."""
     plugin = ParamCollisionPlugin()
     ds.pm.register(plugin, name="collision")
     try:
@@ -330,6 +512,24 @@ async def test_allowed_many_global_actions_without_resource(ds):
     assert anon == {"permissions-debug": False}
 
 
+@pytest.mark.asyncio
+async def test_allowed_many_seeds_request_cache(counting_ds):
+    ds, plugin = counting_ds
+    resource = TableResource("analytics", "users")
+    actions = ["view-table", "insert-row", "drop-table"]
+    token = _permission_check_cache.set({})
+    try:
+        await ds.allowed_many(actions=actions, resource=resource, actor={"id": "alice"})
+        gathers = plugin.count(actor_id="alice")
+        assert gathers > 0
+        for action in actions:
+            await ds.allowed(action=action, resource=resource, actor={"id": "alice"})
+        # Every allowed() call must have been served from the seeded cache
+        assert plugin.count(actor_id="alice") == gathers
+    finally:
+        _permission_check_cache.reset(token)
+
+
 @pytest.mark.asyncio
 async def test_allowed_many_skip_permission_checks(ds):
     with SkipPermissions():
@@ -339,3 +539,131 @@ async def test_allowed_many_skip_permission_checks(ds):
             actor=None,
         )
     assert results == {"view-table": True, "drop-table": True}
+
+
+# ----------------------------------------------------------------------
+# Layer 3: precompute before table_actions / database_actions hooks
+# ----------------------------------------------------------------------
+
+
+class ActionHooksPlugin:
+    """Plugin hooks that make allowed() checks, like real action plugins do."""
+
+    @hookimpl
+    def table_actions(self, datasette, actor, database, table):
+        async def inner():
+            links = []
+            if await datasette.allowed(
+                action="drop-table",
+                resource=TableResource(database, table),
+                actor=actor,
+            ):
+                links.append(
+                    {"href": "/drop", "label": "Drop this table (test-plugin)"}
+                )
+            if await datasette.allowed(
+                action="create-table",
+                resource=DatabaseResource(database),
+                actor=actor,
+            ):
+                links.append(
+                    {"href": "/create", "label": "Create a table (test-plugin)"}
+                )
+            return links
+
+        return inner
+
+    @hookimpl
+    def database_actions(self, datasette, actor, database):
+        async def inner():
+            if await datasette.allowed(
+                action="create-table",
+                resource=DatabaseResource(database),
+                actor=actor,
+            ):
+                return [{"href": "/create", "label": "Create a table (test-plugin)"}]
+            return []
+
+        return inner
+
+
+@pytest_asyncio.fixture
+async def spying_ds(ds, monkeypatch):
+    """ds with the ActionHooksPlugin plus a spy recording every batch of
+    actions sent to check_permissions_for_actions."""
+    from datasette.utils import actions_sql
+
+    plugin = ActionHooksPlugin()
+    ds.pm.register(plugin, name="action_hooks")
+    ds.root_enabled = True
+    recorded = []
+    original = actions_sql.check_permissions_for_actions
+
+    async def spy(**kwargs):
+        recorded.append(kwargs["actions"])
+        return await original(**kwargs)
+
+    monkeypatch.setattr(actions_sql, "check_permissions_for_actions", spy)
+    try:
+        yield ds, recorded
+    finally:
+        ds.pm.unregister(name="action_hooks")
+
+
+@pytest.mark.asyncio
+async def test_table_page_precomputes_action_permissions(spying_ds):
+    ds, recorded = spying_ds
+    cookies = {"ds_actor": ds.client.actor_cookie({"id": "root"})}
+    response = await ds.client.get("/analytics/users", cookies=cookies)
+    assert response.status_code == 200
+    # The plugin's permission checks were served from the precomputed batch
+    assert "Drop this table (test-plugin)" in response.text
+    assert "Create a table (test-plugin)" in response.text
+    # One batch covered the table-level actions for the table resource,
+    # and one covered the database-level actions for the database resource
+    batches = [batch for batch in recorded if len(batch) > 1]
+    assert any("drop-table" in batch for batch in batches)
+    assert any("create-table" in batch for batch in batches)
+    # The precompute is scoped to actions relevant to each resource:
+    # no global or query-level actions in any batch, and no mixing of
+    # table-level and database-level actions
+    for batch in batches:
+        assert "view-instance" not in batch
+        assert "view-query" not in batch
+        assert not ("drop-table" in batch and "create-table" in batch)
+    # The hook's own allowed() calls hit the cache - no single-action
+    # fallback queries for the actions it checked
+    assert ["drop-table"] not in recorded
+    assert ["create-table"] not in recorded
+
+
+@pytest.mark.asyncio
+async def test_database_page_precomputes_action_permissions(spying_ds):
+    ds, recorded = spying_ds
+    cookies = {"ds_actor": ds.client.actor_cookie({"id": "root"})}
+    response = await ds.client.get("/analytics", cookies=cookies)
+    assert response.status_code == 200
+    assert "Create a table (test-plugin)" in response.text
+    batches = [batch for batch in recorded if len(batch) > 1]
+    assert any("create-table" in batch for batch in batches)
+    # Scoped to database-level actions only
+    for batch in batches:
+        assert "view-instance" not in batch
+        assert "drop-table" not in batch
+    assert ["create-table"] not in recorded
+
+
+@pytest.mark.asyncio
+async def test_cache_does_not_leak_across_requests(counting_ds):
+    ds, plugin = counting_ds
+    cookies = {"ds_actor": ds.client.actor_cookie({"id": "alice"})}
+    response = await ds.client.get("/analytics/users.json", cookies=cookies)
+    assert response.status_code == 200
+    first_request_gathers = plugin.count(actor_id="alice", action="view-table")
+    assert first_request_gathers > 0
+    response = await ds.client.get("/analytics/users.json", cookies=cookies)
+    assert response.status_code == 200
+    # Second request must re-gather (fresh cache), not reuse the first one
+    assert (
+        plugin.count(actor_id="alice", action="view-table") == first_request_gathers * 2
+    )

From d4cb8b464bf1cbe69a8921fc8c9315e04a5f49cb Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 12 Jun 2026 13:21:58 -0700
Subject: [PATCH 185/386] Fix for trace_child_tasks exception handling

I had Claude Fable 5 review our use of contextvar and
it spotted this place where exceptions were not
correctly handled.
---
 datasette/tracer.py  |  6 ++++--
 tests/test_tracer.py | 13 +++++++++++++
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/datasette/tracer.py b/datasette/tracer.py
index 9e66613b..28f3cc09 100644
--- a/datasette/tracer.py
+++ b/datasette/tracer.py
@@ -27,8 +27,10 @@ def get_task_id():
 @contextmanager
 def trace_child_tasks():
     token = trace_task_id.set(get_task_id())
-    yield
-    trace_task_id.reset(token)
+    try:
+        yield
+    finally:
+        trace_task_id.reset(token)
 
 
 @contextmanager
diff --git a/tests/test_tracer.py b/tests/test_tracer.py
index 6cc80fc4..9db211d3 100644
--- a/tests/test_tracer.py
+++ b/tests/test_tracer.py
@@ -70,6 +70,19 @@ def test_trace_query_errors():
     assert trace_info["traces"][-1]["error"] == "no such table: non_existent_table"
 
 
+@pytest.mark.asyncio
+async def test_trace_child_tasks_resets_contextvar_on_exception():
+    from datasette import tracer
+
+    before = tracer.trace_task_id.get()
+    with pytest.raises(ValueError):
+        with tracer.trace_child_tasks():
+            assert tracer.trace_task_id.get() is not None
+            raise ValueError("simulated error")
+    # The contextvar must be reset even though the block raised
+    assert tracer.trace_task_id.get() == before
+
+
 def test_trace_parallel_queries():
     with make_app_client(settings={"trace_debug": True}) as client:
         response = client.get("/parallel-queries?_trace=1")

From 86334d233dd2e668169e54fb2312cae2705e7ffc Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 11:09:28 -0700
Subject: [PATCH 186/386] Switch to CTE to handle 600+ actions at once

GPT-5.5 xhigh in Codex spotted this problem and fixed it with a CTE:

https://gisthost.github.io/?46076499ee685acddc988ff6b47a74b0
---
 datasette/utils/actions_sql.py | 15 ++++++++++----
 tests/test_allowed_many.py     | 38 ++++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+), 4 deletions(-)

diff --git a/datasette/utils/actions_sql.py b/datasette/utils/actions_sql.py
index a422c1ed..c7137e6b 100644
--- a/datasette/utils/actions_sql.py
+++ b/datasette/utils/actions_sql.py
@@ -555,7 +555,7 @@ async def check_permissions_for_actions(
 
     params = {"_check_parent": parent, "_check_child": child}
     ctes = []
-    selects = []
+    result_rows = []
     verdicts = {}
 
     for i, (action, permission_sqls) in enumerate(zip(unique_actions, gathered)):
@@ -627,10 +627,17 @@ async def check_permissions_for_actions(
     AND (r.child = :_check_child OR r.child IS NULL)
 )"""
 
-        selects.append(f"SELECT {i} AS action_idx, ({verdict_sql}) AS is_allowed")
+        result_rows.append(f"({i}, ({verdict_sql}))")
 
-    if selects:
-        query = "WITH\n" + ",\n".join(ctes) + "\n" + "\nUNION ALL\n".join(selects)
+    if result_rows:
+        ctes.append(
+            "results(action_idx, is_allowed) AS (VALUES\n"
+            + ",\n".join(result_rows)
+            + "\n)"
+        )
+        query = (
+            "WITH\n" + ",\n".join(ctes) + "\nSELECT action_idx, is_allowed FROM results"
+        )
         result = await datasette.get_internal_database().execute(query, params)
         for row in result.rows:
             verdicts[unique_actions[row[0]]] = bool(row[1])
diff --git a/tests/test_allowed_many.py b/tests/test_allowed_many.py
index 3d0d0c9a..08b952fb 100644
--- a/tests/test_allowed_many.py
+++ b/tests/test_allowed_many.py
@@ -12,6 +12,7 @@ import pytest
 import pytest_asyncio
 from datasette.app import Datasette
 from datasette.permissions import (
+    Action,
     PermissionSQL,
     SkipPermissions,
     _permission_check_cache,
@@ -541,6 +542,43 @@ async def test_allowed_many_skip_permission_checks(ds):
     assert results == {"view-table": True, "drop-table": True}
 
 
+class ManyActionsPlugin:
+    """Registers enough actions to exceed SQLite's compound SELECT limit."""
+
+    def __init__(self, count):
+        self.action_names = [f"bulk-action-{i}" for i in range(count)]
+        self.action_names_set = set(self.action_names)
+
+    @hookimpl
+    def register_actions(self, datasette):
+        return [
+            Action(name=name, abbr=None, description="Bulk test action")
+            for name in self.action_names
+        ]
+
+    @hookimpl
+    def permission_resources_sql(self, datasette, actor, action):
+        if action in self.action_names_set:
+            return PermissionSQL(
+                sql="SELECT NULL AS parent, NULL AS child, 1 AS allow, 'bulk allow' AS reason",
+                params={},
+            )
+
+
+@pytest.mark.asyncio
+async def test_allowed_many_more_than_sqlite_compound_select_limit():
+    plugin = ManyActionsPlugin(600)
+    ds = Datasette()
+    ds.pm.register(plugin, name="many_actions")
+    try:
+        await ds.invoke_startup()
+        results = await ds.allowed_many(actions=plugin.action_names, actor=None)
+        assert len(results) == 600
+        assert all(results.values())
+    finally:
+        ds.pm.unregister(name="many_actions")
+
+
 # ----------------------------------------------------------------------
 # Layer 3: precompute before table_actions / database_actions hooks
 # ----------------------------------------------------------------------

From ab19b0382bc560ef7ae511f899aa7051935577af Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 11:12:31 -0700
Subject: [PATCH 187/386] Removed note from permission_resources_sql

Refs https://github.com/simonw/datasette/pull/2775/changes#r3408385197
---
 docs/plugin_hooks.rst | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 580f7402..2a0ddc93 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1458,12 +1458,6 @@ to avoid conflicts with other plugins. The recommended convention is to prefix p
 plugin's source name (e.g., ``myplugin_user_id``). The system reserves these parameter names:
 ``:actor``, ``:actor_id``, ``:action``, and ``:filter_parent``.
 
-This hook may be called for many actions in rapid succession - for example
-:ref:`datasette.allowed_many() <datasette_allowed_many>` gathers rules for every action in its batch
-concurrently before table and database pages render their action menus. Hook implementations must not
-assume that checks for different actions arrive one page-render apart, and expensive work (such as
-network calls) should be cached independently of the ``action`` argument where possible.
-
 You can also use return ``PermissionSQL.allow(reason="reason goes here")`` or ``PermissionSQL.deny(reason="reason goes here")`` as shortcuts for simple root-level allow or deny rules. These will create SQL snippets that look like this:
 
 .. code-block:: sql

From f2927a164746a1a2da3e14680948bfbdddfd626b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 11:15:47 -0700
Subject: [PATCH 188/386] Fix for gen.throw(*sys.exc_info()) warning

Closes #2776
---
 datasette/database.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/datasette/database.py b/datasette/database.py
index 6cd5d11e..e7fe1ed9 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -829,10 +829,10 @@ def _apply_write_wrapper(fn, wrapper_factory, track_event):
         # Execute the actual write
         try:
             result = fn(conn)
-        except Exception:
+        except Exception as e:
             # Throw exception into generator so it can handle it
             try:
-                gen.throw(*sys.exc_info())
+                gen.throw(e)
             except StopIteration:
                 pass
             # Re-raise the original exception

From e3a1f190572708b422457e2d50eb031f85ba4f52 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 14:19:39 -0700
Subject: [PATCH 189/386] Edit/delete icon prototype

---
 datasette/static/app.css | 55 +++++++++++++++++++++++++++++++++
 datasette/views/table.py | 67 +++++++++++++++++++++++++++++++++++-----
 2 files changed, 115 insertions(+), 7 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 6d675d9f..ec3a85fb 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1192,6 +1192,50 @@ dialog.set-column-type-dialog::backdrop {
     cursor: wait;
 }
 
+.row-link-with-actions {
+    display: inline-flex;
+    align-items: center;
+    gap: 0.4rem;
+    flex-wrap: wrap;
+}
+
+.row-inline-actions {
+    display: inline-flex;
+    gap: 0.2rem;
+    align-items: center;
+}
+
+.row-inline-action {
+    appearance: none;
+    border: 1px solid rgba(74, 85, 104, 0.24);
+    background: transparent;
+    color: #4a5568;
+    border-radius: 4px;
+    cursor: pointer;
+    display: inline-grid;
+    place-items: center;
+    min-height: 24px;
+    min-width: 24px;
+    padding: 2px;
+    position: relative;
+}
+
+.row-inline-action:hover,
+.row-inline-action:focus {
+    background: rgba(74, 85, 104, 0.07);
+}
+
+.row-inline-action:focus {
+    outline: 3px solid #b3d4ff;
+    outline-offset: 1px;
+}
+
+.row-inline-action-icon {
+    display: block;
+    height: 13px;
+    width: 13px;
+}
+
 @media (max-width: 640px) {
     dialog.mobile-column-actions-dialog {
         width: 95vw;
@@ -1239,6 +1283,17 @@ dialog.set-column-type-dialog::backdrop {
         padding-left: 18px;
         padding-right: 18px;
     }
+
+    .row-inline-action {
+        min-height: 30px;
+        min-width: 30px;
+        padding: 4px;
+    }
+
+    .row-inline-action-icon {
+        height: 14px;
+        width: 14px;
+    }
 }
 
 @media only screen and (max-width: 576px) {
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 65388c9c..49238ff4 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -194,6 +194,13 @@ async def display_columns_and_rows(
     pks_for_display = pks
     if not pks_for_display:
         pks_for_display = ["rowid"]
+    row_action_permissions = {}
+    if link_column and request is not None and db.is_mutable:
+        row_action_permissions = await datasette.allowed_many(
+            actions=["update-row", "delete-row"],
+            resource=TableResource(database=database_name, table=table_name),
+            actor=request.actor,
+        )
 
     columns = []
     for r in description:
@@ -233,19 +240,65 @@ async def display_columns_and_rows(
         if link_column:
             is_special_link_column = len(pks) != 1
             pk_path = path_from_row_pks(row, pks, not pks, False)
+            row_path = path_from_row_pks(row, pks, not pks)
+            row_link = '<a href="{table_path}/{flat_pks_quoted}">{flat_pks}</a>'.format(
+                table_path=datasette.urls.table(database_name, table_name),
+                flat_pks=str(markupsafe.escape(pk_path)),
+                flat_pks_quoted=row_path,
+            )
+            edit_icon = (
+                '<svg class="row-inline-action-icon" aria-hidden="true" '
+                'xmlns="http://www.w3.org/2000/svg" width="14" height="14" '
+                'viewBox="0 0 24 24" fill="none" stroke="currentColor" '
+                'stroke-width="2" stroke-linecap="round" stroke-linejoin="round">'
+                '<path d="M12 20h9"></path>'
+                '<path d="M16.5 3.5a2.1 2.1 0 0 1 3 3L7 19l-4 1 1-4Z"></path>'
+                "</svg>"
+            )
+            delete_icon = (
+                '<svg class="row-inline-action-icon" aria-hidden="true" '
+                'xmlns="http://www.w3.org/2000/svg" width="14" height="14" '
+                'viewBox="0 0 24 24" fill="none" stroke="currentColor" '
+                'stroke-width="2" stroke-linecap="round" stroke-linejoin="round">'
+                '<path d="M3 6h18"></path>'
+                '<path d="M8 6V4a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v2"></path>'
+                '<path d="M19 6l-1 14a2 2 0 0 1-2 2H8a2 2 0 0 1-2-2L5 6"></path>'
+                '<path d="M10 11v6"></path>'
+                '<path d="M14 11v6"></path>'
+                "</svg>"
+            )
+            row_actions = []
+            if row_action_permissions.get("update-row"):
+                row_actions.append(
+                    '<button type="button" class="row-inline-action row-inline-action-edit" '
+                    'aria-label="Edit row {row_label}" title="Edit row">'
+                    "{edit_icon}</button>".format(
+                        edit_icon=edit_icon,
+                        row_label=markupsafe.escape(pk_path),
+                    )
+                )
+            if row_action_permissions.get("delete-row"):
+                row_actions.append(
+                    '<button type="button" class="row-inline-action row-inline-action-delete" '
+                    'aria-label="Delete row {row_label}" title="Delete row">'
+                    "{delete_icon}</button>".format(
+                        delete_icon=delete_icon,
+                        row_label=markupsafe.escape(pk_path),
+                    )
+                )
+            if row_actions:
+                row_link = (
+                    '<span class="row-link-with-actions">{row_link}'
+                    '<span class="row-inline-actions" aria-label="Row actions">'
+                    "{row_actions}</span></span>"
+                ).format(row_link=row_link, row_actions="".join(row_actions))
             cells.append(
                 {
                     "column": pks[0] if len(pks) == 1 else "Link",
                     "value_type": "pk",
                     "is_special_link_column": is_special_link_column,
                     "raw": pk_path,
-                    "value": markupsafe.Markup(
-                        '<a href="{table_path}/{flat_pks_quoted}">{flat_pks}</a>'.format(
-                            table_path=datasette.urls.table(database_name, table_name),
-                            flat_pks=str(markupsafe.escape(pk_path)),
-                            flat_pks_quoted=path_from_row_pks(row, pks, not pks),
-                        )
-                    ),
+                    "value": markupsafe.Markup(row_link),
                 }
             )
 

From de5f72dd8847be184f5283491a4df38c63f823bd Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 14:38:49 -0700
Subject: [PATCH 190/386] hash busting thing on table.js

Addd for Codex Desktop, which has real trouble with edits
to files like this as the in-app browser does not seem to
have a cache-busting reload option.
---
 datasette/app.py               | 1 +
 datasette/templates/table.html | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/datasette/app.py b/datasette/app.py
index 9979b6c5..4931f486 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2312,6 +2312,7 @@ class Datasette:
                 and "ds_actor" in request.cookies
                 and request.actor,
                 "app_css_hash": self.app_css_hash(),
+                "table_js_hash": self.static_hash("table.js"),
                 "zip": zip,
                 "body_scripts": body_scripts,
                 "format_bytes": format_bytes,
diff --git a/datasette/templates/table.html b/datasette/templates/table.html
index c841e1be..4dc908e0 100644
--- a/datasette/templates/table.html
+++ b/datasette/templates/table.html
@@ -5,7 +5,7 @@
 {% block extra_head %}
 {{- super() -}}
 <script src="{{ urls.static('column-chooser.js') }}" defer></script>
-<script src="{{ urls.static('table.js') }}" defer></script>
+<script src="{{ urls.static('table.js') }}?hash={{ table_js_hash }}" defer></script>
 <script src="{{ urls.static('mobile-column-actions.js') }}" defer></script>
 <script>DATASETTE_ALLOW_FACET = {{ datasette_allow_facet }};</script>
 <style>

From 20824bd707c35ec56830ba8465cb3b5f7698a6a3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 14:40:29 -0700
Subject: [PATCH 191/386] Delete icon on table page now works

---
 datasette/static/app.css        | 159 +++++++++++++++++++
 datasette/static/table.js       | 273 ++++++++++++++++++++++++++++++++
 datasette/templates/_table.html |   2 +-
 datasette/views/table.py        |  37 ++++-
 tests/test_table_html.py        |  47 ++++++
 5 files changed, 513 insertions(+), 5 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index ec3a85fb..36335146 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1192,6 +1192,147 @@ dialog.set-column-type-dialog::backdrop {
     cursor: wait;
 }
 
+.row-delete-status {
+    margin: 0 0 0.75rem;
+    padding: 8px 10px;
+    border-left: 4px solid #54AC8E;
+    background: rgba(103,201,141,0.12);
+    color: #222;
+}
+
+.row-delete-status[hidden] {
+    display: none;
+}
+
+.row-delete-status-error {
+    border-left-color: #D0021B;
+    background: rgba(208,2,27,0.12);
+}
+
+dialog.row-delete-dialog {
+    --ink: #0f0f0f;
+    --paper: #f5f3ef;
+    --muted: #6b6b6b;
+    --rule: #e2dfd8;
+    --accent: #1a56db;
+    --card: #ffffff;
+    border: none;
+    border-radius: var(--modal-border-radius, 0.75rem);
+    padding: 0;
+    margin: auto;
+    width: min(440px, calc(100vw - 32px));
+    max-width: 95vw;
+    box-shadow: var(--modal-shadow, 0 20px 25px -5px rgba(0, 0, 0, 0.1), 0 10px 10px -5px rgba(0, 0, 0, 0.04));
+    animation: datasette-modal-slide-in var(--modal-animation-duration, 0.2s) ease-out;
+    overflow: hidden;
+    font-family: system-ui, -apple-system, sans-serif;
+    background: var(--card);
+}
+
+dialog.row-delete-dialog[open] {
+    display: flex;
+    flex-direction: column;
+}
+
+dialog.row-delete-dialog::backdrop {
+    background: var(--modal-backdrop-bg, rgba(0, 0, 0, 0.5));
+    backdrop-filter: var(--modal-backdrop-blur, blur(4px));
+    -webkit-backdrop-filter: var(--modal-backdrop-blur, blur(4px));
+    animation: datasette-modal-fade-in var(--modal-animation-duration, 0.2s) ease-out;
+}
+
+.row-delete-dialog .modal-header {
+    padding: 20px 24px 12px;
+    border-bottom: 1px solid var(--rule);
+    display: flex;
+    align-items: center;
+    justify-content: flex-start;
+    gap: 12px;
+    flex-shrink: 0;
+}
+
+.row-delete-dialog .modal-title {
+    font-size: 1rem;
+    font-weight: 600;
+    color: var(--ink);
+}
+
+.row-delete-message,
+.row-delete-error {
+    margin: 0;
+    padding: 16px 24px 0;
+}
+
+.row-delete-message {
+    color: var(--ink);
+    font-size: 0.95rem;
+}
+
+.row-delete-id {
+    display: inline;
+    padding: 2px 5px;
+    border: 1px solid var(--rule);
+    border-radius: 4px;
+    background: var(--paper);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.92em;
+    overflow-wrap: anywhere;
+}
+
+.row-delete-error {
+    color: #b91c1c;
+    font-size: 0.9rem;
+}
+
+.row-delete-dialog .modal-footer {
+    padding: 18px 20px 14px;
+    border-top: 1px solid var(--rule);
+    display: flex;
+    align-items: center;
+    justify-content: flex-end;
+    gap: 10px;
+    flex-shrink: 0;
+    background: var(--paper);
+    margin-top: 18px;
+}
+
+.row-delete-dialog .btn {
+    border: none;
+    border-radius: 5px;
+    padding: 9px 20px;
+    font-size: 0.85rem;
+    font-weight: 500;
+    cursor: pointer;
+    touch-action: manipulation;
+    font-family: inherit;
+    transition: background 0.12s;
+}
+
+.row-delete-dialog .btn-ghost {
+    background: transparent;
+    color: var(--muted);
+    border: 1px solid var(--rule);
+}
+
+.row-delete-dialog .btn-ghost:hover {
+    background: var(--rule);
+    color: var(--ink);
+}
+
+.row-delete-dialog .btn-primary {
+    background: var(--accent);
+    color: #fff;
+}
+
+.row-delete-dialog .btn-primary:hover {
+    background: #1949b8;
+}
+
+.row-delete-dialog .btn:disabled {
+    opacity: 0.65;
+    cursor: wait;
+}
+
 .row-link-with-actions {
     display: inline-flex;
     align-items: center;
@@ -1284,6 +1425,24 @@ dialog.set-column-type-dialog::backdrop {
         padding-right: 18px;
     }
 
+    dialog.row-delete-dialog {
+        width: 95vw;
+        max-height: 85vh;
+        border-radius: 0.5rem;
+    }
+
+    .row-delete-dialog .modal-header,
+    .row-delete-message,
+    .row-delete-error {
+        padding-left: 18px;
+        padding-right: 18px;
+    }
+
+    .row-delete-dialog .modal-footer {
+        padding-left: 18px;
+        padding-right: 18px;
+    }
+
     .row-inline-action {
         min-height: 30px;
         min-width: 30px;
diff --git a/datasette/static/table.js b/datasette/static/table.js
index e9115453..cd69f474 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -12,6 +12,8 @@ var DROPDOWN_ICON_SVG = `<svg xmlns="http://www.w3.org/2000/svg" width="14" heig
 
 var SET_COLUMN_TYPE_DIALOG_ID = "set-column-type-dialog";
 var setColumnTypeDialogState = null;
+var ROW_DELETE_DIALOG_ID = "row-delete-dialog";
+var rowDeleteDialogState = null;
 
 function getParams() {
   return new URLSearchParams(location.search);
@@ -355,6 +357,276 @@ function openSetColumnTypeDialog(th) {
   }
 }
 
+function ensureRowDeleteStatus(manager) {
+  var status = document.querySelector(".row-delete-status");
+  if (status) {
+    return status;
+  }
+
+  status = document.createElement("p");
+  status.className = "row-delete-status";
+  status.hidden = true;
+  status.setAttribute("role", "status");
+  status.setAttribute("aria-live", "polite");
+  status.setAttribute("tabindex", "-1");
+
+  var tableWrapper = document.querySelector(manager.selectors.tableWrapper);
+  if (tableWrapper && tableWrapper.parentNode) {
+    tableWrapper.parentNode.insertBefore(status, tableWrapper);
+  } else {
+    document.body.appendChild(status);
+  }
+  return status;
+}
+
+function showRowDeleteStatus(manager, message, isError) {
+  var status = ensureRowDeleteStatus(manager);
+  status.hidden = false;
+  status.classList.toggle("row-delete-status-error", !!isError);
+  status.textContent = message;
+  return status;
+}
+
+function setRowDeleteDialogBusy(state, isBusy) {
+  state.isBusy = isBusy;
+  state.confirmButton.disabled = isBusy;
+  state.cancelButton.disabled = isBusy;
+  state.confirmButton.textContent = isBusy ? "Deleting..." : "Delete row";
+}
+
+function clearRowDeleteDialogError(state) {
+  state.error.hidden = true;
+  state.error.textContent = "";
+}
+
+function showRowDeleteDialogError(state, message) {
+  state.error.hidden = false;
+  state.error.textContent = message;
+}
+
+function rowDeleteRequestError(response, data) {
+  if (data && data.errors) {
+    return new Error(data.errors.join(" "));
+  }
+  if (data && data.error) {
+    return new Error(data.error);
+  }
+  if (data && data.title) {
+    return new Error(data.title);
+  }
+  return new Error("Delete failed with HTTP " + response.status);
+}
+
+function nextRowDeleteFocusTarget(row, manager) {
+  var sibling = row.nextElementSibling;
+  while (sibling) {
+    var nextButton = sibling.querySelector(
+      'button[data-row-action="delete"]:not([disabled])',
+    );
+    if (nextButton) {
+      return nextButton;
+    }
+    sibling = sibling.nextElementSibling;
+  }
+
+  sibling = row.previousElementSibling;
+  while (sibling) {
+    var previousButton = sibling.querySelector(
+      'button[data-row-action="delete"]:not([disabled])',
+    );
+    if (previousButton) {
+      return previousButton;
+    }
+    sibling = sibling.previousElementSibling;
+  }
+
+  return ensureRowDeleteStatus(manager);
+}
+
+function ensureRowDeleteDialog(manager) {
+  if (rowDeleteDialogState) {
+    return rowDeleteDialogState;
+  }
+  if (!window.HTMLDialogElement) {
+    return null;
+  }
+
+  var dialog = document.createElement("dialog");
+  dialog.id = ROW_DELETE_DIALOG_ID;
+  dialog.className = "row-delete-dialog";
+  dialog.setAttribute("aria-labelledby", "row-delete-title");
+  dialog.setAttribute("aria-describedby", "row-delete-message");
+  dialog.innerHTML = `
+    <div class="modal-header">
+      <span class="modal-title" id="row-delete-title">Delete row</span>
+    </div>
+    <p class="row-delete-message" id="row-delete-message">Delete row <span class="row-delete-id"></span>?</p>
+    <p class="row-delete-error" role="alert" hidden></p>
+    <div class="modal-footer">
+      <button type="button" class="btn btn-ghost row-delete-cancel">Cancel</button>
+      <button type="button" class="btn btn-primary row-delete-confirm">Delete row</button>
+    </div>
+  `;
+  document.body.appendChild(dialog);
+
+  rowDeleteDialogState = {
+    dialog: dialog,
+    message: dialog.querySelector(".row-delete-message"),
+    rowId: dialog.querySelector(".row-delete-id"),
+    error: dialog.querySelector(".row-delete-error"),
+    cancelButton: dialog.querySelector(".row-delete-cancel"),
+    confirmButton: dialog.querySelector(".row-delete-confirm"),
+    currentRow: null,
+    currentDeleteUrl: null,
+    currentPkPath: null,
+    manager: manager,
+    isBusy: false,
+    shouldRestoreFocus: true,
+  };
+
+  rowDeleteDialogState.cancelButton.addEventListener("click", function () {
+    if (!rowDeleteDialogState.isBusy) {
+      rowDeleteDialogState.shouldRestoreFocus = true;
+      dialog.close();
+    }
+  });
+
+  dialog.addEventListener("click", function (ev) {
+    if (ev.target === dialog && !rowDeleteDialogState.isBusy) {
+      rowDeleteDialogState.shouldRestoreFocus = true;
+      dialog.close();
+    }
+  });
+
+  dialog.addEventListener("keydown", function (ev) {
+    if (
+      ev.key === "Enter" &&
+      document.activeElement === rowDeleteDialogState.confirmButton
+    ) {
+      ev.preventDefault();
+      if (!rowDeleteDialogState.isBusy) {
+        rowDeleteDialogState.confirmButton.click();
+      }
+      return;
+    }
+    if (ev.key !== "Escape") {
+      return;
+    }
+    if (rowDeleteDialogState.isBusy) {
+      ev.preventDefault();
+      return;
+    }
+    ev.preventDefault();
+    rowDeleteDialogState.shouldRestoreFocus = true;
+    dialog.close();
+  });
+
+  dialog.addEventListener("cancel", function (ev) {
+    if (rowDeleteDialogState.isBusy) {
+      ev.preventDefault();
+    } else {
+      rowDeleteDialogState.shouldRestoreFocus = true;
+    }
+  });
+
+  dialog.addEventListener("close", function () {
+    var state = rowDeleteDialogState;
+    clearRowDeleteDialogError(state);
+    setRowDeleteDialogBusy(state, false);
+    if (
+      state.shouldRestoreFocus &&
+      state.currentButton &&
+      document.contains(state.currentButton)
+    ) {
+      state.currentButton.focus();
+    }
+  });
+
+  rowDeleteDialogState.confirmButton.addEventListener("click", async function () {
+    var state = rowDeleteDialogState;
+    clearRowDeleteDialogError(state);
+    setRowDeleteDialogBusy(state, true);
+
+    try {
+      var response = await fetch(state.currentDeleteUrl, {
+        method: "POST",
+        headers: {
+          Accept: "application/json",
+        },
+      });
+      var data = null;
+      try {
+        data = await response.json();
+      } catch (_error) {
+        data = null;
+      }
+      if (!response.ok || (data && data.ok === false)) {
+        throw rowDeleteRequestError(response, data);
+      }
+
+      var focusTarget = nextRowDeleteFocusTarget(state.currentRow, state.manager);
+      var statusMessage = state.currentPkPath
+        ? "Deleted row " + state.currentPkPath + "."
+        : "Deleted row.";
+      state.shouldRestoreFocus = false;
+      state.dialog.close();
+      state.currentRow.remove();
+      showRowDeleteStatus(state.manager, statusMessage, false);
+      if (focusTarget && document.contains(focusTarget)) {
+        focusTarget.focus();
+      } else {
+        ensureRowDeleteStatus(state.manager).focus();
+      }
+    } catch (error) {
+      setRowDeleteDialogBusy(state, false);
+      showRowDeleteDialogError(state, error.message || "Delete failed");
+    }
+  });
+
+  return rowDeleteDialogState;
+}
+
+function openRowDeleteDialog(button, manager) {
+  var row = button.closest("tr[data-row-delete-url]");
+  if (!row || !row.dataset.rowDeleteUrl) {
+    return;
+  }
+  var state = ensureRowDeleteDialog(manager);
+  if (!state) {
+    return;
+  }
+
+  state.manager = manager;
+  state.currentButton = button;
+  state.currentRow = row;
+  state.currentDeleteUrl = row.dataset.rowDeleteUrl;
+  state.currentPkPath = row.dataset.rowPkPath || "";
+  state.shouldRestoreFocus = true;
+
+  clearRowDeleteDialogError(state);
+  setRowDeleteDialogBusy(state, false);
+  state.rowId.textContent = state.currentPkPath || "this row";
+
+  if (!state.dialog.open) {
+    state.dialog.showModal();
+  }
+  state.confirmButton.focus();
+}
+
+function initRowDeleteActions(manager) {
+  if (!window.fetch || !window.HTMLDialogElement) {
+    return;
+  }
+  document.addEventListener("click", function (ev) {
+    var button = ev.target.closest('button[data-row-action="delete"]');
+    if (!button) {
+      return;
+    }
+    ev.preventDefault();
+    openRowDeleteDialog(button, manager);
+  });
+}
+
 function canChooseColumns() {
   return !!(
     document.querySelector("column-chooser") && window._columnChooserData
@@ -750,6 +1022,7 @@ document.addEventListener("datasette_init", function (evt) {
 
   // Main table
   initDatasetteTable(manager);
+  initRowDeleteActions(manager);
 
   // Other UI functions with interactive JS needs
   addButtonsToFilterRows(manager);
diff --git a/datasette/templates/_table.html b/datasette/templates/_table.html
index f47a325f..36b0ef7e 100644
--- a/datasette/templates/_table.html
+++ b/datasette/templates/_table.html
@@ -22,7 +22,7 @@
         </thead>
         <tbody>
         {% for row in display_rows %}
-            <tr>
+            <tr{% if row.pk_path is not none %} data-row-pk-path="{{ row.pk_path }}" data-row-path="{{ row.row_path }}" data-row-url="{{ row.row_url }}" data-row-delete-url="{{ row.delete_url }}"{% endif %}>
                 {% for cell in row %}
                     <td class="col-{{ cell.column|to_css_class }} type-{{ cell.value_type }}">{{ cell.value }}</td>
                 {% endfor %}
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 49238ff4..f1d4ea45 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -59,8 +59,19 @@ LINK_WITH_VALUE = '<a href="{base_url}{database}/{table}/{link_id}">{id}</a>'
 
 
 class Row:
-    def __init__(self, cells):
+    def __init__(
+        self,
+        cells,
+        pk_path=None,
+        row_path=None,
+        row_url=None,
+        delete_url=None,
+    ):
         self.cells = cells
+        self.pk_path = pk_path
+        self.row_path = row_path
+        self.row_url = row_url
+        self.delete_url = delete_url
 
     def __iter__(self):
         return iter(self.cells)
@@ -241,8 +252,14 @@ async def display_columns_and_rows(
             is_special_link_column = len(pks) != 1
             pk_path = path_from_row_pks(row, pks, not pks, False)
             row_path = path_from_row_pks(row, pks, not pks)
+            table_path = datasette.urls.table(database_name, table_name)
+            row_url = "{table_path}/{row_path}".format(
+                table_path=table_path,
+                row_path=row_path,
+            )
+            delete_url = "{row_url}/-/delete".format(row_url=row_url)
             row_link = '<a href="{table_path}/{flat_pks_quoted}">{flat_pks}</a>'.format(
-                table_path=datasette.urls.table(database_name, table_name),
+                table_path=table_path,
                 flat_pks=str(markupsafe.escape(pk_path)),
                 flat_pks_quoted=row_path,
             )
@@ -280,7 +297,8 @@ async def display_columns_and_rows(
             if row_action_permissions.get("delete-row"):
                 row_actions.append(
                     '<button type="button" class="row-inline-action row-inline-action-delete" '
-                    'aria-label="Delete row {row_label}" title="Delete row">'
+                    'aria-label="Delete row {row_label}" title="Delete row" '
+                    'data-row-action="delete">'
                     "{delete_icon}</button>".format(
                         delete_icon=delete_icon,
                         row_label=markupsafe.escape(pk_path),
@@ -404,7 +422,18 @@ async def display_columns_and_rows(
                     ),
                 }
             )
-        cell_rows.append(Row(cells))
+        if link_column:
+            cell_rows.append(
+                Row(
+                    cells,
+                    pk_path=pk_path,
+                    row_path=row_path,
+                    row_url=row_url,
+                    delete_url=delete_url,
+                )
+            )
+        else:
+            cell_rows.append(Row(cells))
 
     if link_column:
         # Add the link column header.
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 63e233fa..14d463ae 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1,4 +1,5 @@
 from datasette.app import Datasette
+from datasette.database import Database
 from bs4 import BeautifulSoup as Soup
 from .fixtures import make_app_client
 import pathlib
@@ -828,6 +829,52 @@ async def test_mobile_column_actions_present(ds_client, path):
     assert len(ths) >= 1
 
 
+@pytest.mark.asyncio
+async def test_row_delete_action_data_attributes():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "tables": {
+                        "items": {
+                            "permissions": {
+                                "delete-row": {"id": "root"},
+                            },
+                        },
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_row_delete_actions"), name="data"
+        )
+        await db.execute_write_script("""
+            create table items (id integer primary key, name text);
+            insert into items (id, name) values (1, 'One');
+            """)
+        response = await ds.client.get("/data/items", actor={"id": "root"})
+        assert response.status_code == 200
+        soup = Soup(response.text, "html.parser")
+        row = soup.select_one("table.rows-and-columns tbody tr")
+        assert row["data-row-pk-path"] == "1"
+        assert row["data-row-path"] == "1"
+        assert row["data-row-url"] == "/data/items/1"
+        assert row["data-row-delete-url"] == "/data/items/1/-/delete"
+
+        button = row.select_one(
+            'button.row-inline-action-delete[data-row-action="delete"]'
+        )
+        assert button is not None
+        assert button["aria-label"] == "Delete row 1"
+        assert button["title"] == "Delete row"
+        assert button.find("svg") is not None
+    finally:
+        ds.close()
+
+
 @pytest.mark.asyncio
 async def test_zero_row_table_renders_thead(ds_client):
     response = await ds_client.get("/fixtures/123_starts_with_digits")

From ad3456dc4af9f574c3c34f79951bf087bff7ffb0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 14:48:44 -0700
Subject: [PATCH 192/386] Display of edit modal (no save yet)

---
 datasette/static/app.css        | 226 +++++++++++++++++++++++++
 datasette/static/table.js       | 287 ++++++++++++++++++++++++++++++++
 datasette/templates/_table.html |   2 +-
 datasette/views/table.py        |   7 +-
 tests/test_table_html.py        |  10 ++
 5 files changed, 530 insertions(+), 2 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 36335146..5c92d59c 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1333,6 +1333,199 @@ dialog.row-delete-dialog::backdrop {
     cursor: wait;
 }
 
+dialog.row-edit-dialog {
+    --ink: #0f0f0f;
+    --paper: #f5f3ef;
+    --muted: #6b6b6b;
+    --rule: #e2dfd8;
+    --accent: #1a56db;
+    --card: #ffffff;
+    border: none;
+    border-radius: var(--modal-border-radius, 0.75rem);
+    padding: 0;
+    margin: auto;
+    width: min(720px, calc(100vw - 32px));
+    max-width: 95vw;
+    max-height: min(780px, calc(100vh - 32px));
+    box-shadow: var(--modal-shadow, 0 20px 25px -5px rgba(0, 0, 0, 0.1), 0 10px 10px -5px rgba(0, 0, 0, 0.04));
+    animation: datasette-modal-slide-in var(--modal-animation-duration, 0.2s) ease-out;
+    overflow: hidden;
+    font-family: system-ui, -apple-system, sans-serif;
+    background: var(--card);
+}
+
+dialog.row-edit-dialog[open] {
+    display: flex;
+    flex-direction: column;
+}
+
+dialog.row-edit-dialog::backdrop {
+    background: var(--modal-backdrop-bg, rgba(0, 0, 0, 0.5));
+    backdrop-filter: var(--modal-backdrop-blur, blur(4px));
+    -webkit-backdrop-filter: var(--modal-backdrop-blur, blur(4px));
+    animation: datasette-modal-fade-in var(--modal-animation-duration, 0.2s) ease-out;
+}
+
+.row-edit-dialog .modal-header {
+    padding: 20px 24px 12px;
+    border-bottom: 1px solid var(--rule);
+    display: flex;
+    align-items: center;
+    gap: 12px;
+    flex-shrink: 0;
+}
+
+.row-edit-dialog .modal-title {
+    font-size: 1rem;
+    font-weight: 600;
+    color: var(--ink);
+}
+
+.row-edit-form {
+    display: flex;
+    flex: 1 1 auto;
+    min-height: 0;
+    flex-direction: column;
+}
+
+.row-edit-summary,
+.row-edit-loading,
+.row-edit-error {
+    margin: 0;
+    padding: 12px 24px 0;
+}
+
+.row-edit-summary,
+.row-edit-loading {
+    color: var(--muted);
+    font-size: 0.9rem;
+}
+
+.row-edit-id {
+    display: inline;
+    padding: 2px 5px;
+    border: 1px solid var(--rule);
+    border-radius: 4px;
+    background: var(--paper);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.92em;
+    overflow-wrap: anywhere;
+}
+
+.row-edit-error {
+    color: #b91c1c;
+    font-size: 0.9rem;
+}
+
+.row-edit-fields {
+    display: grid;
+    gap: 14px;
+    padding: 16px 24px 24px;
+    overflow-y: auto;
+}
+
+.row-edit-field {
+    display: grid;
+    grid-template-columns: minmax(120px, 180px) minmax(0, 1fr);
+    gap: 12px;
+    align-items: start;
+}
+
+.row-edit-label {
+    padding-top: 8px;
+    color: var(--ink);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.82rem;
+    overflow-wrap: anywhere;
+}
+
+.row-edit-control-wrap {
+    display: grid;
+    gap: 5px;
+}
+
+.row-edit-input {
+    box-sizing: border-box;
+    width: 100%;
+    min-width: 0;
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    padding: 8px 10px;
+    color: var(--ink);
+    background: #fff;
+    font: inherit;
+}
+
+textarea.row-edit-input {
+    resize: vertical;
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.82rem;
+    line-height: 1.45;
+}
+
+.row-edit-input:focus {
+    border-color: var(--accent);
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+}
+
+.row-edit-input[readonly] {
+    color: var(--muted);
+    background: var(--paper);
+}
+
+.row-edit-field-meta {
+    color: var(--muted);
+    font-size: 0.78rem;
+}
+
+.row-edit-dialog .modal-footer {
+    padding: 14px 20px;
+    border-top: 1px solid var(--rule);
+    display: flex;
+    align-items: center;
+    justify-content: flex-end;
+    gap: 10px;
+    flex-shrink: 0;
+    background: var(--paper);
+}
+
+.row-edit-dialog .btn {
+    border: none;
+    border-radius: 5px;
+    padding: 9px 20px;
+    font-size: 0.85rem;
+    font-weight: 500;
+    cursor: pointer;
+    touch-action: manipulation;
+    font-family: inherit;
+    transition: background 0.12s;
+}
+
+.row-edit-dialog .btn-ghost {
+    background: transparent;
+    color: var(--muted);
+    border: 1px solid var(--rule);
+}
+
+.row-edit-dialog .btn-ghost:hover {
+    background: var(--rule);
+    color: var(--ink);
+}
+
+.row-edit-dialog .btn-primary {
+    background: var(--accent);
+    color: #fff;
+}
+
+.row-edit-dialog .btn-primary:hover {
+    background: #1949b8;
+}
+
+.row-edit-dialog .btn:disabled {
+    opacity: 0.55;
+    cursor: not-allowed;
+}
+
 .row-link-with-actions {
     display: inline-flex;
     align-items: center;
@@ -1443,6 +1636,35 @@ dialog.row-delete-dialog::backdrop {
         padding-right: 18px;
     }
 
+    dialog.row-edit-dialog {
+        width: 95vw;
+        max-height: 85vh;
+        border-radius: 0.5rem;
+    }
+
+    .row-edit-dialog .modal-header,
+    .row-edit-summary,
+    .row-edit-loading,
+    .row-edit-error,
+    .row-edit-fields {
+        padding-left: 18px;
+        padding-right: 18px;
+    }
+
+    .row-edit-field {
+        grid-template-columns: 1fr;
+        gap: 5px;
+    }
+
+    .row-edit-label {
+        padding-top: 0;
+    }
+
+    .row-edit-dialog .modal-footer {
+        padding-left: 18px;
+        padding-right: 18px;
+    }
+
     .row-inline-action {
         min-height: 30px;
         min-width: 30px;
@@ -1507,6 +1729,10 @@ dialog.row-delete-dialog::backdrop {
         font-size: 0.8em;
     }
 
+    .row-inline-actions {
+        margin-bottom: 0.35rem;
+    }
+
     .select-wrapper {
         width: 100px;
     }
diff --git a/datasette/static/table.js b/datasette/static/table.js
index cd69f474..044c9509 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -14,6 +14,8 @@ var SET_COLUMN_TYPE_DIALOG_ID = "set-column-type-dialog";
 var setColumnTypeDialogState = null;
 var ROW_DELETE_DIALOG_ID = "row-delete-dialog";
 var rowDeleteDialogState = null;
+var ROW_EDIT_DIALOG_ID = "row-edit-dialog";
+var rowEditDialogState = null;
 
 function getParams() {
   return new URLSearchParams(location.search);
@@ -627,6 +629,290 @@ function initRowDeleteActions(manager) {
   });
 }
 
+function rowJsonUrl(row) {
+  var url = new URL(row.dataset.rowUrl, location.href);
+  url.pathname = url.pathname + ".json";
+  url.searchParams.set("_extra", "columns,column_types");
+  return url.toString();
+}
+
+function valueToEditText(value) {
+  if (value === null || typeof value === "undefined") {
+    return "";
+  }
+  if (typeof value === "object") {
+    return JSON.stringify(value, null, 2);
+  }
+  return String(value);
+}
+
+function shouldUseTextarea(value) {
+  if (value && typeof value === "object") {
+    return true;
+  }
+  var text = valueToEditText(value);
+  return text.length > 80 || text.indexOf("\n") !== -1;
+}
+
+function createRowEditField(column, value, isPk, columnType, index) {
+  var field = document.createElement("div");
+  field.className = "row-edit-field";
+
+  var fieldId = "row-edit-field-" + index;
+  var metaId = "row-edit-field-meta-" + index;
+  var label = document.createElement("label");
+  label.className = "row-edit-label";
+  label.setAttribute("for", fieldId);
+  label.textContent = column;
+
+  var controlWrap = document.createElement("div");
+  controlWrap.className = "row-edit-control-wrap";
+
+  var control = shouldUseTextarea(value)
+    ? document.createElement("textarea")
+    : document.createElement("input");
+  control.className = "row-edit-input";
+  control.id = fieldId;
+  control.name = column;
+  control.value = valueToEditText(value);
+  control.setAttribute("aria-describedby", metaId);
+  control.dataset.originalValue = valueToEditText(value);
+
+  if (control.nodeName === "TEXTAREA") {
+    control.rows = Math.min(8, Math.max(3, control.value.split("\n").length));
+  } else {
+    control.type = "text";
+  }
+
+  if (isPk) {
+    control.readOnly = true;
+  }
+
+  var meta = document.createElement("span");
+  meta.id = metaId;
+  meta.className = "row-edit-field-meta";
+  var metaParts = [];
+  if (isPk) {
+    metaParts.push("Primary key");
+  }
+  if (value === null) {
+    metaParts.push("Current value: NULL");
+    control.placeholder = "NULL";
+  }
+  if (columnType && columnType.type) {
+    metaParts.push("Custom type: " + columnType.type);
+  }
+  meta.textContent = metaParts.join(" · ");
+
+  controlWrap.appendChild(control);
+  if (meta.textContent) {
+    controlWrap.appendChild(meta);
+  }
+  field.appendChild(label);
+  field.appendChild(controlWrap);
+  return field;
+}
+
+function clearRowEditDialogError(state) {
+  state.error.hidden = true;
+  state.error.textContent = "";
+}
+
+function showRowEditDialogError(state, message) {
+  state.error.hidden = false;
+  state.error.textContent = message;
+}
+
+function setRowEditDialogLoading(state, isLoading) {
+  state.isLoading = isLoading;
+  state.loading.hidden = !isLoading;
+}
+
+function renderRowEditFields(state, data) {
+  var row = data.rows && data.rows.length ? data.rows[0] : null;
+  var columns = data.columns || (row ? Object.keys(row) : []);
+  var primaryKeys = data.primary_keys || [];
+  var columnTypes = data.column_types || {};
+
+  state.fields.innerHTML = "";
+  columns.forEach(function (column, index) {
+    state.fields.appendChild(
+      createRowEditField(
+        column,
+        row ? row[column] : null,
+        primaryKeys.indexOf(column) !== -1,
+        columnTypes[column],
+        index,
+      ),
+    );
+  });
+
+  var firstEditable = state.fields.querySelector(".row-edit-input:not([readonly])");
+  var firstField = state.fields.querySelector(".row-edit-input");
+  (firstEditable || firstField || state.cancelButton).focus();
+}
+
+function ensureRowEditDialog(manager) {
+  if (rowEditDialogState) {
+    return rowEditDialogState;
+  }
+  if (!window.HTMLDialogElement) {
+    return null;
+  }
+
+  var dialog = document.createElement("dialog");
+  dialog.id = ROW_EDIT_DIALOG_ID;
+  dialog.className = "row-edit-dialog";
+  dialog.setAttribute("aria-labelledby", "row-edit-title");
+  dialog.setAttribute("aria-describedby", "row-edit-summary");
+  dialog.innerHTML = `
+    <div class="modal-header">
+      <span class="modal-title" id="row-edit-title">Edit row</span>
+    </div>
+    <form class="row-edit-form">
+      <p class="row-edit-summary" id="row-edit-summary">Editing row <span class="row-edit-id"></span></p>
+      <p class="row-edit-loading">Loading row...</p>
+      <p class="row-edit-error" role="alert" hidden></p>
+      <div class="row-edit-fields"></div>
+      <div class="modal-footer">
+        <button type="button" class="btn btn-ghost row-edit-cancel">Cancel</button>
+        <button type="button" class="btn btn-primary row-edit-save" disabled>Save</button>
+      </div>
+    </form>
+  `;
+  document.body.appendChild(dialog);
+
+  rowEditDialogState = {
+    dialog: dialog,
+    form: dialog.querySelector(".row-edit-form"),
+    rowId: dialog.querySelector(".row-edit-id"),
+    loading: dialog.querySelector(".row-edit-loading"),
+    error: dialog.querySelector(".row-edit-error"),
+    fields: dialog.querySelector(".row-edit-fields"),
+    cancelButton: dialog.querySelector(".row-edit-cancel"),
+    saveButton: dialog.querySelector(".row-edit-save"),
+    currentButton: null,
+    currentRow: null,
+    currentPkPath: null,
+    loadId: 0,
+    manager: manager,
+    isLoading: false,
+    shouldRestoreFocus: true,
+  };
+
+  rowEditDialogState.form.addEventListener("submit", function (ev) {
+    ev.preventDefault();
+  });
+
+  rowEditDialogState.cancelButton.addEventListener("click", function () {
+    rowEditDialogState.shouldRestoreFocus = true;
+    dialog.close();
+  });
+
+  dialog.addEventListener("click", function (ev) {
+    if (ev.target === dialog) {
+      rowEditDialogState.shouldRestoreFocus = true;
+      dialog.close();
+    }
+  });
+
+  dialog.addEventListener("keydown", function (ev) {
+    if (ev.key !== "Escape") {
+      return;
+    }
+    ev.preventDefault();
+    rowEditDialogState.shouldRestoreFocus = true;
+    dialog.close();
+  });
+
+  dialog.addEventListener("cancel", function () {
+    rowEditDialogState.shouldRestoreFocus = true;
+  });
+
+  dialog.addEventListener("close", function () {
+    var state = rowEditDialogState;
+    state.loadId += 1;
+    clearRowEditDialogError(state);
+    setRowEditDialogLoading(state, false);
+    if (
+      state.shouldRestoreFocus &&
+      state.currentButton &&
+      document.contains(state.currentButton)
+    ) {
+      state.currentButton.focus();
+    }
+  });
+
+  return rowEditDialogState;
+}
+
+async function openRowEditDialog(button, manager) {
+  var row = button.closest("tr[data-row-url]");
+  if (!row || !row.dataset.rowUrl) {
+    return;
+  }
+  var state = ensureRowEditDialog(manager);
+  if (!state) {
+    return;
+  }
+
+  state.manager = manager;
+  state.currentButton = button;
+  state.currentRow = row;
+  state.currentPkPath = row.dataset.rowPkPath || "";
+  state.shouldRestoreFocus = true;
+  state.loadId += 1;
+  var loadId = state.loadId;
+
+  clearRowEditDialogError(state);
+  setRowEditDialogLoading(state, true);
+  state.fields.innerHTML = "";
+  state.rowId.textContent = state.currentPkPath || "this row";
+
+  if (!state.dialog.open) {
+    state.dialog.showModal();
+  }
+  state.cancelButton.focus();
+
+  try {
+    var response = await fetch(rowJsonUrl(row), {
+      headers: {
+        Accept: "application/json",
+      },
+    });
+    var data = await response.json();
+    if (loadId !== state.loadId) {
+      return;
+    }
+    if (!response.ok || data.ok === false) {
+      throw rowDeleteRequestError(response, data);
+    }
+    setRowEditDialogLoading(state, false);
+    renderRowEditFields(state, data);
+  } catch (error) {
+    if (loadId !== state.loadId) {
+      return;
+    }
+    setRowEditDialogLoading(state, false);
+    showRowEditDialogError(state, error.message || "Could not load row");
+    state.cancelButton.focus();
+  }
+}
+
+function initRowEditActions(manager) {
+  if (!window.fetch || !window.HTMLDialogElement) {
+    return;
+  }
+  document.addEventListener("click", function (ev) {
+    var button = ev.target.closest('button[data-row-action="edit"]');
+    if (!button) {
+      return;
+    }
+    ev.preventDefault();
+    openRowEditDialog(button, manager);
+  });
+}
+
 function canChooseColumns() {
   return !!(
     document.querySelector("column-chooser") && window._columnChooserData
@@ -1022,6 +1308,7 @@ document.addEventListener("datasette_init", function (evt) {
 
   // Main table
   initDatasetteTable(manager);
+  initRowEditActions(manager);
   initRowDeleteActions(manager);
 
   // Other UI functions with interactive JS needs
diff --git a/datasette/templates/_table.html b/datasette/templates/_table.html
index 36b0ef7e..2ecf5cc2 100644
--- a/datasette/templates/_table.html
+++ b/datasette/templates/_table.html
@@ -22,7 +22,7 @@
         </thead>
         <tbody>
         {% for row in display_rows %}
-            <tr{% if row.pk_path is not none %} data-row-pk-path="{{ row.pk_path }}" data-row-path="{{ row.row_path }}" data-row-url="{{ row.row_url }}" data-row-delete-url="{{ row.delete_url }}"{% endif %}>
+            <tr{% if row.pk_path is not none %} data-row-pk-path="{{ row.pk_path }}" data-row-path="{{ row.row_path }}" data-row-url="{{ row.row_url }}" data-row-delete-url="{{ row.delete_url }}" data-row-update-url="{{ row.update_url }}"{% endif %}>
                 {% for cell in row %}
                     <td class="col-{{ cell.column|to_css_class }} type-{{ cell.value_type }}">{{ cell.value }}</td>
                 {% endfor %}
diff --git a/datasette/views/table.py b/datasette/views/table.py
index f1d4ea45..cd6a016a 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -66,12 +66,14 @@ class Row:
         row_path=None,
         row_url=None,
         delete_url=None,
+        update_url=None,
     ):
         self.cells = cells
         self.pk_path = pk_path
         self.row_path = row_path
         self.row_url = row_url
         self.delete_url = delete_url
+        self.update_url = update_url
 
     def __iter__(self):
         return iter(self.cells)
@@ -258,6 +260,7 @@ async def display_columns_and_rows(
                 row_path=row_path,
             )
             delete_url = "{row_url}/-/delete".format(row_url=row_url)
+            update_url = "{row_url}/-/update".format(row_url=row_url)
             row_link = '<a href="{table_path}/{flat_pks_quoted}">{flat_pks}</a>'.format(
                 table_path=table_path,
                 flat_pks=str(markupsafe.escape(pk_path)),
@@ -288,7 +291,8 @@ async def display_columns_and_rows(
             if row_action_permissions.get("update-row"):
                 row_actions.append(
                     '<button type="button" class="row-inline-action row-inline-action-edit" '
-                    'aria-label="Edit row {row_label}" title="Edit row">'
+                    'aria-label="Edit row {row_label}" title="Edit row" '
+                    'data-row-action="edit">'
                     "{edit_icon}</button>".format(
                         edit_icon=edit_icon,
                         row_label=markupsafe.escape(pk_path),
@@ -430,6 +434,7 @@ async def display_columns_and_rows(
                     row_path=row_path,
                     row_url=row_url,
                     delete_url=delete_url,
+                    update_url=update_url,
                 )
             )
         else:
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 14d463ae..6be6942d 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -839,6 +839,7 @@ async def test_row_delete_action_data_attributes():
                     "tables": {
                         "items": {
                             "permissions": {
+                                "update-row": {"id": "root"},
                                 "delete-row": {"id": "root"},
                             },
                         },
@@ -863,6 +864,15 @@ async def test_row_delete_action_data_attributes():
         assert row["data-row-path"] == "1"
         assert row["data-row-url"] == "/data/items/1"
         assert row["data-row-delete-url"] == "/data/items/1/-/delete"
+        assert row["data-row-update-url"] == "/data/items/1/-/update"
+
+        edit_button = row.select_one(
+            'button.row-inline-action-edit[data-row-action="edit"]'
+        )
+        assert edit_button is not None
+        assert edit_button["aria-label"] == "Edit row 1"
+        assert edit_button["title"] == "Edit row"
+        assert edit_button.find("svg") is not None
 
         button = row.select_one(
             'button.row-inline-action-delete[data-row-action="delete"]'

From e50d176722e572230cf105072e08b41dfc50bf00 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 18:41:00 -0700
Subject: [PATCH 193/386] Add in-place table row edit and delete UI

Use a compact data-row attribute on table row fragments and derive row API URLs in JavaScript from a page-level table URL. Add a /-/fragment endpoint so edited rows can be re-rendered with the active table template and render_cell hooks, then replaced in place after a successful save.

Document the custom _table.html data-row contract and cover the fragment endpoint, base_url handling, and row markup with tests.
---
 datasette/app.py                |   5 +
 datasette/static/app.css        |  24 ++-
 datasette/static/table.js       | 368 ++++++++++++++++++++++++++++----
 datasette/templates/_table.html |   2 +-
 datasette/templates/table.html  |   1 +
 datasette/views/table.py        | 115 ++++++++--
 docs/custom_templates.rst       |   9 +-
 tests/test_table_html.py        | 118 +++++++++-
 8 files changed, 571 insertions(+), 71 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 4931f486..4d7f483a 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -86,6 +86,7 @@ from .views.table import (
     TableUpsertView,
     TableSetColumnTypeView,
     TableDropView,
+    TableFragmentView,
     table_view,
 )
 from .views.row import RowView, RowDeleteView, RowUpdateView
@@ -2614,6 +2615,10 @@ class Datasette:
             TableSetColumnTypeView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/set-column-type$",
         )
+        add_route(
+            TableFragmentView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/fragment$",
+        )
         add_route(
             TableDropView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/drop$",
diff --git a/datasette/static/app.css b/datasette/static/app.css
index 5c92d59c..aca39e58 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1192,7 +1192,7 @@ dialog.set-column-type-dialog::backdrop {
     cursor: wait;
 }
 
-.row-delete-status {
+.row-mutation-status {
     margin: 0 0 0.75rem;
     padding: 8px 10px;
     border-left: 4px solid #54AC8E;
@@ -1200,11 +1200,11 @@ dialog.set-column-type-dialog::backdrop {
     color: #222;
 }
 
-.row-delete-status[hidden] {
+.row-mutation-status[hidden] {
     display: none;
 }
 
-.row-delete-status-error {
+.row-mutation-status-error {
     border-left-color: #D0021B;
     background: rgba(208,2,27,0.12);
 }
@@ -1413,8 +1413,18 @@ dialog.row-edit-dialog::backdrop {
 }
 
 .row-edit-error {
-    color: #b91c1c;
+    border-left: 4px solid #b91c1c;
+    border-radius: 4px;
+    background: #fff1f1;
+    color: #7f1d1d;
     font-size: 0.9rem;
+    margin: 12px 24px 0;
+    padding: 10px 12px;
+}
+
+.row-edit-error:focus {
+    outline: 3px solid rgba(185, 28, 28, 0.18);
+    outline-offset: 2px;
 }
 
 .row-edit-fields {
@@ -1645,12 +1655,16 @@ textarea.row-edit-input {
     .row-edit-dialog .modal-header,
     .row-edit-summary,
     .row-edit-loading,
-    .row-edit-error,
     .row-edit-fields {
         padding-left: 18px;
         padding-right: 18px;
     }
 
+    .row-edit-error {
+        margin-left: 18px;
+        margin-right: 18px;
+    }
+
     .row-edit-field {
         grid-template-columns: 1fr;
         gap: 5px;
diff --git a/datasette/static/table.js b/datasette/static/table.js
index 044c9509..1ae2f30d 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -359,14 +359,14 @@ function openSetColumnTypeDialog(th) {
   }
 }
 
-function ensureRowDeleteStatus(manager) {
-  var status = document.querySelector(".row-delete-status");
+function ensureRowMutationStatus(manager) {
+  var status = document.querySelector(".row-mutation-status");
   if (status) {
     return status;
   }
 
   status = document.createElement("p");
-  status.className = "row-delete-status";
+  status.className = "row-mutation-status";
   status.hidden = true;
   status.setAttribute("role", "status");
   status.setAttribute("aria-live", "polite");
@@ -381,10 +381,10 @@ function ensureRowDeleteStatus(manager) {
   return status;
 }
 
-function showRowDeleteStatus(manager, message, isError) {
-  var status = ensureRowDeleteStatus(manager);
+function showRowMutationStatus(manager, message, isError) {
+  var status = ensureRowMutationStatus(manager);
   status.hidden = false;
-  status.classList.toggle("row-delete-status-error", !!isError);
+  status.classList.toggle("row-mutation-status-error", !!isError);
   status.textContent = message;
   return status;
 }
@@ -406,7 +406,7 @@ function showRowDeleteDialogError(state, message) {
   state.error.textContent = message;
 }
 
-function rowDeleteRequestError(response, data) {
+function rowMutationRequestError(response, data) {
   if (data && data.errors) {
     return new Error(data.errors.join(" "));
   }
@@ -416,15 +416,98 @@ function rowDeleteRequestError(response, data) {
   if (data && data.title) {
     return new Error(data.title);
   }
-  return new Error("Delete failed with HTTP " + response.status);
+  return new Error("Request failed with HTTP " + response.status);
 }
 
-function nextRowDeleteFocusTarget(row, manager) {
+function tildeDecode(value) {
+  if (!value) {
+    return "";
+  }
+  var placeholder = "__datasette_percent_placeholder__";
+  try {
+    return decodeURIComponent(
+      value
+        .replace(/%/g, placeholder)
+        .replace(/~/g, "%")
+        .replace(/\+/g, " "),
+    ).replace(new RegExp(placeholder, "g"), "%");
+  } catch (_error) {
+    return value;
+  }
+}
+
+function rowDisplayLabel(row) {
+  return tildeDecode(row.getAttribute("data-row") || "");
+}
+
+function tableBaseUrl() {
+  var tableUrl =
+    window._datasetteTableData && window._datasetteTableData.tableUrl;
+  var url = new URL(tableUrl || location.href, location.href);
+  url.hash = "";
+  url.search = "";
+  return url;
+}
+
+function rowResourceUrl(row) {
+  var rowId = row.getAttribute("data-row");
+  if (!rowId) {
+    return null;
+  }
+  var url = tableBaseUrl();
+  url.pathname = url.pathname.replace(/\/$/, "") + "/" + rowId;
+  return url;
+}
+
+function rowJsonUrl(row) {
+  var url = rowResourceUrl(row);
+  if (!url) {
+    return "";
+  }
+  url.pathname = url.pathname + ".json";
+  url.searchParams.set("_extra", "columns,column_types");
+  return url.toString();
+}
+
+function rowDeleteUrl(row) {
+  var url = rowResourceUrl(row);
+  if (!url) {
+    return "";
+  }
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/delete";
+  return url.toString();
+}
+
+function rowUpdateUrl(row) {
+  var url = rowResourceUrl(row);
+  if (!url) {
+    return "";
+  }
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/update";
+  return url.toString();
+}
+
+function rowFragmentUrl(row) {
+  var rowId = row.getAttribute("data-row");
+  if (!rowId) {
+    return "";
+  }
+  var url = tableBaseUrl();
+  url.search = new URL(location.href).search;
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/fragment";
+  url.searchParams.delete("_next");
+  url.searchParams.set("_row", rowId);
+  url.searchParams.set("_nocount", "1");
+  url.searchParams.set("_nofacet", "1");
+  url.searchParams.set("_nosuggest", "1");
+  return url.toString();
+}
+
+function nextRowActionFocusTarget(row, action) {
+  var selector = 'button[data-row-action="' + action + '"]:not([disabled])';
   var sibling = row.nextElementSibling;
   while (sibling) {
-    var nextButton = sibling.querySelector(
-      'button[data-row-action="delete"]:not([disabled])',
-    );
+    var nextButton = sibling.querySelector(selector);
     if (nextButton) {
       return nextButton;
     }
@@ -433,16 +516,18 @@ function nextRowDeleteFocusTarget(row, manager) {
 
   sibling = row.previousElementSibling;
   while (sibling) {
-    var previousButton = sibling.querySelector(
-      'button[data-row-action="delete"]:not([disabled])',
-    );
+    var previousButton = sibling.querySelector(selector);
     if (previousButton) {
       return previousButton;
     }
     sibling = sibling.previousElementSibling;
   }
 
-  return ensureRowDeleteStatus(manager);
+  return null;
+}
+
+function nextRowDeleteFocusTarget(row, manager) {
+  return nextRowActionFocusTarget(row, "delete") || ensureRowMutationStatus(manager);
 }
 
 function ensureRowDeleteDialog(manager) {
@@ -563,7 +648,7 @@ function ensureRowDeleteDialog(manager) {
         data = null;
       }
       if (!response.ok || (data && data.ok === false)) {
-        throw rowDeleteRequestError(response, data);
+        throw rowMutationRequestError(response, data);
       }
 
       var focusTarget = nextRowDeleteFocusTarget(state.currentRow, state.manager);
@@ -573,11 +658,11 @@ function ensureRowDeleteDialog(manager) {
       state.shouldRestoreFocus = false;
       state.dialog.close();
       state.currentRow.remove();
-      showRowDeleteStatus(state.manager, statusMessage, false);
+      showRowMutationStatus(state.manager, statusMessage, false);
       if (focusTarget && document.contains(focusTarget)) {
         focusTarget.focus();
       } else {
-        ensureRowDeleteStatus(state.manager).focus();
+        ensureRowMutationStatus(state.manager).focus();
       }
     } catch (error) {
       setRowDeleteDialogBusy(state, false);
@@ -589,8 +674,8 @@ function ensureRowDeleteDialog(manager) {
 }
 
 function openRowDeleteDialog(button, manager) {
-  var row = button.closest("tr[data-row-delete-url]");
-  if (!row || !row.dataset.rowDeleteUrl) {
+  var row = button.closest("[data-row]");
+  if (!row || !row.getAttribute("data-row")) {
     return;
   }
   var state = ensureRowDeleteDialog(manager);
@@ -601,8 +686,8 @@ function openRowDeleteDialog(button, manager) {
   state.manager = manager;
   state.currentButton = button;
   state.currentRow = row;
-  state.currentDeleteUrl = row.dataset.rowDeleteUrl;
-  state.currentPkPath = row.dataset.rowPkPath || "";
+  state.currentDeleteUrl = rowDeleteUrl(row);
+  state.currentPkPath = rowDisplayLabel(row);
   state.shouldRestoreFocus = true;
 
   clearRowDeleteDialogError(state);
@@ -629,13 +714,6 @@ function initRowDeleteActions(manager) {
   });
 }
 
-function rowJsonUrl(row) {
-  var url = new URL(row.dataset.rowUrl, location.href);
-  url.pathname = url.pathname + ".json";
-  url.searchParams.set("_extra", "columns,column_types");
-  return url.toString();
-}
-
 function valueToEditText(value) {
   if (value === null || typeof value === "undefined") {
     return "";
@@ -654,6 +732,22 @@ function shouldUseTextarea(value) {
   return text.length > 80 || text.indexOf("\n") !== -1;
 }
 
+function rowEditValueType(value) {
+  if (value === null || typeof value === "undefined") {
+    return "null";
+  }
+  if (typeof value === "number") {
+    return "number";
+  }
+  if (typeof value === "boolean") {
+    return "boolean";
+  }
+  if (typeof value === "object") {
+    return "json";
+  }
+  return "string";
+}
+
 function createRowEditField(column, value, isPk, columnType, index) {
   var field = document.createElement("div");
   field.className = "row-edit-field";
@@ -677,6 +771,8 @@ function createRowEditField(column, value, isPk, columnType, index) {
   control.value = valueToEditText(value);
   control.setAttribute("aria-describedby", metaId);
   control.dataset.originalValue = valueToEditText(value);
+  control.dataset.originalValueType = rowEditValueType(value);
+  control.dataset.primaryKey = isPk ? "1" : "0";
 
   if (control.nodeName === "TEXTAREA") {
     control.rows = Math.min(8, Math.max(3, control.value.split("\n").length));
@@ -721,11 +817,168 @@ function clearRowEditDialogError(state) {
 function showRowEditDialogError(state, message) {
   state.error.hidden = false;
   state.error.textContent = message;
+  state.error.focus();
+}
+
+function updateRowEditDialogButtons(state) {
+  state.saveButton.disabled = state.isLoading || state.isSaving || !state.hasLoaded;
+  state.cancelButton.disabled = state.isSaving;
+  state.saveButton.textContent = state.isSaving ? "Saving..." : "Save";
+  state.form.setAttribute(
+    "aria-busy",
+    state.isLoading || state.isSaving ? "true" : "false",
+  );
 }
 
 function setRowEditDialogLoading(state, isLoading) {
   state.isLoading = isLoading;
   state.loading.hidden = !isLoading;
+  updateRowEditDialogButtons(state);
+}
+
+function setRowEditDialogSaving(state, isSaving) {
+  state.isSaving = isSaving;
+  updateRowEditDialogButtons(state);
+}
+
+function valueFromRowEditControl(control) {
+  var value = control.value;
+  var trimmed = value.trim();
+  var originalValueType = control.dataset.originalValueType || "string";
+
+  if (originalValueType === "null" && value === "") {
+    return null;
+  }
+  if (originalValueType === "number") {
+    if (trimmed === "") {
+      return null;
+    }
+    var numberValue = Number(trimmed);
+    if (Number.isNaN(numberValue)) {
+      throw new Error(control.name + " must be a number");
+    }
+    return numberValue;
+  }
+  if (originalValueType === "boolean") {
+    if (/^(true|1|yes)$/i.test(trimmed)) {
+      return true;
+    }
+    if (/^(false|0|no)$/i.test(trimmed)) {
+      return false;
+    }
+    throw new Error(control.name + " must be true or false");
+  }
+  if (originalValueType === "json") {
+    if (trimmed === "") {
+      return null;
+    }
+    try {
+      return JSON.parse(value);
+    } catch (_error) {
+      throw new Error(control.name + " must be valid JSON");
+    }
+  }
+  return value;
+}
+
+function collectRowEditUpdate(state) {
+  var update = {};
+  state.fields.querySelectorAll(".row-edit-input").forEach(function (control) {
+    if (control.readOnly || control.dataset.primaryKey === "1") {
+      return;
+    }
+    update[control.name] = valueFromRowEditControl(control);
+  });
+  return update;
+}
+
+function findDataRowElement(root, rowId) {
+  var elements = root.querySelectorAll("[data-row]");
+  for (var i = 0; i < elements.length; i += 1) {
+    if (elements[i].getAttribute("data-row") === rowId) {
+      return elements[i];
+    }
+  }
+  return null;
+}
+
+async function fetchUpdatedRowElement(state) {
+  if (!state.currentFragmentUrl || !state.currentRowId) {
+    return null;
+  }
+  var response = await fetch(state.currentFragmentUrl, {
+    headers: {
+      Accept: "text/html",
+    },
+  });
+  var html = await response.text();
+  if (!response.ok) {
+    throw new Error("Could not refresh row: HTTP " + response.status);
+  }
+  var doc = new DOMParser().parseFromString(html, "text/html");
+  return findDataRowElement(doc, state.currentRowId);
+}
+
+async function saveRowEditDialog(state) {
+  if (state.isLoading || state.isSaving || !state.hasLoaded) {
+    return;
+  }
+  clearRowEditDialogError(state);
+  setRowEditDialogSaving(state, true);
+
+  try {
+    if (!state.currentUpdateUrl) {
+      throw new Error("Could not find the row update URL");
+    }
+    var response = await fetch(state.currentUpdateUrl, {
+      method: "POST",
+      headers: {
+        "Content-Type": "application/json",
+        Accept: "application/json",
+      },
+      body: JSON.stringify({
+        update: collectRowEditUpdate(state),
+        return: true,
+      }),
+    });
+    var data = null;
+    try {
+      data = await response.json();
+    } catch (_error) {
+      data = null;
+    }
+    if (!response.ok || (data && data.ok === false)) {
+      throw rowMutationRequestError(response, data);
+    }
+
+    var updatedRow = await fetchUpdatedRowElement(state);
+    var focusTarget = null;
+    if (updatedRow && state.currentRow && document.contains(state.currentRow)) {
+      var importedRow = document.importNode(updatedRow, true);
+      state.currentRow.replaceWith(importedRow);
+      focusTarget =
+        importedRow.querySelector('button[data-row-action="edit"]') || importedRow;
+    } else if (state.currentRow && document.contains(state.currentRow)) {
+      focusTarget =
+        nextRowActionFocusTarget(state.currentRow, "edit") ||
+        ensureRowMutationStatus(state.manager);
+      state.currentRow.remove();
+      showRowMutationStatus(
+        state.manager,
+        "Saved row. It no longer matches the current filters.",
+        false,
+      );
+    }
+
+    state.shouldRestoreFocus = false;
+    state.dialog.close();
+    if (focusTarget && document.contains(focusTarget)) {
+      focusTarget.focus();
+    }
+  } catch (error) {
+    setRowEditDialogSaving(state, false);
+    showRowEditDialogError(state, error.message || "Could not save row");
+  }
 }
 
 function renderRowEditFields(state, data) {
@@ -747,6 +1000,8 @@ function renderRowEditFields(state, data) {
     );
   });
 
+  state.hasLoaded = true;
+  updateRowEditDialogButtons(state);
   var firstEditable = state.fields.querySelector(".row-edit-input:not([readonly])");
   var firstField = state.fields.querySelector(".row-edit-input");
   (firstEditable || firstField || state.cancelButton).focus();
@@ -769,14 +1024,14 @@ function ensureRowEditDialog(manager) {
     <div class="modal-header">
       <span class="modal-title" id="row-edit-title">Edit row</span>
     </div>
-    <form class="row-edit-form">
+    <form class="row-edit-form" method="post">
       <p class="row-edit-summary" id="row-edit-summary">Editing row <span class="row-edit-id"></span></p>
-      <p class="row-edit-loading">Loading row...</p>
-      <p class="row-edit-error" role="alert" hidden></p>
+      <p class="row-edit-loading" role="status" aria-live="polite">Loading row...</p>
+      <p class="row-edit-error" role="alert" tabindex="-1" hidden></p>
       <div class="row-edit-fields"></div>
       <div class="modal-footer">
         <button type="button" class="btn btn-ghost row-edit-cancel">Cancel</button>
-        <button type="button" class="btn btn-primary row-edit-save" disabled>Save</button>
+        <button type="submit" class="btn btn-primary row-edit-save" disabled>Save</button>
       </div>
     </form>
   `;
@@ -793,24 +1048,32 @@ function ensureRowEditDialog(manager) {
     saveButton: dialog.querySelector(".row-edit-save"),
     currentButton: null,
     currentRow: null,
+    currentRowId: null,
     currentPkPath: null,
+    currentUpdateUrl: null,
+    currentFragmentUrl: null,
     loadId: 0,
     manager: manager,
     isLoading: false,
+    isSaving: false,
+    hasLoaded: false,
     shouldRestoreFocus: true,
   };
 
   rowEditDialogState.form.addEventListener("submit", function (ev) {
     ev.preventDefault();
+    saveRowEditDialog(rowEditDialogState);
   });
 
   rowEditDialogState.cancelButton.addEventListener("click", function () {
-    rowEditDialogState.shouldRestoreFocus = true;
-    dialog.close();
+    if (!rowEditDialogState.isSaving) {
+      rowEditDialogState.shouldRestoreFocus = true;
+      dialog.close();
+    }
   });
 
   dialog.addEventListener("click", function (ev) {
-    if (ev.target === dialog) {
+    if (ev.target === dialog && !rowEditDialogState.isSaving) {
       rowEditDialogState.shouldRestoreFocus = true;
       dialog.close();
     }
@@ -820,20 +1083,30 @@ function ensureRowEditDialog(manager) {
     if (ev.key !== "Escape") {
       return;
     }
+    if (rowEditDialogState.isSaving) {
+      ev.preventDefault();
+      return;
+    }
     ev.preventDefault();
     rowEditDialogState.shouldRestoreFocus = true;
     dialog.close();
   });
 
-  dialog.addEventListener("cancel", function () {
-    rowEditDialogState.shouldRestoreFocus = true;
+  dialog.addEventListener("cancel", function (ev) {
+    if (rowEditDialogState.isSaving) {
+      ev.preventDefault();
+    } else {
+      rowEditDialogState.shouldRestoreFocus = true;
+    }
   });
 
   dialog.addEventListener("close", function () {
     var state = rowEditDialogState;
     state.loadId += 1;
     clearRowEditDialogError(state);
+    state.hasLoaded = false;
     setRowEditDialogLoading(state, false);
+    setRowEditDialogSaving(state, false);
     if (
       state.shouldRestoreFocus &&
       state.currentButton &&
@@ -847,8 +1120,8 @@ function ensureRowEditDialog(manager) {
 }
 
 async function openRowEditDialog(button, manager) {
-  var row = button.closest("tr[data-row-url]");
-  if (!row || !row.dataset.rowUrl) {
+  var row = button.closest("[data-row]");
+  if (!row || !row.getAttribute("data-row")) {
     return;
   }
   var state = ensureRowEditDialog(manager);
@@ -859,8 +1132,17 @@ async function openRowEditDialog(button, manager) {
   state.manager = manager;
   state.currentButton = button;
   state.currentRow = row;
-  state.currentPkPath = row.dataset.rowPkPath || "";
+  state.currentRowId = row.getAttribute("data-row") || "";
+  state.currentPkPath = rowDisplayLabel(row);
+  state.currentUpdateUrl = rowUpdateUrl(row);
+  state.currentFragmentUrl = rowFragmentUrl(row);
+  if (state.currentUpdateUrl) {
+    state.form.action = new URL(state.currentUpdateUrl, location.href).toString();
+  } else {
+    state.form.removeAttribute("action");
+  }
   state.shouldRestoreFocus = true;
+  state.hasLoaded = false;
   state.loadId += 1;
   var loadId = state.loadId;
 
@@ -885,7 +1167,7 @@ async function openRowEditDialog(button, manager) {
       return;
     }
     if (!response.ok || data.ok === false) {
-      throw rowDeleteRequestError(response, data);
+      throw rowMutationRequestError(response, data);
     }
     setRowEditDialogLoading(state, false);
     renderRowEditFields(state, data);
diff --git a/datasette/templates/_table.html b/datasette/templates/_table.html
index 2ecf5cc2..38454da3 100644
--- a/datasette/templates/_table.html
+++ b/datasette/templates/_table.html
@@ -22,7 +22,7 @@
         </thead>
         <tbody>
         {% for row in display_rows %}
-            <tr{% if row.pk_path is not none %} data-row-pk-path="{{ row.pk_path }}" data-row-path="{{ row.row_path }}" data-row-url="{{ row.row_url }}" data-row-delete-url="{{ row.delete_url }}" data-row-update-url="{{ row.update_url }}"{% endif %}>
+            <tr{% if row.pk_path is not none %} data-row="{{ row.row_path }}"{% endif %}>
                 {% for cell in row %}
                     <td class="col-{{ cell.column|to_css_class }} type-{{ cell.value_type }}">{{ cell.value }}</td>
                 {% endfor %}
diff --git a/datasette/templates/table.html b/datasette/templates/table.html
index 4dc908e0..026599cc 100644
--- a/datasette/templates/table.html
+++ b/datasette/templates/table.html
@@ -4,6 +4,7 @@
 
 {% block extra_head %}
 {{- super() -}}
+<script>window._datasetteTableData = {{ {"tableUrl": urls.table(database, table)}|tojson }};</script>
 <script src="{{ urls.static('column-chooser.js') }}" defer></script>
 <script src="{{ urls.static('table.js') }}?hash={{ table_js_hash }}" defer></script>
 <script src="{{ urls.static('mobile-column-actions.js') }}" defer></script>
diff --git a/datasette/views/table.py b/datasette/views/table.py
index cd6a016a..33357165 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -2,6 +2,7 @@ import asyncio
 import itertools
 import json
 import urllib
+import urllib.parse
 
 import markupsafe
 
@@ -40,7 +41,7 @@ from datasette.utils import (
     InvalidSql,
     sqlite3,
 )
-from datasette.utils.asgi import BadRequest, Forbidden, NotFound, Response
+from datasette.utils.asgi import BadRequest, Forbidden, NotFound, Request, Response
 from datasette.filters import Filters
 import sqlite_utils
 from .base import BaseView, DatasetteError, _error, stream_csv
@@ -64,16 +65,10 @@ class Row:
         cells,
         pk_path=None,
         row_path=None,
-        row_url=None,
-        delete_url=None,
-        update_url=None,
     ):
         self.cells = cells
         self.pk_path = pk_path
         self.row_path = row_path
-        self.row_url = row_url
-        self.delete_url = delete_url
-        self.update_url = update_url
 
     def __iter__(self):
         return iter(self.cells)
@@ -110,6 +105,66 @@ async def run_sequential(*args):
     return results
 
 
+def _exact_filter_key(column):
+    if column.startswith("_"):
+        return f"{column}__exact"
+    return column
+
+
+def _request_with_query_string(request, query_string):
+    scope = dict(request.scope)
+    scope["query_string"] = query_string.encode("latin-1")
+    return Request(scope, request.receive)
+
+
+async def _fragment_request_for_row(request, resolved):
+    row_path = request.args.get("_row")
+    if not row_path:
+        return request
+    if resolved.is_view:
+        raise BadRequest("_row is not supported for views")
+
+    pks = await resolved.db.primary_keys(resolved.table)
+    row_pks = pks or ["rowid"]
+    pk_values = urlsafe_components(row_path)
+    if len(pk_values) != len(row_pks):
+        raise BadRequest("_row does not match the primary key for this table")
+
+    row_pk_filter_keys = {
+        key
+        for pk in row_pks
+        for key in {
+            _exact_filter_key(pk),
+            f"{pk}__exact",
+        }
+    }
+    args = [
+        (key, value)
+        for key, value in urllib.parse.parse_qsl(
+            request.query_string, keep_blank_values=True
+        )
+        if key
+        not in {
+            "_row",
+            "_next",
+            "_nocount",
+            "_nofacet",
+            "_nosuggest",
+        }.union(row_pk_filter_keys)
+    ]
+    args.extend(
+        [(_exact_filter_key(pk), value) for pk, value in zip(row_pks, pk_values)]
+    )
+    args.extend(
+        [
+            ("_nocount", "1"),
+            ("_nofacet", "1"),
+            ("_nosuggest", "1"),
+        ]
+    )
+    return _request_with_query_string(request, urllib.parse.urlencode(args))
+
+
 def _redirect(datasette, request, path, forward_querystring=True, remove_args=None):
     if request.query_string and "?" not in path and forward_querystring:
         path = f"{path}?{request.query_string}"
@@ -255,12 +310,6 @@ async def display_columns_and_rows(
             pk_path = path_from_row_pks(row, pks, not pks, False)
             row_path = path_from_row_pks(row, pks, not pks)
             table_path = datasette.urls.table(database_name, table_name)
-            row_url = "{table_path}/{row_path}".format(
-                table_path=table_path,
-                row_path=row_path,
-            )
-            delete_url = "{row_url}/-/delete".format(row_url=row_url)
-            update_url = "{row_url}/-/update".format(row_url=row_url)
             row_link = '<a href="{table_path}/{flat_pks_quoted}">{flat_pks}</a>'.format(
                 table_path=table_path,
                 flat_pks=str(markupsafe.escape(pk_path)),
@@ -432,9 +481,6 @@ async def display_columns_and_rows(
                     cells,
                     pk_path=pk_path,
                     row_path=row_path,
-                    row_url=row_url,
-                    delete_url=delete_url,
-                    update_url=update_url,
                 )
             )
         else:
@@ -941,6 +987,43 @@ class TableDropView(BaseView):
         return Response.json({"ok": True}, status=200)
 
 
+class TableFragmentView(BaseView):
+    name = "table-fragment"
+
+    def __init__(self, datasette):
+        self.ds = datasette
+
+    async def get(self, request):
+        resolved = await self.ds.resolve_table(request)
+        request = await _fragment_request_for_row(request, resolved)
+        view_data = await table_view_data(
+            self.ds,
+            request,
+            resolved,
+            extra_extras={"_html"},
+            context_for_html_hack=True,
+            default_labels=True,
+        )
+        if isinstance(view_data, Response):
+            return view_data
+        data, _rows, _columns, _expanded_columns, _sql, _next_url = view_data
+        templates = data["custom_table_templates"]
+        html = await self.ds.render_template(
+            templates,
+            dict(
+                data,
+                append_querystring=append_querystring,
+                path_with_replaced_args=path_with_replaced_args,
+                fix_path=self.ds.urls.path,
+                settings=self.ds.settings_dict(),
+                count_limit=resolved.db.count_limit,
+            ),
+            request=request,
+            view_name="table",
+        )
+        return Response.html(html)
+
+
 async def _columns_to_select(table_columns, pks, request):
     columns = list(table_columns)
     if "_col" in request.args:
diff --git a/docs/custom_templates.rst b/docs/custom_templates.rst
index c324fb79..aa82a536 100644
--- a/docs/custom_templates.rst
+++ b/docs/custom_templates.rst
@@ -274,13 +274,20 @@ Here is an example of a custom ``_table.html`` template:
 .. code-block:: jinja
 
     {% for row in display_rows %}
-        <div>
+        <div data-row="{{ row.row_path }}">
             <h2>{{ row["title"] }}</h2>
             <p>{{ row["description"] }}<lp>
             <p>Category: {{ row.display("category_id") }}</p>
         </div>
     {% endfor %}
 
+If your custom table template should support Datasette's row editing UI, include
+``data-row="{{ row.row_path }}"`` on the outer element that represents each row.
+This does not need to be a ``<tr>``: it can be a ``<div>``, ``<li>`` or any other
+element that wraps the HTML for that row. Datasette uses this attribute to find
+the element to remove after a delete, or replace after an edit. Any edit or
+delete controls should be rendered inside that same element.
+
 .. _custom_pages:
 
 Custom pages
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 6be6942d..4e24f129 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -664,6 +664,11 @@ async def test_table_html_compound_primary_key(ds_client):
     assert [
         [str(td) for td in tr.select("td")] for tr in table.select("tbody tr")
     ] == expected
+    rows = table.select("tbody tr")
+    assert rows[0]["data-row"] == "a,b"
+    assert "data-row-pk-path" not in rows[0].attrs
+    assert rows[1]["data-row"] == "a~2Fb,~2Ec-d"
+    assert "data-row-pk-path" not in rows[1].attrs
 
 
 @pytest.mark.asyncio
@@ -859,12 +864,24 @@ async def test_row_delete_action_data_attributes():
         response = await ds.client.get("/data/items", actor={"id": "root"})
         assert response.status_code == 200
         soup = Soup(response.text, "html.parser")
+        import json
+        import re
+
+        table_script = [
+            s for s in soup.find_all("script") if "_datasetteTableData" in (s.string or "")
+        ][0]
+        match = re.search(
+            r"window\._datasetteTableData\s*=\s*({.*?});",
+            table_script.string,
+            re.DOTALL,
+        )
+        assert json.loads(match.group(1)) == {"tableUrl": "/data/items"}
+
         row = soup.select_one("table.rows-and-columns tbody tr")
-        assert row["data-row-pk-path"] == "1"
-        assert row["data-row-path"] == "1"
-        assert row["data-row-url"] == "/data/items/1"
-        assert row["data-row-delete-url"] == "/data/items/1/-/delete"
-        assert row["data-row-update-url"] == "/data/items/1/-/update"
+        assert row["data-row"] == "1"
+        assert {
+            key for key in row.attrs if key.startswith("data-row")
+        } == {"data-row"}
 
         edit_button = row.select_one(
             'button.row-inline-action-edit[data-row-action="edit"]'
@@ -885,6 +902,97 @@ async def test_row_delete_action_data_attributes():
         ds.close()
 
 
+@pytest.mark.asyncio
+async def test_table_fragment_endpoint(ds_client):
+    response = await ds_client.get("/fixtures/simple_primary_key/-/fragment?_row=1")
+    assert response.status_code == 200
+    assert response.headers["content-type"].startswith("text/html")
+    soup = Soup(response.text, "html.parser")
+    assert soup.find("html") is None
+    rows = soup.select("[data-row]")
+    assert len(rows) == 1
+    assert rows[0]["data-row"] == "1"
+    assert {
+        key for key in rows[0].attrs if key.startswith("data-row")
+    } == {"data-row"}
+
+
+@pytest.mark.asyncio
+async def test_table_fragment_row_parameter_replaces_pk_filters(ds_client):
+    response = await ds_client.get(
+        "/fixtures/simple_primary_key/-/fragment?id=2&_row=1"
+    )
+    assert response.status_code == 200
+    soup = Soup(response.text, "html.parser")
+    rows = soup.select("[data-row]")
+    assert len(rows) == 1
+    assert rows[0]["data-row"] == "1"
+
+
+def test_table_data_uses_base_url(app_client_base_url_prefix):
+    response = app_client_base_url_prefix.get("/prefix/fixtures/simple_primary_key")
+    assert response.status_code == 200
+    import json
+    import re
+
+    soup = Soup(response.text, "html.parser")
+    table_script = [
+        s for s in soup.find_all("script") if "_datasetteTableData" in (s.string or "")
+    ][0]
+    match = re.search(
+        r"window\._datasetteTableData\s*=\s*({.*?});",
+        table_script.string,
+        re.DOTALL,
+    )
+    assert json.loads(match.group(1)) == {
+        "tableUrl": "/prefix/fixtures/simple_primary_key"
+    }
+
+
+def test_table_fragment_custom_table_include():
+    with make_app_client(
+        template_dir=str(pathlib.Path(__file__).parent / "test_templates")
+    ) as client:
+        response = client.get("/fixtures/complex_foreign_keys/-/fragment?f1=1&f2=2")
+        assert response.status == 200
+        assert (
+            '<div class="custom-table-row">'
+            '1 - 2 - <a href="/fixtures/simple_primary_key/1">hello</a> <em>1</em>'
+            "</div>"
+        ) == str(Soup(response.text, "html.parser").select_one("div.custom-table-row"))
+
+
+@pytest.mark.asyncio
+async def test_table_fragment_uses_render_cell_hook():
+    from datasette import hookimpl
+    from markupsafe import Markup
+
+    class TestRenderCellPlugin:
+        __name__ = "TestRenderCellPlugin"
+
+        @hookimpl
+        def render_cell(self, value, column, table, database):
+            if database == "data" and table == "items" and column == "name":
+                return Markup("<strong>{}</strong>".format(value))
+            return None
+
+    ds = Datasette(memory=True)
+    await ds.invoke_startup()
+    db = ds.add_memory_database("data")
+    await db.execute_write(
+        "create table items (id integer primary key, name text)"
+    )
+    await db.execute_write("insert into items values (1, 'Alice')")
+    ds.pm.register(TestRenderCellPlugin(), name="TestRenderCellPlugin")
+    try:
+        response = await ds.client.get("/data/items/-/fragment?id=1")
+        assert response.status_code == 200
+        assert "<strong>Alice</strong>" in response.text
+    finally:
+        ds.pm.unregister(name="TestRenderCellPlugin")
+        ds.close()
+
+
 @pytest.mark.asyncio
 async def test_zero_row_table_renders_thead(ds_client):
     response = await ds_client.get("/fixtures/123_starts_with_digits")

From 5bf4cf8860bd44a8e2729a7f73705d7120ae0cc6 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 21:34:45 -0700
Subject: [PATCH 194/386] Add insert row UI to table pages

Add a permission-gated Insert row button to mutable table pages and expose the metadata needed by the client-side UI, including the insert API path, table name, primary keys, editable columns, defaults, nullability, and column type information.

Reuse the existing row edit modal for inserts. Insert submissions now use the JSON API with return=true, derive the new row's tilde-encoded row path from the returned primary key values, fetch the matching table fragment, and insert the rendered row into the current table. Successful inserts and updates now show mutation status messages above the table.

Support SQLite defaults in insert forms by showing default expressions as non-editable values with Set value / Use default controls. Keep those controls aligned and stable so toggling between default and custom values does not shift the modal layout.

Refine the edit modal at the same time: send only changed fields on update, skip the update API entirely when nothing changed, clear stale mutation status for no-op saves, and simplify modal headings so insert/edit context is shown in the bold title instead of duplicated summary text.

Add tests for the insert button and metadata, including omitted integer primary keys, default values, table names, and compound primary keys.
---
 datasette/static/app.css       | 116 ++++++++-
 datasette/static/table.js      | 460 +++++++++++++++++++++++++++++++--
 datasette/templates/table.html |  17 ++
 datasette/views/table.py       |  66 +++++
 tests/test_table_html.py       | 159 ++++++++++--
 5 files changed, 760 insertions(+), 58 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index aca39e58..9226580b 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1209,6 +1209,21 @@ dialog.set-column-type-dialog::backdrop {
     background: rgba(208,2,27,0.12);
 }
 
+.table-row-toolbar {
+    margin: 0 0 0.75rem;
+}
+
+button.table-insert-row {
+    display: inline-flex;
+    align-items: center;
+    gap: 0.4rem;
+}
+
+button.table-insert-row svg {
+    display: block;
+    flex-shrink: 0;
+}
+
 dialog.row-delete-dialog {
     --ink: #0f0f0f;
     --paper: #f5f3ef;
@@ -1381,6 +1396,17 @@ dialog.row-edit-dialog::backdrop {
     color: var(--ink);
 }
 
+.row-edit-dialog .modal-title code {
+    display: inline;
+    padding: 2px 5px;
+    border: 1px solid var(--rule);
+    border-radius: 4px;
+    background: var(--paper);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.92em;
+    overflow-wrap: anywhere;
+}
+
 .row-edit-form {
     display: flex;
     flex: 1 1 auto;
@@ -1401,17 +1427,6 @@ dialog.row-edit-dialog::backdrop {
     font-size: 0.9rem;
 }
 
-.row-edit-id {
-    display: inline;
-    padding: 2px 5px;
-    border: 1px solid var(--rule);
-    border-radius: 4px;
-    background: var(--paper);
-    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
-    font-size: 0.92em;
-    overflow-wrap: anywhere;
-}
-
 .row-edit-error {
     border-left: 4px solid #b91c1c;
     border-radius: 4px;
@@ -1483,11 +1498,80 @@ textarea.row-edit-input {
     background: var(--paper);
 }
 
+.row-edit-default {
+    display: grid;
+    grid-template-columns: minmax(0, 1fr) 7.25rem;
+    align-items: center;
+    gap: 8px;
+    min-width: 0;
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    padding: 7px 8px 7px 10px;
+    background: var(--paper);
+    color: var(--ink);
+}
+
+.row-edit-default[hidden],
+.row-edit-custom-value[hidden] {
+    display: none;
+}
+
+.row-edit-default-text {
+    min-width: 0;
+    overflow-wrap: anywhere;
+}
+
+.row-edit-default-code {
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.82rem;
+}
+
+.row-edit-custom-value {
+    display: grid;
+    grid-template-columns: minmax(0, 1fr) 7.25rem;
+    gap: 8px;
+    align-items: center;
+    min-height: 45px;
+    padding-right: 8px;
+}
+
+.row-edit-default-button {
+    appearance: none;
+    border: 1px solid var(--rule);
+    border-radius: 4px;
+    background: #fff;
+    color: var(--accent);
+    cursor: pointer;
+    font: inherit;
+    font-size: 0.78rem;
+    line-height: 1.2;
+    padding: 6px 8px;
+    white-space: nowrap;
+    width: 100%;
+    align-self: center;
+}
+
+.row-edit-default-button:hover,
+.row-edit-default-button:focus {
+    background: #f8fafc;
+}
+
+.row-edit-default-button:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 1px;
+}
+
 .row-edit-field-meta {
     color: var(--muted);
     font-size: 0.78rem;
 }
 
+.row-edit-empty {
+    color: var(--muted);
+    font-size: 0.9rem;
+    margin: 0;
+}
+
 .row-edit-dialog .modal-footer {
     padding: 14px 20px;
     border-top: 1px solid var(--rule);
@@ -1757,6 +1841,7 @@ textarea.row-edit-input {
         width: 140px;
     }
     button.choose-columns-mobile,
+    button.table-insert-row,
     button.column-actions-mobile {
         display: inline-flex;
         align-items: center;
@@ -1793,6 +1878,15 @@ textarea.row-edit-input {
     button.choose-columns-mobile {
         margin-right: 0.5rem;
     }
+
+    .table-row-toolbar {
+        margin-bottom: 0.75rem;
+    }
+
+    button.table-insert-row {
+        width: 100%;
+        margin-bottom: 0;
+    }
 }
 
 svg.dropdown-menu-icon {
diff --git a/datasette/static/table.js b/datasette/static/table.js
index 1ae2f30d..c8109c62 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -389,6 +389,16 @@ function showRowMutationStatus(manager, message, isError) {
   return status;
 }
 
+function hideRowMutationStatus() {
+  var status = document.querySelector(".row-mutation-status");
+  if (!status) {
+    return;
+  }
+  status.hidden = true;
+  status.classList.remove("row-mutation-status-error");
+  status.textContent = "";
+}
+
 function setRowDeleteDialogBusy(state, isBusy) {
   state.isBusy = isBusy;
   state.confirmButton.disabled = isBusy;
@@ -436,6 +446,27 @@ function tildeDecode(value) {
   }
 }
 
+function tildeEncode(value) {
+  var bytes = new TextEncoder().encode(String(value));
+  var encoded = "";
+  bytes.forEach(function (byte) {
+    var isSafe =
+      (byte >= 65 && byte <= 90) ||
+      (byte >= 97 && byte <= 122) ||
+      (byte >= 48 && byte <= 57) ||
+      byte === 95 ||
+      byte === 45;
+    if (isSafe) {
+      encoded += String.fromCharCode(byte);
+    } else if (byte === 32) {
+      encoded += "+";
+    } else {
+      encoded += "~" + byte.toString(16).toUpperCase().padStart(2, "0");
+    }
+  });
+  return encoded;
+}
+
 function rowDisplayLabel(row) {
   return tildeDecode(row.getAttribute("data-row") || "");
 }
@@ -449,6 +480,20 @@ function tableBaseUrl() {
   return url;
 }
 
+function tableInsertData() {
+  return window._datasetteTableData && window._datasetteTableData.insertRow;
+}
+
+function tableInsertUrl() {
+  var data = tableInsertData();
+  if (data && data.path) {
+    return new URL(data.path, location.href).toString();
+  }
+  var url = tableBaseUrl();
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/insert";
+  return url.toString();
+}
+
 function rowResourceUrl(row) {
   var rowId = row.getAttribute("data-row");
   if (!rowId) {
@@ -489,6 +534,10 @@ function rowUpdateUrl(row) {
 
 function rowFragmentUrl(row) {
   var rowId = row.getAttribute("data-row");
+  return rowFragmentUrlById(rowId);
+}
+
+function rowFragmentUrlById(rowId) {
   if (!rowId) {
     return "";
   }
@@ -748,9 +797,14 @@ function rowEditValueType(value) {
   return "string";
 }
 
-function createRowEditField(column, value, isPk, columnType, index) {
+function createRowEditField(column, value, isPk, columnType, index, options) {
+  options = options || {};
   var field = document.createElement("div");
   field.className = "row-edit-field";
+  var hasDefault =
+    options.hasDefault ||
+    (options.defaultValue !== null && typeof options.defaultValue !== "undefined");
+  var useDefaultInitially = hasDefault && options.useDefaultInitially;
 
   var fieldId = "row-edit-field-" + index;
   var metaId = "row-edit-field-meta-" + index;
@@ -771,8 +825,16 @@ function createRowEditField(column, value, isPk, columnType, index) {
   control.value = valueToEditText(value);
   control.setAttribute("aria-describedby", metaId);
   control.dataset.originalValue = valueToEditText(value);
-  control.dataset.originalValueType = rowEditValueType(value);
+  control.dataset.originalValueType =
+    options.valueType || rowEditValueType(value);
   control.dataset.primaryKey = isPk ? "1" : "0";
+  if (useDefaultInitially) {
+    control.dataset.useDefault = "1";
+    control.disabled = true;
+  }
+  if (options.omitIfBlank) {
+    control.dataset.omitIfBlank = "1";
+  }
 
   if (control.nodeName === "TEXTAREA") {
     control.rows = Math.min(8, Math.max(3, control.value.split("\n").length));
@@ -780,7 +842,7 @@ function createRowEditField(column, value, isPk, columnType, index) {
     control.type = "text";
   }
 
-  if (isPk) {
+  if (isPk && options.primaryKeyReadonly !== false) {
     control.readOnly = true;
   }
 
@@ -791,6 +853,12 @@ function createRowEditField(column, value, isPk, columnType, index) {
   if (isPk) {
     metaParts.push("Primary key");
   }
+  if (options.notnull) {
+    metaParts.push("Required");
+  }
+  if (hasDefault && !useDefaultInitially) {
+    metaParts.push("Default: " + options.defaultValue);
+  }
   if (value === null) {
     metaParts.push("Current value: NULL");
     control.placeholder = "NULL";
@@ -800,7 +868,62 @@ function createRowEditField(column, value, isPk, columnType, index) {
   }
   meta.textContent = metaParts.join(" · ");
 
-  controlWrap.appendChild(control);
+  if (useDefaultInitially) {
+    var defaultBlock = document.createElement("div");
+    defaultBlock.className = "row-edit-default";
+    defaultBlock.setAttribute("aria-describedby", metaId);
+
+    var defaultText = document.createElement("span");
+    defaultText.className = "row-edit-default-text";
+    defaultText.appendChild(document.createTextNode("default "));
+    var defaultCode = document.createElement("code");
+    defaultCode.className = "row-edit-default-code";
+    defaultCode.textContent = options.defaultValue;
+    defaultText.appendChild(defaultCode);
+
+    var setValueButton = document.createElement("button");
+    setValueButton.type = "button";
+    setValueButton.className =
+      "row-edit-default-button row-edit-default-set-value";
+    setValueButton.textContent = "Set value";
+    setValueButton.setAttribute("aria-label", "Set value for " + column);
+
+    var customWrap = document.createElement("div");
+    customWrap.className = "row-edit-custom-value";
+    customWrap.hidden = true;
+
+    var useDefaultButton = document.createElement("button");
+    useDefaultButton.type = "button";
+    useDefaultButton.className = "row-edit-default-button";
+    useDefaultButton.textContent = "Use default";
+    useDefaultButton.setAttribute("aria-label", "Use default for " + column);
+
+    setValueButton.addEventListener("click", function () {
+      control.dataset.useDefault = "0";
+      control.disabled = false;
+      defaultBlock.hidden = true;
+      customWrap.hidden = false;
+      control.focus();
+    });
+
+    useDefaultButton.addEventListener("click", function () {
+      control.dataset.useDefault = "1";
+      control.disabled = true;
+      control.value = "";
+      customWrap.hidden = true;
+      defaultBlock.hidden = false;
+      setValueButton.focus();
+    });
+
+    defaultBlock.appendChild(defaultText);
+    defaultBlock.appendChild(setValueButton);
+    customWrap.appendChild(control);
+    customWrap.appendChild(useDefaultButton);
+    controlWrap.appendChild(defaultBlock);
+    controlWrap.appendChild(customWrap);
+  } else {
+    controlWrap.appendChild(control);
+  }
   if (meta.textContent) {
     controlWrap.appendChild(meta);
   }
@@ -823,7 +946,8 @@ function showRowEditDialogError(state, message) {
 function updateRowEditDialogButtons(state) {
   state.saveButton.disabled = state.isLoading || state.isSaving || !state.hasLoaded;
   state.cancelButton.disabled = state.isSaving;
-  state.saveButton.textContent = state.isSaving ? "Saving..." : "Save";
+  var saveLabel = state.mode === "insert" ? "Insert row" : "Save";
+  state.saveButton.textContent = state.isSaving ? "Saving..." : saveLabel;
   state.form.setAttribute(
     "aria-busy",
     state.isLoading || state.isSaving ? "true" : "false",
@@ -843,8 +967,15 @@ function setRowEditDialogSaving(state, isSaving) {
 
 function valueFromRowEditControl(control) {
   var value = control.value;
+  return valueFromRowEditText(
+    control.name,
+    value,
+    control.dataset.originalValueType || "string",
+  );
+}
+
+function valueFromRowEditText(name, value, originalValueType) {
   var trimmed = value.trim();
-  var originalValueType = control.dataset.originalValueType || "string";
 
   if (originalValueType === "null" && value === "") {
     return null;
@@ -855,7 +986,7 @@ function valueFromRowEditControl(control) {
     }
     var numberValue = Number(trimmed);
     if (Number.isNaN(numberValue)) {
-      throw new Error(control.name + " must be a number");
+      throw new Error(name + " must be a number");
     }
     return numberValue;
   }
@@ -866,7 +997,7 @@ function valueFromRowEditControl(control) {
     if (/^(false|0|no)$/i.test(trimmed)) {
       return false;
     }
-    throw new Error(control.name + " must be true or false");
+    throw new Error(name + " must be true or false");
   }
   if (originalValueType === "json") {
     if (trimmed === "") {
@@ -875,21 +1006,60 @@ function valueFromRowEditControl(control) {
     try {
       return JSON.parse(value);
     } catch (_error) {
-      throw new Error(control.name + " must be valid JSON");
+      throw new Error(name + " must be valid JSON");
     }
   }
   return value;
 }
 
-function collectRowEditUpdate(state) {
-  var update = {};
+function originalValueFromRowEditControl(control) {
+  return valueFromRowEditText(
+    control.name,
+    control.dataset.originalValue || "",
+    control.dataset.originalValueType || "string",
+  );
+}
+
+function rowEditValuesMatch(left, right) {
+  if (left === right) {
+    return true;
+  }
+  if (
+    left &&
+    right &&
+    typeof left === "object" &&
+    typeof right === "object"
+  ) {
+    return JSON.stringify(left) === JSON.stringify(right);
+  }
+  return false;
+}
+
+function collectRowFormValues(state) {
+  var values = {};
   state.fields.querySelectorAll(".row-edit-input").forEach(function (control) {
-    if (control.readOnly || control.dataset.primaryKey === "1") {
+    if (
+      state.mode === "edit" &&
+      (control.readOnly || control.dataset.primaryKey === "1")
+    ) {
       return;
     }
-    update[control.name] = valueFromRowEditControl(control);
+    if (control.dataset.useDefault === "1") {
+      return;
+    }
+    if (control.dataset.omitIfBlank === "1" && control.value === "") {
+      return;
+    }
+    var value = valueFromRowEditControl(control);
+    if (
+      state.mode === "edit" &&
+      rowEditValuesMatch(value, originalValueFromRowEditControl(control))
+    ) {
+      return;
+    }
+    values[control.name] = value;
   });
-  return update;
+  return values;
 }
 
 function findDataRowElement(root, rowId) {
@@ -919,6 +1089,41 @@ async function fetchUpdatedRowElement(state) {
   return findDataRowElement(doc, state.currentRowId);
 }
 
+function rowPathFromRowData(row, primaryKeys) {
+  if (!row) {
+    return null;
+  }
+  var keys = primaryKeys && primaryKeys.length ? primaryKeys : ["rowid"];
+  var bits = [];
+  for (var i = 0; i < keys.length; i += 1) {
+    var key = keys[i];
+    if (typeof row[key] === "undefined") {
+      return null;
+    }
+    bits.push(tildeEncode(row[key]));
+  }
+  return bits.join(",");
+}
+
+function addInsertedRowToPage(rowElement) {
+  var importedRow = document.importNode(rowElement, true);
+  var firstRow = document.querySelector("[data-row]");
+  if (firstRow && firstRow.parentNode) {
+    firstRow.parentNode.insertBefore(importedRow, firstRow);
+  } else {
+    var tbody = document.querySelector("table.rows-and-columns tbody");
+    if (!tbody) {
+      return null;
+    }
+    tbody.appendChild(importedRow);
+  }
+  var zeroResults = document.querySelector(".zero-results");
+  if (zeroResults) {
+    zeroResults.remove();
+  }
+  return importedRow;
+}
+
 async function saveRowEditDialog(state) {
   if (state.isLoading || state.isSaving || !state.hasLoaded) {
     return;
@@ -927,19 +1132,32 @@ async function saveRowEditDialog(state) {
   setRowEditDialogSaving(state, true);
 
   try {
-    if (!state.currentUpdateUrl) {
-      throw new Error("Could not find the row update URL");
+    var url = state.mode === "insert" ? state.currentInsertUrl : state.currentUpdateUrl;
+    if (!url) {
+      throw new Error(
+        state.mode === "insert"
+          ? "Could not find the row insert URL"
+          : "Could not find the row update URL",
+      );
     }
-    var response = await fetch(state.currentUpdateUrl, {
+    var formValues = collectRowFormValues(state);
+    if (state.mode === "edit" && !Object.keys(formValues).length) {
+      state.shouldRestoreFocus = true;
+      hideRowMutationStatus();
+      state.dialog.close();
+      return;
+    }
+    var payload =
+      state.mode === "insert"
+        ? { row: formValues, return: true }
+        : { update: formValues, return: true };
+    var response = await fetch(url, {
       method: "POST",
       headers: {
         "Content-Type": "application/json",
         Accept: "application/json",
       },
-      body: JSON.stringify({
-        update: collectRowEditUpdate(state),
-        return: true,
-      }),
+      body: JSON.stringify(payload),
     });
     var data = null;
     try {
@@ -951,11 +1169,75 @@ async function saveRowEditDialog(state) {
       throw rowMutationRequestError(response, data);
     }
 
+    if (state.mode === "insert") {
+      var insertData = tableInsertData() || {};
+      var insertedRowData = data && data.rows && data.rows.length ? data.rows[0] : null;
+      var insertedRowId = rowPathFromRowData(
+        insertedRowData,
+        insertData.primaryKeys || [],
+      );
+      state.shouldRestoreFocus = false;
+      if (!insertedRowId) {
+        state.dialog.close();
+        var missingIdStatus = showRowMutationStatus(
+          state.manager,
+          "Inserted row. Refresh the page to see it.",
+          false,
+        );
+        missingIdStatus.focus();
+        return;
+      }
+
+      state.currentRowId = insertedRowId;
+      state.currentFragmentUrl = rowFragmentUrlById(insertedRowId);
+      var insertedStatusMessage =
+        "Inserted row " + tildeDecode(insertedRowId) + ".";
+      var insertedRow = null;
+      try {
+        insertedRow = await fetchUpdatedRowElement(state);
+      } catch (_error) {
+        state.dialog.close();
+        var refreshFailedStatus = showRowMutationStatus(
+          state.manager,
+          "Inserted row, but could not refresh the table row. Refresh the page to see it.",
+          true,
+        );
+        refreshFailedStatus.focus();
+        return;
+      }
+      if (insertedRow) {
+        var addedRow = addInsertedRowToPage(insertedRow);
+        state.dialog.close();
+        showRowMutationStatus(state.manager, insertedStatusMessage, false);
+        if (addedRow) {
+          var insertedFocusTarget =
+            addedRow.querySelector('button[data-row-action="edit"]') || addedRow;
+          insertedFocusTarget.focus();
+        }
+      } else {
+        state.dialog.close();
+        var filteredStatus = showRowMutationStatus(
+          state.manager,
+          "Inserted row. It does not match the current filters.",
+          false,
+        );
+        filteredStatus.focus();
+      }
+      return;
+    }
+
     var updatedRow = await fetchUpdatedRowElement(state);
     var focusTarget = null;
     if (updatedRow && state.currentRow && document.contains(state.currentRow)) {
       var importedRow = document.importNode(updatedRow, true);
       state.currentRow.replaceWith(importedRow);
+      showRowMutationStatus(
+        state.manager,
+        state.currentPkPath
+          ? "Updated row " + state.currentPkPath + "."
+          : "Updated row.",
+        false,
+      );
       focusTarget =
         importedRow.querySelector('button[data-row-action="edit"]') || importedRow;
     } else if (state.currentRow && document.contains(state.currentRow)) {
@@ -965,7 +1247,11 @@ async function saveRowEditDialog(state) {
       state.currentRow.remove();
       showRowMutationStatus(
         state.manager,
-        "Saved row. It no longer matches the current filters.",
+        state.currentPkPath
+          ? "Updated row " +
+              state.currentPkPath +
+              ". It no longer matches the current filters."
+          : "Updated row. It no longer matches the current filters.",
         false,
       );
     }
@@ -996,6 +1282,9 @@ function renderRowEditFields(state, data) {
         primaryKeys.indexOf(column) !== -1,
         columnTypes[column],
         index,
+        {
+          primaryKeyReadonly: true,
+        },
       ),
     );
   });
@@ -1007,6 +1296,57 @@ function renderRowEditFields(state, data) {
   (firstEditable || firstField || state.cancelButton).focus();
 }
 
+function renderRowInsertFields(state, data) {
+  var columns = data.columns || [];
+
+  state.fields.innerHTML = "";
+  columns.forEach(function (column, index) {
+    state.fields.appendChild(
+      createRowEditField(
+        column.name,
+        "",
+        !!column.is_pk,
+        column.column_type,
+        index,
+        {
+          defaultValue: column.default,
+          hasDefault: column.has_default,
+          notnull: column.notnull,
+          primaryKeyReadonly: false,
+          useDefaultInitially: column.has_default,
+          valueType: column.value_type,
+        },
+      ),
+    );
+  });
+
+  if (!columns.length) {
+    var emptyMessage = document.createElement("p");
+    emptyMessage.className = "row-edit-empty";
+    emptyMessage.textContent = "This row will use the table defaults.";
+    state.fields.appendChild(emptyMessage);
+  }
+
+  state.hasLoaded = true;
+  updateRowEditDialogButtons(state);
+  var firstControl = state.fields.querySelector(
+    ".row-edit-default-set-value, .row-edit-input:not(:disabled)",
+  );
+  (firstControl || state.saveButton).focus();
+}
+
+function setRowEditDialogTitle(state, text, codeText) {
+  state.title.textContent = "";
+  state.title.appendChild(document.createTextNode(text));
+  if (!codeText) {
+    return;
+  }
+  state.title.appendChild(document.createTextNode(" "));
+  var code = document.createElement("code");
+  code.textContent = codeText;
+  state.title.appendChild(code);
+}
+
 function ensureRowEditDialog(manager) {
   if (rowEditDialogState) {
     return rowEditDialogState;
@@ -1019,13 +1359,12 @@ function ensureRowEditDialog(manager) {
   dialog.id = ROW_EDIT_DIALOG_ID;
   dialog.className = "row-edit-dialog";
   dialog.setAttribute("aria-labelledby", "row-edit-title");
-  dialog.setAttribute("aria-describedby", "row-edit-summary");
   dialog.innerHTML = `
     <div class="modal-header">
       <span class="modal-title" id="row-edit-title">Edit row</span>
     </div>
     <form class="row-edit-form" method="post">
-      <p class="row-edit-summary" id="row-edit-summary">Editing row <span class="row-edit-id"></span></p>
+      <p class="row-edit-summary" id="row-edit-summary" hidden></p>
       <p class="row-edit-loading" role="status" aria-live="polite">Loading row...</p>
       <p class="row-edit-error" role="alert" tabindex="-1" hidden></p>
       <div class="row-edit-fields"></div>
@@ -1040,7 +1379,8 @@ function ensureRowEditDialog(manager) {
   rowEditDialogState = {
     dialog: dialog,
     form: dialog.querySelector(".row-edit-form"),
-    rowId: dialog.querySelector(".row-edit-id"),
+    title: dialog.querySelector(".modal-title"),
+    summary: dialog.querySelector(".row-edit-summary"),
     loading: dialog.querySelector(".row-edit-loading"),
     error: dialog.querySelector(".row-edit-error"),
     fields: dialog.querySelector(".row-edit-fields"),
@@ -1050,8 +1390,10 @@ function ensureRowEditDialog(manager) {
     currentRow: null,
     currentRowId: null,
     currentPkPath: null,
+    currentInsertUrl: null,
     currentUpdateUrl: null,
     currentFragmentUrl: null,
+    mode: "edit",
     loadId: 0,
     manager: manager,
     isLoading: false,
@@ -1130,10 +1472,12 @@ async function openRowEditDialog(button, manager) {
   }
 
   state.manager = manager;
+  state.mode = "edit";
   state.currentButton = button;
   state.currentRow = row;
   state.currentRowId = row.getAttribute("data-row") || "";
   state.currentPkPath = rowDisplayLabel(row);
+  state.currentInsertUrl = null;
   state.currentUpdateUrl = rowUpdateUrl(row);
   state.currentFragmentUrl = rowFragmentUrl(row);
   if (state.currentUpdateUrl) {
@@ -1149,7 +1493,10 @@ async function openRowEditDialog(button, manager) {
   clearRowEditDialogError(state);
   setRowEditDialogLoading(state, true);
   state.fields.innerHTML = "";
-  state.rowId.textContent = state.currentPkPath || "this row";
+  state.dialog.removeAttribute("aria-describedby");
+  setRowEditDialogTitle(state, "Edit row", state.currentPkPath || "this row");
+  state.summary.hidden = true;
+  state.summary.textContent = "";
 
   if (!state.dialog.open) {
     state.dialog.showModal();
@@ -1181,6 +1528,52 @@ async function openRowEditDialog(button, manager) {
   }
 }
 
+function openRowInsertDialog(button, manager) {
+  var insertData = tableInsertData();
+  if (!insertData) {
+    return;
+  }
+  var state = ensureRowEditDialog(manager);
+  if (!state) {
+    return;
+  }
+
+  state.manager = manager;
+  state.mode = "insert";
+  state.currentButton = button;
+  state.currentRow = null;
+  state.currentRowId = null;
+  state.currentPkPath = null;
+  state.currentInsertUrl = tableInsertUrl();
+  state.currentUpdateUrl = null;
+  state.currentFragmentUrl = null;
+  state.shouldRestoreFocus = true;
+  state.hasLoaded = false;
+  state.loadId += 1;
+
+  if (state.currentInsertUrl) {
+    state.form.action = new URL(state.currentInsertUrl, location.href).toString();
+  } else {
+    state.form.removeAttribute("action");
+  }
+
+  clearRowEditDialogError(state);
+  setRowEditDialogLoading(state, false);
+  state.fields.innerHTML = "";
+  state.dialog.removeAttribute("aria-describedby");
+  setRowEditDialogTitle(
+    state,
+    insertData.tableName ? "Insert row into " + insertData.tableName : "Insert row",
+  );
+  state.summary.hidden = true;
+  state.summary.textContent = "";
+
+  if (!state.dialog.open) {
+    state.dialog.showModal();
+  }
+  renderRowInsertFields(state, insertData);
+}
+
 function initRowEditActions(manager) {
   if (!window.fetch || !window.HTMLDialogElement) {
     return;
@@ -1195,6 +1588,20 @@ function initRowEditActions(manager) {
   });
 }
 
+function initRowInsertActions(manager) {
+  if (!window.fetch || !window.HTMLDialogElement || !tableInsertData()) {
+    return;
+  }
+  document.addEventListener("click", function (ev) {
+    var button = ev.target.closest('button[data-table-action="insert-row"]');
+    if (!button) {
+      return;
+    }
+    ev.preventDefault();
+    openRowInsertDialog(button, manager);
+  });
+}
+
 function canChooseColumns() {
   return !!(
     document.querySelector("column-chooser") && window._columnChooserData
@@ -1590,6 +1997,7 @@ document.addEventListener("datasette_init", function (evt) {
 
   // Main table
   initDatasetteTable(manager);
+  initRowInsertActions(manager);
   initRowEditActions(manager);
   initRowDeleteActions(manager);
 
diff --git a/datasette/templates/table.html b/datasette/templates/table.html
index 026599cc..5a4e7a68 100644
--- a/datasette/templates/table.html
+++ b/datasette/templates/table.html
@@ -4,7 +4,11 @@
 
 {% block extra_head %}
 {{- super() -}}
+{% if table_insert_ui %}
+<script>window._datasetteTableData = {{ {"tableUrl": urls.table(database, table), "insertRow": table_insert_ui}|tojson }};</script>
+{% else %}
 <script>window._datasetteTableData = {{ {"tableUrl": urls.table(database, table)}|tojson }};</script>
+{% endif %}
 <script src="{{ urls.static('column-chooser.js') }}" defer></script>
 <script src="{{ urls.static('table.js') }}?hash={{ table_js_hash }}" defer></script>
 <script src="{{ urls.static('mobile-column-actions.js') }}" defer></script>
@@ -159,6 +163,19 @@ window._setColumnTypeData = {{ set_column_type_ui|tojson }};
 </script>
 {% endif %}
 
+{% if table_insert_ui %}
+<div class="table-row-toolbar">
+    <button type="button" class="core table-insert-row" data-table-action="insert-row">
+        <svg class="row-inline-action-icon" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
+            <rect width="18" height="18" x="3" y="3" rx="2"></rect>
+            <path d="M8 12h8"></path>
+            <path d="M12 8v8"></path>
+        </svg>
+        <span>Insert row</span>
+    </button>
+</div>
+{% endif %}
+
 {% include custom_table_templates %}
 
 {% if next_url %}
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 33357165..c58e39f3 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -6,6 +6,7 @@ import urllib.parse
 
 import markupsafe
 
+from datasette.column_types import SQLiteType
 from datasette.extras import extra_names_from_request
 from datasette.plugins import pm
 from datasette.events import (
@@ -223,6 +224,68 @@ async def _validate_column_types(datasette, database_name, table_name, rows):
     return errors
 
 
+def _column_value_type_for_insert_form(column_detail, column_type):
+    if column_type is not None and column_type.name == "json":
+        return "json"
+    sqlite_type = SQLiteType.from_declared_type(column_detail.type)
+    if sqlite_type in (SQLiteType.INTEGER, SQLiteType.REAL):
+        return "number"
+    return "string"
+
+
+async def _table_insert_ui(
+    datasette, request, db, database_name, table_name, is_view, pks
+):
+    if is_view or not db.is_mutable:
+        return None
+
+    if not await datasette.allowed(
+        action="insert-row",
+        resource=TableResource(database=database_name, table=table_name),
+        actor=request.actor,
+    ):
+        return None
+
+    column_types_map = await datasette.get_column_types(database_name, table_name)
+    columns = []
+    column_details = await db.table_column_details(table_name)
+    for column in column_details:
+        if column.hidden:
+            continue
+        is_pk = column.name in pks
+        is_auto_pk = (
+            is_pk
+            and len(pks) == 1
+            and SQLiteType.from_declared_type(column.type) == SQLiteType.INTEGER
+        )
+        if is_auto_pk:
+            continue
+        column_type = column_types_map.get(column.name)
+        columns.append(
+            {
+                "name": column.name,
+                "type": column.type,
+                "notnull": column.notnull,
+                "default": column.default_value,
+                "has_default": column.default_value is not None,
+                "is_pk": is_pk,
+                "value_type": _column_value_type_for_insert_form(column, column_type),
+                "column_type": (
+                    {"type": column_type.name, "config": column_type.config}
+                    if column_type is not None
+                    else None
+                ),
+            }
+        )
+
+    return {
+        "path": "{}/-/insert".format(datasette.urls.table(database_name, table_name)),
+        "tableName": table_name,
+        "columns": columns,
+        "primaryKeys": pks,
+    }
+
+
 async def display_columns_and_rows(
     datasette,
     database_name,
@@ -1753,6 +1816,9 @@ async def table_view_data(
                 sort = "rowid"
         data["sort"] = sort
         data["sort_desc"] = sort_desc
+        data["table_insert_ui"] = await _table_insert_ui(
+            datasette, request, db, database_name, table_name, is_view, pks
+        )
 
     return data, rows[:page_size], columns, expanded_columns, sql, next_url
 
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 4e24f129..71d4b852 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -8,6 +8,21 @@ import urllib.parse
 from .utils import inner_html
 
 
+def table_data_from_soup(soup):
+    import json
+    import re
+
+    table_script = [
+        s for s in soup.find_all("script") if "_datasetteTableData" in (s.string or "")
+    ][0]
+    match = re.search(
+        r"window\._datasetteTableData\s*=\s*({.*?});",
+        table_script.string,
+        re.DOTALL,
+    )
+    return json.loads(match.group(1))
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "path,expected_definition_sql",
@@ -864,24 +879,12 @@ async def test_row_delete_action_data_attributes():
         response = await ds.client.get("/data/items", actor={"id": "root"})
         assert response.status_code == 200
         soup = Soup(response.text, "html.parser")
-        import json
-        import re
-
-        table_script = [
-            s for s in soup.find_all("script") if "_datasetteTableData" in (s.string or "")
-        ][0]
-        match = re.search(
-            r"window\._datasetteTableData\s*=\s*({.*?});",
-            table_script.string,
-            re.DOTALL,
-        )
-        assert json.loads(match.group(1)) == {"tableUrl": "/data/items"}
+        assert table_data_from_soup(soup) == {"tableUrl": "/data/items"}
+        assert soup.select_one('button[data-table-action="insert-row"]') is None
 
         row = soup.select_one("table.rows-and-columns tbody tr")
         assert row["data-row"] == "1"
-        assert {
-            key for key in row.attrs if key.startswith("data-row")
-        } == {"data-row"}
+        assert {key for key in row.attrs if key.startswith("data-row")} == {"data-row"}
 
         edit_button = row.select_one(
             'button.row-inline-action-edit[data-row-action="edit"]'
@@ -902,6 +905,124 @@ async def test_row_delete_action_data_attributes():
         ds.close()
 
 
+@pytest.mark.asyncio
+async def test_table_insert_action_button_and_data():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "tables": {
+                        "items": {
+                            "permissions": {
+                                "insert-row": {"id": "root"},
+                            },
+                        },
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_table_insert_action"), name="data"
+        )
+        await db.execute_write_script("""
+            create table items (
+                id integer primary key,
+                name text not null,
+                score integer default 5,
+                created text default (datetime('now')),
+                body text
+            );
+            """)
+        response = await ds.client.get("/data/items", actor={"id": "root"})
+        assert response.status_code == 200
+        soup = Soup(response.text, "html.parser")
+
+        button = soup.select_one(
+            'button.table-insert-row[data-table-action="insert-row"]'
+        )
+        assert button is not None
+        assert button.text.strip() == "Insert row"
+        assert button.find("svg") is not None
+        assert button.find_parent("div", class_="table-row-toolbar") is not None
+
+        insert_data = table_data_from_soup(soup)["insertRow"]
+        assert insert_data["path"] == "/data/items/-/insert"
+        assert insert_data["tableName"] == "items"
+        assert insert_data["primaryKeys"] == ["id"]
+        assert [column["name"] for column in insert_data["columns"]] == [
+            "name",
+            "score",
+            "created",
+            "body",
+        ]
+        name, score, created, body = insert_data["columns"]
+        assert name["notnull"] == 1
+        assert name["value_type"] == "string"
+        assert not name["has_default"]
+        assert score["default"] == "5"
+        assert score["has_default"]
+        assert score["value_type"] == "number"
+        assert created["default"] == "datetime('now')"
+        assert created["has_default"]
+        assert body["value_type"] == "string"
+    finally:
+        ds.close()
+
+
+@pytest.mark.asyncio
+async def test_table_insert_action_includes_compound_primary_keys():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "tables": {
+                        "memberships": {
+                            "permissions": {
+                                "insert-row": {"id": "root"},
+                            },
+                        },
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_table_insert_compound_pk"), name="data"
+        )
+        await db.execute_write_script("""
+            create table memberships (
+                account text,
+                username text,
+                role text,
+                primary key (account, username)
+            );
+            """)
+        response = await ds.client.get("/data/memberships", actor={"id": "root"})
+        assert response.status_code == 200
+        insert_data = table_data_from_soup(Soup(response.text, "html.parser"))[
+            "insertRow"
+        ]
+        assert insert_data["tableName"] == "memberships"
+        assert insert_data["primaryKeys"] == ["account", "username"]
+        assert [column["name"] for column in insert_data["columns"]] == [
+            "account",
+            "username",
+            "role",
+        ]
+        assert [column["is_pk"] for column in insert_data["columns"]] == [
+            True,
+            True,
+            False,
+        ]
+    finally:
+        ds.close()
+
+
 @pytest.mark.asyncio
 async def test_table_fragment_endpoint(ds_client):
     response = await ds_client.get("/fixtures/simple_primary_key/-/fragment?_row=1")
@@ -912,9 +1033,7 @@ async def test_table_fragment_endpoint(ds_client):
     rows = soup.select("[data-row]")
     assert len(rows) == 1
     assert rows[0]["data-row"] == "1"
-    assert {
-        key for key in rows[0].attrs if key.startswith("data-row")
-    } == {"data-row"}
+    assert {key for key in rows[0].attrs if key.startswith("data-row")} == {"data-row"}
 
 
 @pytest.mark.asyncio
@@ -979,9 +1098,7 @@ async def test_table_fragment_uses_render_cell_hook():
     ds = Datasette(memory=True)
     await ds.invoke_startup()
     db = ds.add_memory_database("data")
-    await db.execute_write(
-        "create table items (id integer primary key, name text)"
-    )
+    await db.execute_write("create table items (id integer primary key, name text)")
     await db.execute_write("insert into items values (1, 'Alice')")
     ds.pm.register(TestRenderCellPlugin(), name="TestRenderCellPlugin")
     try:

From e91c646ee6890b564cc9433c86d21b2ac5804f5b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 21:43:48 -0700
Subject: [PATCH 195/386] Use column label, if available in edit/delete dialog

---
 datasette/static/app.css        | 30 ++++++++++++++++++++++-
 datasette/static/table.js       | 42 ++++++++++++++++++++++++++-------
 datasette/templates/_table.html |  2 +-
 datasette/views/table.py        | 28 ++++++++++++++++++++--
 tests/test_table_html.py        | 19 +++++++++++----
 5 files changed, 105 insertions(+), 16 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 9226580b..8e68c1bf 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1264,9 +1264,15 @@ dialog.row-delete-dialog::backdrop {
     justify-content: flex-start;
     gap: 12px;
     flex-shrink: 0;
+    min-width: 0;
 }
 
 .row-delete-dialog .modal-title {
+    display: flex;
+    align-items: center;
+    gap: 0.35rem;
+    min-width: 0;
+    max-width: 100%;
     font-size: 1rem;
     font-weight: 600;
     color: var(--ink);
@@ -1388,16 +1394,30 @@ dialog.row-edit-dialog::backdrop {
     align-items: center;
     gap: 12px;
     flex-shrink: 0;
+    min-width: 0;
 }
 
 .row-edit-dialog .modal-title {
+    display: flex;
+    align-items: center;
+    gap: 0.35rem;
+    min-width: 0;
+    max-width: 100%;
     font-size: 1rem;
     font-weight: 600;
     color: var(--ink);
 }
 
-.row-edit-dialog .modal-title code {
+.row-edit-dialog .modal-title .row-dialog-action,
+.row-delete-dialog .modal-title .row-dialog-action {
+    flex: 0 0 auto;
+    white-space: nowrap;
+}
+
+.row-edit-dialog .modal-title code,
+.row-delete-dialog .modal-title code {
     display: inline;
+    flex: 0 0 auto;
     padding: 2px 5px;
     border: 1px solid var(--rule);
     border-radius: 4px;
@@ -1407,6 +1427,14 @@ dialog.row-edit-dialog::backdrop {
     overflow-wrap: anywhere;
 }
 
+.row-edit-dialog .modal-title .row-dialog-label,
+.row-delete-dialog .modal-title .row-dialog-label {
+    min-width: 0;
+    overflow: hidden;
+    text-overflow: ellipsis;
+    white-space: nowrap;
+}
+
 .row-edit-form {
     display: flex;
     flex: 1 1 auto;
diff --git a/datasette/static/table.js b/datasette/static/table.js
index c8109c62..53c4592b 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -471,6 +471,10 @@ function rowDisplayLabel(row) {
   return tildeDecode(row.getAttribute("data-row") || "");
 }
 
+function rowTitleLabel(row) {
+  return row.getAttribute("data-row-label") || "";
+}
+
 function tableBaseUrl() {
   var tableUrl =
     window._datasetteTableData && window._datasetteTableData.tableUrl;
@@ -607,6 +611,7 @@ function ensureRowDeleteDialog(manager) {
 
   rowDeleteDialogState = {
     dialog: dialog,
+    title: dialog.querySelector(".modal-title"),
     message: dialog.querySelector(".row-delete-message"),
     rowId: dialog.querySelector(".row-delete-id"),
     error: dialog.querySelector(".row-delete-error"),
@@ -741,6 +746,12 @@ function openRowDeleteDialog(button, manager) {
 
   clearRowDeleteDialogError(state);
   setRowDeleteDialogBusy(state, false);
+  setRowDialogTitle(
+    state.title,
+    "Delete row",
+    state.currentPkPath || "this row",
+    rowTitleLabel(row),
+  );
   state.rowId.textContent = state.currentPkPath || "this row";
 
   if (!state.dialog.open) {
@@ -1335,16 +1346,26 @@ function renderRowInsertFields(state, data) {
   (firstControl || state.saveButton).focus();
 }
 
-function setRowEditDialogTitle(state, text, codeText) {
-  state.title.textContent = "";
-  state.title.appendChild(document.createTextNode(text));
+function setRowDialogTitle(title, text, codeText, labelText) {
+  title.textContent = "";
+  var action = document.createElement("span");
+  action.className = "row-dialog-action";
+  action.textContent = text;
+  title.appendChild(action);
   if (!codeText) {
     return;
   }
-  state.title.appendChild(document.createTextNode(" "));
+  title.appendChild(document.createTextNode(" "));
   var code = document.createElement("code");
   code.textContent = codeText;
-  state.title.appendChild(code);
+  title.appendChild(code);
+  if (labelText && labelText !== codeText) {
+    title.appendChild(document.createTextNode(" "));
+    var label = document.createElement("span");
+    label.className = "row-dialog-label";
+    label.textContent = labelText;
+    title.appendChild(label);
+  }
 }
 
 function ensureRowEditDialog(manager) {
@@ -1494,7 +1515,12 @@ async function openRowEditDialog(button, manager) {
   setRowEditDialogLoading(state, true);
   state.fields.innerHTML = "";
   state.dialog.removeAttribute("aria-describedby");
-  setRowEditDialogTitle(state, "Edit row", state.currentPkPath || "this row");
+  setRowDialogTitle(
+    state.title,
+    "Edit row",
+    state.currentPkPath || "this row",
+    rowTitleLabel(row),
+  );
   state.summary.hidden = true;
   state.summary.textContent = "";
 
@@ -1561,8 +1587,8 @@ function openRowInsertDialog(button, manager) {
   setRowEditDialogLoading(state, false);
   state.fields.innerHTML = "";
   state.dialog.removeAttribute("aria-describedby");
-  setRowEditDialogTitle(
-    state,
+  setRowDialogTitle(
+    state.title,
     insertData.tableName ? "Insert row into " + insertData.tableName : "Insert row",
   );
   state.summary.hidden = true;
diff --git a/datasette/templates/_table.html b/datasette/templates/_table.html
index 38454da3..171b6442 100644
--- a/datasette/templates/_table.html
+++ b/datasette/templates/_table.html
@@ -22,7 +22,7 @@
         </thead>
         <tbody>
         {% for row in display_rows %}
-            <tr{% if row.pk_path is not none %} data-row="{{ row.row_path }}"{% endif %}>
+            <tr{% if row.pk_path is not none %} data-row="{{ row.row_path }}"{% if row.row_label %} data-row-label="{{ row.row_label }}"{% endif %}{% endif %}>
                 {% for cell in row %}
                     <td class="col-{{ cell.column|to_css_class }} type-{{ cell.value_type }}">{{ cell.value }}</td>
                 {% endfor %}
diff --git a/datasette/views/table.py b/datasette/views/table.py
index c58e39f3..c962637f 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -66,10 +66,12 @@ class Row:
         cells,
         pk_path=None,
         row_path=None,
+        row_label=None,
     ):
         self.cells = cells
         self.pk_path = pk_path
         self.row_path = row_path
+        self.row_label = row_label
 
     def __iter__(self):
         return iter(self.cells)
@@ -96,6 +98,20 @@ class Row:
         return json.dumps(d, default=repr, indent=2)
 
 
+def row_label_from_label_column(row, label_column):
+    if not label_column:
+        return None
+    try:
+        value = row[label_column]
+    except KeyError:
+        return None
+    if isinstance(value, dict):
+        value = value.get("label")
+    if value is None or value == "":
+        return None
+    return str(value)
+
+
 async def run_sequential(*args):
     # This used to be swappable for asyncio.gather() to run things in
     # parallel, but this lead to hard-to-debug locking issues with
@@ -325,6 +341,9 @@ async def display_columns_and_rows(
     pks_for_display = pks
     if not pks_for_display:
         pks_for_display = ["rowid"]
+    label_column = None
+    if link_column:
+        label_column = await db.label_column_for_table(table_name)
     row_action_permissions = {}
     if link_column and request is not None and db.is_mutable:
         row_action_permissions = await datasette.allowed_many(
@@ -372,6 +391,10 @@ async def display_columns_and_rows(
             is_special_link_column = len(pks) != 1
             pk_path = path_from_row_pks(row, pks, not pks, False)
             row_path = path_from_row_pks(row, pks, not pks)
+            row_label = row_label_from_label_column(row, label_column)
+            row_action_label = pk_path
+            if row_label and row_label != pk_path:
+                row_action_label = "{} {}".format(pk_path, row_label)
             table_path = datasette.urls.table(database_name, table_name)
             row_link = '<a href="{table_path}/{flat_pks_quoted}">{flat_pks}</a>'.format(
                 table_path=table_path,
@@ -407,7 +430,7 @@ async def display_columns_and_rows(
                     'data-row-action="edit">'
                     "{edit_icon}</button>".format(
                         edit_icon=edit_icon,
-                        row_label=markupsafe.escape(pk_path),
+                        row_label=markupsafe.escape(row_action_label),
                     )
                 )
             if row_action_permissions.get("delete-row"):
@@ -417,7 +440,7 @@ async def display_columns_and_rows(
                     'data-row-action="delete">'
                     "{delete_icon}</button>".format(
                         delete_icon=delete_icon,
-                        row_label=markupsafe.escape(pk_path),
+                        row_label=markupsafe.escape(row_action_label),
                     )
                 )
             if row_actions:
@@ -544,6 +567,7 @@ async def display_columns_and_rows(
                     cells,
                     pk_path=pk_path,
                     row_path=row_path,
+                    row_label=row_label,
                 )
             )
         else:
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 71d4b852..364457d9 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -682,8 +682,10 @@ async def test_table_html_compound_primary_key(ds_client):
     rows = table.select("tbody tr")
     assert rows[0]["data-row"] == "a,b"
     assert "data-row-pk-path" not in rows[0].attrs
+    assert "data-row-label" not in rows[0].attrs
     assert rows[1]["data-row"] == "a~2Fb,~2Ec-d"
     assert "data-row-pk-path" not in rows[1].attrs
+    assert "data-row-label" not in rows[1].attrs
 
 
 @pytest.mark.asyncio
@@ -884,13 +886,17 @@ async def test_row_delete_action_data_attributes():
 
         row = soup.select_one("table.rows-and-columns tbody tr")
         assert row["data-row"] == "1"
-        assert {key for key in row.attrs if key.startswith("data-row")} == {"data-row"}
+        assert row["data-row-label"] == "One"
+        assert {key for key in row.attrs if key.startswith("data-row")} == {
+            "data-row",
+            "data-row-label",
+        }
 
         edit_button = row.select_one(
             'button.row-inline-action-edit[data-row-action="edit"]'
         )
         assert edit_button is not None
-        assert edit_button["aria-label"] == "Edit row 1"
+        assert edit_button["aria-label"] == "Edit row 1 One"
         assert edit_button["title"] == "Edit row"
         assert edit_button.find("svg") is not None
 
@@ -898,7 +904,7 @@ async def test_row_delete_action_data_attributes():
             'button.row-inline-action-delete[data-row-action="delete"]'
         )
         assert button is not None
-        assert button["aria-label"] == "Delete row 1"
+        assert button["aria-label"] == "Delete row 1 One"
         assert button["title"] == "Delete row"
         assert button.find("svg") is not None
     finally:
@@ -1033,7 +1039,11 @@ async def test_table_fragment_endpoint(ds_client):
     rows = soup.select("[data-row]")
     assert len(rows) == 1
     assert rows[0]["data-row"] == "1"
-    assert {key for key in rows[0].attrs if key.startswith("data-row")} == {"data-row"}
+    assert rows[0]["data-row-label"] == "hello"
+    assert {key for key in rows[0].attrs if key.startswith("data-row")} == {
+        "data-row",
+        "data-row-label",
+    }
 
 
 @pytest.mark.asyncio
@@ -1046,6 +1056,7 @@ async def test_table_fragment_row_parameter_replaces_pk_filters(ds_client):
     rows = soup.select("[data-row]")
     assert len(rows) == 1
     assert rows[0]["data-row"] == "1"
+    assert rows[0]["data-row-label"] == "hello"
 
 
 def test_table_data_uses_base_url(app_client_base_url_prefix):

From a7cd746613bf419553e9373e97545be0c81de426 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 21:48:28 -0700
Subject: [PATCH 196/386] Use label column in 'Inserted X' messages

---
 datasette/static/table.js | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/datasette/static/table.js b/datasette/static/table.js
index 53c4592b..7d8f591d 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -475,6 +475,14 @@ function rowTitleLabel(row) {
   return row.getAttribute("data-row-label") || "";
 }
 
+function insertedRowStatusMessage(rowId, rowLabel) {
+  var message = "Inserted row " + rowId;
+  if (rowLabel && rowLabel !== rowId) {
+    message += " (" + rowLabel + ")";
+  }
+  return message + ".";
+}
+
 function tableBaseUrl() {
   var tableUrl =
     window._datasetteTableData && window._datasetteTableData.tableUrl;
@@ -1201,8 +1209,6 @@ async function saveRowEditDialog(state) {
 
       state.currentRowId = insertedRowId;
       state.currentFragmentUrl = rowFragmentUrlById(insertedRowId);
-      var insertedStatusMessage =
-        "Inserted row " + tildeDecode(insertedRowId) + ".";
       var insertedRow = null;
       try {
         insertedRow = await fetchUpdatedRowElement(state);
@@ -1217,6 +1223,10 @@ async function saveRowEditDialog(state) {
         return;
       }
       if (insertedRow) {
+        var insertedStatusMessage = insertedRowStatusMessage(
+          tildeDecode(insertedRowId),
+          rowTitleLabel(insertedRow),
+        );
         var addedRow = addInsertedRowToPage(insertedRow);
         state.dialog.close();
         showRowMutationStatus(state.manager, insertedStatusMessage, false);

From e1e67e912a3b82bd4df4c8d35a047dc6de80b207 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 21:58:16 -0700
Subject: [PATCH 197/386] Docs for /<database>/<table>/-/fragment

---
 docs/pages.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/pages.rst b/docs/pages.rst
index a8ff7c37..ce88be12 100644
--- a/docs/pages.rst
+++ b/docs/pages.rst
@@ -118,6 +118,16 @@ Some examples:
 * `../antiquities-act%2Factions_under_antiquities_act <https://fivethirtyeight.datasettes.com/fivethirtyeight/antiquities-act%2Factions_under_antiquities_act>`_ is an interface for exploring the "actions under the antiquities act" data table published by FiveThirtyEight.
 * `../global-power-plants?country_long=United+Kingdom&primary_fuel=Gas <https://datasette.io/global-power-plants/global-power-plants?_facet=primary_fuel&_facet=owner&_facet=country_long&country_long__exact=United+Kingdom&primary_fuel=Gas>`_ is a filtered table page showing every Gas power plant in the United Kingdom. It includes some default facets (configured using `its metadata.json <https://datasette.io/-/metadata>`_) and uses the `datasette-cluster-map <https://github.com/simonw/datasette-cluster-map>`_ plugin to show a map of the results.
 
+.. _TableFragmentView:
+
+Table fragment
+--------------
+
+The ``/<database>/<table>/-/fragment`` endpoint returns the rendered table HTML
+for rows matching the provided filters. It is used by Datasette's row editing
+interface to refresh rows after changes while still respecting custom table
+templates and ``render_cell`` plugin hooks.
+
 .. _RowView:
 
 Row

From 2b61c916d009aed4db9a5c402cdbe5538102758c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 22:01:26 -0700
Subject: [PATCH 198/386] Handle hidden label columns in row actions

---
 datasette/views/table.py |  2 +-
 tests/test_table_html.py | 23 +++++++++++++++++++++--
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index c962637f..d1928fae 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -103,7 +103,7 @@ def row_label_from_label_column(row, label_column):
         return None
     try:
         value = row[label_column]
-    except KeyError:
+    except (KeyError, IndexError):
         return None
     if isinstance(value, dict):
         value = value.get("label")
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 364457d9..699c1c1c 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -875,8 +875,8 @@ async def test_row_delete_action_data_attributes():
             Database(ds, memory_name="test_row_delete_actions"), name="data"
         )
         await db.execute_write_script("""
-            create table items (id integer primary key, name text);
-            insert into items (id, name) values (1, 'One');
+            create table items (id integer primary key, name text, score integer);
+            insert into items (id, name, score) values (1, 'One', 5);
             """)
         response = await ds.client.get("/data/items", actor={"id": "root"})
         assert response.status_code == 200
@@ -907,6 +907,25 @@ async def test_row_delete_action_data_attributes():
         assert button["aria-label"] == "Delete row 1 One"
         assert button["title"] == "Delete row"
         assert button.find("svg") is not None
+
+        response = await ds.client.get("/data/items?_col=score", actor={"id": "root"})
+        assert response.status_code == 200
+        soup = Soup(response.text, "html.parser")
+        row = soup.select_one("table.rows-and-columns tbody tr")
+        assert row["data-row"] == "1"
+        assert "data-row-label" not in row.attrs
+
+        edit_button = row.select_one(
+            'button.row-inline-action-edit[data-row-action="edit"]'
+        )
+        assert edit_button is not None
+        assert edit_button["aria-label"] == "Edit row 1"
+
+        button = row.select_one(
+            'button.row-inline-action-delete[data-row-action="delete"]'
+        )
+        assert button is not None
+        assert button["aria-label"] == "Delete row 1"
     finally:
         ds.close()
 

From 5490c7b7948202e024d05aa4752be4565cf3d34a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 22:18:45 -0700
Subject: [PATCH 199/386] textarea column type

Shows as multiline edit in edit/insert dialog
---
 datasette/default_column_types.py | 8 +++++++-
 datasette/static/table.js         | 9 ++++++---
 docs/configuration.rst            | 9 ++++++---
 docs/plugin_hooks.rst             | 2 +-
 tests/test_column_types.py        | 7 +++++++
 tests/test_table_html.py          | 2 ++
 6 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/datasette/default_column_types.py b/datasette/default_column_types.py
index 24493994..f90a733e 100644
--- a/datasette/default_column_types.py
+++ b/datasette/default_column_types.py
@@ -76,6 +76,12 @@ class JsonColumnType(ColumnType):
         return None
 
 
+class TextareaColumnType(ColumnType):
+    name = "textarea"
+    description = "Multiline text"
+    sqlite_types = (SQLiteType.TEXT,)
+
+
 @hookimpl
 def register_column_types(datasette):
-    return [UrlColumnType, EmailColumnType, JsonColumnType]
+    return [UrlColumnType, EmailColumnType, JsonColumnType, TextareaColumnType]
diff --git a/datasette/static/table.js b/datasette/static/table.js
index 7d8f591d..f762ca40 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -792,12 +792,15 @@ function valueToEditText(value) {
   return String(value);
 }
 
-function shouldUseTextarea(value) {
+function shouldUseTextarea(value, columnType) {
+  if (columnType && columnType.type === "textarea") {
+    return true;
+  }
   if (value && typeof value === "object") {
     return true;
   }
   var text = valueToEditText(value);
-  return text.length > 80 || text.indexOf("\n") !== -1;
+  return text.length > 80 || /[\r\n]/.test(text);
 }
 
 function rowEditValueType(value) {
@@ -835,7 +838,7 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   var controlWrap = document.createElement("div");
   controlWrap.className = "row-edit-control-wrap";
 
-  var control = shouldUseTextarea(value)
+  var control = shouldUseTextarea(value, columnType)
     ? document.createElement("textarea")
     : document.createElement("input");
   control.className = "row-edit-input";
diff --git a/docs/configuration.rst b/docs/configuration.rst
index 9213a640..d01f5153 100644
--- a/docs/configuration.rst
+++ b/docs/configuration.rst
@@ -1102,9 +1102,9 @@ These configure :ref:`full-text search <full_text_search>` for a table or view.
 ``column_types``
 ^^^^^^^^^^^^^^^^
 
-You can assign semantic column types to columns, which affect how values are rendered, validated, and transformed. Built-in column types include ``url``, ``email``, and ``json``. Plugins can register additional column types using the :ref:`register_column_types <plugin_register_column_types>` plugin hook.
+You can assign semantic column types to columns, which affect how values are rendered, validated, transformed, and edited. Built-in column types include ``url``, ``email``, ``json``, and ``textarea``. Plugins can register additional column types using the :ref:`register_column_types <plugin_register_column_types>` plugin hook.
 
-Column types can optionally declare which SQLite column types they apply to using ``sqlite_types``. Datasette will reject incompatible assignments. The built-in ``url``, ``email``, and ``json`` column types are all restricted to ``TEXT`` columns.
+Column types can optionally declare which SQLite column types they apply to using ``sqlite_types``. Datasette will reject incompatible assignments. The built-in ``url``, ``email``, ``json``, and ``textarea`` column types are all restricted to ``TEXT`` columns.
 
 The simplest form maps column names to type name strings:
 
@@ -1119,6 +1119,7 @@ The simplest form maps column names to type name strings:
                   website: url
                   contact: email
                   extra_data: json
+                  notes: textarea
       """).strip()
     )
 .. ]]]
@@ -1135,6 +1136,7 @@ The simplest form maps column names to type name strings:
                   website: url
                   contact: email
                   extra_data: json
+                  notes: textarea
 
 .. tab:: datasette.json
 
@@ -1148,7 +1150,8 @@ The simplest form maps column names to type name strings:
                   "column_types": {
                     "website": "url",
                     "contact": "email",
-                    "extra_data": "json"
+                    "extra_data": "json",
+                    "notes": "textarea"
                   }
                 }
               }
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 2a0ddc93..7ae52a68 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1092,7 +1092,7 @@ Column types are assigned to columns via the :ref:`column_types <table_configura
                 config:
                   format: rgb
 
-Datasette includes three built-in column types: ``url``, ``email``, and ``json``.
+Datasette includes four built-in column types: ``url``, ``email``, ``json``, and ``textarea``. The ``textarea`` type is an editing hint that causes Datasette's insert/edit forms to use a multiline ``<textarea>`` control for that column.
 
 .. _plugin_asgi_wrapper:
 
diff --git a/tests/test_column_types.py b/tests/test_column_types.py
index d77f2cf5..0c6b0dd4 100644
--- a/tests/test_column_types.py
+++ b/tests/test_column_types.py
@@ -494,6 +494,7 @@ async def test_builtin_column_types_registered(ds_ct):
     assert "url" in ds_ct._column_types
     assert "email" in ds_ct._column_types
     assert "json" in ds_ct._column_types
+    assert "textarea" in ds_ct._column_types
     assert "nonexistent" not in ds_ct._column_types
 
 
@@ -510,6 +511,10 @@ async def test_column_type_class_attributes(ds_ct):
     assert email_cls.sqlite_types == (SQLiteType.TEXT,)
     json_cls = ds_ct._column_types["json"]
     assert json_cls.sqlite_types == (SQLiteType.TEXT,)
+    textarea_cls = ds_ct._column_types["textarea"]
+    assert textarea_cls.name == "textarea"
+    assert textarea_cls.description == "Multiline text"
+    assert textarea_cls.sqlite_types == (SQLiteType.TEXT,)
 
 
 def test_sqlite_type_from_declared_type():
@@ -941,6 +946,7 @@ async def test_set_column_type_ui_data_includes_applicable_types(
         "options": [
             {"name": "email", "description": "Email address"},
             {"name": "json", "description": "JSON data"},
+            {"name": "textarea", "description": "Multiline text"},
             {"name": "url", "description": "URL"},
         ],
     }
@@ -949,6 +955,7 @@ async def test_set_column_type_ui_data_includes_applicable_types(
         "options": [
             {"name": "email", "description": "Email address"},
             {"name": "json", "description": "JSON data"},
+            {"name": "textarea", "description": "Multiline text"},
             {"name": "url", "description": "URL"},
         ],
     }
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 699c1c1c..c0af996f 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -942,6 +942,7 @@ async def test_table_insert_action_button_and_data():
                             "permissions": {
                                 "insert-row": {"id": "root"},
                             },
+                            "column_types": {"body": "textarea"},
                         },
                     },
                 },
@@ -993,6 +994,7 @@ async def test_table_insert_action_button_and_data():
         assert created["default"] == "datetime('now')"
         assert created["has_default"]
         assert body["value_type"] == "string"
+        assert body["column_type"] == {"type": "textarea", "config": None}
     finally:
         ds.close()
 

From b868f7d4c36888e4c7d7525cbbe2071103480d42 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 22:40:03 -0700
Subject: [PATCH 200/386] /db/table/-/autocomplete?q= JSON endpoint

Needed to help implement edit foreign key reference.
---
 datasette/app.py           |   5 +
 datasette/views/table.py   | 150 +++++++++++++++++++++++++++++
 docs/json_api.rst          |  42 +++++++++
 tests/test_autocomplete.py | 188 +++++++++++++++++++++++++++++++++++++
 4 files changed, 385 insertions(+)
 create mode 100644 tests/test_autocomplete.py

diff --git a/datasette/app.py b/datasette/app.py
index 4d7f483a..545b4588 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -82,6 +82,7 @@ from .views.special import (
     TableSchemaView,
 )
 from .views.table import (
+    TableAutocompleteView,
     TableInsertView,
     TableUpsertView,
     TableSetColumnTypeView,
@@ -2619,6 +2620,10 @@ class Datasette:
             TableFragmentView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/fragment$",
         )
+        add_route(
+            TableAutocompleteView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/autocomplete$",
+        )
         add_route(
             TableDropView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/drop$",
diff --git a/datasette/views/table.py b/datasette/views/table.py
index d1928fae..e3e448f6 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -15,6 +15,7 @@ from datasette.events import (
     InsertRowsEvent,
     UpsertRowsEvent,
 )
+from datasette.database import QueryInterrupted
 from datasette import tracer
 from datasette.resources import DatabaseResource, TableResource
 from datasette.utils import (
@@ -1111,6 +1112,155 @@ class TableFragmentView(BaseView):
         return Response.html(html)
 
 
+def _escape_like(value):
+    return value.replace("\\", "\\\\").replace("%", "\\%").replace("_", "\\_")
+
+
+# Returns the exclusive upper bound for an indexed prefix search:
+# "abc" -> "abd", so `pk >= "abc" and pk < "abd"` covers "abc%".
+# The LIKE clause is still applied separately for exact escaped-LIKE semantics.
+def _prefix_range_end(value):
+    if not value:
+        return None
+    characters = list(value)
+    for i in range(len(characters) - 1, -1, -1):
+        if ord(characters[i]) < 0x10FFFF:
+            return "{}{}".format("".join(characters[:i]), chr(ord(characters[i]) + 1))
+    return None
+
+
+def _autocomplete_like(column):
+    return "{} like :like escape char(92)".format(escape_sqlite(column))
+
+
+def _autocomplete_prefix_like(column):
+    return "{} like :prefix escape char(92)".format(escape_sqlite(column))
+
+
+def _autocomplete_order_by(pks, label_column, exact_pk, label_matches_first=True):
+    clauses = []
+    if exact_pk:
+        clauses.append(
+            "case when cast({} as text) = :q then 0 else 1 end".format(
+                escape_sqlite(pks[0])
+            )
+        )
+    if label_column:
+        label_like = _autocomplete_like(label_column)
+        if label_matches_first:
+            clauses.append("case when {} then 0 else 1 end".format(label_like))
+        clauses.append(
+            "case when {} then length(cast({} as text)) end".format(
+                label_like, escape_sqlite(label_column)
+            )
+        )
+    else:
+        clauses.append("length(cast({} as text))".format(escape_sqlite(pks[0])))
+    clauses.extend(escape_sqlite(pk) for pk in pks)
+    return ", ".join(clauses)
+
+
+def _autocomplete_pk_order_by(pks):
+    return ", ".join(escape_sqlite(pk) for pk in pks)
+
+
+def _autocomplete_response_rows(rows, pks, label_column):
+    response_rows = []
+    for row in rows:
+        item = {"pks": {pk: row[pk] for pk in pks}}
+        if label_column:
+            item["label"] = row[label_column]
+        response_rows.append(item)
+    return response_rows
+
+
+class TableAutocompleteView(BaseView):
+    name = "table-autocomplete"
+
+    async def get(self, request):
+        resolved = await self.ds.resolve_table(request)
+        if resolved.is_view:
+            raise BadRequest("Autocomplete is only available for tables")
+
+        db = resolved.db
+        database_name = db.name
+        table_name = resolved.table
+        visible, _ = await self.ds.check_visibility(
+            request.actor,
+            action="view-table",
+            resource=TableResource(database=database_name, table=table_name),
+        )
+        if not visible:
+            raise Forbidden("You do not have permission to view this table")
+
+        pks = await db.primary_keys(table_name)
+        if not pks:
+            pks = ["rowid"]
+        label_column = await db.label_column_for_table(table_name)
+        select_columns = list(
+            dict.fromkeys(pks + ([label_column] if label_column else []))
+        )
+        select_sql = ", ".join(escape_sqlite(column) for column in select_columns)
+        q = request.args.get("q") or ""
+        if not q:
+            return Response.json({"rows": []})
+        params = {
+            "q": q,
+            "like": "%{}%".format(_escape_like(q)),
+            "prefix": "{}%".format(_escape_like(q)),
+        }
+
+        like_columns = pks[:]
+        if label_column and label_column not in like_columns:
+            like_columns.append(label_column)
+        where_sql = " or ".join(_autocomplete_like(column) for column in like_columns)
+        exact_pk = len(pks) == 1
+        sql = """
+            select {select_sql}
+            from {table}
+            where {where}
+            order by {order_by}
+            limit 10
+        """.format(
+            select_sql=select_sql,
+            table=escape_sqlite(table_name),
+            where=where_sql,
+            order_by=_autocomplete_order_by(pks, label_column, exact_pk),
+        )
+
+        try:
+            results = await db.execute(sql, params, custom_time_limit=500)
+        except QueryInterrupted:
+            fallback_where = _autocomplete_prefix_like(pks[0])
+            prefix_end = _prefix_range_end(q)
+            if prefix_end:
+                params["prefix_end"] = prefix_end
+                first_pk = escape_sqlite(pks[0])
+                fallback_where = (
+                    "{first_pk} >= :q and {first_pk} < :prefix_end and {like}"
+                ).format(first_pk=first_pk, like=fallback_where)
+            fallback_sql = """
+                select {select_sql}
+                from {table}
+                where {where}
+                order by {order_by}
+                limit 10
+            """.format(
+                select_sql=select_sql,
+                table=escape_sqlite(table_name),
+                where=fallback_where,
+                order_by=_autocomplete_pk_order_by(pks),
+            )
+            try:
+                results = await db.execute(fallback_sql, params, custom_time_limit=500)
+            except QueryInterrupted:
+                return Response.json({"rows": []})
+
+        return Response.json(
+            {"rows": _autocomplete_response_rows(results.rows, pks, label_column)}
+        )
+
+
 async def _columns_to_select(table_columns, pks, request):
     columns = list(table_columns)
     if "_col" in request.args:
diff --git a/docs/json_api.rst b/docs/json_api.rst
index fbc3cf60..f7a0caae 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -1201,6 +1201,48 @@ The following extras are available for arbitrary SQL query responses and stored,
 
 .. [[[end]]]
 
+.. _TableAutocompleteView:
+
+Table autocomplete
+------------------
+
+The ``/<database>/<table>/-/autocomplete`` endpoint returns up to 10 primary key
+matches for a table, intended for building autocomplete interfaces such as
+foreign key pickers.
+
+::
+
+    GET /<database>/<table>/-/autocomplete?q=search
+
+The ``q`` parameter is required. If it is omitted or blank, the endpoint returns
+an empty ``"rows"`` list.
+
+The response includes a ``"pks"`` object containing the primary key value or
+values for each row. If Datasette can detect a label column, or one has been
+configured using ``label_column``, each row will also include ``"label"``:
+
+.. code-block:: json
+
+    {
+        "rows": [
+            {
+                "pks": {
+                    "id": 1
+                },
+                "label": "Example row"
+            }
+        ]
+    }
+
+The endpoint searches the primary key column or columns and the label column
+using escaped SQL ``LIKE`` queries. A single-column primary key exact match is
+returned first. Other matches are ordered by the shortest matching label value
+where a label column is available.
+
+The initial search runs with a 500ms time limit. If that query times out,
+Datasette falls back to a prefix match against the first primary key column so
+SQLite can use the primary key index.
+
 .. _table_arguments:
 
 Table arguments
diff --git a/tests/test_autocomplete.py b/tests/test_autocomplete.py
new file mode 100644
index 00000000..55e7458f
--- /dev/null
+++ b/tests/test_autocomplete.py
@@ -0,0 +1,188 @@
+import pytest
+
+from datasette.app import Datasette
+
+
+@pytest.mark.asyncio
+async def test_autocomplete_single_pk_exact_match_and_label_order():
+    ds = Datasette(memory=True)
+    db = ds.add_memory_database("autocomplete_single")
+    await db.execute_write_script("""
+        create table people (
+            id integer primary key,
+            name text
+        );
+        insert into people (id, name) values
+            (2, 'Longer non-label pk match'),
+            (20, '2'),
+            (21, '22'),
+            (200, 'A'),
+            (3, 'A label containing 2');
+        """)
+
+    response = await ds.client.get("/autocomplete_single/people/-/autocomplete?q=2")
+
+    assert response.status_code == 200
+    assert response.json() == {
+        "rows": [
+            {"pks": {"id": 2}, "label": "Longer non-label pk match"},
+            {"pks": {"id": 20}, "label": "2"},
+            {"pks": {"id": 21}, "label": "22"},
+            {"pks": {"id": 3}, "label": "A label containing 2"},
+            {"pks": {"id": 200}, "label": "A"},
+        ]
+    }
+
+
+@pytest.mark.asyncio
+async def test_autocomplete_blank_q_returns_no_results():
+    ds = Datasette(memory=True)
+    db = ds.add_memory_database("autocomplete_blank")
+    await db.execute_write_script("""
+        create table people (
+            id integer primary key,
+            name text
+        );
+        insert into people (id, name) values
+            (1, 'Alice'),
+            (2, 'Bob');
+        """)
+
+    response = await ds.client.get("/autocomplete_blank/people/-/autocomplete?q=")
+
+    assert response.status_code == 200
+    assert response.json() == {"rows": []}
+
+
+@pytest.mark.asyncio
+async def test_autocomplete_escapes_like_characters():
+    ds = Datasette(memory=True)
+    db = ds.add_memory_database("autocomplete_escape")
+    await db.execute_write_script("""
+        create table tags (
+            id integer primary key,
+            name text
+        );
+        insert into tags (id, name) values
+            (1, '100% real'),
+            (2, '100X real'),
+            (3, '100 percent real');
+        """)
+
+    response = await ds.client.get("/autocomplete_escape/tags/-/autocomplete?q=100%25")
+
+    assert response.status_code == 200
+    assert response.json() == {
+        "rows": [
+            {"pks": {"id": 1}, "label": "100% real"},
+        ]
+    }
+
+
+@pytest.mark.asyncio
+async def test_autocomplete_compound_pk_searches_all_pk_columns():
+    ds = Datasette(memory=True)
+    db = ds.add_memory_database("autocomplete_compound")
+    await db.execute_write_script("""
+        create table places (
+            country text,
+            code text,
+            name text,
+            primary key (country, code)
+        );
+        insert into places (country, code, name) values
+            ('us', 'ca', 'California'),
+            ('ca', 'bc', 'British Columbia'),
+            ('mx', 'ca', 'Campeche'),
+            ('zz', 'zz', 'Nothing');
+        """)
+
+    response = await ds.client.get("/autocomplete_compound/places/-/autocomplete?q=ca")
+
+    assert response.status_code == 200
+    assert response.json() == {
+        "rows": [
+            {"pks": {"country": "mx", "code": "ca"}, "label": "Campeche"},
+            {"pks": {"country": "us", "code": "ca"}, "label": "California"},
+            {"pks": {"country": "ca", "code": "bc"}, "label": "British Columbia"},
+        ]
+    }
+
+
+@pytest.mark.asyncio
+async def test_autocomplete_primary_key_called_label():
+    ds = Datasette(
+        memory=True,
+        config={
+            "databases": {
+                "autocomplete_label_pk": {
+                    "tables": {"things": {"label_column": "name"}}
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("autocomplete_label_pk")
+    await db.execute_write_script("""
+        create table things (
+            label text primary key,
+            name text
+        );
+        insert into things (label, name) values
+            ('abc', 'Display value'),
+            ('def', 'Other value');
+        """)
+
+    response = await ds.client.get("/autocomplete_label_pk/things/-/autocomplete?q=abc")
+
+    assert response.status_code == 200
+    assert response.json() == {
+        "rows": [
+            {"pks": {"label": "abc"}, "label": "Display value"},
+        ]
+    }
+
+
+@pytest.mark.asyncio
+async def test_autocomplete_timeout_uses_prefix_fallback():
+    ds = Datasette(
+        memory=True,
+        config={
+            "databases": {
+                "autocomplete_timeout": {"tables": {"things": {"label_column": "name"}}}
+            }
+        },
+        settings={
+            "num_sql_threads": 1,
+            "sql_time_limit_ms": 1,
+        },
+    )
+    db = ds.add_memory_database("autocomplete_timeout")
+    await db.execute_write_script("""
+        create table things (
+            id text primary key,
+            name text
+        );
+        insert into things (id, name) values
+            ('other-000001', 'item-1999 label-only match');
+        """)
+
+    def insert_rows(conn):
+        conn.executemany(
+            "insert into things (id, name) values (?, ?)",
+            ((f"item-{i:06d}", f"name {i:06d}") for i in range(200_000)),
+        )
+
+    await db.execute_write_fn(insert_rows)
+
+    response = await ds.client.get(
+        "/autocomplete_timeout/things/-/autocomplete?q=item-1999"
+    )
+
+    assert response.status_code == 200
+    data = response.json()
+    assert data == {
+        "rows": [
+            {"pks": {"id": f"item-1999{i:02d}"}, "label": f"name 1999{i:02d}"}
+            for i in range(10)
+        ]
+    }

From aa5fb7be3de3daaa26cd63eb1635fd024230f635 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sat, 13 Jun 2026 22:59:37 -0700
Subject: [PATCH 201/386] Autocomplete widget and /-/debug/autocomplete test
 page

---
 datasette/app.py                            |   5 +
 datasette/default_debug_menu.py             |   5 +
 datasette/static/app.css                    |  67 +++++
 datasette/static/autocomplete.js            | 291 ++++++++++++++++++++
 datasette/templates/debug_autocomplete.html |  78 ++++++
 datasette/views/special.py                  | 104 +++++++
 tests/test_debug_autocomplete.py            |  91 ++++++
 tests/test_jump.py                          |   1 +
 8 files changed, 642 insertions(+)
 create mode 100644 datasette/static/autocomplete.js
 create mode 100644 datasette/templates/debug_autocomplete.html
 create mode 100644 tests/test_debug_autocomplete.py

diff --git a/datasette/app.py b/datasette/app.py
index 545b4588..75cab1e7 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -66,6 +66,7 @@ from .views.index import IndexView
 from .views.special import (
     JsonDataView,
     PatternPortfolioView,
+    AutocompleteDebugView,
     AuthTokenView,
     ApiExplorerView,
     CreateTokenView,
@@ -2539,6 +2540,10 @@ class Datasette:
             wrap_view(PatternPortfolioView, self),
             r"/-/patterns$",
         )
+        add_route(
+            AutocompleteDebugView.as_view(self),
+            r"/-/debug/autocomplete$",
+        )
         add_route(
             wrap_view(database_download, self),
             r"/(?P<database>[^\/\.]+)\.db$",
diff --git a/datasette/default_debug_menu.py b/datasette/default_debug_menu.py
index 6127b2a6..8ea3c287 100644
--- a/datasette/default_debug_menu.py
+++ b/datasette/default_debug_menu.py
@@ -37,6 +37,11 @@ DEBUG_MENU_ITEMS = (
         "Debug allow rules",
         "Explore how allow blocks match actors against permission rules.",
     ),
+    (
+        "/-/debug/autocomplete",
+        "Debug autocomplete",
+        "Try out table autocomplete against a detected label column.",
+    ),
     (
         "/-/threads",
         "Debug threads",
diff --git a/datasette/static/app.css b/datasette/static/app.css
index 8e68c1bf..450324aa 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1600,6 +1600,73 @@ textarea.row-edit-input {
     margin: 0;
 }
 
+datasette-autocomplete {
+    display: block;
+    position: relative;
+    max-width: 38rem;
+}
+
+datasette-autocomplete input[type="text"],
+.debug-autocomplete-form input[type="text"] {
+    box-sizing: border-box;
+    width: 100%;
+    max-width: 38rem;
+}
+
+.datasette-autocomplete-list {
+    background: #fff;
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    box-shadow: 0 12px 24px rgba(15, 23, 42, 0.14);
+    box-sizing: border-box;
+    left: 0;
+    max-height: 16rem;
+    overflow-y: auto;
+    position: absolute;
+    right: 0;
+    top: calc(100% + 3px);
+    z-index: 20;
+}
+
+.datasette-autocomplete-list[hidden] {
+    display: none;
+}
+
+.datasette-autocomplete-option {
+    cursor: pointer;
+    padding: 7px 9px;
+}
+
+.datasette-autocomplete-option:hover,
+.datasette-autocomplete-option[aria-selected="true"] {
+    background: var(--paper);
+}
+
+.datasette-autocomplete-option[aria-selected="true"] {
+    background: #eef4ff;
+    box-shadow: inset 3px 0 0 #1a56db;
+}
+
+.datasette-autocomplete-status {
+    border: 0;
+    clip: rect(0 0 0 0);
+    height: 1px;
+    margin: -1px;
+    overflow: hidden;
+    padding: 0;
+    position: absolute;
+    white-space: nowrap;
+    width: 1px;
+}
+
+.debug-autocomplete-demo {
+    margin: 1rem 0;
+}
+
+.debug-autocomplete-selected {
+    max-width: 46rem;
+}
+
 .row-edit-dialog .modal-footer {
     padding: 14px 20px;
     border-top: 1px solid var(--rule);
diff --git a/datasette/static/autocomplete.js b/datasette/static/autocomplete.js
new file mode 100644
index 00000000..8a5bdc3d
--- /dev/null
+++ b/datasette/static/autocomplete.js
@@ -0,0 +1,291 @@
+(function () {
+  function autocompleteValueFromRow(row) {
+    var pks = (row && row.pks) || {};
+    var keys = Object.keys(pks);
+    if (!keys.length) {
+      return "";
+    }
+    if (keys.length === 1) {
+      return String(pks[keys[0]]);
+    }
+    return keys
+      .map(function (key) {
+        return key + "=" + pks[key];
+      })
+      .join(", ");
+  }
+
+  function autocompleteLabelFromRow(row) {
+    var value = autocompleteValueFromRow(row);
+    if (row.label && String(row.label) !== value) {
+      return row.label + " (" + value + ")";
+    }
+    return value;
+  }
+
+  if (!window.customElements || customElements.get("datasette-autocomplete")) {
+    return;
+  }
+
+  class DatasetteAutocomplete extends HTMLElement {
+    constructor() {
+      super();
+      this.input = null;
+      this.listbox = null;
+      this.status = null;
+      this.results = [];
+      this.activeIndex = -1;
+      this.fetchId = 0;
+      this.searchTimer = null;
+      this.boundInput = this.handleInput.bind(this);
+      this.boundKeydown = this.handleKeydown.bind(this);
+      this.boundBlur = this.handleBlur.bind(this);
+      this.boundFocus = this.handleFocus.bind(this);
+    }
+
+    connectedCallback() {
+      if (this.input) {
+        return;
+      }
+      this.input = this.querySelector("input");
+      if (!this.input) {
+        return;
+      }
+
+      var inputId =
+        this.input.id ||
+        "datasette-autocomplete-" + Math.random().toString(36).slice(2);
+      this.input.id = inputId;
+      var listboxId = inputId + "-listbox";
+      var statusId = inputId + "-status";
+
+      this.classList.add("datasette-autocomplete");
+      this.input.setAttribute("role", "combobox");
+      this.input.setAttribute("aria-autocomplete", "list");
+      this.input.setAttribute("aria-expanded", "false");
+      this.input.setAttribute("aria-controls", listboxId);
+      this.input.setAttribute("autocomplete", "off");
+
+      this.listbox = document.createElement("div");
+      this.listbox.className = "datasette-autocomplete-list";
+      this.listbox.id = listboxId;
+      this.listbox.setAttribute("role", "listbox");
+      this.listbox.hidden = true;
+
+      this.status = document.createElement("span");
+      this.status.className = "datasette-autocomplete-status";
+      this.status.id = statusId;
+      this.status.setAttribute("role", "status");
+      this.status.setAttribute("aria-live", "polite");
+
+      this.input.setAttribute(
+        "aria-describedby",
+        [this.input.getAttribute("aria-describedby"), statusId]
+          .filter(Boolean)
+          .join(" "),
+      );
+
+      this.appendChild(this.listbox);
+      this.appendChild(this.status);
+
+      this.input.addEventListener("input", this.boundInput);
+      this.input.addEventListener("keydown", this.boundKeydown);
+      this.input.addEventListener("blur", this.boundBlur);
+      this.input.addEventListener("focus", this.boundFocus);
+    }
+
+    disconnectedCallback() {
+      if (!this.input) {
+        return;
+      }
+      this.input.removeEventListener("input", this.boundInput);
+      this.input.removeEventListener("keydown", this.boundKeydown);
+      this.input.removeEventListener("blur", this.boundBlur);
+      this.input.removeEventListener("focus", this.boundFocus);
+    }
+
+    handleInput() {
+      this.scheduleSearch();
+    }
+
+    handleFocus() {
+      if (this.input.value.trim()) {
+        this.scheduleSearch();
+      }
+    }
+
+    handleBlur() {
+      window.setTimeout(() => this.close(), 150);
+    }
+
+    handleKeydown(ev) {
+      if (ev.key === "Escape") {
+        if (!this.listbox.hidden) {
+          ev.preventDefault();
+          this.close();
+        }
+        return;
+      }
+      if (ev.key === "ArrowDown") {
+        ev.preventDefault();
+        if (this.listbox.hidden) {
+          this.scheduleSearch();
+        } else {
+          this.setActiveIndex(this.activeIndex + 1);
+        }
+        return;
+      }
+      if (ev.key === "ArrowUp") {
+        ev.preventDefault();
+        if (!this.listbox.hidden) {
+          this.setActiveIndex(this.activeIndex - 1);
+        }
+        return;
+      }
+      if (ev.key === "Enter" && !this.listbox.hidden && this.activeIndex >= 0) {
+        ev.preventDefault();
+        this.chooseIndex(this.activeIndex);
+      }
+    }
+
+    scheduleSearch() {
+      window.clearTimeout(this.searchTimer);
+      this.searchTimer = window.setTimeout(() => this.search(), 150);
+    }
+
+    async search() {
+      var query = this.input.value.trim();
+      if (!query) {
+        this.close();
+        this.status.textContent = "";
+        return;
+      }
+      var src = this.getAttribute("src");
+      if (!src) {
+        return;
+      }
+
+      var url = new URL(src, location.href);
+      url.searchParams.set("q", query);
+      var fetchId = this.fetchId + 1;
+      this.fetchId = fetchId;
+      this.status.textContent = "Searching...";
+
+      try {
+        var response = await fetch(url.toString(), {
+          headers: {
+            Accept: "application/json",
+          },
+        });
+        if (!response.ok) {
+          throw new Error("HTTP " + response.status);
+        }
+        var data = await response.json();
+        if (fetchId !== this.fetchId) {
+          return;
+        }
+        this.results = (data && data.rows) || [];
+        this.render();
+      } catch (_error) {
+        if (fetchId !== this.fetchId) {
+          return;
+        }
+        this.results = [];
+        this.close();
+        this.status.textContent = "Could not load suggestions";
+      }
+    }
+
+    render() {
+      this.listbox.textContent = "";
+      this.activeIndex = -1;
+      if (!this.results.length) {
+        this.close();
+        this.status.textContent = "No matches";
+        return;
+      }
+
+      this.results.forEach((row, index) => {
+        var option = document.createElement("div");
+        option.className = "datasette-autocomplete-option";
+        option.id = this.input.id + "-option-" + index;
+        option.setAttribute("role", "option");
+        option.setAttribute("aria-selected", "false");
+        option.dataset.index = String(index);
+        option.dataset.value = autocompleteValueFromRow(row);
+        option.textContent = autocompleteLabelFromRow(row);
+        option.addEventListener("mousedown", (ev) => {
+          ev.preventDefault();
+          this.chooseIndex(index);
+        });
+        this.listbox.appendChild(option);
+      });
+
+      this.listbox.hidden = false;
+      this.input.setAttribute("aria-expanded", "true");
+      this.status.textContent =
+        this.results.length + (this.results.length === 1 ? " match" : " matches");
+      this.setActiveIndex(0);
+    }
+
+    setActiveIndex(index) {
+      var options = this.listbox.querySelectorAll("[role='option']");
+      if (!options.length) {
+        this.activeIndex = -1;
+        this.input.removeAttribute("aria-activedescendant");
+        return;
+      }
+      if (index < 0) {
+        index = options.length - 1;
+      }
+      if (index >= options.length) {
+        index = 0;
+      }
+      options.forEach((option, optionIndex) => {
+        option.setAttribute(
+          "aria-selected",
+          optionIndex === index ? "true" : "false",
+        );
+      });
+      this.activeIndex = index;
+      this.input.setAttribute("aria-activedescendant", options[index].id);
+    }
+
+    chooseIndex(index) {
+      var row = this.results[index];
+      if (!row) {
+        return;
+      }
+      var value = autocompleteValueFromRow(row);
+      var label = autocompleteLabelFromRow(row);
+      this.input.value = value;
+      this.input.dispatchEvent(new Event("change", { bubbles: true }));
+      this.close();
+      this.status.textContent = "Selected " + label;
+      this.dispatchEvent(
+        new CustomEvent("datasette-autocomplete-select", {
+          bubbles: true,
+          detail: {
+            row: row,
+            value: value,
+            label: label,
+          },
+        }),
+      );
+    }
+
+    close() {
+      if (this.listbox) {
+        this.listbox.hidden = true;
+        this.listbox.textContent = "";
+      }
+      if (this.input) {
+        this.input.setAttribute("aria-expanded", "false");
+        this.input.removeAttribute("aria-activedescendant");
+      }
+      this.activeIndex = -1;
+    }
+  }
+
+  customElements.define("datasette-autocomplete", DatasetteAutocomplete);
+})();
diff --git a/datasette/templates/debug_autocomplete.html b/datasette/templates/debug_autocomplete.html
new file mode 100644
index 00000000..84dbc14f
--- /dev/null
+++ b/datasette/templates/debug_autocomplete.html
@@ -0,0 +1,78 @@
+{% extends "base.html" %}
+
+{% block title %}Debug autocomplete{% endblock %}
+
+{% block extra_head %}
+{{ super() }}
+<script src="{{ urls.static('autocomplete.js') }}" defer></script>
+{% endblock %}
+
+{% block content %}
+<h1>Debug autocomplete</h1>
+
+<form class="core debug-autocomplete-form" action="{{ urls.path('-/debug/autocomplete') }}" method="get">
+    <p>
+        <label for="debug-autocomplete-database">Database</label>
+        <input id="debug-autocomplete-database" type="text" name="database" value="{{ database_name or "" }}">
+    </p>
+    <p>
+        <label for="debug-autocomplete-table">Table</label>
+        <input id="debug-autocomplete-table" type="text" name="table" value="{{ table_name or "" }}">
+    </p>
+    <p><input type="submit" value="Open autocomplete"></p>
+</form>
+
+{% if error %}
+    <p class="message-error">{{ error }}</p>
+{% elif autocomplete_url %}
+    <h2>{{ database_name }} / {{ table_name }}</h2>
+    {% if label_column %}
+        <p>Label column: <code>{{ label_column }}</code></p>
+    {% else %}
+        <p>No label column detected. Results will use primary key values.</p>
+    {% endif %}
+    <div class="debug-autocomplete-demo">
+        <label for="debug-autocomplete-input">Search rows</label>
+        <datasette-autocomplete src="{{ autocomplete_url }}">
+            <input id="debug-autocomplete-input" type="text">
+        </datasette-autocomplete>
+    </div>
+    <h3>Selected row</h3>
+    <pre class="debug-autocomplete-selected" aria-live="polite">No row selected.</pre>
+    <script>
+    document.addEventListener("datasette-autocomplete-select", function (event) {
+        var output = document.querySelector(".debug-autocomplete-selected");
+        if (output) {
+            output.textContent = JSON.stringify(event.detail.row, null, 2);
+        }
+    });
+    </script>
+{% else %}
+    <h2>Suggested tables</h2>
+    {% if suggestions %}
+        <p>Showing up to five tables with a detected label column.</p>
+        <table class="rows-and-columns">
+            <thead>
+                <tr>
+                    <th>Database</th>
+                    <th>Table</th>
+                    <th>Label column</th>
+                </tr>
+            </thead>
+            <tbody>
+                {% for suggestion in suggestions %}
+                    <tr>
+                        <td>{{ suggestion.database }}</td>
+                        <td><a href="{{ suggestion.url }}">{{ suggestion.table }}</a></td>
+                        <td><code>{{ suggestion.label_column }}</code></td>
+                    </tr>
+                {% endfor %}
+            </tbody>
+        </table>
+    {% else %}
+        <p>No tables with detected label columns found.</p>
+    {% endif %}
+    <p>Scanned {{ scanned }} table{% if scanned != 1 %}s{% endif %}{% if reached_scan_limit %}; stopped at the 100 table scan limit{% endif %}.</p>
+{% endif %}
+
+{% endblock %}
diff --git a/datasette/views/special.py b/datasette/views/special.py
index aa063ad6..3245bc13 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -91,6 +91,110 @@ class PatternPortfolioView(View):
         )
 
 
+class AutocompleteDebugView(BaseView):
+    name = "autocomplete_debug"
+    has_json_alternate = False
+
+    async def _suggested_tables(self, request):
+        scanned = 0
+        reached_scan_limit = False
+        suggestions = []
+        for database_name, db in self.ds.databases.items():
+            if scanned >= 100 or len(suggestions) >= 5:
+                break
+            remaining = 100 - scanned
+            results = await db.execute(
+                "select name from sqlite_master where type = 'table' order by name limit ?",
+                [remaining],
+            )
+            for row in results.rows:
+                table_name = row["name"]
+                scanned += 1
+                if scanned >= 100:
+                    reached_scan_limit = True
+                visible, _ = await self.ds.check_visibility(
+                    request.actor,
+                    action="view-table",
+                    resource=TableResource(database=database_name, table=table_name),
+                )
+                if not visible:
+                    if scanned >= 100:
+                        break
+                    continue
+                label_column = await db.label_column_for_table(table_name)
+                if label_column:
+                    suggestions.append(
+                        {
+                            "database": database_name,
+                            "table": table_name,
+                            "label_column": label_column,
+                            "url": self.ds.urls.path(
+                                "-/debug/autocomplete?"
+                                + urllib.parse.urlencode(
+                                    {
+                                        "database": database_name,
+                                        "table": table_name,
+                                    }
+                                )
+                            ),
+                        }
+                    )
+                    if len(suggestions) >= 5:
+                        break
+                if scanned >= 100:
+                    break
+        return suggestions, scanned, reached_scan_limit
+
+    async def get(self, request):
+        await self.ds.ensure_permission(action="view-instance", actor=request.actor)
+        database_name = request.args.get("database")
+        table_name = request.args.get("table")
+        context = {
+            "database_name": database_name,
+            "table_name": table_name,
+        }
+
+        if database_name or table_name:
+            if not database_name or not table_name:
+                context["error"] = "Both database and table are required."
+            elif database_name not in self.ds.databases:
+                context["error"] = "Database not found."
+            else:
+                db = self.ds.databases[database_name]
+                if not await db.table_exists(table_name):
+                    context["error"] = "Table not found."
+                else:
+                    await self.ds.ensure_permission(
+                        action="view-table",
+                        resource=TableResource(
+                            database=database_name,
+                            table=table_name,
+                        ),
+                        actor=request.actor,
+                    )
+                    context.update(
+                        {
+                            "autocomplete_url": "{}/-/autocomplete".format(
+                                self.ds.urls.table(database_name, table_name)
+                            ),
+                            "label_column": await db.label_column_for_table(table_name),
+                        }
+                    )
+        else:
+            suggestions, scanned, reached_scan_limit = await self._suggested_tables(
+                request
+            )
+            context.update(
+                {
+                    "suggestions": suggestions,
+                    "scanned": scanned,
+                    "reached_scan_limit": reached_scan_limit,
+                }
+            )
+
+        return await self.render(["debug_autocomplete.html"], request, context)
+
+
 class AuthTokenView(BaseView):
     name = "auth_token"
     has_json_alternate = False
diff --git a/tests/test_debug_autocomplete.py b/tests/test_debug_autocomplete.py
new file mode 100644
index 00000000..f438ace5
--- /dev/null
+++ b/tests/test_debug_autocomplete.py
@@ -0,0 +1,91 @@
+import pytest
+from bs4 import BeautifulSoup as Soup
+
+from datasette.app import Datasette
+from datasette.database import Database
+
+
+@pytest.mark.asyncio
+async def test_debug_autocomplete_for_table():
+    ds = Datasette(memory=True)
+    db = ds.add_database(
+        Database(ds, memory_name="test_debug_autocomplete_for_table"), name="data"
+    )
+    await db.execute_write_script("""
+        create table authors (
+            id integer primary key,
+            name text
+        );
+        insert into authors (id, name) values
+            (1, 'Ada Lovelace'),
+            (2, 'Grace Hopper');
+    """)
+
+    response = await ds.client.get("/-/debug/autocomplete?database=data&table=authors")
+
+    assert response.status_code == 200
+    soup = Soup(response.text, "html.parser")
+    assert soup.select_one("h1").text == "Debug autocomplete"
+    assert any(
+        "autocomplete.js" in (script.get("src") or "")
+        for script in soup.find_all("script")
+    )
+    autocomplete = soup.select_one("datasette-autocomplete")
+    assert autocomplete is not None
+    assert autocomplete["src"] == "/data/authors/-/autocomplete"
+    assert soup.select_one("input#debug-autocomplete-input") is not None
+    assert "Label column:" in response.text
+    assert "<code>name</code>" in response.text
+
+
+@pytest.mark.asyncio
+async def test_debug_autocomplete_suggests_label_column_tables():
+    ds = Datasette(memory=True)
+    db = ds.add_database(
+        Database(ds, memory_name="test_debug_autocomplete_suggests"), name="data"
+    )
+    await db.execute_write_script("""
+        create table authors (
+            id integer primary key,
+            name text
+        );
+        create table releases (
+            id integer primary key,
+            title text
+        );
+    """)
+
+    response = await ds.client.get("/-/debug/autocomplete")
+
+    assert response.status_code == 200
+    soup = Soup(response.text, "html.parser")
+    links = {a.text: a["href"] for a in soup.select("table.rows-and-columns a")}
+    assert links == {
+        "authors": "/-/debug/autocomplete?database=data&table=authors",
+        "releases": "/-/debug/autocomplete?database=data&table=releases",
+    }
+    assert [code.text for code in soup.select("table.rows-and-columns code")] == [
+        "name",
+        "title",
+    ]
+
+
+@pytest.mark.asyncio
+async def test_debug_autocomplete_scan_limit():
+    ds = Datasette(memory=True)
+    db = ds.add_database(
+        Database(ds, memory_name="test_debug_autocomplete_scan_limit"), name="data"
+    )
+    await db.execute_write_script(
+        "\n".join(
+            f"create table t{i:03d} (id integer primary key);" for i in range(100)
+        )
+        + "\ncreate table z_has_label (id integer primary key, name text);"
+    )
+
+    response = await ds.client.get("/-/debug/autocomplete")
+
+    assert response.status_code == 200
+    assert "No tables with detected label columns found." in response.text
+    assert "Scanned 100 tables; stopped at the 100 table scan limit." in response.text
+    assert "z_has_label" not in response.text
diff --git a/tests/test_jump.py b/tests/test_jump.py
index 513a809f..0fb6a552 100644
--- a/tests/test_jump.py
+++ b/tests/test_jump.py
@@ -191,6 +191,7 @@ async def test_debug_menu_items_are_in_jump_for_debug_menu_permission():
         "Debug permissions": "/-/permissions",
         "Debug messages": "/-/messages",
         "Debug allow rules": "/-/allow-debug",
+        "Debug autocomplete": "/-/debug/autocomplete",
         "Debug threads": "/-/threads",
         "Debug actor": "/-/actor",
         "Pattern portfolio": "/-/patterns",

From 574290fb231e45602c3efca3d35586a02f78ad37 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 07:30:34 -0700
Subject: [PATCH 202/386] Add foreign key autocomplete to row forms

Expose single-primary-key foreign key autocomplete URLs in table page metadata and load the autocomplete component when needed.

Enhance insert and edit dialogs to wrap foreign-key inputs with the autocomplete web component, show linked selected-row labels, reserve metadata space, and keep the dropdown as a fixed overlay above modal chrome.

Add an explicit _initial=1 autocomplete mode for empty-field starter suggestions while keeping blank q responses empty by default, with tests for the endpoint and table metadata.
---
 datasette/app.py                 |   5 +
 datasette/static/app.css         |  26 +++-
 datasette/static/autocomplete.js |  57 +++++++-
 datasette/static/table.js        | 219 ++++++++++++++++++++++++++++++-
 datasette/templates/table.html   |   9 +-
 datasette/views/table.py         |  76 ++++++++++-
 tests/test_autocomplete.py       |  47 +++++++
 tests/test_table_html.py         |  55 ++++++++
 8 files changed, 474 insertions(+), 20 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 75cab1e7..9b3cf51c 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2019,6 +2019,11 @@ class Datasette:
 
         other_table = fk["other_table"]
         other_column = fk["other_column"]
+        if other_column is None:
+            other_pks = await db.primary_keys(other_table)
+            if len(other_pks) != 1:
+                return {}
+            other_column = other_pks[0]
         visible, _ = await self.check_visibility(
             actor,
             action="view-table",
diff --git a/datasette/static/app.css b/datasette/static/app.css
index 450324aa..d0356b81 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1594,6 +1594,20 @@ textarea.row-edit-input {
     font-size: 0.78rem;
 }
 
+.row-edit-field-meta-autocomplete {
+    line-height: 1.2;
+    min-height: 1.2em;
+}
+
+.row-edit-fk-pk {
+    color: var(--ink);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+}
+
+.row-edit-fk-link {
+    overflow-wrap: anywhere;
+}
+
 .row-edit-empty {
     color: var(--muted);
     font-size: 0.9rem;
@@ -1622,10 +1636,10 @@ datasette-autocomplete input[type="text"],
     left: 0;
     max-height: 16rem;
     overflow-y: auto;
-    position: absolute;
-    right: 0;
-    top: calc(100% + 3px);
-    z-index: 20;
+    position: fixed;
+    right: auto;
+    top: auto;
+    z-index: 10000;
 }
 
 .datasette-autocomplete-list[hidden] {
@@ -1643,8 +1657,8 @@ datasette-autocomplete input[type="text"],
 }
 
 .datasette-autocomplete-option[aria-selected="true"] {
-    background: #eef4ff;
-    box-shadow: inset 3px 0 0 #1a56db;
+    background: var(--paper);
+    font-weight: 600;
 }
 
 .datasette-autocomplete-status {
diff --git a/datasette/static/autocomplete.js b/datasette/static/autocomplete.js
index 8a5bdc3d..c615000e 100644
--- a/datasette/static/autocomplete.js
+++ b/datasette/static/autocomplete.js
@@ -41,6 +41,7 @@
       this.boundKeydown = this.handleKeydown.bind(this);
       this.boundBlur = this.handleBlur.bind(this);
       this.boundFocus = this.handleFocus.bind(this);
+      this.boundPositionListbox = this.positionListbox.bind(this);
     }
 
     connectedCallback() {
@@ -109,7 +110,7 @@
     }
 
     handleFocus() {
-      if (this.input.value.trim()) {
+      if (this.input.value.trim() || this.hasAttribute("suggest-on-focus")) {
         this.scheduleSearch();
       }
     }
@@ -155,7 +156,8 @@
 
     async search() {
       var query = this.input.value.trim();
-      if (!query) {
+      var initial = !query && this.hasAttribute("suggest-on-focus");
+      if (!query && !initial) {
         this.close();
         this.status.textContent = "";
         return;
@@ -167,6 +169,11 @@
 
       var url = new URL(src, location.href);
       url.searchParams.set("q", query);
+      if (initial) {
+        url.searchParams.set("_initial", "1");
+      } else {
+        url.searchParams.delete("_initial");
+      }
       var fetchId = this.fetchId + 1;
       this.fetchId = fetchId;
       this.status.textContent = "Searching...";
@@ -225,9 +232,49 @@
       this.input.setAttribute("aria-expanded", "true");
       this.status.textContent =
         this.results.length + (this.results.length === 1 ? " match" : " matches");
+      this.positionListbox();
       this.setActiveIndex(0);
     }
 
+    positionListbox() {
+      if (!this.input || !this.listbox || this.listbox.hidden) {
+        return;
+      }
+
+      var gap = 3;
+      var margin = 8;
+      var inputRect = this.input.getBoundingClientRect();
+      this.listbox.style.maxHeight = "";
+      var defaultMaxHeight = parseFloat(
+        window.getComputedStyle(this.listbox).maxHeight,
+      );
+      if (!Number.isFinite(defaultMaxHeight)) {
+        defaultMaxHeight = 256;
+      }
+      var scrollHeight = Math.ceil(this.listbox.scrollHeight);
+      var desiredHeight = Math.min(scrollHeight, defaultMaxHeight);
+      var availableBelow = Math.max(
+        0,
+        (window.innerHeight || document.documentElement.clientHeight) -
+          inputRect.bottom -
+          gap -
+          margin,
+      );
+
+      this.listbox.style.left = inputRect.left + "px";
+      this.listbox.style.top = inputRect.bottom + gap + "px";
+      this.listbox.style.width = inputRect.width + "px";
+      if (scrollHeight <= defaultMaxHeight && scrollHeight <= availableBelow) {
+        this.listbox.style.maxHeight = "none";
+      } else {
+        this.listbox.style.maxHeight =
+          Math.min(defaultMaxHeight, desiredHeight, availableBelow || defaultMaxHeight) +
+          "px";
+      }
+      window.addEventListener("resize", this.boundPositionListbox);
+      document.addEventListener("scroll", this.boundPositionListbox, true);
+    }
+
     setActiveIndex(index) {
       var options = this.listbox.querySelectorAll("[role='option']");
       if (!options.length) {
@@ -278,11 +325,17 @@
       if (this.listbox) {
         this.listbox.hidden = true;
         this.listbox.textContent = "";
+        this.listbox.style.left = "";
+        this.listbox.style.maxHeight = "";
+        this.listbox.style.top = "";
+        this.listbox.style.width = "";
       }
       if (this.input) {
         this.input.setAttribute("aria-expanded", "false");
         this.input.removeAttribute("aria-activedescendant");
       }
+      window.removeEventListener("resize", this.boundPositionListbox);
+      document.removeEventListener("scroll", this.boundPositionListbox, true);
       this.activeIndex = -1;
     }
   }
diff --git a/datasette/static/table.js b/datasette/static/table.js
index f762ca40..43dd81d7 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -496,6 +496,158 @@ function tableInsertData() {
   return window._datasetteTableData && window._datasetteTableData.insertRow;
 }
 
+function tableForeignKeys() {
+  return (window._datasetteTableData && window._datasetteTableData.foreignKeys) || {};
+}
+
+function foreignKeyAutocompleteUrl(column) {
+  return tableForeignKeys()[column] || null;
+}
+
+function autocompleteRowPk(row) {
+  var pks = (row && row.pks) || {};
+  var keys = Object.keys(pks);
+  if (keys.length !== 1) {
+    return null;
+  }
+  return pks[keys[0]];
+}
+
+function foreignKeyRowUrl(autocompleteUrl, pk) {
+  var url = new URL(autocompleteUrl, location.href);
+  if (!/\/-\/autocomplete\/?$/.test(url.pathname)) {
+    return null;
+  }
+  url.pathname =
+    url.pathname.replace(/\/-\/autocomplete\/?$/, "") + "/" + tildeEncode(pk);
+  url.search = "";
+  url.hash = "";
+  return url.toString();
+}
+
+function foreignKeyLabelText(row) {
+  var pk = autocompleteRowPk(row);
+  var label = row && row.label;
+  if (
+    label !== null &&
+    typeof label !== "undefined" &&
+    String(label) !== String(pk)
+  ) {
+    return String(label);
+  }
+  return "View row";
+}
+
+function rowEditMetaTextWithoutCurrentValue(meta) {
+  return (meta.dataset.baseMeta || "")
+    .split(" · ")
+    .filter(function (part) {
+      return part !== "Current value: NULL";
+    })
+    .join(" · ");
+}
+
+function updateRowEditForeignKeySeparator(meta) {
+  var separator = meta.querySelector(".row-edit-fk-separator");
+  if (!separator) {
+    return;
+  }
+  var baseMeta = meta.querySelector(".row-edit-base-meta");
+  var hasBaseMeta = !!(baseMeta && baseMeta.textContent);
+  separator.textContent = hasBaseMeta ? " · " : "";
+  separator.hidden = !hasBaseMeta;
+}
+
+function updateRowEditFieldMetaHidden(meta) {
+  var baseMeta = meta.querySelector(".row-edit-base-meta");
+  var hasBaseMeta = !!(baseMeta && baseMeta.textContent);
+  var foreignKeyLinkWrap = meta.querySelector(".row-edit-fk-link-wrap");
+  var hasForeignKeyLink = foreignKeyLinkWrap && !foreignKeyLinkWrap.hidden;
+  meta.hidden =
+    meta.dataset.reserveSpace !== "1" && !hasBaseMeta && !hasForeignKeyLink;
+}
+
+function setRowEditBaseMetaText(meta, text) {
+  var baseMeta = meta.querySelector(".row-edit-base-meta");
+  if (!baseMeta) {
+    return;
+  }
+  baseMeta.textContent = text || "";
+  updateRowEditForeignKeySeparator(meta);
+  updateRowEditFieldMetaHidden(meta);
+}
+
+function setForeignKeyMetaLink(meta, autocompleteUrl, row) {
+  var wrap = meta.querySelector(".row-edit-fk-link-wrap");
+  if (!wrap) {
+    return;
+  }
+  var pkSpan = wrap.querySelector(".row-edit-fk-pk");
+  var link = wrap.querySelector("a");
+  var pk = autocompleteRowPk(row);
+  var url =
+    pk === null || typeof pk === "undefined"
+      ? null
+      : foreignKeyRowUrl(autocompleteUrl, pk);
+  if (!url) {
+    wrap.hidden = true;
+    pkSpan.textContent = "";
+    link.removeAttribute("href");
+    link.textContent = "";
+    link.removeAttribute("aria-label");
+    setRowEditBaseMetaText(meta, meta.dataset.baseMeta || "");
+    updateRowEditFieldMetaHidden(meta);
+    return;
+  }
+  setRowEditBaseMetaText(meta, rowEditMetaTextWithoutCurrentValue(meta));
+  var pkText = String(pk);
+  var linkText = foreignKeyLabelText(row);
+  pkSpan.textContent = pkText;
+  link.href = url;
+  link.textContent = linkText;
+  link.setAttribute(
+    "aria-label",
+    "Open referenced row " + pkText + " " + linkText + " in a new tab",
+  );
+  wrap.hidden = false;
+  updateRowEditFieldMetaHidden(meta);
+}
+
+async function resolveForeignKeyMetaLink(control, autocompleteUrl, meta) {
+  var value = control.value.trim();
+  if (!value) {
+    setForeignKeyMetaLink(meta, autocompleteUrl, null);
+    return;
+  }
+
+  var url = new URL(autocompleteUrl, location.href);
+  url.searchParams.set("q", value);
+  try {
+    var response = await fetch(url.toString(), {
+      headers: {
+        Accept: "application/json",
+      },
+    });
+    if (!response.ok) {
+      throw new Error("HTTP " + response.status);
+    }
+    var data = await response.json();
+    if (control.value.trim() !== value) {
+      return;
+    }
+    var rows = (data && data.rows) || [];
+    var row = rows.find(function (candidate) {
+      var pk = autocompleteRowPk(candidate);
+      return pk !== null && typeof pk !== "undefined" && String(pk) === value;
+    });
+    setForeignKeyMetaLink(meta, autocompleteUrl, row || null);
+  } catch (_error) {
+    if (control.value.trim() === value) {
+      setForeignKeyMetaLink(meta, autocompleteUrl, null);
+    }
+  }
+}
+
 function tableInsertUrl() {
   var data = tableInsertData();
   if (data && data.path) {
@@ -819,6 +971,17 @@ function rowEditValueType(value) {
   return "string";
 }
 
+function rowEditControlElement(control, autocompleteUrl) {
+  if (!autocompleteUrl || control.nodeName !== "INPUT") {
+    return control;
+  }
+  var autocomplete = document.createElement("datasette-autocomplete");
+  autocomplete.setAttribute("src", autocompleteUrl);
+  autocomplete.setAttribute("suggest-on-focus", "");
+  autocomplete.appendChild(control);
+  return autocomplete;
+}
+
 function createRowEditField(column, value, isPk, columnType, index, options) {
   options = options || {};
   var field = document.createElement("div");
@@ -871,6 +1034,10 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   var meta = document.createElement("span");
   meta.id = metaId;
   meta.className = "row-edit-field-meta";
+  if (options.autocompleteUrl) {
+    meta.classList.add("row-edit-field-meta-autocomplete");
+    meta.dataset.reserveSpace = "1";
+  }
   var metaParts = [];
   if (isPk) {
     metaParts.push("Primary key");
@@ -888,7 +1055,49 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   if (columnType && columnType.type) {
     metaParts.push("Custom type: " + columnType.type);
   }
-  meta.textContent = metaParts.join(" · ");
+  meta.dataset.baseMeta = metaParts.join(" · ");
+  var baseMeta = document.createElement("span");
+  baseMeta.className = "row-edit-base-meta";
+  baseMeta.textContent = meta.dataset.baseMeta;
+  meta.appendChild(baseMeta);
+  if (options.autocompleteUrl) {
+    var foreignKeyLinkWrap = document.createElement("span");
+    foreignKeyLinkWrap.className = "row-edit-fk-link-wrap";
+    foreignKeyLinkWrap.hidden = true;
+    var foreignKeySeparator = document.createElement("span");
+    foreignKeySeparator.className = "row-edit-fk-separator";
+    foreignKeySeparator.textContent = meta.dataset.baseMeta ? " · " : "";
+    foreignKeySeparator.hidden = !meta.dataset.baseMeta;
+    foreignKeyLinkWrap.appendChild(foreignKeySeparator);
+    var foreignKeyPk = document.createElement("span");
+    foreignKeyPk.className = "row-edit-fk-pk";
+    foreignKeyLinkWrap.appendChild(foreignKeyPk);
+    foreignKeyLinkWrap.appendChild(document.createTextNode(" "));
+    var foreignKeyLink = document.createElement("a");
+    foreignKeyLink.className = "row-edit-fk-link";
+    foreignKeyLink.target = "_blank";
+    foreignKeyLink.rel = "noopener noreferrer";
+    foreignKeyLinkWrap.appendChild(foreignKeyLink);
+    meta.appendChild(foreignKeyLinkWrap);
+    updateRowEditFieldMetaHidden(meta);
+  }
+  var controlElement = rowEditControlElement(control, options.autocompleteUrl);
+  if (options.autocompleteUrl) {
+    control.addEventListener("input", function () {
+      setForeignKeyMetaLink(meta, options.autocompleteUrl, null);
+    });
+    control.addEventListener("change", function () {
+      resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
+    });
+    controlElement.addEventListener("datasette-autocomplete-select", function (ev) {
+      setForeignKeyMetaLink(
+        meta,
+        options.autocompleteUrl,
+        ev.detail && ev.detail.row,
+      );
+    });
+    resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
+  }
 
   if (useDefaultInitially) {
     var defaultBlock = document.createElement("div");
@@ -939,14 +1148,14 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
 
     defaultBlock.appendChild(defaultText);
     defaultBlock.appendChild(setValueButton);
-    customWrap.appendChild(control);
+    customWrap.appendChild(controlElement);
     customWrap.appendChild(useDefaultButton);
     controlWrap.appendChild(defaultBlock);
     controlWrap.appendChild(customWrap);
   } else {
-    controlWrap.appendChild(control);
+    controlWrap.appendChild(controlElement);
   }
-  if (meta.textContent) {
+  if (meta.textContent || options.autocompleteUrl) {
     controlWrap.appendChild(meta);
   }
   field.appendChild(label);
@@ -1307,6 +1516,7 @@ function renderRowEditFields(state, data) {
         columnTypes[column],
         index,
         {
+          autocompleteUrl: foreignKeyAutocompleteUrl(column),
           primaryKeyReadonly: true,
         },
       ),
@@ -1333,6 +1543,7 @@ function renderRowInsertFields(state, data) {
         column.column_type,
         index,
         {
+          autocompleteUrl: foreignKeyAutocompleteUrl(column.name),
           defaultValue: column.default,
           hasDefault: column.has_default,
           notnull: column.notnull,
diff --git a/datasette/templates/table.html b/datasette/templates/table.html
index 5a4e7a68..81b51b28 100644
--- a/datasette/templates/table.html
+++ b/datasette/templates/table.html
@@ -4,12 +4,11 @@
 
 {% block extra_head %}
 {{- super() -}}
-{% if table_insert_ui %}
-<script>window._datasetteTableData = {{ {"tableUrl": urls.table(database, table), "insertRow": table_insert_ui}|tojson }};</script>
-{% else %}
-<script>window._datasetteTableData = {{ {"tableUrl": urls.table(database, table)}|tojson }};</script>
-{% endif %}
+<script>window._datasetteTableData = {{ table_page_data|tojson }};</script>
 <script src="{{ urls.static('column-chooser.js') }}" defer></script>
+{% if table_page_data.foreignKeys %}
+<script src="{{ urls.static('autocomplete.js') }}" defer></script>
+{% endif %}
 <script src="{{ urls.static('table.js') }}?hash={{ table_js_hash }}" defer></script>
 <script src="{{ urls.static('mobile-column-actions.js') }}" defer></script>
 <script>DATASETTE_ALLOW_FACET = {{ datasette_allow_facet }};</script>
diff --git a/datasette/views/table.py b/datasette/views/table.py
index e3e448f6..190529f4 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -250,6 +250,47 @@ def _column_value_type_for_insert_form(column_detail, column_type):
     return "string"
 
 
+async def _foreign_key_autocomplete_urls(
+    datasette, request, db, database_name, table_name
+):
+    autocomplete_urls = {}
+    for fk in await db.foreign_keys_for_table(table_name):
+        if not await db.table_exists(fk["other_table"]):
+            continue
+        other_pks = await db.primary_keys(fk["other_table"])
+        other_column = fk["other_column"]
+        if other_column is None and len(other_pks) == 1:
+            other_column = other_pks[0]
+        if len(other_pks) != 1 or other_column != other_pks[0]:
+            continue
+        visible, _ = await datasette.check_visibility(
+            request.actor,
+            action="view-table",
+            resource=TableResource(database=database_name, table=fk["other_table"]),
+        )
+        if not visible:
+            continue
+        autocomplete_urls[fk["column"]] = "{}/-/autocomplete".format(
+            datasette.urls.table(database_name, fk["other_table"])
+        )
+    return autocomplete_urls
+
+
+async def _table_page_data(
+    datasette, request, db, database_name, table_name, is_view, table_insert_ui
+):
+    data = {"tableUrl": datasette.urls.table(database_name, table_name)}
+    if table_insert_ui:
+        data["insertRow"] = table_insert_ui
+    if not is_view:
+        foreign_keys = await _foreign_key_autocomplete_urls(
+            datasette, request, db, database_name, table_name
+        )
+        if foreign_keys:
+            data["foreignKeys"] = foreign_keys
+    return data
+
+
 async def _table_insert_ui(
     datasette, request, db, database_name, table_name, is_view, pks
 ):
@@ -1164,6 +1205,12 @@ def _autocomplete_pk_order_by(pks):
     return ", ".join(escape_sqlite(pk) for pk in pks)
 
 
+def _autocomplete_initial_order_by(pks):
+    order_by = [f"{escape_sqlite(pks[0])} desc"]
+    order_by.extend(escape_sqlite(pk) for pk in pks[1:])
+    return ", ".join(order_by)
+
+
 def _autocomplete_response_rows(rows, pks, label_column):
     response_rows = []
     for row in rows:
@@ -1202,7 +1249,14 @@ class TableAutocompleteView(BaseView):
         )
         select_sql = ", ".join(escape_sqlite(column) for column in select_columns)
         q = request.args.get("q") or ""
-        if not q:
+        initial_arg = request.args.get("_initial")
+        initial = (
+            not q
+            and initial_arg is not None
+            and initial_arg != ""
+            and value_as_boolean(initial_arg)
+        )
+        if not q and not initial:
             return Response.json({"rows": []})
         params = {
             "q": q,
@@ -1215,6 +1269,12 @@ class TableAutocompleteView(BaseView):
             like_columns.append(label_column)
         where_sql = " or ".join(_autocomplete_like(column) for column in like_columns)
         exact_pk = len(pks) == 1
+        order_by = _autocomplete_order_by(pks, label_column, exact_pk)
+
+        if initial:
+            where_sql = "1 = 1"
+            order_by = _autocomplete_initial_order_by(pks)
+
         sql = """
             select {select_sql}
             from {table}
@@ -1225,7 +1285,7 @@ class TableAutocompleteView(BaseView):
             select_sql=select_sql,
             table=escape_sqlite(table_name),
             where=where_sql,
-            order_by=_autocomplete_order_by(pks, label_column, exact_pk),
+            order_by=order_by,
         )
 
         try:
@@ -1990,9 +2050,19 @@ async def table_view_data(
                 sort = "rowid"
         data["sort"] = sort
         data["sort_desc"] = sort_desc
-        data["table_insert_ui"] = await _table_insert_ui(
+        table_insert_ui = await _table_insert_ui(
             datasette, request, db, database_name, table_name, is_view, pks
         )
+        data["table_insert_ui"] = table_insert_ui
+        data["table_page_data"] = await _table_page_data(
+            datasette,
+            request,
+            db,
+            database_name,
+            table_name,
+            is_view,
+            table_insert_ui,
+        )
 
     return data, rows[:page_size], columns, expanded_columns, sql, next_url
 
diff --git a/tests/test_autocomplete.py b/tests/test_autocomplete.py
index 55e7458f..d7d78848 100644
--- a/tests/test_autocomplete.py
+++ b/tests/test_autocomplete.py
@@ -53,6 +53,53 @@ async def test_autocomplete_blank_q_returns_no_results():
     assert response.status_code == 200
     assert response.json() == {"rows": []}
 
+    response = await ds.client.get("/autocomplete_blank/people/-/autocomplete")
+
+    assert response.status_code == 200
+    assert response.json() == {"rows": []}
+
+
+@pytest.mark.asyncio
+async def test_autocomplete_initial_returns_latest_rows():
+    ds = Datasette(memory=True)
+    db = ds.add_memory_database("autocomplete_initial")
+    await db.execute_write_script("""
+        create table people (
+            id integer primary key,
+            name text
+        );
+        insert into people (id, name) values
+            (1, 'Alice'),
+            (2, 'Bob'),
+            (3, 'Cleo');
+        """)
+
+    response = await ds.client.get(
+        "/autocomplete_initial/people/-/autocomplete?_initial=1"
+    )
+
+    assert response.status_code == 200
+    assert response.json() == {
+        "rows": [
+            {"pks": {"id": 3}, "label": "Cleo"},
+            {"pks": {"id": 2}, "label": "Bob"},
+            {"pks": {"id": 1}, "label": "Alice"},
+        ]
+    }
+
+    response = await ds.client.get(
+        "/autocomplete_initial/people/-/autocomplete?q=&_initial=1"
+    )
+
+    assert response.status_code == 200
+    assert response.json() == {
+        "rows": [
+            {"pks": {"id": 3}, "label": "Cleo"},
+            {"pks": {"id": 2}, "label": "Bob"},
+            {"pks": {"id": 1}, "label": "Alice"},
+        ]
+    }
+
 
 @pytest.mark.asyncio
 async def test_autocomplete_escapes_like_characters():
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index c0af996f..b7d57918 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1050,6 +1050,61 @@ async def test_table_insert_action_includes_compound_primary_keys():
         ds.close()
 
 
+@pytest.mark.asyncio
+async def test_table_data_includes_foreign_key_autocomplete_urls():
+    ds = Datasette([])
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_table_foreign_key_autocomplete"), name="data"
+        )
+        await db.execute_write_script("""
+            create table authors (
+                id integer primary key,
+                name text
+            );
+            create table tags (
+                slug text unique,
+                name text
+            );
+            create table articles (
+                id integer primary key,
+                author_id integer references authors(id),
+                implicit_author_id integer references authors,
+                tag_slug text references tags(slug),
+                title text
+            );
+            insert into authors (id, name) values (1, 'Ada Lovelace');
+            insert into tags (slug, name) values ('science', 'Science');
+            insert into articles (
+                id,
+                author_id,
+                implicit_author_id,
+                tag_slug,
+                title
+            ) values (
+                1,
+                1,
+                1,
+                'science',
+                'Notes'
+            );
+            """)
+        response = await ds.client.get("/data/articles")
+        assert response.status_code == 200
+        soup = Soup(response.text, "html.parser")
+        table_data = table_data_from_soup(soup)
+        assert table_data["foreignKeys"] == {
+            "author_id": "/data/authors/-/autocomplete",
+            "implicit_author_id": "/data/authors/-/autocomplete",
+        }
+        assert any(
+            "autocomplete.js" in (script.get("src") or "")
+            for script in soup.find_all("script")
+        )
+    finally:
+        ds.close()
+
+
 @pytest.mark.asyncio
 async def test_table_fragment_endpoint(ds_client):
     response = await ds_client.get("/fixtures/simple_primary_key/-/fragment?_row=1")

From 35d7e3cab874be2a957923126dcd590782b1d4be Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 08:03:20 -0700
Subject: [PATCH 203/386] Fixed some tests for the new autocomplete work

---
 datasette/views/table.py   | 15 ++++++++++++---
 docs/introspection.rst     |  9 +++++++++
 tests/test_autocomplete.py |  5 +++--
 3 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 190529f4..eb155407 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1158,7 +1158,7 @@ def _escape_like(value):
 
 
 # Returns the exclusive upper bound for an indexed prefix search:
-# "abc" -> "abd", so `pk >= "abc" and pk < "abd"` covers "abc%".
+# For example, values beginning with "abc" fall below the next prefix boundary.
 # The LIKE clause is still applied separately for exact escaped-LIKE semantics.
 def _prefix_range_end(value):
     if not value:
@@ -1221,6 +1221,9 @@ def _autocomplete_response_rows(rows, pks, label_column):
     return response_rows
 
 
+AUTOCOMPLETE_TIME_LIMIT_MS = 500
+
+
 class TableAutocompleteView(BaseView):
     name = "table-autocomplete"
 
@@ -1289,7 +1292,9 @@ class TableAutocompleteView(BaseView):
         )
 
         try:
-            results = await db.execute(sql, params, custom_time_limit=500)
+            results = await db.execute(
+                sql, params, custom_time_limit=AUTOCOMPLETE_TIME_LIMIT_MS
+            )
         except QueryInterrupted:
             fallback_where = _autocomplete_prefix_like(pks[0])
             prefix_end = _prefix_range_end(q)
@@ -1312,7 +1317,11 @@ class TableAutocompleteView(BaseView):
                 order_by=_autocomplete_pk_order_by(pks),
             )
             try:
-                results = await db.execute(fallback_sql, params, custom_time_limit=500)
+                results = await db.execute(
+                    fallback_sql,
+                    params,
+                    custom_time_limit=AUTOCOMPLETE_TIME_LIMIT_MS,
+                )
             except QueryInterrupted:
                 return Response.json({"rows": []})
 
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 7702a4b5..4834f441 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -201,6 +201,15 @@ Search example with ``?q=facet`` returns only items matching ``.*facet.*``:
 
 When multiple search terms are provided (e.g., ``?q=user+profile``), items must match the pattern ``.*user.*profile.*``. Results are ordered by relevance, then by item type and shortest display name.
 
+.. _AutocompleteDebugView:
+
+/-/debug/autocomplete
+---------------------
+
+The debug tool at ``/-/debug/autocomplete`` can be used to try out the autocomplete component against a specific table. Pass ``?database=db&table=table`` to display an autocomplete field backed by that table's ``/-/autocomplete`` endpoint.
+
+Without those query string arguments, the page lists up to five tables with detected label columns, scanning at most 100 tables.
+
 .. _JsonDataView_threads:
 
 /-/threads
diff --git a/tests/test_autocomplete.py b/tests/test_autocomplete.py
index d7d78848..abe19af2 100644
--- a/tests/test_autocomplete.py
+++ b/tests/test_autocomplete.py
@@ -1,6 +1,7 @@
 import pytest
 
 from datasette.app import Datasette
+import datasette.views.table as table_views
 
 
 @pytest.mark.asyncio
@@ -190,7 +191,8 @@ async def test_autocomplete_primary_key_called_label():
 
 
 @pytest.mark.asyncio
-async def test_autocomplete_timeout_uses_prefix_fallback():
+async def test_autocomplete_timeout_uses_prefix_fallback(monkeypatch):
+    monkeypatch.setattr(table_views, "AUTOCOMPLETE_TIME_LIMIT_MS", 1)
     ds = Datasette(
         memory=True,
         config={
@@ -200,7 +202,6 @@ async def test_autocomplete_timeout_uses_prefix_fallback():
         },
         settings={
             "num_sql_threads": 1,
-            "sql_time_limit_ms": 1,
         },
     )
     db = ds.add_memory_database("autocomplete_timeout")

From c405b56223992d93644e93d63ddad15d535beb81 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 11:56:51 -0700
Subject: [PATCH 204/386] Tweak modal color scheme to be more Datasette

---
 datasette/static/app.css | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index d0356b81..633ebd7a 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -792,9 +792,9 @@ p.zero-results {
 
 dialog.mobile-column-actions-dialog {
     --ink: #0f0f0f;
-    --paper: #f5f3ef;
+    --paper: #eef6ff;
     --muted: #6b6b6b;
-    --rule: #e2dfd8;
+    --rule: #d8e6f5;
     --accent: #1a56db;
     --card: #ffffff;
     border: none;
@@ -1020,9 +1020,9 @@ dialog.mobile-column-actions-dialog::backdrop {
 
 dialog.set-column-type-dialog {
     --ink: #0f0f0f;
-    --paper: #f5f3ef;
+    --paper: #eef6ff;
     --muted: #6b6b6b;
-    --rule: #e2dfd8;
+    --rule: #d8e6f5;
     --accent: #1a56db;
     --card: #ffffff;
     border: none;
@@ -1109,7 +1109,7 @@ dialog.set-column-type-dialog::backdrop {
     padding: 14px 16px;
     border: 1px solid var(--rule);
     border-radius: 8px;
-    background: #fcfbf9;
+    background: #fbfdff;
     cursor: pointer;
 }
 
@@ -1226,9 +1226,9 @@ button.table-insert-row svg {
 
 dialog.row-delete-dialog {
     --ink: #0f0f0f;
-    --paper: #f5f3ef;
+    --paper: #eef6ff;
     --muted: #6b6b6b;
-    --rule: #e2dfd8;
+    --rule: #d8e6f5;
     --accent: #1a56db;
     --card: #ffffff;
     border: none;
@@ -1356,9 +1356,9 @@ dialog.row-delete-dialog::backdrop {
 
 dialog.row-edit-dialog {
     --ink: #0f0f0f;
-    --paper: #f5f3ef;
+    --paper: #eef6ff;
     --muted: #6b6b6b;
-    --rule: #e2dfd8;
+    --rule: #d8e6f5;
     --accent: #1a56db;
     --card: #ffffff;
     border: none;

From b2de8b5d2eb9e3d0b5dd95b4a54f884748bd3b5d Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 11:57:13 -0700
Subject: [PATCH 205/386] First draft of makeColumnField() plugin hook

---
 datasette/static/column-chooser.js    |   4 +-
 datasette/static/datasette-manager.js |  29 +++
 datasette/static/table.js             | 184 ++++++++++++++--
 datasette/views/table.py              |   6 +-
 docs/javascript_plugins.rst           | 298 ++++++++++++++++++++++++++
 tests/test_table_html.py              |  10 +-
 6 files changed, 510 insertions(+), 21 deletions(-)

diff --git a/datasette/static/column-chooser.js b/datasette/static/column-chooser.js
index 133e7cb0..198641f3 100644
--- a/datasette/static/column-chooser.js
+++ b/datasette/static/column-chooser.js
@@ -31,9 +31,9 @@ class ColumnChooser extends HTMLElement {
       <style>
         :host {
           --ink: #0f0f0f;
-          --paper: #f5f3ef;
+          --paper: #eef6ff;
           --muted: #6b6b6b;
-          --rule: #e2dfd8;
+          --rule: #d8e6f5;
           --accent: #1a56db;
           --accent-light: #e8effd;
           --card: #ffffff;
diff --git a/datasette/static/datasette-manager.js b/datasette/static/datasette-manager.js
index e75f7aae..b049fc73 100644
--- a/datasette/static/datasette-manager.js
+++ b/datasette/static/datasette-manager.js
@@ -82,6 +82,35 @@ const datasetteManager = {
     return columnActions;
   },
 
+  /**
+   * Allows JavaScript plugins to replace or enhance insert/edit modal fields
+   * for specific Datasette column types.
+   *
+   * The first plugin to return a control object wins. Returning null or
+   * undefined means "I do not handle this field".
+   */
+  makeColumnField: (context) => {
+    for (const [pluginName, plugin] of datasetteManager.plugins) {
+      if (!plugin.makeColumnField) {
+        continue;
+      }
+      let control = null;
+      try {
+        control = plugin.makeColumnField(context);
+      } catch (error) {
+        console.error(
+          `Error in makeColumnField() for plugin ${pluginName}`,
+          error,
+        );
+        continue;
+      }
+      if (control) {
+        return Object.assign({ pluginName }, control);
+      }
+    }
+    return null;
+  },
+
   makeJumpSections: (context) => {
     let jumpSections = [];
 
diff --git a/datasette/static/table.js b/datasette/static/table.js
index 43dd81d7..27b816be 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -492,12 +492,16 @@ function tableBaseUrl() {
   return url;
 }
 
+function tablePageData() {
+  return window._datasetteTableData || {};
+}
+
 function tableInsertData() {
-  return window._datasetteTableData && window._datasetteTableData.insertRow;
+  return tablePageData().insertRow;
 }
 
 function tableForeignKeys() {
-  return (window._datasetteTableData && window._datasetteTableData.foreignKeys) || {};
+  return tablePageData().foreignKeys || {};
 }
 
 function foreignKeyAutocompleteUrl(column) {
@@ -982,6 +986,118 @@ function rowEditControlElement(control, autocompleteUrl) {
   return autocomplete;
 }
 
+function columnFormControlContext(column, value, isPk, columnType, options) {
+  var pageData = tablePageData();
+  var hasDefault =
+    options.hasDefault ||
+    (options.defaultValue !== null && typeof options.defaultValue !== "undefined");
+  return {
+    mode: options.mode || "edit",
+    database: pageData.database || null,
+    table: pageData.table || (tableInsertData() && tableInsertData().tableName) || null,
+    tableUrl: pageData.tableUrl || null,
+    column: column,
+    value: value,
+    originalValue: value,
+    columnType: columnType || null,
+    sqliteType: options.sqliteType || null,
+    notNull: !!options.notnull,
+    isPrimaryKey: !!isPk,
+    readOnly: !!(isPk && options.primaryKeyReadonly !== false),
+    hasDefault: !!hasDefault,
+    defaultValue: options.defaultValue,
+    form: options.form || null,
+    dialog: options.dialog || null,
+  };
+}
+
+function makeColumnField(manager, context) {
+  if (!manager || !manager.makeColumnField) {
+    return null;
+  }
+  return manager.makeColumnField(context);
+}
+
+function renderColumnField(pluginControl, fieldApi) {
+  if (!pluginControl || !pluginControl.render) {
+    return null;
+  }
+  var pluginWrap = document.createElement("div");
+  pluginWrap.className = "row-edit-plugin-control";
+  pluginWrap.dataset.pluginName = pluginControl.pluginName || "";
+  pluginWrap.dataset.column = fieldApi.context.column;
+  if (fieldApi.context.columnType && fieldApi.context.columnType.type) {
+    pluginWrap.dataset.columnType = fieldApi.context.columnType.type;
+  }
+  try {
+    var rendered = pluginControl.render(pluginWrap, fieldApi);
+    if (rendered && rendered.nodeType) {
+      pluginWrap.appendChild(rendered);
+    }
+  } catch (error) {
+    console.error("Error rendering column form control", error);
+    return null;
+  }
+  pluginWrap._datasetteColumnField = pluginControl;
+  pluginWrap._datasetteColumnFormField = fieldApi;
+  return pluginWrap;
+}
+
+function focusRowEditPluginControl(field) {
+  var pluginWrap = field.querySelector(".row-edit-plugin-control");
+  if (!pluginWrap) {
+    return false;
+  }
+  var pluginControl = pluginWrap._datasetteColumnField;
+  var fieldApi = pluginWrap._datasetteColumnFormField;
+  if (pluginControl && pluginControl.focus) {
+    pluginControl.focus(pluginWrap, fieldApi);
+    return true;
+  }
+  return false;
+}
+
+function focusFirstRowEditControl(state, options) {
+  options = options || {};
+  var fields = state.fields.querySelectorAll(".row-edit-field");
+  for (var i = 0; i < fields.length; i += 1) {
+    var field = fields[i];
+    var control = field.querySelector(".row-edit-input");
+    if (!control) {
+      continue;
+    }
+    if (options.skipReadonly && (control.readOnly || control.disabled)) {
+      continue;
+    }
+    if (focusRowEditPluginControl(field)) {
+      return true;
+    }
+    control.focus();
+    return true;
+  }
+  return false;
+}
+
+function destroyRowEditFields(state) {
+  if (!state || !state.fields) {
+    return;
+  }
+  state.fields
+    .querySelectorAll(".row-edit-plugin-control")
+    .forEach(function (pluginWrap) {
+      var pluginControl = pluginWrap._datasetteColumnField;
+      var fieldApi = pluginWrap._datasetteColumnFormField;
+      if (pluginControl && pluginControl.destroy) {
+        try {
+          pluginControl.destroy(pluginWrap, fieldApi);
+        } catch (error) {
+          console.error("Error destroying column form control", error);
+        }
+      }
+    });
+  state.fields.innerHTML = "";
+}
+
 function createRowEditField(column, value, isPk, columnType, index, options) {
   options = options || {};
   var field = document.createElement("div");
@@ -993,15 +1109,26 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
 
   var fieldId = "row-edit-field-" + index;
   var metaId = "row-edit-field-meta-" + index;
+  var labelId = "row-edit-field-label-" + index;
   var label = document.createElement("label");
   label.className = "row-edit-label";
+  label.id = labelId;
   label.setAttribute("for", fieldId);
   label.textContent = column;
 
   var controlWrap = document.createElement("div");
   controlWrap.className = "row-edit-control-wrap";
 
-  var control = shouldUseTextarea(value, columnType)
+  var context = columnFormControlContext(
+    column,
+    value,
+    isPk,
+    columnType,
+    options,
+  );
+  var pluginControl = makeColumnField(options.manager, context);
+  var preferredControl = pluginControl && pluginControl.inputType;
+  var control = (preferredControl === "textarea" || shouldUseTextarea(value, columnType))
     ? document.createElement("textarea")
     : document.createElement("input");
   control.className = "row-edit-input";
@@ -1081,8 +1208,20 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     meta.appendChild(foreignKeyLinkWrap);
     updateRowEditFieldMetaHidden(meta);
   }
-  var controlElement = rowEditControlElement(control, options.autocompleteUrl);
-  if (options.autocompleteUrl) {
+  var fieldApi = {
+    id: fieldId,
+    labelId: labelId,
+    descriptionId: metaId,
+    input: control,
+    control: control,
+    form: options.form || null,
+    dialog: options.dialog || null,
+    context: context,
+  };
+  var pluginControlElement = renderColumnField(pluginControl, fieldApi);
+  var controlElement =
+    pluginControlElement || rowEditControlElement(control, options.autocompleteUrl);
+  if (options.autocompleteUrl && !pluginControlElement) {
     control.addEventListener("input", function () {
       setForeignKeyMetaLink(meta, options.autocompleteUrl, null);
     });
@@ -1506,7 +1645,7 @@ function renderRowEditFields(state, data) {
   var primaryKeys = data.primary_keys || [];
   var columnTypes = data.column_types || {};
 
-  state.fields.innerHTML = "";
+  destroyRowEditFields(state);
   columns.forEach(function (column, index) {
     state.fields.appendChild(
       createRowEditField(
@@ -1517,6 +1656,10 @@ function renderRowEditFields(state, data) {
         index,
         {
           autocompleteUrl: foreignKeyAutocompleteUrl(column),
+          dialog: state.dialog,
+          form: state.form,
+          manager: state.manager,
+          mode: state.mode,
           primaryKeyReadonly: true,
         },
       ),
@@ -1525,15 +1668,15 @@ function renderRowEditFields(state, data) {
 
   state.hasLoaded = true;
   updateRowEditDialogButtons(state);
-  var firstEditable = state.fields.querySelector(".row-edit-input:not([readonly])");
-  var firstField = state.fields.querySelector(".row-edit-input");
-  (firstEditable || firstField || state.cancelButton).focus();
+  if (!focusFirstRowEditControl(state, { skipReadonly: true })) {
+    focusFirstRowEditControl(state) || state.cancelButton.focus();
+  }
 }
 
 function renderRowInsertFields(state, data) {
   var columns = data.columns || [];
 
-  state.fields.innerHTML = "";
+  destroyRowEditFields(state);
   columns.forEach(function (column, index) {
     state.fields.appendChild(
       createRowEditField(
@@ -1544,10 +1687,15 @@ function renderRowInsertFields(state, data) {
         index,
         {
           autocompleteUrl: foreignKeyAutocompleteUrl(column.name),
+          dialog: state.dialog,
           defaultValue: column.default,
+          form: state.form,
           hasDefault: column.has_default,
+          manager: state.manager,
+          mode: state.mode,
           notnull: column.notnull,
           primaryKeyReadonly: false,
+          sqliteType: column.type,
           useDefaultInitially: column.has_default,
           valueType: column.value_type,
         },
@@ -1564,10 +1712,13 @@ function renderRowInsertFields(state, data) {
 
   state.hasLoaded = true;
   updateRowEditDialogButtons(state);
-  var firstControl = state.fields.querySelector(
-    ".row-edit-default-set-value, .row-edit-input:not(:disabled)",
-  );
-  (firstControl || state.saveButton).focus();
+  var firstDefaultButton = state.fields.querySelector(".row-edit-default-set-value");
+  if (firstDefaultButton) {
+    firstDefaultButton.focus();
+  } else {
+    focusFirstRowEditControl(state, { skipReadonly: true }) ||
+      state.saveButton.focus();
+  }
 }
 
 function setRowDialogTitle(title, text, codeText, labelText) {
@@ -1692,6 +1843,7 @@ function ensureRowEditDialog(manager) {
     state.loadId += 1;
     clearRowEditDialogError(state);
     state.hasLoaded = false;
+    destroyRowEditFields(state);
     setRowEditDialogLoading(state, false);
     setRowEditDialogSaving(state, false);
     if (
@@ -1737,7 +1889,7 @@ async function openRowEditDialog(button, manager) {
 
   clearRowEditDialogError(state);
   setRowEditDialogLoading(state, true);
-  state.fields.innerHTML = "";
+  destroyRowEditFields(state);
   state.dialog.removeAttribute("aria-describedby");
   setRowDialogTitle(
     state.title,
@@ -1809,7 +1961,7 @@ function openRowInsertDialog(button, manager) {
 
   clearRowEditDialogError(state);
   setRowEditDialogLoading(state, false);
-  state.fields.innerHTML = "";
+  destroyRowEditFields(state);
   state.dialog.removeAttribute("aria-describedby");
   setRowDialogTitle(
     state.title,
diff --git a/datasette/views/table.py b/datasette/views/table.py
index eb155407..dc2589e9 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -279,7 +279,11 @@ async def _foreign_key_autocomplete_urls(
 async def _table_page_data(
     datasette, request, db, database_name, table_name, is_view, table_insert_ui
 ):
-    data = {"tableUrl": datasette.urls.table(database_name, table_name)}
+    data = {
+        "database": database_name,
+        "table": table_name,
+        "tableUrl": datasette.urls.table(database_name, table_name),
+    }
     if table_insert_ui:
         data["insertRow"] = table_insert_ui
     if not is_view:
diff --git a/docs/javascript_plugins.rst b/docs/javascript_plugins.rst
index 805938c0..d298b6d4 100644
--- a/docs/javascript_plugins.rst
+++ b/docs/javascript_plugins.rst
@@ -46,6 +46,9 @@ The ``datasetteManager`` object
 ``registerPlugin(name, implementation)``
     Call this to register a plugin, passing its name and implementation
 
+``makeColumnField(context)``
+    Calls the ``makeColumnField()`` hook on registered plugins, returning the first custom insert/edit field control that matches the provided field context. This is used internally by Datasette's row insert and edit dialogs.
+
 ``selectors`` - object
     An object providing named aliases to useful CSS selectors, :ref:`listed below <javascript_datasette_manager_selectors>`
 
@@ -188,6 +191,301 @@ This example plugin adds two menu items - one to copy the column name to the cli
       });
     });
 
+.. _javascript_plugins_makeColumnField:
+
+makeColumnField(context)
+~~~~~~~~~~~~~~~~~~~~~~~~
+
+This method, if present, can provide a custom form field for a column in Datasette's row insert and edit dialogs.
+
+It is designed for plugins that register custom column types using the Python ``register_column_types()`` plugin hook. For example, a plugin that defines a ``file`` column type can use ``makeColumnField()`` to replace a plain text input with a file picker, and a plugin that defines a rich text column type can use it to enhance the field with an editor.
+
+Datasette calls ``makeColumnField(context)`` on each registered JavaScript plugin when it renders an editable insert/edit field. Plugins should inspect the ``context`` object and return ``null`` or ``undefined`` for fields they do not handle.
+
+The first plugin to return a truthy control object is used for that field. Plugins are called in registration order. If a plugin raises an exception, Datasette logs the error to the browser console and continues to the next plugin.
+
+The value that Datasette submits is still read from the core-owned input or textarea provided to the plugin as ``field.input``. This keeps custom fields progressive: the plugin can render any UI it needs, but it must keep ``field.input.value`` synchronized with the raw value that should be sent to the insert/update API.
+
+Context object
+^^^^^^^^^^^^^^
+
+``makeColumnField(context)`` is called with a context object describing the field. The current context object has these keys:
+
+``mode`` - string
+    ``"insert"`` or ``"edit"``.
+
+``database`` - string or null
+    The database name.
+
+``table`` - string or null
+    The table name.
+
+``tableUrl`` - string or null
+    The path to the table page, including any configured base URL prefix.
+
+``column`` - string
+    The column name.
+
+``value``
+    The current JavaScript value for the field. For edit forms this is the row's current value. For insert forms this is usually ``null`` or ``""``.
+
+``originalValue``
+    The value the field had when the form was opened. This currently matches ``value``.
+
+``columnType`` - object or null
+    The configured Datasette column type for this column, if one exists. This object includes a ``type`` key containing the column type name. Plugins should generally check ``context.columnType && context.columnType.type`` before deciding whether to handle a field.
+
+``sqliteType`` - string or null
+    The SQLite column type, if known.
+
+``notNull`` - boolean
+    True if the column is defined as ``NOT NULL``.
+
+``isPrimaryKey`` - boolean
+    True if this column is part of the table's primary key.
+
+``readOnly`` - boolean
+    True if Datasette is rendering the field as read-only. Primary key fields are read-only in edit forms by default.
+
+``hasDefault`` - boolean
+    True if the column has a SQLite default value and the insert form can offer the "use default" behavior.
+
+``defaultValue``
+    The column default value or expression, if available.
+
+``form`` - ``HTMLFormElement`` or null
+    The row insert/edit form element.
+
+``dialog`` - ``HTMLDialogElement`` or null
+    The modal dialog element.
+
+Returned control object
+^^^^^^^^^^^^^^^^^^^^^^^
+
+A plugin that wants to handle a field should return an object. Datasette currently recognizes these properties:
+
+``inputType`` - string, optional
+    If set to ``"textarea"``, Datasette creates a ``<textarea>`` as the underlying ``field.input`` before calling ``render()``. Any other value is ignored.
+
+``render(node, field)`` - function
+    Called once to render the custom field UI. ``node`` is an empty container element created by Datasette. ``field`` is a helper object described below.
+
+    The plugin should append its UI to ``node``. If ``render()`` returns a DOM node, Datasette appends that returned node to ``node``.
+
+``focus(node, field)`` - function, optional
+    Called when Datasette wants to focus this field, for example when focusing the first editable field in the dialog. Use this to focus the most useful interactive element inside the custom UI.
+
+``destroy(node, field)`` - function, optional
+    Called when Datasette tears down the insert/edit form. Use this to remove event listeners, close nested pickers, revoke object URLs, clear timers, or release other resources.
+
+Datasette adds a ``pluginName`` property to the control object internally, based on the name passed to ``registerPlugin()``.
+
+The field helper object
+^^^^^^^^^^^^^^^^^^^^^^^
+
+The second argument to ``render(node, field)`` provides the core input and stable IDs that help the plugin integrate with the modal's form and accessibility behavior:
+
+``id`` - string
+    The ID Datasette assigned to the underlying form control.
+
+``labelId`` - string
+    The ID of the visible field label.
+
+``descriptionId`` - string
+    The ID of the field metadata/help text. This metadata can include details such as ``Primary key``, ``Required``, ``Current value: NULL`` or ``Custom type: file``.
+
+``input`` - ``HTMLInputElement`` or ``HTMLTextAreaElement``
+    The core-owned form control. Datasette reads this element's ``name``, ``value`` and ``dataset`` properties when the row is inserted or updated.
+
+``control``
+    An alias for ``input``.
+
+``form`` - ``HTMLFormElement`` or null
+    The containing row insert/edit form.
+
+``dialog`` - ``HTMLDialogElement`` or null
+    The containing modal dialog.
+
+``context`` - object
+    The original context object passed to ``makeColumnField()``.
+
+Value handling
+^^^^^^^^^^^^^^
+
+Custom fields should keep ``field.input.value`` synchronized with the raw value to submit.
+
+If a custom field changes the value programmatically, it should dispatch normal ``input`` and ``change`` events so the rest of the form can observe the update:
+
+.. code-block:: javascript
+
+    function setInputValue(input, value) {
+      input.value = value || "";
+      input.dispatchEvent(new Event("input", { bubbles: true }));
+      input.dispatchEvent(new Event("change", { bubbles: true }));
+    }
+
+Plugins can either keep the core input visible, wrap it in a custom element, or hide it and provide a richer interface. If the input is hidden, the custom UI must still expose an accessible name, state and keyboard interaction.
+
+If the plugin changes the kind of value stored in the underlying input, it can adjust ``field.input.dataset.originalValueType``. Datasette uses that dataset value when converting the submitted text back to a JSON value for the insert/update API.
+
+For example, a file picker that stores a string file ID can set:
+
+.. code-block:: javascript
+
+    field.input.type = "hidden";
+    field.input.dataset.originalValueType = "null";
+
+This causes an empty string to be submitted as ``null``.
+
+Lazy loading large controls
+^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The JavaScript file that registers ``makeColumnField()`` should be small. If the actual control is large, load it from inside ``render()`` using dynamic ``import()``. That way the heavier code is only downloaded after a user opens an insert/edit dialog containing a matching column type.
+
+.. code-block:: javascript
+
+    const editorUrl = new URL("./editor.js", import.meta.url).href;
+
+    document.addEventListener("datasette_init", function (event) {
+      event.detail.registerPlugin("my-editor", {
+        version: "0.1",
+
+        makeColumnField(context) {
+          if (!context.columnType || context.columnType.type !== "my-editor") {
+            return null;
+          }
+          return {
+            inputType: "textarea",
+            render(node, field) {
+              node.appendChild(field.input);
+              import(editorUrl).then(function () {
+                // Enhance field.input here.
+              });
+            }
+          };
+        }
+      });
+    });
+
+Example: textarea-backed custom element
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+This example handles a ``markdown-editor`` column type by asking Datasette for a textarea and wrapping that textarea in a custom element:
+
+.. code-block:: javascript
+
+    document.addEventListener("datasette_init", function (event) {
+      event.detail.registerPlugin("markdown-editor", {
+        version: "0.1",
+
+        makeColumnField(context) {
+          if (!context.columnType || context.columnType.type !== "markdown-editor") {
+            return null;
+          }
+
+          return {
+            inputType: "textarea",
+
+            render(node, field) {
+              const editor = document.createElement("my-markdown-editor");
+              editor.appendChild(field.input);
+              node.appendChild(editor);
+
+              if (field.labelId) {
+                field.input.setAttribute("aria-labelledby", field.labelId);
+              }
+              if (field.descriptionId) {
+                field.input.setAttribute("aria-describedby", field.descriptionId);
+              }
+            },
+
+            focus(node, field) {
+              const editor = node.querySelector("my-markdown-editor");
+              if (editor && editor.focus) {
+                editor.focus();
+              } else {
+                field.input.focus();
+              }
+            }
+          };
+        }
+      });
+    });
+
+Example: hidden input with custom picker
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+This example handles an ``asset`` column type by hiding the core input and writing an asset ID into it when the user selects an item:
+
+.. code-block:: javascript
+
+    document.addEventListener("datasette_init", function (event) {
+      event.detail.registerPlugin("asset-picker", {
+        version: "0.1",
+
+        makeColumnField(context) {
+          if (!context.columnType || context.columnType.type !== "asset") {
+            return null;
+          }
+
+          return {
+            render(node, field) {
+              field.input.type = "hidden";
+              field.input.dataset.originalValueType = "null";
+
+              const group = document.createElement("div");
+              group.setAttribute("role", "group");
+              group.setAttribute("aria-labelledby", field.labelId);
+              group.setAttribute("aria-describedby", field.descriptionId);
+
+              const current = document.createElement("span");
+              current.textContent = field.input.value || "No asset selected";
+
+              const button = document.createElement("button");
+              button.type = "button";
+              button.textContent = "Choose asset";
+              button.addEventListener("click", async function () {
+                const assetId = await chooseAsset();
+                if (assetId === null) {
+                  return;
+                }
+                field.input.value = assetId;
+                field.input.dispatchEvent(new Event("input", { bubbles: true }));
+                field.input.dispatchEvent(new Event("change", { bubbles: true }));
+                current.textContent = assetId || "No asset selected";
+              });
+
+              group.appendChild(current);
+              group.appendChild(button);
+              node.appendChild(field.input);
+              node.appendChild(group);
+            },
+
+            focus(node) {
+              const button = node.querySelector("button");
+              if (button) {
+                button.focus();
+              }
+            }
+          };
+        }
+      });
+    });
+
+Accessibility
+^^^^^^^^^^^^^
+
+Custom fields are responsible for preserving the accessibility of the form:
+
+- The visible field label should name the control. Use ``field.labelId`` with ``aria-labelledby`` when wrapping or replacing the visible input.
+- Field metadata should remain available to assistive technology. Use ``field.descriptionId`` with ``aria-describedby``.
+- Keyboard users must be able to operate every part of the custom field.
+- If the field opens an inline picker or other nested UI, ``Escape`` should close that nested UI first and return focus to a sensible element.
+- If a control performs asynchronous loading, expose loading and error states in the UI. Use appropriate ARIA live regions where the state change is important to understand the field.
+- If a plugin hides ``field.input``, the replacement UI must still make the current value and available actions clear.
+
+Plugins should not submit the row themselves from inside ``makeColumnField()`` controls. Datasette owns the insert/edit dialog lifecycle, form submission, API call, error handling and row refresh.
+
 .. _javascript_datasette_manager_selectors:
 
 Selectors
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index b7d57918..a1510aeb 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -881,7 +881,11 @@ async def test_row_delete_action_data_attributes():
         response = await ds.client.get("/data/items", actor={"id": "root"})
         assert response.status_code == 200
         soup = Soup(response.text, "html.parser")
-        assert table_data_from_soup(soup) == {"tableUrl": "/data/items"}
+        assert table_data_from_soup(soup) == {
+            "database": "data",
+            "table": "items",
+            "tableUrl": "/data/items",
+        }
         assert soup.select_one('button[data-table-action="insert-row"]') is None
 
         row = soup.select_one("table.rows-and-columns tbody tr")
@@ -1151,7 +1155,9 @@ def test_table_data_uses_base_url(app_client_base_url_prefix):
         re.DOTALL,
     )
     assert json.loads(match.group(1)) == {
-        "tableUrl": "/prefix/fixtures/simple_primary_key"
+        "database": "fixtures",
+        "table": "simple_primary_key",
+        "tableUrl": "/prefix/fixtures/simple_primary_key",
     }
 
 

From 841a2536ea993ef31b8161b1470367da397a5eae Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 13:54:10 -0700
Subject: [PATCH 206/386] Tighten row edit field plugin API

Replace the value/valueType/originalValue/originalValueType fields on makeColumnField() contexts with an explicit field object API for reading, writing, resetting, comparing and validating field values.

Normalize columnType to {type, config}, rename the SQLite default metadata so it is clearly SQLite-specific, and document that plugins submit only string, number, boolean or null values. Plugins that need structured data should serialize it themselves instead of relying on Datasette to special-case JSON.

Move the built-in json column type behavior onto the same plugin API used by external plugins: validate the textarea with field.setValidity() as the value changes, but submit plain text. Harden row edit value comparison so fixing invalid JSON in an existing row is not blocked by the original invalid value.

Update the JavaScript plugin documentation and Node-based tests for the revised field contract.
---
 datasette/static/app.css           |  20 ++
 datasette/static/table.js          | 367 +++++++++++++++-----
 datasette/views/table.py           |  13 +-
 docs/javascript_plugins.rst        | 173 ++++++----
 tests/test_datasette_manager_js.py | 515 +++++++++++++++++++++++++++++
 tests/test_table_html.py           |  10 +-
 6 files changed, 958 insertions(+), 140 deletions(-)
 create mode 100644 tests/test_datasette_manager_js.py

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 633ebd7a..c053f484 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1521,6 +1521,16 @@ textarea.row-edit-input {
     outline: 3px solid rgba(26, 86, 219, 0.12);
 }
 
+.row-edit-input[aria-invalid="true"] {
+    border-color: #b42318;
+    background: #fff8f7;
+}
+
+.row-edit-input[aria-invalid="true"]:focus {
+    border-color: #b42318;
+    outline-color: rgba(180, 35, 24, 0.16);
+}
+
 .row-edit-input[readonly] {
     color: var(--muted);
     background: var(--paper);
@@ -1594,6 +1604,16 @@ textarea.row-edit-input {
     font-size: 0.78rem;
 }
 
+.row-edit-field-validation-error {
+    color: #b42318;
+    display: block;
+    margin-top: 2px;
+}
+
+.row-edit-field-validation-error[hidden] {
+    display: none;
+}
+
 .row-edit-field-meta-autocomplete {
     line-height: 1.2;
     min-height: 1.2em;
diff --git a/datasette/static/table.js b/datasette/static/table.js
index 27b816be..79ed45b9 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -959,7 +959,7 @@ function shouldUseTextarea(value, columnType) {
   return text.length > 80 || /[\r\n]/.test(text);
 }
 
-function rowEditValueType(value) {
+function rowEditValueKind(value) {
   if (value === null || typeof value === "undefined") {
     return "null";
   }
@@ -969,9 +969,6 @@ function rowEditValueType(value) {
   if (typeof value === "boolean") {
     return "boolean";
   }
-  if (typeof value === "object") {
-    return "json";
-  }
   return "string";
 }
 
@@ -986,26 +983,37 @@ function rowEditControlElement(control, autocompleteUrl) {
   return autocomplete;
 }
 
+function columnTypeForContext(columnType) {
+  if (!columnType) {
+    return null;
+  }
+  return {
+    type: columnType.type,
+    config: columnType.config || {},
+  };
+}
+
 function columnFormControlContext(column, value, isPk, columnType, options) {
   var pageData = tablePageData();
-  var hasDefault =
-    options.hasDefault ||
-    (options.defaultValue !== null && typeof options.defaultValue !== "undefined");
+  var hasSqliteDefault =
+    options.hasSqliteDefault ||
+    (options.sqliteDefaultExpression !== null &&
+      typeof options.sqliteDefaultExpression !== "undefined");
   return {
     mode: options.mode || "edit",
     database: pageData.database || null,
     table: pageData.table || (tableInsertData() && tableInsertData().tableName) || null,
     tableUrl: pageData.tableUrl || null,
     column: column,
-    value: value,
-    originalValue: value,
-    columnType: columnType || null,
+    columnType: columnTypeForContext(columnType),
     sqliteType: options.sqliteType || null,
     notNull: !!options.notnull,
     isPrimaryKey: !!isPk,
-    readOnly: !!(isPk && options.primaryKeyReadonly !== false),
-    hasDefault: !!hasDefault,
-    defaultValue: options.defaultValue,
+    hasSqliteDefault: !!hasSqliteDefault,
+    sqliteDefaultExpression: options.sqliteDefaultExpression,
+    useSqliteDefaultInitially: !!(
+      hasSqliteDefault && options.useSqliteDefaultInitially
+    ),
     form: options.form || null,
     dialog: options.dialog || null,
   };
@@ -1018,6 +1026,148 @@ function makeColumnField(manager, context) {
   return manager.makeColumnField(context);
 }
 
+function createColumnFieldApi(options) {
+  var control = options.control;
+  var context = options.context;
+  var field = {
+    context: context,
+    id: options.id,
+    labelId: options.labelId,
+    descriptionId: options.descriptionId,
+    root: null,
+    form: options.form || null,
+    dialog: options.dialog || null,
+    input: control,
+    control: control,
+    meta: options.meta || null,
+    validationMessageElement: null,
+    getValue: function () {
+      return valueFromRowEditControl(control);
+    },
+    setValue: function (value, setOptions) {
+      setOptions = setOptions || {};
+      if (
+        value !== null &&
+        typeof value !== "undefined" &&
+        typeof value === "object"
+      ) {
+        throw new TypeError(
+          "field.setValue() accepts strings, numbers, booleans or null; serialize objects before setting the field value",
+        );
+      }
+      field.stopUsingSqliteDefault({ dispatch: false });
+      control.value = valueToEditText(value);
+      control.dataset.currentValueKind = rowEditValueKind(value);
+      if (setOptions.dispatch !== false) {
+        field.dispatchChange();
+      }
+    },
+    getInitialValue: function () {
+      return initialValueFromRowEditControl(control);
+    },
+    hasChanged: function () {
+      if (field.isUsingSqliteDefault()) {
+        return !context.useSqliteDefaultInitially;
+      }
+      if (
+        control.value === (control.dataset.initialValue || "") &&
+        (control.dataset.currentValueKind ||
+          control.dataset.initialValueKind ||
+          "string") === (control.dataset.initialValueKind || "string")
+      ) {
+        return false;
+      }
+      try {
+        return !rowEditValuesMatch(field.getValue(), field.getInitialValue());
+      } catch (_error) {
+        return true;
+      }
+    },
+    clearValue: function (clearOptions) {
+      field.setValue(null, clearOptions);
+    },
+    resetValue: function (resetOptions) {
+      resetOptions = resetOptions || {};
+      field.stopUsingSqliteDefault({ dispatch: false });
+      control.value = control.dataset.initialValue || "";
+      control.dataset.currentValueKind =
+        control.dataset.initialValueKind || "string";
+      if (resetOptions.dispatch !== false) {
+        field.dispatchChange();
+      }
+    },
+    isUsingSqliteDefault: function () {
+      return control.dataset.useSqliteDefault === "1";
+    },
+    useSqliteDefault: function (defaultOptions) {
+      defaultOptions = defaultOptions || {};
+      if (!context.hasSqliteDefault) {
+        return;
+      }
+      control.dataset.useSqliteDefault = "1";
+      control.disabled = true;
+      control.value = "";
+      control.dataset.currentValueKind = "null";
+      field.syncSqliteDefaultUi();
+      if (defaultOptions.dispatch !== false) {
+        field.dispatchChange();
+      }
+    },
+    stopUsingSqliteDefault: function (defaultOptions) {
+      defaultOptions = defaultOptions || {};
+      if (control.dataset.useSqliteDefault !== "1") {
+        return;
+      }
+      control.dataset.useSqliteDefault = "0";
+      control.disabled = false;
+      field.syncSqliteDefaultUi();
+      if (defaultOptions.dispatch !== false) {
+        field.dispatchChange();
+      }
+    },
+    syncSqliteDefaultUi: function () {},
+    dispatchChange: function () {
+      control.dispatchEvent(new Event("input", { bubbles: true }));
+      control.dispatchEvent(new Event("change", { bubbles: true }));
+    },
+    setValidity: function (message) {
+      message = message || "";
+      control.setCustomValidity(message);
+      if (message) {
+        control.setAttribute("aria-invalid", "true");
+      } else {
+        control.removeAttribute("aria-invalid");
+      }
+      var validationMessage = ensureColumnFieldValidationMessage(field);
+      if (validationMessage) {
+        validationMessage.textContent = message;
+        validationMessage.hidden = !message;
+      }
+    },
+    clearValidity: function () {
+      field.setValidity("");
+    },
+  };
+  return field;
+}
+
+function ensureColumnFieldValidationMessage(field) {
+  if (field.validationMessageElement) {
+    return field.validationMessageElement;
+  }
+  if (!field.meta) {
+    return null;
+  }
+  var validationMessage = document.createElement("span");
+  validationMessage.id = field.id + "-validation-error";
+  validationMessage.className = "row-edit-field-validation-error";
+  validationMessage.hidden = true;
+  validationMessage.setAttribute("role", "alert");
+  field.meta.appendChild(validationMessage);
+  field.validationMessageElement = validationMessage;
+  return validationMessage;
+}
+
 function renderColumnField(pluginControl, fieldApi) {
   if (!pluginControl || !pluginControl.render) {
     return null;
@@ -1029,8 +1179,9 @@ function renderColumnField(pluginControl, fieldApi) {
   if (fieldApi.context.columnType && fieldApi.context.columnType.type) {
     pluginWrap.dataset.columnType = fieldApi.context.columnType.type;
   }
+  fieldApi.root = pluginWrap;
   try {
-    var rendered = pluginControl.render(pluginWrap, fieldApi);
+    var rendered = pluginControl.render(fieldApi);
     if (rendered && rendered.nodeType) {
       pluginWrap.appendChild(rendered);
     }
@@ -1043,6 +1194,54 @@ function renderColumnField(pluginControl, fieldApi) {
   return pluginWrap;
 }
 
+function validateJsonColumnField(field) {
+  var value = field.input.value;
+  if (value.trim() === "") {
+    field.clearValidity();
+    return true;
+  }
+  try {
+    JSON.parse(value);
+    field.clearValidity();
+    return true;
+  } catch (error) {
+    field.setValidity(
+      "Invalid JSON" + (error && error.message ? ": " + error.message : ""),
+    );
+    return false;
+  }
+}
+
+function registerBuiltinColumnFieldPlugins(manager) {
+  if (!manager || !manager.registerPlugin) {
+    return;
+  }
+  manager.registerPlugin("datasette-json-column", {
+    version: "1.0",
+    makeColumnField: function (context) {
+      if (!context.columnType || context.columnType.type !== "json") {
+        return null;
+      }
+      return {
+        inputType: "textarea",
+        render: function (field) {
+          field.input.addEventListener("input", function () {
+            validateJsonColumnField(field);
+          });
+          field.input.addEventListener("change", function () {
+            validateJsonColumnField(field);
+          });
+          validateJsonColumnField(field);
+          field.root.appendChild(field.input);
+        },
+        focus: function (field) {
+          field.input.focus();
+        },
+      };
+    },
+  });
+}
+
 function focusRowEditPluginControl(field) {
   var pluginWrap = field.querySelector(".row-edit-plugin-control");
   if (!pluginWrap) {
@@ -1051,8 +1250,12 @@ function focusRowEditPluginControl(field) {
   var pluginControl = pluginWrap._datasetteColumnField;
   var fieldApi = pluginWrap._datasetteColumnFormField;
   if (pluginControl && pluginControl.focus) {
-    pluginControl.focus(pluginWrap, fieldApi);
-    return true;
+    try {
+      pluginControl.focus(fieldApi);
+      return true;
+    } catch (error) {
+      console.error("Error focusing column form control", error);
+    }
   }
   return false;
 }
@@ -1089,7 +1292,7 @@ function destroyRowEditFields(state) {
       var fieldApi = pluginWrap._datasetteColumnFormField;
       if (pluginControl && pluginControl.destroy) {
         try {
-          pluginControl.destroy(pluginWrap, fieldApi);
+          pluginControl.destroy(fieldApi);
         } catch (error) {
           console.error("Error destroying column form control", error);
         }
@@ -1102,10 +1305,12 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   options = options || {};
   var field = document.createElement("div");
   field.className = "row-edit-field";
-  var hasDefault =
-    options.hasDefault ||
-    (options.defaultValue !== null && typeof options.defaultValue !== "undefined");
-  var useDefaultInitially = hasDefault && options.useDefaultInitially;
+  var hasSqliteDefault =
+    options.hasSqliteDefault ||
+    (options.sqliteDefaultExpression !== null &&
+      typeof options.sqliteDefaultExpression !== "undefined");
+  var useSqliteDefaultInitially =
+    hasSqliteDefault && options.useSqliteDefaultInitially;
 
   var fieldId = "row-edit-field-" + index;
   var metaId = "row-edit-field-meta-" + index;
@@ -1136,12 +1341,15 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   control.name = column;
   control.value = valueToEditText(value);
   control.setAttribute("aria-describedby", metaId);
-  control.dataset.originalValue = valueToEditText(value);
-  control.dataset.originalValueType =
-    options.valueType || rowEditValueType(value);
+  control.dataset.initialValue = valueToEditText(value);
+  control.dataset.initialValueKind =
+    options.valueKind || rowEditValueKind(value);
   control.dataset.primaryKey = isPk ? "1" : "0";
-  if (useDefaultInitially) {
-    control.dataset.useDefault = "1";
+  control.dataset.currentValueKind = control.dataset.initialValueKind;
+  if (hasSqliteDefault) {
+    control.dataset.useSqliteDefault = useSqliteDefaultInitially ? "1" : "0";
+  }
+  if (useSqliteDefaultInitially) {
     control.disabled = true;
   }
   if (options.omitIfBlank) {
@@ -1172,8 +1380,8 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   if (options.notnull) {
     metaParts.push("Required");
   }
-  if (hasDefault && !useDefaultInitially) {
-    metaParts.push("Default: " + options.defaultValue);
+  if (hasSqliteDefault && !useSqliteDefaultInitially) {
+    metaParts.push("SQLite default: " + options.sqliteDefaultExpression);
   }
   if (value === null) {
     metaParts.push("Current value: NULL");
@@ -1208,16 +1416,17 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     meta.appendChild(foreignKeyLinkWrap);
     updateRowEditFieldMetaHidden(meta);
   }
-  var fieldApi = {
+  var fieldApi = createColumnFieldApi({
     id: fieldId,
     labelId: labelId,
     descriptionId: metaId,
-    input: control,
     control: control,
+    meta: meta,
+    input: control,
     form: options.form || null,
     dialog: options.dialog || null,
     context: context,
-  };
+  });
   var pluginControlElement = renderColumnField(pluginControl, fieldApi);
   var controlElement =
     pluginControlElement || rowEditControlElement(control, options.autocompleteUrl);
@@ -1238,7 +1447,7 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
   }
 
-  if (useDefaultInitially) {
+  if (hasSqliteDefault) {
     var defaultBlock = document.createElement("div");
     defaultBlock.className = "row-edit-default";
     defaultBlock.setAttribute("aria-describedby", metaId);
@@ -1248,7 +1457,7 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     defaultText.appendChild(document.createTextNode("default "));
     var defaultCode = document.createElement("code");
     defaultCode.className = "row-edit-default-code";
-    defaultCode.textContent = options.defaultValue;
+    defaultCode.textContent = options.sqliteDefaultExpression;
     defaultText.appendChild(defaultCode);
 
     var setValueButton = document.createElement("button");
@@ -1262,35 +1471,37 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     customWrap.className = "row-edit-custom-value";
     customWrap.hidden = true;
 
-    var useDefaultButton = document.createElement("button");
-    useDefaultButton.type = "button";
-    useDefaultButton.className = "row-edit-default-button";
-    useDefaultButton.textContent = "Use default";
-    useDefaultButton.setAttribute("aria-label", "Use default for " + column);
+    var useSqliteDefaultButton = document.createElement("button");
+    useSqliteDefaultButton.type = "button";
+    useSqliteDefaultButton.className = "row-edit-default-button";
+    useSqliteDefaultButton.textContent = "Use default";
+    useSqliteDefaultButton.setAttribute(
+      "aria-label",
+      "Use SQLite default for " + column,
+    );
 
     setValueButton.addEventListener("click", function () {
-      control.dataset.useDefault = "0";
-      control.disabled = false;
-      defaultBlock.hidden = true;
-      customWrap.hidden = false;
+      fieldApi.stopUsingSqliteDefault();
       control.focus();
     });
 
-    useDefaultButton.addEventListener("click", function () {
-      control.dataset.useDefault = "1";
-      control.disabled = true;
-      control.value = "";
-      customWrap.hidden = true;
-      defaultBlock.hidden = false;
+    useSqliteDefaultButton.addEventListener("click", function () {
+      fieldApi.useSqliteDefault();
       setValueButton.focus();
     });
 
     defaultBlock.appendChild(defaultText);
     defaultBlock.appendChild(setValueButton);
     customWrap.appendChild(controlElement);
-    customWrap.appendChild(useDefaultButton);
+    customWrap.appendChild(useSqliteDefaultButton);
     controlWrap.appendChild(defaultBlock);
     controlWrap.appendChild(customWrap);
+    fieldApi.syncSqliteDefaultUi = function () {
+      var usingDefault = fieldApi.isUsingSqliteDefault();
+      defaultBlock.hidden = !usingDefault;
+      customWrap.hidden = usingDefault;
+    };
+    fieldApi.syncSqliteDefaultUi();
   } else {
     controlWrap.appendChild(controlElement);
   }
@@ -1340,17 +1551,19 @@ function valueFromRowEditControl(control) {
   return valueFromRowEditText(
     control.name,
     value,
-    control.dataset.originalValueType || "string",
+    control.dataset.currentValueKind ||
+      control.dataset.initialValueKind ||
+      "string",
   );
 }
 
-function valueFromRowEditText(name, value, originalValueType) {
+function valueFromRowEditText(name, value, initialValueKind) {
   var trimmed = value.trim();
 
-  if (originalValueType === "null" && value === "") {
+  if (initialValueKind === "null" && value === "") {
     return null;
   }
-  if (originalValueType === "number") {
+  if (initialValueKind === "number") {
     if (trimmed === "") {
       return null;
     }
@@ -1360,7 +1573,7 @@ function valueFromRowEditText(name, value, originalValueType) {
     }
     return numberValue;
   }
-  if (originalValueType === "boolean") {
+  if (initialValueKind === "boolean") {
     if (/^(true|1|yes)$/i.test(trimmed)) {
       return true;
     }
@@ -1369,24 +1582,14 @@ function valueFromRowEditText(name, value, originalValueType) {
     }
     throw new Error(name + " must be true or false");
   }
-  if (originalValueType === "json") {
-    if (trimmed === "") {
-      return null;
-    }
-    try {
-      return JSON.parse(value);
-    } catch (_error) {
-      throw new Error(name + " must be valid JSON");
-    }
-  }
   return value;
 }
 
-function originalValueFromRowEditControl(control) {
+function initialValueFromRowEditControl(control) {
   return valueFromRowEditText(
     control.name,
-    control.dataset.originalValue || "",
-    control.dataset.originalValueType || "string",
+    control.dataset.initialValue || "",
+    control.dataset.initialValueKind || "string",
   );
 }
 
@@ -1414,19 +1617,32 @@ function collectRowFormValues(state) {
     ) {
       return;
     }
-    if (control.dataset.useDefault === "1") {
+    if (control.dataset.useSqliteDefault === "1") {
       return;
     }
     if (control.dataset.omitIfBlank === "1" && control.value === "") {
       return;
     }
-    var value = valueFromRowEditControl(control);
     if (
       state.mode === "edit" &&
-      rowEditValuesMatch(value, originalValueFromRowEditControl(control))
+      control.value === (control.dataset.initialValue || "") &&
+      (control.dataset.currentValueKind ||
+        control.dataset.initialValueKind ||
+        "string") === (control.dataset.initialValueKind || "string")
     ) {
       return;
     }
+    var value = valueFromRowEditControl(control);
+    if (state.mode === "edit") {
+      try {
+        if (rowEditValuesMatch(value, initialValueFromRowEditControl(control))) {
+          return;
+        }
+      } catch (_error) {
+        // If the original value cannot be parsed using the field's current
+        // type, treat the field as changed and submit the corrected value.
+      }
+    }
     values[control.name] = value;
   });
   return values;
@@ -1688,16 +1904,16 @@ function renderRowInsertFields(state, data) {
         {
           autocompleteUrl: foreignKeyAutocompleteUrl(column.name),
           dialog: state.dialog,
-          defaultValue: column.default,
           form: state.form,
-          hasDefault: column.has_default,
+          hasSqliteDefault: column.has_default,
           manager: state.manager,
           mode: state.mode,
           notnull: column.notnull,
           primaryKeyReadonly: false,
-          sqliteType: column.type,
-          useDefaultInitially: column.has_default,
-          valueType: column.value_type,
+          sqliteDefaultExpression: column.default,
+          sqliteType: column.sqlite_type,
+          useSqliteDefaultInitially: column.has_default,
+          valueKind: column.value_kind,
         },
       ),
     );
@@ -2395,6 +2611,7 @@ function openColumnChooser() {
 document.addEventListener("datasette_init", function (evt) {
   const { detail: manager } = evt;
 
+  registerBuiltinColumnFieldPlugins(manager);
   initializeColumnActions(manager);
 
   // Main table
diff --git a/datasette/views/table.py b/datasette/views/table.py
index dc2589e9..de7b0216 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -241,15 +241,18 @@ async def _validate_column_types(datasette, database_name, table_name, rows):
     return errors
 
 
-def _column_value_type_for_insert_form(column_detail, column_type):
-    if column_type is not None and column_type.name == "json":
-        return "json"
+def _column_value_kind_for_insert_form(column_detail):
     sqlite_type = SQLiteType.from_declared_type(column_detail.type)
     if sqlite_type in (SQLiteType.INTEGER, SQLiteType.REAL):
         return "number"
     return "string"
 
 
+def _column_sqlite_type_for_insert_form(column_detail):
+    sqlite_type = SQLiteType.from_declared_type(column_detail.type)
+    return sqlite_type.value if sqlite_type is not None else None
+
+
 async def _foreign_key_autocomplete_urls(
     datasette, request, db, database_name, table_name
 ):
@@ -326,12 +329,12 @@ async def _table_insert_ui(
         columns.append(
             {
                 "name": column.name,
-                "type": column.type,
+                "sqlite_type": _column_sqlite_type_for_insert_form(column),
                 "notnull": column.notnull,
                 "default": column.default_value,
                 "has_default": column.default_value is not None,
                 "is_pk": is_pk,
-                "value_type": _column_value_type_for_insert_form(column, column_type),
+                "value_kind": _column_value_kind_for_insert_form(column),
                 "column_type": (
                     {"type": column_type.name, "config": column_type.config}
                     if column_type is not None
diff --git a/docs/javascript_plugins.rst b/docs/javascript_plugins.rst
index d298b6d4..e1a889b4 100644
--- a/docs/javascript_plugins.rst
+++ b/docs/javascript_plugins.rst
@@ -198,13 +198,13 @@ makeColumnField(context)
 
 This method, if present, can provide a custom form field for a column in Datasette's row insert and edit dialogs.
 
-It is designed for plugins that register custom column types using the Python ``register_column_types()`` plugin hook. For example, a plugin that defines a ``file`` column type can use ``makeColumnField()`` to replace a plain text input with a file picker, and a plugin that defines a rich text column type can use it to enhance the field with an editor.
+It is designed for plugins that :ref:`register custom column types <plugin_register_column_types>` using the Python ``register_column_types()`` plugin hook. For example, a plugin that defines a ``file`` column type can use ``makeColumnField()`` to replace a plain text input with a file picker, and a plugin that defines a rich text column type can use it to enhance the field with an editor.
 
 Datasette calls ``makeColumnField(context)`` on each registered JavaScript plugin when it renders an editable insert/edit field. Plugins should inspect the ``context`` object and return ``null`` or ``undefined`` for fields they do not handle.
 
 The first plugin to return a truthy control object is used for that field. Plugins are called in registration order. If a plugin raises an exception, Datasette logs the error to the browser console and continues to the next plugin.
 
-The value that Datasette submits is still read from the core-owned input or textarea provided to the plugin as ``field.input``. This keeps custom fields progressive: the plugin can render any UI it needs, but it must keep ``field.input.value`` synchronized with the raw value that should be sent to the insert/update API.
+Datasette owns the value that will be submitted to the insert/update API. The ``context`` object describes the column and form environment; custom controls should read and write field values using the ``field`` helper object passed to ``render(field)``.
 
 Context object
 ^^^^^^^^^^^^^^
@@ -221,22 +221,26 @@ Context object
     The table name.
 
 ``tableUrl`` - string or null
-    The path to the table page, including any configured base URL prefix.
+    The path to the table page, including any configured :ref:`base URL prefix <setting_base_url>`.
 
 ``column`` - string
     The column name.
 
-``value``
-    The current JavaScript value for the field. For edit forms this is the row's current value. For insert forms this is usually ``null`` or ``""``.
-
-``originalValue``
-    The value the field had when the form was opened. This currently matches ``value``.
-
 ``columnType`` - object or null
-    The configured Datasette column type for this column, if one exists. This object includes a ``type`` key containing the column type name. Plugins should generally check ``context.columnType && context.columnType.type`` before deciding whether to handle a field.
+    The configured Datasette column type for this column, if one exists. This is ``null`` if no column type has been configured.
+
+    If present, this object has exactly these keys:
+
+    ``type`` - string
+        The :ref:`registered column type name <plugin_register_column_types>`, matching the ``name`` attribute of the Python ``ColumnType`` subclass.
+
+    ``config`` - object
+        Configuration for this specific column type assignment. This is ``{}`` if no configuration has been set.
+
+    Plugins should generally check ``context.columnType && context.columnType.type`` before deciding whether to handle a field.
 
 ``sqliteType`` - string or null
-    The SQLite column type, if known.
+    The normalized SQLite type for this column, if known. This is one of ``"TEXT"``, ``"INTEGER"``, ``"REAL"``, ``"BLOB"``, ``"NULL"`` or ``null`` if Datasette could not determine the type.
 
 ``notNull`` - boolean
     True if the column is defined as ``NOT NULL``.
@@ -244,14 +248,14 @@ Context object
 ``isPrimaryKey`` - boolean
     True if this column is part of the table's primary key.
 
-``readOnly`` - boolean
-    True if Datasette is rendering the field as read-only. Primary key fields are read-only in edit forms by default.
-
-``hasDefault`` - boolean
+``hasSqliteDefault`` - boolean
     True if the column has a SQLite default value and the insert form can offer the "use default" behavior.
 
-``defaultValue``
-    The column default value or expression, if available.
+``sqliteDefaultExpression``
+    The SQLite default expression for the column, if available. This is the expression from the table schema, not the actual value SQLite will insert.
+
+``useSqliteDefaultInitially`` - boolean
+    True if the insert form should initially omit this column so SQLite uses the column default.
 
 ``form`` - ``HTMLFormElement`` or null
     The row insert/edit form element.
@@ -267,15 +271,15 @@ A plugin that wants to handle a field should return an object. Datasette current
 ``inputType`` - string, optional
     If set to ``"textarea"``, Datasette creates a ``<textarea>`` as the underlying ``field.input`` before calling ``render()``. Any other value is ignored.
 
-``render(node, field)`` - function
-    Called once to render the custom field UI. ``node`` is an empty container element created by Datasette. ``field`` is a helper object described below.
+``render(field)`` - function
+    Called once to render the custom field UI. ``field`` is a helper object described below.
 
-    The plugin should append its UI to ``node``. If ``render()`` returns a DOM node, Datasette appends that returned node to ``node``.
+    The plugin should append its UI to ``field.root``. If ``render()`` returns a DOM node, Datasette appends that returned node to ``field.root``.
 
-``focus(node, field)`` - function, optional
+``focus(field)`` - function, optional
     Called when Datasette wants to focus this field, for example when focusing the first editable field in the dialog. Use this to focus the most useful interactive element inside the custom UI.
 
-``destroy(node, field)`` - function, optional
+``destroy(field)`` - function, optional
     Called when Datasette tears down the insert/edit form. Use this to remove event listeners, close nested pickers, revoke object URLs, clear timers, or release other resources.
 
 Datasette adds a ``pluginName`` property to the control object internally, based on the name passed to ``registerPlugin()``.
@@ -283,7 +287,10 @@ Datasette adds a ``pluginName`` property to the control object internally, based
 The field helper object
 ^^^^^^^^^^^^^^^^^^^^^^^
 
-The second argument to ``render(node, field)`` provides the core input and stable IDs that help the plugin integrate with the modal's form and accessibility behavior:
+The ``field`` object passed to ``render(field)``, ``focus(field)`` and ``destroy(field)`` provides stable IDs, DOM elements and value helpers for integrating with the row insert/edit dialog:
+
+``context`` - object
+    The original context object passed to ``makeColumnField()``.
 
 ``id`` - string
     The ID Datasette assigned to the underlying form control.
@@ -294,48 +301,103 @@ The second argument to ``render(node, field)`` provides the core input and stabl
 ``descriptionId`` - string
     The ID of the field metadata/help text. This metadata can include details such as ``Primary key``, ``Required``, ``Current value: NULL`` or ``Custom type: file``.
 
+``root`` - ``HTMLElement``
+    The empty container element created by Datasette for this custom field. Plugins should append their UI to this element.
+
 ``input`` - ``HTMLInputElement`` or ``HTMLTextAreaElement``
-    The core-owned form control. Datasette reads this element's ``name``, ``value`` and ``dataset`` properties when the row is inserted or updated.
+    The core-owned backing form control. Plugins can keep this visible, wrap it or hide it, but should use the value helper methods below rather than mutating ``input.value`` directly.
 
 ``control``
     An alias for ``input``.
 
+``meta`` - ``HTMLElement`` or null
+    The field metadata/help text element.
+
 ``form`` - ``HTMLFormElement`` or null
     The containing row insert/edit form.
 
 ``dialog`` - ``HTMLDialogElement`` or null
     The containing modal dialog.
 
-``context`` - object
-    The original context object passed to ``makeColumnField()``.
+``getValue()`` - function
+    Returns the current value Datasette will submit for this field.
 
-Value handling
-^^^^^^^^^^^^^^
+    Datasette uses string values by default. Insert fields for ``"INTEGER"`` and ``"REAL"`` SQLite columns return numbers, or ``null`` if left blank. Plugins can use strings, numbers, booleans or ``null``. If a plugin is editing structured data stored in a SQLite ``TEXT`` column, such as JSON, it should serialize that data to a string before calling ``setValue()``.
 
-Custom fields should keep ``field.input.value`` synchronized with the raw value to submit.
+``setValue(value, options)`` - function
+    Sets the current value Datasette will submit for this field. ``value`` should be a string, number, boolean or ``null``. This also dispatches ``input`` and ``change`` events from the backing input. Pass ``{dispatch: false}`` as the second argument to skip those events.
 
-If a custom field changes the value programmatically, it should dispatch normal ``input`` and ``change`` events so the rest of the form can observe the update:
+    Calling ``setValue()`` also stops using the SQLite default for the field, if it was previously selected.
+
+``getInitialValue()`` - function
+    Returns the submitted-value representation the field had when the form was rendered. For edit forms this is the raw row value from the database. For insert forms this is the blank starting value.
+
+``hasChanged()`` - function
+    Returns true if the field value differs from its initial value, or if the field's SQLite-default state has changed.
+
+``clearValue(options)`` - function
+    Sets the value to ``null``. Accepts the same options as ``setValue()``.
+
+``resetValue(options)`` - function
+    Restores the initial field value. Accepts the same options as ``setValue()``.
+
+``isUsingSqliteDefault()`` - function
+    Returns true if the insert dialog is currently set to omit this column and use the SQLite default.
+
+``useSqliteDefault(options)`` - function
+    Switches the field to use the SQLite default, if one exists. Accepts ``{dispatch: false}``.
+
+``stopUsingSqliteDefault(options)`` - function
+    Switches the field away from the SQLite default without changing the current field value. Accepts ``{dispatch: false}``.
+
+``dispatchChange()`` - function
+    Dispatches ``input`` and ``change`` events from the backing input.
+
+``setValidity(message)`` - function
+    Sets a custom validation message for this field, marks the backing input with ``aria-invalid="true"`` and shows the message in the field metadata area. Pass an empty string to clear the error.
+
+``clearValidity()`` - function
+    Clears any custom validation message previously set by ``setValidity()``.
+
+Submitted value contract
+^^^^^^^^^^^^^^^^^^^^^^^^
+
+The field value contract is deliberately narrow. Datasette submits field values to the row insert/update JSON API, so a custom field value should be one of:
+
+* string
+* number
+* boolean
+* ``null``
+
+Plugins should not pass objects or arrays to ``field.setValue()``. If a column stores structured data in SQLite, such as JSON in a ``TEXT`` column, the plugin should serialize that data first and submit the serialized string. Client-side parsing can still be useful for validation or editor state, but the submitted value should match the SQLite value Datasette should write.
+
+``field.input.dataset`` is reserved for Datasette's private form state. Plugins should not read from it, write to it, or use it to change how Datasette serializes values.
+
+Value helpers
+^^^^^^^^^^^^^
+
+Custom fields should use ``field.getValue()`` and ``field.setValue(value)`` for value handling:
 
 .. code-block:: javascript
 
-    function setInputValue(input, value) {
-      input.value = value || "";
-      input.dispatchEvent(new Event("input", { bubbles: true }));
-      input.dispatchEvent(new Event("change", { bubbles: true }));
-    }
+    const currentValue = field.getValue();
+    field.setValue("new value");
+    field.setValue(null);
 
-Plugins can either keep the core input visible, wrap it in a custom element, or hide it and provide a richer interface. If the input is hidden, the custom UI must still expose an accessible name, state and keyboard interaction.
+Plugins can keep the core input visible, wrap it in a custom element, or hide it and provide a richer interface. If the input is hidden, the custom UI must still expose an accessible name, state and keyboard interaction.
 
-If the plugin changes the kind of value stored in the underlying input, it can adjust ``field.input.dataset.originalValueType``. Datasette uses that dataset value when converting the submitted text back to a JSON value for the insert/update API.
+``field.setValue()`` updates the backing input and Datasette's private value serialization state.
 
-For example, a file picker that stores a string file ID can set:
+For insert forms with a SQLite default, ``field.isUsingSqliteDefault()`` indicates whether Datasette will omit that column from the insert payload. Calling ``field.setValue(value)`` automatically stops using the SQLite default. A plugin can also expose explicit controls that call ``field.useSqliteDefault()`` and ``field.stopUsingSqliteDefault()``.
+
+Datasette's built-in ``json`` column type is implemented using this same JavaScript plugin hook. Datasette registers a small textarea-backed control for fields where ``context.columnType.type === "json"``; that control validates the field as JSON while the value changes and marks it visibly invalid if parsing fails. The submitted value remains the textarea string. The generic field API does not special-case custom column types.
+
+For example, a file picker can store a file ID string or ``null`` without modifying the backing input directly:
 
 .. code-block:: javascript
 
     field.input.type = "hidden";
-    field.input.dataset.originalValueType = "null";
-
-This causes an empty string to be submitted as ``null``.
+    field.setValue(fileId || null);
 
 Lazy loading large controls
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -356,8 +418,8 @@ The JavaScript file that registers ``makeColumnField()`` should be small. If the
           }
           return {
             inputType: "textarea",
-            render(node, field) {
-              node.appendChild(field.input);
+            render(field) {
+              field.root.appendChild(field.input);
               import(editorUrl).then(function () {
                 // Enhance field.input here.
               });
@@ -386,10 +448,10 @@ This example handles a ``markdown-editor`` column type by asking Datasette for a
           return {
             inputType: "textarea",
 
-            render(node, field) {
+            render(field) {
               const editor = document.createElement("my-markdown-editor");
               editor.appendChild(field.input);
-              node.appendChild(editor);
+              field.root.appendChild(editor);
 
               if (field.labelId) {
                 field.input.setAttribute("aria-labelledby", field.labelId);
@@ -399,8 +461,8 @@ This example handles a ``markdown-editor`` column type by asking Datasette for a
               }
             },
 
-            focus(node, field) {
-              const editor = node.querySelector("my-markdown-editor");
+            focus(field) {
+              const editor = field.root.querySelector("my-markdown-editor");
               if (editor && editor.focus) {
                 editor.focus();
               } else {
@@ -429,9 +491,8 @@ This example handles an ``asset`` column type by hiding the core input and writi
           }
 
           return {
-            render(node, field) {
+            render(field) {
               field.input.type = "hidden";
-              field.input.dataset.originalValueType = "null";
 
               const group = document.createElement("div");
               group.setAttribute("role", "group");
@@ -439,7 +500,7 @@ This example handles an ``asset`` column type by hiding the core input and writi
               group.setAttribute("aria-describedby", field.descriptionId);
 
               const current = document.createElement("span");
-              current.textContent = field.input.value || "No asset selected";
+              current.textContent = field.getValue() || "No asset selected";
 
               const button = document.createElement("button");
               button.type = "button";
@@ -449,20 +510,18 @@ This example handles an ``asset`` column type by hiding the core input and writi
                 if (assetId === null) {
                   return;
                 }
-                field.input.value = assetId;
-                field.input.dispatchEvent(new Event("input", { bubbles: true }));
-                field.input.dispatchEvent(new Event("change", { bubbles: true }));
+                field.setValue(assetId || null);
                 current.textContent = assetId || "No asset selected";
               });
 
               group.appendChild(current);
               group.appendChild(button);
-              node.appendChild(field.input);
-              node.appendChild(group);
+              field.root.appendChild(field.input);
+              field.root.appendChild(group);
             },
 
-            focus(node) {
-              const button = node.querySelector("button");
+            focus(field) {
+              const button = field.root.querySelector("button");
               if (button) {
                 button.focus();
               }
diff --git a/tests/test_datasette_manager_js.py b/tests/test_datasette_manager_js.py
new file mode 100644
index 00000000..5e21b5bb
--- /dev/null
+++ b/tests/test_datasette_manager_js.py
@@ -0,0 +1,515 @@
+import json
+from pathlib import Path
+import subprocess
+import textwrap
+
+STATIC_DIR = Path(__file__).resolve().parents[1] / "datasette" / "static"
+
+
+def test_datasette_manager_make_column_field():
+    script = textwrap.dedent("""
+        const fs = require("fs");
+        const vm = require("vm");
+        const datasetteManagerJs = __DATASETTE_MANAGER_JS__;
+
+        const documentListeners = {};
+        global.CustomEvent = class {
+          constructor(name, options) {
+            this.type = name;
+            this.detail = options ? options.detail : undefined;
+          }
+        };
+        global.document = {
+          addEventListener(name, callback) {
+            documentListeners[name] = documentListeners[name] || [];
+            documentListeners[name].push(callback);
+          },
+          dispatchEvent(event) {
+            for (const callback of documentListeners[event.type] || []) {
+              callback(event);
+            }
+          },
+        };
+        global.window = { datasetteVersion: "test" };
+
+        vm.runInThisContext(
+          fs.readFileSync(datasetteManagerJs, "utf8"),
+          { filename: "datasette-manager.js" }
+        );
+        for (const callback of documentListeners.DOMContentLoaded || []) {
+          callback();
+        }
+
+        window.__DATASETTE__.registerPlugin("declines", {
+          makeColumnField() {
+            return null;
+          },
+        });
+        window.__DATASETTE__.registerPlugin("handles", {
+          makeColumnField(context) {
+            if (context.columnType.type !== "demo") {
+              return null;
+            }
+            return { inputType: "textarea" };
+          },
+        });
+
+        const control = window.__DATASETTE__.makeColumnField({
+          column: "body",
+          columnType: { type: "demo", config: null },
+        });
+        console.log(JSON.stringify(control));
+    """).replace(
+        "__DATASETTE_MANAGER_JS__",
+        json.dumps(str(STATIC_DIR / "datasette-manager.js")),
+    )
+    result = subprocess.run(
+        ["node", "-e", script],
+        text=True,
+        capture_output=True,
+        check=False,
+    )
+    assert result.returncode == 0, result.stderr
+    assert json.loads(result.stdout) == {
+        "pluginName": "handles",
+        "inputType": "textarea",
+    }
+
+
+def test_table_plugin_column_field_api():
+    script = textwrap.dedent("""
+        const fs = require("fs");
+        const vm = require("vm");
+        const tableJs = __TABLE_JS__;
+
+        class FakeEvent {
+          constructor(type, options) {
+            this.type = type;
+            this.bubbles = !!(options && options.bubbles);
+          }
+        }
+
+        class FakeElement {
+          constructor(tagName = "div") {
+            this.nodeName = tagName.toUpperCase();
+            this.nodeType = 1;
+            this.children = [];
+            this.dataset = {};
+            this.attributes = {};
+            this.value = "";
+            this.name = "";
+            this.disabled = false;
+            this.readOnly = false;
+            this.dispatchedEvents = [];
+            this.eventListeners = {};
+            this.validationMessage = "";
+            this.hidden = false;
+            this.textContent = "";
+            this.className = "";
+            this.classList = {
+              add: (...names) => {
+                const classes = new Set(this.className.split(/\\s+/).filter(Boolean));
+                for (const name of names) {
+                  classes.add(name);
+                }
+                this.className = Array.from(classes).join(" ");
+              },
+              remove: (...names) => {
+                const removeNames = new Set(names);
+                this.className = this.className
+                  .split(/\\s+/)
+                  .filter((name) => name && !removeNames.has(name))
+                  .join(" ");
+              },
+              contains: (name) => this.className.split(/\\s+/).includes(name),
+            };
+          }
+          appendChild(child) {
+            this.children.push(child);
+            child.parentNode = this;
+            return child;
+          }
+          addEventListener(type, callback) {
+            this.eventListeners[type] = this.eventListeners[type] || [];
+            this.eventListeners[type].push(callback);
+          }
+          dispatchEvent(event) {
+            event.target = event.target || this;
+            this.dispatchedEvents.push(event.type);
+            for (const callback of this.eventListeners[event.type] || []) {
+              callback(event);
+            }
+            return true;
+          }
+          setAttribute(name, value) {
+            this.attributes[name] = String(value);
+          }
+          getAttribute(name) {
+            return this.attributes[name] || null;
+          }
+          removeAttribute(name) {
+            delete this.attributes[name];
+          }
+          setCustomValidity(message) {
+            this.validationMessage = message;
+          }
+        }
+
+        global.Event = FakeEvent;
+        global.document = {
+          addEventListener() {},
+          createElement(tagName) {
+            return new FakeElement(tagName);
+          },
+          createTextNode(text) {
+            const node = new FakeElement("#text");
+            node.textContent = text;
+            return node;
+          },
+        };
+        global.location = {
+          href: "http://localhost/data/projects",
+          pathname: "/data/projects",
+          search: "",
+        };
+        global.window = {
+          _datasetteTableData: {
+            database: "data",
+            table: "projects",
+            tableUrl: "/data/projects",
+          },
+        };
+
+        vm.runInThisContext(fs.readFileSync(tableJs, "utf8"), {
+          filename: "table.js",
+        });
+
+        const context = columnFormControlContext(
+          "logo",
+          "df-old",
+          false,
+          { type: "file", config: null },
+          {
+            mode: "edit",
+            hasSqliteDefault: true,
+            sqliteDefaultExpression: "lower(hex(randomblob(4)))",
+            useSqliteDefaultInitially: true,
+          }
+        );
+        if ("defaultValue" in context) {
+          throw new Error("context should not expose defaultValue");
+        }
+        if (!context.hasSqliteDefault) {
+          throw new Error("context.hasSqliteDefault should be true");
+        }
+        if (context.sqliteDefaultExpression !== "lower(hex(randomblob(4)))") {
+          throw new Error("context.sqliteDefaultExpression was not set");
+        }
+        if (JSON.stringify(context.columnType) !== '{"type":"file","config":{}}') {
+          throw new Error("context.columnType should expose type and object config");
+        }
+        if ("value" in context || "valueType" in context) {
+          throw new Error("context should not expose value state");
+        }
+        if ("initialValue" in context || "initialValueKind" in context) {
+          throw new Error("context should not expose initial value state");
+        }
+
+        const control = new FakeElement("input");
+        control.name = "logo";
+        control.value = "df-old";
+        control.dataset.initialValue = "df-old";
+        control.dataset.initialValueKind = "string";
+        control.dataset.currentValueKind = "string";
+        control.dataset.useSqliteDefault = "1";
+        control.disabled = true;
+
+        const field = createColumnFieldApi({
+          id: "row-edit-field-0",
+          labelId: "row-edit-field-label-0",
+          descriptionId: "row-edit-field-meta-0",
+          control,
+          meta: new FakeElement("span"),
+          context,
+        });
+
+        let renderArgumentCount = null;
+        let renderField = null;
+        const wrapper = renderColumnField(
+          {
+            pluginName: "test-plugin",
+            render(field) {
+              renderArgumentCount = arguments.length;
+              renderField = field;
+              field.root.appendChild(document.createElement("button"));
+            },
+          },
+          field
+        );
+        if (renderArgumentCount !== 1 || renderField !== field) {
+          throw new Error("plugin render should receive the field object only");
+        }
+        if (field.root !== wrapper) {
+          throw new Error("field.root should be the plugin wrapper");
+        }
+
+        field.setValue(null);
+        if (field.getValue() !== null) {
+          throw new Error("field.setValue(null) should round-trip as null");
+        }
+        if (field.isUsingSqliteDefault()) {
+          throw new Error("field.setValue() should stop using the SQLite default");
+        }
+        if (control.dataset.currentValueKind !== "null") {
+          throw new Error("null values should update currentValueKind");
+        }
+
+        field.setValue("df-new");
+        if (field.getValue() !== "df-new") {
+          throw new Error("field.setValue() should update the current value");
+        }
+        if (field.getInitialValue() !== "df-old") {
+          throw new Error("field.getInitialValue() should remain stable");
+        }
+        if (!field.hasChanged()) {
+          throw new Error("field.hasChanged() should notice plugin value changes");
+        }
+        if (control.dispatchedEvents.join(",") !== "input,change,input,change") {
+          throw new Error(`Unexpected dispatched events: ${control.dispatchedEvents}`);
+        }
+        try {
+          field.setValue({ id: "df-object" });
+          throw new Error("field.setValue() should reject object values");
+        } catch (error) {
+          if (!String(error.message).includes("serialize objects")) {
+            throw error;
+          }
+        }
+
+        field.setValidity("Pick a file");
+        if (control.validationMessage !== "Pick a file") {
+          throw new Error("field.setValidity() should set custom validity");
+        }
+        if (control.getAttribute("aria-invalid") !== "true") {
+          throw new Error("field.setValidity() should set aria-invalid");
+        }
+        if (!field.validationMessageElement || field.validationMessageElement.hidden) {
+          throw new Error("field.setValidity() should show a field validation message");
+        }
+        field.clearValidity();
+        if (control.validationMessage !== "" || control.getAttribute("aria-invalid") !== null) {
+          throw new Error("field.clearValidity() should clear custom validity");
+        }
+
+        field.useSqliteDefault();
+        if (!field.isUsingSqliteDefault() || !control.disabled) {
+          throw new Error("field.useSqliteDefault() should mark and disable control");
+        }
+
+        process.stdout.write("ok");
+    """).replace("__TABLE_JS__", json.dumps(str(STATIC_DIR / "table.js")))
+    result = subprocess.run(
+        ["node", "-e", script],
+        text=True,
+        capture_output=True,
+        check=False,
+    )
+    assert result.returncode == 0, result.stderr
+    assert result.stdout == "ok"
+
+
+def test_builtin_json_column_field_validation():
+    script = textwrap.dedent("""
+        const fs = require("fs");
+        const vm = require("vm");
+        const tableJs = __TABLE_JS__;
+
+        class FakeEvent {
+          constructor(type, options) {
+            this.type = type;
+            this.bubbles = !!(options && options.bubbles);
+          }
+        }
+
+        class FakeElement {
+          constructor(tagName = "div") {
+            this.nodeName = tagName.toUpperCase();
+            this.nodeType = 1;
+            this.children = [];
+            this.dataset = {};
+            this.attributes = {};
+            this.value = "";
+            this.name = "";
+            this.disabled = false;
+            this.hidden = false;
+            this.textContent = "";
+            this.validationMessage = "";
+            this.eventListeners = {};
+            this.className = "";
+          }
+          appendChild(child) {
+            this.children.push(child);
+            child.parentNode = this;
+            return child;
+          }
+          addEventListener(type, callback) {
+            this.eventListeners[type] = this.eventListeners[type] || [];
+            this.eventListeners[type].push(callback);
+          }
+          dispatchEvent(event) {
+            event.target = event.target || this;
+            for (const callback of this.eventListeners[event.type] || []) {
+              callback(event);
+            }
+            return true;
+          }
+          setAttribute(name, value) {
+            this.attributes[name] = String(value);
+          }
+          getAttribute(name) {
+            return this.attributes[name] || null;
+          }
+          removeAttribute(name) {
+            delete this.attributes[name];
+          }
+          setCustomValidity(message) {
+            this.validationMessage = message;
+          }
+        }
+
+        global.Event = FakeEvent;
+        global.document = {
+          addEventListener() {},
+          createElement(tagName) {
+            return new FakeElement(tagName);
+          },
+          createTextNode(text) {
+            const node = new FakeElement("#text");
+            node.textContent = text;
+            return node;
+          },
+        };
+        global.location = {
+          href: "http://localhost/data/projects",
+          pathname: "/data/projects",
+          search: "",
+        };
+        global.window = {
+          _datasetteTableData: {
+            database: "data",
+            table: "projects",
+            tableUrl: "/data/projects",
+          },
+        };
+
+        vm.runInThisContext(fs.readFileSync(tableJs, "utf8"), {
+          filename: "table.js",
+        });
+
+        const plugins = [];
+        registerBuiltinColumnFieldPlugins({
+          registerPlugin(name, plugin) {
+            plugins.push({ name, plugin });
+          },
+        });
+        const jsonPlugin = plugins.find((entry) => entry.name === "datasette-json-column");
+        if (!jsonPlugin) {
+          throw new Error("datasette-json-column plugin was not registered");
+        }
+        const pluginControl = jsonPlugin.plugin.makeColumnField({
+          column: "metadata",
+          columnType: { type: "json", config: {} },
+        });
+        if (!pluginControl || pluginControl.inputType !== "textarea") {
+          throw new Error("JSON column plugin should request a textarea");
+        }
+
+        const context = columnFormControlContext(
+          "metadata",
+          '{"ok": true}',
+          false,
+          { type: "json", config: {} },
+          { mode: "edit" }
+        );
+        const control = new FakeElement("textarea");
+        control.name = "metadata";
+        control.value = '{"ok": true}';
+        control.dataset.initialValue = '{"ok": true}';
+        control.dataset.initialValueKind = "string";
+        control.dataset.currentValueKind = "string";
+        const meta = new FakeElement("span");
+
+        const field = createColumnFieldApi({
+          id: "row-edit-field-0",
+          labelId: "row-edit-field-label-0",
+          descriptionId: "row-edit-field-meta-0",
+          control,
+          meta,
+          context,
+        });
+        renderColumnField(
+          Object.assign({ pluginName: "datasette-json-column" }, pluginControl),
+          field
+        );
+
+        if (control.validationMessage !== "") {
+          throw new Error("Initial valid JSON should not be invalid");
+        }
+        if (control.dataset.initialValueKind !== "string") {
+          throw new Error("JSON plugin should keep the original string value kind");
+        }
+        if (control.dataset.currentValueKind !== "string") {
+          throw new Error("JSON plugin should keep the current string value kind");
+        }
+        if (!field.validationMessageElement || field.validationMessageElement.hidden !== true) {
+          throw new Error("JSON validation message should start hidden");
+        }
+
+        control.value = "{";
+        control.dispatchEvent(new Event("input", { bubbles: true }));
+        if (!control.validationMessage.startsWith("Invalid JSON")) {
+          throw new Error("Invalid JSON should set a custom validity message");
+        }
+        if (control.getAttribute("aria-invalid") !== "true") {
+          throw new Error("Invalid JSON should set aria-invalid");
+        }
+        if (field.validationMessageElement.hidden) {
+          throw new Error("Invalid JSON should show the validation message");
+        }
+
+        control.value = '{"ok": true}';
+        control.dispatchEvent(new Event("input", { bubbles: true }));
+        if (control.validationMessage !== "") {
+          throw new Error("Valid JSON should clear the custom validity message");
+        }
+        if (control.getAttribute("aria-invalid") !== null) {
+          throw new Error("Valid JSON should clear aria-invalid");
+        }
+        if (!field.validationMessageElement.hidden) {
+          throw new Error("Valid JSON should hide the validation message");
+        }
+
+        control.dataset.initialValue = '{"ok":';
+        control.value = '{"ok": true}';
+        const values = collectRowFormValues({
+          mode: "edit",
+          fields: {
+            querySelectorAll() {
+              return [control];
+            },
+          },
+        });
+        if (values.metadata !== '{"ok": true}') {
+          throw new Error("Corrected JSON should be submitted as a string value");
+        }
+
+        process.stdout.write("ok");
+    """).replace("__TABLE_JS__", json.dumps(str(STATIC_DIR / "table.js")))
+    result = subprocess.run(
+        ["node", "-e", script],
+        text=True,
+        capture_output=True,
+        check=False,
+    )
+    assert result.returncode == 0, result.stderr
+    assert result.stdout == "ok"
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index a1510aeb..023e7c4c 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -990,14 +990,18 @@ async def test_table_insert_action_button_and_data():
         ]
         name, score, created, body = insert_data["columns"]
         assert name["notnull"] == 1
-        assert name["value_type"] == "string"
+        assert name["sqlite_type"] == "TEXT"
+        assert name["value_kind"] == "string"
         assert not name["has_default"]
         assert score["default"] == "5"
         assert score["has_default"]
-        assert score["value_type"] == "number"
+        assert score["sqlite_type"] == "INTEGER"
+        assert score["value_kind"] == "number"
         assert created["default"] == "datetime('now')"
         assert created["has_default"]
-        assert body["value_type"] == "string"
+        assert created["sqlite_type"] == "TEXT"
+        assert body["sqlite_type"] == "TEXT"
+        assert body["value_kind"] == "string"
         assert body["column_type"] == {"type": "textarea", "config": None}
     finally:
         ds.close()

From c083e44561cbc227b489e31b95e79c8cc72745b6 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 14:21:04 -0700
Subject: [PATCH 207/386] Ignore .playwright-mcp

Codex Desktop likes using this folder.
---
 .gitignore | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index 12acd87e..8c058692 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,8 @@
 build-metadata.json
 datasets.json
 
+.playwright-mcp
+
 scratchpad
 
 .vscode
@@ -131,4 +133,4 @@ tests/*.dylib
 tests/*.so
 tests/*.dll
 
-.idea
\ No newline at end of file
+.idea

From 3f7d389caf72081cb7d6d5c6b25e9a19068e744e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 15:00:07 -0700
Subject: [PATCH 208/386] Refine column field plugin API and documentation

- Simplify JavaScript column field context:
  - expose `isPk` instead of `isPrimaryKey`
  - expose `defaultExpression` instead of separate SQLite default flags
  - remove value/default state from plugin context
- Update field helper behavior:
  - `setValue()` no longer dispatches input/change events
  - remove dispatch options and `resetValue()`
  - add `markClean()` for plugin-normalized initial values
  - track clean field state for reliable dirty detection

Also:

- Prompt before closing row insert/edit dialogs when there are unsaved changes
- Map declared SQLite types to affinities, returning `BLOB` for typeless columns and `NUMERIC` for numeric/date/boolean-like declarations
---
 datasette/column_types.py          |  12 +-
 datasette/static/table.js          | 256 ++++++++++++++++++-----------
 docs/javascript_plugins.rst        | 149 +++++------------
 tests/test_column_types.py         |   9 +-
 tests/test_datasette_manager_js.py | 196 +++++++++++++++++++---
 tests/test_table_html.py           |  12 +-
 6 files changed, 391 insertions(+), 243 deletions(-)

diff --git a/datasette/column_types.py b/datasette/column_types.py
index 7320e1d6..11a14ec0 100644
--- a/datasette/column_types.py
+++ b/datasette/column_types.py
@@ -6,19 +6,17 @@ class SQLiteType(Enum):
     INTEGER = "INTEGER"
     REAL = "REAL"
     BLOB = "BLOB"
-    NULL = "NULL"
+    NUMERIC = "NUMERIC"
 
     @classmethod
-    def from_declared_type(cls, declared_type: str | None) -> "SQLiteType | None":
+    def from_declared_type(cls, declared_type: str | None) -> "SQLiteType":
         if declared_type is None:
-            return cls.NULL
+            return cls.BLOB
 
         normalized = declared_type.strip().upper()
         if not normalized:
-            return cls.NULL
+            return cls.BLOB
 
-        if normalized == cls.NULL.value:
-            return cls.NULL
         if "INT" in normalized:
             return cls.INTEGER
         if any(token in normalized for token in ("CHAR", "CLOB", "TEXT")):
@@ -31,7 +29,7 @@ class SQLiteType(Enum):
         ):
             return cls.REAL
 
-        return None
+        return cls.NUMERIC
 
 
 class ColumnType:
diff --git a/datasette/static/table.js b/datasette/static/table.js
index 79ed45b9..291afc95 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -993,12 +993,16 @@ function columnTypeForContext(columnType) {
   };
 }
 
-function columnFormControlContext(column, value, isPk, columnType, options) {
+function defaultExpressionForContext(expression) {
+  if (expression === null || typeof expression === "undefined") {
+    return null;
+  }
+  return expression;
+}
+
+function columnFormControlContext(column, isPk, columnType, options) {
   var pageData = tablePageData();
-  var hasSqliteDefault =
-    options.hasSqliteDefault ||
-    (options.sqliteDefaultExpression !== null &&
-      typeof options.sqliteDefaultExpression !== "undefined");
+  var defaultExpression = defaultExpressionForContext(options.defaultExpression);
   return {
     mode: options.mode || "edit",
     database: pageData.database || null,
@@ -1008,12 +1012,8 @@ function columnFormControlContext(column, value, isPk, columnType, options) {
     columnType: columnTypeForContext(columnType),
     sqliteType: options.sqliteType || null,
     notNull: !!options.notnull,
-    isPrimaryKey: !!isPk,
-    hasSqliteDefault: !!hasSqliteDefault,
-    sqliteDefaultExpression: options.sqliteDefaultExpression,
-    useSqliteDefaultInitially: !!(
-      hasSqliteDefault && options.useSqliteDefaultInitially
-    ),
+    isPk: !!isPk,
+    defaultExpression: defaultExpression,
     form: options.form || null,
     dialog: options.dialog || null,
   };
@@ -1044,8 +1044,7 @@ function createColumnFieldApi(options) {
     getValue: function () {
       return valueFromRowEditControl(control);
     },
-    setValue: function (value, setOptions) {
-      setOptions = setOptions || {};
+    setValue: function (value) {
       if (
         value !== null &&
         typeof value !== "undefined" &&
@@ -1055,53 +1054,27 @@ function createColumnFieldApi(options) {
           "field.setValue() accepts strings, numbers, booleans or null; serialize objects before setting the field value",
         );
       }
-      field.stopUsingSqliteDefault({ dispatch: false });
+      field.stopUsingSqliteDefault();
       control.value = valueToEditText(value);
       control.dataset.currentValueKind = rowEditValueKind(value);
-      if (setOptions.dispatch !== false) {
-        field.dispatchChange();
-      }
     },
     getInitialValue: function () {
       return initialValueFromRowEditControl(control);
     },
     hasChanged: function () {
-      if (field.isUsingSqliteDefault()) {
-        return !context.useSqliteDefaultInitially;
-      }
-      if (
-        control.value === (control.dataset.initialValue || "") &&
-        (control.dataset.currentValueKind ||
-          control.dataset.initialValueKind ||
-          "string") === (control.dataset.initialValueKind || "string")
-      ) {
-        return false;
-      }
-      try {
-        return !rowEditValuesMatch(field.getValue(), field.getInitialValue());
-      } catch (_error) {
-        return true;
-      }
+      return rowEditControlHasChanged(control);
     },
-    clearValue: function (clearOptions) {
-      field.setValue(null, clearOptions);
-    },
-    resetValue: function (resetOptions) {
-      resetOptions = resetOptions || {};
-      field.stopUsingSqliteDefault({ dispatch: false });
-      control.value = control.dataset.initialValue || "";
-      control.dataset.currentValueKind =
-        control.dataset.initialValueKind || "string";
-      if (resetOptions.dispatch !== false) {
-        field.dispatchChange();
-      }
+    clearValue: function () {
+      field.setValue(null);
     },
     isUsingSqliteDefault: function () {
       return control.dataset.useSqliteDefault === "1";
     },
-    useSqliteDefault: function (defaultOptions) {
-      defaultOptions = defaultOptions || {};
-      if (!context.hasSqliteDefault) {
+    useSqliteDefault: function () {
+      if (
+        context.defaultExpression === null ||
+        typeof context.defaultExpression === "undefined"
+      ) {
         return;
       }
       control.dataset.useSqliteDefault = "1";
@@ -1109,26 +1082,18 @@ function createColumnFieldApi(options) {
       control.value = "";
       control.dataset.currentValueKind = "null";
       field.syncSqliteDefaultUi();
-      if (defaultOptions.dispatch !== false) {
-        field.dispatchChange();
-      }
     },
-    stopUsingSqliteDefault: function (defaultOptions) {
-      defaultOptions = defaultOptions || {};
+    stopUsingSqliteDefault: function () {
       if (control.dataset.useSqliteDefault !== "1") {
         return;
       }
       control.dataset.useSqliteDefault = "0";
       control.disabled = false;
       field.syncSqliteDefaultUi();
-      if (defaultOptions.dispatch !== false) {
-        field.dispatchChange();
-      }
     },
     syncSqliteDefaultUi: function () {},
-    dispatchChange: function () {
-      control.dispatchEvent(new Event("input", { bubbles: true }));
-      control.dispatchEvent(new Event("change", { bubbles: true }));
+    markClean: function () {
+      markRowEditControlClean(control);
     },
     setValidity: function (message) {
       message = message || "";
@@ -1148,6 +1113,7 @@ function createColumnFieldApi(options) {
       field.setValidity("");
     },
   };
+  field.markClean();
   return field;
 }
 
@@ -1220,10 +1186,10 @@ function registerBuiltinColumnFieldPlugins(manager) {
     version: "1.0",
     makeColumnField: function (context) {
       if (!context.columnType || context.columnType.type !== "json") {
-        return null;
+        return;
       }
       return {
-        inputType: "textarea",
+        useTextarea: true,
         render: function (field) {
           field.input.addEventListener("input", function () {
             validateJsonColumnField(field);
@@ -1232,7 +1198,7 @@ function registerBuiltinColumnFieldPlugins(manager) {
             validateJsonColumnField(field);
           });
           validateJsonColumnField(field);
-          field.root.appendChild(field.input);
+          return field.input;
         },
         focus: function (field) {
           field.input.focus();
@@ -1305,12 +1271,9 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   options = options || {};
   var field = document.createElement("div");
   field.className = "row-edit-field";
-  var hasSqliteDefault =
-    options.hasSqliteDefault ||
-    (options.sqliteDefaultExpression !== null &&
-      typeof options.sqliteDefaultExpression !== "undefined");
-  var useSqliteDefaultInitially =
-    hasSqliteDefault && options.useSqliteDefaultInitially;
+  var defaultExpression = defaultExpressionForContext(options.defaultExpression);
+  var hasDefaultExpression = defaultExpression !== null;
+  var useSqliteDefault = hasDefaultExpression && options.useSqliteDefault;
 
   var fieldId = "row-edit-field-" + index;
   var metaId = "row-edit-field-meta-" + index;
@@ -1326,14 +1289,15 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
 
   var context = columnFormControlContext(
     column,
-    value,
     isPk,
     columnType,
     options,
   );
   var pluginControl = makeColumnField(options.manager, context);
-  var preferredControl = pluginControl && pluginControl.inputType;
-  var control = (preferredControl === "textarea" || shouldUseTextarea(value, columnType))
+  var useTextarea =
+    (pluginControl && pluginControl.useTextarea === true) ||
+    shouldUseTextarea(value, columnType);
+  var control = useTextarea
     ? document.createElement("textarea")
     : document.createElement("input");
   control.className = "row-edit-input";
@@ -1346,10 +1310,10 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     options.valueKind || rowEditValueKind(value);
   control.dataset.primaryKey = isPk ? "1" : "0";
   control.dataset.currentValueKind = control.dataset.initialValueKind;
-  if (hasSqliteDefault) {
-    control.dataset.useSqliteDefault = useSqliteDefaultInitially ? "1" : "0";
+  if (hasDefaultExpression) {
+    control.dataset.useSqliteDefault = useSqliteDefault ? "1" : "0";
   }
-  if (useSqliteDefaultInitially) {
+  if (useSqliteDefault) {
     control.disabled = true;
   }
   if (options.omitIfBlank) {
@@ -1380,8 +1344,8 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   if (options.notnull) {
     metaParts.push("Required");
   }
-  if (hasSqliteDefault && !useSqliteDefaultInitially) {
-    metaParts.push("SQLite default: " + options.sqliteDefaultExpression);
+  if (hasDefaultExpression && !useSqliteDefault) {
+    metaParts.push("SQLite default: " + defaultExpression);
   }
   if (value === null) {
     metaParts.push("Current value: NULL");
@@ -1427,6 +1391,7 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     dialog: options.dialog || null,
     context: context,
   });
+  field._datasetteColumnFormField = fieldApi;
   var pluginControlElement = renderColumnField(pluginControl, fieldApi);
   var controlElement =
     pluginControlElement || rowEditControlElement(control, options.autocompleteUrl);
@@ -1447,7 +1412,7 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
   }
 
-  if (hasSqliteDefault) {
+  if (hasDefaultExpression) {
     var defaultBlock = document.createElement("div");
     defaultBlock.className = "row-edit-default";
     defaultBlock.setAttribute("aria-describedby", metaId);
@@ -1457,7 +1422,7 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     defaultText.appendChild(document.createTextNode("default "));
     var defaultCode = document.createElement("code");
     defaultCode.className = "row-edit-default-code";
-    defaultCode.textContent = options.sqliteDefaultExpression;
+    defaultCode.textContent = defaultExpression;
     defaultText.appendChild(defaultCode);
 
     var setValueButton = document.createElement("button");
@@ -1551,9 +1516,7 @@ function valueFromRowEditControl(control) {
   return valueFromRowEditText(
     control.name,
     value,
-    control.dataset.currentValueKind ||
-      control.dataset.initialValueKind ||
-      "string",
+    rowEditControlValueKind(control),
   );
 }
 
@@ -1593,6 +1556,56 @@ function initialValueFromRowEditControl(control) {
   );
 }
 
+function rowEditControlValueKind(control) {
+  return (
+    control.dataset.currentValueKind ||
+    control.dataset.initialValueKind ||
+    "string"
+  );
+}
+
+function rowEditControlCleanValue(control) {
+  if (Object.prototype.hasOwnProperty.call(control.dataset, "cleanValue")) {
+    return control.dataset.cleanValue;
+  }
+  return control.dataset.initialValue || "";
+}
+
+function rowEditControlCleanValueKind(control) {
+  return (
+    control.dataset.cleanValueKind ||
+    control.dataset.initialValueKind ||
+    "string"
+  );
+}
+
+function rowEditControlCleanUsesSqliteDefault(control) {
+  if (
+    Object.prototype.hasOwnProperty.call(
+      control.dataset,
+      "cleanUseSqliteDefault",
+    )
+  ) {
+    return control.dataset.cleanUseSqliteDefault === "1";
+  }
+  return false;
+}
+
+function markRowEditControlClean(control) {
+  control.dataset.cleanValue = control.value;
+  control.dataset.cleanValueKind = rowEditControlValueKind(control);
+  control.dataset.cleanUseSqliteDefault =
+    control.dataset.useSqliteDefault === "1" ? "1" : "0";
+}
+
+function cleanValueFromRowEditControl(control) {
+  return valueFromRowEditText(
+    control.name,
+    rowEditControlCleanValue(control),
+    rowEditControlCleanValueKind(control),
+  );
+}
+
 function rowEditValuesMatch(left, right) {
   if (left === right) {
     return true;
@@ -1608,6 +1621,28 @@ function rowEditValuesMatch(left, right) {
   return false;
 }
 
+function rowEditControlHasChanged(control) {
+  var usingSqliteDefault = control.dataset.useSqliteDefault === "1";
+  var cleanUsesSqliteDefault = rowEditControlCleanUsesSqliteDefault(control);
+  if (usingSqliteDefault || cleanUsesSqliteDefault) {
+    return usingSqliteDefault !== cleanUsesSqliteDefault;
+  }
+  if (
+    control.value === rowEditControlCleanValue(control) &&
+    rowEditControlValueKind(control) === rowEditControlCleanValueKind(control)
+  ) {
+    return false;
+  }
+  try {
+    return !rowEditValuesMatch(
+      valueFromRowEditControl(control),
+      cleanValueFromRowEditControl(control),
+    );
+  } catch (_error) {
+    return true;
+  }
+}
+
 function collectRowFormValues(state) {
   var values = {};
   state.fields.querySelectorAll(".row-edit-input").forEach(function (control) {
@@ -1648,6 +1683,43 @@ function collectRowFormValues(state) {
   return values;
 }
 
+function rowEditDialogHasChanges(state) {
+  if (!state || !state.hasLoaded || state.isLoading) {
+    return false;
+  }
+  var fields = state.fields.querySelectorAll(".row-edit-field");
+  for (var i = 0; i < fields.length; i += 1) {
+    var fieldApi = fields[i]._datasetteColumnFormField;
+    if (fieldApi && fieldApi.hasChanged && fieldApi.hasChanged()) {
+      return true;
+    }
+  }
+  return false;
+}
+
+function confirmDiscardRowEditChanges(state) {
+  if (!rowEditDialogHasChanges(state)) {
+    return true;
+  }
+  var message =
+    state.mode === "insert"
+      ? "Discard this new row?"
+      : "Discard unsaved changes to this row?";
+  return window.confirm(message);
+}
+
+function closeRowEditDialogIfConfirmed(state) {
+  if (!state || state.isSaving) {
+    return false;
+  }
+  if (!confirmDiscardRowEditChanges(state)) {
+    return false;
+  }
+  state.shouldRestoreFocus = true;
+  state.dialog.close();
+  return true;
+}
+
 function findDataRowElement(root, rowId) {
   var elements = root.querySelectorAll("[data-row]");
   for (var i = 0; i < elements.length; i += 1) {
@@ -1905,14 +1977,13 @@ function renderRowInsertFields(state, data) {
           autocompleteUrl: foreignKeyAutocompleteUrl(column.name),
           dialog: state.dialog,
           form: state.form,
-          hasSqliteDefault: column.has_default,
+          defaultExpression: column.default,
           manager: state.manager,
           mode: state.mode,
           notnull: column.notnull,
           primaryKeyReadonly: false,
-          sqliteDefaultExpression: column.default,
           sqliteType: column.sqlite_type,
-          useSqliteDefaultInitially: column.has_default,
+          useSqliteDefault: column.default !== null,
           valueKind: column.value_kind,
         },
       ),
@@ -2027,9 +2098,8 @@ function ensureRowEditDialog(manager) {
   });
 
   dialog.addEventListener("click", function (ev) {
-    if (ev.target === dialog && !rowEditDialogState.isSaving) {
-      rowEditDialogState.shouldRestoreFocus = true;
-      dialog.close();
+    if (ev.target === dialog) {
+      closeRowEditDialogIfConfirmed(rowEditDialogState);
     }
   });
 
@@ -2037,17 +2107,15 @@ function ensureRowEditDialog(manager) {
     if (ev.key !== "Escape") {
       return;
     }
-    if (rowEditDialogState.isSaving) {
-      ev.preventDefault();
-      return;
-    }
     ev.preventDefault();
-    rowEditDialogState.shouldRestoreFocus = true;
-    dialog.close();
+    closeRowEditDialogIfConfirmed(rowEditDialogState);
   });
 
   dialog.addEventListener("cancel", function (ev) {
-    if (rowEditDialogState.isSaving) {
+    if (
+      rowEditDialogState.isSaving ||
+      !confirmDiscardRowEditChanges(rowEditDialogState)
+    ) {
       ev.preventDefault();
     } else {
       rowEditDialogState.shouldRestoreFocus = true;
diff --git a/docs/javascript_plugins.rst b/docs/javascript_plugins.rst
index e1a889b4..4bc9b53c 100644
--- a/docs/javascript_plugins.rst
+++ b/docs/javascript_plugins.rst
@@ -200,11 +200,11 @@ This method, if present, can provide a custom form field for a column in Dataset
 
 It is designed for plugins that :ref:`register custom column types <plugin_register_column_types>` using the Python ``register_column_types()`` plugin hook. For example, a plugin that defines a ``file`` column type can use ``makeColumnField()`` to replace a plain text input with a file picker, and a plugin that defines a rich text column type can use it to enhance the field with an editor.
 
-Datasette calls ``makeColumnField(context)`` on each registered JavaScript plugin when it renders an editable insert/edit field. Plugins should inspect the ``context`` object and return ``null`` or ``undefined`` for fields they do not handle.
+Datasette calls ``makeColumnField(context)`` on each registered JavaScript plugin when it renders an editable insert/edit field. Plugins should inspect the ``context`` object and only return a control object if they can handle that field. Otherwise, use a bare ``return;``.
 
 The first plugin to return a truthy control object is used for that field. Plugins are called in registration order. If a plugin raises an exception, Datasette logs the error to the browser console and continues to the next plugin.
 
-Datasette owns the value that will be submitted to the insert/update API. The ``context`` object describes the column and form environment; custom controls should read and write field values using the ``field`` helper object passed to ``render(field)``.
+The row dialog tracks the value that will be sent to the insert/update API. The ``context`` object describes the column and form environment; custom controls should read and write field values using the ``field`` helper object passed to ``render(field)``.
 
 Context object
 ^^^^^^^^^^^^^^
@@ -237,25 +237,17 @@ Context object
     ``config`` - object
         Configuration for this specific column type assignment. This is ``{}`` if no configuration has been set.
 
-    Plugins should generally check ``context.columnType && context.columnType.type`` before deciding whether to handle a field.
-
 ``sqliteType`` - string or null
-    The normalized SQLite type for this column, if known. This is one of ``"TEXT"``, ``"INTEGER"``, ``"REAL"``, ``"BLOB"``, ``"NULL"`` or ``null`` if Datasette could not determine the type.
+    The SQLite affinity for this column, if known. This is one of ``"TEXT"``, ``"INTEGER"``, ``"REAL"``, ``"BLOB"``, ``"NUMERIC"`` or ``null`` if Datasette could not determine the affinity.
 
 ``notNull`` - boolean
     True if the column is defined as ``NOT NULL``.
 
-``isPrimaryKey`` - boolean
+``isPk`` - boolean
     True if this column is part of the table's primary key.
 
-``hasSqliteDefault`` - boolean
-    True if the column has a SQLite default value and the insert form can offer the "use default" behavior.
-
-``sqliteDefaultExpression``
-    The SQLite default expression for the column, if available. This is the expression from the table schema, not the actual value SQLite will insert.
-
-``useSqliteDefaultInitially`` - boolean
-    True if the insert form should initially omit this column so SQLite uses the column default.
+``defaultExpression`` - string or null
+    The SQLite default expression for the column, if available. This is ``null`` if the column has no SQLite default. For example, a column defined with ``DEFAULT (datetime('now'))`` will have ``"datetime('now')"`` here. This is the expression from the table schema, not the actual value SQLite will insert.
 
 ``form`` - ``HTMLFormElement`` or null
     The row insert/edit form element.
@@ -268,13 +260,13 @@ Returned control object
 
 A plugin that wants to handle a field should return an object. Datasette currently recognizes these properties:
 
-``inputType`` - string, optional
-    If set to ``"textarea"``, Datasette creates a ``<textarea>`` as the underlying ``field.input`` before calling ``render()``. Any other value is ignored.
+``useTextarea`` - boolean, optional
+    If true, Datasette creates a ``<textarea>`` as the underlying ``field.input`` before calling ``render()``. If omitted, Datasette chooses either an ``<input>`` or ``<textarea>`` based on the column type and current value.
 
 ``render(field)`` - function
     Called once to render the custom field UI. ``field`` is a helper object described below.
 
-    The plugin should append its UI to ``field.root``. If ``render()`` returns a DOM node, Datasette appends that returned node to ``field.root``.
+    The recommended pattern is to return a DOM node from ``render()``. Datasette appends that node to ``field.root``, a ``<div>`` inside the control area for that field in the row insert/edit dialog. A plugin can alternatively manipulate ``field.root`` directly and return nothing.
 
 ``focus(field)`` - function, optional
     Called when Datasette wants to focus this field, for example when focusing the first editable field in the dialog. Use this to focus the most useful interactive element inside the custom UI.
@@ -282,8 +274,6 @@ A plugin that wants to handle a field should return an object. Datasette current
 ``destroy(field)`` - function, optional
     Called when Datasette tears down the insert/edit form. Use this to remove event listeners, close nested pickers, revoke object URLs, clear timers, or release other resources.
 
-Datasette adds a ``pluginName`` property to the control object internally, based on the name passed to ``registerPlugin()``.
-
 The field helper object
 ^^^^^^^^^^^^^^^^^^^^^^^
 
@@ -293,7 +283,7 @@ The ``field`` object passed to ``render(field)``, ``focus(field)`` and ``destroy
     The original context object passed to ``makeColumnField()``.
 
 ``id`` - string
-    The ID Datasette assigned to the underlying form control.
+    The ID Datasette assigned to ``field.input``, the backing ``<input>`` or ``<textarea>`` element.
 
 ``labelId`` - string
     The ID of the visible field label.
@@ -302,7 +292,7 @@ The ``field`` object passed to ``render(field)``, ``focus(field)`` and ``destroy
     The ID of the field metadata/help text. This metadata can include details such as ``Primary key``, ``Required``, ``Current value: NULL`` or ``Custom type: file``.
 
 ``root`` - ``HTMLElement``
-    The empty container element created by Datasette for this custom field. Plugins should append their UI to this element.
+    The empty ``<div>`` container created by Datasette for this custom field. It is inside the control area for the field in the row insert/edit dialog, next to the field label and above the field metadata. Datasette appends the DOM node returned by ``render(field)`` to this element. Plugins can alternatively manipulate this element directly and return nothing from ``render(field)``.
 
 ``input`` - ``HTMLInputElement`` or ``HTMLTextAreaElement``
     The core-owned backing form control. Plugins can keep this visible, wrap it or hide it, but should use the value helper methods below rather than mutating ``input.value`` directly.
@@ -320,12 +310,12 @@ The ``field`` object passed to ``render(field)``, ``focus(field)`` and ``destroy
     The containing modal dialog.
 
 ``getValue()`` - function
-    Returns the current value Datasette will submit for this field.
+    Returns the current value for this field.
 
     Datasette uses string values by default. Insert fields for ``"INTEGER"`` and ``"REAL"`` SQLite columns return numbers, or ``null`` if left blank. Plugins can use strings, numbers, booleans or ``null``. If a plugin is editing structured data stored in a SQLite ``TEXT`` column, such as JSON, it should serialize that data to a string before calling ``setValue()``.
 
-``setValue(value, options)`` - function
-    Sets the current value Datasette will submit for this field. ``value`` should be a string, number, boolean or ``null``. This also dispatches ``input`` and ``change`` events from the backing input. Pass ``{dispatch: false}`` as the second argument to skip those events.
+``setValue(value)`` - function
+    Sets the current value for this field. ``value`` should be a string, number, boolean or ``null``.
 
     Calling ``setValue()`` also stops using the SQLite default for the field, if it was previously selected.
 
@@ -333,26 +323,19 @@ The ``field`` object passed to ``render(field)``, ``focus(field)`` and ``destroy
     Returns the submitted-value representation the field had when the form was rendered. For edit forms this is the raw row value from the database. For insert forms this is the blank starting value.
 
 ``hasChanged()`` - function
-    Returns true if the field value differs from its initial value, or if the field's SQLite-default state has changed.
+    Returns true if the field has changed since Datasette last considered it unmodified. By default that means the field state when the insert/edit form was rendered.
 
-``clearValue(options)`` - function
-    Sets the value to ``null``. Accepts the same options as ``setValue()``.
+``clearValue()`` - function
+    Sets the value to ``null``.
 
-``resetValue(options)`` - function
-    Restores the initial field value. Accepts the same options as ``setValue()``.
+``markClean()`` - function
+    Tells Datasette to treat the field's current state as unmodified. After calling this method, ``hasChanged()`` returns false until the field value changes again or its SQLite-default state changes.
+
+    This is useful when a plugin rewrites the starting value into an equivalent representation while initializing its editor. For example, a rich text editor might normalize empty HTML or reserialize its initial document before the user has made any edits.
 
 ``isUsingSqliteDefault()`` - function
     Returns true if the insert dialog is currently set to omit this column and use the SQLite default.
 
-``useSqliteDefault(options)`` - function
-    Switches the field to use the SQLite default, if one exists. Accepts ``{dispatch: false}``.
-
-``stopUsingSqliteDefault(options)`` - function
-    Switches the field away from the SQLite default without changing the current field value. Accepts ``{dispatch: false}``.
-
-``dispatchChange()`` - function
-    Dispatches ``input`` and ``change`` events from the backing input.
-
 ``setValidity(message)`` - function
     Sets a custom validation message for this field, marks the backing input with ``aria-invalid="true"`` and shows the message in the field metadata area. Pass an empty string to clear the error.
 
@@ -362,16 +345,16 @@ The ``field`` object passed to ``render(field)``, ``focus(field)`` and ``destroy
 Submitted value contract
 ^^^^^^^^^^^^^^^^^^^^^^^^
 
-The field value contract is deliberately narrow. Datasette submits field values to the row insert/update JSON API, so a custom field value should be one of:
+The ``field.setValue()`` method accepts the following value types:
 
 * string
 * number
 * boolean
 * ``null``
 
-Plugins should not pass objects or arrays to ``field.setValue()``. If a column stores structured data in SQLite, such as JSON in a ``TEXT`` column, the plugin should serialize that data first and submit the serialized string. Client-side parsing can still be useful for validation or editor state, but the submitted value should match the SQLite value Datasette should write.
+These values are used as column values in requests to the :ref:`insert rows <TableInsertView>` and :ref:`update row <RowUpdateView>` JSON APIs.
 
-``field.input.dataset`` is reserved for Datasette's private form state. Plugins should not read from it, write to it, or use it to change how Datasette serializes values.
+Plugins should not pass objects or arrays to ``field.setValue()``. If a column stores structured data in SQLite, such as JSON in a ``TEXT`` column, the plugin should serialize that data first and submit the serialized string. Client-side parsing can still be useful for validation or editor state, but the submitted value should match the SQLite value Datasette should write.
 
 Value helpers
 ^^^^^^^^^^^^^
@@ -386,18 +369,16 @@ Custom fields should use ``field.getValue()`` and ``field.setValue(value)`` for
 
 Plugins can keep the core input visible, wrap it in a custom element, or hide it and provide a richer interface. If the input is hidden, the custom UI must still expose an accessible name, state and keyboard interaction.
 
-``field.setValue()`` updates the backing input and Datasette's private value serialization state.
+``field.setValue()`` updates both ``field.input`` and the value used in the insert/update request.
 
-For insert forms with a SQLite default, ``field.isUsingSqliteDefault()`` indicates whether Datasette will omit that column from the insert payload. Calling ``field.setValue(value)`` automatically stops using the SQLite default. A plugin can also expose explicit controls that call ``field.useSqliteDefault()`` and ``field.stopUsingSqliteDefault()``.
-
-Datasette's built-in ``json`` column type is implemented using this same JavaScript plugin hook. Datasette registers a small textarea-backed control for fields where ``context.columnType.type === "json"``; that control validates the field as JSON while the value changes and marks it visibly invalid if parsing fails. The submitted value remains the textarea string. The generic field API does not special-case custom column types.
-
-For example, a file picker can store a file ID string or ``null`` without modifying the backing input directly:
+For example, a file picker that stores a selected file ID can hide the backing input and call ``field.setValue()`` when the selection changes:
 
 .. code-block:: javascript
 
     field.input.type = "hidden";
-    field.setValue(fileId || null);
+    field.setValue(fileId);
+
+For insert forms with a SQLite default, ``field.isUsingSqliteDefault()`` indicates whether Datasette will omit that column from the insert payload. Calling ``field.setValue(value)`` automatically stops using the SQLite default.
 
 Lazy loading large controls
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -414,15 +395,15 @@ The JavaScript file that registers ``makeColumnField()`` should be small. If the
 
         makeColumnField(context) {
           if (!context.columnType || context.columnType.type !== "my-editor") {
-            return null;
+            return;
           }
           return {
-            inputType: "textarea",
+            useTextarea: true,
             render(field) {
-              field.root.appendChild(field.input);
               import(editorUrl).then(function () {
                 // Enhance field.input here.
               });
+              return field.input;
             }
           };
         }
@@ -432,7 +413,7 @@ The JavaScript file that registers ``makeColumnField()`` should be small. If the
 Example: textarea-backed custom element
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-This example handles a ``markdown-editor`` column type by asking Datasette for a textarea and wrapping that textarea in a custom element:
+This example handles a ``markdown-editor`` column type by asking Datasette for a textarea and wrapping that textarea in a custom ``<my-markdown-editor>`` Web Component element:
 
 .. code-block:: javascript
 
@@ -442,16 +423,15 @@ This example handles a ``markdown-editor`` column type by asking Datasette for a
 
         makeColumnField(context) {
           if (!context.columnType || context.columnType.type !== "markdown-editor") {
-            return null;
+            return;
           }
 
           return {
-            inputType: "textarea",
+            useTextarea: true,
 
             render(field) {
               const editor = document.createElement("my-markdown-editor");
               editor.appendChild(field.input);
-              field.root.appendChild(editor);
 
               if (field.labelId) {
                 field.input.setAttribute("aria-labelledby", field.labelId);
@@ -459,6 +439,8 @@ This example handles a ``markdown-editor`` column type by asking Datasette for a
               if (field.descriptionId) {
                 field.input.setAttribute("aria-describedby", field.descriptionId);
               }
+
+              return editor;
             },
 
             focus(field) {
@@ -474,63 +456,6 @@ This example handles a ``markdown-editor`` column type by asking Datasette for a
       });
     });
 
-Example: hidden input with custom picker
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-This example handles an ``asset`` column type by hiding the core input and writing an asset ID into it when the user selects an item:
-
-.. code-block:: javascript
-
-    document.addEventListener("datasette_init", function (event) {
-      event.detail.registerPlugin("asset-picker", {
-        version: "0.1",
-
-        makeColumnField(context) {
-          if (!context.columnType || context.columnType.type !== "asset") {
-            return null;
-          }
-
-          return {
-            render(field) {
-              field.input.type = "hidden";
-
-              const group = document.createElement("div");
-              group.setAttribute("role", "group");
-              group.setAttribute("aria-labelledby", field.labelId);
-              group.setAttribute("aria-describedby", field.descriptionId);
-
-              const current = document.createElement("span");
-              current.textContent = field.getValue() || "No asset selected";
-
-              const button = document.createElement("button");
-              button.type = "button";
-              button.textContent = "Choose asset";
-              button.addEventListener("click", async function () {
-                const assetId = await chooseAsset();
-                if (assetId === null) {
-                  return;
-                }
-                field.setValue(assetId || null);
-                current.textContent = assetId || "No asset selected";
-              });
-
-              group.appendChild(current);
-              group.appendChild(button);
-              field.root.appendChild(field.input);
-              field.root.appendChild(group);
-            },
-
-            focus(field) {
-              const button = field.root.querySelector("button");
-              if (button) {
-                button.focus();
-              }
-            }
-          };
-        }
-      });
-    });
-
 Accessibility
 ^^^^^^^^^^^^^
 
diff --git a/tests/test_column_types.py b/tests/test_column_types.py
index 0c6b0dd4..45a9e7d1 100644
--- a/tests/test_column_types.py
+++ b/tests/test_column_types.py
@@ -518,13 +518,18 @@ async def test_column_type_class_attributes(ds_ct):
 
 
 def test_sqlite_type_from_declared_type():
+    assert SQLiteType.from_declared_type(None) == SQLiteType.BLOB
     assert SQLiteType.from_declared_type("text") == SQLiteType.TEXT
     assert SQLiteType.from_declared_type("varchar(255)") == SQLiteType.TEXT
     assert SQLiteType.from_declared_type("integer") == SQLiteType.INTEGER
     assert SQLiteType.from_declared_type("float") == SQLiteType.REAL
     assert SQLiteType.from_declared_type("blob") == SQLiteType.BLOB
-    assert SQLiteType.from_declared_type("") == SQLiteType.NULL
-    assert SQLiteType.from_declared_type("numeric") is None
+    assert SQLiteType.from_declared_type("") == SQLiteType.BLOB
+    assert SQLiteType.from_declared_type("numeric") == SQLiteType.NUMERIC
+    assert SQLiteType.from_declared_type("decimal(10,5)") == SQLiteType.NUMERIC
+    assert SQLiteType.from_declared_type("boolean") == SQLiteType.NUMERIC
+    assert SQLiteType.from_declared_type("date") == SQLiteType.NUMERIC
+    assert SQLiteType.from_declared_type("null") == SQLiteType.NUMERIC
 
 
 # --- JSON API ---
diff --git a/tests/test_datasette_manager_js.py b/tests/test_datasette_manager_js.py
index 5e21b5bb..f32f2de0 100644
--- a/tests/test_datasette_manager_js.py
+++ b/tests/test_datasette_manager_js.py
@@ -42,15 +42,15 @@ def test_datasette_manager_make_column_field():
 
         window.__DATASETTE__.registerPlugin("declines", {
           makeColumnField() {
-            return null;
+            return;
           },
         });
         window.__DATASETTE__.registerPlugin("handles", {
           makeColumnField(context) {
             if (context.columnType.type !== "demo") {
-              return null;
+              return;
             }
-            return { inputType: "textarea" };
+            return { useTextarea: true };
           },
         });
 
@@ -72,7 +72,7 @@ def test_datasette_manager_make_column_field():
     assert result.returncode == 0, result.stderr
     assert json.loads(result.stdout) == {
         "pluginName": "handles",
-        "inputType": "textarea",
+        "useTextarea": True,
     }
 
 
@@ -186,33 +186,39 @@ def test_table_plugin_column_field_api():
 
         const context = columnFormControlContext(
           "logo",
-          "df-old",
-          false,
+          true,
           { type: "file", config: null },
           {
             mode: "edit",
-            hasSqliteDefault: true,
-            sqliteDefaultExpression: "lower(hex(randomblob(4)))",
-            useSqliteDefaultInitially: true,
+            defaultExpression: "lower(hex(randomblob(4)))",
+            useSqliteDefault: true,
           }
         );
-        if ("defaultValue" in context) {
-          throw new Error("context should not expose defaultValue");
+        const expectedContextKeys = [
+          "mode",
+          "database",
+          "table",
+          "tableUrl",
+          "column",
+          "columnType",
+          "sqliteType",
+          "notNull",
+          "isPk",
+          "defaultExpression",
+          "form",
+          "dialog",
+        ].join(",");
+        if (Object.keys(context).join(",") !== expectedContextKeys) {
+          throw new Error(`Unexpected context keys: ${Object.keys(context).join(",")}`);
         }
-        if (!context.hasSqliteDefault) {
-          throw new Error("context.hasSqliteDefault should be true");
-        }
-        if (context.sqliteDefaultExpression !== "lower(hex(randomblob(4)))") {
-          throw new Error("context.sqliteDefaultExpression was not set");
+        if (context.defaultExpression !== "lower(hex(randomblob(4)))") {
+          throw new Error("context.defaultExpression was not set");
         }
         if (JSON.stringify(context.columnType) !== '{"type":"file","config":{}}') {
           throw new Error("context.columnType should expose type and object config");
         }
-        if ("value" in context || "valueType" in context) {
-          throw new Error("context should not expose value state");
-        }
-        if ("initialValue" in context || "initialValueKind" in context) {
-          throw new Error("context should not expose initial value state");
+        if (!context.isPk) {
+          throw new Error("context.isPk should say whether the column is a primary key");
         }
 
         const control = new FakeElement("input");
@@ -241,7 +247,7 @@ def test_table_plugin_column_field_api():
             render(field) {
               renderArgumentCount = arguments.length;
               renderField = field;
-              field.root.appendChild(document.createElement("button"));
+              return document.createElement("button");
             },
           },
           field
@@ -252,6 +258,9 @@ def test_table_plugin_column_field_api():
         if (field.root !== wrapper) {
           throw new Error("field.root should be the plugin wrapper");
         }
+        if (wrapper.children.length !== 1 || wrapper.children[0].nodeName !== "BUTTON") {
+          throw new Error("plugin render should append returned DOM nodes to field.root");
+        }
 
         field.setValue(null);
         if (field.getValue() !== null) {
@@ -274,9 +283,145 @@ def test_table_plugin_column_field_api():
         if (!field.hasChanged()) {
           throw new Error("field.hasChanged() should notice plugin value changes");
         }
-        if (control.dispatchedEvents.join(",") !== "input,change,input,change") {
-          throw new Error(`Unexpected dispatched events: ${control.dispatchedEvents}`);
+        if (control.dispatchedEvents.length !== 0) {
+          throw new Error(`field.setValue() should not dispatch events: ${control.dispatchedEvents}`);
         }
+
+        const dirtyRowField = new FakeElement("div");
+        dirtyRowField._datasetteColumnFormField = field;
+        const dirtyState = {
+          hasLoaded: true,
+          isLoading: false,
+          isSaving: false,
+          mode: "edit",
+          fields: {
+            querySelectorAll(selector) {
+              return selector === ".row-edit-field" ? [dirtyRowField] : [];
+            },
+          },
+          dialog: {
+            closeCalled: false,
+            close() {
+              this.closeCalled = true;
+            },
+          },
+          shouldRestoreFocus: false,
+        };
+        const confirmMessages = [];
+        window.confirm = (message) => {
+          confirmMessages.push(message);
+          return false;
+        };
+        if (!rowEditDialogHasChanges(dirtyState)) {
+          throw new Error("row edit dialog should notice changed field values");
+        }
+        if (closeRowEditDialogIfConfirmed(dirtyState)) {
+          throw new Error("dirty row edit dialog should stay open when discard is rejected");
+        }
+        if (dirtyState.dialog.closeCalled) {
+          throw new Error("dirty row edit dialog should not close when discard is rejected");
+        }
+        if (confirmMessages[0] !== "Discard unsaved changes to this row?") {
+          throw new Error(`Unexpected discard confirmation: ${confirmMessages[0]}`);
+        }
+        dirtyState.mode = "insert";
+        window.confirm = (message) => {
+          confirmMessages.push(message);
+          return true;
+        };
+        if (!closeRowEditDialogIfConfirmed(dirtyState)) {
+          throw new Error("dirty row edit dialog should close when discard is confirmed");
+        }
+        if (!dirtyState.dialog.closeCalled || !dirtyState.shouldRestoreFocus) {
+          throw new Error("confirmed dirty row edit dialog should close and restore focus");
+        }
+        if (confirmMessages[1] !== "Discard this new row?") {
+          throw new Error(`Unexpected insert discard confirmation: ${confirmMessages[1]}`);
+        }
+
+        const cleanContext = columnFormControlContext(
+          "title",
+          false,
+          null,
+          { mode: "edit" }
+        );
+        if (cleanContext.defaultExpression !== null) {
+          throw new Error("context.defaultExpression should be null without a SQLite default");
+        }
+        const cleanControl = new FakeElement("input");
+        cleanControl.name = "title";
+        cleanControl.value = "clean";
+        cleanControl.dataset.initialValue = "clean";
+        cleanControl.dataset.initialValueKind = "string";
+        cleanControl.dataset.currentValueKind = "string";
+        const cleanField = createColumnFieldApi({
+          id: "row-edit-field-1",
+          labelId: "row-edit-field-label-1",
+          descriptionId: "row-edit-field-meta-1",
+          control: cleanControl,
+          meta: new FakeElement("span"),
+          context: cleanContext,
+        });
+        const cleanRowField = new FakeElement("div");
+        cleanRowField._datasetteColumnFormField = cleanField;
+        const cleanState = {
+          hasLoaded: true,
+          isLoading: false,
+          isSaving: false,
+          mode: "edit",
+          fields: {
+            querySelectorAll(selector) {
+              return selector === ".row-edit-field" ? [cleanRowField] : [];
+            },
+          },
+          dialog: {
+            closeCalled: false,
+            close() {
+              this.closeCalled = true;
+            },
+          },
+          shouldRestoreFocus: false,
+        };
+        confirmMessages.length = 0;
+        window.confirm = (message) => {
+          confirmMessages.push(message);
+          return false;
+        };
+        if (rowEditDialogHasChanges(cleanState)) {
+          throw new Error("row edit dialog should ignore unchanged field values");
+        }
+        if (!closeRowEditDialogIfConfirmed(cleanState)) {
+          throw new Error("clean row edit dialog should close without confirmation");
+        }
+        if (!cleanState.dialog.closeCalled || !cleanState.shouldRestoreFocus) {
+          throw new Error("clean row edit dialog should close and restore focus");
+        }
+        if (confirmMessages.length !== 0) {
+          throw new Error("clean row edit dialog should not ask for confirmation");
+        }
+
+        dirtyState.dialog.closeCalled = false;
+        dirtyState.shouldRestoreFocus = false;
+        confirmMessages.length = 0;
+        field.setValue("<p></p>");
+        field.markClean();
+        if (field.hasChanged()) {
+          throw new Error("field.markClean() should update the clean baseline");
+        }
+        if (rowEditDialogHasChanges(dirtyState)) {
+          throw new Error("row edit dialog should ignore clean plugin normalization");
+        }
+        if (!closeRowEditDialogIfConfirmed(dirtyState)) {
+          throw new Error("normalized row edit dialog should close without confirmation");
+        }
+        if (confirmMessages.length !== 0) {
+          throw new Error("normalized row edit dialog should not ask for confirmation");
+        }
+        field.setValue("<p>Hello</p>");
+        if (!field.hasChanged() || !rowEditDialogHasChanges(dirtyState)) {
+          throw new Error("later plugin value changes should still count as dirty");
+        }
+
         try {
           field.setValue({ id: "df-object" });
           throw new Error("field.setValue() should reject object values");
@@ -420,13 +565,12 @@ def test_builtin_json_column_field_validation():
           column: "metadata",
           columnType: { type: "json", config: {} },
         });
-        if (!pluginControl || pluginControl.inputType !== "textarea") {
+        if (!pluginControl || pluginControl.useTextarea !== true) {
           throw new Error("JSON column plugin should request a textarea");
         }
 
         const context = columnFormControlContext(
           "metadata",
-          '{"ok": true}',
           false,
           { type: "json", config: {} },
           { mode: "edit" }
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 023e7c4c..b9936eab 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -962,8 +962,10 @@ async def test_table_insert_action_button_and_data():
                 id integer primary key,
                 name text not null,
                 score integer default 5,
+                price numeric,
                 created text default (datetime('now')),
-                body text
+                body text,
+                typeless
             );
             """)
         response = await ds.client.get("/data/items", actor={"id": "root"})
@@ -985,10 +987,12 @@ async def test_table_insert_action_button_and_data():
         assert [column["name"] for column in insert_data["columns"]] == [
             "name",
             "score",
+            "price",
             "created",
             "body",
+            "typeless",
         ]
-        name, score, created, body = insert_data["columns"]
+        name, score, price, created, body, typeless = insert_data["columns"]
         assert name["notnull"] == 1
         assert name["sqlite_type"] == "TEXT"
         assert name["value_kind"] == "string"
@@ -997,12 +1001,16 @@ async def test_table_insert_action_button_and_data():
         assert score["has_default"]
         assert score["sqlite_type"] == "INTEGER"
         assert score["value_kind"] == "number"
+        assert price["sqlite_type"] == "NUMERIC"
+        assert price["value_kind"] == "string"
         assert created["default"] == "datetime('now')"
         assert created["has_default"]
         assert created["sqlite_type"] == "TEXT"
         assert body["sqlite_type"] == "TEXT"
         assert body["value_kind"] == "string"
         assert body["column_type"] == {"type": "textarea", "config": None}
+        assert typeless["sqlite_type"] == "BLOB"
+        assert typeless["value_kind"] == "string"
     finally:
         ds.close()
 

From 4ce2888e79d4fdd5a6d5c4f949b70abac6f59e53 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 15:58:37 -0700
Subject: [PATCH 209/386] Support for <button> items in action menus

Closes #2782

Animated demo: https://github.com/simonw/datasette/pull/2781#issuecomment-4703303274
---
 datasette/hookspecs.py                | 12 ++---
 datasette/static/app.css              | 20 +++++--
 datasette/templates/_action_menu.html | 18 +++++--
 docs/custom_templates.rst             |  8 +++
 docs/plugin_hooks.rst                 | 75 ++++++++++++++++++++++++++-
 tests/plugins/my_plugin.py            | 19 ++++++-
 tests/test_plugins.py                 | 47 +++++++++++++++--
 7 files changed, 179 insertions(+), 20 deletions(-)

diff --git a/datasette/hookspecs.py b/datasette/hookspecs.py
index dcd502af..7c56f882 100644
--- a/datasette/hookspecs.py
+++ b/datasette/hookspecs.py
@@ -159,32 +159,32 @@ def jump_items_sql(datasette, actor, request):
 
 @hookspec
 def row_actions(datasette, actor, request, database, table, row):
-    """Links for the row actions menu"""
+    """Items for the row actions menu"""
 
 
 @hookspec
 def table_actions(datasette, actor, database, table, request):
-    """Links for the table actions menu"""
+    """Items for the table actions menu"""
 
 
 @hookspec
 def view_actions(datasette, actor, database, view, request):
-    """Links for the view actions menu"""
+    """Items for the view actions menu"""
 
 
 @hookspec
 def query_actions(datasette, actor, database, query_name, request, sql, params):
-    """Links for the query and stored query actions menu"""
+    """Items for the query and stored query actions menu"""
 
 
 @hookspec
 def database_actions(datasette, actor, database, request):
-    """Links for the database actions menu"""
+    """Items for the database actions menu"""
 
 
 @hookspec
 def homepage_actions(datasette, actor, request):
-    """Links for the homepage actions menu"""
+    """Items for the homepage actions menu"""
 
 
 @hookspec
diff --git a/datasette/static/app.css b/datasette/static/app.css
index c053f484..5fe4502d 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -2061,18 +2061,32 @@ svg.dropdown-menu-icon {
 .dropdown-menu a:link,
 .dropdown-menu a:visited,
 .dropdown-menu a:hover,
-.dropdown-menu a:focus
-.dropdown-menu a:active {
+.dropdown-menu a:focus,
+.dropdown-menu a:active,
+.dropdown-menu button.action-menu-button {
     text-decoration: none;
     display: block;
     padding: 4px 8px 2px 8px;
     color: #222;
     white-space: nowrap;
 }
-.dropdown-menu a:hover {
+.dropdown-menu button.action-menu-button {
+    appearance: none;
+    background: none;
+    border: none;
+    box-sizing: border-box;
+    cursor: pointer;
+    font: inherit;
+    text-align: left;
+    width: 100%;
+}
+.dropdown-menu a:hover,
+.dropdown-menu button.action-menu-button:hover,
+.dropdown-menu button.action-menu-button:focus {
     background-color: #eee;
 }
 .dropdown-menu .dropdown-description {
+    display: block;
     margin: 0;
     color: #666;
     font-size: 0.8em;
diff --git a/datasette/templates/_action_menu.html b/datasette/templates/_action_menu.html
index 1ae8c173..86089992 100644
--- a/datasette/templates/_action_menu.html
+++ b/datasette/templates/_action_menu.html
@@ -15,14 +15,22 @@
         <div class="hook"></div>
         <ul role="menu">
             {% for link in action_links %}
-            <li role="none"><a href="{{ link.href }}" role="menuitem" tabindex="-1">{{ link.label }}
-            {% if link.description %}
-                <p class="dropdown-description">{{ link.description }}</p>
-            {% endif %}</a>
+            <li role="none">
+            {% if link.get("type") == "button" %}
+                <button type="button" class="button-as-link action-menu-button" role="menuitem" tabindex="-1"{% for name, value in (link.get("attrs") or {}).items() %} {{ name }}="{{ value }}"{% endfor %}>{{ link.label }}
+                {% if link.description %}
+                    <span class="dropdown-description">{{ link.description }}</span>
+                {% endif %}</button>
+            {% else %}
+                <a href="{{ link.href }}" role="menuitem" tabindex="-1">{{ link.label }}
+                {% if link.description %}
+                    <span class="dropdown-description">{{ link.description }}</span>
+                {% endif %}</a>
+            {% endif %}
             </li>
             {% endfor %}
         </ul>
     </div>
 </details>
 </div>
-{% endif %}
\ No newline at end of file
+{% endif %}
diff --git a/docs/custom_templates.rst b/docs/custom_templates.rst
index aa82a536..8851a841 100644
--- a/docs/custom_templates.rst
+++ b/docs/custom_templates.rst
@@ -288,6 +288,14 @@ element that wraps the HTML for that row. Datasette uses this attribute to find
 the element to remove after a delete, or replace after an edit. Any edit or
 delete controls should be rendered inside that same element.
 
+The ``_action_menu.html`` template renders the action menus used by database,
+table, query and row pages. Plugin-provided actions can be link dictionaries
+with ``href`` and ``label`` keys, or button dictionaries using ``{"type":
+"button", "label": "...", "attrs": {...}}`` for JavaScript-backed interactions.
+Both shapes can include an optional ``description`` key. Custom
+``_action_menu.html`` templates should preserve support for both link and button
+action items.
+
 .. _custom_pages:
 
 Custom pages
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 7ae52a68..d2f87e27 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1909,7 +1909,80 @@ Action hooks
 
 Action hooks can be used to add items to the action menus that appear at the top of different pages within Datasette. Unlike :ref:`menu_links() <plugin_hook_menu_links>`, actions which are displayed on every page, actions should only be relevant to the page the user is currently viewing.
 
-Each of these hooks should return return a list of ``{"href": "...", "label": "..."}`` menu items, with optional ``"description": "..."`` keys describing each action in more detail.
+Each of these hooks should return a list of menu items, with optional ``"description": "..."`` keys describing each action in more detail.
+
+The most common action item is a link to another page:
+
+.. code-block:: python
+
+    {
+        "href": datasette.urls.path("/-/custom-action"),
+        "label": "Custom action",
+        "description": "Run this action on a separate page.",
+    }
+
+Plugins can also return button actions for JavaScript-backed interactions:
+
+.. code-block:: python
+
+    {
+        "type": "button",
+        "label": "Open custom dialog",
+        "description": "Show a dialog without leaving this page.",
+        "attrs": {
+            "aria-label": "Open custom dialog",
+            "data-plugin-action": "open-custom-dialog",
+        },
+    }
+
+These are rendered as ``<button type="button" class="button-as-link action-menu-button" role="menuitem" tabindex="-1">``. The optional ``attrs`` dictionary is added to the button, and is useful for ``data-*`` attributes that your plugin's JavaScript can use to attach event handlers.
+
+Here is a minimal plugin example that adds a button to a table page and loads JavaScript to handle clicks on that button:
+
+.. code-block:: python
+
+    from datasette import hookimpl
+
+
+    @hookimpl
+    def table_actions(datasette, database, table):
+        return [
+            {
+                "type": "button",
+                "label": "Show table name",
+                "description": "Open a JavaScript-powered plugin action.",
+                "attrs": {
+                    "aria-label": "Show table name",
+                    "data-plugin-action": "show-table-name",
+                    "data-database": database,
+                    "data-table": table,
+                },
+            }
+        ]
+
+
+    @hookimpl
+    def extra_js_urls(datasette):
+        return [
+            datasette.urls.static_plugins(
+                "datasette_show_table",
+                "show-table.js",
+            )
+        ]
+
+The ``static/show-table.js`` file in that plugin could look like this:
+
+.. code-block:: javascript
+
+    document.addEventListener("click", (event) => {
+      const button = event.target.closest(
+        "button[data-plugin-action='show-table-name']"
+      );
+      if (!button) {
+        return;
+      }
+      alert(`${button.dataset.database}.${button.dataset.table}`);
+    });
 
 They can alternatively return an ``async def`` awaitable function which, when called, returns a list of those menu items.
 
diff --git a/tests/plugins/my_plugin.py b/tests/plugins/my_plugin.py
index 1d2378b4..c89ad0a3 100644
--- a/tests/plugins/my_plugin.py
+++ b/tests/plugins/my_plugin.py
@@ -357,15 +357,30 @@ def menu_links(datasette, actor, request):
 
 
 @hookimpl
-def table_actions(datasette, database, table, actor):
+def table_actions(datasette, database, table, actor, request):
     if actor:
-        return [
+        actions = [
             {
                 "href": datasette.urls.instance(),
                 "label": f"Database: {database}",
             },
             {"href": datasette.urls.instance(), "label": f"Table: {table}"},
         ]
+        if request.args.get("_button"):
+            actions.append(
+                {
+                    "type": "button",
+                    "label": "Plugin button",
+                    "description": "Runs JavaScript from a plugin",
+                    "attrs": {
+                        "aria-label": "Plugin button for {}".format(table),
+                        "data-plugin-action": "plugin-button",
+                        "data-database": database,
+                        "data-table": table,
+                    },
+                }
+            )
+        return actions
 
 
 @hookimpl
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index cf753c9e..da14c714 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -1062,6 +1062,7 @@ async def test_hook_menu_links(ds_client):
 async def test_hook_table_actions(ds_client):
     response = await ds_client.get("/fixtures/facetable")
     assert get_actions_links(response.text) == []
+    assert get_actions_buttons(response.text) == []
     response_2 = await ds_client.get("/fixtures/facetable?_bot=1&_hello=BOB")
     assert ">Table actions<" in response_2.text
     assert sorted(
@@ -1071,6 +1072,23 @@ async def test_hook_table_actions(ds_client):
         {"label": "From async BOB", "href": "/", "description": None},
         {"label": "Table: facetable", "href": "/", "description": None},
     ]
+    response_3 = await ds_client.get("/fixtures/facetable?_bot=1&_button=1")
+    assert get_actions_buttons(response_3.text) == [
+        {
+            "label": "Plugin button",
+            "description": "Runs JavaScript from a plugin",
+            "attrs": {
+                "aria-label": "Plugin button for facetable",
+                "class": ["button-as-link", "action-menu-button"],
+                "data-database": "fixtures",
+                "data-plugin-action": "plugin-button",
+                "data-table": "facetable",
+                "role": "menuitem",
+                "tabindex": "-1",
+                "type": "button",
+            },
+        }
+    ]
 
 
 @pytest.mark.asyncio
@@ -1098,15 +1116,38 @@ def get_actions_links(html):
     links = []
     for a_el in details.select("a"):
         description = None
-        if a_el.find("p") is not None:
-            description = a_el.find("p").text.strip()
-            a_el.find("p").extract()
+        description_el = a_el.find(class_="dropdown-description")
+        if description_el is not None:
+            description = description_el.text.strip()
+            description_el.extract()
         label = a_el.text.strip()
         href = a_el["href"]
         links.append({"label": label, "href": href, "description": description})
     return links
 
 
+def get_actions_buttons(html):
+    soup = Soup(html, "html.parser")
+    details = soup.find("details", {"class": "actions-menu-links"})
+    if details is None:
+        return []
+    buttons = []
+    for button_el in details.select("button.action-menu-button"):
+        description = None
+        description_el = button_el.find(class_="dropdown-description")
+        if description_el is not None:
+            description = description_el.text.strip()
+            description_el.extract()
+        buttons.append(
+            {
+                "label": button_el.text.strip(),
+                "description": description,
+                "attrs": dict(button_el.attrs),
+            }
+        )
+    return buttons
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "path,expected_url",

From 82c95a1a135d4a2c1b667031e141cb7f88193bc4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 15:59:08 -0700
Subject: [PATCH 210/386] Refactor edit/delete tools to work on row pages too

Refs https://github.com/simonw/datasette/pull/2781#issuecomment-4703303274

Refs #2780
---
 datasette/app.py                   |    1 +
 datasette/static/edit-tools.js     | 1972 ++++++++++++++++++++++++++++
 datasette/static/table.js          | 1938 ---------------------------
 datasette/templates/row.html       |    7 +
 datasette/templates/table.html     |    1 +
 datasette/views/row.py             |  120 +-
 tests/test_datasette_manager_js.py |   16 +-
 tests/test_table_html.py           |  154 +++
 8 files changed, 2261 insertions(+), 1948 deletions(-)
 create mode 100644 datasette/static/edit-tools.js

diff --git a/datasette/app.py b/datasette/app.py
index 9b3cf51c..545a65c8 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2320,6 +2320,7 @@ class Datasette:
                 and "ds_actor" in request.cookies
                 and request.actor,
                 "app_css_hash": self.app_css_hash(),
+                "edit_tools_js_hash": self.static_hash("edit-tools.js"),
                 "table_js_hash": self.static_hash("table.js"),
                 "zip": zip,
                 "body_scripts": body_scripts,
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
new file mode 100644
index 00000000..2af7b35b
--- /dev/null
+++ b/datasette/static/edit-tools.js
@@ -0,0 +1,1972 @@
+var ROW_DELETE_DIALOG_ID = "row-delete-dialog";
+var rowDeleteDialogState = null;
+var ROW_EDIT_DIALOG_ID = "row-edit-dialog";
+var rowEditDialogState = null;
+
+function ensureRowMutationStatus(manager) {
+  var status = document.querySelector(".row-mutation-status");
+  if (status) {
+    return status;
+  }
+
+  status = document.createElement("p");
+  status.className = "row-mutation-status";
+  status.hidden = true;
+  status.setAttribute("role", "status");
+  status.setAttribute("aria-live", "polite");
+  status.setAttribute("tabindex", "-1");
+
+  var tableWrapper = document.querySelector(manager.selectors.tableWrapper);
+  if (tableWrapper && tableWrapper.parentNode) {
+    tableWrapper.parentNode.insertBefore(status, tableWrapper);
+  } else {
+    document.body.appendChild(status);
+  }
+  return status;
+}
+
+function showRowMutationStatus(manager, message, isError) {
+  var status = ensureRowMutationStatus(manager);
+  status.hidden = false;
+  status.classList.toggle("row-mutation-status-error", !!isError);
+  status.textContent = message;
+  return status;
+}
+
+function hideRowMutationStatus() {
+  var status = document.querySelector(".row-mutation-status");
+  if (!status) {
+    return;
+  }
+  status.hidden = true;
+  status.classList.remove("row-mutation-status-error");
+  status.textContent = "";
+}
+
+function setRowDeleteDialogBusy(state, isBusy) {
+  state.isBusy = isBusy;
+  state.confirmButton.disabled = isBusy;
+  state.cancelButton.disabled = isBusy;
+  state.confirmButton.textContent = isBusy ? "Deleting..." : "Delete row";
+}
+
+function clearRowDeleteDialogError(state) {
+  state.error.hidden = true;
+  state.error.textContent = "";
+}
+
+function showRowDeleteDialogError(state, message) {
+  state.error.hidden = false;
+  state.error.textContent = message;
+}
+
+function rowMutationRequestError(response, data) {
+  if (data && data.errors) {
+    return new Error(data.errors.join(" "));
+  }
+  if (data && data.error) {
+    return new Error(data.error);
+  }
+  if (data && data.title) {
+    return new Error(data.title);
+  }
+  return new Error("Request failed with HTTP " + response.status);
+}
+
+function tildeDecode(value) {
+  if (!value) {
+    return "";
+  }
+  var placeholder = "__datasette_percent_placeholder__";
+  try {
+    return decodeURIComponent(
+      value
+        .replace(/%/g, placeholder)
+        .replace(/~/g, "%")
+        .replace(/\+/g, " "),
+    ).replace(new RegExp(placeholder, "g"), "%");
+  } catch (_error) {
+    return value;
+  }
+}
+
+function tildeEncode(value) {
+  var bytes = new TextEncoder().encode(String(value));
+  var encoded = "";
+  bytes.forEach(function (byte) {
+    var isSafe =
+      (byte >= 65 && byte <= 90) ||
+      (byte >= 97 && byte <= 122) ||
+      (byte >= 48 && byte <= 57) ||
+      byte === 95 ||
+      byte === 45;
+    if (isSafe) {
+      encoded += String.fromCharCode(byte);
+    } else if (byte === 32) {
+      encoded += "+";
+    } else {
+      encoded += "~" + byte.toString(16).toUpperCase().padStart(2, "0");
+    }
+  });
+  return encoded;
+}
+
+function rowDisplayLabel(row) {
+  return tildeDecode(row.getAttribute("data-row") || "");
+}
+
+function rowTitleLabel(row) {
+  return row.getAttribute("data-row-label") || "";
+}
+
+function insertedRowStatusMessage(rowId, rowLabel) {
+  var message = "Inserted row " + rowId;
+  if (rowLabel && rowLabel !== rowId) {
+    message += " (" + rowLabel + ")";
+  }
+  return message + ".";
+}
+
+function tableBaseUrl() {
+  var tableUrl =
+    window._datasetteTableData && window._datasetteTableData.tableUrl;
+  var url = new URL(tableUrl || location.href, location.href);
+  url.hash = "";
+  url.search = "";
+  return url;
+}
+
+function tablePageData() {
+  return window._datasetteTableData || {};
+}
+
+function tableInsertData() {
+  return tablePageData().insertRow;
+}
+
+function tableForeignKeys() {
+  return tablePageData().foreignKeys || {};
+}
+
+function isRowPage() {
+  return document.body && document.body.classList.contains("row");
+}
+
+function rowElementForActionButton(button) {
+  return (
+    button.closest("[data-row]") ||
+    (button.getAttribute("data-row") ? button : null)
+  );
+}
+
+function foreignKeyAutocompleteUrl(column) {
+  return tableForeignKeys()[column] || null;
+}
+
+function autocompleteRowPk(row) {
+  var pks = (row && row.pks) || {};
+  var keys = Object.keys(pks);
+  if (keys.length !== 1) {
+    return null;
+  }
+  return pks[keys[0]];
+}
+
+function foreignKeyRowUrl(autocompleteUrl, pk) {
+  var url = new URL(autocompleteUrl, location.href);
+  if (!/\/-\/autocomplete\/?$/.test(url.pathname)) {
+    return null;
+  }
+  url.pathname =
+    url.pathname.replace(/\/-\/autocomplete\/?$/, "") + "/" + tildeEncode(pk);
+  url.search = "";
+  url.hash = "";
+  return url.toString();
+}
+
+function foreignKeyLabelText(row) {
+  var pk = autocompleteRowPk(row);
+  var label = row && row.label;
+  if (
+    label !== null &&
+    typeof label !== "undefined" &&
+    String(label) !== String(pk)
+  ) {
+    return String(label);
+  }
+  return "View row";
+}
+
+function rowEditMetaTextWithoutCurrentValue(meta) {
+  return (meta.dataset.baseMeta || "")
+    .split(" · ")
+    .filter(function (part) {
+      return part !== "Current value: NULL";
+    })
+    .join(" · ");
+}
+
+function updateRowEditForeignKeySeparator(meta) {
+  var separator = meta.querySelector(".row-edit-fk-separator");
+  if (!separator) {
+    return;
+  }
+  var baseMeta = meta.querySelector(".row-edit-base-meta");
+  var hasBaseMeta = !!(baseMeta && baseMeta.textContent);
+  separator.textContent = hasBaseMeta ? " · " : "";
+  separator.hidden = !hasBaseMeta;
+}
+
+function updateRowEditFieldMetaHidden(meta) {
+  var baseMeta = meta.querySelector(".row-edit-base-meta");
+  var hasBaseMeta = !!(baseMeta && baseMeta.textContent);
+  var foreignKeyLinkWrap = meta.querySelector(".row-edit-fk-link-wrap");
+  var hasForeignKeyLink = foreignKeyLinkWrap && !foreignKeyLinkWrap.hidden;
+  meta.hidden =
+    meta.dataset.reserveSpace !== "1" && !hasBaseMeta && !hasForeignKeyLink;
+}
+
+function setRowEditBaseMetaText(meta, text) {
+  var baseMeta = meta.querySelector(".row-edit-base-meta");
+  if (!baseMeta) {
+    return;
+  }
+  baseMeta.textContent = text || "";
+  updateRowEditForeignKeySeparator(meta);
+  updateRowEditFieldMetaHidden(meta);
+}
+
+function setForeignKeyMetaLink(meta, autocompleteUrl, row) {
+  var wrap = meta.querySelector(".row-edit-fk-link-wrap");
+  if (!wrap) {
+    return;
+  }
+  var pkSpan = wrap.querySelector(".row-edit-fk-pk");
+  var link = wrap.querySelector("a");
+  var pk = autocompleteRowPk(row);
+  var url =
+    pk === null || typeof pk === "undefined"
+      ? null
+      : foreignKeyRowUrl(autocompleteUrl, pk);
+  if (!url) {
+    wrap.hidden = true;
+    pkSpan.textContent = "";
+    link.removeAttribute("href");
+    link.textContent = "";
+    link.removeAttribute("aria-label");
+    setRowEditBaseMetaText(meta, meta.dataset.baseMeta || "");
+    updateRowEditFieldMetaHidden(meta);
+    return;
+  }
+  setRowEditBaseMetaText(meta, rowEditMetaTextWithoutCurrentValue(meta));
+  var pkText = String(pk);
+  var linkText = foreignKeyLabelText(row);
+  pkSpan.textContent = pkText;
+  link.href = url;
+  link.textContent = linkText;
+  link.setAttribute(
+    "aria-label",
+    "Open referenced row " + pkText + " " + linkText + " in a new tab",
+  );
+  wrap.hidden = false;
+  updateRowEditFieldMetaHidden(meta);
+}
+
+async function resolveForeignKeyMetaLink(control, autocompleteUrl, meta) {
+  var value = control.value.trim();
+  if (!value) {
+    setForeignKeyMetaLink(meta, autocompleteUrl, null);
+    return;
+  }
+
+  var url = new URL(autocompleteUrl, location.href);
+  url.searchParams.set("q", value);
+  try {
+    var response = await fetch(url.toString(), {
+      headers: {
+        Accept: "application/json",
+      },
+    });
+    if (!response.ok) {
+      throw new Error("HTTP " + response.status);
+    }
+    var data = await response.json();
+    if (control.value.trim() !== value) {
+      return;
+    }
+    var rows = (data && data.rows) || [];
+    var row = rows.find(function (candidate) {
+      var pk = autocompleteRowPk(candidate);
+      return pk !== null && typeof pk !== "undefined" && String(pk) === value;
+    });
+    setForeignKeyMetaLink(meta, autocompleteUrl, row || null);
+  } catch (_error) {
+    if (control.value.trim() === value) {
+      setForeignKeyMetaLink(meta, autocompleteUrl, null);
+    }
+  }
+}
+
+function tableInsertUrl() {
+  var data = tableInsertData();
+  if (data && data.path) {
+    return new URL(data.path, location.href).toString();
+  }
+  var url = tableBaseUrl();
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/insert";
+  return url.toString();
+}
+
+function rowResourceUrl(row) {
+  var rowId = row.getAttribute("data-row");
+  if (!rowId) {
+    return null;
+  }
+  var url = tableBaseUrl();
+  url.pathname = url.pathname.replace(/\/$/, "") + "/" + rowId;
+  return url;
+}
+
+function rowJsonUrl(row) {
+  var url = rowResourceUrl(row);
+  if (!url) {
+    return "";
+  }
+  url.pathname = url.pathname + ".json";
+  url.searchParams.set("_extra", "columns,column_types");
+  return url.toString();
+}
+
+function rowDeleteUrl(row) {
+  var url = rowResourceUrl(row);
+  if (!url) {
+    return "";
+  }
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/delete";
+  if (isRowPage()) {
+    url.searchParams.set("_redirect_to_table", "1");
+  }
+  return url.toString();
+}
+
+function rowUpdateUrl(row) {
+  var url = rowResourceUrl(row);
+  if (!url) {
+    return "";
+  }
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/update";
+  if (isRowPage()) {
+    url.searchParams.set("_message", "1");
+  }
+  return url.toString();
+}
+
+function rowFragmentUrl(row) {
+  var rowId = row.getAttribute("data-row");
+  return rowFragmentUrlById(rowId);
+}
+
+function rowFragmentUrlById(rowId) {
+  if (!rowId) {
+    return "";
+  }
+  var url = tableBaseUrl();
+  url.search = new URL(location.href).search;
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/fragment";
+  url.searchParams.delete("_next");
+  url.searchParams.set("_row", rowId);
+  url.searchParams.set("_nocount", "1");
+  url.searchParams.set("_nofacet", "1");
+  url.searchParams.set("_nosuggest", "1");
+  return url.toString();
+}
+
+function nextRowActionFocusTarget(row, action) {
+  var selector = 'button[data-row-action="' + action + '"]:not([disabled])';
+  var sibling = row.nextElementSibling;
+  while (sibling) {
+    var nextButton = sibling.querySelector(selector);
+    if (nextButton) {
+      return nextButton;
+    }
+    sibling = sibling.nextElementSibling;
+  }
+
+  sibling = row.previousElementSibling;
+  while (sibling) {
+    var previousButton = sibling.querySelector(selector);
+    if (previousButton) {
+      return previousButton;
+    }
+    sibling = sibling.previousElementSibling;
+  }
+
+  return null;
+}
+
+function nextRowDeleteFocusTarget(row, manager) {
+  return nextRowActionFocusTarget(row, "delete") || ensureRowMutationStatus(manager);
+}
+
+function ensureRowDeleteDialog(manager) {
+  if (rowDeleteDialogState) {
+    return rowDeleteDialogState;
+  }
+  if (!window.HTMLDialogElement) {
+    return null;
+  }
+
+  var dialog = document.createElement("dialog");
+  dialog.id = ROW_DELETE_DIALOG_ID;
+  dialog.className = "row-delete-dialog";
+  dialog.setAttribute("aria-labelledby", "row-delete-title");
+  dialog.setAttribute("aria-describedby", "row-delete-message");
+  dialog.innerHTML = `
+    <div class="modal-header">
+      <span class="modal-title" id="row-delete-title">Delete row</span>
+    </div>
+    <p class="row-delete-message" id="row-delete-message">Delete row <span class="row-delete-id"></span>?</p>
+    <p class="row-delete-error" role="alert" hidden></p>
+    <div class="modal-footer">
+      <button type="button" class="btn btn-ghost row-delete-cancel">Cancel</button>
+      <button type="button" class="btn btn-primary row-delete-confirm">Delete row</button>
+    </div>
+  `;
+  document.body.appendChild(dialog);
+
+  rowDeleteDialogState = {
+    dialog: dialog,
+    title: dialog.querySelector(".modal-title"),
+    message: dialog.querySelector(".row-delete-message"),
+    rowId: dialog.querySelector(".row-delete-id"),
+    error: dialog.querySelector(".row-delete-error"),
+    cancelButton: dialog.querySelector(".row-delete-cancel"),
+    confirmButton: dialog.querySelector(".row-delete-confirm"),
+    currentRow: null,
+    currentDeleteUrl: null,
+    currentPkPath: null,
+    manager: manager,
+    isBusy: false,
+    shouldRestoreFocus: true,
+  };
+
+  rowDeleteDialogState.cancelButton.addEventListener("click", function () {
+    if (!rowDeleteDialogState.isBusy) {
+      rowDeleteDialogState.shouldRestoreFocus = true;
+      dialog.close();
+    }
+  });
+
+  dialog.addEventListener("click", function (ev) {
+    if (ev.target === dialog && !rowDeleteDialogState.isBusy) {
+      rowDeleteDialogState.shouldRestoreFocus = true;
+      dialog.close();
+    }
+  });
+
+  dialog.addEventListener("keydown", function (ev) {
+    if (
+      ev.key === "Enter" &&
+      document.activeElement === rowDeleteDialogState.confirmButton
+    ) {
+      ev.preventDefault();
+      if (!rowDeleteDialogState.isBusy) {
+        rowDeleteDialogState.confirmButton.click();
+      }
+      return;
+    }
+    if (ev.key !== "Escape") {
+      return;
+    }
+    if (rowDeleteDialogState.isBusy) {
+      ev.preventDefault();
+      return;
+    }
+    ev.preventDefault();
+    rowDeleteDialogState.shouldRestoreFocus = true;
+    dialog.close();
+  });
+
+  dialog.addEventListener("cancel", function (ev) {
+    if (rowDeleteDialogState.isBusy) {
+      ev.preventDefault();
+    } else {
+      rowDeleteDialogState.shouldRestoreFocus = true;
+    }
+  });
+
+  dialog.addEventListener("close", function () {
+    var state = rowDeleteDialogState;
+    clearRowDeleteDialogError(state);
+    setRowDeleteDialogBusy(state, false);
+    if (
+      state.shouldRestoreFocus &&
+      state.currentButton &&
+      document.contains(state.currentButton)
+    ) {
+      state.currentButton.focus();
+    }
+  });
+
+  rowDeleteDialogState.confirmButton.addEventListener("click", async function () {
+    var state = rowDeleteDialogState;
+    clearRowDeleteDialogError(state);
+    setRowDeleteDialogBusy(state, true);
+
+    try {
+      var response = await fetch(state.currentDeleteUrl, {
+        method: "POST",
+        headers: {
+          Accept: "application/json",
+        },
+      });
+      var data = null;
+      try {
+        data = await response.json();
+      } catch (_error) {
+        data = null;
+      }
+      if (!response.ok || (data && data.ok === false)) {
+        throw rowMutationRequestError(response, data);
+      }
+      if (data && data.redirect) {
+        state.shouldRestoreFocus = false;
+        state.dialog.close();
+        location.href = data.redirect;
+        return;
+      }
+
+      var focusTarget = nextRowDeleteFocusTarget(state.currentRow, state.manager);
+      var statusMessage = state.currentPkPath
+        ? "Deleted row " + state.currentPkPath + "."
+        : "Deleted row.";
+      state.shouldRestoreFocus = false;
+      state.dialog.close();
+      state.currentRow.remove();
+      showRowMutationStatus(state.manager, statusMessage, false);
+      if (focusTarget && document.contains(focusTarget)) {
+        focusTarget.focus();
+      } else {
+        ensureRowMutationStatus(state.manager).focus();
+      }
+    } catch (error) {
+      setRowDeleteDialogBusy(state, false);
+      showRowDeleteDialogError(state, error.message || "Delete failed");
+    }
+  });
+
+  return rowDeleteDialogState;
+}
+
+function openRowDeleteDialog(button, manager) {
+  var row = rowElementForActionButton(button);
+  if (!row || !row.getAttribute("data-row")) {
+    return;
+  }
+  var state = ensureRowDeleteDialog(manager);
+  if (!state) {
+    return;
+  }
+
+  state.manager = manager;
+  state.currentButton = button;
+  state.currentRow = row;
+  state.currentDeleteUrl = rowDeleteUrl(row);
+  state.currentPkPath = rowDisplayLabel(row);
+  state.shouldRestoreFocus = true;
+
+  clearRowDeleteDialogError(state);
+  setRowDeleteDialogBusy(state, false);
+  setRowDialogTitle(
+    state.title,
+    "Delete row",
+    state.currentPkPath || "this row",
+    rowTitleLabel(row),
+  );
+  state.rowId.textContent = state.currentPkPath || "this row";
+
+  if (!state.dialog.open) {
+    state.dialog.showModal();
+  }
+  state.confirmButton.focus();
+}
+
+function initRowDeleteActions(manager) {
+  if (!window.fetch || !window.HTMLDialogElement) {
+    return;
+  }
+  document.addEventListener("click", function (ev) {
+    var button = ev.target.closest('button[data-row-action="delete"]');
+    if (!button) {
+      return;
+    }
+    ev.preventDefault();
+    openRowDeleteDialog(button, manager);
+  });
+}
+
+function valueToEditText(value) {
+  if (value === null || typeof value === "undefined") {
+    return "";
+  }
+  if (typeof value === "object") {
+    return JSON.stringify(value, null, 2);
+  }
+  return String(value);
+}
+
+function shouldUseTextarea(value, columnType) {
+  if (columnType && columnType.type === "textarea") {
+    return true;
+  }
+  if (value && typeof value === "object") {
+    return true;
+  }
+  var text = valueToEditText(value);
+  return text.length > 80 || /[\r\n]/.test(text);
+}
+
+function rowEditValueKind(value) {
+  if (value === null || typeof value === "undefined") {
+    return "null";
+  }
+  if (typeof value === "number") {
+    return "number";
+  }
+  if (typeof value === "boolean") {
+    return "boolean";
+  }
+  return "string";
+}
+
+function rowEditControlElement(control, autocompleteUrl) {
+  if (!autocompleteUrl || control.nodeName !== "INPUT") {
+    return control;
+  }
+  var autocomplete = document.createElement("datasette-autocomplete");
+  autocomplete.setAttribute("src", autocompleteUrl);
+  autocomplete.setAttribute("suggest-on-focus", "");
+  autocomplete.appendChild(control);
+  return autocomplete;
+}
+
+function columnTypeForContext(columnType) {
+  if (!columnType) {
+    return null;
+  }
+  return {
+    type: columnType.type,
+    config: columnType.config || {},
+  };
+}
+
+function defaultExpressionForContext(expression) {
+  if (expression === null || typeof expression === "undefined") {
+    return null;
+  }
+  return expression;
+}
+
+function columnFormControlContext(column, isPk, columnType, options) {
+  var pageData = tablePageData();
+  var defaultExpression = defaultExpressionForContext(options.defaultExpression);
+  return {
+    mode: options.mode || "edit",
+    database: pageData.database || null,
+    table: pageData.table || (tableInsertData() && tableInsertData().tableName) || null,
+    tableUrl: pageData.tableUrl || null,
+    column: column,
+    columnType: columnTypeForContext(columnType),
+    sqliteType: options.sqliteType || null,
+    notNull: !!options.notnull,
+    isPk: !!isPk,
+    defaultExpression: defaultExpression,
+    form: options.form || null,
+    dialog: options.dialog || null,
+  };
+}
+
+function makeColumnField(manager, context) {
+  if (!manager || !manager.makeColumnField) {
+    return null;
+  }
+  return manager.makeColumnField(context);
+}
+
+function createColumnFieldApi(options) {
+  var control = options.control;
+  var context = options.context;
+  var field = {
+    context: context,
+    id: options.id,
+    labelId: options.labelId,
+    descriptionId: options.descriptionId,
+    root: null,
+    form: options.form || null,
+    dialog: options.dialog || null,
+    input: control,
+    control: control,
+    meta: options.meta || null,
+    validationMessageElement: null,
+    getValue: function () {
+      return valueFromRowEditControl(control);
+    },
+    setValue: function (value) {
+      if (
+        value !== null &&
+        typeof value !== "undefined" &&
+        typeof value === "object"
+      ) {
+        throw new TypeError(
+          "field.setValue() accepts strings, numbers, booleans or null; serialize objects before setting the field value",
+        );
+      }
+      field.stopUsingSqliteDefault();
+      control.value = valueToEditText(value);
+      control.dataset.currentValueKind = rowEditValueKind(value);
+    },
+    getInitialValue: function () {
+      return initialValueFromRowEditControl(control);
+    },
+    hasChanged: function () {
+      return rowEditControlHasChanged(control);
+    },
+    clearValue: function () {
+      field.setValue(null);
+    },
+    isUsingSqliteDefault: function () {
+      return control.dataset.useSqliteDefault === "1";
+    },
+    useSqliteDefault: function () {
+      if (
+        context.defaultExpression === null ||
+        typeof context.defaultExpression === "undefined"
+      ) {
+        return;
+      }
+      control.dataset.useSqliteDefault = "1";
+      control.disabled = true;
+      control.value = "";
+      control.dataset.currentValueKind = "null";
+      field.syncSqliteDefaultUi();
+    },
+    stopUsingSqliteDefault: function () {
+      if (control.dataset.useSqliteDefault !== "1") {
+        return;
+      }
+      control.dataset.useSqliteDefault = "0";
+      control.disabled = false;
+      field.syncSqliteDefaultUi();
+    },
+    syncSqliteDefaultUi: function () {},
+    markClean: function () {
+      markRowEditControlClean(control);
+    },
+    setValidity: function (message) {
+      message = message || "";
+      control.setCustomValidity(message);
+      if (message) {
+        control.setAttribute("aria-invalid", "true");
+      } else {
+        control.removeAttribute("aria-invalid");
+      }
+      var validationMessage = ensureColumnFieldValidationMessage(field);
+      if (validationMessage) {
+        validationMessage.textContent = message;
+        validationMessage.hidden = !message;
+      }
+    },
+    clearValidity: function () {
+      field.setValidity("");
+    },
+  };
+  field.markClean();
+  return field;
+}
+
+function ensureColumnFieldValidationMessage(field) {
+  if (field.validationMessageElement) {
+    return field.validationMessageElement;
+  }
+  if (!field.meta) {
+    return null;
+  }
+  var validationMessage = document.createElement("span");
+  validationMessage.id = field.id + "-validation-error";
+  validationMessage.className = "row-edit-field-validation-error";
+  validationMessage.hidden = true;
+  validationMessage.setAttribute("role", "alert");
+  field.meta.appendChild(validationMessage);
+  field.validationMessageElement = validationMessage;
+  return validationMessage;
+}
+
+function renderColumnField(pluginControl, fieldApi) {
+  if (!pluginControl || !pluginControl.render) {
+    return null;
+  }
+  var pluginWrap = document.createElement("div");
+  pluginWrap.className = "row-edit-plugin-control";
+  pluginWrap.dataset.pluginName = pluginControl.pluginName || "";
+  pluginWrap.dataset.column = fieldApi.context.column;
+  if (fieldApi.context.columnType && fieldApi.context.columnType.type) {
+    pluginWrap.dataset.columnType = fieldApi.context.columnType.type;
+  }
+  fieldApi.root = pluginWrap;
+  try {
+    var rendered = pluginControl.render(fieldApi);
+    if (rendered && rendered.nodeType) {
+      pluginWrap.appendChild(rendered);
+    }
+  } catch (error) {
+    console.error("Error rendering column form control", error);
+    return null;
+  }
+  pluginWrap._datasetteColumnField = pluginControl;
+  pluginWrap._datasetteColumnFormField = fieldApi;
+  return pluginWrap;
+}
+
+function validateJsonColumnField(field) {
+  var value = field.input.value;
+  if (value.trim() === "") {
+    field.clearValidity();
+    return true;
+  }
+  try {
+    JSON.parse(value);
+    field.clearValidity();
+    return true;
+  } catch (error) {
+    field.setValidity(
+      "Invalid JSON" + (error && error.message ? ": " + error.message : ""),
+    );
+    return false;
+  }
+}
+
+function registerBuiltinColumnFieldPlugins(manager) {
+  if (!manager || !manager.registerPlugin) {
+    return;
+  }
+  manager.registerPlugin("datasette-json-column", {
+    version: "1.0",
+    makeColumnField: function (context) {
+      if (!context.columnType || context.columnType.type !== "json") {
+        return;
+      }
+      return {
+        useTextarea: true,
+        render: function (field) {
+          field.input.addEventListener("input", function () {
+            validateJsonColumnField(field);
+          });
+          field.input.addEventListener("change", function () {
+            validateJsonColumnField(field);
+          });
+          validateJsonColumnField(field);
+          return field.input;
+        },
+        focus: function (field) {
+          field.input.focus();
+        },
+      };
+    },
+  });
+}
+
+function focusRowEditPluginControl(field) {
+  var pluginWrap = field.querySelector(".row-edit-plugin-control");
+  if (!pluginWrap) {
+    return false;
+  }
+  var pluginControl = pluginWrap._datasetteColumnField;
+  var fieldApi = pluginWrap._datasetteColumnFormField;
+  if (pluginControl && pluginControl.focus) {
+    try {
+      pluginControl.focus(fieldApi);
+      return true;
+    } catch (error) {
+      console.error("Error focusing column form control", error);
+    }
+  }
+  return false;
+}
+
+function focusFirstRowEditControl(state, options) {
+  options = options || {};
+  var fields = state.fields.querySelectorAll(".row-edit-field");
+  for (var i = 0; i < fields.length; i += 1) {
+    var field = fields[i];
+    var control = field.querySelector(".row-edit-input");
+    if (!control) {
+      continue;
+    }
+    if (options.skipReadonly && (control.readOnly || control.disabled)) {
+      continue;
+    }
+    if (focusRowEditPluginControl(field)) {
+      return true;
+    }
+    control.focus();
+    return true;
+  }
+  return false;
+}
+
+function destroyRowEditFields(state) {
+  if (!state || !state.fields) {
+    return;
+  }
+  state.fields
+    .querySelectorAll(".row-edit-plugin-control")
+    .forEach(function (pluginWrap) {
+      var pluginControl = pluginWrap._datasetteColumnField;
+      var fieldApi = pluginWrap._datasetteColumnFormField;
+      if (pluginControl && pluginControl.destroy) {
+        try {
+          pluginControl.destroy(fieldApi);
+        } catch (error) {
+          console.error("Error destroying column form control", error);
+        }
+      }
+    });
+  state.fields.innerHTML = "";
+}
+
+function createRowEditField(column, value, isPk, columnType, index, options) {
+  options = options || {};
+  var field = document.createElement("div");
+  field.className = "row-edit-field";
+  var defaultExpression = defaultExpressionForContext(options.defaultExpression);
+  var hasDefaultExpression = defaultExpression !== null;
+  var useSqliteDefault = hasDefaultExpression && options.useSqliteDefault;
+
+  var fieldId = "row-edit-field-" + index;
+  var metaId = "row-edit-field-meta-" + index;
+  var labelId = "row-edit-field-label-" + index;
+  var label = document.createElement("label");
+  label.className = "row-edit-label";
+  label.id = labelId;
+  label.setAttribute("for", fieldId);
+  label.textContent = column;
+
+  var controlWrap = document.createElement("div");
+  controlWrap.className = "row-edit-control-wrap";
+
+  var context = columnFormControlContext(
+    column,
+    isPk,
+    columnType,
+    options,
+  );
+  var pluginControl = makeColumnField(options.manager, context);
+  var useTextarea =
+    (pluginControl && pluginControl.useTextarea === true) ||
+    shouldUseTextarea(value, columnType);
+  var control = useTextarea
+    ? document.createElement("textarea")
+    : document.createElement("input");
+  control.className = "row-edit-input";
+  control.id = fieldId;
+  control.name = column;
+  control.value = valueToEditText(value);
+  control.setAttribute("aria-describedby", metaId);
+  control.dataset.initialValue = valueToEditText(value);
+  control.dataset.initialValueKind =
+    options.valueKind || rowEditValueKind(value);
+  control.dataset.primaryKey = isPk ? "1" : "0";
+  control.dataset.currentValueKind = control.dataset.initialValueKind;
+  if (hasDefaultExpression) {
+    control.dataset.useSqliteDefault = useSqliteDefault ? "1" : "0";
+  }
+  if (useSqliteDefault) {
+    control.disabled = true;
+  }
+  if (options.omitIfBlank) {
+    control.dataset.omitIfBlank = "1";
+  }
+
+  if (control.nodeName === "TEXTAREA") {
+    control.rows = Math.min(8, Math.max(3, control.value.split("\n").length));
+  } else {
+    control.type = "text";
+  }
+
+  if (isPk && options.primaryKeyReadonly !== false) {
+    control.readOnly = true;
+  }
+
+  var meta = document.createElement("span");
+  meta.id = metaId;
+  meta.className = "row-edit-field-meta";
+  if (options.autocompleteUrl) {
+    meta.classList.add("row-edit-field-meta-autocomplete");
+    meta.dataset.reserveSpace = "1";
+  }
+  var metaParts = [];
+  if (isPk) {
+    metaParts.push("Primary key");
+  }
+  if (options.notnull) {
+    metaParts.push("Required");
+  }
+  if (hasDefaultExpression && !useSqliteDefault) {
+    metaParts.push("SQLite default: " + defaultExpression);
+  }
+  if (value === null) {
+    metaParts.push("Current value: NULL");
+    control.placeholder = "NULL";
+  }
+  if (columnType && columnType.type) {
+    metaParts.push("Custom type: " + columnType.type);
+  }
+  meta.dataset.baseMeta = metaParts.join(" · ");
+  var baseMeta = document.createElement("span");
+  baseMeta.className = "row-edit-base-meta";
+  baseMeta.textContent = meta.dataset.baseMeta;
+  meta.appendChild(baseMeta);
+  if (options.autocompleteUrl) {
+    var foreignKeyLinkWrap = document.createElement("span");
+    foreignKeyLinkWrap.className = "row-edit-fk-link-wrap";
+    foreignKeyLinkWrap.hidden = true;
+    var foreignKeySeparator = document.createElement("span");
+    foreignKeySeparator.className = "row-edit-fk-separator";
+    foreignKeySeparator.textContent = meta.dataset.baseMeta ? " · " : "";
+    foreignKeySeparator.hidden = !meta.dataset.baseMeta;
+    foreignKeyLinkWrap.appendChild(foreignKeySeparator);
+    var foreignKeyPk = document.createElement("span");
+    foreignKeyPk.className = "row-edit-fk-pk";
+    foreignKeyLinkWrap.appendChild(foreignKeyPk);
+    foreignKeyLinkWrap.appendChild(document.createTextNode(" "));
+    var foreignKeyLink = document.createElement("a");
+    foreignKeyLink.className = "row-edit-fk-link";
+    foreignKeyLink.target = "_blank";
+    foreignKeyLink.rel = "noopener noreferrer";
+    foreignKeyLinkWrap.appendChild(foreignKeyLink);
+    meta.appendChild(foreignKeyLinkWrap);
+    updateRowEditFieldMetaHidden(meta);
+  }
+  var fieldApi = createColumnFieldApi({
+    id: fieldId,
+    labelId: labelId,
+    descriptionId: metaId,
+    control: control,
+    meta: meta,
+    input: control,
+    form: options.form || null,
+    dialog: options.dialog || null,
+    context: context,
+  });
+  field._datasetteColumnFormField = fieldApi;
+  var pluginControlElement = renderColumnField(pluginControl, fieldApi);
+  var controlElement =
+    pluginControlElement || rowEditControlElement(control, options.autocompleteUrl);
+  if (options.autocompleteUrl && !pluginControlElement) {
+    control.addEventListener("input", function () {
+      setForeignKeyMetaLink(meta, options.autocompleteUrl, null);
+    });
+    control.addEventListener("change", function () {
+      resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
+    });
+    controlElement.addEventListener("datasette-autocomplete-select", function (ev) {
+      setForeignKeyMetaLink(
+        meta,
+        options.autocompleteUrl,
+        ev.detail && ev.detail.row,
+      );
+    });
+    resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
+  }
+
+  if (hasDefaultExpression) {
+    var defaultBlock = document.createElement("div");
+    defaultBlock.className = "row-edit-default";
+    defaultBlock.setAttribute("aria-describedby", metaId);
+
+    var defaultText = document.createElement("span");
+    defaultText.className = "row-edit-default-text";
+    defaultText.appendChild(document.createTextNode("default "));
+    var defaultCode = document.createElement("code");
+    defaultCode.className = "row-edit-default-code";
+    defaultCode.textContent = defaultExpression;
+    defaultText.appendChild(defaultCode);
+
+    var setValueButton = document.createElement("button");
+    setValueButton.type = "button";
+    setValueButton.className =
+      "row-edit-default-button row-edit-default-set-value";
+    setValueButton.textContent = "Set value";
+    setValueButton.setAttribute("aria-label", "Set value for " + column);
+
+    var customWrap = document.createElement("div");
+    customWrap.className = "row-edit-custom-value";
+    customWrap.hidden = true;
+
+    var useSqliteDefaultButton = document.createElement("button");
+    useSqliteDefaultButton.type = "button";
+    useSqliteDefaultButton.className = "row-edit-default-button";
+    useSqliteDefaultButton.textContent = "Use default";
+    useSqliteDefaultButton.setAttribute(
+      "aria-label",
+      "Use SQLite default for " + column,
+    );
+
+    setValueButton.addEventListener("click", function () {
+      fieldApi.stopUsingSqliteDefault();
+      control.focus();
+    });
+
+    useSqliteDefaultButton.addEventListener("click", function () {
+      fieldApi.useSqliteDefault();
+      setValueButton.focus();
+    });
+
+    defaultBlock.appendChild(defaultText);
+    defaultBlock.appendChild(setValueButton);
+    customWrap.appendChild(controlElement);
+    customWrap.appendChild(useSqliteDefaultButton);
+    controlWrap.appendChild(defaultBlock);
+    controlWrap.appendChild(customWrap);
+    fieldApi.syncSqliteDefaultUi = function () {
+      var usingDefault = fieldApi.isUsingSqliteDefault();
+      defaultBlock.hidden = !usingDefault;
+      customWrap.hidden = usingDefault;
+    };
+    fieldApi.syncSqliteDefaultUi();
+  } else {
+    controlWrap.appendChild(controlElement);
+  }
+  if (meta.textContent || options.autocompleteUrl) {
+    controlWrap.appendChild(meta);
+  }
+  field.appendChild(label);
+  field.appendChild(controlWrap);
+  return field;
+}
+
+function clearRowEditDialogError(state) {
+  state.error.hidden = true;
+  state.error.textContent = "";
+}
+
+function showRowEditDialogError(state, message) {
+  state.error.hidden = false;
+  state.error.textContent = message;
+  state.error.focus();
+}
+
+function updateRowEditDialogButtons(state) {
+  state.saveButton.disabled = state.isLoading || state.isSaving || !state.hasLoaded;
+  state.cancelButton.disabled = state.isSaving;
+  var saveLabel = state.mode === "insert" ? "Insert row" : "Save";
+  state.saveButton.textContent = state.isSaving ? "Saving..." : saveLabel;
+  state.form.setAttribute(
+    "aria-busy",
+    state.isLoading || state.isSaving ? "true" : "false",
+  );
+}
+
+function setRowEditDialogLoading(state, isLoading) {
+  state.isLoading = isLoading;
+  state.loading.hidden = !isLoading;
+  updateRowEditDialogButtons(state);
+}
+
+function setRowEditDialogSaving(state, isSaving) {
+  state.isSaving = isSaving;
+  updateRowEditDialogButtons(state);
+}
+
+function valueFromRowEditControl(control) {
+  var value = control.value;
+  return valueFromRowEditText(
+    control.name,
+    value,
+    rowEditControlValueKind(control),
+  );
+}
+
+function valueFromRowEditText(name, value, initialValueKind) {
+  var trimmed = value.trim();
+
+  if (initialValueKind === "null" && value === "") {
+    return null;
+  }
+  if (initialValueKind === "number") {
+    if (trimmed === "") {
+      return null;
+    }
+    var numberValue = Number(trimmed);
+    if (Number.isNaN(numberValue)) {
+      throw new Error(name + " must be a number");
+    }
+    return numberValue;
+  }
+  if (initialValueKind === "boolean") {
+    if (/^(true|1|yes)$/i.test(trimmed)) {
+      return true;
+    }
+    if (/^(false|0|no)$/i.test(trimmed)) {
+      return false;
+    }
+    throw new Error(name + " must be true or false");
+  }
+  return value;
+}
+
+function initialValueFromRowEditControl(control) {
+  return valueFromRowEditText(
+    control.name,
+    control.dataset.initialValue || "",
+    control.dataset.initialValueKind || "string",
+  );
+}
+
+function rowEditControlValueKind(control) {
+  return (
+    control.dataset.currentValueKind ||
+    control.dataset.initialValueKind ||
+    "string"
+  );
+}
+
+function rowEditControlCleanValue(control) {
+  if (Object.prototype.hasOwnProperty.call(control.dataset, "cleanValue")) {
+    return control.dataset.cleanValue;
+  }
+  return control.dataset.initialValue || "";
+}
+
+function rowEditControlCleanValueKind(control) {
+  return (
+    control.dataset.cleanValueKind ||
+    control.dataset.initialValueKind ||
+    "string"
+  );
+}
+
+function rowEditControlCleanUsesSqliteDefault(control) {
+  if (
+    Object.prototype.hasOwnProperty.call(
+      control.dataset,
+      "cleanUseSqliteDefault",
+    )
+  ) {
+    return control.dataset.cleanUseSqliteDefault === "1";
+  }
+  return false;
+}
+
+function markRowEditControlClean(control) {
+  control.dataset.cleanValue = control.value;
+  control.dataset.cleanValueKind = rowEditControlValueKind(control);
+  control.dataset.cleanUseSqliteDefault =
+    control.dataset.useSqliteDefault === "1" ? "1" : "0";
+}
+
+function cleanValueFromRowEditControl(control) {
+  return valueFromRowEditText(
+    control.name,
+    rowEditControlCleanValue(control),
+    rowEditControlCleanValueKind(control),
+  );
+}
+
+function rowEditValuesMatch(left, right) {
+  if (left === right) {
+    return true;
+  }
+  if (
+    left &&
+    right &&
+    typeof left === "object" &&
+    typeof right === "object"
+  ) {
+    return JSON.stringify(left) === JSON.stringify(right);
+  }
+  return false;
+}
+
+function rowEditControlHasChanged(control) {
+  var usingSqliteDefault = control.dataset.useSqliteDefault === "1";
+  var cleanUsesSqliteDefault = rowEditControlCleanUsesSqliteDefault(control);
+  if (usingSqliteDefault || cleanUsesSqliteDefault) {
+    return usingSqliteDefault !== cleanUsesSqliteDefault;
+  }
+  if (
+    control.value === rowEditControlCleanValue(control) &&
+    rowEditControlValueKind(control) === rowEditControlCleanValueKind(control)
+  ) {
+    return false;
+  }
+  try {
+    return !rowEditValuesMatch(
+      valueFromRowEditControl(control),
+      cleanValueFromRowEditControl(control),
+    );
+  } catch (_error) {
+    return true;
+  }
+}
+
+function collectRowFormValues(state) {
+  var values = {};
+  state.fields.querySelectorAll(".row-edit-input").forEach(function (control) {
+    if (
+      state.mode === "edit" &&
+      (control.readOnly || control.dataset.primaryKey === "1")
+    ) {
+      return;
+    }
+    if (control.dataset.useSqliteDefault === "1") {
+      return;
+    }
+    if (control.dataset.omitIfBlank === "1" && control.value === "") {
+      return;
+    }
+    if (
+      state.mode === "edit" &&
+      control.value === (control.dataset.initialValue || "") &&
+      (control.dataset.currentValueKind ||
+        control.dataset.initialValueKind ||
+        "string") === (control.dataset.initialValueKind || "string")
+    ) {
+      return;
+    }
+    var value = valueFromRowEditControl(control);
+    if (state.mode === "edit") {
+      try {
+        if (rowEditValuesMatch(value, initialValueFromRowEditControl(control))) {
+          return;
+        }
+      } catch (_error) {
+        // If the original value cannot be parsed using the field's current
+        // type, treat the field as changed and submit the corrected value.
+      }
+    }
+    values[control.name] = value;
+  });
+  return values;
+}
+
+function rowEditDialogHasChanges(state) {
+  if (!state || !state.hasLoaded || state.isLoading) {
+    return false;
+  }
+  var fields = state.fields.querySelectorAll(".row-edit-field");
+  for (var i = 0; i < fields.length; i += 1) {
+    var fieldApi = fields[i]._datasetteColumnFormField;
+    if (fieldApi && fieldApi.hasChanged && fieldApi.hasChanged()) {
+      return true;
+    }
+  }
+  return false;
+}
+
+function confirmDiscardRowEditChanges(state) {
+  if (!rowEditDialogHasChanges(state)) {
+    return true;
+  }
+  var message =
+    state.mode === "insert"
+      ? "Discard this new row?"
+      : "Discard unsaved changes to this row?";
+  return window.confirm(message);
+}
+
+function closeRowEditDialogIfConfirmed(state) {
+  if (!state || state.isSaving) {
+    return false;
+  }
+  if (!confirmDiscardRowEditChanges(state)) {
+    return false;
+  }
+  state.shouldRestoreFocus = true;
+  state.dialog.close();
+  return true;
+}
+
+function findDataRowElement(root, rowId) {
+  var elements = root.querySelectorAll("[data-row]");
+  for (var i = 0; i < elements.length; i += 1) {
+    if (elements[i].getAttribute("data-row") === rowId) {
+      return elements[i];
+    }
+  }
+  return null;
+}
+
+async function fetchUpdatedRowElement(state) {
+  if (!state.currentFragmentUrl || !state.currentRowId) {
+    return null;
+  }
+  var response = await fetch(state.currentFragmentUrl, {
+    headers: {
+      Accept: "text/html",
+    },
+  });
+  var html = await response.text();
+  if (!response.ok) {
+    throw new Error("Could not refresh row: HTTP " + response.status);
+  }
+  var doc = new DOMParser().parseFromString(html, "text/html");
+  return findDataRowElement(doc, state.currentRowId);
+}
+
+function rowPathFromRowData(row, primaryKeys) {
+  if (!row) {
+    return null;
+  }
+  var keys = primaryKeys && primaryKeys.length ? primaryKeys : ["rowid"];
+  var bits = [];
+  for (var i = 0; i < keys.length; i += 1) {
+    var key = keys[i];
+    if (typeof row[key] === "undefined") {
+      return null;
+    }
+    bits.push(tildeEncode(row[key]));
+  }
+  return bits.join(",");
+}
+
+function addInsertedRowToPage(rowElement) {
+  var importedRow = document.importNode(rowElement, true);
+  var firstRow = document.querySelector("[data-row]");
+  if (firstRow && firstRow.parentNode) {
+    firstRow.parentNode.insertBefore(importedRow, firstRow);
+  } else {
+    var tbody = document.querySelector("table.rows-and-columns tbody");
+    if (!tbody) {
+      return null;
+    }
+    tbody.appendChild(importedRow);
+  }
+  var zeroResults = document.querySelector(".zero-results");
+  if (zeroResults) {
+    zeroResults.remove();
+  }
+  return importedRow;
+}
+
+async function saveRowEditDialog(state) {
+  if (state.isLoading || state.isSaving || !state.hasLoaded) {
+    return;
+  }
+  clearRowEditDialogError(state);
+  setRowEditDialogSaving(state, true);
+
+  try {
+    var url = state.mode === "insert" ? state.currentInsertUrl : state.currentUpdateUrl;
+    if (!url) {
+      throw new Error(
+        state.mode === "insert"
+          ? "Could not find the row insert URL"
+          : "Could not find the row update URL",
+      );
+    }
+    var formValues = collectRowFormValues(state);
+    if (state.mode === "edit" && !Object.keys(formValues).length) {
+      state.shouldRestoreFocus = true;
+      hideRowMutationStatus();
+      state.dialog.close();
+      return;
+    }
+    var payload =
+      state.mode === "insert"
+        ? { row: formValues, return: true }
+        : { update: formValues, return: true };
+    var response = await fetch(url, {
+      method: "POST",
+      headers: {
+        "Content-Type": "application/json",
+        Accept: "application/json",
+      },
+      body: JSON.stringify(payload),
+    });
+    var data = null;
+    try {
+      data = await response.json();
+    } catch (_error) {
+      data = null;
+    }
+    if (!response.ok || (data && data.ok === false)) {
+      throw rowMutationRequestError(response, data);
+    }
+
+    if (state.mode === "insert") {
+      var insertData = tableInsertData() || {};
+      var insertedRowData = data && data.rows && data.rows.length ? data.rows[0] : null;
+      var insertedRowId = rowPathFromRowData(
+        insertedRowData,
+        insertData.primaryKeys || [],
+      );
+      state.shouldRestoreFocus = false;
+      if (!insertedRowId) {
+        state.dialog.close();
+        var missingIdStatus = showRowMutationStatus(
+          state.manager,
+          "Inserted row. Refresh the page to see it.",
+          false,
+        );
+        missingIdStatus.focus();
+        return;
+      }
+
+      state.currentRowId = insertedRowId;
+      state.currentFragmentUrl = rowFragmentUrlById(insertedRowId);
+      var insertedRow = null;
+      try {
+        insertedRow = await fetchUpdatedRowElement(state);
+      } catch (_error) {
+        state.dialog.close();
+        var refreshFailedStatus = showRowMutationStatus(
+          state.manager,
+          "Inserted row, but could not refresh the table row. Refresh the page to see it.",
+          true,
+        );
+        refreshFailedStatus.focus();
+        return;
+      }
+      if (insertedRow) {
+        var insertedStatusMessage = insertedRowStatusMessage(
+          tildeDecode(insertedRowId),
+          rowTitleLabel(insertedRow),
+        );
+        var addedRow = addInsertedRowToPage(insertedRow);
+        state.dialog.close();
+        showRowMutationStatus(state.manager, insertedStatusMessage, false);
+        if (addedRow) {
+          var insertedFocusTarget =
+            addedRow.querySelector('button[data-row-action="edit"]') || addedRow;
+          insertedFocusTarget.focus();
+        }
+      } else {
+        state.dialog.close();
+        var filteredStatus = showRowMutationStatus(
+          state.manager,
+          "Inserted row. It does not match the current filters.",
+          false,
+        );
+        filteredStatus.focus();
+      }
+      return;
+    }
+
+    if (isRowPage()) {
+      state.shouldRestoreFocus = false;
+      state.dialog.close();
+      location.reload();
+      return;
+    }
+
+    var updatedRow = await fetchUpdatedRowElement(state);
+    var focusTarget = null;
+    if (updatedRow && state.currentRow && document.contains(state.currentRow)) {
+      var importedRow = document.importNode(updatedRow, true);
+      state.currentRow.replaceWith(importedRow);
+      showRowMutationStatus(
+        state.manager,
+        state.currentPkPath
+          ? "Updated row " + state.currentPkPath + "."
+          : "Updated row.",
+        false,
+      );
+      focusTarget =
+        importedRow.querySelector('button[data-row-action="edit"]') || importedRow;
+    } else if (state.currentRow && document.contains(state.currentRow)) {
+      focusTarget =
+        nextRowActionFocusTarget(state.currentRow, "edit") ||
+        ensureRowMutationStatus(state.manager);
+      state.currentRow.remove();
+      showRowMutationStatus(
+        state.manager,
+        state.currentPkPath
+          ? "Updated row " +
+              state.currentPkPath +
+              ". It no longer matches the current filters."
+          : "Updated row. It no longer matches the current filters.",
+        false,
+      );
+    }
+
+    state.shouldRestoreFocus = false;
+    state.dialog.close();
+    if (focusTarget && document.contains(focusTarget)) {
+      focusTarget.focus();
+    }
+  } catch (error) {
+    setRowEditDialogSaving(state, false);
+    showRowEditDialogError(state, error.message || "Could not save row");
+  }
+}
+
+function renderRowEditFields(state, data) {
+  var row = data.rows && data.rows.length ? data.rows[0] : null;
+  var columns = data.columns || (row ? Object.keys(row) : []);
+  var primaryKeys = data.primary_keys || [];
+  var columnTypes = data.column_types || {};
+
+  destroyRowEditFields(state);
+  columns.forEach(function (column, index) {
+    state.fields.appendChild(
+      createRowEditField(
+        column,
+        row ? row[column] : null,
+        primaryKeys.indexOf(column) !== -1,
+        columnTypes[column],
+        index,
+        {
+          autocompleteUrl: foreignKeyAutocompleteUrl(column),
+          dialog: state.dialog,
+          form: state.form,
+          manager: state.manager,
+          mode: state.mode,
+          primaryKeyReadonly: true,
+        },
+      ),
+    );
+  });
+
+  state.hasLoaded = true;
+  updateRowEditDialogButtons(state);
+  if (!focusFirstRowEditControl(state, { skipReadonly: true })) {
+    focusFirstRowEditControl(state) || state.cancelButton.focus();
+  }
+}
+
+function renderRowInsertFields(state, data) {
+  var columns = data.columns || [];
+
+  destroyRowEditFields(state);
+  columns.forEach(function (column, index) {
+    state.fields.appendChild(
+      createRowEditField(
+        column.name,
+        "",
+        !!column.is_pk,
+        column.column_type,
+        index,
+        {
+          autocompleteUrl: foreignKeyAutocompleteUrl(column.name),
+          dialog: state.dialog,
+          form: state.form,
+          defaultExpression: column.default,
+          manager: state.manager,
+          mode: state.mode,
+          notnull: column.notnull,
+          primaryKeyReadonly: false,
+          sqliteType: column.sqlite_type,
+          useSqliteDefault: column.default !== null,
+          valueKind: column.value_kind,
+        },
+      ),
+    );
+  });
+
+  if (!columns.length) {
+    var emptyMessage = document.createElement("p");
+    emptyMessage.className = "row-edit-empty";
+    emptyMessage.textContent = "This row will use the table defaults.";
+    state.fields.appendChild(emptyMessage);
+  }
+
+  state.hasLoaded = true;
+  updateRowEditDialogButtons(state);
+  var firstDefaultButton = state.fields.querySelector(".row-edit-default-set-value");
+  if (firstDefaultButton) {
+    firstDefaultButton.focus();
+  } else {
+    focusFirstRowEditControl(state, { skipReadonly: true }) ||
+      state.saveButton.focus();
+  }
+}
+
+function setRowDialogTitle(title, text, codeText, labelText) {
+  title.textContent = "";
+  var action = document.createElement("span");
+  action.className = "row-dialog-action";
+  action.textContent = text;
+  title.appendChild(action);
+  if (!codeText) {
+    return;
+  }
+  title.appendChild(document.createTextNode(" "));
+  var code = document.createElement("code");
+  code.textContent = codeText;
+  title.appendChild(code);
+  if (labelText && labelText !== codeText) {
+    title.appendChild(document.createTextNode(" "));
+    var label = document.createElement("span");
+    label.className = "row-dialog-label";
+    label.textContent = labelText;
+    title.appendChild(label);
+  }
+}
+
+function ensureRowEditDialog(manager) {
+  if (rowEditDialogState) {
+    return rowEditDialogState;
+  }
+  if (!window.HTMLDialogElement) {
+    return null;
+  }
+
+  var dialog = document.createElement("dialog");
+  dialog.id = ROW_EDIT_DIALOG_ID;
+  dialog.className = "row-edit-dialog";
+  dialog.setAttribute("aria-labelledby", "row-edit-title");
+  dialog.innerHTML = `
+    <div class="modal-header">
+      <span class="modal-title" id="row-edit-title">Edit row</span>
+    </div>
+    <form class="row-edit-form" method="post">
+      <p class="row-edit-summary" id="row-edit-summary" hidden></p>
+      <p class="row-edit-loading" role="status" aria-live="polite">Loading row...</p>
+      <p class="row-edit-error" role="alert" tabindex="-1" hidden></p>
+      <div class="row-edit-fields"></div>
+      <div class="modal-footer">
+        <button type="button" class="btn btn-ghost row-edit-cancel">Cancel</button>
+        <button type="submit" class="btn btn-primary row-edit-save" disabled>Save</button>
+      </div>
+    </form>
+  `;
+  document.body.appendChild(dialog);
+
+  rowEditDialogState = {
+    dialog: dialog,
+    form: dialog.querySelector(".row-edit-form"),
+    title: dialog.querySelector(".modal-title"),
+    summary: dialog.querySelector(".row-edit-summary"),
+    loading: dialog.querySelector(".row-edit-loading"),
+    error: dialog.querySelector(".row-edit-error"),
+    fields: dialog.querySelector(".row-edit-fields"),
+    cancelButton: dialog.querySelector(".row-edit-cancel"),
+    saveButton: dialog.querySelector(".row-edit-save"),
+    currentButton: null,
+    currentRow: null,
+    currentRowId: null,
+    currentPkPath: null,
+    currentInsertUrl: null,
+    currentUpdateUrl: null,
+    currentFragmentUrl: null,
+    mode: "edit",
+    loadId: 0,
+    manager: manager,
+    isLoading: false,
+    isSaving: false,
+    hasLoaded: false,
+    shouldRestoreFocus: true,
+  };
+
+  rowEditDialogState.form.addEventListener("submit", function (ev) {
+    ev.preventDefault();
+    saveRowEditDialog(rowEditDialogState);
+  });
+
+  rowEditDialogState.cancelButton.addEventListener("click", function () {
+    if (!rowEditDialogState.isSaving) {
+      rowEditDialogState.shouldRestoreFocus = true;
+      dialog.close();
+    }
+  });
+
+  dialog.addEventListener("click", function (ev) {
+    if (ev.target === dialog) {
+      closeRowEditDialogIfConfirmed(rowEditDialogState);
+    }
+  });
+
+  dialog.addEventListener("keydown", function (ev) {
+    if (ev.key !== "Escape") {
+      return;
+    }
+    ev.preventDefault();
+    closeRowEditDialogIfConfirmed(rowEditDialogState);
+  });
+
+  dialog.addEventListener("cancel", function (ev) {
+    if (
+      rowEditDialogState.isSaving ||
+      !confirmDiscardRowEditChanges(rowEditDialogState)
+    ) {
+      ev.preventDefault();
+    } else {
+      rowEditDialogState.shouldRestoreFocus = true;
+    }
+  });
+
+  dialog.addEventListener("close", function () {
+    var state = rowEditDialogState;
+    state.loadId += 1;
+    clearRowEditDialogError(state);
+    state.hasLoaded = false;
+    destroyRowEditFields(state);
+    setRowEditDialogLoading(state, false);
+    setRowEditDialogSaving(state, false);
+    if (
+      state.shouldRestoreFocus &&
+      state.currentButton &&
+      document.contains(state.currentButton)
+    ) {
+      state.currentButton.focus();
+    }
+  });
+
+  return rowEditDialogState;
+}
+
+async function openRowEditDialog(button, manager) {
+  var row = rowElementForActionButton(button);
+  if (!row || !row.getAttribute("data-row")) {
+    return;
+  }
+  var state = ensureRowEditDialog(manager);
+  if (!state) {
+    return;
+  }
+
+  state.manager = manager;
+  state.mode = "edit";
+  state.currentButton = button;
+  state.currentRow = row;
+  state.currentRowId = row.getAttribute("data-row") || "";
+  state.currentPkPath = rowDisplayLabel(row);
+  state.currentInsertUrl = null;
+  state.currentUpdateUrl = rowUpdateUrl(row);
+  state.currentFragmentUrl = rowFragmentUrl(row);
+  if (state.currentUpdateUrl) {
+    state.form.action = new URL(state.currentUpdateUrl, location.href).toString();
+  } else {
+    state.form.removeAttribute("action");
+  }
+  state.shouldRestoreFocus = true;
+  state.hasLoaded = false;
+  state.loadId += 1;
+  var loadId = state.loadId;
+
+  clearRowEditDialogError(state);
+  setRowEditDialogLoading(state, true);
+  destroyRowEditFields(state);
+  state.dialog.removeAttribute("aria-describedby");
+  setRowDialogTitle(
+    state.title,
+    "Edit row",
+    state.currentPkPath || "this row",
+    rowTitleLabel(row),
+  );
+  state.summary.hidden = true;
+  state.summary.textContent = "";
+
+  if (!state.dialog.open) {
+    state.dialog.showModal();
+  }
+  state.cancelButton.focus();
+
+  try {
+    var response = await fetch(rowJsonUrl(row), {
+      headers: {
+        Accept: "application/json",
+      },
+    });
+    var data = await response.json();
+    if (loadId !== state.loadId) {
+      return;
+    }
+    if (!response.ok || data.ok === false) {
+      throw rowMutationRequestError(response, data);
+    }
+    setRowEditDialogLoading(state, false);
+    renderRowEditFields(state, data);
+  } catch (error) {
+    if (loadId !== state.loadId) {
+      return;
+    }
+    setRowEditDialogLoading(state, false);
+    showRowEditDialogError(state, error.message || "Could not load row");
+    state.cancelButton.focus();
+  }
+}
+
+function openRowInsertDialog(button, manager) {
+  var insertData = tableInsertData();
+  if (!insertData) {
+    return;
+  }
+  var state = ensureRowEditDialog(manager);
+  if (!state) {
+    return;
+  }
+
+  state.manager = manager;
+  state.mode = "insert";
+  state.currentButton = button;
+  state.currentRow = null;
+  state.currentRowId = null;
+  state.currentPkPath = null;
+  state.currentInsertUrl = tableInsertUrl();
+  state.currentUpdateUrl = null;
+  state.currentFragmentUrl = null;
+  state.shouldRestoreFocus = true;
+  state.hasLoaded = false;
+  state.loadId += 1;
+
+  if (state.currentInsertUrl) {
+    state.form.action = new URL(state.currentInsertUrl, location.href).toString();
+  } else {
+    state.form.removeAttribute("action");
+  }
+
+  clearRowEditDialogError(state);
+  setRowEditDialogLoading(state, false);
+  destroyRowEditFields(state);
+  state.dialog.removeAttribute("aria-describedby");
+  setRowDialogTitle(
+    state.title,
+    insertData.tableName ? "Insert row into " + insertData.tableName : "Insert row",
+  );
+  state.summary.hidden = true;
+  state.summary.textContent = "";
+
+  if (!state.dialog.open) {
+    state.dialog.showModal();
+  }
+  renderRowInsertFields(state, insertData);
+}
+
+function initRowEditActions(manager) {
+  if (!window.fetch || !window.HTMLDialogElement) {
+    return;
+  }
+  document.addEventListener("click", function (ev) {
+    var button = ev.target.closest('button[data-row-action="edit"]');
+    if (!button) {
+      return;
+    }
+    ev.preventDefault();
+    openRowEditDialog(button, manager);
+  });
+}
+
+function initRowInsertActions(manager) {
+  if (!window.fetch || !window.HTMLDialogElement || !tableInsertData()) {
+    return;
+  }
+  document.addEventListener("click", function (ev) {
+    var button = ev.target.closest('button[data-table-action="insert-row"]');
+    if (!button) {
+      return;
+    }
+    ev.preventDefault();
+    openRowInsertDialog(button, manager);
+  });
+}
+
+document.addEventListener("datasette_init", function (evt) {
+  const { detail: manager } = evt;
+
+  registerBuiltinColumnFieldPlugins(manager);
+  initRowInsertActions(manager);
+  initRowEditActions(manager);
+  initRowDeleteActions(manager);
+});
diff --git a/datasette/static/table.js b/datasette/static/table.js
index 291afc95..f160f3f3 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -12,11 +12,6 @@ var DROPDOWN_ICON_SVG = `<svg xmlns="http://www.w3.org/2000/svg" width="14" heig
 
 var SET_COLUMN_TYPE_DIALOG_ID = "set-column-type-dialog";
 var setColumnTypeDialogState = null;
-var ROW_DELETE_DIALOG_ID = "row-delete-dialog";
-var rowDeleteDialogState = null;
-var ROW_EDIT_DIALOG_ID = "row-edit-dialog";
-var rowEditDialogState = null;
-
 function getParams() {
   return new URLSearchParams(location.search);
 }
@@ -359,1935 +354,6 @@ function openSetColumnTypeDialog(th) {
   }
 }
 
-function ensureRowMutationStatus(manager) {
-  var status = document.querySelector(".row-mutation-status");
-  if (status) {
-    return status;
-  }
-
-  status = document.createElement("p");
-  status.className = "row-mutation-status";
-  status.hidden = true;
-  status.setAttribute("role", "status");
-  status.setAttribute("aria-live", "polite");
-  status.setAttribute("tabindex", "-1");
-
-  var tableWrapper = document.querySelector(manager.selectors.tableWrapper);
-  if (tableWrapper && tableWrapper.parentNode) {
-    tableWrapper.parentNode.insertBefore(status, tableWrapper);
-  } else {
-    document.body.appendChild(status);
-  }
-  return status;
-}
-
-function showRowMutationStatus(manager, message, isError) {
-  var status = ensureRowMutationStatus(manager);
-  status.hidden = false;
-  status.classList.toggle("row-mutation-status-error", !!isError);
-  status.textContent = message;
-  return status;
-}
-
-function hideRowMutationStatus() {
-  var status = document.querySelector(".row-mutation-status");
-  if (!status) {
-    return;
-  }
-  status.hidden = true;
-  status.classList.remove("row-mutation-status-error");
-  status.textContent = "";
-}
-
-function setRowDeleteDialogBusy(state, isBusy) {
-  state.isBusy = isBusy;
-  state.confirmButton.disabled = isBusy;
-  state.cancelButton.disabled = isBusy;
-  state.confirmButton.textContent = isBusy ? "Deleting..." : "Delete row";
-}
-
-function clearRowDeleteDialogError(state) {
-  state.error.hidden = true;
-  state.error.textContent = "";
-}
-
-function showRowDeleteDialogError(state, message) {
-  state.error.hidden = false;
-  state.error.textContent = message;
-}
-
-function rowMutationRequestError(response, data) {
-  if (data && data.errors) {
-    return new Error(data.errors.join(" "));
-  }
-  if (data && data.error) {
-    return new Error(data.error);
-  }
-  if (data && data.title) {
-    return new Error(data.title);
-  }
-  return new Error("Request failed with HTTP " + response.status);
-}
-
-function tildeDecode(value) {
-  if (!value) {
-    return "";
-  }
-  var placeholder = "__datasette_percent_placeholder__";
-  try {
-    return decodeURIComponent(
-      value
-        .replace(/%/g, placeholder)
-        .replace(/~/g, "%")
-        .replace(/\+/g, " "),
-    ).replace(new RegExp(placeholder, "g"), "%");
-  } catch (_error) {
-    return value;
-  }
-}
-
-function tildeEncode(value) {
-  var bytes = new TextEncoder().encode(String(value));
-  var encoded = "";
-  bytes.forEach(function (byte) {
-    var isSafe =
-      (byte >= 65 && byte <= 90) ||
-      (byte >= 97 && byte <= 122) ||
-      (byte >= 48 && byte <= 57) ||
-      byte === 95 ||
-      byte === 45;
-    if (isSafe) {
-      encoded += String.fromCharCode(byte);
-    } else if (byte === 32) {
-      encoded += "+";
-    } else {
-      encoded += "~" + byte.toString(16).toUpperCase().padStart(2, "0");
-    }
-  });
-  return encoded;
-}
-
-function rowDisplayLabel(row) {
-  return tildeDecode(row.getAttribute("data-row") || "");
-}
-
-function rowTitleLabel(row) {
-  return row.getAttribute("data-row-label") || "";
-}
-
-function insertedRowStatusMessage(rowId, rowLabel) {
-  var message = "Inserted row " + rowId;
-  if (rowLabel && rowLabel !== rowId) {
-    message += " (" + rowLabel + ")";
-  }
-  return message + ".";
-}
-
-function tableBaseUrl() {
-  var tableUrl =
-    window._datasetteTableData && window._datasetteTableData.tableUrl;
-  var url = new URL(tableUrl || location.href, location.href);
-  url.hash = "";
-  url.search = "";
-  return url;
-}
-
-function tablePageData() {
-  return window._datasetteTableData || {};
-}
-
-function tableInsertData() {
-  return tablePageData().insertRow;
-}
-
-function tableForeignKeys() {
-  return tablePageData().foreignKeys || {};
-}
-
-function foreignKeyAutocompleteUrl(column) {
-  return tableForeignKeys()[column] || null;
-}
-
-function autocompleteRowPk(row) {
-  var pks = (row && row.pks) || {};
-  var keys = Object.keys(pks);
-  if (keys.length !== 1) {
-    return null;
-  }
-  return pks[keys[0]];
-}
-
-function foreignKeyRowUrl(autocompleteUrl, pk) {
-  var url = new URL(autocompleteUrl, location.href);
-  if (!/\/-\/autocomplete\/?$/.test(url.pathname)) {
-    return null;
-  }
-  url.pathname =
-    url.pathname.replace(/\/-\/autocomplete\/?$/, "") + "/" + tildeEncode(pk);
-  url.search = "";
-  url.hash = "";
-  return url.toString();
-}
-
-function foreignKeyLabelText(row) {
-  var pk = autocompleteRowPk(row);
-  var label = row && row.label;
-  if (
-    label !== null &&
-    typeof label !== "undefined" &&
-    String(label) !== String(pk)
-  ) {
-    return String(label);
-  }
-  return "View row";
-}
-
-function rowEditMetaTextWithoutCurrentValue(meta) {
-  return (meta.dataset.baseMeta || "")
-    .split(" · ")
-    .filter(function (part) {
-      return part !== "Current value: NULL";
-    })
-    .join(" · ");
-}
-
-function updateRowEditForeignKeySeparator(meta) {
-  var separator = meta.querySelector(".row-edit-fk-separator");
-  if (!separator) {
-    return;
-  }
-  var baseMeta = meta.querySelector(".row-edit-base-meta");
-  var hasBaseMeta = !!(baseMeta && baseMeta.textContent);
-  separator.textContent = hasBaseMeta ? " · " : "";
-  separator.hidden = !hasBaseMeta;
-}
-
-function updateRowEditFieldMetaHidden(meta) {
-  var baseMeta = meta.querySelector(".row-edit-base-meta");
-  var hasBaseMeta = !!(baseMeta && baseMeta.textContent);
-  var foreignKeyLinkWrap = meta.querySelector(".row-edit-fk-link-wrap");
-  var hasForeignKeyLink = foreignKeyLinkWrap && !foreignKeyLinkWrap.hidden;
-  meta.hidden =
-    meta.dataset.reserveSpace !== "1" && !hasBaseMeta && !hasForeignKeyLink;
-}
-
-function setRowEditBaseMetaText(meta, text) {
-  var baseMeta = meta.querySelector(".row-edit-base-meta");
-  if (!baseMeta) {
-    return;
-  }
-  baseMeta.textContent = text || "";
-  updateRowEditForeignKeySeparator(meta);
-  updateRowEditFieldMetaHidden(meta);
-}
-
-function setForeignKeyMetaLink(meta, autocompleteUrl, row) {
-  var wrap = meta.querySelector(".row-edit-fk-link-wrap");
-  if (!wrap) {
-    return;
-  }
-  var pkSpan = wrap.querySelector(".row-edit-fk-pk");
-  var link = wrap.querySelector("a");
-  var pk = autocompleteRowPk(row);
-  var url =
-    pk === null || typeof pk === "undefined"
-      ? null
-      : foreignKeyRowUrl(autocompleteUrl, pk);
-  if (!url) {
-    wrap.hidden = true;
-    pkSpan.textContent = "";
-    link.removeAttribute("href");
-    link.textContent = "";
-    link.removeAttribute("aria-label");
-    setRowEditBaseMetaText(meta, meta.dataset.baseMeta || "");
-    updateRowEditFieldMetaHidden(meta);
-    return;
-  }
-  setRowEditBaseMetaText(meta, rowEditMetaTextWithoutCurrentValue(meta));
-  var pkText = String(pk);
-  var linkText = foreignKeyLabelText(row);
-  pkSpan.textContent = pkText;
-  link.href = url;
-  link.textContent = linkText;
-  link.setAttribute(
-    "aria-label",
-    "Open referenced row " + pkText + " " + linkText + " in a new tab",
-  );
-  wrap.hidden = false;
-  updateRowEditFieldMetaHidden(meta);
-}
-
-async function resolveForeignKeyMetaLink(control, autocompleteUrl, meta) {
-  var value = control.value.trim();
-  if (!value) {
-    setForeignKeyMetaLink(meta, autocompleteUrl, null);
-    return;
-  }
-
-  var url = new URL(autocompleteUrl, location.href);
-  url.searchParams.set("q", value);
-  try {
-    var response = await fetch(url.toString(), {
-      headers: {
-        Accept: "application/json",
-      },
-    });
-    if (!response.ok) {
-      throw new Error("HTTP " + response.status);
-    }
-    var data = await response.json();
-    if (control.value.trim() !== value) {
-      return;
-    }
-    var rows = (data && data.rows) || [];
-    var row = rows.find(function (candidate) {
-      var pk = autocompleteRowPk(candidate);
-      return pk !== null && typeof pk !== "undefined" && String(pk) === value;
-    });
-    setForeignKeyMetaLink(meta, autocompleteUrl, row || null);
-  } catch (_error) {
-    if (control.value.trim() === value) {
-      setForeignKeyMetaLink(meta, autocompleteUrl, null);
-    }
-  }
-}
-
-function tableInsertUrl() {
-  var data = tableInsertData();
-  if (data && data.path) {
-    return new URL(data.path, location.href).toString();
-  }
-  var url = tableBaseUrl();
-  url.pathname = url.pathname.replace(/\/$/, "") + "/-/insert";
-  return url.toString();
-}
-
-function rowResourceUrl(row) {
-  var rowId = row.getAttribute("data-row");
-  if (!rowId) {
-    return null;
-  }
-  var url = tableBaseUrl();
-  url.pathname = url.pathname.replace(/\/$/, "") + "/" + rowId;
-  return url;
-}
-
-function rowJsonUrl(row) {
-  var url = rowResourceUrl(row);
-  if (!url) {
-    return "";
-  }
-  url.pathname = url.pathname + ".json";
-  url.searchParams.set("_extra", "columns,column_types");
-  return url.toString();
-}
-
-function rowDeleteUrl(row) {
-  var url = rowResourceUrl(row);
-  if (!url) {
-    return "";
-  }
-  url.pathname = url.pathname.replace(/\/$/, "") + "/-/delete";
-  return url.toString();
-}
-
-function rowUpdateUrl(row) {
-  var url = rowResourceUrl(row);
-  if (!url) {
-    return "";
-  }
-  url.pathname = url.pathname.replace(/\/$/, "") + "/-/update";
-  return url.toString();
-}
-
-function rowFragmentUrl(row) {
-  var rowId = row.getAttribute("data-row");
-  return rowFragmentUrlById(rowId);
-}
-
-function rowFragmentUrlById(rowId) {
-  if (!rowId) {
-    return "";
-  }
-  var url = tableBaseUrl();
-  url.search = new URL(location.href).search;
-  url.pathname = url.pathname.replace(/\/$/, "") + "/-/fragment";
-  url.searchParams.delete("_next");
-  url.searchParams.set("_row", rowId);
-  url.searchParams.set("_nocount", "1");
-  url.searchParams.set("_nofacet", "1");
-  url.searchParams.set("_nosuggest", "1");
-  return url.toString();
-}
-
-function nextRowActionFocusTarget(row, action) {
-  var selector = 'button[data-row-action="' + action + '"]:not([disabled])';
-  var sibling = row.nextElementSibling;
-  while (sibling) {
-    var nextButton = sibling.querySelector(selector);
-    if (nextButton) {
-      return nextButton;
-    }
-    sibling = sibling.nextElementSibling;
-  }
-
-  sibling = row.previousElementSibling;
-  while (sibling) {
-    var previousButton = sibling.querySelector(selector);
-    if (previousButton) {
-      return previousButton;
-    }
-    sibling = sibling.previousElementSibling;
-  }
-
-  return null;
-}
-
-function nextRowDeleteFocusTarget(row, manager) {
-  return nextRowActionFocusTarget(row, "delete") || ensureRowMutationStatus(manager);
-}
-
-function ensureRowDeleteDialog(manager) {
-  if (rowDeleteDialogState) {
-    return rowDeleteDialogState;
-  }
-  if (!window.HTMLDialogElement) {
-    return null;
-  }
-
-  var dialog = document.createElement("dialog");
-  dialog.id = ROW_DELETE_DIALOG_ID;
-  dialog.className = "row-delete-dialog";
-  dialog.setAttribute("aria-labelledby", "row-delete-title");
-  dialog.setAttribute("aria-describedby", "row-delete-message");
-  dialog.innerHTML = `
-    <div class="modal-header">
-      <span class="modal-title" id="row-delete-title">Delete row</span>
-    </div>
-    <p class="row-delete-message" id="row-delete-message">Delete row <span class="row-delete-id"></span>?</p>
-    <p class="row-delete-error" role="alert" hidden></p>
-    <div class="modal-footer">
-      <button type="button" class="btn btn-ghost row-delete-cancel">Cancel</button>
-      <button type="button" class="btn btn-primary row-delete-confirm">Delete row</button>
-    </div>
-  `;
-  document.body.appendChild(dialog);
-
-  rowDeleteDialogState = {
-    dialog: dialog,
-    title: dialog.querySelector(".modal-title"),
-    message: dialog.querySelector(".row-delete-message"),
-    rowId: dialog.querySelector(".row-delete-id"),
-    error: dialog.querySelector(".row-delete-error"),
-    cancelButton: dialog.querySelector(".row-delete-cancel"),
-    confirmButton: dialog.querySelector(".row-delete-confirm"),
-    currentRow: null,
-    currentDeleteUrl: null,
-    currentPkPath: null,
-    manager: manager,
-    isBusy: false,
-    shouldRestoreFocus: true,
-  };
-
-  rowDeleteDialogState.cancelButton.addEventListener("click", function () {
-    if (!rowDeleteDialogState.isBusy) {
-      rowDeleteDialogState.shouldRestoreFocus = true;
-      dialog.close();
-    }
-  });
-
-  dialog.addEventListener("click", function (ev) {
-    if (ev.target === dialog && !rowDeleteDialogState.isBusy) {
-      rowDeleteDialogState.shouldRestoreFocus = true;
-      dialog.close();
-    }
-  });
-
-  dialog.addEventListener("keydown", function (ev) {
-    if (
-      ev.key === "Enter" &&
-      document.activeElement === rowDeleteDialogState.confirmButton
-    ) {
-      ev.preventDefault();
-      if (!rowDeleteDialogState.isBusy) {
-        rowDeleteDialogState.confirmButton.click();
-      }
-      return;
-    }
-    if (ev.key !== "Escape") {
-      return;
-    }
-    if (rowDeleteDialogState.isBusy) {
-      ev.preventDefault();
-      return;
-    }
-    ev.preventDefault();
-    rowDeleteDialogState.shouldRestoreFocus = true;
-    dialog.close();
-  });
-
-  dialog.addEventListener("cancel", function (ev) {
-    if (rowDeleteDialogState.isBusy) {
-      ev.preventDefault();
-    } else {
-      rowDeleteDialogState.shouldRestoreFocus = true;
-    }
-  });
-
-  dialog.addEventListener("close", function () {
-    var state = rowDeleteDialogState;
-    clearRowDeleteDialogError(state);
-    setRowDeleteDialogBusy(state, false);
-    if (
-      state.shouldRestoreFocus &&
-      state.currentButton &&
-      document.contains(state.currentButton)
-    ) {
-      state.currentButton.focus();
-    }
-  });
-
-  rowDeleteDialogState.confirmButton.addEventListener("click", async function () {
-    var state = rowDeleteDialogState;
-    clearRowDeleteDialogError(state);
-    setRowDeleteDialogBusy(state, true);
-
-    try {
-      var response = await fetch(state.currentDeleteUrl, {
-        method: "POST",
-        headers: {
-          Accept: "application/json",
-        },
-      });
-      var data = null;
-      try {
-        data = await response.json();
-      } catch (_error) {
-        data = null;
-      }
-      if (!response.ok || (data && data.ok === false)) {
-        throw rowMutationRequestError(response, data);
-      }
-
-      var focusTarget = nextRowDeleteFocusTarget(state.currentRow, state.manager);
-      var statusMessage = state.currentPkPath
-        ? "Deleted row " + state.currentPkPath + "."
-        : "Deleted row.";
-      state.shouldRestoreFocus = false;
-      state.dialog.close();
-      state.currentRow.remove();
-      showRowMutationStatus(state.manager, statusMessage, false);
-      if (focusTarget && document.contains(focusTarget)) {
-        focusTarget.focus();
-      } else {
-        ensureRowMutationStatus(state.manager).focus();
-      }
-    } catch (error) {
-      setRowDeleteDialogBusy(state, false);
-      showRowDeleteDialogError(state, error.message || "Delete failed");
-    }
-  });
-
-  return rowDeleteDialogState;
-}
-
-function openRowDeleteDialog(button, manager) {
-  var row = button.closest("[data-row]");
-  if (!row || !row.getAttribute("data-row")) {
-    return;
-  }
-  var state = ensureRowDeleteDialog(manager);
-  if (!state) {
-    return;
-  }
-
-  state.manager = manager;
-  state.currentButton = button;
-  state.currentRow = row;
-  state.currentDeleteUrl = rowDeleteUrl(row);
-  state.currentPkPath = rowDisplayLabel(row);
-  state.shouldRestoreFocus = true;
-
-  clearRowDeleteDialogError(state);
-  setRowDeleteDialogBusy(state, false);
-  setRowDialogTitle(
-    state.title,
-    "Delete row",
-    state.currentPkPath || "this row",
-    rowTitleLabel(row),
-  );
-  state.rowId.textContent = state.currentPkPath || "this row";
-
-  if (!state.dialog.open) {
-    state.dialog.showModal();
-  }
-  state.confirmButton.focus();
-}
-
-function initRowDeleteActions(manager) {
-  if (!window.fetch || !window.HTMLDialogElement) {
-    return;
-  }
-  document.addEventListener("click", function (ev) {
-    var button = ev.target.closest('button[data-row-action="delete"]');
-    if (!button) {
-      return;
-    }
-    ev.preventDefault();
-    openRowDeleteDialog(button, manager);
-  });
-}
-
-function valueToEditText(value) {
-  if (value === null || typeof value === "undefined") {
-    return "";
-  }
-  if (typeof value === "object") {
-    return JSON.stringify(value, null, 2);
-  }
-  return String(value);
-}
-
-function shouldUseTextarea(value, columnType) {
-  if (columnType && columnType.type === "textarea") {
-    return true;
-  }
-  if (value && typeof value === "object") {
-    return true;
-  }
-  var text = valueToEditText(value);
-  return text.length > 80 || /[\r\n]/.test(text);
-}
-
-function rowEditValueKind(value) {
-  if (value === null || typeof value === "undefined") {
-    return "null";
-  }
-  if (typeof value === "number") {
-    return "number";
-  }
-  if (typeof value === "boolean") {
-    return "boolean";
-  }
-  return "string";
-}
-
-function rowEditControlElement(control, autocompleteUrl) {
-  if (!autocompleteUrl || control.nodeName !== "INPUT") {
-    return control;
-  }
-  var autocomplete = document.createElement("datasette-autocomplete");
-  autocomplete.setAttribute("src", autocompleteUrl);
-  autocomplete.setAttribute("suggest-on-focus", "");
-  autocomplete.appendChild(control);
-  return autocomplete;
-}
-
-function columnTypeForContext(columnType) {
-  if (!columnType) {
-    return null;
-  }
-  return {
-    type: columnType.type,
-    config: columnType.config || {},
-  };
-}
-
-function defaultExpressionForContext(expression) {
-  if (expression === null || typeof expression === "undefined") {
-    return null;
-  }
-  return expression;
-}
-
-function columnFormControlContext(column, isPk, columnType, options) {
-  var pageData = tablePageData();
-  var defaultExpression = defaultExpressionForContext(options.defaultExpression);
-  return {
-    mode: options.mode || "edit",
-    database: pageData.database || null,
-    table: pageData.table || (tableInsertData() && tableInsertData().tableName) || null,
-    tableUrl: pageData.tableUrl || null,
-    column: column,
-    columnType: columnTypeForContext(columnType),
-    sqliteType: options.sqliteType || null,
-    notNull: !!options.notnull,
-    isPk: !!isPk,
-    defaultExpression: defaultExpression,
-    form: options.form || null,
-    dialog: options.dialog || null,
-  };
-}
-
-function makeColumnField(manager, context) {
-  if (!manager || !manager.makeColumnField) {
-    return null;
-  }
-  return manager.makeColumnField(context);
-}
-
-function createColumnFieldApi(options) {
-  var control = options.control;
-  var context = options.context;
-  var field = {
-    context: context,
-    id: options.id,
-    labelId: options.labelId,
-    descriptionId: options.descriptionId,
-    root: null,
-    form: options.form || null,
-    dialog: options.dialog || null,
-    input: control,
-    control: control,
-    meta: options.meta || null,
-    validationMessageElement: null,
-    getValue: function () {
-      return valueFromRowEditControl(control);
-    },
-    setValue: function (value) {
-      if (
-        value !== null &&
-        typeof value !== "undefined" &&
-        typeof value === "object"
-      ) {
-        throw new TypeError(
-          "field.setValue() accepts strings, numbers, booleans or null; serialize objects before setting the field value",
-        );
-      }
-      field.stopUsingSqliteDefault();
-      control.value = valueToEditText(value);
-      control.dataset.currentValueKind = rowEditValueKind(value);
-    },
-    getInitialValue: function () {
-      return initialValueFromRowEditControl(control);
-    },
-    hasChanged: function () {
-      return rowEditControlHasChanged(control);
-    },
-    clearValue: function () {
-      field.setValue(null);
-    },
-    isUsingSqliteDefault: function () {
-      return control.dataset.useSqliteDefault === "1";
-    },
-    useSqliteDefault: function () {
-      if (
-        context.defaultExpression === null ||
-        typeof context.defaultExpression === "undefined"
-      ) {
-        return;
-      }
-      control.dataset.useSqliteDefault = "1";
-      control.disabled = true;
-      control.value = "";
-      control.dataset.currentValueKind = "null";
-      field.syncSqliteDefaultUi();
-    },
-    stopUsingSqliteDefault: function () {
-      if (control.dataset.useSqliteDefault !== "1") {
-        return;
-      }
-      control.dataset.useSqliteDefault = "0";
-      control.disabled = false;
-      field.syncSqliteDefaultUi();
-    },
-    syncSqliteDefaultUi: function () {},
-    markClean: function () {
-      markRowEditControlClean(control);
-    },
-    setValidity: function (message) {
-      message = message || "";
-      control.setCustomValidity(message);
-      if (message) {
-        control.setAttribute("aria-invalid", "true");
-      } else {
-        control.removeAttribute("aria-invalid");
-      }
-      var validationMessage = ensureColumnFieldValidationMessage(field);
-      if (validationMessage) {
-        validationMessage.textContent = message;
-        validationMessage.hidden = !message;
-      }
-    },
-    clearValidity: function () {
-      field.setValidity("");
-    },
-  };
-  field.markClean();
-  return field;
-}
-
-function ensureColumnFieldValidationMessage(field) {
-  if (field.validationMessageElement) {
-    return field.validationMessageElement;
-  }
-  if (!field.meta) {
-    return null;
-  }
-  var validationMessage = document.createElement("span");
-  validationMessage.id = field.id + "-validation-error";
-  validationMessage.className = "row-edit-field-validation-error";
-  validationMessage.hidden = true;
-  validationMessage.setAttribute("role", "alert");
-  field.meta.appendChild(validationMessage);
-  field.validationMessageElement = validationMessage;
-  return validationMessage;
-}
-
-function renderColumnField(pluginControl, fieldApi) {
-  if (!pluginControl || !pluginControl.render) {
-    return null;
-  }
-  var pluginWrap = document.createElement("div");
-  pluginWrap.className = "row-edit-plugin-control";
-  pluginWrap.dataset.pluginName = pluginControl.pluginName || "";
-  pluginWrap.dataset.column = fieldApi.context.column;
-  if (fieldApi.context.columnType && fieldApi.context.columnType.type) {
-    pluginWrap.dataset.columnType = fieldApi.context.columnType.type;
-  }
-  fieldApi.root = pluginWrap;
-  try {
-    var rendered = pluginControl.render(fieldApi);
-    if (rendered && rendered.nodeType) {
-      pluginWrap.appendChild(rendered);
-    }
-  } catch (error) {
-    console.error("Error rendering column form control", error);
-    return null;
-  }
-  pluginWrap._datasetteColumnField = pluginControl;
-  pluginWrap._datasetteColumnFormField = fieldApi;
-  return pluginWrap;
-}
-
-function validateJsonColumnField(field) {
-  var value = field.input.value;
-  if (value.trim() === "") {
-    field.clearValidity();
-    return true;
-  }
-  try {
-    JSON.parse(value);
-    field.clearValidity();
-    return true;
-  } catch (error) {
-    field.setValidity(
-      "Invalid JSON" + (error && error.message ? ": " + error.message : ""),
-    );
-    return false;
-  }
-}
-
-function registerBuiltinColumnFieldPlugins(manager) {
-  if (!manager || !manager.registerPlugin) {
-    return;
-  }
-  manager.registerPlugin("datasette-json-column", {
-    version: "1.0",
-    makeColumnField: function (context) {
-      if (!context.columnType || context.columnType.type !== "json") {
-        return;
-      }
-      return {
-        useTextarea: true,
-        render: function (field) {
-          field.input.addEventListener("input", function () {
-            validateJsonColumnField(field);
-          });
-          field.input.addEventListener("change", function () {
-            validateJsonColumnField(field);
-          });
-          validateJsonColumnField(field);
-          return field.input;
-        },
-        focus: function (field) {
-          field.input.focus();
-        },
-      };
-    },
-  });
-}
-
-function focusRowEditPluginControl(field) {
-  var pluginWrap = field.querySelector(".row-edit-plugin-control");
-  if (!pluginWrap) {
-    return false;
-  }
-  var pluginControl = pluginWrap._datasetteColumnField;
-  var fieldApi = pluginWrap._datasetteColumnFormField;
-  if (pluginControl && pluginControl.focus) {
-    try {
-      pluginControl.focus(fieldApi);
-      return true;
-    } catch (error) {
-      console.error("Error focusing column form control", error);
-    }
-  }
-  return false;
-}
-
-function focusFirstRowEditControl(state, options) {
-  options = options || {};
-  var fields = state.fields.querySelectorAll(".row-edit-field");
-  for (var i = 0; i < fields.length; i += 1) {
-    var field = fields[i];
-    var control = field.querySelector(".row-edit-input");
-    if (!control) {
-      continue;
-    }
-    if (options.skipReadonly && (control.readOnly || control.disabled)) {
-      continue;
-    }
-    if (focusRowEditPluginControl(field)) {
-      return true;
-    }
-    control.focus();
-    return true;
-  }
-  return false;
-}
-
-function destroyRowEditFields(state) {
-  if (!state || !state.fields) {
-    return;
-  }
-  state.fields
-    .querySelectorAll(".row-edit-plugin-control")
-    .forEach(function (pluginWrap) {
-      var pluginControl = pluginWrap._datasetteColumnField;
-      var fieldApi = pluginWrap._datasetteColumnFormField;
-      if (pluginControl && pluginControl.destroy) {
-        try {
-          pluginControl.destroy(fieldApi);
-        } catch (error) {
-          console.error("Error destroying column form control", error);
-        }
-      }
-    });
-  state.fields.innerHTML = "";
-}
-
-function createRowEditField(column, value, isPk, columnType, index, options) {
-  options = options || {};
-  var field = document.createElement("div");
-  field.className = "row-edit-field";
-  var defaultExpression = defaultExpressionForContext(options.defaultExpression);
-  var hasDefaultExpression = defaultExpression !== null;
-  var useSqliteDefault = hasDefaultExpression && options.useSqliteDefault;
-
-  var fieldId = "row-edit-field-" + index;
-  var metaId = "row-edit-field-meta-" + index;
-  var labelId = "row-edit-field-label-" + index;
-  var label = document.createElement("label");
-  label.className = "row-edit-label";
-  label.id = labelId;
-  label.setAttribute("for", fieldId);
-  label.textContent = column;
-
-  var controlWrap = document.createElement("div");
-  controlWrap.className = "row-edit-control-wrap";
-
-  var context = columnFormControlContext(
-    column,
-    isPk,
-    columnType,
-    options,
-  );
-  var pluginControl = makeColumnField(options.manager, context);
-  var useTextarea =
-    (pluginControl && pluginControl.useTextarea === true) ||
-    shouldUseTextarea(value, columnType);
-  var control = useTextarea
-    ? document.createElement("textarea")
-    : document.createElement("input");
-  control.className = "row-edit-input";
-  control.id = fieldId;
-  control.name = column;
-  control.value = valueToEditText(value);
-  control.setAttribute("aria-describedby", metaId);
-  control.dataset.initialValue = valueToEditText(value);
-  control.dataset.initialValueKind =
-    options.valueKind || rowEditValueKind(value);
-  control.dataset.primaryKey = isPk ? "1" : "0";
-  control.dataset.currentValueKind = control.dataset.initialValueKind;
-  if (hasDefaultExpression) {
-    control.dataset.useSqliteDefault = useSqliteDefault ? "1" : "0";
-  }
-  if (useSqliteDefault) {
-    control.disabled = true;
-  }
-  if (options.omitIfBlank) {
-    control.dataset.omitIfBlank = "1";
-  }
-
-  if (control.nodeName === "TEXTAREA") {
-    control.rows = Math.min(8, Math.max(3, control.value.split("\n").length));
-  } else {
-    control.type = "text";
-  }
-
-  if (isPk && options.primaryKeyReadonly !== false) {
-    control.readOnly = true;
-  }
-
-  var meta = document.createElement("span");
-  meta.id = metaId;
-  meta.className = "row-edit-field-meta";
-  if (options.autocompleteUrl) {
-    meta.classList.add("row-edit-field-meta-autocomplete");
-    meta.dataset.reserveSpace = "1";
-  }
-  var metaParts = [];
-  if (isPk) {
-    metaParts.push("Primary key");
-  }
-  if (options.notnull) {
-    metaParts.push("Required");
-  }
-  if (hasDefaultExpression && !useSqliteDefault) {
-    metaParts.push("SQLite default: " + defaultExpression);
-  }
-  if (value === null) {
-    metaParts.push("Current value: NULL");
-    control.placeholder = "NULL";
-  }
-  if (columnType && columnType.type) {
-    metaParts.push("Custom type: " + columnType.type);
-  }
-  meta.dataset.baseMeta = metaParts.join(" · ");
-  var baseMeta = document.createElement("span");
-  baseMeta.className = "row-edit-base-meta";
-  baseMeta.textContent = meta.dataset.baseMeta;
-  meta.appendChild(baseMeta);
-  if (options.autocompleteUrl) {
-    var foreignKeyLinkWrap = document.createElement("span");
-    foreignKeyLinkWrap.className = "row-edit-fk-link-wrap";
-    foreignKeyLinkWrap.hidden = true;
-    var foreignKeySeparator = document.createElement("span");
-    foreignKeySeparator.className = "row-edit-fk-separator";
-    foreignKeySeparator.textContent = meta.dataset.baseMeta ? " · " : "";
-    foreignKeySeparator.hidden = !meta.dataset.baseMeta;
-    foreignKeyLinkWrap.appendChild(foreignKeySeparator);
-    var foreignKeyPk = document.createElement("span");
-    foreignKeyPk.className = "row-edit-fk-pk";
-    foreignKeyLinkWrap.appendChild(foreignKeyPk);
-    foreignKeyLinkWrap.appendChild(document.createTextNode(" "));
-    var foreignKeyLink = document.createElement("a");
-    foreignKeyLink.className = "row-edit-fk-link";
-    foreignKeyLink.target = "_blank";
-    foreignKeyLink.rel = "noopener noreferrer";
-    foreignKeyLinkWrap.appendChild(foreignKeyLink);
-    meta.appendChild(foreignKeyLinkWrap);
-    updateRowEditFieldMetaHidden(meta);
-  }
-  var fieldApi = createColumnFieldApi({
-    id: fieldId,
-    labelId: labelId,
-    descriptionId: metaId,
-    control: control,
-    meta: meta,
-    input: control,
-    form: options.form || null,
-    dialog: options.dialog || null,
-    context: context,
-  });
-  field._datasetteColumnFormField = fieldApi;
-  var pluginControlElement = renderColumnField(pluginControl, fieldApi);
-  var controlElement =
-    pluginControlElement || rowEditControlElement(control, options.autocompleteUrl);
-  if (options.autocompleteUrl && !pluginControlElement) {
-    control.addEventListener("input", function () {
-      setForeignKeyMetaLink(meta, options.autocompleteUrl, null);
-    });
-    control.addEventListener("change", function () {
-      resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
-    });
-    controlElement.addEventListener("datasette-autocomplete-select", function (ev) {
-      setForeignKeyMetaLink(
-        meta,
-        options.autocompleteUrl,
-        ev.detail && ev.detail.row,
-      );
-    });
-    resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
-  }
-
-  if (hasDefaultExpression) {
-    var defaultBlock = document.createElement("div");
-    defaultBlock.className = "row-edit-default";
-    defaultBlock.setAttribute("aria-describedby", metaId);
-
-    var defaultText = document.createElement("span");
-    defaultText.className = "row-edit-default-text";
-    defaultText.appendChild(document.createTextNode("default "));
-    var defaultCode = document.createElement("code");
-    defaultCode.className = "row-edit-default-code";
-    defaultCode.textContent = defaultExpression;
-    defaultText.appendChild(defaultCode);
-
-    var setValueButton = document.createElement("button");
-    setValueButton.type = "button";
-    setValueButton.className =
-      "row-edit-default-button row-edit-default-set-value";
-    setValueButton.textContent = "Set value";
-    setValueButton.setAttribute("aria-label", "Set value for " + column);
-
-    var customWrap = document.createElement("div");
-    customWrap.className = "row-edit-custom-value";
-    customWrap.hidden = true;
-
-    var useSqliteDefaultButton = document.createElement("button");
-    useSqliteDefaultButton.type = "button";
-    useSqliteDefaultButton.className = "row-edit-default-button";
-    useSqliteDefaultButton.textContent = "Use default";
-    useSqliteDefaultButton.setAttribute(
-      "aria-label",
-      "Use SQLite default for " + column,
-    );
-
-    setValueButton.addEventListener("click", function () {
-      fieldApi.stopUsingSqliteDefault();
-      control.focus();
-    });
-
-    useSqliteDefaultButton.addEventListener("click", function () {
-      fieldApi.useSqliteDefault();
-      setValueButton.focus();
-    });
-
-    defaultBlock.appendChild(defaultText);
-    defaultBlock.appendChild(setValueButton);
-    customWrap.appendChild(controlElement);
-    customWrap.appendChild(useSqliteDefaultButton);
-    controlWrap.appendChild(defaultBlock);
-    controlWrap.appendChild(customWrap);
-    fieldApi.syncSqliteDefaultUi = function () {
-      var usingDefault = fieldApi.isUsingSqliteDefault();
-      defaultBlock.hidden = !usingDefault;
-      customWrap.hidden = usingDefault;
-    };
-    fieldApi.syncSqliteDefaultUi();
-  } else {
-    controlWrap.appendChild(controlElement);
-  }
-  if (meta.textContent || options.autocompleteUrl) {
-    controlWrap.appendChild(meta);
-  }
-  field.appendChild(label);
-  field.appendChild(controlWrap);
-  return field;
-}
-
-function clearRowEditDialogError(state) {
-  state.error.hidden = true;
-  state.error.textContent = "";
-}
-
-function showRowEditDialogError(state, message) {
-  state.error.hidden = false;
-  state.error.textContent = message;
-  state.error.focus();
-}
-
-function updateRowEditDialogButtons(state) {
-  state.saveButton.disabled = state.isLoading || state.isSaving || !state.hasLoaded;
-  state.cancelButton.disabled = state.isSaving;
-  var saveLabel = state.mode === "insert" ? "Insert row" : "Save";
-  state.saveButton.textContent = state.isSaving ? "Saving..." : saveLabel;
-  state.form.setAttribute(
-    "aria-busy",
-    state.isLoading || state.isSaving ? "true" : "false",
-  );
-}
-
-function setRowEditDialogLoading(state, isLoading) {
-  state.isLoading = isLoading;
-  state.loading.hidden = !isLoading;
-  updateRowEditDialogButtons(state);
-}
-
-function setRowEditDialogSaving(state, isSaving) {
-  state.isSaving = isSaving;
-  updateRowEditDialogButtons(state);
-}
-
-function valueFromRowEditControl(control) {
-  var value = control.value;
-  return valueFromRowEditText(
-    control.name,
-    value,
-    rowEditControlValueKind(control),
-  );
-}
-
-function valueFromRowEditText(name, value, initialValueKind) {
-  var trimmed = value.trim();
-
-  if (initialValueKind === "null" && value === "") {
-    return null;
-  }
-  if (initialValueKind === "number") {
-    if (trimmed === "") {
-      return null;
-    }
-    var numberValue = Number(trimmed);
-    if (Number.isNaN(numberValue)) {
-      throw new Error(name + " must be a number");
-    }
-    return numberValue;
-  }
-  if (initialValueKind === "boolean") {
-    if (/^(true|1|yes)$/i.test(trimmed)) {
-      return true;
-    }
-    if (/^(false|0|no)$/i.test(trimmed)) {
-      return false;
-    }
-    throw new Error(name + " must be true or false");
-  }
-  return value;
-}
-
-function initialValueFromRowEditControl(control) {
-  return valueFromRowEditText(
-    control.name,
-    control.dataset.initialValue || "",
-    control.dataset.initialValueKind || "string",
-  );
-}
-
-function rowEditControlValueKind(control) {
-  return (
-    control.dataset.currentValueKind ||
-    control.dataset.initialValueKind ||
-    "string"
-  );
-}
-
-function rowEditControlCleanValue(control) {
-  if (Object.prototype.hasOwnProperty.call(control.dataset, "cleanValue")) {
-    return control.dataset.cleanValue;
-  }
-  return control.dataset.initialValue || "";
-}
-
-function rowEditControlCleanValueKind(control) {
-  return (
-    control.dataset.cleanValueKind ||
-    control.dataset.initialValueKind ||
-    "string"
-  );
-}
-
-function rowEditControlCleanUsesSqliteDefault(control) {
-  if (
-    Object.prototype.hasOwnProperty.call(
-      control.dataset,
-      "cleanUseSqliteDefault",
-    )
-  ) {
-    return control.dataset.cleanUseSqliteDefault === "1";
-  }
-  return false;
-}
-
-function markRowEditControlClean(control) {
-  control.dataset.cleanValue = control.value;
-  control.dataset.cleanValueKind = rowEditControlValueKind(control);
-  control.dataset.cleanUseSqliteDefault =
-    control.dataset.useSqliteDefault === "1" ? "1" : "0";
-}
-
-function cleanValueFromRowEditControl(control) {
-  return valueFromRowEditText(
-    control.name,
-    rowEditControlCleanValue(control),
-    rowEditControlCleanValueKind(control),
-  );
-}
-
-function rowEditValuesMatch(left, right) {
-  if (left === right) {
-    return true;
-  }
-  if (
-    left &&
-    right &&
-    typeof left === "object" &&
-    typeof right === "object"
-  ) {
-    return JSON.stringify(left) === JSON.stringify(right);
-  }
-  return false;
-}
-
-function rowEditControlHasChanged(control) {
-  var usingSqliteDefault = control.dataset.useSqliteDefault === "1";
-  var cleanUsesSqliteDefault = rowEditControlCleanUsesSqliteDefault(control);
-  if (usingSqliteDefault || cleanUsesSqliteDefault) {
-    return usingSqliteDefault !== cleanUsesSqliteDefault;
-  }
-  if (
-    control.value === rowEditControlCleanValue(control) &&
-    rowEditControlValueKind(control) === rowEditControlCleanValueKind(control)
-  ) {
-    return false;
-  }
-  try {
-    return !rowEditValuesMatch(
-      valueFromRowEditControl(control),
-      cleanValueFromRowEditControl(control),
-    );
-  } catch (_error) {
-    return true;
-  }
-}
-
-function collectRowFormValues(state) {
-  var values = {};
-  state.fields.querySelectorAll(".row-edit-input").forEach(function (control) {
-    if (
-      state.mode === "edit" &&
-      (control.readOnly || control.dataset.primaryKey === "1")
-    ) {
-      return;
-    }
-    if (control.dataset.useSqliteDefault === "1") {
-      return;
-    }
-    if (control.dataset.omitIfBlank === "1" && control.value === "") {
-      return;
-    }
-    if (
-      state.mode === "edit" &&
-      control.value === (control.dataset.initialValue || "") &&
-      (control.dataset.currentValueKind ||
-        control.dataset.initialValueKind ||
-        "string") === (control.dataset.initialValueKind || "string")
-    ) {
-      return;
-    }
-    var value = valueFromRowEditControl(control);
-    if (state.mode === "edit") {
-      try {
-        if (rowEditValuesMatch(value, initialValueFromRowEditControl(control))) {
-          return;
-        }
-      } catch (_error) {
-        // If the original value cannot be parsed using the field's current
-        // type, treat the field as changed and submit the corrected value.
-      }
-    }
-    values[control.name] = value;
-  });
-  return values;
-}
-
-function rowEditDialogHasChanges(state) {
-  if (!state || !state.hasLoaded || state.isLoading) {
-    return false;
-  }
-  var fields = state.fields.querySelectorAll(".row-edit-field");
-  for (var i = 0; i < fields.length; i += 1) {
-    var fieldApi = fields[i]._datasetteColumnFormField;
-    if (fieldApi && fieldApi.hasChanged && fieldApi.hasChanged()) {
-      return true;
-    }
-  }
-  return false;
-}
-
-function confirmDiscardRowEditChanges(state) {
-  if (!rowEditDialogHasChanges(state)) {
-    return true;
-  }
-  var message =
-    state.mode === "insert"
-      ? "Discard this new row?"
-      : "Discard unsaved changes to this row?";
-  return window.confirm(message);
-}
-
-function closeRowEditDialogIfConfirmed(state) {
-  if (!state || state.isSaving) {
-    return false;
-  }
-  if (!confirmDiscardRowEditChanges(state)) {
-    return false;
-  }
-  state.shouldRestoreFocus = true;
-  state.dialog.close();
-  return true;
-}
-
-function findDataRowElement(root, rowId) {
-  var elements = root.querySelectorAll("[data-row]");
-  for (var i = 0; i < elements.length; i += 1) {
-    if (elements[i].getAttribute("data-row") === rowId) {
-      return elements[i];
-    }
-  }
-  return null;
-}
-
-async function fetchUpdatedRowElement(state) {
-  if (!state.currentFragmentUrl || !state.currentRowId) {
-    return null;
-  }
-  var response = await fetch(state.currentFragmentUrl, {
-    headers: {
-      Accept: "text/html",
-    },
-  });
-  var html = await response.text();
-  if (!response.ok) {
-    throw new Error("Could not refresh row: HTTP " + response.status);
-  }
-  var doc = new DOMParser().parseFromString(html, "text/html");
-  return findDataRowElement(doc, state.currentRowId);
-}
-
-function rowPathFromRowData(row, primaryKeys) {
-  if (!row) {
-    return null;
-  }
-  var keys = primaryKeys && primaryKeys.length ? primaryKeys : ["rowid"];
-  var bits = [];
-  for (var i = 0; i < keys.length; i += 1) {
-    var key = keys[i];
-    if (typeof row[key] === "undefined") {
-      return null;
-    }
-    bits.push(tildeEncode(row[key]));
-  }
-  return bits.join(",");
-}
-
-function addInsertedRowToPage(rowElement) {
-  var importedRow = document.importNode(rowElement, true);
-  var firstRow = document.querySelector("[data-row]");
-  if (firstRow && firstRow.parentNode) {
-    firstRow.parentNode.insertBefore(importedRow, firstRow);
-  } else {
-    var tbody = document.querySelector("table.rows-and-columns tbody");
-    if (!tbody) {
-      return null;
-    }
-    tbody.appendChild(importedRow);
-  }
-  var zeroResults = document.querySelector(".zero-results");
-  if (zeroResults) {
-    zeroResults.remove();
-  }
-  return importedRow;
-}
-
-async function saveRowEditDialog(state) {
-  if (state.isLoading || state.isSaving || !state.hasLoaded) {
-    return;
-  }
-  clearRowEditDialogError(state);
-  setRowEditDialogSaving(state, true);
-
-  try {
-    var url = state.mode === "insert" ? state.currentInsertUrl : state.currentUpdateUrl;
-    if (!url) {
-      throw new Error(
-        state.mode === "insert"
-          ? "Could not find the row insert URL"
-          : "Could not find the row update URL",
-      );
-    }
-    var formValues = collectRowFormValues(state);
-    if (state.mode === "edit" && !Object.keys(formValues).length) {
-      state.shouldRestoreFocus = true;
-      hideRowMutationStatus();
-      state.dialog.close();
-      return;
-    }
-    var payload =
-      state.mode === "insert"
-        ? { row: formValues, return: true }
-        : { update: formValues, return: true };
-    var response = await fetch(url, {
-      method: "POST",
-      headers: {
-        "Content-Type": "application/json",
-        Accept: "application/json",
-      },
-      body: JSON.stringify(payload),
-    });
-    var data = null;
-    try {
-      data = await response.json();
-    } catch (_error) {
-      data = null;
-    }
-    if (!response.ok || (data && data.ok === false)) {
-      throw rowMutationRequestError(response, data);
-    }
-
-    if (state.mode === "insert") {
-      var insertData = tableInsertData() || {};
-      var insertedRowData = data && data.rows && data.rows.length ? data.rows[0] : null;
-      var insertedRowId = rowPathFromRowData(
-        insertedRowData,
-        insertData.primaryKeys || [],
-      );
-      state.shouldRestoreFocus = false;
-      if (!insertedRowId) {
-        state.dialog.close();
-        var missingIdStatus = showRowMutationStatus(
-          state.manager,
-          "Inserted row. Refresh the page to see it.",
-          false,
-        );
-        missingIdStatus.focus();
-        return;
-      }
-
-      state.currentRowId = insertedRowId;
-      state.currentFragmentUrl = rowFragmentUrlById(insertedRowId);
-      var insertedRow = null;
-      try {
-        insertedRow = await fetchUpdatedRowElement(state);
-      } catch (_error) {
-        state.dialog.close();
-        var refreshFailedStatus = showRowMutationStatus(
-          state.manager,
-          "Inserted row, but could not refresh the table row. Refresh the page to see it.",
-          true,
-        );
-        refreshFailedStatus.focus();
-        return;
-      }
-      if (insertedRow) {
-        var insertedStatusMessage = insertedRowStatusMessage(
-          tildeDecode(insertedRowId),
-          rowTitleLabel(insertedRow),
-        );
-        var addedRow = addInsertedRowToPage(insertedRow);
-        state.dialog.close();
-        showRowMutationStatus(state.manager, insertedStatusMessage, false);
-        if (addedRow) {
-          var insertedFocusTarget =
-            addedRow.querySelector('button[data-row-action="edit"]') || addedRow;
-          insertedFocusTarget.focus();
-        }
-      } else {
-        state.dialog.close();
-        var filteredStatus = showRowMutationStatus(
-          state.manager,
-          "Inserted row. It does not match the current filters.",
-          false,
-        );
-        filteredStatus.focus();
-      }
-      return;
-    }
-
-    var updatedRow = await fetchUpdatedRowElement(state);
-    var focusTarget = null;
-    if (updatedRow && state.currentRow && document.contains(state.currentRow)) {
-      var importedRow = document.importNode(updatedRow, true);
-      state.currentRow.replaceWith(importedRow);
-      showRowMutationStatus(
-        state.manager,
-        state.currentPkPath
-          ? "Updated row " + state.currentPkPath + "."
-          : "Updated row.",
-        false,
-      );
-      focusTarget =
-        importedRow.querySelector('button[data-row-action="edit"]') || importedRow;
-    } else if (state.currentRow && document.contains(state.currentRow)) {
-      focusTarget =
-        nextRowActionFocusTarget(state.currentRow, "edit") ||
-        ensureRowMutationStatus(state.manager);
-      state.currentRow.remove();
-      showRowMutationStatus(
-        state.manager,
-        state.currentPkPath
-          ? "Updated row " +
-              state.currentPkPath +
-              ". It no longer matches the current filters."
-          : "Updated row. It no longer matches the current filters.",
-        false,
-      );
-    }
-
-    state.shouldRestoreFocus = false;
-    state.dialog.close();
-    if (focusTarget && document.contains(focusTarget)) {
-      focusTarget.focus();
-    }
-  } catch (error) {
-    setRowEditDialogSaving(state, false);
-    showRowEditDialogError(state, error.message || "Could not save row");
-  }
-}
-
-function renderRowEditFields(state, data) {
-  var row = data.rows && data.rows.length ? data.rows[0] : null;
-  var columns = data.columns || (row ? Object.keys(row) : []);
-  var primaryKeys = data.primary_keys || [];
-  var columnTypes = data.column_types || {};
-
-  destroyRowEditFields(state);
-  columns.forEach(function (column, index) {
-    state.fields.appendChild(
-      createRowEditField(
-        column,
-        row ? row[column] : null,
-        primaryKeys.indexOf(column) !== -1,
-        columnTypes[column],
-        index,
-        {
-          autocompleteUrl: foreignKeyAutocompleteUrl(column),
-          dialog: state.dialog,
-          form: state.form,
-          manager: state.manager,
-          mode: state.mode,
-          primaryKeyReadonly: true,
-        },
-      ),
-    );
-  });
-
-  state.hasLoaded = true;
-  updateRowEditDialogButtons(state);
-  if (!focusFirstRowEditControl(state, { skipReadonly: true })) {
-    focusFirstRowEditControl(state) || state.cancelButton.focus();
-  }
-}
-
-function renderRowInsertFields(state, data) {
-  var columns = data.columns || [];
-
-  destroyRowEditFields(state);
-  columns.forEach(function (column, index) {
-    state.fields.appendChild(
-      createRowEditField(
-        column.name,
-        "",
-        !!column.is_pk,
-        column.column_type,
-        index,
-        {
-          autocompleteUrl: foreignKeyAutocompleteUrl(column.name),
-          dialog: state.dialog,
-          form: state.form,
-          defaultExpression: column.default,
-          manager: state.manager,
-          mode: state.mode,
-          notnull: column.notnull,
-          primaryKeyReadonly: false,
-          sqliteType: column.sqlite_type,
-          useSqliteDefault: column.default !== null,
-          valueKind: column.value_kind,
-        },
-      ),
-    );
-  });
-
-  if (!columns.length) {
-    var emptyMessage = document.createElement("p");
-    emptyMessage.className = "row-edit-empty";
-    emptyMessage.textContent = "This row will use the table defaults.";
-    state.fields.appendChild(emptyMessage);
-  }
-
-  state.hasLoaded = true;
-  updateRowEditDialogButtons(state);
-  var firstDefaultButton = state.fields.querySelector(".row-edit-default-set-value");
-  if (firstDefaultButton) {
-    firstDefaultButton.focus();
-  } else {
-    focusFirstRowEditControl(state, { skipReadonly: true }) ||
-      state.saveButton.focus();
-  }
-}
-
-function setRowDialogTitle(title, text, codeText, labelText) {
-  title.textContent = "";
-  var action = document.createElement("span");
-  action.className = "row-dialog-action";
-  action.textContent = text;
-  title.appendChild(action);
-  if (!codeText) {
-    return;
-  }
-  title.appendChild(document.createTextNode(" "));
-  var code = document.createElement("code");
-  code.textContent = codeText;
-  title.appendChild(code);
-  if (labelText && labelText !== codeText) {
-    title.appendChild(document.createTextNode(" "));
-    var label = document.createElement("span");
-    label.className = "row-dialog-label";
-    label.textContent = labelText;
-    title.appendChild(label);
-  }
-}
-
-function ensureRowEditDialog(manager) {
-  if (rowEditDialogState) {
-    return rowEditDialogState;
-  }
-  if (!window.HTMLDialogElement) {
-    return null;
-  }
-
-  var dialog = document.createElement("dialog");
-  dialog.id = ROW_EDIT_DIALOG_ID;
-  dialog.className = "row-edit-dialog";
-  dialog.setAttribute("aria-labelledby", "row-edit-title");
-  dialog.innerHTML = `
-    <div class="modal-header">
-      <span class="modal-title" id="row-edit-title">Edit row</span>
-    </div>
-    <form class="row-edit-form" method="post">
-      <p class="row-edit-summary" id="row-edit-summary" hidden></p>
-      <p class="row-edit-loading" role="status" aria-live="polite">Loading row...</p>
-      <p class="row-edit-error" role="alert" tabindex="-1" hidden></p>
-      <div class="row-edit-fields"></div>
-      <div class="modal-footer">
-        <button type="button" class="btn btn-ghost row-edit-cancel">Cancel</button>
-        <button type="submit" class="btn btn-primary row-edit-save" disabled>Save</button>
-      </div>
-    </form>
-  `;
-  document.body.appendChild(dialog);
-
-  rowEditDialogState = {
-    dialog: dialog,
-    form: dialog.querySelector(".row-edit-form"),
-    title: dialog.querySelector(".modal-title"),
-    summary: dialog.querySelector(".row-edit-summary"),
-    loading: dialog.querySelector(".row-edit-loading"),
-    error: dialog.querySelector(".row-edit-error"),
-    fields: dialog.querySelector(".row-edit-fields"),
-    cancelButton: dialog.querySelector(".row-edit-cancel"),
-    saveButton: dialog.querySelector(".row-edit-save"),
-    currentButton: null,
-    currentRow: null,
-    currentRowId: null,
-    currentPkPath: null,
-    currentInsertUrl: null,
-    currentUpdateUrl: null,
-    currentFragmentUrl: null,
-    mode: "edit",
-    loadId: 0,
-    manager: manager,
-    isLoading: false,
-    isSaving: false,
-    hasLoaded: false,
-    shouldRestoreFocus: true,
-  };
-
-  rowEditDialogState.form.addEventListener("submit", function (ev) {
-    ev.preventDefault();
-    saveRowEditDialog(rowEditDialogState);
-  });
-
-  rowEditDialogState.cancelButton.addEventListener("click", function () {
-    if (!rowEditDialogState.isSaving) {
-      rowEditDialogState.shouldRestoreFocus = true;
-      dialog.close();
-    }
-  });
-
-  dialog.addEventListener("click", function (ev) {
-    if (ev.target === dialog) {
-      closeRowEditDialogIfConfirmed(rowEditDialogState);
-    }
-  });
-
-  dialog.addEventListener("keydown", function (ev) {
-    if (ev.key !== "Escape") {
-      return;
-    }
-    ev.preventDefault();
-    closeRowEditDialogIfConfirmed(rowEditDialogState);
-  });
-
-  dialog.addEventListener("cancel", function (ev) {
-    if (
-      rowEditDialogState.isSaving ||
-      !confirmDiscardRowEditChanges(rowEditDialogState)
-    ) {
-      ev.preventDefault();
-    } else {
-      rowEditDialogState.shouldRestoreFocus = true;
-    }
-  });
-
-  dialog.addEventListener("close", function () {
-    var state = rowEditDialogState;
-    state.loadId += 1;
-    clearRowEditDialogError(state);
-    state.hasLoaded = false;
-    destroyRowEditFields(state);
-    setRowEditDialogLoading(state, false);
-    setRowEditDialogSaving(state, false);
-    if (
-      state.shouldRestoreFocus &&
-      state.currentButton &&
-      document.contains(state.currentButton)
-    ) {
-      state.currentButton.focus();
-    }
-  });
-
-  return rowEditDialogState;
-}
-
-async function openRowEditDialog(button, manager) {
-  var row = button.closest("[data-row]");
-  if (!row || !row.getAttribute("data-row")) {
-    return;
-  }
-  var state = ensureRowEditDialog(manager);
-  if (!state) {
-    return;
-  }
-
-  state.manager = manager;
-  state.mode = "edit";
-  state.currentButton = button;
-  state.currentRow = row;
-  state.currentRowId = row.getAttribute("data-row") || "";
-  state.currentPkPath = rowDisplayLabel(row);
-  state.currentInsertUrl = null;
-  state.currentUpdateUrl = rowUpdateUrl(row);
-  state.currentFragmentUrl = rowFragmentUrl(row);
-  if (state.currentUpdateUrl) {
-    state.form.action = new URL(state.currentUpdateUrl, location.href).toString();
-  } else {
-    state.form.removeAttribute("action");
-  }
-  state.shouldRestoreFocus = true;
-  state.hasLoaded = false;
-  state.loadId += 1;
-  var loadId = state.loadId;
-
-  clearRowEditDialogError(state);
-  setRowEditDialogLoading(state, true);
-  destroyRowEditFields(state);
-  state.dialog.removeAttribute("aria-describedby");
-  setRowDialogTitle(
-    state.title,
-    "Edit row",
-    state.currentPkPath || "this row",
-    rowTitleLabel(row),
-  );
-  state.summary.hidden = true;
-  state.summary.textContent = "";
-
-  if (!state.dialog.open) {
-    state.dialog.showModal();
-  }
-  state.cancelButton.focus();
-
-  try {
-    var response = await fetch(rowJsonUrl(row), {
-      headers: {
-        Accept: "application/json",
-      },
-    });
-    var data = await response.json();
-    if (loadId !== state.loadId) {
-      return;
-    }
-    if (!response.ok || data.ok === false) {
-      throw rowMutationRequestError(response, data);
-    }
-    setRowEditDialogLoading(state, false);
-    renderRowEditFields(state, data);
-  } catch (error) {
-    if (loadId !== state.loadId) {
-      return;
-    }
-    setRowEditDialogLoading(state, false);
-    showRowEditDialogError(state, error.message || "Could not load row");
-    state.cancelButton.focus();
-  }
-}
-
-function openRowInsertDialog(button, manager) {
-  var insertData = tableInsertData();
-  if (!insertData) {
-    return;
-  }
-  var state = ensureRowEditDialog(manager);
-  if (!state) {
-    return;
-  }
-
-  state.manager = manager;
-  state.mode = "insert";
-  state.currentButton = button;
-  state.currentRow = null;
-  state.currentRowId = null;
-  state.currentPkPath = null;
-  state.currentInsertUrl = tableInsertUrl();
-  state.currentUpdateUrl = null;
-  state.currentFragmentUrl = null;
-  state.shouldRestoreFocus = true;
-  state.hasLoaded = false;
-  state.loadId += 1;
-
-  if (state.currentInsertUrl) {
-    state.form.action = new URL(state.currentInsertUrl, location.href).toString();
-  } else {
-    state.form.removeAttribute("action");
-  }
-
-  clearRowEditDialogError(state);
-  setRowEditDialogLoading(state, false);
-  destroyRowEditFields(state);
-  state.dialog.removeAttribute("aria-describedby");
-  setRowDialogTitle(
-    state.title,
-    insertData.tableName ? "Insert row into " + insertData.tableName : "Insert row",
-  );
-  state.summary.hidden = true;
-  state.summary.textContent = "";
-
-  if (!state.dialog.open) {
-    state.dialog.showModal();
-  }
-  renderRowInsertFields(state, insertData);
-}
-
-function initRowEditActions(manager) {
-  if (!window.fetch || !window.HTMLDialogElement) {
-    return;
-  }
-  document.addEventListener("click", function (ev) {
-    var button = ev.target.closest('button[data-row-action="edit"]');
-    if (!button) {
-      return;
-    }
-    ev.preventDefault();
-    openRowEditDialog(button, manager);
-  });
-}
-
-function initRowInsertActions(manager) {
-  if (!window.fetch || !window.HTMLDialogElement || !tableInsertData()) {
-    return;
-  }
-  document.addEventListener("click", function (ev) {
-    var button = ev.target.closest('button[data-table-action="insert-row"]');
-    if (!button) {
-      return;
-    }
-    ev.preventDefault();
-    openRowInsertDialog(button, manager);
-  });
-}
-
 function canChooseColumns() {
   return !!(
     document.querySelector("column-chooser") && window._columnChooserData
@@ -2679,14 +745,10 @@ function openColumnChooser() {
 document.addEventListener("datasette_init", function (evt) {
   const { detail: manager } = evt;
 
-  registerBuiltinColumnFieldPlugins(manager);
   initializeColumnActions(manager);
 
   // Main table
   initDatasetteTable(manager);
-  initRowInsertActions(manager);
-  initRowEditActions(manager);
-  initRowDeleteActions(manager);
 
   // Other UI functions with interactive JS needs
   addButtonsToFilterRows(manager);
diff --git a/datasette/templates/row.html b/datasette/templates/row.html
index db43e71a..5e483d34 100644
--- a/datasette/templates/row.html
+++ b/datasette/templates/row.html
@@ -4,6 +4,13 @@
 
 {% block extra_head %}
 {{- super() -}}
+{% if row_mutation_ui %}
+<script>window._datasetteTableData = {{ table_page_data|tojson }};</script>
+{% if table_page_data.foreignKeys %}
+<script src="{{ urls.static('autocomplete.js') }}" defer></script>
+{% endif %}
+<script src="{{ urls.static('edit-tools.js') }}?hash={{ edit_tools_js_hash }}" defer></script>
+{% endif %}
 <style>
 @media only screen and (max-width: 576px) {
 {% for column in columns %}
diff --git a/datasette/templates/table.html b/datasette/templates/table.html
index 81b51b28..86b6a6ed 100644
--- a/datasette/templates/table.html
+++ b/datasette/templates/table.html
@@ -9,6 +9,7 @@
 {% if table_page_data.foreignKeys %}
 <script src="{{ urls.static('autocomplete.js') }}" defer></script>
 {% endif %}
+<script src="{{ urls.static('edit-tools.js') }}?hash={{ edit_tools_js_hash }}" defer></script>
 <script src="{{ urls.static('table.js') }}?hash={{ table_js_hash }}" defer></script>
 <script src="{{ urls.static('mobile-column-actions.js') }}" defer></script>
 <script>DATASETTE_ALLOW_FACET = {{ datasette_allow_facet }};</script>
diff --git a/datasette/views/row.py b/datasette/views/row.py
index c300758b..e6eaa92b 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -7,6 +7,7 @@ from datasette.utils import (
     await_me_maybe,
     CustomRow,
     make_slot_function,
+    path_from_row_pks,
     to_css_class,
     escape_sqlite,
 )
@@ -15,7 +16,11 @@ import json
 import markupsafe
 import sqlite_utils
 from datasette.extras import extra_names_from_request
-from .table import display_columns_and_rows
+from .table import (
+    display_columns_and_rows,
+    _table_page_data,
+    row_label_from_label_column,
+)
 from .table_extras import RowExtraContext, resolve_row_extras, table_extra_registry
 
 
@@ -49,6 +54,7 @@ class RowView(DataView):
         pks = resolved.pks
 
         async def template_data():
+            is_table = await db.table_exists(table)
             # Reorder columns so primary keys come first
             pk_set = set(pks)
             pk_cols = [d for d in results.description if d[0] in pk_set]
@@ -117,7 +123,60 @@ class RowView(DataView):
                             "<strong>{}</strong>".format(cell["value"])
                         )
 
+            label_column = await db.label_column_for_table(table) if is_table else None
+            row_path = path_from_row_pks(rows[0], pks, False)
+            pk_path = path_from_row_pks(rows[0], pks, False, False)
+            row_label = row_label_from_label_column(expanded_rows[0], label_column)
+            for display_row in display_rows:
+                display_row.pk_path = pk_path
+                display_row.row_path = row_path
+                display_row.row_label = row_label
+
+            row_action_label = pk_path
+            if row_label and row_label != pk_path:
+                row_action_label = "{} {}".format(pk_path, row_label)
+
+            row_action_permissions = {}
+            if is_table and db.is_mutable:
+                row_action_permissions = await self.ds.allowed_many(
+                    actions=["update-row", "delete-row"],
+                    resource=TableResource(database=database, table=table),
+                    actor=request.actor,
+                )
+
             row_actions = []
+            if row_action_permissions.get("update-row"):
+                attrs = {
+                    "aria-label": "Edit row {}".format(row_action_label),
+                    "data-row": row_path,
+                    "data-row-action": "edit",
+                }
+                if row_label:
+                    attrs["data-row-label"] = row_label
+                row_actions.append(
+                    {
+                        "type": "button",
+                        "label": "Edit row",
+                        "description": "Open a dialog to edit this row.",
+                        "attrs": attrs,
+                    }
+                )
+            if row_action_permissions.get("delete-row"):
+                attrs = {
+                    "aria-label": "Delete row {}".format(row_action_label),
+                    "data-row": row_path,
+                    "data-row-action": "delete",
+                }
+                if row_label:
+                    attrs["data-row-label"] = row_label
+                row_actions.append(
+                    {
+                        "type": "button",
+                        "label": "Delete row",
+                        "description": "Open a confirmation dialog to delete this row.",
+                        "attrs": attrs,
+                    }
+                )
             for hook in pm.hook.row_actions(
                 datasette=self.ds,
                 actor=request.actor,
@@ -144,6 +203,16 @@ class RowView(DataView):
                     f"_table-row-{to_css_class(database)}-{to_css_class(table)}.html",
                     "_table.html",
                 ],
+                "row_mutation_ui": any(row_action_permissions.values()),
+                "table_page_data": await _table_page_data(
+                    self.ds,
+                    request,
+                    db,
+                    database,
+                    table,
+                    not is_table,
+                    None,
+                ),
                 "row_actions": row_actions,
                 "top_row": make_slot_function(
                     "top_row",
@@ -249,6 +318,27 @@ class RowError(Exception):
         self.error = error
 
 
+ROW_FLASH_LABEL_MAX_LENGTH = 80
+
+
+def _truncated_row_flash_label(label):
+    label = " ".join(str(label).split())
+    if len(label) <= ROW_FLASH_LABEL_MAX_LENGTH:
+        return label
+    return label[: ROW_FLASH_LABEL_MAX_LENGTH - 1] + "\u2026"
+
+
+async def _row_flash_message(db, action, resolved, row=None):
+    pk_label = ", ".join(resolved.pk_values)
+    label_column = await db.label_column_for_table(resolved.table)
+    label = row_label_from_label_column(row or resolved.row, label_column)
+    if label:
+        label = _truncated_row_flash_label(label)
+    if label and label != pk_label:
+        return "{} row {} ({})".format(action, pk_label, label)
+    return "{} row {}".format(action, pk_label)
+
+
 async def _resolve_row_and_check_permission(datasette, request, permission):
     from datasette.app import DatabaseNotFound, TableNotFound, RowNotFound
 
@@ -303,6 +393,15 @@ class RowDeleteView(BaseView):
             )
         )
 
+        if request.args.get("_redirect_to_table"):
+            table_url = self.ds.urls.table(resolved.db.name, resolved.table)
+            self.ds.add_message(
+                request,
+                await _row_flash_message(resolved.db, "Deleted", resolved),
+                self.ds.INFO,
+            )
+            return Response.json({"ok": True, "redirect": str(table_url)}, status=200)
+
         return Response.json({"ok": True}, status=200)
 
 
@@ -364,11 +463,13 @@ class RowUpdateView(BaseView):
             return _error([str(e)], 400)
 
         result = {"ok": True}
+        returned_row = None
         if data.get("return"):
             results = await resolved.db.execute(
                 resolved.sql, resolved.params, truncate=True
             )
-            result["row"] = results.dicts()[0]
+            returned_row = results.dicts()[0]
+            result["row"] = returned_row
 
         await self.ds.track_event(
             UpdateRowEvent(
@@ -379,4 +480,19 @@ class RowUpdateView(BaseView):
             )
         )
 
+        if request.args.get("_message"):
+            message_row = returned_row
+            if message_row is None:
+                results = await resolved.db.execute(
+                    resolved.sql, resolved.params, truncate=True
+                )
+                message_row = results.first()
+            self.ds.add_message(
+                request,
+                await _row_flash_message(
+                    resolved.db, "Updated", resolved, row=message_row
+                ),
+                self.ds.INFO,
+            )
+
         return Response.json(result, status=200)
diff --git a/tests/test_datasette_manager_js.py b/tests/test_datasette_manager_js.py
index f32f2de0..01b6bbac 100644
--- a/tests/test_datasette_manager_js.py
+++ b/tests/test_datasette_manager_js.py
@@ -80,7 +80,7 @@ def test_table_plugin_column_field_api():
     script = textwrap.dedent("""
         const fs = require("fs");
         const vm = require("vm");
-        const tableJs = __TABLE_JS__;
+        const editToolsJs = __EDIT_TOOLS_JS__;
 
         class FakeEvent {
           constructor(type, options) {
@@ -180,8 +180,8 @@ def test_table_plugin_column_field_api():
           },
         };
 
-        vm.runInThisContext(fs.readFileSync(tableJs, "utf8"), {
-          filename: "table.js",
+        vm.runInThisContext(fs.readFileSync(editToolsJs, "utf8"), {
+          filename: "edit-tools.js",
         });
 
         const context = columnFormControlContext(
@@ -452,7 +452,7 @@ def test_table_plugin_column_field_api():
         }
 
         process.stdout.write("ok");
-    """).replace("__TABLE_JS__", json.dumps(str(STATIC_DIR / "table.js")))
+    """).replace("__EDIT_TOOLS_JS__", json.dumps(str(STATIC_DIR / "edit-tools.js")))
     result = subprocess.run(
         ["node", "-e", script],
         text=True,
@@ -467,7 +467,7 @@ def test_builtin_json_column_field_validation():
     script = textwrap.dedent("""
         const fs = require("fs");
         const vm = require("vm");
-        const tableJs = __TABLE_JS__;
+        const editToolsJs = __EDIT_TOOLS_JS__;
 
         class FakeEvent {
           constructor(type, options) {
@@ -547,8 +547,8 @@ def test_builtin_json_column_field_validation():
           },
         };
 
-        vm.runInThisContext(fs.readFileSync(tableJs, "utf8"), {
-          filename: "table.js",
+        vm.runInThisContext(fs.readFileSync(editToolsJs, "utf8"), {
+          filename: "edit-tools.js",
         });
 
         const plugins = [];
@@ -648,7 +648,7 @@ def test_builtin_json_column_field_validation():
         }
 
         process.stdout.write("ok");
-    """).replace("__TABLE_JS__", json.dumps(str(STATIC_DIR / "table.js")))
+    """).replace("__EDIT_TOOLS_JS__", json.dumps(str(STATIC_DIR / "edit-tools.js")))
     result = subprocess.run(
         ["node", "-e", script],
         text=True,
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index b9936eab..aa67bb3f 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1151,6 +1151,160 @@ async def test_table_fragment_row_parameter_replaces_pk_filters(ds_client):
     assert rows[0]["data-row-label"] == "hello"
 
 
+@pytest.mark.asyncio
+async def test_row_page_edit_delete_action_menu_buttons():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "tables": {
+                        "items": {
+                            "permissions": {
+                                "update-row": {"id": "root"},
+                                "delete-row": {"id": "root"},
+                            },
+                        },
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_row_page_edit_delete_actions"), name="data"
+        )
+        await db.execute_write_script("""
+            create table items (id integer primary key, name text, score integer);
+            insert into items (id, name, score) values (1, 'One', 5);
+            """)
+        response = await ds.client.get("/data/items/1", actor={"id": "root"})
+        assert response.status_code == 200
+        soup = Soup(response.text, "html.parser")
+        assert table_data_from_soup(soup) == {
+            "database": "data",
+            "table": "items",
+            "tableUrl": "/data/items",
+        }
+        script_srcs = [script.get("src") or "" for script in soup.find_all("script")]
+        assert any("edit-tools.js" in src for src in script_srcs)
+        assert not any("table.js" in src for src in script_srcs)
+
+        row = soup.select_one("table.rows-and-columns tbody tr")
+        assert row["data-row"] == "1"
+        assert row["data-row-label"] == "One"
+
+        edit_button = soup.select_one(
+            'details.actions-menu-links button.action-menu-button[data-row-action="edit"]'
+        )
+        assert edit_button is not None
+        assert edit_button["aria-label"] == "Edit row 1 One"
+        assert edit_button["data-row"] == "1"
+        assert edit_button["data-row-label"] == "One"
+        assert edit_button["role"] == "menuitem"
+        assert edit_button.find("span", class_="dropdown-description").text.strip() == (
+            "Open a dialog to edit this row."
+        )
+        edit_button.find("span").extract()
+        assert edit_button.text.strip() == "Edit row"
+
+        delete_button = soup.select_one(
+            'details.actions-menu-links button.action-menu-button[data-row-action="delete"]'
+        )
+        assert delete_button is not None
+        assert delete_button["aria-label"] == "Delete row 1 One"
+        assert delete_button["data-row"] == "1"
+        assert delete_button["data-row-label"] == "One"
+        assert delete_button["role"] == "menuitem"
+        assert delete_button.find(
+            "span", class_="dropdown-description"
+        ).text.strip() == ("Open a confirmation dialog to delete this row.")
+        delete_button.find("span").extract()
+        assert delete_button.text.strip() == "Delete row"
+    finally:
+        ds.close()
+
+
+@pytest.mark.asyncio
+async def test_row_delete_redirect_to_table_sets_message():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "tables": {
+                        "items": {
+                            "permissions": {
+                                "delete-row": {"id": "root"},
+                            },
+                        },
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_row_delete_redirect"), name="data"
+        )
+        await db.execute_write_script("""
+            create table items (id integer primary key, name text);
+            insert into items (id, name) values (1, 'One');
+            """)
+        response = await ds.client.post(
+            "/data/items/1/-/delete?_redirect_to_table=1", actor={"id": "root"}
+        )
+        assert response.status_code == 200
+        assert response.json() == {"ok": True, "redirect": "/data/items"}
+        assert ds.unsign(response.cookies["ds_messages"], "messages") == [
+            ["Deleted row 1 (One)", ds.INFO]
+        ]
+    finally:
+        ds.close()
+
+
+@pytest.mark.asyncio
+async def test_row_update_sets_message():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "tables": {
+                        "items": {
+                            "permissions": {
+                                "update-row": {"id": "root"},
+                            },
+                        },
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_row_update_message"), name="data"
+        )
+        await db.execute_write_script("""
+            create table items (id integer primary key, name text);
+            insert into items (id, name) values (1, 'One');
+            """)
+        long_name = "Two " + ("long label " * 12)
+        truncated_name = long_name[:79] + "\u2026"
+        response = await ds.client.post(
+            "/data/items/1/-/update?_message=1",
+            actor={"id": "root"},
+            json={"update": {"name": long_name}, "return": True},
+        )
+        assert response.status_code == 200
+        assert response.json()["row"]["name"] == long_name
+        assert ds.unsign(response.cookies["ds_messages"], "messages") == [
+            ["Updated row 1 ({})".format(truncated_name), ds.INFO]
+        ]
+    finally:
+        ds.close()
+
+
 def test_table_data_uses_base_url(app_client_base_url_prefix):
     response = app_client_base_url_prefix.get("/prefix/fixtures/simple_primary_key")
     assert response.status_code == 200

From f157df7f07279ad52153fa52ff68cc71eba5b406 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:06:36 -0700
Subject: [PATCH 211/386] Ran prettier

---
 datasette/static/edit-tools.js | 181 +++++++++++++++++++--------------
 1 file changed, 102 insertions(+), 79 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 2af7b35b..b1928f1d 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -80,10 +80,7 @@ function tildeDecode(value) {
   var placeholder = "__datasette_percent_placeholder__";
   try {
     return decodeURIComponent(
-      value
-        .replace(/%/g, placeholder)
-        .replace(/~/g, "%")
-        .replace(/\+/g, " "),
+      value.replace(/%/g, placeholder).replace(/~/g, "%").replace(/\+/g, " "),
     ).replace(new RegExp(placeholder, "g"), "%");
   } catch (_error) {
     return value;
@@ -405,7 +402,9 @@ function nextRowActionFocusTarget(row, action) {
 }
 
 function nextRowDeleteFocusTarget(row, manager) {
-  return nextRowActionFocusTarget(row, "delete") || ensureRowMutationStatus(manager);
+  return (
+    nextRowActionFocusTarget(row, "delete") || ensureRowMutationStatus(manager)
+  );
 }
 
 function ensureRowDeleteDialog(manager) {
@@ -508,52 +507,58 @@ function ensureRowDeleteDialog(manager) {
     }
   });
 
-  rowDeleteDialogState.confirmButton.addEventListener("click", async function () {
-    var state = rowDeleteDialogState;
-    clearRowDeleteDialogError(state);
-    setRowDeleteDialogBusy(state, true);
+  rowDeleteDialogState.confirmButton.addEventListener(
+    "click",
+    async function () {
+      var state = rowDeleteDialogState;
+      clearRowDeleteDialogError(state);
+      setRowDeleteDialogBusy(state, true);
 
-    try {
-      var response = await fetch(state.currentDeleteUrl, {
-        method: "POST",
-        headers: {
-          Accept: "application/json",
-        },
-      });
-      var data = null;
       try {
-        data = await response.json();
-      } catch (_error) {
-        data = null;
-      }
-      if (!response.ok || (data && data.ok === false)) {
-        throw rowMutationRequestError(response, data);
-      }
-      if (data && data.redirect) {
+        var response = await fetch(state.currentDeleteUrl, {
+          method: "POST",
+          headers: {
+            Accept: "application/json",
+          },
+        });
+        var data = null;
+        try {
+          data = await response.json();
+        } catch (_error) {
+          data = null;
+        }
+        if (!response.ok || (data && data.ok === false)) {
+          throw rowMutationRequestError(response, data);
+        }
+        if (data && data.redirect) {
+          state.shouldRestoreFocus = false;
+          state.dialog.close();
+          location.href = data.redirect;
+          return;
+        }
+
+        var focusTarget = nextRowDeleteFocusTarget(
+          state.currentRow,
+          state.manager,
+        );
+        var statusMessage = state.currentPkPath
+          ? "Deleted row " + state.currentPkPath + "."
+          : "Deleted row.";
         state.shouldRestoreFocus = false;
         state.dialog.close();
-        location.href = data.redirect;
-        return;
+        state.currentRow.remove();
+        showRowMutationStatus(state.manager, statusMessage, false);
+        if (focusTarget && document.contains(focusTarget)) {
+          focusTarget.focus();
+        } else {
+          ensureRowMutationStatus(state.manager).focus();
+        }
+      } catch (error) {
+        setRowDeleteDialogBusy(state, false);
+        showRowDeleteDialogError(state, error.message || "Delete failed");
       }
-
-      var focusTarget = nextRowDeleteFocusTarget(state.currentRow, state.manager);
-      var statusMessage = state.currentPkPath
-        ? "Deleted row " + state.currentPkPath + "."
-        : "Deleted row.";
-      state.shouldRestoreFocus = false;
-      state.dialog.close();
-      state.currentRow.remove();
-      showRowMutationStatus(state.manager, statusMessage, false);
-      if (focusTarget && document.contains(focusTarget)) {
-        focusTarget.focus();
-      } else {
-        ensureRowMutationStatus(state.manager).focus();
-      }
-    } catch (error) {
-      setRowDeleteDialogBusy(state, false);
-      showRowDeleteDialogError(state, error.message || "Delete failed");
-    }
-  });
+    },
+  );
 
   return rowDeleteDialogState;
 }
@@ -669,11 +674,16 @@ function defaultExpressionForContext(expression) {
 
 function columnFormControlContext(column, isPk, columnType, options) {
   var pageData = tablePageData();
-  var defaultExpression = defaultExpressionForContext(options.defaultExpression);
+  var defaultExpression = defaultExpressionForContext(
+    options.defaultExpression,
+  );
   return {
     mode: options.mode || "edit",
     database: pageData.database || null,
-    table: pageData.table || (tableInsertData() && tableInsertData().tableName) || null,
+    table:
+      pageData.table ||
+      (tableInsertData() && tableInsertData().tableName) ||
+      null,
     tableUrl: pageData.tableUrl || null,
     column: column,
     columnType: columnTypeForContext(columnType),
@@ -938,7 +948,9 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   options = options || {};
   var field = document.createElement("div");
   field.className = "row-edit-field";
-  var defaultExpression = defaultExpressionForContext(options.defaultExpression);
+  var defaultExpression = defaultExpressionForContext(
+    options.defaultExpression,
+  );
   var hasDefaultExpression = defaultExpression !== null;
   var useSqliteDefault = hasDefaultExpression && options.useSqliteDefault;
 
@@ -954,12 +966,7 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   var controlWrap = document.createElement("div");
   controlWrap.className = "row-edit-control-wrap";
 
-  var context = columnFormControlContext(
-    column,
-    isPk,
-    columnType,
-    options,
-  );
+  var context = columnFormControlContext(column, isPk, columnType, options);
   var pluginControl = makeColumnField(options.manager, context);
   var useTextarea =
     (pluginControl && pluginControl.useTextarea === true) ||
@@ -1061,7 +1068,8 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   field._datasetteColumnFormField = fieldApi;
   var pluginControlElement = renderColumnField(pluginControl, fieldApi);
   var controlElement =
-    pluginControlElement || rowEditControlElement(control, options.autocompleteUrl);
+    pluginControlElement ||
+    rowEditControlElement(control, options.autocompleteUrl);
   if (options.autocompleteUrl && !pluginControlElement) {
     control.addEventListener("input", function () {
       setForeignKeyMetaLink(meta, options.autocompleteUrl, null);
@@ -1069,13 +1077,16 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
     control.addEventListener("change", function () {
       resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
     });
-    controlElement.addEventListener("datasette-autocomplete-select", function (ev) {
-      setForeignKeyMetaLink(
-        meta,
-        options.autocompleteUrl,
-        ev.detail && ev.detail.row,
-      );
-    });
+    controlElement.addEventListener(
+      "datasette-autocomplete-select",
+      function (ev) {
+        setForeignKeyMetaLink(
+          meta,
+          options.autocompleteUrl,
+          ev.detail && ev.detail.row,
+        );
+      },
+    );
     resolveForeignKeyMetaLink(control, options.autocompleteUrl, meta);
   }
 
@@ -1157,7 +1168,8 @@ function showRowEditDialogError(state, message) {
 }
 
 function updateRowEditDialogButtons(state) {
-  state.saveButton.disabled = state.isLoading || state.isSaving || !state.hasLoaded;
+  state.saveButton.disabled =
+    state.isLoading || state.isSaving || !state.hasLoaded;
   state.cancelButton.disabled = state.isSaving;
   var saveLabel = state.mode === "insert" ? "Insert row" : "Save";
   state.saveButton.textContent = state.isSaving ? "Saving..." : saveLabel;
@@ -1277,12 +1289,7 @@ function rowEditValuesMatch(left, right) {
   if (left === right) {
     return true;
   }
-  if (
-    left &&
-    right &&
-    typeof left === "object" &&
-    typeof right === "object"
-  ) {
+  if (left && right && typeof left === "object" && typeof right === "object") {
     return JSON.stringify(left) === JSON.stringify(right);
   }
   return false;
@@ -1337,7 +1344,9 @@ function collectRowFormValues(state) {
     var value = valueFromRowEditControl(control);
     if (state.mode === "edit") {
       try {
-        if (rowEditValuesMatch(value, initialValueFromRowEditControl(control))) {
+        if (
+          rowEditValuesMatch(value, initialValueFromRowEditControl(control))
+        ) {
           return;
         }
       } catch (_error) {
@@ -1457,7 +1466,8 @@ async function saveRowEditDialog(state) {
   setRowEditDialogSaving(state, true);
 
   try {
-    var url = state.mode === "insert" ? state.currentInsertUrl : state.currentUpdateUrl;
+    var url =
+      state.mode === "insert" ? state.currentInsertUrl : state.currentUpdateUrl;
     if (!url) {
       throw new Error(
         state.mode === "insert"
@@ -1496,7 +1506,8 @@ async function saveRowEditDialog(state) {
 
     if (state.mode === "insert") {
       var insertData = tableInsertData() || {};
-      var insertedRowData = data && data.rows && data.rows.length ? data.rows[0] : null;
+      var insertedRowData =
+        data && data.rows && data.rows.length ? data.rows[0] : null;
       var insertedRowId = rowPathFromRowData(
         insertedRowData,
         insertData.primaryKeys || [],
@@ -1538,7 +1549,8 @@ async function saveRowEditDialog(state) {
         showRowMutationStatus(state.manager, insertedStatusMessage, false);
         if (addedRow) {
           var insertedFocusTarget =
-            addedRow.querySelector('button[data-row-action="edit"]') || addedRow;
+            addedRow.querySelector('button[data-row-action="edit"]') ||
+            addedRow;
           insertedFocusTarget.focus();
         }
       } else {
@@ -1573,7 +1585,8 @@ async function saveRowEditDialog(state) {
         false,
       );
       focusTarget =
-        importedRow.querySelector('button[data-row-action="edit"]') || importedRow;
+        importedRow.querySelector('button[data-row-action="edit"]') ||
+        importedRow;
     } else if (state.currentRow && document.contains(state.currentRow)) {
       focusTarget =
         nextRowActionFocusTarget(state.currentRow, "edit") ||
@@ -1673,7 +1686,9 @@ function renderRowInsertFields(state, data) {
 
   state.hasLoaded = true;
   updateRowEditDialogButtons(state);
-  var firstDefaultButton = state.fields.querySelector(".row-edit-default-set-value");
+  var firstDefaultButton = state.fields.querySelector(
+    ".row-edit-default-set-value",
+  );
   if (firstDefaultButton) {
     firstDefaultButton.focus();
   } else {
@@ -1836,7 +1851,10 @@ async function openRowEditDialog(button, manager) {
   state.currentUpdateUrl = rowUpdateUrl(row);
   state.currentFragmentUrl = rowFragmentUrl(row);
   if (state.currentUpdateUrl) {
-    state.form.action = new URL(state.currentUpdateUrl, location.href).toString();
+    state.form.action = new URL(
+      state.currentUpdateUrl,
+      location.href,
+    ).toString();
   } else {
     state.form.removeAttribute("action");
   }
@@ -1912,7 +1930,10 @@ function openRowInsertDialog(button, manager) {
   state.loadId += 1;
 
   if (state.currentInsertUrl) {
-    state.form.action = new URL(state.currentInsertUrl, location.href).toString();
+    state.form.action = new URL(
+      state.currentInsertUrl,
+      location.href,
+    ).toString();
   } else {
     state.form.removeAttribute("action");
   }
@@ -1923,7 +1944,9 @@ function openRowInsertDialog(button, manager) {
   state.dialog.removeAttribute("aria-describedby");
   setRowDialogTitle(
     state.title,
-    insertData.tableName ? "Insert row into " + insertData.tableName : "Insert row",
+    insertData.tableName
+      ? "Insert row into " + insertData.tableName
+      : "Insert row",
   );
   state.summary.hidden = true;
   state.summary.textContent = "";

From bba7e0b0272b4db0eb9964176aed453c9d3fc8d6 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:28:09 -0700
Subject: [PATCH 212/386] Better docs for makeJumpSections()

Closes #2778
---
 docs/javascript_plugins.rst | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/docs/javascript_plugins.rst b/docs/javascript_plugins.rst
index 4bc9b53c..c4283cac 100644
--- a/docs/javascript_plugins.rst
+++ b/docs/javascript_plugins.rst
@@ -63,22 +63,26 @@ The ``implementation`` object passed to this method should include a ``version``
 
 .. _javascript_plugins_makeJumpSections:
 
-makeJumpSections()
-~~~~~~~~~~~~~~~~~~
+makeJumpSections(context)
+~~~~~~~~~~~~~~~~~~~~~~~~~
 
 This method should return a JavaScript array of objects defining additional sections to be added to the blank state of the ``/`` jump menu, before the user starts typing a search.
 
-Each object should have the following:
+It should return an array of objects, each with the following:
 
 ``id`` - string
     A unique string ID for the section, for example ``agent-chat``
 ``render(node, context)`` - function
     A function that will be called with a DOM node to render the section into
 
-The ``context`` object has the following keys:
+Datasette passes a ``context`` object to both ``makeJumpSections(context)`` and ``render(node, context)``. It has the following keys:
 
 ``navigationSearch``
     The ``<navigation-search>`` custom element instance.
+``container`` - only for ``render()``
+    The ``.results-container`` element used by the jump menu.
+``input`` - only for ``render()``
+    The ``.search-input`` element used by the jump menu.
 
 This example shows how a plugin might add a button for starting a new chat:
 
@@ -87,11 +91,11 @@ This example shows how a plugin might add a button for starting a new chat:
     document.addEventListener('datasette_init', function(ev) {
       ev.detail.registerPlugin('agent-plugin', {
         version: 0.1,
-        makeJumpSections: () => {
+        makeJumpSections: (context) => {
           return [
             {
               id: 'agent-chat',
-              render: node => {
+              render: (node, context) => {
                 node.innerHTML = '<button type="button">Start a new chat</button>';
                 node.querySelector('button').addEventListener('click', () => {
                   location.href = '/-/agent/new';

From 6cd65cf4fb1e23e811085884e49e10501f9fc10f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:39:55 -0700
Subject: [PATCH 213/386] Initial Playwright setup plus first test

Refs #2779
---
 .github/workflows/playwright.yml | 48 +++++++++++++++++++
 pyproject.toml                   |  3 ++
 pytest.ini                       |  3 +-
 tests/conftest.py                | 17 ++++++-
 tests/test_playwright.py         | 79 ++++++++++++++++++++++++++++++++
 5 files changed, 148 insertions(+), 2 deletions(-)
 create mode 100644 .github/workflows/playwright.yml
 create mode 100644 tests/test_playwright.py

diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
new file mode 100644
index 00000000..5275ddef
--- /dev/null
+++ b/.github/workflows/playwright.yml
@@ -0,0 +1,48 @@
+name: Playwright
+
+on:
+  push:
+  pull_request:
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        browser: [chromium, firefox, webkit]
+    steps:
+    - uses: actions/checkout@v6
+    - name: Set up Python 3.14
+      uses: actions/setup-python@v6
+      with:
+        python-version: "3.14"
+        allow-prereleases: true
+        cache: pip
+        cache-dependency-path: pyproject.toml
+    - name: Cache uv
+      uses: actions/cache@v5
+      with:
+        path: ~/.cache/uv
+        key: ${{ runner.os }}-py3.14-uv-${{ hashFiles('pyproject.toml') }}
+        restore-keys: |
+          ${{ runner.os }}-py3.14-uv-
+    - name: Cache Playwright browsers
+      uses: actions/cache@v5
+      with:
+        path: ~/.cache/ms-playwright/
+        key: ${{ runner.os }}-playwright-${{ matrix.browser }}-${{ hashFiles('pyproject.toml') }}
+        restore-keys: |
+          ${{ runner.os }}-playwright-${{ matrix.browser }}-
+    - name: Install uv
+      run: python -m pip install uv
+    - name: Install dependencies
+      run: uv sync --group dev --group playwright
+    - name: Install ${{ matrix.browser }}
+      run: uv run --group dev --group playwright playwright install --with-deps ${{ matrix.browser }}
+    - name: Run Playwright tests
+      run: uv run --group dev --group playwright pytest tests/test_playwright.py --playwright --browser ${{ matrix.browser }}
diff --git a/pyproject.toml b/pyproject.toml
index 0d136d60..a19dc957 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -81,6 +81,9 @@ dev = [
     "ruamel.yaml",
     "psutil>=5.9",
 ]
+playwright = [
+    "pytest-playwright>=0.8.0",
+]
 
 [project.optional-dependencies]
 rich = ["rich"]
diff --git a/pytest.ini b/pytest.ini
index 29b84ea5..75de6925 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -6,4 +6,5 @@ filterwarnings=
     ignore:Using or importing the ABCs::bs4.element
 markers =
     serial: tests to avoid using with pytest-xdist
-asyncio_mode = strict
\ No newline at end of file
+    playwright: browser automation tests, skipped unless --playwright is passed
+asyncio_mode = strict
diff --git a/tests/conftest.py b/tests/conftest.py
index 27d6fa77..04b6f8be 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -96,6 +96,15 @@ def pytest_report_header(config):
     return "SQLite: {}".format(version)
 
 
+def pytest_addoption(parser):
+    parser.addoption(
+        "--playwright",
+        action="store_true",
+        default=False,
+        help="run Playwright browser automation tests",
+    )
+
+
 def pytest_configure(config):
     import sys
 
@@ -108,7 +117,13 @@ def pytest_unconfigure(config):
     del sys._called_from_test
 
 
-def pytest_collection_modifyitems(items):
+def pytest_collection_modifyitems(config, items):
+    if not config.getoption("--playwright"):
+        skip_playwright = pytest.mark.skip(reason="need --playwright option to run")
+        for item in items:
+            if "playwright" in item.keywords:
+                item.add_marker(skip_playwright)
+
     # Ensure test_cli.py and test_black.py and test_inspect.py run first before any asyncio code kicks in
     move_to_front(items, "test_cli")
     move_to_front(items, "test_black")
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
new file mode 100644
index 00000000..abe992bc
--- /dev/null
+++ b/tests/test_playwright.py
@@ -0,0 +1,79 @@
+import socket
+import subprocess
+import sys
+import time
+
+import httpx
+import pytest
+
+from datasette.fixtures import write_fixture_database
+
+
+def find_free_port():
+    with socket.socket() as sock:
+        sock.bind(("127.0.0.1", 0))
+        return sock.getsockname()[1]
+
+
+def wait_for_server(process, url, timeout=10):
+    deadline = time.monotonic() + timeout
+    last_error = None
+    while time.monotonic() < deadline:
+        if process.poll() is not None:
+            stdout, stderr = process.communicate()
+            raise AssertionError(
+                "Datasette server exited early\n"
+                f"stdout:\n{stdout}\n"
+                f"stderr:\n{stderr}"
+            )
+        try:
+            response = httpx.get(url, timeout=1.0)
+            if response.status_code < 500:
+                return
+            last_error = f"HTTP {response.status_code}: {response.text[:200]}"
+        except httpx.HTTPError as ex:
+            last_error = repr(ex)
+        time.sleep(0.1)
+    raise AssertionError(f"Timed out waiting for {url}: {last_error}")
+
+
+@pytest.fixture
+def datasette_server(tmp_path):
+    db_path = tmp_path / "fixtures.db"
+    write_fixture_database(str(db_path))
+    port = find_free_port()
+    process = subprocess.Popen(
+        [
+            sys.executable,
+            "-m",
+            "datasette",
+            str(db_path),
+            "--host",
+            "127.0.0.1",
+            "--port",
+            str(port),
+            "--setting",
+            "num_sql_threads",
+            "1",
+        ],
+        stdout=subprocess.PIPE,
+        stderr=subprocess.PIPE,
+        text=True,
+    )
+    url = f"http://127.0.0.1:{port}/"
+    try:
+        wait_for_server(process, url)
+        yield url
+    finally:
+        process.terminate()
+        try:
+            process.wait(timeout=5)
+        except subprocess.TimeoutExpired:
+            process.kill()
+            process.wait()
+
+
+@pytest.mark.playwright
+def test_datasette_homepage_contains_datasette(page, datasette_server):
+    page.goto(datasette_server)
+    assert "Datasette" in page.locator("body").inner_text()

From 047b69e87f0c94bbd4e59ba151731859158e25e3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:44:17 -0700
Subject: [PATCH 214/386] Port navigation search recents to Playwright

Refs #2779
---
 tests/test_navigation_search_js.py | 200 -----------------------------
 tests/test_playwright.py           |  68 ++++++++++
 2 files changed, 68 insertions(+), 200 deletions(-)

diff --git a/tests/test_navigation_search_js.py b/tests/test_navigation_search_js.py
index b487357d..fc3c7a63 100644
--- a/tests/test_navigation_search_js.py
+++ b/tests/test_navigation_search_js.py
@@ -7,206 +7,6 @@ REPO_ROOT = Path(__file__).resolve().parents[1]
 STATIC_DIR = REPO_ROOT / "datasette" / "static"
 
 
-def test_navigation_search_tracks_and_renders_recent_items():
-    script = textwrap.dedent("""
-        const fs = require("fs");
-        const vm = require("vm");
-        const navigationSearchJs = __NAVIGATION_SEARCH_JS__;
-
-        class FakeElement {
-          constructor() {
-            this.innerHTML = "";
-            this.value = "";
-            this.dataset = {};
-            this.open = false;
-          }
-          addEventListener() {}
-          close() { this.open = false; }
-          focus() {}
-          querySelector() {
-            return { scrollIntoView() {} };
-          }
-          showModal() { this.open = true; }
-        }
-
-        class FakeShadowRoot {
-          constructor() {
-            this.innerHTML = "";
-            this.dialog = new FakeElement();
-            this.input = new FakeElement();
-            this.results = new FakeElement();
-          }
-          querySelector(selector) {
-            if (selector == "dialog") return this.dialog;
-            if (selector == ".search-input") return this.input;
-            if (selector == ".results-container") return this.results;
-            return new FakeElement();
-          }
-        }
-
-        global.HTMLElement = class {
-          constructor() {
-            this.attributes = {};
-          }
-          attachShadow() {
-            this.shadowRoot = new FakeShadowRoot();
-            return this.shadowRoot;
-          }
-          dispatchEvent() {}
-          getAttribute(name) {
-            return this.attributes[name] || null;
-          }
-          querySelector() {
-            return null;
-          }
-          setAttribute(name, value) {
-            this.attributes[name] = value;
-          }
-        };
-        global.CustomEvent = class {
-          constructor(name, options) {
-            this.name = name;
-            this.options = options;
-          }
-        };
-        global.customElements = {
-          registry: new Map(),
-          define(name, cls) {
-            this.registry.set(name, cls);
-          },
-        };
-        global.document = {
-          addEventListener() {},
-          activeElement: null,
-          createElement() {
-            return {
-              set textContent(value) {
-                this.innerHTML = String(value)
-                  .replace(/&/g, "&amp;")
-                  .replace(/</g, "&lt;")
-                  .replace(/>/g, "&gt;")
-                  .replace(/"/g, "&quot;");
-              },
-            };
-          },
-        };
-        global.localStorage = {
-          store: {},
-          getItem(key) {
-            return Object.prototype.hasOwnProperty.call(this.store, key)
-              ? this.store[key]
-              : null;
-          },
-          setItem(key, value) {
-            this.store[key] = String(value);
-          },
-          removeItem(key) {
-            delete this.store[key];
-          },
-        };
-        global.window = { location: { href: "" } };
-
-        vm.runInThisContext(
-          fs.readFileSync(navigationSearchJs, "utf8"),
-          { filename: "navigation-search.js" }
-        );
-
-        const Component = customElements.registry.get("navigation-search");
-        const element = new Component();
-        const items = Array.from({ length: 6 }, (_, index) => ({
-          name: `Item ${index + 1}`,
-          url: `/item-${index + 1}`,
-          type: "table",
-          description: "Table",
-        }));
-        items[5].name = "content: recent_datasette_releases";
-        items[5].display_name = "Recent Datasette releases";
-
-        for (const item of items) {
-          element.matches = [item];
-          element.renderedMatches = [item];
-          element.selectedIndex = 0;
-          element.selectCurrentItem();
-        }
-
-        const stored = JSON.parse(
-          Object.values(localStorage.store).find((value) => value.includes("/item-6"))
-        );
-        if (stored.length !== 5) {
-          throw new Error(`Expected 5 recent items, got ${stored.length}`);
-        }
-        if (stored[0].url !== "/item-6" || stored[4].url !== "/item-2") {
-          throw new Error(`Unexpected recent order: ${JSON.stringify(stored)}`);
-        }
-        if (stored[0].display_name !== "Recent Datasette releases") {
-          throw new Error(`Missing display_name in recent item: ${JSON.stringify(stored[0])}`);
-        }
-
-        element.matches = [
-          items[5],
-          items[4],
-          {
-            name: "Other",
-            url: "/other",
-            type: "database",
-            description: "Database",
-          },
-        ];
-        element.shadowRoot.input.value = "";
-        element.renderResults();
-
-        const html = element.shadowRoot.results.innerHTML;
-        if (!html.includes("Recent")) {
-          throw new Error(`Missing Recent heading: ${html}`);
-        }
-        if (!html.includes("Recent Datasette releases") || !html.includes("Item 5")) {
-          throw new Error(`Missing recent items: ${html}`);
-        }
-        if (!html.includes("content: recent_datasette_releases")) {
-          throw new Error(`Missing canonical item name for display_name item: ${html}`);
-        }
-        if (!html.includes("Item 4") || !html.includes("Item 2")) {
-          throw new Error(`Expected all stored recent items in empty state: ${html}`);
-        }
-        if (html.includes("Other")) {
-          throw new Error(`Rendered non-recent item in empty state: ${html}`);
-        }
-        if (!html.includes("Clear recent")) {
-          throw new Error(`Missing Clear recent control: ${html}`);
-        }
-
-        element.clearRecentItems();
-        if (localStorage.getItem(element.recentItemsStorageKey()) !== null) {
-          throw new Error("Expected recent items to be cleared");
-        }
-        element.renderResults();
-        if (element.shadowRoot.results.innerHTML.includes("Clear recent")) {
-          throw new Error("Clear recent should disappear after clearing");
-        }
-
-        process.stdout.write(JSON.stringify(stored));
-        """).replace(
-        "__NAVIGATION_SEARCH_JS__",
-        json.dumps(str(STATIC_DIR / "navigation-search.js")),
-    )
-    result = subprocess.run(
-        ["node", "-e", script],
-        cwd=REPO_ROOT,
-        text=True,
-        capture_output=True,
-        check=False,
-    )
-    assert result.returncode == 0, result.stderr
-    assert [item["url"] for item in json.loads(result.stdout)] == [
-        "/item-6",
-        "/item-5",
-        "/item-4",
-        "/item-3",
-        "/item-2",
-    ]
-    assert json.loads(result.stdout)[0]["display_name"] == "Recent Datasette releases"
-
-
 def test_navigation_search_renders_jump_sections_from_javascript_plugins():
     script = (
         textwrap.dedent("""
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index abe992bc..726536d9 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -77,3 +77,71 @@ def datasette_server(tmp_path):
 def test_datasette_homepage_contains_datasette(page, datasette_server):
     page.goto(datasette_server)
     assert "Datasette" in page.locator("body").inner_text()
+
+
+@pytest.mark.playwright
+def test_navigation_search_tracks_and_renders_recent_items(page, datasette_server):
+    page.goto(datasette_server)
+    result = page.evaluate("""
+    async () => {
+      await customElements.whenDefined("navigation-search");
+      const element = document.querySelector("navigation-search");
+      const key = element.recentItemsStorageKey();
+      localStorage.removeItem(key);
+
+      const items = Array.from({ length: 6 }, (_, index) => ({
+        name: `Item ${index + 1}`,
+        url: `/item-${index + 1}`,
+        type: "table",
+        description: "Table",
+      }));
+      items[5].name = "content: recent_datasette_releases";
+      items[5].display_name = "Recent Datasette releases";
+
+      for (const item of items) {
+        element.saveRecentItem(item);
+      }
+
+      const stored = JSON.parse(localStorage.getItem(key));
+      element.matches = [
+        items[5],
+        items[4],
+        {
+          name: "Other",
+          url: "/other",
+          type: "database",
+          description: "Database",
+        },
+      ];
+      element.shadowRoot.querySelector(".search-input").value = "";
+      element.renderResults();
+      const html = element.shadowRoot.querySelector(".results-container").innerHTML;
+
+      element.clearRecentItems();
+      const clearedValue = localStorage.getItem(key);
+      element.renderResults();
+      const htmlAfterClear = element.shadowRoot
+        .querySelector(".results-container")
+        .innerHTML;
+
+      return { stored, html, clearedValue, htmlAfterClear };
+    }
+    """)
+    assert [item["url"] for item in result["stored"]] == [
+        "/item-6",
+        "/item-5",
+        "/item-4",
+        "/item-3",
+        "/item-2",
+    ]
+    assert result["stored"][0]["display_name"] == "Recent Datasette releases"
+    assert "Recent" in result["html"]
+    assert "Recent Datasette releases" in result["html"]
+    assert "Item 5" in result["html"]
+    assert "content: recent_datasette_releases" in result["html"]
+    assert "Item 4" in result["html"]
+    assert "Item 2" in result["html"]
+    assert "Other" not in result["html"]
+    assert "Clear recent" in result["html"]
+    assert result["clearedValue"] is None
+    assert "Clear recent" not in result["htmlAfterClear"]

From 6bbd33d81da6b0b599639e07f212602a3b25f48b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:44:59 -0700
Subject: [PATCH 215/386] Port navigation jump sections to Playwright

Refs #2779
---
 tests/test_navigation_search_js.py | 194 -----------------------------
 tests/test_playwright.py           |  38 ++++++
 2 files changed, 38 insertions(+), 194 deletions(-)
 delete mode 100644 tests/test_navigation_search_js.py

diff --git a/tests/test_navigation_search_js.py b/tests/test_navigation_search_js.py
deleted file mode 100644
index fc3c7a63..00000000
--- a/tests/test_navigation_search_js.py
+++ /dev/null
@@ -1,194 +0,0 @@
-import json
-from pathlib import Path
-import subprocess
-import textwrap
-
-REPO_ROOT = Path(__file__).resolve().parents[1]
-STATIC_DIR = REPO_ROOT / "datasette" / "static"
-
-
-def test_navigation_search_renders_jump_sections_from_javascript_plugins():
-    script = (
-        textwrap.dedent("""
-        const fs = require("fs");
-        const vm = require("vm");
-        const datasetteManagerJs = __DATASETTE_MANAGER_JS__;
-        const navigationSearchJs = __NAVIGATION_SEARCH_JS__;
-
-        const documentListeners = {};
-
-        class FakeElement {
-          constructor(tagName = "div", parent = null) {
-            this._innerHTML = "";
-            this.value = "";
-            this.dataset = {};
-            this.open = false;
-            this.parent = parent;
-            this.tagName = tagName.toUpperCase();
-          }
-          set textContent(value) {
-            this.innerHTML = String(value)
-              .replace(/&/g, "&amp;")
-              .replace(/</g, "&lt;")
-              .replace(/>/g, "&gt;")
-              .replace(/"/g, "&quot;");
-          }
-          get innerHTML() {
-            return this._innerHTML;
-          }
-          set innerHTML(value) {
-            this._innerHTML = String(value);
-            if (this.parent) {
-              this.parent._innerHTML += this._innerHTML;
-            }
-          }
-          addEventListener() {}
-          appendChild(child) {
-            this._innerHTML += child.innerHTML || "";
-            return child;
-          }
-          close() { this.open = false; }
-          focus() {}
-          querySelector(selector) {
-            if (selector.startsWith("[data-jump-section-index=")) {
-              return new FakeElement("div", this);
-            }
-            return { scrollIntoView() {} };
-          }
-          showModal() { this.open = true; }
-        }
-
-        class FakeShadowRoot {
-          constructor() {
-            this.innerHTML = "";
-            this.dialog = new FakeElement("dialog");
-            this.input = new FakeElement("input");
-            this.results = new FakeElement("div");
-          }
-          querySelector(selector) {
-            if (selector == "dialog") return this.dialog;
-            if (selector == ".search-input") return this.input;
-            if (selector == ".results-container") return this.results;
-            return new FakeElement();
-          }
-        }
-
-        global.HTMLElement = class {
-          constructor() {
-            this.attributes = {};
-          }
-          attachShadow() {
-            this.shadowRoot = new FakeShadowRoot();
-            return this.shadowRoot;
-          }
-          dispatchEvent() {}
-          getAttribute(name) {
-            return this.attributes[name] || null;
-          }
-          querySelector() {
-            return null;
-          }
-          setAttribute(name, value) {
-            this.attributes[name] = value;
-          }
-        };
-        global.CustomEvent = class {
-          constructor(name, options) {
-            this.name = name;
-            this.type = name;
-            this.detail = options ? options.detail : undefined;
-          }
-        };
-        global.customElements = {
-          registry: new Map(),
-          define(name, cls) {
-            this.registry.set(name, cls);
-          },
-        };
-        global.document = {
-          addEventListener(name, callback) {
-            documentListeners[name] = documentListeners[name] || [];
-            documentListeners[name].push(callback);
-          },
-          activeElement: null,
-          createElement(tagName) {
-            return new FakeElement(tagName);
-          },
-          dispatchEvent(event) {
-            for (const callback of documentListeners[event.type] || []) {
-              callback(event);
-            }
-          },
-          querySelectorAll() {
-            return [];
-          },
-        };
-        global.localStorage = {
-          getItem() { return null; },
-          setItem() {},
-          removeItem() {},
-        };
-        global.window = { datasetteVersion: "test", location: { href: "" } };
-
-        vm.runInThisContext(
-          fs.readFileSync(datasetteManagerJs, "utf8"),
-          { filename: "datasette-manager.js" }
-        );
-        for (const callback of documentListeners.DOMContentLoaded || []) {
-          callback();
-        }
-        window.__DATASETTE__.registerPlugin("agent", {
-          version: "0.1",
-          makeJumpSections() {
-            return [
-              {
-                id: "agent-chat",
-                render(node, context) {
-                  if (!context.navigationSearch) {
-                    throw new Error("Expected navigationSearch in render context");
-                  }
-                  node.innerHTML = [
-                    '<section class="agent-jump-start">',
-                    '<button>Start a new agent chat</button>',
-                    '</section>',
-                  ].join('');
-                },
-              },
-            ];
-          },
-        });
-
-        vm.runInThisContext(
-          fs.readFileSync(navigationSearchJs, "utf8"),
-          { filename: "navigation-search.js" }
-        );
-
-        const Component = customElements.registry.get("navigation-search");
-        const element = new Component();
-        element.shadowRoot.input.value = "";
-        element.renderResults();
-
-        const html = element.shadowRoot.results.innerHTML;
-        if (!html.includes("Start a new agent chat")) {
-          throw new Error(`Missing jump section content: ${html}`);
-        }
-        process.stdout.write("ok");
-        """)
-        .replace(
-            "__DATASETTE_MANAGER_JS__",
-            json.dumps(str(STATIC_DIR / "datasette-manager.js")),
-        )
-        .replace(
-            "__NAVIGATION_SEARCH_JS__",
-            json.dumps(str(STATIC_DIR / "navigation-search.js")),
-        )
-    )
-    result = subprocess.run(
-        ["node", "-e", script],
-        cwd=REPO_ROOT,
-        text=True,
-        capture_output=True,
-        check=False,
-    )
-    assert result.returncode == 0, result.stderr
-    assert result.stdout.endswith("ok")
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 726536d9..caea8b16 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -145,3 +145,41 @@ def test_navigation_search_tracks_and_renders_recent_items(page, datasette_serve
     assert "Clear recent" in result["html"]
     assert result["clearedValue"] is None
     assert "Clear recent" not in result["htmlAfterClear"]
+
+
+@pytest.mark.playwright
+def test_navigation_search_renders_jump_sections_from_javascript_plugins(
+    page, datasette_server
+):
+    page.goto(datasette_server)
+    html = page.evaluate("""
+    async () => {
+      await customElements.whenDefined("navigation-search");
+      window.__DATASETTE__.registerPlugin("agent", {
+        version: "0.1",
+        makeJumpSections() {
+          return [
+            {
+              id: "agent-chat",
+              render(node, context) {
+                if (!context.navigationSearch) {
+                  throw new Error("Expected navigationSearch in render context");
+                }
+                node.innerHTML = [
+                  '<section class="agent-jump-start">',
+                  '<button>Start a new agent chat</button>',
+                  '</section>',
+                ].join("");
+              },
+            },
+          ];
+        },
+      });
+
+      const element = document.querySelector("navigation-search");
+      element.shadowRoot.querySelector(".search-input").value = "";
+      element.renderResults();
+      return element.shadowRoot.querySelector(".results-container").innerHTML;
+    }
+    """)
+    assert "Start a new agent chat" in html

From b5fa485a9f2588aa53e98c27691ae80540000be2 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:45:48 -0700
Subject: [PATCH 216/386] Port datasette manager plugin test to Playwright

Refs #2779
---
 tests/test_datasette_manager_js.py | 70 ------------------------------
 tests/test_playwright.py           | 30 +++++++++++++
 2 files changed, 30 insertions(+), 70 deletions(-)

diff --git a/tests/test_datasette_manager_js.py b/tests/test_datasette_manager_js.py
index 01b6bbac..1a46bb42 100644
--- a/tests/test_datasette_manager_js.py
+++ b/tests/test_datasette_manager_js.py
@@ -6,76 +6,6 @@ import textwrap
 STATIC_DIR = Path(__file__).resolve().parents[1] / "datasette" / "static"
 
 
-def test_datasette_manager_make_column_field():
-    script = textwrap.dedent("""
-        const fs = require("fs");
-        const vm = require("vm");
-        const datasetteManagerJs = __DATASETTE_MANAGER_JS__;
-
-        const documentListeners = {};
-        global.CustomEvent = class {
-          constructor(name, options) {
-            this.type = name;
-            this.detail = options ? options.detail : undefined;
-          }
-        };
-        global.document = {
-          addEventListener(name, callback) {
-            documentListeners[name] = documentListeners[name] || [];
-            documentListeners[name].push(callback);
-          },
-          dispatchEvent(event) {
-            for (const callback of documentListeners[event.type] || []) {
-              callback(event);
-            }
-          },
-        };
-        global.window = { datasetteVersion: "test" };
-
-        vm.runInThisContext(
-          fs.readFileSync(datasetteManagerJs, "utf8"),
-          { filename: "datasette-manager.js" }
-        );
-        for (const callback of documentListeners.DOMContentLoaded || []) {
-          callback();
-        }
-
-        window.__DATASETTE__.registerPlugin("declines", {
-          makeColumnField() {
-            return;
-          },
-        });
-        window.__DATASETTE__.registerPlugin("handles", {
-          makeColumnField(context) {
-            if (context.columnType.type !== "demo") {
-              return;
-            }
-            return { useTextarea: true };
-          },
-        });
-
-        const control = window.__DATASETTE__.makeColumnField({
-          column: "body",
-          columnType: { type: "demo", config: null },
-        });
-        console.log(JSON.stringify(control));
-    """).replace(
-        "__DATASETTE_MANAGER_JS__",
-        json.dumps(str(STATIC_DIR / "datasette-manager.js")),
-    )
-    result = subprocess.run(
-        ["node", "-e", script],
-        text=True,
-        capture_output=True,
-        check=False,
-    )
-    assert result.returncode == 0, result.stderr
-    assert json.loads(result.stdout) == {
-        "pluginName": "handles",
-        "useTextarea": True,
-    }
-
-
 def test_table_plugin_column_field_api():
     script = textwrap.dedent("""
         const fs = require("fs");
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index caea8b16..353f1d94 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -183,3 +183,33 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins(
     }
     """)
     assert "Start a new agent chat" in html
+
+
+@pytest.mark.playwright
+def test_datasette_manager_make_column_field(page, datasette_server):
+    page.goto(datasette_server)
+    control = page.evaluate("""
+    () => {
+      window.__DATASETTE__.registerPlugin("declines", {
+        makeColumnField() {
+          return;
+        },
+      });
+      window.__DATASETTE__.registerPlugin("handles", {
+        makeColumnField(context) {
+          if (context.columnType.type !== "demo") {
+            return;
+          }
+          return { useTextarea: true };
+        },
+      });
+      return window.__DATASETTE__.makeColumnField({
+        column: "body",
+        columnType: { type: "demo", config: null },
+      });
+    }
+    """)
+    assert control == {
+        "pluginName": "handles",
+        "useTextarea": True,
+    }

From 3cfdca026ad0d8173e3094a3c4776694ee6443b4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:48:32 -0700
Subject: [PATCH 217/386] Port edit tools field API test to Playwright

Refs #2779
---
 tests/test_datasette_manager_js.py | 387 -----------------------------
 tests/test_playwright.py           | 329 ++++++++++++++++++++++++
 2 files changed, 329 insertions(+), 387 deletions(-)

diff --git a/tests/test_datasette_manager_js.py b/tests/test_datasette_manager_js.py
index 1a46bb42..9022d26f 100644
--- a/tests/test_datasette_manager_js.py
+++ b/tests/test_datasette_manager_js.py
@@ -6,393 +6,6 @@ import textwrap
 STATIC_DIR = Path(__file__).resolve().parents[1] / "datasette" / "static"
 
 
-def test_table_plugin_column_field_api():
-    script = textwrap.dedent("""
-        const fs = require("fs");
-        const vm = require("vm");
-        const editToolsJs = __EDIT_TOOLS_JS__;
-
-        class FakeEvent {
-          constructor(type, options) {
-            this.type = type;
-            this.bubbles = !!(options && options.bubbles);
-          }
-        }
-
-        class FakeElement {
-          constructor(tagName = "div") {
-            this.nodeName = tagName.toUpperCase();
-            this.nodeType = 1;
-            this.children = [];
-            this.dataset = {};
-            this.attributes = {};
-            this.value = "";
-            this.name = "";
-            this.disabled = false;
-            this.readOnly = false;
-            this.dispatchedEvents = [];
-            this.eventListeners = {};
-            this.validationMessage = "";
-            this.hidden = false;
-            this.textContent = "";
-            this.className = "";
-            this.classList = {
-              add: (...names) => {
-                const classes = new Set(this.className.split(/\\s+/).filter(Boolean));
-                for (const name of names) {
-                  classes.add(name);
-                }
-                this.className = Array.from(classes).join(" ");
-              },
-              remove: (...names) => {
-                const removeNames = new Set(names);
-                this.className = this.className
-                  .split(/\\s+/)
-                  .filter((name) => name && !removeNames.has(name))
-                  .join(" ");
-              },
-              contains: (name) => this.className.split(/\\s+/).includes(name),
-            };
-          }
-          appendChild(child) {
-            this.children.push(child);
-            child.parentNode = this;
-            return child;
-          }
-          addEventListener(type, callback) {
-            this.eventListeners[type] = this.eventListeners[type] || [];
-            this.eventListeners[type].push(callback);
-          }
-          dispatchEvent(event) {
-            event.target = event.target || this;
-            this.dispatchedEvents.push(event.type);
-            for (const callback of this.eventListeners[event.type] || []) {
-              callback(event);
-            }
-            return true;
-          }
-          setAttribute(name, value) {
-            this.attributes[name] = String(value);
-          }
-          getAttribute(name) {
-            return this.attributes[name] || null;
-          }
-          removeAttribute(name) {
-            delete this.attributes[name];
-          }
-          setCustomValidity(message) {
-            this.validationMessage = message;
-          }
-        }
-
-        global.Event = FakeEvent;
-        global.document = {
-          addEventListener() {},
-          createElement(tagName) {
-            return new FakeElement(tagName);
-          },
-          createTextNode(text) {
-            const node = new FakeElement("#text");
-            node.textContent = text;
-            return node;
-          },
-        };
-        global.location = {
-          href: "http://localhost/data/projects",
-          pathname: "/data/projects",
-          search: "",
-        };
-        global.window = {
-          _datasetteTableData: {
-            database: "data",
-            table: "projects",
-            tableUrl: "/data/projects",
-          },
-        };
-
-        vm.runInThisContext(fs.readFileSync(editToolsJs, "utf8"), {
-          filename: "edit-tools.js",
-        });
-
-        const context = columnFormControlContext(
-          "logo",
-          true,
-          { type: "file", config: null },
-          {
-            mode: "edit",
-            defaultExpression: "lower(hex(randomblob(4)))",
-            useSqliteDefault: true,
-          }
-        );
-        const expectedContextKeys = [
-          "mode",
-          "database",
-          "table",
-          "tableUrl",
-          "column",
-          "columnType",
-          "sqliteType",
-          "notNull",
-          "isPk",
-          "defaultExpression",
-          "form",
-          "dialog",
-        ].join(",");
-        if (Object.keys(context).join(",") !== expectedContextKeys) {
-          throw new Error(`Unexpected context keys: ${Object.keys(context).join(",")}`);
-        }
-        if (context.defaultExpression !== "lower(hex(randomblob(4)))") {
-          throw new Error("context.defaultExpression was not set");
-        }
-        if (JSON.stringify(context.columnType) !== '{"type":"file","config":{}}') {
-          throw new Error("context.columnType should expose type and object config");
-        }
-        if (!context.isPk) {
-          throw new Error("context.isPk should say whether the column is a primary key");
-        }
-
-        const control = new FakeElement("input");
-        control.name = "logo";
-        control.value = "df-old";
-        control.dataset.initialValue = "df-old";
-        control.dataset.initialValueKind = "string";
-        control.dataset.currentValueKind = "string";
-        control.dataset.useSqliteDefault = "1";
-        control.disabled = true;
-
-        const field = createColumnFieldApi({
-          id: "row-edit-field-0",
-          labelId: "row-edit-field-label-0",
-          descriptionId: "row-edit-field-meta-0",
-          control,
-          meta: new FakeElement("span"),
-          context,
-        });
-
-        let renderArgumentCount = null;
-        let renderField = null;
-        const wrapper = renderColumnField(
-          {
-            pluginName: "test-plugin",
-            render(field) {
-              renderArgumentCount = arguments.length;
-              renderField = field;
-              return document.createElement("button");
-            },
-          },
-          field
-        );
-        if (renderArgumentCount !== 1 || renderField !== field) {
-          throw new Error("plugin render should receive the field object only");
-        }
-        if (field.root !== wrapper) {
-          throw new Error("field.root should be the plugin wrapper");
-        }
-        if (wrapper.children.length !== 1 || wrapper.children[0].nodeName !== "BUTTON") {
-          throw new Error("plugin render should append returned DOM nodes to field.root");
-        }
-
-        field.setValue(null);
-        if (field.getValue() !== null) {
-          throw new Error("field.setValue(null) should round-trip as null");
-        }
-        if (field.isUsingSqliteDefault()) {
-          throw new Error("field.setValue() should stop using the SQLite default");
-        }
-        if (control.dataset.currentValueKind !== "null") {
-          throw new Error("null values should update currentValueKind");
-        }
-
-        field.setValue("df-new");
-        if (field.getValue() !== "df-new") {
-          throw new Error("field.setValue() should update the current value");
-        }
-        if (field.getInitialValue() !== "df-old") {
-          throw new Error("field.getInitialValue() should remain stable");
-        }
-        if (!field.hasChanged()) {
-          throw new Error("field.hasChanged() should notice plugin value changes");
-        }
-        if (control.dispatchedEvents.length !== 0) {
-          throw new Error(`field.setValue() should not dispatch events: ${control.dispatchedEvents}`);
-        }
-
-        const dirtyRowField = new FakeElement("div");
-        dirtyRowField._datasetteColumnFormField = field;
-        const dirtyState = {
-          hasLoaded: true,
-          isLoading: false,
-          isSaving: false,
-          mode: "edit",
-          fields: {
-            querySelectorAll(selector) {
-              return selector === ".row-edit-field" ? [dirtyRowField] : [];
-            },
-          },
-          dialog: {
-            closeCalled: false,
-            close() {
-              this.closeCalled = true;
-            },
-          },
-          shouldRestoreFocus: false,
-        };
-        const confirmMessages = [];
-        window.confirm = (message) => {
-          confirmMessages.push(message);
-          return false;
-        };
-        if (!rowEditDialogHasChanges(dirtyState)) {
-          throw new Error("row edit dialog should notice changed field values");
-        }
-        if (closeRowEditDialogIfConfirmed(dirtyState)) {
-          throw new Error("dirty row edit dialog should stay open when discard is rejected");
-        }
-        if (dirtyState.dialog.closeCalled) {
-          throw new Error("dirty row edit dialog should not close when discard is rejected");
-        }
-        if (confirmMessages[0] !== "Discard unsaved changes to this row?") {
-          throw new Error(`Unexpected discard confirmation: ${confirmMessages[0]}`);
-        }
-        dirtyState.mode = "insert";
-        window.confirm = (message) => {
-          confirmMessages.push(message);
-          return true;
-        };
-        if (!closeRowEditDialogIfConfirmed(dirtyState)) {
-          throw new Error("dirty row edit dialog should close when discard is confirmed");
-        }
-        if (!dirtyState.dialog.closeCalled || !dirtyState.shouldRestoreFocus) {
-          throw new Error("confirmed dirty row edit dialog should close and restore focus");
-        }
-        if (confirmMessages[1] !== "Discard this new row?") {
-          throw new Error(`Unexpected insert discard confirmation: ${confirmMessages[1]}`);
-        }
-
-        const cleanContext = columnFormControlContext(
-          "title",
-          false,
-          null,
-          { mode: "edit" }
-        );
-        if (cleanContext.defaultExpression !== null) {
-          throw new Error("context.defaultExpression should be null without a SQLite default");
-        }
-        const cleanControl = new FakeElement("input");
-        cleanControl.name = "title";
-        cleanControl.value = "clean";
-        cleanControl.dataset.initialValue = "clean";
-        cleanControl.dataset.initialValueKind = "string";
-        cleanControl.dataset.currentValueKind = "string";
-        const cleanField = createColumnFieldApi({
-          id: "row-edit-field-1",
-          labelId: "row-edit-field-label-1",
-          descriptionId: "row-edit-field-meta-1",
-          control: cleanControl,
-          meta: new FakeElement("span"),
-          context: cleanContext,
-        });
-        const cleanRowField = new FakeElement("div");
-        cleanRowField._datasetteColumnFormField = cleanField;
-        const cleanState = {
-          hasLoaded: true,
-          isLoading: false,
-          isSaving: false,
-          mode: "edit",
-          fields: {
-            querySelectorAll(selector) {
-              return selector === ".row-edit-field" ? [cleanRowField] : [];
-            },
-          },
-          dialog: {
-            closeCalled: false,
-            close() {
-              this.closeCalled = true;
-            },
-          },
-          shouldRestoreFocus: false,
-        };
-        confirmMessages.length = 0;
-        window.confirm = (message) => {
-          confirmMessages.push(message);
-          return false;
-        };
-        if (rowEditDialogHasChanges(cleanState)) {
-          throw new Error("row edit dialog should ignore unchanged field values");
-        }
-        if (!closeRowEditDialogIfConfirmed(cleanState)) {
-          throw new Error("clean row edit dialog should close without confirmation");
-        }
-        if (!cleanState.dialog.closeCalled || !cleanState.shouldRestoreFocus) {
-          throw new Error("clean row edit dialog should close and restore focus");
-        }
-        if (confirmMessages.length !== 0) {
-          throw new Error("clean row edit dialog should not ask for confirmation");
-        }
-
-        dirtyState.dialog.closeCalled = false;
-        dirtyState.shouldRestoreFocus = false;
-        confirmMessages.length = 0;
-        field.setValue("<p></p>");
-        field.markClean();
-        if (field.hasChanged()) {
-          throw new Error("field.markClean() should update the clean baseline");
-        }
-        if (rowEditDialogHasChanges(dirtyState)) {
-          throw new Error("row edit dialog should ignore clean plugin normalization");
-        }
-        if (!closeRowEditDialogIfConfirmed(dirtyState)) {
-          throw new Error("normalized row edit dialog should close without confirmation");
-        }
-        if (confirmMessages.length !== 0) {
-          throw new Error("normalized row edit dialog should not ask for confirmation");
-        }
-        field.setValue("<p>Hello</p>");
-        if (!field.hasChanged() || !rowEditDialogHasChanges(dirtyState)) {
-          throw new Error("later plugin value changes should still count as dirty");
-        }
-
-        try {
-          field.setValue({ id: "df-object" });
-          throw new Error("field.setValue() should reject object values");
-        } catch (error) {
-          if (!String(error.message).includes("serialize objects")) {
-            throw error;
-          }
-        }
-
-        field.setValidity("Pick a file");
-        if (control.validationMessage !== "Pick a file") {
-          throw new Error("field.setValidity() should set custom validity");
-        }
-        if (control.getAttribute("aria-invalid") !== "true") {
-          throw new Error("field.setValidity() should set aria-invalid");
-        }
-        if (!field.validationMessageElement || field.validationMessageElement.hidden) {
-          throw new Error("field.setValidity() should show a field validation message");
-        }
-        field.clearValidity();
-        if (control.validationMessage !== "" || control.getAttribute("aria-invalid") !== null) {
-          throw new Error("field.clearValidity() should clear custom validity");
-        }
-
-        field.useSqliteDefault();
-        if (!field.isUsingSqliteDefault() || !control.disabled) {
-          throw new Error("field.useSqliteDefault() should mark and disable control");
-        }
-
-        process.stdout.write("ok");
-    """).replace("__EDIT_TOOLS_JS__", json.dumps(str(STATIC_DIR / "edit-tools.js")))
-    result = subprocess.run(
-        ["node", "-e", script],
-        text=True,
-        capture_output=True,
-        check=False,
-    )
-    assert result.returncode == 0, result.stderr
-    assert result.stdout == "ok"
-
-
 def test_builtin_json_column_field_validation():
     script = textwrap.dedent("""
         const fs = require("fs");
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 353f1d94..06ae826d 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -79,6 +79,20 @@ def test_datasette_homepage_contains_datasette(page, datasette_server):
     assert "Datasette" in page.locator("body").inner_text()
 
 
+def load_edit_tools(page, datasette_server):
+    page.goto(datasette_server)
+    page.evaluate("""
+    () => {
+      window._datasetteTableData = {
+        database: "data",
+        table: "projects",
+        tableUrl: "/data/projects",
+      };
+    }
+    """)
+    page.add_script_tag(url=f"{datasette_server}-/static/edit-tools.js")
+
+
 @pytest.mark.playwright
 def test_navigation_search_tracks_and_renders_recent_items(page, datasette_server):
     page.goto(datasette_server)
@@ -213,3 +227,318 @@ def test_datasette_manager_make_column_field(page, datasette_server):
         "pluginName": "handles",
         "useTextarea": True,
     }
+
+
+@pytest.mark.playwright
+def test_table_plugin_column_field_api(page, datasette_server):
+    load_edit_tools(page, datasette_server)
+    page.evaluate("""
+    () => {
+      const assert = (condition, message) => {
+        if (!condition) {
+          throw new Error(message);
+        }
+      };
+
+      const context = columnFormControlContext(
+        "logo",
+        true,
+        { type: "file", config: null },
+        {
+          mode: "edit",
+          defaultExpression: "lower(hex(randomblob(4)))",
+          useSqliteDefault: true,
+        },
+      );
+      const expectedContextKeys = [
+        "mode",
+        "database",
+        "table",
+        "tableUrl",
+        "column",
+        "columnType",
+        "sqliteType",
+        "notNull",
+        "isPk",
+        "defaultExpression",
+        "form",
+        "dialog",
+      ].join(",");
+      assert(
+        Object.keys(context).join(",") === expectedContextKeys,
+        `Unexpected context keys: ${Object.keys(context).join(",")}`,
+      );
+      assert(
+        context.defaultExpression === "lower(hex(randomblob(4)))",
+        "context.defaultExpression was not set",
+      );
+      assert(
+        JSON.stringify(context.columnType) === '{"type":"file","config":{}}',
+        "context.columnType should expose type and object config",
+      );
+      assert(
+        context.isPk,
+        "context.isPk should say whether the column is a primary key",
+      );
+
+      const control = document.createElement("input");
+      control.name = "logo";
+      control.value = "df-old";
+      control.dataset.initialValue = "df-old";
+      control.dataset.initialValueKind = "string";
+      control.dataset.currentValueKind = "string";
+      control.dataset.useSqliteDefault = "1";
+      control.disabled = true;
+      const dispatchedEvents = [];
+      control.addEventListener("input", (event) =>
+        dispatchedEvents.push(event.type),
+      );
+      control.addEventListener("change", (event) =>
+        dispatchedEvents.push(event.type),
+      );
+
+      const field = createColumnFieldApi({
+        id: "row-edit-field-0",
+        labelId: "row-edit-field-label-0",
+        descriptionId: "row-edit-field-meta-0",
+        control,
+        meta: document.createElement("span"),
+        context,
+      });
+
+      let renderArgumentCount = null;
+      let renderField = null;
+      const wrapper = renderColumnField(
+        {
+          pluginName: "test-plugin",
+          render(field) {
+            renderArgumentCount = arguments.length;
+            renderField = field;
+            return document.createElement("button");
+          },
+        },
+        field,
+      );
+      assert(
+        renderArgumentCount === 1 && renderField === field,
+        "plugin render should receive the field object only",
+      );
+      assert(field.root === wrapper, "field.root should be the plugin wrapper");
+      assert(
+        wrapper.children.length === 1 &&
+          wrapper.children[0].nodeName === "BUTTON",
+        "plugin render should append returned DOM nodes to field.root",
+      );
+
+      field.setValue(null);
+      assert(field.getValue() === null, "field.setValue(null) should round-trip as null");
+      assert(
+        !field.isUsingSqliteDefault(),
+        "field.setValue() should stop using the SQLite default",
+      );
+      assert(
+        control.dataset.currentValueKind === "null",
+        "null values should update currentValueKind",
+      );
+
+      field.setValue("df-new");
+      assert(
+        field.getValue() === "df-new",
+        "field.setValue() should update the current value",
+      );
+      assert(
+        field.getInitialValue() === "df-old",
+        "field.getInitialValue() should remain stable",
+      );
+      assert(
+        field.hasChanged(),
+        "field.hasChanged() should notice plugin value changes",
+      );
+      assert(
+        dispatchedEvents.length === 0,
+        `field.setValue() should not dispatch events: ${dispatchedEvents}`,
+      );
+
+      const dirtyRowField = document.createElement("div");
+      dirtyRowField.className = "row-edit-field";
+      dirtyRowField._datasetteColumnFormField = field;
+      const dirtyFields = document.createElement("div");
+      dirtyFields.appendChild(dirtyRowField);
+      const dirtyState = {
+        hasLoaded: true,
+        isLoading: false,
+        isSaving: false,
+        mode: "edit",
+        fields: dirtyFields,
+        dialog: {
+          closeCalled: false,
+          close() {
+            this.closeCalled = true;
+          },
+        },
+        shouldRestoreFocus: false,
+      };
+      const confirmMessages = [];
+      window.confirm = (message) => {
+        confirmMessages.push(message);
+        return false;
+      };
+      assert(
+        rowEditDialogHasChanges(dirtyState),
+        "row edit dialog should notice changed field values",
+      );
+      assert(
+        !closeRowEditDialogIfConfirmed(dirtyState),
+        "dirty row edit dialog should stay open when discard is rejected",
+      );
+      assert(
+        !dirtyState.dialog.closeCalled,
+        "dirty row edit dialog should not close when discard is rejected",
+      );
+      assert(
+        confirmMessages[0] === "Discard unsaved changes to this row?",
+        `Unexpected discard confirmation: ${confirmMessages[0]}`,
+      );
+      dirtyState.mode = "insert";
+      window.confirm = (message) => {
+        confirmMessages.push(message);
+        return true;
+      };
+      assert(
+        closeRowEditDialogIfConfirmed(dirtyState),
+        "dirty row edit dialog should close when discard is confirmed",
+      );
+      assert(
+        dirtyState.dialog.closeCalled && dirtyState.shouldRestoreFocus,
+        "confirmed dirty row edit dialog should close and restore focus",
+      );
+      assert(
+        confirmMessages[1] === "Discard this new row?",
+        `Unexpected insert discard confirmation: ${confirmMessages[1]}`,
+      );
+
+      const cleanContext = columnFormControlContext("title", false, null, {
+        mode: "edit",
+      });
+      assert(
+        cleanContext.defaultExpression === null,
+        "context.defaultExpression should be null without a SQLite default",
+      );
+      const cleanControl = document.createElement("input");
+      cleanControl.name = "title";
+      cleanControl.value = "clean";
+      cleanControl.dataset.initialValue = "clean";
+      cleanControl.dataset.initialValueKind = "string";
+      cleanControl.dataset.currentValueKind = "string";
+      const cleanField = createColumnFieldApi({
+        id: "row-edit-field-1",
+        labelId: "row-edit-field-label-1",
+        descriptionId: "row-edit-field-meta-1",
+        control: cleanControl,
+        meta: document.createElement("span"),
+        context: cleanContext,
+      });
+      const cleanRowField = document.createElement("div");
+      cleanRowField.className = "row-edit-field";
+      cleanRowField._datasetteColumnFormField = cleanField;
+      const cleanFields = document.createElement("div");
+      cleanFields.appendChild(cleanRowField);
+      const cleanState = {
+        hasLoaded: true,
+        isLoading: false,
+        isSaving: false,
+        mode: "edit",
+        fields: cleanFields,
+        dialog: {
+          closeCalled: false,
+          close() {
+            this.closeCalled = true;
+          },
+        },
+        shouldRestoreFocus: false,
+      };
+      confirmMessages.length = 0;
+      window.confirm = (message) => {
+        confirmMessages.push(message);
+        return false;
+      };
+      assert(
+        !rowEditDialogHasChanges(cleanState),
+        "row edit dialog should ignore unchanged field values",
+      );
+      assert(
+        closeRowEditDialogIfConfirmed(cleanState),
+        "clean row edit dialog should close without confirmation",
+      );
+      assert(
+        cleanState.dialog.closeCalled && cleanState.shouldRestoreFocus,
+        "clean row edit dialog should close and restore focus",
+      );
+      assert(
+        confirmMessages.length === 0,
+        "clean row edit dialog should not ask for confirmation",
+      );
+
+      dirtyState.dialog.closeCalled = false;
+      dirtyState.shouldRestoreFocus = false;
+      confirmMessages.length = 0;
+      field.setValue("<p></p>");
+      field.markClean();
+      assert(
+        !field.hasChanged(),
+        "field.markClean() should update the clean baseline",
+      );
+      assert(
+        !rowEditDialogHasChanges(dirtyState),
+        "row edit dialog should ignore clean plugin normalization",
+      );
+      assert(
+        closeRowEditDialogIfConfirmed(dirtyState),
+        "normalized row edit dialog should close without confirmation",
+      );
+      assert(
+        confirmMessages.length === 0,
+        "normalized row edit dialog should not ask for confirmation",
+      );
+      field.setValue("<p>Hello</p>");
+      assert(
+        field.hasChanged() && rowEditDialogHasChanges(dirtyState),
+        "later plugin value changes should still count as dirty",
+      );
+
+      try {
+        field.setValue({ id: "df-object" });
+        throw new Error("field.setValue() should reject object values");
+      } catch (error) {
+        if (!String(error.message).includes("serialize objects")) {
+          throw error;
+        }
+      }
+
+      field.setValidity("Pick a file");
+      assert(
+        control.validationMessage === "Pick a file",
+        "field.setValidity() should set custom validity",
+      );
+      assert(
+        control.getAttribute("aria-invalid") === "true",
+        "field.setValidity() should set aria-invalid",
+      );
+      assert(
+        field.validationMessageElement && !field.validationMessageElement.hidden,
+        "field.setValidity() should show a field validation message",
+      );
+      field.clearValidity();
+      assert(
+        control.validationMessage === "" &&
+          control.getAttribute("aria-invalid") === null,
+        "field.clearValidity() should clear custom validity",
+      );
+
+      field.useSqliteDefault();
+      assert(
+        field.isUsingSqliteDefault() && control.disabled,
+        "field.useSqliteDefault() should mark and disable control",
+      );
+    }
+    """)

From 387e309b3bed719b0e9b3c0ec4965cc8d8204626 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:49:30 -0700
Subject: [PATCH 218/386] Port JSON column field test to Playwright

Refs #2779
---
 tests/test_datasette_manager_js.py | 202 -----------------------------
 tests/test_playwright.py           | 125 ++++++++++++++++++
 2 files changed, 125 insertions(+), 202 deletions(-)
 delete mode 100644 tests/test_datasette_manager_js.py

diff --git a/tests/test_datasette_manager_js.py b/tests/test_datasette_manager_js.py
deleted file mode 100644
index 9022d26f..00000000
--- a/tests/test_datasette_manager_js.py
+++ /dev/null
@@ -1,202 +0,0 @@
-import json
-from pathlib import Path
-import subprocess
-import textwrap
-
-STATIC_DIR = Path(__file__).resolve().parents[1] / "datasette" / "static"
-
-
-def test_builtin_json_column_field_validation():
-    script = textwrap.dedent("""
-        const fs = require("fs");
-        const vm = require("vm");
-        const editToolsJs = __EDIT_TOOLS_JS__;
-
-        class FakeEvent {
-          constructor(type, options) {
-            this.type = type;
-            this.bubbles = !!(options && options.bubbles);
-          }
-        }
-
-        class FakeElement {
-          constructor(tagName = "div") {
-            this.nodeName = tagName.toUpperCase();
-            this.nodeType = 1;
-            this.children = [];
-            this.dataset = {};
-            this.attributes = {};
-            this.value = "";
-            this.name = "";
-            this.disabled = false;
-            this.hidden = false;
-            this.textContent = "";
-            this.validationMessage = "";
-            this.eventListeners = {};
-            this.className = "";
-          }
-          appendChild(child) {
-            this.children.push(child);
-            child.parentNode = this;
-            return child;
-          }
-          addEventListener(type, callback) {
-            this.eventListeners[type] = this.eventListeners[type] || [];
-            this.eventListeners[type].push(callback);
-          }
-          dispatchEvent(event) {
-            event.target = event.target || this;
-            for (const callback of this.eventListeners[event.type] || []) {
-              callback(event);
-            }
-            return true;
-          }
-          setAttribute(name, value) {
-            this.attributes[name] = String(value);
-          }
-          getAttribute(name) {
-            return this.attributes[name] || null;
-          }
-          removeAttribute(name) {
-            delete this.attributes[name];
-          }
-          setCustomValidity(message) {
-            this.validationMessage = message;
-          }
-        }
-
-        global.Event = FakeEvent;
-        global.document = {
-          addEventListener() {},
-          createElement(tagName) {
-            return new FakeElement(tagName);
-          },
-          createTextNode(text) {
-            const node = new FakeElement("#text");
-            node.textContent = text;
-            return node;
-          },
-        };
-        global.location = {
-          href: "http://localhost/data/projects",
-          pathname: "/data/projects",
-          search: "",
-        };
-        global.window = {
-          _datasetteTableData: {
-            database: "data",
-            table: "projects",
-            tableUrl: "/data/projects",
-          },
-        };
-
-        vm.runInThisContext(fs.readFileSync(editToolsJs, "utf8"), {
-          filename: "edit-tools.js",
-        });
-
-        const plugins = [];
-        registerBuiltinColumnFieldPlugins({
-          registerPlugin(name, plugin) {
-            plugins.push({ name, plugin });
-          },
-        });
-        const jsonPlugin = plugins.find((entry) => entry.name === "datasette-json-column");
-        if (!jsonPlugin) {
-          throw new Error("datasette-json-column plugin was not registered");
-        }
-        const pluginControl = jsonPlugin.plugin.makeColumnField({
-          column: "metadata",
-          columnType: { type: "json", config: {} },
-        });
-        if (!pluginControl || pluginControl.useTextarea !== true) {
-          throw new Error("JSON column plugin should request a textarea");
-        }
-
-        const context = columnFormControlContext(
-          "metadata",
-          false,
-          { type: "json", config: {} },
-          { mode: "edit" }
-        );
-        const control = new FakeElement("textarea");
-        control.name = "metadata";
-        control.value = '{"ok": true}';
-        control.dataset.initialValue = '{"ok": true}';
-        control.dataset.initialValueKind = "string";
-        control.dataset.currentValueKind = "string";
-        const meta = new FakeElement("span");
-
-        const field = createColumnFieldApi({
-          id: "row-edit-field-0",
-          labelId: "row-edit-field-label-0",
-          descriptionId: "row-edit-field-meta-0",
-          control,
-          meta,
-          context,
-        });
-        renderColumnField(
-          Object.assign({ pluginName: "datasette-json-column" }, pluginControl),
-          field
-        );
-
-        if (control.validationMessage !== "") {
-          throw new Error("Initial valid JSON should not be invalid");
-        }
-        if (control.dataset.initialValueKind !== "string") {
-          throw new Error("JSON plugin should keep the original string value kind");
-        }
-        if (control.dataset.currentValueKind !== "string") {
-          throw new Error("JSON plugin should keep the current string value kind");
-        }
-        if (!field.validationMessageElement || field.validationMessageElement.hidden !== true) {
-          throw new Error("JSON validation message should start hidden");
-        }
-
-        control.value = "{";
-        control.dispatchEvent(new Event("input", { bubbles: true }));
-        if (!control.validationMessage.startsWith("Invalid JSON")) {
-          throw new Error("Invalid JSON should set a custom validity message");
-        }
-        if (control.getAttribute("aria-invalid") !== "true") {
-          throw new Error("Invalid JSON should set aria-invalid");
-        }
-        if (field.validationMessageElement.hidden) {
-          throw new Error("Invalid JSON should show the validation message");
-        }
-
-        control.value = '{"ok": true}';
-        control.dispatchEvent(new Event("input", { bubbles: true }));
-        if (control.validationMessage !== "") {
-          throw new Error("Valid JSON should clear the custom validity message");
-        }
-        if (control.getAttribute("aria-invalid") !== null) {
-          throw new Error("Valid JSON should clear aria-invalid");
-        }
-        if (!field.validationMessageElement.hidden) {
-          throw new Error("Valid JSON should hide the validation message");
-        }
-
-        control.dataset.initialValue = '{"ok":';
-        control.value = '{"ok": true}';
-        const values = collectRowFormValues({
-          mode: "edit",
-          fields: {
-            querySelectorAll() {
-              return [control];
-            },
-          },
-        });
-        if (values.metadata !== '{"ok": true}') {
-          throw new Error("Corrected JSON should be submitted as a string value");
-        }
-
-        process.stdout.write("ok");
-    """).replace("__EDIT_TOOLS_JS__", json.dumps(str(STATIC_DIR / "edit-tools.js")))
-    result = subprocess.run(
-        ["node", "-e", script],
-        text=True,
-        capture_output=True,
-        check=False,
-    )
-    assert result.returncode == 0, result.stderr
-    assert result.stdout == "ok"
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 06ae826d..a2d05d80 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -542,3 +542,128 @@ def test_table_plugin_column_field_api(page, datasette_server):
       );
     }
     """)
+
+
+@pytest.mark.playwright
+def test_builtin_json_column_field_validation(page, datasette_server):
+    load_edit_tools(page, datasette_server)
+    page.evaluate("""
+    () => {
+      const assert = (condition, message) => {
+        if (!condition) {
+          throw new Error(message);
+        }
+      };
+
+      const plugins = [];
+      registerBuiltinColumnFieldPlugins({
+        registerPlugin(name, plugin) {
+          plugins.push({ name, plugin });
+        },
+      });
+      const jsonPlugin = plugins.find(
+        (entry) => entry.name === "datasette-json-column",
+      );
+      assert(
+        jsonPlugin,
+        "datasette-json-column plugin was not registered",
+      );
+      const pluginControl = jsonPlugin.plugin.makeColumnField({
+        column: "metadata",
+        columnType: { type: "json", config: {} },
+      });
+      assert(
+        pluginControl && pluginControl.useTextarea === true,
+        "JSON column plugin should request a textarea",
+      );
+
+      const context = columnFormControlContext(
+        "metadata",
+        false,
+        { type: "json", config: {} },
+        { mode: "edit" },
+      );
+      const control = document.createElement("textarea");
+      control.className = "row-edit-input";
+      control.name = "metadata";
+      control.value = '{"ok": true}';
+      control.dataset.initialValue = '{"ok": true}';
+      control.dataset.initialValueKind = "string";
+      control.dataset.currentValueKind = "string";
+      const meta = document.createElement("span");
+
+      const field = createColumnFieldApi({
+        id: "row-edit-field-0",
+        labelId: "row-edit-field-label-0",
+        descriptionId: "row-edit-field-meta-0",
+        control,
+        meta,
+        context,
+      });
+      const wrapper = renderColumnField(
+        Object.assign({ pluginName: "datasette-json-column" }, pluginControl),
+        field,
+      );
+
+      assert(
+        control.validationMessage === "",
+        "Initial valid JSON should not be invalid",
+      );
+      assert(
+        control.dataset.initialValueKind === "string",
+        "JSON plugin should keep the original string value kind",
+      );
+      assert(
+        control.dataset.currentValueKind === "string",
+        "JSON plugin should keep the current string value kind",
+      );
+      assert(
+        field.validationMessageElement &&
+          field.validationMessageElement.hidden === true,
+        "JSON validation message should start hidden",
+      );
+
+      control.value = "{";
+      control.dispatchEvent(new Event("input", { bubbles: true }));
+      assert(
+        control.validationMessage.startsWith("Invalid JSON"),
+        "Invalid JSON should set a custom validity message",
+      );
+      assert(
+        control.getAttribute("aria-invalid") === "true",
+        "Invalid JSON should set aria-invalid",
+      );
+      assert(
+        !field.validationMessageElement.hidden,
+        "Invalid JSON should show the validation message",
+      );
+
+      control.value = '{"ok": true}';
+      control.dispatchEvent(new Event("input", { bubbles: true }));
+      assert(
+        control.validationMessage === "",
+        "Valid JSON should clear the custom validity message",
+      );
+      assert(
+        control.getAttribute("aria-invalid") === null,
+        "Valid JSON should clear aria-invalid",
+      );
+      assert(
+        field.validationMessageElement.hidden,
+        "Valid JSON should hide the validation message",
+      );
+
+      control.dataset.initialValue = '{"ok":';
+      control.value = '{"ok": true}';
+      const fields = document.createElement("div");
+      fields.appendChild(wrapper);
+      const values = collectRowFormValues({
+        mode: "edit",
+        fields,
+      });
+      assert(
+        values.metadata === '{"ok": true}',
+        "Corrected JSON should be submitted as a string value",
+      );
+    }
+    """)

From 0748b561d5265da6e78a48b065fd691dea67a078 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 16:52:07 -0700
Subject: [PATCH 219/386] Document Playwright test commands

Refs #2779
---
 docs/contributing.rst | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/docs/contributing.rst b/docs/contributing.rst
index 5a109fda..d4fcb19d 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -62,6 +62,33 @@ You can run the tests faster using multiple CPU cores with `pytest-xdist <https:
 
     uv run pytest -m "serial"
 
+Running Playwright tests
+~~~~~~~~~~~~~~~~~~~~~~~~
+
+Datasette includes a small number of browser automation tests using Playwright_.
+These tests are skipped by default, so you can run the main test suite with
+``uv run pytest`` without installing Playwright or any browser binaries.
+
+.. _Playwright: https://playwright.dev/python/
+
+The Playwright tests use a separate dependency group. To run them, first install
+the browser engine you want to test against, for example Chromium::
+
+    uv run --group playwright playwright install chromium
+
+Then run the Playwright test module with the explicit ``--playwright`` flag::
+
+    uv run --group playwright pytest tests/test_playwright.py --playwright --browser chromium
+
+You can also run the same tests against Firefox or WebKit by installing that
+browser engine and passing it to ``--browser``::
+
+    uv run --group playwright playwright install firefox
+    uv run --group playwright pytest tests/test_playwright.py --playwright --browser firefox
+
+    uv run --group playwright playwright install webkit
+    uv run --group playwright pytest tests/test_playwright.py --playwright --browser webkit
+
 .. _contributing_using_fixtures:
 
 Using fixtures

From 49362a9b20b541c833ac79590829665c4826ace2 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 17:00:12 -0700
Subject: [PATCH 220/386] await request.json() method, closes #2767

---
 datasette/utils/asgi.py         |  4 +++
 datasette/views/database.py     |  3 +-
 datasette/views/row.py          |  3 +-
 datasette/views/table.py        |  7 ++---
 docs/internals.rst              |  3 ++
 tests/test_internals_request.py | 51 +++++++++++++++++++++++++++++++++
 6 files changed, 63 insertions(+), 8 deletions(-)

diff --git a/datasette/utils/asgi.py b/datasette/utils/asgi.py
index 55eba1bb..93084365 100644
--- a/datasette/utils/asgi.py
+++ b/datasette/utils/asgi.py
@@ -155,6 +155,10 @@ class Request:
         body = await self.post_body()
         return dict(parse_qsl(body.decode("utf-8"), keep_blank_values=True))
 
+    async def json(self):
+        body = await self.post_body()
+        return json.loads(body)
+
     async def form(
         self,
         files: bool = False,
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 6afd9734..cd9565c6 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -1093,9 +1093,8 @@ class TableCreateView(BaseView):
         ):
             return _error(["Permission denied"], 403)
 
-        body = await request.post_body()
         try:
-            data = json.loads(body)
+            data = await request.json()
         except json.JSONDecodeError as e:
             return _error(["Invalid JSON: {}".format(e)])
 
diff --git a/datasette/views/row.py b/datasette/views/row.py
index e6eaa92b..4d61eb91 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -418,9 +418,8 @@ class RowUpdateView(BaseView):
         if not ok:
             return resolved
 
-        body = await request.post_body()
         try:
-            data = json.loads(body)
+            data = await request.json()
         except json.JSONDecodeError as e:
             return _error(["Invalid JSON: {}".format(e)])
 
diff --git a/datasette/views/table.py b/datasette/views/table.py
index de7b0216..c5448c85 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -673,9 +673,8 @@ class TableInsertView(BaseView):
         if not request.headers.get("content-type").startswith("application/json"):
             # TODO: handle form-encoded data
             return _errors(["Invalid content-type, must be application/json"])
-        body = await request.post_body()
         try:
-            data = json.loads(body)
+            data = await request.json()
         except json.JSONDecodeError as e:
             return _errors(["Invalid JSON: {}".format(e)])
         if not isinstance(data, dict):
@@ -974,7 +973,7 @@ class TableSetColumnTypeView(BaseView):
             return _error(["Invalid content-type, must be application/json"], 400)
 
         try:
-            data = json.loads(await request.post_body())
+            data = await request.json()
         except json.JSONDecodeError as e:
             return _error(["Invalid JSON: {}".format(e)], 400)
 
@@ -1091,7 +1090,7 @@ class TableDropView(BaseView):
             return _error(["Database is immutable"], 403)
         confirm = False
         try:
-            data = json.loads(await request.post_body())
+            data = await request.json()
             confirm = data.get("confirm")
         except json.JSONDecodeError:
             pass
diff --git a/docs/internals.rst b/docs/internals.rst
index 641286f8..06027f42 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -106,6 +106,9 @@ The object also has the following awaitable methods:
 ``await request.post_vars()`` - dictionary
     Returns a dictionary of form variables that were submitted in the request body via ``POST`` using ``application/x-www-form-urlencoded`` encoding. For multipart forms or file uploads, use ``request.form()`` instead.
 
+``await request.json()`` - Any
+    Returns the parsed JSON body of a request submitted by ``POST``.
+
 ``await request.post_body()`` - bytes
     Returns the un-parsed body of a request submitted by ``POST`` - useful for things like incoming JSON data.
 
diff --git a/tests/test_internals_request.py b/tests/test_internals_request.py
index d1ca1f46..9c448186 100644
--- a/tests/test_internals_request.py
+++ b/tests/test_internals_request.py
@@ -55,6 +55,57 @@ async def test_request_post_body():
     assert data == json.loads(body)
 
 
+@pytest.mark.asyncio
+async def test_request_json():
+    scope = {
+        "http_version": "1.1",
+        "method": "POST",
+        "path": "/",
+        "raw_path": b"/",
+        "query_string": b"",
+        "scheme": "http",
+        "type": "http",
+        "headers": [[b"content-type", b"application/json"]],
+    }
+
+    data = {"hello": "world", "items": [1, 2, 3]}
+
+    async def receive():
+        return {
+            "type": "http.request",
+            "body": json.dumps(data).encode("utf-8"),
+            "more_body": False,
+        }
+
+    request = Request(scope, receive)
+    assert data == await request.json()
+
+
+@pytest.mark.asyncio
+async def test_request_json_invalid():
+    scope = {
+        "http_version": "1.1",
+        "method": "POST",
+        "path": "/",
+        "raw_path": b"/",
+        "query_string": b"",
+        "scheme": "http",
+        "type": "http",
+        "headers": [[b"content-type", b"application/json"]],
+    }
+
+    async def receive():
+        return {
+            "type": "http.request",
+            "body": b"this is not JSON",
+            "more_body": False,
+        }
+
+    request = Request(scope, receive)
+    with pytest.raises(json.JSONDecodeError):
+        await request.json()
+
+
 def test_request_args():
     request = Request.fake("/foo?multi=1&multi=2&single=3")
     assert "1" == request.args.get("multi")

From dc6f207d3773bcfa9c1dcbaa9a5e5686c89c442c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 14 Jun 2026 20:29:59 -0700
Subject: [PATCH 221/386] Update unreleased release notes section

Refs #2780 and many more.
---
 docs/changelog.rst | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index c0bd7e6b..e4aae2b8 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -3,6 +3,26 @@
 =========
 Changelog
 =========
+.. _unreleased:
+
+Unreleased
+----------
+
+The big feature in this alpha is tools to **insert, edit and delete** rows within the Datasette interface. These features are available on table pages, and edit and delete are also available as action items on the row page.
+
+The edit interface takes :ref:`custom column types <table_configuration_column_types>` into account. Plugins that define their own column types can use JavaScript to customize how those column types are presented in the edit interface.
+
+- ``datasette.allowed_many()`` method for :ref:`resolving multiple permission checks at once <datasette_allowed_many>`. (:pr:`2775`)
+- Permission checks are now cached on a per-request basis, speeding up table pages with multiple plugins that check permissions in order to populate the :ref:`table actions menu <plugin_hook_table_actions>`.
+- Fixed a warning about ``gen.throw(*sys.exc_info())``. (:issue:`2776`)
+- New default custom column type ``textarea`` for multi-line text content. This is rendered as a ``<textarea>`` input in the edit UI.
+- The ``json`` column type now implements client-side validation in the edit UI.
+- The :ref:`makeColumnField() <javascript_plugins_makeColumnField>` JavaScript plugin hook allows plugins to define custom fields in the edit interface for their custom column types.
+- New UI for inserting, editing, and deleting rows within Datasette. (:issue:`2780`)
+- New ``/<database>/<table>/-/autocomplete?q=term`` :ref:`autocomplete JSON API <TableAutocompleteView>` for rapid autocomplete search against the contents of a table. This is used by the edit interface to select related rows for foreign keys. You can try it out on the ``/-/debug/autocomplete`` debug page.
+- New ``/<database>/<table>/-/fragment`` :ref:`HTML fragment endpoint  <TableFragmentView>` for returning the HTML used to display a specific row.
+- ``await request.json()`` utility method for consuming the request body as JSON. (:issue:`2767`)
+- Database, table, query and row action menus can now be modified by plugins to :ref:`display buttons in addition to links <plugin_actions>`. (:issue:`2782`)
 
 .. _v1_0_a33:
 

From 0a0491568a39f881917aba0f55043a1dec2fd850 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 11:59:42 -0700
Subject: [PATCH 222/386] Fix flaky autocomplete timeout test

---
 tests/test_autocomplete.py | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/tests/test_autocomplete.py b/tests/test_autocomplete.py
index abe19af2..76b9c902 100644
--- a/tests/test_autocomplete.py
+++ b/tests/test_autocomplete.py
@@ -1,7 +1,7 @@
 import pytest
 
 from datasette.app import Datasette
-import datasette.views.table as table_views
+from datasette.database import QueryInterrupted
 
 
 @pytest.mark.asyncio
@@ -192,7 +192,6 @@ async def test_autocomplete_primary_key_called_label():
 
 @pytest.mark.asyncio
 async def test_autocomplete_timeout_uses_prefix_fallback(monkeypatch):
-    monkeypatch.setattr(table_views, "AUTOCOMPLETE_TIME_LIMIT_MS", 1)
     ds = Datasette(
         memory=True,
         config={
@@ -217,16 +216,34 @@ async def test_autocomplete_timeout_uses_prefix_fallback(monkeypatch):
     def insert_rows(conn):
         conn.executemany(
             "insert into things (id, name) values (?, ?)",
-            ((f"item-{i:06d}", f"name {i:06d}") for i in range(200_000)),
+            ((f"item-1999{i:02d}", f"name 1999{i:02d}") for i in range(12)),
         )
 
     await db.execute_write_fn(insert_rows)
 
+    original_execute = db.execute
+    timeout_was_simulated = False
+
+    async def execute_with_simulated_timeout(sql, params=None, *args, **kwargs):
+        nonlocal timeout_was_simulated
+        if (
+            not timeout_was_simulated
+            and isinstance(params, dict)
+            and params.get("q") == "item-1999"
+            and "prefix_end" not in params
+        ):
+            timeout_was_simulated = True
+            raise QueryInterrupted(Exception("interrupted"), sql, params)
+        return await original_execute(sql, params, *args, **kwargs)
+
+    monkeypatch.setattr(db, "execute", execute_with_simulated_timeout)
+
     response = await ds.client.get(
         "/autocomplete_timeout/things/-/autocomplete?q=item-1999"
     )
 
     assert response.status_code == 200
+    assert timeout_was_simulated
     data = response.json()
     assert data == {
         "rows": [

From b5ba41c9dbcd22e57f8217d45a77ca8b733d49c6 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 13:28:18 -0700
Subject: [PATCH 223/386] Fix for Safari esc-closes-confirm bug, closes #2784

---
 datasette/static/edit-tools.js | 46 +++++++++++++++++++++++++++-------
 1 file changed, 37 insertions(+), 9 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index b1928f1d..8142d02b 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -1396,6 +1396,38 @@ function closeRowEditDialogIfConfirmed(state) {
   return true;
 }
 
+function scheduleCloseRowEditDialogIfConfirmed(state) {
+  // Fix for an issue in Safari where hitting Esc would show
+  // the confirm() prompt asking if state should be discarded
+  // but the Esc key press would then cancel that dialog too.
+  // Wait for keyup, then move the confirm() to a fresh timer tick.
+  if (!state || state.isSaving || state.isClosePending) {
+    return false;
+  }
+  if (!rowEditDialogHasChanges(state)) {
+    state.shouldRestoreFocus = true;
+    state.dialog.close();
+    return true;
+  }
+  state.isClosePending = true;
+  var closeAfterKeyup = function () {
+    if (!state.isClosePending) {
+      return;
+    }
+    state.isClosePending = false;
+    closeRowEditDialogIfConfirmed(state);
+  };
+  var onKeyup = function (ev) {
+    if (ev.key !== "Escape") {
+      return;
+    }
+    document.removeEventListener("keyup", onKeyup, true);
+    setTimeout(closeAfterKeyup, 0);
+  };
+  document.addEventListener("keyup", onKeyup, true);
+  return true;
+}
+
 function findDataRowElement(root, rowId) {
   var elements = root.querySelectorAll("[data-row]");
   for (var i = 0; i < elements.length; i += 1) {
@@ -1770,6 +1802,7 @@ function ensureRowEditDialog(manager) {
     manager: manager,
     isLoading: false,
     isSaving: false,
+    isClosePending: false,
     hasLoaded: false,
     shouldRestoreFocus: true,
   };
@@ -1797,23 +1830,18 @@ function ensureRowEditDialog(manager) {
       return;
     }
     ev.preventDefault();
-    closeRowEditDialogIfConfirmed(rowEditDialogState);
+    scheduleCloseRowEditDialogIfConfirmed(rowEditDialogState);
   });
 
   dialog.addEventListener("cancel", function (ev) {
-    if (
-      rowEditDialogState.isSaving ||
-      !confirmDiscardRowEditChanges(rowEditDialogState)
-    ) {
-      ev.preventDefault();
-    } else {
-      rowEditDialogState.shouldRestoreFocus = true;
-    }
+    ev.preventDefault();
+    scheduleCloseRowEditDialogIfConfirmed(rowEditDialogState);
   });
 
   dialog.addEventListener("close", function () {
     var state = rowEditDialogState;
     state.loadId += 1;
+    state.isClosePending = false;
     clearRowEditDialogError(state);
     state.hasLoaded = false;
     destroyRowEditFields(state);

From 77fa49cf1749e0e370b6dafd590d497bcd0eb838 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 13:35:15 -0700
Subject: [PATCH 224/386] Just recipes for running Playwright tests

Plus the pytest header now reports selected Playwright browsers
---
 Justfile              | 16 ++++++++++++++++
 docs/contributing.rst | 44 ++++++++++++++++++++++++++++++-------------
 tests/conftest.py     | 12 +++++++++++-
 3 files changed, 58 insertions(+), 14 deletions(-)

diff --git a/Justfile b/Justfile
index 657881be..5fcd9afd 100644
--- a/Justfile
+++ b/Justfile
@@ -11,6 +11,22 @@ export DATASETTE_SECRET := "not_a_secret"
 @test *options: init
   uv run pytest -n auto {{options}}
 
+# Install Playwright browser support, Chromium by default
+@playwright-install browser="chromium":
+  uv run --group playwright playwright install {{browser}}
+
+# Install all Playwright browsers used by the test suite
+@playwright-install-all:
+  uv run --group playwright playwright install chromium firefox webkit
+
+# Run Playwright tests, Chromium by default
+@playwright browser="chromium" *options:
+  uv run --group playwright pytest tests/test_playwright.py --playwright --browser {{browser}} {{options}}
+
+# Run Playwright tests against all supported browsers
+@playwright-all *options:
+  uv run --group playwright pytest tests/test_playwright.py --playwright --browser chromium --browser firefox --browser webkit {{options}}
+
 @codespell:
   uv run codespell README.md --ignore-words docs/codespell-ignore-words.txt
   uv run codespell docs/*.rst --ignore-words docs/codespell-ignore-words.txt
diff --git a/docs/contributing.rst b/docs/contributing.rst
index d4fcb19d..0d365f3a 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -71,24 +71,42 @@ These tests are skipped by default, so you can run the main test suite with
 
 .. _Playwright: https://playwright.dev/python/
 
-The Playwright tests use a separate dependency group. To run them, first install
-the browser engine you want to test against, for example Chromium::
+The Playwright tests use a separate dependency group. The easiest way to run
+them is using ``just``. First install the browser engine you want to test
+against. Chromium is used by default::
+
+    just playwright-install
+
+Then run the Playwright test module::
+
+    just playwright
+
+You can also run the same tests against Firefox or WebKit by installing that
+browser engine and passing it to ``just playwright``::
+
+    just playwright-install firefox
+    just playwright firefox
+
+    just playwright-install webkit
+    just playwright webkit
+
+To install every supported browser engine and run the tests against all of
+them, use::
+
+    just playwright-install-all
+    just playwright-all
+
+You can pass extra ``pytest`` options after the browser name::
+
+    just playwright chromium -k permissions
+    just playwright-all -x
+
+If you are not using ``just``, the equivalent Chromium commands are::
 
     uv run --group playwright playwright install chromium
 
-Then run the Playwright test module with the explicit ``--playwright`` flag::
-
     uv run --group playwright pytest tests/test_playwright.py --playwright --browser chromium
 
-You can also run the same tests against Firefox or WebKit by installing that
-browser engine and passing it to ``--browser``::
-
-    uv run --group playwright playwright install firefox
-    uv run --group playwright pytest tests/test_playwright.py --playwright --browser firefox
-
-    uv run --group playwright playwright install webkit
-    uv run --group playwright pytest tests/test_playwright.py --playwright --browser webkit
-
 .. _contributing_using_fixtures:
 
 Using fixtures
diff --git a/tests/conftest.py b/tests/conftest.py
index 04b6f8be..55110a42 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -93,7 +93,17 @@ def pytest_report_header(config):
     conn = sqlite3.connect(":memory:")
     version = conn.execute("select sqlite_version()").fetchone()[0]
     conn.close()
-    return "SQLite: {}".format(version)
+    headers = ["SQLite: {}".format(version)]
+    if config.getoption("--playwright"):
+        try:
+            browsers = config.getoption("--browser")
+        except ValueError:
+            browsers = None
+        if isinstance(browsers, str):
+            browsers = [browsers]
+        if browsers:
+            headers.append("Playwright browsers: {}".format(", ".join(browsers)))
+    return headers
 
 
 def pytest_addoption(parser):

From 2f27b0840598470b6d9c0fe026f84f214fbbec8b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 13:41:24 -0700
Subject: [PATCH 225/386] Use code-block:: bash for Playwright docs

---
 docs/contributing.rst | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/docs/contributing.rst b/docs/contributing.rst
index 0d365f3a..f28b9bcb 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -73,16 +73,22 @@ These tests are skipped by default, so you can run the main test suite with
 
 The Playwright tests use a separate dependency group. The easiest way to run
 them is using ``just``. First install the browser engine you want to test
-against. Chromium is used by default::
+against. Chromium is used by default:
+
+.. code-block:: bash
 
     just playwright-install
 
-Then run the Playwright test module::
+Then run the Playwright test module:
+
+.. code-block:: bash
 
     just playwright
 
 You can also run the same tests against Firefox or WebKit by installing that
-browser engine and passing it to ``just playwright``::
+browser engine and passing it to ``just playwright``:
+
+.. code-block:: bash
 
     just playwright-install firefox
     just playwright firefox
@@ -91,17 +97,23 @@ browser engine and passing it to ``just playwright``::
     just playwright webkit
 
 To install every supported browser engine and run the tests against all of
-them, use::
+them, use:
+
+.. code-block:: bash
 
     just playwright-install-all
     just playwright-all
 
-You can pass extra ``pytest`` options after the browser name::
+You can pass extra ``pytest`` options after the browser name:
+
+.. code-block:: bash
 
     just playwright chromium -k permissions
     just playwright-all -x
 
-If you are not using ``just``, the equivalent Chromium commands are::
+If you are not using ``just``, the equivalent Chromium commands are:
+
+.. code-block:: bash
 
     uv run --group playwright playwright install chromium
 

From a8124172dd39b270452d74cf4bb7c2fe1cd12b64 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 13:54:00 -0700
Subject: [PATCH 226/386] Remove load_edit_tools(), use a new fixture instead

Refs https://github.com/simonw/datasette/pull/2785/changes#r3423913454
---
 tests/test_playwright.py | 45 +++++++++++++++++++++++-----------------
 1 file changed, 26 insertions(+), 19 deletions(-)

diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index a2d05d80..b35de8db 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -7,6 +7,7 @@ import httpx
 import pytest
 
 from datasette.fixtures import write_fixture_database
+from datasette.utils.sqlite import sqlite3
 
 
 def find_free_port():
@@ -39,15 +40,18 @@ def wait_for_server(process, url, timeout=10):
 
 @pytest.fixture
 def datasette_server(tmp_path):
-    db_path = tmp_path / "fixtures.db"
-    write_fixture_database(str(db_path))
+    fixtures_db_path = tmp_path / "fixtures.db"
+    write_fixture_database(str(fixtures_db_path))
+    data_db_path = tmp_path / "data.db"
+    write_playwright_database(str(data_db_path))
     port = find_free_port()
     process = subprocess.Popen(
         [
             sys.executable,
             "-m",
             "datasette",
-            str(db_path),
+            str(fixtures_db_path),
+            str(data_db_path),
             "--host",
             "127.0.0.1",
             "--port",
@@ -73,26 +77,29 @@ def datasette_server(tmp_path):
             process.wait()
 
 
+def write_playwright_database(db_path):
+    conn = sqlite3.connect(db_path)
+    try:
+        conn.executescript("""
+        create table projects (
+            id integer primary key,
+            title text not null,
+            metadata text,
+            logo text
+        );
+        insert into projects (title, metadata, logo) values
+            ('Build Datasette', '{"ok": true}', 'df-old');
+        """)
+    finally:
+        conn.close()
+
+
 @pytest.mark.playwright
 def test_datasette_homepage_contains_datasette(page, datasette_server):
     page.goto(datasette_server)
     assert "Datasette" in page.locator("body").inner_text()
 
 
-def load_edit_tools(page, datasette_server):
-    page.goto(datasette_server)
-    page.evaluate("""
-    () => {
-      window._datasetteTableData = {
-        database: "data",
-        table: "projects",
-        tableUrl: "/data/projects",
-      };
-    }
-    """)
-    page.add_script_tag(url=f"{datasette_server}-/static/edit-tools.js")
-
-
 @pytest.mark.playwright
 def test_navigation_search_tracks_and_renders_recent_items(page, datasette_server):
     page.goto(datasette_server)
@@ -231,7 +238,7 @@ def test_datasette_manager_make_column_field(page, datasette_server):
 
 @pytest.mark.playwright
 def test_table_plugin_column_field_api(page, datasette_server):
-    load_edit_tools(page, datasette_server)
+    page.goto(f"{datasette_server}data/projects")
     page.evaluate("""
     () => {
       const assert = (condition, message) => {
@@ -546,7 +553,7 @@ def test_table_plugin_column_field_api(page, datasette_server):
 
 @pytest.mark.playwright
 def test_builtin_json_column_field_validation(page, datasette_server):
-    load_edit_tools(page, datasette_server)
+    page.goto(f"{datasette_server}data/projects")
     page.evaluate("""
     () => {
       const assert = (condition, message) => {

From 3edc98a871f27fd53a068fd3c4e6a0c6a32b6274 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 14:13:44 -0700
Subject: [PATCH 227/386] Playwright tests exercise the real UI now

Refs https://github.com/simonw/datasette/pull/2785#issuecomment-4723583959
---
 tests/test_playwright.py | 820 +++++++++++++--------------------------
 1 file changed, 274 insertions(+), 546 deletions(-)

diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index b35de8db..a8c5aa4b 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -1,3 +1,4 @@
+import json
 import socket
 import subprocess
 import sys
@@ -44,6 +45,10 @@ def datasette_server(tmp_path):
     write_fixture_database(str(fixtures_db_path))
     data_db_path = tmp_path / "data.db"
     write_playwright_database(str(data_db_path))
+    config_path = tmp_path / "datasette.json"
+    write_playwright_config(config_path)
+    plugins_dir = tmp_path / "plugins"
+    write_playwright_plugin(plugins_dir)
     port = find_free_port()
     process = subprocess.Popen(
         [
@@ -52,6 +57,10 @@ def datasette_server(tmp_path):
             "datasette",
             str(fixtures_db_path),
             str(data_db_path),
+            "--config",
+            str(config_path),
+            "--plugins-dir",
+            str(plugins_dir),
             "--host",
             "127.0.0.1",
             "--port",
@@ -85,15 +94,181 @@ def write_playwright_database(db_path):
             id integer primary key,
             title text not null,
             metadata text,
-            logo text
+            logo text,
+            notes text,
+            score integer default 5
         );
-        insert into projects (title, metadata, logo) values
-            ('Build Datasette', '{"ok": true}', 'df-old');
+        insert into projects (title, metadata, logo, notes, score) values
+            (
+                'Build Datasette',
+                '{"ok": true}',
+                'asset-original',
+                'Initial notes',
+                5
+            );
         """)
     finally:
         conn.close()
 
 
+def write_playwright_config(config_path):
+    config_path.write_text(
+        json.dumps(
+            {
+                "databases": {
+                    "data": {
+                        "tables": {
+                            "projects": {
+                                "label_column": "title",
+                                "column_types": {
+                                    "metadata": "json",
+                                    "logo": "asset",
+                                    "notes": "textarea",
+                                },
+                                "permissions": {
+                                    "insert-row": True,
+                                    "update-row": True,
+                                    "delete-row": True,
+                                },
+                            },
+                        },
+                    },
+                },
+            }
+        ),
+        "utf-8",
+    )
+
+
+def write_playwright_plugin(plugins_dir):
+    plugins_dir.mkdir()
+    (plugins_dir / "playwright_plugin.py").write_text(
+        '''
+from datasette import hookimpl
+from datasette.column_types import ColumnType, SQLiteType
+
+
+class AssetColumnType(ColumnType):
+    name = "asset"
+    description = "Demo asset picker"
+    sqlite_types = (SQLiteType.TEXT,)
+
+
+@hookimpl
+def register_column_types(datasette):
+    return [AssetColumnType]
+
+
+@hookimpl
+def extra_body_script():
+    return {
+        "module": True,
+        "script": """
+document.addEventListener("datasette_init", function (event) {
+  event.detail.registerPlugin("playwright-jump-section", {
+    version: "0.1",
+    makeJumpSections() {
+      return [
+        {
+          id: "agent-chat",
+          render(node, context) {
+            if (!context.navigationSearch || !context.input) {
+              throw new Error("Expected navigation search context");
+            }
+            node.innerHTML = [
+              '<section class="agent-jump-start">',
+              '<button type="button" data-playwright-agent-chat>',
+              'Start a new agent chat',
+              '</button>',
+              '</section>',
+            ].join("");
+            node.querySelector("button").addEventListener("click", function () {
+              window.location.href = "/-/playwright-agent";
+            });
+          },
+        },
+      ];
+    },
+  });
+
+  event.detail.registerPlugin("playwright-asset-field", {
+    version: "0.1",
+    makeColumnField(context) {
+      if (!context.columnType || context.columnType.type !== "asset") {
+        return;
+      }
+      return {
+        render(field) {
+          const wrapper = document.createElement("div");
+          wrapper.className = "playwright-asset-picker";
+          wrapper.dataset.column = field.context.column;
+          wrapper.dataset.database = field.context.database || "";
+          wrapper.dataset.table = field.context.table || "";
+          wrapper.dataset.tableUrl = field.context.tableUrl || "";
+          wrapper.dataset.mode = field.context.mode || "";
+          wrapper.dataset.columnType = field.context.columnType.type;
+
+          field.input.type = "hidden";
+          const value = document.createElement("span");
+          value.className = "playwright-asset-value";
+          const button = document.createElement("button");
+          button.type = "button";
+          button.className = "playwright-asset-select";
+          button.textContent = "Use demo asset";
+
+          function sync() {
+            value.textContent = field.getValue() || "No asset selected";
+          }
+
+          button.addEventListener("click", function () {
+            field.setValue("asset-from-plugin");
+            sync();
+          });
+
+          wrapper.appendChild(field.input);
+          wrapper.appendChild(value);
+          wrapper.appendChild(button);
+          sync();
+          return wrapper;
+        },
+        focus(field) {
+          const button = field.root.querySelector(".playwright-asset-select");
+          if (button) {
+            button.focus();
+          }
+        },
+      };
+    },
+  });
+});
+""",
+    }
+''',
+        "utf-8",
+    )
+
+
+def project_rows(datasette_server, **filters):
+    params = {
+        "_shape": "objects",
+        **{key: str(value) for key, value in filters.items()},
+    }
+    response = httpx.get(f"{datasette_server}data/projects.json", params=params)
+    response.raise_for_status()
+    return response.json()["rows"]
+
+
+def project_row(datasette_server, pk):
+    rows = project_rows(datasette_server, id=pk)
+    assert len(rows) == 1
+    return rows[0]
+
+
+def open_jump_menu(page):
+    page.keyboard.press("/")
+    page.locator("navigation-search .search-input").wait_for()
+
+
 @pytest.mark.playwright
 def test_datasette_homepage_contains_datasette(page, datasette_server):
     page.goto(datasette_server)
@@ -103,69 +278,24 @@ def test_datasette_homepage_contains_datasette(page, datasette_server):
 @pytest.mark.playwright
 def test_navigation_search_tracks_and_renders_recent_items(page, datasette_server):
     page.goto(datasette_server)
-    result = page.evaluate("""
-    async () => {
-      await customElements.whenDefined("navigation-search");
-      const element = document.querySelector("navigation-search");
-      const key = element.recentItemsStorageKey();
-      localStorage.removeItem(key);
+    open_jump_menu(page)
+    search = page.locator("navigation-search .search-input")
+    search.fill("projects")
+    result = page.locator("navigation-search .result-item", has_text="projects").first
+    result.wait_for()
+    result.click()
+    page.wait_for_url("**/data/projects")
 
-      const items = Array.from({ length: 6 }, (_, index) => ({
-        name: `Item ${index + 1}`,
-        url: `/item-${index + 1}`,
-        type: "table",
-        description: "Table",
-      }));
-      items[5].name = "content: recent_datasette_releases";
-      items[5].display_name = "Recent Datasette releases";
+    page.goto(datasette_server)
+    open_jump_menu(page)
+    results = page.locator("navigation-search .results-container")
+    results.locator(".results-heading", has_text="Recent").wait_for()
+    assert "projects" in results.inner_text()
 
-      for (const item of items) {
-        element.saveRecentItem(item);
-      }
-
-      const stored = JSON.parse(localStorage.getItem(key));
-      element.matches = [
-        items[5],
-        items[4],
-        {
-          name: "Other",
-          url: "/other",
-          type: "database",
-          description: "Database",
-        },
-      ];
-      element.shadowRoot.querySelector(".search-input").value = "";
-      element.renderResults();
-      const html = element.shadowRoot.querySelector(".results-container").innerHTML;
-
-      element.clearRecentItems();
-      const clearedValue = localStorage.getItem(key);
-      element.renderResults();
-      const htmlAfterClear = element.shadowRoot
-        .querySelector(".results-container")
-        .innerHTML;
-
-      return { stored, html, clearedValue, htmlAfterClear };
-    }
-    """)
-    assert [item["url"] for item in result["stored"]] == [
-        "/item-6",
-        "/item-5",
-        "/item-4",
-        "/item-3",
-        "/item-2",
-    ]
-    assert result["stored"][0]["display_name"] == "Recent Datasette releases"
-    assert "Recent" in result["html"]
-    assert "Recent Datasette releases" in result["html"]
-    assert "Item 5" in result["html"]
-    assert "content: recent_datasette_releases" in result["html"]
-    assert "Item 4" in result["html"]
-    assert "Item 2" in result["html"]
-    assert "Other" not in result["html"]
-    assert "Clear recent" in result["html"]
-    assert result["clearedValue"] is None
-    assert "Clear recent" not in result["htmlAfterClear"]
+    page.locator("navigation-search [data-clear-recent-items]").click()
+    page.locator("navigation-search .results-container", has_text="Recent").wait_for(
+        state="detached"
+    )
 
 
 @pytest.mark.playwright
@@ -173,504 +303,102 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins(
     page, datasette_server
 ):
     page.goto(datasette_server)
-    html = page.evaluate("""
-    async () => {
-      await customElements.whenDefined("navigation-search");
-      window.__DATASETTE__.registerPlugin("agent", {
-        version: "0.1",
-        makeJumpSections() {
-          return [
-            {
-              id: "agent-chat",
-              render(node, context) {
-                if (!context.navigationSearch) {
-                  throw new Error("Expected navigationSearch in render context");
-                }
-                node.innerHTML = [
-                  '<section class="agent-jump-start">',
-                  '<button>Start a new agent chat</button>',
-                  '</section>',
-                ].join("");
-              },
-            },
-          ];
-        },
-      });
-
-      const element = document.querySelector("navigation-search");
-      element.shadowRoot.querySelector(".search-input").value = "";
-      element.renderResults();
-      return element.shadowRoot.querySelector(".results-container").innerHTML;
-    }
-    """)
-    assert "Start a new agent chat" in html
+    open_jump_menu(page)
+    button = page.locator("navigation-search [data-playwright-agent-chat]")
+    button.wait_for()
+    assert button.inner_text() == "Start a new agent chat"
+    button.click()
+    page.wait_for_url("**/-/playwright-agent")
 
 
 @pytest.mark.playwright
-def test_datasette_manager_make_column_field(page, datasette_server):
-    page.goto(datasette_server)
-    control = page.evaluate("""
-    () => {
-      window.__DATASETTE__.registerPlugin("declines", {
-        makeColumnField() {
-          return;
-        },
-      });
-      window.__DATASETTE__.registerPlugin("handles", {
-        makeColumnField(context) {
-          if (context.columnType.type !== "demo") {
-            return;
-          }
-          return { useTextarea: true };
-        },
-      });
-      return window.__DATASETTE__.makeColumnField({
-        column: "body",
-        columnType: { type: "demo", config: null },
-      });
-    }
-    """)
-    assert control == {
-        "pluginName": "handles",
-        "useTextarea": True,
-    }
-
-
-@pytest.mark.playwright
-def test_table_plugin_column_field_api(page, datasette_server):
+def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
     page.goto(f"{datasette_server}data/projects")
-    page.evaluate("""
-    () => {
-      const assert = (condition, message) => {
-        if (!condition) {
-          throw new Error(message);
-        }
-      };
+    page.locator('button[data-table-action="insert-row"]').click()
 
-      const context = columnFormControlContext(
-        "logo",
-        true,
-        { type: "file", config: null },
-        {
-          mode: "edit",
-          defaultExpression: "lower(hex(randomblob(4)))",
-          useSqliteDefault: true,
-        },
-      );
-      const expectedContextKeys = [
-        "mode",
-        "database",
-        "table",
-        "tableUrl",
-        "column",
-        "columnType",
-        "sqliteType",
-        "notNull",
-        "isPk",
-        "defaultExpression",
-        "form",
-        "dialog",
-      ].join(",");
-      assert(
-        Object.keys(context).join(",") === expectedContextKeys,
-        `Unexpected context keys: ${Object.keys(context).join(",")}`,
-      );
-      assert(
-        context.defaultExpression === "lower(hex(randomblob(4)))",
-        "context.defaultExpression was not set",
-      );
-      assert(
-        JSON.stringify(context.columnType) === '{"type":"file","config":{}}',
-        "context.columnType should expose type and object config",
-      );
-      assert(
-        context.isPk,
-        "context.isPk should say whether the column is a primary key",
-      );
+    dialog = page.locator("#row-edit-dialog")
+    dialog.wait_for()
+    dialog.locator('input[name="title"]').fill("Launch Datasette Cloud")
+    dialog.locator('textarea[name="metadata"]').fill(
+        '{"ok": false, "source": "playwright"}'
+    )
+    dialog.locator('textarea[name="notes"]').fill("Inserted from Playwright")
 
-      const control = document.createElement("input");
-      control.name = "logo";
-      control.value = "df-old";
-      control.dataset.initialValue = "df-old";
-      control.dataset.initialValueKind = "string";
-      control.dataset.currentValueKind = "string";
-      control.dataset.useSqliteDefault = "1";
-      control.disabled = true;
-      const dispatchedEvents = [];
-      control.addEventListener("input", (event) =>
-        dispatchedEvents.push(event.type),
-      );
-      control.addEventListener("change", (event) =>
-        dispatchedEvents.push(event.type),
-      );
+    asset = dialog.locator(".playwright-asset-picker")
+    asset.wait_for()
+    assert asset.get_attribute("data-column") == "logo"
+    assert asset.get_attribute("data-database") == "data"
+    assert asset.get_attribute("data-table") == "projects"
+    assert asset.get_attribute("data-mode") == "insert"
+    asset.locator(".playwright-asset-select").click()
+    assert asset.locator(".playwright-asset-value").inner_text() == "asset-from-plugin"
 
-      const field = createColumnFieldApi({
-        id: "row-edit-field-0",
-        labelId: "row-edit-field-label-0",
-        descriptionId: "row-edit-field-meta-0",
-        control,
-        meta: document.createElement("span"),
-        context,
-      });
+    dialog.locator(".row-edit-save").click()
+    page.locator(".row-mutation-status", has_text="Inserted row 2").wait_for()
+    row = page.locator('tr[data-row="2"]')
+    row.wait_for()
+    assert "Launch Datasette Cloud" in row.inner_text()
 
-      let renderArgumentCount = null;
-      let renderField = null;
-      const wrapper = renderColumnField(
-        {
-          pluginName: "test-plugin",
-          render(field) {
-            renderArgumentCount = arguments.length;
-            renderField = field;
-            return document.createElement("button");
-          },
-        },
-        field,
-      );
-      assert(
-        renderArgumentCount === 1 && renderField === field,
-        "plugin render should receive the field object only",
-      );
-      assert(field.root === wrapper, "field.root should be the plugin wrapper");
-      assert(
-        wrapper.children.length === 1 &&
-          wrapper.children[0].nodeName === "BUTTON",
-        "plugin render should append returned DOM nodes to field.root",
-      );
-
-      field.setValue(null);
-      assert(field.getValue() === null, "field.setValue(null) should round-trip as null");
-      assert(
-        !field.isUsingSqliteDefault(),
-        "field.setValue() should stop using the SQLite default",
-      );
-      assert(
-        control.dataset.currentValueKind === "null",
-        "null values should update currentValueKind",
-      );
-
-      field.setValue("df-new");
-      assert(
-        field.getValue() === "df-new",
-        "field.setValue() should update the current value",
-      );
-      assert(
-        field.getInitialValue() === "df-old",
-        "field.getInitialValue() should remain stable",
-      );
-      assert(
-        field.hasChanged(),
-        "field.hasChanged() should notice plugin value changes",
-      );
-      assert(
-        dispatchedEvents.length === 0,
-        `field.setValue() should not dispatch events: ${dispatchedEvents}`,
-      );
-
-      const dirtyRowField = document.createElement("div");
-      dirtyRowField.className = "row-edit-field";
-      dirtyRowField._datasetteColumnFormField = field;
-      const dirtyFields = document.createElement("div");
-      dirtyFields.appendChild(dirtyRowField);
-      const dirtyState = {
-        hasLoaded: true,
-        isLoading: false,
-        isSaving: false,
-        mode: "edit",
-        fields: dirtyFields,
-        dialog: {
-          closeCalled: false,
-          close() {
-            this.closeCalled = true;
-          },
-        },
-        shouldRestoreFocus: false,
-      };
-      const confirmMessages = [];
-      window.confirm = (message) => {
-        confirmMessages.push(message);
-        return false;
-      };
-      assert(
-        rowEditDialogHasChanges(dirtyState),
-        "row edit dialog should notice changed field values",
-      );
-      assert(
-        !closeRowEditDialogIfConfirmed(dirtyState),
-        "dirty row edit dialog should stay open when discard is rejected",
-      );
-      assert(
-        !dirtyState.dialog.closeCalled,
-        "dirty row edit dialog should not close when discard is rejected",
-      );
-      assert(
-        confirmMessages[0] === "Discard unsaved changes to this row?",
-        `Unexpected discard confirmation: ${confirmMessages[0]}`,
-      );
-      dirtyState.mode = "insert";
-      window.confirm = (message) => {
-        confirmMessages.push(message);
-        return true;
-      };
-      assert(
-        closeRowEditDialogIfConfirmed(dirtyState),
-        "dirty row edit dialog should close when discard is confirmed",
-      );
-      assert(
-        dirtyState.dialog.closeCalled && dirtyState.shouldRestoreFocus,
-        "confirmed dirty row edit dialog should close and restore focus",
-      );
-      assert(
-        confirmMessages[1] === "Discard this new row?",
-        `Unexpected insert discard confirmation: ${confirmMessages[1]}`,
-      );
-
-      const cleanContext = columnFormControlContext("title", false, null, {
-        mode: "edit",
-      });
-      assert(
-        cleanContext.defaultExpression === null,
-        "context.defaultExpression should be null without a SQLite default",
-      );
-      const cleanControl = document.createElement("input");
-      cleanControl.name = "title";
-      cleanControl.value = "clean";
-      cleanControl.dataset.initialValue = "clean";
-      cleanControl.dataset.initialValueKind = "string";
-      cleanControl.dataset.currentValueKind = "string";
-      const cleanField = createColumnFieldApi({
-        id: "row-edit-field-1",
-        labelId: "row-edit-field-label-1",
-        descriptionId: "row-edit-field-meta-1",
-        control: cleanControl,
-        meta: document.createElement("span"),
-        context: cleanContext,
-      });
-      const cleanRowField = document.createElement("div");
-      cleanRowField.className = "row-edit-field";
-      cleanRowField._datasetteColumnFormField = cleanField;
-      const cleanFields = document.createElement("div");
-      cleanFields.appendChild(cleanRowField);
-      const cleanState = {
-        hasLoaded: true,
-        isLoading: false,
-        isSaving: false,
-        mode: "edit",
-        fields: cleanFields,
-        dialog: {
-          closeCalled: false,
-          close() {
-            this.closeCalled = true;
-          },
-        },
-        shouldRestoreFocus: false,
-      };
-      confirmMessages.length = 0;
-      window.confirm = (message) => {
-        confirmMessages.push(message);
-        return false;
-      };
-      assert(
-        !rowEditDialogHasChanges(cleanState),
-        "row edit dialog should ignore unchanged field values",
-      );
-      assert(
-        closeRowEditDialogIfConfirmed(cleanState),
-        "clean row edit dialog should close without confirmation",
-      );
-      assert(
-        cleanState.dialog.closeCalled && cleanState.shouldRestoreFocus,
-        "clean row edit dialog should close and restore focus",
-      );
-      assert(
-        confirmMessages.length === 0,
-        "clean row edit dialog should not ask for confirmation",
-      );
-
-      dirtyState.dialog.closeCalled = false;
-      dirtyState.shouldRestoreFocus = false;
-      confirmMessages.length = 0;
-      field.setValue("<p></p>");
-      field.markClean();
-      assert(
-        !field.hasChanged(),
-        "field.markClean() should update the clean baseline",
-      );
-      assert(
-        !rowEditDialogHasChanges(dirtyState),
-        "row edit dialog should ignore clean plugin normalization",
-      );
-      assert(
-        closeRowEditDialogIfConfirmed(dirtyState),
-        "normalized row edit dialog should close without confirmation",
-      );
-      assert(
-        confirmMessages.length === 0,
-        "normalized row edit dialog should not ask for confirmation",
-      );
-      field.setValue("<p>Hello</p>");
-      assert(
-        field.hasChanged() && rowEditDialogHasChanges(dirtyState),
-        "later plugin value changes should still count as dirty",
-      );
-
-      try {
-        field.setValue({ id: "df-object" });
-        throw new Error("field.setValue() should reject object values");
-      } catch (error) {
-        if (!String(error.message).includes("serialize objects")) {
-          throw error;
-        }
-      }
-
-      field.setValidity("Pick a file");
-      assert(
-        control.validationMessage === "Pick a file",
-        "field.setValidity() should set custom validity",
-      );
-      assert(
-        control.getAttribute("aria-invalid") === "true",
-        "field.setValidity() should set aria-invalid",
-      );
-      assert(
-        field.validationMessageElement && !field.validationMessageElement.hidden,
-        "field.setValidity() should show a field validation message",
-      );
-      field.clearValidity();
-      assert(
-        control.validationMessage === "" &&
-          control.getAttribute("aria-invalid") === null,
-        "field.clearValidity() should clear custom validity",
-      );
-
-      field.useSqliteDefault();
-      assert(
-        field.isUsingSqliteDefault() && control.disabled,
-        "field.useSqliteDefault() should mark and disable control",
-      );
-    }
-    """)
+    data = project_row(datasette_server, 2)
+    assert data["title"] == "Launch Datasette Cloud"
+    assert data["metadata"] == '{"ok": false, "source": "playwright"}'
+    assert data["logo"] == "asset-from-plugin"
+    assert data["notes"] == "Inserted from Playwright"
+    assert data["score"] == 5
 
 
 @pytest.mark.playwright
-def test_builtin_json_column_field_validation(page, datasette_server):
+def test_edit_row_flow_validates_json_and_saves_changes(page, datasette_server):
     page.goto(f"{datasette_server}data/projects")
-    page.evaluate("""
-    () => {
-      const assert = (condition, message) => {
-        if (!condition) {
-          throw new Error(message);
-        }
-      };
+    page.locator('tr[data-row="1"] button[data-row-action="edit"]').click()
 
-      const plugins = [];
-      registerBuiltinColumnFieldPlugins({
-        registerPlugin(name, plugin) {
-          plugins.push({ name, plugin });
-        },
-      });
-      const jsonPlugin = plugins.find(
-        (entry) => entry.name === "datasette-json-column",
-      );
-      assert(
-        jsonPlugin,
-        "datasette-json-column plugin was not registered",
-      );
-      const pluginControl = jsonPlugin.plugin.makeColumnField({
-        column: "metadata",
-        columnType: { type: "json", config: {} },
-      });
-      assert(
-        pluginControl && pluginControl.useTextarea === true,
-        "JSON column plugin should request a textarea",
-      );
+    dialog = page.locator("#row-edit-dialog")
+    dialog.wait_for()
+    title = dialog.locator('input[name="title"]')
+    title.wait_for()
+    title.fill("Build Datasette, edited")
 
-      const context = columnFormControlContext(
-        "metadata",
-        false,
-        { type: "json", config: {} },
-        { mode: "edit" },
-      );
-      const control = document.createElement("textarea");
-      control.className = "row-edit-input";
-      control.name = "metadata";
-      control.value = '{"ok": true}';
-      control.dataset.initialValue = '{"ok": true}';
-      control.dataset.initialValueKind = "string";
-      control.dataset.currentValueKind = "string";
-      const meta = document.createElement("span");
+    metadata = dialog.locator('textarea[name="metadata"]')
+    metadata.fill("{")
+    dialog.locator(
+        ".row-edit-field-validation-error", has_text="Invalid JSON"
+    ).wait_for()
+    dialog.locator(".row-edit-save").click()
+    assert dialog.evaluate("node => node.open")
+    assert project_row(datasette_server, 1)["title"] == "Build Datasette"
 
-      const field = createColumnFieldApi({
-        id: "row-edit-field-0",
-        labelId: "row-edit-field-label-0",
-        descriptionId: "row-edit-field-meta-0",
-        control,
-        meta,
-        context,
-      });
-      const wrapper = renderColumnField(
-        Object.assign({ pluginName: "datasette-json-column" }, pluginControl),
-        field,
-      );
+    metadata.fill('{"ok": true, "edited": true}')
+    dialog.locator(
+        ".row-edit-field-validation-error", has_text="Invalid JSON"
+    ).wait_for(state="hidden")
+    dialog.locator('textarea[name="notes"]').fill("Edited from Playwright")
+    asset = dialog.locator(".playwright-asset-picker")
+    asset.wait_for()
+    assert asset.get_attribute("data-mode") == "edit"
+    asset.locator(".playwright-asset-select").click()
 
-      assert(
-        control.validationMessage === "",
-        "Initial valid JSON should not be invalid",
-      );
-      assert(
-        control.dataset.initialValueKind === "string",
-        "JSON plugin should keep the original string value kind",
-      );
-      assert(
-        control.dataset.currentValueKind === "string",
-        "JSON plugin should keep the current string value kind",
-      );
-      assert(
-        field.validationMessageElement &&
-          field.validationMessageElement.hidden === true,
-        "JSON validation message should start hidden",
-      );
+    dialog.locator(".row-edit-save").click()
+    page.locator(".row-mutation-status", has_text="Updated row 1").wait_for()
+    row = page.locator('tr[data-row="1"]')
+    assert "Build Datasette, edited" in row.inner_text()
 
-      control.value = "{";
-      control.dispatchEvent(new Event("input", { bubbles: true }));
-      assert(
-        control.validationMessage.startsWith("Invalid JSON"),
-        "Invalid JSON should set a custom validity message",
-      );
-      assert(
-        control.getAttribute("aria-invalid") === "true",
-        "Invalid JSON should set aria-invalid",
-      );
-      assert(
-        !field.validationMessageElement.hidden,
-        "Invalid JSON should show the validation message",
-      );
+    data = project_row(datasette_server, 1)
+    assert data["title"] == "Build Datasette, edited"
+    assert data["metadata"] == '{"ok": true, "edited": true}'
+    assert data["logo"] == "asset-from-plugin"
+    assert data["notes"] == "Edited from Playwright"
 
-      control.value = '{"ok": true}';
-      control.dispatchEvent(new Event("input", { bubbles: true }));
-      assert(
-        control.validationMessage === "",
-        "Valid JSON should clear the custom validity message",
-      );
-      assert(
-        control.getAttribute("aria-invalid") === null,
-        "Valid JSON should clear aria-invalid",
-      );
-      assert(
-        field.validationMessageElement.hidden,
-        "Valid JSON should hide the validation message",
-      );
 
-      control.dataset.initialValue = '{"ok":';
-      control.value = '{"ok": true}';
-      const fields = document.createElement("div");
-      fields.appendChild(wrapper);
-      const values = collectRowFormValues({
-        mode: "edit",
-        fields,
-      });
-      assert(
-        values.metadata === '{"ok": true}',
-        "Corrected JSON should be submitted as a string value",
-      );
-    }
-    """)
+@pytest.mark.playwright
+def test_delete_row_flow_removes_row(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator('tr[data-row="1"] button[data-row-action="delete"]').click()
+
+    dialog = page.locator("#row-delete-dialog")
+    dialog.wait_for()
+    assert "Delete row 1" in dialog.inner_text()
+    dialog.locator(".row-delete-confirm").click()
+
+    page.locator(".row-mutation-status", has_text="Deleted row 1").wait_for()
+    page.locator('tr[data-row="1"]').wait_for(state="detached")
+    assert project_rows(datasette_server, id=1) == []

From 8c700f5337239b69e653c648628bf1a61203c4a6 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 14:25:42 -0700
Subject: [PATCH 228/386] Renamed base_url parameter to ds_base_url in tests

Integrating Playwright brought in pytest-base-url which declares a
base_url fixture that was colliding with our own base_url parameters.
---
 tests/test_internals_urls.py | 48 ++++++++++++++++++------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/tests/test_internals_urls.py b/tests/test_internals_urls.py
index fc7b0313..24fa745d 100644
--- a/tests/test_internals_urls.py
+++ b/tests/test_internals_urls.py
@@ -9,7 +9,7 @@ def ds():
 
 
 @pytest.mark.parametrize(
-    "base_url,path,expected",
+    "ds_base_url,path,expected",
     [
         ("/", "/", "/"),
         ("/", "/foo", "/foo"),
@@ -20,8 +20,8 @@ def ds():
         ("/data/", "/data/foo", "/data/data/foo"),
     ],
 )
-def test_path(ds, base_url, path, expected):
-    ds._settings["base_url"] = base_url
+def test_path(ds, ds_base_url, path, expected):
+    ds._settings["base_url"] = ds_base_url
     actual = ds.urls.path(path)
     assert actual == expected
     assert isinstance(actual, PrefixedUrlString)
@@ -36,35 +36,35 @@ def test_path_applied_twice_does_not_double_prefix(ds):
 
 
 @pytest.mark.parametrize(
-    "base_url,expected",
+    "ds_base_url,expected",
     [
         ("/", "/"),
         ("/prefix/", "/prefix/"),
     ],
 )
-def test_instance(ds, base_url, expected):
-    ds._settings["base_url"] = base_url
+def test_instance(ds, ds_base_url, expected):
+    ds._settings["base_url"] = ds_base_url
     actual = ds.urls.instance()
     assert actual == expected
     assert isinstance(actual, PrefixedUrlString)
 
 
 @pytest.mark.parametrize(
-    "base_url,file,expected",
+    "ds_base_url,file,expected",
     [
         ("/", "foo.js", "/-/static/foo.js"),
         ("/prefix/", "foo.js", "/prefix/-/static/foo.js"),
     ],
 )
-def test_static(ds, base_url, file, expected):
-    ds._settings["base_url"] = base_url
+def test_static(ds, ds_base_url, file, expected):
+    ds._settings["base_url"] = ds_base_url
     actual = ds.urls.static(file)
     assert actual == expected
     assert isinstance(actual, PrefixedUrlString)
 
 
 @pytest.mark.parametrize(
-    "base_url,plugin,file,expected",
+    "ds_base_url,plugin,file,expected",
     [
         (
             "/",
@@ -80,44 +80,44 @@ def test_static(ds, base_url, file, expected):
         ),
     ],
 )
-def test_static_plugins(ds, base_url, plugin, file, expected):
-    ds._settings["base_url"] = base_url
+def test_static_plugins(ds, ds_base_url, plugin, file, expected):
+    ds._settings["base_url"] = ds_base_url
     actual = ds.urls.static_plugins(plugin, file)
     assert actual == expected
     assert isinstance(actual, PrefixedUrlString)
 
 
 @pytest.mark.parametrize(
-    "base_url,expected",
+    "ds_base_url,expected",
     [
         ("/", "/-/logout"),
         ("/prefix/", "/prefix/-/logout"),
     ],
 )
-def test_logout(ds, base_url, expected):
-    ds._settings["base_url"] = base_url
+def test_logout(ds, ds_base_url, expected):
+    ds._settings["base_url"] = ds_base_url
     actual = ds.urls.logout()
     assert actual == expected
     assert isinstance(actual, PrefixedUrlString)
 
 
 @pytest.mark.parametrize(
-    "base_url,format,expected",
+    "ds_base_url,format,expected",
     [
         ("/", None, "/_memory"),
         ("/prefix/", None, "/prefix/_memory"),
         ("/", "json", "/_memory.json"),
     ],
 )
-def test_database(ds, base_url, format, expected):
-    ds._settings["base_url"] = base_url
+def test_database(ds, ds_base_url, format, expected):
+    ds._settings["base_url"] = ds_base_url
     actual = ds.urls.database("_memory", format=format)
     assert actual == expected
     assert isinstance(actual, PrefixedUrlString)
 
 
 @pytest.mark.parametrize(
-    "base_url,name,format,expected",
+    "ds_base_url,name,format,expected",
     [
         ("/", "name", None, "/_memory/name"),
         ("/prefix/", "name", None, "/prefix/_memory/name"),
@@ -125,8 +125,8 @@ def test_database(ds, base_url, format, expected):
         ("/", "name.json", "json", "/_memory/name~2Ejson.json"),
     ],
 )
-def test_table_and_query(ds, base_url, name, format, expected):
-    ds._settings["base_url"] = base_url
+def test_table_and_query(ds, ds_base_url, name, format, expected):
+    ds._settings["base_url"] = ds_base_url
     actual1 = ds.urls.table("_memory", name, format=format)
     assert actual1 == expected
     assert isinstance(actual1, PrefixedUrlString)
@@ -136,15 +136,15 @@ def test_table_and_query(ds, base_url, name, format, expected):
 
 
 @pytest.mark.parametrize(
-    "base_url,format,expected",
+    "ds_base_url,format,expected",
     [
         ("/", None, "/_memory/facetable/1"),
         ("/prefix/", None, "/prefix/_memory/facetable/1"),
         ("/", "json", "/_memory/facetable/1.json"),
     ],
 )
-def test_row(ds, base_url, format, expected):
-    ds._settings["base_url"] = base_url
+def test_row(ds, ds_base_url, format, expected):
+    ds._settings["base_url"] = ds_base_url
     actual = ds.urls.row("_memory", "facetable", "1", format=format)
     assert actual == expected
     assert isinstance(actual, PrefixedUrlString)

From 1ae55007f22e04df86380e536b4d67a47d050155 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 14:27:26 -0700
Subject: [PATCH 229/386] Release 1.0a34

Refs #2767, #2775, #2776, #2779, #2780, #2782
---
 datasette/version.py  | 2 +-
 docs/changelog.rst    | 8 +++++---
 docs/contributing.rst | 2 ++
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/datasette/version.py b/datasette/version.py
index 9536d459..12fa170e 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a33"
+__version__ = "1.0a34"
 __version_info__ = tuple(__version__.split("."))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index e4aae2b8..1516604e 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -3,10 +3,11 @@
 =========
 Changelog
 =========
-.. _unreleased:
 
-Unreleased
-----------
+.. _v1_0_a34:
+
+1.0a34 (2026-06-16)
+-------------------
 
 The big feature in this alpha is tools to **insert, edit and delete** rows within the Datasette interface. These features are available on table pages, and edit and delete are also available as action items on the row page.
 
@@ -23,6 +24,7 @@ The edit interface takes :ref:`custom column types <table_configuration_column_t
 - New ``/<database>/<table>/-/fragment`` :ref:`HTML fragment endpoint  <TableFragmentView>` for returning the HTML used to display a specific row.
 - ``await request.json()`` utility method for consuming the request body as JSON. (:issue:`2767`)
 - Database, table, query and row action menus can now be modified by plugins to :ref:`display buttons in addition to links <plugin_actions>`. (:issue:`2782`)
+- Datasette :ref:`now uses Playwright <contributing_playwright>` for browser automation tests as part of the test suite. (:issue:`2779`)
 
 .. _v1_0_a33:
 
diff --git a/docs/contributing.rst b/docs/contributing.rst
index f28b9bcb..11bb7aa8 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -62,6 +62,8 @@ You can run the tests faster using multiple CPU cores with `pytest-xdist <https:
 
     uv run pytest -m "serial"
 
+.. _contributing_playwright:
+
 Running Playwright tests
 ~~~~~~~~~~~~~~~~~~~~~~~~
 

From dfd5b95ec8adc425b683df22148cb1c14bb01128 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 09:52:02 -0700
Subject: [PATCH 230/386] Document --headed option, closes #2791

---
 docs/contributing.rst | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/docs/contributing.rst b/docs/contributing.rst
index 11bb7aa8..3b45834c 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -113,12 +113,23 @@ You can pass extra ``pytest`` options after the browser name:
     just playwright chromium -k permissions
     just playwright-all -x
 
-If you are not using ``just``, the equivalent Chromium commands are:
+You can add the ``--headed`` option to have Playwright open a browser window that you can see while it runs the tests. This only works if you specify a browser, for example:
+
+.. code-block:: bash
+
+    just playwright firefox --headed
+
+Combine this with ``-k`` to watch a specific test:
+
+.. code-block:: bash
+
+    just playwright chromium --headed -k test_insert_row
+
+If you are not using ``just``, the equivalent ``uv run`` commands are:
 
 .. code-block:: bash
 
     uv run --group playwright playwright install chromium
-
     uv run --group playwright pytest tests/test_playwright.py --playwright --browser chromium
 
 .. _contributing_using_fixtures:

From f673e7416f3a18a1ad9471d696782206114532f7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 19 Jun 2026 17:14:33 -0700
Subject: [PATCH 231/386] Add create table execute-write template (#2794)

Add a Create table starter template to the execute-write page, alongside the existing table-specific insert/update/delete templates.

Keep template button clicks in-page by updating CodeMirror and the URL without collapsing the template controls.

Refresh schema metadata after successful schema-changing execute-write statements so newly created tables appear immediately.
---
 datasette/app.py                       |   7 +-
 datasette/templates/execute_write.html |  71 ++++++++++----
 datasette/views/execute_write.py       |  33 +++++++
 tests/test_queries.py                  | 127 +++++++++++++++++++++++++
 4 files changed, 220 insertions(+), 18 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 545a65c8..139e4c34 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -625,9 +625,12 @@ class Datasette:
                 return action
         return None
 
-    async def refresh_schemas(self):
+    async def refresh_schemas(self, *, force=False):
         # Throttle schema refreshes to at most once per second
-        if time.monotonic() - getattr(self, "_last_schema_refresh", 0) < 1.0:
+        if (
+            not force
+            and time.monotonic() - getattr(self, "_last_schema_refresh", 0) < 1.0
+        ):
             return
         self._last_schema_refresh = time.monotonic()
         if self._refresh_schemas_lock.locked():
diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 949850ed..0d0a9931 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -93,20 +93,25 @@ form.sql.core input[data-execute-write-submit]:disabled {
 {% endif %}
 
 <form class="sql core" action="{{ urls.database(database) }}/-/execute-write" method="post" data-analyze-url="{{ urls.database(database) }}/-/execute-write/analyze">
-    {% if write_template_tables %}
+    {% if write_create_table_template_sql or write_template_tables %}
         <div class="execute-write-template-menu">
             <details>
                 <summary>Start with a template</summary>
                 <p class="execute-write-template-controls">
-                    <label for="execute-write-template-table">Table</label>
-                    <select id="execute-write-template-table">
-                        {% for table_name, table in write_template_tables|dictsort %}
-                            <option value="{{ table_name }}"{% for operation, template_sql in table.templates|dictsort %} data-template-{{ operation }}-sql="{{ template_sql }}"{% endfor %}>{{ table_name }}</option>
+                    {% if write_create_table_template_sql %}
+                        <button type="button" data-sql-template="create" data-template-sql="{{ write_create_table_template_sql }}">Create table</button>
+                    {% endif %}
+                    {% if write_template_tables %}
+                        <label for="execute-write-template-table">{% if write_create_table_template_sql %}or table:{% else %}Table{% endif %}</label>
+                        <select id="execute-write-template-table">
+                            {% for table_name, table in write_template_tables|dictsort %}
+                                <option value="{{ table_name }}"{% for operation, template_sql in table.templates|dictsort %} data-template-{{ operation }}-sql="{{ template_sql }}"{% endfor %}>{{ table_name }}</option>
+                            {% endfor %}
+                        </select>
+                        {% for operation in write_template_operations %}
+                            <button type="button" data-sql-template="{{ operation.name }}">{{ operation.label }}</button>
                         {% endfor %}
-                    </select>
-                    {% for operation in write_template_operations %}
-                        <button type="button" data-sql-template="{{ operation.name }}">{{ operation.label }}</button>
-                    {% endfor %}
+                    {% endif %}
                 </p>
             </details>
         </div>
@@ -252,11 +257,12 @@ window.addEventListener("DOMContentLoaded", () => {
 });
 </script>
 
-{% if write_template_tables %}
+{% if write_create_table_template_sql or write_template_tables %}
 <script>
 window.addEventListener("DOMContentLoaded", () => {
   const tableSelect = document.querySelector("#execute-write-template-table");
   const templateButtons = document.querySelectorAll("[data-sql-template]");
+  const sqlInput = document.querySelector("textarea#sql-editor");
 
   function dataKey(operation) {
     return `template${operation.charAt(0).toUpperCase()}${operation.slice(1)}Sql`;
@@ -266,26 +272,59 @@ window.addEventListener("DOMContentLoaded", () => {
     return tableSelect ? tableSelect.options[tableSelect.selectedIndex] : null;
   }
 
-  function templateSql(operation) {
+  function templateSql(button) {
+    if (button.dataset.templateSql) {
+      return button.dataset.templateSql;
+    }
+    const operation = button.dataset.sqlTemplate;
     const option = selectedOption();
     return option ? option.dataset[dataKey(operation)] || "" : "";
   }
 
   function updateTemplateButtons() {
     templateButtons.forEach((button) => {
-      button.hidden = !templateSql(button.dataset.sqlTemplate);
+      button.hidden = !templateSql(button);
     });
   }
 
+  function updateSqlUrl(sql) {
+    if (!window.history || !window.history.replaceState) {
+      return;
+    }
+    const url = new URL(window.location.href);
+    url.searchParams.set("sql", sql);
+    window.history.replaceState(null, "", url.toString());
+  }
+
+  function setEditorSql(sql) {
+    if (window.editor) {
+      window.editor.dispatch({
+        changes: {
+          from: 0,
+          to: window.editor.state.doc.length,
+          insert: sql,
+        },
+        selection: { anchor: sql.length },
+      });
+      window.editor.focus();
+      if (sqlInput) {
+        sqlInput.value = sql;
+      }
+    } else if (sqlInput) {
+      sqlInput.value = sql;
+      sqlInput.dispatchEvent(new Event("input", { bubbles: true }));
+      sqlInput.focus();
+    }
+    updateSqlUrl(sql);
+  }
+
   templateButtons.forEach((button) => {
     button.addEventListener("click", () => {
-      const sql = templateSql(button.dataset.sqlTemplate);
+      const sql = templateSql(button);
       if (!sql) {
         return;
       }
-      const url = new URL(window.location.href);
-      url.searchParams.set("sql", sql);
-      window.location.href = url.toString();
+      setEditorSql(sql);
     });
   });
   if (tableSelect) {
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index 2817f56e..b7e8288e 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -31,6 +31,15 @@ WRITE_TEMPLATE_LABELS = {
     "delete": "Delete rows",
 }
 WRITE_TEMPLATE_OPERATIONS = tuple(WRITE_TEMPLATE_LABELS)
+CREATE_TABLE_TEMPLATE_SQL = "\n".join(
+    (
+        "create table new_table (",
+        "  id integer primary key,",
+        "  name text",
+        "  -- created text default (datetime('now'))",
+        ")",
+    )
+)
 
 
 def _parameter_names(columns):
@@ -207,6 +216,23 @@ def _write_template_operations(write_template_tables):
     return operations
 
 
+async def _create_table_template_sql(datasette, db, actor):
+    if await datasette.allowed(
+        action="create-table",
+        resource=DatabaseResource(db.name),
+        actor=actor,
+    ):
+        return CREATE_TABLE_TEMPLATE_SQL
+    return None
+
+
+def _analysis_changes_schema(analysis):
+    return any(
+        operation.operation in {"create", "alter", "drop"}
+        for operation in analysis.operations
+    )
+
+
 class ExecuteWriteView(BaseView):
     name = "execute-write"
     has_json_alternate = False
@@ -241,6 +267,9 @@ class ExecuteWriteView(BaseView):
             self.ds, db, table_columns, hidden_table_names, request.actor
         )
         write_template_operations = _write_template_operations(write_template_tables)
+        write_create_table_template_sql = await _create_table_template_sql(
+            self.ds, db, request.actor
+        )
         if sql and analysis_error is None:
             try:
                 parameter_names = _derived_query_parameters(sql)
@@ -302,6 +331,7 @@ class ExecuteWriteView(BaseView):
                 "table_columns": table_columns,
                 "write_template_tables": write_template_tables,
                 "write_template_operations": write_template_operations,
+                "write_create_table_template_sql": write_create_table_template_sql,
                 "save_query_url": save_query_url,
                 "save_query_base_url": save_query_base_url,
             },
@@ -387,6 +417,9 @@ class ExecuteWriteView(BaseView):
                 status=400,
             )
 
+        if _analysis_changes_schema(analysis):
+            await self.ds.refresh_schemas(force=True)
+
         if cursor.rowcount == -1:
             message = "Query executed"
         else:
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 0354f73a..c3c0b9db 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -14,6 +14,15 @@ from datasette.utils.sqlite import sqlite3, supports_returning
 requires_sqlite_returning = pytest.mark.skipif(
     not supports_returning(), reason="SQLite does not support RETURNING"
 )
+EXPECTED_CREATE_TABLE_TEMPLATE_SQL = "\n".join(
+    (
+        "create table new_table (",
+        "  id integer primary key,",
+        "  name text",
+        "  -- created text default (datetime('now'))",
+        ")",
+    )
+)
 
 
 def _template_option_attributes(html, table):
@@ -29,6 +38,16 @@ def _template_sql(html, table, operation):
     return unescape(match.group(1))
 
 
+def _template_button_sql(html, operation):
+    soup = Soup(html, "html.parser")
+    button = soup.select_one('button[data-sql-template="{}"]'.format(operation))
+    assert button, "Could not find {} template button".format(operation)
+    assert button.get(
+        "data-template-sql"
+    ), "Could not find SQL for {} template button".format(operation)
+    return button["data-template-sql"]
+
+
 async def add_numbered_queries(ds, database, count):
     for i in range(1, count + 1):
         await ds.add_query(
@@ -1645,6 +1664,14 @@ async def test_execute_write_get_prepopulates_without_executing():
     )
     assert "<h2>Query operations</h2>" in response.text
     assert "<summary>Start with a template</summary>" in response.text
+    assert 'data-sql-template="create"' in response.text
+    assert _template_button_sql(response.text, "create") == (
+        EXPECTED_CREATE_TABLE_TEMPLATE_SQL
+    )
+    assert ">Create table</button>" in response.text
+    assert '<label for="execute-write-template-table">or table:</label>' in (
+        response.text
+    )
     assert '<option value="dogs"' in response.text
     assert "data-template-insert-sql=" in response.text
     assert 'data-sql-template="insert"' in response.text
@@ -1660,6 +1687,9 @@ async def test_execute_write_get_prepopulates_without_executing():
     assert 'addEventListener("paste"' in response.text
     assert "setupSqlParameterRefresh" in response.text
     assert "datasetteSqlAnalysis.renderAnalysis" in response.text
+    assert "window.editor.dispatch" in response.text
+    assert "window.history.replaceState" in response.text
+    assert "window.location.href = url.toString();" not in response.text
     assert "input[data-execute-write-submit]:disabled" in response.text
     assert (
         'data-execute-write-disabled-reason aria-live="polite" hidden' in response.text
@@ -1813,6 +1843,7 @@ async def test_execute_write_templates_are_filtered_by_permission_and_server_gen
     assert '<option value="dogs"' in writer_response.text
     assert '<option value="manual"' in writer_response.text
     assert '<option value="cats"' not in writer_response.text
+    assert 'data-sql-template="create"' not in writer_response.text
     assert "function insertSql(" not in writer_response.text
     assert "function updateSql(" not in writer_response.text
     assert "function deleteSql(" not in writer_response.text
@@ -1842,6 +1873,7 @@ async def test_execute_write_templates_are_filtered_by_permission_and_server_gen
     assert 'data-sql-template="delete"' in deleter_response.text
     assert 'data-sql-template="insert"' not in deleter_response.text
     assert 'data-sql-template="update"' not in deleter_response.text
+    assert 'data-sql-template="create"' not in deleter_response.text
 
     assert viewer_response.status_code == 200
     assert "<summary>Start with a template</summary>" not in viewer_response.text
@@ -1851,6 +1883,101 @@ async def test_execute_write_templates_are_filtered_by_permission_and_server_gen
     assert "data-template-delete-sql" not in viewer_response.text
 
 
+@pytest.mark.asyncio
+async def test_execute_write_create_table_template_is_filtered_by_permission():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": ["creator", "editor", "both"]},
+                        "execute-write-sql": {"id": ["creator", "editor", "both"]},
+                        "create-table": {"id": ["creator", "both"]},
+                    },
+                    "tables": {
+                        "dogs": {
+                            "permissions": {
+                                "view-table": {"id": ["editor", "both"]},
+                                "insert-row": {"id": ["editor", "both"]},
+                                "update-row": {"id": ["editor", "both"]},
+                                "delete-row": {"id": ["editor", "both"]},
+                            }
+                        },
+                    },
+                }
+            }
+        },
+    )
+    db = ds.add_memory_database("execute_write_create_template", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    creator_response = await ds.client.get(
+        "/data/-/execute-write", actor={"id": "creator"}
+    )
+    editor_response = await ds.client.get(
+        "/data/-/execute-write", actor={"id": "editor"}
+    )
+    both_response = await ds.client.get("/data/-/execute-write", actor={"id": "both"})
+
+    assert creator_response.status_code == 200
+    assert "<summary>Start with a template</summary>" in creator_response.text
+    assert _template_button_sql(creator_response.text, "create") == (
+        EXPECTED_CREATE_TABLE_TEMPLATE_SQL
+    )
+    assert "There are no tables that you can currently edit." not in (
+        creator_response.text
+    )
+    assert 'id="execute-write-template-table"' not in creator_response.text
+    assert 'data-sql-template="insert"' not in creator_response.text
+    assert 'data-sql-template="update"' not in creator_response.text
+    assert 'data-sql-template="delete"' not in creator_response.text
+
+    assert editor_response.status_code == 200
+    assert 'data-sql-template="create"' not in editor_response.text
+    assert '<label for="execute-write-template-table">Table</label>' in (
+        editor_response.text
+    )
+    assert 'data-sql-template="insert"' in editor_response.text
+    assert 'data-sql-template="update"' in editor_response.text
+    assert 'data-sql-template="delete"' in editor_response.text
+
+    assert both_response.status_code == 200
+    assert _template_button_sql(both_response.text, "create") == (
+        EXPECTED_CREATE_TABLE_TEMPLATE_SQL
+    )
+    assert '<label for="execute-write-template-table">or table:</label>' in (
+        both_response.text
+    )
+    assert 'data-sql-template="insert"' in both_response.text
+    assert 'data-sql-template="update"' in both_response.text
+    assert 'data-sql-template="delete"' in both_response.text
+
+
+@pytest.mark.asyncio
+async def test_execute_write_create_table_refreshes_template_tables():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("execute_write_create_template_refresh", name="data")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "root"},
+        data={"sql": "create table selectable (id integer primary key, name text)"},
+    )
+
+    assert response.status_code == 200
+    assert "Query executed" in response.text
+    assert '<option value="selectable"' in response.text
+    assert _template_sql(response.text, "selectable", "insert") == (
+        'insert into "selectable" (\n' '  "name"\n' ")\n" "values (\n" "  :name\n" ")"
+    )
+    assert await db.table_exists("selectable")
+
+
 @pytest.mark.asyncio
 async def test_execute_write_analyze_endpoint_uses_sql_only():
     ds = Datasette(memory=True, default_deny=True)

From ad6fe47a950ba66794b6b947911c628a5520feda Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 17:33:51 -0700
Subject: [PATCH 232/386] Better way of setting min height on CodeMirror

Previously there were four lines of whitespace, but that
meant users had to delete that whitespace themselves when
they started editing. Now it is four lines tall without that.
---
 datasette/templates/execute_write.html | 15 +++++++--------
 tests/test_queries.py                  |  4 +++-
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/datasette/templates/execute_write.html b/datasette/templates/execute_write.html
index 0d0a9931..592577f8 100644
--- a/datasette/templates/execute_write.html
+++ b/datasette/templates/execute_write.html
@@ -56,6 +56,11 @@ form.sql.core input[data-execute-write-submit]:disabled {
     cursor: not-allowed;
     opacity: 1;
 }
+.execute-write form.sql .sql-editor-min-lines .cm-content,
+.execute-write form.sql .sql-editor-min-lines .cm-gutter {
+    /* Four visible editor lines without adding blank lines to the SQL value. */
+    min-height: calc(5.6em + 8px);
+}
 .execute-write-disabled-reason {
     color: #4f5b6d;
     font-size: 0.85rem;
@@ -119,7 +124,7 @@ form.sql.core input[data-execute-write-submit]:disabled {
         <p class="message-warning execute-write-template-unavailable">There are no tables that you can currently edit.</p>
     {% endif %}
 
-    <p class="sql-editor"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
+    <p class="sql-editor{% if not sql %} sql-editor-min-lines{% endif %}"><textarea id="sql-editor" name="sql"{% if sql %} style="height: {{ sql.split("\n")|length + 2 }}em"{% endif %}>{{ sql }}</textarea></p>
 
     {% set sql_parameters_section_id = "execute-write-parameters-section" %}
     {% set sql_parameters_allow_expand = true %}
@@ -164,19 +169,13 @@ form.sql.core input[data-execute-write-submit]:disabled {
     </p>
 </form>
 
-<script>
-const executeWriteSqlInput = document.querySelector("textarea#sql-editor");
-if (executeWriteSqlInput && !executeWriteSqlInput.value) {
-  executeWriteSqlInput.value = "\n\n\n";
-}
-</script>
-
 {% include "_codemirror_foot.html" %}
 {% include "_sql_parameter_scripts.html" %}
 {% include "_execute_write_analysis_scripts.html" %}
 
 <script>
 window.addEventListener("DOMContentLoaded", () => {
+  const executeWriteSqlInput = document.querySelector("textarea#sql-editor");
   const form = document.querySelector("form.sql.core");
   const analysisSection = document.querySelector("#execute-write-analysis-section");
   const submitButton = form
diff --git a/tests/test_queries.py b/tests/test_queries.py
index c3c0b9db..b757f221 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1708,8 +1708,10 @@ async def test_execute_write_get_prepopulates_without_executing():
         "/data/-/execute-write",
         actor={"id": "root"},
     )
+    assert '<p class="sql-editor sql-editor-min-lines">' in empty_response.text
     assert '<textarea id="sql-editor" name="sql"></textarea>' in empty_response.text
-    assert 'executeWriteSqlInput.value = "\\n\\n\\n";' in empty_response.text
+    assert "min-height: calc(5.6em + 8px);" in empty_response.text
+    assert 'executeWriteSqlInput.value = "\\n\\n\\n";' not in empty_response.text
     assert "Enter writable SQL before executing." in empty_response.text
     assert 'data-save-query-base-url="/data/-/queries/store"' in empty_response.text
     assert '<a href="/data/-/queries/store' not in empty_response.text

From 387f4dd4bcbb74539345ecbaaa31c5635d9c6b11 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 21 Jun 2026 16:46:20 -0700
Subject: [PATCH 233/386] Try sqlite-utils 4.0rc1 in CI

Also output current sqlite-utils version in pytest headers

Refs https://github.com/simonw/sqlite-utils/issues/758
---
 .github/workflows/test.yml | 7 +++++++
 tests/conftest.py          | 7 ++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index a1b2e9d2..80416ec2 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -11,6 +11,10 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
+        sqlite-utils-version: [""]
+        include:
+        - python-version: "3.14"
+          sqlite-utils-version: "4.0rc1"
     steps:
     - uses: actions/checkout@v6
     - name: Set up Python ${{ matrix.python-version }}
@@ -26,6 +30,9 @@ jobs:
     - name: Install dependencies
       run: |
         pip install . --group dev
+        if [ -n "${{ matrix.sqlite-utils-version }}" ]; then
+          pip install sqlite-utils==${{ matrix.sqlite-utils-version }}
+        fi
         pip freeze
     - name: Run tests
       run: |
diff --git a/tests/conftest.py b/tests/conftest.py
index 55110a42..8860d54c 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -1,4 +1,5 @@
 import httpx
+import importlib.metadata
 import os
 import pathlib
 import pytest
@@ -93,7 +94,11 @@ def pytest_report_header(config):
     conn = sqlite3.connect(":memory:")
     version = conn.execute("select sqlite_version()").fetchone()[0]
     conn.close()
-    headers = ["SQLite: {}".format(version)]
+    sqlite_utils_version = importlib.metadata.version("sqlite-utils")
+    headers = [
+        "SQLite: {}".format(version),
+        "sqlite-utils: {}".format(sqlite_utils_version),
+    ]
     if config.getoption("--playwright"):
         try:
             browsers = config.getoption("--browser")

From bccb7f17e571b41ac9668a6e243266effa938add Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 21 Jun 2026 16:52:14 -0700
Subject: [PATCH 234/386] Don't fail test run on sqlite-utils 4.0rc1 failures

Refs https://github.com/simonw/sqlite-utils/issues/758#issuecomment-4763675905
---
 .github/workflows/test.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 80416ec2..74366b29 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -8,13 +8,17 @@ permissions:
 jobs:
   test:
     runs-on: ubuntu-latest
+    continue-on-error: ${{ matrix.experimental }}
     strategy:
+      fail-fast: false
       matrix:
         python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
         sqlite-utils-version: [""]
+        experimental: [false]
         include:
         - python-version: "3.14"
           sqlite-utils-version: "4.0rc1"
+          experimental: true
     steps:
     - uses: actions/checkout@v6
     - name: Set up Python ${{ matrix.python-version }}

From 57e7bba38f04a1c3d25094aa3b8a1ecad1ff429a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 09:06:00 -0700
Subject: [PATCH 235/386] Stop matrix testing against sqlite-utils 4.0rc1

Refs https://github.com/simonw/sqlite-utils/issues/758#issuecomment-4770349630

I'm going to test this in a branch instead.
---
 .github/workflows/test.yml | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 74366b29..9e47db6f 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -8,17 +8,10 @@ permissions:
 jobs:
   test:
     runs-on: ubuntu-latest
-    continue-on-error: ${{ matrix.experimental }}
     strategy:
       fail-fast: false
       matrix:
         python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
-        sqlite-utils-version: [""]
-        experimental: [false]
-        include:
-        - python-version: "3.14"
-          sqlite-utils-version: "4.0rc1"
-          experimental: true
     steps:
     - uses: actions/checkout@v6
     - name: Set up Python ${{ matrix.python-version }}
@@ -34,9 +27,6 @@ jobs:
     - name: Install dependencies
       run: |
         pip install . --group dev
-        if [ -n "${{ matrix.sqlite-utils-version }}" ]; then
-          pip install sqlite-utils==${{ matrix.sqlite-utils-version }}
-        fi
         pip freeze
     - name: Run tests
       run: |

From 2d3c85dfc0b802dcb6736f17cb15e84f67d4f921 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 16 Jun 2026 18:02:58 -0700
Subject: [PATCH 236/386] Add create table UI

Adds a permission-gated database action that opens a create table modal on database pages, backed by the existing create-table JSON API.

The modal starts with an id integer primary key column plus a blank text column, supports SQLite type selection, and shows custom column type controls only when the actor can set column types.

Selected custom column types are applied after table creation with follow-up set-column-type API calls. Includes styling plus HTML and Playwright coverage for the action payload and create-table flow.
---
 datasette/static/app.css          | 323 ++++++++++++++
 datasette/static/edit-tools.js    | 679 ++++++++++++++++++++++++++++++
 datasette/templates/database.html |   4 +
 datasette/views/database.py       | 120 +++++-
 tests/test_playwright.py          |  53 +++
 tests/test_table_html.py          | 144 +++++++
 6 files changed, 1303 insertions(+), 20 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 5fe4502d..ce0c46a8 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1749,6 +1749,289 @@ datasette-autocomplete input[type="text"],
     cursor: not-allowed;
 }
 
+dialog.table-create-dialog {
+    --ink: #0f0f0f;
+    --paper: #eef6ff;
+    --muted: #6b6b6b;
+    --rule: #d8e6f5;
+    --accent: #1a56db;
+    --card: #ffffff;
+    border: none;
+    border-radius: var(--modal-border-radius, 0.75rem);
+    padding: 0;
+    margin: auto;
+    width: min(760px, calc(100vw - 32px));
+    max-width: 95vw;
+    max-height: min(780px, calc(100vh - 32px));
+    box-shadow: var(--modal-shadow, 0 20px 25px -5px rgba(0, 0, 0, 0.1), 0 10px 10px -5px rgba(0, 0, 0, 0.04));
+    animation: datasette-modal-slide-in var(--modal-animation-duration, 0.2s) ease-out;
+    overflow: hidden;
+    font-family: system-ui, -apple-system, sans-serif;
+    background: var(--card);
+}
+
+dialog.table-create-dialog[open] {
+    display: flex;
+    flex-direction: column;
+}
+
+dialog.table-create-dialog::backdrop {
+    background: var(--modal-backdrop-bg, rgba(0, 0, 0, 0.5));
+    backdrop-filter: var(--modal-backdrop-blur, blur(4px));
+    -webkit-backdrop-filter: var(--modal-backdrop-blur, blur(4px));
+    animation: datasette-modal-fade-in var(--modal-animation-duration, 0.2s) ease-out;
+}
+
+.table-create-dialog .modal-header {
+    padding: 20px 24px 12px;
+    border-bottom: 1px solid var(--rule);
+    display: flex;
+    align-items: center;
+    gap: 12px;
+    flex-shrink: 0;
+    min-width: 0;
+}
+
+.table-create-dialog .modal-title {
+    display: flex;
+    align-items: center;
+    min-width: 0;
+    max-width: 100%;
+    font-size: 1rem;
+    font-weight: 600;
+    color: var(--ink);
+}
+
+.table-create-form {
+    display: flex;
+    flex: 1 1 auto;
+    min-height: 0;
+    flex-direction: column;
+}
+
+.table-create-error {
+    border-left: 4px solid #b91c1c;
+    border-radius: 4px;
+    background: #fff1f1;
+    color: #7f1d1d;
+    font-size: 0.9rem;
+    margin: 12px 24px 0;
+    padding: 10px 12px;
+}
+
+.table-create-error:focus {
+    outline: 3px solid rgba(185, 28, 28, 0.18);
+    outline-offset: 2px;
+}
+
+.table-create-fields {
+    display: grid;
+    gap: 18px;
+    padding: 16px 24px 24px;
+    overflow-y: auto;
+}
+
+.table-create-field {
+    display: grid;
+    grid-template-columns: minmax(120px, 180px) minmax(0, 1fr);
+    gap: 12px;
+    align-items: start;
+}
+
+.table-create-label,
+.table-create-columns-heading {
+    color: var(--ink);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.82rem;
+}
+
+.table-create-label {
+    padding-top: 8px;
+}
+
+.table-create-column-label {
+    border: 0;
+    clip: rect(0 0 0 0);
+    height: 1px;
+    margin: -1px;
+    overflow: hidden;
+    padding: 0;
+    position: absolute;
+    white-space: nowrap;
+    width: 1px;
+}
+
+.table-create-input {
+    box-sizing: border-box;
+    min-width: 0;
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    padding: 8px 10px;
+    color: var(--ink);
+    background: #fff;
+    font: inherit;
+}
+
+.table-create-input-placeholder {
+    color: var(--muted);
+}
+
+.table-create-custom-column-type option {
+    color: var(--ink);
+}
+
+.table-create-custom-column-type option[value=""] {
+    color: var(--muted);
+}
+
+.table-create-table-name {
+    width: 100%;
+}
+
+.table-create-input:focus {
+    border-color: var(--accent);
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+}
+
+.table-create-columns {
+    display: grid;
+    gap: 10px;
+}
+
+.table-create-columns-heading {
+    font-weight: 600;
+}
+
+.table-create-column-list {
+    display: grid;
+    gap: 8px;
+}
+
+.table-create-column-row {
+    display: grid;
+    grid-template-columns: minmax(140px, 1.2fr) minmax(7.5rem, 0.7fr) minmax(12rem, 1fr) minmax(3.5rem, max-content) 32px;
+    align-items: center;
+    gap: 8px;
+    min-width: 0;
+    position: relative;
+}
+
+.table-create-primary-key {
+    display: inline-flex;
+    align-items: center;
+    gap: 6px;
+    color: var(--ink);
+    font-size: 0.85rem;
+    min-width: 0;
+    white-space: nowrap;
+    justify-self: center;
+}
+
+.table-create-primary-key-input {
+    margin: 0;
+}
+
+.table-create-remove-column {
+    appearance: none;
+    border: 1px solid rgba(74, 85, 104, 0.24);
+    background: transparent;
+    color: #4a5568;
+    border-radius: 4px;
+    cursor: pointer;
+    display: inline-grid;
+    place-items: center;
+    height: 32px;
+    width: 32px;
+    padding: 0;
+}
+
+.table-create-remove-column:hover,
+.table-create-remove-column:focus {
+    background: rgba(74, 85, 104, 0.07);
+}
+
+.table-create-remove-column:focus {
+    outline: 3px solid #b3d4ff;
+    outline-offset: 1px;
+}
+
+.table-create-remove-column svg {
+    display: block;
+}
+
+.table-create-add-column {
+    appearance: none;
+    justify-self: start;
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    background: #fff;
+    color: var(--accent);
+    cursor: pointer;
+    font: inherit;
+    font-size: 0.85rem;
+    padding: 7px 10px;
+}
+
+.table-create-add-column:hover,
+.table-create-add-column:focus {
+    background: #f8fafc;
+}
+
+.table-create-add-column:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 1px;
+}
+
+.table-create-dialog .modal-footer {
+    padding: 14px 20px;
+    border-top: 1px solid var(--rule);
+    display: flex;
+    align-items: center;
+    justify-content: flex-end;
+    gap: 10px;
+    flex-shrink: 0;
+    background: var(--paper);
+}
+
+.table-create-dialog .btn {
+    border: none;
+    border-radius: 5px;
+    padding: 9px 20px;
+    font-size: 0.85rem;
+    font-weight: 500;
+    cursor: pointer;
+    touch-action: manipulation;
+    font-family: inherit;
+    transition: background 0.12s;
+}
+
+.table-create-dialog .btn-ghost {
+    background: transparent;
+    color: var(--muted);
+    border: 1px solid var(--rule);
+}
+
+.table-create-dialog .btn-ghost:hover {
+    background: var(--rule);
+    color: var(--ink);
+}
+
+.table-create-dialog .btn-primary {
+    background: var(--accent);
+    color: #fff;
+}
+
+.table-create-dialog .btn-primary:hover {
+    background: #1949b8;
+}
+
+.table-create-dialog .btn:disabled,
+.table-create-add-column:disabled,
+.table-create-remove-column:disabled {
+    opacity: 0.55;
+    cursor: not-allowed;
+}
+
 .row-link-with-actions {
     display: inline-flex;
     align-items: center;
@@ -1892,6 +2175,46 @@ datasette-autocomplete input[type="text"],
         padding-right: 18px;
     }
 
+    dialog.table-create-dialog {
+        width: 95vw;
+        max-height: 85vh;
+        border-radius: 0.5rem;
+    }
+
+    .table-create-dialog .modal-header,
+    .table-create-fields {
+        padding-left: 18px;
+        padding-right: 18px;
+    }
+
+    .table-create-error {
+        margin-left: 18px;
+        margin-right: 18px;
+    }
+
+    .table-create-field {
+        grid-template-columns: 1fr;
+        gap: 5px;
+    }
+
+    .table-create-label {
+        padding-top: 0;
+    }
+
+    .table-create-column-row {
+        grid-template-columns: minmax(0, 1fr) 8.5rem 3.5rem 32px;
+        align-items: end;
+    }
+
+    .table-create-custom-column-type {
+        grid-column: 1 / -1;
+    }
+
+    .table-create-dialog .modal-footer {
+        padding-left: 18px;
+        padding-right: 18px;
+    }
+
     .row-inline-action {
         min-height: 30px;
         min-width: 30px;
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 8142d02b..4b93c4fd 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -2,6 +2,8 @@ var ROW_DELETE_DIALOG_ID = "row-delete-dialog";
 var rowDeleteDialogState = null;
 var ROW_EDIT_DIALOG_ID = "row-edit-dialog";
 var rowEditDialogState = null;
+var TABLE_CREATE_DIALOG_ID = "table-create-dialog";
+var tableCreateDialogState = null;
 
 function ensureRowMutationStatus(manager) {
   var status = document.querySelector(".row-mutation-status");
@@ -43,6 +45,682 @@ function hideRowMutationStatus() {
   status.textContent = "";
 }
 
+function databaseCreateTableData() {
+  return (
+    window._datasetteDatabaseData &&
+    window._datasetteDatabaseData.createTable
+  );
+}
+
+function tableCreateColumnTypes() {
+  var data = databaseCreateTableData() || {};
+  return data.columnTypes && data.columnTypes.length
+    ? data.columnTypes
+    : ["text", "integer", "float", "blob"];
+}
+
+function tableCreateCustomColumnTypes() {
+  var data = databaseCreateTableData() || {};
+  return data.customColumnTypes || [];
+}
+
+function tableCreateCustomColumnType(name) {
+  var options = tableCreateCustomColumnTypes();
+  for (var i = 0; i < options.length; i += 1) {
+    if (options[i].name === name) {
+      return options[i];
+    }
+  }
+  return null;
+}
+
+function tableCreateCustomTypeAppliesToSqliteType(option, sqliteType) {
+  return (
+    option &&
+    option.sqliteTypes &&
+    option.sqliteTypes.indexOf(sqliteType) !== -1
+  );
+}
+
+function tableCreateDialogSignature(state) {
+  if (!state || !state.form) {
+    return "";
+  }
+  var columns = [];
+  state.columnList
+    .querySelectorAll(".table-create-column-row")
+    .forEach(function (row) {
+      columns.push({
+        name: row.querySelector(".table-create-column-name").value,
+        type: row.querySelector(".table-create-column-type").value,
+        customType:
+          (
+            row.querySelector(".table-create-custom-column-type") || {
+              value: "",
+            }
+          ).value || "",
+        pk: row.querySelector(".table-create-primary-key-input").checked,
+      });
+    });
+  return JSON.stringify({
+    table: state.tableName.value,
+    columns: columns,
+  });
+}
+
+function tableCreateDialogHasChanges(state) {
+  return (
+    !!state &&
+    !state.isSaving &&
+    tableCreateDialogSignature(state) !== state.initialSignature
+  );
+}
+
+function clearTableCreateDialogError(state) {
+  state.error.hidden = true;
+  state.error.textContent = "";
+  state.dialog.removeAttribute("aria-describedby");
+}
+
+function showTableCreateDialogError(state, message) {
+  state.error.hidden = false;
+  state.error.textContent = message;
+  state.dialog.setAttribute("aria-describedby", "table-create-error");
+  state.error.focus();
+}
+
+function setTableCreateDialogSaving(state, isSaving) {
+  state.isSaving = isSaving;
+  state.cancelButton.disabled = isSaving;
+  state.saveButton.disabled = isSaving;
+  state.addColumnButton.disabled = isSaving;
+  state.saveButton.textContent = isSaving ? "Creating..." : "Create table";
+  state.columnList
+    .querySelectorAll("input, select, button")
+    .forEach(function (control) {
+      control.disabled = isSaving;
+    });
+}
+
+function tableCreateSelectTypeValue(select, type) {
+  var options = tableCreateColumnTypes();
+  options.forEach(function (option) {
+    var optionElement = document.createElement("option");
+    optionElement.value = option;
+    optionElement.textContent = option;
+    select.appendChild(optionElement);
+  });
+  select.value = options.indexOf(type) === -1 ? options[0] : type;
+}
+
+function updateTableCreateCustomColumnTypePlaceholder(select) {
+  select.classList.toggle(
+    "table-create-input-placeholder",
+    !select.value,
+  );
+}
+
+function createTableCustomColumnTypeSelect() {
+  var options = tableCreateCustomColumnTypes();
+  var select = document.createElement("select");
+  select.className = "table-create-input table-create-custom-column-type";
+  select.setAttribute("aria-label", "Custom column type");
+  var blankOption = document.createElement("option");
+  blankOption.value = "";
+  blankOption.textContent = "- custom type -";
+  select.appendChild(blankOption);
+  options.forEach(function (option) {
+    var optionElement = document.createElement("option");
+    optionElement.value = option.name;
+    optionElement.textContent = option.description
+      ? option.description + " (" + option.name + ")"
+      : option.name;
+    select.appendChild(optionElement);
+  });
+  updateTableCreateCustomColumnTypePlaceholder(select);
+  return select;
+}
+
+function syncTableCreateCustomTypeForSqliteType(row) {
+  var typeSelect = row.querySelector(".table-create-column-type");
+  var customTypeSelect = row.querySelector(".table-create-custom-column-type");
+  if (!typeSelect || !customTypeSelect || !customTypeSelect.value) {
+    return;
+  }
+  var option = tableCreateCustomColumnType(customTypeSelect.value);
+  if (!tableCreateCustomTypeAppliesToSqliteType(option, typeSelect.value)) {
+    customTypeSelect.value = "";
+    updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+  }
+}
+
+function createTableColumnRow(state, column) {
+  var index = state.nextColumnIndex;
+  state.nextColumnIndex += 1;
+
+  var row = document.createElement("div");
+  row.className = "table-create-column-row";
+
+  var nameId = "table-create-column-name-" + index;
+  var nameLabel = document.createElement("label");
+  nameLabel.className = "table-create-column-label";
+  nameLabel.setAttribute("for", nameId);
+  nameLabel.textContent = "Column";
+
+  var nameInput = document.createElement("input");
+  nameInput.id = nameId;
+  nameInput.className = "table-create-input table-create-column-name";
+  nameInput.type = "text";
+  nameInput.required = true;
+  nameInput.autocomplete = "off";
+  nameInput.value = column && column.name ? column.name : "";
+
+  var typeSelect = document.createElement("select");
+  typeSelect.className = "table-create-input table-create-column-type";
+  typeSelect.setAttribute("aria-label", "Column type");
+  tableCreateSelectTypeValue(typeSelect, column && column.type);
+
+  var customTypeSelect = createTableCustomColumnTypeSelect();
+  if (column && column.customType) {
+    customTypeSelect.value = column.customType;
+  }
+  updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+
+  var pkLabel = document.createElement("label");
+  pkLabel.className = "table-create-primary-key";
+  var pkInput = document.createElement("input");
+  pkInput.type = "checkbox";
+  pkInput.className = "table-create-primary-key-input";
+  pkInput.checked = !!(column && column.primaryKey);
+  var pkText = document.createElement("span");
+  pkText.textContent = "PK";
+  pkText.title = "Primary key";
+  pkLabel.appendChild(pkInput);
+  pkLabel.appendChild(pkText);
+
+  var removeButton = document.createElement("button");
+  removeButton.type = "button";
+  removeButton.className = "table-create-remove-column";
+  removeButton.setAttribute("aria-label", "Remove column");
+  removeButton.title = "Remove column";
+  removeButton.innerHTML =
+    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M3 6h18"></path><path d="M8 6V4a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v2"></path><path d="M19 6l-1 14a2 2 0 0 1-2 2H8a2 2 0 0 1-2-2L5 6"></path></svg>';
+
+  row.appendChild(nameLabel);
+  row.appendChild(nameInput);
+  row.appendChild(typeSelect);
+  if (tableCreateCustomColumnTypes().length) {
+    row.appendChild(customTypeSelect);
+  }
+  row.appendChild(pkLabel);
+  row.appendChild(removeButton);
+
+  removeButton.addEventListener("click", function () {
+    if (state.isSaving) {
+      return;
+    }
+    row.remove();
+    clearTableCreateDialogError(state);
+    var nextInput = state.columnList.querySelector(
+      ".table-create-column-name",
+    );
+    if (nextInput) {
+      nextInput.focus();
+    } else {
+      state.addColumnButton.focus();
+    }
+  });
+
+  nameInput.addEventListener("input", function () {
+    clearTableCreateDialogError(state);
+  });
+  typeSelect.addEventListener("change", function () {
+    clearTableCreateDialogError(state);
+    syncTableCreateCustomTypeForSqliteType(row);
+  });
+  customTypeSelect.addEventListener("change", function () {
+    clearTableCreateDialogError(state);
+    updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+    var option = tableCreateCustomColumnType(customTypeSelect.value);
+    if (
+      option &&
+      option.fixedSqliteType &&
+      tableCreateColumnTypes().indexOf(option.fixedSqliteType) !== -1
+    ) {
+      typeSelect.value = option.fixedSqliteType;
+    }
+  });
+  pkInput.addEventListener("change", function () {
+    clearTableCreateDialogError(state);
+  });
+
+  return row;
+}
+
+function addTableCreateColumn(state, column) {
+  var row = createTableColumnRow(state, column || { type: "text" });
+  state.columnList.appendChild(row);
+  return row;
+}
+
+function resetTableCreateDialog(state) {
+  state.nextColumnIndex = 0;
+  state.tableName.value = "";
+  state.columnList.textContent = "";
+  addTableCreateColumn(state, {
+    name: "id",
+    type: "integer",
+    primaryKey: true,
+  });
+  addTableCreateColumn(state, {
+    name: "",
+    type: "text",
+    primaryKey: false,
+  });
+  state.initialSignature = tableCreateDialogSignature(state);
+}
+
+function collectTableCreatePayload(state) {
+  var payload = {
+    table: state.tableName.value.trim(),
+    columns: [],
+  };
+  var primaryKeys = [];
+  state.columnList
+    .querySelectorAll(".table-create-column-row")
+    .forEach(function (row) {
+      var name = row.querySelector(".table-create-column-name").value.trim();
+      var type = row.querySelector(".table-create-column-type").value;
+      payload.columns.push({ name: name, type: type });
+      if (row.querySelector(".table-create-primary-key-input").checked) {
+        primaryKeys.push(name);
+      }
+    });
+  if (primaryKeys.length === 1) {
+    payload.pk = primaryKeys[0];
+  } else if (primaryKeys.length > 1) {
+    payload.pks = primaryKeys;
+  }
+  return payload;
+}
+
+function collectTableCreateColumnTypeAssignments(state) {
+  var assignments = [];
+  state.columnList
+    .querySelectorAll(".table-create-column-row")
+    .forEach(function (row) {
+      var customTypeSelect = row.querySelector(
+        ".table-create-custom-column-type",
+      );
+      if (!customTypeSelect || !customTypeSelect.value) {
+        return;
+      }
+      assignments.push({
+        column: row.querySelector(".table-create-column-name").value.trim(),
+        columnType: customTypeSelect.value,
+        sqliteType: row.querySelector(".table-create-column-type").value,
+      });
+    });
+  return assignments;
+}
+
+function validateTableCreatePayload(payload) {
+  if (!payload.table) {
+    return "Table name is required.";
+  }
+  if (payload.table.indexOf("\n") !== -1) {
+    return "Table name cannot contain newlines.";
+  }
+  if (/^sqlite_/i.test(payload.table)) {
+    return "Table name cannot start with sqlite_.";
+  }
+  if (!payload.columns.length) {
+    return "At least one column is required.";
+  }
+  var seen = {};
+  var supportedTypes = tableCreateColumnTypes();
+  for (var i = 0; i < payload.columns.length; i += 1) {
+    var column = payload.columns[i];
+    if (!column.name) {
+      return "Column name is required.";
+    }
+    if (column.name.indexOf("\n") !== -1) {
+      return "Column names cannot contain newlines.";
+    }
+    var columnKey = column.name.toLowerCase();
+    if (seen[columnKey]) {
+      return "Duplicate column name: " + column.name;
+    }
+    seen[columnKey] = true;
+    if (supportedTypes.indexOf(column.type) === -1) {
+      return "Unsupported column type: " + column.type;
+    }
+  }
+  return null;
+}
+
+function validateTableCreateColumnTypeAssignments(assignments) {
+  for (var i = 0; i < assignments.length; i += 1) {
+    var assignment = assignments[i];
+    var option = tableCreateCustomColumnType(assignment.columnType);
+    if (!option) {
+      return "Unknown custom column type: " + assignment.columnType;
+    }
+    if (!tableCreateCustomTypeAppliesToSqliteType(option, assignment.sqliteType)) {
+      return (
+        "Custom type " +
+        assignment.columnType +
+        " cannot be used with SQLite type " +
+        assignment.sqliteType +
+        "."
+      );
+    }
+  }
+  return null;
+}
+
+function fallbackTableUrl(tableName) {
+  var data = databaseCreateTableData() || {};
+  if (!data.path) {
+    return null;
+  }
+  return data.path.replace(/\/-\/create$/, "/" + encodeURIComponent(tableName));
+}
+
+function tableCreateSetColumnTypeUrl(responseData, payload) {
+  var tableUrl =
+    responseData.table_url || fallbackTableUrl(responseData.table || payload.table);
+  if (!tableUrl) {
+    return null;
+  }
+  var url = new URL(tableUrl, location.href);
+  url.hash = "";
+  url.search = "";
+  url.pathname = url.pathname.replace(/\/$/, "") + "/-/set-column-type";
+  return url.toString();
+}
+
+async function assignTableCreateColumnTypes(responseData, payload, assignments) {
+  if (!assignments.length) {
+    return;
+  }
+  var url = tableCreateSetColumnTypeUrl(responseData, payload);
+  if (!url) {
+    throw new Error("Could not find the set column type URL.");
+  }
+  for (var i = 0; i < assignments.length; i += 1) {
+    var assignment = assignments[i];
+    var response = await fetch(url, {
+      method: "POST",
+      headers: {
+        "Content-Type": "application/json",
+        Accept: "application/json",
+      },
+      body: JSON.stringify({
+        column: assignment.column,
+        column_type: {
+          type: assignment.columnType,
+        },
+      }),
+    });
+    var data = null;
+    try {
+      data = await response.json();
+    } catch (_error) {
+      data = null;
+    }
+    if (!response.ok || (data && data.ok === false)) {
+      var error = rowMutationRequestError(response, data);
+      throw new Error(
+        "Created table, but could not set custom type for " +
+          assignment.column +
+          ": " +
+          error.message,
+      );
+    }
+  }
+}
+
+async function saveTableCreateDialog(state) {
+  if (state.isSaving) {
+    return;
+  }
+  var data = databaseCreateTableData();
+  if (!data || !data.path) {
+    showTableCreateDialogError(state, "Could not find the create table URL.");
+    return;
+  }
+  clearTableCreateDialogError(state);
+  var payload = collectTableCreatePayload(state);
+  var columnTypeAssignments = collectTableCreateColumnTypeAssignments(state);
+  var validationError = validateTableCreatePayload(payload);
+  if (validationError) {
+    showTableCreateDialogError(state, validationError);
+    return;
+  }
+  var columnTypeValidationError = validateTableCreateColumnTypeAssignments(
+    columnTypeAssignments,
+  );
+  if (columnTypeValidationError) {
+    showTableCreateDialogError(state, columnTypeValidationError);
+    return;
+  }
+  setTableCreateDialogSaving(state, true);
+  try {
+    var response = await fetch(data.path, {
+      method: "POST",
+      headers: {
+        "Content-Type": "application/json",
+        Accept: "application/json",
+      },
+      body: JSON.stringify(payload),
+    });
+    var responseData = null;
+    try {
+      responseData = await response.json();
+    } catch (_error) {
+      responseData = null;
+    }
+    if (!response.ok || (responseData && responseData.ok === false)) {
+      throw rowMutationRequestError(response, responseData);
+    }
+    await assignTableCreateColumnTypes(
+      responseData,
+      payload,
+      columnTypeAssignments,
+    );
+    var tableUrl =
+      responseData.table_url || fallbackTableUrl(responseData.table || payload.table);
+    state.shouldRestoreFocus = false;
+    state.dialog.close();
+    if (tableUrl) {
+      location.href = tableUrl;
+    } else {
+      location.reload();
+    }
+  } catch (error) {
+    setTableCreateDialogSaving(state, false);
+    showTableCreateDialogError(
+      state,
+      error.message || "Could not create table",
+    );
+  }
+}
+
+function confirmDiscardTableCreateChanges(state) {
+  if (!tableCreateDialogHasChanges(state)) {
+    return true;
+  }
+  return window.confirm("Discard this new table?");
+}
+
+function closeTableCreateDialogIfConfirmed(state) {
+  if (!state || state.isSaving) {
+    return false;
+  }
+  if (!confirmDiscardTableCreateChanges(state)) {
+    return false;
+  }
+  state.shouldRestoreFocus = true;
+  state.dialog.close();
+  return true;
+}
+
+function ensureTableCreateDialog(manager) {
+  if (tableCreateDialogState) {
+    return tableCreateDialogState;
+  }
+  if (!window.HTMLDialogElement) {
+    return null;
+  }
+
+  var dialog = document.createElement("dialog");
+  dialog.id = TABLE_CREATE_DIALOG_ID;
+  dialog.className = "table-create-dialog";
+  dialog.setAttribute("aria-labelledby", "table-create-title");
+  dialog.innerHTML = `
+    <div class="modal-header">
+      <span class="modal-title" id="table-create-title">Create table</span>
+    </div>
+    <form class="table-create-form" method="post" novalidate>
+      <p class="table-create-error" id="table-create-error" role="alert" tabindex="-1" hidden></p>
+      <div class="table-create-fields">
+        <div class="table-create-field">
+          <label class="table-create-label" for="table-create-name">Table name</label>
+          <input class="table-create-input table-create-table-name" id="table-create-name" type="text" name="table" required autocomplete="off">
+        </div>
+        <div class="table-create-columns">
+          <div class="table-create-columns-heading">Columns</div>
+          <div class="table-create-column-list"></div>
+          <button type="button" class="table-create-add-column">Add column</button>
+        </div>
+      </div>
+      <div class="modal-footer">
+        <button type="button" class="btn btn-ghost table-create-cancel">Cancel</button>
+        <button type="submit" class="btn btn-primary table-create-save">Create table</button>
+      </div>
+    </form>
+  `;
+  document.body.appendChild(dialog);
+
+  tableCreateDialogState = {
+    dialog: dialog,
+    form: dialog.querySelector(".table-create-form"),
+    title: dialog.querySelector(".modal-title"),
+    error: dialog.querySelector(".table-create-error"),
+    fields: dialog.querySelector(".table-create-fields"),
+    tableName: dialog.querySelector(".table-create-table-name"),
+    columnList: dialog.querySelector(".table-create-column-list"),
+    addColumnButton: dialog.querySelector(".table-create-add-column"),
+    cancelButton: dialog.querySelector(".table-create-cancel"),
+    saveButton: dialog.querySelector(".table-create-save"),
+    currentButton: null,
+    shouldRestoreFocus: true,
+    isSaving: false,
+    initialSignature: "",
+    nextColumnIndex: 0,
+    manager: manager,
+  };
+
+  tableCreateDialogState.form.addEventListener("submit", function (ev) {
+    ev.preventDefault();
+    saveTableCreateDialog(tableCreateDialogState);
+  });
+
+  tableCreateDialogState.addColumnButton.addEventListener("click", function () {
+    if (tableCreateDialogState.isSaving) {
+      return;
+    }
+    var row = addTableCreateColumn(tableCreateDialogState, { type: "text" });
+    clearTableCreateDialogError(tableCreateDialogState);
+    row.querySelector(".table-create-column-name").focus();
+  });
+
+  tableCreateDialogState.cancelButton.addEventListener("click", function () {
+    closeTableCreateDialogIfConfirmed(tableCreateDialogState);
+  });
+
+  tableCreateDialogState.tableName.addEventListener("input", function () {
+    clearTableCreateDialogError(tableCreateDialogState);
+  });
+
+  dialog.addEventListener("click", function (ev) {
+    if (ev.target === dialog) {
+      closeTableCreateDialogIfConfirmed(tableCreateDialogState);
+    }
+  });
+
+  dialog.addEventListener("keydown", function (ev) {
+    if (ev.key !== "Escape") {
+      return;
+    }
+    ev.preventDefault();
+    closeTableCreateDialogIfConfirmed(tableCreateDialogState);
+  });
+
+  dialog.addEventListener("cancel", function (ev) {
+    ev.preventDefault();
+    closeTableCreateDialogIfConfirmed(tableCreateDialogState);
+  });
+
+  dialog.addEventListener("close", function () {
+    var state = tableCreateDialogState;
+    clearTableCreateDialogError(state);
+    setTableCreateDialogSaving(state, false);
+    if (
+      state.shouldRestoreFocus &&
+      state.currentButton &&
+      document.contains(state.currentButton)
+    ) {
+      state.currentButton.focus();
+    }
+  });
+
+  return tableCreateDialogState;
+}
+
+function openTableCreateDialog(button, manager) {
+  var data = databaseCreateTableData();
+  if (!data) {
+    return;
+  }
+  var state = ensureTableCreateDialog(manager);
+  if (!state) {
+    return;
+  }
+
+  var menu = button.closest("details");
+  if (menu) {
+    menu.open = false;
+  }
+  state.manager = manager;
+  state.currentButton = button;
+  state.shouldRestoreFocus = true;
+  state.title.textContent = "Create a table in " + data.databaseName;
+  clearTableCreateDialogError(state);
+  resetTableCreateDialog(state);
+  if (!state.dialog.open) {
+    state.dialog.showModal();
+  }
+  state.tableName.focus();
+}
+
+function initTableCreateActions(manager) {
+  if (!window.fetch || !window.HTMLDialogElement || !databaseCreateTableData()) {
+    return;
+  }
+  document.addEventListener("click", function (ev) {
+    var button = ev.target.closest(
+      'button[data-database-action="create-table"]',
+    );
+    if (!button) {
+      return;
+    }
+    ev.preventDefault();
+    openTableCreateDialog(button, manager);
+  });
+}
+
 function setRowDeleteDialogBusy(state, isBusy) {
   state.isBusy = isBusy;
   state.confirmButton.disabled = isBusy;
@@ -2017,6 +2695,7 @@ document.addEventListener("datasette_init", function (evt) {
   const { detail: manager } = evt;
 
   registerBuiltinColumnFieldPlugins(manager);
+  initTableCreateActions(manager);
   initRowInsertActions(manager);
   initRowEditActions(manager);
   initRowDeleteActions(manager);
diff --git a/datasette/templates/database.html b/datasette/templates/database.html
index 371f6a22..23eeb571 100644
--- a/datasette/templates/database.html
+++ b/datasette/templates/database.html
@@ -6,6 +6,10 @@
 {{- super() -}}
 {% include "_codemirror.html" %}
 {% include "_sql_parameter_styles.html" %}
+{% if database_page_data.createTable %}
+<script>window._datasetteDatabaseData = {{ database_page_data|tojson }};</script>
+<script src="{{ urls.static('edit-tools.js') }}?hash={{ edit_tools_js_hash }}" defer></script>
+{% endif %}
 {% endblock %}
 
 {% block body_class %}db db-{{ database|to_css_class }}{% endblock %}
diff --git a/datasette/views/database.py b/datasette/views/database.py
index cd9565c6..db70b135 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -13,7 +13,8 @@ import textwrap
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.extras import extra_names_from_request
 from datasette.database import QueryInterrupted
-from datasette.resources import DatabaseResource, QueryResource
+from datasette.column_types import SQLiteType
+from datasette.resources import DatabaseResource, QueryResource, TableResource
 from datasette.stored_queries import stored_query_to_dict
 from datasette.write_sql import QueryWriteRejected
 from datasette.utils import (
@@ -46,6 +47,18 @@ from .table_extras import (
 )
 from . import Context
 
+CREATE_TABLE_COLUMN_TYPES = ["text", "integer", "float", "blob"]
+CREATE_TABLE_SQLITE_TYPES = {
+    "text": SQLiteType.TEXT,
+    "integer": SQLiteType.INTEGER,
+    "float": SQLiteType.REAL,
+    "blob": SQLiteType.BLOB,
+}
+CREATE_TABLE_TYPE_FOR_SQLITE_TYPE = {
+    sqlite_type: column_type
+    for column_type, sqlite_type in CREATE_TABLE_SQLITE_TYPES.items()
+}
+
 
 class DatabaseView(View):
     async def get(self, request, datasette):
@@ -117,21 +130,36 @@ class DatabaseView(View):
             else len(stored_queries)
         )
 
+        # Resolve the registered database-level actions for this database in
+        # one batched query, seeding the request permission cache so allowed()
+        # calls made inside plugin hooks below are served from the cache.
+        database_action_permissions = await datasette.allowed_many(
+            actions=[
+                name
+                for name, action in datasette.actions.items()
+                if action.resource_class is DatabaseResource
+            ],
+            resource=DatabaseResource(database),
+            actor=request.actor,
+        )
+        create_table_ui = await _database_create_table_ui(
+            datasette, request, db, database, database_action_permissions
+        )
+
         async def database_actions():
-            # Resolve the registered database-level actions for this
-            # database in one batched query, seeding the request permission
-            # cache so that allowed() calls made inside the plugin hooks
-            # below are served from the cache
-            await datasette.allowed_many(
-                actions=[
-                    name
-                    for name, action in datasette.actions.items()
-                    if action.resource_class is DatabaseResource
-                ],
-                resource=DatabaseResource(database),
-                actor=request.actor,
-            )
             links = []
+            if create_table_ui:
+                links.append(
+                    {
+                        "type": "button",
+                        "label": "Create table",
+                        "description": "Create a new table in this database.",
+                        "attrs": {
+                            "aria-label": "Create table in {}".format(database),
+                            "data-database-action": "create-table",
+                        },
+                    }
+                )
             for hook in pm.hook.database_actions(
                 datasette=datasette,
                 database=database,
@@ -211,6 +239,9 @@ class DatabaseView(View):
                     ),
                     metadata=metadata,
                     database_color=db.color,
+                    database_page_data=(
+                        {"createTable": create_table_ui} if create_table_ui else {}
+                    ),
                     database_actions=database_actions,
                     show_hidden=request.args.get("_show_hidden"),
                     editable=True,
@@ -263,6 +294,9 @@ class DatabaseContext(Context):
     )
     metadata: dict = field(metadata={"help": "Metadata for the database"})
     database_color: str = field(metadata={"help": "The color assigned to the database"})
+    database_page_data: dict = field(
+        metadata={"help": "JSON data used by JavaScript on the database page"}
+    )
     database_actions: callable = field(
         metadata={
             "help": "Callable returning list of action links for the database menu"
@@ -292,6 +326,57 @@ class DatabaseContext(Context):
     )
 
 
+async def _database_create_table_ui(
+    datasette, request, db, database_name, database_action_permissions
+):
+    if not db.is_mutable:
+        return None
+    if not database_action_permissions.get("create-table"):
+        return None
+    data = {
+        "path": "{}/-/create".format(datasette.urls.database(database_name)),
+        "databaseName": database_name,
+        "columnTypes": CREATE_TABLE_COLUMN_TYPES,
+    }
+    can_set_column_type = await datasette.allowed(
+        action="set-column-type",
+        resource=TableResource(database=database_name, table="__new_table__"),
+        actor=request.actor,
+    )
+    if can_set_column_type:
+        data["customColumnTypes"] = _custom_column_type_options_for_create_table(
+            datasette
+        )
+    return data
+
+
+def _custom_column_type_options_for_create_table(datasette):
+    options = []
+    for name, ct_cls in sorted(datasette._column_types.items()):
+        sqlite_types = getattr(ct_cls, "sqlite_types", None)
+        if sqlite_types is None:
+            option_sqlite_types = CREATE_TABLE_COLUMN_TYPES[:]
+        else:
+            option_sqlite_types = [
+                create_table_type
+                for create_table_type, sqlite_type in CREATE_TABLE_SQLITE_TYPES.items()
+                if sqlite_type in sqlite_types
+            ]
+        if not option_sqlite_types:
+            continue
+        option = {
+            "name": name,
+            "description": ct_cls.description,
+            "sqliteTypes": option_sqlite_types,
+        }
+        if sqlite_types is not None and len(sqlite_types) == 1:
+            fixed_sqlite_type = CREATE_TABLE_TYPE_FOR_SQLITE_TYPE.get(sqlite_types[0])
+            if fixed_sqlite_type is not None:
+                option["fixedSqliteType"] = fixed_sqlite_type
+        options.append(option)
+    return options
+
+
 @dataclass
 class QueryContext(Context):
     database: str = field(metadata={"help": "The name of the database being queried"})
@@ -1069,12 +1154,7 @@ class TableCreateView(BaseView):
         "replace",
         "alter",
     }
-    _supported_column_types = {
-        "text",
-        "integer",
-        "float",
-        "blob",
-    }
+    _supported_column_types = set(CREATE_TABLE_COLUMN_TYPES)
     # Any string that does not contain a newline or start with sqlite_
     _table_name_re = re.compile(r"^(?!sqlite_)[^\n]+$")
 
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index a8c5aa4b..0c7042f0 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -117,6 +117,10 @@ def write_playwright_config(config_path):
             {
                 "databases": {
                     "data": {
+                        "permissions": {
+                            "create-table": True,
+                            "set-column-type": True,
+                        },
                         "tables": {
                             "projects": {
                                 "label_column": "title",
@@ -275,6 +279,55 @@ def test_datasette_homepage_contains_datasette(page, datasette_server):
     assert "Datasette" in page.locator("body").inner_text()
 
 
+@pytest.mark.playwright
+def test_create_table_flow(page, datasette_server):
+    page.goto(f"{datasette_server}data")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-database-action="create-table"]').click()
+
+    dialog = page.locator("#table-create-dialog")
+    dialog.wait_for()
+    assert dialog.locator(".modal-title").inner_text() == "Create a table in data"
+    placeholder_select = dialog.locator(".table-create-custom-column-type").nth(0)
+    assert placeholder_select.input_value() == ""
+    assert (
+        placeholder_select.locator("option:checked").inner_text() == "- custom type -"
+    )
+    assert "table-create-input-placeholder" in placeholder_select.get_attribute("class")
+    dialog.locator('input[name="table"]').fill("playwright_created")
+    dialog.locator(".table-create-column-name").nth(1).fill("title")
+    dialog.locator(".table-create-add-column").click()
+    dialog.locator(".table-create-column-name").nth(2).fill("score")
+    dialog.locator(".table-create-column-type").nth(2).select_option("integer")
+    dialog.locator(".table-create-add-column").click()
+    dialog.locator(".table-create-column-name").nth(3).fill("metadata")
+    dialog.locator(".table-create-column-type").nth(3).select_option("integer")
+    dialog.locator(".table-create-custom-column-type").nth(3).select_option("json")
+    assert dialog.locator(".table-create-column-type").nth(3).input_value() == "text"
+    assert "table-create-input-placeholder" not in dialog.locator(
+        ".table-create-custom-column-type"
+    ).nth(3).get_attribute("class")
+
+    dialog.locator(".table-create-save").click()
+    page.wait_for_url("**/data/playwright_created")
+    assert "playwright_created" in page.locator("h1").inner_text()
+
+    response = httpx.get(
+        f"{datasette_server}data/playwright_created.json?_extra=columns,column_types"
+    )
+    response.raise_for_status()
+    data = response.json()
+    assert data["columns"] == [
+        "id",
+        "title",
+        "score",
+        "metadata",
+    ]
+    assert data["column_types"] == {
+        "metadata": {"type": "json", "config": None},
+    }
+
+
 @pytest.mark.playwright
 def test_navigation_search_tracks_and_renders_recent_items(page, datasette_server):
     page.goto(datasette_server)
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index aa67bb3f..887fdf50 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -23,6 +23,23 @@ def table_data_from_soup(soup):
     return json.loads(match.group(1))
 
 
+def database_data_from_soup(soup):
+    import json
+    import re
+
+    database_script = [
+        s
+        for s in soup.find_all("script")
+        if "_datasetteDatabaseData" in (s.string or "")
+    ][0]
+    match = re.search(
+        r"window\._datasetteDatabaseData\s*=\s*({.*?});",
+        database_script.string,
+        re.DOTALL,
+    )
+    return json.loads(match.group(1))
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "path,expected_definition_sql",
@@ -934,6 +951,133 @@ async def test_row_delete_action_data_attributes():
         ds.close()
 
 
+@pytest.mark.asyncio
+async def test_database_create_table_action_button_and_data():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "create-table": {"id": "root"},
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_database_create_table_action"), name="data"
+        )
+        await db.execute_write_script("""
+            create table items (id integer primary key, name text);
+            """)
+
+        response = await ds.client.get("/data", actor={"id": "root"})
+        assert response.status_code == 200
+        soup = Soup(response.text, "html.parser")
+
+        button = soup.select_one(
+            'button.action-menu-button[data-database-action="create-table"]'
+        )
+        assert button is not None
+        assert button["aria-label"] == "Create table in data"
+        assert button["role"] == "menuitem"
+        description = button.find("span", class_="dropdown-description")
+        assert description.text.strip() == "Create a new table in this database."
+        description.extract()
+        assert button.text.strip() == "Create table"
+        assert any(
+            "edit-tools.js" in script.get("src", "")
+            for script in soup.find_all("script")
+        )
+        assert database_data_from_soup(soup) == {
+            "createTable": {
+                "path": "/data/-/create",
+                "databaseName": "data",
+                "columnTypes": ["text", "integer", "float", "blob"],
+            },
+        }
+        assert "customColumnTypes" not in database_data_from_soup(soup)["createTable"]
+
+        response_without_permission = await ds.client.get(
+            "/data", actor={"id": "someone-else"}
+        )
+        assert response_without_permission.status_code == 200
+        soup_without_permission = Soup(response_without_permission.text, "html.parser")
+        assert (
+            soup_without_permission.select_one(
+                'button[data-database-action="create-table"]'
+            )
+            is None
+        )
+        assert not any(
+            "_datasetteDatabaseData" in (script.string or "")
+            for script in soup_without_permission.find_all("script")
+        )
+    finally:
+        ds.close()
+
+
+@pytest.mark.asyncio
+async def test_database_create_table_data_includes_custom_column_types():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "create-table": {"id": "root"},
+                        "set-column-type": {"id": "root"},
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_database_create_table_custom_types"),
+            name="data",
+        )
+        await db.execute_write_script("""
+            create table items (id integer primary key, name text);
+            """)
+
+        response = await ds.client.get("/data", actor={"id": "root"})
+        assert response.status_code == 200
+        create_table_data = database_data_from_soup(Soup(response.text, "html.parser"))[
+            "createTable"
+        ]
+        assert create_table_data["customColumnTypes"] == [
+            {
+                "name": "email",
+                "description": "Email address",
+                "sqliteTypes": ["text"],
+                "fixedSqliteType": "text",
+            },
+            {
+                "name": "json",
+                "description": "JSON data",
+                "sqliteTypes": ["text"],
+                "fixedSqliteType": "text",
+            },
+            {
+                "name": "textarea",
+                "description": "Multiline text",
+                "sqliteTypes": ["text"],
+                "fixedSqliteType": "text",
+            },
+            {
+                "name": "url",
+                "description": "URL",
+                "sqliteTypes": ["text"],
+                "fixedSqliteType": "text",
+            },
+        ]
+    finally:
+        ds.close()
+
+
 @pytest.mark.asyncio
 async def test_table_insert_action_button_and_data():
     ds = Datasette(

From b40665dd143a81b5cea99ff039b3bc8a41c41d1f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 09:14:19 -0700
Subject: [PATCH 237/386] Add alter table JSON API

- Add POST /<database>/<table>/-/alter with Pydantic validation and dry-run support.
- Support add, rename, alter, drop, primary-key and reorder operations, including allow-listed default expressions.
- Document the endpoint and cover schema changes, validation, permissions, events and dry runs.

Refs #2788
---
 datasette/app.py         |   5 +
 datasette/views/table.py | 353 +++++++++++++++++++++++++++++++++++++++
 docs/json_api.rst        | 103 ++++++++++++
 pyproject.toml           |   1 +
 tests/test_api_write.py  | 205 +++++++++++++++++++++++
 5 files changed, 667 insertions(+)

diff --git a/datasette/app.py b/datasette/app.py
index 139e4c34..6ea3d5a4 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -84,6 +84,7 @@ from .views.special import (
 )
 from .views.table import (
     TableAutocompleteView,
+    TableAlterView,
     TableInsertView,
     TableUpsertView,
     TableSetColumnTypeView,
@@ -2626,6 +2627,10 @@ class Datasette:
             TableUpsertView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/upsert$",
         )
+        add_route(
+            TableAlterView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/alter$",
+        )
         add_route(
             TableSetColumnTypeView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/set-column-type$",
diff --git a/datasette/views/table.py b/datasette/views/table.py
index c5448c85..11a28323 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1,10 +1,12 @@
 import asyncio
 import itertools
 import json
+from typing import Annotated, Any, Literal, Union
 import urllib
 import urllib.parse
 
 import markupsafe
+from pydantic import BaseModel, ConfigDict, Field, ValidationError, model_validator
 
 from datasette.column_types import SQLiteType
 from datasette.extras import extra_names_from_request
@@ -46,6 +48,7 @@ from datasette.utils import (
 from datasette.utils.asgi import BadRequest, Forbidden, NotFound, Request, Response
 from datasette.filters import Filters
 import sqlite_utils
+from sqlite_utils.db import DEFAULT as SQLITE_UTILS_DEFAULT
 from .base import BaseView, DatasetteError, _error, stream_csv
 from .database import QueryView
 from .table_extras import (
@@ -649,6 +652,154 @@ async def display_columns_and_rows(
     return columns, cell_rows
 
 
+SqliteApiType = Literal["text", "integer", "float", "blob"]
+DefaultExpr = Literal["current_timestamp", "current_date", "current_time"]
+DEFAULT_EXPR_SQL = {
+    "current_timestamp": "CURRENT_TIMESTAMP",
+    "current_date": "CURRENT_DATE",
+    "current_time": "CURRENT_TIME",
+}
+
+
+class _StrictPydanticModel(BaseModel):
+    model_config = ConfigDict(extra="forbid")
+
+
+class _DefaultArgsMixin(_StrictPydanticModel):
+    default: Any | None = None
+    default_expr: DefaultExpr | None = None
+
+    @model_validator(mode="after")
+    def validate_default_fields(self):
+        has_default = "default" in self.model_fields_set
+        has_default_expr = "default_expr" in self.model_fields_set
+        if has_default and has_default_expr:
+            raise ValueError("default and default_expr cannot both be provided")
+        if has_default_expr and self.default_expr is None:
+            raise ValueError("default_expr cannot be null")
+        return self
+
+
+class AddColumnArgs(_DefaultArgsMixin):
+    name: str
+    type: SqliteApiType = "text"
+    not_null: bool = False
+
+
+class RenameColumnArgs(_StrictPydanticModel):
+    name: str
+    to: str
+
+
+class AlterColumnArgs(_DefaultArgsMixin):
+    name: str
+    type: SqliteApiType | None = None
+    not_null: bool | None = None
+
+    @model_validator(mode="after")
+    def require_change(self):
+        if not (
+            {"type", "not_null", "default", "default_expr"} & self.model_fields_set
+        ):
+            raise ValueError(
+                "At least one of type, not_null, default or default_expr must be provided"
+            )
+        return self
+
+
+class DropColumnArgs(_StrictPydanticModel):
+    name: str
+
+
+class SetPrimaryKeyArgs(_StrictPydanticModel):
+    columns: list[str] = Field(min_length=1)
+
+
+class ReorderColumnsArgs(_StrictPydanticModel):
+    columns: list[str] = Field(min_length=1)
+
+
+class AddColumnOperation(_StrictPydanticModel):
+    op: Literal["add_column"]
+    args: AddColumnArgs
+
+
+class RenameColumnOperation(_StrictPydanticModel):
+    op: Literal["rename_column"]
+    args: RenameColumnArgs
+
+
+class AlterColumnOperation(_StrictPydanticModel):
+    op: Literal["alter_column"]
+    args: AlterColumnArgs
+
+
+class DropColumnOperation(_StrictPydanticModel):
+    op: Literal["drop_column"]
+    args: DropColumnArgs
+
+
+class SetPrimaryKeyOperation(_StrictPydanticModel):
+    op: Literal["set_primary_key"]
+    args: SetPrimaryKeyArgs
+
+
+class ReorderColumnsOperation(_StrictPydanticModel):
+    op: Literal["reorder_columns"]
+    args: ReorderColumnsArgs
+
+
+AlterTableOperation = Annotated[
+    Union[
+        AddColumnOperation,
+        RenameColumnOperation,
+        AlterColumnOperation,
+        DropColumnOperation,
+        SetPrimaryKeyOperation,
+        ReorderColumnsOperation,
+    ],
+    Field(discriminator="op"),
+]
+
+
+class AlterTableRequest(_StrictPydanticModel):
+    operations: list[AlterTableOperation] = Field(min_length=1)
+    dry_run: bool = False
+
+
+def _pydantic_errors(validation_error):
+    errors = []
+    for error in validation_error.errors():
+        location = ".".join(str(item) for item in error["loc"])
+        message = error["msg"]
+        errors.append("{}: {}".format(location, message) if location else message)
+    return errors
+
+
+def _table_schema_from_conn(conn, table_name):
+    row = conn.execute(
+        "select sql from sqlite_master where type = 'table' and name = ?",
+        [table_name],
+    ).fetchone()
+    return row[0] if row else None
+
+
+def _primary_key_value(columns):
+    if len(columns) == 1:
+        return columns[0]
+    return tuple(columns)
+
+
+def _default_expression_sql(default_expr):
+    return DEFAULT_EXPR_SQL[default_expr]
+
+
+def _literal_default(db, value):
+    if isinstance(value, str):
+        return db.quote(value)
+    return value
+
+
 class TableInsertView(BaseView):
     name = "table-insert"
 
@@ -946,6 +1097,208 @@ class TableUpsertView(TableInsertView):
         return await super().post(request, upsert=True)
 
 
+class TableAlterView(BaseView):
+    name = "table-alter"
+
+    def __init__(self, datasette):
+        self.ds = datasette
+
+    async def post(self, request):
+        try:
+            resolved = await self.ds.resolve_table(request)
+        except NotFound as e:
+            return _error([e.args[0]], 404)
+
+        db = resolved.db
+        database_name = db.name
+        table_name = resolved.table
+
+        if not await self.ds.allowed(
+            action="alter-table",
+            resource=TableResource(database=database_name, table=table_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need alter-table"], 403)
+
+        if not db.is_mutable:
+            return _error(["Database is immutable"], 403)
+
+        content_type = request.headers.get("content-type") or ""
+        if not content_type.startswith("application/json"):
+            return _error(["Invalid content-type, must be application/json"], 400)
+
+        try:
+            data = await request.json()
+        except json.JSONDecodeError as e:
+            return _error(["Invalid JSON: {}".format(e)], 400)
+
+        if not isinstance(data, dict):
+            return _error(["JSON must be a dictionary"], 400)
+
+        try:
+            alter_request = AlterTableRequest.model_validate(data)
+        except ValidationError as e:
+            return _error(_pydantic_errors(e), 400)
+
+        def alter_table(conn):
+            before_schema = _table_schema_from_conn(conn, table_name)
+
+            def apply_operations(operation_conn):
+                db_for_write = sqlite_utils.Database(operation_conn)
+                table = db_for_write[table_name]
+
+                add_columns = []
+                types = {}
+                rename = {}
+                drop = set()
+                not_null = {}
+                defaults = {}
+                column_order = None
+                pk = SQLITE_UTILS_DEFAULT
+
+                for operation in alter_request.operations:
+                    args = operation.args
+                    if operation.op == "add_column":
+                        if args.not_null and not (
+                            (
+                                "default" in args.model_fields_set
+                                and args.default is not None
+                            )
+                            or "default_expr" in args.model_fields_set
+                        ):
+                            raise ValueError(
+                                "add_column args.default or args.default_expr is required when not_null is true"
+                            )
+                        add_columns.append(args)
+                        if "default" in args.model_fields_set and not args.not_null:
+                            defaults[args.name] = _literal_default(
+                                db_for_write, args.default
+                            )
+                        if "default_expr" in args.model_fields_set and not args.not_null:
+                            defaults[args.name] = _default_expression_sql(
+                                args.default_expr
+                            )
+                    elif operation.op == "rename_column":
+                        rename[args.name] = args.to
+                    elif operation.op == "alter_column":
+                        if args.type is not None:
+                            types[args.name] = args.type
+                        if args.not_null is not None:
+                            not_null[args.name] = args.not_null
+                        if "default" in args.model_fields_set:
+                            defaults[args.name] = (
+                                None
+                                if args.default is None
+                                else _literal_default(db_for_write, args.default)
+                            )
+                        if "default_expr" in args.model_fields_set:
+                            defaults[args.name] = _default_expression_sql(
+                                args.default_expr
+                            )
+                    elif operation.op == "drop_column":
+                        drop.add(args.name)
+                    elif operation.op == "set_primary_key":
+                        pk = _primary_key_value(args.columns)
+                    elif operation.op == "reorder_columns":
+                        column_order = args.columns
+
+                with operation_conn:
+                    for column in add_columns:
+                        not_null_default = None
+                        if column.not_null:
+                            if "default_expr" in column.model_fields_set:
+                                not_null_default = _default_expression_sql(
+                                    column.default_expr
+                                )
+                            else:
+                                not_null_default = _literal_default(
+                                    db_for_write, column.default
+                                )
+                        table.add_column(
+                            column.name,
+                            column.type,
+                            not_null_default=not_null_default,
+                        )
+
+                    should_transform = any(
+                        (
+                            types,
+                            rename,
+                            drop,
+                            not_null,
+                            defaults,
+                            column_order is not None,
+                            pk is not SQLITE_UTILS_DEFAULT,
+                        )
+                    )
+                    if should_transform:
+                        table.transform(
+                            types=types or None,
+                            rename=rename or None,
+                            drop=drop or None,
+                            pk=pk,
+                            not_null=not_null or None,
+                            defaults=defaults or None,
+                            column_order=column_order,
+                        )
+
+                return _table_schema_from_conn(operation_conn, table_name)
+
+            if alter_request.dry_run:
+                memory_conn = sqlite3.connect(":memory:")
+                try:
+                    conn.backup(memory_conn)
+                    return before_schema, apply_operations(memory_conn)
+                finally:
+                    memory_conn.close()
+
+            after_schema = apply_operations(conn)
+            return before_schema, after_schema
+
+        try:
+            before_schema, after_schema = await db.execute_write_fn(
+                alter_table, request=request
+            )
+        except Exception as e:
+            return _error([str(e)], 400)
+
+        altered = before_schema != after_schema
+        if altered and not alter_request.dry_run:
+            await self.ds.track_event(
+                AlterTableEvent(
+                    request.actor,
+                    database=database_name,
+                    table=table_name,
+                    before_schema=before_schema,
+                    after_schema=after_schema,
+                )
+            )
+
+        table_url = self.ds.absolute_url(
+            request, self.ds.urls.table(database_name, table_name)
+        )
+        table_api_url = self.ds.absolute_url(
+            request, self.ds.urls.table(database_name, table_name, format="json")
+        )
+        return Response.json(
+            {
+                "ok": True,
+                "database": database_name,
+                "table": table_name,
+                "table_url": table_url,
+                "table_api_url": table_api_url,
+                "altered": altered,
+                "schema": after_schema,
+                "before_schema": before_schema,
+                "operations_applied": 0
+                if alter_request.dry_run
+                else len(alter_request.operations),
+                "dry_run": alter_request.dry_run,
+            },
+            status=200,
+        )
+
+
 class TableSetColumnTypeView(BaseView):
     name = "table-set-column-type"
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index f7a0caae..4074b479 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -2072,6 +2072,109 @@ To use the ``"replace": true`` option you will also need the :ref:`actions_updat
 
 Pass ``"alter": true`` to automatically add any missing columns to the existing table that are present in the rows you are submitting. This requires the :ref:`actions_alter_table` permission.
 
+.. _TableAlterView:
+
+Altering tables
+~~~~~~~~~~~~~~~
+
+To alter an existing table, make a ``POST`` to ``/<database>/<table>/-/alter``. This requires the :ref:`actions_alter_table` permission.
+
+::
+
+    POST /<database>/<table>/-/alter
+    Content-Type: application/json
+    Authorization: Bearer dstok_<rest-of-token>
+
+The request body should include an ``operations`` array. Each operation has the same top-level shape: an ``op`` string and an ``args`` object.
+
+.. code-block:: json
+
+    {
+        "operations": [
+            {
+                "op": "add_column",
+                "args": {
+                    "name": "slug",
+                    "type": "text",
+                    "not_null": true,
+                    "default": ""
+                }
+            },
+            {
+                "op": "add_column",
+                "args": {
+                    "name": "created",
+                    "type": "text",
+                    "default_expr": "current_timestamp"
+                }
+            },
+            {
+                "op": "rename_column",
+                "args": {
+                    "name": "title",
+                    "to": "headline"
+                }
+            },
+            {
+                "op": "alter_column",
+                "args": {
+                    "name": "score",
+                    "type": "float"
+                }
+            },
+            {
+                "op": "drop_column",
+                "args": {
+                    "name": "draft_notes"
+                }
+            },
+            {
+                "op": "set_primary_key",
+                "args": {
+                    "columns": ["id"]
+                }
+            },
+            {
+                "op": "reorder_columns",
+                "args": {
+                    "columns": ["id", "headline", "slug", "created", "score"]
+                }
+            }
+        ]
+    }
+
+Set ``"dry_run": true`` to validate the operations and return the schema that would be created without modifying the table.
+
+Supported operations:
+
+* ``add_column`` adds a new column. ``args`` accepts ``name``, optional ``type`` of ``text``, ``integer``, ``float`` or ``blob``, optional ``not_null``, optional literal ``default`` and optional ``default_expr``. If ``not_null`` is ``true`` either a non-null ``default`` or ``default_expr`` is required.
+* ``rename_column`` renames a column. ``args`` accepts ``name`` and ``to``.
+* ``alter_column`` changes column properties. ``args`` accepts ``name`` and at least one of ``type``, ``not_null``, literal ``default`` or ``default_expr``. Passing ``"default": null`` removes an existing default.
+* ``drop_column`` drops a column. ``args`` accepts ``name``.
+* ``set_primary_key`` changes the table primary key. ``args`` accepts ``columns``, a list of one or more column names.
+* ``reorder_columns`` reorders columns. ``args`` accepts ``columns``, a list of one or more column names. Columns omitted from this list will appear afterwards in their existing order.
+
+``default`` is always treated as a literal value. ``default_expr`` accepts one of ``current_timestamp``, ``current_date`` or ``current_time`` and is rendered as the corresponding SQLite default expression.
+
+A successful response returns the new schema and the previous schema:
+
+.. code-block:: json
+
+    {
+        "ok": true,
+        "database": "data",
+        "table": "posts",
+        "table_url": "http://127.0.0.1:8001/data/posts",
+        "table_api_url": "http://127.0.0.1:8001/data/posts.json",
+        "altered": true,
+        "schema": "CREATE TABLE ...",
+        "before_schema": "CREATE TABLE ...",
+        "operations_applied": 7,
+        "dry_run": false
+    }
+
+Any errors will return ``{"errors": ["... descriptive message ..."], "ok": false}``, and a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
+
 .. _TableSetColumnTypeView:
 
 Setting a column type
diff --git a/pyproject.toml b/pyproject.toml
index a19dc957..38776b2c 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -39,6 +39,7 @@ dependencies = [
     "asyncinject>=0.7",
     "setuptools",
     "pip",
+    "pydantic>=2",
 ]
 
 [project.urls]
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index b7ceb6b2..f117c06e 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -794,6 +794,211 @@ async def test_update_row_alter(ds_write):
     assert response.json() == {"ok": True}
 
 
+@pytest.mark.asyncio
+async def test_alter_table_operations(ds_write):
+    token = write_token(ds_write, permissions=["at"])
+    db = ds_write.get_database("data")
+    before_schema = await db.execute_fn(
+        lambda conn: conn.execute(
+            "select sql from sqlite_master where type = 'table' and name = 'docs'"
+        ).fetchone()[0]
+    )
+
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "operations": [
+                {
+                    "op": "add_column",
+                    "args": {
+                        "name": "slug",
+                        "type": "text",
+                        "not_null": True,
+                        "default": "",
+                    },
+                },
+                {
+                    "op": "add_column",
+                    "args": {
+                        "name": "created",
+                        "type": "text",
+                        "default_expr": "current_timestamp",
+                    },
+                },
+                {
+                    "op": "add_column",
+                    "args": {
+                        "name": "literal_default",
+                        "type": "text",
+                        "default": "hello)",
+                    },
+                },
+                {"op": "rename_column", "args": {"name": "title", "to": "headline"}},
+                {
+                    "op": "alter_column",
+                    "args": {"name": "age", "type": "text", "default": "0"},
+                },
+                {"op": "drop_column", "args": {"name": "score"}},
+                {
+                    "op": "reorder_columns",
+                    "args": {
+                        "columns": [
+                            "id",
+                            "headline",
+                            "slug",
+                            "created",
+                            "literal_default",
+                            "age",
+                        ]
+                    },
+                },
+                {"op": "set_primary_key", "args": {"columns": ["id"]}},
+            ]
+        },
+        headers=_headers(token),
+    )
+
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert data["ok"] is True
+    assert data["database"] == "data"
+    assert data["table"] == "docs"
+    assert data["altered"] is True
+    assert data["operations_applied"] == 8
+    assert data["before_schema"] == before_schema
+    assert "headline" in data["schema"]
+    assert "score" not in data["schema"]
+    assert "DEFAULT CURRENT_TIMESTAMP" in data["schema"]
+    assert "DEFAULT 'hello)'" in data["schema"]
+
+    columns = (
+        await db.execute("select * from pragma_table_info('docs') order by cid")
+    ).dicts()
+    assert [column["name"] for column in columns] == [
+        "id",
+        "headline",
+        "slug",
+        "created",
+        "literal_default",
+        "age",
+    ]
+    assert columns[0]["pk"] == 1
+    assert columns[2]["notnull"] == 1
+    assert columns[2]["dflt_value"] == "''"
+    assert columns[3]["dflt_value"] == "CURRENT_TIMESTAMP"
+    assert columns[4]["dflt_value"] == "'hello)'"
+    assert columns[5]["type"] == "TEXT"
+    assert columns[5]["dflt_value"] == "'0'"
+
+    event = last_event(ds_write)
+    assert event.name == "alter-table"
+    assert event.database == "data"
+    assert event.table == "docs"
+    assert event.before_schema == before_schema
+    assert event.after_schema == data["schema"]
+
+
+@pytest.mark.asyncio
+async def test_alter_table_dry_run(ds_write):
+    token = write_token(ds_write, permissions=["at"])
+    db = ds_write.get_database("data")
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "dry_run": True,
+            "operations": [
+                {"op": "add_column", "args": {"name": "slug", "type": "text"}}
+            ],
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert data["ok"] is True
+    assert data["dry_run"] is True
+    assert data["altered"] is True
+    assert data["operations_applied"] == 0
+    assert "slug" in data["schema"]
+    columns = (
+        await db.execute("select name from pragma_table_info('docs') order by cid")
+    ).dicts()
+    assert [column["name"] for column in columns] == ["id", "title", "score", "age"]
+    assert last_event(ds_write) is None
+
+
+@pytest.mark.asyncio
+async def test_alter_table_permission_denied(ds_write):
+    token = write_token(ds_write, permissions=["ir"])
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={"operations": [{"op": "add_column", "args": {"name": "slug"}}]},
+        headers=_headers(token),
+    )
+    assert response.status_code == 403
+    assert response.json() == {
+        "ok": False,
+        "errors": ["Permission denied: need alter-table"],
+    }
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "body,expected_error",
+    (
+        (
+            {"operations": [{"op": "add_column", "args": {"type": "text"}}]},
+            "operations.0.add_column.args.name: Field required",
+        ),
+        (
+            {
+                "operations": [
+                    {"op": "add_column", "args": {"name": "x", "type": "bad"}}
+                ]
+            },
+            "operations.0.add_column.args.type: Input should be 'text', 'integer', 'float' or 'blob'",
+        ),
+        (
+            {
+                "operations": [
+                    {
+                        "op": "add_column",
+                        "args": {
+                            "name": "x",
+                            "default_expr": "datetime('now')",
+                        },
+                    }
+                ]
+            },
+            "operations.0.add_column.args.default_expr: Input should be 'current_timestamp', 'current_date' or 'current_time'",
+        ),
+        (
+            {
+                "operations": [
+                    {
+                        "op": "add_column",
+                        "args": {
+                            "name": "x",
+                            "default": "x",
+                            "default_expr": "current_timestamp",
+                        },
+                    }
+                ]
+            },
+            "operations.0.add_column.args: Value error, default and default_expr cannot both be provided",
+        ),
+    ),
+)
+async def test_alter_table_validation_errors(ds_write, body, expected_error):
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json=body,
+        headers=_headers(write_token(ds_write, permissions=["at"])),
+    )
+    assert response.status_code == 400
+    assert response.json()["ok"] is False
+    assert response.json()["errors"] == [expected_error]
+
+
 @pytest.mark.asyncio
 async def test_execute_write_form_parameter_called_sql():
     ds = Datasette(memory=True, default_deny=True)

From fdd1b61a3e4bacba7e792554c5376856160f1dba Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 09:21:09 -0700
Subject: [PATCH 238/386] Add alter table modal

- Register a built-in table action and expose alter-table metadata to table pages.
- Build the client-side modal for editing columns, defaults, ordering, primary keys, and custom column types.
- Add a review/apply confirmation flow with HTML and Playwright coverage.

Refs #2788
---
 datasette/default_table_actions.py |   29 +
 datasette/plugins.py               |    1 +
 datasette/static/app.css           |  499 ++++++++++
 datasette/static/edit-tools.js     | 1478 +++++++++++++++++++++++++++-
 datasette/views/row.py             |    1 +
 datasette/views/table.py           |   82 +-
 tests/test_playwright.py           |  210 ++++
 tests/test_table_html.py           |  117 +++
 8 files changed, 2414 insertions(+), 3 deletions(-)
 create mode 100644 datasette/default_table_actions.py

diff --git a/datasette/default_table_actions.py b/datasette/default_table_actions.py
new file mode 100644
index 00000000..e41434ef
--- /dev/null
+++ b/datasette/default_table_actions.py
@@ -0,0 +1,29 @@
+from datasette import hookimpl
+from datasette.resources import TableResource
+
+
+@hookimpl
+def table_actions(datasette, actor, database, table, request):
+    async def inner():
+        db = datasette.get_database(database)
+        if not db.is_mutable:
+            return []
+        if not await datasette.allowed(
+            action="alter-table",
+            resource=TableResource(database=database, table=table),
+            actor=actor,
+        ):
+            return []
+        return [
+            {
+                "type": "button",
+                "label": "Alter table",
+                "description": "Change columns and primary key for this table.",
+                "attrs": {
+                    "aria-label": "Alter table {}".format(table),
+                    "data-table-action": "alter-table",
+                },
+            }
+        ]
+
+    return inner
diff --git a/datasette/plugins.py b/datasette/plugins.py
index f0fbc7f8..ae2cb17d 100644
--- a/datasette/plugins.py
+++ b/datasette/plugins.py
@@ -31,6 +31,7 @@ DEFAULT_PLUGINS = (
     "datasette.default_debug_menu",
     "datasette.default_jump_items",
     "datasette.default_database_actions",
+    "datasette.default_table_actions",
     "datasette.default_query_actions",
     "datasette.handle_exception",
     "datasette.forbidden",
diff --git a/datasette/static/app.css b/datasette/static/app.css
index ce0c46a8..f9ebe5ac 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -2032,6 +2032,505 @@ dialog.table-create-dialog::backdrop {
     cursor: not-allowed;
 }
 
+dialog.table-alter-dialog {
+    --ink: #0f0f0f;
+    --paper: #eef6ff;
+    --muted: #6b6b6b;
+    --rule: #d8e6f5;
+    --accent: #1a56db;
+    --card: #ffffff;
+    border: none;
+    border-radius: var(--modal-border-radius, 0.75rem);
+    padding: 0;
+    margin: auto;
+    width: min(980px, calc(100vw - 32px));
+    max-width: 95vw;
+    max-height: min(780px, calc(100vh - 32px));
+    box-shadow: var(--modal-shadow, 0 20px 25px -5px rgba(0, 0, 0, 0.1), 0 10px 10px -5px rgba(0, 0, 0, 0.04));
+    animation: datasette-modal-slide-in var(--modal-animation-duration, 0.2s) ease-out;
+    overflow: hidden;
+    font-family: system-ui, -apple-system, sans-serif;
+    background: var(--card);
+}
+
+dialog.table-alter-dialog[open] {
+    display: flex;
+    flex-direction: column;
+}
+
+dialog.table-alter-dialog::backdrop {
+    background: var(--modal-backdrop-bg, rgba(0, 0, 0, 0.5));
+    backdrop-filter: var(--modal-backdrop-blur, blur(4px));
+    -webkit-backdrop-filter: var(--modal-backdrop-blur, blur(4px));
+    animation: datasette-modal-fade-in var(--modal-animation-duration, 0.2s) ease-out;
+}
+
+.table-alter-dialog .modal-header {
+    padding: 20px 24px 12px;
+    border-bottom: 1px solid var(--rule);
+    display: flex;
+    align-items: center;
+    gap: 12px;
+    flex-shrink: 0;
+    min-width: 0;
+}
+
+.table-alter-dialog .modal-title {
+    display: flex;
+    align-items: center;
+    min-width: 0;
+    max-width: 100%;
+    font-size: 1rem;
+    font-weight: 600;
+    color: var(--ink);
+}
+
+.table-alter-form {
+    display: flex;
+    flex: 1 1 auto;
+    min-height: 0;
+    flex-direction: column;
+}
+
+.table-alter-error {
+    border-left: 4px solid #b91c1c;
+    border-radius: 4px;
+    background: #fff1f1;
+    color: #7f1d1d;
+    font-size: 0.9rem;
+    margin: 12px 24px 0;
+    padding: 10px 12px;
+}
+
+.table-alter-error:focus {
+    outline: 3px solid rgba(185, 28, 28, 0.18);
+    outline-offset: 2px;
+}
+
+.table-alter-fields {
+    display: grid;
+    gap: 18px;
+    padding: 16px 24px 24px;
+    overflow-y: auto;
+}
+
+.table-alter-fields[hidden],
+.table-alter-dialog .modal-footer [hidden] {
+    display: none;
+}
+
+.table-alter-review {
+    display: grid;
+    gap: 12px;
+    overflow-y: auto;
+    padding: 16px 24px 24px;
+}
+
+.table-alter-review[hidden] {
+    display: none;
+}
+
+.table-alter-review-title {
+    color: var(--ink);
+    font-size: 1rem;
+    line-height: 1.35;
+    margin: 0;
+}
+
+.table-alter-review-title:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 2px;
+}
+
+.table-alter-review-intro {
+    color: var(--muted);
+    font-size: 0.9rem;
+    margin: 0;
+}
+
+.table-alter-review-warning {
+    border-left: 4px solid #b91c1c;
+    border-radius: 4px;
+    background: #fff1f1;
+    color: #7f1d1d;
+    font-size: 0.9rem;
+    margin: 0;
+    padding: 10px 12px;
+}
+
+.table-alter-review-list {
+    display: grid;
+    gap: 8px;
+    margin: 0;
+    padding-left: 1.4rem;
+}
+
+.table-alter-review-list li {
+    color: var(--ink);
+    line-height: 1.4;
+}
+
+.table-alter-review-damaging {
+    font-weight: 600;
+}
+
+.table-alter-review-name {
+    background: #eef6ff;
+    border: 1px solid #c9ddf2;
+    border-radius: 4px;
+    color: var(--ink);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.85em;
+    padding: 1px 4px;
+    white-space: nowrap;
+}
+
+.table-alter-columns {
+    display: grid;
+    gap: 10px;
+}
+
+.table-alter-column-list {
+    display: grid;
+    gap: 8px;
+}
+
+.table-alter-column-headings,
+.table-alter-column-main {
+    display: grid;
+    grid-template-columns: minmax(140px, 1.2fr) minmax(7.5rem, 0.7fr) minmax(12rem, 1fr) max-content 32px;
+    align-items: center;
+    gap: 8px;
+    min-width: 0;
+}
+
+.table-alter-column-row {
+    display: grid;
+    gap: 8px;
+    min-width: 0;
+}
+
+.table-alter-column-headings {
+    color: var(--muted);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.72rem;
+    padding: 0 1px;
+}
+
+.table-alter-column-label {
+    border: 0;
+    clip: rect(0 0 0 0);
+    height: 1px;
+    margin: -1px;
+    overflow: hidden;
+    padding: 0;
+    position: absolute;
+    white-space: nowrap;
+    width: 1px;
+}
+
+.table-alter-input {
+    box-sizing: border-box;
+    min-width: 0;
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    padding: 8px 10px;
+    color: var(--ink);
+    background: #fff;
+    font: inherit;
+}
+
+.table-alter-input-placeholder {
+    color: var(--muted);
+}
+
+.table-alter-default-expr option,
+.table-alter-custom-column-type option {
+    color: var(--ink);
+}
+
+.table-alter-default-expr option[value=""],
+.table-alter-custom-column-type option[value=""] {
+    color: var(--muted);
+}
+
+.table-alter-input:focus {
+    border-color: var(--accent);
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+}
+
+.table-alter-column-details {
+    display: grid;
+    grid-template-columns: minmax(0, 1fr) minmax(0, 1fr);
+    align-items: start;
+    gap: 12px 16px;
+    padding: 12px;
+    border-left: 3px solid var(--rule);
+    background: #f8fafc;
+}
+
+.table-alter-column-details[hidden] {
+    display: none;
+}
+
+.table-alter-detail-field {
+    display: grid;
+    gap: 4px;
+    min-width: 0;
+}
+
+.table-alter-detail-label {
+    color: var(--muted);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.72rem;
+}
+
+.table-alter-detail-check {
+    display: inline-flex;
+    align-items: flex-start;
+    gap: 8px;
+    color: var(--ink);
+    font-size: 0.85rem;
+    line-height: 1.35;
+    min-width: 0;
+    white-space: normal;
+}
+
+.table-alter-not-null,
+.table-alter-primary-key {
+    grid-column: 1 / -1;
+}
+
+.table-alter-detail-check input {
+    flex: 0 0 auto;
+    margin: 0.15rem 0 0;
+}
+
+.table-alter-detail-check span {
+    min-width: 0;
+    overflow-wrap: break-word;
+}
+
+.table-alter-move-controls {
+    display: grid;
+    grid-template-columns: repeat(4, 32px);
+    gap: 4px;
+    justify-content: start;
+}
+
+.table-alter-more-options {
+    appearance: none;
+    border: 0;
+    background: transparent;
+    color: var(--accent);
+    cursor: pointer;
+    font: inherit;
+    font-size: 0.85rem;
+    justify-self: start;
+    padding: 0;
+    grid-column: 1 / -1;
+    text-align: left;
+}
+
+.table-alter-more-options:hover,
+.table-alter-more-options:focus {
+    text-decoration: underline;
+}
+
+.table-alter-more-options:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 2px;
+}
+
+.table-alter-more-options:disabled {
+    color: var(--muted);
+    cursor: default;
+    text-decoration: none;
+}
+
+.table-alter-icon-button {
+    appearance: none;
+    border: 1px solid rgba(74, 85, 104, 0.24);
+    background: transparent;
+    color: #4a5568;
+    border-radius: 4px;
+    cursor: pointer;
+    display: inline-grid;
+    place-items: center;
+    height: 32px;
+    width: 32px;
+    padding: 0;
+}
+
+.table-alter-icon-button:hover,
+.table-alter-icon-button:focus {
+    background: rgba(74, 85, 104, 0.07);
+}
+
+.table-alter-icon-button:focus {
+    outline: 3px solid #b3d4ff;
+    outline-offset: 1px;
+}
+
+.table-alter-icon-button svg {
+    display: block;
+}
+
+.table-alter-add-column {
+    appearance: none;
+    justify-self: start;
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    background: #fff;
+    color: var(--accent);
+    cursor: pointer;
+    font: inherit;
+    font-size: 0.85rem;
+    padding: 7px 10px;
+}
+
+.table-alter-add-column:hover,
+.table-alter-add-column:focus {
+    background: #f8fafc;
+}
+
+.table-alter-add-column:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 1px;
+}
+
+.table-alter-dialog .modal-footer {
+    padding: 14px 20px;
+    border-top: 1px solid var(--rule);
+    display: flex;
+    align-items: center;
+    justify-content: flex-end;
+    gap: 10px;
+    flex-shrink: 0;
+    background: var(--paper);
+}
+
+.table-alter-dialog .btn {
+    border: none;
+    border-radius: 5px;
+    padding: 9px 20px;
+    font-size: 0.85rem;
+    font-weight: 500;
+    cursor: pointer;
+    touch-action: manipulation;
+    font-family: inherit;
+    transition: background 0.12s;
+}
+
+.table-alter-dialog .btn-ghost {
+    background: transparent;
+    color: var(--muted);
+    border: 1px solid var(--rule);
+}
+
+.table-alter-dialog .btn-ghost:hover {
+    background: var(--rule);
+    color: var(--ink);
+}
+
+.table-alter-dialog .btn-primary {
+    background: var(--accent);
+    color: #fff;
+}
+
+.table-alter-dialog .btn-primary:hover {
+    background: #1949b8;
+}
+
+.table-alter-dialog .btn-primary:disabled,
+.table-alter-dialog .btn-primary:disabled:hover {
+    background: #a0aec0;
+    color: #fff;
+}
+
+.table-alter-dialog .btn:disabled,
+.table-alter-add-column:disabled,
+.table-alter-icon-button:disabled {
+    opacity: 0.55;
+    cursor: not-allowed;
+}
+
+@media (max-width: 900px) {
+    dialog.table-alter-dialog {
+        width: 95vw;
+        max-height: 85vh;
+        border-radius: 0.5rem;
+    }
+
+    .table-alter-dialog .modal-header,
+    .table-alter-fields,
+    .table-alter-review {
+        padding-left: 18px;
+        padding-right: 18px;
+    }
+
+    .table-alter-error {
+        margin-left: 18px;
+        margin-right: 18px;
+    }
+
+    .table-alter-column-headings {
+        display: none;
+    }
+
+    .table-alter-column-row {
+        padding-bottom: 8px;
+        border-bottom: 1px solid var(--rule);
+    }
+
+    .table-alter-column-main {
+        grid-template-columns: minmax(0, 1fr) minmax(7.5rem, 0.8fr) 32px;
+        align-items: end;
+    }
+
+    .table-alter-column-name {
+        grid-column: 1;
+        grid-row: 1;
+    }
+
+    .table-alter-column-type {
+        grid-column: 2;
+        grid-row: 1;
+    }
+
+    .table-alter-remove-column {
+        grid-column: 3;
+        grid-row: 1;
+        justify-self: end;
+    }
+
+    .table-alter-custom-column-type {
+        grid-column: 1 / 3;
+        grid-row: 2;
+    }
+
+    .table-alter-move-controls {
+        grid-column: 1;
+        grid-row: 3;
+        justify-self: start;
+    }
+
+    .table-alter-more-options {
+        align-self: center;
+        grid-column: 2 / 4;
+        grid-row: 3;
+    }
+
+    .table-alter-column-details {
+        grid-template-columns: 1fr;
+    }
+
+    .table-alter-dialog .modal-footer {
+        padding-left: 18px;
+        padding-right: 18px;
+    }
+}
+
 .row-link-with-actions {
     display: inline-flex;
     align-items: center;
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 4b93c4fd..284d6bde 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -4,6 +4,8 @@ var ROW_EDIT_DIALOG_ID = "row-edit-dialog";
 var rowEditDialogState = null;
 var TABLE_CREATE_DIALOG_ID = "table-create-dialog";
 var tableCreateDialogState = null;
+var TABLE_ALTER_DIALOG_ID = "table-alter-dialog";
+var tableAlterDialogState = null;
 
 function ensureRowMutationStatus(manager) {
   var status = document.querySelector(".row-mutation-status");
@@ -59,6 +61,16 @@ function tableCreateColumnTypes() {
     : ["text", "integer", "float", "blob"];
 }
 
+function sqliteColumnTypeLabel(type) {
+  if (type === "float") {
+    return "floating point number";
+  }
+  if (type === "blob") {
+    return "blob - binary data";
+  }
+  return type;
+}
+
 function tableCreateCustomColumnTypes() {
   var data = databaseCreateTableData() || {};
   return data.customColumnTypes || [];
@@ -147,7 +159,7 @@ function tableCreateSelectTypeValue(select, type) {
   options.forEach(function (option) {
     var optionElement = document.createElement("option");
     optionElement.value = option;
-    optionElement.textContent = option;
+    optionElement.textContent = sqliteColumnTypeLabel(option);
     select.appendChild(optionElement);
   });
   select.value = options.indexOf(type) === -1 ? options[0] : type;
@@ -819,6 +831,1469 @@ function tableInsertData() {
   return tablePageData().insertRow;
 }
 
+function tableAlterData() {
+  return tablePageData().alterTable;
+}
+
+function tableAlterColumnTypes() {
+  var data = tableAlterData() || {};
+  return data.columnTypes && data.columnTypes.length
+    ? data.columnTypes
+    : ["text", "integer", "float", "blob"];
+}
+
+function tableAlterDefaultExpressions() {
+  var data = tableAlterData() || {};
+  return data.defaultExpressions || [];
+}
+
+function tableAlterCustomColumnTypes() {
+  var data = tableAlterData() || {};
+  return data.customColumnTypes || [];
+}
+
+function tableAlterCustomColumnType(name) {
+  var options = tableAlterCustomColumnTypes();
+  for (var i = 0; i < options.length; i += 1) {
+    if (options[i].name === name) {
+      return options[i];
+    }
+  }
+  return null;
+}
+
+function tableAlterCustomTypeAppliesToSqliteType(option, sqliteType) {
+  return (
+    option &&
+    option.sqliteTypes &&
+    option.sqliteTypes.indexOf(sqliteType) !== -1
+  );
+}
+
+function tableAlterDialogRows(state) {
+  return Array.prototype.slice.call(
+    state.columnList.querySelectorAll(".table-alter-column-row"),
+  );
+}
+
+function tableAlterRowSignature(row) {
+  return {
+    existing: row.dataset.existing === "1",
+    originalName: row.dataset.originalName || "",
+    name: row.querySelector(".table-alter-column-name").value,
+    type: row.querySelector(".table-alter-column-type").value,
+    customType:
+      (
+        row.querySelector(".table-alter-custom-column-type") || {
+          value: "",
+        }
+      ).value || "",
+    notNull: row.querySelector(".table-alter-not-null-input").checked,
+    defaultValue: row.querySelector(".table-alter-default").value,
+    defaultExpr: row.querySelector(".table-alter-default-expr").value,
+    pk: row.querySelector(".table-alter-primary-key-input").checked,
+  };
+}
+
+function tableAlterDialogSignature(state) {
+  if (!state || !state.form) {
+    return "";
+  }
+  return JSON.stringify({
+    columns: tableAlterDialogRows(state).map(tableAlterRowSignature),
+    deletedColumns: state.deletedColumns.slice(),
+  });
+}
+
+function tableAlterDialogHasChanges(state) {
+  return (
+    !!state &&
+    !state.isSaving &&
+    tableAlterDialogSignature(state) !== state.initialSignature
+  );
+}
+
+function updateTableAlterSaveButtonState(state) {
+  if (!state || !state.saveButton) {
+    return;
+  }
+  state.saveButton.disabled =
+    state.isSaving ||
+    (state.mode !== "review" &&
+      tableAlterDialogSignature(state) === state.initialSignature);
+}
+
+function tableAlterRowIsPrimaryKey(row) {
+  var input = row && row.querySelector(".table-alter-primary-key-input");
+  return !!(input && input.checked);
+}
+
+function tableAlterFirstNonPrimaryRow(state) {
+  var rows = tableAlterDialogRows(state);
+  for (var i = 0; i < rows.length; i += 1) {
+    if (!tableAlterRowIsPrimaryKey(rows[i])) {
+      return rows[i];
+    }
+  }
+  return null;
+}
+
+function updateTableAlterMoveButtons(state) {
+  if (!state || !state.columnList) {
+    return;
+  }
+  var firstNonPrimary = tableAlterFirstNonPrimaryRow(state);
+  var rows = tableAlterDialogRows(state);
+  var hasPrimaryKeys = rows.some(function (row) {
+    return tableAlterRowIsPrimaryKey(row);
+  });
+  var primaryKeyMoveTitle = "Primary key columns are always listed first";
+  rows.forEach(function (row) {
+    var isPrimaryKey = tableAlterRowIsPrimaryKey(row);
+    var previous = row.previousElementSibling;
+    var next = row.nextElementSibling;
+    row.querySelectorAll(".table-alter-move-controls button").forEach(
+      function (button) {
+        button.title = button.dataset.defaultTitle || button.title;
+        button.disabled = state.isSaving || isPrimaryKey;
+        if (isPrimaryKey) {
+          button.title = primaryKeyMoveTitle;
+        }
+      },
+    );
+    if (!isPrimaryKey) {
+      var topButton = row.querySelector(".table-alter-move-top");
+      var upButton = row.querySelector(".table-alter-move-up");
+      var downButton = row.querySelector(".table-alter-move-down");
+      var bottomButton = row.querySelector(".table-alter-move-bottom");
+      topButton.disabled =
+        state.isSaving || !firstNonPrimary || row === firstNonPrimary;
+      upButton.disabled =
+        state.isSaving || !previous || tableAlterRowIsPrimaryKey(previous);
+      downButton.disabled = state.isSaving || !next;
+      bottomButton.disabled = state.isSaving || !next;
+      if (hasPrimaryKeys && row === firstNonPrimary) {
+        topButton.title = primaryKeyMoveTitle;
+        upButton.title = primaryKeyMoveTitle;
+      }
+    }
+  });
+}
+
+function normalizeTableAlterPrimaryKeyRows(state) {
+  var rows = tableAlterDialogRows(state);
+  rows
+    .filter(function (row) {
+      return tableAlterRowIsPrimaryKey(row);
+    })
+    .concat(
+      rows.filter(function (row) {
+        return !tableAlterRowIsPrimaryKey(row);
+      }),
+    )
+    .forEach(function (row) {
+      state.columnList.appendChild(row);
+    });
+}
+
+function clearTableAlterDialogError(state) {
+  state.error.hidden = true;
+  state.error.textContent = "";
+  state.dialog.removeAttribute("aria-describedby");
+}
+
+function showTableAlterDialogError(state, message) {
+  state.error.hidden = false;
+  state.error.textContent = message;
+  state.dialog.setAttribute("aria-describedby", "table-alter-error");
+  state.error.focus();
+}
+
+function setTableAlterDialogSaving(state, isSaving) {
+  state.isSaving = isSaving;
+  state.cancelButton.disabled = isSaving;
+  state.addColumnButton.disabled = isSaving;
+  state.backButton.disabled = isSaving;
+  state.saveButton.textContent = isSaving
+    ? state.mode === "review"
+      ? "Applying..."
+      : "Preparing..."
+    : tableAlterSaveButtonText(state);
+  state.columnList
+    .querySelectorAll("input, select, button")
+    .forEach(function (control) {
+      control.disabled = isSaving;
+    });
+  if (!isSaving) {
+    state.columnList
+      .querySelectorAll(".table-alter-default-expr")
+      .forEach(function (select) {
+        syncTableAlterDefaultControls(select.closest(".table-alter-column-row"));
+      });
+  }
+  updateTableAlterMoveButtons(state);
+  updateTableAlterSaveButtonState(state);
+}
+
+function tableAlterSaveButtonText(state) {
+  return state && state.mode === "review" ? "Apply changes" : "Review changes";
+}
+
+function tableAlterSelectTypeValue(select, type) {
+  var options = tableAlterColumnTypes();
+  options.forEach(function (option) {
+    var optionElement = document.createElement("option");
+    optionElement.value = option;
+    optionElement.textContent = sqliteColumnTypeLabel(option);
+    select.appendChild(optionElement);
+  });
+  select.value = options.indexOf(type) === -1 ? options[0] : type;
+}
+
+function updateTableAlterCustomColumnTypePlaceholder(select) {
+  select.classList.toggle(
+    "table-alter-input-placeholder",
+    !select.value,
+  );
+}
+
+function createTableAlterCustomColumnTypeSelect() {
+  var options = tableAlterCustomColumnTypes();
+  var select = document.createElement("select");
+  select.className = "table-alter-input table-alter-custom-column-type";
+  select.setAttribute("aria-label", "Custom column type");
+  var blankOption = document.createElement("option");
+  blankOption.value = "";
+  blankOption.textContent = "- custom type -";
+  select.appendChild(blankOption);
+  options.forEach(function (option) {
+    var optionElement = document.createElement("option");
+    optionElement.value = option.name;
+    optionElement.textContent = option.description
+      ? option.description + " (" + option.name + ")"
+      : option.name;
+    select.appendChild(optionElement);
+  });
+  updateTableAlterCustomColumnTypePlaceholder(select);
+  return select;
+}
+
+function syncTableAlterCustomTypeForSqliteType(row) {
+  var typeSelect = row.querySelector(".table-alter-column-type");
+  var customTypeSelect = row.querySelector(".table-alter-custom-column-type");
+  if (!typeSelect || !customTypeSelect || !customTypeSelect.value) {
+    return;
+  }
+  var option = tableAlterCustomColumnType(customTypeSelect.value);
+  if (!tableAlterCustomTypeAppliesToSqliteType(option, typeSelect.value)) {
+    customTypeSelect.value = "";
+    updateTableAlterCustomColumnTypePlaceholder(customTypeSelect);
+  }
+}
+
+function tableAlterSelectDefaultExprValue(select, value) {
+  var blankOption = document.createElement("option");
+  blankOption.value = "";
+  blankOption.textContent = "- default expr -";
+  select.appendChild(blankOption);
+  tableAlterDefaultExpressions().forEach(function (option) {
+    var optionElement = document.createElement("option");
+    optionElement.value = option;
+    optionElement.textContent = option.replace(/_/g, " ");
+    select.appendChild(optionElement);
+  });
+  select.value = value || "";
+  updateTableAlterDefaultExprPlaceholder(select);
+}
+
+function updateTableAlterDefaultExprPlaceholder(select) {
+  select.classList.toggle("table-alter-input-placeholder", !select.value);
+}
+
+function syncTableAlterDefaultControls(row) {
+  if (!row) {
+    return;
+  }
+  var defaultInput = row.querySelector(".table-alter-default");
+  var defaultExprSelect = row.querySelector(".table-alter-default-expr");
+  if (!defaultInput || !defaultExprSelect) {
+    return;
+  }
+  defaultInput.disabled = !!defaultExprSelect.value;
+  updateTableAlterDefaultExprPlaceholder(defaultExprSelect);
+}
+
+function createTableAlterColumnRow(state, column) {
+  var index = state.nextColumnIndex;
+  state.nextColumnIndex += 1;
+  var existing = !!(column && column.existing);
+  var originalName = existing ? column.name || "" : "";
+  var originalCustomType =
+    existing && column.column_type ? column.column_type.type || "" : "";
+  var originalDefault =
+    existing && column.has_default && column.default !== null
+      ? String(column.default)
+      : "";
+
+  var row = document.createElement("div");
+  row.className = "table-alter-column-row";
+  row.dataset.existing = existing ? "1" : "0";
+  row.dataset.originalName = originalName;
+  row.dataset.originalType = existing ? column.type || "text" : "";
+  row.dataset.originalNotNull = existing && column.notnull ? "1" : "0";
+  row.dataset.originalHasDefault = existing && column.has_default ? "1" : "0";
+  row.dataset.originalDefault = originalDefault;
+  row.dataset.originalPk = existing && column.is_pk ? "1" : "0";
+  row.dataset.originalCustomType = originalCustomType;
+
+  var main = document.createElement("div");
+  main.className = "table-alter-column-main";
+
+  var details = document.createElement("div");
+  details.className = "table-alter-column-details";
+  details.id = "table-alter-column-details-" + index;
+  details.hidden = !(column && column.expanded);
+
+  var expandButton = document.createElement("button");
+  expandButton.type = "button";
+  expandButton.className = "table-alter-more-options";
+  expandButton.setAttribute("aria-label", "Toggle column settings");
+  expandButton.setAttribute("aria-controls", details.id);
+  expandButton.setAttribute(
+    "aria-expanded",
+    details.hidden ? "false" : "true",
+  );
+  function updateExpandButton() {
+    var isExpanded = expandButton.getAttribute("aria-expanded") === "true";
+    expandButton.textContent = isExpanded
+      ? "v Hide options"
+      : "> Advanced options";
+    expandButton.title = isExpanded
+      ? "Hide column settings"
+      : "Show column settings";
+  }
+  updateExpandButton();
+
+  var nameId = "table-alter-column-name-" + index;
+  var nameLabel = document.createElement("label");
+  nameLabel.className = "table-alter-column-label";
+  nameLabel.setAttribute("for", nameId);
+  nameLabel.textContent = "Column";
+
+  var nameInput = document.createElement("input");
+  nameInput.id = nameId;
+  nameInput.className = "table-alter-input table-alter-column-name";
+  nameInput.type = "text";
+  nameInput.required = true;
+  nameInput.autocomplete = "off";
+  nameInput.value = column && column.name ? column.name : "";
+
+  var typeSelect = document.createElement("select");
+  typeSelect.className = "table-alter-input table-alter-column-type";
+  typeSelect.setAttribute("aria-label", "Column type");
+  tableAlterSelectTypeValue(typeSelect, column && column.type);
+
+  var customTypeSelect = null;
+  if (tableAlterCustomColumnTypes().length) {
+    customTypeSelect = createTableAlterCustomColumnTypeSelect();
+    customTypeSelect.value = originalCustomType;
+    updateTableAlterCustomColumnTypePlaceholder(customTypeSelect);
+  }
+
+  var notNullLabel = document.createElement("label");
+  notNullLabel.className = "table-alter-detail-check table-alter-not-null";
+  var notNullInput = document.createElement("input");
+  notNullInput.type = "checkbox";
+  notNullInput.className = "table-alter-not-null-input";
+  notNullInput.checked = !!(column && column.notnull);
+  var notNullText = document.createElement("span");
+  var notNullStrong = document.createElement("strong");
+  notNullStrong.textContent = "Not null";
+  notNullText.appendChild(notNullStrong);
+  notNullText.appendChild(
+    document.createTextNode(" This value cannot be left unset"),
+  );
+  notNullLabel.appendChild(notNullInput);
+  notNullLabel.appendChild(notNullText);
+
+  var defaultId = "table-alter-column-default-" + index;
+  var defaultField = document.createElement("div");
+  defaultField.className = "table-alter-detail-field";
+  var defaultLabel = document.createElement("label");
+  defaultLabel.className = "table-alter-detail-label";
+  defaultLabel.setAttribute("for", defaultId);
+  defaultLabel.textContent = "Default value";
+  var defaultInput = document.createElement("input");
+  defaultInput.id = defaultId;
+  defaultInput.className = "table-alter-input table-alter-default";
+  defaultInput.type = "text";
+  defaultInput.autocomplete = "off";
+  defaultInput.placeholder = "default";
+  defaultInput.setAttribute("aria-label", "Default value");
+  defaultInput.value = originalDefault;
+  defaultField.appendChild(defaultLabel);
+  defaultField.appendChild(defaultInput);
+
+  var defaultExprId = "table-alter-column-default-expr-" + index;
+  var defaultExprField = document.createElement("div");
+  defaultExprField.className = "table-alter-detail-field";
+  var defaultExprLabel = document.createElement("label");
+  defaultExprLabel.className = "table-alter-detail-label";
+  defaultExprLabel.setAttribute("for", defaultExprId);
+  defaultExprLabel.textContent = "or default to a specific time";
+  var defaultExprSelect = document.createElement("select");
+  defaultExprSelect.id = defaultExprId;
+  defaultExprSelect.className =
+    "table-alter-input table-alter-default-expr";
+  defaultExprSelect.setAttribute("aria-label", "or default to a specific time");
+  tableAlterSelectDefaultExprValue(defaultExprSelect, "");
+  defaultExprField.appendChild(defaultExprLabel);
+  defaultExprField.appendChild(defaultExprSelect);
+
+  var pkLabel = document.createElement("label");
+  pkLabel.className = "table-alter-detail-check table-alter-primary-key";
+  var pkInput = document.createElement("input");
+  pkInput.type = "checkbox";
+  pkInput.className = "table-alter-primary-key-input";
+  pkInput.checked = !!(column && column.is_pk);
+  var pkText = document.createElement("span");
+  var pkStrong = document.createElement("strong");
+  pkStrong.textContent = "Primary key";
+  pkText.appendChild(pkStrong);
+  pkText.appendChild(
+    document.createTextNode(" An ID that uniquely identifies this record"),
+  );
+  pkLabel.appendChild(pkInput);
+  pkLabel.appendChild(pkText);
+
+  var moveControls = document.createElement("div");
+  moveControls.className = "table-alter-move-controls";
+
+  var moveTopButton = document.createElement("button");
+  moveTopButton.type = "button";
+  moveTopButton.className = "table-alter-icon-button table-alter-move-top";
+  moveTopButton.setAttribute("aria-label", "Move column to top");
+  moveTopButton.title = "Move column to top";
+  moveTopButton.dataset.defaultTitle = moveTopButton.title;
+  moveTopButton.innerHTML =
+    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m18 17-6-6-6 6"></path><path d="m18 11-6-6-6 6"></path></svg>';
+
+  var moveUpButton = document.createElement("button");
+  moveUpButton.type = "button";
+  moveUpButton.className = "table-alter-icon-button table-alter-move-up";
+  moveUpButton.setAttribute("aria-label", "Move column up");
+  moveUpButton.title = "Move column up";
+  moveUpButton.dataset.defaultTitle = moveUpButton.title;
+  moveUpButton.innerHTML =
+    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m18 15-6-6-6 6"></path></svg>';
+
+  var moveDownButton = document.createElement("button");
+  moveDownButton.type = "button";
+  moveDownButton.className = "table-alter-icon-button table-alter-move-down";
+  moveDownButton.setAttribute("aria-label", "Move column down");
+  moveDownButton.title = "Move column down";
+  moveDownButton.dataset.defaultTitle = moveDownButton.title;
+  moveDownButton.innerHTML =
+    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m6 9 6 6 6-6"></path></svg>';
+
+  var moveBottomButton = document.createElement("button");
+  moveBottomButton.type = "button";
+  moveBottomButton.className = "table-alter-icon-button table-alter-move-bottom";
+  moveBottomButton.setAttribute("aria-label", "Move column to bottom");
+  moveBottomButton.title = "Move column to bottom";
+  moveBottomButton.dataset.defaultTitle = moveBottomButton.title;
+  moveBottomButton.innerHTML =
+    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m6 7 6 6 6-6"></path><path d="m6 13 6 6 6-6"></path></svg>';
+
+  var removeButton = document.createElement("button");
+  removeButton.type = "button";
+  removeButton.className = "table-alter-icon-button table-alter-remove-column";
+  removeButton.setAttribute(
+    "aria-label",
+    existing ? "Drop column" : "Remove column",
+  );
+  removeButton.title = existing ? "Drop column" : "Remove column";
+  removeButton.innerHTML =
+    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M3 6h18"></path><path d="M8 6V4a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v2"></path><path d="M19 6l-1 14a2 2 0 0 1-2 2H8a2 2 0 0 1-2-2L5 6"></path></svg>';
+
+  moveControls.appendChild(moveTopButton);
+  moveControls.appendChild(moveUpButton);
+  moveControls.appendChild(moveDownButton);
+  moveControls.appendChild(moveBottomButton);
+  main.appendChild(nameLabel);
+  main.appendChild(nameInput);
+  main.appendChild(typeSelect);
+  if (customTypeSelect) {
+    main.appendChild(customTypeSelect);
+  }
+  main.appendChild(moveControls);
+  main.appendChild(removeButton);
+  main.appendChild(expandButton);
+
+  details.appendChild(notNullLabel);
+  details.appendChild(defaultField);
+  details.appendChild(defaultExprField);
+  details.appendChild(pkLabel);
+  row.appendChild(main);
+  row.appendChild(details);
+
+  var controls = [
+    nameInput,
+    typeSelect,
+    notNullInput,
+    defaultInput,
+    defaultExprSelect,
+    pkInput,
+  ];
+  if (customTypeSelect) {
+    controls.push(customTypeSelect);
+  }
+  controls.forEach(function (control) {
+      control.addEventListener("input", function () {
+        clearTableAlterDialogError(state);
+        updateTableAlterSaveButtonState(state);
+      });
+      control.addEventListener("change", function () {
+        clearTableAlterDialogError(state);
+        updateTableAlterSaveButtonState(state);
+      });
+    });
+
+  defaultInput.addEventListener("input", function () {
+    if (defaultInput.value) {
+      defaultExprSelect.value = "";
+      syncTableAlterDefaultControls(row);
+    }
+    updateTableAlterSaveButtonState(state);
+  });
+  defaultExprSelect.addEventListener("change", function () {
+    if (defaultExprSelect.value) {
+      defaultInput.value = "";
+    }
+    syncTableAlterDefaultControls(row);
+    updateTableAlterSaveButtonState(state);
+  });
+  pkInput.addEventListener("change", function () {
+    normalizeTableAlterPrimaryKeyRows(state);
+    updateTableAlterMoveButtons(state);
+    updateTableAlterSaveButtonState(state);
+  });
+
+  expandButton.addEventListener("click", function () {
+    var isExpanded = expandButton.getAttribute("aria-expanded") === "true";
+    details.hidden = isExpanded;
+    expandButton.setAttribute("aria-expanded", isExpanded ? "false" : "true");
+    updateExpandButton();
+  });
+
+  typeSelect.addEventListener("change", function () {
+    syncTableAlterCustomTypeForSqliteType(row);
+    updateTableAlterSaveButtonState(state);
+  });
+  if (customTypeSelect) {
+    customTypeSelect.addEventListener("change", function () {
+      updateTableAlterCustomColumnTypePlaceholder(customTypeSelect);
+      var option = tableAlterCustomColumnType(customTypeSelect.value);
+      if (
+        option &&
+        option.fixedSqliteType &&
+        tableAlterColumnTypes().indexOf(option.fixedSqliteType) !== -1
+      ) {
+        typeSelect.value = option.fixedSqliteType;
+      }
+      updateTableAlterSaveButtonState(state);
+    });
+  }
+
+  moveTopButton.addEventListener("click", function () {
+    var first = tableAlterFirstNonPrimaryRow(state);
+    if (state.isSaving || tableAlterRowIsPrimaryKey(row) || !first || first === row) {
+      return;
+    }
+    state.columnList.insertBefore(row, first);
+    clearTableAlterDialogError(state);
+    updateTableAlterMoveButtons(state);
+    updateTableAlterSaveButtonState(state);
+    row.querySelector(".table-alter-column-name").focus();
+  });
+
+  moveUpButton.addEventListener("click", function () {
+    var previous = row.previousElementSibling;
+    if (
+      state.isSaving ||
+      tableAlterRowIsPrimaryKey(row) ||
+      !previous ||
+      tableAlterRowIsPrimaryKey(previous)
+    ) {
+      return;
+    }
+    state.columnList.insertBefore(row, previous);
+    clearTableAlterDialogError(state);
+    updateTableAlterMoveButtons(state);
+    updateTableAlterSaveButtonState(state);
+    row.querySelector(".table-alter-column-name").focus();
+  });
+
+  moveDownButton.addEventListener("click", function () {
+    var next = row.nextElementSibling;
+    if (state.isSaving || tableAlterRowIsPrimaryKey(row) || !next) {
+      return;
+    }
+    state.columnList.insertBefore(next, row);
+    clearTableAlterDialogError(state);
+    updateTableAlterMoveButtons(state);
+    updateTableAlterSaveButtonState(state);
+    row.querySelector(".table-alter-column-name").focus();
+  });
+
+  moveBottomButton.addEventListener("click", function () {
+    var last = state.columnList.lastElementChild;
+    if (state.isSaving || tableAlterRowIsPrimaryKey(row) || !last || last === row) {
+      return;
+    }
+    state.columnList.appendChild(row);
+    clearTableAlterDialogError(state);
+    updateTableAlterMoveButtons(state);
+    updateTableAlterSaveButtonState(state);
+    row.querySelector(".table-alter-column-name").focus();
+  });
+
+  removeButton.addEventListener("click", function () {
+    if (state.isSaving) {
+      return;
+    }
+    if (row.dataset.existing === "1") {
+      state.deletedColumns.push(row.dataset.originalName);
+    }
+    row.remove();
+    clearTableAlterDialogError(state);
+    updateTableAlterMoveButtons(state);
+    updateTableAlterSaveButtonState(state);
+    var nextInput = state.columnList.querySelector(".table-alter-column-name");
+    if (nextInput) {
+      nextInput.focus();
+    } else {
+      state.addColumnButton.focus();
+    }
+  });
+
+  syncTableAlterDefaultControls(row);
+  return row;
+}
+
+function addTableAlterColumn(state, column) {
+  var row = createTableAlterColumnRow(state, column || { type: "text" });
+  state.columnList.appendChild(row);
+  return row;
+}
+
+function resetTableAlterDialog(state, data) {
+  state.nextColumnIndex = 0;
+  state.deletedColumns = [];
+  state.originalPrimaryKeys = (data.primaryKeys || []).slice();
+  state.originalColumnNames = (data.columns || []).map(function (column) {
+    return column.name;
+  });
+  state.columnList.textContent = "";
+  (data.columns || []).forEach(function (column) {
+    addTableAlterColumn(
+      state,
+      Object.assign({}, column, {
+        existing: true,
+      }),
+    );
+  });
+  normalizeTableAlterPrimaryKeyRows(state);
+  state.initialSignature = tableAlterDialogSignature(state);
+  showTableAlterEditor(state);
+}
+
+function collectTableAlterRows(state) {
+  return tableAlterDialogRows(state).map(function (row) {
+    var signature = tableAlterRowSignature(row);
+    signature.originalType = row.dataset.originalType || "";
+    signature.originalNotNull = row.dataset.originalNotNull === "1";
+    signature.originalHasDefault = row.dataset.originalHasDefault === "1";
+    signature.originalDefault = row.dataset.originalDefault || "";
+    signature.originalPk = row.dataset.originalPk === "1";
+    signature.originalCustomType = row.dataset.originalCustomType || "";
+    return signature;
+  });
+}
+
+function validateTableAlterRows(state, rows) {
+  if (!rows.length) {
+    return "At least one column is required.";
+  }
+  var seen = {};
+  var supportedTypes = tableAlterColumnTypes();
+  for (var i = 0; i < rows.length; i += 1) {
+    var row = rows[i];
+    var name = row.name.trim();
+    if (!name) {
+      return "Column name is required.";
+    }
+    if (name.indexOf("\n") !== -1) {
+      return "Column names cannot contain newlines.";
+    }
+    var columnKey = name.toLowerCase();
+    if (seen[columnKey]) {
+      return "Duplicate column name: " + name;
+    }
+    seen[columnKey] = true;
+    if (supportedTypes.indexOf(row.type) === -1) {
+      return "Unsupported column type: " + row.type;
+    }
+    if (row.customType) {
+      var option = tableAlterCustomColumnType(row.customType);
+      if (!option) {
+        return "Unknown custom column type: " + row.customType;
+      }
+      if (!tableAlterCustomTypeAppliesToSqliteType(option, row.type)) {
+        return (
+          "Custom type " +
+          row.customType +
+          " cannot be used with SQLite type " +
+          row.type +
+          "."
+        );
+      }
+    }
+    if (row.defaultValue && row.defaultExpr) {
+      return "Use either a default value or a default expression.";
+    }
+    if (!row.existing && row.notNull && !row.defaultValue && !row.defaultExpr) {
+      return "New NOT NULL columns need a default or default expression.";
+    }
+  }
+  var pkColumns = rows.filter(function (row) {
+    return row.pk;
+  });
+  if (state.originalPrimaryKeys.length && !pkColumns.length) {
+    return "At least one primary key column is required.";
+  }
+  return null;
+}
+
+function collectTableAlterColumnTypeAssignments(rows) {
+  var assignments = [];
+  if (!tableAlterCustomColumnTypes().length) {
+    return assignments;
+  }
+  rows.forEach(function (row) {
+    var renamed = row.existing && row.name.trim() !== row.originalName;
+    if (row.customType === row.originalCustomType && !renamed) {
+      return;
+    }
+    if (!row.customType && !row.originalCustomType) {
+      return;
+    }
+    assignments.push({
+      column: row.name.trim(),
+      columnType: row.customType || null,
+      sqliteType: row.type,
+    });
+  });
+  return assignments;
+}
+
+function tableAlterPkIdentityColumns(rows) {
+  return rows
+    .filter(function (row) {
+      return row.pk;
+    })
+    .map(function (row) {
+      return row.existing ? row.originalName : row.name.trim();
+    });
+}
+
+function tableAlterPkChanged(state, rows) {
+  return (
+    JSON.stringify(tableAlterPkIdentityColumns(rows)) !==
+    JSON.stringify(state.originalPrimaryKeys)
+  );
+}
+
+function tableAlterNaturalColumnOrder(state, rows) {
+  var existingRowsByOriginalName = {};
+  var newRows = [];
+  rows.forEach(function (row) {
+    if (row.existing) {
+      existingRowsByOriginalName[row.originalName] = row;
+    } else {
+      newRows.push(row);
+    }
+  });
+  var naturalOrder = [];
+  state.originalColumnNames.forEach(function (originalName) {
+    var row = existingRowsByOriginalName[originalName];
+    if (row) {
+      naturalOrder.push(row.name.trim());
+    }
+  });
+  newRows.forEach(function (row) {
+    naturalOrder.push(row.name.trim());
+  });
+  return naturalOrder;
+}
+
+function tableAlterColumnsReordered(state, rows) {
+  var finalOrder = rows.map(function (row) {
+    return row.name.trim();
+  });
+  return (
+    JSON.stringify(finalOrder) !==
+    JSON.stringify(tableAlterNaturalColumnOrder(state, rows))
+  );
+}
+
+function collectTableAlterPayload(state) {
+  var rows = collectTableAlterRows(state);
+  var validationError = validateTableAlterRows(state, rows);
+  if (validationError) {
+    return { error: validationError };
+  }
+
+  var operations = [];
+  var columnTypeAssignments = collectTableAlterColumnTypeAssignments(rows);
+  rows.forEach(function (row) {
+    var name = row.name.trim();
+    if (!row.existing) {
+      var addArgs = {
+        name: name,
+        type: row.type,
+        not_null: row.notNull,
+      };
+      if (row.defaultExpr) {
+        addArgs.default_expr = row.defaultExpr;
+      } else if (row.defaultValue || row.notNull) {
+        addArgs.default = row.defaultValue;
+      }
+      operations.push({ op: "add_column", args: addArgs });
+      return;
+    }
+
+    var originalName = row.originalName;
+    if (name !== originalName) {
+      operations.push({
+        op: "rename_column",
+        args: { name: originalName, to: name },
+      });
+    }
+
+    var alterArgs = { name: originalName };
+    if (row.type !== row.originalType) {
+      alterArgs.type = row.type;
+    }
+    if (row.notNull !== row.originalNotNull) {
+      alterArgs.not_null = row.notNull;
+    }
+    if (row.defaultExpr) {
+      alterArgs.default_expr = row.defaultExpr;
+    } else if (row.originalHasDefault) {
+      if (row.defaultValue !== row.originalDefault) {
+        alterArgs.default = row.defaultValue === "" ? null : row.defaultValue;
+      }
+    } else if (row.defaultValue) {
+      alterArgs.default = row.defaultValue;
+    }
+    if (Object.keys(alterArgs).length > 1) {
+      operations.push({ op: "alter_column", args: alterArgs });
+    }
+  });
+
+  state.deletedColumns.forEach(function (name) {
+    operations.push({ op: "drop_column", args: { name: name } });
+  });
+
+  var pkColumns = rows
+    .filter(function (row) {
+      return row.pk;
+    })
+    .map(function (row) {
+      return row.name.trim();
+    });
+  if (tableAlterPkChanged(state, rows)) {
+    operations.push({ op: "set_primary_key", args: { columns: pkColumns } });
+  }
+
+  if (tableAlterColumnsReordered(state, rows)) {
+    operations.push({
+      op: "reorder_columns",
+      args: {
+        columns: rows.map(function (row) {
+          return row.name.trim();
+        }),
+      },
+    });
+  }
+
+  if (!operations.length && !columnTypeAssignments.length) {
+    return { error: "No changes to apply." };
+  }
+  return {
+    payload: operations.length ? { operations: operations } : null,
+    columnTypeAssignments: columnTypeAssignments,
+  };
+}
+
+function tableAlterQuotedName(name) {
+  return '"' + name + '"';
+}
+
+function tableAlterReadableDefaultExpression(value) {
+  return value ? value.replace(/_/g, " ") : "";
+}
+
+function tableAlterReadableValue(value) {
+  if (value === null) {
+    return "NULL";
+  }
+  return '"' + String(value) + '"';
+}
+
+function tableAlterOperationSummary(operation) {
+  var args = operation.args || {};
+  if (operation.op === "add_column") {
+    var addDetails = ["as " + args.type];
+    if (args.not_null) {
+      addDetails.push("with values required");
+    }
+    if (args.default_expr) {
+      addDetails.push(
+        "defaulting to " +
+          tableAlterReadableDefaultExpression(args.default_expr),
+      );
+    } else if (Object.prototype.hasOwnProperty.call(args, "default")) {
+      addDetails.push(
+        "with default value " + tableAlterReadableValue(args.default),
+      );
+    }
+    return {
+      text:
+        "Add column " +
+        tableAlterQuotedName(args.name) +
+        " " +
+        addDetails.join(", ") +
+        ".",
+      damaging: false,
+    };
+  }
+  if (operation.op === "rename_column") {
+    return {
+      text:
+        "Rename column " +
+        tableAlterQuotedName(args.name) +
+        " to " +
+        tableAlterQuotedName(args.to) +
+        ".",
+      damaging: false,
+    };
+  }
+  if (operation.op === "alter_column") {
+    var changes = [];
+    if (args.type) {
+      changes.push("set type to " + args.type);
+    }
+    if (Object.prototype.hasOwnProperty.call(args, "not_null")) {
+      changes.push(
+        args.not_null
+          ? "not null (require values)"
+          : "allow unset values",
+      );
+    }
+    if (args.default_expr) {
+      changes.push(
+        "default to " + tableAlterReadableDefaultExpression(args.default_expr),
+      );
+    } else if (Object.prototype.hasOwnProperty.call(args, "default")) {
+      changes.push(
+        args.default === null
+          ? "remove the default value"
+          : "set default value to " + tableAlterReadableValue(args.default),
+      );
+    }
+    return {
+      text:
+        "Change column " +
+        tableAlterQuotedName(args.name) +
+        ": " +
+        changes.join(", ") +
+        ".",
+      damaging: false,
+    };
+  }
+  if (operation.op === "drop_column") {
+    return {
+      text: "Drop column " + tableAlterQuotedName(args.name) + ".",
+      damaging: true,
+    };
+  }
+  if (operation.op === "set_primary_key") {
+    return {
+      text:
+        "Set primary key to " +
+        (args.columns || []).map(tableAlterQuotedName).join(", ") +
+        ".",
+      damaging: false,
+    };
+  }
+  if (operation.op === "reorder_columns") {
+    return {
+      text:
+        "Set column order to " +
+        (args.columns || []).map(tableAlterQuotedName).join(", ") +
+        ".",
+      damaging: false,
+    };
+  }
+  return {
+    text: "Run " + operation.op + ".",
+    damaging: false,
+  };
+}
+
+function tableAlterColumnTypeAssignmentSummary(assignment) {
+  return {
+    text: assignment.columnType
+      ? "Set custom type for column " +
+        tableAlterQuotedName(assignment.column) +
+        " to " +
+        assignment.columnType +
+        "."
+      : "Remove custom type from column " +
+        tableAlterQuotedName(assignment.column) +
+        ".",
+    damaging: false,
+  };
+}
+
+function tableAlterReviewItems(result) {
+  var items = [];
+  var operations = result.payload ? result.payload.operations || [] : [];
+  operations.forEach(function (operation) {
+    items.push(tableAlterOperationSummary(operation));
+  });
+  (result.columnTypeAssignments || []).forEach(function (assignment) {
+    items.push(tableAlterColumnTypeAssignmentSummary(assignment));
+  });
+  return items;
+}
+
+function tableAlterReviewHasDamagingItems(items) {
+  return items.some(function (item) {
+    return item.damaging;
+  });
+}
+
+function appendTableAlterReviewText(element, text) {
+  text.split(/("[^"]+")/g).forEach(function (part) {
+    if (!part) {
+      return;
+    }
+    if (part.charAt(0) === '"' && part.charAt(part.length - 1) === '"') {
+      var name = document.createElement("code");
+      name.className = "table-alter-review-name";
+      name.textContent = part.slice(1, -1);
+      element.appendChild(name);
+    } else {
+      element.appendChild(document.createTextNode(part));
+    }
+  });
+}
+
+function tableAlterSetColumnTypeUrl() {
+  var data = tableAlterData();
+  if (!data || !data.path) {
+    return null;
+  }
+  var url = new URL(data.path, location.href);
+  url.pathname = url.pathname.replace(/\/-\/alter\/?$/, "/-/set-column-type");
+  return url.toString();
+}
+
+async function assignTableAlterColumnTypes(assignments) {
+  if (!assignments.length) {
+    return;
+  }
+  var url = tableAlterSetColumnTypeUrl();
+  if (!url) {
+    throw new Error("Could not find the set column type URL.");
+  }
+  for (var i = 0; i < assignments.length; i += 1) {
+    var assignment = assignments[i];
+    var response = await fetch(url, {
+      method: "POST",
+      headers: {
+        "Content-Type": "application/json",
+        Accept: "application/json",
+      },
+      body: JSON.stringify({
+        column: assignment.column,
+        column_type: assignment.columnType
+          ? {
+              type: assignment.columnType,
+            }
+          : null,
+      }),
+    });
+    var data = null;
+    try {
+      data = await response.json();
+    } catch (_error) {
+      data = null;
+    }
+    if (!response.ok || (data && data.ok === false)) {
+      var error = rowMutationRequestError(response, data);
+      throw new Error(
+        "Saved schema changes, but could not set custom type for " +
+          assignment.column +
+          ": " +
+          error.message,
+      );
+    }
+  }
+}
+
+function showTableAlterEditor(state) {
+  state.mode = "edit";
+  state.reviewResult = null;
+  state.dialog.classList.remove("table-alter-reviewing");
+  state.fields.hidden = false;
+  state.review.hidden = true;
+  state.review.textContent = "";
+  state.backButton.hidden = true;
+  state.saveButton.textContent = tableAlterSaveButtonText(state);
+  updateTableAlterMoveButtons(state);
+  updateTableAlterSaveButtonState(state);
+}
+
+function showTableAlterReview(state, result) {
+  var items = tableAlterReviewItems(result);
+  state.mode = "review";
+  state.reviewResult = result;
+  state.dialog.classList.add("table-alter-reviewing");
+  state.fields.hidden = true;
+  state.review.hidden = false;
+  state.review.textContent = "";
+  state.backButton.hidden = false;
+  state.saveButton.textContent = tableAlterSaveButtonText(state);
+  updateTableAlterSaveButtonState(state);
+
+  var heading = document.createElement("h3");
+  heading.className = "table-alter-review-title";
+  heading.tabIndex = -1;
+  heading.textContent = "Review changes";
+  state.review.appendChild(heading);
+
+  var intro = document.createElement("p");
+  intro.className = "table-alter-review-intro";
+  intro.textContent = "These changes will be applied to the table.";
+  state.review.appendChild(intro);
+
+  if (tableAlterReviewHasDamagingItems(items)) {
+    var warning = document.createElement("p");
+    warning.className = "table-alter-review-warning";
+    warning.setAttribute("role", "alert");
+    warning.textContent =
+      "Warning: data in dropped columns will be permanently lost.";
+    state.review.appendChild(warning);
+  }
+
+  var list = document.createElement("ol");
+  list.className = "table-alter-review-list";
+  items.forEach(function (item) {
+    var listItem = document.createElement("li");
+    appendTableAlterReviewText(listItem, item.text);
+    if (item.damaging) {
+      listItem.className = "table-alter-review-damaging";
+    }
+    list.appendChild(listItem);
+  });
+  state.review.appendChild(list);
+  heading.focus();
+}
+
+async function applyTableAlterChanges(state, result) {
+  if (state.isSaving) {
+    return;
+  }
+  if (!result) {
+    showTableAlterDialogError(state, "Could not find the reviewed changes.");
+    return;
+  }
+  var data = tableAlterData();
+  if (!data || !data.path) {
+    showTableAlterDialogError(state, "Could not find the alter table URL.");
+    return;
+  }
+  clearTableAlterDialogError(state);
+  if (result.error) {
+    showTableAlterDialogError(state, result.error);
+    return;
+  }
+  setTableAlterDialogSaving(state, true);
+  try {
+    if (result.payload) {
+      var response = await fetch(data.path, {
+        method: "POST",
+        headers: {
+          "Content-Type": "application/json",
+          Accept: "application/json",
+        },
+        body: JSON.stringify(result.payload),
+      });
+      var responseData = null;
+      try {
+        responseData = await response.json();
+      } catch (_error) {
+        responseData = null;
+      }
+      if (!response.ok || (responseData && responseData.ok === false)) {
+        throw rowMutationRequestError(response, responseData);
+      }
+    }
+    await assignTableAlterColumnTypes(result.columnTypeAssignments || []);
+    state.shouldRestoreFocus = false;
+    state.dialog.close();
+    location.reload();
+  } catch (error) {
+    setTableAlterDialogSaving(state, false);
+    showTableAlterDialogError(state, error.message || "Could not alter table");
+  }
+}
+
+async function saveTableAlterDialog(state) {
+  if (state.isSaving) {
+    return;
+  }
+  if (state.mode === "review") {
+    if (!state.reviewResult) {
+      showTableAlterDialogError(state, "Could not find the reviewed changes.");
+      return;
+    }
+    await applyTableAlterChanges(state, state.reviewResult);
+    return;
+  }
+  clearTableAlterDialogError(state);
+  var result = collectTableAlterPayload(state);
+  if (result.error) {
+    showTableAlterDialogError(state, result.error);
+    return;
+  }
+  showTableAlterReview(state, result);
+}
+
+function confirmDiscardTableAlterChanges(state) {
+  if (!tableAlterDialogHasChanges(state)) {
+    return true;
+  }
+  return window.confirm("Discard table changes?");
+}
+
+function closeTableAlterDialogIfConfirmed(state) {
+  if (!state || state.isSaving) {
+    return false;
+  }
+  if (!confirmDiscardTableAlterChanges(state)) {
+    return false;
+  }
+  state.shouldRestoreFocus = true;
+  state.dialog.close();
+  return true;
+}
+
+function closeTableAlterDialog(state) {
+  if (!state || state.isSaving) {
+    return false;
+  }
+  state.shouldRestoreFocus = true;
+  state.dialog.close();
+  return true;
+}
+
+function ensureTableAlterDialog(manager) {
+  if (tableAlterDialogState) {
+    return tableAlterDialogState;
+  }
+  if (!window.HTMLDialogElement) {
+    return null;
+  }
+
+  var dialog = document.createElement("dialog");
+  dialog.id = TABLE_ALTER_DIALOG_ID;
+  dialog.className = "table-alter-dialog";
+  dialog.setAttribute("aria-labelledby", "table-alter-title");
+  dialog.innerHTML = `
+    <div class="modal-header">
+      <span class="modal-title" id="table-alter-title">Alter table</span>
+    </div>
+    <form class="table-alter-form" method="post" novalidate>
+      <p class="table-alter-error" id="table-alter-error" role="alert" tabindex="-1" hidden></p>
+      <div class="table-alter-fields">
+        <div class="table-alter-columns">
+          <div class="table-alter-column-headings" aria-hidden="true">
+            <span>Column</span>
+            <span>Type</span>
+            <span>Custom Type</span>
+            <span>Move</span>
+            <span></span>
+          </div>
+          <div class="table-alter-column-list"></div>
+          <button type="button" class="table-alter-add-column">Add column</button>
+        </div>
+      </div>
+      <div class="table-alter-review" hidden></div>
+      <div class="modal-footer">
+        <button type="button" class="btn btn-ghost table-alter-back" hidden>Back</button>
+        <button type="button" class="btn btn-ghost table-alter-cancel">Cancel</button>
+        <button type="submit" class="btn btn-primary table-alter-save">Review changes</button>
+      </div>
+    </form>
+  `;
+  document.body.appendChild(dialog);
+
+  tableAlterDialogState = {
+    dialog: dialog,
+    form: dialog.querySelector(".table-alter-form"),
+    title: dialog.querySelector(".modal-title"),
+    error: dialog.querySelector(".table-alter-error"),
+    fields: dialog.querySelector(".table-alter-fields"),
+    review: dialog.querySelector(".table-alter-review"),
+    columnList: dialog.querySelector(".table-alter-column-list"),
+    addColumnButton: dialog.querySelector(".table-alter-add-column"),
+    backButton: dialog.querySelector(".table-alter-back"),
+    cancelButton: dialog.querySelector(".table-alter-cancel"),
+    saveButton: dialog.querySelector(".table-alter-save"),
+    currentButton: null,
+    shouldRestoreFocus: true,
+    isSaving: false,
+    initialSignature: "",
+    nextColumnIndex: 0,
+    deletedColumns: [],
+    originalColumnNames: [],
+    originalPrimaryKeys: [],
+    mode: "edit",
+    reviewResult: null,
+    manager: manager,
+  };
+
+  tableAlterDialogState.form.addEventListener("submit", function (ev) {
+    ev.preventDefault();
+    saveTableAlterDialog(tableAlterDialogState);
+  });
+
+  tableAlterDialogState.addColumnButton.addEventListener("click", function () {
+    if (tableAlterDialogState.isSaving) {
+      return;
+    }
+    var row = addTableAlterColumn(tableAlterDialogState, {
+      type: "text",
+      existing: false,
+      expanded: true,
+    });
+    clearTableAlterDialogError(tableAlterDialogState);
+    updateTableAlterMoveButtons(tableAlterDialogState);
+    updateTableAlterSaveButtonState(tableAlterDialogState);
+    row.querySelector(".table-alter-column-name").focus();
+  });
+
+  tableAlterDialogState.cancelButton.addEventListener("click", function () {
+    closeTableAlterDialog(tableAlterDialogState);
+  });
+
+  tableAlterDialogState.backButton.addEventListener("click", function () {
+    if (tableAlterDialogState.isSaving) {
+      return;
+    }
+    clearTableAlterDialogError(tableAlterDialogState);
+    showTableAlterEditor(tableAlterDialogState);
+    var firstName = tableAlterDialogState.columnList.querySelector(
+      ".table-alter-column-name",
+    );
+    if (firstName) {
+      firstName.focus();
+    }
+  });
+
+  dialog.addEventListener("click", function (ev) {
+    if (ev.target === dialog) {
+      closeTableAlterDialogIfConfirmed(tableAlterDialogState);
+    }
+  });
+
+  dialog.addEventListener("keydown", function (ev) {
+    if (ev.key !== "Escape") {
+      return;
+    }
+    ev.preventDefault();
+    closeTableAlterDialogIfConfirmed(tableAlterDialogState);
+  });
+
+  dialog.addEventListener("cancel", function (ev) {
+    ev.preventDefault();
+    closeTableAlterDialogIfConfirmed(tableAlterDialogState);
+  });
+
+  dialog.addEventListener("close", function () {
+    var state = tableAlterDialogState;
+    clearTableAlterDialogError(state);
+    setTableAlterDialogSaving(state, false);
+    if (
+      state.shouldRestoreFocus &&
+      state.currentButton &&
+      document.contains(state.currentButton)
+    ) {
+      state.currentButton.focus();
+    }
+  });
+
+  return tableAlterDialogState;
+}
+
+function openTableAlterDialog(button, manager) {
+  var data = tableAlterData();
+  if (!data) {
+    return;
+  }
+  var state = ensureTableAlterDialog(manager);
+  if (!state) {
+    return;
+  }
+
+  var menu = button.closest("details");
+  if (menu) {
+    menu.open = false;
+  }
+  state.manager = manager;
+  state.currentButton = button;
+  state.shouldRestoreFocus = true;
+  state.title.textContent = "Alter table " + data.tableName;
+  clearTableAlterDialogError(state);
+  resetTableAlterDialog(state, data);
+  if (!state.dialog.open) {
+    state.dialog.showModal();
+  }
+  var firstName = state.columnList.querySelector(".table-alter-column-name");
+  if (firstName) {
+    firstName.focus();
+  }
+}
+
+function initTableAlterActions(manager) {
+  if (!window.fetch || !window.HTMLDialogElement || !tableAlterData()) {
+    return;
+  }
+  document.addEventListener("click", function (ev) {
+    var button = ev.target.closest('button[data-table-action="alter-table"]');
+    if (!button) {
+      return;
+    }
+    ev.preventDefault();
+    openTableAlterDialog(button, manager);
+  });
+}
+
 function tableForeignKeys() {
   return tablePageData().foreignKeys || {};
 }
@@ -2696,6 +4171,7 @@ document.addEventListener("datasette_init", function (evt) {
 
   registerBuiltinColumnFieldPlugins(manager);
   initTableCreateActions(manager);
+  initTableAlterActions(manager);
   initRowInsertActions(manager);
   initRowEditActions(manager);
   initRowDeleteActions(manager);
diff --git a/datasette/views/row.py b/datasette/views/row.py
index 4d61eb91..34773d48 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -212,6 +212,7 @@ class RowView(DataView):
                     table,
                     not is_table,
                     None,
+                    None,
                 ),
                 "row_actions": row_actions,
                 "top_row": make_slot_function(
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 11a28323..5175c7d9 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -50,7 +50,7 @@ from datasette.filters import Filters
 import sqlite_utils
 from sqlite_utils.db import DEFAULT as SQLITE_UTILS_DEFAULT
 from .base import BaseView, DatasetteError, _error, stream_csv
-from .database import QueryView
+from .database import QueryView, _custom_column_type_options_for_create_table
 from .table_extras import (
     TABLE_EXTRA_BUNDLES,
     TableExtraContext,
@@ -62,6 +62,13 @@ LINK_WITH_LABEL = (
     '<a href="{base_url}{database}/{table}/{link_id}">{label}</a>&nbsp;<em>{id}</em>'
 )
 LINK_WITH_VALUE = '<a href="{base_url}{database}/{table}/{link_id}">{id}</a>'
+ALTER_TABLE_COLUMN_TYPES = ["text", "integer", "float", "blob"]
+ALTER_TABLE_TYPE_FOR_SQLITE_TYPE = {
+    SQLiteType.TEXT: "text",
+    SQLiteType.INTEGER: "integer",
+    SQLiteType.REAL: "float",
+    SQLiteType.BLOB: "blob",
+}
 
 
 class Row:
@@ -283,7 +290,14 @@ async def _foreign_key_autocomplete_urls(
 
 
 async def _table_page_data(
-    datasette, request, db, database_name, table_name, is_view, table_insert_ui
+    datasette,
+    request,
+    db,
+    database_name,
+    table_name,
+    is_view,
+    table_insert_ui,
+    table_alter_ui,
 ):
     data = {
         "database": database_name,
@@ -292,6 +306,8 @@ async def _table_page_data(
     }
     if table_insert_ui:
         data["insertRow"] = table_insert_ui
+    if table_alter_ui:
+        data["alterTable"] = table_alter_ui
     if not is_view:
         foreign_keys = await _foreign_key_autocomplete_urls(
             datasette, request, db, database_name, table_name
@@ -354,6 +370,63 @@ async def _table_insert_ui(
     }
 
 
+async def _table_alter_ui(
+    datasette, request, db, database_name, table_name, is_view, pks
+):
+    if is_view or not db.is_mutable:
+        return None
+
+    if not await datasette.allowed(
+        action="alter-table",
+        resource=TableResource(database=database_name, table=table_name),
+        actor=request.actor,
+    ):
+        return None
+
+    column_types_map = await datasette.get_column_types(database_name, table_name)
+    columns = []
+    for column in await db.table_column_details(table_name):
+        if column.hidden:
+            continue
+        sqlite_type = SQLiteType.from_declared_type(column.type)
+        column_type = column_types_map.get(column.name)
+        columns.append(
+            {
+                "name": column.name,
+                "type": ALTER_TABLE_TYPE_FOR_SQLITE_TYPE.get(sqlite_type, "text"),
+                "sqlite_type": sqlite_type.value,
+                "notnull": column.notnull,
+                "default": column.default_value,
+                "has_default": column.default_value is not None,
+                "is_pk": column.name in pks,
+                "column_type": (
+                    {"type": column_type.name, "config": column_type.config}
+                    if column_type is not None
+                    else None
+                ),
+            }
+        )
+
+    data = {
+        "path": "{}/-/alter".format(datasette.urls.table(database_name, table_name)),
+        "tableName": table_name,
+        "columns": columns,
+        "primaryKeys": pks,
+        "columnTypes": ALTER_TABLE_COLUMN_TYPES,
+        "defaultExpressions": list(DEFAULT_EXPR_SQL),
+    }
+    can_set_column_type = await datasette.allowed(
+        action="set-column-type",
+        resource=TableResource(database=database_name, table=table_name),
+        actor=request.actor,
+    )
+    if can_set_column_type:
+        data["customColumnTypes"] = _custom_column_type_options_for_create_table(
+            datasette
+        )
+    return data
+
+
 async def display_columns_and_rows(
     datasette,
     database_name,
@@ -2421,7 +2494,11 @@ async def table_view_data(
         table_insert_ui = await _table_insert_ui(
             datasette, request, db, database_name, table_name, is_view, pks
         )
+        table_alter_ui = await _table_alter_ui(
+            datasette, request, db, database_name, table_name, is_view, pks
+        )
         data["table_insert_ui"] = table_insert_ui
+        data["table_alter_ui"] = table_alter_ui
         data["table_page_data"] = await _table_page_data(
             datasette,
             request,
@@ -2430,6 +2507,7 @@ async def table_view_data(
             table_name,
             is_view,
             table_insert_ui,
+            table_alter_ui,
         )
 
     return data, rows[:page_size], columns, expanded_columns, sql, next_url
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 0c7042f0..b7990009 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -130,6 +130,7 @@ def write_playwright_config(config_path):
                                     "notes": "textarea",
                                 },
                                 "permissions": {
+                                    "alter-table": True,
                                     "insert-row": True,
                                     "update-row": True,
                                     "delete-row": True,
@@ -328,6 +329,215 @@ def test_create_table_flow(page, datasette_server):
     }
 
 
+@pytest.mark.playwright
+def test_alter_table_flow(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    assert dialog.locator(".modal-title").inner_text() == "Alter table projects"
+    assert dialog.locator(".table-alter-save").is_disabled()
+    type_options = dialog.locator(".table-alter-column-type").first.locator("option")
+    assert type_options.all_inner_texts() == [
+        "text",
+        "integer",
+        "floating point number",
+        "blob - binary data",
+    ]
+    first_more_options = dialog.locator(".table-alter-more-options").first
+    assert first_more_options.inner_text() == "> Advanced options"
+    first_more_options.click()
+    assert first_more_options.inner_text() == "v Hide options"
+    expanded_options_text = dialog.locator(".table-alter-column-details").first.inner_text()
+    assert dialog.locator(".table-alter-fields").evaluate(
+        "node => node.scrollWidth <= node.clientWidth + 1"
+    )
+    assert "Not null" in expanded_options_text
+    assert "This value cannot be left unset" in expanded_options_text
+    assert "Default value" in expanded_options_text
+    assert "or default to a specific time" in expanded_options_text
+    assert "Primary key" in expanded_options_text
+    assert "An ID that uniquely identifies this record" in expanded_options_text
+
+    dialog.locator(".table-alter-add-column").click()
+    assert dialog.locator(".table-alter-save").is_enabled()
+    dialog.locator(".table-alter-column-name").last.fill("status")
+    dialog.locator(".table-alter-column-type").last.select_option("text")
+    dialog.locator(".table-alter-default").last.fill("planned")
+    dialog.locator(".table-alter-save").click()
+    review = dialog.locator(".table-alter-review")
+    review.wait_for()
+    assert not dialog.locator(".table-alter-column-list").is_visible()
+    review_text = review.inner_text()
+    assert "Add column status as text, with default value planned." in review_text
+    assert "Set column order to" not in review_text
+    assert dialog.locator(".table-alter-back").is_visible()
+    assert dialog.locator(".table-alter-save").inner_text() == "Apply changes"
+    dialog.locator(".table-alter-save").click()
+
+    columns = []
+    for _ in range(20):
+        response = httpx.get(f"{datasette_server}data/projects.json?_extra=columns")
+        response.raise_for_status()
+        columns = response.json()["columns"]
+        if "status" in columns:
+            break
+        time.sleep(0.1)
+    assert "status" in columns
+
+
+@pytest.mark.playwright
+def test_alter_table_primary_key_columns_stay_at_top(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    rows = dialog.locator(".table-alter-column-row")
+    assert rows.nth(0).locator(".table-alter-column-name").input_value() == "id"
+    first_row_move_buttons = rows.nth(0).locator(".table-alter-move-controls button")
+    for i in range(first_row_move_buttons.count()):
+        assert first_row_move_buttons.nth(i).is_disabled()
+        assert (
+            first_row_move_buttons.nth(i).get_attribute("title")
+            == "Primary key columns are always listed first"
+        )
+
+    assert rows.nth(1).locator(".table-alter-move-up").is_disabled()
+    assert rows.nth(1).locator(".table-alter-move-top").get_attribute("title") == (
+        "Primary key columns are always listed first"
+    )
+    assert rows.nth(1).locator(".table-alter-move-up").get_attribute("title") == (
+        "Primary key columns are always listed first"
+    )
+    last_row = rows.nth(rows.count() - 1)
+    assert last_row.locator(".table-alter-column-name").input_value() == "score"
+    last_row.locator(".table-alter-move-top").click()
+    assert rows.nth(0).locator(".table-alter-column-name").input_value() == "id"
+    assert rows.nth(1).locator(".table-alter-column-name").input_value() == "score"
+
+
+@pytest.mark.playwright
+def test_alter_table_review_rename_primary_key_column(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    save = dialog.locator(".table-alter-save")
+    assert save.is_disabled()
+    dialog.locator(".table-alter-column-name").first.fill("id3")
+    assert save.is_enabled()
+    save.click()
+
+    review = dialog.locator(".table-alter-review")
+    review.wait_for()
+    review_text = review.inner_text()
+    assert "Rename column id to id3." in review_text
+    assert "Set primary key to" not in review_text
+    assert dialog.locator(".table-alter-review-name").all_inner_texts() == [
+        "id",
+        "id3",
+    ]
+
+
+@pytest.mark.playwright
+def test_alter_table_review_not_null_wording(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    dialog.locator(".table-alter-more-options").first.click()
+    dialog.locator(".table-alter-not-null-input").first.check()
+    dialog.locator(".table-alter-save").click()
+
+    review = dialog.locator(".table-alter-review")
+    review.wait_for()
+    assert "Change column id: not null (require values)." in review.inner_text()
+
+
+@pytest.mark.playwright
+def test_alter_table_review_warns_when_dropping_column(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    remove_buttons = dialog.locator(".table-alter-remove-column")
+    remove_buttons.nth(remove_buttons.count() - 1).click()
+    dialog.locator(".table-alter-save").click()
+
+    review = dialog.locator(".table-alter-review")
+    review.wait_for()
+    assert not dialog.locator(".table-alter-column-list").is_visible()
+    review_text = review.inner_text()
+    assert "Warning: data in dropped columns will be permanently lost." in review_text
+    assert "Drop column score." in review_text
+    assert "Set column order to" not in review_text
+    assert dialog.locator(".table-alter-review-damaging").inner_text() == (
+        "Drop column score."
+    )
+
+    dialog.locator(".table-alter-back").click()
+    assert dialog.locator(".table-alter-column-list").is_visible()
+    assert dialog.locator(".table-alter-save").inner_text() == "Review changes"
+
+
+@pytest.mark.playwright
+def test_alter_table_cancel_skips_discard_prompt(page, datasette_server):
+    def open_alter_dialog():
+        page.locator("details.actions-menu-links").evaluate("node => node.open = true")
+        page.locator('button[data-table-action="alter-table"]').click()
+        dialog = page.locator("#table-alter-dialog")
+        dialog.wait_for()
+        return dialog
+
+    page.goto(f"{datasette_server}data/projects")
+    page.evaluate(
+        """
+        () => {
+            window.__discardConfirmMessages = [];
+            window.confirm = (message) => {
+                window.__discardConfirmMessages.push(message);
+                return false;
+            };
+        }
+        """
+    )
+
+    dialog = open_alter_dialog()
+    dialog.locator(".table-alter-add-column").click()
+    dialog.locator(".table-alter-column-name").last.fill("cancel_me")
+    dialog.locator(".table-alter-cancel").click()
+    assert dialog.evaluate("node => node.open") is False
+    assert page.evaluate("() => window.__discardConfirmMessages") == []
+
+    dialog = open_alter_dialog()
+    dialog.locator(".table-alter-add-column").click()
+    dialog.locator(".table-alter-column-name").last.fill("escape_me")
+    page.keyboard.press("Escape")
+    assert page.evaluate("() => window.__discardConfirmMessages") == [
+        "Discard table changes?"
+    ]
+    assert dialog.evaluate("node => node.open") is True
+
+    page.evaluate("() => window.__discardConfirmMessages = []")
+    dialog.evaluate(
+        """node => node.dispatchEvent(new MouseEvent("click", {bubbles: true}))"""
+    )
+    assert page.evaluate("() => window.__discardConfirmMessages") == [
+        "Discard table changes?"
+    ]
+    assert dialog.evaluate("node => node.open") is True
+
+
 @pytest.mark.playwright
 def test_navigation_search_tracks_and_renders_recent_items(page, datasette_server):
     page.goto(datasette_server)
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 887fdf50..374cc08d 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1078,6 +1078,123 @@ async def test_database_create_table_data_includes_custom_column_types():
         ds.close()
 
 
+@pytest.mark.asyncio
+async def test_table_alter_action_button_and_data():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "tables": {
+                        "items": {
+                            "permissions": {
+                                "alter-table": {"id": "root"},
+                                "set-column-type": {"id": "root"},
+                            },
+                            "column_types": {"name": "textarea"},
+                        },
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_table_alter_action"), name="data"
+        )
+        await db.execute_write_script("""
+            create table items (
+                id integer primary key,
+                name text not null,
+                score integer default 5
+            );
+            """)
+        response = await ds.client.get("/data/items", actor={"id": "root"})
+        assert response.status_code == 200
+        soup = Soup(response.text, "html.parser")
+
+        button = soup.select_one(
+            'button.action-menu-button[data-table-action="alter-table"]'
+        )
+        assert button is not None
+        assert button["aria-label"] == "Alter table items"
+        assert button["role"] == "menuitem"
+        description = button.find("span", class_="dropdown-description")
+        assert description.text.strip() == (
+            "Change columns and primary key for this table."
+        )
+        description.extract()
+        assert button.text.strip() == "Alter table"
+        assert any(
+            "edit-tools.js" in script.get("src", "")
+            for script in soup.find_all("script")
+        )
+
+        alter_data = table_data_from_soup(soup)["alterTable"]
+        assert alter_data["path"] == "/data/items/-/alter"
+        assert alter_data["tableName"] == "items"
+        assert alter_data["primaryKeys"] == ["id"]
+        assert alter_data["columnTypes"] == ["text", "integer", "float", "blob"]
+        assert alter_data["defaultExpressions"] == [
+            "current_timestamp",
+            "current_date",
+            "current_time",
+        ]
+        assert [option["name"] for option in alter_data["customColumnTypes"]] == [
+            "email",
+            "json",
+            "textarea",
+            "url",
+        ]
+        assert alter_data["columns"] == [
+            {
+                "name": "id",
+                "type": "integer",
+                "sqlite_type": "INTEGER",
+                "notnull": 0,
+                "default": None,
+                "has_default": False,
+                "is_pk": True,
+                "column_type": None,
+            },
+            {
+                "name": "name",
+                "type": "text",
+                "sqlite_type": "TEXT",
+                "notnull": 1,
+                "default": None,
+                "has_default": False,
+                "is_pk": False,
+                "column_type": {"type": "textarea", "config": None},
+            },
+            {
+                "name": "score",
+                "type": "integer",
+                "sqlite_type": "INTEGER",
+                "notnull": 0,
+                "default": "5",
+                "has_default": True,
+                "is_pk": False,
+                "column_type": None,
+            },
+        ]
+
+        response_without_permission = await ds.client.get(
+            "/data/items", actor={"id": "someone-else"}
+        )
+        assert response_without_permission.status_code == 200
+        soup_without_permission = Soup(response_without_permission.text, "html.parser")
+        assert (
+            soup_without_permission.select_one(
+                'button[data-table-action="alter-table"]'
+            )
+            is None
+        )
+        assert "alterTable" not in table_data_from_soup(soup_without_permission)
+    finally:
+        ds.close()
+
+
 @pytest.mark.asyncio
 async def test_table_insert_action_button_and_data():
     ds = Datasette(

From 15a3ac58cc10a4004e21e67845e53b2ead26a3b3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 09:24:28 -0700
Subject: [PATCH 239/386] Ran Prettier

---
 datasette/static/edit-tools.js | 96 +++++++++++++++++++---------------
 1 file changed, 53 insertions(+), 43 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 284d6bde..cb964365 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -49,8 +49,7 @@ function hideRowMutationStatus() {
 
 function databaseCreateTableData() {
   return (
-    window._datasetteDatabaseData &&
-    window._datasetteDatabaseData.createTable
+    window._datasetteDatabaseData && window._datasetteDatabaseData.createTable
   );
 }
 
@@ -166,10 +165,7 @@ function tableCreateSelectTypeValue(select, type) {
 }
 
 function updateTableCreateCustomColumnTypePlaceholder(select) {
-  select.classList.toggle(
-    "table-create-input-placeholder",
-    !select.value,
-  );
+  select.classList.toggle("table-create-input-placeholder", !select.value);
 }
 
 function createTableCustomColumnTypeSelect() {
@@ -273,9 +269,7 @@ function createTableColumnRow(state, column) {
     }
     row.remove();
     clearTableCreateDialogError(state);
-    var nextInput = state.columnList.querySelector(
-      ".table-create-column-name",
-    );
+    var nextInput = state.columnList.querySelector(".table-create-column-name");
     if (nextInput) {
       nextInput.focus();
     } else {
@@ -418,7 +412,9 @@ function validateTableCreateColumnTypeAssignments(assignments) {
     if (!option) {
       return "Unknown custom column type: " + assignment.columnType;
     }
-    if (!tableCreateCustomTypeAppliesToSqliteType(option, assignment.sqliteType)) {
+    if (
+      !tableCreateCustomTypeAppliesToSqliteType(option, assignment.sqliteType)
+    ) {
       return (
         "Custom type " +
         assignment.columnType +
@@ -441,7 +437,8 @@ function fallbackTableUrl(tableName) {
 
 function tableCreateSetColumnTypeUrl(responseData, payload) {
   var tableUrl =
-    responseData.table_url || fallbackTableUrl(responseData.table || payload.table);
+    responseData.table_url ||
+    fallbackTableUrl(responseData.table || payload.table);
   if (!tableUrl) {
     return null;
   }
@@ -452,7 +449,11 @@ function tableCreateSetColumnTypeUrl(responseData, payload) {
   return url.toString();
 }
 
-async function assignTableCreateColumnTypes(responseData, payload, assignments) {
+async function assignTableCreateColumnTypes(
+  responseData,
+  payload,
+  assignments,
+) {
   if (!assignments.length) {
     return;
   }
@@ -542,7 +543,8 @@ async function saveTableCreateDialog(state) {
       columnTypeAssignments,
     );
     var tableUrl =
-      responseData.table_url || fallbackTableUrl(responseData.table || payload.table);
+      responseData.table_url ||
+      fallbackTableUrl(responseData.table || payload.table);
     state.shouldRestoreFocus = false;
     state.dialog.close();
     if (tableUrl) {
@@ -718,7 +720,11 @@ function openTableCreateDialog(button, manager) {
 }
 
 function initTableCreateActions(manager) {
-  if (!window.fetch || !window.HTMLDialogElement || !databaseCreateTableData()) {
+  if (
+    !window.fetch ||
+    !window.HTMLDialogElement ||
+    !databaseCreateTableData()
+  ) {
     return;
   }
   document.addEventListener("click", function (ev) {
@@ -952,15 +958,15 @@ function updateTableAlterMoveButtons(state) {
     var isPrimaryKey = tableAlterRowIsPrimaryKey(row);
     var previous = row.previousElementSibling;
     var next = row.nextElementSibling;
-    row.querySelectorAll(".table-alter-move-controls button").forEach(
-      function (button) {
+    row
+      .querySelectorAll(".table-alter-move-controls button")
+      .forEach(function (button) {
         button.title = button.dataset.defaultTitle || button.title;
         button.disabled = state.isSaving || isPrimaryKey;
         if (isPrimaryKey) {
           button.title = primaryKeyMoveTitle;
         }
-      },
-    );
+      });
     if (!isPrimaryKey) {
       var topButton = row.querySelector(".table-alter-move-top");
       var upButton = row.querySelector(".table-alter-move-up");
@@ -1028,7 +1034,9 @@ function setTableAlterDialogSaving(state, isSaving) {
     state.columnList
       .querySelectorAll(".table-alter-default-expr")
       .forEach(function (select) {
-        syncTableAlterDefaultControls(select.closest(".table-alter-column-row"));
+        syncTableAlterDefaultControls(
+          select.closest(".table-alter-column-row"),
+        );
       });
   }
   updateTableAlterMoveButtons(state);
@@ -1051,10 +1059,7 @@ function tableAlterSelectTypeValue(select, type) {
 }
 
 function updateTableAlterCustomColumnTypePlaceholder(select) {
-  select.classList.toggle(
-    "table-alter-input-placeholder",
-    !select.value,
-  );
+  select.classList.toggle("table-alter-input-placeholder", !select.value);
 }
 
 function createTableAlterCustomColumnTypeSelect() {
@@ -1159,10 +1164,7 @@ function createTableAlterColumnRow(state, column) {
   expandButton.className = "table-alter-more-options";
   expandButton.setAttribute("aria-label", "Toggle column settings");
   expandButton.setAttribute("aria-controls", details.id);
-  expandButton.setAttribute(
-    "aria-expanded",
-    details.hidden ? "false" : "true",
-  );
+  expandButton.setAttribute("aria-expanded", details.hidden ? "false" : "true");
   function updateExpandButton() {
     var isExpanded = expandButton.getAttribute("aria-expanded") === "true";
     expandButton.textContent = isExpanded
@@ -1243,8 +1245,7 @@ function createTableAlterColumnRow(state, column) {
   defaultExprLabel.textContent = "or default to a specific time";
   var defaultExprSelect = document.createElement("select");
   defaultExprSelect.id = defaultExprId;
-  defaultExprSelect.className =
-    "table-alter-input table-alter-default-expr";
+  defaultExprSelect.className = "table-alter-input table-alter-default-expr";
   defaultExprSelect.setAttribute("aria-label", "or default to a specific time");
   tableAlterSelectDefaultExprValue(defaultExprSelect, "");
   defaultExprField.appendChild(defaultExprLabel);
@@ -1298,7 +1299,8 @@ function createTableAlterColumnRow(state, column) {
 
   var moveBottomButton = document.createElement("button");
   moveBottomButton.type = "button";
-  moveBottomButton.className = "table-alter-icon-button table-alter-move-bottom";
+  moveBottomButton.className =
+    "table-alter-icon-button table-alter-move-bottom";
   moveBottomButton.setAttribute("aria-label", "Move column to bottom");
   moveBottomButton.title = "Move column to bottom";
   moveBottomButton.dataset.defaultTitle = moveBottomButton.title;
@@ -1349,15 +1351,15 @@ function createTableAlterColumnRow(state, column) {
     controls.push(customTypeSelect);
   }
   controls.forEach(function (control) {
-      control.addEventListener("input", function () {
-        clearTableAlterDialogError(state);
-        updateTableAlterSaveButtonState(state);
-      });
-      control.addEventListener("change", function () {
-        clearTableAlterDialogError(state);
-        updateTableAlterSaveButtonState(state);
-      });
+    control.addEventListener("input", function () {
+      clearTableAlterDialogError(state);
+      updateTableAlterSaveButtonState(state);
     });
+    control.addEventListener("change", function () {
+      clearTableAlterDialogError(state);
+      updateTableAlterSaveButtonState(state);
+    });
+  });
 
   defaultInput.addEventListener("input", function () {
     if (defaultInput.value) {
@@ -1407,7 +1409,12 @@ function createTableAlterColumnRow(state, column) {
 
   moveTopButton.addEventListener("click", function () {
     var first = tableAlterFirstNonPrimaryRow(state);
-    if (state.isSaving || tableAlterRowIsPrimaryKey(row) || !first || first === row) {
+    if (
+      state.isSaving ||
+      tableAlterRowIsPrimaryKey(row) ||
+      !first ||
+      first === row
+    ) {
       return;
     }
     state.columnList.insertBefore(row, first);
@@ -1448,7 +1455,12 @@ function createTableAlterColumnRow(state, column) {
 
   moveBottomButton.addEventListener("click", function () {
     var last = state.columnList.lastElementChild;
-    if (state.isSaving || tableAlterRowIsPrimaryKey(row) || !last || last === row) {
+    if (
+      state.isSaving ||
+      tableAlterRowIsPrimaryKey(row) ||
+      !last ||
+      last === row
+    ) {
       return;
     }
     state.columnList.appendChild(row);
@@ -1797,9 +1809,7 @@ function tableAlterOperationSummary(operation) {
     }
     if (Object.prototype.hasOwnProperty.call(args, "not_null")) {
       changes.push(
-        args.not_null
-          ? "not null (require values)"
-          : "allow unset values",
+        args.not_null ? "not null (require values)" : "allow unset values",
       );
     }
     if (args.default_expr) {

From c9c79fdfc8395fe49d0e9d262548f2b337bec3bc Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 09:58:39 -0700
Subject: [PATCH 240/386] Isolate Unix domain socket test server paths

- Use a per-process socket path for the UDS test fixture.
- Clean up stale socket files before and after the fixture runs.
- Close the HTTP client and wait for the Datasette subprocess to exit.
---
 tests/conftest.py | 34 ++++++++++++++++++++++++++--------
 1 file changed, 26 insertions(+), 8 deletions(-)

diff --git a/tests/conftest.py b/tests/conftest.py
index 8860d54c..7ec03146 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -260,8 +260,12 @@ def ds_unix_domain_socket_server(tmp_path_factory):
     # This used to use tmp_path_factory.mktemp("uds") but that turned out to
     # produce paths that were too long to use as UDS on macOS, see
     # https://github.com/simonw/datasette/issues/1407 - so I switched to
-    # using tempfile.gettempdir()
-    uds = str(pathlib.Path(tempfile.gettempdir()) / "datasette.sock")
+    # using tempfile.gettempdir() with a per-process filename.
+    uds = str(pathlib.Path(tempfile.gettempdir()) / f"datasette-{os.getpid()}.sock")
+    try:
+        os.unlink(uds)
+    except FileNotFoundError:
+        pass
     ds_proc = subprocess.Popen(
         [sys.executable, "-m", "datasette", "--memory", "--uds", uds],
         stdout=subprocess.PIPE,
@@ -271,12 +275,26 @@ def ds_unix_domain_socket_server(tmp_path_factory):
     # Poll until available
     transport = httpx.HTTPTransport(uds=uds)
     client = httpx.Client(transport=transport)
-    wait_until_responds("http://localhost/_memory.json", client=client)
-    # Check it started successfully
-    assert not ds_proc.poll(), ds_proc.stdout.read().decode("utf-8")
-    yield ds_proc, uds
-    # Shut it down at the end of the pytest session
-    ds_proc.terminate()
+    try:
+        wait_until_responds(
+            "http://localhost/_memory.json", timeout=30.0, client=client
+        )
+        # Check it started successfully
+        assert not ds_proc.poll(), ds_proc.stdout.read().decode("utf-8")
+        yield ds_proc, uds
+    finally:
+        client.close()
+        # Shut it down at the end of the pytest session
+        ds_proc.terminate()
+        try:
+            ds_proc.wait(timeout=5)
+        except subprocess.TimeoutExpired:
+            ds_proc.kill()
+            ds_proc.wait()
+        try:
+            os.unlink(uds)
+        except FileNotFoundError:
+            pass
 
 
 # Import fixtures from fixtures.py to make them available

From 4115213e17d23cdf3286bc4583e7005991892568 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 10:22:42 -0700
Subject: [PATCH 241/386] Precompute action permissions for table pages

- Extract reusable helpers for database and table action permission preloading.
- Precompute those permissions before building table-page HTML data.
- Document the default table actions plugin.
---
 datasette/views/table.py        | 22 ++++++++++++---
 datasette/views/table_extras.py | 49 ++++++++++++++++++++++-----------
 docs/plugins.rst                |  9 ++++++
 tests/test_playwright.py        | 10 +++----
 4 files changed, 65 insertions(+), 25 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 5175c7d9..82c7e03d 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -54,6 +54,8 @@ from .database import QueryView, _custom_column_type_options_for_create_table
 from .table_extras import (
     TABLE_EXTRA_BUNDLES,
     TableExtraContext,
+    precompute_database_action_permissions,
+    precompute_table_action_permissions,
     resolve_table_extras,
     table_extra_registry,
 )
@@ -1247,7 +1249,10 @@ class TableAlterView(BaseView):
                             defaults[args.name] = _literal_default(
                                 db_for_write, args.default
                             )
-                        if "default_expr" in args.model_fields_set and not args.not_null:
+                        if (
+                            "default_expr" in args.model_fields_set
+                            and not args.not_null
+                        ):
                             defaults[args.name] = _default_expression_sql(
                                 args.default_expr
                             )
@@ -1363,9 +1368,9 @@ class TableAlterView(BaseView):
                 "altered": altered,
                 "schema": after_schema,
                 "before_schema": before_schema,
-                "operations_applied": 0
-                if alter_request.dry_run
-                else len(alter_request.operations),
+                "operations_applied": (
+                    0 if alter_request.dry_run else len(alter_request.operations)
+                ),
                 "dry_run": alter_request.dry_run,
             },
             status=200,
@@ -2068,6 +2073,15 @@ async def table_view_data(
     if redirect_response:
         return redirect_response
 
+    if context_for_html_hack:
+        await precompute_database_action_permissions(
+            datasette, request.actor, database_name
+        )
+        if not is_view:
+            await precompute_table_action_permissions(
+                datasette, request.actor, database_name, table_name
+            )
+
     # Introspect columns and primary keys for table
     pks = await db.primary_keys(table_name)
     table_columns = await db.table_columns(table_name)
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index a0308e49..7cb4d8f0 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -367,23 +367,14 @@ class ActionsExtra(Extra):
                 # that allowed() calls made inside the plugin hooks below
                 # are served from the cache
                 datasette = context.datasette
-                await datasette.allowed_many(
-                    actions=[
-                        name
-                        for name, action in datasette.actions.items()
-                        if action.resource_class is TableResource
-                    ],
-                    resource=TableResource(context.database_name, context.table_name),
-                    actor=context.request.actor,
+                await precompute_table_action_permissions(
+                    datasette,
+                    context.request.actor,
+                    context.database_name,
+                    context.table_name,
                 )
-                await datasette.allowed_many(
-                    actions=[
-                        name
-                        for name, action in datasette.actions.items()
-                        if action.resource_class is DatabaseResource
-                    ],
-                    resource=DatabaseResource(context.database_name),
-                    actor=context.request.actor,
+                await precompute_database_action_permissions(
+                    datasette, context.request.actor, context.database_name
                 )
             for hook in method(**kwargs):
                 extra_links = await await_me_maybe(hook)
@@ -394,6 +385,32 @@ class ActionsExtra(Extra):
         return actions
 
 
+async def precompute_table_action_permissions(
+    datasette, actor, database_name, table_name
+):
+    await datasette.allowed_many(
+        actions=[
+            name
+            for name, action in datasette.actions.items()
+            if action.resource_class is TableResource
+        ],
+        resource=TableResource(database_name, table_name),
+        actor=actor,
+    )
+
+
+async def precompute_database_action_permissions(datasette, actor, database_name):
+    await datasette.allowed_many(
+        actions=[
+            name
+            for name, action in datasette.actions.items()
+            if action.resource_class is DatabaseResource
+        ],
+        resource=DatabaseResource(database_name),
+        actor=actor,
+    )
+
+
 class IsViewExtra(Extra):
     description = "Whether this resource is a view instead of a table"
     example = ExtraExample("/fixtures/simple_view.json?_extra=is_view")
diff --git a/docs/plugins.rst b/docs/plugins.rst
index c2eb282a..d2b5c20a 100644
--- a/docs/plugins.rst
+++ b/docs/plugins.rst
@@ -280,6 +280,15 @@ If you run ``datasette plugins --all`` it will include default plugins that ship
                 "query_actions"
             ]
         },
+        {
+            "name": "datasette.default_table_actions",
+            "static": false,
+            "templates": false,
+            "version": null,
+            "hooks": [
+                "table_actions"
+            ]
+        },
         {
             "name": "datasette.events",
             "static": false,
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index b7990009..70b5a8c1 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -350,7 +350,9 @@ def test_alter_table_flow(page, datasette_server):
     assert first_more_options.inner_text() == "> Advanced options"
     first_more_options.click()
     assert first_more_options.inner_text() == "v Hide options"
-    expanded_options_text = dialog.locator(".table-alter-column-details").first.inner_text()
+    expanded_options_text = dialog.locator(
+        ".table-alter-column-details"
+    ).first.inner_text()
     assert dialog.locator(".table-alter-fields").evaluate(
         "node => node.scrollWidth <= node.clientWidth + 1"
     )
@@ -500,8 +502,7 @@ def test_alter_table_cancel_skips_discard_prompt(page, datasette_server):
         return dialog
 
     page.goto(f"{datasette_server}data/projects")
-    page.evaluate(
-        """
+    page.evaluate("""
         () => {
             window.__discardConfirmMessages = [];
             window.confirm = (message) => {
@@ -509,8 +510,7 @@ def test_alter_table_cancel_skips_discard_prompt(page, datasette_server):
                 return false;
             };
         }
-        """
-    )
+        """)
 
     dialog = open_alter_dialog()
     dialog.locator(".table-alter-add-column").click()

From 8cec528eebd253994fbb41c85d571ab649d723e9 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 10:32:21 -0700
Subject: [PATCH 242/386] Test against pyodide/v314.0.0

Now that we depend on pydantic we need a more recent
pyodide in order to load the emscripten build
of pydantic-core.

Refs https://github.com/simonw/datasette/pull/2789#issuecomment-4733412763
---
 test-in-pyodide-with-shot-scraper.sh | 29 +++++++++++++---------------
 1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/test-in-pyodide-with-shot-scraper.sh b/test-in-pyodide-with-shot-scraper.sh
index 4d1c4968..8d7fa08e 100755
--- a/test-in-pyodide-with-shot-scraper.sh
+++ b/test-in-pyodide-with-shot-scraper.sh
@@ -1,40 +1,37 @@
 #!/bin/bash
-set -e
-# So the script fails if there are any errors
+set -euo pipefail
+
+read -r -a PYTHON_CMD <<< "${PYTHON:-python3}"
+read -r -a SHOT_SCRAPER_CMD <<< "${SHOT_SCRAPER:-shot-scraper}"
 
 # Build the wheel
-python3 -m build
+"${PYTHON_CMD[@]}" -m build
 
-# Find name of wheel, strip off the dist/
-wheel=$(basename $(ls dist/*.whl) | head -n 1)
+# Find name of most recently built wheel, strip off the dist/
+wheel=$(basename "$(ls -t dist/*.whl | head -n 1)")
 
 # Create a blank index page
 echo '
-<script src="https://cdn.jsdelivr.net/pyodide/v0.20.0/full/pyodide.js"></script>
+<script src="https://cdn.jsdelivr.net/pyodide/v314.0.0/full/pyodide.js"></script>
 ' > dist/index.html
 
 # Run a server for that dist/ folder
-cd dist
-python3 -m http.server 8529 &
-cd ..
+"${PYTHON_CMD[@]}" -m http.server 8529 --directory dist &
+server_pid=$!
 
 # Register the kill_server function to be called on script exit
 kill_server() {
-  pkill -f 'http.server 8529'
+  kill "$server_pid" 2>/dev/null || true
 }
 trap kill_server EXIT
 
 
-shot-scraper javascript http://localhost:8529/ "
+"${SHOT_SCRAPER_CMD[@]}" javascript http://localhost:8529/ "
 async () => {
   let pyodide = await loadPyodide();
-  await pyodide.loadPackage(['micropip', 'ssl', 'setuptools']);
+  await pyodide.loadPackage(['micropip', 'setuptools']);
   let output = await pyodide.runPythonAsync(\`
     import micropip
-    await micropip.install('h11==0.12.0')
-    await micropip.install('httpx==0.23')
-    # To avoid 'from typing_extensions import deprecated' error:
-    await micropip.install('typing-extensions>=4.12.2')
     await micropip.install('http://localhost:8529/$wheel')
     import ssl
     import setuptools

From 1972ba8952f0e10fc13054c4214df2473c448daf Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 10:54:25 -0700
Subject: [PATCH 243/386] Split table create and alter views

- Move create-table and alter-table API views into table_create_alter.py.
- Keep create and alter schema-editing constants and helpers together.
- Rename the create table modal context helper.
---
 datasette/app.py                      |   3 +-
 datasette/views/database.py           | 323 +-----------
 datasette/views/table.py              | 371 +-------------
 datasette/views/table_create_alter.py | 687 ++++++++++++++++++++++++++
 4 files changed, 699 insertions(+), 685 deletions(-)
 create mode 100644 datasette/views/table_create_alter.py

diff --git a/datasette/app.py b/datasette/app.py
index 6ea3d5a4..13e25d4e 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -47,9 +47,9 @@ from .views import Context
 from .views.database import (
     database_download,
     DatabaseView,
-    TableCreateView,
     QueryView,
 )
+from .views.table_create_alter import TableAlterView, TableCreateView
 from .views.execute_write import ExecuteWriteAnalyzeView, ExecuteWriteView
 from .views.stored_queries import (
     QueryCreateAnalyzeView,
@@ -84,7 +84,6 @@ from .views.special import (
 )
 from .views.table import (
     TableAutocompleteView,
-    TableAlterView,
     TableInsertView,
     TableUpsertView,
     TableSetColumnTypeView,
diff --git a/datasette/views/database.py b/datasette/views/database.py
index db70b135..8e9c1361 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -6,15 +6,11 @@ import itertools
 import json
 import markupsafe
 import os
-import re
-import sqlite_utils
 import textwrap
 
-from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.extras import extra_names_from_request
 from datasette.database import QueryInterrupted
-from datasette.column_types import SQLiteType
-from datasette.resources import DatabaseResource, QueryResource, TableResource
+from datasette.resources import DatabaseResource, QueryResource
 from datasette.stored_queries import stored_query_to_dict
 from datasette.write_sql import QueryWriteRejected
 from datasette.utils import (
@@ -38,27 +34,16 @@ from datasette.utils import (
 from datasette.utils.asgi import AsgiFileDownload, NotFound, Response, Forbidden
 from datasette.plugins import pm
 
-from .base import BaseView, DatasetteError, View, _error, stream_csv
+from .base import DatasetteError, View, stream_csv
 from .query_helpers import _ensure_stored_query_execution_permissions, _table_columns
 from .table_extras import (
     QueryExtraContext,
     resolve_query_extras,
     table_extra_registry,
 )
+from .table_create_alter import _create_table_ui_context
 from . import Context
 
-CREATE_TABLE_COLUMN_TYPES = ["text", "integer", "float", "blob"]
-CREATE_TABLE_SQLITE_TYPES = {
-    "text": SQLiteType.TEXT,
-    "integer": SQLiteType.INTEGER,
-    "float": SQLiteType.REAL,
-    "blob": SQLiteType.BLOB,
-}
-CREATE_TABLE_TYPE_FOR_SQLITE_TYPE = {
-    sqlite_type: column_type
-    for column_type, sqlite_type in CREATE_TABLE_SQLITE_TYPES.items()
-}
-
 
 class DatabaseView(View):
     async def get(self, request, datasette):
@@ -142,7 +127,7 @@ class DatabaseView(View):
             resource=DatabaseResource(database),
             actor=request.actor,
         )
-        create_table_ui = await _database_create_table_ui(
+        create_table_ui = await _create_table_ui_context(
             datasette, request, db, database, database_action_permissions
         )
 
@@ -326,57 +311,6 @@ class DatabaseContext(Context):
     )
 
 
-async def _database_create_table_ui(
-    datasette, request, db, database_name, database_action_permissions
-):
-    if not db.is_mutable:
-        return None
-    if not database_action_permissions.get("create-table"):
-        return None
-    data = {
-        "path": "{}/-/create".format(datasette.urls.database(database_name)),
-        "databaseName": database_name,
-        "columnTypes": CREATE_TABLE_COLUMN_TYPES,
-    }
-    can_set_column_type = await datasette.allowed(
-        action="set-column-type",
-        resource=TableResource(database=database_name, table="__new_table__"),
-        actor=request.actor,
-    )
-    if can_set_column_type:
-        data["customColumnTypes"] = _custom_column_type_options_for_create_table(
-            datasette
-        )
-    return data
-
-
-def _custom_column_type_options_for_create_table(datasette):
-    options = []
-    for name, ct_cls in sorted(datasette._column_types.items()):
-        sqlite_types = getattr(ct_cls, "sqlite_types", None)
-        if sqlite_types is None:
-            option_sqlite_types = CREATE_TABLE_COLUMN_TYPES[:]
-        else:
-            option_sqlite_types = [
-                create_table_type
-                for create_table_type, sqlite_type in CREATE_TABLE_SQLITE_TYPES.items()
-                if sqlite_type in sqlite_types
-            ]
-        if not option_sqlite_types:
-            continue
-        option = {
-            "name": name,
-            "description": ct_cls.description,
-            "sqliteTypes": option_sqlite_types,
-        }
-        if sqlite_types is not None and len(sqlite_types) == 1:
-            fixed_sqlite_type = CREATE_TABLE_TYPE_FOR_SQLITE_TYPE.get(sqlite_types[0])
-            if fixed_sqlite_type is not None:
-                option["fixedSqliteType"] = fixed_sqlite_type
-        options.append(option)
-    return options
-
-
 @dataclass
 class QueryContext(Context):
     database: str = field(metadata={"help": "The name of the database being queried"})
@@ -1140,255 +1074,6 @@ class MagicParameters(dict):
             return super().__getitem__(key)
 
 
-class TableCreateView(BaseView):
-    name = "table-create"
-
-    _valid_keys = {
-        "table",
-        "rows",
-        "row",
-        "columns",
-        "pk",
-        "pks",
-        "ignore",
-        "replace",
-        "alter",
-    }
-    _supported_column_types = set(CREATE_TABLE_COLUMN_TYPES)
-    # Any string that does not contain a newline or start with sqlite_
-    _table_name_re = re.compile(r"^(?!sqlite_)[^\n]+$")
-
-    def __init__(self, datasette):
-        self.ds = datasette
-
-    async def post(self, request):
-        db = await self.ds.resolve_database(request)
-        database_name = db.name
-
-        # Must have create-table permission
-        if not await self.ds.allowed(
-            action="create-table",
-            resource=DatabaseResource(database=database_name),
-            actor=request.actor,
-        ):
-            return _error(["Permission denied"], 403)
-
-        try:
-            data = await request.json()
-        except json.JSONDecodeError as e:
-            return _error(["Invalid JSON: {}".format(e)])
-
-        if not isinstance(data, dict):
-            return _error(["JSON must be an object"])
-
-        invalid_keys = set(data.keys()) - self._valid_keys
-        if invalid_keys:
-            return _error(["Invalid keys: {}".format(", ".join(invalid_keys))])
-
-        # ignore and replace are mutually exclusive
-        if data.get("ignore") and data.get("replace"):
-            return _error(["ignore and replace are mutually exclusive"])
-
-        # ignore and replace only allowed with row or rows
-        if "ignore" in data or "replace" in data:
-            if not data.get("row") and not data.get("rows"):
-                return _error(["ignore and replace require row or rows"])
-
-        # ignore and replace require pk or pks
-        if "ignore" in data or "replace" in data:
-            if not data.get("pk") and not data.get("pks"):
-                return _error(["ignore and replace require pk or pks"])
-
-        ignore = data.get("ignore")
-        replace = data.get("replace")
-
-        if replace:
-            # Must have update-row permission
-            if not await self.ds.allowed(
-                action="update-row",
-                resource=DatabaseResource(database=database_name),
-                actor=request.actor,
-            ):
-                return _error(["Permission denied: need update-row"], 403)
-
-        table_name = data.get("table")
-        if not table_name:
-            return _error(["Table is required"])
-
-        if not self._table_name_re.match(table_name):
-            return _error(["Invalid table name"])
-
-        table_exists = await db.table_exists(data["table"])
-        columns = data.get("columns")
-        rows = data.get("rows")
-        row = data.get("row")
-        if not columns and not rows and not row:
-            return _error(["columns, rows or row is required"])
-
-        if rows and row:
-            return _error(["Cannot specify both rows and row"])
-
-        if rows or row:
-            # Must have insert-row permission
-            if not await self.ds.allowed(
-                action="insert-row",
-                resource=DatabaseResource(database=database_name),
-                actor=request.actor,
-            ):
-                return _error(["Permission denied: need insert-row"], 403)
-
-        alter = False
-        if rows or row:
-            if not table_exists:
-                # if table is being created for the first time, alter=True
-                alter = True
-            else:
-                # alter=True only if they request it AND they have permission
-                if data.get("alter"):
-                    if not await self.ds.allowed(
-                        action="alter-table",
-                        resource=DatabaseResource(database=database_name),
-                        actor=request.actor,
-                    ):
-                        return _error(["Permission denied: need alter-table"], 403)
-                    alter = True
-
-        if columns:
-            if rows or row:
-                return _error(["Cannot specify columns with rows or row"])
-            if not isinstance(columns, list):
-                return _error(["columns must be a list"])
-            for column in columns:
-                if not isinstance(column, dict):
-                    return _error(["columns must be a list of objects"])
-                if not column.get("name") or not isinstance(column.get("name"), str):
-                    return _error(["Column name is required"])
-                if not column.get("type"):
-                    column["type"] = "text"
-                if column["type"] not in self._supported_column_types:
-                    return _error(
-                        ["Unsupported column type: {}".format(column["type"])]
-                    )
-            # No duplicate column names
-            dupes = {c["name"] for c in columns if columns.count(c) > 1}
-            if dupes:
-                return _error(["Duplicate column name: {}".format(", ".join(dupes))])
-
-        if row:
-            rows = [row]
-
-        if rows:
-            if not isinstance(rows, list):
-                return _error(["rows must be a list"])
-            for row in rows:
-                if not isinstance(row, dict):
-                    return _error(["rows must be a list of objects"])
-
-        pk = data.get("pk")
-        pks = data.get("pks")
-
-        if pk and pks:
-            return _error(["Cannot specify both pk and pks"])
-        if pk:
-            if not isinstance(pk, str):
-                return _error(["pk must be a string"])
-        if pks:
-            if not isinstance(pks, list):
-                return _error(["pks must be a list"])
-            for pk in pks:
-                if not isinstance(pk, str):
-                    return _error(["pks must be a list of strings"])
-
-        # If table exists already, read pks from that instead
-        if table_exists:
-            actual_pks = await db.primary_keys(table_name)
-            # if pk passed and table already exists check it does not change
-            bad_pks = False
-            if len(actual_pks) == 1 and data.get("pk") and data["pk"] != actual_pks[0]:
-                bad_pks = True
-            elif (
-                len(actual_pks) > 1
-                and data.get("pks")
-                and set(data["pks"]) != set(actual_pks)
-            ):
-                bad_pks = True
-            if bad_pks:
-                return _error(["pk cannot be changed for existing table"])
-            pks = actual_pks
-
-        initial_schema = None
-        if table_exists:
-            initial_schema = await db.execute_fn(
-                lambda conn: sqlite_utils.Database(conn)[table_name].schema
-            )
-
-        def create_table(conn):
-            table = sqlite_utils.Database(conn)[table_name]
-            if rows:
-                table.insert_all(
-                    rows, pk=pks or pk, ignore=ignore, replace=replace, alter=alter
-                )
-            else:
-                table.create(
-                    {c["name"]: c["type"] for c in columns},
-                    pk=pks or pk,
-                )
-            return table.schema
-
-        try:
-            schema = await db.execute_write_fn(create_table, request=request)
-        except Exception as e:
-            return _error([str(e)])
-
-        if initial_schema is not None and initial_schema != schema:
-            await self.ds.track_event(
-                AlterTableEvent(
-                    request.actor,
-                    database=database_name,
-                    table=table_name,
-                    before_schema=initial_schema,
-                    after_schema=schema,
-                )
-            )
-
-        table_url = self.ds.absolute_url(
-            request, self.ds.urls.table(db.name, table_name)
-        )
-        table_api_url = self.ds.absolute_url(
-            request, self.ds.urls.table(db.name, table_name, format="json")
-        )
-        details = {
-            "ok": True,
-            "database": db.name,
-            "table": table_name,
-            "table_url": table_url,
-            "table_api_url": table_api_url,
-            "schema": schema,
-        }
-        if rows:
-            details["row_count"] = len(rows)
-
-        if not table_exists:
-            # Only log creation if we created a table
-            await self.ds.track_event(
-                CreateTableEvent(
-                    request.actor, database=db.name, table=table_name, schema=schema
-                )
-            )
-        if rows:
-            await self.ds.track_event(
-                InsertRowsEvent(
-                    request.actor,
-                    database=db.name,
-                    table=table_name,
-                    num_rows=len(rows),
-                    ignore=ignore,
-                    replace=replace,
-                )
-            )
-        return Response.json(details, status=201)
-
-
 async def display_rows(datasette, database, request, rows, columns):
     display_rows = []
     truncate_cells = datasette.setting("truncate_cells_html")
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 82c7e03d..6c0d2914 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1,12 +1,10 @@
 import asyncio
 import itertools
 import json
-from typing import Annotated, Any, Literal, Union
 import urllib
 import urllib.parse
 
 import markupsafe
-from pydantic import BaseModel, ConfigDict, Field, ValidationError, model_validator
 
 from datasette.column_types import SQLiteType
 from datasette.extras import extra_names_from_request
@@ -48,9 +46,14 @@ from datasette.utils import (
 from datasette.utils.asgi import BadRequest, Forbidden, NotFound, Request, Response
 from datasette.filters import Filters
 import sqlite_utils
-from sqlite_utils.db import DEFAULT as SQLITE_UTILS_DEFAULT
 from .base import BaseView, DatasetteError, _error, stream_csv
-from .database import QueryView, _custom_column_type_options_for_create_table
+from .database import QueryView
+from .table_create_alter import (
+    ALTER_TABLE_COLUMN_TYPES,
+    ALTER_TABLE_TYPE_FOR_SQLITE_TYPE,
+    DEFAULT_EXPR_SQL,
+    _custom_column_type_options_for_create_table,
+)
 from .table_extras import (
     TABLE_EXTRA_BUNDLES,
     TableExtraContext,
@@ -64,13 +67,6 @@ LINK_WITH_LABEL = (
     '<a href="{base_url}{database}/{table}/{link_id}">{label}</a>&nbsp;<em>{id}</em>'
 )
 LINK_WITH_VALUE = '<a href="{base_url}{database}/{table}/{link_id}">{id}</a>'
-ALTER_TABLE_COLUMN_TYPES = ["text", "integer", "float", "blob"]
-ALTER_TABLE_TYPE_FOR_SQLITE_TYPE = {
-    SQLiteType.TEXT: "text",
-    SQLiteType.INTEGER: "integer",
-    SQLiteType.REAL: "float",
-    SQLiteType.BLOB: "blob",
-}
 
 
 class Row:
@@ -727,154 +723,6 @@ async def display_columns_and_rows(
     return columns, cell_rows
 
 
-SqliteApiType = Literal["text", "integer", "float", "blob"]
-DefaultExpr = Literal["current_timestamp", "current_date", "current_time"]
-DEFAULT_EXPR_SQL = {
-    "current_timestamp": "CURRENT_TIMESTAMP",
-    "current_date": "CURRENT_DATE",
-    "current_time": "CURRENT_TIME",
-}
-
-
-class _StrictPydanticModel(BaseModel):
-    model_config = ConfigDict(extra="forbid")
-
-
-class _DefaultArgsMixin(_StrictPydanticModel):
-    default: Any | None = None
-    default_expr: DefaultExpr | None = None
-
-    @model_validator(mode="after")
-    def validate_default_fields(self):
-        has_default = "default" in self.model_fields_set
-        has_default_expr = "default_expr" in self.model_fields_set
-        if has_default and has_default_expr:
-            raise ValueError("default and default_expr cannot both be provided")
-        if has_default_expr and self.default_expr is None:
-            raise ValueError("default_expr cannot be null")
-        return self
-
-
-class AddColumnArgs(_DefaultArgsMixin):
-    name: str
-    type: SqliteApiType = "text"
-    not_null: bool = False
-
-
-class RenameColumnArgs(_StrictPydanticModel):
-    name: str
-    to: str
-
-
-class AlterColumnArgs(_DefaultArgsMixin):
-    name: str
-    type: SqliteApiType | None = None
-    not_null: bool | None = None
-
-    @model_validator(mode="after")
-    def require_change(self):
-        if not (
-            {"type", "not_null", "default", "default_expr"} & self.model_fields_set
-        ):
-            raise ValueError(
-                "At least one of type, not_null, default or default_expr must be provided"
-            )
-        return self
-
-
-class DropColumnArgs(_StrictPydanticModel):
-    name: str
-
-
-class SetPrimaryKeyArgs(_StrictPydanticModel):
-    columns: list[str] = Field(min_length=1)
-
-
-class ReorderColumnsArgs(_StrictPydanticModel):
-    columns: list[str] = Field(min_length=1)
-
-
-class AddColumnOperation(_StrictPydanticModel):
-    op: Literal["add_column"]
-    args: AddColumnArgs
-
-
-class RenameColumnOperation(_StrictPydanticModel):
-    op: Literal["rename_column"]
-    args: RenameColumnArgs
-
-
-class AlterColumnOperation(_StrictPydanticModel):
-    op: Literal["alter_column"]
-    args: AlterColumnArgs
-
-
-class DropColumnOperation(_StrictPydanticModel):
-    op: Literal["drop_column"]
-    args: DropColumnArgs
-
-
-class SetPrimaryKeyOperation(_StrictPydanticModel):
-    op: Literal["set_primary_key"]
-    args: SetPrimaryKeyArgs
-
-
-class ReorderColumnsOperation(_StrictPydanticModel):
-    op: Literal["reorder_columns"]
-    args: ReorderColumnsArgs
-
-
-AlterTableOperation = Annotated[
-    Union[
-        AddColumnOperation,
-        RenameColumnOperation,
-        AlterColumnOperation,
-        DropColumnOperation,
-        SetPrimaryKeyOperation,
-        ReorderColumnsOperation,
-    ],
-    Field(discriminator="op"),
-]
-
-
-class AlterTableRequest(_StrictPydanticModel):
-    operations: list[AlterTableOperation] = Field(min_length=1)
-    dry_run: bool = False
-
-
-def _pydantic_errors(validation_error):
-    errors = []
-    for error in validation_error.errors():
-        location = ".".join(str(item) for item in error["loc"])
-        message = error["msg"]
-        errors.append("{}: {}".format(location, message) if location else message)
-    return errors
-
-
-def _table_schema_from_conn(conn, table_name):
-    row = conn.execute(
-        "select sql from sqlite_master where type = 'table' and name = ?",
-        [table_name],
-    ).fetchone()
-    return row[0] if row else None
-
-
-def _primary_key_value(columns):
-    if len(columns) == 1:
-        return columns[0]
-    return tuple(columns)
-
-
-def _default_expression_sql(default_expr):
-    return DEFAULT_EXPR_SQL[default_expr]
-
-
-def _literal_default(db, value):
-    if isinstance(value, str):
-        return db.quote(value)
-    return value
-
-
 class TableInsertView(BaseView):
     name = "table-insert"
 
@@ -1172,211 +1020,6 @@ class TableUpsertView(TableInsertView):
         return await super().post(request, upsert=True)
 
 
-class TableAlterView(BaseView):
-    name = "table-alter"
-
-    def __init__(self, datasette):
-        self.ds = datasette
-
-    async def post(self, request):
-        try:
-            resolved = await self.ds.resolve_table(request)
-        except NotFound as e:
-            return _error([e.args[0]], 404)
-
-        db = resolved.db
-        database_name = db.name
-        table_name = resolved.table
-
-        if not await self.ds.allowed(
-            action="alter-table",
-            resource=TableResource(database=database_name, table=table_name),
-            actor=request.actor,
-        ):
-            return _error(["Permission denied: need alter-table"], 403)
-
-        if not db.is_mutable:
-            return _error(["Database is immutable"], 403)
-
-        content_type = request.headers.get("content-type") or ""
-        if not content_type.startswith("application/json"):
-            return _error(["Invalid content-type, must be application/json"], 400)
-
-        try:
-            data = await request.json()
-        except json.JSONDecodeError as e:
-            return _error(["Invalid JSON: {}".format(e)], 400)
-
-        if not isinstance(data, dict):
-            return _error(["JSON must be a dictionary"], 400)
-
-        try:
-            alter_request = AlterTableRequest.model_validate(data)
-        except ValidationError as e:
-            return _error(_pydantic_errors(e), 400)
-
-        def alter_table(conn):
-            before_schema = _table_schema_from_conn(conn, table_name)
-
-            def apply_operations(operation_conn):
-                db_for_write = sqlite_utils.Database(operation_conn)
-                table = db_for_write[table_name]
-
-                add_columns = []
-                types = {}
-                rename = {}
-                drop = set()
-                not_null = {}
-                defaults = {}
-                column_order = None
-                pk = SQLITE_UTILS_DEFAULT
-
-                for operation in alter_request.operations:
-                    args = operation.args
-                    if operation.op == "add_column":
-                        if args.not_null and not (
-                            (
-                                "default" in args.model_fields_set
-                                and args.default is not None
-                            )
-                            or "default_expr" in args.model_fields_set
-                        ):
-                            raise ValueError(
-                                "add_column args.default or args.default_expr is required when not_null is true"
-                            )
-                        add_columns.append(args)
-                        if "default" in args.model_fields_set and not args.not_null:
-                            defaults[args.name] = _literal_default(
-                                db_for_write, args.default
-                            )
-                        if (
-                            "default_expr" in args.model_fields_set
-                            and not args.not_null
-                        ):
-                            defaults[args.name] = _default_expression_sql(
-                                args.default_expr
-                            )
-                    elif operation.op == "rename_column":
-                        rename[args.name] = args.to
-                    elif operation.op == "alter_column":
-                        if args.type is not None:
-                            types[args.name] = args.type
-                        if args.not_null is not None:
-                            not_null[args.name] = args.not_null
-                        if "default" in args.model_fields_set:
-                            defaults[args.name] = (
-                                None
-                                if args.default is None
-                                else _literal_default(db_for_write, args.default)
-                            )
-                        if "default_expr" in args.model_fields_set:
-                            defaults[args.name] = _default_expression_sql(
-                                args.default_expr
-                            )
-                    elif operation.op == "drop_column":
-                        drop.add(args.name)
-                    elif operation.op == "set_primary_key":
-                        pk = _primary_key_value(args.columns)
-                    elif operation.op == "reorder_columns":
-                        column_order = args.columns
-
-                with operation_conn:
-                    for column in add_columns:
-                        not_null_default = None
-                        if column.not_null:
-                            if "default_expr" in column.model_fields_set:
-                                not_null_default = _default_expression_sql(
-                                    column.default_expr
-                                )
-                            else:
-                                not_null_default = _literal_default(
-                                    db_for_write, column.default
-                                )
-                        table.add_column(
-                            column.name,
-                            column.type,
-                            not_null_default=not_null_default,
-                        )
-
-                    should_transform = any(
-                        (
-                            types,
-                            rename,
-                            drop,
-                            not_null,
-                            defaults,
-                            column_order is not None,
-                            pk is not SQLITE_UTILS_DEFAULT,
-                        )
-                    )
-                    if should_transform:
-                        table.transform(
-                            types=types or None,
-                            rename=rename or None,
-                            drop=drop or None,
-                            pk=pk,
-                            not_null=not_null or None,
-                            defaults=defaults or None,
-                            column_order=column_order,
-                        )
-
-                return _table_schema_from_conn(operation_conn, table_name)
-
-            if alter_request.dry_run:
-                memory_conn = sqlite3.connect(":memory:")
-                try:
-                    conn.backup(memory_conn)
-                    return before_schema, apply_operations(memory_conn)
-                finally:
-                    memory_conn.close()
-
-            after_schema = apply_operations(conn)
-            return before_schema, after_schema
-
-        try:
-            before_schema, after_schema = await db.execute_write_fn(
-                alter_table, request=request
-            )
-        except Exception as e:
-            return _error([str(e)], 400)
-
-        altered = before_schema != after_schema
-        if altered and not alter_request.dry_run:
-            await self.ds.track_event(
-                AlterTableEvent(
-                    request.actor,
-                    database=database_name,
-                    table=table_name,
-                    before_schema=before_schema,
-                    after_schema=after_schema,
-                )
-            )
-
-        table_url = self.ds.absolute_url(
-            request, self.ds.urls.table(database_name, table_name)
-        )
-        table_api_url = self.ds.absolute_url(
-            request, self.ds.urls.table(database_name, table_name, format="json")
-        )
-        return Response.json(
-            {
-                "ok": True,
-                "database": database_name,
-                "table": table_name,
-                "table_url": table_url,
-                "table_api_url": table_api_url,
-                "altered": altered,
-                "schema": after_schema,
-                "before_schema": before_schema,
-                "operations_applied": (
-                    0 if alter_request.dry_run else len(alter_request.operations)
-                ),
-                "dry_run": alter_request.dry_run,
-            },
-            status=200,
-        )
-
-
 class TableSetColumnTypeView(BaseView):
     name = "table-set-column-type"
 
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
new file mode 100644
index 00000000..7decfad2
--- /dev/null
+++ b/datasette/views/table_create_alter.py
@@ -0,0 +1,687 @@
+import json
+import re
+from typing import Annotated, Any, Literal, Union
+
+from pydantic import BaseModel, ConfigDict, Field, ValidationError, model_validator
+import sqlite_utils
+from sqlite_utils.db import DEFAULT as SQLITE_UTILS_DEFAULT
+
+from datasette.column_types import SQLiteType
+from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
+from datasette.resources import DatabaseResource, TableResource
+from datasette.utils import sqlite3
+from datasette.utils.asgi import NotFound, Response
+
+from .base import BaseView, _error
+
+CREATE_TABLE_COLUMN_TYPES = ["text", "integer", "float", "blob"]
+CREATE_TABLE_SQLITE_TYPES = {
+    "text": SQLiteType.TEXT,
+    "integer": SQLiteType.INTEGER,
+    "float": SQLiteType.REAL,
+    "blob": SQLiteType.BLOB,
+}
+CREATE_TABLE_TYPE_FOR_SQLITE_TYPE = {
+    sqlite_type: column_type
+    for column_type, sqlite_type in CREATE_TABLE_SQLITE_TYPES.items()
+}
+ALTER_TABLE_COLUMN_TYPES = CREATE_TABLE_COLUMN_TYPES
+ALTER_TABLE_TYPE_FOR_SQLITE_TYPE = {
+    SQLiteType.TEXT: "text",
+    SQLiteType.INTEGER: "integer",
+    SQLiteType.REAL: "float",
+    SQLiteType.BLOB: "blob",
+}
+
+
+async def _create_table_ui_context(
+    datasette, request, db, database_name, database_action_permissions
+):
+    if not db.is_mutable:
+        return None
+    if not database_action_permissions.get("create-table"):
+        return None
+    data = {
+        "path": "{}/-/create".format(datasette.urls.database(database_name)),
+        "databaseName": database_name,
+        "columnTypes": CREATE_TABLE_COLUMN_TYPES,
+    }
+    can_set_column_type = await datasette.allowed(
+        action="set-column-type",
+        resource=TableResource(database=database_name, table="__new_table__"),
+        actor=request.actor,
+    )
+    if can_set_column_type:
+        data["customColumnTypes"] = _custom_column_type_options_for_create_table(
+            datasette
+        )
+    return data
+
+
+def _custom_column_type_options_for_create_table(datasette):
+    options = []
+    for name, ct_cls in sorted(datasette._column_types.items()):
+        sqlite_types = getattr(ct_cls, "sqlite_types", None)
+        if sqlite_types is None:
+            option_sqlite_types = CREATE_TABLE_COLUMN_TYPES[:]
+        else:
+            option_sqlite_types = [
+                create_table_type
+                for create_table_type, sqlite_type in CREATE_TABLE_SQLITE_TYPES.items()
+                if sqlite_type in sqlite_types
+            ]
+        if not option_sqlite_types:
+            continue
+        option = {
+            "name": name,
+            "description": ct_cls.description,
+            "sqliteTypes": option_sqlite_types,
+        }
+        if sqlite_types is not None and len(sqlite_types) == 1:
+            fixed_sqlite_type = CREATE_TABLE_TYPE_FOR_SQLITE_TYPE.get(sqlite_types[0])
+            if fixed_sqlite_type is not None:
+                option["fixedSqliteType"] = fixed_sqlite_type
+        options.append(option)
+    return options
+
+
+SqliteApiType = Literal["text", "integer", "float", "blob"]
+DefaultExpr = Literal["current_timestamp", "current_date", "current_time"]
+DEFAULT_EXPR_SQL = {
+    "current_timestamp": "CURRENT_TIMESTAMP",
+    "current_date": "CURRENT_DATE",
+    "current_time": "CURRENT_TIME",
+}
+
+
+class _StrictPydanticModel(BaseModel):
+    model_config = ConfigDict(extra="forbid")
+
+
+class _DefaultArgsMixin(_StrictPydanticModel):
+    default: Any | None = None
+    default_expr: DefaultExpr | None = None
+
+    @model_validator(mode="after")
+    def validate_default_fields(self):
+        has_default = "default" in self.model_fields_set
+        has_default_expr = "default_expr" in self.model_fields_set
+        if has_default and has_default_expr:
+            raise ValueError("default and default_expr cannot both be provided")
+        if has_default_expr and self.default_expr is None:
+            raise ValueError("default_expr cannot be null")
+        return self
+
+
+class AddColumnArgs(_DefaultArgsMixin):
+    name: str
+    type: SqliteApiType = "text"
+    not_null: bool = False
+
+
+class RenameColumnArgs(_StrictPydanticModel):
+    name: str
+    to: str
+
+
+class AlterColumnArgs(_DefaultArgsMixin):
+    name: str
+    type: SqliteApiType | None = None
+    not_null: bool | None = None
+
+    @model_validator(mode="after")
+    def require_change(self):
+        if not (
+            {"type", "not_null", "default", "default_expr"} & self.model_fields_set
+        ):
+            raise ValueError(
+                "At least one of type, not_null, default or default_expr must be provided"
+            )
+        return self
+
+
+class DropColumnArgs(_StrictPydanticModel):
+    name: str
+
+
+class SetPrimaryKeyArgs(_StrictPydanticModel):
+    columns: list[str] = Field(min_length=1)
+
+
+class ReorderColumnsArgs(_StrictPydanticModel):
+    columns: list[str] = Field(min_length=1)
+
+
+class AddColumnOperation(_StrictPydanticModel):
+    op: Literal["add_column"]
+    args: AddColumnArgs
+
+
+class RenameColumnOperation(_StrictPydanticModel):
+    op: Literal["rename_column"]
+    args: RenameColumnArgs
+
+
+class AlterColumnOperation(_StrictPydanticModel):
+    op: Literal["alter_column"]
+    args: AlterColumnArgs
+
+
+class DropColumnOperation(_StrictPydanticModel):
+    op: Literal["drop_column"]
+    args: DropColumnArgs
+
+
+class SetPrimaryKeyOperation(_StrictPydanticModel):
+    op: Literal["set_primary_key"]
+    args: SetPrimaryKeyArgs
+
+
+class ReorderColumnsOperation(_StrictPydanticModel):
+    op: Literal["reorder_columns"]
+    args: ReorderColumnsArgs
+
+
+AlterTableOperation = Annotated[
+    Union[
+        AddColumnOperation,
+        RenameColumnOperation,
+        AlterColumnOperation,
+        DropColumnOperation,
+        SetPrimaryKeyOperation,
+        ReorderColumnsOperation,
+    ],
+    Field(discriminator="op"),
+]
+
+
+class AlterTableRequest(_StrictPydanticModel):
+    operations: list[AlterTableOperation] = Field(min_length=1)
+    dry_run: bool = False
+
+
+def _pydantic_errors(validation_error):
+    errors = []
+    for error in validation_error.errors():
+        location = ".".join(str(item) for item in error["loc"])
+        message = error["msg"]
+        errors.append("{}: {}".format(location, message) if location else message)
+    return errors
+
+
+def _table_schema_from_conn(conn, table_name):
+    row = conn.execute(
+        "select sql from sqlite_master where type = 'table' and name = ?",
+        [table_name],
+    ).fetchone()
+    return row[0] if row else None
+
+
+def _primary_key_value(columns):
+    if len(columns) == 1:
+        return columns[0]
+    return tuple(columns)
+
+
+def _default_expression_sql(default_expr):
+    return DEFAULT_EXPR_SQL[default_expr]
+
+
+def _literal_default(db, value):
+    if isinstance(value, str):
+        return db.quote(value)
+    return value
+
+
+class TableCreateView(BaseView):
+    name = "table-create"
+
+    _valid_keys = {
+        "table",
+        "rows",
+        "row",
+        "columns",
+        "pk",
+        "pks",
+        "ignore",
+        "replace",
+        "alter",
+    }
+    _supported_column_types = set(CREATE_TABLE_COLUMN_TYPES)
+    # Any string that does not contain a newline or start with sqlite_
+    _table_name_re = re.compile(r"^(?!sqlite_)[^\n]+$")
+
+    def __init__(self, datasette):
+        self.ds = datasette
+
+    async def post(self, request):
+        db = await self.ds.resolve_database(request)
+        database_name = db.name
+
+        # Must have create-table permission
+        if not await self.ds.allowed(
+            action="create-table",
+            resource=DatabaseResource(database=database_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied"], 403)
+
+        try:
+            data = await request.json()
+        except json.JSONDecodeError as e:
+            return _error(["Invalid JSON: {}".format(e)])
+
+        if not isinstance(data, dict):
+            return _error(["JSON must be an object"])
+
+        invalid_keys = set(data.keys()) - self._valid_keys
+        if invalid_keys:
+            return _error(["Invalid keys: {}".format(", ".join(invalid_keys))])
+
+        # ignore and replace are mutually exclusive
+        if data.get("ignore") and data.get("replace"):
+            return _error(["ignore and replace are mutually exclusive"])
+
+        # ignore and replace only allowed with row or rows
+        if "ignore" in data or "replace" in data:
+            if not data.get("row") and not data.get("rows"):
+                return _error(["ignore and replace require row or rows"])
+
+        # ignore and replace require pk or pks
+        if "ignore" in data or "replace" in data:
+            if not data.get("pk") and not data.get("pks"):
+                return _error(["ignore and replace require pk or pks"])
+
+        ignore = data.get("ignore")
+        replace = data.get("replace")
+
+        if replace:
+            # Must have update-row permission
+            if not await self.ds.allowed(
+                action="update-row",
+                resource=DatabaseResource(database=database_name),
+                actor=request.actor,
+            ):
+                return _error(["Permission denied: need update-row"], 403)
+
+        table_name = data.get("table")
+        if not table_name:
+            return _error(["Table is required"])
+
+        if not self._table_name_re.match(table_name):
+            return _error(["Invalid table name"])
+
+        table_exists = await db.table_exists(data["table"])
+        columns = data.get("columns")
+        rows = data.get("rows")
+        row = data.get("row")
+        if not columns and not rows and not row:
+            return _error(["columns, rows or row is required"])
+
+        if rows and row:
+            return _error(["Cannot specify both rows and row"])
+
+        if rows or row:
+            # Must have insert-row permission
+            if not await self.ds.allowed(
+                action="insert-row",
+                resource=DatabaseResource(database=database_name),
+                actor=request.actor,
+            ):
+                return _error(["Permission denied: need insert-row"], 403)
+
+        alter = False
+        if rows or row:
+            if not table_exists:
+                # if table is being created for the first time, alter=True
+                alter = True
+            else:
+                # alter=True only if they request it AND they have permission
+                if data.get("alter"):
+                    if not await self.ds.allowed(
+                        action="alter-table",
+                        resource=DatabaseResource(database=database_name),
+                        actor=request.actor,
+                    ):
+                        return _error(["Permission denied: need alter-table"], 403)
+                    alter = True
+
+        if columns:
+            if rows or row:
+                return _error(["Cannot specify columns with rows or row"])
+            if not isinstance(columns, list):
+                return _error(["columns must be a list"])
+            for column in columns:
+                if not isinstance(column, dict):
+                    return _error(["columns must be a list of objects"])
+                if not column.get("name") or not isinstance(column.get("name"), str):
+                    return _error(["Column name is required"])
+                if not column.get("type"):
+                    column["type"] = "text"
+                if column["type"] not in self._supported_column_types:
+                    return _error(
+                        ["Unsupported column type: {}".format(column["type"])]
+                    )
+            # No duplicate column names
+            dupes = {c["name"] for c in columns if columns.count(c) > 1}
+            if dupes:
+                return _error(["Duplicate column name: {}".format(", ".join(dupes))])
+
+        if row:
+            rows = [row]
+
+        if rows:
+            if not isinstance(rows, list):
+                return _error(["rows must be a list"])
+            for row in rows:
+                if not isinstance(row, dict):
+                    return _error(["rows must be a list of objects"])
+
+        pk = data.get("pk")
+        pks = data.get("pks")
+
+        if pk and pks:
+            return _error(["Cannot specify both pk and pks"])
+        if pk:
+            if not isinstance(pk, str):
+                return _error(["pk must be a string"])
+        if pks:
+            if not isinstance(pks, list):
+                return _error(["pks must be a list"])
+            for pk in pks:
+                if not isinstance(pk, str):
+                    return _error(["pks must be a list of strings"])
+
+        # If table exists already, read pks from that instead
+        if table_exists:
+            actual_pks = await db.primary_keys(table_name)
+            # if pk passed and table already exists check it does not change
+            bad_pks = False
+            if len(actual_pks) == 1 and data.get("pk") and data["pk"] != actual_pks[0]:
+                bad_pks = True
+            elif (
+                len(actual_pks) > 1
+                and data.get("pks")
+                and set(data["pks"]) != set(actual_pks)
+            ):
+                bad_pks = True
+            if bad_pks:
+                return _error(["pk cannot be changed for existing table"])
+            pks = actual_pks
+
+        initial_schema = None
+        if table_exists:
+            initial_schema = await db.execute_fn(
+                lambda conn: sqlite_utils.Database(conn)[table_name].schema
+            )
+
+        def create_table(conn):
+            table = sqlite_utils.Database(conn)[table_name]
+            if rows:
+                table.insert_all(
+                    rows, pk=pks or pk, ignore=ignore, replace=replace, alter=alter
+                )
+            else:
+                table.create(
+                    {c["name"]: c["type"] for c in columns},
+                    pk=pks or pk,
+                )
+            return table.schema
+
+        try:
+            schema = await db.execute_write_fn(create_table, request=request)
+        except Exception as e:
+            return _error([str(e)])
+
+        if initial_schema is not None and initial_schema != schema:
+            await self.ds.track_event(
+                AlterTableEvent(
+                    request.actor,
+                    database=database_name,
+                    table=table_name,
+                    before_schema=initial_schema,
+                    after_schema=schema,
+                )
+            )
+
+        table_url = self.ds.absolute_url(
+            request, self.ds.urls.table(db.name, table_name)
+        )
+        table_api_url = self.ds.absolute_url(
+            request, self.ds.urls.table(db.name, table_name, format="json")
+        )
+        details = {
+            "ok": True,
+            "database": db.name,
+            "table": table_name,
+            "table_url": table_url,
+            "table_api_url": table_api_url,
+            "schema": schema,
+        }
+        if rows:
+            details["row_count"] = len(rows)
+
+        if not table_exists:
+            # Only log creation if we created a table
+            await self.ds.track_event(
+                CreateTableEvent(
+                    request.actor, database=db.name, table=table_name, schema=schema
+                )
+            )
+        if rows:
+            await self.ds.track_event(
+                InsertRowsEvent(
+                    request.actor,
+                    database=db.name,
+                    table=table_name,
+                    num_rows=len(rows),
+                    ignore=ignore,
+                    replace=replace,
+                )
+            )
+        return Response.json(details, status=201)
+
+
+class TableAlterView(BaseView):
+    name = "table-alter"
+
+    def __init__(self, datasette):
+        self.ds = datasette
+
+    async def post(self, request):
+        try:
+            resolved = await self.ds.resolve_table(request)
+        except NotFound as e:
+            return _error([e.args[0]], 404)
+
+        db = resolved.db
+        database_name = db.name
+        table_name = resolved.table
+
+        if not await self.ds.allowed(
+            action="alter-table",
+            resource=TableResource(database=database_name, table=table_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need alter-table"], 403)
+
+        if not db.is_mutable:
+            return _error(["Database is immutable"], 403)
+
+        content_type = request.headers.get("content-type") or ""
+        if not content_type.startswith("application/json"):
+            return _error(["Invalid content-type, must be application/json"], 400)
+
+        try:
+            data = await request.json()
+        except json.JSONDecodeError as e:
+            return _error(["Invalid JSON: {}".format(e)], 400)
+
+        if not isinstance(data, dict):
+            return _error(["JSON must be a dictionary"], 400)
+
+        try:
+            alter_request = AlterTableRequest.model_validate(data)
+        except ValidationError as e:
+            return _error(_pydantic_errors(e), 400)
+
+        def alter_table(conn):
+            before_schema = _table_schema_from_conn(conn, table_name)
+
+            def apply_operations(operation_conn):
+                db_for_write = sqlite_utils.Database(operation_conn)
+                table = db_for_write[table_name]
+
+                add_columns = []
+                types = {}
+                rename = {}
+                drop = set()
+                not_null = {}
+                defaults = {}
+                column_order = None
+                pk = SQLITE_UTILS_DEFAULT
+
+                for operation in alter_request.operations:
+                    args = operation.args
+                    if operation.op == "add_column":
+                        if args.not_null and not (
+                            (
+                                "default" in args.model_fields_set
+                                and args.default is not None
+                            )
+                            or "default_expr" in args.model_fields_set
+                        ):
+                            raise ValueError(
+                                "add_column args.default or args.default_expr is required when not_null is true"
+                            )
+                        add_columns.append(args)
+                        if "default" in args.model_fields_set and not args.not_null:
+                            defaults[args.name] = _literal_default(
+                                db_for_write, args.default
+                            )
+                        if (
+                            "default_expr" in args.model_fields_set
+                            and not args.not_null
+                        ):
+                            defaults[args.name] = _default_expression_sql(
+                                args.default_expr
+                            )
+                    elif operation.op == "rename_column":
+                        rename[args.name] = args.to
+                    elif operation.op == "alter_column":
+                        if args.type is not None:
+                            types[args.name] = args.type
+                        if args.not_null is not None:
+                            not_null[args.name] = args.not_null
+                        if "default" in args.model_fields_set:
+                            defaults[args.name] = (
+                                None
+                                if args.default is None
+                                else _literal_default(db_for_write, args.default)
+                            )
+                        if "default_expr" in args.model_fields_set:
+                            defaults[args.name] = _default_expression_sql(
+                                args.default_expr
+                            )
+                    elif operation.op == "drop_column":
+                        drop.add(args.name)
+                    elif operation.op == "set_primary_key":
+                        pk = _primary_key_value(args.columns)
+                    elif operation.op == "reorder_columns":
+                        column_order = args.columns
+
+                with operation_conn:
+                    for column in add_columns:
+                        not_null_default = None
+                        if column.not_null:
+                            if "default_expr" in column.model_fields_set:
+                                not_null_default = _default_expression_sql(
+                                    column.default_expr
+                                )
+                            else:
+                                not_null_default = _literal_default(
+                                    db_for_write, column.default
+                                )
+                        table.add_column(
+                            column.name,
+                            column.type,
+                            not_null_default=not_null_default,
+                        )
+
+                    should_transform = any(
+                        (
+                            types,
+                            rename,
+                            drop,
+                            not_null,
+                            defaults,
+                            column_order is not None,
+                            pk is not SQLITE_UTILS_DEFAULT,
+                        )
+                    )
+                    if should_transform:
+                        table.transform(
+                            types=types or None,
+                            rename=rename or None,
+                            drop=drop or None,
+                            pk=pk,
+                            not_null=not_null or None,
+                            defaults=defaults or None,
+                            column_order=column_order,
+                        )
+
+                return _table_schema_from_conn(operation_conn, table_name)
+
+            if alter_request.dry_run:
+                memory_conn = sqlite3.connect(":memory:")
+                try:
+                    conn.backup(memory_conn)
+                    return before_schema, apply_operations(memory_conn)
+                finally:
+                    memory_conn.close()
+
+            after_schema = apply_operations(conn)
+            return before_schema, after_schema
+
+        try:
+            before_schema, after_schema = await db.execute_write_fn(
+                alter_table, request=request
+            )
+        except Exception as e:
+            return _error([str(e)], 400)
+
+        altered = before_schema != after_schema
+        if altered and not alter_request.dry_run:
+            await self.ds.track_event(
+                AlterTableEvent(
+                    request.actor,
+                    database=database_name,
+                    table=table_name,
+                    before_schema=before_schema,
+                    after_schema=after_schema,
+                )
+            )
+
+        table_url = self.ds.absolute_url(
+            request, self.ds.urls.table(database_name, table_name)
+        )
+        table_api_url = self.ds.absolute_url(
+            request, self.ds.urls.table(database_name, table_name, format="json")
+        )
+        return Response.json(
+            {
+                "ok": True,
+                "database": database_name,
+                "table": table_name,
+                "table_url": table_url,
+                "table_api_url": table_api_url,
+                "altered": altered,
+                "schema": after_schema,
+                "before_schema": before_schema,
+                "operations_applied": (
+                    0 if alter_request.dry_run else len(alter_request.operations)
+                ),
+                "dry_run": alter_request.dry_run,
+            },
+            status=200,
+        )

From 9766a9c0876351a5c60430c4582a7686cb24ad79 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 12:38:51 -0700
Subject: [PATCH 244/386] Add foreign keys to create table API

- Add fk_table and optional fk_column support to create-table columns.
- Validate create-table requests with Pydantic while preserving existing errors.
- Document the API and cover inferred primary-key and validation cases.
Refs https://github.com/simonw/datasette/pull/2789#issuecomment-4733544452
---
 datasette/views/table_create_alter.py | 287 ++++++++++++++++----------
 docs/json_api.rst                     |  25 +++
 tests/test_api_write.py               | 115 +++++++++++
 3 files changed, 321 insertions(+), 106 deletions(-)

diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index 7decfad2..e8264a6f 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -2,7 +2,15 @@ import json
 import re
 from typing import Annotated, Any, Literal, Union
 
-from pydantic import BaseModel, ConfigDict, Field, ValidationError, model_validator
+from pydantic import (
+    BaseModel,
+    ConfigDict,
+    Field,
+    ValidationError,
+    field_validator,
+    model_validator,
+)
+from pydantic_core import PydanticCustomError
 import sqlite_utils
 from sqlite_utils.db import DEFAULT as SQLITE_UTILS_DEFAULT
 
@@ -25,6 +33,7 @@ CREATE_TABLE_TYPE_FOR_SQLITE_TYPE = {
     sqlite_type: column_type
     for column_type, sqlite_type in CREATE_TABLE_SQLITE_TYPES.items()
 }
+TABLE_NAME_RE = re.compile(r"^(?!sqlite_)[^\n]+$")
 ALTER_TABLE_COLUMN_TYPES = CREATE_TABLE_COLUMN_TYPES
 ALTER_TABLE_TYPE_FOR_SQLITE_TYPE = {
     SQLiteType.TEXT: "text",
@@ -98,6 +107,137 @@ class _StrictPydanticModel(BaseModel):
     model_config = ConfigDict(extra="forbid")
 
 
+class CreateTableColumn(BaseModel):
+    model_config = ConfigDict(extra="forbid")
+
+    name: Any = None
+    type: Any = "text"
+    fk_table: str | None = None
+    fk_column: str | None = None
+
+    @model_validator(mode="after")
+    def validate_column(self):
+        if not self.name or not isinstance(self.name, str):
+            raise PydanticCustomError("create_table", "Column name is required")
+        if not self.type:
+            self.type = "text"
+        elif self.type not in CREATE_TABLE_COLUMN_TYPES:
+            raise PydanticCustomError(
+                "create_table", "Unsupported column type: {type}", {"type": self.type}
+            )
+        if self.fk_column and not self.fk_table:
+            raise PydanticCustomError(
+                "create_table_with_location",
+                "fk_column requires fk_table",
+            )
+        return self
+
+
+class CreateTableRequest(_StrictPydanticModel):
+    table: Any = None
+    rows: Any = None
+    row: Any = None
+    columns: list[CreateTableColumn] | None = None
+    pk: Any = None
+    pks: Any = None
+    ignore: bool | None = None
+    replace: bool | None = None
+    alter: bool | None = None
+
+    @field_validator("columns", mode="before")
+    @classmethod
+    def validate_columns_list(cls, value):
+        if value is None:
+            return value
+        if not isinstance(value, list):
+            raise PydanticCustomError("create_table", "columns must be a list")
+        if not all(isinstance(column, dict) for column in value):
+            raise PydanticCustomError(
+                "create_table", "columns must be a list of objects"
+            )
+        return value
+
+    @model_validator(mode="after")
+    def validate_request(self):
+        if not self.table:
+            raise PydanticCustomError("create_table", "Table is required")
+        if not isinstance(self.table, str) or not TABLE_NAME_RE.match(self.table):
+            raise PydanticCustomError("create_table", "Invalid table name")
+        if not self.columns and not self.rows and not self.row:
+            raise PydanticCustomError(
+                "create_table", "columns, rows or row is required"
+            )
+        if self.rows and self.row:
+            raise PydanticCustomError(
+                "create_table", "Cannot specify both rows and row"
+            )
+        if self.columns and (self.rows or self.row):
+            raise PydanticCustomError(
+                "create_table", "Cannot specify columns with rows or row"
+            )
+        if self.columns is not None:
+            seen = set()
+            duplicates = []
+            for column in self.columns:
+                if column.name in seen and column.name not in duplicates:
+                    duplicates.append(column.name)
+                seen.add(column.name)
+            if duplicates:
+                raise PydanticCustomError(
+                    "create_table",
+                    "Duplicate column name: {names}",
+                    {"names": ", ".join(duplicates)},
+                )
+        if self.rows is not None:
+            if not isinstance(self.rows, list):
+                raise PydanticCustomError("create_table", "rows must be a list")
+            if not all(isinstance(row, dict) for row in self.rows):
+                raise PydanticCustomError(
+                    "create_table", "rows must be a list of objects"
+                )
+        if self.pk is not None and not isinstance(self.pk, str):
+            raise PydanticCustomError("create_table", "pk must be a string")
+        if self.pk and self.pks:
+            raise PydanticCustomError("create_table", "Cannot specify both pk and pks")
+        if self.pks is not None:
+            if not isinstance(self.pks, list):
+                raise PydanticCustomError("create_table", "pks must be a list")
+            if not all(isinstance(pk, str) for pk in self.pks):
+                raise PydanticCustomError(
+                    "create_table", "pks must be a list of strings"
+                )
+        if self.ignore and self.replace:
+            raise PydanticCustomError(
+                "create_table", "ignore and replace are mutually exclusive"
+            )
+        if {"ignore", "replace"} & self.model_fields_set:
+            if not self.row and not self.rows:
+                raise PydanticCustomError(
+                    "create_table", "ignore and replace require row or rows"
+                )
+            if not self.pk and not self.pks:
+                raise PydanticCustomError(
+                    "create_table", "ignore and replace require pk or pks"
+                )
+        return self
+
+    @property
+    def rows_list(self):
+        return [self.row] if self.row else self.rows
+
+    @property
+    def foreign_keys(self):
+        if not self.columns:
+            return None
+        foreign_keys = []
+        for column in self.columns:
+            if column.fk_table and column.fk_column:
+                foreign_keys.append((column.name, column.fk_table, column.fk_column))
+            elif column.fk_table:
+                foreign_keys.append((column.name, column.fk_table))
+        return foreign_keys or None
+
+
 class _DefaultArgsMixin(_StrictPydanticModel):
     default: Any | None = None
     default_expr: DefaultExpr | None = None
@@ -209,6 +349,27 @@ def _pydantic_errors(validation_error):
     return errors
 
 
+def _create_table_pydantic_errors(validation_error):
+    errors = validation_error.errors()
+    invalid_keys = sorted(
+        str(error["loc"][0])
+        for error in errors
+        if error["type"] == "extra_forbidden" and len(error["loc"]) == 1
+    )
+    if invalid_keys:
+        return ["Invalid keys: {}".format(", ".join(invalid_keys))]
+
+    output = []
+    for error in errors:
+        message = error["msg"]
+        if error["type"] == "create_table":
+            output.append(message)
+            continue
+        location = ".".join(str(item) for item in error["loc"])
+        output.append("{}: {}".format(location, message) if location else message)
+    return output
+
+
 def _table_schema_from_conn(conn, table_name):
     row = conn.execute(
         "select sql from sqlite_master where type = 'table' and name = ?",
@@ -236,21 +397,6 @@ def _literal_default(db, value):
 class TableCreateView(BaseView):
     name = "table-create"
 
-    _valid_keys = {
-        "table",
-        "rows",
-        "row",
-        "columns",
-        "pk",
-        "pks",
-        "ignore",
-        "replace",
-        "alter",
-    }
-    _supported_column_types = set(CREATE_TABLE_COLUMN_TYPES)
-    # Any string that does not contain a newline or start with sqlite_
-    _table_name_re = re.compile(r"^(?!sqlite_)[^\n]+$")
-
     def __init__(self, datasette):
         self.ds = datasette
 
@@ -274,26 +420,13 @@ class TableCreateView(BaseView):
         if not isinstance(data, dict):
             return _error(["JSON must be an object"])
 
-        invalid_keys = set(data.keys()) - self._valid_keys
-        if invalid_keys:
-            return _error(["Invalid keys: {}".format(", ".join(invalid_keys))])
+        try:
+            create_request = CreateTableRequest.model_validate(data)
+        except ValidationError as e:
+            return _error(_create_table_pydantic_errors(e))
 
-        # ignore and replace are mutually exclusive
-        if data.get("ignore") and data.get("replace"):
-            return _error(["ignore and replace are mutually exclusive"])
-
-        # ignore and replace only allowed with row or rows
-        if "ignore" in data or "replace" in data:
-            if not data.get("row") and not data.get("rows"):
-                return _error(["ignore and replace require row or rows"])
-
-        # ignore and replace require pk or pks
-        if "ignore" in data or "replace" in data:
-            if not data.get("pk") and not data.get("pks"):
-                return _error(["ignore and replace require pk or pks"])
-
-        ignore = data.get("ignore")
-        replace = data.get("replace")
+        ignore = create_request.ignore
+        replace = create_request.replace
 
         if replace:
             # Must have update-row permission
@@ -304,24 +437,12 @@ class TableCreateView(BaseView):
             ):
                 return _error(["Permission denied: need update-row"], 403)
 
-        table_name = data.get("table")
-        if not table_name:
-            return _error(["Table is required"])
+        table_name = create_request.table
+        table_exists = await db.table_exists(table_name)
+        columns = create_request.columns
+        rows = create_request.rows_list
 
-        if not self._table_name_re.match(table_name):
-            return _error(["Invalid table name"])
-
-        table_exists = await db.table_exists(data["table"])
-        columns = data.get("columns")
-        rows = data.get("rows")
-        row = data.get("row")
-        if not columns and not rows and not row:
-            return _error(["columns, rows or row is required"])
-
-        if rows and row:
-            return _error(["Cannot specify both rows and row"])
-
-        if rows or row:
+        if rows:
             # Must have insert-row permission
             if not await self.ds.allowed(
                 action="insert-row",
@@ -331,13 +452,13 @@ class TableCreateView(BaseView):
                 return _error(["Permission denied: need insert-row"], 403)
 
         alter = False
-        if rows or row:
+        if rows:
             if not table_exists:
                 # if table is being created for the first time, alter=True
                 alter = True
             else:
                 # alter=True only if they request it AND they have permission
-                if data.get("alter"):
+                if create_request.alter:
                     if not await self.ds.allowed(
                         action="alter-table",
                         resource=DatabaseResource(database=database_name),
@@ -346,64 +467,17 @@ class TableCreateView(BaseView):
                         return _error(["Permission denied: need alter-table"], 403)
                     alter = True
 
-        if columns:
-            if rows or row:
-                return _error(["Cannot specify columns with rows or row"])
-            if not isinstance(columns, list):
-                return _error(["columns must be a list"])
-            for column in columns:
-                if not isinstance(column, dict):
-                    return _error(["columns must be a list of objects"])
-                if not column.get("name") or not isinstance(column.get("name"), str):
-                    return _error(["Column name is required"])
-                if not column.get("type"):
-                    column["type"] = "text"
-                if column["type"] not in self._supported_column_types:
-                    return _error(
-                        ["Unsupported column type: {}".format(column["type"])]
-                    )
-            # No duplicate column names
-            dupes = {c["name"] for c in columns if columns.count(c) > 1}
-            if dupes:
-                return _error(["Duplicate column name: {}".format(", ".join(dupes))])
-
-        if row:
-            rows = [row]
-
-        if rows:
-            if not isinstance(rows, list):
-                return _error(["rows must be a list"])
-            for row in rows:
-                if not isinstance(row, dict):
-                    return _error(["rows must be a list of objects"])
-
-        pk = data.get("pk")
-        pks = data.get("pks")
-
-        if pk and pks:
-            return _error(["Cannot specify both pk and pks"])
-        if pk:
-            if not isinstance(pk, str):
-                return _error(["pk must be a string"])
-        if pks:
-            if not isinstance(pks, list):
-                return _error(["pks must be a list"])
-            for pk in pks:
-                if not isinstance(pk, str):
-                    return _error(["pks must be a list of strings"])
+        pk = create_request.pk
+        pks = create_request.pks
 
         # If table exists already, read pks from that instead
         if table_exists:
             actual_pks = await db.primary_keys(table_name)
             # if pk passed and table already exists check it does not change
             bad_pks = False
-            if len(actual_pks) == 1 and data.get("pk") and data["pk"] != actual_pks[0]:
+            if len(actual_pks) == 1 and pk and pk != actual_pks[0]:
                 bad_pks = True
-            elif (
-                len(actual_pks) > 1
-                and data.get("pks")
-                and set(data["pks"]) != set(actual_pks)
-            ):
+            elif len(actual_pks) > 1 and pks and set(pks) != set(actual_pks):
                 bad_pks = True
             if bad_pks:
                 return _error(["pk cannot be changed for existing table"])
@@ -423,8 +497,9 @@ class TableCreateView(BaseView):
                 )
             else:
                 table.create(
-                    {c["name"]: c["type"] for c in columns},
+                    {column.name: column.type for column in columns},
                     pk=pks or pk,
+                    foreign_keys=create_request.foreign_keys,
                 )
             return table.schema
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 4074b479..1b4a196e 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -1981,6 +1981,7 @@ The JSON here describes the table that will be created:
 
   - ``name`` is the name of the column. This is required.
   - ``type`` is the type of the column. This is optional - if not provided, ``text`` will be assumed. The valid types are ``text``, ``integer``, ``float`` and ``blob``.
+  - ``fk_table`` can be used to create a single-column foreign key constraint referencing another table. ``fk_column`` is optional and can be used to specify the referenced column - if omitted, Datasette will use the single primary key of ``fk_table``.
 
 * ``pk`` is the primary key for the table. This is optional - if not provided, Datasette will create a SQLite table with a hidden ``rowid`` column.
 
@@ -1993,6 +1994,30 @@ The JSON here describes the table that will be created:
 * ``replace`` can be set to ``true`` to replace existing rows by primary key if the table already exists. This requires the :ref:`actions_update_row` permission.
 * ``alter`` can be set to ``true`` if you want to automatically add any missing columns to the table. This requires the :ref:`actions_alter_table` permission.
 
+This example creates a foreign key from ``projects.owner_id`` to the single primary key of ``owners``:
+
+.. code-block:: json
+
+    {
+        "table": "projects",
+        "columns": [
+            {
+                "name": "id",
+                "type": "integer"
+            },
+            {
+                "name": "owner_id",
+                "type": "integer",
+                "fk_table": "owners"
+            },
+            {
+                "name": "title",
+                "type": "text"
+            }
+        ],
+        "pk": "id"
+    }
+
 If the table is successfully created this will return a ``201`` status code and the following response:
 
 .. code-block:: json
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index f117c06e..627b1ac1 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1614,6 +1614,121 @@ async def test_create_table(
     assert [e.name for e in events] == expected_events
 
 
+@pytest.mark.asyncio
+async def test_create_table_with_foreign_key(ds_write):
+    token = write_token(ds_write)
+    response = await ds_write.client.post(
+        "/data/-/create",
+        json={
+            "table": "owners",
+            "columns": [
+                {"name": "id", "type": "integer"},
+                {"name": "name", "type": "text"},
+            ],
+            "pk": "id",
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 201
+
+    response = await ds_write.client.post(
+        "/data/-/create",
+        json={
+            "table": "projects",
+            "columns": [
+                {"name": "id", "type": "integer"},
+                {
+                    "name": "owner_id",
+                    "type": "integer",
+                    "fk_table": "owners",
+                },
+                {"name": "title", "type": "text"},
+            ],
+            "pk": "id",
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 201
+    data = response.json()
+    assert "[owner_id] INTEGER REFERENCES [owners]([id])" in data["schema"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "column,expected_error",
+    (
+        (
+            {"name": "owner_id", "type": "integer", "fk_table": "owners"},
+            None,
+        ),
+        (
+            {"name": "owner_id", "type": "integer", "fk_column": "id"},
+            "columns.0: fk_column requires fk_table",
+        ),
+    ),
+)
+async def test_create_table_foreign_key_validation(ds_write, column, expected_error):
+    token = write_token(ds_write)
+    response = await ds_write.client.post(
+        "/data/-/create",
+        json={
+            "table": "projects",
+            "columns": [column],
+        },
+        headers=_headers(token),
+    )
+    if expected_error:
+        assert response.status_code == 400
+        assert response.json() == {"ok": False, "errors": [expected_error]}
+    else:
+        assert response.status_code == 400
+        assert response.json() == {
+            "ok": False,
+            "errors": ["Could not detect single primary key for table 'owners'"],
+        }
+
+
+@pytest.mark.asyncio
+async def test_create_table_foreign_key_without_fk_column_requires_single_pk(ds_write):
+    token = write_token(ds_write)
+    response = await ds_write.client.post(
+        "/data/-/create",
+        json={
+            "table": "accounts",
+            "columns": [
+                {"name": "tenant_id", "type": "integer"},
+                {"name": "id", "type": "integer"},
+                {"name": "name", "type": "text"},
+            ],
+            "pks": ["tenant_id", "id"],
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 201
+
+    response = await ds_write.client.post(
+        "/data/-/create",
+        json={
+            "table": "projects",
+            "columns": [
+                {"name": "id", "type": "integer"},
+                {
+                    "name": "account_id",
+                    "type": "integer",
+                    "fk_table": "accounts",
+                },
+            ],
+            "pk": "id",
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 400
+    assert response.json() == {
+        "ok": False,
+        "errors": ["Could not detect single primary key for table 'accounts'"],
+    }
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "permissions,body,expected_status,expected_errors",

From 9d9a2d3ff379b1f1ee3db4d24b53310ef2a71023 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 12:51:19 -0700
Subject: [PATCH 245/386] Add foreign keys to alter table API

- Add add_foreign_key, drop_foreign_key, and set_foreign_keys operations.
- Validate flat fk_table and fk_column arguments with Pydantic.
- Document the API and cover inferred primary-key and validation cases.
---
 datasette/views/table_create_alter.py |  67 +++++++++++++++
 docs/json_api.rst                     |  30 +++++++
 tests/test_api_write.py               | 118 ++++++++++++++++++++++++++
 3 files changed, 215 insertions(+)

diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index e8264a6f..20dcc03e 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -292,6 +292,40 @@ class ReorderColumnsArgs(_StrictPydanticModel):
     columns: list[str] = Field(min_length=1)
 
 
+class ForeignKeyArgs(_StrictPydanticModel):
+    column: str
+    fk_table: str | None = None
+    fk_column: str | None = None
+
+    @model_validator(mode="after")
+    def validate_foreign_key(self):
+        if self.fk_column and not self.fk_table:
+            raise PydanticCustomError(
+                "alter_table_foreign_key",
+                "fk_column requires fk_table",
+            )
+        if not self.fk_table:
+            raise PydanticCustomError(
+                "alter_table_foreign_key",
+                "fk_table is required",
+            )
+        return self
+
+    @property
+    def tuple(self):
+        if self.fk_column:
+            return (self.column, self.fk_table, self.fk_column)
+        return (self.column, self.fk_table)
+
+
+class DropForeignKeyArgs(_StrictPydanticModel):
+    column: str
+
+
+class SetForeignKeysArgs(_StrictPydanticModel):
+    foreign_keys: list[ForeignKeyArgs]
+
+
 class AddColumnOperation(_StrictPydanticModel):
     op: Literal["add_column"]
     args: AddColumnArgs
@@ -322,6 +356,21 @@ class ReorderColumnsOperation(_StrictPydanticModel):
     args: ReorderColumnsArgs
 
 
+class AddForeignKeyOperation(_StrictPydanticModel):
+    op: Literal["add_foreign_key"]
+    args: ForeignKeyArgs
+
+
+class DropForeignKeyOperation(_StrictPydanticModel):
+    op: Literal["drop_foreign_key"]
+    args: DropForeignKeyArgs
+
+
+class SetForeignKeysOperation(_StrictPydanticModel):
+    op: Literal["set_foreign_keys"]
+    args: SetForeignKeysArgs
+
+
 AlterTableOperation = Annotated[
     Union[
         AddColumnOperation,
@@ -330,6 +379,9 @@ AlterTableOperation = Annotated[
         DropColumnOperation,
         SetPrimaryKeyOperation,
         ReorderColumnsOperation,
+        AddForeignKeyOperation,
+        DropForeignKeyOperation,
+        SetForeignKeysOperation,
     ],
     Field(discriminator="op"),
 ]
@@ -615,6 +667,9 @@ class TableAlterView(BaseView):
                 defaults = {}
                 column_order = None
                 pk = SQLITE_UTILS_DEFAULT
+                add_foreign_keys = []
+                drop_foreign_keys = []
+                foreign_keys = None
 
                 for operation in alter_request.operations:
                     args = operation.args
@@ -664,6 +719,12 @@ class TableAlterView(BaseView):
                         pk = _primary_key_value(args.columns)
                     elif operation.op == "reorder_columns":
                         column_order = args.columns
+                    elif operation.op == "add_foreign_key":
+                        add_foreign_keys.append(args.tuple)
+                    elif operation.op == "drop_foreign_key":
+                        drop_foreign_keys.append(args.column)
+                    elif operation.op == "set_foreign_keys":
+                        foreign_keys = [fk.tuple for fk in args.foreign_keys]
 
                 with operation_conn:
                     for column in add_columns:
@@ -692,6 +753,9 @@ class TableAlterView(BaseView):
                             defaults,
                             column_order is not None,
                             pk is not SQLITE_UTILS_DEFAULT,
+                            add_foreign_keys,
+                            drop_foreign_keys,
+                            foreign_keys is not None,
                         )
                     )
                     if should_transform:
@@ -703,6 +767,9 @@ class TableAlterView(BaseView):
                             not_null=not_null or None,
                             defaults=defaults or None,
                             column_order=column_order,
+                            add_foreign_keys=add_foreign_keys or None,
+                            drop_foreign_keys=drop_foreign_keys or None,
+                            foreign_keys=foreign_keys,
                         )
 
                 return _table_schema_from_conn(operation_conn, table_name)
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 1b4a196e..af16626f 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -2159,6 +2159,31 @@ The request body should include an ``operations`` array. Each operation has the
                     "columns": ["id"]
                 }
             },
+            {
+                "op": "add_foreign_key",
+                "args": {
+                    "column": "owner_id",
+                    "fk_table": "owners"
+                }
+            },
+            {
+                "op": "drop_foreign_key",
+                "args": {
+                    "column": "old_owner_id"
+                }
+            },
+            {
+                "op": "set_foreign_keys",
+                "args": {
+                    "foreign_keys": [
+                        {
+                            "column": "owner_id",
+                            "fk_table": "owners",
+                            "fk_column": "id"
+                        }
+                    ]
+                }
+            },
             {
                 "op": "reorder_columns",
                 "args": {
@@ -2177,10 +2202,15 @@ Supported operations:
 * ``alter_column`` changes column properties. ``args`` accepts ``name`` and at least one of ``type``, ``not_null``, literal ``default`` or ``default_expr``. Passing ``"default": null`` removes an existing default.
 * ``drop_column`` drops a column. ``args`` accepts ``name``.
 * ``set_primary_key`` changes the table primary key. ``args`` accepts ``columns``, a list of one or more column names.
+* ``add_foreign_key`` adds a single-column foreign key constraint. ``args`` accepts ``column``, ``fk_table`` and optional ``fk_column``. If ``fk_column`` is omitted, Datasette will use the single primary key of ``fk_table``.
+* ``drop_foreign_key`` removes the foreign key constraint for a column. ``args`` accepts ``column``.
+* ``set_foreign_keys`` replaces all foreign key constraints on the table. ``args`` accepts ``foreign_keys``, a list of objects that each have ``column``, ``fk_table`` and optional ``fk_column``. An empty list removes all foreign key constraints.
 * ``reorder_columns`` reorders columns. ``args`` accepts ``columns``, a list of one or more column names. Columns omitted from this list will appear afterwards in their existing order.
 
 ``default`` is always treated as a literal value. ``default_expr`` accepts one of ``current_timestamp``, ``current_date`` or ``current_time`` and is rendered as the corresponding SQLite default expression.
 
+For foreign key operations that omit ``fk_column``, the referenced ``fk_table`` must have a single-column primary key. Datasette will return an error if it cannot identify a single primary key column for that table.
+
 A successful response returns the new schema and the previous schema:
 
 .. code-block:: json
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 627b1ac1..046cf695 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -926,6 +926,124 @@ async def test_alter_table_dry_run(ds_write):
     assert last_event(ds_write) is None
 
 
+@pytest.mark.asyncio
+async def test_alter_table_foreign_key_operations(ds_write):
+    token = write_token(ds_write, permissions=["at"])
+    db = ds_write.get_database("data")
+    await db.execute_write("create table owners (id integer primary key)")
+    await db.execute_write("create table categories (id integer primary key)")
+
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "operations": [
+                {"op": "add_column", "args": {"name": "owner_id", "type": "integer"}},
+                {
+                    "op": "add_foreign_key",
+                    "args": {"column": "owner_id", "fk_table": "owners"},
+                },
+            ]
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert data["operations_applied"] == 2
+    assert "[owner_id] INTEGER REFERENCES [owners]([id])" in data["schema"]
+
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "operations": [{"op": "drop_foreign_key", "args": {"column": "owner_id"}}]
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert "[owner_id] INTEGER REFERENCES" not in data["schema"]
+
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "operations": [
+                {
+                    "op": "set_foreign_keys",
+                    "args": {
+                        "foreign_keys": [
+                            {
+                                "column": "owner_id",
+                                "fk_table": "categories",
+                                "fk_column": "id",
+                            }
+                        ]
+                    },
+                }
+            ]
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert "[owner_id] INTEGER REFERENCES [categories]([id])" in data["schema"]
+
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={"operations": [{"op": "set_foreign_keys", "args": {"foreign_keys": []}}]},
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert "[owner_id] INTEGER REFERENCES" not in data["schema"]
+
+
+@pytest.mark.asyncio
+async def test_alter_table_foreign_key_requires_fk_table_for_fk_column(ds_write):
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "operations": [
+                {
+                    "op": "add_foreign_key",
+                    "args": {"column": "age", "fk_column": "id"},
+                }
+            ]
+        },
+        headers=_headers(write_token(ds_write, permissions=["at"])),
+    )
+    assert response.status_code == 400
+    assert response.json() == {
+        "ok": False,
+        "errors": ["operations.0.add_foreign_key.args: fk_column requires fk_table"],
+    }
+
+
+@pytest.mark.asyncio
+async def test_alter_table_foreign_key_without_fk_column_requires_single_pk(ds_write):
+    token = write_token(ds_write, permissions=["at"])
+    db = ds_write.get_database("data")
+    await db.execute_write(
+        "create table accounts (tenant_id integer, id integer, primary key (tenant_id, id))"
+    )
+
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "operations": [
+                {
+                    "op": "add_foreign_key",
+                    "args": {"column": "age", "fk_table": "accounts"},
+                }
+            ]
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 400
+    assert response.json() == {
+        "ok": False,
+        "errors": ["Could not detect single primary key for table 'accounts'"],
+    }
+
+
 @pytest.mark.asyncio
 async def test_alter_table_permission_denied(ds_write):
     token = write_token(ds_write, permissions=["ir"])

From 2900efb32d5348fdd4b3ecb33e5f8b1ee836f5c3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 14:47:25 -0700
Subject: [PATCH 246/386] /db/table/-/foreign-key-suggestions API

Improved version of the implementation datasette-edit-schema
---
 datasette/app.py                      |  10 +-
 datasette/views/table_create_alter.py | 303 +++++++++++++++++++++++++-
 docs/json_api.rst                     |  58 +++++
 tests/test_api_write.py               | 100 +++++++++
 4 files changed, 469 insertions(+), 2 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 13e25d4e..6b9f47ba 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -49,7 +49,11 @@ from .views.database import (
     DatabaseView,
     QueryView,
 )
-from .views.table_create_alter import TableAlterView, TableCreateView
+from .views.table_create_alter import (
+    TableAlterView,
+    TableCreateView,
+    TableForeignKeySuggestionsView,
+)
 from .views.execute_write import ExecuteWriteAnalyzeView, ExecuteWriteView
 from .views.stored_queries import (
     QueryCreateAnalyzeView,
@@ -2630,6 +2634,10 @@ class Datasette:
             TableAlterView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/alter$",
         )
+        add_route(
+            TableForeignKeySuggestionsView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/foreign-key-suggestions$",
+        )
         add_route(
             TableSetColumnTypeView.as_view(self),
             r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)/-/set-column-type$",
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index 20dcc03e..2cb59ac1 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -1,7 +1,9 @@
 import json
 import re
+import time
 from typing import Annotated, Any, Literal, Union
 
+from datasette.database import QueryInterrupted
 from pydantic import (
     BaseModel,
     ConfigDict,
@@ -17,8 +19,14 @@ from sqlite_utils.db import DEFAULT as SQLITE_UTILS_DEFAULT
 from datasette.column_types import SQLiteType
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.resources import DatabaseResource, TableResource
-from datasette.utils import sqlite3
+from datasette.utils import (
+    escape_sqlite,
+    get_outbound_foreign_keys,
+    sqlite3,
+    table_column_details,
+)
 from datasette.utils.asgi import NotFound, Response
+from datasette.utils.sqlite import sqlite_hidden_table_names
 
 from .base import BaseView, _error
 
@@ -41,6 +49,177 @@ ALTER_TABLE_TYPE_FOR_SQLITE_TYPE = {
     SQLiteType.REAL: "float",
     SQLiteType.BLOB: "blob",
 }
+FOREIGN_KEY_SUGGESTION_ROW_LIMIT = 500
+FOREIGN_KEY_SUGGESTION_TIME_LIMIT_MS = 50
+FOREIGN_KEY_SUGGESTION_TOTAL_TIME_LIMIT_MS = 200
+
+
+class ForeignKeySuggestionTimedOut(Exception):
+    pass
+
+
+def _sqlite_type_affinity(type_name):
+    type_name = (type_name or "").upper()
+    if "INT" in type_name:
+        return "integer"
+    if any(token in type_name for token in ("CHAR", "CLOB", "TEXT")):
+        return "text"
+    if "BLOB" in type_name or not type_name:
+        return "blob"
+    if any(token in type_name for token in ("REAL", "FLOA", "DOUB")):
+        return "real"
+    return "numeric"
+
+
+def _foreign_key_type_compatible(source_affinity, target_affinity):
+    if source_affinity == target_affinity:
+        return True
+    numeric_affinities = {"integer", "real", "numeric"}
+    if source_affinity == "numeric":
+        return target_affinity in numeric_affinities
+    if target_affinity == "numeric":
+        return source_affinity in numeric_affinities
+    return False
+
+
+def _public_foreign_key_target(target):
+    return {
+        "fk_table": target["fk_table"],
+        "fk_column": target["fk_column"],
+        "type": target["type"],
+    }
+
+
+def _singular(name):
+    if name.endswith("ies") and len(name) > 3:
+        return name[:-3] + "y"
+    if name.endswith("s") and len(name) > 1:
+        return name[:-1]
+    return name
+
+
+def _foreign_key_name_reasons(source_column, target):
+    source = source_column.lower()
+    table = target["fk_table"].lower()
+    singular_table = _singular(table)
+    column = target["fk_column"].lower()
+    possible_names = {
+        "{}_{}".format(table, column),
+        "{}_{}".format(singular_table, column),
+    }
+    if column == "id":
+        possible_names.update(
+            {
+                "{}_id".format(table),
+                "{}_id".format(singular_table),
+            }
+        )
+    return ["name_match"] if source in possible_names else []
+
+
+def _foreign_key_option_sort_key(source_column, target):
+    has_name_match = bool(_foreign_key_name_reasons(source_column, target))
+    return (
+        0 if has_name_match else 1,
+        target["fk_table"],
+        target["fk_column"],
+    )
+
+
+def _foreign_key_suggestion_metadata(conn, table_name):
+    hidden_tables = set(sqlite_hidden_table_names(conn))
+    source_columns = [
+        {
+            "column": column.name,
+            "type": (column.type or "").upper(),
+            "affinity": _sqlite_type_affinity(column.type),
+        }
+        for column in table_column_details(conn, table_name)
+        if not column.hidden
+    ]
+    current_by_column = {
+        fk["column"]: {
+            "fk_table": fk["other_table"],
+            "fk_column": fk["other_column"],
+        }
+        for fk in get_outbound_foreign_keys(conn, table_name)
+    }
+    table_names = [
+        row[0]
+        for row in conn.execute(
+            "select name from sqlite_master where type = 'table' order by name"
+        ).fetchall()
+        if not row[0].startswith("sqlite_")
+    ]
+    targets = []
+    for candidate_table in table_names:
+        if candidate_table == table_name or candidate_table in hidden_tables:
+            continue
+        columns = [column for column in table_column_details(conn, candidate_table)]
+        pks = [column for column in columns if column.is_pk and not column.hidden]
+        pks.sort(key=lambda column: column.is_pk)
+        if len(pks) != 1:
+            continue
+        pk = pks[0]
+        targets.append(
+            {
+                "fk_table": candidate_table,
+                "fk_column": pk.name,
+                "type": (pk.type or "").upper(),
+                "affinity": _sqlite_type_affinity(pk.type),
+            }
+        )
+    return source_columns, targets, current_by_column
+
+
+async def _foreign_key_suggestion_samples(db, table_name, columns):
+    if not columns:
+        return 0, {}
+    sql = "select {} from {} limit {}".format(
+        ", ".join(escape_sqlite(column) for column in columns),
+        escape_sqlite(table_name),
+        FOREIGN_KEY_SUGGESTION_ROW_LIMIT,
+    )
+    try:
+        results = await db.execute(
+            sql,
+            custom_time_limit=FOREIGN_KEY_SUGGESTION_TIME_LIMIT_MS,
+            log_sql_errors=False,
+        )
+    except QueryInterrupted as e:
+        raise ForeignKeySuggestionTimedOut from e
+    values_by_column = {column: [] for column in columns}
+    seen_by_column = {column: set() for column in columns}
+    for row in results.rows:
+        for column in columns:
+            value = row[column]
+            if value is None or value in seen_by_column[column]:
+                continue
+            seen_by_column[column].add(value)
+            values_by_column[column].append(value)
+    return len(results.rows), values_by_column
+
+
+async def _foreign_key_suggestion_values_exist(db, target, values, time_limit_ms):
+    if not values:
+        return False
+    sql = "select {} from {} where {} in ({})".format(
+        escape_sqlite(target["fk_column"]),
+        escape_sqlite(target["fk_table"]),
+        escape_sqlite(target["fk_column"]),
+        ", ".join("?" for _ in values),
+    )
+    try:
+        results = await db.execute(
+            sql,
+            params=values,
+            custom_time_limit=time_limit_ms,
+            log_sql_errors=False,
+        )
+    except QueryInterrupted as e:
+        raise ForeignKeySuggestionTimedOut from e
+    found = {row[0] for row in results.rows}
+    return all(value in found for value in values)
 
 
 async def _create_table_ui_context(
@@ -609,6 +788,128 @@ class TableCreateView(BaseView):
         return Response.json(details, status=201)
 
 
+class TableForeignKeySuggestionsView(BaseView):
+    name = "table-foreign-key-suggestions"
+
+    def __init__(self, datasette):
+        self.ds = datasette
+
+    async def get(self, request):
+        try:
+            resolved = await self.ds.resolve_table(request)
+        except NotFound as e:
+            return _error([e.args[0]], 404)
+
+        db = resolved.db
+        database_name = db.name
+        table_name = resolved.table
+
+        if resolved.is_view:
+            return _error(["Cannot suggest foreign keys for a view"], 400)
+
+        if not await self.ds.allowed(
+            action="alter-table",
+            resource=TableResource(database=database_name, table=table_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need alter-table"], 403)
+
+        source_columns, targets, current_by_column = await db.execute_fn(
+            lambda conn: _foreign_key_suggestion_metadata(conn, table_name)
+        )
+
+        columns = []
+        options_by_column = {}
+        for source_column in source_columns:
+            options = sorted(
+                [
+                    target
+                    for target in targets
+                    if _foreign_key_type_compatible(
+                        source_column["affinity"], target["affinity"]
+                    )
+                ],
+                key=lambda target: _foreign_key_option_sort_key(
+                    source_column["column"], target
+                ),
+            )
+            options_by_column[source_column["column"]] = options
+            columns.append(
+                {
+                    "column": source_column["column"],
+                    "type": source_column["type"],
+                    "affinity": source_column["affinity"],
+                    "current": current_by_column.get(source_column["column"]),
+                    "suggestions": [],
+                    "options": [
+                        _public_foreign_key_target(option) for option in options
+                    ],
+                }
+            )
+
+        columns_to_sample = [
+            column["column"]
+            for column in columns
+            if options_by_column[column["column"]]
+        ]
+        row_check = {
+            "attempted": bool(columns_to_sample),
+            "status": "completed" if columns_to_sample else "skipped",
+            "row_limit": FOREIGN_KEY_SUGGESTION_ROW_LIMIT,
+            "sampled_rows": 0,
+            "checked_options": 0,
+        }
+
+        try:
+            sampled_rows, values_by_column = await _foreign_key_suggestion_samples(
+                db, table_name, columns_to_sample
+            )
+            row_check["sampled_rows"] = sampled_rows
+            deadline = time.perf_counter() + (
+                FOREIGN_KEY_SUGGESTION_TOTAL_TIME_LIMIT_MS / 1000
+            )
+            for column_info in columns:
+                values = values_by_column.get(column_info["column"]) or []
+                if not values:
+                    continue
+                for option in options_by_column[column_info["column"]]:
+                    remaining_ms = int((deadline - time.perf_counter()) * 1000)
+                    if remaining_ms <= 0:
+                        raise ForeignKeySuggestionTimedOut
+                    if await _foreign_key_suggestion_values_exist(
+                        db,
+                        option,
+                        values,
+                        min(FOREIGN_KEY_SUGGESTION_TIME_LIMIT_MS, remaining_ms),
+                    ):
+                        reasons = [
+                            "type_match",
+                            "sample_values_exist",
+                        ] + _foreign_key_name_reasons(column_info["column"], option)
+                        column_info["suggestions"].append(
+                            {
+                                "fk_table": option["fk_table"],
+                                "fk_column": option["fk_column"],
+                                "confidence": "sampled",
+                                "sampled_values": len(values),
+                                "reasons": reasons,
+                            }
+                        )
+                    row_check["checked_options"] += 1
+        except ForeignKeySuggestionTimedOut:
+            row_check["status"] = "timed_out"
+
+        return Response.json(
+            {
+                "ok": True,
+                "database": database_name,
+                "table": table_name,
+                "row_check": row_check,
+                "columns": columns,
+            }
+        )
+
+
 class TableAlterView(BaseView):
     name = "table-alter"
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index af16626f..5b05e920 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -2097,6 +2097,64 @@ To use the ``"replace": true`` option you will also need the :ref:`actions_updat
 
 Pass ``"alter": true`` to automatically add any missing columns to the existing table that are present in the rows you are submitting. This requires the :ref:`actions_alter_table` permission.
 
+.. _TableForeignKeySuggestionsView:
+
+Table foreign key suggestions
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The ``/<database>/<table>/-/foreign-key-suggestions`` endpoint suggests possible single-column foreign key relationships for a table. This requires the :ref:`actions_alter_table` permission.
+
+::
+
+    GET /<database>/<table>/-/foreign-key-suggestions
+
+The response includes every type-compatible single-column primary key target for each column in ``options``. Datasette also performs a bounded data check against up to 500 rows in the table: if the sampled non-null values for a column all exist in a target primary key, that target is included in ``suggestions``.
+
+If the bounded check takes too long, the endpoint fails open. It still returns the type-compatible ``options`` for each column, but ``row_check.status`` will be ``"timed_out"`` and there may be no ``suggestions``.
+
+.. code-block:: json
+
+    {
+        "ok": true,
+        "database": "data",
+        "table": "projects",
+        "row_check": {
+            "attempted": true,
+            "status": "completed",
+            "row_limit": 500,
+            "sampled_rows": 3,
+            "checked_options": 4
+        },
+        "columns": [
+            {
+                "column": "owner_id",
+                "type": "INTEGER",
+                "affinity": "integer",
+                "current": null,
+                "suggestions": [
+                    {
+                        "fk_table": "owners",
+                        "fk_column": "id",
+                        "confidence": "sampled",
+                        "sampled_values": 3,
+                        "reasons": [
+                            "type_match",
+                            "sample_values_exist",
+                            "name_match"
+                        ]
+                    }
+                ],
+                "options": [
+                    {
+                        "fk_table": "owners",
+                        "fk_column": "id",
+                        "type": "INTEGER"
+                    }
+                ]
+            }
+        ]
+    }
+
 .. _TableAlterView:
 
 Altering tables
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 046cf695..36fe40e9 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1044,6 +1044,106 @@ async def test_alter_table_foreign_key_without_fk_column_requires_single_pk(ds_w
     }
 
 
+@pytest.mark.asyncio
+async def test_foreign_key_suggestions(ds_write):
+    token = write_token(ds_write, permissions=["at"])
+    db = ds_write.get_database("data")
+    await db.execute_write("create table owners (id integer primary key)")
+    await db.execute_write("insert into owners (id) values (1), (2), (3)")
+    await db.execute_write("create table categories (slug text primary key)")
+    await db.execute_write("insert into categories (slug) values ('one'), ('two')")
+    await db.execute_write("create table numbers (id integer primary key)")
+    await db.execute_write("insert into numbers (id) values (10), (20)")
+    await db.execute_write("create table weights (id real primary key)")
+    await db.execute_write("insert into weights (id) values (1.5), (2.5)")
+    await db.execute_write(
+        "insert into docs (id, title, score, age) values "
+        "(1, 'one', 1.5, 1), (2, 'two', 999.5, 2), (3, null, null, null)"
+    )
+
+    response = await ds_write.client.get(
+        "/data/docs/-/foreign-key-suggestions",
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert data["ok"] is True
+    assert data["database"] == "data"
+    assert data["table"] == "docs"
+    assert data["row_check"]["attempted"] is True
+    assert data["row_check"]["status"] == "completed"
+    assert data["row_check"]["row_limit"] == 500
+    assert data["row_check"]["sampled_rows"] == 3
+
+    columns = {column["column"]: column for column in data["columns"]}
+    assert columns["age"]["options"] == [
+        {"fk_table": "numbers", "fk_column": "id", "type": "INTEGER"},
+        {"fk_table": "owners", "fk_column": "id", "type": "INTEGER"},
+    ]
+    assert columns["age"]["suggestions"] == [
+        {
+            "fk_table": "owners",
+            "fk_column": "id",
+            "confidence": "sampled",
+            "sampled_values": 2,
+            "reasons": ["type_match", "sample_values_exist"],
+        }
+    ]
+    assert columns["title"]["options"] == [
+        {"fk_table": "categories", "fk_column": "slug", "type": "TEXT"}
+    ]
+    assert columns["title"]["suggestions"][0]["fk_table"] == "categories"
+    assert columns["score"]["options"] == [
+        {"fk_table": "weights", "fk_column": "id", "type": "REAL"}
+    ]
+    assert columns["score"]["suggestions"] == []
+
+
+@pytest.mark.asyncio
+async def test_foreign_key_suggestions_permission_denied(ds_write):
+    token = write_token(ds_write, permissions=["ir"])
+    response = await ds_write.client.get(
+        "/data/docs/-/foreign-key-suggestions",
+        headers=_headers(token),
+    )
+    assert response.status_code == 403
+    assert response.json() == {
+        "ok": False,
+        "errors": ["Permission denied: need alter-table"],
+    }
+
+
+@pytest.mark.asyncio
+async def test_foreign_key_suggestions_fail_open(ds_write, monkeypatch):
+    token = write_token(ds_write, permissions=["at"])
+    db = ds_write.get_database("data")
+    await db.execute_write("create table owners (id integer primary key)")
+
+    async def raise_timeout(*args, **kwargs):
+        raise table_create_alter.ForeignKeySuggestionTimedOut
+
+    from datasette.views import table_create_alter
+
+    monkeypatch.setattr(
+        table_create_alter,
+        "_foreign_key_suggestion_samples",
+        raise_timeout,
+    )
+
+    response = await ds_write.client.get(
+        "/data/docs/-/foreign-key-suggestions",
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert data["row_check"]["status"] == "timed_out"
+    columns = {column["column"]: column for column in data["columns"]}
+    assert columns["age"]["options"] == [
+        {"fk_table": "owners", "fk_column": "id", "type": "INTEGER"}
+    ]
+    assert columns["age"]["suggestions"] == []
+
+
 @pytest.mark.asyncio
 async def test_alter_table_permission_denied(ds_write):
     token = write_token(ds_write, permissions=["ir"])

From a6ef65f90da8b7789a41972fbe89aba37e1b6a30 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Wed, 17 Jun 2026 16:29:59 -0700
Subject: [PATCH 247/386] /<database>/-/foreign-key-targets API endpoint

Returns a list of tables with a single primary key, and for each one
the name of that primary key column and its SQLite type affinity.

This will be used by the create table UI to suggest foreign keys.
---
 datasette/app.py                      |  5 ++
 datasette/views/table_create_alter.py | 60 ++++++++++++++++++++-
 docs/json_api.rst                     | 34 ++++++++++++
 tests/test_api_write.py               | 75 +++++++++++++++++++++++++++
 4 files changed, 173 insertions(+), 1 deletion(-)

diff --git a/datasette/app.py b/datasette/app.py
index 6b9f47ba..79dffb66 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -50,6 +50,7 @@ from .views.database import (
     QueryView,
 )
 from .views.table_create_alter import (
+    DatabaseForeignKeyTargetsView,
     TableAlterView,
     TableCreateView,
     TableForeignKeySuggestionsView,
@@ -2566,6 +2567,10 @@ class Datasette:
             r"/(?P<database>[^\/\.]+)(\.(?P<format>\w+))?$",
         )
         add_route(TableCreateView.as_view(self), r"/(?P<database>[^\/\.]+)/-/create$")
+        add_route(
+            DatabaseForeignKeyTargetsView.as_view(self),
+            r"/(?P<database>[^\/\.]+)/-/foreign-key-targets$",
+        )
         add_route(
             QueryListView.as_view(self),
             r"/(?P<database>[^\/\.]+)/-/queries(\.(?P<format>json))?$",
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index 2cb59ac1..ce43199c 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -52,6 +52,34 @@ ALTER_TABLE_TYPE_FOR_SQLITE_TYPE = {
 FOREIGN_KEY_SUGGESTION_ROW_LIMIT = 500
 FOREIGN_KEY_SUGGESTION_TIME_LIMIT_MS = 50
 FOREIGN_KEY_SUGGESTION_TOTAL_TIME_LIMIT_MS = 200
+FOREIGN_KEY_TARGETS_SQL = """
+select
+  m.name as fk_table,
+  p.name as fk_column,
+  case
+    when upper(coalesce(p.type, '')) like '%INT%' then 'integer'
+    when upper(coalesce(p.type, '')) like '%CHAR%'
+      or upper(coalesce(p.type, '')) like '%CLOB%'
+      or upper(coalesce(p.type, '')) like '%TEXT%' then 'text'
+    when upper(coalesce(p.type, '')) like '%BLOB%'
+      or coalesce(p.type, '') = '' then 'blob'
+    when upper(coalesce(p.type, '')) like '%REAL%'
+      or upper(coalesce(p.type, '')) like '%FLOA%'
+      or upper(coalesce(p.type, '')) like '%' || 'DOU' || 'B' || '%' then 'real'
+    else 'numeric'
+  end as type
+from sqlite_master as m
+cross join pragma_table_info(m.name) as p
+where m.type = 'table'
+  and m.name not like 'sqlite_%'
+  and p.pk > 0
+  and (
+    select count(*)
+    from pragma_table_info(m.name) as p2
+    where p2.pk > 0
+  ) = 1
+order by m.name
+"""
 
 
 class ForeignKeySuggestionTimedOut(Exception):
@@ -66,7 +94,10 @@ def _sqlite_type_affinity(type_name):
         return "text"
     if "BLOB" in type_name or not type_name:
         return "blob"
-    if any(token in type_name for token in ("REAL", "FLOA", "DOUB")):
+    if any(
+        token in type_name
+        for token in ("REAL", "FLOA", "DOUB")  # codespell:ignore doub
+    ):
         return "real"
     return "numeric"
 
@@ -788,6 +819,33 @@ class TableCreateView(BaseView):
         return Response.json(details, status=201)
 
 
+class DatabaseForeignKeyTargetsView(BaseView):
+    name = "database-foreign-key-targets"
+
+    def __init__(self, datasette):
+        self.ds = datasette
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        database_name = db.name
+
+        if not await self.ds.allowed(
+            action="create-table",
+            resource=DatabaseResource(database=database_name),
+            actor=request.actor,
+        ):
+            return _error(["Permission denied: need create-table"], 403)
+
+        targets = (await db.execute(FOREIGN_KEY_TARGETS_SQL)).dicts()
+        return Response.json(
+            {
+                "ok": True,
+                "database": database_name,
+                "targets": targets,
+            }
+        )
+
+
 class TableForeignKeySuggestionsView(BaseView):
     name = "table-foreign-key-suggestions"
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 5b05e920..dee98ef2 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -2097,6 +2097,40 @@ To use the ``"replace": true`` option you will also need the :ref:`actions_updat
 
 Pass ``"alter": true`` to automatically add any missing columns to the existing table that are present in the rows you are submitting. This requires the :ref:`actions_alter_table` permission.
 
+.. _DatabaseForeignKeyTargetsView:
+
+Database foreign key targets
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The ``/<database>/-/foreign-key-targets`` endpoint returns the list of tables in a database that can be referenced by a single-column foreign key. This requires the :ref:`actions_create_table` permission.
+
+::
+
+    GET /<database>/-/foreign-key-targets
+
+The response includes only tables with exactly one primary key column. Tables with compound primary keys and tables with no explicit primary key are omitted.
+
+Each target includes the normalized SQLite type affinity for the primary key column in ``type``. The type is calculated using SQLite's documented affinity rules: ``INT`` maps to ``integer``; ``CHAR``, ``CLOB`` or ``TEXT`` maps to ``text``; ``BLOB`` or no type maps to ``blob``; ``REAL`` and floating-point declared types map to ``real``; everything else maps to ``numeric``.
+
+.. code-block:: json
+
+    {
+        "ok": true,
+        "database": "data",
+        "targets": [
+            {
+                "fk_table": "owners",
+                "fk_column": "id",
+                "type": "integer"
+            },
+            {
+                "fk_table": "categories",
+                "fk_column": "slug",
+                "type": "text"
+            }
+        ]
+    }
+
 .. _TableForeignKeySuggestionsView:
 
 Table foreign key suggestions
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 36fe40e9..18ffe43d 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1144,6 +1144,81 @@ async def test_foreign_key_suggestions_fail_open(ds_write, monkeypatch):
     assert columns["age"]["suggestions"] == []
 
 
+@pytest.mark.asyncio
+async def test_foreign_key_targets(ds_write):
+    token = write_token(ds_write, permissions=["ct"])
+    db = ds_write.get_database("data")
+    await db.execute_write("create table owners (id integer primary key)")
+    await db.execute_write("create table categories (slug varchar(30) primary key)")
+    await db.execute_write("create table blob_things (hash blob primary key)")
+    await db.execute_write(
+        "create table numeric_codes (code decimal(10,5) primary key)"
+    )
+    await db.execute_write(
+        'create table floating_point (value "FLOATING POINT" primary key)'
+    )
+    await db.execute_write(
+        "create table compound (a integer, b integer, primary key (a, b))"
+    )
+    await db.execute_write("create table no_pk (name text)")
+
+    response = await ds_write.client.get(
+        "/data/-/foreign-key-targets",
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    assert response.json() == {
+        "ok": True,
+        "database": "data",
+        "targets": [
+            {
+                "fk_table": "blob_things",
+                "fk_column": "hash",
+                "type": "blob",
+            },
+            {
+                "fk_table": "categories",
+                "fk_column": "slug",
+                "type": "text",
+            },
+            {
+                "fk_table": "docs",
+                "fk_column": "id",
+                "type": "integer",
+            },
+            {
+                "fk_table": "floating_point",
+                "fk_column": "value",
+                "type": "integer",
+            },
+            {
+                "fk_table": "numeric_codes",
+                "fk_column": "code",
+                "type": "numeric",
+            },
+            {
+                "fk_table": "owners",
+                "fk_column": "id",
+                "type": "integer",
+            },
+        ],
+    }
+
+
+@pytest.mark.asyncio
+async def test_foreign_key_targets_permission_denied(ds_write):
+    token = write_token(ds_write, permissions=["ir"])
+    response = await ds_write.client.get(
+        "/data/-/foreign-key-targets",
+        headers=_headers(token),
+    )
+    assert response.status_code == 403
+    assert response.json() == {
+        "ok": False,
+        "errors": ["Permission denied: need create-table"],
+    }
+
+
 @pytest.mark.asyncio
 async def test_alter_table_permission_denied(ds_write):
     token = write_token(ds_write, permissions=["ir"])

From 21c156dfb1ca76d8e8c2e04c044766a155e22edc Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 18 Jun 2026 08:13:28 -0700
Subject: [PATCH 248/386] Expose foreign key targets to create table UI

- Add foreignKeyTargetsPath to create table page data
- Filter hidden tables from database-level foreign key target results
- Update JSON API docs and tests for filtered targets
---
 datasette/views/table_create_alter.py | 12 +++++++++++-
 docs/json_api.rst                     |  2 +-
 tests/test_api_write.py               |  8 ++++++++
 tests/test_table_html.py              |  1 +
 4 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index ce43199c..f7775479 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -262,6 +262,9 @@ async def _create_table_ui_context(
         return None
     data = {
         "path": "{}/-/create".format(datasette.urls.database(database_name)),
+        "foreignKeyTargetsPath": "{}/-/foreign-key-targets".format(
+            datasette.urls.database(database_name)
+        ),
         "databaseName": database_name,
         "columnTypes": CREATE_TABLE_COLUMN_TYPES,
     }
@@ -836,7 +839,14 @@ class DatabaseForeignKeyTargetsView(BaseView):
         ):
             return _error(["Permission denied: need create-table"], 403)
 
-        targets = (await db.execute(FOREIGN_KEY_TARGETS_SQL)).dicts()
+        hidden_tables = await db.execute_fn(
+            lambda conn: set(sqlite_hidden_table_names(conn))
+        )
+        targets = [
+            target
+            for target in (await db.execute(FOREIGN_KEY_TARGETS_SQL)).dicts()
+            if target["fk_table"] not in hidden_tables
+        ]
         return Response.json(
             {
                 "ok": True,
diff --git a/docs/json_api.rst b/docs/json_api.rst
index dee98ef2..1db46dd2 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -2108,7 +2108,7 @@ The ``/<database>/-/foreign-key-targets`` endpoint returns the list of tables in
 
     GET /<database>/-/foreign-key-targets
 
-The response includes only tables with exactly one primary key column. Tables with compound primary keys and tables with no explicit primary key are omitted.
+The response includes only tables with exactly one primary key column. Hidden tables, tables with compound primary keys and tables with no explicit primary key are omitted.
 
 Each target includes the normalized SQLite type affinity for the primary key column in ``type``. The type is calculated using SQLite's documented affinity rules: ``INT`` maps to ``integer``; ``CHAR``, ``CLOB`` or ``TEXT`` maps to ``text``; ``BLOB`` or no type maps to ``blob``; ``REAL`` and floating-point declared types map to ``real``; everything else maps to ``numeric``.
 
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 18ffe43d..1d16ad26 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1161,6 +1161,10 @@ async def test_foreign_key_targets(ds_write):
         "create table compound (a integer, b integer, primary key (a, b))"
     )
     await db.execute_write("create table no_pk (name text)")
+    try:
+        await db.execute_write("create virtual table search_docs using fts5(body)")
+    except Exception:
+        pass
 
     response = await ds_write.client.get(
         "/data/-/foreign-key-targets",
@@ -1203,6 +1207,10 @@ async def test_foreign_key_targets(ds_write):
             },
         ],
     }
+    assert not any(
+        target["fk_table"].startswith("search_docs_")
+        for target in response.json()["targets"]
+    )
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 374cc08d..fa01c8ec 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -994,6 +994,7 @@ async def test_database_create_table_action_button_and_data():
         assert database_data_from_soup(soup) == {
             "createTable": {
                 "path": "/data/-/create",
+                "foreignKeyTargetsPath": "/data/-/foreign-key-targets",
                 "databaseName": "data",
                 "columnTypes": ["text", "integer", "float", "blob"],
             },

From 1f863def5e410cc3f836f1e07404aa68b578db9b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 18 Jun 2026 08:13:37 -0700
Subject: [PATCH 249/386] Add foreign key controls to create table dialog

- Add create table advanced controls for foreign keys and first-column primary keys
- Share schema dialog row helpers between create and alter dialogs
- Move custom type into advanced options and add Add column icons
---
 datasette/static/app.css       | 210 ++++++--
 datasette/static/edit-tools.js | 954 ++++++++++++++++++++++++---------
 2 files changed, 862 insertions(+), 302 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index f9ebe5ac..49f070b1 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1760,7 +1760,7 @@ dialog.table-create-dialog {
     border-radius: var(--modal-border-radius, 0.75rem);
     padding: 0;
     margin: auto;
-    width: min(760px, calc(100vw - 32px));
+    width: min(980px, calc(100vw - 32px));
     max-width: 95vw;
     max-height: min(780px, calc(100vh - 32px));
     box-shadow: var(--modal-shadow, 0 20px 25px -5px rgba(0, 0, 0, 0.1), 0 10px 10px -5px rgba(0, 0, 0, 0.04));
@@ -1839,7 +1839,7 @@ dialog.table-create-dialog::backdrop {
 }
 
 .table-create-label,
-.table-create-columns-heading {
+.table-create-column-headings {
     color: var(--ink);
     font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
     font-size: 0.82rem;
@@ -1876,10 +1876,12 @@ dialog.table-create-dialog::backdrop {
     color: var(--muted);
 }
 
+.table-create-foreign-key-target option,
 .table-create-custom-column-type option {
     color: var(--ink);
 }
 
+.table-create-foreign-key-target option[value=""],
 .table-create-custom-column-type option[value=""] {
     color: var(--muted);
 }
@@ -1898,40 +1900,130 @@ dialog.table-create-dialog::backdrop {
     gap: 10px;
 }
 
-.table-create-columns-heading {
-    font-weight: 600;
-}
-
 .table-create-column-list {
     display: grid;
     gap: 8px;
 }
 
-.table-create-column-row {
+.table-create-column-headings,
+.table-create-column-main {
     display: grid;
-    grid-template-columns: minmax(140px, 1.2fr) minmax(7.5rem, 0.7fr) minmax(12rem, 1fr) minmax(3.5rem, max-content) 32px;
+    grid-template-columns: minmax(140px, 1.2fr) minmax(7.5rem, 0.7fr) max-content 32px;
     align-items: center;
     gap: 8px;
     min-width: 0;
-    position: relative;
 }
 
-.table-create-primary-key {
-    display: inline-flex;
-    align-items: center;
-    gap: 6px;
-    color: var(--ink);
-    font-size: 0.85rem;
+.table-create-column-row {
+    display: grid;
+    gap: 8px;
     min-width: 0;
-    white-space: nowrap;
-    justify-self: center;
 }
 
-.table-create-primary-key-input {
+.table-create-column-headings {
+    color: var(--muted);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.72rem;
+    padding: 0 1px;
+}
+
+.table-create-column-details {
+    display: grid;
+    grid-template-columns: minmax(0, 1fr) minmax(0, 1fr);
+    align-items: start;
+    gap: 12px 16px;
+    padding: 12px;
+    border-left: 3px solid var(--rule);
+    background: #f8fafc;
+}
+
+.table-create-column-details[hidden] {
+    display: none;
+}
+
+.table-create-detail-field {
+    display: grid;
+    gap: 4px;
+    min-width: 0;
+}
+
+.table-create-detail-label {
+    color: var(--muted);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.72rem;
+}
+
+.table-create-detail-help {
+    color: var(--muted);
+    font-size: 0.82rem;
+    line-height: 1.35;
     margin: 0;
 }
 
-.table-create-remove-column {
+.table-create-detail-check {
+    display: inline-flex;
+    align-items: flex-start;
+    gap: 8px;
+    color: var(--ink);
+    font-size: 0.85rem;
+    line-height: 1.35;
+    min-width: 0;
+    white-space: normal;
+}
+
+.table-create-primary-key,
+.table-create-foreign-key-field {
+    grid-column: 1 / -1;
+}
+
+.table-create-detail-check input {
+    flex: 0 0 auto;
+    margin: 0.15rem 0 0;
+}
+
+.table-create-detail-check span {
+    min-width: 0;
+    overflow-wrap: break-word;
+}
+
+.table-create-move-controls {
+    display: grid;
+    grid-template-columns: repeat(4, 32px);
+    gap: 4px;
+    justify-content: start;
+}
+
+.table-create-more-options {
+    appearance: none;
+    border: 0;
+    background: transparent;
+    color: var(--accent);
+    cursor: pointer;
+    font: inherit;
+    font-size: 0.85rem;
+    justify-self: start;
+    padding: 0;
+    grid-column: 1 / -1;
+    text-align: left;
+}
+
+.table-create-more-options:hover,
+.table-create-more-options:focus {
+    text-decoration: underline;
+}
+
+.table-create-more-options:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 2px;
+}
+
+.table-create-more-options:disabled {
+    color: var(--muted);
+    cursor: default;
+    text-decoration: none;
+}
+
+.table-create-icon-button {
     appearance: none;
     border: 1px solid rgba(74, 85, 104, 0.24);
     background: transparent;
@@ -1945,17 +2037,17 @@ dialog.table-create-dialog::backdrop {
     padding: 0;
 }
 
-.table-create-remove-column:hover,
-.table-create-remove-column:focus {
+.table-create-icon-button:hover,
+.table-create-icon-button:focus {
     background: rgba(74, 85, 104, 0.07);
 }
 
-.table-create-remove-column:focus {
+.table-create-icon-button:focus {
     outline: 3px solid #b3d4ff;
     outline-offset: 1px;
 }
 
-.table-create-remove-column svg {
+.table-create-icon-button svg {
     display: block;
 }
 
@@ -1967,11 +2059,19 @@ dialog.table-create-dialog::backdrop {
     background: #fff;
     color: var(--accent);
     cursor: pointer;
+    display: inline-flex;
+    align-items: center;
+    gap: 6px;
     font: inherit;
     font-size: 0.85rem;
     padding: 7px 10px;
 }
 
+.table-create-add-column svg {
+    display: block;
+    flex: 0 0 auto;
+}
+
 .table-create-add-column:hover,
 .table-create-add-column:focus {
     background: #f8fafc;
@@ -2027,7 +2127,7 @@ dialog.table-create-dialog::backdrop {
 
 .table-create-dialog .btn:disabled,
 .table-create-add-column:disabled,
-.table-create-remove-column:disabled {
+.table-create-icon-button:disabled {
     opacity: 0.55;
     cursor: not-allowed;
 }
@@ -2198,7 +2298,7 @@ dialog.table-alter-dialog::backdrop {
 .table-alter-column-headings,
 .table-alter-column-main {
     display: grid;
-    grid-template-columns: minmax(140px, 1.2fr) minmax(7.5rem, 0.7fr) minmax(12rem, 1fr) max-content 32px;
+    grid-template-columns: minmax(140px, 1.2fr) minmax(7.5rem, 0.7fr) max-content 32px;
     align-items: center;
     gap: 8px;
     min-width: 0;
@@ -2384,11 +2484,19 @@ dialog.table-alter-dialog::backdrop {
     background: #fff;
     color: var(--accent);
     cursor: pointer;
+    display: inline-flex;
+    align-items: center;
+    gap: 6px;
     font: inherit;
     font-size: 0.85rem;
     padding: 7px 10px;
 }
 
+.table-alter-add-column svg {
+    display: block;
+    flex: 0 0 auto;
+}
+
 .table-alter-add-column:hover,
 .table-alter-add-column:focus {
     background: #f8fafc;
@@ -2504,21 +2612,16 @@ dialog.table-alter-dialog::backdrop {
         justify-self: end;
     }
 
-    .table-alter-custom-column-type {
-        grid-column: 1 / 3;
-        grid-row: 2;
-    }
-
     .table-alter-move-controls {
         grid-column: 1;
-        grid-row: 3;
+        grid-row: 2;
         justify-self: start;
     }
 
     .table-alter-more-options {
         align-self: center;
         grid-column: 2 / 4;
-        grid-row: 3;
+        grid-row: 2;
     }
 
     .table-alter-column-details {
@@ -2700,13 +2803,50 @@ dialog.table-alter-dialog::backdrop {
         padding-top: 0;
     }
 
+    .table-create-column-headings {
+        display: none;
+    }
+
     .table-create-column-row {
-        grid-template-columns: minmax(0, 1fr) 8.5rem 3.5rem 32px;
+        padding-bottom: 8px;
+        border-bottom: 1px solid var(--rule);
+    }
+
+    .table-create-column-main {
+        grid-template-columns: minmax(0, 1fr) minmax(7.5rem, 0.8fr) 32px;
         align-items: end;
     }
 
-    .table-create-custom-column-type {
-        grid-column: 1 / -1;
+    .table-create-column-name {
+        grid-column: 1;
+        grid-row: 1;
+    }
+
+    .table-create-column-type {
+        grid-column: 2;
+        grid-row: 1;
+    }
+
+    .table-create-remove-column {
+        grid-column: 3;
+        grid-row: 1;
+        justify-self: end;
+    }
+
+    .table-create-move-controls {
+        grid-column: 1;
+        grid-row: 2;
+        justify-self: start;
+    }
+
+    .table-create-more-options {
+        align-self: center;
+        grid-column: 2 / 4;
+        grid-row: 2;
+    }
+
+    .table-create-column-details {
+        grid-template-columns: 1fr;
     }
 
     .table-create-dialog .modal-footer {
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index cb964365..5a9d0962 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -64,12 +64,220 @@ function sqliteColumnTypeLabel(type) {
   if (type === "float") {
     return "floating point number";
   }
+  if (type === "real") {
+    return "floating point number";
+  }
   if (type === "blob") {
     return "blob - binary data";
   }
   return type;
 }
 
+function populateSqliteColumnTypeSelect(select, type, options) {
+  options.forEach(function (option) {
+    var optionElement = document.createElement("option");
+    optionElement.value = option;
+    optionElement.textContent = sqliteColumnTypeLabel(option);
+    select.appendChild(optionElement);
+  });
+  select.value = options.indexOf(type) === -1 ? options[0] : type;
+}
+
+function updateSelectPlaceholder(select, placeholderClass) {
+  select.classList.toggle(placeholderClass, !select.value);
+}
+
+function createCustomColumnTypeSelect(options, className, placeholderClass) {
+  var select = document.createElement("select");
+  select.className = className;
+  select.setAttribute("aria-label", "Custom column type");
+  var blankOption = document.createElement("option");
+  blankOption.value = "";
+  blankOption.textContent = "- custom type -";
+  select.appendChild(blankOption);
+  options.forEach(function (option) {
+    var optionElement = document.createElement("option");
+    optionElement.value = option.name;
+    optionElement.textContent = option.description
+      ? option.description + " (" + option.name + ")"
+      : option.name;
+    select.appendChild(optionElement);
+  });
+  updateSelectPlaceholder(select, placeholderClass);
+  return select;
+}
+
+var COLUMN_MOVE_ICONS = {
+  top: '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m18 17-6-6-6 6"></path><path d="m18 11-6-6-6 6"></path></svg>',
+  up: '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m18 15-6-6-6 6"></path></svg>',
+  down: '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m6 9 6 6 6-6"></path></svg>',
+  bottom:
+    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m6 7 6 6 6-6"></path><path d="m6 13 6 6 6-6"></path></svg>',
+  remove:
+    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M3 6h18"></path><path d="M8 6V4a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v2"></path><path d="M19 6l-1 14a2 2 0 0 1-2 2H8a2 2 0 0 1-2-2L5 6"></path></svg>',
+};
+
+function createSchemaDialogIconButton(prefix, modifier, ariaLabel, title, svg) {
+  var button = document.createElement("button");
+  button.type = "button";
+  button.className = prefix + "-icon-button " + prefix + "-" + modifier;
+  button.setAttribute("aria-label", ariaLabel);
+  button.title = title;
+  button.dataset.defaultTitle = title;
+  button.innerHTML = svg;
+  return button;
+}
+
+function createSchemaDialogMoveControls(prefix) {
+  var moveControls = document.createElement("div");
+  moveControls.className = prefix + "-move-controls";
+
+  var moveTopButton = createSchemaDialogIconButton(
+    prefix,
+    "move-top",
+    "Move column to top",
+    "Move column to top",
+    COLUMN_MOVE_ICONS.top,
+  );
+  var moveUpButton = createSchemaDialogIconButton(
+    prefix,
+    "move-up",
+    "Move column up",
+    "Move column up",
+    COLUMN_MOVE_ICONS.up,
+  );
+  var moveDownButton = createSchemaDialogIconButton(
+    prefix,
+    "move-down",
+    "Move column down",
+    "Move column down",
+    COLUMN_MOVE_ICONS.down,
+  );
+  var moveBottomButton = createSchemaDialogIconButton(
+    prefix,
+    "move-bottom",
+    "Move column to bottom",
+    "Move column to bottom",
+    COLUMN_MOVE_ICONS.bottom,
+  );
+
+  moveControls.appendChild(moveTopButton);
+  moveControls.appendChild(moveUpButton);
+  moveControls.appendChild(moveDownButton);
+  moveControls.appendChild(moveBottomButton);
+
+  return {
+    controls: moveControls,
+    topButton: moveTopButton,
+    upButton: moveUpButton,
+    downButton: moveDownButton,
+    bottomButton: moveBottomButton,
+  };
+}
+
+function createSchemaDialogMoreOptionsButton(prefix, details) {
+  var expandButton = document.createElement("button");
+  expandButton.type = "button";
+  expandButton.className = prefix + "-more-options";
+  expandButton.setAttribute("aria-label", "Toggle column settings");
+  expandButton.setAttribute("aria-controls", details.id);
+  expandButton.setAttribute("aria-expanded", details.hidden ? "false" : "true");
+  updateSchemaDialogMoreOptionsButton(expandButton);
+  return expandButton;
+}
+
+function updateSchemaDialogMoreOptionsButton(button) {
+  var isExpanded = button.getAttribute("aria-expanded") === "true";
+  button.textContent = isExpanded ? "v Hide options" : "> Advanced options";
+  button.title = isExpanded ? "Hide column settings" : "Show column settings";
+}
+
+function toggleSchemaDialogMoreOptions(button, details) {
+  var isExpanded = button.getAttribute("aria-expanded") === "true";
+  details.hidden = isExpanded;
+  button.setAttribute("aria-expanded", isExpanded ? "false" : "true");
+  updateSchemaDialogMoreOptionsButton(button);
+}
+
+function schemaDialogRows(state, prefix) {
+  return Array.prototype.slice.call(
+    state.columnList.querySelectorAll("." + prefix + "-column-row"),
+  );
+}
+
+function schemaDialogRowIsPrimaryKey(row, prefix) {
+  var input = row && row.querySelector("." + prefix + "-primary-key-input");
+  return !!(input && input.checked);
+}
+
+function schemaDialogFirstNonPrimaryRow(state, prefix) {
+  var rows = schemaDialogRows(state, prefix);
+  for (var i = 0; i < rows.length; i += 1) {
+    if (!schemaDialogRowIsPrimaryKey(rows[i], prefix)) {
+      return rows[i];
+    }
+  }
+  return null;
+}
+
+function updateSchemaDialogMoveButtons(state, prefix) {
+  if (!state || !state.columnList) {
+    return;
+  }
+  var firstNonPrimary = schemaDialogFirstNonPrimaryRow(state, prefix);
+  var rows = schemaDialogRows(state, prefix);
+  var hasPrimaryKeys = rows.some(function (row) {
+    return schemaDialogRowIsPrimaryKey(row, prefix);
+  });
+  var primaryKeyMoveTitle = "Primary key columns are always listed first";
+  rows.forEach(function (row) {
+    var isPrimaryKey = schemaDialogRowIsPrimaryKey(row, prefix);
+    var previous = row.previousElementSibling;
+    var next = row.nextElementSibling;
+    row
+      .querySelectorAll("." + prefix + "-move-controls button")
+      .forEach(function (button) {
+        button.title = button.dataset.defaultTitle || button.title;
+        button.disabled = state.isSaving || isPrimaryKey;
+        if (isPrimaryKey) {
+          button.title = primaryKeyMoveTitle;
+        }
+      });
+    if (!isPrimaryKey) {
+      var topButton = row.querySelector("." + prefix + "-move-top");
+      var upButton = row.querySelector("." + prefix + "-move-up");
+      var downButton = row.querySelector("." + prefix + "-move-down");
+      var bottomButton = row.querySelector("." + prefix + "-move-bottom");
+      topButton.disabled =
+        state.isSaving || !firstNonPrimary || row === firstNonPrimary;
+      upButton.disabled =
+        state.isSaving || !previous || schemaDialogRowIsPrimaryKey(previous, prefix);
+      downButton.disabled = state.isSaving || !next;
+      bottomButton.disabled = state.isSaving || !next;
+      if (hasPrimaryKeys && row === firstNonPrimary) {
+        topButton.title = primaryKeyMoveTitle;
+        upButton.title = primaryKeyMoveTitle;
+      }
+    }
+  });
+}
+
+function normalizeSchemaDialogPrimaryKeyRows(state, prefix) {
+  var rows = schemaDialogRows(state, prefix);
+  rows
+    .filter(function (row) {
+      return schemaDialogRowIsPrimaryKey(row, prefix);
+    })
+    .concat(
+      rows.filter(function (row) {
+        return !schemaDialogRowIsPrimaryKey(row, prefix);
+      }),
+    )
+    .forEach(function (row) {
+      state.columnList.appendChild(row);
+    });
+}
+
 function tableCreateCustomColumnTypes() {
   var data = databaseCreateTableData() || {};
   return data.customColumnTypes || [];
@@ -93,15 +301,205 @@ function tableCreateCustomTypeAppliesToSqliteType(option, sqliteType) {
   );
 }
 
+function tableCreateDialogRows(state) {
+  return schemaDialogRows(state, "table-create");
+}
+
+function tableCreateRowIsPrimaryKey(row) {
+  return schemaDialogRowIsPrimaryKey(row, "table-create");
+}
+
+function tableCreateFirstNonPrimaryRow(state) {
+  return schemaDialogFirstNonPrimaryRow(state, "table-create");
+}
+
+function updateTableCreateMoveButtons(state) {
+  updateSchemaDialogMoveButtons(state, "table-create");
+}
+
+function tableCreateTypeAffinity(type) {
+  if (type === "float") {
+    return "real";
+  }
+  return type;
+}
+
+function foreignKeyTypesCompatible(sourceAffinity, targetAffinity) {
+  if (sourceAffinity === targetAffinity) {
+    return true;
+  }
+  var numericAffinities = ["integer", "real", "numeric"];
+  if (sourceAffinity === "numeric") {
+    return numericAffinities.indexOf(targetAffinity) !== -1;
+  }
+  if (targetAffinity === "numeric") {
+    return numericAffinities.indexOf(sourceAffinity) !== -1;
+  }
+  return false;
+}
+
+function tableCreateForeignKeyTargetKey(target) {
+  return target.fk_table + "\u001f" + target.fk_column;
+}
+
+function tableCreateForeignKeyTargetLabel(target) {
+  return (
+    target.fk_table +
+    "." +
+    target.fk_column +
+    " (" +
+    sqliteColumnTypeLabel(target.type) +
+    ")"
+  );
+}
+
+function tableCreateForeignKeyTargetsUrl() {
+  var data = databaseCreateTableData() || {};
+  if (data.foreignKeyTargetsPath) {
+    return data.foreignKeyTargetsPath;
+  }
+  if (!data.path) {
+    return null;
+  }
+  return data.path.replace(/\/-\/create$/, "/-/foreign-key-targets");
+}
+
+function populateTableCreateForeignKeySelect(select, state, sourceType) {
+  var previousKey = select.value || select.dataset.selectedKey || "";
+  select.textContent = "";
+
+  var blankOption = document.createElement("option");
+  blankOption.value = "";
+  blankOption.textContent = "- no foreign key -";
+  select.appendChild(blankOption);
+
+  if (state.foreignKeyTargetsLoading) {
+    var loadingOption = document.createElement("option");
+    loadingOption.value = "";
+    loadingOption.disabled = true;
+    loadingOption.textContent = "Loading foreign keys...";
+    select.appendChild(loadingOption);
+  } else if (state.foreignKeyTargetsError) {
+    var errorOption = document.createElement("option");
+    errorOption.value = "";
+    errorOption.disabled = true;
+    errorOption.textContent = "Could not load foreign keys";
+    select.appendChild(errorOption);
+  } else {
+    var sourceAffinity = tableCreateTypeAffinity(sourceType);
+    (state.foreignKeyTargets || []).forEach(function (target) {
+      if (!foreignKeyTypesCompatible(sourceAffinity, target.type)) {
+        return;
+      }
+      var optionElement = document.createElement("option");
+      optionElement.value = tableCreateForeignKeyTargetKey(target);
+      optionElement.dataset.fkTable = target.fk_table;
+      optionElement.dataset.fkColumn = target.fk_column;
+      optionElement.textContent = tableCreateForeignKeyTargetLabel(target);
+      select.appendChild(optionElement);
+    });
+  }
+
+  select.value = previousKey;
+  if (select.value !== previousKey) {
+    select.value = "";
+  }
+  select.dataset.selectedKey = select.value;
+  select.disabled = state.isSaving || select.options.length <= 1;
+  updateSelectPlaceholder(select, "table-create-input-placeholder");
+}
+
+function syncTableCreateForeignKeyOptions(row, state) {
+  var typeSelect = row.querySelector(".table-create-column-type");
+  var foreignKeySelect = row.querySelector(".table-create-foreign-key-target");
+  if (!typeSelect || !foreignKeySelect) {
+    return;
+  }
+  populateTableCreateForeignKeySelect(
+    foreignKeySelect,
+    state,
+    typeSelect.value,
+  );
+}
+
+function refreshTableCreateForeignKeyControls(state) {
+  tableCreateDialogRows(state).forEach(function (row, index) {
+    if (index > 0) {
+      syncTableCreateForeignKeyOptions(row, state);
+    }
+  });
+}
+
+function updateTableCreateColumnRules(state) {
+  tableCreateDialogRows(state).forEach(function (row, index) {
+    var isFirstColumn = index === 0;
+    var pkLabel = row.querySelector(".table-create-primary-key");
+    var pkInput = row.querySelector(".table-create-primary-key-input");
+    var foreignKeyField = row.querySelector(".table-create-foreign-key-field");
+    var foreignKeySelect = row.querySelector(".table-create-foreign-key-target");
+
+    if (pkLabel && pkInput) {
+      pkLabel.hidden = !isFirstColumn;
+      if (!isFirstColumn) {
+        pkInput.checked = false;
+      }
+    }
+
+    if (foreignKeyField && foreignKeySelect) {
+      foreignKeyField.hidden = isFirstColumn;
+      if (isFirstColumn) {
+        foreignKeySelect.value = "";
+        foreignKeySelect.dataset.selectedKey = "";
+        foreignKeySelect.disabled = true;
+        updateTableCreateCustomColumnTypePlaceholder(foreignKeySelect);
+      } else {
+        syncTableCreateForeignKeyOptions(row, state);
+      }
+    }
+  });
+  updateTableCreateMoveButtons(state);
+}
+
+async function loadTableCreateForeignKeyTargets(state) {
+  var url = tableCreateForeignKeyTargetsUrl();
+  if (!url || !window.fetch) {
+    state.foreignKeyTargets = [];
+    state.foreignKeyTargetsLoading = false;
+    refreshTableCreateForeignKeyControls(state);
+    return;
+  }
+  state.foreignKeyTargets = [];
+  state.foreignKeyTargetsError = null;
+  state.foreignKeyTargetsLoading = true;
+  refreshTableCreateForeignKeyControls(state);
+  try {
+    var response = await fetch(url, {
+      headers: {
+        Accept: "application/json",
+      },
+    });
+    var data = await response.json();
+    if (!response.ok || data.ok === false) {
+      throw rowMutationRequestError(response, data);
+    }
+    state.foreignKeyTargets = data.targets || [];
+  } catch (error) {
+    state.foreignKeyTargets = [];
+    state.foreignKeyTargetsError = error;
+  } finally {
+    state.foreignKeyTargetsLoading = false;
+    refreshTableCreateForeignKeyControls(state);
+  }
+}
+
 function tableCreateDialogSignature(state) {
   if (!state || !state.form) {
     return "";
   }
-  var columns = [];
-  state.columnList
-    .querySelectorAll(".table-create-column-row")
-    .forEach(function (row) {
-      columns.push({
+  return JSON.stringify({
+    table: state.tableName.value,
+    columns: tableCreateDialogRows(state).map(function (row) {
+      return {
         name: row.querySelector(".table-create-column-name").value,
         type: row.querySelector(".table-create-column-type").value,
         customType:
@@ -111,11 +509,14 @@ function tableCreateDialogSignature(state) {
             }
           ).value || "",
         pk: row.querySelector(".table-create-primary-key-input").checked,
-      });
-    });
-  return JSON.stringify({
-    table: state.tableName.value,
-    columns: columns,
+        foreignKey:
+          (
+            row.querySelector(".table-create-foreign-key-target") || {
+              value: "",
+            }
+          ).value || "",
+      };
+    }),
   });
 }
 
@@ -151,42 +552,28 @@ function setTableCreateDialogSaving(state, isSaving) {
     .forEach(function (control) {
       control.disabled = isSaving;
     });
+  if (!isSaving) {
+    updateTableCreateColumnRules(state);
+  }
+  updateTableCreateMoveButtons(state);
 }
 
 function tableCreateSelectTypeValue(select, type) {
   var options = tableCreateColumnTypes();
-  options.forEach(function (option) {
-    var optionElement = document.createElement("option");
-    optionElement.value = option;
-    optionElement.textContent = sqliteColumnTypeLabel(option);
-    select.appendChild(optionElement);
-  });
-  select.value = options.indexOf(type) === -1 ? options[0] : type;
+  populateSqliteColumnTypeSelect(select, type, options);
 }
 
 function updateTableCreateCustomColumnTypePlaceholder(select) {
-  select.classList.toggle("table-create-input-placeholder", !select.value);
+  updateSelectPlaceholder(select, "table-create-input-placeholder");
 }
 
 function createTableCustomColumnTypeSelect() {
   var options = tableCreateCustomColumnTypes();
-  var select = document.createElement("select");
-  select.className = "table-create-input table-create-custom-column-type";
-  select.setAttribute("aria-label", "Custom column type");
-  var blankOption = document.createElement("option");
-  blankOption.value = "";
-  blankOption.textContent = "- custom type -";
-  select.appendChild(blankOption);
-  options.forEach(function (option) {
-    var optionElement = document.createElement("option");
-    optionElement.value = option.name;
-    optionElement.textContent = option.description
-      ? option.description + " (" + option.name + ")"
-      : option.name;
-    select.appendChild(optionElement);
-  });
-  updateTableCreateCustomColumnTypePlaceholder(select);
-  return select;
+  return createCustomColumnTypeSelect(
+    options,
+    "table-create-input table-create-custom-column-type",
+    "table-create-input-placeholder",
+  );
 }
 
 function syncTableCreateCustomTypeForSqliteType(row) {
@@ -209,6 +596,19 @@ function createTableColumnRow(state, column) {
   var row = document.createElement("div");
   row.className = "table-create-column-row";
 
+  var main = document.createElement("div");
+  main.className = "table-create-column-main";
+
+  var details = document.createElement("div");
+  details.className = "table-create-column-details";
+  details.id = "table-create-column-details-" + index;
+  details.hidden = !(column && column.expanded);
+
+  var expandButton = createSchemaDialogMoreOptionsButton(
+    "table-create",
+    details,
+  );
+
   var nameId = "table-create-column-name-" + index;
   var nameLabel = document.createElement("label");
   nameLabel.className = "table-create-column-label";
@@ -228,40 +628,88 @@ function createTableColumnRow(state, column) {
   typeSelect.setAttribute("aria-label", "Column type");
   tableCreateSelectTypeValue(typeSelect, column && column.type);
 
-  var customTypeSelect = createTableCustomColumnTypeSelect();
-  if (column && column.customType) {
-    customTypeSelect.value = column.customType;
+  var customTypeSelect = null;
+  var customTypeField = null;
+  if (tableCreateCustomColumnTypes().length) {
+    var customTypeId = "table-create-column-custom-type-" + index;
+    customTypeField = document.createElement("div");
+    customTypeField.className =
+      "table-create-detail-field table-create-custom-type-field";
+    var customTypeLabel = document.createElement("label");
+    customTypeLabel.className = "table-create-detail-label";
+    customTypeLabel.setAttribute("for", customTypeId);
+    customTypeLabel.textContent = "Custom type";
+    customTypeSelect = createTableCustomColumnTypeSelect();
+    customTypeSelect.id = customTypeId;
+    customTypeSelect.value = column && column.customType ? column.customType : "";
+    updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+    customTypeField.appendChild(customTypeLabel);
+    customTypeField.appendChild(customTypeSelect);
   }
-  updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
 
   var pkLabel = document.createElement("label");
-  pkLabel.className = "table-create-primary-key";
+  pkLabel.className = "table-create-detail-check table-create-primary-key";
   var pkInput = document.createElement("input");
   pkInput.type = "checkbox";
   pkInput.className = "table-create-primary-key-input";
   pkInput.checked = !!(column && column.primaryKey);
   var pkText = document.createElement("span");
-  pkText.textContent = "PK";
-  pkText.title = "Primary key";
+  var pkStrong = document.createElement("strong");
+  pkStrong.textContent = "Primary key";
+  pkText.appendChild(pkStrong);
+  pkText.appendChild(
+    document.createTextNode(" This ID uniquely identifies the record"),
+  );
   pkLabel.appendChild(pkInput);
   pkLabel.appendChild(pkText);
 
-  var removeButton = document.createElement("button");
-  removeButton.type = "button";
-  removeButton.className = "table-create-remove-column";
-  removeButton.setAttribute("aria-label", "Remove column");
-  removeButton.title = "Remove column";
-  removeButton.innerHTML =
-    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M3 6h18"></path><path d="M8 6V4a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v2"></path><path d="M19 6l-1 14a2 2 0 0 1-2 2H8a2 2 0 0 1-2-2L5 6"></path></svg>';
+  var foreignKeyId = "table-create-column-foreign-key-" + index;
+  var foreignKeyHelpId = "table-create-column-foreign-key-help-" + index;
+  var foreignKeyField = document.createElement("div");
+  foreignKeyField.className =
+    "table-create-detail-field table-create-foreign-key-field";
+  var foreignKeyLabel = document.createElement("label");
+  foreignKeyLabel.className = "table-create-detail-label";
+  foreignKeyLabel.setAttribute("for", foreignKeyId);
+  foreignKeyLabel.textContent = "Foreign key";
+  var foreignKeyHelp = document.createElement("p");
+  foreignKeyHelp.id = foreignKeyHelpId;
+  foreignKeyHelp.className = "table-create-detail-help";
+  foreignKeyHelp.textContent = "Link this column to another table.";
+  var foreignKeySelect = document.createElement("select");
+  foreignKeySelect.id = foreignKeyId;
+  foreignKeySelect.className =
+    "table-create-input table-create-foreign-key-target";
+  foreignKeySelect.setAttribute("aria-label", "Foreign key target");
+  foreignKeySelect.setAttribute("aria-describedby", foreignKeyHelpId);
+  foreignKeyField.appendChild(foreignKeyLabel);
+  foreignKeyField.appendChild(foreignKeyHelp);
+  foreignKeyField.appendChild(foreignKeySelect);
 
-  row.appendChild(nameLabel);
-  row.appendChild(nameInput);
-  row.appendChild(typeSelect);
-  if (tableCreateCustomColumnTypes().length) {
-    row.appendChild(customTypeSelect);
+  var moveControls = createSchemaDialogMoveControls("table-create");
+
+  var removeButton = createSchemaDialogIconButton(
+    "table-create",
+    "remove-column",
+    "Remove column",
+    "Remove column",
+    COLUMN_MOVE_ICONS.remove,
+  );
+
+  main.appendChild(nameLabel);
+  main.appendChild(nameInput);
+  main.appendChild(typeSelect);
+  main.appendChild(moveControls.controls);
+  main.appendChild(removeButton);
+  main.appendChild(expandButton);
+
+  if (customTypeField) {
+    details.appendChild(customTypeField);
   }
-  row.appendChild(pkLabel);
-  row.appendChild(removeButton);
+  details.appendChild(foreignKeyField);
+  details.appendChild(pkLabel);
+  row.appendChild(main);
+  row.appendChild(details);
 
   removeButton.addEventListener("click", function () {
     if (state.isSaving) {
@@ -269,6 +717,7 @@ function createTableColumnRow(state, column) {
     }
     row.remove();
     clearTableCreateDialogError(state);
+    updateTableCreateColumnRules(state);
     var nextInput = state.columnList.querySelector(".table-create-column-name");
     if (nextInput) {
       nextInput.focus();
@@ -283,21 +732,94 @@ function createTableColumnRow(state, column) {
   typeSelect.addEventListener("change", function () {
     clearTableCreateDialogError(state);
     syncTableCreateCustomTypeForSqliteType(row);
+    syncTableCreateForeignKeyOptions(row, state);
   });
-  customTypeSelect.addEventListener("change", function () {
-    clearTableCreateDialogError(state);
-    updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
-    var option = tableCreateCustomColumnType(customTypeSelect.value);
-    if (
-      option &&
-      option.fixedSqliteType &&
-      tableCreateColumnTypes().indexOf(option.fixedSqliteType) !== -1
-    ) {
-      typeSelect.value = option.fixedSqliteType;
-    }
-  });
+  if (customTypeSelect) {
+    customTypeSelect.addEventListener("change", function () {
+      clearTableCreateDialogError(state);
+      updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+      var option = tableCreateCustomColumnType(customTypeSelect.value);
+      if (
+        option &&
+        option.fixedSqliteType &&
+        tableCreateColumnTypes().indexOf(option.fixedSqliteType) !== -1
+      ) {
+        typeSelect.value = option.fixedSqliteType;
+        syncTableCreateForeignKeyOptions(row, state);
+      }
+    });
+  }
   pkInput.addEventListener("change", function () {
     clearTableCreateDialogError(state);
+    updateTableCreateColumnRules(state);
+  });
+  foreignKeySelect.addEventListener("change", function () {
+    foreignKeySelect.dataset.selectedKey = foreignKeySelect.value;
+    clearTableCreateDialogError(state);
+    updateTableCreateCustomColumnTypePlaceholder(foreignKeySelect);
+  });
+
+  expandButton.addEventListener("click", function () {
+    toggleSchemaDialogMoreOptions(expandButton, details);
+  });
+
+  moveControls.topButton.addEventListener("click", function () {
+    var first = tableCreateFirstNonPrimaryRow(state);
+    if (
+      state.isSaving ||
+      tableCreateRowIsPrimaryKey(row) ||
+      !first ||
+      first === row
+    ) {
+      return;
+    }
+    state.columnList.insertBefore(row, first);
+    clearTableCreateDialogError(state);
+    updateTableCreateColumnRules(state);
+    row.querySelector(".table-create-column-name").focus();
+  });
+
+  moveControls.upButton.addEventListener("click", function () {
+    var previous = row.previousElementSibling;
+    if (
+      state.isSaving ||
+      tableCreateRowIsPrimaryKey(row) ||
+      !previous ||
+      tableCreateRowIsPrimaryKey(previous)
+    ) {
+      return;
+    }
+    state.columnList.insertBefore(row, previous);
+    clearTableCreateDialogError(state);
+    updateTableCreateColumnRules(state);
+    row.querySelector(".table-create-column-name").focus();
+  });
+
+  moveControls.downButton.addEventListener("click", function () {
+    var next = row.nextElementSibling;
+    if (state.isSaving || tableCreateRowIsPrimaryKey(row) || !next) {
+      return;
+    }
+    state.columnList.insertBefore(next, row);
+    clearTableCreateDialogError(state);
+    updateTableCreateColumnRules(state);
+    row.querySelector(".table-create-column-name").focus();
+  });
+
+  moveControls.bottomButton.addEventListener("click", function () {
+    var last = state.columnList.lastElementChild;
+    if (
+      state.isSaving ||
+      tableCreateRowIsPrimaryKey(row) ||
+      !last ||
+      last === row
+    ) {
+      return;
+    }
+    state.columnList.appendChild(row);
+    clearTableCreateDialogError(state);
+    updateTableCreateColumnRules(state);
+    row.querySelector(".table-create-column-name").focus();
   });
 
   return row;
@@ -306,6 +828,7 @@ function createTableColumnRow(state, column) {
 function addTableCreateColumn(state, column) {
   var row = createTableColumnRow(state, column || { type: "text" });
   state.columnList.appendChild(row);
+  updateTableCreateColumnRules(state);
   return row;
 }
 
@@ -323,6 +846,7 @@ function resetTableCreateDialog(state) {
     type: "text",
     primaryKey: false,
   });
+  updateTableCreateColumnRules(state);
   state.initialSignature = tableCreateDialogSignature(state);
 }
 
@@ -332,16 +856,32 @@ function collectTableCreatePayload(state) {
     columns: [],
   };
   var primaryKeys = [];
-  state.columnList
-    .querySelectorAll(".table-create-column-row")
-    .forEach(function (row) {
-      var name = row.querySelector(".table-create-column-name").value.trim();
-      var type = row.querySelector(".table-create-column-type").value;
-      payload.columns.push({ name: name, type: type });
-      if (row.querySelector(".table-create-primary-key-input").checked) {
-        primaryKeys.push(name);
-      }
-    });
+  tableCreateDialogRows(state).forEach(function (row, index) {
+    var name = row.querySelector(".table-create-column-name").value.trim();
+    var type = row.querySelector(".table-create-column-type").value;
+    var column = { name: name, type: type };
+    var foreignKeySelect = row.querySelector(".table-create-foreign-key-target");
+    var foreignKeyOption =
+      foreignKeySelect && foreignKeySelect.selectedOptions
+        ? foreignKeySelect.selectedOptions[0]
+        : null;
+    if (
+      index > 0 &&
+      foreignKeyOption &&
+      foreignKeyOption.dataset.fkTable &&
+      foreignKeyOption.dataset.fkColumn
+    ) {
+      column.fk_table = foreignKeyOption.dataset.fkTable;
+      column.fk_column = foreignKeyOption.dataset.fkColumn;
+    }
+    payload.columns.push(column);
+    if (
+      index === 0 &&
+      row.querySelector(".table-create-primary-key-input").checked
+    ) {
+      primaryKeys.push(name);
+    }
+  });
   if (primaryKeys.length === 1) {
     payload.pk = primaryKeys[0];
   } else if (primaryKeys.length > 1) {
@@ -352,21 +892,19 @@ function collectTableCreatePayload(state) {
 
 function collectTableCreateColumnTypeAssignments(state) {
   var assignments = [];
-  state.columnList
-    .querySelectorAll(".table-create-column-row")
-    .forEach(function (row) {
-      var customTypeSelect = row.querySelector(
-        ".table-create-custom-column-type",
-      );
-      if (!customTypeSelect || !customTypeSelect.value) {
-        return;
-      }
-      assignments.push({
-        column: row.querySelector(".table-create-column-name").value.trim(),
-        columnType: customTypeSelect.value,
-        sqliteType: row.querySelector(".table-create-column-type").value,
-      });
+  tableCreateDialogRows(state).forEach(function (row) {
+    var customTypeSelect = row.querySelector(
+      ".table-create-custom-column-type",
+    );
+    if (!customTypeSelect || !customTypeSelect.value) {
+      return;
+    }
+    assignments.push({
+      column: row.querySelector(".table-create-column-name").value.trim(),
+      columnType: customTypeSelect.value,
+      sqliteType: row.querySelector(".table-create-column-type").value,
     });
+  });
   return assignments;
 }
 
@@ -604,9 +1142,14 @@ function ensureTableCreateDialog(manager) {
           <input class="table-create-input table-create-table-name" id="table-create-name" type="text" name="table" required autocomplete="off">
         </div>
         <div class="table-create-columns">
-          <div class="table-create-columns-heading">Columns</div>
+          <div class="table-create-column-headings" aria-hidden="true">
+            <span>Column</span>
+            <span>Type</span>
+            <span>Move</span>
+            <span></span>
+          </div>
           <div class="table-create-column-list"></div>
-          <button type="button" class="table-create-add-column">Add column</button>
+          <button type="button" class="table-create-add-column"><svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M5 12h14"></path><path d="M12 5v14"></path></svg><span>Add column</span></button>
         </div>
       </div>
       <div class="modal-footer">
@@ -633,6 +1176,9 @@ function ensureTableCreateDialog(manager) {
     isSaving: false,
     initialSignature: "",
     nextColumnIndex: 0,
+    foreignKeyTargets: [],
+    foreignKeyTargetsError: null,
+    foreignKeyTargetsLoading: false,
     manager: manager,
   };
 
@@ -713,6 +1259,7 @@ function openTableCreateDialog(button, manager) {
   state.title.textContent = "Create a table in " + data.databaseName;
   clearTableCreateDialogError(state);
   resetTableCreateDialog(state);
+  loadTableCreateForeignKeyTargets(state);
   if (!state.dialog.open) {
     state.dialog.showModal();
   }
@@ -877,9 +1424,7 @@ function tableAlterCustomTypeAppliesToSqliteType(option, sqliteType) {
 }
 
 function tableAlterDialogRows(state) {
-  return Array.prototype.slice.call(
-    state.columnList.querySelectorAll(".table-alter-column-row"),
-  );
+  return schemaDialogRows(state, "table-alter");
 }
 
 function tableAlterRowSignature(row) {
@@ -930,76 +1475,19 @@ function updateTableAlterSaveButtonState(state) {
 }
 
 function tableAlterRowIsPrimaryKey(row) {
-  var input = row && row.querySelector(".table-alter-primary-key-input");
-  return !!(input && input.checked);
+  return schemaDialogRowIsPrimaryKey(row, "table-alter");
 }
 
 function tableAlterFirstNonPrimaryRow(state) {
-  var rows = tableAlterDialogRows(state);
-  for (var i = 0; i < rows.length; i += 1) {
-    if (!tableAlterRowIsPrimaryKey(rows[i])) {
-      return rows[i];
-    }
-  }
-  return null;
+  return schemaDialogFirstNonPrimaryRow(state, "table-alter");
 }
 
 function updateTableAlterMoveButtons(state) {
-  if (!state || !state.columnList) {
-    return;
-  }
-  var firstNonPrimary = tableAlterFirstNonPrimaryRow(state);
-  var rows = tableAlterDialogRows(state);
-  var hasPrimaryKeys = rows.some(function (row) {
-    return tableAlterRowIsPrimaryKey(row);
-  });
-  var primaryKeyMoveTitle = "Primary key columns are always listed first";
-  rows.forEach(function (row) {
-    var isPrimaryKey = tableAlterRowIsPrimaryKey(row);
-    var previous = row.previousElementSibling;
-    var next = row.nextElementSibling;
-    row
-      .querySelectorAll(".table-alter-move-controls button")
-      .forEach(function (button) {
-        button.title = button.dataset.defaultTitle || button.title;
-        button.disabled = state.isSaving || isPrimaryKey;
-        if (isPrimaryKey) {
-          button.title = primaryKeyMoveTitle;
-        }
-      });
-    if (!isPrimaryKey) {
-      var topButton = row.querySelector(".table-alter-move-top");
-      var upButton = row.querySelector(".table-alter-move-up");
-      var downButton = row.querySelector(".table-alter-move-down");
-      var bottomButton = row.querySelector(".table-alter-move-bottom");
-      topButton.disabled =
-        state.isSaving || !firstNonPrimary || row === firstNonPrimary;
-      upButton.disabled =
-        state.isSaving || !previous || tableAlterRowIsPrimaryKey(previous);
-      downButton.disabled = state.isSaving || !next;
-      bottomButton.disabled = state.isSaving || !next;
-      if (hasPrimaryKeys && row === firstNonPrimary) {
-        topButton.title = primaryKeyMoveTitle;
-        upButton.title = primaryKeyMoveTitle;
-      }
-    }
-  });
+  updateSchemaDialogMoveButtons(state, "table-alter");
 }
 
 function normalizeTableAlterPrimaryKeyRows(state) {
-  var rows = tableAlterDialogRows(state);
-  rows
-    .filter(function (row) {
-      return tableAlterRowIsPrimaryKey(row);
-    })
-    .concat(
-      rows.filter(function (row) {
-        return !tableAlterRowIsPrimaryKey(row);
-      }),
-    )
-    .forEach(function (row) {
-      state.columnList.appendChild(row);
-    });
+  normalizeSchemaDialogPrimaryKeyRows(state, "table-alter");
 }
 
 function clearTableAlterDialogError(state) {
@@ -1049,38 +1537,20 @@ function tableAlterSaveButtonText(state) {
 
 function tableAlterSelectTypeValue(select, type) {
   var options = tableAlterColumnTypes();
-  options.forEach(function (option) {
-    var optionElement = document.createElement("option");
-    optionElement.value = option;
-    optionElement.textContent = sqliteColumnTypeLabel(option);
-    select.appendChild(optionElement);
-  });
-  select.value = options.indexOf(type) === -1 ? options[0] : type;
+  populateSqliteColumnTypeSelect(select, type, options);
 }
 
 function updateTableAlterCustomColumnTypePlaceholder(select) {
-  select.classList.toggle("table-alter-input-placeholder", !select.value);
+  updateSelectPlaceholder(select, "table-alter-input-placeholder");
 }
 
 function createTableAlterCustomColumnTypeSelect() {
   var options = tableAlterCustomColumnTypes();
-  var select = document.createElement("select");
-  select.className = "table-alter-input table-alter-custom-column-type";
-  select.setAttribute("aria-label", "Custom column type");
-  var blankOption = document.createElement("option");
-  blankOption.value = "";
-  blankOption.textContent = "- custom type -";
-  select.appendChild(blankOption);
-  options.forEach(function (option) {
-    var optionElement = document.createElement("option");
-    optionElement.value = option.name;
-    optionElement.textContent = option.description
-      ? option.description + " (" + option.name + ")"
-      : option.name;
-    select.appendChild(optionElement);
-  });
-  updateTableAlterCustomColumnTypePlaceholder(select);
-  return select;
+  return createCustomColumnTypeSelect(
+    options,
+    "table-alter-input table-alter-custom-column-type",
+    "table-alter-input-placeholder",
+  );
 }
 
 function syncTableAlterCustomTypeForSqliteType(row) {
@@ -1112,7 +1582,7 @@ function tableAlterSelectDefaultExprValue(select, value) {
 }
 
 function updateTableAlterDefaultExprPlaceholder(select) {
-  select.classList.toggle("table-alter-input-placeholder", !select.value);
+  updateSelectPlaceholder(select, "table-alter-input-placeholder");
 }
 
 function syncTableAlterDefaultControls(row) {
@@ -1159,22 +1629,10 @@ function createTableAlterColumnRow(state, column) {
   details.id = "table-alter-column-details-" + index;
   details.hidden = !(column && column.expanded);
 
-  var expandButton = document.createElement("button");
-  expandButton.type = "button";
-  expandButton.className = "table-alter-more-options";
-  expandButton.setAttribute("aria-label", "Toggle column settings");
-  expandButton.setAttribute("aria-controls", details.id);
-  expandButton.setAttribute("aria-expanded", details.hidden ? "false" : "true");
-  function updateExpandButton() {
-    var isExpanded = expandButton.getAttribute("aria-expanded") === "true";
-    expandButton.textContent = isExpanded
-      ? "v Hide options"
-      : "> Advanced options";
-    expandButton.title = isExpanded
-      ? "Hide column settings"
-      : "Show column settings";
-  }
-  updateExpandButton();
+  var expandButton = createSchemaDialogMoreOptionsButton(
+    "table-alter",
+    details,
+  );
 
   var nameId = "table-alter-column-name-" + index;
   var nameLabel = document.createElement("label");
@@ -1196,10 +1654,22 @@ function createTableAlterColumnRow(state, column) {
   tableAlterSelectTypeValue(typeSelect, column && column.type);
 
   var customTypeSelect = null;
+  var customTypeField = null;
   if (tableAlterCustomColumnTypes().length) {
+    var customTypeId = "table-alter-column-custom-type-" + index;
+    customTypeField = document.createElement("div");
+    customTypeField.className =
+      "table-alter-detail-field table-alter-custom-type-field";
+    var customTypeLabel = document.createElement("label");
+    customTypeLabel.className = "table-alter-detail-label";
+    customTypeLabel.setAttribute("for", customTypeId);
+    customTypeLabel.textContent = "Custom type";
     customTypeSelect = createTableAlterCustomColumnTypeSelect();
+    customTypeSelect.id = customTypeId;
     customTypeSelect.value = originalCustomType;
     updateTableAlterCustomColumnTypePlaceholder(customTypeSelect);
+    customTypeField.appendChild(customTypeLabel);
+    customTypeField.appendChild(customTypeSelect);
   }
 
   var notNullLabel = document.createElement("label");
@@ -1262,76 +1732,30 @@ function createTableAlterColumnRow(state, column) {
   pkStrong.textContent = "Primary key";
   pkText.appendChild(pkStrong);
   pkText.appendChild(
-    document.createTextNode(" An ID that uniquely identifies this record"),
+    document.createTextNode(" This ID uniquely identifies the record"),
   );
   pkLabel.appendChild(pkInput);
   pkLabel.appendChild(pkText);
 
-  var moveControls = document.createElement("div");
-  moveControls.className = "table-alter-move-controls";
+  var moveControls = createSchemaDialogMoveControls("table-alter");
 
-  var moveTopButton = document.createElement("button");
-  moveTopButton.type = "button";
-  moveTopButton.className = "table-alter-icon-button table-alter-move-top";
-  moveTopButton.setAttribute("aria-label", "Move column to top");
-  moveTopButton.title = "Move column to top";
-  moveTopButton.dataset.defaultTitle = moveTopButton.title;
-  moveTopButton.innerHTML =
-    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m18 17-6-6-6 6"></path><path d="m18 11-6-6-6 6"></path></svg>';
-
-  var moveUpButton = document.createElement("button");
-  moveUpButton.type = "button";
-  moveUpButton.className = "table-alter-icon-button table-alter-move-up";
-  moveUpButton.setAttribute("aria-label", "Move column up");
-  moveUpButton.title = "Move column up";
-  moveUpButton.dataset.defaultTitle = moveUpButton.title;
-  moveUpButton.innerHTML =
-    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m18 15-6-6-6 6"></path></svg>';
-
-  var moveDownButton = document.createElement("button");
-  moveDownButton.type = "button";
-  moveDownButton.className = "table-alter-icon-button table-alter-move-down";
-  moveDownButton.setAttribute("aria-label", "Move column down");
-  moveDownButton.title = "Move column down";
-  moveDownButton.dataset.defaultTitle = moveDownButton.title;
-  moveDownButton.innerHTML =
-    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m6 9 6 6 6-6"></path></svg>';
-
-  var moveBottomButton = document.createElement("button");
-  moveBottomButton.type = "button";
-  moveBottomButton.className =
-    "table-alter-icon-button table-alter-move-bottom";
-  moveBottomButton.setAttribute("aria-label", "Move column to bottom");
-  moveBottomButton.title = "Move column to bottom";
-  moveBottomButton.dataset.defaultTitle = moveBottomButton.title;
-  moveBottomButton.innerHTML =
-    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m6 7 6 6 6-6"></path><path d="m6 13 6 6 6-6"></path></svg>';
-
-  var removeButton = document.createElement("button");
-  removeButton.type = "button";
-  removeButton.className = "table-alter-icon-button table-alter-remove-column";
-  removeButton.setAttribute(
-    "aria-label",
+  var removeButton = createSchemaDialogIconButton(
+    "table-alter",
+    "remove-column",
     existing ? "Drop column" : "Remove column",
+    existing ? "Drop column" : "Remove column",
+    COLUMN_MOVE_ICONS.remove,
   );
-  removeButton.title = existing ? "Drop column" : "Remove column";
-  removeButton.innerHTML =
-    '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M3 6h18"></path><path d="M8 6V4a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v2"></path><path d="M19 6l-1 14a2 2 0 0 1-2 2H8a2 2 0 0 1-2-2L5 6"></path></svg>';
-
-  moveControls.appendChild(moveTopButton);
-  moveControls.appendChild(moveUpButton);
-  moveControls.appendChild(moveDownButton);
-  moveControls.appendChild(moveBottomButton);
   main.appendChild(nameLabel);
   main.appendChild(nameInput);
   main.appendChild(typeSelect);
-  if (customTypeSelect) {
-    main.appendChild(customTypeSelect);
-  }
-  main.appendChild(moveControls);
+  main.appendChild(moveControls.controls);
   main.appendChild(removeButton);
   main.appendChild(expandButton);
 
+  if (customTypeField) {
+    details.appendChild(customTypeField);
+  }
   details.appendChild(notNullLabel);
   details.appendChild(defaultField);
   details.appendChild(defaultExprField);
@@ -1382,10 +1806,7 @@ function createTableAlterColumnRow(state, column) {
   });
 
   expandButton.addEventListener("click", function () {
-    var isExpanded = expandButton.getAttribute("aria-expanded") === "true";
-    details.hidden = isExpanded;
-    expandButton.setAttribute("aria-expanded", isExpanded ? "false" : "true");
-    updateExpandButton();
+    toggleSchemaDialogMoreOptions(expandButton, details);
   });
 
   typeSelect.addEventListener("change", function () {
@@ -1407,7 +1828,7 @@ function createTableAlterColumnRow(state, column) {
     });
   }
 
-  moveTopButton.addEventListener("click", function () {
+  moveControls.topButton.addEventListener("click", function () {
     var first = tableAlterFirstNonPrimaryRow(state);
     if (
       state.isSaving ||
@@ -1424,7 +1845,7 @@ function createTableAlterColumnRow(state, column) {
     row.querySelector(".table-alter-column-name").focus();
   });
 
-  moveUpButton.addEventListener("click", function () {
+  moveControls.upButton.addEventListener("click", function () {
     var previous = row.previousElementSibling;
     if (
       state.isSaving ||
@@ -1441,7 +1862,7 @@ function createTableAlterColumnRow(state, column) {
     row.querySelector(".table-alter-column-name").focus();
   });
 
-  moveDownButton.addEventListener("click", function () {
+  moveControls.downButton.addEventListener("click", function () {
     var next = row.nextElementSibling;
     if (state.isSaving || tableAlterRowIsPrimaryKey(row) || !next) {
       return;
@@ -1453,7 +1874,7 @@ function createTableAlterColumnRow(state, column) {
     row.querySelector(".table-alter-column-name").focus();
   });
 
-  moveBottomButton.addEventListener("click", function () {
+  moveControls.bottomButton.addEventListener("click", function () {
     var last = state.columnList.lastElementChild;
     if (
       state.isSaving ||
@@ -2145,12 +2566,11 @@ function ensureTableAlterDialog(manager) {
           <div class="table-alter-column-headings" aria-hidden="true">
             <span>Column</span>
             <span>Type</span>
-            <span>Custom Type</span>
             <span>Move</span>
             <span></span>
           </div>
           <div class="table-alter-column-list"></div>
-          <button type="button" class="table-alter-add-column">Add column</button>
+          <button type="button" class="table-alter-add-column"><svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M5 12h14"></path><path d="M12 5v14"></path></svg><span>Add column</span></button>
         </div>
       </div>
       <div class="table-alter-review" hidden></div>

From c77dad910b47c370c2b4c2cf16bebf3d74b51069 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 18 Jun 2026 21:16:56 -0700
Subject: [PATCH 250/386] More robust test_datasette_https_server.sh test

---
 tests/test_datasette_https_server.sh | 31 ++++++++++++++--------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/tests/test_datasette_https_server.sh b/tests/test_datasette_https_server.sh
index aee262cc..a544b9a8 100755
--- a/tests/test_datasette_https_server.sh
+++ b/tests/test_datasette_https_server.sh
@@ -40,22 +40,23 @@ curl -f --cacert client.pem $test_url
 curl_exit_code=$?
 
 # Shut down the server
-kill $server_pid
-waiting=0
-#         show all pids
-#         |       find just the $server_pid
-#         |       |                  don’t match on the previous grep
-#         |       |                  |            we don’t need the output
-#         |       |                  |            |
-until ( ! ps ax | grep $server_pid | grep -v grep > /dev/null ); do
-    if [ $waiting -eq 4 ]; then
-        echo "$server_pid does still exist, server failed to stop"
-        cleanup
-        exit 1
+kill $server_pid 2>/dev/null || true
+(
+    sleep 5
+    if kill -0 $server_pid 2>/dev/null; then
+        kill -9 $server_pid 2>/dev/null || true
     fi
-    let waiting=waiting+1
-    sleep 1
-done
+) &
+killer_pid=$!
+wait_status=0
+wait $server_pid 2>/dev/null || wait_status=$?
+kill $killer_pid 2>/dev/null || true
+wait $killer_pid 2>/dev/null || true
+if [ $wait_status -eq 137 ]; then
+    echo "$server_pid did not stop after SIGTERM, server failed to stop"
+    cleanup
+    exit 1
+fi
 
 # Clean up the certificates
 cleanup

From e834008075eead04c142a57275dcaa3f08d44d38 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 19 Jun 2026 22:32:37 -0700
Subject: [PATCH 251/386] Make custom type and foreign key mutually exclusive

In the create table dialog a column can now have either a custom display
type or a foreign key target, but not both - a foreign key column's type
is determined by the referenced primary key, so a custom type doesn't
apply. Setting one clears and disables the other, and the foreign key
select stays disabled on the primary key column and when no targets exist.

Also add "Controls how Datasette displays and edits this column" help
text (with aria-describedby) under the custom type selector in both the
create and alter dialogs, and style the alter dialog help text.
---
 datasette/static/app.css       |  3 +-
 datasette/static/edit-tools.js | 71 ++++++++++++++++++++++++++++++++++
 2 files changed, 73 insertions(+), 1 deletion(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 49f070b1..06919444 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1953,7 +1953,8 @@ dialog.table-create-dialog::backdrop {
     font-size: 0.72rem;
 }
 
-.table-create-detail-help {
+.table-create-detail-help,
+.table-alter-detail-help {
     color: var(--muted);
     font-size: 0.82rem;
     line-height: 1.35;
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 5a9d0962..2a0a29b2 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -422,11 +422,42 @@ function syncTableCreateForeignKeyOptions(row, state) {
   );
 }
 
+function syncTableCreateCustomTypeAndForeignKey(row, state, isFirstColumn) {
+  var customTypeSelect = row.querySelector(".table-create-custom-column-type");
+  var foreignKeySelect = row.querySelector(".table-create-foreign-key-target");
+  if (!foreignKeySelect) {
+    return;
+  }
+
+  var hasCustomType = customTypeSelect && !!customTypeSelect.value;
+  var hasForeignKey = !!foreignKeySelect.value;
+
+  if (customTypeSelect && hasForeignKey) {
+    customTypeSelect.value = "";
+    updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+    hasCustomType = false;
+  }
+
+  if (isFirstColumn || hasCustomType) {
+    foreignKeySelect.value = "";
+    foreignKeySelect.dataset.selectedKey = "";
+    updateTableCreateCustomColumnTypePlaceholder(foreignKeySelect);
+    hasForeignKey = false;
+  }
+
+  if (customTypeSelect) {
+    customTypeSelect.disabled = state.isSaving;
+  }
+  foreignKeySelect.disabled =
+    state.isSaving || isFirstColumn || foreignKeySelect.options.length <= 1;
+}
+
 function refreshTableCreateForeignKeyControls(state) {
   tableCreateDialogRows(state).forEach(function (row, index) {
     if (index > 0) {
       syncTableCreateForeignKeyOptions(row, state);
     }
+    syncTableCreateCustomTypeAndForeignKey(row, state, index === 0);
   });
 }
 
@@ -455,6 +486,7 @@ function updateTableCreateColumnRules(state) {
       } else {
         syncTableCreateForeignKeyOptions(row, state);
       }
+      syncTableCreateCustomTypeAndForeignKey(row, state, isFirstColumn);
     }
   });
   updateTableCreateMoveButtons(state);
@@ -639,11 +671,19 @@ function createTableColumnRow(state, column) {
     customTypeLabel.className = "table-create-detail-label";
     customTypeLabel.setAttribute("for", customTypeId);
     customTypeLabel.textContent = "Custom type";
+    var customTypeHelpId = "table-create-column-custom-type-help-" + index;
+    var customTypeHelp = document.createElement("p");
+    customTypeHelp.id = customTypeHelpId;
+    customTypeHelp.className = "table-create-detail-help";
+    customTypeHelp.textContent =
+      "Controls how Datasette displays and edits this column";
     customTypeSelect = createTableCustomColumnTypeSelect();
     customTypeSelect.id = customTypeId;
+    customTypeSelect.setAttribute("aria-describedby", customTypeHelpId);
     customTypeSelect.value = column && column.customType ? column.customType : "";
     updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
     customTypeField.appendChild(customTypeLabel);
+    customTypeField.appendChild(customTypeHelp);
     customTypeField.appendChild(customTypeSelect);
   }
 
@@ -733,11 +773,20 @@ function createTableColumnRow(state, column) {
     clearTableCreateDialogError(state);
     syncTableCreateCustomTypeForSqliteType(row);
     syncTableCreateForeignKeyOptions(row, state);
+    syncTableCreateCustomTypeAndForeignKey(
+      row,
+      state,
+      row === state.columnList.firstElementChild,
+    );
   });
   if (customTypeSelect) {
     customTypeSelect.addEventListener("change", function () {
       clearTableCreateDialogError(state);
       updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+      if (customTypeSelect.value) {
+        foreignKeySelect.value = "";
+        foreignKeySelect.dataset.selectedKey = "";
+      }
       var option = tableCreateCustomColumnType(customTypeSelect.value);
       if (
         option &&
@@ -747,6 +796,11 @@ function createTableColumnRow(state, column) {
         typeSelect.value = option.fixedSqliteType;
         syncTableCreateForeignKeyOptions(row, state);
       }
+      syncTableCreateCustomTypeAndForeignKey(
+        row,
+        state,
+        row === state.columnList.firstElementChild,
+      );
     });
   }
   pkInput.addEventListener("change", function () {
@@ -757,6 +811,15 @@ function createTableColumnRow(state, column) {
     foreignKeySelect.dataset.selectedKey = foreignKeySelect.value;
     clearTableCreateDialogError(state);
     updateTableCreateCustomColumnTypePlaceholder(foreignKeySelect);
+    if (customTypeSelect && foreignKeySelect.value) {
+      customTypeSelect.value = "";
+      updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+    }
+    syncTableCreateCustomTypeAndForeignKey(
+      row,
+      state,
+      row === state.columnList.firstElementChild,
+    );
   });
 
   expandButton.addEventListener("click", function () {
@@ -1664,11 +1727,19 @@ function createTableAlterColumnRow(state, column) {
     customTypeLabel.className = "table-alter-detail-label";
     customTypeLabel.setAttribute("for", customTypeId);
     customTypeLabel.textContent = "Custom type";
+    var customTypeHelpId = "table-alter-column-custom-type-help-" + index;
+    var customTypeHelp = document.createElement("p");
+    customTypeHelp.id = customTypeHelpId;
+    customTypeHelp.className = "table-alter-detail-help";
+    customTypeHelp.textContent =
+      "Controls how Datasette displays and edits this column";
     customTypeSelect = createTableAlterCustomColumnTypeSelect();
     customTypeSelect.id = customTypeId;
+    customTypeSelect.setAttribute("aria-describedby", customTypeHelpId);
     customTypeSelect.value = originalCustomType;
     updateTableAlterCustomColumnTypePlaceholder(customTypeSelect);
     customTypeField.appendChild(customTypeLabel);
+    customTypeField.appendChild(customTypeHelp);
     customTypeField.appendChild(customTypeSelect);
   }
 

From 354780a1366bbfa6c5c9c34fdec3ccf24163e099 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 19 Jun 2026 22:40:14 -0700
Subject: [PATCH 252/386] Drop table button in alter dialog

---
 datasette/static/app.css       | 16 ++++++++
 datasette/static/edit-tools.js | 68 ++++++++++++++++++++++++++++++++++
 datasette/views/table.py       | 14 +++++++
 tests/test_table_html.py       | 14 ++++++-
 4 files changed, 111 insertions(+), 1 deletion(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 06919444..1cca8b80 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -2542,6 +2542,22 @@ dialog.table-alter-dialog::backdrop {
     color: var(--ink);
 }
 
+.table-alter-dialog .btn-danger {
+    background: #b91c1c;
+    color: #fff;
+    margin-right: auto;
+}
+
+.table-alter-dialog .btn-danger:hover {
+    background: #991b1b;
+}
+
+.table-alter-dialog .btn-danger:disabled,
+.table-alter-dialog .btn-danger:disabled:hover {
+    background: #d98c8c;
+    color: #fff;
+}
+
 .table-alter-dialog .btn-primary {
     background: var(--accent);
     color: #fff;
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 2a0a29b2..779ec702 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -1571,6 +1571,7 @@ function setTableAlterDialogSaving(state, isSaving) {
   state.cancelButton.disabled = isSaving;
   state.addColumnButton.disabled = isSaving;
   state.backButton.disabled = isSaving;
+  state.dropButton.disabled = isSaving;
   state.saveButton.textContent = isSaving
     ? state.mode === "review"
       ? "Applying..."
@@ -2465,6 +2466,8 @@ function showTableAlterEditor(state) {
   state.review.hidden = true;
   state.review.textContent = "";
   state.backButton.hidden = true;
+  var data = tableAlterData();
+  state.dropButton.hidden = !(data && data.dropPath);
   state.saveButton.textContent = tableAlterSaveButtonText(state);
   updateTableAlterMoveButtons(state);
   updateTableAlterSaveButtonState(state);
@@ -2479,6 +2482,7 @@ function showTableAlterReview(state, result) {
   state.review.hidden = false;
   state.review.textContent = "";
   state.backButton.hidden = false;
+  state.dropButton.hidden = true;
   state.saveButton.textContent = tableAlterSaveButtonText(state);
   updateTableAlterSaveButtonState(state);
 
@@ -2565,6 +2569,64 @@ async function applyTableAlterChanges(state, result) {
   }
 }
 
+function tableAlterDatabaseUrl() {
+  var data = tableAlterData();
+  if (!data || !data.path) {
+    return null;
+  }
+  var url = new URL(data.path, location.href);
+  url.pathname = url.pathname.replace(/\/[^/]+\/-\/alter\/?$/, "");
+  url.search = "";
+  url.hash = "";
+  return url.toString();
+}
+
+async function dropTableFromAlterDialog(state) {
+  if (state.isSaving) {
+    return;
+  }
+  var data = tableAlterData();
+  if (!data || !data.dropPath) {
+    return;
+  }
+  if (
+    !window.confirm(
+      'Permanently delete the table "' +
+        data.tableName +
+        '"? This will delete all of its data and cannot be undone.',
+    )
+  ) {
+    return;
+  }
+  clearTableAlterDialogError(state);
+  setTableAlterDialogSaving(state, true);
+  try {
+    var response = await fetch(data.dropPath, {
+      method: "POST",
+      headers: {
+        "Content-Type": "application/json",
+        Accept: "application/json",
+      },
+      body: JSON.stringify({ confirm: true }),
+    });
+    var responseData = null;
+    try {
+      responseData = await response.json();
+    } catch (_error) {
+      responseData = null;
+    }
+    if (!response.ok || (responseData && responseData.ok === false)) {
+      throw rowMutationRequestError(response, responseData);
+    }
+    state.shouldRestoreFocus = false;
+    state.dialog.close();
+    window.location.href = tableAlterDatabaseUrl() || "/";
+  } catch (error) {
+    setTableAlterDialogSaving(state, false);
+    showTableAlterDialogError(state, error.message || "Could not drop table");
+  }
+}
+
 async function saveTableAlterDialog(state) {
   if (state.isSaving) {
     return;
@@ -2646,6 +2708,7 @@ function ensureTableAlterDialog(manager) {
       </div>
       <div class="table-alter-review" hidden></div>
       <div class="modal-footer">
+        <button type="button" class="btn btn-danger table-alter-drop" hidden>Drop table</button>
         <button type="button" class="btn btn-ghost table-alter-back" hidden>Back</button>
         <button type="button" class="btn btn-ghost table-alter-cancel">Cancel</button>
         <button type="submit" class="btn btn-primary table-alter-save">Review changes</button>
@@ -2664,6 +2727,7 @@ function ensureTableAlterDialog(manager) {
     columnList: dialog.querySelector(".table-alter-column-list"),
     addColumnButton: dialog.querySelector(".table-alter-add-column"),
     backButton: dialog.querySelector(".table-alter-back"),
+    dropButton: dialog.querySelector(".table-alter-drop"),
     cancelButton: dialog.querySelector(".table-alter-cancel"),
     saveButton: dialog.querySelector(".table-alter-save"),
     currentButton: null,
@@ -2703,6 +2767,10 @@ function ensureTableAlterDialog(manager) {
     closeTableAlterDialog(tableAlterDialogState);
   });
 
+  tableAlterDialogState.dropButton.addEventListener("click", function () {
+    dropTableFromAlterDialog(tableAlterDialogState);
+  });
+
   tableAlterDialogState.backButton.addEventListener("click", function () {
     if (tableAlterDialogState.isSaving) {
       return;
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 6c0d2914..4adcd181 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -422,6 +422,15 @@ async def _table_alter_ui(
         data["customColumnTypes"] = _custom_column_type_options_for_create_table(
             datasette
         )
+    can_drop_table = await datasette.allowed(
+        action="drop-table",
+        resource=TableResource(database=database_name, table=table_name),
+        actor=request.actor,
+    )
+    if can_drop_table:
+        data["dropPath"] = "{}/-/drop".format(
+            datasette.urls.table(database_name, table_name)
+        )
     return data
 
 
@@ -1193,6 +1202,11 @@ class TableDropView(BaseView):
                 actor=request.actor, database=database_name, table=table_name
             )
         )
+        self.ds.add_message(
+            request,
+            "Table {} dropped".format(table_name),
+            self.ds.WARNING,
+        )
         return Response.json({"ok": True}, status=200)
 
 
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index fa01c8ec..4c80691c 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1089,8 +1089,9 @@ async def test_table_alter_action_button_and_data():
                     "tables": {
                         "items": {
                             "permissions": {
-                                "alter-table": {"id": "root"},
+                                "alter-table": {"id": ["root", "alter-only"]},
                                 "set-column-type": {"id": "root"},
+                                "drop-table": {"id": "root"},
                             },
                             "column_types": {"name": "textarea"},
                         },
@@ -1147,6 +1148,7 @@ async def test_table_alter_action_button_and_data():
             "textarea",
             "url",
         ]
+        assert alter_data["dropPath"] == "/data/items/-/drop"
         assert alter_data["columns"] == [
             {
                 "name": "id",
@@ -1192,6 +1194,16 @@ async def test_table_alter_action_button_and_data():
             is None
         )
         assert "alterTable" not in table_data_from_soup(soup_without_permission)
+
+        # An actor that can alter but not drop should not get a dropPath
+        response_alter_only = await ds.client.get(
+            "/data/items", actor={"id": "alter-only"}
+        )
+        assert response_alter_only.status_code == 200
+        alter_only_data = table_data_from_soup(
+            Soup(response_alter_only.text, "html.parser")
+        )["alterTable"]
+        assert "dropPath" not in alter_only_data
     finally:
         ds.close()
 

From a87c4ac555ed763b4e4e48716a7d4402dd439b99 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 09:47:39 -0700
Subject: [PATCH 253/386] Object not chain of ifs

Refs https://github.com/simonw/datasette/pull/2789/changes#r3453964430
---
 datasette/static/edit-tools.js | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 779ec702..4c6d7d10 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -60,17 +60,14 @@ function tableCreateColumnTypes() {
     : ["text", "integer", "float", "blob"];
 }
 
+var SQLITE_COLUMN_TYPE_LABELS = {
+  float: "floating point number",
+  real: "floating point number",
+  blob: "blob - binary data",
+};
+
 function sqliteColumnTypeLabel(type) {
-  if (type === "float") {
-    return "floating point number";
-  }
-  if (type === "real") {
-    return "floating point number";
-  }
-  if (type === "blob") {
-    return "blob - binary data";
-  }
-  return type;
+  return SQLITE_COLUMN_TYPE_LABELS[type] || type;
 }
 
 function populateSqliteColumnTypeSelect(select, type, options) {

From b02999bca6a4cf9aa3712b3ba424f42b0cbee35b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 09:59:29 -0700
Subject: [PATCH 254/386] Fix broken Playwright tests

---
 tests/test_playwright.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 70b5a8c1..94dcbd64 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -303,6 +303,7 @@ def test_create_table_flow(page, datasette_server):
     dialog.locator(".table-create-add-column").click()
     dialog.locator(".table-create-column-name").nth(3).fill("metadata")
     dialog.locator(".table-create-column-type").nth(3).select_option("integer")
+    dialog.locator(".table-create-more-options").nth(3).click()
     dialog.locator(".table-create-custom-column-type").nth(3).select_option("json")
     assert dialog.locator(".table-create-column-type").nth(3).input_value() == "text"
     assert "table-create-input-placeholder" not in dialog.locator(
@@ -361,7 +362,7 @@ def test_alter_table_flow(page, datasette_server):
     assert "Default value" in expanded_options_text
     assert "or default to a specific time" in expanded_options_text
     assert "Primary key" in expanded_options_text
-    assert "An ID that uniquely identifies this record" in expanded_options_text
+    assert "This ID uniquely identifies the record" in expanded_options_text
 
     dialog.locator(".table-alter-add-column").click()
     assert dialog.locator(".table-alter-save").is_enabled()

From 17876ccf45b35a025c5fa0186427685629b66492 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 10:01:39 -0700
Subject: [PATCH 255/386] Keyword arguments for readability

---
 datasette/views/row.py   | 16 ++++++++--------
 datasette/views/table.py | 16 ++++++++--------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/datasette/views/row.py b/datasette/views/row.py
index 34773d48..e3575b6c 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -205,14 +205,14 @@ class RowView(DataView):
                 ],
                 "row_mutation_ui": any(row_action_permissions.values()),
                 "table_page_data": await _table_page_data(
-                    self.ds,
-                    request,
-                    db,
-                    database,
-                    table,
-                    not is_table,
-                    None,
-                    None,
+                    datasette=self.ds,
+                    request=request,
+                    db=db,
+                    database_name=database,
+                    table_name=table,
+                    is_view=not is_table,
+                    table_insert_ui=None,
+                    table_alter_ui=None,
                 ),
                 "row_actions": row_actions,
                 "top_row": make_slot_function(
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 4adcd181..988d3808 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -2171,14 +2171,14 @@ async def table_view_data(
         data["table_insert_ui"] = table_insert_ui
         data["table_alter_ui"] = table_alter_ui
         data["table_page_data"] = await _table_page_data(
-            datasette,
-            request,
-            db,
-            database_name,
-            table_name,
-            is_view,
-            table_insert_ui,
-            table_alter_ui,
+            datasette=datasette,
+            request=request,
+            db=db,
+            database_name=database_name,
+            table_name=table_name,
+            is_view=is_view,
+            table_insert_ui=table_insert_ui,
+            table_alter_ui=table_alter_ui,
         )
 
     return data, rows[:page_size], columns, expanded_columns, sql, next_url

From c4aead65ee5a37a40f9fa8abb9fc45a03979e535 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 10:02:42 -0700
Subject: [PATCH 256/386] Ran prettier

---
 datasette/static/edit-tools.js | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 4c6d7d10..c4982e54 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -248,7 +248,9 @@ function updateSchemaDialogMoveButtons(state, prefix) {
       topButton.disabled =
         state.isSaving || !firstNonPrimary || row === firstNonPrimary;
       upButton.disabled =
-        state.isSaving || !previous || schemaDialogRowIsPrimaryKey(previous, prefix);
+        state.isSaving ||
+        !previous ||
+        schemaDialogRowIsPrimaryKey(previous, prefix);
       downButton.disabled = state.isSaving || !next;
       bottomButton.disabled = state.isSaving || !next;
       if (hasPrimaryKeys && row === firstNonPrimary) {
@@ -464,7 +466,9 @@ function updateTableCreateColumnRules(state) {
     var pkLabel = row.querySelector(".table-create-primary-key");
     var pkInput = row.querySelector(".table-create-primary-key-input");
     var foreignKeyField = row.querySelector(".table-create-foreign-key-field");
-    var foreignKeySelect = row.querySelector(".table-create-foreign-key-target");
+    var foreignKeySelect = row.querySelector(
+      ".table-create-foreign-key-target",
+    );
 
     if (pkLabel && pkInput) {
       pkLabel.hidden = !isFirstColumn;
@@ -677,7 +681,8 @@ function createTableColumnRow(state, column) {
     customTypeSelect = createTableCustomColumnTypeSelect();
     customTypeSelect.id = customTypeId;
     customTypeSelect.setAttribute("aria-describedby", customTypeHelpId);
-    customTypeSelect.value = column && column.customType ? column.customType : "";
+    customTypeSelect.value =
+      column && column.customType ? column.customType : "";
     updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
     customTypeField.appendChild(customTypeLabel);
     customTypeField.appendChild(customTypeHelp);
@@ -920,7 +925,9 @@ function collectTableCreatePayload(state) {
     var name = row.querySelector(".table-create-column-name").value.trim();
     var type = row.querySelector(".table-create-column-type").value;
     var column = { name: name, type: type };
-    var foreignKeySelect = row.querySelector(".table-create-foreign-key-target");
+    var foreignKeySelect = row.querySelector(
+      ".table-create-foreign-key-target",
+    );
     var foreignKeyOption =
       foreignKeySelect && foreignKeySelect.selectedOptions
         ? foreignKeySelect.selectedOptions[0]

From 084df1fba2076eec2124309360e05bfa2a497a28 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 10:18:01 -0700
Subject: [PATCH 257/386] Removed the alter table dry run feature

It works by doing conn.backup(memory_conn) which could use
a lot of memory for a large database.
---
 datasette/views/table_create_alter.py | 17 ++----------
 docs/json_api.rst                     |  5 +---
 tests/test_api_write.py               | 37 +++++++--------------------
 3 files changed, 12 insertions(+), 47 deletions(-)

diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index f7775479..88bdafc4 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -22,7 +22,6 @@ from datasette.resources import DatabaseResource, TableResource
 from datasette.utils import (
     escape_sqlite,
     get_outbound_foreign_keys,
-    sqlite3,
     table_column_details,
 )
 from datasette.utils.asgi import NotFound, Response
@@ -602,7 +601,6 @@ AlterTableOperation = Annotated[
 
 class AlterTableRequest(_StrictPydanticModel):
     operations: list[AlterTableOperation] = Field(min_length=1)
-    dry_run: bool = False
 
 
 def _pydantic_errors(validation_error):
@@ -1143,14 +1141,6 @@ class TableAlterView(BaseView):
 
                 return _table_schema_from_conn(operation_conn, table_name)
 
-            if alter_request.dry_run:
-                memory_conn = sqlite3.connect(":memory:")
-                try:
-                    conn.backup(memory_conn)
-                    return before_schema, apply_operations(memory_conn)
-                finally:
-                    memory_conn.close()
-
             after_schema = apply_operations(conn)
             return before_schema, after_schema
 
@@ -1162,7 +1152,7 @@ class TableAlterView(BaseView):
             return _error([str(e)], 400)
 
         altered = before_schema != after_schema
-        if altered and not alter_request.dry_run:
+        if altered:
             await self.ds.track_event(
                 AlterTableEvent(
                     request.actor,
@@ -1189,10 +1179,7 @@ class TableAlterView(BaseView):
                 "altered": altered,
                 "schema": after_schema,
                 "before_schema": before_schema,
-                "operations_applied": (
-                    0 if alter_request.dry_run else len(alter_request.operations)
-                ),
-                "dry_run": alter_request.dry_run,
+                "operations_applied": len(alter_request.operations),
             },
             status=200,
         )
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 1db46dd2..a42175f7 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -2285,8 +2285,6 @@ The request body should include an ``operations`` array. Each operation has the
         ]
     }
 
-Set ``"dry_run": true`` to validate the operations and return the schema that would be created without modifying the table.
-
 Supported operations:
 
 * ``add_column`` adds a new column. ``args`` accepts ``name``, optional ``type`` of ``text``, ``integer``, ``float`` or ``blob``, optional ``not_null``, optional literal ``default`` and optional ``default_expr``. If ``not_null`` is ``true`` either a non-null ``default`` or ``default_expr`` is required.
@@ -2316,8 +2314,7 @@ A successful response returns the new schema and the previous schema:
         "altered": true,
         "schema": "CREATE TABLE ...",
         "before_schema": "CREATE TABLE ...",
-        "operations_applied": 7,
-        "dry_run": false
+        "operations_applied": 7
     }
 
 Any errors will return ``{"errors": ["... descriptive message ..."], "ok": false}``, and a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 1d16ad26..49f38cde 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -898,34 +898,6 @@ async def test_alter_table_operations(ds_write):
     assert event.after_schema == data["schema"]
 
 
-@pytest.mark.asyncio
-async def test_alter_table_dry_run(ds_write):
-    token = write_token(ds_write, permissions=["at"])
-    db = ds_write.get_database("data")
-    response = await ds_write.client.post(
-        "/data/docs/-/alter",
-        json={
-            "dry_run": True,
-            "operations": [
-                {"op": "add_column", "args": {"name": "slug", "type": "text"}}
-            ],
-        },
-        headers=_headers(token),
-    )
-    assert response.status_code == 200, response.text
-    data = response.json()
-    assert data["ok"] is True
-    assert data["dry_run"] is True
-    assert data["altered"] is True
-    assert data["operations_applied"] == 0
-    assert "slug" in data["schema"]
-    columns = (
-        await db.execute("select name from pragma_table_info('docs') order by cid")
-    ).dicts()
-    assert [column["name"] for column in columns] == ["id", "title", "score", "age"]
-    assert last_event(ds_write) is None
-
-
 @pytest.mark.asyncio
 async def test_alter_table_foreign_key_operations(ds_write):
     token = write_token(ds_write, permissions=["at"])
@@ -1246,6 +1218,15 @@ async def test_alter_table_permission_denied(ds_write):
 @pytest.mark.parametrize(
     "body,expected_error",
     (
+        (
+            {
+                "dry_run": True,
+                "operations": [
+                    {"op": "add_column", "args": {"name": "slug", "type": "text"}}
+                ],
+            },
+            "dry_run: Extra inputs are not permitted",
+        ),
         (
             {"operations": [{"op": "add_column", "args": {"type": "text"}}]},
             "operations.0.add_column.args.name: Field required",

From a2e75967ce19445d2862ac40cd9306447f2b4524 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 11:03:49 -0700
Subject: [PATCH 258/386] sqlite-utils>=3.30,<4.0

So we don't get test failures from reformatted SQL.
---
 pyproject.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pyproject.toml b/pyproject.toml
index 38776b2c..215b2cca 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -35,7 +35,7 @@ dependencies = [
     "PyYAML>=5.3",
     "mergedeep>=1.1.1",
     "itsdangerous>=1.1",
-    "sqlite-utils>=3.30",
+    "sqlite-utils>=3.30,<4.0",
     "asyncinject>=0.7",
     "setuptools",
     "pip",

From 87354cf94e9921262d1fb50dfb9b25afd0cc028f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 11:04:19 -0700
Subject: [PATCH 259/386] not_null, default and default_exr support for create
 table API columns

---
 datasette/views/table_create_alter.py | 53 ++++++++++++-------
 docs/json_api.rst                     | 14 ++++-
 tests/test_api_write.py               | 73 ++++++++++++++++++++++++++-
 3 files changed, 119 insertions(+), 21 deletions(-)

diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index 88bdafc4..d4259287 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -319,13 +319,28 @@ class _StrictPydanticModel(BaseModel):
     model_config = ConfigDict(extra="forbid")
 
 
-class CreateTableColumn(BaseModel):
-    model_config = ConfigDict(extra="forbid")
+class _DefaultArgsMixin(_StrictPydanticModel):
+    default: Any | None = None
+    default_expr: DefaultExpr | None = None
+
+    @model_validator(mode="after")
+    def validate_default_fields(self):
+        has_default = "default" in self.model_fields_set
+        has_default_expr = "default_expr" in self.model_fields_set
+        if has_default and has_default_expr:
+            raise ValueError("default and default_expr cannot both be provided")
+        if has_default_expr and self.default_expr is None:
+            raise ValueError("default_expr cannot be null")
+        return self
+
+
+class CreateTableColumn(_DefaultArgsMixin):
 
     name: Any = None
     type: Any = "text"
     fk_table: str | None = None
     fk_column: str | None = None
+    not_null: bool = False
 
     @model_validator(mode="after")
     def validate_column(self):
@@ -450,21 +465,6 @@ class CreateTableRequest(_StrictPydanticModel):
         return foreign_keys or None
 
 
-class _DefaultArgsMixin(_StrictPydanticModel):
-    default: Any | None = None
-    default_expr: DefaultExpr | None = None
-
-    @model_validator(mode="after")
-    def validate_default_fields(self):
-        has_default = "default" in self.model_fields_set
-        has_default_expr = "default_expr" in self.model_fields_set
-        if has_default and has_default_expr:
-            raise ValueError("default and default_expr cannot both be provided")
-        if has_default_expr and self.default_expr is None:
-            raise ValueError("default_expr cannot be null")
-        return self
-
-
 class AddColumnArgs(_DefaultArgsMixin):
     name: str
     type: SqliteApiType = "text"
@@ -753,16 +753,33 @@ class TableCreateView(BaseView):
             )
 
         def create_table(conn):
-            table = sqlite_utils.Database(conn)[table_name]
+            db_for_write = sqlite_utils.Database(conn)
+            table = db_for_write[table_name]
             if rows:
                 table.insert_all(
                     rows, pk=pks or pk, ignore=ignore, replace=replace, alter=alter
                 )
             else:
+                not_null = [column.name for column in columns if column.not_null]
+                defaults = {}
+                for column in columns:
+                    if "default_expr" in column.model_fields_set:
+                        defaults[column.name] = _default_expression_sql(
+                            column.default_expr
+                        )
+                    elif (
+                        "default" in column.model_fields_set
+                        and column.default is not None
+                    ):
+                        defaults[column.name] = _literal_default(
+                            db_for_write, column.default
+                        )
                 table.create(
                     {column.name: column.type for column in columns},
                     pk=pks or pk,
                     foreign_keys=create_request.foreign_keys,
+                    not_null=not_null or None,
+                    defaults=defaults or None,
                 )
             return table.schema
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index a42175f7..b2927e38 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -1968,7 +1968,14 @@ To create a table, make a ``POST`` to ``/<database>/-/create``. This requires th
             },
             {
                 "name": "title",
-                "type": "text"
+                "type": "text",
+                "not_null": true,
+                "default": "Untitled"
+            },
+            {
+                "name": "created",
+                "type": "text",
+                "default_expr": "current_timestamp"
             }
         ],
         "pk": "id"
@@ -1981,6 +1988,9 @@ The JSON here describes the table that will be created:
 
   - ``name`` is the name of the column. This is required.
   - ``type`` is the type of the column. This is optional - if not provided, ``text`` will be assumed. The valid types are ``text``, ``integer``, ``float`` and ``blob``.
+  - ``not_null`` can be set to ``true`` to create this column with a ``NOT NULL`` constraint.
+  - ``default`` can be used to set a literal default value for this column.
+  - ``default_expr`` can be used instead of ``default`` to set a SQLite default expression. The supported values are ``current_timestamp``, ``current_date`` and ``current_time``.
   - ``fk_table`` can be used to create a single-column foreign key constraint referencing another table. ``fk_column`` is optional and can be used to specify the referenced column - if omitted, Datasette will use the single primary key of ``fk_table``.
 
 * ``pk`` is the primary key for the table. This is optional - if not provided, Datasette will create a SQLite table with a hidden ``rowid`` column.
@@ -2028,7 +2038,7 @@ If the table is successfully created this will return a ``201`` status code and
         "table": "name_of_new_table",
         "table_url": "http://127.0.0.1:8001/data/name_of_new_table",
         "table_api_url": "http://127.0.0.1:8001/data/name_of_new_table.json",
-        "schema": "CREATE TABLE [name_of_new_table] (\n   [id] INTEGER PRIMARY KEY,\n   [title] TEXT\n)"
+        "schema": "CREATE TABLE [name_of_new_table] (\n   [id] INTEGER PRIMARY KEY,\n   [title] TEXT NOT NULL DEFAULT 'Untitled',\n   [created] TEXT DEFAULT CURRENT_TIMESTAMP\n)"
     }
 
 .. _TableCreateView_example:
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 49f38cde..32be8905 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1935,6 +1935,60 @@ async def test_create_table_with_foreign_key(ds_write):
     assert "[owner_id] INTEGER REFERENCES [owners]([id])" in data["schema"]
 
 
+@pytest.mark.asyncio
+async def test_create_table_with_column_constraints(ds_write):
+    token = write_token(ds_write)
+    response = await ds_write.client.post(
+        "/data/-/create",
+        json={
+            "table": "constrained",
+            "columns": [
+                {"name": "id", "type": "integer"},
+                {
+                    "name": "title",
+                    "type": "text",
+                    "not_null": True,
+                    "default": "Untitled",
+                },
+                {
+                    "name": "created",
+                    "type": "text",
+                    "default_expr": "current_timestamp",
+                },
+                {"name": "score", "type": "integer", "default": 0},
+                {"name": "literal_default", "type": "text", "default": "hello)"},
+            ],
+            "pk": "id",
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 201, response.text
+    data = response.json()
+    assert data["ok"] is True
+    assert "NOT NULL DEFAULT 'Untitled'" in data["schema"]
+    assert "DEFAULT CURRENT_TIMESTAMP" in data["schema"]
+    assert "DEFAULT 0" in data["schema"]
+    assert "DEFAULT 'hello)'" in data["schema"]
+
+    db = ds_write.get_database("data")
+    columns = (
+        await db.execute("select * from pragma_table_info('constrained') order by cid")
+    ).dicts()
+    assert [column["name"] for column in columns] == [
+        "id",
+        "title",
+        "created",
+        "score",
+        "literal_default",
+    ]
+    assert columns[0]["pk"] == 1
+    assert columns[1]["notnull"] == 1
+    assert columns[1]["dflt_value"] == "'Untitled'"
+    assert columns[2]["dflt_value"] == "CURRENT_TIMESTAMP"
+    assert columns[3]["dflt_value"] == "0"
+    assert columns[4]["dflt_value"] == "'hello)'"
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "column,expected_error",
@@ -1947,9 +2001,26 @@ async def test_create_table_with_foreign_key(ds_write):
             {"name": "owner_id", "type": "integer", "fk_column": "id"},
             "columns.0: fk_column requires fk_table",
         ),
+        (
+            {
+                "name": "created",
+                "type": "text",
+                "default_expr": "datetime('now')",
+            },
+            "columns.0.default_expr: Input should be 'current_timestamp', 'current_date' or 'current_time'",
+        ),
+        (
+            {
+                "name": "created",
+                "type": "text",
+                "default": "x",
+                "default_expr": "current_timestamp",
+            },
+            "columns.0: Value error, default and default_expr cannot both be provided",
+        ),
     ),
 )
-async def test_create_table_foreign_key_validation(ds_write, column, expected_error):
+async def test_create_table_column_validation(ds_write, column, expected_error):
     token = write_token(ds_write)
     response = await ds_write.client.post(
         "/data/-/create",

From 4b219be8bd14b445b1a48206050d2c34a6943185 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 12:02:51 -0700
Subject: [PATCH 260/386] Alter table API can now rename tables, refs #2788

Refs https://github.com/simonw/datasette/pull/2789#issuecomment-4771774289
---
 datasette/views/table_create_alter.py | 53 +++++++++++++++++++++++----
 docs/json_api.rst                     | 17 ++++++---
 tests/test_api_write.py               | 53 +++++++++++++++++++++++++++
 3 files changed, 110 insertions(+), 13 deletions(-)

diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index d4259287..07f13e9d 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -476,6 +476,20 @@ class RenameColumnArgs(_StrictPydanticModel):
     to: str
 
 
+class RenameTableArgs(_StrictPydanticModel):
+    to: str
+
+    @field_validator("to")
+    @classmethod
+    def validate_table_name(cls, v):
+        if not TABLE_NAME_RE.match(v):
+            raise PydanticCustomError(
+                "alter_table_rename_table",
+                "Invalid table name",
+            )
+        return v
+
+
 class AlterColumnArgs(_DefaultArgsMixin):
     name: str
     type: SqliteApiType | None = None
@@ -548,6 +562,11 @@ class RenameColumnOperation(_StrictPydanticModel):
     args: RenameColumnArgs
 
 
+class RenameTableOperation(_StrictPydanticModel):
+    op: Literal["rename_table"]
+    args: RenameTableArgs
+
+
 class AlterColumnOperation(_StrictPydanticModel):
     op: Literal["alter_column"]
     args: AlterColumnArgs
@@ -587,6 +606,7 @@ AlterTableOperation = Annotated[
     Union[
         AddColumnOperation,
         RenameColumnOperation,
+        RenameTableOperation,
         AlterColumnOperation,
         DropColumnOperation,
         SetPrimaryKeyOperation,
@@ -1042,10 +1062,12 @@ class TableAlterView(BaseView):
             def apply_operations(operation_conn):
                 db_for_write = sqlite_utils.Database(operation_conn)
                 table = db_for_write[table_name]
+                current_table_name = table_name
 
                 add_columns = []
                 types = {}
                 rename = {}
+                rename_table_to = None
                 drop = set()
                 not_null = {}
                 defaults = {}
@@ -1080,6 +1102,8 @@ class TableAlterView(BaseView):
                             defaults[args.name] = _default_expression_sql(
                                 args.default_expr
                             )
+                    elif operation.op == "rename_table":
+                        rename_table_to = args.to
                     elif operation.op == "rename_column":
                         rename[args.name] = args.to
                     elif operation.op == "alter_column":
@@ -1155,14 +1179,27 @@ class TableAlterView(BaseView):
                             drop_foreign_keys=drop_foreign_keys or None,
                             foreign_keys=foreign_keys,
                         )
+                    if (
+                        rename_table_to is not None
+                        and rename_table_to != current_table_name
+                    ):
+                        operation_conn.execute(
+                            "alter table {} rename to {}".format(
+                                escape_sqlite(current_table_name),
+                                escape_sqlite(rename_table_to),
+                            )
+                        )
+                        current_table_name = rename_table_to
 
-                return _table_schema_from_conn(operation_conn, table_name)
+                return current_table_name, _table_schema_from_conn(
+                    operation_conn, current_table_name
+                )
 
-            after_schema = apply_operations(conn)
-            return before_schema, after_schema
+            after_table_name, after_schema = apply_operations(conn)
+            return before_schema, after_schema, after_table_name
 
         try:
-            before_schema, after_schema = await db.execute_write_fn(
+            before_schema, after_schema, after_table_name = await db.execute_write_fn(
                 alter_table, request=request
             )
         except Exception as e:
@@ -1174,23 +1211,23 @@ class TableAlterView(BaseView):
                 AlterTableEvent(
                     request.actor,
                     database=database_name,
-                    table=table_name,
+                    table=after_table_name,
                     before_schema=before_schema,
                     after_schema=after_schema,
                 )
             )
 
         table_url = self.ds.absolute_url(
-            request, self.ds.urls.table(database_name, table_name)
+            request, self.ds.urls.table(database_name, after_table_name)
         )
         table_api_url = self.ds.absolute_url(
-            request, self.ds.urls.table(database_name, table_name, format="json")
+            request, self.ds.urls.table(database_name, after_table_name, format="json")
         )
         return Response.json(
             {
                 "ok": True,
                 "database": database_name,
-                "table": table_name,
+                "table": after_table_name,
                 "table_url": table_url,
                 "table_api_url": table_api_url,
                 "altered": altered,
diff --git a/docs/json_api.rst b/docs/json_api.rst
index b2927e38..849a8acf 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -2242,6 +2242,12 @@ The request body should include an ``operations`` array. Each operation has the
                     "to": "headline"
                 }
             },
+            {
+                "op": "rename_table",
+                "args": {
+                    "to": "published_posts"
+                }
+            },
             {
                 "op": "alter_column",
                 "args": {
@@ -2299,6 +2305,7 @@ Supported operations:
 
 * ``add_column`` adds a new column. ``args`` accepts ``name``, optional ``type`` of ``text``, ``integer``, ``float`` or ``blob``, optional ``not_null``, optional literal ``default`` and optional ``default_expr``. If ``not_null`` is ``true`` either a non-null ``default`` or ``default_expr`` is required.
 * ``rename_column`` renames a column. ``args`` accepts ``name`` and ``to``.
+* ``rename_table`` renames the table. ``args`` accepts ``to``, the new table name. If combined with other operations, Datasette applies the column, primary key, foreign key and column order changes before renaming the table.
 * ``alter_column`` changes column properties. ``args`` accepts ``name`` and at least one of ``type``, ``not_null``, literal ``default`` or ``default_expr``. Passing ``"default": null`` removes an existing default.
 * ``drop_column`` drops a column. ``args`` accepts ``name``.
 * ``set_primary_key`` changes the table primary key. ``args`` accepts ``columns``, a list of one or more column names.
@@ -2311,20 +2318,20 @@ Supported operations:
 
 For foreign key operations that omit ``fk_column``, the referenced ``fk_table`` must have a single-column primary key. Datasette will return an error if it cannot identify a single primary key column for that table.
 
-A successful response returns the new schema and the previous schema:
+A successful response returns the new schema and the previous schema. If the request used ``rename_table``, ``table``, ``table_url`` and ``table_api_url`` will use the new table name. Renaming a table through this endpoint triggers the :class:`~datasette.events.RenameTableEvent` event.
 
 .. code-block:: json
 
     {
         "ok": true,
         "database": "data",
-        "table": "posts",
-        "table_url": "http://127.0.0.1:8001/data/posts",
-        "table_api_url": "http://127.0.0.1:8001/data/posts.json",
+        "table": "published_posts",
+        "table_url": "http://127.0.0.1:8001/data/published_posts",
+        "table_api_url": "http://127.0.0.1:8001/data/published_posts.json",
         "altered": true,
         "schema": "CREATE TABLE ...",
         "before_schema": "CREATE TABLE ...",
-        "operations_applied": 7
+        "operations_applied": 11
     }
 
 Any errors will return ``{"errors": ["... descriptive message ..."], "ok": false}``, and a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 32be8905..ca8a46f5 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1,4 +1,5 @@
 from datasette.app import Datasette
+from datasette.events import RenameTableEvent
 from datasette.utils import sqlite3
 from .utils import last_event
 import pytest
@@ -898,6 +899,58 @@ async def test_alter_table_operations(ds_write):
     assert event.after_schema == data["schema"]
 
 
+@pytest.mark.asyncio
+async def test_alter_table_rename_table(ds_write):
+    token = write_token(ds_write, permissions=["at"])
+    db = ds_write.get_database("data")
+    before_schema = await db.execute_fn(
+        lambda conn: conn.execute(
+            "select sql from sqlite_master where type = 'table' and name = 'docs'"
+        ).fetchone()[0]
+    )
+
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "operations": [
+                {"op": "rename_table", "args": {"to": "documents"}},
+            ]
+        },
+        headers=_headers(token),
+    )
+
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert data["ok"] is True
+    assert data["database"] == "data"
+    assert data["table"] == "documents"
+    assert data["table_url"].endswith("/data/documents")
+    assert data["table_api_url"].endswith("/data/documents.json")
+    assert data["altered"] is True
+    assert data["operations_applied"] == 1
+    assert data["before_schema"] == before_schema
+    assert 'CREATE TABLE "documents"' in data["schema"]
+
+    tables = (
+        await db.execute(
+            "select name from sqlite_master where type = 'table' order by name"
+        )
+    ).dicts()
+    table_names = [table["name"] for table in tables]
+    assert "docs" not in table_names
+    assert "documents" in table_names
+
+    rename_events = [
+        event
+        for event in ds_write._tracked_events
+        if isinstance(event, RenameTableEvent)
+    ]
+    assert len(rename_events) == 1
+    assert rename_events[0].database == "data"
+    assert rename_events[0].old_table == "docs"
+    assert rename_events[0].new_table == "documents"
+
+
 @pytest.mark.asyncio
 async def test_alter_table_foreign_key_operations(ds_write):
     token = write_token(ds_write, permissions=["at"])

From dada4de172c974f677c51855e8234ffb22c6259a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 12:35:34 -0700
Subject: [PATCH 261/386] Fix for Safari select box heights

Refs https://github.com/simonw/datasette/pull/2789#issuecomment-4772241681
---
 datasette/static/app.css | 12 ++++++++++++
 tests/test_playwright.py | 18 ++++++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 1cca8b80..90d7e7e9 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1864,12 +1864,18 @@ dialog.table-create-dialog::backdrop {
 .table-create-input {
     box-sizing: border-box;
     min-width: 0;
+    min-height: 46px;
     border: 1px solid var(--rule);
     border-radius: 5px;
     padding: 8px 10px;
     color: var(--ink);
     background: #fff;
     font: inherit;
+    line-height: 1.35;
+}
+
+select.table-create-input {
+    height: 46px;
 }
 
 .table-create-input-placeholder {
@@ -2333,12 +2339,18 @@ dialog.table-alter-dialog::backdrop {
 .table-alter-input {
     box-sizing: border-box;
     min-width: 0;
+    min-height: 46px;
     border: 1px solid var(--rule);
     border-radius: 5px;
     padding: 8px 10px;
     color: var(--ink);
     background: #fff;
     font: inherit;
+    line-height: 1.35;
+}
+
+select.table-alter-input {
+    height: 46px;
 }
 
 .table-alter-input-placeholder {
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 94dcbd64..eefec118 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -295,6 +295,15 @@ def test_create_table_flow(page, datasette_server):
         placeholder_select.locator("option:checked").inner_text() == "- custom type -"
     )
     assert "table-create-input-placeholder" in placeholder_select.get_attribute("class")
+    assert dialog.locator(".table-create-column-main").first.evaluate("""node => {
+            const inputHeight = node.querySelector(
+                ".table-create-column-name"
+            ).getBoundingClientRect().height;
+            const selectHeight = node.querySelector(
+                ".table-create-column-type"
+            ).getBoundingClientRect().height;
+            return Math.abs(inputHeight - selectHeight) <= 1;
+        }""")
     dialog.locator('input[name="table"]').fill("playwright_created")
     dialog.locator(".table-create-column-name").nth(1).fill("title")
     dialog.locator(".table-create-add-column").click()
@@ -340,6 +349,15 @@ def test_alter_table_flow(page, datasette_server):
     dialog.wait_for()
     assert dialog.locator(".modal-title").inner_text() == "Alter table projects"
     assert dialog.locator(".table-alter-save").is_disabled()
+    assert dialog.locator(".table-alter-column-main").first.evaluate("""node => {
+            const inputHeight = node.querySelector(
+                ".table-alter-column-name"
+            ).getBoundingClientRect().height;
+            const selectHeight = node.querySelector(
+                ".table-alter-column-type"
+            ).getBoundingClientRect().height;
+            return Math.abs(inputHeight - selectHeight) <= 1;
+        }""")
     type_options = dialog.locator(".table-alter-column-type").first.locator("option")
     assert type_options.all_inner_texts() == [
         "text",

From 063b04ad83f88f642053bd88c5368e9ad19f13af Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 12:47:02 -0700
Subject: [PATCH 262/386] Expose foreign key data to alter table UI

Include current foreign key metadata in the alter table page data and allow the foreign-key-targets endpoint to be read by actors with alter-table permission for a specific table.

Add API and HTML data tests for the new alter-table foreign key support.
---
 datasette/views/table.py              | 18 ++++++++++++++++++
 datasette/views/table_create_alter.py | 13 +++++++++++--
 tests/test_api_write.py               | 11 +++++++++++
 tests/test_table_html.py              |  6 ++++++
 4 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 988d3808..dbca3a18 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -382,6 +382,19 @@ async def _table_alter_ui(
         return None
 
     column_types_map = await datasette.get_column_types(database_name, table_name)
+    foreign_keys_by_column = {}
+    for fk in await db.foreign_keys_for_table(table_name):
+        other_column = fk["other_column"]
+        if other_column is None and await db.table_exists(fk["other_table"]):
+            other_pks = await db.primary_keys(fk["other_table"])
+            if len(other_pks) == 1:
+                other_column = other_pks[0]
+        if other_column is None:
+            continue
+        foreign_keys_by_column[fk["column"]] = {
+            "fk_table": fk["other_table"],
+            "fk_column": other_column,
+        }
     columns = []
     for column in await db.table_column_details(table_name):
         if column.hidden:
@@ -397,6 +410,7 @@ async def _table_alter_ui(
                 "default": column.default_value,
                 "has_default": column.default_value is not None,
                 "is_pk": column.name in pks,
+                "foreign_key": foreign_keys_by_column.get(column.name),
                 "column_type": (
                     {"type": column_type.name, "config": column_type.config}
                     if column_type is not None
@@ -412,6 +426,10 @@ async def _table_alter_ui(
         "primaryKeys": pks,
         "columnTypes": ALTER_TABLE_COLUMN_TYPES,
         "defaultExpressions": list(DEFAULT_EXPR_SQL),
+        "foreignKeyTargetsPath": "{}/-/foreign-key-targets?table={}".format(
+            datasette.urls.database(database_name),
+            urllib.parse.quote(table_name, safe=""),
+        ),
     }
     can_set_column_type = await datasette.allowed(
         action="set-column-type",
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index 07f13e9d..fa89aae4 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -867,11 +867,20 @@ class DatabaseForeignKeyTargetsView(BaseView):
         db = await self.ds.resolve_database(request)
         database_name = db.name
 
-        if not await self.ds.allowed(
+        table_name = request.args.get("table")
+        can_create_table = await self.ds.allowed(
             action="create-table",
             resource=DatabaseResource(database=database_name),
             actor=request.actor,
-        ):
+        )
+        can_alter_table = False
+        if table_name and await db.table_exists(table_name):
+            can_alter_table = await self.ds.allowed(
+                action="alter-table",
+                resource=TableResource(database=database_name, table=table_name),
+                actor=request.actor,
+            )
+        if not (can_create_table or can_alter_table):
             return _error(["Permission denied: need create-table"], 403)
 
         hidden_tables = await db.execute_fn(
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index ca8a46f5..6e8c4d4b 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1252,6 +1252,17 @@ async def test_foreign_key_targets_permission_denied(ds_write):
     }
 
 
+@pytest.mark.asyncio
+async def test_foreign_key_targets_allowed_for_alter_table(ds_write):
+    token = write_token(ds_write, permissions=["at"])
+    response = await ds_write.client.get(
+        "/data/-/foreign-key-targets?table=docs",
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    assert response.json()["ok"] is True
+
+
 @pytest.mark.asyncio
 async def test_alter_table_permission_denied(ds_write):
     token = write_token(ds_write, permissions=["ir"])
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 4c80691c..ba9c03a5 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1137,6 +1137,9 @@ async def test_table_alter_action_button_and_data():
         assert alter_data["tableName"] == "items"
         assert alter_data["primaryKeys"] == ["id"]
         assert alter_data["columnTypes"] == ["text", "integer", "float", "blob"]
+        assert alter_data["foreignKeyTargetsPath"] == (
+            "/data/-/foreign-key-targets?table=items"
+        )
         assert alter_data["defaultExpressions"] == [
             "current_timestamp",
             "current_date",
@@ -1158,6 +1161,7 @@ async def test_table_alter_action_button_and_data():
                 "default": None,
                 "has_default": False,
                 "is_pk": True,
+                "foreign_key": None,
                 "column_type": None,
             },
             {
@@ -1168,6 +1172,7 @@ async def test_table_alter_action_button_and_data():
                 "default": None,
                 "has_default": False,
                 "is_pk": False,
+                "foreign_key": None,
                 "column_type": {"type": "textarea", "config": None},
             },
             {
@@ -1178,6 +1183,7 @@ async def test_table_alter_action_button_and_data():
                 "default": "5",
                 "has_default": True,
                 "is_pk": False,
+                "foreign_key": None,
                 "column_type": None,
             },
         ]

From fa43aba30920eb268557897b2eb1d7d6a41acade Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 12:50:57 -0700
Subject: [PATCH 263/386] Unify create and alter table modal controls

Share default value controls between the create and alter table dialogs and expose create-table default expressions to the frontend.

Add create-table not-null/default handling and align the shared foreign key picker behavior across both dialogs.
---
 datasette/static/app.css              |  60 ++-
 datasette/static/edit-tools.js        | 716 ++++++++++++++++++++------
 datasette/views/table_create_alter.py |   1 +
 tests/test_playwright.py              |  99 +++-
 tests/test_table_html.py              |   5 +
 5 files changed, 709 insertions(+), 172 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 90d7e7e9..32b7a4c2 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1883,12 +1883,14 @@ select.table-create-input {
 }
 
 .table-create-foreign-key-target option,
-.table-create-custom-column-type option {
+.table-create-custom-column-type option,
+.table-create-default-expr option {
     color: var(--ink);
 }
 
 .table-create-foreign-key-target option[value=""],
-.table-create-custom-column-type option[value=""] {
+.table-create-custom-column-type option[value=""],
+.table-create-default-expr option[value=""] {
     color: var(--muted);
 }
 
@@ -1978,11 +1980,44 @@ select.table-create-input {
     white-space: normal;
 }
 
+.table-create-not-null,
 .table-create-primary-key,
-.table-create-foreign-key-field {
+.table-create-foreign-key-field,
+.table-create-default-options {
     grid-column: 1 / -1;
 }
 
+.table-create-default-options,
+.table-alter-default-options {
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    background: #fff;
+    color: var(--ink);
+    min-width: 0;
+}
+
+.table-create-default-options > summary,
+.table-alter-default-options > summary {
+    cursor: pointer;
+    color: var(--accent);
+    font-size: 0.85rem;
+    padding: 8px 10px;
+}
+
+.table-create-default-options > summary:focus,
+.table-alter-default-options > summary:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 1px;
+}
+
+.table-create-default-grid,
+.table-alter-default-grid {
+    display: grid;
+    grid-template-columns: minmax(0, 1fr) minmax(0, 1fr);
+    gap: 12px 16px;
+    padding: 0 10px 10px;
+}
+
 .table-create-detail-check input {
     flex: 0 0 auto;
     margin: 0.15rem 0 0;
@@ -2221,6 +2256,7 @@ dialog.table-alter-dialog::backdrop {
     overflow-y: auto;
 }
 
+
 .table-alter-fields[hidden],
 .table-alter-dialog .modal-footer [hidden] {
     display: none;
@@ -2358,12 +2394,14 @@ select.table-alter-input {
 }
 
 .table-alter-default-expr option,
-.table-alter-custom-column-type option {
+.table-alter-custom-column-type option,
+.table-alter-foreign-key-target option {
     color: var(--ink);
 }
 
 .table-alter-default-expr option[value=""],
-.table-alter-custom-column-type option[value=""] {
+.table-alter-custom-column-type option[value=""],
+.table-alter-foreign-key-target option[value=""] {
     color: var(--muted);
 }
 
@@ -2410,7 +2448,9 @@ select.table-alter-input {
 }
 
 .table-alter-not-null,
-.table-alter-primary-key {
+.table-alter-primary-key,
+.table-alter-foreign-key-field,
+.table-alter-default-options {
     grid-column: 1 / -1;
 }
 
@@ -2657,6 +2697,10 @@ select.table-alter-input {
         grid-template-columns: 1fr;
     }
 
+    .table-alter-default-grid {
+        grid-template-columns: 1fr;
+    }
+
     .table-alter-dialog .modal-footer {
         padding-left: 18px;
         padding-right: 18px;
@@ -2878,6 +2922,10 @@ select.table-alter-input {
         grid-template-columns: 1fr;
     }
 
+    .table-create-default-grid {
+        grid-template-columns: 1fr;
+    }
+
     .table-create-dialog .modal-footer {
         padding-left: 18px;
         padding-right: 18px;
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index c4982e54..2e4331e6 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -60,6 +60,11 @@ function tableCreateColumnTypes() {
     : ["text", "integer", "float", "blob"];
 }
 
+function tableCreateDefaultExpressions() {
+  var data = databaseCreateTableData() || {};
+  return data.defaultExpressions || [];
+}
+
 var SQLITE_COLUMN_TYPE_LABELS = {
   float: "floating point number",
   real: "floating point number",
@@ -104,6 +109,112 @@ function createCustomColumnTypeSelect(options, className, placeholderClass) {
   return select;
 }
 
+var DEFAULT_EXPRESSION_LABELS = {
+  current_timestamp: "Current timestamp in UTC, e.g. 2026-05-01 13:34:00",
+  current_date: "Current date in UTC, e.g. 2026-05-01",
+  current_time: "Current time in UTC, e.g. 13:34:00",
+};
+
+function defaultExpressionLabel(value) {
+  return DEFAULT_EXPRESSION_LABELS[value] || value.replace(/_/g, " ");
+}
+
+function createDefaultExpressionSelect(
+  options,
+  className,
+  placeholderClass,
+  value,
+) {
+  var select = document.createElement("select");
+  select.className = className;
+  var blankOption = document.createElement("option");
+  blankOption.value = "";
+  blankOption.textContent = "- default expr -";
+  select.appendChild(blankOption);
+  options.forEach(function (option) {
+    var optionElement = document.createElement("option");
+    optionElement.value = option;
+    optionElement.textContent = defaultExpressionLabel(option);
+    select.appendChild(optionElement);
+  });
+  select.value = value || "";
+  updateSelectPlaceholder(select, placeholderClass);
+  return select;
+}
+
+function createSchemaDialogDefaultControls(prefix, index, expressions, column) {
+  var defaultDetails = document.createElement("details");
+  defaultDetails.className = prefix + "-default-options";
+  defaultDetails.open = !!(
+    column &&
+    (column.defaultValue || column.defaultExpr)
+  );
+  var summary = document.createElement("summary");
+  summary.textContent = "Set a default value";
+  defaultDetails.appendChild(summary);
+
+  var defaultGrid = document.createElement("div");
+  defaultGrid.className = prefix + "-default-grid";
+
+  var defaultExprId = prefix + "-column-default-expr-" + index;
+  var defaultExprField = document.createElement("div");
+  defaultExprField.className = prefix + "-detail-field";
+  var defaultExprLabel = document.createElement("label");
+  defaultExprLabel.className = prefix + "-detail-label";
+  defaultExprLabel.setAttribute("for", defaultExprId);
+  defaultExprLabel.textContent = "Default expression";
+  var defaultExprSelect = createDefaultExpressionSelect(
+    expressions,
+    prefix + "-input " + prefix + "-default-expr",
+    prefix + "-input-placeholder",
+    column && column.defaultExpr,
+  );
+  defaultExprSelect.id = defaultExprId;
+  defaultExprSelect.setAttribute("aria-label", "Default expression");
+  defaultExprField.appendChild(defaultExprLabel);
+  defaultExprField.appendChild(defaultExprSelect);
+
+  var defaultId = prefix + "-column-default-" + index;
+  var defaultField = document.createElement("div");
+  defaultField.className = prefix + "-detail-field";
+  var defaultLabel = document.createElement("label");
+  defaultLabel.className = prefix + "-detail-label";
+  defaultLabel.setAttribute("for", defaultId);
+  defaultLabel.textContent = "or default to a specific value";
+  var defaultInput = document.createElement("input");
+  defaultInput.id = defaultId;
+  defaultInput.className = prefix + "-input " + prefix + "-default";
+  defaultInput.type = "text";
+  defaultInput.autocomplete = "off";
+  defaultInput.placeholder = "default";
+  defaultInput.setAttribute("aria-label", "or default to a specific value");
+  defaultInput.value = column && column.defaultValue ? column.defaultValue : "";
+  defaultField.appendChild(defaultLabel);
+  defaultField.appendChild(defaultInput);
+
+  defaultGrid.appendChild(defaultExprField);
+  defaultGrid.appendChild(defaultField);
+  defaultDetails.appendChild(defaultGrid);
+
+  return {
+    controls: defaultDetails,
+    defaultInput: defaultInput,
+    defaultExprSelect: defaultExprSelect,
+  };
+}
+
+function syncSchemaDialogDefaultControls(row, prefix) {
+  if (!row) {
+    return;
+  }
+  var defaultInput = row.querySelector("." + prefix + "-default");
+  var defaultExprSelect = row.querySelector("." + prefix + "-default-expr");
+  if (!defaultInput || !defaultExprSelect) {
+    return;
+  }
+  updateSelectPlaceholder(defaultExprSelect, prefix + "-input-placeholder");
+}
+
 var COLUMN_MOVE_ICONS = {
   top: '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m18 17-6-6-6 6"></path><path d="m18 11-6-6-6 6"></path></svg>',
   up: '<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="m18 15-6-6-6 6"></path></svg>',
@@ -316,7 +427,7 @@ function updateTableCreateMoveButtons(state) {
   updateSchemaDialogMoveButtons(state, "table-create");
 }
 
-function tableCreateTypeAffinity(type) {
+function schemaDialogTypeAffinity(type) {
   if (type === "float") {
     return "real";
   }
@@ -337,11 +448,11 @@ function foreignKeyTypesCompatible(sourceAffinity, targetAffinity) {
   return false;
 }
 
-function tableCreateForeignKeyTargetKey(target) {
+function foreignKeyTargetKey(target) {
   return target.fk_table + "\u001f" + target.fk_column;
 }
 
-function tableCreateForeignKeyTargetLabel(target) {
+function foreignKeyTargetLabel(target) {
   return (
     target.fk_table +
     "." +
@@ -352,6 +463,54 @@ function tableCreateForeignKeyTargetLabel(target) {
   );
 }
 
+function appendForeignKeyTargetOption(select, target) {
+  var optionElement = document.createElement("option");
+  optionElement.value = foreignKeyTargetKey(target);
+  optionElement.dataset.fkTable = target.fk_table;
+  optionElement.dataset.fkColumn = target.fk_column;
+  optionElement.dataset.fkType = target.type;
+  optionElement.textContent = foreignKeyTargetLabel(target);
+  select.appendChild(optionElement);
+  return optionElement;
+}
+
+function sqliteColumnTypeForForeignKeyTarget(type) {
+  var affinity = schemaDialogTypeAffinity(type);
+  if (affinity === "real" || affinity === "numeric") {
+    return "float";
+  }
+  if (["text", "integer", "blob"].indexOf(affinity) !== -1) {
+    return affinity;
+  }
+  return "";
+}
+
+function selectedSchemaDialogForeignKeyOption(foreignKeySelect) {
+  return foreignKeySelect && foreignKeySelect.selectedOptions
+    ? foreignKeySelect.selectedOptions[0]
+    : null;
+}
+
+function setBlankSchemaDialogColumnNameFromForeignKey(
+  row,
+  prefix,
+  foreignKeyOption,
+) {
+  var nameInput = row.querySelector("." + prefix + "-column-name");
+  if (
+    nameInput &&
+    !nameInput.value.trim() &&
+    foreignKeyOption &&
+    foreignKeyOption.dataset.fkTable &&
+    foreignKeyOption.dataset.fkColumn
+  ) {
+    nameInput.value =
+      foreignKeyOption.dataset.fkTable +
+      "_" +
+      foreignKeyOption.dataset.fkColumn;
+  }
+}
+
 function tableCreateForeignKeyTargetsUrl() {
   var data = databaseCreateTableData() || {};
   if (data.foreignKeyTargetsPath) {
@@ -363,7 +522,14 @@ function tableCreateForeignKeyTargetsUrl() {
   return data.path.replace(/\/-\/create$/, "/-/foreign-key-targets");
 }
 
-function populateTableCreateForeignKeySelect(select, state, sourceType) {
+function populateSchemaDialogForeignKeySelect(
+  select,
+  state,
+  prefix,
+  sourceType,
+  options,
+) {
+  options = options || {};
   var previousKey = select.value || select.dataset.selectedKey || "";
   select.textContent = "";
 
@@ -385,45 +551,64 @@ function populateTableCreateForeignKeySelect(select, state, sourceType) {
     errorOption.textContent = "Could not load foreign keys";
     select.appendChild(errorOption);
   } else {
-    var sourceAffinity = tableCreateTypeAffinity(sourceType);
+    var sourceAffinity = schemaDialogTypeAffinity(sourceType);
     (state.foreignKeyTargets || []).forEach(function (target) {
-      if (!foreignKeyTypesCompatible(sourceAffinity, target.type)) {
+      if (
+        options.filterByType !== false &&
+        !foreignKeyTypesCompatible(sourceAffinity, target.type)
+      ) {
         return;
       }
-      var optionElement = document.createElement("option");
-      optionElement.value = tableCreateForeignKeyTargetKey(target);
-      optionElement.dataset.fkTable = target.fk_table;
-      optionElement.dataset.fkColumn = target.fk_column;
-      optionElement.textContent = tableCreateForeignKeyTargetLabel(target);
-      select.appendChild(optionElement);
+      appendForeignKeyTargetOption(select, target);
     });
   }
 
   select.value = previousKey;
+  if (
+    previousKey &&
+    select.value !== previousKey &&
+    select.dataset.currentFkTable &&
+    select.dataset.currentFkColumn
+  ) {
+    appendForeignKeyTargetOption(select, {
+      fk_table: select.dataset.currentFkTable,
+      fk_column: select.dataset.currentFkColumn,
+      type: select.dataset.currentFkType || sourceType,
+    });
+    select.value = previousKey;
+  }
   if (select.value !== previousKey) {
     select.value = "";
   }
   select.dataset.selectedKey = select.value;
   select.disabled = state.isSaving || select.options.length <= 1;
-  updateSelectPlaceholder(select, "table-create-input-placeholder");
+  updateSelectPlaceholder(select, prefix + "-input-placeholder");
 }
 
-function syncTableCreateForeignKeyOptions(row, state) {
-  var typeSelect = row.querySelector(".table-create-column-type");
-  var foreignKeySelect = row.querySelector(".table-create-foreign-key-target");
+function syncSchemaDialogForeignKeyOptions(row, state, prefix, options) {
+  var typeSelect = row.querySelector("." + prefix + "-column-type");
+  var foreignKeySelect = row.querySelector(
+    "." + prefix + "-foreign-key-target",
+  );
   if (!typeSelect || !foreignKeySelect) {
     return;
   }
-  populateTableCreateForeignKeySelect(
+  populateSchemaDialogForeignKeySelect(
     foreignKeySelect,
     state,
+    prefix,
     typeSelect.value,
+    options,
   );
 }
 
-function syncTableCreateCustomTypeAndForeignKey(row, state, isFirstColumn) {
-  var customTypeSelect = row.querySelector(".table-create-custom-column-type");
-  var foreignKeySelect = row.querySelector(".table-create-foreign-key-target");
+function syncSchemaDialogCustomTypeAndForeignKey(row, state, prefix) {
+  var customTypeSelect = row.querySelector(
+    "." + prefix + "-custom-column-type",
+  );
+  var foreignKeySelect = row.querySelector(
+    "." + prefix + "-foreign-key-target",
+  );
   if (!foreignKeySelect) {
     return;
   }
@@ -433,14 +618,14 @@ function syncTableCreateCustomTypeAndForeignKey(row, state, isFirstColumn) {
 
   if (customTypeSelect && hasForeignKey) {
     customTypeSelect.value = "";
-    updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+    updateSelectPlaceholder(customTypeSelect, prefix + "-input-placeholder");
     hasCustomType = false;
   }
 
-  if (isFirstColumn || hasCustomType) {
+  if (hasCustomType) {
     foreignKeySelect.value = "";
     foreignKeySelect.dataset.selectedKey = "";
-    updateTableCreateCustomColumnTypePlaceholder(foreignKeySelect);
+    updateSelectPlaceholder(foreignKeySelect, prefix + "-input-placeholder");
     hasForeignKey = false;
   }
 
@@ -448,63 +633,73 @@ function syncTableCreateCustomTypeAndForeignKey(row, state, isFirstColumn) {
     customTypeSelect.disabled = state.isSaving;
   }
   foreignKeySelect.disabled =
-    state.isSaving || isFirstColumn || foreignKeySelect.options.length <= 1;
+    state.isSaving || foreignKeySelect.options.length <= 1;
 }
 
-function refreshTableCreateForeignKeyControls(state) {
-  tableCreateDialogRows(state).forEach(function (row, index) {
-    if (index > 0) {
-      syncTableCreateForeignKeyOptions(row, state);
-    }
-    syncTableCreateCustomTypeAndForeignKey(row, state, index === 0);
-  });
-}
+function handleSchemaDialogForeignKeyChange(row, state, prefix, options) {
+  options = options || {};
+  var foreignKeySelect = row.querySelector(
+    "." + prefix + "-foreign-key-target",
+  );
+  var typeSelect = row.querySelector("." + prefix + "-column-type");
+  var customTypeSelect = row.querySelector(
+    "." + prefix + "-custom-column-type",
+  );
+  if (!foreignKeySelect) {
+    return;
+  }
+  foreignKeySelect.dataset.selectedKey = foreignKeySelect.value;
+  updateSelectPlaceholder(foreignKeySelect, prefix + "-input-placeholder");
 
-function updateTableCreateColumnRules(state) {
-  tableCreateDialogRows(state).forEach(function (row, index) {
-    var isFirstColumn = index === 0;
-    var pkLabel = row.querySelector(".table-create-primary-key");
-    var pkInput = row.querySelector(".table-create-primary-key-input");
-    var foreignKeyField = row.querySelector(".table-create-foreign-key-field");
-    var foreignKeySelect = row.querySelector(
-      ".table-create-foreign-key-target",
+  var foreignKeyOption = selectedSchemaDialogForeignKeyOption(foreignKeySelect);
+  setBlankSchemaDialogColumnNameFromForeignKey(row, prefix, foreignKeyOption);
+
+  var columnTypes = options.columnTypes || [];
+  var foreignKeyColumnType =
+    foreignKeyOption && foreignKeyOption.dataset.fkType
+      ? sqliteColumnTypeForForeignKeyTarget(foreignKeyOption.dataset.fkType)
+      : "";
+  if (
+    options.matchType &&
+    typeSelect &&
+    foreignKeyColumnType &&
+    columnTypes.indexOf(foreignKeyColumnType) !== -1 &&
+    typeSelect.value !== foreignKeyColumnType
+  ) {
+    typeSelect.value = foreignKeyColumnType;
+    syncSchemaDialogForeignKeyOptions(
+      row,
+      state,
+      prefix,
+      options.foreignKeyOptions,
     );
+  }
 
-    if (pkLabel && pkInput) {
-      pkLabel.hidden = !isFirstColumn;
-      if (!isFirstColumn) {
-        pkInput.checked = false;
-      }
-    }
-
-    if (foreignKeyField && foreignKeySelect) {
-      foreignKeyField.hidden = isFirstColumn;
-      if (isFirstColumn) {
-        foreignKeySelect.value = "";
-        foreignKeySelect.dataset.selectedKey = "";
-        foreignKeySelect.disabled = true;
-        updateTableCreateCustomColumnTypePlaceholder(foreignKeySelect);
-      } else {
-        syncTableCreateForeignKeyOptions(row, state);
-      }
-      syncTableCreateCustomTypeAndForeignKey(row, state, isFirstColumn);
-    }
-  });
-  updateTableCreateMoveButtons(state);
+  if (customTypeSelect && foreignKeySelect.value) {
+    customTypeSelect.value = "";
+    updateSelectPlaceholder(customTypeSelect, prefix + "-input-placeholder");
+  }
+  syncSchemaDialogCustomTypeAndForeignKey(row, state, prefix);
 }
 
-async function loadTableCreateForeignKeyTargets(state) {
-  var url = tableCreateForeignKeyTargetsUrl();
+function refreshSchemaDialogForeignKeyControls(state, prefix, options) {
+  schemaDialogRows(state, prefix).forEach(function (row) {
+    syncSchemaDialogForeignKeyOptions(row, state, prefix, options);
+    syncSchemaDialogCustomTypeAndForeignKey(row, state, prefix);
+  });
+}
+
+async function loadSchemaDialogForeignKeyTargets(state, prefix, url, options) {
   if (!url || !window.fetch) {
     state.foreignKeyTargets = [];
     state.foreignKeyTargetsLoading = false;
-    refreshTableCreateForeignKeyControls(state);
+    refreshSchemaDialogForeignKeyControls(state, prefix, options);
     return;
   }
   state.foreignKeyTargets = [];
   state.foreignKeyTargetsError = null;
   state.foreignKeyTargetsLoading = true;
-  refreshTableCreateForeignKeyControls(state);
+  refreshSchemaDialogForeignKeyControls(state, prefix, options);
   try {
     var response = await fetch(url, {
       headers: {
@@ -521,10 +716,46 @@ async function loadTableCreateForeignKeyTargets(state) {
     state.foreignKeyTargetsError = error;
   } finally {
     state.foreignKeyTargetsLoading = false;
-    refreshTableCreateForeignKeyControls(state);
+    refreshSchemaDialogForeignKeyControls(state, prefix, options);
   }
 }
 
+function syncTableCreateForeignKeyOptions(row, state) {
+  syncSchemaDialogForeignKeyOptions(row, state, "table-create", {
+    filterByType: false,
+  });
+}
+
+function syncTableCreateCustomTypeAndForeignKey(row, state) {
+  syncSchemaDialogCustomTypeAndForeignKey(row, state, "table-create");
+}
+
+function refreshTableCreateForeignKeyControls(state) {
+  tableCreateDialogRows(state).forEach(function (row) {
+    syncTableCreateForeignKeyOptions(row, state);
+    syncTableCreateCustomTypeAndForeignKey(row, state);
+  });
+}
+
+function updateTableCreateColumnRules(state) {
+  normalizeSchemaDialogPrimaryKeyRows(state, "table-create");
+  tableCreateDialogRows(state).forEach(function (row) {
+    syncTableCreateForeignKeyOptions(row, state);
+    syncTableCreateCustomTypeAndForeignKey(row, state);
+    syncSchemaDialogDefaultControls(row, "table-create");
+  });
+  updateTableCreateMoveButtons(state);
+}
+
+async function loadTableCreateForeignKeyTargets(state) {
+  return loadSchemaDialogForeignKeyTargets(
+    state,
+    "table-create",
+    tableCreateForeignKeyTargetsUrl(),
+    { filterByType: false },
+  );
+}
+
 function tableCreateDialogSignature(state) {
   if (!state || !state.form) {
     return "";
@@ -542,6 +773,9 @@ function tableCreateDialogSignature(state) {
             }
           ).value || "",
         pk: row.querySelector(".table-create-primary-key-input").checked,
+        notNull: row.querySelector(".table-create-not-null-input").checked,
+        defaultValue: row.querySelector(".table-create-default").value,
+        defaultExpr: row.querySelector(".table-create-default-expr").value,
         foreignKey:
           (
             row.querySelector(".table-create-foreign-key-target") || {
@@ -654,6 +888,7 @@ function createTableColumnRow(state, column) {
   nameInput.type = "text";
   nameInput.required = true;
   nameInput.autocomplete = "off";
+  nameInput.placeholder = "column name";
   nameInput.value = column && column.name ? column.name : "";
 
   var typeSelect = document.createElement("select");
@@ -728,6 +963,32 @@ function createTableColumnRow(state, column) {
   foreignKeyField.appendChild(foreignKeyHelp);
   foreignKeyField.appendChild(foreignKeySelect);
 
+  var notNullLabel = document.createElement("label");
+  notNullLabel.className = "table-create-detail-check table-create-not-null";
+  var notNullInput = document.createElement("input");
+  notNullInput.type = "checkbox";
+  notNullInput.className = "table-create-not-null-input";
+  notNullInput.checked = !!(column && column.notNull);
+  var notNullText = document.createElement("span");
+  var notNullStrong = document.createElement("strong");
+  notNullStrong.textContent = "Not null";
+  notNullText.appendChild(notNullStrong);
+  notNullText.appendChild(
+    document.createTextNode(" This value cannot be left unset"),
+  );
+  notNullLabel.appendChild(notNullInput);
+  notNullLabel.appendChild(notNullText);
+
+  var defaultControls = createSchemaDialogDefaultControls(
+    "table-create",
+    index,
+    tableCreateDefaultExpressions(),
+    {
+      defaultValue: column && column.defaultValue,
+      defaultExpr: column && column.defaultExpr,
+    },
+  );
+
   var moveControls = createSchemaDialogMoveControls("table-create");
 
   var removeButton = createSchemaDialogIconButton(
@@ -748,8 +1009,10 @@ function createTableColumnRow(state, column) {
   if (customTypeField) {
     details.appendChild(customTypeField);
   }
-  details.appendChild(foreignKeyField);
+  details.appendChild(defaultControls.controls);
+  details.appendChild(notNullLabel);
   details.appendChild(pkLabel);
+  details.appendChild(foreignKeyField);
   row.appendChild(main);
   row.appendChild(details);
 
@@ -775,11 +1038,7 @@ function createTableColumnRow(state, column) {
     clearTableCreateDialogError(state);
     syncTableCreateCustomTypeForSqliteType(row);
     syncTableCreateForeignKeyOptions(row, state);
-    syncTableCreateCustomTypeAndForeignKey(
-      row,
-      state,
-      row === state.columnList.firstElementChild,
-    );
+    syncTableCreateCustomTypeAndForeignKey(row, state);
   });
   if (customTypeSelect) {
     customTypeSelect.addEventListener("change", function () {
@@ -798,30 +1057,37 @@ function createTableColumnRow(state, column) {
         typeSelect.value = option.fixedSqliteType;
         syncTableCreateForeignKeyOptions(row, state);
       }
-      syncTableCreateCustomTypeAndForeignKey(
-        row,
-        state,
-        row === state.columnList.firstElementChild,
-      );
+      syncTableCreateCustomTypeAndForeignKey(row, state);
     });
   }
   pkInput.addEventListener("change", function () {
     clearTableCreateDialogError(state);
     updateTableCreateColumnRules(state);
   });
-  foreignKeySelect.addEventListener("change", function () {
-    foreignKeySelect.dataset.selectedKey = foreignKeySelect.value;
+  notNullInput.addEventListener("change", function () {
     clearTableCreateDialogError(state);
-    updateTableCreateCustomColumnTypePlaceholder(foreignKeySelect);
-    if (customTypeSelect && foreignKeySelect.value) {
-      customTypeSelect.value = "";
-      updateTableCreateCustomColumnTypePlaceholder(customTypeSelect);
+  });
+  defaultControls.defaultInput.addEventListener("input", function () {
+    if (defaultControls.defaultInput.value) {
+      defaultControls.defaultExprSelect.value = "";
+      syncSchemaDialogDefaultControls(row, "table-create");
     }
-    syncTableCreateCustomTypeAndForeignKey(
-      row,
-      state,
-      row === state.columnList.firstElementChild,
-    );
+    clearTableCreateDialogError(state);
+  });
+  defaultControls.defaultExprSelect.addEventListener("change", function () {
+    if (defaultControls.defaultExprSelect.value) {
+      defaultControls.defaultInput.value = "";
+    }
+    syncSchemaDialogDefaultControls(row, "table-create");
+    clearTableCreateDialogError(state);
+  });
+  foreignKeySelect.addEventListener("change", function () {
+    clearTableCreateDialogError(state);
+    handleSchemaDialogForeignKeyChange(row, state, "table-create", {
+      columnTypes: tableCreateColumnTypes(),
+      foreignKeyOptions: { filterByType: false },
+      matchType: true,
+    });
   });
 
   expandButton.addEventListener("click", function () {
@@ -887,6 +1153,7 @@ function createTableColumnRow(state, column) {
     row.querySelector(".table-create-column-name").focus();
   });
 
+  syncSchemaDialogDefaultControls(row, "table-create");
   return row;
 }
 
@@ -921,7 +1188,7 @@ function collectTableCreatePayload(state) {
     columns: [],
   };
   var primaryKeys = [];
-  tableCreateDialogRows(state).forEach(function (row, index) {
+  tableCreateDialogRows(state).forEach(function (row) {
     var name = row.querySelector(".table-create-column-name").value.trim();
     var type = row.querySelector(".table-create-column-type").value;
     var column = { name: name, type: type };
@@ -933,7 +1200,6 @@ function collectTableCreatePayload(state) {
         ? foreignKeySelect.selectedOptions[0]
         : null;
     if (
-      index > 0 &&
       foreignKeyOption &&
       foreignKeyOption.dataset.fkTable &&
       foreignKeyOption.dataset.fkColumn
@@ -941,11 +1207,18 @@ function collectTableCreatePayload(state) {
       column.fk_table = foreignKeyOption.dataset.fkTable;
       column.fk_column = foreignKeyOption.dataset.fkColumn;
     }
+    if (row.querySelector(".table-create-not-null-input").checked) {
+      column.not_null = true;
+    }
+    var defaultExpr = row.querySelector(".table-create-default-expr").value;
+    var defaultValue = row.querySelector(".table-create-default").value;
+    if (defaultExpr) {
+      column.default_expr = defaultExpr;
+    } else if (defaultValue) {
+      column.default = defaultValue;
+    }
     payload.columns.push(column);
-    if (
-      index === 0 &&
-      row.querySelector(".table-create-primary-key-input").checked
-    ) {
+    if (row.querySelector(".table-create-primary-key-input").checked) {
       primaryKeys.push(name);
     }
   });
@@ -1006,6 +1279,9 @@ function validateTableCreatePayload(payload) {
     if (supportedTypes.indexOf(column.type) === -1) {
       return "Unsupported column type: " + column.type;
     }
+    if (column.default && column.default_expr) {
+      return "Use either a default value or a default expression.";
+    }
   }
   return null;
 }
@@ -1467,6 +1743,11 @@ function tableAlterDefaultExpressions() {
   return data.defaultExpressions || [];
 }
 
+function tableAlterForeignKeyTargetsUrl() {
+  var data = tableAlterData() || {};
+  return data.foreignKeyTargetsPath || null;
+}
+
 function tableAlterCustomColumnTypes() {
   var data = tableAlterData() || {};
   return data.customColumnTypes || [];
@@ -1494,7 +1775,21 @@ function tableAlterDialogRows(state) {
   return schemaDialogRows(state, "table-alter");
 }
 
+function syncTableAlterForeignKeyOptions(row, state) {
+  syncSchemaDialogForeignKeyOptions(row, state, "table-alter", {
+    filterByType: false,
+  });
+}
+
 function tableAlterRowSignature(row) {
+  var foreignKeySelect = row.querySelector(".table-alter-foreign-key-target");
+  var foreignKeyValue = foreignKeySelect
+    ? foreignKeySelect.value || foreignKeySelect.dataset.selectedKey || ""
+    : "";
+  var foreignKeyOption =
+    foreignKeySelect && foreignKeySelect.selectedOptions
+      ? foreignKeySelect.selectedOptions[0]
+      : null;
   return {
     existing: row.dataset.existing === "1",
     originalName: row.dataset.originalName || "",
@@ -1510,6 +1805,15 @@ function tableAlterRowSignature(row) {
     defaultValue: row.querySelector(".table-alter-default").value,
     defaultExpr: row.querySelector(".table-alter-default-expr").value,
     pk: row.querySelector(".table-alter-primary-key-input").checked,
+    foreignKey: foreignKeyValue,
+    foreignKeyTable:
+      foreignKeyOption && foreignKeyOption.dataset.fkTable
+        ? foreignKeyOption.dataset.fkTable
+        : "",
+    foreignKeyColumn:
+      foreignKeyOption && foreignKeyOption.dataset.fkColumn
+        ? foreignKeyOption.dataset.fkColumn
+        : "",
   };
 }
 
@@ -1581,7 +1885,7 @@ function setTableAlterDialogSaving(state, isSaving) {
       ? "Applying..."
       : "Preparing..."
     : tableAlterSaveButtonText(state);
-  state.columnList
+  state.fields
     .querySelectorAll("input, select, button")
     .forEach(function (control) {
       control.disabled = isSaving;
@@ -1590,10 +1894,12 @@ function setTableAlterDialogSaving(state, isSaving) {
     state.columnList
       .querySelectorAll(".table-alter-default-expr")
       .forEach(function (select) {
-        syncTableAlterDefaultControls(
+        syncSchemaDialogDefaultControls(
           select.closest(".table-alter-column-row"),
+          "table-alter",
         );
       });
+    refreshSchemaDialogForeignKeyControls(state, "table-alter");
   }
   updateTableAlterMoveButtons(state);
   updateTableAlterSaveButtonState(state);
@@ -1634,38 +1940,6 @@ function syncTableAlterCustomTypeForSqliteType(row) {
   }
 }
 
-function tableAlterSelectDefaultExprValue(select, value) {
-  var blankOption = document.createElement("option");
-  blankOption.value = "";
-  blankOption.textContent = "- default expr -";
-  select.appendChild(blankOption);
-  tableAlterDefaultExpressions().forEach(function (option) {
-    var optionElement = document.createElement("option");
-    optionElement.value = option;
-    optionElement.textContent = option.replace(/_/g, " ");
-    select.appendChild(optionElement);
-  });
-  select.value = value || "";
-  updateTableAlterDefaultExprPlaceholder(select);
-}
-
-function updateTableAlterDefaultExprPlaceholder(select) {
-  updateSelectPlaceholder(select, "table-alter-input-placeholder");
-}
-
-function syncTableAlterDefaultControls(row) {
-  if (!row) {
-    return;
-  }
-  var defaultInput = row.querySelector(".table-alter-default");
-  var defaultExprSelect = row.querySelector(".table-alter-default-expr");
-  if (!defaultInput || !defaultExprSelect) {
-    return;
-  }
-  defaultInput.disabled = !!defaultExprSelect.value;
-  updateTableAlterDefaultExprPlaceholder(defaultExprSelect);
-}
-
 function createTableAlterColumnRow(state, column) {
   var index = state.nextColumnIndex;
   state.nextColumnIndex += 1;
@@ -1677,6 +1951,10 @@ function createTableAlterColumnRow(state, column) {
     existing && column.has_default && column.default !== null
       ? String(column.default)
       : "";
+  var originalForeignKey =
+    existing && column.foreign_key
+      ? foreignKeyTargetKey(column.foreign_key)
+      : "";
 
   var row = document.createElement("div");
   row.className = "table-alter-column-row";
@@ -1688,6 +1966,7 @@ function createTableAlterColumnRow(state, column) {
   row.dataset.originalDefault = originalDefault;
   row.dataset.originalPk = existing && column.is_pk ? "1" : "0";
   row.dataset.originalCustomType = originalCustomType;
+  row.dataset.originalForeignKey = originalForeignKey;
 
   var main = document.createElement("div");
   main.className = "table-alter-column-main";
@@ -1714,6 +1993,7 @@ function createTableAlterColumnRow(state, column) {
   nameInput.type = "text";
   nameInput.required = true;
   nameInput.autocomplete = "off";
+  nameInput.placeholder = "column name";
   nameInput.value = column && column.name ? column.name : "";
 
   var typeSelect = document.createElement("select");
@@ -1764,38 +2044,51 @@ function createTableAlterColumnRow(state, column) {
   notNullLabel.appendChild(notNullInput);
   notNullLabel.appendChild(notNullText);
 
-  var defaultId = "table-alter-column-default-" + index;
-  var defaultField = document.createElement("div");
-  defaultField.className = "table-alter-detail-field";
-  var defaultLabel = document.createElement("label");
-  defaultLabel.className = "table-alter-detail-label";
-  defaultLabel.setAttribute("for", defaultId);
-  defaultLabel.textContent = "Default value";
-  var defaultInput = document.createElement("input");
-  defaultInput.id = defaultId;
-  defaultInput.className = "table-alter-input table-alter-default";
-  defaultInput.type = "text";
-  defaultInput.autocomplete = "off";
-  defaultInput.placeholder = "default";
-  defaultInput.setAttribute("aria-label", "Default value");
-  defaultInput.value = originalDefault;
-  defaultField.appendChild(defaultLabel);
-  defaultField.appendChild(defaultInput);
+  var defaultControls = createSchemaDialogDefaultControls(
+    "table-alter",
+    index,
+    tableAlterDefaultExpressions(),
+    {
+      defaultValue: originalDefault,
+      defaultExpr: "",
+    },
+  );
+  var defaultInput = defaultControls.defaultInput;
+  var defaultExprSelect = defaultControls.defaultExprSelect;
 
-  var defaultExprId = "table-alter-column-default-expr-" + index;
-  var defaultExprField = document.createElement("div");
-  defaultExprField.className = "table-alter-detail-field";
-  var defaultExprLabel = document.createElement("label");
-  defaultExprLabel.className = "table-alter-detail-label";
-  defaultExprLabel.setAttribute("for", defaultExprId);
-  defaultExprLabel.textContent = "or default to a specific time";
-  var defaultExprSelect = document.createElement("select");
-  defaultExprSelect.id = defaultExprId;
-  defaultExprSelect.className = "table-alter-input table-alter-default-expr";
-  defaultExprSelect.setAttribute("aria-label", "or default to a specific time");
-  tableAlterSelectDefaultExprValue(defaultExprSelect, "");
-  defaultExprField.appendChild(defaultExprLabel);
-  defaultExprField.appendChild(defaultExprSelect);
+  var foreignKeyId = "table-alter-column-foreign-key-" + index;
+  var foreignKeyHelpId = "table-alter-column-foreign-key-help-" + index;
+  var foreignKeyField = document.createElement("div");
+  foreignKeyField.className =
+    "table-alter-detail-field table-alter-foreign-key-field";
+  var foreignKeyLabel = document.createElement("label");
+  foreignKeyLabel.className = "table-alter-detail-label";
+  foreignKeyLabel.setAttribute("for", foreignKeyId);
+  foreignKeyLabel.textContent = "Foreign key";
+  var foreignKeyHelp = document.createElement("p");
+  foreignKeyHelp.id = foreignKeyHelpId;
+  foreignKeyHelp.className = "table-alter-detail-help";
+  foreignKeyHelp.textContent = "Link this column to another table.";
+  var foreignKeySelect = document.createElement("select");
+  foreignKeySelect.id = foreignKeyId;
+  foreignKeySelect.className =
+    "table-alter-input table-alter-foreign-key-target";
+  foreignKeySelect.setAttribute("aria-label", "Foreign key target");
+  foreignKeySelect.setAttribute("aria-describedby", foreignKeyHelpId);
+  foreignKeySelect.dataset.selectedKey = originalForeignKey;
+  if (column && column.foreign_key) {
+    foreignKeySelect.dataset.currentFkTable = column.foreign_key.fk_table;
+    foreignKeySelect.dataset.currentFkColumn = column.foreign_key.fk_column;
+    appendForeignKeyTargetOption(foreignKeySelect, {
+      fk_table: column.foreign_key.fk_table,
+      fk_column: column.foreign_key.fk_column,
+      type: column.type || "text",
+    });
+    foreignKeySelect.value = originalForeignKey;
+  }
+  foreignKeyField.appendChild(foreignKeyLabel);
+  foreignKeyField.appendChild(foreignKeyHelp);
+  foreignKeyField.appendChild(foreignKeySelect);
 
   var pkLabel = document.createElement("label");
   pkLabel.className = "table-alter-detail-check table-alter-primary-key";
@@ -1832,10 +2125,10 @@ function createTableAlterColumnRow(state, column) {
   if (customTypeField) {
     details.appendChild(customTypeField);
   }
+  details.appendChild(defaultControls.controls);
   details.appendChild(notNullLabel);
-  details.appendChild(defaultField);
-  details.appendChild(defaultExprField);
   details.appendChild(pkLabel);
+  details.appendChild(foreignKeyField);
   row.appendChild(main);
   row.appendChild(details);
 
@@ -1846,6 +2139,7 @@ function createTableAlterColumnRow(state, column) {
     defaultInput,
     defaultExprSelect,
     pkInput,
+    foreignKeySelect,
   ];
   if (customTypeSelect) {
     controls.push(customTypeSelect);
@@ -1864,7 +2158,7 @@ function createTableAlterColumnRow(state, column) {
   defaultInput.addEventListener("input", function () {
     if (defaultInput.value) {
       defaultExprSelect.value = "";
-      syncTableAlterDefaultControls(row);
+      syncSchemaDialogDefaultControls(row, "table-alter");
     }
     updateTableAlterSaveButtonState(state);
   });
@@ -1872,7 +2166,7 @@ function createTableAlterColumnRow(state, column) {
     if (defaultExprSelect.value) {
       defaultInput.value = "";
     }
-    syncTableAlterDefaultControls(row);
+    syncSchemaDialogDefaultControls(row, "table-alter");
     updateTableAlterSaveButtonState(state);
   });
   pkInput.addEventListener("change", function () {
@@ -1887,6 +2181,8 @@ function createTableAlterColumnRow(state, column) {
 
   typeSelect.addEventListener("change", function () {
     syncTableAlterCustomTypeForSqliteType(row);
+    syncTableAlterForeignKeyOptions(row, state);
+    syncSchemaDialogCustomTypeAndForeignKey(row, state, "table-alter");
     updateTableAlterSaveButtonState(state);
   });
   if (customTypeSelect) {
@@ -1899,10 +2195,20 @@ function createTableAlterColumnRow(state, column) {
         tableAlterColumnTypes().indexOf(option.fixedSqliteType) !== -1
       ) {
         typeSelect.value = option.fixedSqliteType;
+        syncTableAlterForeignKeyOptions(row, state);
       }
+      syncSchemaDialogCustomTypeAndForeignKey(row, state, "table-alter");
       updateTableAlterSaveButtonState(state);
     });
   }
+  foreignKeySelect.addEventListener("change", function () {
+    handleSchemaDialogForeignKeyChange(row, state, "table-alter", {
+      columnTypes: tableAlterColumnTypes(),
+      foreignKeyOptions: { filterByType: false },
+      matchType: true,
+    });
+    updateTableAlterSaveButtonState(state);
+  });
 
   moveControls.topButton.addEventListener("click", function () {
     var first = tableAlterFirstNonPrimaryRow(state);
@@ -1986,7 +2292,9 @@ function createTableAlterColumnRow(state, column) {
     }
   });
 
-  syncTableAlterDefaultControls(row);
+  syncSchemaDialogDefaultControls(row, "table-alter");
+  syncTableAlterForeignKeyOptions(row, state);
+  syncSchemaDialogCustomTypeAndForeignKey(row, state, "table-alter");
   return row;
 }
 
@@ -2026,6 +2334,7 @@ function collectTableAlterRows(state) {
     signature.originalDefault = row.dataset.originalDefault || "";
     signature.originalPk = row.dataset.originalPk === "1";
     signature.originalCustomType = row.dataset.originalCustomType || "";
+    signature.originalForeignKey = row.dataset.originalForeignKey || "";
     return signature;
   });
 }
@@ -2156,6 +2465,46 @@ function tableAlterColumnsReordered(state, rows) {
   );
 }
 
+function tableAlterForeignKeyIdentity(row) {
+  return [
+    row.name.trim(),
+    row.foreignKeyTable || "",
+    row.foreignKeyColumn || "",
+  ].join("\u001f");
+}
+
+function tableAlterOriginalForeignKeyIdentity(row) {
+  return [row.originalName || "", row.originalForeignKey].join("\u001f");
+}
+
+function tableAlterForeignKeyRows(rows) {
+  return rows
+    .filter(function (row) {
+      return row.foreignKey && row.foreignKeyTable && row.foreignKeyColumn;
+    })
+    .map(function (row) {
+      return {
+        column: row.name.trim(),
+        fk_table: row.foreignKeyTable,
+        fk_column: row.foreignKeyColumn,
+      };
+    });
+}
+
+function tableAlterForeignKeysChanged(rows) {
+  var original = rows
+    .filter(function (row) {
+      return row.existing && row.originalForeignKey;
+    })
+    .map(tableAlterOriginalForeignKeyIdentity);
+  var final = rows
+    .filter(function (row) {
+      return row.foreignKey && row.foreignKeyTable && row.foreignKeyColumn;
+    })
+    .map(tableAlterForeignKeyIdentity);
+  return JSON.stringify(original) !== JSON.stringify(final);
+}
+
 function collectTableAlterPayload(state) {
   var rows = collectTableAlterRows(state);
   var validationError = validateTableAlterRows(state, rows);
@@ -2237,6 +2586,15 @@ function collectTableAlterPayload(state) {
     });
   }
 
+  if (tableAlterForeignKeysChanged(rows)) {
+    operations.push({
+      op: "set_foreign_keys",
+      args: {
+        foreign_keys: tableAlterForeignKeyRows(rows),
+      },
+    });
+  }
+
   if (!operations.length && !columnTypeAssignments.length) {
     return { error: "No changes to apply." };
   }
@@ -2354,6 +2712,27 @@ function tableAlterOperationSummary(operation) {
       damaging: false,
     };
   }
+  if (operation.op === "set_foreign_keys") {
+    var foreignKeys = args.foreign_keys || [];
+    return {
+      text: foreignKeys.length
+        ? "Set foreign keys to " +
+          foreignKeys
+            .map(function (foreignKey) {
+              return (
+                tableAlterQuotedName(foreignKey.column) +
+                " -> " +
+                foreignKey.fk_table +
+                "." +
+                foreignKey.fk_column
+              );
+            })
+            .join(", ") +
+          "."
+        : "Remove all foreign keys.",
+      damaging: false,
+    };
+  }
   return {
     text: "Run " + operation.op + ".",
     damaging: false,
@@ -2742,6 +3121,9 @@ function ensureTableAlterDialog(manager) {
     deletedColumns: [],
     originalColumnNames: [],
     originalPrimaryKeys: [],
+    foreignKeyTargets: [],
+    foreignKeyTargetsError: null,
+    foreignKeyTargetsLoading: false,
     mode: "edit",
     reviewResult: null,
     manager: manager,
@@ -2844,6 +3226,12 @@ function openTableAlterDialog(button, manager) {
   state.title.textContent = "Alter table " + data.tableName;
   clearTableAlterDialogError(state);
   resetTableAlterDialog(state, data);
+  loadSchemaDialogForeignKeyTargets(
+    state,
+    "table-alter",
+    tableAlterForeignKeyTargetsUrl(),
+    { filterByType: false },
+  );
   if (!state.dialog.open) {
     state.dialog.showModal();
   }
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index fa89aae4..111dfab1 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -266,6 +266,7 @@ async def _create_table_ui_context(
         ),
         "databaseName": database_name,
         "columnTypes": CREATE_TABLE_COLUMN_TYPES,
+        "defaultExpressions": list(DEFAULT_EXPR_SQL),
     }
     can_set_column_type = await datasette.allowed(
         action="set-column-type",
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index eefec118..5719039a 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -295,6 +295,10 @@ def test_create_table_flow(page, datasette_server):
         placeholder_select.locator("option:checked").inner_text() == "- custom type -"
     )
     assert "table-create-input-placeholder" in placeholder_select.get_attribute("class")
+    assert (
+        dialog.locator(".table-create-column-name").nth(0).get_attribute("placeholder")
+        == "column name"
+    )
     assert dialog.locator(".table-create-column-main").first.evaluate("""node => {
             const inputHeight = node.querySelector(
                 ".table-create-column-name"
@@ -306,6 +310,22 @@ def test_create_table_flow(page, datasette_server):
         }""")
     dialog.locator('input[name="table"]').fill("playwright_created")
     dialog.locator(".table-create-column-name").nth(1).fill("title")
+    dialog.locator(".table-create-more-options").nth(1).click()
+    dialog.locator(".table-create-not-null-input").nth(1).check()
+    title_defaults = dialog.locator(".table-create-default-options").nth(1)
+    assert title_defaults.locator("summary").inner_text() == "Set a default value"
+    title_defaults.locator("summary").click()
+    assert "or default to a specific value" in title_defaults.inner_text()
+    title_default_expr = title_defaults.locator(".table-create-default-expr")
+    title_default_input = title_defaults.locator(".table-create-default")
+    assert (
+        "Current timestamp in UTC, e.g. 2026-05-01 13:34:00"
+        in title_default_expr.locator("option").nth(1).inner_text()
+    )
+    title_default_expr.select_option("current_timestamp")
+    assert title_default_input.is_enabled()
+    title_default_input.fill("Untitled")
+    assert title_default_expr.input_value() == ""
     dialog.locator(".table-create-add-column").click()
     dialog.locator(".table-create-column-name").nth(2).fill("score")
     dialog.locator(".table-create-column-type").nth(2).select_option("integer")
@@ -337,6 +357,63 @@ def test_create_table_flow(page, datasette_server):
     assert data["column_types"] == {
         "metadata": {"type": "json", "config": None},
     }
+    schema_response = httpx.get(
+        f"{datasette_server}data/-/query.json",
+        params={
+            "sql": (
+                "select sql from sqlite_master where type = 'table' "
+                "and name = 'playwright_created'"
+            )
+        },
+    )
+    schema_response.raise_for_status()
+    schema = schema_response.json()["rows"][0]["sql"]
+    assert "title" in schema
+    assert "NOT NULL DEFAULT 'Untitled'" in schema
+
+
+@pytest.mark.playwright
+def test_create_table_foreign_key_selection_updates_column_type(page, datasette_server):
+    page.goto(f"{datasette_server}data")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-database-action="create-table"]').click()
+
+    dialog = page.locator("#table-create-dialog")
+    dialog.wait_for()
+    dialog.locator(".table-create-more-options").nth(1).click()
+
+    column_name = dialog.locator(".table-create-column-name").nth(1)
+    type_select = dialog.locator(".table-create-column-type").nth(1)
+    foreign_key_select = dialog.locator(".table-create-foreign-key-target").nth(1)
+    assert column_name.input_value() == ""
+    assert type_select.input_value() == "text"
+
+    foreign_key_select.select_option("projects\u001fid")
+    assert column_name.input_value() == "projects_id"
+    assert type_select.input_value() == "integer"
+    assert foreign_key_select.input_value() == "projects\u001fid"
+
+
+@pytest.mark.playwright
+def test_alter_table_foreign_key_selection_updates_blank_column(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    dialog.locator(".table-alter-add-column").click()
+
+    column_name = dialog.locator(".table-alter-column-name").last
+    type_select = dialog.locator(".table-alter-column-type").last
+    foreign_key_select = dialog.locator(".table-alter-foreign-key-target").last
+    assert column_name.input_value() == ""
+    assert type_select.input_value() == "text"
+
+    foreign_key_select.select_option("projects\u001fid")
+    assert column_name.input_value() == "projects_id"
+    assert type_select.input_value() == "integer"
+    assert foreign_key_select.input_value() == "projects\u001fid"
 
 
 @pytest.mark.playwright
@@ -349,6 +426,10 @@ def test_alter_table_flow(page, datasette_server):
     dialog.wait_for()
     assert dialog.locator(".modal-title").inner_text() == "Alter table projects"
     assert dialog.locator(".table-alter-save").is_disabled()
+    assert (
+        dialog.locator(".table-alter-column-name").first.get_attribute("placeholder")
+        == "column name"
+    )
     assert dialog.locator(".table-alter-column-main").first.evaluate("""node => {
             const inputHeight = node.querySelector(
                 ".table-alter-column-name"
@@ -377,15 +458,29 @@ def test_alter_table_flow(page, datasette_server):
     )
     assert "Not null" in expanded_options_text
     assert "This value cannot be left unset" in expanded_options_text
-    assert "Default value" in expanded_options_text
-    assert "or default to a specific time" in expanded_options_text
+    assert "Set a default value" in expanded_options_text
     assert "Primary key" in expanded_options_text
     assert "This ID uniquely identifies the record" in expanded_options_text
+    assert "Foreign key" in expanded_options_text
+    first_defaults = dialog.locator(".table-alter-default-options").first
+    first_defaults.locator("summary").click()
+    assert "or default to a specific value" in first_defaults.inner_text()
+    first_default_expr = first_defaults.locator(".table-alter-default-expr")
+    first_default_input = first_defaults.locator(".table-alter-default")
+    assert (
+        "Current timestamp in UTC, e.g. 2026-05-01 13:34:00"
+        in first_default_expr.locator("option").nth(1).inner_text()
+    )
+    first_default_expr.select_option("current_timestamp")
+    assert first_default_input.is_enabled()
+    first_default_input.fill("manual")
+    assert first_default_expr.input_value() == ""
 
     dialog.locator(".table-alter-add-column").click()
     assert dialog.locator(".table-alter-save").is_enabled()
     dialog.locator(".table-alter-column-name").last.fill("status")
     dialog.locator(".table-alter-column-type").last.select_option("text")
+    dialog.locator(".table-alter-default-options").last.locator("summary").click()
     dialog.locator(".table-alter-default").last.fill("planned")
     dialog.locator(".table-alter-save").click()
     review = dialog.locator(".table-alter-review")
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index ba9c03a5..9d1d1245 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -997,6 +997,11 @@ async def test_database_create_table_action_button_and_data():
                 "foreignKeyTargetsPath": "/data/-/foreign-key-targets",
                 "databaseName": "data",
                 "columnTypes": ["text", "integer", "float", "blob"],
+                "defaultExpressions": [
+                    "current_timestamp",
+                    "current_date",
+                    "current_time",
+                ],
             },
         }
         assert "customColumnTypes" not in database_data_from_soup(soup)["createTable"]

From 2ebae5ed71887cfd65af03aa88514170bdf4af17 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 12:51:23 -0700
Subject: [PATCH 264/386] Add rename table controls to alter table dialog

Add a collapsed rename-table section to the alter table modal and include rename_table operations in the review/apply flow.

Redirect to the renamed table URL after applying changes and cover the review text in Playwright.
---
 datasette/static/app.css       | 22 ++++++++++
 datasette/static/edit-tools.js | 75 +++++++++++++++++++++++++++++++---
 tests/test_playwright.py       | 30 ++++++++++++++
 3 files changed, 121 insertions(+), 6 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 32b7a4c2..f7cd97b0 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -2256,6 +2256,28 @@ dialog.table-alter-dialog::backdrop {
     overflow-y: auto;
 }
 
+.table-alter-table-options {
+    border-top: 1px solid var(--rule);
+    padding-top: 12px;
+}
+
+.table-alter-table-options > summary {
+    color: var(--ink);
+    cursor: pointer;
+    font-weight: 600;
+}
+
+.table-alter-table-options > summary:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 3px;
+}
+
+.table-alter-table-name-field {
+    display: grid;
+    gap: 4px;
+    margin-top: 10px;
+    max-width: 24rem;
+}
 
 .table-alter-fields[hidden],
 .table-alter-dialog .modal-footer [hidden] {
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 2e4331e6..fd8d9a0c 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -1822,6 +1822,7 @@ function tableAlterDialogSignature(state) {
     return "";
   }
   return JSON.stringify({
+    tableName: state.tableNameInput ? state.tableNameInput.value.trim() : "",
     columns: tableAlterDialogRows(state).map(tableAlterRowSignature),
     deletedColumns: state.deletedColumns.slice(),
   });
@@ -2307,6 +2308,9 @@ function addTableAlterColumn(state, column) {
 function resetTableAlterDialog(state, data) {
   state.nextColumnIndex = 0;
   state.deletedColumns = [];
+  state.originalTableName = data.tableName || "";
+  state.tableNameInput.value = state.originalTableName;
+  state.tableOptions.open = false;
   state.originalPrimaryKeys = (data.primaryKeys || []).slice();
   state.originalColumnNames = (data.columns || []).map(function (column) {
     return column.name;
@@ -2340,6 +2344,16 @@ function collectTableAlterRows(state) {
 }
 
 function validateTableAlterRows(state, rows) {
+  var tableName = state.tableNameInput.value.trim();
+  if (!tableName) {
+    return "Table name is required.";
+  }
+  if (tableName.indexOf("\n") !== -1) {
+    return "Table names cannot contain newlines.";
+  }
+  if (/^sqlite_/.test(tableName)) {
+    return "Table names cannot start with sqlite_.";
+  }
   if (!rows.length) {
     return "At least one column is required.";
   }
@@ -2513,6 +2527,13 @@ function collectTableAlterPayload(state) {
   }
 
   var operations = [];
+  var tableName = state.tableNameInput.value.trim();
+  if (tableName !== state.originalTableName) {
+    operations.push({
+      op: "rename_table",
+      args: { to: tableName },
+    });
+  }
   var columnTypeAssignments = collectTableAlterColumnTypeAssignments(rows);
   rows.forEach(function (row) {
     var name = row.name.trim();
@@ -2621,6 +2642,12 @@ function tableAlterReadableValue(value) {
 
 function tableAlterOperationSummary(operation) {
   var args = operation.args || {};
+  if (operation.op === "rename_table") {
+    return {
+      text: "Rename table to " + tableAlterQuotedName(args.to) + ".",
+      damaging: false,
+    };
+  }
   if (operation.op === "add_column") {
     var addDetails = ["as " + args.type];
     if (args.not_null) {
@@ -2788,7 +2815,10 @@ function appendTableAlterReviewText(element, text) {
   });
 }
 
-function tableAlterSetColumnTypeUrl() {
+function tableAlterSetColumnTypeUrl(tableUrl) {
+  if (tableUrl) {
+    return tableUrl.replace(/\/$/, "") + "/-/set-column-type";
+  }
   var data = tableAlterData();
   if (!data || !data.path) {
     return null;
@@ -2798,11 +2828,11 @@ function tableAlterSetColumnTypeUrl() {
   return url.toString();
 }
 
-async function assignTableAlterColumnTypes(assignments) {
+async function assignTableAlterColumnTypes(assignments, tableUrl) {
   if (!assignments.length) {
     return;
   }
-  var url = tableAlterSetColumnTypeUrl();
+  var url = tableAlterSetColumnTypeUrl(tableUrl);
   if (!url) {
     throw new Error("Could not find the set column type URL.");
   }
@@ -2841,6 +2871,16 @@ async function assignTableAlterColumnTypes(assignments) {
   }
 }
 
+function tableAlterResultRenamesTable(result) {
+  return !!(
+    result &&
+    result.payload &&
+    (result.payload.operations || []).some(function (operation) {
+      return operation.op === "rename_table";
+    })
+  );
+}
+
 function showTableAlterEditor(state) {
   state.mode = "edit";
   state.reviewResult = null;
@@ -2923,6 +2963,7 @@ async function applyTableAlterChanges(state, result) {
   }
   setTableAlterDialogSaving(state, true);
   try {
+    var responseData = null;
     if (result.payload) {
       var response = await fetch(data.path, {
         method: "POST",
@@ -2932,7 +2973,6 @@ async function applyTableAlterChanges(state, result) {
         },
         body: JSON.stringify(result.payload),
       });
-      var responseData = null;
       try {
         responseData = await response.json();
       } catch (_error) {
@@ -2942,10 +2982,18 @@ async function applyTableAlterChanges(state, result) {
         throw rowMutationRequestError(response, responseData);
       }
     }
-    await assignTableAlterColumnTypes(result.columnTypeAssignments || []);
+    var tableUrl = responseData && responseData.table_url;
+    await assignTableAlterColumnTypes(
+      result.columnTypeAssignments || [],
+      tableUrl,
+    );
     state.shouldRestoreFocus = false;
     state.dialog.close();
-    location.reload();
+    if (tableAlterResultRenamesTable(result) && tableUrl) {
+      window.location.href = tableUrl;
+    } else {
+      location.reload();
+    }
   } catch (error) {
     setTableAlterDialogSaving(state, false);
     showTableAlterDialogError(state, error.message || "Could not alter table");
@@ -3088,6 +3136,13 @@ function ensureTableAlterDialog(manager) {
           <div class="table-alter-column-list"></div>
           <button type="button" class="table-alter-add-column"><svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M5 12h14"></path><path d="M12 5v14"></path></svg><span>Add column</span></button>
         </div>
+        <details class="table-alter-table-options">
+          <summary>Rename table</summary>
+          <div class="table-alter-table-name-field">
+            <label class="table-alter-detail-label" for="table-alter-table-name">New table name</label>
+            <input id="table-alter-table-name" class="table-alter-input table-alter-table-name" type="text" autocomplete="off" placeholder="table name" required>
+          </div>
+        </details>
       </div>
       <div class="table-alter-review" hidden></div>
       <div class="modal-footer">
@@ -3106,6 +3161,8 @@ function ensureTableAlterDialog(manager) {
     title: dialog.querySelector(".modal-title"),
     error: dialog.querySelector(".table-alter-error"),
     fields: dialog.querySelector(".table-alter-fields"),
+    tableOptions: dialog.querySelector(".table-alter-table-options"),
+    tableNameInput: dialog.querySelector(".table-alter-table-name"),
     review: dialog.querySelector(".table-alter-review"),
     columnList: dialog.querySelector(".table-alter-column-list"),
     addColumnButton: dialog.querySelector(".table-alter-add-column"),
@@ -3117,6 +3174,7 @@ function ensureTableAlterDialog(manager) {
     shouldRestoreFocus: true,
     isSaving: false,
     initialSignature: "",
+    originalTableName: "",
     nextColumnIndex: 0,
     deletedColumns: [],
     originalColumnNames: [],
@@ -3134,6 +3192,11 @@ function ensureTableAlterDialog(manager) {
     saveTableAlterDialog(tableAlterDialogState);
   });
 
+  tableAlterDialogState.tableNameInput.addEventListener("input", function () {
+    clearTableAlterDialogError(tableAlterDialogState);
+    updateTableAlterSaveButtonState(tableAlterDialogState);
+  });
+
   tableAlterDialogState.addColumnButton.addEventListener("click", function () {
     if (tableAlterDialogState.isSaving) {
       return;
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 5719039a..fcf97a90 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -561,6 +561,36 @@ def test_alter_table_review_rename_primary_key_column(page, datasette_server):
     ]
 
 
+@pytest.mark.playwright
+def test_alter_table_review_rename_table(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    save = dialog.locator(".table-alter-save")
+    rename_details = dialog.locator(".table-alter-table-options")
+    assert rename_details.locator("summary").inner_text() == "Rename table"
+    assert not dialog.locator(".table-alter-table-name").is_visible()
+    assert save.is_disabled()
+
+    rename_details.locator("summary").click()
+    table_name = dialog.locator(".table-alter-table-name")
+    assert table_name.input_value() == "projects"
+    assert table_name.get_attribute("placeholder") == "table name"
+    table_name.fill("projects_archive")
+    assert save.is_enabled()
+    save.click()
+
+    review = dialog.locator(".table-alter-review")
+    review.wait_for()
+    assert "Rename table to projects_archive." in review.inner_text()
+    assert dialog.locator(".table-alter-review-name").all_inner_texts() == [
+        "projects_archive",
+    ]
+
+
 @pytest.mark.playwright
 def test_alter_table_review_not_null_wording(page, datasette_server):
     page.goto(f"{datasette_server}data/projects")

From 1717ab02f720286aea8e4634a1047e6a6f2a1d45 Mon Sep 17 00:00:00 2001
From: Copilot <198982749+Copilot@users.noreply.github.com>
Date: Mon, 22 Jun 2026 13:22:56 -0700
Subject: [PATCH 265/386] Replace row edit icon SVG in table.py

Closes #2796
---
 datasette/views/table.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index c5448c85..0e291524 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -455,8 +455,8 @@ async def display_columns_and_rows(
                 'xmlns="http://www.w3.org/2000/svg" width="14" height="14" '
                 'viewBox="0 0 24 24" fill="none" stroke="currentColor" '
                 'stroke-width="2" stroke-linecap="round" stroke-linejoin="round">'
-                '<path d="M12 20h9"></path>'
-                '<path d="M16.5 3.5a2.1 2.1 0 0 1 3 3L7 19l-4 1 1-4Z"></path>'
+                '<path d="M11 4H4a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h14a2 2 0 0 0 2-2v-7"></path>'
+                '<path d="M18.5 2.5a2.12 2.12 0 0 1 3 3L12 15l-4 1 1-4 9.5-9.5z"></path>'
                 "</svg>"
             )
             delete_icon = (

From b932d0dc78a3ddc466409a6d21a31124a20d8c17 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 13:42:35 -0700
Subject: [PATCH 266/386] current_unixtime and current_unixtime_ms default_expr
 options

Plus tweaked how alter table changing those works a bit.
---
 datasette/static/edit-tools.js        | 119 +++++++++++++++++++++++---
 datasette/views/table.py              |  41 +++++----
 datasette/views/table_create_alter.py | 116 +++++++++++++++++++++++--
 docs/json_api.rst                     |  32 ++++++-
 tests/test_api_write.py               | 119 +++++++++++++++++++++++++-
 tests/test_playwright.py              |  81 ++++++++++++++++++
 tests/test_table_html.py              |  69 ++++++++++++---
 7 files changed, 522 insertions(+), 55 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index fd8d9a0c..9f4f89b9 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -109,14 +109,64 @@ function createCustomColumnTypeSelect(options, className, placeholderClass) {
   return select;
 }
 
-var DEFAULT_EXPRESSION_LABELS = {
-  current_timestamp: "Current timestamp in UTC, e.g. 2026-05-01 13:34:00",
-  current_date: "Current date in UTC, e.g. 2026-05-01",
-  current_time: "Current time in UTC, e.g. 13:34:00",
-};
+function normalizeDefaultExpressionOption(option) {
+  if (typeof option === "string") {
+    return {
+      value: option,
+      label: option.replace(/_/g, " "),
+      sqliteType: "",
+    };
+  }
+  option = option || {};
+  return {
+    value: option.value || "",
+    label: option.label || option.value || "",
+    sqliteType: option.sqliteType || "",
+  };
+}
 
-function defaultExpressionLabel(value) {
-  return DEFAULT_EXPRESSION_LABELS[value] || value.replace(/_/g, " ");
+function defaultExpressionOptionForValue(options, value) {
+  var match = null;
+  (options || []).some(function (option) {
+    var normalized = normalizeDefaultExpressionOption(option);
+    if (normalized.value === value) {
+      match = normalized;
+      return true;
+    }
+    return false;
+  });
+  return match;
+}
+
+function defaultExpressionLabelForValue(options, value) {
+  var option = defaultExpressionOptionForValue(options, value);
+  return option && option.label
+    ? option.label
+    : value
+      ? value.replace(/_/g, " ")
+      : "";
+}
+
+function applyDefaultExpressionColumnType(row, prefix, options, columnTypes) {
+  var defaultExprSelect = row.querySelector("." + prefix + "-default-expr");
+  var typeSelect = row.querySelector("." + prefix + "-column-type");
+  if (!defaultExprSelect || !typeSelect || !defaultExprSelect.value) {
+    return false;
+  }
+  var option = defaultExpressionOptionForValue(
+    options,
+    defaultExprSelect.value,
+  );
+  if (
+    option &&
+    option.sqliteType &&
+    (columnTypes || []).indexOf(option.sqliteType) !== -1 &&
+    typeSelect.value !== option.sqliteType
+  ) {
+    typeSelect.value = option.sqliteType;
+    return true;
+  }
+  return false;
 }
 
 function createDefaultExpressionSelect(
@@ -132,9 +182,13 @@ function createDefaultExpressionSelect(
   blankOption.textContent = "- default expr -";
   select.appendChild(blankOption);
   options.forEach(function (option) {
+    var normalized = normalizeDefaultExpressionOption(option);
+    if (!normalized.value) {
+      return;
+    }
     var optionElement = document.createElement("option");
-    optionElement.value = option;
-    optionElement.textContent = defaultExpressionLabel(option);
+    optionElement.value = normalized.value;
+    optionElement.textContent = normalized.label;
     select.appendChild(optionElement);
   });
   select.value = value || "";
@@ -1078,6 +1132,18 @@ function createTableColumnRow(state, column) {
     if (defaultControls.defaultExprSelect.value) {
       defaultControls.defaultInput.value = "";
     }
+    if (
+      applyDefaultExpressionColumnType(
+        row,
+        "table-create",
+        tableCreateDefaultExpressions(),
+        tableCreateColumnTypes(),
+      )
+    ) {
+      syncTableCreateCustomTypeForSqliteType(row);
+      syncTableCreateForeignKeyOptions(row, state);
+      syncTableCreateCustomTypeAndForeignKey(row, state);
+    }
     syncSchemaDialogDefaultControls(row, "table-create");
     clearTableCreateDialogError(state);
   });
@@ -1948,8 +2014,15 @@ function createTableAlterColumnRow(state, column) {
   var originalName = existing ? column.name || "" : "";
   var originalCustomType =
     existing && column.column_type ? column.column_type.type || "" : "";
+  var originalDefaultExpr =
+    existing && column.has_default && column.default_expr
+      ? column.default_expr
+      : "";
   var originalDefault =
-    existing && column.has_default && column.default !== null
+    existing &&
+    column.has_default &&
+    !originalDefaultExpr &&
+    column.default !== null
       ? String(column.default)
       : "";
   var originalForeignKey =
@@ -1965,6 +2038,7 @@ function createTableAlterColumnRow(state, column) {
   row.dataset.originalNotNull = existing && column.notnull ? "1" : "0";
   row.dataset.originalHasDefault = existing && column.has_default ? "1" : "0";
   row.dataset.originalDefault = originalDefault;
+  row.dataset.originalDefaultExpr = originalDefaultExpr;
   row.dataset.originalPk = existing && column.is_pk ? "1" : "0";
   row.dataset.originalCustomType = originalCustomType;
   row.dataset.originalForeignKey = originalForeignKey;
@@ -2051,7 +2125,7 @@ function createTableAlterColumnRow(state, column) {
     tableAlterDefaultExpressions(),
     {
       defaultValue: originalDefault,
-      defaultExpr: "",
+      defaultExpr: originalDefaultExpr,
     },
   );
   var defaultInput = defaultControls.defaultInput;
@@ -2167,6 +2241,18 @@ function createTableAlterColumnRow(state, column) {
     if (defaultExprSelect.value) {
       defaultInput.value = "";
     }
+    if (
+      applyDefaultExpressionColumnType(
+        row,
+        "table-alter",
+        tableAlterDefaultExpressions(),
+        tableAlterColumnTypes(),
+      )
+    ) {
+      syncTableAlterCustomTypeForSqliteType(row);
+      syncTableAlterForeignKeyOptions(row, state);
+      syncSchemaDialogCustomTypeAndForeignKey(row, state, "table-alter");
+    }
     syncSchemaDialogDefaultControls(row, "table-alter");
     updateTableAlterSaveButtonState(state);
   });
@@ -2336,6 +2422,7 @@ function collectTableAlterRows(state) {
     signature.originalNotNull = row.dataset.originalNotNull === "1";
     signature.originalHasDefault = row.dataset.originalHasDefault === "1";
     signature.originalDefault = row.dataset.originalDefault || "";
+    signature.originalDefaultExpr = row.dataset.originalDefaultExpr || "";
     signature.originalPk = row.dataset.originalPk === "1";
     signature.originalCustomType = row.dataset.originalCustomType || "";
     signature.originalForeignKey = row.dataset.originalForeignKey || "";
@@ -2567,8 +2654,12 @@ function collectTableAlterPayload(state) {
     if (row.notNull !== row.originalNotNull) {
       alterArgs.not_null = row.notNull;
     }
-    if (row.defaultExpr) {
-      alterArgs.default_expr = row.defaultExpr;
+    if (row.defaultExpr !== row.originalDefaultExpr) {
+      if (row.defaultExpr) {
+        alterArgs.default_expr = row.defaultExpr;
+      } else {
+        alterArgs.default = row.defaultValue === "" ? null : row.defaultValue;
+      }
     } else if (row.originalHasDefault) {
       if (row.defaultValue !== row.originalDefault) {
         alterArgs.default = row.defaultValue === "" ? null : row.defaultValue;
@@ -2630,7 +2721,7 @@ function tableAlterQuotedName(name) {
 }
 
 function tableAlterReadableDefaultExpression(value) {
-  return value ? value.replace(/_/g, " ") : "";
+  return defaultExpressionLabelForValue(tableAlterDefaultExpressions(), value);
 }
 
 function tableAlterReadableValue(value) {
diff --git a/datasette/views/table.py b/datasette/views/table.py
index dbca3a18..80e1c514 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -51,8 +51,9 @@ from .database import QueryView
 from .table_create_alter import (
     ALTER_TABLE_COLUMN_TYPES,
     ALTER_TABLE_TYPE_FOR_SQLITE_TYPE,
-    DEFAULT_EXPR_SQL,
     _custom_column_type_options_for_create_table,
+    default_expr_for_sql,
+    default_expression_options,
 )
 from .table_extras import (
     TABLE_EXTRA_BUNDLES,
@@ -401,23 +402,25 @@ async def _table_alter_ui(
             continue
         sqlite_type = SQLiteType.from_declared_type(column.type)
         column_type = column_types_map.get(column.name)
-        columns.append(
-            {
-                "name": column.name,
-                "type": ALTER_TABLE_TYPE_FOR_SQLITE_TYPE.get(sqlite_type, "text"),
-                "sqlite_type": sqlite_type.value,
-                "notnull": column.notnull,
-                "default": column.default_value,
-                "has_default": column.default_value is not None,
-                "is_pk": column.name in pks,
-                "foreign_key": foreign_keys_by_column.get(column.name),
-                "column_type": (
-                    {"type": column_type.name, "config": column_type.config}
-                    if column_type is not None
-                    else None
-                ),
-            }
-        )
+        default_expr = default_expr_for_sql(column.default_value)
+        column_data = {
+            "name": column.name,
+            "type": ALTER_TABLE_TYPE_FOR_SQLITE_TYPE.get(sqlite_type, "text"),
+            "sqlite_type": sqlite_type.value,
+            "notnull": column.notnull,
+            "default": None if default_expr else column.default_value,
+            "has_default": column.default_value is not None,
+            "is_pk": column.name in pks,
+            "foreign_key": foreign_keys_by_column.get(column.name),
+            "column_type": (
+                {"type": column_type.name, "config": column_type.config}
+                if column_type is not None
+                else None
+            ),
+        }
+        if default_expr:
+            column_data["default_expr"] = default_expr
+        columns.append(column_data)
 
     data = {
         "path": "{}/-/alter".format(datasette.urls.table(database_name, table_name)),
@@ -425,7 +428,7 @@ async def _table_alter_ui(
         "columns": columns,
         "primaryKeys": pks,
         "columnTypes": ALTER_TABLE_COLUMN_TYPES,
-        "defaultExpressions": list(DEFAULT_EXPR_SQL),
+        "defaultExpressions": default_expression_options(),
         "foreignKeyTargetsPath": "{}/-/foreign-key-targets?table={}".format(
             datasette.urls.database(database_name),
             urllib.parse.quote(table_name, safe=""),
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index 111dfab1..ffeb7f14 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -266,7 +266,7 @@ async def _create_table_ui_context(
         ),
         "databaseName": database_name,
         "columnTypes": CREATE_TABLE_COLUMN_TYPES,
-        "defaultExpressions": list(DEFAULT_EXPR_SQL),
+        "defaultExpressions": default_expression_options(),
     }
     can_set_column_type = await datasette.allowed(
         action="set-column-type",
@@ -308,12 +308,109 @@ def _custom_column_type_options_for_create_table(datasette):
 
 
 SqliteApiType = Literal["text", "integer", "float", "blob"]
-DefaultExpr = Literal["current_timestamp", "current_date", "current_time"]
-DEFAULT_EXPR_SQL = {
-    "current_timestamp": "CURRENT_TIMESTAMP",
-    "current_date": "CURRENT_DATE",
-    "current_time": "CURRENT_TIME",
+DEFAULT_EXPRESSIONS = {
+    "current_timestamp": {
+        "sql": "CURRENT_TIMESTAMP",
+        "label": "Current timestamp in UTC, e.g. 2026-05-01 13:34:00",
+        "sqliteType": "text",
+    },
+    "current_date": {
+        "sql": "CURRENT_DATE",
+        "label": "Current date in UTC, e.g. 2026-05-01",
+        "sqliteType": "text",
+    },
+    "current_time": {
+        "sql": "CURRENT_TIME",
+        "label": "Current time in UTC, e.g. 13:34:00",
+        "sqliteType": "text",
+    },
+    "current_unixtime": {
+        "sql": "(CAST(strftime('%s', 'now') AS INTEGER))",
+        "label": "Current Unix time, integer seconds since the epoch",
+        "sqliteType": "integer",
+    },
+    "current_unixtime_ms": {
+        "sql": "(CAST((julianday('now') - 2440587.5) * 86400000 AS INTEGER))",
+        "label": "Current Unix time, integer milliseconds since the epoch",
+        "sqliteType": "integer",
+    },
 }
+DefaultExpr = str
+DEFAULT_EXPR_SQL = {
+    name: metadata["sql"] for name, metadata in DEFAULT_EXPRESSIONS.items()
+}
+
+
+def _strip_wrapping_parentheses(expression):
+    expression = expression.strip()
+    while expression.startswith("(") and expression.endswith(")"):
+        depth = 0
+        in_single_quote = False
+        wraps_whole_expression = True
+        i = 0
+        while i < len(expression):
+            char = expression[i]
+            if char == "'":
+                if (
+                    in_single_quote
+                    and i + 1 < len(expression)
+                    and expression[i + 1] == "'"
+                ):
+                    i += 2
+                    continue
+                in_single_quote = not in_single_quote
+            elif not in_single_quote:
+                if char == "(":
+                    depth += 1
+                elif char == ")":
+                    depth -= 1
+                    if depth == 0 and i != len(expression) - 1:
+                        wraps_whole_expression = False
+                        break
+            i += 1
+        if not wraps_whole_expression or depth != 0 or in_single_quote:
+            break
+        expression = expression[1:-1].strip()
+    return expression
+
+
+def _default_expression_lookup_key(expression):
+    return re.sub(r"\s+", " ", _strip_wrapping_parentheses(expression)).lower()
+
+
+DEFAULT_EXPR_BY_SQL = {
+    _default_expression_lookup_key(sql): name for name, sql in DEFAULT_EXPR_SQL.items()
+}
+
+
+def default_expr_for_sql(expression):
+    if expression is None:
+        return None
+    return DEFAULT_EXPR_BY_SQL.get(_default_expression_lookup_key(expression))
+
+
+def _quoted_options(options):
+    if len(options) == 1:
+        return "'{}'".format(options[0])
+    return "{} or '{}'".format(
+        ", ".join("'{}'".format(option) for option in options[:-1]),
+        options[-1],
+    )
+
+
+def _default_expr_error_message():
+    return "Input should be {}".format(_quoted_options(list(DEFAULT_EXPRESSIONS)))
+
+
+def default_expression_options():
+    return [
+        {
+            "value": value,
+            "label": metadata["label"],
+            "sqliteType": metadata["sqliteType"],
+        }
+        for value, metadata in DEFAULT_EXPRESSIONS.items()
+    ]
 
 
 class _StrictPydanticModel(BaseModel):
@@ -324,6 +421,13 @@ class _DefaultArgsMixin(_StrictPydanticModel):
     default: Any | None = None
     default_expr: DefaultExpr | None = None
 
+    @field_validator("default_expr")
+    @classmethod
+    def validate_default_expr_value(cls, value):
+        if value is not None and value not in DEFAULT_EXPRESSIONS:
+            raise PydanticCustomError("default_expr", _default_expr_error_message())
+        return value
+
     @model_validator(mode="after")
     def validate_default_fields(self):
         has_default = "default" in self.model_fields_set
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 849a8acf..b8632bc3 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -44,7 +44,7 @@ looks like this:
 
 ``"ok"`` is always ``true`` if an error did not occur.
 
-The ``"rows"`` key is a list of objects, each one representing a row. 
+The ``"rows"`` key is a list of objects, each one representing a row.
 
 The ``"truncated"`` key lets you know if the query was truncated. This can happen if a SQL query returns more than 1,000 results (or the :ref:`setting_max_returned_rows` setting).
 
@@ -1990,7 +1990,7 @@ The JSON here describes the table that will be created:
   - ``type`` is the type of the column. This is optional - if not provided, ``text`` will be assumed. The valid types are ``text``, ``integer``, ``float`` and ``blob``.
   - ``not_null`` can be set to ``true`` to create this column with a ``NOT NULL`` constraint.
   - ``default`` can be used to set a literal default value for this column.
-  - ``default_expr`` can be used instead of ``default`` to set a SQLite default expression. The supported values are ``current_timestamp``, ``current_date`` and ``current_time``.
+  - ``default_expr`` can be used instead of ``default`` to set a SQLite default expression. See :ref:`default_expr values <json_api_default_expr_values>`.
   - ``fk_table`` can be used to create a single-column foreign key constraint referencing another table. ``fk_column`` is optional and can be used to specify the referenced column - if omitted, Datasette will use the single primary key of ``fk_table``.
 
 * ``pk`` is the primary key for the table. This is optional - if not provided, Datasette will create a SQLite table with a hidden ``rowid`` column.
@@ -2004,6 +2004,32 @@ The JSON here describes the table that will be created:
 * ``replace`` can be set to ``true`` to replace existing rows by primary key if the table already exists. This requires the :ref:`actions_update_row` permission.
 * ``alter`` can be set to ``true`` if you want to automatically add any missing columns to the table. This requires the :ref:`actions_alter_table` permission.
 
+.. _json_api_default_expr_values:
+
+``default_expr`` accepts these values:
+
+.. list-table::
+   :header-rows: 1
+
+   * - Value
+     - Recommended column type
+     - Example inserted value
+   * - ``current_timestamp``
+     - ``text``
+     - ``2026-05-01 13:34:00``
+   * - ``current_date``
+     - ``text``
+     - ``2026-05-01``
+   * - ``current_time``
+     - ``text``
+     - ``13:34:00``
+   * - ``current_unixtime``
+     - ``integer``
+     - ``1777642440``
+   * - ``current_unixtime_ms``
+     - ``integer``
+     - ``1777642440000``
+
 This example creates a foreign key from ``projects.owner_id`` to the single primary key of ``owners``:
 
 .. code-block:: json
@@ -2314,7 +2340,7 @@ Supported operations:
 * ``set_foreign_keys`` replaces all foreign key constraints on the table. ``args`` accepts ``foreign_keys``, a list of objects that each have ``column``, ``fk_table`` and optional ``fk_column``. An empty list removes all foreign key constraints.
 * ``reorder_columns`` reorders columns. ``args`` accepts ``columns``, a list of one or more column names. Columns omitted from this list will appear afterwards in their existing order.
 
-``default`` is always treated as a literal value. ``default_expr`` accepts one of ``current_timestamp``, ``current_date`` or ``current_time`` and is rendered as the corresponding SQLite default expression.
+``default`` is always treated as a literal value. ``default_expr`` accepts the values shown in :ref:`default_expr values <json_api_default_expr_values>` and is rendered as the corresponding SQLite default expression.
 
 For foreign key operations that omit ``fk_column``, the referenced ``fk_table`` must have a single-column primary key. Datasette will return an error if it cannot identify a single primary key column for that table.
 
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 6e8c4d4b..b3a2f6a3 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -899,6 +899,64 @@ async def test_alter_table_operations(ds_write):
     assert event.after_schema == data["schema"]
 
 
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "default_expr,minimum_value,expected_schema",
+    (
+        (
+            "current_unixtime",
+            1_600_000_000,
+            "strftime('%s', 'now')",
+        ),
+        (
+            "current_unixtime_ms",
+            1_600_000_000_000,
+            "julianday('now')",
+        ),
+    ),
+)
+async def test_alter_table_integer_default_expr(
+    ds_write, default_expr, minimum_value, expected_schema
+):
+    token = write_token(ds_write, permissions=["at"])
+    db = ds_write.get_database("data")
+    response = await ds_write.client.post(
+        "/data/docs/-/alter",
+        json={
+            "operations": [
+                {
+                    "op": "add_column",
+                    "args": {
+                        "name": "created",
+                        "type": "integer",
+                        "default_expr": default_expr,
+                    },
+                }
+            ]
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 200, response.text
+    data = response.json()
+    assert expected_schema in data["schema"]
+
+    columns = await db.execute("select * from pragma_table_info('docs')")
+    created_column = [
+        column for column in columns.dicts() if column["name"] == "created"
+    ][0]
+    assert created_column["type"] == "INTEGER"
+    assert expected_schema in created_column["dflt_value"]
+
+    row = await db.execute_write_fn(
+        lambda conn: conn.execute(
+            "insert into docs (title) values ('with default') "
+            "returning created, typeof(created)"
+        ).fetchone()
+    )
+    assert row[0] > minimum_value
+    assert row[1] == "integer"
+
+
 @pytest.mark.asyncio
 async def test_alter_table_rename_table(ds_write):
     token = write_token(ds_write, permissions=["at"])
@@ -1315,7 +1373,7 @@ async def test_alter_table_permission_denied(ds_write):
                     }
                 ]
             },
-            "operations.0.add_column.args.default_expr: Input should be 'current_timestamp', 'current_date' or 'current_time'",
+            "operations.0.add_column.args.default_expr: Input should be 'current_timestamp', 'current_date', 'current_time', 'current_unixtime' or 'current_unixtime_ms'",
         ),
         (
             {
@@ -2053,6 +2111,63 @@ async def test_create_table_with_column_constraints(ds_write):
     assert columns[4]["dflt_value"] == "'hello)'"
 
 
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "default_expr,minimum_value,expected_schema",
+    (
+        (
+            "current_unixtime",
+            1_600_000_000,
+            "strftime('%s', 'now')",
+        ),
+        (
+            "current_unixtime_ms",
+            1_600_000_000_000,
+            "julianday('now')",
+        ),
+    ),
+)
+async def test_create_table_integer_default_expr(
+    ds_write, default_expr, minimum_value, expected_schema
+):
+    token = write_token(ds_write)
+    table = "default_{}".format(default_expr)
+    response = await ds_write.client.post(
+        "/data/-/create",
+        json={
+            "table": table,
+            "columns": [
+                {"name": "id", "type": "integer"},
+                {
+                    "name": "created",
+                    "type": "integer",
+                    "default_expr": default_expr,
+                },
+            ],
+            "pk": "id",
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 201, response.text
+    data = response.json()
+    assert expected_schema in data["schema"]
+
+    db = ds_write.get_database("data")
+    columns = (await db.execute("select * from pragma_table_info(?)", [table])).dicts()
+    assert columns[1]["type"] == "INTEGER"
+    assert expected_schema in columns[1]["dflt_value"]
+
+    row = await db.execute_write_fn(
+        lambda conn: conn.execute(
+            "insert into [{}] default values returning created, typeof(created)".format(
+                table
+            )
+        ).fetchone()
+    )
+    assert row[0] > minimum_value
+    assert row[1] == "integer"
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "column,expected_error",
@@ -2071,7 +2186,7 @@ async def test_create_table_with_column_constraints(ds_write):
                 "type": "text",
                 "default_expr": "datetime('now')",
             },
-            "columns.0.default_expr: Input should be 'current_timestamp', 'current_date' or 'current_time'",
+            "columns.0.default_expr: Input should be 'current_timestamp', 'current_date', 'current_time', 'current_unixtime' or 'current_unixtime_ms'",
         ),
         (
             {
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index fcf97a90..ee396de5 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -98,6 +98,10 @@ def write_playwright_database(db_path):
             notes text,
             score integer default 5
         );
+        create table defaults_demo (
+            id integer primary key,
+            created_ms integer default (CAST((julianday('now') - 2440587.5) * 86400000 AS INTEGER))
+        );
         insert into projects (title, metadata, logo, notes, score) values
             (
                 'Build Datasette',
@@ -136,6 +140,11 @@ def write_playwright_config(config_path):
                                     "delete-row": True,
                                 },
                             },
+                            "defaults_demo": {
+                                "permissions": {
+                                    "alter-table": True,
+                                },
+                            },
                         },
                     },
                 },
@@ -394,6 +403,32 @@ def test_create_table_foreign_key_selection_updates_column_type(page, datasette_
     assert foreign_key_select.input_value() == "projects\u001fid"
 
 
+@pytest.mark.playwright
+def test_create_table_unix_default_expression_updates_column_type(
+    page, datasette_server
+):
+    page.goto(f"{datasette_server}data")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-database-action="create-table"]').click()
+
+    dialog = page.locator("#table-create-dialog")
+    dialog.wait_for()
+    row = dialog.locator(".table-create-column-row").nth(1)
+    row.locator(".table-create-more-options").click()
+    row.locator(".table-create-default-options summary").click()
+
+    type_select = row.locator(".table-create-column-type")
+    default_expr = row.locator(".table-create-default-expr")
+    assert type_select.input_value() == "text"
+    assert (
+        "Current Unix time, integer milliseconds since the epoch"
+        in default_expr.locator("option").last.inner_text()
+    )
+
+    default_expr.select_option("current_unixtime_ms")
+    assert type_select.input_value() == "integer"
+
+
 @pytest.mark.playwright
 def test_alter_table_foreign_key_selection_updates_blank_column(page, datasette_server):
     page.goto(f"{datasette_server}data/projects")
@@ -416,6 +451,52 @@ def test_alter_table_foreign_key_selection_updates_blank_column(page, datasette_
     assert foreign_key_select.input_value() == "projects\u001fid"
 
 
+@pytest.mark.playwright
+def test_alter_table_unix_default_expression_updates_column_type(
+    page, datasette_server
+):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    dialog.locator(".table-alter-add-column").click()
+    row = dialog.locator(".table-alter-column-row").last
+    row.locator(".table-alter-default-options summary").click()
+
+    type_select = row.locator(".table-alter-column-type")
+    default_expr = row.locator(".table-alter-default-expr")
+    assert type_select.input_value() == "text"
+    assert (
+        "Current Unix time, integer seconds since the epoch"
+        in default_expr.locator("option").all_inner_texts()
+    )
+
+    default_expr.select_option("current_unixtime")
+    assert type_select.input_value() == "integer"
+
+
+@pytest.mark.playwright
+def test_alter_table_existing_default_expression_populates_select(
+    page, datasette_server
+):
+    page.goto(f"{datasette_server}data/defaults_demo")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-table-action="alter-table"]').click()
+
+    dialog = page.locator("#table-alter-dialog")
+    dialog.wait_for()
+    row = dialog.locator(".table-alter-column-row").nth(1)
+    row.locator(".table-alter-more-options").click()
+    row.locator(".table-alter-default-options summary").click()
+
+    assert row.locator(".table-alter-default-expr").input_value() == (
+        "current_unixtime_ms"
+    )
+    assert row.locator(".table-alter-default").input_value() == ""
+
+
 @pytest.mark.playwright
 def test_alter_table_flow(page, datasette_server):
     page.goto(f"{datasette_server}data/projects")
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 9d1d1245..3af2bb08 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -40,6 +40,35 @@ def database_data_from_soup(soup):
     return json.loads(match.group(1))
 
 
+DEFAULT_EXPRESSION_OPTIONS = [
+    {
+        "value": "current_timestamp",
+        "label": "Current timestamp in UTC, e.g. 2026-05-01 13:34:00",
+        "sqliteType": "text",
+    },
+    {
+        "value": "current_date",
+        "label": "Current date in UTC, e.g. 2026-05-01",
+        "sqliteType": "text",
+    },
+    {
+        "value": "current_time",
+        "label": "Current time in UTC, e.g. 13:34:00",
+        "sqliteType": "text",
+    },
+    {
+        "value": "current_unixtime",
+        "label": "Current Unix time, integer seconds since the epoch",
+        "sqliteType": "integer",
+    },
+    {
+        "value": "current_unixtime_ms",
+        "label": "Current Unix time, integer milliseconds since the epoch",
+        "sqliteType": "integer",
+    },
+]
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "path,expected_definition_sql",
@@ -997,11 +1026,7 @@ async def test_database_create_table_action_button_and_data():
                 "foreignKeyTargetsPath": "/data/-/foreign-key-targets",
                 "databaseName": "data",
                 "columnTypes": ["text", "integer", "float", "blob"],
-                "defaultExpressions": [
-                    "current_timestamp",
-                    "current_date",
-                    "current_time",
-                ],
+                "defaultExpressions": DEFAULT_EXPRESSION_OPTIONS,
             },
         }
         assert "customColumnTypes" not in database_data_from_soup(soup)["createTable"]
@@ -1113,7 +1138,9 @@ async def test_table_alter_action_button_and_data():
             create table items (
                 id integer primary key,
                 name text not null,
-                score integer default 5
+                score integer default 5,
+                created text default current_timestamp,
+                created_ms integer default (CAST((julianday('now') - 2440587.5) * 86400000 AS INTEGER))
             );
             """)
         response = await ds.client.get("/data/items", actor={"id": "root"})
@@ -1145,11 +1172,7 @@ async def test_table_alter_action_button_and_data():
         assert alter_data["foreignKeyTargetsPath"] == (
             "/data/-/foreign-key-targets?table=items"
         )
-        assert alter_data["defaultExpressions"] == [
-            "current_timestamp",
-            "current_date",
-            "current_time",
-        ]
+        assert alter_data["defaultExpressions"] == DEFAULT_EXPRESSION_OPTIONS
         assert [option["name"] for option in alter_data["customColumnTypes"]] == [
             "email",
             "json",
@@ -1191,6 +1214,30 @@ async def test_table_alter_action_button_and_data():
                 "foreign_key": None,
                 "column_type": None,
             },
+            {
+                "name": "created",
+                "type": "text",
+                "sqlite_type": "TEXT",
+                "notnull": 0,
+                "default": None,
+                "default_expr": "current_timestamp",
+                "has_default": True,
+                "is_pk": False,
+                "foreign_key": None,
+                "column_type": None,
+            },
+            {
+                "name": "created_ms",
+                "type": "integer",
+                "sqlite_type": "INTEGER",
+                "notnull": 0,
+                "default": None,
+                "default_expr": "current_unixtime_ms",
+                "has_default": True,
+                "is_pk": False,
+                "foreign_key": None,
+                "column_type": None,
+            },
         ]
 
         response_without_permission = await ds.client.get(

From b3b5c25df8c51fb0da39a1c8f19198cd5c0b4afb Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 13:51:32 -0700
Subject: [PATCH 267/386] Draft changelog for create/alter table UI, refs
 #2787, #2788

---
 docs/changelog.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 1516604e..697df87d 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,6 +4,16 @@
 Changelog
 =========
 
+.. _unreleased:
+
+Unreleased
+----------
+
+- New "Create table" interface in the database actions menu, backed by the ``/<database>/-/create`` :ref:`JSON API <TableCreateView>`. It can define columns, primary keys, custom column types, ``NOT NULL`` constraints, literal defaults, expression defaults and single-column foreign keys. (:issue:`2787`)
+- New "Alter table" table action and ``/<database>/<table>/-/alter`` :ref:`JSON API <TableAlterView>` for changing existing tables: add, rename, reorder and drop columns; change column types, defaults, ``NOT NULL`` constraints, primary keys and foreign keys; and rename the table. The alter table dialog also includes a "Drop table" button. (:issue:`2788`)
+- New ``/<database>/-/foreign-key-targets`` and ``/<database>/<table>/-/foreign-key-suggestions`` JSON APIs for discovering valid single-column foreign key targets and suggested relationships.
+- Create and alter table dialogs share their column-editing controls, including literal and expression defaults, custom column types, foreign keys and column ordering.
+
 .. _v1_0_a34:
 
 1.0a34 (2026-06-16)

From f8313525517b774879482c597172da076b4ba59b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 14:24:34 -0700
Subject: [PATCH 268/386] Avoid SQLite RETURNING for compat with older SQLite

Refs #2789
---
 tests/test_api_write.py | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index b3a2f6a3..76797742 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1,6 +1,6 @@
 from datasette.app import Datasette
 from datasette.events import RenameTableEvent
-from datasette.utils import sqlite3
+from datasette.utils import escape_sqlite, sqlite3
 from .utils import last_event
 import pytest
 import time
@@ -40,6 +40,16 @@ def _headers(token):
     }
 
 
+def _insert_and_fetch_created(conn, table, insert_sql):
+    cursor = conn.execute(insert_sql)
+    return conn.execute(
+        "select created, typeof(created) from {} where rowid = ?".format(
+            escape_sqlite(table)
+        ),
+        (cursor.lastrowid,),
+    ).fetchone()
+
+
 @pytest.mark.asyncio
 async def test_api_explorer_upsert_example_json(ds_write):
     response = await ds_write.client.get("/-/api", actor={"id": "root"})
@@ -948,10 +958,9 @@ async def test_alter_table_integer_default_expr(
     assert expected_schema in created_column["dflt_value"]
 
     row = await db.execute_write_fn(
-        lambda conn: conn.execute(
-            "insert into docs (title) values ('with default') "
-            "returning created, typeof(created)"
-        ).fetchone()
+        lambda conn: _insert_and_fetch_created(
+            conn, "docs", "insert into docs (title) values ('with default')"
+        )
     )
     assert row[0] > minimum_value
     assert row[1] == "integer"
@@ -2158,11 +2167,9 @@ async def test_create_table_integer_default_expr(
     assert expected_schema in columns[1]["dflt_value"]
 
     row = await db.execute_write_fn(
-        lambda conn: conn.execute(
-            "insert into [{}] default values returning created, typeof(created)".format(
-                table
-            )
-        ).fetchone()
+        lambda conn: _insert_and_fetch_created(
+            conn, table, "insert into {} default values".format(escape_sqlite(table))
+        )
     )
     assert row[0] > minimum_value
     assert row[1] == "integer"

From 86ea1d472275d353105cb2a8b2109c9ffc1a343e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 18:19:49 -0700
Subject: [PATCH 269/386] Visual improvements to table filter UI

- Looks nicer
- Add / remove buttons work properly

Closes #2798
---
 datasette/static/app.css          | 300 +++++++++++++++++++++++++-----
 datasette/static/table.js         | 169 ++++++++++++++---
 datasette/templates/patterns.html |  14 +-
 datasette/templates/table.html    |  14 +-
 4 files changed, 411 insertions(+), 86 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index f7cd97b0..ce800f61 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -609,9 +609,6 @@ button.core[type=button] {
     border-color: #007bff;
 }
 
-.filter-row {
-    margin-bottom: 0.6em;
-}
 .search-row {
     margin-bottom: 1.8em;
 }
@@ -623,72 +620,239 @@ button.core[type=button] {
     width: 80px;
 }
 
-.select-wrapper {
-    border: 1px solid #ccc;
-    width: 120px;
-    border-radius: 3px;
+.filters .search-row {
+    box-sizing: border-box;
+    display: grid;
+    grid-template-columns: max-content minmax(16rem, 1fr);
+    align-items: center;
+    gap: 0.6rem;
+    margin: 0 0 0.45rem;
+    padding-right: var(--filter-two-icon-space);
+}
+
+.filters .search-row label {
+    width: auto;
     padding: 0;
-    background-color: #fafafa;
-    position: relative;
+    color: var(--filter-muted);
+    font-size: 0.875rem;
+    font-weight: 600;
+}
+
+.filters {
+    --filter-ink: #0f0f0f;
+    --filter-paper: #eef6ff;
+    --filter-muted: #6b6b6b;
+    --filter-rule: #d8e6f5;
+    --filter-accent: #1a56db;
+    --filter-control-border: #bfccd9;
+    --filter-control-height: 2.125rem;
+    --filter-control-gap: 0.4rem;
+    --filter-row-icon-size: 2rem;
+    --filter-two-icon-space: calc(
+        (2 * var(--filter-row-icon-size)) + (2 * var(--filter-control-gap))
+    );
+    display: grid;
+    grid-template-columns: minmax(0, 1fr);
+    gap: 0.55rem;
+    max-width: 760px;
+    margin: 0 0 1rem;
+    padding: 0.75rem;
+    border: 1px solid var(--filter-rule);
+    border-radius: 8px;
+    background: var(--filter-paper);
+    color: var(--filter-ink);
+    font-size: 0.875rem;
+}
+
+.filters .filter-row {
+    margin-bottom: 0;
+}
+
+.filters .filter-controls-row {
+    display: grid;
+    min-width: 0;
+    width: 100%;
+    max-width: 100%;
+    box-sizing: border-box;
+    grid-template-columns:
+        minmax(8rem, 0.75fr)
+        minmax(6.5rem, 0.5fr)
+        minmax(12rem, 1.2fr)
+        var(--filter-row-icon-size)
+        var(--filter-row-icon-size);
+    gap: var(--filter-control-gap);
+    align-items: center;
+}
+
+.filters .filter-actions-row {
+    display: flex;
+    align-items: center;
+    justify-content: flex-start;
+    flex-wrap: wrap;
+    gap: 0.6rem;
+}
+
+.select-wrapper {
     display: inline-block;
-    margin-right: 0.3em;
-}
-.select-wrapper:focus-within {
-    border: 1px solid black;
+    width: 120px;
+    min-width: 0;
 }
+
 .select-wrapper.filter-op {
     width: 80px;
 }
-.select-wrapper::after {
-    content: "\25BE";
-    position: absolute;
-    top: 0px;
-    right: 0.4em;
-    color: #bbb;
-    pointer-events: none;
-    font-size: 1.2em;
-    padding-top: 0.16em;
+
+.filters .select-wrapper {
+    width: auto;
 }
 
 .select-wrapper select {
-    padding: 9px 8px;
+    box-sizing: border-box;
     width: 100%;
-    border: none;
-    box-shadow: none;
-    background: transparent;
-    background-image: none;
-    -webkit-appearance: none;
-    -moz-appearance: none;
+    height: var(--filter-control-height);
+    border: 1px solid var(--filter-control-border, #ccc);
+    border-radius: 5px;
+    background-color: #fff;
+    color: inherit;
     cursor: pointer;
+    font-family: inherit;
+    font-size: 0.875rem;
+    line-height: 1.25;
+    padding: 7px 8px;
 }
-.select-wrapper select {
-    font-size: 1em;
-    font-family: Helvetica, sans-serif;
-}
+
 .select-wrapper option {
     font-size: 1em;
     font-family: Helvetica, sans-serif;
 }
 
 .select-wrapper select:focus {
+    border-color: var(--filter-accent, #000);
+    box-shadow: 0 0 0 2px rgba(26, 86, 219, 0.14);
     outline: none;
 }
-.filters {
-    font-size: 0.8em;
-}
 .filters input.filter-value {
-    width: 200px;
-    border-radius: 3px;
-    -webkit-appearance: none;
-    padding: 9px 4px;
-    font-size: 16px;
-    font-family: Helvetica, sans-serif;
+    box-sizing: border-box;
+    width: 100%;
+    min-width: 0;
+    height: var(--filter-control-height);
+    border: 1px solid var(--filter-control-border);
+    border-radius: 5px;
+    background: #fff;
+    color: inherit;
+    font-family: inherit;
+    font-size: 0.875rem;
+    line-height: 1.25;
+    padding: 7px 9px;
+}
+
+.filters input.filter-value:focus {
+    border-color: var(--filter-accent);
+    box-shadow: 0 0 0 2px rgba(26, 86, 219, 0.14);
+    outline: none;
+}
+
+.filters input[type=submit] {
+    border-color: var(--filter-accent);
+    background: var(--filter-accent);
+    border-radius: 5px;
+    font-weight: 500;
+    padding: 0.55rem 0.85rem;
+}
+
+.filters input[type=submit]:hover,
+.filters input[type=submit]:focus {
+    background: #1949b8;
+    border-color: #1949b8;
+}
+
+.filters button.filter-row-icon {
+    display: inline-flex;
+    align-items: center;
+    justify-content: center;
+    box-sizing: border-box;
+    width: var(--filter-row-icon-size);
+    height: var(--filter-row-icon-size);
+    min-width: var(--filter-row-icon-size);
+    padding: 0;
+    border: 1px solid var(--filter-rule);
+    border-radius: 5px;
+    background: #fff;
+    color: var(--filter-muted);
+    font-family: inherit;
+    font-size: 1.15rem;
+    font-weight: 600;
+    line-height: 1;
+}
+
+.filters button.filter-row-icon[hidden] {
+    display: none;
+}
+
+.filters button.filter-row-icon:focus-visible {
+    outline: 3px solid rgba(26, 86, 219, 0.14);
+    outline-offset: 2px;
+}
+
+.filters .filter-row-remove-icon {
+    display: block;
+    height: 14px;
+    width: 14px;
+}
+
+.filters button.filter-row-remove:hover,
+.filters button.filter-row-remove:focus {
+    border-color: #c9d5e3;
+    background: #f8fbff;
+    color: var(--filter-ink);
+}
+
+.filters button.filter-row-add {
+    border-color: var(--filter-accent);
+    background: var(--filter-accent);
+    color: #fff;
+}
+
+.filters .filter-row-add-icon {
+    display: block;
+    height: 16px;
+    width: 16px;
+}
+
+.filters button.filter-row-add:hover,
+.filters button.filter-row-add:focus {
+    border-color: #1949b8;
+    background: #1949b8;
+    color: #fff;
+}
+
+.filters button.filter-row-add:focus-visible svg {
+    color: #fff;
+    stroke: currentColor;
 }
 
 #_search {
     font-size: 16px;
 }
 
+.filters #_search {
+    box-sizing: border-box;
+    width: 100%;
+    height: var(--filter-control-height);
+    border: 1px solid var(--filter-control-border);
+    border-radius: 5px;
+    background: #fff;
+    color: var(--filter-ink);
+    font: inherit;
+    padding: 7px 9px;
+}
+
+.filters #_search:focus {
+    border-color: var(--filter-accent);
+    box-shadow: 0 0 0 2px rgba(26, 86, 219, 0.14);
+    outline: none;
+}
+
 
 
 
@@ -3021,14 +3185,56 @@ select.table-alter-input {
         margin-bottom: 0.35rem;
     }
 
-    .select-wrapper {
-        width: 100px;
+    .filters {
+        max-width: none;
+        padding: 0.65rem;
     }
-    .select-wrapper.filter-op {
-        width: 60px;
+    .filters .search-row {
+        grid-template-columns: max-content minmax(0, 1fr);
+        padding-right: 0;
+    }
+    .filters .filter-controls-row {
+        --filter-value-button-space: 0px;
+        --filter-remove-button-offset: 0px;
+        grid-template-columns: repeat(2, minmax(0, 1fr));
+    }
+    .filters .filter-controls-row-one-button {
+        --filter-value-button-space: calc(
+            var(--filter-row-icon-size) + var(--filter-control-gap)
+        );
+    }
+    .filters .filter-controls-row-two-buttons {
+        --filter-value-button-space: var(--filter-two-icon-space);
+        --filter-remove-button-offset: calc(
+            var(--filter-row-icon-size) + var(--filter-control-gap)
+        );
+    }
+    .filters .filter-controls-row .select-wrapper {
+        grid-row: 1;
+        grid-column: 1 / 2;
+    }
+    .filters .filter-controls-row .select-wrapper.filter-op {
+        grid-column: 2 / 3;
     }
     .filters input.filter-value {
-        width: 140px;
+        grid-row: 2;
+        grid-column: 1 / 3;
+        justify-self: start;
+        width: calc(100% - var(--filter-value-button-space));
+    }
+    .filters button.filter-row-icon {
+        grid-row: 2;
+        grid-column: 1 / 3;
+        justify-self: end;
+    }
+    .filters .filter-controls-row-two-buttons button.filter-row-remove:not([hidden]) {
+        margin-right: var(--filter-remove-button-offset);
+    }
+    .filters .filter-actions-row {
+        justify-content: flex-start;
+    }
+    .filters .filter-actions-row input[type=submit] {
+        flex: 0 1 auto;
     }
     button.choose-columns-mobile,
     button.table-insert-row,
diff --git a/datasette/static/table.js b/datasette/static/table.js
index f160f3f3..74a96d8e 100644
--- a/datasette/static/table.js
+++ b/datasette/static/table.js
@@ -633,32 +633,151 @@ const initDatasetteTable = function (manager) {
   });
 };
 
-/* Add x buttons to the filter rows */
-function addButtonsToFilterRows(manager) {
-  var x = "✖";
-  var rows = Array.from(
-    document.querySelectorAll(manager.selectors.filterRow),
+function filterRowSelector(manager) {
+  return manager.selectors.filterRows || manager.selectors.filterRow;
+}
+
+function filterRowsWithControls(manager) {
+  return Array.from(
+    document.querySelectorAll(filterRowSelector(manager)),
   ).filter((el) => el.querySelector(".filter-op"));
-  rows.forEach((row) => {
-    var a = document.createElement("a");
-    a.setAttribute("href", "#");
-    a.setAttribute("aria-label", "Remove this filter");
-    a.style.textDecoration = "none";
-    a.innerText = x;
-    a.addEventListener("click", (ev) => {
-      ev.preventDefault();
-      let row = ev.target.closest("div");
-      row.querySelector("select").value = "";
-      row.querySelector(".filter-op select").value = "exact";
-      row.querySelector("input.filter-value").value = "";
-      ev.target.closest("a").style.display = "none";
-    });
-    row.appendChild(a);
+}
+
+function filterRowNumberFromName(name) {
+  var match = name && name.match(/^_filter_column_(\d+)$/);
+  return match ? parseInt(match[1], 10) : 0;
+}
+
+function nextFilterRowNumber(manager) {
+  return filterRowsWithControls(manager).reduce((max, row) => {
     var column = row.querySelector("select");
-    if (!column.value) {
-      a.style.display = "none";
+    return Math.max(max, filterRowNumberFromName(column && column.name));
+  }, 0) + 1;
+}
+
+function setFilterRowNumber(row, number) {
+  row.querySelector("select").name = `_filter_column_${number}`;
+  row.querySelector(".filter-op select").name = `_filter_op_${number}`;
+  row.querySelector("input.filter-value").name = `_filter_value_${number}`;
+}
+
+function resetFilterRow(row) {
+  row.querySelector("select").value = "";
+  row.querySelector(".filter-op select").value = "exact";
+  row.querySelector("input.filter-value").value = "";
+}
+
+function updateFilterRowButtons(manager) {
+  var rows = filterRowsWithControls(manager);
+  rows.forEach((row, index) => {
+    var removeButton = row.querySelector(".filter-row-remove");
+    var addButton = row.querySelector(".filter-row-add");
+    var column = row.querySelector("select");
+    if (removeButton) {
+      removeButton.hidden = index === 0;
+    }
+    if (addButton) {
+      addButton.hidden = index !== rows.length - 1 || !column.value;
+    }
+    var visibleButtonCount = [removeButton, addButton].filter(function (button) {
+      return button && !button.hidden;
+    }).length;
+    row.classList.toggle(
+      "filter-controls-row-has-buttons",
+      visibleButtonCount > 0,
+    );
+    row.classList.toggle(
+      "filter-controls-row-one-button",
+      visibleButtonCount === 1,
+    );
+    row.classList.toggle(
+      "filter-controls-row-two-buttons",
+      visibleButtonCount === 2,
+    );
+  });
+}
+
+function cloneFilterRow(row) {
+  var clone = row.cloneNode(true);
+  clone.querySelector("select").name = "_filter_column";
+  clone.querySelector(".filter-op select").name = "_filter_op";
+  clone.querySelector("input.filter-value").name = "_filter_value";
+  resetFilterRow(clone);
+  clone.querySelectorAll(".filter-row-icon").forEach((button) => button.remove());
+  return clone;
+}
+
+var FILTER_REMOVE_ICON_SVG = `<svg class="filter-row-remove-icon" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.1" stroke-linecap="round" stroke-linejoin="round">
+  <path d="M3 6h18"></path>
+  <path d="M8 6V4a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v2"></path>
+  <path d="M19 6l-1 14a2 2 0 0 1-2 2H8a2 2 0 0 1-2-2L5 6"></path>
+  <path d="M10 11v6"></path>
+  <path d="M14 11v6"></path>
+</svg>`;
+
+var FILTER_ADD_ICON_SVG = `<svg class="filter-row-add-icon" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="3" stroke-linecap="round" stroke-linejoin="round">
+  <path d="M5 12h14"></path>
+  <path d="M12 5v14"></path>
+</svg>`;
+
+function addFilterRowButtons(row, manager) {
+  var removeButton = document.createElement("button");
+  removeButton.type = "button";
+  removeButton.className = "filter-row-icon filter-row-remove";
+  removeButton.setAttribute("aria-label", "Remove this filter");
+  removeButton.title = "Remove this filter";
+  removeButton.tabIndex = 0;
+  removeButton.innerHTML = FILTER_REMOVE_ICON_SVG;
+  removeButton.addEventListener("click", (ev) => {
+    var row = ev.currentTarget.closest(filterRowSelector(manager));
+    var rows = filterRowsWithControls(manager);
+    var rowIndex = rows.indexOf(row);
+    var focusRow = rows[rowIndex + 1] || rows[rowIndex - 1] || null;
+    row.remove();
+    updateFilterRowButtons(manager);
+    if (focusRow) {
+      var focusTarget =
+        focusRow.querySelector(".filter-row-add:not([hidden])") ||
+        focusRow.querySelector("select");
+      if (focusTarget) {
+        focusTarget.focus();
+      }
     }
   });
+  row.appendChild(removeButton);
+
+  var addButton = document.createElement("button");
+  addButton.type = "button";
+  addButton.className = "filter-row-icon filter-row-add";
+  addButton.setAttribute("aria-label", "Add another filter");
+  addButton.title = "Add another filter";
+  addButton.tabIndex = 0;
+  addButton.innerHTML = FILTER_ADD_ICON_SVG;
+  addButton.addEventListener("click", (ev) => {
+    var row = ev.currentTarget.closest(filterRowSelector(manager));
+    if (row.querySelector("select").name === "_filter_column") {
+      setFilterRowNumber(row, nextFilterRowNumber(manager));
+    }
+    var clone = cloneFilterRow(row);
+    addFilterRowButtons(clone, manager);
+    row.parentNode.insertBefore(clone, row.nextSibling);
+    updateFilterRowButtons(manager);
+    clone.querySelector("select").focus();
+  });
+  row.appendChild(addButton);
+
+  row.querySelector("select").addEventListener("change", () => {
+    updateFilterRowButtons(manager);
+  });
+}
+
+/* Add buttons to the filter rows */
+function addButtonsToFilterRows(manager) {
+  var rows = filterRowsWithControls(manager);
+  rows.forEach((row) => {
+    addFilterRowButtons(row, manager);
+  });
+  updateFilterRowButtons(manager);
 }
 
 /* Set up datalist autocomplete for filter values */
@@ -687,11 +806,11 @@ function initAutocompleteForFilterValues(manager) {
     });
   }
   createDataLists();
-  // When any select with name=_filter_column changes, update the datalist
+  // When any filter column select changes, update the datalist
   document.body.addEventListener("change", function (event) {
-    if (event.target.name === "_filter_column") {
+    if (event.target.name && event.target.name.startsWith("_filter_column")) {
       event.target
-        .closest(manager.selectors.filterRow)
+        .closest(filterRowSelector(manager))
         .querySelector(".filter-value")
         .setAttribute("list", "datalist-" + event.target.value);
     }
diff --git a/datasette/templates/patterns.html b/datasette/templates/patterns.html
index a46478a7..bff44341 100644
--- a/datasette/templates/patterns.html
+++ b/datasette/templates/patterns.html
@@ -202,9 +202,9 @@
     <h3>3 rows
         where characteristic_id = 2
     </h3>
-    <form class="filters" action="{{ base_url }}fixtures/roadside_attraction_characteristics" method="get">
+    <form class="core filters" action="{{ base_url }}fixtures/roadside_attraction_characteristics" method="get">
     <div class="search-row"><label for="_search">Search:</label><input id="_search" type="search" name="_search" value=""></div>
-        <div class="filter-row">
+        <div class="filter-row filter-controls-row">
             <div class="select-wrapper">
                 <select name="_filter_column_1">
                     <option value="">- remove filter -</option>
@@ -238,7 +238,7 @@
                 </select>
             </div><input type="text" name="_filter_value_1" class="filter-value" value="2">
         </div>
-    <div class="filter-row">
+    <div class="filter-row filter-controls-row">
         <div class="select-wrapper">
             <select name="_filter_column">
                 <option value="">- column -</option>
@@ -272,8 +272,8 @@
             </select>
         </div><input type="text" name="_filter_value" class="filter-value">
     </div>
-    <div class="filter-row">
-            <div class="select-wrapper small-screen-only">
+    <div class="filter-row filter-actions-row">
+            <div class="select-wrapper">
                 <select name="_sort" id="sort_by">
                     <option value="">Sort...</option>
                     <option value="rowid" selected>Sort by rowid</option>
@@ -281,8 +281,8 @@
                     <option value="characteristic_id">Sort by characteristic_id</option>
                 </select>
             </div>
-            <label class="sort_by_desc small-screen-only"><input type="checkbox" name="_sort_by_desc"> descending</label>
-        <input type="submit" value="Apply">
+            <label class="sort_by_desc"><input type="checkbox" name="_sort_by_desc"> descending</label>
+        <input type="submit" value="Apply filters">
     </div>
   </form>
 
diff --git a/datasette/templates/table.html b/datasette/templates/table.html
index 86b6a6ed..e06ef94e 100644
--- a/datasette/templates/table.html
+++ b/datasette/templates/table.html
@@ -55,12 +55,12 @@
     </h3>
 {% endif %}
 
-<form class="core" class="filters" action="{{ urls.table(database, table) }}" method="get">
+<form class="core filters" action="{{ urls.table(database, table) }}" method="get">
     {% if supports_search %}
         <div class="search-row"><label for="_search">Search:</label><input id="_search" type="search" name="_search" value="{{ search }}"></div>
     {% endif %}
     {% for column, lookup, value in filters.selections() %}
-        <div class="filter-row">
+        <div class="filter-row filter-controls-row">
             <div class="select-wrapper">
                 <select name="_filter_column_{{ loop.index }}">
                     <option value="">- remove filter -</option>
@@ -77,7 +77,7 @@
             </div><input type="text" name="_filter_value_{{ loop.index }}" class="filter-value" value="{{ value }}">
         </div>
     {% endfor %}
-    <div class="filter-row">
+    <div class="filter-row filter-controls-row">
         <div class="select-wrapper">
             <select name="_filter_column">
                 <option value="">- column -</option>
@@ -93,9 +93,9 @@
             </select>
         </div><input type="text" name="_filter_value" class="filter-value">
     </div>
-    <div class="filter-row">
+    <div class="filter-row filter-actions-row">
         {% if is_sortable %}
-            <div class="select-wrapper small-screen-only">
+            <div class="select-wrapper">
                 <select name="_sort" id="sort_by">
                     <option value="">Sort...</option>
                     {% for column in display_columns %}
@@ -105,12 +105,12 @@
                     {% endfor %}
                 </select>
             </div>
-            <label class="sort_by_desc small-screen-only"><input type="checkbox" name="_sort_by_desc"{% if sort_desc %} checked{% endif %}> descending</label>
+            <label class="sort_by_desc"><input type="checkbox" name="_sort_by_desc" tabindex="0"{% if sort_desc %} checked{% endif %}> descending</label>
         {% endif %}
         {% for key, value in form_hidden_args %}
             <input type="hidden" name="{{ key }}" value="{{ value }}">
         {% endfor %}
-        <input type="submit" value="Apply">
+        <input type="submit" value="Apply filters" tabindex="0">
     </div>
 </form>
 

From 4d031c85621ab7e63b1952d25e3e938fa72323b1 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 22 Jun 2026 19:47:21 -0700
Subject: [PATCH 270/386] Add count_truncated template context

---
 datasette/templates/database.html |  2 +-
 datasette/templates/table.html    |  4 ++--
 datasette/views/__init__.py       |  2 ++
 datasette/views/database.py       | 29 ++++++++++++++++++++++----
 datasette/views/table.py          | 33 +++++++++++++++++++++++-------
 datasette/views/table_extras.py   |  4 ++--
 docs/template_context.rst         | 13 +++++-------
 tests/test_template_context.py    | 34 ++++++++++++++++++++++++++++++-
 8 files changed, 96 insertions(+), 25 deletions(-)

diff --git a/datasette/templates/database.html b/datasette/templates/database.html
index 23eeb571..c09582f7 100644
--- a/datasette/templates/database.html
+++ b/datasette/templates/database.html
@@ -76,7 +76,7 @@
 <div class="db-table">
     <h3><a href="{{ urls.table(database, table.name) }}">{{ table.name }}</a>{% if table.private %} 🔒{% endif %}{% if table.hidden %}<em> (hidden)</em>{% endif %}</h3>
     <p><em>{% for column in table.columns %}{{ column }}{% if not loop.last %}, {% endif %}{% endfor %}</em></p>
-    <p>{% if table.count is none %}Many rows{% elif table.count == count_limit + 1 %}&gt;{{ "{:,}".format(count_limit) }} rows{% else %}{{ "{:,}".format(table.count) }} row{% if table.count == 1 %}{% else %}s{% endif %}{% endif %}</p>
+    <p>{% if table.count is none %}Many rows{% elif table.count_truncated %}&gt;{{ "{:,}".format(table.count - 1) }} rows{% else %}{{ "{:,}".format(table.count) }} row{% if table.count == 1 %}{% else %}s{% endif %}{% endif %}</p>
 </div>
 {% endif %}
 {% endfor %}
diff --git a/datasette/templates/table.html b/datasette/templates/table.html
index e06ef94e..b7b776ab 100644
--- a/datasette/templates/table.html
+++ b/datasette/templates/table.html
@@ -1,6 +1,6 @@
 {% extends "base.html" %}
 
-{% block title %}{{ database }}: {{ table }}: {% if count or count == 0 %}{{ "{:,}".format(count) }} row{% if count == 1 %}{% else %}s{% endif %}{% endif %}{% if human_description_en %} {{ human_description_en }}{% endif %}{% endblock %}
+{% block title %}{{ database }}: {{ table }}: {% if count_truncated %}&gt;{{ "{:,}".format(count - 1) }} rows{% elif count or count == 0 %}{{ "{:,}".format(count) }} row{% if count == 1 %}{% else %}s{% endif %}{% endif %}{% if human_description_en %} {{ human_description_en }}{% endif %}{% endblock %}
 
 {% block extra_head %}
 {{- super() -}}
@@ -48,7 +48,7 @@
 
 {% if count or human_description_en %}
     <h3>
-        {% if count == count_limit + 1 %}&gt;{{ "{:,}".format(count_limit) }} rows
+        {% if count_truncated %}&gt;{{ "{:,}".format(count - 1) }} rows
         {% if allow_execute_sql and query.sql %} <a class="count-sql" style="font-size: 0.8em;" href="{{ urls.database_query(database, count_sql) }}">count all</a>{% endif %}
         {% elif count or count == 0 %}{{ "{:,}".format(count) }} row{% if count == 1 %}{% else %}s{% endif %}{% endif %}
         {% if human_description_en %}{{ human_description_en }}{% endif %}
diff --git a/datasette/views/__init__.py b/datasette/views/__init__.py
index 238b9bb3..e503ed35 100644
--- a/datasette/views/__init__.py
+++ b/datasette/views/__init__.py
@@ -32,6 +32,8 @@ class Context:
         "List of ContextField describing the documented fields of this context"
         documented = []
         for f in dataclasses.fields(cls):
+            if f.name.startswith("_"):
+                continue
             from_extra = bool(f.metadata.get("from_extra"))
             if from_extra:
                 help_text = cls._extra_description(f.name)
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 0d35b87f..46a90c4c 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -230,7 +230,6 @@ class DatabaseView(View):
                     database_actions=database_actions,
                     show_hidden=request.args.get("_show_hidden"),
                     editable=True,
-                    count_limit=db.count_limit,
                     allow_download=datasette.setting("allow_download")
                     and not db.is_mutable
                     and not db.is_memory,
@@ -267,7 +266,11 @@ class DatabaseContext(Context):
     )
     path: str = field(metadata={"help": "The URL path to this database"})
     size: int = field(metadata={"help": "The size of the database in bytes"})
-    tables: list = field(metadata={"help": "List of table objects in the database"})
+    tables: list = field(
+        metadata={
+            "help": "List of table objects in the database. Each item includes a ``count_truncated`` key that is true if ``count`` is a capped lower bound rather than an exact total."
+        }
+    )
     hidden_count: int = field(metadata={"help": "Count of hidden tables"})
     views: list = field(metadata={"help": "List of view objects in the database"})
     queries: list = field(metadata={"help": "List of stored query objects"})
@@ -295,7 +298,6 @@ class DatabaseContext(Context):
     editable: bool = field(
         metadata={"help": "Boolean indicating if the database is editable"}
     )
-    count_limit: int = field(metadata={"help": "The maximum number of rows to count"})
     allow_download: bool = field(
         metadata={"help": "Boolean indicating if database download is allowed"}
     )
@@ -365,7 +367,11 @@ class QueryContext(Context):
     save_query_url: str = field(
         metadata={"help": "URL to save the current arbitrary SQL as a query"}
     )
-    tables: list = field(metadata={"help": "List of table objects in the database"})
+    tables: list = field(
+        metadata={
+            "help": "List of table objects in the database. Each item includes a ``count_truncated`` key that is true if ``count`` is a capped lower bound rather than an exact total."
+        }
+    )
     named_parameter_values: dict = field(
         metadata={"help": "Dictionary of parameter names/values"}
     )
@@ -430,6 +436,9 @@ async def get_tables(datasette, request, db, allowed_dict):
                 "columns": table_columns,
                 "primary_keys": await db.primary_keys(table),
                 "count": table_counts[table],
+                "count_truncated": _table_count_truncated(
+                    datasette, db, table, table_counts[table]
+                ),
                 "hidden": table in hidden_table_names,
                 "fts_table": await db.fts_table(table),
                 "foreign_keys": all_foreign_keys[table],
@@ -440,6 +449,18 @@ async def get_tables(datasette, request, db, allowed_dict):
     return tables
 
 
+def _table_count_truncated(datasette, db, table, count):
+    if count != db.count_limit + 1:
+        return False
+    if not db.is_mutable and datasette.inspect_data:
+        try:
+            datasette.inspect_data[db.name]["tables"][table]["count"]
+            return False
+        except KeyError:
+            pass
+    return True
+
+
 async def database_download(request, datasette):
     from datasette.resources import DatabaseResource
 
diff --git a/datasette/views/table.py b/datasette/views/table.py
index a6769242..38a69f5f 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -113,6 +113,11 @@ class TableContext(Context):
         metadata={"help": "True if the data for this page was retrieved without errors"}
     )
     next: str = field(metadata={"help": "Pagination token for the next page, or None"})
+    count_truncated: bool = field(
+        metadata={
+            "help": "True if ``count`` is a capped lower bound rather than an exact total, because Datasette stopped counting after its configured row-count limit."
+        }
+    )
     rows: list = field(
         metadata={
             "help": "The rows for this page, as a list of dictionaries mapping column name to value"
@@ -185,11 +190,6 @@ class TableContext(Context):
     top_table: callable = field(
         metadata={"help": "Async function rendering the top_table plugin slot"}
     )
-    count_limit: int = field(
-        metadata={
-            "help": "The maximum number of rows Datasette will count before showing an approximation"
-        }
-    )
     table_page_data: dict = field(
         metadata={"help": "JSON data used by JavaScript on the table page"}
     )
@@ -1391,7 +1391,6 @@ class TableFragmentView(BaseView):
                 path_with_replaced_args=path_with_replaced_args,
                 fix_path=self.ds.urls.path,
                 settings=self.ds.settings_dict(),
-                count_limit=resolved.db.count_limit,
             ),
             request=request,
             view_name="table",
@@ -1843,7 +1842,6 @@ async def table_view_traced(datasette, request):
                         database=resolved.db.name,
                         table=resolved.table,
                     ),
-                    count_limit=resolved.db.count_limit,
                 ),
                 request=request,
                 view_name="table",
@@ -2276,6 +2274,9 @@ async def table_view_data(
     data["rows"] = transformed_rows
 
     if context_for_html_hack:
+        data["count_truncated"] = _count_truncated_for_table_page(
+            datasette, db, database_name, table_name, count_sql, data.get("count")
+        )
         data.update(extra_context_from_filters)
         # filter_columns combine the columns we know are available
         # in the table with any additional columns (such as rowid)
@@ -2341,6 +2342,24 @@ async def table_view_data(
     return data, rows[:page_size], columns, expanded_columns, sql, next_url
 
 
+def _count_truncated_for_table_page(
+    datasette, db, database_name, table_name, count_sql, count
+):
+    if count != db.count_limit + 1:
+        return False
+    if (
+        not db.is_mutable
+        and datasette.inspect_data
+        and count_sql == f"select count(*) from {table_name} "
+    ):
+        try:
+            datasette.inspect_data[database_name]["tables"][table_name]["count"]
+            return False
+        except KeyError:
+            pass
+    return True
+
+
 async def _next_value_and_url(
     datasette,
     db,
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index 7cb4d8f0..f688433d 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -127,8 +127,8 @@ class CountExtra(Extra):
                 pass
 
         if context.count_sql and count is None and not context.nocount:
-            count_sql_limited = (
-                f"select count(*) from (select * {context.from_sql} limit 10001)"
+            count_sql_limited = "select count(*) from (select * {} limit {})".format(
+                context.from_sql, context.db.count_limit + 1
             )
             try:
                 count_rows = list(
diff --git a/docs/template_context.rst b/docs/template_context.rst
index f94ecd48..b27f2f79 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -100,9 +100,6 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
 ``attached_databases`` - ``list``
     List of names of attached databases
 
-``count_limit`` - ``int``
-    The maximum number of rows to count
-
 ``database`` - ``str``
     The name of the database
 
@@ -152,7 +149,7 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
     Dictionary mapping table names to their column lists
 
 ``tables`` - ``list``
-    List of table objects in the database
+    List of table objects in the database. Each item includes a ``count_truncated`` key that is true if ``count`` is a capped lower bound rather than an exact total.
 
 ``top_database`` - ``callable``
     Callable to render the top_database slot
@@ -241,7 +238,7 @@ The page for arbitrary SQL queries (/database/-/query?sql=...) and stored querie
     Dictionary of table name to list of column names
 
 ``tables`` - ``list``
-    List of table objects in the database
+    List of table objects in the database. Each item includes a ``count_truncated`` key that is true if ``count`` is a capped lower bound rather than an exact total.
 
 ``top_query`` - ``callable``
     Callable to render the top_query slot
@@ -280,12 +277,12 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
 ``count`` - ``int``
     Total count of rows matching these filters
 
-``count_limit`` - ``int``
-    The maximum number of rows Datasette will count before showing an approximation
-
 ``count_sql`` - ``str``
     SQL query used to calculate the total count
 
+``count_truncated`` - ``bool``
+    True if ``count`` is a capped lower bound rather than an exact total, because Datasette stopped counting after its configured row-count limit.
+
 ``custom_table_templates`` - ``list``
     Custom template names considered for this table
 
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index b970cb8a..8d78bf77 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -21,6 +21,7 @@ def test_documented_fields():
     @dataclass
     class DemoContext(Context):
         name: str = field(metadata={"help": "The name"})
+        _internal: str = field()
         count: int = field(metadata={"help": "How many there are"})
 
     fields = DemoContext.documented_fields()
@@ -165,7 +166,11 @@ async def test_template_context_matches_documented_contract(
     # The full contract: every key in the rendered template context is
     # documented, and every documented key is present in the context
     documented = documented_context_keys(page_name)
-    actual = set(await get_template_context(context_ds, path))
+    actual = {
+        key
+        for key in await get_template_context(context_ds, path)
+        if not key.startswith("_")
+    }
     undocumented = actual - documented
     no_longer_present = documented - actual
     assert not undocumented, (
@@ -178,6 +183,33 @@ async def test_template_context_matches_documented_contract(
     )
 
 
+@pytest.mark.asyncio
+async def test_count_truncated_replaces_count_limit_context_key(context_ds):
+    db = context_ds.databases["fixtures"]
+    previous_count_limit = db.count_limit
+    previous_cached_table_counts = db._cached_table_counts
+    db.count_limit = 10
+    db._cached_table_counts = None
+    try:
+        table_context = await get_template_context(context_ds, "/fixtures/facetable")
+        assert table_context["count"] == 11
+        assert table_context["count_truncated"] is True
+        assert "count_limit" not in table_context
+
+        database_context = await get_template_context(context_ds, "/fixtures")
+        facetable = next(
+            table
+            for table in database_context["tables"]
+            if table["name"] == "facetable"
+        )
+        assert facetable["count"] == 11
+        assert facetable["count_truncated"] is True
+        assert "count_limit" not in database_context
+    finally:
+        db.count_limit = previous_count_limit
+        db._cached_table_counts = previous_cached_table_counts
+
+
 def test_base_context_keys_all_have_docs():
     for name, doc in TEMPLATE_BASE_CONTEXT.items():
         assert doc, "Base context key {} is missing docs".format(name)

From 29971d97293a78ca44f66a1129d8c8b922b09c38 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 07:29:14 -0700
Subject: [PATCH 271/386] Clarify base template context docs

---
 datasette/app.py          | 42 +++++++++++++++++++++------------------
 docs/template_context.rst | 29 ++++++++++++---------------
 2 files changed, 36 insertions(+), 35 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 9f0c8397..90de60a9 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -35,6 +35,7 @@ from jinja2 import (
     ChoiceLoader,
     Environment,
     FileSystemLoader,
+    pass_context,
     PrefixLoader,
 )
 from jinja2.environment import Template
@@ -330,30 +331,37 @@ def _to_string(value):
         return json.dumps(value, default=str)
 
 
+@pass_context
+def _legacy_template_csrftoken(context):
+    request = context.get("request")
+    if request and "csrftoken" in request.scope:
+        return request.scope["csrftoken"]()
+    return ""
+
+
 # Documentation for the variables Datasette.render_template() adds to the
 # context for every page. This is part of the documented template contract:
 # keys added in render_template() must be documented here - the contract
 # tests in tests/test_template_context.py enforce this, and the docs in
 # docs/template_context.rst are generated from it.
 TEMPLATE_BASE_CONTEXT = {
-    "request": "The current Request object, or None",
-    "crumb_items": "Async function returning breadcrumb navigation items for the current page",
-    "urls": "Object with methods for constructing URLs to pages within Datasette - see datasette.urls in the internals documentation",
-    "actor": "The currently authenticated actor dictionary, or None",
-    "menu_links": "Async function returning links for the Datasette application menu, including those added by plugins",
-    "display_actor": "Function returning a display string for an actor dictionary",
+    "request": "The current :ref:`Request object <internals_request>`, or None. Common properties include ``request.path``, ``request.args``, ``request.actor``, ``request.url_vars`` and ``request.host``.",
+    "crumb_items": 'Async function returning breadcrumb navigation items for the current page. Call it with ``request=request`` plus optional ``database=`` and ``table=`` arguments; it returns a list of ``{"href": url, "label": label}`` dictionaries.',
+    "urls": "Object with methods for constructing URLs within Datasette. Common methods include ``urls.instance()``, ``urls.database(database)``, ``urls.table(database, table)``, ``urls.query(database, query)``, ``urls.row(database, table, row_path)`` and ``urls.static(path)`` - see :ref:`internals_datasette_urls`.",
+    "actor": "The currently authenticated actor dictionary, or None. Actors usually include an ``id`` key and may include any other keys supplied by authentication plugins.",
+    "menu_links": "Async function returning links for the Datasette application menu, including links added by plugins. Each item is a link dictionary with ``href`` and ``label`` keys. See :ref:`plugin_hook_menu_links`; for page action menus that can also include JavaScript-backed buttons, see :ref:`plugin_actions`.",
+    "display_actor": "Function that accepts an actor dictionary and returns the display string used in the navigation menu.",
     "show_logout": "True if the logout link should be shown in the navigation menu",
     "app_css_hash": "Hash of Datasette's app.css contents, used for cache busting",
     "edit_tools_js_hash": "Hash of Datasette's edit-tools.js contents, used for cache busting",
     "table_js_hash": "Hash of Datasette's table.js contents, used for cache busting",
-    "zip": "Python's zip() builtin, made available to template logic",
-    "body_scripts": "List of script blocks for the page body contributed by plugins",
-    "format_bytes": "Function that formats a number of bytes as a human-readable size",
-    "show_messages": "Function returning any messages set for the current user, clearing them in the process",
-    "extra_css_urls": "List of {url, sri} dictionaries of extra CSS stylesheets to include on the page, from plugins and configuration",
-    "extra_js_urls": "List of {url, sri, module} dictionaries of extra JavaScript URLs to include on the page",
-    "base_url": "The configured base_url setting",
-    "csrftoken": "Function returning the CSRF token for the current request",
+    "zip": "Python's ``zip()`` builtin, made available to template logic",
+    "body_scripts": 'List of JavaScript snippets contributed by plugins using :ref:`plugin_hook_extra_body_script`. Each item is a dictionary with ``script`` containing JavaScript source and ``module`` indicating whether Datasette will wrap it in ``<script type="module">``; otherwise Datasette wraps it in a regular ``<script>`` block.',
+    "format_bytes": "Function that accepts a byte count integer and returns a human-readable string such as ``1.2 MB``.",
+    "show_messages": "Function returning any messages set for the current user, clearing them in the process. Returns a list of ``(message, type)`` pairs, where ``type`` is one of Datasette's ``INFO``, ``WARNING`` or ``ERROR`` constants.",
+    "extra_css_urls": "List of extra CSS stylesheets to include on the page. Each item is a dictionary with ``url`` and optional ``sri`` keys, from plugins and configuration.",
+    "extra_js_urls": "List of extra JavaScript URLs to include on the page. Each item is a dictionary with ``url`` plus optional ``sri`` and ``module`` keys, from plugins and configuration.",
+    "base_url": "The configured :ref:`setting_base_url` setting",
     "datasette_version": "The version of Datasette that is running",
 }
 
@@ -590,6 +598,7 @@ class Datasette:
         )
         environment.filters["escape_css_string"] = escape_css_string
         environment.filters["quote_plus"] = urllib.parse.quote_plus
+        environment.globals["csrftoken"] = _legacy_template_csrftoken
         self._jinja_env = environment
         environment.filters["escape_sqlite"] = escape_sqlite
         environment.filters["to_css_class"] = to_css_class
@@ -2375,11 +2384,6 @@ class Datasette:
                     "extra_js_urls", template, context, request, view_name
                 ),
                 "base_url": self.setting("base_url"),
-                "csrftoken": (
-                    request.scope["csrftoken"]
-                    if request and "csrftoken" in request.scope
-                    else lambda: ""
-                ),
                 "datasette_version": __version__,
             },
             **extra_template_vars,
diff --git a/docs/template_context.rst b/docs/template_context.rst
index b27f2f79..dd4524f0 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -27,22 +27,22 @@ Base context
 These variables are available on every page rendered by Datasette, including pages rendered by plugins that use :ref:`datasette.render_template() <datasette_render_template>`. Plugins can add additional variables using the :ref:`plugin_hook_extra_template_vars` hook.
 
 ``request``
-    The current Request object, or None
+    The current :ref:`Request object <internals_request>`, or None. Common properties include ``request.path``, ``request.args``, ``request.actor``, ``request.url_vars`` and ``request.host``.
 
 ``crumb_items``
-    Async function returning breadcrumb navigation items for the current page
+    Async function returning breadcrumb navigation items for the current page. Call it with ``request=request`` plus optional ``database=`` and ``table=`` arguments; it returns a list of ``{"href": url, "label": label}`` dictionaries.
 
 ``urls``
-    Object with methods for constructing URLs to pages within Datasette - see datasette.urls in the internals documentation
+    Object with methods for constructing URLs within Datasette. Common methods include ``urls.instance()``, ``urls.database(database)``, ``urls.table(database, table)``, ``urls.query(database, query)``, ``urls.row(database, table, row_path)`` and ``urls.static(path)`` - see :ref:`internals_datasette_urls`.
 
 ``actor``
-    The currently authenticated actor dictionary, or None
+    The currently authenticated actor dictionary, or None. Actors usually include an ``id`` key and may include any other keys supplied by authentication plugins.
 
 ``menu_links``
-    Async function returning links for the Datasette application menu, including those added by plugins
+    Async function returning links for the Datasette application menu, including links added by plugins. Each item is a link dictionary with ``href`` and ``label`` keys. See :ref:`plugin_hook_menu_links`; for page action menus that can also include JavaScript-backed buttons, see :ref:`plugin_actions`.
 
 ``display_actor``
-    Function returning a display string for an actor dictionary
+    Function that accepts an actor dictionary and returns the display string used in the navigation menu.
 
 ``show_logout``
     True if the logout link should be shown in the navigation menu
@@ -57,28 +57,25 @@ These variables are available on every page rendered by Datasette, including pag
     Hash of Datasette's table.js contents, used for cache busting
 
 ``zip``
-    Python's zip() builtin, made available to template logic
+    Python's ``zip()`` builtin, made available to template logic
 
 ``body_scripts``
-    List of script blocks for the page body contributed by plugins
+    List of JavaScript snippets contributed by plugins using :ref:`plugin_hook_extra_body_script`. Each item is a dictionary with ``script`` containing JavaScript source and ``module`` indicating whether Datasette will wrap it in ``<script type="module">``; otherwise Datasette wraps it in a regular ``<script>`` block.
 
 ``format_bytes``
-    Function that formats a number of bytes as a human-readable size
+    Function that accepts a byte count integer and returns a human-readable string such as ``1.2 MB``.
 
 ``show_messages``
-    Function returning any messages set for the current user, clearing them in the process
+    Function returning any messages set for the current user, clearing them in the process. Returns a list of ``(message, type)`` pairs, where ``type`` is one of Datasette's ``INFO``, ``WARNING`` or ``ERROR`` constants.
 
 ``extra_css_urls``
-    List of {url, sri} dictionaries of extra CSS stylesheets to include on the page, from plugins and configuration
+    List of extra CSS stylesheets to include on the page. Each item is a dictionary with ``url`` and optional ``sri`` keys, from plugins and configuration.
 
 ``extra_js_urls``
-    List of {url, sri, module} dictionaries of extra JavaScript URLs to include on the page
+    List of extra JavaScript URLs to include on the page. Each item is a dictionary with ``url`` plus optional ``sri`` and ``module`` keys, from plugins and configuration.
 
 ``base_url``
-    The configured base_url setting
-
-``csrftoken``
-    Function returning the CSRF token for the current request
+    The configured :ref:`setting_base_url` setting
 
 ``datasette_version``
     The version of Datasette that is running

From 4ac795e20c7a8ffc4937d5e9408f9f0ad86cab01 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 07:30:04 -0700
Subject: [PATCH 272/386] Expand template context field documentation

---
 datasette/views/database.py     |  92 +++++++++++++++------
 datasette/views/row.py          |  38 +++++----
 datasette/views/table.py        |  32 +++++---
 datasette/views/table_extras.py |  50 ++++++------
 docs/template_context.rst       | 136 ++++++++++++++++----------------
 5 files changed, 208 insertions(+), 140 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index 46a90c4c..7409e7d3 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -268,12 +268,20 @@ class DatabaseContext(Context):
     size: int = field(metadata={"help": "The size of the database in bytes"})
     tables: list = field(
         metadata={
-            "help": "List of table objects in the database. Each item includes a ``count_truncated`` key that is true if ``count`` is a capped lower bound rather than an exact total."
+            "help": "List of table dictionaries in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` keys. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total."
         }
     )
     hidden_count: int = field(metadata={"help": "Count of hidden tables"})
-    views: list = field(metadata={"help": "List of view objects in the database"})
-    queries: list = field(metadata={"help": "List of stored query objects"})
+    views: list = field(
+        metadata={
+            "help": "List of SQLite view dictionaries. Each item has ``name`` and ``private`` keys."
+        }
+    )
+    queries: list = field(
+        metadata={
+            "help": "List of stored query objects. Each has attributes including ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``is_write`` and ``private``."
+        }
+    )
     queries_more: bool = field(
         metadata={"help": "Boolean indicating if more stored queries are available"}
     )
@@ -282,16 +290,24 @@ class DatabaseContext(Context):
         metadata={"help": "Boolean indicating if custom SQL can be executed"}
     )
     table_columns: dict = field(
-        metadata={"help": "Dictionary mapping table names to their column lists"}
+        metadata={
+            "help": "Dictionary mapping table names to lists of column names, used to power SQL autocomplete."
+        }
+    )
+    metadata: dict = field(
+        metadata={
+            "help": "Metadata dictionary for the database, such as ``title``, ``description``, ``license`` and ``source`` values from Datasette metadata."
+        }
     )
-    metadata: dict = field(metadata={"help": "Metadata for the database"})
     database_color: str = field(metadata={"help": "The color assigned to the database"})
     database_page_data: dict = field(
-        metadata={"help": "JSON data used by JavaScript on the database page"}
+        metadata={
+            "help": 'JSON data used by JavaScript on the database page. Currently ``{}`` or ``{"createTable": {...}}`` where ``createTable`` includes ``path``, ``foreignKeyTargetsPath``, ``databaseName``, ``columnTypes``, ``defaultExpressions`` and optional ``customColumnTypes``.'
+        }
     )
     database_actions: callable = field(
         metadata={
-            "help": "Callable returning list of action links for the database menu"
+            "help": 'Async callable returning action items for the database menu. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions` and :ref:`plugin_hook_database_actions`.'
         }
     )
     show_hidden: str = field(metadata={"help": "Value of _show_hidden query parameter"})
@@ -302,18 +318,22 @@ class DatabaseContext(Context):
         metadata={"help": "Boolean indicating if database download is allowed"}
     )
     attached_databases: list = field(
-        metadata={"help": "List of names of attached databases"}
+        metadata={
+            "help": "List of names of databases attached to this SQLite connection. This is only populated for the special ``/_memory`` database when Datasette is started with ``--crossdb`` for :ref:`cross_database_queries`."
+        }
     )
     alternate_url_json: str = field(
         metadata={"help": "URL for the alternate JSON version of this page"}
     )
     select_templates: list = field(
         metadata={
-            "help": "List of templates that were considered for rendering this page"
+            "help": "List of template names that were considered for this page, with the selected template prefixed by ``*``."
         }
     )
     top_database: callable = field(
-        metadata={"help": "Callable to render the top_database slot"}
+        metadata={
+            "help": "Async callable that renders the ``top_database`` plugin slot for this database and returns HTML."
+        }
     )
 
 
@@ -326,7 +346,9 @@ class QueryContext(Context):
     database: str = field(metadata={"help": "The name of the database being queried"})
     database_color: str = field(metadata={"help": "The color of the database"})
     query: dict = field(
-        metadata={"help": "The SQL query object containing the `sql` string"}
+        metadata={
+            "help": "Dictionary describing the SQL query being executed, with ``sql`` and ``params`` keys."
+        }
     )
     stored_query: str = field(
         metadata={"help": "The name of the stored query if this is a stored query"}
@@ -343,7 +365,9 @@ class QueryContext(Context):
         }
     )
     metadata: dict = field(
-        metadata={"help": "Metadata about the database or the stored query"}
+        metadata={
+            "help": "Metadata dictionary for the database or stored query. Stored query metadata may include options such as ``hide_sql``, ``on_success_message`` and ``on_error_redirect``."
+        }
     )
     db_is_immutable: bool = field(
         metadata={"help": "Boolean indicating if this database is immutable"}
@@ -369,24 +393,42 @@ class QueryContext(Context):
     )
     tables: list = field(
         metadata={
-            "help": "List of table objects in the database. Each item includes a ``count_truncated`` key that is true if ``count`` is a capped lower bound rather than an exact total."
+            "help": "List of table dictionaries in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` keys. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total."
         }
     )
     named_parameter_values: dict = field(
-        metadata={"help": "Dictionary of parameter names/values"}
+        metadata={
+            "help": "Dictionary of named SQL parameter values, keyed by parameter name without the leading ``:``."
+        }
     )
     edit_sql_url: str = field(
         metadata={"help": "URL to edit the SQL for a stored query"}
     )
-    display_rows: list = field(metadata={"help": "List of result rows to display"})
-    columns: list = field(metadata={"help": "List of column names"})
-    renderers: dict = field(metadata={"help": "Dictionary of renderer name to URL"})
+    display_rows: list = field(
+        metadata={
+            "help": "List of result rows formatted for HTML display. Each row is a list of rendered cell values in the same order as ``columns``."
+        }
+    )
+    columns: list = field(
+        metadata={
+            "help": "List of result column names in the order they appear in ``display_rows`` and ``rows``."
+        }
+    )
+    renderers: dict = field(
+        metadata={
+            "help": "Dictionary mapping output format names such as ``json`` to URLs for this query in that format."
+        }
+    )
     url_csv: str = field(metadata={"help": "URL for CSV export"})
     show_hide_hidden: str = field(
-        metadata={"help": "Hidden input field for the _show_sql parameter"}
+        metadata={
+            "help": "Rendered hidden ``<input>`` HTML preserving the current ``_hide_sql`` or ``_show_sql`` state."
+        }
     )
     table_columns: dict = field(
-        metadata={"help": "Dictionary of table name to list of column names"}
+        metadata={
+            "help": "Dictionary mapping table names to lists of column names, used to power SQL autocomplete."
+        }
     )
     alternate_url_json: str = field(
         metadata={"help": "URL for alternate JSON version of this page"}
@@ -394,18 +436,22 @@ class QueryContext(Context):
     # TODO: refactor this to somewhere else, probably ds.render_template()
     select_templates: list = field(
         metadata={
-            "help": "List of templates that were considered for rendering this page"
+            "help": "List of template names that were considered for this page, with the selected template prefixed by ``*``."
         }
     )
     top_query: callable = field(
-        metadata={"help": "Callable to render the top_query slot"}
+        metadata={
+            "help": "Async callable that renders the ``top_query`` plugin slot for this query and returns HTML."
+        }
     )
     top_stored_query: callable = field(
-        metadata={"help": "Callable to render the top_stored_query slot"}
+        metadata={
+            "help": "Async callable that renders the ``top_stored_query`` plugin slot for stored queries and returns HTML."
+        }
     )
     query_actions: callable = field(
         metadata={
-            "help": "Callable returning a list of links for the query action menu"
+            "help": 'Async callable returning action items for the query menu. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions` and :ref:`plugin_hook_query_actions`.'
         }
     )
 
diff --git a/datasette/views/row.py b/datasette/views/row.py
index e7472773..7802f45e 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -50,7 +50,7 @@ class RowContext(Context):
     )
     rows: list = field(
         metadata={
-            "help": "The rows for this page, as a list of dictionaries mapping column name to value"
+            "help": "A single-item list containing this row as a dictionary mapping column name to raw value."
         }
     )
     primary_key_values: list = field(
@@ -62,48 +62,58 @@ class RowContext(Context):
         }
     )
     display_columns: list = field(
-        metadata={"help": "Column objects formatted for the HTML table display"}
+        metadata={
+            "help": "Column metadata used by the HTML table display. Each item includes ``name``, ``sortable``, ``is_pk``, ``type``, ``notnull``, ``description``, ``column_type`` and ``column_type_config`` keys."
+        }
     )
     display_rows: list = field(
-        metadata={"help": "Row data formatted for the HTML table display"}
+        metadata={
+            "help": "Rows formatted for the HTML table display. Each row is iterable and contains cell dictionaries with ``column``, ``value``, ``raw`` and ``value_type`` keys."
+        }
     )
     custom_table_templates: list = field(
         metadata={
-            "help": "Custom template names that were considered for displaying this table"
+            "help": "Custom template names that were considered for displaying this row's table, in lookup order."
         }
     )
     row_actions: list = field(
-        metadata={"help": "Row actions made available by plugin hooks"}
-    )
-    row_mutation_ui: bool = field(
         metadata={
-            "help": "True if the row edit/delete JavaScript UI should be enabled"
+            "help": 'Row actions made available by core and plugin hooks. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions` and :ref:`plugin_hook_row_actions`.'
         }
     )
+    row_mutation_ui: bool = field(
+        metadata={"help": "True if the row edit/delete JavaScript UI should be enabled"}
+    )
     table_page_data: dict = field(
-        metadata={"help": "JSON data used by JavaScript on the row page"}
+        metadata={
+            "help": "JSON data used by JavaScript on the row page. Includes ``database``, ``table`` and ``tableUrl``, plus optional ``foreignKeys`` mapping column names to autocomplete URLs."
+        }
     )
     top_row: callable = field(
-        metadata={"help": "Async function rendering the top_row plugin slot"}
+        metadata={
+            "help": "Async callable that renders the ``top_row`` plugin slot for this row and returns HTML."
+        }
     )
     renderers: dict = field(
         metadata={
-            "help": "Dictionary mapping output format names (e.g. json) to their URLs for this page"
+            "help": "Dictionary mapping output format names such as ``json`` to URLs for this row in that format."
         }
     )
     url_csv: str = field(metadata={"help": "URL for the CSV export of this page"})
     url_csv_path: str = field(metadata={"help": "Path portion of the CSV export URL"})
     url_csv_hidden_args: list = field(
         metadata={
-            "help": "(name, value) pairs for hidden form fields used by the CSV export form"
+            "help": "List of ``(name, value)`` pairs for hidden form fields used by the CSV export form, preserving current options while forcing ``_size=max``."
         }
     )
     settings: dict = field(
-        metadata={"help": "Dictionary of Datasette's current settings"}
+        metadata={
+            "help": "Dictionary of Datasette's current settings, keyed by setting name."
+        }
     )
     select_templates: list = field(
         metadata={
-            "help": "List of template names that were considered for this page, the one used marked with an asterisk"
+            "help": "List of template names that were considered for this page, with the selected template prefixed by ``*``."
         }
     )
     alternate_url_json: str = field(
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 38a69f5f..4b6899b2 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -120,25 +120,27 @@ class TableContext(Context):
     )
     rows: list = field(
         metadata={
-            "help": "The rows for this page, as a list of dictionaries mapping column name to value"
+            "help": "The rows for this page, as a list of dictionaries mapping column name to raw value."
         }
     )
     filter_columns: list = field(
-        metadata={"help": "List of columns offered by the filter interface"}
+        metadata={
+            "help": "List of column names offered by the filter interface, including currently displayed columns and any hidden columns that can still be filtered."
+        }
     )
     supports_search: bool = field(
         metadata={"help": "True if this table has full-text search configured"}
     )
     extra_wheres_for_ui: list = field(
         metadata={
-            "help": "Extra where clauses from ?_where=, with links to remove them"
+            "help": "Extra where clauses from ``?_where=`` for display in the UI. Each item has ``text`` for the SQL fragment and ``remove_url`` for a URL that removes that fragment."
         }
     )
     url_csv: str = field(metadata={"help": "URL for the CSV export of this page"})
     url_csv_path: str = field(metadata={"help": "Path portion of the CSV export URL"})
     url_csv_hidden_args: list = field(
         metadata={
-            "help": "(name, value) pairs for hidden form fields used by the CSV export form"
+            "help": "List of ``(name, value)`` pairs for hidden form fields used by the CSV export form, preserving current filters while forcing ``_size=max``."
         }
     )
     sort: str = field(metadata={"help": "Column the page is sorted by, or None"})
@@ -147,19 +149,23 @@ class TableContext(Context):
     )
     append_querystring: callable = field(
         metadata={
-            "help": "Function that appends additional querystring arguments to a URL"
+            "help": "Function ``append_querystring(url, querystring)`` that appends additional query string arguments to a URL, using ``?`` or ``&`` as appropriate."
         }
     )
     path_with_replaced_args: callable = field(
         metadata={
-            "help": "Function for building the current path with modified querystring arguments"
+            "help": "Function for building the current path with modified query string arguments. Pass the current ``request`` and a dictionary of argument names to replacement values, using ``None`` to remove an argument."
         }
     )
     fix_path: callable = field(
-        metadata={"help": "Function that applies the base_url prefix to a path"}
+        metadata={
+            "help": "Function that applies the configured ``base_url`` prefix to a path."
+        }
     )
     settings: dict = field(
-        metadata={"help": "Dictionary of Datasette's current settings"}
+        metadata={
+            "help": "Dictionary of Datasette's current settings, keyed by setting name."
+        }
     )
     alternate_url_json: str = field(
         metadata={"help": "URL for the JSON version of this page"}
@@ -184,14 +190,18 @@ class TableContext(Context):
     )
     select_templates: list = field(
         metadata={
-            "help": "List of template names that were considered for this page, the one used marked with an asterisk"
+            "help": "List of template names that were considered for this page, with the selected template prefixed by ``*``."
         }
     )
     top_table: callable = field(
-        metadata={"help": "Async function rendering the top_table plugin slot"}
+        metadata={
+            "help": "Async callable that renders the ``top_table`` plugin slot for this table or view and returns HTML."
+        }
     )
     table_page_data: dict = field(
-        metadata={"help": "JSON data used by JavaScript on the table page"}
+        metadata={
+            "help": "JSON data used by JavaScript on the table page. Includes ``database``, ``table`` and ``tableUrl``, plus optional ``foreignKeys`` mapping column names to autocomplete URLs, optional ``insertRow`` data and optional ``alterTable`` data."
+        }
     )
 
 
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index f688433d..db659c80 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -98,7 +98,7 @@ class QueryExtraContext:
 
 
 class CountSqlExtra(Extra):
-    description = "SQL query used to calculate the total count"
+    description = "SQL query string used to calculate the total count for the current table view, including active filters."
     example = ExtraExample("/fixtures/facetable.json?_size=0&_extra=count_sql")
     scopes = {ExtraScope.TABLE}
 
@@ -165,7 +165,7 @@ class FacetInstancesProvider(Provider):
 
 
 class FacetResultsExtra(Extra):
-    description = "Results of facets calculated against this data"
+    description = "Results of facets calculated against this data. A dictionary with ``results`` and ``timed_out`` keys: ``results`` maps facet names to facet dictionaries with ``name``, ``type``, ``results`` and URL keys, and each facet result item includes ``value``, ``label``, ``count`` and ``toggle_url``."
     example = ExtraExample(
         value={
             "results": {
@@ -214,7 +214,9 @@ class FacetResultsExtra(Extra):
 
 
 class FacetsTimedOutExtra(Extra):
-    description = "Facet calculations that timed out"
+    description = (
+        "List of names of facet calculations that exceeded the facet time limit."
+    )
     example = ExtraExample(
         "/fixtures/facetable.json?_facet=state&_extra=facets_timed_out",
         note=(
@@ -230,7 +232,7 @@ class FacetsTimedOutExtra(Extra):
 
 
 class SuggestedFacetsExtra(Extra):
-    description = "Suggestions for facets that might return interesting results"
+    description = "Suggestions for facets that might return interesting results. Each item is a dictionary with ``name`` and ``toggle_url`` keys, and may include extra keys such as ``type`` or ``label`` depending on the facet class."
     example = ExtraExample(
         value=[
             {
@@ -301,7 +303,7 @@ class NextUrlExtra(Extra):
 
 
 class ColumnsExtra(Extra):
-    description = "Column names returned by this query"
+    description = "List of column names returned by this table, row or query."
     example = ExtraExample("/fixtures/facetable.json?_extra=columns")
     examples = {
         ExtraScope.ROW: ExtraExample(
@@ -318,7 +320,7 @@ class ColumnsExtra(Extra):
 
 
 class AllColumnsExtra(Extra):
-    description = "All columns in the table, regardless of _col/_nocol filtering"
+    description = "List of all column names in the table, regardless of ``_col=`` or ``_nocol=`` filtering."
     example = ExtraExample("/fixtures/facetable.json?_col=pk&_extra=all_columns")
     scopes = {ExtraScope.TABLE}
 
@@ -327,7 +329,7 @@ class AllColumnsExtra(Extra):
 
 
 class PrimaryKeysExtra(Extra):
-    description = "Primary keys for this table"
+    description = "List of primary key column names for this table, or an empty list if the table has no explicit primary key."
     example = ExtraExample("/fixtures/facetable.json?_extra=primary_keys")
     examples = {
         ExtraScope.ROW: ExtraExample(
@@ -341,7 +343,7 @@ class PrimaryKeysExtra(Extra):
 
 
 class ActionsExtra(Extra):
-    description = "Table or view actions made available by plugin hooks"
+    description = 'Async callable returning table or view actions made available by core and plugin hooks. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions`, :ref:`plugin_hook_table_actions` and :ref:`plugin_hook_view_actions`.'
     scopes = {ExtraScope.TABLE}
     # Returns an async function for the HTML templates - not JSON serializable
     public = False
@@ -421,7 +423,7 @@ class IsViewExtra(Extra):
 
 
 class DebugExtra(Extra):
-    description = "Extra debug information"
+    description = "Extra debug information dictionary. This is intended for development only and its shape is not part of the stable template contract."
     docs_note = (
         "The contents of this block are not a stable part of the Datasette "
         "API and may change without warning."
@@ -457,7 +459,7 @@ class DebugExtra(Extra):
 
 
 class RequestExtra(Extra):
-    description = "Full information about the request"
+    description = "Dictionary with request details: ``url``, ``path``, ``full_path``, ``host`` and ``args`` where ``args`` maps query string parameter names to their values."
     example = ExtraExample("/fixtures/facetable.json?_extra=request")
     examples = {
         ExtraScope.ROW: ExtraExample(
@@ -501,7 +503,7 @@ class DisplayColumnsAndRowsProvider(Provider):
 
 
 class DisplayColumnsExtra(Extra):
-    description = "Column metadata used by the HTML table display"
+    description = "Column metadata used by the HTML table display. Each item includes ``name``, ``sortable``, ``is_pk``, ``type``, ``notnull``, ``description``, ``column_type`` and ``column_type_config`` keys."
     example = ExtraExample(
         value=[
             {
@@ -531,7 +533,7 @@ class DisplayColumnsExtra(Extra):
 
 
 class DisplayRowsExtra(Extra):
-    description = "Row data formatted for the HTML table display"
+    description = "Rows formatted for the HTML table display. Each row is iterable and contains cell dictionaries with ``column``, ``value``, ``raw`` and ``value_type`` keys; table pages may also provide ``pk_path``, ``row_path`` and ``row_label`` attributes on each row object."
     scopes = {ExtraScope.TABLE}
     # Contains markupsafe/sqlite3.Row values - not JSON serializable
     public = False
@@ -640,7 +642,7 @@ class RenderCellExtra(Extra):
 
 
 class QueryExtra(Extra):
-    description = "Details of the underlying SQL query"
+    description = "Details of the underlying SQL query as a dictionary with ``sql`` and ``params`` keys."
     example = ExtraExample("/fixtures/facetable.json?_size=1&_extra=query")
     examples = {
         ExtraScope.ROW: ExtraExample(
@@ -661,7 +663,7 @@ class QueryExtra(Extra):
 
 
 class ColumnTypesExtra(Extra):
-    description = "Column type assignments for this table"
+    description = 'Column type assignments for this table. A dictionary mapping column names to ``{"type": type_name, "config": config}`` dictionaries.'
     docs_note = (
         "An empty object if no column types have been assigned. Column types "
         "can be assigned in :ref:`configuration "
@@ -700,7 +702,7 @@ class ColumnTypesExtra(Extra):
 
 
 class SetColumnTypeUiExtra(Extra):
-    description = "Information needed to build an interface for assigning column types"
+    description = "Information needed to build an interface for assigning column types, or ``None`` if unavailable. When present it has ``path`` and ``columns`` keys; ``columns`` maps column names to ``current`` and ``options`` values."
     docs_note = (
         "``null`` unless the current actor is allowed to use the :ref:`set "
         "column type API <TableSetColumnTypeView>` for this table."
@@ -784,7 +786,7 @@ class SetColumnTypeUiExtra(Extra):
 
 
 class MetadataExtra(Extra):
-    description = "Metadata about the table, database or stored query"
+    description = "Metadata dictionary for the table, database or stored query. Table and row metadata include a ``columns`` dictionary mapping column names to descriptions; stored query metadata returns the stored query configuration."
     docs_note = "See :ref:`metadata` for how to attach metadata to tables."
     example = ExtraExample(
         "/fixtures/facetable.json?_extra=metadata",
@@ -891,7 +893,7 @@ class DatabaseColorExtra(Extra):
 
 
 class FormHiddenArgsExtra(Extra):
-    description = "Hidden form arguments used by the HTML table interface"
+    description = "List of ``(name, value)`` pairs for hidden form fields used by the HTML table interface to preserve current query string options."
     example = ExtraExample(
         "/fixtures/facetable.json?_facet=state&_size=1&_extra=form_hidden_args"
     )
@@ -911,7 +913,7 @@ class FormHiddenArgsExtra(Extra):
 
 
 class FiltersExtra(Extra):
-    description = "Filters object used by the HTML table interface"
+    description = "``Filters`` object used by the HTML table interface. Useful methods include ``filters.human_description_en()``; this is not JSON serializable."
     scopes = {ExtraScope.TABLE}
     # Returns a Filters instance for the HTML templates - not JSON serializable
     public = False
@@ -921,7 +923,7 @@ class FiltersExtra(Extra):
 
 
 class CustomTableTemplatesExtra(Extra):
-    description = "Custom template names considered for this table"
+    description = "List of custom template names considered for rendering table rows, in lookup order."
     docs_note = (
         "The first template in this list that exists will be used to render "
         "the table on the HTML version of this page. See "
@@ -939,7 +941,7 @@ class CustomTableTemplatesExtra(Extra):
 
 
 class SortedFacetResultsExtra(Extra):
-    description = "Facet results sorted for display"
+    description = "Facet result dictionaries sorted for display. Each item has the same shape as an entry from ``facet_results['results']``."
     docs_note = (
         "The same data as ``facet_results``, as a list in the order used by "
         "the HTML interface: facets from :ref:`facet configuration "
@@ -1001,7 +1003,7 @@ class ViewDefinitionExtra(Extra):
 
 
 class RenderersExtra(Extra):
-    description = "Alternative output renderers available for this table"
+    description = "Dictionary mapping output format names such as ``json`` or plugin-provided renderer names to URLs for this data in that format."
     example = ExtraExample(
         "/fixtures/facetable.json?_extra=renderers",
         note=(
@@ -1068,7 +1070,7 @@ class PrivateExtra(Extra):
 
 
 class ExpandableColumnsExtra(Extra):
-    description = "Foreign key columns that can be expanded with labels"
+    description = "List of foreign key columns that can be expanded with labels. Each item is a ``(foreign_key, label_column)`` pair where ``foreign_key`` is the SQLite foreign key dictionary and ``label_column`` is the label column in the referenced table, or ``None``."
     docs_note = "See :ref:`expand_foreign_keys` for how to expand these labels."
     example = ExtraExample(
         "/fixtures/facetable.json?_extra=expandable_columns",
@@ -1090,7 +1092,7 @@ class ExpandableColumnsExtra(Extra):
 
 
 class ForeignKeyTablesExtra(Extra):
-    description = "Tables that link to this row using foreign keys"
+    description = "List of tables that link to this row using foreign keys. Each item includes the foreign key fields plus ``count`` for matching rows and ``link`` for the filtered table URL."
     example = ExtraExample(
         "/fixtures/simple_primary_key/1.json?_extra=foreign_key_tables",
         note=(
@@ -1108,7 +1110,7 @@ class ForeignKeyTablesExtra(Extra):
 
 
 class ExtrasExtra(Extra):
-    description = "List of ?_extra= blocks that can be used on this page"
+    description = "List of ``?_extra=`` blocks that can be used on this page. Each item has ``name``, ``description``, ``toggle_url`` and ``selected`` keys."
     example = ExtraExample(
         value=[
             {
diff --git a/docs/template_context.rst b/docs/template_context.rst
index dd4524f0..b09fc3a1 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -95,19 +95,19 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
     URL for the alternate JSON version of this page
 
 ``attached_databases`` - ``list``
-    List of names of attached databases
+    List of names of databases attached to this SQLite connection. This is only populated for the special ``/_memory`` database when Datasette is started with ``--crossdb`` for :ref:`cross_database_queries`.
 
 ``database`` - ``str``
     The name of the database
 
 ``database_actions`` - ``callable``
-    Callable returning list of action links for the database menu
+    Async callable returning action items for the database menu. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions` and :ref:`plugin_hook_database_actions`.
 
 ``database_color`` - ``str``
     The color assigned to the database
 
 ``database_page_data`` - ``dict``
-    JSON data used by JavaScript on the database page
+    JSON data used by JavaScript on the database page. Currently ``{}`` or ``{"createTable": {...}}`` where ``createTable`` includes ``path``, ``foreignKeyTargetsPath``, ``databaseName``, ``columnTypes``, ``defaultExpressions`` and optional ``customColumnTypes``.
 
 ``editable`` - ``bool``
     Boolean indicating if the database is editable
@@ -116,7 +116,7 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
     Count of hidden tables
 
 ``metadata`` - ``dict``
-    Metadata for the database
+    Metadata dictionary for the database, such as ``title``, ``description``, ``license`` and ``source`` values from Datasette metadata.
 
 ``path`` - ``str``
     The URL path to this database
@@ -125,7 +125,7 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
     Boolean indicating if this is a private database
 
 ``queries`` - ``list``
-    List of stored query objects
+    List of stored query objects. Each has attributes including ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``is_write`` and ``private``.
 
 ``queries_count`` - ``int``
     Count of visible stored queries
@@ -134,7 +134,7 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
     Boolean indicating if more stored queries are available
 
 ``select_templates`` - ``list``
-    List of templates that were considered for rendering this page
+    List of template names that were considered for this page, with the selected template prefixed by ``*``.
 
 ``show_hidden`` - ``str``
     Value of _show_hidden query parameter
@@ -143,16 +143,16 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
     The size of the database in bytes
 
 ``table_columns`` - ``dict``
-    Dictionary mapping table names to their column lists
+    Dictionary mapping table names to lists of column names, used to power SQL autocomplete.
 
 ``tables`` - ``list``
-    List of table objects in the database. Each item includes a ``count_truncated`` key that is true if ``count`` is a capped lower bound rather than an exact total.
+    List of table dictionaries in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` keys. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total.
 
 ``top_database`` - ``callable``
-    Callable to render the top_database slot
+    Async callable that renders the ``top_database`` plugin slot for this database and returns HTML.
 
 ``views`` - ``list``
-    List of view objects in the database
+    List of SQLite view dictionaries. Each item has ``name`` and ``private`` keys.
 
 Query page
 ----------
@@ -166,7 +166,7 @@ The page for arbitrary SQL queries (/database/-/query?sql=...) and stored querie
     URL for alternate JSON version of this page
 
 ``columns`` - ``list``
-    List of column names
+    List of result column names in the order they appear in ``display_rows`` and ``rows``.
 
 ``database`` - ``str``
     The name of the database being queried
@@ -178,7 +178,7 @@ The page for arbitrary SQL queries (/database/-/query?sql=...) and stored querie
     Boolean indicating if this database is immutable
 
 ``display_rows`` - ``list``
-    List of result rows to display
+    List of result rows formatted for HTML display. Each row is a list of rendered cell values in the same order as ``columns``.
 
 ``edit_sql_url`` - ``str``
     URL to edit the SQL for a stored query
@@ -193,31 +193,31 @@ The page for arbitrary SQL queries (/database/-/query?sql=...) and stored querie
     Boolean indicating if the SQL should be hidden
 
 ``metadata`` - ``dict``
-    Metadata about the database or the stored query
+    Metadata dictionary for the database or stored query. Stored query metadata may include options such as ``hide_sql``, ``on_success_message`` and ``on_error_redirect``.
 
 ``named_parameter_values`` - ``dict``
-    Dictionary of parameter names/values
+    Dictionary of named SQL parameter values, keyed by parameter name without the leading ``:``.
 
 ``private`` - ``bool``
     Boolean indicating if this is a private database
 
 ``query`` - ``dict``
-    The SQL query object containing the `sql` string
+    Dictionary describing the SQL query being executed, with ``sql`` and ``params`` keys.
 
 ``query_actions`` - ``callable``
-    Callable returning a list of links for the query action menu
+    Async callable returning action items for the query menu. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions` and :ref:`plugin_hook_query_actions`.
 
 ``renderers`` - ``dict``
-    Dictionary of renderer name to URL
+    Dictionary mapping output format names such as ``json`` to URLs for this query in that format.
 
 ``save_query_url`` - ``str``
     URL to save the current arbitrary SQL as a query
 
 ``select_templates`` - ``list``
-    List of templates that were considered for rendering this page
+    List of template names that were considered for this page, with the selected template prefixed by ``*``.
 
 ``show_hide_hidden`` - ``str``
-    Hidden input field for the _show_sql parameter
+    Rendered hidden ``<input>`` HTML preserving the current ``_hide_sql`` or ``_show_sql`` state.
 
 ``show_hide_link`` - ``str``
     The URL to toggle showing/hiding the SQL
@@ -232,16 +232,16 @@ The page for arbitrary SQL queries (/database/-/query?sql=...) and stored querie
     Boolean indicating if this is a stored query that allows writes
 
 ``table_columns`` - ``dict``
-    Dictionary of table name to list of column names
+    Dictionary mapping table names to lists of column names, used to power SQL autocomplete.
 
 ``tables`` - ``list``
-    List of table objects in the database. Each item includes a ``count_truncated`` key that is true if ``count`` is a capped lower bound rather than an exact total.
+    List of table dictionaries in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` keys. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total.
 
 ``top_query`` - ``callable``
-    Callable to render the top_query slot
+    Async callable that renders the ``top_query`` plugin slot for this query and returns HTML.
 
 ``top_stored_query`` - ``callable``
-    Callable to render the top_stored_query slot
+    Async callable that renders the ``top_stored_query`` plugin slot for stored queries and returns HTML.
 
 ``url_csv`` - ``str``
     URL for CSV export
@@ -254,10 +254,10 @@ The page showing the rows in a table or SQL view, e.g. /fixtures/facetable. Rend
 Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
 
 ``actions`` - ``callable``
-    Table or view actions made available by plugin hooks
+    Async callable returning table or view actions made available by core and plugin hooks. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions`, :ref:`plugin_hook_table_actions` and :ref:`plugin_hook_view_actions`.
 
 ``all_columns`` - ``list``
-    All columns in the table, regardless of _col/_nocol filtering
+    List of all column names in the table, regardless of ``_col=`` or ``_nocol=`` filtering.
 
 ``allow_execute_sql`` - ``bool``
     True if the current actor can execute custom SQL against this database
@@ -266,22 +266,22 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     URL for the JSON version of this page
 
 ``append_querystring`` - ``callable``
-    Function that appends additional querystring arguments to a URL
+    Function ``append_querystring(url, querystring)`` that appends additional query string arguments to a URL, using ``?`` or ``&`` as appropriate.
 
 ``columns`` - ``list``
-    Column names returned by this query
+    List of column names returned by this table, row or query.
 
 ``count`` - ``int``
     Total count of rows matching these filters
 
 ``count_sql`` - ``str``
-    SQL query used to calculate the total count
+    SQL query string used to calculate the total count for the current table view, including active filters.
 
 ``count_truncated`` - ``bool``
     True if ``count`` is a capped lower bound rather than an exact total, because Datasette stopped counting after its configured row-count limit.
 
 ``custom_table_templates`` - ``list``
-    Custom template names considered for this table
+    List of custom template names considered for rendering table rows, in lookup order.
 
 ``database`` - ``str``
     Database name
@@ -293,34 +293,34 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     The string "true" or "false" reflecting the allow_facet setting
 
 ``display_columns`` - ``list``
-    Column metadata used by the HTML table display
+    Column metadata used by the HTML table display. Each item includes ``name``, ``sortable``, ``is_pk``, ``type``, ``notnull``, ``description``, ``column_type`` and ``column_type_config`` keys.
 
 ``display_rows`` - ``list``
-    Row data formatted for the HTML table display
+    Rows formatted for the HTML table display. Each row is iterable and contains cell dictionaries with ``column``, ``value``, ``raw`` and ``value_type`` keys; table pages may also provide ``pk_path``, ``row_path`` and ``row_label`` attributes on each row object.
 
 ``expandable_columns`` - ``list``
-    Foreign key columns that can be expanded with labels
+    List of foreign key columns that can be expanded with labels. Each item is a ``(foreign_key, label_column)`` pair where ``foreign_key`` is the SQLite foreign key dictionary and ``label_column`` is the label column in the referenced table, or ``None``.
 
 ``extra_wheres_for_ui`` - ``list``
-    Extra where clauses from ?_where=, with links to remove them
+    Extra where clauses from ``?_where=`` for display in the UI. Each item has ``text`` for the SQL fragment and ``remove_url`` for a URL that removes that fragment.
 
 ``facet_results`` - ``dict``
-    Results of facets calculated against this data
+    Results of facets calculated against this data. A dictionary with ``results`` and ``timed_out`` keys: ``results`` maps facet names to facet dictionaries with ``name``, ``type``, ``results`` and URL keys, and each facet result item includes ``value``, ``label``, ``count`` and ``toggle_url``.
 
 ``facets_timed_out`` - ``list``
-    Facet calculations that timed out
+    List of names of facet calculations that exceeded the facet time limit.
 
 ``filter_columns`` - ``list``
-    List of columns offered by the filter interface
+    List of column names offered by the filter interface, including currently displayed columns and any hidden columns that can still be filtered.
 
 ``filters`` - ``Filters``
-    Filters object used by the HTML table interface
+    ``Filters`` object used by the HTML table interface. Useful methods include ``filters.human_description_en()``; this is not JSON serializable.
 
 ``fix_path`` - ``callable``
-    Function that applies the base_url prefix to a path
+    Function that applies the configured ``base_url`` prefix to a path.
 
 ``form_hidden_args`` - ``list``
-    Hidden form arguments used by the HTML table interface
+    List of ``(name, value)`` pairs for hidden form fields used by the HTML table interface to preserve current query string options.
 
 ``human_description_en`` - ``str``
     Human-readable description of the filters
@@ -332,7 +332,7 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     Whether this resource is a view instead of a table
 
 ``metadata`` - ``dict``
-    Metadata about the table, database or stored query
+    Metadata dictionary for the table, database or stored query. Table and row metadata include a ``columns`` dictionary mapping column names to descriptions; stored query metadata returns the stored query configuration.
 
 ``next`` - ``str``
     Pagination token for the next page, or None
@@ -344,34 +344,34 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     True if the data for this page was retrieved without errors
 
 ``path_with_replaced_args`` - ``callable``
-    Function for building the current path with modified querystring arguments
+    Function for building the current path with modified query string arguments. Pass the current ``request`` and a dictionary of argument names to replacement values, using ``None`` to remove an argument.
 
 ``primary_keys`` - ``list``
-    Primary keys for this table
+    List of primary key column names for this table, or an empty list if the table has no explicit primary key.
 
 ``private`` - ``bool``
     Whether this resource is private to the current actor
 
 ``query`` - ``dict``
-    Details of the underlying SQL query
+    Details of the underlying SQL query as a dictionary with ``sql`` and ``params`` keys.
 
 ``query_ms`` - ``float``
     Time taken by the SQL queries for this page, in milliseconds
 
 ``renderers`` - ``dict``
-    Alternative output renderers available for this table
+    Dictionary mapping output format names such as ``json`` or plugin-provided renderer names to URLs for this data in that format.
 
 ``rows`` - ``list``
-    The rows for this page, as a list of dictionaries mapping column name to value
+    The rows for this page, as a list of dictionaries mapping column name to raw value.
 
 ``select_templates`` - ``list``
-    List of template names that were considered for this page, the one used marked with an asterisk
+    List of template names that were considered for this page, with the selected template prefixed by ``*``.
 
 ``set_column_type_ui`` - ``dict``
-    Information needed to build an interface for assigning column types
+    Information needed to build an interface for assigning column types, or ``None`` if unavailable. When present it has ``path`` and ``columns`` keys; ``columns`` maps column names to ``current`` and ``options`` values.
 
 ``settings`` - ``dict``
-    Dictionary of Datasette's current settings
+    Dictionary of Datasette's current settings, keyed by setting name.
 
 ``sort`` - ``str``
     Column the page is sorted by, or None
@@ -380,10 +380,10 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     Column the page is sorted by in descending order, or None
 
 ``sorted_facet_results`` - ``list``
-    Facet results sorted for display
+    Facet result dictionaries sorted for display. Each item has the same shape as an entry from ``facet_results['results']``.
 
 ``suggested_facets`` - ``list``
-    Suggestions for facets that might return interesting results
+    Suggestions for facets that might return interesting results. Each item is a dictionary with ``name`` and ``toggle_url`` keys, and may include extra keys such as ``type`` or ``label`` depending on the facet class.
 
 ``supports_search`` - ``bool``
     True if this table has full-text search configured
@@ -395,16 +395,16 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     SQL definition for this table
 
 ``table_page_data`` - ``dict``
-    JSON data used by JavaScript on the table page
+    JSON data used by JavaScript on the table page. Includes ``database``, ``table`` and ``tableUrl``, plus optional ``foreignKeys`` mapping column names to autocomplete URLs, optional ``insertRow`` data and optional ``alterTable`` data.
 
 ``top_table`` - ``callable``
-    Async function rendering the top_table plugin slot
+    Async callable that renders the ``top_table`` plugin slot for this table or view and returns HTML.
 
 ``url_csv`` - ``str``
     URL for the CSV export of this page
 
 ``url_csv_hidden_args`` - ``list``
-    (name, value) pairs for hidden form fields used by the CSV export form
+    List of ``(name, value)`` pairs for hidden form fields used by the CSV export form, preserving current filters while forcing ``_size=max``.
 
 ``url_csv_path`` - ``str``
     Path portion of the CSV export URL
@@ -423,10 +423,10 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     URL for the JSON version of this page
 
 ``columns`` - ``list``
-    Column names returned by this query
+    List of column names returned by this table, row or query.
 
 ``custom_table_templates`` - ``list``
-    Custom template names that were considered for displaying this table
+    Custom template names that were considered for displaying this row's table, in lookup order.
 
 ``database`` - ``str``
     Database name
@@ -435,16 +435,16 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     Color assigned to the database
 
 ``display_columns`` - ``list``
-    Column objects formatted for the HTML table display
+    Column metadata used by the HTML table display. Each item includes ``name``, ``sortable``, ``is_pk``, ``type``, ``notnull``, ``description``, ``column_type`` and ``column_type_config`` keys.
 
 ``display_rows`` - ``list``
-    Row data formatted for the HTML table display
+    Rows formatted for the HTML table display. Each row is iterable and contains cell dictionaries with ``column``, ``value``, ``raw`` and ``value_type`` keys.
 
 ``foreign_key_tables`` - ``list``
-    Tables that link to this row using foreign keys
+    List of tables that link to this row using foreign keys. Each item includes the foreign key fields plus ``count`` for matching rows and ``link`` for the filtered table URL.
 
 ``metadata`` - ``dict``
-    Metadata about the table, database or stored query
+    Metadata dictionary for the table, database or stored query. Table and row metadata include a ``columns`` dictionary mapping column names to descriptions; stored query metadata returns the stored query configuration.
 
 ``ok`` - ``bool``
     True if the data for this page was retrieved without errors
@@ -453,7 +453,7 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     Values of the primary keys for this row, from the URL
 
 ``primary_keys`` - ``list``
-    Primary keys for this table
+    List of primary key column names for this table, or an empty list if the table has no explicit primary key.
 
 ``private`` - ``bool``
     Whether this resource is private to the current actor
@@ -462,37 +462,37 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     Time taken by the SQL queries for this page, in milliseconds
 
 ``renderers`` - ``dict``
-    Dictionary mapping output format names (e.g. json) to their URLs for this page
+    Dictionary mapping output format names such as ``json`` to URLs for this row in that format.
 
 ``row_actions`` - ``list``
-    Row actions made available by plugin hooks
+    Row actions made available by core and plugin hooks. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions` and :ref:`plugin_hook_row_actions`.
 
 ``row_mutation_ui`` - ``bool``
     True if the row edit/delete JavaScript UI should be enabled
 
 ``rows`` - ``list``
-    The rows for this page, as a list of dictionaries mapping column name to value
+    A single-item list containing this row as a dictionary mapping column name to raw value.
 
 ``select_templates`` - ``list``
-    List of template names that were considered for this page, the one used marked with an asterisk
+    List of template names that were considered for this page, with the selected template prefixed by ``*``.
 
 ``settings`` - ``dict``
-    Dictionary of Datasette's current settings
+    Dictionary of Datasette's current settings, keyed by setting name.
 
 ``table`` - ``str``
     Table name
 
 ``table_page_data`` - ``dict``
-    JSON data used by JavaScript on the row page
+    JSON data used by JavaScript on the row page. Includes ``database``, ``table`` and ``tableUrl``, plus optional ``foreignKeys`` mapping column names to autocomplete URLs.
 
 ``top_row`` - ``callable``
-    Async function rendering the top_row plugin slot
+    Async callable that renders the ``top_row`` plugin slot for this row and returns HTML.
 
 ``url_csv`` - ``str``
     URL for the CSV export of this page
 
 ``url_csv_hidden_args`` - ``list``
-    (name, value) pairs for hidden form fields used by the CSV export form
+    List of ``(name, value)`` pairs for hidden form fields used by the CSV export form, preserving current options while forcing ``_size=max``.
 
 ``url_csv_path`` - ``str``
     Path portion of the CSV export URL

From 2680e3c4bde392a5edbba4cd4d89db124fe79d66 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 07:32:37 -0700
Subject: [PATCH 273/386] Refresh JSON API extra descriptions

---
 docs/json_api.rst | 70 +++++++++++++++++++++++------------------------
 1 file changed, 35 insertions(+), 35 deletions(-)

diff --git a/docs/json_api.rst b/docs/json_api.rst
index b8632bc3..eca22fdc 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -267,7 +267,7 @@ The available table extras are listed below.
         15
 
 ``count_sql``
-    SQL query used to calculate the total count
+    SQL query string used to calculate the total count for the current table view, including active filters.
 
     ``GET /fixtures/facetable.json?_size=0&_extra=count_sql``
 
@@ -276,7 +276,7 @@ The available table extras are listed below.
         "select count(*) from facetable "
 
 ``facet_results``
-    Results of facets calculated against this data (May execute additional queries. See :ref:`facets` for details of how facets work.)
+    Results of facets calculated against this data. A dictionary with ``results`` and ``timed_out`` keys: ``results`` maps facet names to facet dictionaries with ``name``, ``type``, ``results`` and URL keys, and each facet result item includes ``value``, ``label``, ``count`` and ``toggle_url``. (May execute additional queries. See :ref:`facets` for details of how facets work.)
 
     Shape abbreviated from /fixtures/facetable.json?_facet=state&_extra=facet_results.
 
@@ -305,7 +305,7 @@ The available table extras are listed below.
         }
 
 ``facets_timed_out``
-    Facet calculations that timed out
+    List of names of facet calculations that exceeded the facet time limit.
 
     ``GET /fixtures/facetable.json?_facet=state&_extra=facets_timed_out``
 
@@ -316,7 +316,7 @@ The available table extras are listed below.
         []
 
 ``suggested_facets``
-    Suggestions for facets that might return interesting results (May execute additional queries. Suggestions are controlled by the :ref:`setting_suggest_facets` setting.)
+    Suggestions for facets that might return interesting results. Each item is a dictionary with ``name`` and ``toggle_url`` keys, and may include extra keys such as ``type`` or ``label`` depending on the facet class. (May execute additional queries. Suggestions are controlled by the :ref:`setting_suggest_facets` setting.)
 
     Shape abbreviated from /fixtures/facetable.json?_extra=suggested_facets.
 
@@ -350,7 +350,7 @@ The available table extras are listed below.
         "http://localhost/fixtures/facetable.json?_size=1&_extra=next_url&_next=1"
 
 ``columns``
-    Column names returned by this query
+    List of column names returned by this table, row or query.
 
     ``GET /fixtures/facetable.json?_extra=columns``
 
@@ -371,7 +371,7 @@ The available table extras are listed below.
         ]
 
 ``all_columns``
-    All columns in the table, regardless of _col/_nocol filtering
+    List of all column names in the table, regardless of ``_col=`` or ``_nocol=`` filtering.
 
     ``GET /fixtures/facetable.json?_col=pk&_extra=all_columns``
 
@@ -392,7 +392,7 @@ The available table extras are listed below.
         ]
 
 ``primary_keys``
-    Primary keys for this table
+    List of primary key column names for this table, or an empty list if the table has no explicit primary key.
 
     ``GET /fixtures/facetable.json?_extra=primary_keys``
 
@@ -403,7 +403,7 @@ The available table extras are listed below.
         ]
 
 ``display_columns``
-    Column metadata used by the HTML table display
+    Column metadata used by the HTML table display. Each item includes ``name``, ``sortable``, ``is_pk``, ``type``, ``notnull``, ``description``, ``column_type`` and ``column_type_config`` keys.
 
     Shape abbreviated from /fixtures/facetable.json?_size=1&_extra=display_columns.
 
@@ -456,7 +456,7 @@ The available table extras are listed below.
         }
 
 ``debug``
-    Extra debug information (The contents of this block are not a stable part of the Datasette API and may change without warning.)
+    Extra debug information dictionary. This is intended for development only and its shape is not part of the stable template contract. (The contents of this block are not a stable part of the Datasette API and may change without warning.)
 
     ``GET /fixtures/facetable.json?_extra=debug``
 
@@ -474,7 +474,7 @@ The available table extras are listed below.
         }
 
 ``request``
-    Full information about the request
+    Dictionary with request details: ``url``, ``path``, ``full_path``, ``host`` and ``args`` where ``args`` maps query string parameter names to their values.
 
     ``GET /fixtures/facetable.json?_extra=request``
 
@@ -493,7 +493,7 @@ The available table extras are listed below.
         }
 
 ``query``
-    Details of the underlying SQL query
+    Details of the underlying SQL query as a dictionary with ``sql`` and ``params`` keys.
 
     ``GET /fixtures/facetable.json?_size=1&_extra=query``
 
@@ -505,7 +505,7 @@ The available table extras are listed below.
         }
 
 ``column_types``
-    Column type assignments for this table (An empty object if no column types have been assigned. Column types can be assigned in :ref:`configuration <table_configuration_column_types>` or using the :ref:`set column type API <TableSetColumnTypeView>`.)
+    Column type assignments for this table. A dictionary mapping column names to ``{"type": type_name, "config": config}`` dictionaries. (An empty object if no column types have been assigned. Column types can be assigned in :ref:`configuration <table_configuration_column_types>` or using the :ref:`set column type API <TableSetColumnTypeView>`.)
 
     ``GET /fixtures/facetable.json?_size=0&_extra=column_types``
 
@@ -521,7 +521,7 @@ The available table extras are listed below.
         }
 
 ``set_column_type_ui``
-    Information needed to build an interface for assigning column types (``null`` unless the current actor is allowed to use the :ref:`set column type API <TableSetColumnTypeView>` for this table.)
+    Information needed to build an interface for assigning column types, or ``None`` if unavailable. When present it has ``path`` and ``columns`` keys; ``columns`` maps column names to ``current`` and ``options`` values. (``null`` unless the current actor is allowed to use the :ref:`set column type API <TableSetColumnTypeView>` for this table.)
 
     Shape abbreviated to two columns, as seen by an actor with ``set-column-type`` permission. ``current`` is the column type currently assigned to each column and ``options`` lists the types that could be assigned to it.
 
@@ -571,7 +571,7 @@ The available table extras are listed below.
         }
 
 ``metadata``
-    Metadata about the table, database or stored query (See :ref:`metadata` for how to attach metadata to tables.)
+    Metadata dictionary for the table, database or stored query. Table and row metadata include a ``columns`` dictionary mapping column names to descriptions; stored query metadata returns the stored query configuration. (See :ref:`metadata` for how to attach metadata to tables.)
 
     ``GET /fixtures/facetable.json?_extra=metadata``
 
@@ -587,7 +587,7 @@ The available table extras are listed below.
         }
 
 ``extras``
-    List of ?_extra= blocks that can be used on this page
+    List of ``?_extra=`` blocks that can be used on this page. Each item has ``name``, ``description``, ``toggle_url`` and ``selected`` keys.
 
     Shape abbreviated from /fixtures/facetable.json?_extra=extras - the full response lists every extra described on this page. ``toggle_url`` is the current URL with that extra added or removed, and ``selected`` is ``true`` for extras included in the current request.
 
@@ -636,7 +636,7 @@ The available table extras are listed below.
         "9403e5"
 
 ``renderers``
-    Alternative output renderers available for this table
+    Dictionary mapping output format names such as ``json`` or plugin-provided renderer names to URLs for this data in that format.
 
     ``GET /fixtures/facetable.json?_extra=renderers``
 
@@ -649,7 +649,7 @@ The available table extras are listed below.
         }
 
 ``custom_table_templates``
-    Custom template names considered for this table (The first template in this list that exists will be used to render the table on the HTML version of this page. See :ref:`customization_custom_templates`.)
+    List of custom template names considered for rendering table rows, in lookup order. (The first template in this list that exists will be used to render the table on the HTML version of this page. See :ref:`customization_custom_templates`.)
 
     ``GET /fixtures/facetable.json?_extra=custom_table_templates``
 
@@ -662,7 +662,7 @@ The available table extras are listed below.
         ]
 
 ``sorted_facet_results``
-    Facet results sorted for display (The same data as ``facet_results``, as a list in the order used by the HTML interface: facets from :ref:`facet configuration <facets_metadata>` first, then other facets ordered by their number of results.)
+    Facet result dictionaries sorted for display. Each item has the same shape as an entry from ``facet_results['results']``. (The same data as ``facet_results``, as a list in the order used by the HTML interface: facets from :ref:`facet configuration <facets_metadata>` first, then other facets ordered by their number of results.)
 
     ``GET /fixtures/facetable.json?_facet=state&_extra=sorted_facet_results``
 
@@ -738,7 +738,7 @@ The available table extras are listed below.
         false
 
 ``expandable_columns``
-    Foreign key columns that can be expanded with labels (See :ref:`expand_foreign_keys` for how to expand these labels.)
+    List of foreign key columns that can be expanded with labels. Each item is a ``(foreign_key, label_column)`` pair where ``foreign_key`` is the SQLite foreign key dictionary and ``label_column`` is the label column in the referenced table, or ``None``. (See :ref:`expand_foreign_keys` for how to expand these labels.)
 
     ``GET /fixtures/facetable.json?_extra=expandable_columns``
 
@@ -758,7 +758,7 @@ The available table extras are listed below.
         ]
 
 ``form_hidden_args``
-    Hidden form arguments used by the HTML table interface
+    List of ``(name, value)`` pairs for hidden form fields used by the HTML table interface to preserve current query string options.
 
     ``GET /fixtures/facetable.json?_facet=state&_size=1&_extra=form_hidden_args``
 
@@ -785,7 +785,7 @@ Row JSON responses
 The following extras are available for row JSON responses.
 
 ``columns``
-    Column names returned by this query
+    List of column names returned by this table, row or query.
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=columns``
 
@@ -797,7 +797,7 @@ The following extras are available for row JSON responses.
         ]
 
 ``primary_keys``
-    Primary keys for this table
+    List of primary key column names for this table, or an empty list if the table has no explicit primary key.
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=primary_keys``
 
@@ -829,7 +829,7 @@ The following extras are available for row JSON responses.
         }
 
 ``debug``
-    Extra debug information (The contents of this block are not a stable part of the Datasette API and may change without warning.)
+    Extra debug information dictionary. This is intended for development only and its shape is not part of the stable template contract. (The contents of this block are not a stable part of the Datasette API and may change without warning.)
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=debug``
 
@@ -858,7 +858,7 @@ The following extras are available for row JSON responses.
         }
 
 ``request``
-    Full information about the request
+    Dictionary with request details: ``url``, ``path``, ``full_path``, ``host`` and ``args`` where ``args`` maps query string parameter names to their values.
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=request``
 
@@ -877,7 +877,7 @@ The following extras are available for row JSON responses.
         }
 
 ``query``
-    Details of the underlying SQL query
+    Details of the underlying SQL query as a dictionary with ``sql`` and ``params`` keys.
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=query``
 
@@ -891,7 +891,7 @@ The following extras are available for row JSON responses.
         }
 
 ``column_types``
-    Column type assignments for this table (An empty object if no column types have been assigned. Column types can be assigned in :ref:`configuration <table_configuration_column_types>` or using the :ref:`set column type API <TableSetColumnTypeView>`.)
+    Column type assignments for this table. A dictionary mapping column names to ``{"type": type_name, "config": config}`` dictionaries. (An empty object if no column types have been assigned. Column types can be assigned in :ref:`configuration <table_configuration_column_types>` or using the :ref:`set column type API <TableSetColumnTypeView>`.)
 
     ``GET /fixtures/facetable/1.json?_extra=column_types``
 
@@ -907,7 +907,7 @@ The following extras are available for row JSON responses.
         }
 
 ``metadata``
-    Metadata about the table, database or stored query (See :ref:`metadata` for how to attach metadata to tables.)
+    Metadata dictionary for the table, database or stored query. Table and row metadata include a ``columns`` dictionary mapping column names to descriptions; stored query metadata returns the stored query configuration. (See :ref:`metadata` for how to attach metadata to tables.)
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=metadata``
 
@@ -920,7 +920,7 @@ The following extras are available for row JSON responses.
         }
 
 ``extras``
-    List of ?_extra= blocks that can be used on this page
+    List of ``?_extra=`` blocks that can be used on this page. Each item has ``name``, ``description``, ``toggle_url`` and ``selected`` keys.
 
     Shape abbreviated from /fixtures/facetable.json?_extra=extras - the full response lists every extra described on this page. ``toggle_url`` is the current URL with that extra added or removed, and ``selected`` is ``true`` for extras included in the current request.
 
@@ -978,7 +978,7 @@ The following extras are available for row JSON responses.
         false
 
 ``foreign_key_tables``
-    Tables that link to this row using foreign keys (May execute additional queries.)
+    List of tables that link to this row using foreign keys. Each item includes the foreign key fields plus ``count`` for matching rows and ``link`` for the filtered table URL. (May execute additional queries.)
 
     ``GET /fixtures/simple_primary_key/1.json?_extra=foreign_key_tables``
 
@@ -1030,7 +1030,7 @@ Query JSON responses
 The following extras are available for arbitrary SQL query responses and stored, named query responses.
 
 ``columns``
-    Column names returned by this query
+    List of column names returned by this table, row or query.
 
     ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=columns``
 
@@ -1061,7 +1061,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         }
 
 ``debug``
-    Extra debug information (The contents of this block are not a stable part of the Datasette API and may change without warning.)
+    Extra debug information dictionary. This is intended for development only and its shape is not part of the stable template contract. (The contents of this block are not a stable part of the Datasette API and may change without warning.)
 
     ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=debug``
 
@@ -1075,7 +1075,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         }
 
 ``request``
-    Full information about the request
+    Dictionary with request details: ``url``, ``path``, ``full_path``, ``host`` and ``args`` where ``args`` maps query string parameter names to their values.
 
     ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=request``
 
@@ -1097,7 +1097,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         }
 
 ``query``
-    Details of the underlying SQL query
+    Details of the underlying SQL query as a dictionary with ``sql`` and ``params`` keys.
 
     ``GET /fixtures/-/query.json?sql=select+1+as+one&_extra=query``
 
@@ -1120,7 +1120,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         }
 
 ``metadata``
-    Metadata about the table, database or stored query (See :ref:`metadata` for how to attach metadata to tables.)
+    Metadata dictionary for the table, database or stored query. Table and row metadata include a ``columns`` dictionary mapping column names to descriptions; stored query metadata returns the stored query configuration. (See :ref:`metadata` for how to attach metadata to tables.)
 
     ``GET /fixtures/neighborhood_search.json?text=town&_extra=metadata``
 
@@ -1151,7 +1151,7 @@ The following extras are available for arbitrary SQL query responses and stored,
         }
 
 ``extras``
-    List of ?_extra= blocks that can be used on this page
+    List of ``?_extra=`` blocks that can be used on this page. Each item has ``name``, ``description``, ``toggle_url`` and ``selected`` keys.
 
     Shape abbreviated from /fixtures/facetable.json?_extra=extras - the full response lists every extra described on this page. ``toggle_url`` is the current URL with that extra added or removed, and ``selected`` is ``true`` for extras included in the current request.
 

From 17ec88503ead421280c9fd8e3ac02d8f1c5a646f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 07:36:07 -0700
Subject: [PATCH 274/386] Document table mutation UI context

---
 datasette/views/table.py  | 10 ++++++++++
 docs/template_context.rst |  6 ++++++
 2 files changed, 16 insertions(+)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 4b6899b2..1e182937 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -203,6 +203,16 @@ class TableContext(Context):
             "help": "JSON data used by JavaScript on the table page. Includes ``database``, ``table`` and ``tableUrl``, plus optional ``foreignKeys`` mapping column names to autocomplete URLs, optional ``insertRow`` data and optional ``alterTable`` data."
         }
     )
+    table_insert_ui: dict = field(
+        metadata={
+            "help": "Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns`` and ``primaryKeys`` keys; each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``value_kind`` and ``column_type`` keys."
+        }
+    )
+    table_alter_ui: dict = field(
+        metadata={
+            "help": "Information needed to enable the alter table UI, or ``None`` if altering this table is not available to the current actor. When present it has ``path``, ``tableName``, ``columns``, ``primaryKeys``, ``columnTypes``, ``defaultExpressions`` and ``foreignKeyTargetsPath`` keys, plus optional ``customColumnTypes`` and ``dropPath`` keys."
+        }
+    )
 
 
 LINK_WITH_LABEL = (
diff --git a/docs/template_context.rst b/docs/template_context.rst
index b09fc3a1..12f656d0 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -391,9 +391,15 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
 ``table`` - ``str``
     Table name
 
+``table_alter_ui`` - ``dict``
+    Information needed to enable the alter table UI, or ``None`` if altering this table is not available to the current actor. When present it has ``path``, ``tableName``, ``columns``, ``primaryKeys``, ``columnTypes``, ``defaultExpressions`` and ``foreignKeyTargetsPath`` keys, plus optional ``customColumnTypes`` and ``dropPath`` keys.
+
 ``table_definition`` - ``str``
     SQL definition for this table
 
+``table_insert_ui`` - ``dict``
+    Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns`` and ``primaryKeys`` keys; each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``value_kind`` and ``column_type`` keys.
+
 ``table_page_data`` - ``dict``
     JSON data used by JavaScript on the table page. Includes ``database``, ``table`` and ``tableUrl``, plus optional ``foreignKeys`` mapping column names to autocomplete URLs, optional ``insertRow`` data and optional ``alterTable`` data.
 

From cda8f7bbefc63b440c2b4f7322717fbeb37df116 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 09:02:11 -0700
Subject: [PATCH 275/386] Remove DataView base class

---
 datasette/views/base.py | 242 -----------------------------------
 datasette/views/row.py  | 277 +++++++++++++++++++++++++++++++++++++++-
 2 files changed, 270 insertions(+), 249 deletions(-)

diff --git a/datasette/views/base.py b/datasette/views/base.py
index a3a207bd..30026f4b 100644
--- a/datasette/views/base.py
+++ b/datasette/views/base.py
@@ -1,32 +1,19 @@
-import asyncio
 import csv
-import dataclasses
 import hashlib
 import sys
-import textwrap
-import time
-import urllib
-from markupsafe import escape
 
-
-from datasette.database import QueryInterrupted
 from datasette.utils.asgi import Request
 from datasette.utils import (
     add_cors_headers,
-    await_me_maybe,
     EscapeHtmlWriter,
     InvalidSql,
     LimitedWriter,
-    call_with_supported_arguments,
     path_from_row_pks,
-    path_with_added_args,
-    path_with_removed_args,
     path_with_format,
     sqlite3,
 )
 from datasette.utils.asgi import (
     AsgiStream,
-    NotFound,
     Response,
     BadRequest,
 )
@@ -89,9 +76,6 @@ class View:
 class BaseView:
     ds = None
     has_json_alternate = True
-    # Set to a Context subclass to render a documented template context -
-    # keys not declared on the class are dropped before rendering
-    context_class = None
 
     def __init__(self, datasette):
         self.ds = datasette
@@ -173,11 +157,6 @@ class BaseView:
                     )
                 }
             )
-        if self.context_class is not None:
-            declared = {f.name for f in dataclasses.fields(self.context_class)}
-            template_context = self.context_class(
-                **{k: v for k, v in template_context.items() if k in declared}
-            )
         return Response.html(
             await self.ds.render_template(
                 template,
@@ -201,227 +180,6 @@ class BaseView:
         return view
 
 
-class DataView(BaseView):
-    name = ""
-
-    def redirect(self, request, path, forward_querystring=True, remove_args=None):
-        if request.query_string and "?" not in path and forward_querystring:
-            path = f"{path}?{request.query_string}"
-        if remove_args:
-            path = path_with_removed_args(request, remove_args, path=path)
-        r = Response.redirect(path)
-        r.headers["Link"] = f"<{path}>; rel=preload"
-        if self.ds.cors:
-            add_cors_headers(r.headers)
-        return r
-
-    async def data(self, request):
-        raise NotImplementedError
-
-    async def as_csv(self, request, database):
-        return await stream_csv(self.ds, self.data, request, database)
-
-    async def get(self, request):
-        db = await self.ds.resolve_database(request)
-        database = db.name
-        database_route = db.route
-
-        _format = request.url_vars["format"]
-        data_kwargs = {}
-
-        if _format == "csv":
-            return await self.as_csv(request, database_route)
-
-        if _format is None:
-            # HTML views default to expanding all foreign key labels
-            data_kwargs["default_labels"] = True
-
-        extra_template_data = {}
-        start = time.perf_counter()
-        status_code = None
-        templates = []
-        try:
-            response_or_template_contexts = await self.data(request, **data_kwargs)
-            if isinstance(response_or_template_contexts, Response):
-                return response_or_template_contexts
-            # If it has four items, it includes an HTTP status code
-            if len(response_or_template_contexts) == 4:
-                (
-                    data,
-                    extra_template_data,
-                    templates,
-                    status_code,
-                ) = response_or_template_contexts
-            else:
-                data, extra_template_data, templates = response_or_template_contexts
-        except QueryInterrupted as ex:
-            raise DatasetteError(
-                textwrap.dedent("""
-                <p>SQL query took too long. The time limit is controlled by the
-                <a href="https://docs.datasette.io/en/stable/settings.html#sql-time-limit-ms">sql_time_limit_ms</a>
-                configuration option.</p>
-                <textarea style="width: 90%">{}</textarea>
-                <script>
-                let ta = document.querySelector("textarea");
-                ta.style.height = ta.scrollHeight + "px";
-                </script>
-            """.format(escape(ex.sql))).strip(),
-                title="SQL Interrupted",
-                status=400,
-                message_is_html=True,
-            )
-        except (sqlite3.OperationalError, InvalidSql) as e:
-            raise DatasetteError(str(e), title="Invalid SQL", status=400)
-
-        except sqlite3.OperationalError as e:
-            raise DatasetteError(str(e))
-
-        except DatasetteError:
-            raise
-
-        end = time.perf_counter()
-        data["query_ms"] = (end - start) * 1000
-
-        # Special case for .jsono extension - redirect to _shape=objects
-        if _format == "jsono":
-            return self.redirect(
-                request,
-                path_with_added_args(
-                    request,
-                    {"_shape": "objects"},
-                    path=request.path.rsplit(".jsono", 1)[0] + ".json",
-                ),
-                forward_querystring=False,
-            )
-
-        if _format in self.ds.renderers.keys():
-            # Dispatch request to the correct output format renderer
-            # (CSV is not handled here due to streaming)
-            result = call_with_supported_arguments(
-                self.ds.renderers[_format][0],
-                datasette=self.ds,
-                columns=data.get("columns") or [],
-                rows=data.get("rows") or [],
-                sql=data.get("query", {}).get("sql", None),
-                query_name=data.get("query_name"),
-                database=database,
-                table=data.get("table"),
-                request=request,
-                view_name=self.name,
-                truncated=False,  # TODO: support this
-                error=data.get("error"),
-                # These will be deprecated in Datasette 1.0:
-                args=request.args,
-                data=data,
-            )
-            if asyncio.iscoroutine(result):
-                result = await result
-            if result is None:
-                raise NotFound("No data")
-            if isinstance(result, dict):
-                r = Response(
-                    body=result.get("body"),
-                    status=result.get("status_code", status_code or 200),
-                    content_type=result.get("content_type", "text/plain"),
-                    headers=result.get("headers"),
-                )
-            elif isinstance(result, Response):
-                r = result
-                if status_code is not None:
-                    # Over-ride the status code
-                    r.status = status_code
-            else:
-                assert False, f"{result} should be dict or Response"
-        else:
-            extras = {}
-            if callable(extra_template_data):
-                extras = extra_template_data()
-                if asyncio.iscoroutine(extras):
-                    extras = await extras
-            else:
-                extras = extra_template_data
-            url_labels_extra = {}
-            if data.get("expandable_columns"):
-                url_labels_extra = {"_labels": "on"}
-
-            renderers = {}
-            for key, (_, can_render) in self.ds.renderers.items():
-                it_can_render = call_with_supported_arguments(
-                    can_render,
-                    datasette=self.ds,
-                    columns=data.get("columns") or [],
-                    rows=data.get("rows") or [],
-                    sql=data.get("query", {}).get("sql", None),
-                    query_name=data.get("query_name"),
-                    database=database,
-                    table=data.get("table"),
-                    request=request,
-                    view_name=self.name,
-                )
-                it_can_render = await await_me_maybe(it_can_render)
-                if it_can_render:
-                    renderers[key] = self.ds.urls.path(
-                        path_with_format(
-                            request=request,
-                            path=request.scope.get("route_path"),
-                            format=key,
-                            extra_qs={**url_labels_extra},
-                        )
-                    )
-
-            url_csv_args = {"_size": "max", **url_labels_extra}
-            url_csv = self.ds.urls.path(
-                path_with_format(
-                    request=request,
-                    path=request.scope.get("route_path"),
-                    format="csv",
-                    extra_qs=url_csv_args,
-                )
-            )
-            url_csv_path = url_csv.split("?")[0]
-            context = {
-                **data,
-                **extras,
-                **{
-                    "renderers": renderers,
-                    "url_csv": url_csv,
-                    "url_csv_path": url_csv_path,
-                    "url_csv_hidden_args": [
-                        (key, value)
-                        for key, value in urllib.parse.parse_qsl(request.query_string)
-                        if key not in ("_labels", "_facet", "_size")
-                    ]
-                    + [("_size", "max")],
-                    "settings": self.ds.settings_dict(),
-                },
-            }
-            if "metadata" not in context:
-                context["metadata"] = await self.ds.get_instance_metadata()
-            r = await self.render(templates, request=request, context=context)
-            if status_code is not None:
-                r.status = status_code
-
-        ttl = request.args.get("_ttl", None)
-        if ttl is None or not ttl.isdigit():
-            ttl = self.ds.setting("default_cache_ttl")
-
-        return self.set_response_headers(r, ttl)
-
-    def set_response_headers(self, response, ttl):
-        # Set far-future cache expiry
-        if self.ds.cache_headers and response.status == 200:
-            ttl = int(ttl)
-            if ttl == 0:
-                ttl_header = "no-cache"
-            else:
-                ttl_header = f"max-age={ttl}"
-            response.headers["Cache-Control"] = ttl_header
-        response.headers["Referrer-Policy"] = "no-referrer"
-        if self.ds.cors:
-            add_cors_headers(response.headers)
-        return response
-
-
 def _error(messages, status=400):
     return Response.json({"ok": False, "errors": messages}, status=status)
 
diff --git a/datasette/views/row.py b/datasette/views/row.py
index 7802f45e..3e3e52a9 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -1,21 +1,34 @@
+import asyncio
+import json
+import textwrap
+import time
+import urllib.parse
+from dataclasses import dataclass, field, fields
+
+import markupsafe
+import sqlite_utils
+
 from datasette.utils.asgi import NotFound, Forbidden, Response
 from datasette.database import QueryInterrupted
 from datasette.events import UpdateRowEvent, DeleteRowEvent
 from datasette.resources import TableResource
-from .base import DataView, BaseView, _error
+from .base import BaseView, DatasetteError, _error, stream_csv
 from datasette.utils import (
+    add_cors_headers,
     await_me_maybe,
+    call_with_supported_arguments,
     CustomRow,
+    InvalidSql,
     make_slot_function,
     path_from_row_pks,
+    path_with_added_args,
+    path_with_format,
+    path_with_removed_args,
     to_css_class,
     escape_sqlite,
+    sqlite3,
 )
 from datasette.plugins import pm
-from dataclasses import dataclass, field
-import json
-import markupsafe
-import sqlite_utils
 from datasette.extras import extra_names_from_request, ExtraScope
 from . import Context, extra_field
 from .table import (
@@ -121,9 +134,259 @@ class RowContext(Context):
     )
 
 
-class RowView(DataView):
+class RowView(BaseView):
     name = "row"
-    context_class = RowContext
+
+    def redirect(self, request, path, forward_querystring=True, remove_args=None):
+        if request.query_string and "?" not in path and forward_querystring:
+            path = f"{path}?{request.query_string}"
+        if remove_args:
+            path = path_with_removed_args(request, remove_args, path=path)
+        response = Response.redirect(path)
+        response.headers["Link"] = f"<{path}>; rel=preload"
+        if self.ds.cors:
+            add_cors_headers(response.headers)
+        return response
+
+    async def as_csv(self, request, database):
+        return await stream_csv(self.ds, self.data, request, database)
+
+    async def get(self, request):
+        db = await self.ds.resolve_database(request)
+        database = db.name
+        database_route = db.route
+        format_ = request.url_vars.get("format") or "html"
+        data_kwargs = {}
+
+        if format_ == "csv":
+            return await self.as_csv(request, database_route)
+
+        if format_ == "html":
+            # HTML views default to expanding all foreign key labels
+            data_kwargs["default_labels"] = True
+
+        extra_template_data = {}
+        start = time.perf_counter()
+        status_code = None
+        templates = ()
+        try:
+            response_or_template_contexts = await self.data(request, **data_kwargs)
+            if isinstance(response_or_template_contexts, Response):
+                return response_or_template_contexts
+            # If it has four items, it includes an HTTP status code
+            if len(response_or_template_contexts) == 4:
+                (
+                    data,
+                    extra_template_data,
+                    templates,
+                    status_code,
+                ) = response_or_template_contexts
+            else:
+                data, extra_template_data, templates = response_or_template_contexts
+        except QueryInterrupted as ex:
+            raise DatasetteError(
+                textwrap.dedent("""
+                <p>SQL query took too long. The time limit is controlled by the
+                <a href="https://docs.datasette.io/en/stable/settings.html#sql-time-limit-ms">sql_time_limit_ms</a>
+                configuration option.</p>
+                <textarea style="width: 90%">{}</textarea>
+                <script>
+                let ta = document.querySelector("textarea");
+                ta.style.height = ta.scrollHeight + "px";
+                </script>
+            """.format(markupsafe.escape(ex.sql))).strip(),
+                title="SQL Interrupted",
+                status=400,
+                message_is_html=True,
+            )
+        except (sqlite3.OperationalError, InvalidSql) as e:
+            raise DatasetteError(str(e), title="Invalid SQL", status=400)
+        except sqlite3.OperationalError as e:
+            raise DatasetteError(str(e))
+        except DatasetteError:
+            raise
+
+        end = time.perf_counter()
+        data["query_ms"] = (end - start) * 1000
+
+        # Special case for .jsono extension - redirect to _shape=objects
+        if format_ == "jsono":
+            return self.redirect(
+                request,
+                path_with_added_args(
+                    request,
+                    {"_shape": "objects"},
+                    path=request.path.rsplit(".jsono", 1)[0] + ".json",
+                ),
+                forward_querystring=False,
+            )
+
+        if format_ in self.ds.renderers.keys():
+            # Dispatch request to the correct output format renderer
+            # (CSV is not handled here due to streaming)
+            result = call_with_supported_arguments(
+                self.ds.renderers[format_][0],
+                datasette=self.ds,
+                columns=data.get("columns") or [],
+                rows=data.get("rows") or [],
+                sql=data.get("query", {}).get("sql", None),
+                query_name=data.get("query_name"),
+                database=database,
+                table=data.get("table"),
+                request=request,
+                view_name=self.name,
+                truncated=False,  # TODO: support this
+                error=data.get("error"),
+                # These will be deprecated in Datasette 1.0:
+                args=request.args,
+                data=data,
+            )
+            if asyncio.iscoroutine(result):
+                result = await result
+            if result is None:
+                raise NotFound("No data")
+            if isinstance(result, dict):
+                response = Response(
+                    body=result.get("body"),
+                    status=result.get("status_code", status_code or 200),
+                    content_type=result.get("content_type", "text/plain"),
+                    headers=result.get("headers"),
+                )
+            elif isinstance(result, Response):
+                response = result
+                if status_code is not None:
+                    # Over-ride the status code
+                    response.status = status_code
+            else:
+                assert False, f"{result} should be dict or Response"
+        elif format_ == "html":
+            response = await self.html(request, data, extra_template_data, templates)
+            if status_code is not None:
+                response.status = status_code
+        else:
+            raise NotFound("Invalid format: {}".format(format_))
+
+        ttl = request.args.get("_ttl", None)
+        if ttl is None or not ttl.isdigit():
+            ttl = self.ds.setting("default_cache_ttl")
+
+        return self.set_response_headers(response, ttl)
+
+    async def html(self, request, data, extra_template_data, templates):
+        extras = {}
+        if callable(extra_template_data):
+            extras = extra_template_data()
+            if asyncio.iscoroutine(extras):
+                extras = await extras
+        else:
+            extras = extra_template_data
+
+        url_labels_extra = {}
+        if data.get("expandable_columns"):
+            url_labels_extra = {"_labels": "on"}
+
+        renderers = {}
+        for key, (_, can_render) in self.ds.renderers.items():
+            it_can_render = call_with_supported_arguments(
+                can_render,
+                datasette=self.ds,
+                columns=data.get("columns") or [],
+                rows=data.get("rows") or [],
+                sql=data.get("query", {}).get("sql", None),
+                query_name=data.get("query_name"),
+                database=data.get("database"),
+                table=data.get("table"),
+                request=request,
+                view_name=self.name,
+            )
+            it_can_render = await await_me_maybe(it_can_render)
+            if it_can_render:
+                renderers[key] = self.ds.urls.path(
+                    path_with_format(
+                        request=request,
+                        path=request.scope.get("route_path"),
+                        format=key,
+                        extra_qs={**url_labels_extra},
+                    )
+                )
+
+        url_csv_args = {"_size": "max", **url_labels_extra}
+        url_csv = self.ds.urls.path(
+            path_with_format(
+                request=request,
+                path=request.scope.get("route_path"),
+                format="csv",
+                extra_qs=url_csv_args,
+            )
+        )
+        url_csv_path = url_csv.split("?")[0]
+        context = {**data, **extras}
+        if "metadata" not in context:
+            context["metadata"] = await self.ds.get_instance_metadata()
+
+        environment = self.ds.get_jinja_environment(request)
+        template = environment.select_template(templates)
+        alternate_url_json = self.ds.absolute_url(
+            request,
+            self.ds.urls.path(
+                path_with_format(
+                    request=request,
+                    path=request.scope.get("route_path"),
+                    format="json",
+                )
+            ),
+        )
+        explicit_context = {
+            "renderers": renderers,
+            "url_csv": url_csv,
+            "url_csv_path": url_csv_path,
+            "url_csv_hidden_args": [
+                (key, value)
+                for key, value in urllib.parse.parse_qsl(request.query_string)
+                if key not in ("_labels", "_facet", "_size")
+            ]
+            + [("_size", "max")],
+            "settings": self.ds.settings_dict(),
+            "alternate_url_json": alternate_url_json,
+            "select_templates": [
+                f"{'*' if template_name == template.name else ''}{template_name}"
+                for template_name in templates
+            ],
+        }
+        declared_fields = {f.name for f in fields(RowContext)}
+        context = {
+            key: value
+            for key, value in context.items()
+            if key in declared_fields and key not in explicit_context
+        }
+
+        return Response.html(
+            await self.ds.render_template(
+                template,
+                RowContext(**context, **explicit_context),
+                request=request,
+                view_name=self.name,
+            ),
+            headers={
+                "Link": '<{}>; rel="alternate"; type="application/json+datasette"'.format(
+                    alternate_url_json
+                )
+            },
+        )
+
+    def set_response_headers(self, response, ttl):
+        # Set far-future cache expiry
+        if self.ds.cache_headers and response.status == 200:
+            ttl = int(ttl)
+            if ttl == 0:
+                ttl_header = "no-cache"
+            else:
+                ttl_header = f"max-age={ttl}"
+            response.headers["Cache-Control"] = ttl_header
+        response.headers["Referrer-Policy"] = "no-referrer"
+        if self.ds.cors:
+            add_cors_headers(response.headers)
+        return response
 
     async def data(self, request, default_labels=False):
         resolved = await self.ds.resolve_row(request)

From a43e76c31a3c4b96ab7289b5f3202c7c3537bf6a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 09:08:40 -0700
Subject: [PATCH 276/386] Construct row template context explicitly

---
 datasette/views/row.py | 63 +++++++++++++++++++++++++-----------------
 1 file changed, 37 insertions(+), 26 deletions(-)

diff --git a/datasette/views/row.py b/datasette/views/row.py
index 3e3e52a9..ef39dce6 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -3,7 +3,7 @@ import json
 import textwrap
 import time
 import urllib.parse
-from dataclasses import dataclass, field, fields
+from dataclasses import dataclass, field
 
 import markupsafe
 import sqlite_utils
@@ -336,34 +336,45 @@ class RowView(BaseView):
                 )
             ),
         )
-        explicit_context = {
-            "renderers": renderers,
-            "url_csv": url_csv,
-            "url_csv_path": url_csv_path,
-            "url_csv_hidden_args": [
-                (key, value)
-                for key, value in urllib.parse.parse_qsl(request.query_string)
-                if key not in ("_labels", "_facet", "_size")
-            ]
-            + [("_size", "max")],
-            "settings": self.ds.settings_dict(),
-            "alternate_url_json": alternate_url_json,
-            "select_templates": [
-                f"{'*' if template_name == template.name else ''}{template_name}"
-                for template_name in templates
-            ],
-        }
-        declared_fields = {f.name for f in fields(RowContext)}
-        context = {
-            key: value
-            for key, value in context.items()
-            if key in declared_fields and key not in explicit_context
-        }
-
         return Response.html(
             await self.ds.render_template(
                 template,
-                RowContext(**context, **explicit_context),
+                RowContext(
+                    columns=context["columns"],
+                    database=context["database"],
+                    database_color=context["database_color"],
+                    foreign_key_tables=context["foreign_key_tables"],
+                    metadata=context["metadata"],
+                    primary_keys=context["primary_keys"],
+                    private=context["private"],
+                    table=context["table"],
+                    ok=context["ok"],
+                    rows=context["rows"],
+                    primary_key_values=context["primary_key_values"],
+                    query_ms=context["query_ms"],
+                    display_columns=context["display_columns"],
+                    display_rows=context["display_rows"],
+                    custom_table_templates=context["custom_table_templates"],
+                    row_actions=context["row_actions"],
+                    row_mutation_ui=context["row_mutation_ui"],
+                    table_page_data=context["table_page_data"],
+                    top_row=context["top_row"],
+                    renderers=renderers,
+                    url_csv=url_csv,
+                    url_csv_path=url_csv_path,
+                    url_csv_hidden_args=[
+                        (key, value)
+                        for key, value in urllib.parse.parse_qsl(request.query_string)
+                        if key not in ("_labels", "_facet", "_size")
+                    ]
+                    + [("_size", "max")],
+                    settings=self.ds.settings_dict(),
+                    select_templates=[
+                        f"{'*' if template_name == template.name else ''}{template_name}"
+                        for template_name in templates
+                    ],
+                    alternate_url_json=alternate_url_json,
+                ),
                 request=request,
                 view_name=self.name,
             ),

From 59ab0c0ca0b2d86913102dace6813f42f947d772 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 11:30:30 -0700
Subject: [PATCH 277/386] Clarify template context metadata names

---
 datasette/template_contexts.py |  2 +-
 datasette/views/__init__.py    | 14 ++++----
 datasette/views/database.py    |  4 +--
 datasette/views/row.py         | 20 +++++------
 datasette/views/table.py       | 62 +++++++++++++++++-----------------
 docs/template_context_doc.py   |  2 +-
 tests/test_template_context.py | 24 +++++++------
 7 files changed, 65 insertions(+), 63 deletions(-)

diff --git a/datasette/template_contexts.py b/datasette/template_contexts.py
index 5fe6a80e..232eb051 100644
--- a/datasette/template_contexts.py
+++ b/datasette/template_contexts.py
@@ -7,7 +7,7 @@ the documentation lives next to the code it describes:
 - Every page renders a Context dataclass defined in its view module
   (DatabaseContext, QueryContext in views/database.py, TableContext in
   views/table.py, RowContext in views/row.py). Fields added by view code
-  carry ``help`` metadata; fields declared with extra_field() take their
+  carry ``help`` metadata; fields declared with from_extra() take their
   documentation from the description on the matching Extra class in
   views/table_extras.py.
 - The keys render_template() adds to every page are documented in
diff --git a/datasette/views/__init__.py b/datasette/views/__init__.py
index e503ed35..6fba1c90 100644
--- a/datasette/views/__init__.py
+++ b/datasette/views/__init__.py
@@ -10,7 +10,7 @@ class ContextField:
     from_extra: bool = False
 
 
-def extra_field():
+def from_extra():
     """
     Declare a Context dataclass field whose value comes from a registered
     Extra of the same name - its documentation is the Extra description,
@@ -23,7 +23,7 @@ def extra_field():
 class Context:
     "Base class for all documented contexts"
 
-    # Set on subclasses whose extra_field() fields should be resolved
+    # Set on subclasses whose from_extra() fields should be resolved
     # against the extras registry for this scope
     extras_scope = None
 
@@ -34,8 +34,8 @@ class Context:
         for f in dataclasses.fields(cls):
             if f.name.startswith("_"):
                 continue
-            from_extra = bool(f.metadata.get("from_extra"))
-            if from_extra:
+            is_from_extra = bool(f.metadata.get("from_extra"))
+            if is_from_extra:
                 help_text = cls._extra_description(f.name)
             else:
                 help_text = f.metadata.get("help", "")
@@ -44,7 +44,7 @@ class Context:
                     name=f.name,
                     type_name=getattr(f.type, "__name__", str(f.type)),
                     help=help_text,
-                    from_extra=from_extra,
+                    from_extra=is_from_extra,
                 )
             )
         return documented
@@ -59,14 +59,14 @@ class Context:
             extra_class = table_extra_registry.classes_by_name[name]
         except KeyError:
             raise KeyError(
-                "{}.{} is declared with extra_field() but there is no "
+                "{}.{} is declared with from_extra() but there is no "
                 "registered extra of that name".format(cls.__name__, name)
             )
         if cls.extras_scope is not None and not extra_class.available_for(
             cls.extras_scope
         ):
             raise ValueError(
-                "{}.{} is declared with extra_field() but the {} extra is "
+                "{}.{} is declared with from_extra() but the {} extra is "
                 "not available for scope {}".format(
                     cls.__name__, name, name, cls.extras_scope
                 )
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 7409e7d3..0b4ca647 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -258,7 +258,7 @@ class DatabaseView(View):
 class DatabaseContext(Context):
     "The page listing the tables, views and queries in a database, e.g. /fixtures."
 
-    template = "database.html"
+    documented_template = "database.html"
 
     database: str = field(metadata={"help": "The name of the database"})
     private: bool = field(
@@ -341,7 +341,7 @@ class DatabaseContext(Context):
 class QueryContext(Context):
     "The page for arbitrary SQL queries (/database/-/query?sql=...) and stored queries (/database/query-name)."
 
-    template = "query.html"
+    documented_template = "query.html"
 
     database: str = field(metadata={"help": "The name of the database being queried"})
     database_color: str = field(metadata={"help": "The color of the database"})
diff --git a/datasette/views/row.py b/datasette/views/row.py
index ef39dce6..129216b9 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -30,7 +30,7 @@ from datasette.utils import (
 )
 from datasette.plugins import pm
 from datasette.extras import extra_names_from_request, ExtraScope
-from . import Context, extra_field
+from . import Context, from_extra
 from .table import (
     display_columns_and_rows,
     _table_page_data,
@@ -43,19 +43,19 @@ from .table_extras import RowExtraContext, resolve_row_extras, table_extra_regis
 class RowContext(Context):
     "The page showing an individual row, e.g. /fixtures/facetable/1."
 
-    template = "row.html"
+    documented_template = "row.html"
     extras_scope = ExtraScope.ROW
 
     # Fields resolved by registered extras - their documentation comes
     # from the description on each Extra class in table_extras.py
-    columns: list = extra_field()
-    database: str = extra_field()
-    database_color: str = extra_field()
-    foreign_key_tables: list = extra_field()
-    metadata: dict = extra_field()
-    primary_keys: list = extra_field()
-    private: bool = extra_field()
-    table: str = extra_field()
+    columns: list = from_extra()
+    database: str = from_extra()
+    database_color: str = from_extra()
+    foreign_key_tables: list = from_extra()
+    metadata: dict = from_extra()
+    primary_keys: list = from_extra()
+    private: bool = from_extra()
+    table: str = from_extra()
 
     # Fields added by the view code
     ok: bool = field(
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 1e182937..449c6216 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -49,7 +49,7 @@ import sqlite_utils
 from dataclasses import dataclass, field, fields
 
 from datasette.extras import ExtraScope
-from . import Context, extra_field
+from . import Context, from_extra
 from .base import BaseView, DatasetteError, _error, stream_csv
 from .database import QueryView
 from .table_create_alter import (
@@ -73,40 +73,40 @@ from .table_extras import (
 class TableContext(Context):
     "The page showing the rows in a table or SQL view, e.g. /fixtures/facetable."
 
-    template = "table.html"
+    documented_template = "table.html"
     extras_scope = ExtraScope.TABLE
 
     # Fields resolved by registered extras - their documentation comes
     # from the description on each Extra class in table_extras.py
-    actions: callable = extra_field()
-    all_columns: list = extra_field()
-    columns: list = extra_field()
-    count: int = extra_field()
-    count_sql: str = extra_field()
-    custom_table_templates: list = extra_field()
-    database: str = extra_field()
-    database_color: str = extra_field()
-    display_columns: list = extra_field()
-    display_rows: list = extra_field()
-    expandable_columns: list = extra_field()
-    facet_results: dict = extra_field()
-    facets_timed_out: list = extra_field()
-    filters: Filters = extra_field()
-    form_hidden_args: list = extra_field()
-    human_description_en: str = extra_field()
-    is_view: bool = extra_field()
-    metadata: dict = extra_field()
-    next_url: str = extra_field()
-    primary_keys: list = extra_field()
-    private: bool = extra_field()
-    query: dict = extra_field()
-    renderers: dict = extra_field()
-    set_column_type_ui: dict = extra_field()
-    sorted_facet_results: list = extra_field()
-    suggested_facets: list = extra_field()
-    table: str = extra_field()
-    table_definition: str = extra_field()
-    view_definition: str = extra_field()
+    actions: callable = from_extra()
+    all_columns: list = from_extra()
+    columns: list = from_extra()
+    count: int = from_extra()
+    count_sql: str = from_extra()
+    custom_table_templates: list = from_extra()
+    database: str = from_extra()
+    database_color: str = from_extra()
+    display_columns: list = from_extra()
+    display_rows: list = from_extra()
+    expandable_columns: list = from_extra()
+    facet_results: dict = from_extra()
+    facets_timed_out: list = from_extra()
+    filters: Filters = from_extra()
+    form_hidden_args: list = from_extra()
+    human_description_en: str = from_extra()
+    is_view: bool = from_extra()
+    metadata: dict = from_extra()
+    next_url: str = from_extra()
+    primary_keys: list = from_extra()
+    private: bool = from_extra()
+    query: dict = from_extra()
+    renderers: dict = from_extra()
+    set_column_type_ui: dict = from_extra()
+    sorted_facet_results: list = from_extra()
+    suggested_facets: list = from_extra()
+    table: str = from_extra()
+    table_definition: str = from_extra()
+    view_definition: str = from_extra()
 
     # Fields added by the view code
     ok: bool = field(
diff --git a/docs/template_context_doc.py b/docs/template_context_doc.py
index c3ec77e2..a5f4fb6f 100644
--- a/docs/template_context_doc.py
+++ b/docs/template_context_doc.py
@@ -27,7 +27,7 @@ def template_context(cog):
     for klass in PAGES.values():
         title = "{} page".format(klass.__name__.removesuffix("Context"))
         intro = "{} Rendered using the ``{}`` template.".format(
-            klass.__doc__, klass.template
+            klass.__doc__, klass.documented_template
         )
         _section(cog, title, intro)
         if klass.extras_scope is not None:
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index 8d78bf77..4c452774 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -40,20 +40,22 @@ def test_context_class_fields_all_have_help(klass):
 
 
 @pytest.mark.parametrize("klass", PAGES.values(), ids=lambda klass: klass.__name__)
-def test_context_class_has_docstring_and_template(klass):
+def test_context_class_has_docstring_and_documented_template(klass):
     assert klass.__doc__, "{} is missing a docstring".format(klass.__name__)
-    assert klass.template, "{} is missing a template".format(klass.__name__)
+    assert klass.documented_template, "{} is missing a documented_template".format(
+        klass.__name__
+    )
 
 
-def test_extra_field_documentation_comes_from_the_extra_class():
-    from datasette.views import extra_field
+def test_from_extra_documentation_comes_from_the_extra_class():
+    from datasette.views import from_extra
     from datasette.views.table_extras import CountExtra
 
     @dataclass
     class DemoContext(Context):
         extras_scope = ExtraScope.TABLE
 
-        count: int = extra_field()
+        count: int = from_extra()
         name: str = field(metadata={"help": "The name"})
 
     fields = {f.name: f for f in DemoContext.documented_fields()}
@@ -63,28 +65,28 @@ def test_extra_field_documentation_comes_from_the_extra_class():
     assert not fields["name"].from_extra
 
 
-def test_extra_field_must_match_a_registered_extra():
-    from datasette.views import extra_field
+def test_from_extra_must_match_a_registered_extra():
+    from datasette.views import from_extra
 
     @dataclass
     class BadContext(Context):
         extras_scope = ExtraScope.TABLE
 
-        not_a_real_extra: str = extra_field()
+        not_a_real_extra: str = from_extra()
 
     with pytest.raises(KeyError):
         BadContext.documented_fields()
 
 
-def test_extra_field_must_be_available_for_the_scope():
-    from datasette.views import extra_field
+def test_from_extra_must_be_available_for_the_scope():
+    from datasette.views import from_extra
 
     @dataclass
     class WrongScopeContext(Context):
         extras_scope = ExtraScope.ROW
 
         # count is a TABLE-scope extra, not available for ROW
-        count: int = extra_field()
+        count: int = from_extra()
 
     with pytest.raises(ValueError):
         WrongScopeContext.documented_fields()

From 34d9a3bf33e3c4ff610f7d3a633f63c3d7272cc9 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 12:11:26 -0700
Subject: [PATCH 278/386] Use dataclasses for database table context

---
 datasette/app.py               | 17 +++++++++-
 datasette/views/__init__.py    | 17 +++++++++-
 datasette/views/database.py    | 57 +++++++++++++++++++++-------------
 docs/contributing.rst          | 13 ++++++++
 docs/template_context.rst      |  8 ++---
 tests/test_template_context.py | 10 ++++++
 6 files changed, 95 insertions(+), 27 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 90de60a9..57f893fe 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -331,6 +331,15 @@ def _to_string(value):
         return json.dumps(value, default=str)
 
 
+def _template_context_json_default(value):
+    if dataclasses.is_dataclass(value) and not isinstance(value, type):
+        return {
+            field.name: getattr(value, field.name)
+            for field in dataclasses.fields(value)
+        }
+    return repr(value)
+
+
 @pass_context
 def _legacy_template_csrftoken(context):
     request = context.get("request")
@@ -2390,7 +2399,13 @@ class Datasette:
         }
         if request and request.args.get("_context") and self.setting("template_debug"):
             return "<pre>{}</pre>".format(
-                escape(json.dumps(template_context, default=repr, indent=4))
+                escape(
+                    json.dumps(
+                        template_context,
+                        default=_template_context_json_default,
+                        indent=4,
+                    )
+                )
             )
 
         return await template.render_async(template_context)
diff --git a/datasette/views/__init__.py b/datasette/views/__init__.py
index 6fba1c90..ed7e175f 100644
--- a/datasette/views/__init__.py
+++ b/datasette/views/__init__.py
@@ -1,5 +1,7 @@
 from dataclasses import dataclass
 import dataclasses
+import types
+import typing
 
 
 @dataclass(frozen=True)
@@ -10,6 +12,19 @@ class ContextField:
     from_extra: bool = False
 
 
+def _type_name(type_):
+    if type_ is type(None):
+        return "None"
+    origin = typing.get_origin(type_)
+    args = typing.get_args(type_)
+    if origin in (typing.Union, types.UnionType):
+        return " | ".join(_type_name(arg) for arg in args)
+    if origin is not None:
+        name = getattr(origin, "__name__", str(origin).removeprefix("typing."))
+        return "{}[{}]".format(name, ", ".join(_type_name(arg) for arg in args))
+    return getattr(type_, "__name__", str(type_).removeprefix("typing."))
+
+
 def from_extra():
     """
     Declare a Context dataclass field whose value comes from a registered
@@ -42,7 +57,7 @@ class Context:
             documented.append(
                 ContextField(
                     name=f.name,
-                    type_name=getattr(f.type, "__name__", str(f.type)),
+                    type_name=_type_name(f.type),
                     help=help_text,
                     from_extra=is_from_extra,
                 )
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 0b4ca647..fd985b77 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -1,4 +1,4 @@
-from dataclasses import dataclass, field
+from dataclasses import asdict, dataclass, field
 from urllib.parse import parse_qsl, urlencode
 import asyncio
 import hashlib
@@ -45,6 +45,21 @@ from .table_create_alter import _create_table_ui_context
 from . import Context
 
 
+@dataclass
+class DatabaseTable:
+    "Summary of a table or view shown on database and query pages."
+
+    name: str
+    columns: list[str]
+    primary_keys: list[str]
+    count: int | None
+    count_truncated: bool
+    hidden: bool
+    fts_table: str | None
+    foreign_keys: dict[str, list[dict[str, str]]]
+    private: bool
+
+
 class DatabaseView(View):
     async def get(self, request, datasette):
         format_ = request.url_vars.get("format") or "html"
@@ -169,8 +184,8 @@ class DatabaseView(View):
             "private": private,
             "path": datasette.urls.database(database),
             "size": db.size,
-            "tables": tables,
-            "hidden_count": len([t for t in tables if t["hidden"]]),
+            "tables": [asdict(table) for table in tables],
+            "hidden_count": len([table for table in tables if table.hidden]),
             "views": sql_views,
             "queries": [stored_query_to_dict(query) for query in stored_queries],
             "queries_more": queries_more,
@@ -211,7 +226,7 @@ class DatabaseView(View):
                     path=datasette.urls.database(database),
                     size=db.size,
                     tables=tables,
-                    hidden_count=len([t for t in tables if t["hidden"]]),
+                    hidden_count=len([table for table in tables if table.hidden]),
                     views=sql_views,
                     queries=stored_queries,
                     queries_more=queries_more,
@@ -266,9 +281,9 @@ class DatabaseContext(Context):
     )
     path: str = field(metadata={"help": "The URL path to this database"})
     size: int = field(metadata={"help": "The size of the database in bytes"})
-    tables: list = field(
+    tables: list[DatabaseTable] = field(
         metadata={
-            "help": "List of table dictionaries in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` keys. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total."
+            "help": "List of ``DatabaseTable`` objects describing tables in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` attributes. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total."
         }
     )
     hidden_count: int = field(metadata={"help": "Count of hidden tables"})
@@ -391,9 +406,9 @@ class QueryContext(Context):
     save_query_url: str = field(
         metadata={"help": "URL to save the current arbitrary SQL as a query"}
     )
-    tables: list = field(
+    tables: list[DatabaseTable] = field(
         metadata={
-            "help": "List of table dictionaries in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` keys. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total."
+            "help": "List of ``DatabaseTable`` objects describing tables in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` attributes. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total."
         }
     )
     named_parameter_values: dict = field(
@@ -456,7 +471,7 @@ class QueryContext(Context):
     )
 
 
-async def get_tables(datasette, request, db, allowed_dict):
+async def get_tables(datasette, request, db, allowed_dict) -> list[DatabaseTable]:
     """
     Get list of tables with metadata for the database view.
 
@@ -477,21 +492,21 @@ async def get_tables(datasette, request, db, allowed_dict):
 
         table_columns = await db.table_columns(table)
         tables.append(
-            {
-                "name": table,
-                "columns": table_columns,
-                "primary_keys": await db.primary_keys(table),
-                "count": table_counts[table],
-                "count_truncated": _table_count_truncated(
+            DatabaseTable(
+                name=table,
+                columns=table_columns,
+                primary_keys=await db.primary_keys(table),
+                count=table_counts[table],
+                count_truncated=_table_count_truncated(
                     datasette, db, table, table_counts[table]
                 ),
-                "hidden": table in hidden_table_names,
-                "fts_table": await db.fts_table(table),
-                "foreign_keys": all_foreign_keys[table],
-                "private": allowed_dict[table].private,
-            }
+                hidden=table in hidden_table_names,
+                fts_table=await db.fts_table(table),
+                foreign_keys=all_foreign_keys[table],
+                private=allowed_dict[table].private,
+            )
         )
-    tables.sort(key=lambda t: (t["hidden"], t["name"]))
+    tables.sort(key=lambda table: (table.hidden, table.name))
     return tables
 
 
diff --git a/docs/contributing.rst b/docs/contributing.rst
index 3b45834c..142c2f41 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -309,6 +309,19 @@ To update these pages, run the following command::
 
     uv run cog -r docs/*.rst
 
+.. _contributing_template_contexts:
+
+Documented template contexts
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Datasette's documented template contexts are part of the public API for custom templates. They are defined as dataclasses next to the view code that renders them, for example ``DatabaseContext`` and ``QueryContext`` in ``datasette/views/database.py``.
+
+Every documented context class inherits from ``datasette.views.Context``. Fields that are added directly by view code should be declared as dataclass fields with ``help`` metadata, which is used to generate :ref:`template_context`. Fields resolved through the page extras system should use ``from_extra()`` so their documentation comes from the matching ``Extra`` class.
+
+Use ``documented_template`` on each context class to record the canonical template named in the generated documentation. This should be a string such as ``"database.html"``. Runtime template selection still happens in the view code, since most pages consider more specific template names before falling back to the canonical one.
+
+When a context field contains repeated structured data, prefer a small nested dataclass over an anonymous dictionary. For example, a field containing table summaries should be annotated as ``list[DatabaseTable]`` where ``DatabaseTable`` is a dataclass describing the keys and value types. This keeps the Python contract and generated documentation clear. JSON responses and ``?_context=1`` debug output will convert nested dataclasses back to JSON objects at the response boundary.
+
 .. _contributing_continuous_deployment:
 
 Continuously deployed demo instances
diff --git a/docs/template_context.rst b/docs/template_context.rst
index 12f656d0..311de8bb 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -145,8 +145,8 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
 ``table_columns`` - ``dict``
     Dictionary mapping table names to lists of column names, used to power SQL autocomplete.
 
-``tables`` - ``list``
-    List of table dictionaries in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` keys. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total.
+``tables`` - ``list[DatabaseTable]``
+    List of ``DatabaseTable`` objects describing tables in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` attributes. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total.
 
 ``top_database`` - ``callable``
     Async callable that renders the ``top_database`` plugin slot for this database and returns HTML.
@@ -234,8 +234,8 @@ The page for arbitrary SQL queries (/database/-/query?sql=...) and stored querie
 ``table_columns`` - ``dict``
     Dictionary mapping table names to lists of column names, used to power SQL autocomplete.
 
-``tables`` - ``list``
-    List of table dictionaries in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` keys. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total.
+``tables`` - ``list[DatabaseTable]``
+    List of ``DatabaseTable`` objects describing tables in the database. Each item has ``name``, ``columns``, ``primary_keys``, ``count``, ``count_truncated``, ``hidden``, ``fts_table``, ``foreign_keys`` and ``private`` attributes. ``count_truncated`` is true if ``count`` is a capped lower bound rather than an exact total.
 
 ``top_query`` - ``callable``
     Async callable that renders the ``top_query`` plugin slot for this query and returns HTML.
diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index 4c452774..f1919891 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -18,16 +18,22 @@ from datasette.views import Context
 
 
 def test_documented_fields():
+    @dataclass
+    class DemoNested:
+        name: str
+
     @dataclass
     class DemoContext(Context):
         name: str = field(metadata={"help": "The name"})
         _internal: str = field()
         count: int = field(metadata={"help": "How many there are"})
+        items: list[DemoNested] = field(metadata={"help": "Nested items"})
 
     fields = DemoContext.documented_fields()
     assert [(f.name, f.type_name, f.help) for f in fields] == [
         ("name", "str", "The name"),
         ("count", "int", "How many there are"),
+        ("items", "list[DemoNested]", "Nested items"),
     ]
 
 
@@ -230,3 +236,7 @@ def test_template_context_docs_cover_every_documented_key():
             assert "``{}``".format(context_field.name) in docs, "{} ({} page)".format(
                 context_field.name, page_name
             )
+            assert (
+                "``{}`` - ``{}``".format(context_field.name, context_field.type_name)
+                in docs
+            ), "{} type ({} page)".format(context_field.name, page_name)

From 0d1c097396b8e39f4c5d20ea16282c295d2e4e0b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 12:16:42 -0700
Subject: [PATCH 279/386] Document database views and queries as dataclasses

---
 datasette/views/database.py | 22 +++++++++++++++-------
 docs/template_context.rst   |  8 ++++----
 2 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index fd985b77..e02de657 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -11,7 +11,7 @@ import textwrap
 from datasette.extras import extra_names_from_request
 from datasette.database import QueryInterrupted
 from datasette.resources import DatabaseResource, QueryResource
-from datasette.stored_queries import stored_query_to_dict
+from datasette.stored_queries import StoredQuery, stored_query_to_dict
 from datasette.write_sql import QueryWriteRejected
 from datasette.utils import (
     add_cors_headers,
@@ -60,6 +60,14 @@ class DatabaseTable:
     private: bool
 
 
+@dataclass
+class DatabaseViewInfo:
+    "Summary of a SQLite view shown on the database page."
+
+    name: str
+    private: bool
+
+
 class DatabaseView(View):
     async def get(self, request, datasette):
         format_ = request.url_vars.get("format") or "html"
@@ -109,7 +117,7 @@ class DatabaseView(View):
         # Filter to just views
         view_names_set = set(await db.view_names())
         sql_views = [
-            {"name": name, "private": allowed_dict[name].private}
+            DatabaseViewInfo(name=name, private=allowed_dict[name].private)
             for name in allowed_dict
             if name in view_names_set
         ]
@@ -186,7 +194,7 @@ class DatabaseView(View):
             "size": db.size,
             "tables": [asdict(table) for table in tables],
             "hidden_count": len([table for table in tables if table.hidden]),
-            "views": sql_views,
+            "views": [asdict(view) for view in sql_views],
             "queries": [stored_query_to_dict(query) for query in stored_queries],
             "queries_more": queries_more,
             "queries_count": queries_count,
@@ -287,14 +295,14 @@ class DatabaseContext(Context):
         }
     )
     hidden_count: int = field(metadata={"help": "Count of hidden tables"})
-    views: list = field(
+    views: list[DatabaseViewInfo] = field(
         metadata={
-            "help": "List of SQLite view dictionaries. Each item has ``name`` and ``private`` keys."
+            "help": "List of ``DatabaseViewInfo`` objects describing SQLite views in the database. Each item has ``name`` and ``private`` attributes."
         }
     )
-    queries: list = field(
+    queries: list[StoredQuery] = field(
         metadata={
-            "help": "List of stored query objects. Each has attributes including ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``is_write`` and ``private``."
+            "help": "List of ``StoredQuery`` objects. Each has attributes including ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``is_write`` and ``private``."
         }
     )
     queries_more: bool = field(
diff --git a/docs/template_context.rst b/docs/template_context.rst
index 311de8bb..52ccca49 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -124,8 +124,8 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
 ``private`` - ``bool``
     Boolean indicating if this is a private database
 
-``queries`` - ``list``
-    List of stored query objects. Each has attributes including ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``is_write`` and ``private``.
+``queries`` - ``list[StoredQuery]``
+    List of ``StoredQuery`` objects. Each has attributes including ``name``, ``sql``, ``title``, ``description``, ``description_html``, ``hide_sql``, ``fragment``, ``parameters``, ``is_write`` and ``private``.
 
 ``queries_count`` - ``int``
     Count of visible stored queries
@@ -151,8 +151,8 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
 ``top_database`` - ``callable``
     Async callable that renders the ``top_database`` plugin slot for this database and returns HTML.
 
-``views`` - ``list``
-    List of SQLite view dictionaries. Each item has ``name`` and ``private`` keys.
+``views`` - ``list[DatabaseViewInfo]``
+    List of ``DatabaseViewInfo`` objects describing SQLite views in the database. Each item has ``name`` and ``private`` attributes.
 
 Query page
 ----------

From 8276879997661ae618ffe984ab6a183d3b62788f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 12:24:42 -0700
Subject: [PATCH 280/386] Construct table context explicitly

---
 datasette/views/table.py | 110 ++++++++++++++++++++++++++-------------
 1 file changed, 74 insertions(+), 36 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 449c6216..4b923d20 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -46,7 +46,7 @@ from datasette.utils import (
 from datasette.utils.asgi import BadRequest, Forbidden, NotFound, Request, Response
 from datasette.filters import Filters
 import sqlite_utils
-from dataclasses import dataclass, field, fields
+from dataclasses import dataclass, field
 
 from datasette.extras import ExtraScope
 from . import Context, from_extra
@@ -1825,44 +1825,82 @@ async def table_view_traced(datasette, request):
                 )
             }
         )
-        # Only keys declared on TableContext are part of the documented
-        # template contract - anything else in data (e.g. extras requested
-        # with ?_extra= on the HTML page, or extra filter context added by
-        # filters_from_request plugins) is dropped here
-        declared_fields = {f.name for f in fields(TableContext)}
+        table_context = TableContext(
+            actions=data["actions"],
+            all_columns=data["all_columns"],
+            columns=data["columns"],
+            count=data["count"],
+            count_sql=data["count_sql"],
+            custom_table_templates=data["custom_table_templates"],
+            database=data["database"],
+            database_color=data["database_color"],
+            display_columns=data["display_columns"],
+            display_rows=data["display_rows"],
+            expandable_columns=data["expandable_columns"],
+            facet_results=data["facet_results"],
+            facets_timed_out=data["facets_timed_out"],
+            filters=data["filters"],
+            form_hidden_args=data["form_hidden_args"],
+            human_description_en=data["human_description_en"],
+            is_view=data["is_view"],
+            metadata=data["metadata"],
+            next_url=data["next_url"],
+            primary_keys=data["primary_keys"],
+            private=data["private"],
+            query=data["query"],
+            renderers=data["renderers"],
+            set_column_type_ui=data["set_column_type_ui"],
+            sorted_facet_results=data["sorted_facet_results"],
+            suggested_facets=data["suggested_facets"],
+            table=data["table"],
+            table_definition=data["table_definition"],
+            view_definition=data["view_definition"],
+            ok=data["ok"],
+            next=data["next"],
+            count_truncated=data["count_truncated"],
+            rows=data["rows"],
+            filter_columns=data["filter_columns"],
+            supports_search=data["supports_search"],
+            extra_wheres_for_ui=data["extra_wheres_for_ui"],
+            url_csv=data["url_csv"],
+            url_csv_path=data["url_csv_path"],
+            url_csv_hidden_args=data["url_csv_hidden_args"],
+            sort=data["sort"],
+            sort_desc=data["sort_desc"],
+            append_querystring=append_querystring,
+            path_with_replaced_args=path_with_replaced_args,
+            fix_path=datasette.urls.path,
+            settings=datasette.settings_dict(),
+            alternate_url_json=alternate_url_json,
+            datasette_allow_facet=(
+                "true" if datasette.setting("allow_facet") else "false"
+            ),
+            is_sortable=any(c["sortable"] for c in data["display_columns"]),
+            allow_execute_sql=await datasette.allowed(
+                action="execute-sql",
+                resource=DatabaseResource(database=resolved.db.name),
+                actor=request.actor,
+            ),
+            query_ms=1.2,
+            select_templates=[
+                f"{'*' if template_name == template.name else ''}{template_name}"
+                for template_name in templates
+            ],
+            top_table=make_slot_function(
+                "top_table",
+                datasette,
+                request,
+                database=resolved.db.name,
+                table=resolved.table,
+            ),
+            table_page_data=data["table_page_data"],
+            table_insert_ui=data["table_insert_ui"],
+            table_alter_ui=data["table_alter_ui"],
+        )
         r = Response.html(
             await datasette.render_template(
                 template,
-                TableContext(
-                    **{k: v for k, v in data.items() if k in declared_fields},
-                    append_querystring=append_querystring,
-                    path_with_replaced_args=path_with_replaced_args,
-                    fix_path=datasette.urls.path,
-                    settings=datasette.settings_dict(),
-                    # TODO: review up all of these hacks:
-                    alternate_url_json=alternate_url_json,
-                    datasette_allow_facet=(
-                        "true" if datasette.setting("allow_facet") else "false"
-                    ),
-                    is_sortable=any(c["sortable"] for c in data["display_columns"]),
-                    allow_execute_sql=await datasette.allowed(
-                        action="execute-sql",
-                        resource=DatabaseResource(database=resolved.db.name),
-                        actor=request.actor,
-                    ),
-                    query_ms=1.2,
-                    select_templates=[
-                        f"{'*' if template_name == template.name else ''}{template_name}"
-                        for template_name in templates
-                    ],
-                    top_table=make_slot_function(
-                        "top_table",
-                        datasette,
-                        request,
-                        database=resolved.db.name,
-                        table=resolved.table,
-                    ),
-                ),
+                table_context,
                 request=request,
                 view_name="table",
             ),

From 0c523dda209e3b545c52cd3b113d788cba9a342b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 12:29:21 -0700
Subject: [PATCH 281/386] Remove count truncated context test

---
 tests/test_template_context.py | 27 ---------------------------
 1 file changed, 27 deletions(-)

diff --git a/tests/test_template_context.py b/tests/test_template_context.py
index f1919891..7923d0e7 100644
--- a/tests/test_template_context.py
+++ b/tests/test_template_context.py
@@ -191,33 +191,6 @@ async def test_template_context_matches_documented_contract(
     )
 
 
-@pytest.mark.asyncio
-async def test_count_truncated_replaces_count_limit_context_key(context_ds):
-    db = context_ds.databases["fixtures"]
-    previous_count_limit = db.count_limit
-    previous_cached_table_counts = db._cached_table_counts
-    db.count_limit = 10
-    db._cached_table_counts = None
-    try:
-        table_context = await get_template_context(context_ds, "/fixtures/facetable")
-        assert table_context["count"] == 11
-        assert table_context["count_truncated"] is True
-        assert "count_limit" not in table_context
-
-        database_context = await get_template_context(context_ds, "/fixtures")
-        facetable = next(
-            table
-            for table in database_context["tables"]
-            if table["name"] == "facetable"
-        )
-        assert facetable["count"] == 11
-        assert facetable["count_truncated"] is True
-        assert "count_limit" not in database_context
-    finally:
-        db.count_limit = previous_count_limit
-        db._cached_table_counts = previous_cached_table_counts
-
-
 def test_base_context_keys_all_have_docs():
     for name, doc in TEMPLATE_BASE_CONTEXT.items():
         assert doc, "Base context key {} is missing docs".format(name)

From e3ff63b0f93303a8dfe23d8d2d84bbc9551c3eea Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 12:46:15 -0700
Subject: [PATCH 282/386] Warn plugin authors to avoid name conflicts with
 extra_template_vars

Closes #1988
---
 docs/plugin_hooks.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index d2f87e27..66419ec4 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -230,6 +230,10 @@ Function that returns an awaitable function that returns a dictionary
 
 Datasette runs Jinja2 in `async mode <https://jinja.palletsprojects.com/en/2.10.x/api/#async-support>`__, which means you can add awaitable functions to the template scope and they will be automatically awaited when they are rendered by the template.
 
+.. warning::
+
+   Be careful not to accidentally define a variable that conflicts with one that Datasette is already using for something else. Check :ref:`the template context documentation <template_context>` to see the variables defined by Datasette core.
+
 Here's an example plugin that adds a ``"user_agent"`` variable to the template context containing the current request's User-Agent header:
 
 .. code-block:: python

From a4f74d1d2bea4484f026c9adacae6ac961fd0f82 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 12:50:23 -0700
Subject: [PATCH 283/386] More unreleased changes in changelog

---
 docs/changelog.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 697df87d..01ef7f18 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -13,6 +13,11 @@ Unreleased
 - New "Alter table" table action and ``/<database>/<table>/-/alter`` :ref:`JSON API <TableAlterView>` for changing existing tables: add, rename, reorder and drop columns; change column types, defaults, ``NOT NULL`` constraints, primary keys and foreign keys; and rename the table. The alter table dialog also includes a "Drop table" button. (:issue:`2788`)
 - New ``/<database>/-/foreign-key-targets`` and ``/<database>/<table>/-/foreign-key-suggestions`` JSON APIs for discovering valid single-column foreign key targets and suggested relationships.
 - Create and alter table dialogs share their column-editing controls, including literal and expression defaults, custom column types, foreign keys and column ordering.
+- The "Write to this database" page now includes a Create table starter template, alongside the existing Insert, Update and Delete templates. (:pr:`2794`)
+- New :ref:`template_context` documentation listing the variables available to custom templates for Datasette's core pages. Variables documented there are treated as a stable API for custom templates until Datasette 2.0. The documentation is generated from dataclass definitions next to the view code, with tests that compare the documented fields against the actual contexts rendered by the database, table, query and row pages. (:issue:`1510`, :issue:`2127`, :issue:`1477`, :pr:`2803`)
+- Database and table pages now use the ``count_truncated`` template context value to display capped row counts as ``>N rows`.
+- Significant visual improvements to the table filter form UI, plus working add/remove filter buttons. (:issue:`2798`)
+- Improved edit row icon on table pages. (:issue:`2796`)
 
 .. _v1_0_a34:
 

From 5eca46a4bc5adebfb724a1c8e0e42852232152ef Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 13:44:58 -0700
Subject: [PATCH 284/386] Add cache-busted static asset helper (#2804)

* Add cache-busted static asset helper

Add a static() helper for Datasette, plugin, and mounted static assets that appends content-based hashes, caches hashes in production, and serves matching hashed asset URLs with immutable far-future cache headers.

Closes #2800
---
 datasette/app.py                            |  88 +++++++++++-----
 datasette/handle_exception.py               |   1 -
 datasette/templates/_codemirror.html        |   4 +-
 datasette/templates/api_explorer.html       |   2 +-
 datasette/templates/base.html               |   6 +-
 datasette/templates/database.html           |   2 +-
 datasette/templates/debug_allowed.html      |   2 +-
 datasette/templates/debug_autocomplete.html |   2 +-
 datasette/templates/debug_check.html        |   2 +-
 datasette/templates/debug_rules.html        |   2 +-
 datasette/templates/patterns.html           |   2 +-
 datasette/templates/row.html                |   4 +-
 datasette/templates/table.html              |  10 +-
 datasette/utils/__init__.py                 |  11 ++
 datasette/utils/asgi.py                     |  13 ++-
 docs/changelog.rst                          |   3 +-
 docs/contributing.rst                       |   3 +
 docs/custom_templates.rst                   |  39 +++++++
 docs/internals.rst                          |  46 +++++++++
 docs/plugin_hooks.rst                       |   5 +-
 docs/template_context.rst                   |   9 --
 docs/writing_plugins.rst                    |  11 +-
 tests/test_html.py                          |  44 +++++++-
 tests/test_internals_datasette.py           | 108 ++++++++++++++++++++
 tests/test_utils.py                         |   7 ++
 25 files changed, 361 insertions(+), 65 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 57f893fe..9c9b7de4 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -12,7 +12,6 @@ import dataclasses
 import datetime
 import functools
 import glob
-import hashlib
 import httpx
 import importlib.metadata
 import inspect
@@ -123,6 +122,7 @@ from .utils import (
     parse_metadata,
     resolve_env_secrets,
     resolve_routes,
+    sha256_file,
     tilde_decode,
     tilde_encode,
     to_css_class,
@@ -314,7 +314,7 @@ async def favicon(request, send):
         send,
         str(FAVICON_PATH),
         content_type="image/png",
-        headers={"Cache-Control": "max-age=3600, immutable, public"},
+        headers={"Cache-Control": "max-age=3600, public"},
     )
 
 
@@ -348,6 +348,16 @@ def _legacy_template_csrftoken(context):
     return ""
 
 
+def _resolve_static_asset_path(root_path, path):
+    root = Path(root_path).resolve()
+    full_path = (root / path).resolve()
+    try:
+        full_path.relative_to(root)
+    except ValueError:
+        raise ValueError("Static asset path cannot escape static root") from None
+    return full_path
+
+
 # Documentation for the variables Datasette.render_template() adds to the
 # context for every page. This is part of the documented template contract:
 # keys added in render_template() must be documented here - the contract
@@ -361,9 +371,6 @@ TEMPLATE_BASE_CONTEXT = {
     "menu_links": "Async function returning links for the Datasette application menu, including links added by plugins. Each item is a link dictionary with ``href`` and ``label`` keys. See :ref:`plugin_hook_menu_links`; for page action menus that can also include JavaScript-backed buttons, see :ref:`plugin_actions`.",
     "display_actor": "Function that accepts an actor dictionary and returns the display string used in the navigation menu.",
     "show_logout": "True if the logout link should be shown in the navigation menu",
-    "app_css_hash": "Hash of Datasette's app.css contents, used for cache busting",
-    "edit_tools_js_hash": "Hash of Datasette's edit-tools.js contents, used for cache busting",
-    "table_js_hash": "Hash of Datasette's table.js contents, used for cache busting",
     "zip": "Python's ``zip()`` builtin, made available to template logic",
     "body_scripts": 'List of JavaScript snippets contributed by plugins using :ref:`plugin_hook_extra_body_script`. Each item is a dictionary with ``script`` containing JavaScript source and ``module`` indicating whether Datasette will wrap it in ``<script type="module">``; otherwise Datasette wraps it in a regular ``<script>`` block.',
     "format_bytes": "Function that accepts a byte count integer and returns a human-readable string such as ``1.2 MB``.",
@@ -467,6 +474,7 @@ class Datasette:
         self._internal_database.name = INTERNAL_DB_NAME
 
         self.cache_headers = cache_headers
+        self._static_asset_hashes = {}
         self.cors = cors
         config_files = []
         metadata_files = []
@@ -608,6 +616,7 @@ class Datasette:
         environment.filters["escape_css_string"] = escape_css_string
         environment.filters["quote_plus"] = urllib.parse.quote_plus
         environment.globals["csrftoken"] = _legacy_template_csrftoken
+        environment.globals["static"] = self.static
         self._jinja_env = environment
         environment.filters["escape_sqlite"] = escape_sqlite
         environment.filters["to_css_class"] = to_css_class
@@ -1481,24 +1490,55 @@ class Datasette:
 
         return db_plugin_config
 
-    def static_hash(self, filename):
-        if not hasattr(self, "_static_hashes"):
-            self._static_hashes = {}
-        path = os.path.join(str(app_root), "datasette/static", filename)
-        signature = (os.path.getmtime(path), os.path.getsize(path))
-        cached = self._static_hashes.get(filename)
-        if cached and cached["signature"] == signature:
-            return cached["hash"]
-        with open(path) as fp:
-            static_hash = hashlib.sha1(fp.read().encode("utf8")).hexdigest()[:6]
-        self._static_hashes[filename] = {
-            "signature": signature,
-            "hash": static_hash,
-        }
-        return static_hash
+    def _static_asset_path(self, path):
+        return _resolve_static_asset_path(app_root / "datasette" / "static", path)
 
-    def app_css_hash(self):
-        return self.static_hash("app.css")
+    def _static_plugin_asset_path(self, plugin_name, path):
+        for plugin in get_plugins():
+            if not plugin["static_path"]:
+                continue
+            possible_names = {plugin["name"], plugin["name"].replace("-", "_")}
+            if plugin_name in possible_names:
+                return _resolve_static_asset_path(plugin["static_path"], path)
+        raise FileNotFoundError(
+            "No static assets found for plugin {}".format(plugin_name)
+        )
+
+    def _static_mounted_asset(self, mount_name, path):
+        mount_name = mount_name.strip("/")
+        for mount, dirname in self.static_mounts:
+            if mount.strip("/") == mount_name:
+                return (
+                    _resolve_static_asset_path(dirname, path),
+                    self.urls.path("/{}/{}".format(mount_name, path.lstrip("/"))),
+                )
+        raise FileNotFoundError("No static mount found for {}".format(mount_name))
+
+    def _static_asset_hash(self, filepath):
+        filepath = Path(filepath)
+        if self.cache_headers:
+            cached = self._static_asset_hashes.get(filepath)
+            if cached:
+                return cached
+        digest = sha256_file(filepath)[:12]
+        if self.cache_headers:
+            self._static_asset_hashes[filepath] = digest
+        return digest
+
+    def static(self, path, plugin=None, mount=None):
+        if plugin and mount:
+            raise ValueError("Use either plugin= or mount=, not both")
+        if plugin:
+            filepath = self._static_plugin_asset_path(plugin, path)
+            url = self.urls.static_plugins(plugin, path)
+        elif mount:
+            filepath, url = self._static_mounted_asset(mount, path)
+        else:
+            filepath = self._static_asset_path(path)
+            url = self.urls.static(path)
+        hash_value = self._static_asset_hash(filepath)
+        separator = "&" if "?" in url else "?"
+        return url + separator + urllib.parse.urlencode({"_hash": hash_value})
 
     def _prepare_connection(self, conn, database):
         conn.row_factory = sqlite3.Row
@@ -2379,9 +2419,6 @@ class Datasette:
                 "show_logout": request is not None
                 and "ds_actor" in request.cookies
                 and request.actor,
-                "app_css_hash": self.app_css_hash(),
-                "edit_tools_js_hash": self.static_hash("edit-tools.js"),
-                "table_js_hash": self.static_hash("table.js"),
                 "zip": zip,
                 "body_scripts": body_scripts,
                 "format_bytes": format_bytes,
@@ -2480,7 +2517,6 @@ class Datasette:
         add_route(IndexView.as_view(self), r"/(\.(?P<format>jsono?))?$")
         add_route(IndexView.as_view(self), r"/-/(\.(?P<format>jsono?))?$")
         add_route(permanent_redirect("/-/"), r"/-$")
-        # TODO: /favicon.ico and /-/static/ deserve far-future cache expires
         add_route(favicon, "/favicon.ico")
 
         add_route(
diff --git a/datasette/handle_exception.py b/datasette/handle_exception.py
index 96398a4c..2b311644 100644
--- a/datasette/handle_exception.py
+++ b/datasette/handle_exception.py
@@ -66,7 +66,6 @@ def handle_exception(datasette, request, exception):
                     dict(
                         info,
                         urls=datasette.urls,
-                        app_css_hash=datasette.app_css_hash(),
                         menu_links=lambda: [],
                     )
                 ),
diff --git a/datasette/templates/_codemirror.html b/datasette/templates/_codemirror.html
index c4629aeb..75c16168 100644
--- a/datasette/templates/_codemirror.html
+++ b/datasette/templates/_codemirror.html
@@ -1,5 +1,5 @@
-<script src="{{ base_url }}-/static/sql-formatter-2.3.3.min.js" defer></script>
-<script src="{{ base_url }}-/static/cm-editor-6.0.1.bundle.js"></script>
+<script src="{{ static('sql-formatter-2.3.3.min.js') }}" defer></script>
+<script src="{{ static('cm-editor-6.0.1.bundle.js') }}"></script>
 <style>
   .cm-editor {
     resize: both;
diff --git a/datasette/templates/api_explorer.html b/datasette/templates/api_explorer.html
index 58e2a88c..4927cb8d 100644
--- a/datasette/templates/api_explorer.html
+++ b/datasette/templates/api_explorer.html
@@ -3,7 +3,7 @@
 {% block title %}API Explorer{% endblock %}
 
 {% block extra_head %}
-<script src="{{ base_url }}-/static/json-format-highlight-1.0.1.js"></script>
+<script src="{{ static('json-format-highlight-1.0.1.js') }}"></script>
 {% endblock %}
 
 {% block content %}
diff --git a/datasette/templates/base.html b/datasette/templates/base.html
index 82ab48dd..18288439 100644
--- a/datasette/templates/base.html
+++ b/datasette/templates/base.html
@@ -2,13 +2,13 @@
 <html lang="en">
 <head>
     <title>{% block title %}{% endblock %}</title>
-    <link rel="stylesheet" href="{{ urls.static('app.css') }}?{{ app_css_hash }}">
+    <link rel="stylesheet" href="{{ static('app.css') }}">
     <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
 {% for url in extra_css_urls %}
     <link rel="stylesheet" href="{{ url.url }}"{% if url.get("sri") %} integrity="{{ url.sri }}" crossorigin="anonymous"{% endif %}>
 {% endfor %}
 <script>window.datasetteVersion = '{{ datasette_version }}';</script>
-<script src="{{ urls.static('datasette-manager.js') }}" defer></script>
+<script src="{{ static('datasette-manager.js') }}" defer></script>
 {% for url in extra_js_urls %}
     <script {% if url.module %}type="module" {% endif %}src="{{ url.url }}"{% if url.get("sri") %} integrity="{{ url.sri }}" crossorigin="anonymous"{% endif %}></script>
 {% endfor %}
@@ -70,7 +70,7 @@
 {% endfor %}
 
 {% if select_templates %}<!-- Templates considered: {{ select_templates|join(", ") }} -->{% endif %}
-<script src="{{ urls.static('navigation-search.js') }}" defer></script>
+<script src="{{ static('navigation-search.js') }}" defer></script>
 <navigation-search url="{{ urls.path("/-/jump") }}"></navigation-search>
 </body>
 </html>
diff --git a/datasette/templates/database.html b/datasette/templates/database.html
index c09582f7..a9fad8dd 100644
--- a/datasette/templates/database.html
+++ b/datasette/templates/database.html
@@ -8,7 +8,7 @@
 {% include "_sql_parameter_styles.html" %}
 {% if database_page_data.createTable %}
 <script>window._datasetteDatabaseData = {{ database_page_data|tojson }};</script>
-<script src="{{ urls.static('edit-tools.js') }}?hash={{ edit_tools_js_hash }}" defer></script>
+<script src="{{ static('edit-tools.js') }}" defer></script>
 {% endif %}
 {% endblock %}
 
diff --git a/datasette/templates/debug_allowed.html b/datasette/templates/debug_allowed.html
index add3154a..4f8106b8 100644
--- a/datasette/templates/debug_allowed.html
+++ b/datasette/templates/debug_allowed.html
@@ -3,7 +3,7 @@
 {% block title %}Allowed Resources{% endblock %}
 
 {% block extra_head %}
-<script src="{{ base_url }}-/static/json-format-highlight-1.0.1.js"></script>
+<script src="{{ static('json-format-highlight-1.0.1.js') }}"></script>
 {% include "_permission_ui_styles.html" %}
 {% include "_debug_common_functions.html" %}
 {% endblock %}
diff --git a/datasette/templates/debug_autocomplete.html b/datasette/templates/debug_autocomplete.html
index 84dbc14f..380639a3 100644
--- a/datasette/templates/debug_autocomplete.html
+++ b/datasette/templates/debug_autocomplete.html
@@ -4,7 +4,7 @@
 
 {% block extra_head %}
 {{ super() }}
-<script src="{{ urls.static('autocomplete.js') }}" defer></script>
+<script src="{{ static('autocomplete.js') }}" defer></script>
 {% endblock %}
 
 {% block content %}
diff --git a/datasette/templates/debug_check.html b/datasette/templates/debug_check.html
index c2e7997f..3b229a25 100644
--- a/datasette/templates/debug_check.html
+++ b/datasette/templates/debug_check.html
@@ -3,7 +3,7 @@
 {% block title %}Permission Check{% endblock %}
 
 {% block extra_head %}
-<script src="{{ base_url }}-/static/json-format-highlight-1.0.1.js"></script>
+<script src="{{ static('json-format-highlight-1.0.1.js') }}"></script>
 {% include "_permission_ui_styles.html" %}
 {% include "_debug_common_functions.html" %}
 <style>
diff --git a/datasette/templates/debug_rules.html b/datasette/templates/debug_rules.html
index 9a290803..aafa755d 100644
--- a/datasette/templates/debug_rules.html
+++ b/datasette/templates/debug_rules.html
@@ -3,7 +3,7 @@
 {% block title %}Permission Rules{% endblock %}
 
 {% block extra_head %}
-<script src="{{ base_url }}-/static/json-format-highlight-1.0.1.js"></script>
+<script src="{{ static('json-format-highlight-1.0.1.js') }}"></script>
 {% include "_permission_ui_styles.html" %}
 {% include "_debug_common_functions.html" %}
 {% endblock %}
diff --git a/datasette/templates/patterns.html b/datasette/templates/patterns.html
index bff44341..075c0117 100644
--- a/datasette/templates/patterns.html
+++ b/datasette/templates/patterns.html
@@ -2,7 +2,7 @@
 <html lang="en">
 <head>
     <title>Datasette: Pattern Portfolio</title>
-    <link rel="stylesheet" href="{{ base_url }}-/static/app.css?{{ app_css_hash }}">
+    <link rel="stylesheet" href="{{ static('app.css') }}">
     <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
     <meta name="robots" content="noindex">
     <style></style>
diff --git a/datasette/templates/row.html b/datasette/templates/row.html
index 5e483d34..aa1f0ecd 100644
--- a/datasette/templates/row.html
+++ b/datasette/templates/row.html
@@ -7,9 +7,9 @@
 {% if row_mutation_ui %}
 <script>window._datasetteTableData = {{ table_page_data|tojson }};</script>
 {% if table_page_data.foreignKeys %}
-<script src="{{ urls.static('autocomplete.js') }}" defer></script>
+<script src="{{ static('autocomplete.js') }}" defer></script>
 {% endif %}
-<script src="{{ urls.static('edit-tools.js') }}?hash={{ edit_tools_js_hash }}" defer></script>
+<script src="{{ static('edit-tools.js') }}" defer></script>
 {% endif %}
 <style>
 @media only screen and (max-width: 576px) {
diff --git a/datasette/templates/table.html b/datasette/templates/table.html
index b7b776ab..c2131360 100644
--- a/datasette/templates/table.html
+++ b/datasette/templates/table.html
@@ -5,13 +5,13 @@
 {% block extra_head %}
 {{- super() -}}
 <script>window._datasetteTableData = {{ table_page_data|tojson }};</script>
-<script src="{{ urls.static('column-chooser.js') }}" defer></script>
+<script src="{{ static('column-chooser.js') }}" defer></script>
 {% if table_page_data.foreignKeys %}
-<script src="{{ urls.static('autocomplete.js') }}" defer></script>
+<script src="{{ static('autocomplete.js') }}" defer></script>
 {% endif %}
-<script src="{{ urls.static('edit-tools.js') }}?hash={{ edit_tools_js_hash }}" defer></script>
-<script src="{{ urls.static('table.js') }}?hash={{ table_js_hash }}" defer></script>
-<script src="{{ urls.static('mobile-column-actions.js') }}" defer></script>
+<script src="{{ static('edit-tools.js') }}" defer></script>
+<script src="{{ static('table.js') }}" defer></script>
+<script src="{{ static('mobile-column-actions.js') }}" defer></script>
 <script>DATASETTE_ALLOW_FACET = {{ datasette_allow_facet }};</script>
 <style>
 @media only screen and (max-width: 576px) {
diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 55e539b9..9174dca7 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -1548,6 +1548,17 @@ def md5_not_usedforsecurity(s):
 _etag_cache = {}
 
 
+def sha256_file(filepath, chunk_size=4096):
+    hasher = hashlib.sha256()
+    with open(filepath, "rb") as fp:
+        while True:
+            chunk = fp.read(chunk_size)
+            if not chunk:
+                break
+            hasher.update(chunk)
+    return hasher.hexdigest()
+
+
 async def calculate_etag(filepath, chunk_size=4096):
     if filepath in _etag_cache:
         return _etag_cache[filepath]
diff --git a/datasette/utils/asgi.py b/datasette/utils/asgi.py
index 93084365..e1631b10 100644
--- a/datasette/utils/asgi.py
+++ b/datasette/utils/asgi.py
@@ -1,6 +1,6 @@
 import json
 from typing import Optional
-from datasette.utils import MultiParams, calculate_etag
+from datasette.utils import MultiParams, calculate_etag, sha256_file
 from datasette.utils.multipart import (
     parse_form_data,
     MultipartParseError,
@@ -397,6 +397,9 @@ async def asgi_send_file(
             )
 
 
+HASHED_STATIC_CACHE_CONTROL = "max-age=31536000, immutable, public"
+
+
 def asgi_static(root_path, chunk_size=4096, headers=None, content_type=None):
     root_path = Path(root_path)
     static_headers = {}
@@ -423,11 +426,17 @@ def asgi_static(root_path, chunk_size=4096, headers=None, content_type=None):
             return
         try:
             # Calculate ETag for filepath
+            hash_value = request.args.get("_hash")
+            if (
+                hash_value
+                and hash_value == sha256_file(full_path, chunk_size=chunk_size)[:12]
+            ):
+                headers["Cache-Control"] = HASHED_STATIC_CACHE_CONTROL
             etag = await calculate_etag(full_path, chunk_size=chunk_size)
             headers["ETag"] = etag
             if_none_match = request.headers.get("if-none-match")
             if if_none_match and if_none_match == etag:
-                return await asgi_send(send, "", 304)
+                return await asgi_send(send, "", 304, headers=headers)
             await asgi_send_file(
                 send, full_path, chunk_size=chunk_size, headers=headers
             )
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 01ef7f18..3ad8e0da 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -15,7 +15,8 @@ Unreleased
 - Create and alter table dialogs share their column-editing controls, including literal and expression defaults, custom column types, foreign keys and column ordering.
 - The "Write to this database" page now includes a Create table starter template, alongside the existing Insert, Update and Delete templates. (:pr:`2794`)
 - New :ref:`template_context` documentation listing the variables available to custom templates for Datasette's core pages. Variables documented there are treated as a stable API for custom templates until Datasette 2.0. The documentation is generated from dataclass definitions next to the view code, with tests that compare the documented fields against the actual contexts rendered by the database, table, query and row pages. (:issue:`1510`, :issue:`2127`, :issue:`1477`, :pr:`2803`)
-- Database and table pages now use the ``count_truncated`` template context value to display capped row counts as ``>N rows`.
+- New ``static()`` template function and ``datasette.static()`` method for generating cache-busting static asset URLs based on the file contents. Static assets served with a matching ``?_hash=`` parameter now receive far-future immutable cache headers. This works for Datasette's bundled static assets, plugin static assets and directories mounted using ``--static``. See :ref:`customization_static_files`.
+- Database and table pages now use the ``count_truncated`` template context value to display capped row counts as ``>N rows``.
 - Significant visual improvements to the table filter form UI, plus working add/remove filter buttons. (:issue:`2798`)
 - Improved edit row icon on table pages. (:issue:`2796`)
 
diff --git a/docs/contributing.rst b/docs/contributing.rst
index 142c2f41..692f94c8 100644
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -157,6 +157,9 @@ If you want to change Datasette's Python code you can use the ``--reload`` optio
 
     uv run datasette --reload fixtures.db
 
+This also enables development mode for static asset cache busting, described in
+:ref:`customization_static_files`.
+
 You can also use the ``fixtures.py`` script to recreate the testing version of ``metadata.json`` used by the unit tests. To do that::
 
     uv run python tests/fixtures.py fixtures.db fixtures-metadata.json
diff --git a/docs/custom_templates.rst b/docs/custom_templates.rst
index f28f1189..bfbd1725 100644
--- a/docs/custom_templates.rst
+++ b/docs/custom_templates.rst
@@ -151,6 +151,45 @@ You can reference those files from ``datasette.yaml`` like this, see :ref:`custo
         }
 .. [[[end]]]
 
+If you reference those files from a custom template, use the ``static()``
+template function to create a cache-busting URL based on the file contents.
+Pass the mount point as the ``mount=`` argument, and pass a path relative to
+that mounted directory:
+
+.. code-block:: html+jinja
+
+    <link rel="stylesheet" href="{{ static('styles.css', mount='assets') }}">
+    <script src="{{ static('app.js', mount='assets') }}" defer></script>
+
+The returned URL will include a ``?_hash=`` parameter and will take the
+``base_url`` setting into account. When that hash matches the current file
+contents, Datasette will serve the static asset with a far-future immutable
+``Cache-Control`` header. You can also use ``urls.path()`` if you want to link
+to the mounted file without adding a content hash:
+
+.. code-block:: html+jinja
+
+    <link rel="stylesheet" href="{{ urls.path('/assets/styles.css') }}">
+
+When Datasette is run using ``--reload``, the file contents are hashed every time
+the template is rendered, so edits to static files will update their URLs
+without restarting Datasette. Without ``--reload``, the hash is cached for the
+lifetime of the Datasette process.
+
+You can use the same function for Datasette's bundled static assets, omitting
+``mount=``:
+
+.. code-block:: html+jinja
+
+    <link rel="stylesheet" href="{{ static('app.css') }}">
+
+For plugin static assets, pass the plugin name using ``plugin=`` and a path
+relative to the plugin's ``static/`` directory:
+
+.. code-block:: html+jinja
+
+    <script src="{{ static('plugin.js', plugin='datasette_plugin_name') }}" defer></script>
+
 Publishing static assets
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
diff --git a/docs/internals.rst b/docs/internals.rst
index 06027f42..c826de1a 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -451,6 +451,52 @@ await .render_template(template, context=None, request=None)
 
 Renders a `Jinja template <https://jinja.palletsprojects.com/en/2.11.x/>`__ using Datasette's preconfigured instance of Jinja and returns the resulting string. The template will have access to Datasette's default template functions and any functions that have been made available by other plugins.
 
+.. _datasette_static:
+
+.static(path, plugin=None, mount=None)
+--------------------------------------
+
+``path`` - string
+    The path to the static asset, relative to the selected static directory.
+
+``plugin`` - string, optional
+    The plugin name, for linking to an asset in that plugin's ``static/``
+    directory.
+
+``mount`` - string, optional
+    The ``--static`` mount name, for linking to an asset in a directory mounted
+    using ``datasette --static mount_name:directory``.
+
+Returns a URL for a static asset with a ``?_hash=`` parameter based on the file
+contents. That URL takes the ``base_url`` setting into account.
+
+When the ``?_hash=`` parameter matches the current file contents, Datasette will
+serve the asset with ``Cache-Control: max-age=31536000, immutable, public``.
+
+Call this with just ``path`` for one of Datasette's bundled static assets:
+
+.. code-block:: python
+
+    datasette.static("app.css")
+
+Use ``plugin=`` for plugin static assets:
+
+.. code-block:: python
+
+    datasette.static(
+        "plugin.js", plugin="datasette_plugin_name"
+    )
+
+Use ``mount=`` for static directories mounted using the ``--static`` option:
+
+.. code-block:: python
+
+    datasette.static("styles.css", mount="assets")
+
+``plugin`` and ``mount`` are mutually exclusive. The same feature is available
+to Jinja templates as the ``static()`` template function, described in
+:ref:`customization_static_files`.
+
 .. _datasette_actors_from_ids:
 
 await .actors_from_ids(actor_ids)
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 66419ec4..81ef4acd 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1968,9 +1968,8 @@ Here is a minimal plugin example that adds a button to a table page and loads Ja
     @hookimpl
     def extra_js_urls(datasette):
         return [
-            datasette.urls.static_plugins(
-                "datasette_show_table",
-                "show-table.js",
+            datasette.static(
+                "show-table.js", plugin="datasette_show_table"
             )
         ]
 
diff --git a/docs/template_context.rst b/docs/template_context.rst
index 52ccca49..5c6b1567 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -47,15 +47,6 @@ These variables are available on every page rendered by Datasette, including pag
 ``show_logout``
     True if the logout link should be shown in the navigation menu
 
-``app_css_hash``
-    Hash of Datasette's app.css contents, used for cache busting
-
-``edit_tools_js_hash``
-    Hash of Datasette's edit-tools.js contents, used for cache busting
-
-``table_js_hash``
-    Hash of Datasette's table.js contents, used for cache busting
-
 ``zip``
     Python's ``zip()`` builtin, made available to template logic
 
diff --git a/docs/writing_plugins.rst b/docs/writing_plugins.rst
index cd165a3f..d1e5e75a 100644
--- a/docs/writing_plugins.rst
+++ b/docs/writing_plugins.rst
@@ -145,7 +145,16 @@ If your plugin has a ``static/`` directory, Datasette will automatically configu
 
     /-/static-plugins/NAME_OF_PLUGIN_PACKAGE/yourfile.js
 
-Use the ``datasette.urls.static_plugins(plugin_name, path)`` method to generate URLs to that asset that take the ``base_url`` setting into account, see :ref:`internals_datasette_urls`.
+Use the ``datasette.static(path, plugin=plugin_name)`` method to generate
+cache-busting URLs to those assets that take the ``base_url`` setting into
+account, see :ref:`datasette_static`.
+
+This can also be used from plugin templates as the ``static()`` template
+function:
+
+.. code-block:: html+jinja
+
+    <script src="{{ static('plugin.js', plugin='datasette_plugin_name') }}" defer></script>
 
 To bundle the static assets for a plugin in the package that you publish to PyPI, add the following to the plugin's ``setup.py``:
 
diff --git a/tests/test_html.py b/tests/test_html.py
index 20ab22bc..22943300 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -4,6 +4,7 @@ from datasette.utils import allowed_pragmas
 from .fixtures import make_app_client
 from .utils import assert_footer_links, inner_html
 import copy
+import hashlib
 import json
 import pathlib
 import pytest
@@ -83,7 +84,7 @@ async def test_homepage_options(ds_client):
 async def test_favicon(ds_client):
     response = await ds_client.get("/favicon.ico")
     assert response.status_code == 200
-    assert response.headers["cache-control"] == "max-age=3600, immutable, public"
+    assert response.headers["cache-control"] == "max-age=3600, public"
     assert int(response.headers["content-length"]) > 100
     assert response.headers["content-type"] == "image/png"
 
@@ -101,6 +102,24 @@ async def test_static(ds_client):
     assert response.status_code == 304
 
 
+@pytest.mark.asyncio
+async def test_static_hash_cache_control(ds_client):
+    hashed_url = ds_client.ds.static("app.css")
+    response = await ds_client.get(hashed_url)
+    assert response.status_code == 200
+    assert response.headers["cache-control"] == "max-age=31536000, immutable, public"
+
+    response = await ds_client.get(
+        hashed_url, headers={"if-none-match": response.headers["etag"]}
+    )
+    assert response.status_code == 304
+    assert response.headers["cache-control"] == "max-age=31536000, immutable, public"
+
+    response = await ds_client.get("/-/static/app.css?_hash=incorrect")
+    assert response.status_code == 200
+    assert "cache-control" not in response.headers
+
+
 def test_static_mounts():
     with make_app_client(
         static_mounts=[("custom-static", str(pathlib.Path(__file__).parent))]
@@ -113,6 +132,23 @@ def test_static_mounts():
         assert response.status_code == 404
 
 
+def test_static_mounts_hash_cache_control():
+    mount_path = pathlib.Path(__file__).parent
+    with make_app_client(static_mounts=[("custom-static", str(mount_path))]) as client:
+        response = client.get(client.ds.static("test_html.py", mount="custom-static"))
+        assert response.status_code == 200
+        assert (
+            response.headers["cache-control"] == "max-age=31536000, immutable, public"
+        )
+
+        incorrect_hash = hashlib.sha256(b"incorrect").hexdigest()[:12]
+        response = client.get(
+            "/custom-static/test_html.py?_hash={}".format(incorrect_hash)
+        )
+        assert response.status_code == 200
+        assert "cache-control" not in response.headers
+
+
 def test_memory_database_page():
     with make_app_client(memory=True) as client:
         response = client.get("/_memory")
@@ -609,7 +645,7 @@ async def test_404(ds_client, path):
     response = await ds_client.get(path)
     assert response.status_code == 404
     assert (
-        f'<link rel="stylesheet" href="/-/static/app.css?{ds_client.ds.app_css_hash()}'
+        '<link rel="stylesheet" href="{}"'.format(ds_client.ds.static("app.css"))
         in response.text
     )
 
@@ -1082,7 +1118,9 @@ async def test_navigation_menu_links(
     navigation_search_script = soup.find(
         "script", {"src": re.compile(r"navigation-search\.js")}
     )
-    assert navigation_search_script["src"] == "/-/static/navigation-search.js"
+    assert navigation_search_script["src"] == ds_client.ds.static(
+        "navigation-search.js"
+    )
     assert details.find("li").find("button") == search_button
     if not actor_id:
         # The app menu is always visible, but anonymous users do not see logout
diff --git a/tests/test_internals_datasette.py b/tests/test_internals_datasette.py
index e9c78ecc..2eaee3f9 100644
--- a/tests/test_internals_datasette.py
+++ b/tests/test_internals_datasette.py
@@ -4,6 +4,8 @@ Tests for the datasette.app.Datasette class
 
 import asyncio
 import dataclasses
+import hashlib
+import importlib
 import os
 import sqlite3
 import time
@@ -11,6 +13,7 @@ from datasette import Context
 from datasette.app import Datasette, Database, ResourcesSQL
 from datasette.database import DatasetteClosedError
 from datasette.resources import DatabaseResource
+from datasette.utils import PrefixedUrlString
 from itsdangerous import BadSignature
 import pytest
 
@@ -56,6 +59,111 @@ def test_datasette_setting(datasette, setting, expected):
     assert datasette.setting(setting) == expected
 
 
+def _setup_static_app_root(tmp_path, monkeypatch, filename, content):
+    app_module = importlib.import_module("datasette.app")
+    app_root = tmp_path / "app-root"
+    static_path = app_root / "datasette" / "static"
+    static_path.mkdir(parents=True)
+    asset_path = static_path / filename
+    asset_path.write_bytes(content)
+    monkeypatch.setattr(app_module, "app_root", app_root)
+    return asset_path
+
+
+@pytest.mark.asyncio
+async def test_static_template_function_hashes_core_asset(tmp_path, monkeypatch):
+    _setup_static_app_root(tmp_path, monkeypatch, "demo.js", b"const demo = true;")
+    ds = Datasette()
+    template = ds.get_jinja_environment().from_string("{{ static('demo.js') }}")
+    expected_hash = hashlib.sha256(b"const demo = true;").hexdigest()[:12]
+
+    assert await template.render_async() == "/-/static/demo.js?_hash={}".format(
+        expected_hash
+    )
+    assert isinstance(ds.static("demo.js"), PrefixedUrlString)
+
+
+def test_static_hash_cached_when_cache_headers_enabled(tmp_path, monkeypatch):
+    asset_path = _setup_static_app_root(tmp_path, monkeypatch, "demo.js", b"let a = 1;")
+    ds = Datasette(cache_headers=True)
+    first_url = ds.static("demo.js")
+
+    asset_path.write_bytes(b"let a = 2;")
+
+    assert ds.static("demo.js") == first_url
+
+
+def test_static_hash_recalculated_when_cache_headers_disabled(tmp_path, monkeypatch):
+    asset_path = _setup_static_app_root(tmp_path, monkeypatch, "demo.js", b"let a = 1;")
+    ds = Datasette(cache_headers=False)
+    first_url = ds.static("demo.js")
+
+    asset_path.write_bytes(b"let a = 2;")
+
+    expected_hash = hashlib.sha256(b"let a = 2;").hexdigest()[:12]
+    assert ds.static("demo.js") == "/-/static/demo.js?_hash={}".format(expected_hash)
+    assert ds.static("demo.js") != first_url
+
+
+def test_static_hashes_mounted_static_file(tmp_path):
+    static_path = tmp_path / "static-files"
+    static_path.mkdir()
+    asset_path = static_path / "styles.css"
+    asset_path.write_bytes(b"body { color: black; }")
+    ds = Datasette(static_mounts=[("assets", str(static_path))])
+    expected_hash = hashlib.sha256(b"body { color: black; }").hexdigest()[:12]
+
+    assert ds.static("styles.css", mount="assets") == (
+        "/assets/styles.css?_hash={}".format(expected_hash)
+    )
+
+    ds._settings["base_url"] = "/prefix/"
+    assert ds.static("styles.css", mount="assets") == (
+        "/prefix/assets/styles.css?_hash={}".format(expected_hash)
+    )
+
+
+def test_static_hashes_plugin_static_file(tmp_path, monkeypatch):
+    plugin_static_path = tmp_path / "plugin-static"
+    plugin_static_path.mkdir()
+    asset_path = plugin_static_path / "plugin.js"
+    asset_path.write_bytes(b"console.log('plugin');")
+    app_module = importlib.import_module("datasette.app")
+    monkeypatch.setattr(
+        app_module,
+        "get_plugins",
+        lambda: [
+            {
+                "name": "datasette-cluster-map",
+                "static_path": str(plugin_static_path),
+                "templates_path": None,
+            }
+        ],
+    )
+    ds = Datasette()
+    expected_hash = hashlib.sha256(b"console.log('plugin');").hexdigest()[:12]
+
+    assert ds.static("plugin.js", plugin="datasette_cluster_map") == (
+        "/-/static-plugins/datasette_cluster_map/plugin.js?_hash={}".format(
+            expected_hash
+        )
+    )
+
+
+def test_static_rejects_plugin_and_mount():
+    ds = Datasette()
+    with pytest.raises(ValueError):
+        ds.static("styles.css", plugin="datasette_cluster_map", mount="assets")
+
+
+def test_static_rejects_path_traversal(tmp_path, monkeypatch):
+    _setup_static_app_root(tmp_path, monkeypatch, "demo.js", b"")
+    ds = Datasette()
+
+    with pytest.raises(ValueError, match="cannot escape static root"):
+        ds.static("../secret.js")
+
+
 @pytest.mark.asyncio
 async def test_datasette_constructor():
     ds = Datasette()
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 74f1963f..8d080a8a 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -11,6 +11,7 @@ from datasette.utils.sqlite import (
     sqlite_table_type,
     supports_returning,
 )
+import hashlib
 import json
 import os
 import pathlib
@@ -835,6 +836,12 @@ def test_pairs_to_nested_config(pairs, expected):
     assert actual == expected
 
 
+def test_sha256_file(tmp_path):
+    path = tmp_path / "test.txt"
+    path.write_text("hello")
+    assert utils.sha256_file(path, chunk_size=2) == hashlib.sha256(b"hello").hexdigest()
+
+
 @pytest.mark.asyncio
 async def test_calculate_etag(tmp_path):
     path = tmp_path / "test.txt"

From 39f1df59975f57ba011f13a181c1ca801f3296a8 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 13:59:01 -0700
Subject: [PATCH 285/386] Improve docs structure for static(), refs #2804,
 #2800

---
 docs/custom_templates.rst | 91 +++++++++++++++++++++------------------
 1 file changed, 48 insertions(+), 43 deletions(-)

diff --git a/docs/custom_templates.rst b/docs/custom_templates.rst
index bfbd1725..50c23b3e 100644
--- a/docs/custom_templates.rst
+++ b/docs/custom_templates.rst
@@ -94,11 +94,55 @@ The ``core`` class is particularly useful - you can apply this directly to a ``<
 
 .. _customization_static_files:
 
-Serving static files
-~~~~~~~~~~~~~~~~~~~~
+Linking to static assets
+~~~~~~~~~~~~~~~~~~~~~~~~
 
-Datasette can serve static files for you, using the ``--static`` option.
-Consider the following directory structure::
+Use the ``static()`` template function to create cache-busting URLs to static
+assets from your custom templates. It returns a URL with a ``?_hash=`` parameter
+based on the file contents and takes the ``base_url`` setting into account.
+
+When the hash in the URL matches the current file contents, Datasette will serve
+the static asset with a far-future immutable ``Cache-Control`` header.
+
+When Datasette is run using ``--reload``, the file contents are hashed every time
+the template is rendered, so edits to static files will update their URLs
+without restarting Datasette. Without ``--reload``, the hash is cached for the
+lifetime of the Datasette process.
+
+For Datasette's bundled static assets, pass the path to the asset:
+
+.. code-block:: html+jinja
+
+    <link rel="stylesheet" href="{{ static('app.css') }}">
+
+For plugin static assets, pass the plugin name using ``plugin=`` and a path
+relative to the plugin's ``static/`` directory:
+
+.. code-block:: html+jinja
+
+    <script src="{{ static('plugin.js', plugin='datasette_plugin_name') }}" defer></script>
+
+For files served from a directory mounted using ``--static assets:static-files/``,
+pass the mount point name using ``mount=`` and a path relative to that mounted
+directory:
+
+.. code-block:: html+jinja
+
+    <link rel="stylesheet" href="{{ static('styles.css', mount='assets') }}">
+    <script src="{{ static('app.js', mount='assets') }}" defer></script>
+
+You can also use ``urls.path()`` if you want to link to a mounted file without
+adding a content hash:
+
+.. code-block:: html+jinja
+
+    <link rel="stylesheet" href="{{ urls.path('/assets/styles.css') }}">
+
+Serving files from a directory
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Datasette can serve static files from a directory for you, using the ``--static``
+option. Consider the following directory structure::
 
     metadata.json
     static-files/styles.css
@@ -151,45 +195,6 @@ You can reference those files from ``datasette.yaml`` like this, see :ref:`custo
         }
 .. [[[end]]]
 
-If you reference those files from a custom template, use the ``static()``
-template function to create a cache-busting URL based on the file contents.
-Pass the mount point as the ``mount=`` argument, and pass a path relative to
-that mounted directory:
-
-.. code-block:: html+jinja
-
-    <link rel="stylesheet" href="{{ static('styles.css', mount='assets') }}">
-    <script src="{{ static('app.js', mount='assets') }}" defer></script>
-
-The returned URL will include a ``?_hash=`` parameter and will take the
-``base_url`` setting into account. When that hash matches the current file
-contents, Datasette will serve the static asset with a far-future immutable
-``Cache-Control`` header. You can also use ``urls.path()`` if you want to link
-to the mounted file without adding a content hash:
-
-.. code-block:: html+jinja
-
-    <link rel="stylesheet" href="{{ urls.path('/assets/styles.css') }}">
-
-When Datasette is run using ``--reload``, the file contents are hashed every time
-the template is rendered, so edits to static files will update their URLs
-without restarting Datasette. Without ``--reload``, the hash is cached for the
-lifetime of the Datasette process.
-
-You can use the same function for Datasette's bundled static assets, omitting
-``mount=``:
-
-.. code-block:: html+jinja
-
-    <link rel="stylesheet" href="{{ static('app.css') }}">
-
-For plugin static assets, pass the plugin name using ``plugin=`` and a path
-relative to the plugin's ``static/`` directory:
-
-.. code-block:: html+jinja
-
-    <script src="{{ static('plugin.js', plugin='datasette_plugin_name') }}" defer></script>
-
 Publishing static assets
 ~~~~~~~~~~~~~~~~~~~~~~~~
 

From 22ccd8a087903e4d04547fc33bf2d0b43d998520 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 14:04:20 -0700
Subject: [PATCH 286/386] escape_sqlite() favors double quotes, closes #2795

---
 datasette/utils/__init__.py |  7 +------
 tests/test_utils.py         | 28 +++++++++++++++++++++++-----
 2 files changed, 24 insertions(+), 11 deletions(-)

diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 9174dca7..b4ede953 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -410,12 +410,7 @@ def escape_css_string(s):
 def escape_sqlite(s):
     if _boring_keyword_re.match(s) and (s.lower() not in reserved_words):
         return s
-    elif "]" in s:
-        # SQLite does not support escaping ] inside [bracket] quoting, so fall
-        # back to double-quote quoting (doubling any embedded ") - #2677
-        return '"{}"'.format(s.replace('"', '""'))
-    else:
-        return f"[{s}]"
+    return '"{}"'.format(s.replace('"', '""'))
 
 
 def make_dockerfile(
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 8d080a8a..38ebb51e 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -221,11 +221,10 @@ def test_detect_fts(open_quote, close_quote):
     "identifier,expected",
     (
         ("plain", "plain"),
-        ("select", "[select]"),
-        ("has space", "[has space]"),
-        ("has'quote", "[has'quote]"),
-        # Identifiers containing ] must fall back to double-quote quoting
-        # (SQLite does not support escaping ] inside [brackets]) - #2677
+        ("select", '"select"'),
+        ("has space", '"has space"'),
+        ("has'quote", '"has\'quote"'),
+        ('has"dquote', '"has""dquote"'),
         ("has]bracket", '"has]bracket"'),
         ('has"dquote]', '"has""dquote]"'),
     ),
@@ -234,6 +233,25 @@ def test_escape_sqlite(identifier, expected):
     assert utils.escape_sqlite(identifier) == expected
 
 
+def test_escape_sqlite_double_quotes_work_in_query():
+    conn = utils.sqlite3.connect(":memory:")
+    table = 'table with "double quotes"'
+    column = "select"
+    escaped_table = utils.escape_sqlite(table)
+    escaped_column = utils.escape_sqlite(column)
+    conn.execute(f"CREATE TABLE {escaped_table} ({escaped_column} TEXT)")
+    create_sql = conn.execute(
+        "SELECT sql FROM sqlite_master WHERE type = 'table' AND name = ?", (table,)
+    ).fetchone()[0]
+    assert create_sql == 'CREATE TABLE "table with ""double quotes""" ("select" TEXT)'
+    conn.execute(
+        f"INSERT INTO {escaped_table} ({escaped_column}) VALUES (?)", ("hello",)
+    )
+    results = conn.execute(f"SELECT {escaped_column} FROM {escaped_table}").fetchall()
+    conn.close()
+    assert results == [("hello",)]
+
+
 def test_escape_sqlite_prevents_injection():
     # https://github.com/simonw/datasette/issues/2677
     conn = utils.sqlite3.connect(":memory:")

From a5931594ded88dbc1569c5f8e3ff1d187edfb0a4 Mon Sep 17 00:00:00 2001
From: Sebastian Cao <cycsmail@gmail.com>
Date: Wed, 24 Jun 2026 05:07:56 +0800
Subject: [PATCH 287/386] Document how actors are displayed (#2792)

Closes #2002
---
 docs/authentication.rst | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/docs/authentication.rst b/docs/authentication.rst
index 5d831da0..8101699c 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -21,6 +21,23 @@ The actor dictionary can be any shape - the design of that data structure is lef
 
 Plugins can use the :ref:`plugin_hook_actor_from_request` hook to implement custom logic for authenticating an actor based on the incoming HTTP request.
 
+.. _authentication_actor_display:
+
+How actors are displayed
+------------------------
+
+In a number of places - such as the navigation menu and the ``/-/logout`` page - Datasette needs to display a short label representing the currently authenticated actor.
+
+To decide what to show, Datasette looks through the following keys in the actor dictionary and uses the value of the first one that is present and not empty:
+
+* ``display``
+* ``name``
+* ``username``
+* ``login``
+* ``id``
+
+If none of those keys have a value the actor dictionary is displayed as a string instead.
+
 .. _authentication_root:
 
 Using the "root" actor

From a913ba372a87ab6a61c16f35b7159aeb0f97160d Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 14:09:27 -0700
Subject: [PATCH 288/386] Changelog note for #2002

Refs #2792
---
 docs/changelog.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 3ad8e0da..739d015e 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -19,6 +19,7 @@ Unreleased
 - Database and table pages now use the ``count_truncated`` template context value to display capped row counts as ``>N rows``.
 - Significant visual improvements to the table filter form UI, plus working add/remove filter buttons. (:issue:`2798`)
 - Improved edit row icon on table pages. (:issue:`2796`)
+- Documentation covers how actors are displayed. Thanks, [Sebastian Cao](https://github.com/cycsmail). (:issue:`2002`)
 
 .. _v1_0_a34:
 

From 463eea2bd0dabe48ec7f004ff96d78f3178183a5 Mon Sep 17 00:00:00 2001
From: Ritesh Kewlani <riteshkew1001@gmail.com>
Date: Wed, 24 Jun 2026 02:48:49 +0530
Subject: [PATCH 289/386] Fix _col=<pk> producing duplicate column in output
 (#2774)

Closes #1975
---
 datasette/views/table.py |  4 ++--
 tests/test_table_api.py  | 10 ++++++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 4b923d20..1fc151e6 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1606,8 +1606,8 @@ async def _columns_to_select(table_columns, pks, request):
                 "_col={} - invalid columns".format(", ".join(bad_columns)),
                 status=400,
             )
-        # De-duplicate maintaining order:
-        columns.extend(dict.fromkeys(_cols))
+        # De-duplicate maintaining order, skipping columns already added (pks):
+        columns.extend(c for c in dict.fromkeys(_cols) if c not in columns)
     if "_nocol" in request.args:
         # Return all columns EXCEPT these
         bad_columns = [
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 0cb67164..272e39e3 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -1420,6 +1420,16 @@ def test_generated_columns_are_visible_in_datasette():
             "/fixtures/facetable.json?_col=state&_col=state",
             ["pk", "state"],
         ),
+        (
+            # https://github.com/simonw/datasette/issues/1975
+            "/fixtures/facetable.json?_col=pk&_col=state",
+            ["pk", "state"],
+        ),
+        (
+            # https://github.com/simonw/datasette/issues/1975
+            "/fixtures/facetable.json?_col=pk",
+            ["pk"],
+        ),
         (
             "/fixtures/facetable.json?_col=state&_col=created&_nocol=created",
             ["pk", "state"],

From 85be50ac71f58ca98887c5ed8754e7411e978617 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 14:22:14 -0700
Subject: [PATCH 290/386] Changelog entry for #1975

Plus fixed broken rst link
---
 docs/changelog.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 739d015e..df526c32 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -19,7 +19,8 @@ Unreleased
 - Database and table pages now use the ``count_truncated`` template context value to display capped row counts as ``>N rows``.
 - Significant visual improvements to the table filter form UI, plus working add/remove filter buttons. (:issue:`2798`)
 - Improved edit row icon on table pages. (:issue:`2796`)
-- Documentation covers how actors are displayed. Thanks, [Sebastian Cao](https://github.com/cycsmail). (:issue:`2002`)
+- Documentation covers how actors are displayed. Thanks, `Sebastian Cao <https://github.com/cycsmail>`__. (:issue:`2002`)
+- Fix for bug where appending ``?_col=pk`` resulted in duplicate primary key columns in the response. Thanks, `Ritesh Kewlani <https://github.com/riteshkew>`__. (:issue:`1975`)
 
 .. _v1_0_a34:
 

From 753fa3b3168878c497777488481a88c9efa637a2 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 14:30:08 -0700
Subject: [PATCH 291/386] Release 1.0a35

Refs #1477, #1510, #1975, #2002, #2127, #2787, #2788, #2794, #2796, #2798, #2803
---
 datasette/version.py | 2 +-
 docs/changelog.rst   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/datasette/version.py b/datasette/version.py
index 12fa170e..49d270e4 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a34"
+__version__ = "1.0a35"
 __version_info__ = tuple(__version__.split("."))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index df526c32..0ed231fd 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,10 +4,10 @@
 Changelog
 =========
 
-.. _unreleased:
+.. _v1_0_a35:
 
-Unreleased
-----------
+1.0a35 (2026-06-23)
+-------------------
 
 - New "Create table" interface in the database actions menu, backed by the ``/<database>/-/create`` :ref:`JSON API <TableCreateView>`. It can define columns, primary keys, custom column types, ``NOT NULL`` constraints, literal defaults, expression defaults and single-column foreign keys. (:issue:`2787`)
 - New "Alter table" table action and ``/<database>/<table>/-/alter`` :ref:`JSON API <TableAlterView>` for changing existing tables: add, rename, reorder and drop columns; change column types, defaults, ``NOT NULL`` constraints, primary keys and foreign keys; and rename the table. The alter table dialog also includes a "Drop table" button. (:issue:`2788`)

From 488c9cf3d3ba40084f4073c23a53c11c94addab4 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 23 Jun 2026 14:33:20 -0700
Subject: [PATCH 292/386] Small tweaks to 1.0a35 release notes prior to release

---
 docs/changelog.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 0ed231fd..ec32b57e 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -9,12 +9,13 @@ Changelog
 1.0a35 (2026-06-23)
 -------------------
 
+This release adds UI for **creating tables** and **altering tables**, to complement the insert and update row interfaces added in :ref:`v1_0_a34`.
+
 - New "Create table" interface in the database actions menu, backed by the ``/<database>/-/create`` :ref:`JSON API <TableCreateView>`. It can define columns, primary keys, custom column types, ``NOT NULL`` constraints, literal defaults, expression defaults and single-column foreign keys. (:issue:`2787`)
 - New "Alter table" table action and ``/<database>/<table>/-/alter`` :ref:`JSON API <TableAlterView>` for changing existing tables: add, rename, reorder and drop columns; change column types, defaults, ``NOT NULL`` constraints, primary keys and foreign keys; and rename the table. The alter table dialog also includes a "Drop table" button. (:issue:`2788`)
 - New ``/<database>/-/foreign-key-targets`` and ``/<database>/<table>/-/foreign-key-suggestions`` JSON APIs for discovering valid single-column foreign key targets and suggested relationships.
-- Create and alter table dialogs share their column-editing controls, including literal and expression defaults, custom column types, foreign keys and column ordering.
-- The "Write to this database" page now includes a Create table starter template, alongside the existing Insert, Update and Delete templates. (:pr:`2794`)
 - New :ref:`template_context` documentation listing the variables available to custom templates for Datasette's core pages. Variables documented there are treated as a stable API for custom templates until Datasette 2.0. The documentation is generated from dataclass definitions next to the view code, with tests that compare the documented fields against the actual contexts rendered by the database, table, query and row pages. (:issue:`1510`, :issue:`2127`, :issue:`1477`, :pr:`2803`)
+- The "Write to this database" page now includes a Create table starter template, alongside the existing Insert, Update and Delete templates. (:pr:`2794`)
 - New ``static()`` template function and ``datasette.static()`` method for generating cache-busting static asset URLs based on the file contents. Static assets served with a matching ``?_hash=`` parameter now receive far-future immutable cache headers. This works for Datasette's bundled static assets, plugin static assets and directories mounted using ``--static``. See :ref:`customization_static_files`.
 - Database and table pages now use the ``count_truncated`` template context value to display capped row counts as ``>N rows``.
 - Significant visual improvements to the table filter form UI, plus working add/remove filter buttons. (:issue:`2798`)

From fc2922a30054e600070950d312d644cfe2081479 Mon Sep 17 00:00:00 2001
From: Chris Amico <eyeseast@gmail.com>
Date: Tue, 23 Jun 2026 19:24:03 -0400
Subject: [PATCH 293/386] Document custom json encoder (#1996)

Closes #1983
---
 datasette/utils/__init__.py | 24 ++++++++++++++++++++++++
 docs/Makefile               |  2 +-
 docs/internals.rst          |  7 +++++++
 3 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index b4ede953..1caff3a8 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -224,7 +224,31 @@ def compound_keys_after_sql(pks, start_index=0):
     return "({})".format("\n  or\n".join(or_clauses))
 
 
+@documented
 class CustomJSONEncoder(json.JSONEncoder):
+    """
+    The CustomJSONEncoder class handles serialization for objects commonly used by Datasette,
+    including SQLite cursors and binary blobs. Datasette uses it internally to serve .json endpoints,
+    and plugins that return JSON can use it to match Datasette's own handling.
+
+    Built-in types (text, numbers, lists, etc) are encoded the same as Python's built-in ``json`` module.
+
+    - ``sqlite3.Row`` becomes a tuple
+    - ``sqlite3.Cursor`` becomes a list
+
+    If a binary blob can be decoded as UTF-8, the encoder returns it as text.
+
+    If it can't (for example, images), it is encoded as an object, with the actual
+    data base64-encoded, like so: ::
+
+        {
+            "$base64": True,
+            "encoded": ...,
+        }
+
+    Example: https://latest.datasette.io/fixtures/binary_data.json
+    """
+
     def default(self, obj):
         if isinstance(obj, sqlite3.Row):
             return tuple(obj)
diff --git a/docs/Makefile b/docs/Makefile
index 2b092179..a0d17c81 100644
--- a/docs/Makefile
+++ b/docs/Makefile
@@ -20,4 +20,4 @@ help:
 	@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
 
 livehtml:
-	sphinx-autobuild -b html "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(0)
+	sphinx-autobuild -b html --watch ../datasette "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(0)
diff --git a/docs/internals.rst b/docs/internals.rst
index c826de1a..9f75640f 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -2579,6 +2579,13 @@ Async version of :ref:`call_with_supported_arguments <internals_utils_call_with_
 
 .. _internals_tracer:
 
+JSON encoding
+-------------
+
+.. _internals_utils_CustomJSONEncoder:
+
+.. autoclass:: datasette.utils.CustomJSONEncoder
+
 datasette.tracer
 ================
 

From d621bdfbfef1245fb7a088c56edb9ed8f6a0906e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 25 Jun 2026 21:20:21 -0700
Subject: [PATCH 294/386] Ignore ignored/ directory

---
 .gitignore | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.gitignore b/.gitignore
index 8c058692..2a7f6620 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,6 +5,8 @@ datasets.json
 
 scratchpad
 
+ignored/
+
 .vscode
 
 uv.lock

From b7a896a80318e5eafe36d9f5ab8bde4a799eb7a9 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 25 Jun 2026 22:02:39 -0700
Subject: [PATCH 295/386] Insert multiple rows feature in the insert dialog

Works entirely using existing JSON API.

User can paste in CSV, TSV or JSON (or drop a text file on).

They get a preview of the rows to be imported, then they
are imported in max_insert_rows batches.
---
 datasette/static/app.css       | 156 ++++++-
 datasette/static/edit-tools.js | 797 ++++++++++++++++++++++++++++++++-
 datasette/views/table.py       |   1 +
 tests/test_playwright.py       | 117 +++++
 tests/test_table_html.py       |   1 +
 5 files changed, 1062 insertions(+), 10 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index ce800f61..ca51c099 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1641,6 +1641,11 @@ dialog.row-edit-dialog::backdrop {
     overflow-y: auto;
 }
 
+.row-edit-fields[hidden],
+.row-edit-bulk[hidden] {
+    display: none;
+}
+
 .row-edit-field {
     display: grid;
     grid-template-columns: minmax(120px, 180px) minmax(0, 1fr);
@@ -1798,6 +1803,144 @@ textarea.row-edit-input {
     margin: 0;
 }
 
+.row-edit-bulk {
+    display: grid;
+    gap: 8px;
+    padding: 16px 24px 24px;
+    overflow-y: auto;
+}
+
+.row-edit-bulk-editor {
+    display: grid;
+    gap: 8px;
+}
+
+.row-edit-bulk-editor[hidden] {
+    display: none;
+}
+
+.row-edit-bulk-label {
+    color: var(--ink);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.82rem;
+}
+
+.row-edit-bulk-actions {
+    display: flex;
+    justify-content: flex-end;
+}
+
+.row-edit-bulk-actions .btn {
+    padding-left: 12px;
+    padding-right: 12px;
+}
+
+.row-edit-bulk-textarea {
+    min-height: 16rem;
+    resize: vertical;
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.82rem;
+    line-height: 1.45;
+}
+
+.row-edit-bulk-textarea.row-edit-bulk-drop-target {
+    border-color: var(--accent);
+    background: #f8fbff;
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+}
+
+.row-edit-bulk-note {
+    color: var(--muted);
+    font-size: 0.82rem;
+    margin: 0;
+}
+
+.row-edit-bulk-preview {
+    display: grid;
+    gap: 8px;
+    margin-top: 8px;
+}
+
+.row-edit-bulk-preview[hidden] {
+    display: none;
+}
+
+.row-edit-bulk-preview-summary {
+    color: var(--ink);
+    font-size: 0.9rem;
+    font-weight: 600;
+    margin: 0;
+}
+
+.row-edit-bulk-preview-table-wrap {
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    max-height: 18rem;
+    overflow: auto;
+    background: #fff;
+}
+
+.row-edit-bulk-preview-table {
+    border-collapse: collapse;
+    font-size: 0.78rem;
+    min-width: 100%;
+    width: max-content;
+}
+
+.row-edit-bulk-preview-table th,
+.row-edit-bulk-preview-table td {
+    border-bottom: 1px solid var(--rule);
+    border-right: 1px solid var(--rule);
+    max-width: 18rem;
+    padding: 6px 8px;
+    text-align: left;
+    vertical-align: top;
+    white-space: nowrap;
+}
+
+.row-edit-bulk-preview-table th {
+    background: var(--paper);
+    color: var(--ink);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-weight: 600;
+    position: sticky;
+    top: 0;
+    z-index: 1;
+}
+
+.row-edit-bulk-preview-table tr:last-child td {
+    border-bottom: none;
+}
+
+.row-edit-bulk-preview-table th:last-child,
+.row-edit-bulk-preview-table td:last-child {
+    border-right: none;
+}
+
+.row-edit-bulk-preview-null {
+    color: var(--muted);
+    font-style: italic;
+}
+
+.row-edit-bulk-progress {
+    display: grid;
+    gap: 6px;
+}
+
+.row-edit-bulk-progress[hidden] {
+    display: none;
+}
+
+.row-edit-bulk-progress-bar {
+    width: 100%;
+}
+
+.row-edit-bulk-progress-status {
+    color: var(--ink);
+    font-size: 0.9rem;
+    margin: 0;
+}
+
 datasette-autocomplete {
     display: block;
     position: relative;
@@ -1876,6 +2019,16 @@ datasette-autocomplete input[type="text"],
     background: var(--paper);
 }
 
+.row-edit-mode-link {
+    color: var(--accent);
+    font-size: 0.9rem;
+    margin-right: auto;
+}
+
+.row-edit-mode-link[hidden] {
+    display: none;
+}
+
 .row-edit-dialog .btn {
     border: none;
     border-radius: 5px;
@@ -3012,7 +3165,8 @@ select.table-alter-input {
     .row-edit-dialog .modal-header,
     .row-edit-summary,
     .row-edit-loading,
-    .row-edit-fields {
+    .row-edit-fields,
+    .row-edit-bulk {
         padding-left: 18px;
         padding-right: 18px;
     }
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 9f4f89b9..58ddaf19 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -4435,12 +4435,51 @@ function showRowEditDialogError(state, message) {
   state.error.focus();
 }
 
+function rowEditIsMultipleInsert(state) {
+  return state.mode === "insert" && state.insertMode === "multiple";
+}
+
+function syncRowEditInsertModeUi(state) {
+  var isInsert = state.mode === "insert";
+  var isMultiple = rowEditIsMultipleInsert(state);
+  state.fields.hidden = isMultiple;
+  state.bulkInsertPanel.hidden = !isMultiple;
+  state.bulkInsertEditor.hidden = !isMultiple || state.bulkInsertPreviewReady;
+  state.bulkInsertPreview.hidden = !isMultiple || !state.bulkInsertPreviewReady;
+  state.bulkInsertLink.hidden = !isInsert || isMultiple;
+  state.singleInsertLink.hidden = !isInsert || !isMultiple;
+}
+
 function updateRowEditDialogButtons(state) {
   state.saveButton.disabled =
-    state.isLoading || state.isSaving || !state.hasLoaded;
+    state.isLoading ||
+    state.isSaving ||
+    !state.hasLoaded ||
+    state.bulkInsertInserted;
   state.cancelButton.disabled = state.isSaving;
-  var saveLabel = state.mode === "insert" ? "Insert row" : "Save";
-  state.saveButton.textContent = state.isSaving ? "Saving..." : saveLabel;
+  syncRowEditInsertModeUi(state);
+  state.cancelButton.textContent =
+    rowEditIsMultipleInsert(state) &&
+    state.bulkInsertPreviewReady &&
+    !state.bulkInsertInserted
+      ? "Back"
+      : state.bulkInsertInserted
+        ? "Close and view table"
+        : "Cancel";
+  var saveLabel = rowEditIsMultipleInsert(state)
+    ? state.bulkInsertInserted
+      ? "Inserted"
+      : state.bulkInsertPreviewReady
+        ? "Insert these rows"
+        : "Preview rows"
+    : state.mode === "insert"
+      ? "Insert row"
+      : "Save";
+  state.saveButton.textContent = state.isSaving
+    ? rowEditIsMultipleInsert(state)
+      ? "Inserting..."
+      : "Saving..."
+    : saveLabel;
   state.form.setAttribute(
     "aria-busy",
     state.isLoading || state.isSaving ? "true" : "false",
@@ -4631,6 +4670,16 @@ function rowEditDialogHasChanges(state) {
   if (!state || !state.hasLoaded || state.isLoading) {
     return false;
   }
+  if (state.bulkInsertInserted) {
+    return false;
+  }
+  if (
+    state.mode === "insert" &&
+    state.bulkInsertTextarea &&
+    state.bulkInsertTextarea.value.trim()
+  ) {
+    return true;
+  }
   var fields = state.fields.querySelectorAll(".row-edit-field");
   for (var i = 0; i < fields.length; i += 1) {
     var fieldApi = fields[i]._datasetteColumnFormField;
@@ -4664,6 +4713,549 @@ function closeRowEditDialogIfConfirmed(state) {
   return true;
 }
 
+function setRowInsertDialogTitle(state) {
+  var insertData = tableInsertData() || {};
+  var title = rowEditIsMultipleInsert(state)
+    ? "Insert multiple rows"
+    : "Insert row";
+  setRowDialogTitle(
+    state.title,
+    insertData.tableName ? title + " into " + insertData.tableName : title,
+  );
+}
+
+function showMultipleRowInsert(state) {
+  if (!state || state.mode !== "insert" || state.isSaving) {
+    return;
+  }
+  state.insertMode = "multiple";
+  if (state.bulkInsertPreviewReady || state.bulkInsertInserted) {
+    resetBulkInsertPreview(state);
+  }
+  clearRowEditDialogError(state);
+  setRowInsertDialogTitle(state);
+  updateRowEditDialogButtons(state);
+  state.bulkInsertTextarea.focus();
+}
+
+function showSingleRowInsert(state) {
+  if (!state || state.mode !== "insert" || state.isSaving) {
+    return;
+  }
+  state.insertMode = "single";
+  clearRowEditDialogError(state);
+  setRowInsertDialogTitle(state);
+  updateRowEditDialogButtons(state);
+  if (!focusFirstRowEditControl(state, { skipReadonly: true })) {
+    state.saveButton.focus();
+  }
+}
+
+function readTextFile(file) {
+  if (file.text) {
+    return file.text();
+  }
+  return new Promise(function (resolve, reject) {
+    var reader = new FileReader();
+    reader.onload = function () {
+      resolve(reader.result || "");
+    };
+    reader.onerror = function () {
+      reject(reader.error);
+    };
+    reader.readAsText(file);
+  });
+}
+
+function bulkInsertTemplateText(state) {
+  return (state.bulkInsertColumns || []).join("\t");
+}
+
+async function copyTextToClipboard(text) {
+  if (navigator.clipboard && navigator.clipboard.writeText) {
+    await navigator.clipboard.writeText(text);
+    return;
+  }
+  var textarea = document.createElement("textarea");
+  textarea.value = text;
+  textarea.setAttribute("readonly", "");
+  textarea.style.position = "fixed";
+  textarea.style.top = "-1000px";
+  textarea.style.left = "-1000px";
+  document.body.appendChild(textarea);
+  textarea.select();
+  var copied = document.execCommand("copy");
+  textarea.remove();
+  if (!copied) {
+    throw new Error("copy failed");
+  }
+}
+
+function setBulkInsertCopyButtonCopied(state) {
+  state.copyTemplateButton.textContent = "Copied";
+  clearTimeout(state.copyTemplateResetTimer);
+  state.copyTemplateResetTimer = setTimeout(function () {
+    state.copyTemplateButton.textContent = "Copy spreadsheet template";
+  }, 1500);
+}
+
+function resetBulkInsertPreview(state) {
+  state.bulkInsertPreviewRows = null;
+  state.bulkInsertPreviewReady = false;
+  state.bulkInsertInserted = false;
+  state.bulkInsertInsertedCount = 0;
+  state.bulkInsertPreview.hidden = true;
+  state.bulkInsertPreview.textContent = "";
+  state.bulkInsertProgress.hidden = true;
+  state.bulkInsertProgressBar.value = 0;
+  state.bulkInsertProgressBar.max = 1;
+  state.bulkInsertProgressStatus.textContent = "";
+  syncRowEditInsertModeUi(state);
+}
+
+function normalizeBulkInsertCell(column, value, isMissing) {
+  if (isMissing || typeof value === "undefined") {
+    return column.notnull ? "" : null;
+  }
+  if (value === null) {
+    return column.notnull ? "" : null;
+  }
+  if (value === "" && column.notnull) {
+    return "";
+  }
+  if (column.value_kind === "number" && typeof value === "string") {
+    return valueFromRowEditText(column.name, value, "number");
+  }
+  return value;
+}
+
+function rowObjectForBulkInsert(valuesByColumn, columns) {
+  var row = {};
+  columns.forEach(function (column) {
+    var hasValue = Object.prototype.hasOwnProperty.call(
+      valuesByColumn,
+      column.name,
+    );
+    row[column.name] = normalizeBulkInsertCell(
+      column,
+      hasValue ? valuesByColumn[column.name] : undefined,
+      !hasValue,
+    );
+  });
+  return row;
+}
+
+function splitDelimitedRows(text, delimiter) {
+  var rows = [];
+  var row = [];
+  var cell = "";
+  var inQuotes = false;
+
+  for (var i = 0; i < text.length; i += 1) {
+    var character = text[i];
+    if (inQuotes) {
+      if (character === '"') {
+        if (text[i + 1] === '"') {
+          cell += '"';
+          i += 1;
+        } else {
+          inQuotes = false;
+        }
+      } else {
+        cell += character;
+      }
+      continue;
+    }
+
+    if (character === '"') {
+      inQuotes = true;
+    } else if (character === delimiter) {
+      row.push(cell);
+      cell = "";
+    } else if (character === "\n" || character === "\r") {
+      row.push(cell);
+      rows.push(row);
+      row = [];
+      cell = "";
+      if (character === "\r" && text[i + 1] === "\n") {
+        i += 1;
+      }
+    } else {
+      cell += character;
+    }
+  }
+
+  if (inQuotes) {
+    throw new Error("Unclosed quoted value.");
+  }
+  row.push(cell);
+  rows.push(row);
+
+  while (rows.length && bulkInsertDelimitedRowIsBlank(rows[rows.length - 1])) {
+    rows.pop();
+  }
+  return rows;
+}
+
+function bulkInsertDelimitedRowIsBlank(row) {
+  return row.every(function (value) {
+    return value.trim() === "";
+  });
+}
+
+function delimiterPreviewRows(text, delimiter) {
+  try {
+    return splitDelimitedRows(text, delimiter);
+  } catch (_error) {
+    return [];
+  }
+}
+
+function splitSingleColumnRows(text) {
+  var rows = text.split(/\r\n|\n|\r/).map(function (line) {
+    return [line];
+  });
+  while (rows.length && bulkInsertDelimitedRowIsBlank(rows[rows.length - 1])) {
+    rows.pop();
+  }
+  return rows;
+}
+
+function detectBulkInsertDelimiter(text, columns) {
+  var firstLine =
+    text.split(/\r\n|\n|\r/).find(function (line) {
+      return line.trim() !== "";
+    }) || "";
+  var csvRows = delimiterPreviewRows(firstLine, ",");
+  var tsvRows = delimiterPreviewRows(firstLine, "\t");
+  var csvColumns = csvRows.length ? csvRows[0].length : 0;
+  var tsvColumns = tsvRows.length ? tsvRows[0].length : 0;
+
+  if (firstLine.indexOf("\t") !== -1 && firstLine.indexOf(",") === -1) {
+    return "\t";
+  }
+  if (tsvColumns > csvColumns) {
+    return "\t";
+  }
+  if (csvColumns > 1) {
+    return ",";
+  }
+  if (tsvColumns > 1) {
+    return "\t";
+  }
+  if (columns.length === 1 || bulkInsertColumnMap(columns)[firstLine.trim()]) {
+    return null;
+  }
+  throw new Error("Could not detect CSV or TSV columns.");
+}
+
+function bulkInsertColumnMap(columns) {
+  var map = {};
+  columns.forEach(function (column) {
+    map[column.name] = column;
+  });
+  return map;
+}
+
+function parseJsonBulkInsertRows(text, columns) {
+  var parsed;
+  try {
+    parsed = JSON.parse(text);
+  } catch (error) {
+    throw new Error("Invalid JSON: " + error.message);
+  }
+  if (!Array.isArray(parsed)) {
+    throw new Error("JSON must be an array of objects.");
+  }
+  if (!parsed.length) {
+    throw new Error("No rows found to preview.");
+  }
+
+  var columnMap = bulkInsertColumnMap(columns);
+  return parsed.map(function (item, index) {
+    if (!item || typeof item !== "object" || Array.isArray(item)) {
+      throw new Error("JSON row " + (index + 1) + " must be an object.");
+    }
+    Object.keys(item).forEach(function (key) {
+      if (!columnMap[key]) {
+        throw new Error(
+          "JSON row " + (index + 1) + " has unknown column " + key + ".",
+        );
+      }
+    });
+    return rowObjectForBulkInsert(item, columns);
+  });
+}
+
+function parseDelimitedBulkInsertRows(text, columns) {
+  var delimiter = detectBulkInsertDelimiter(text, columns);
+  var rows = (
+    delimiter === null
+      ? splitSingleColumnRows(text)
+      : splitDelimitedRows(text, delimiter)
+  ).filter(function (row) {
+    return !bulkInsertDelimitedRowIsBlank(row);
+  });
+  if (!rows.length) {
+    throw new Error("No rows found to preview.");
+  }
+
+  var columnMap = bulkInsertColumnMap(columns);
+  var header = rows[0].map(function (value) {
+    return value.trim();
+  });
+  var headerMatches = header.filter(function (name) {
+    return !!columnMap[name];
+  }).length;
+  var hasHeader = headerMatches > 0;
+  var dataRows = hasHeader ? rows.slice(1) : rows;
+  var headers = hasHeader
+    ? header
+    : columns.map(function (column) {
+        return column.name;
+      });
+  var seenHeaders = {};
+
+  if (hasHeader) {
+    headers.forEach(function (name) {
+      if (!name) {
+        return;
+      }
+      if (!columnMap[name]) {
+        throw new Error("Unknown column " + name + " in header row.");
+      }
+      if (seenHeaders[name]) {
+        throw new Error("Duplicate column " + name + " in header row.");
+      }
+      seenHeaders[name] = true;
+    });
+  }
+
+  if (!dataRows.length) {
+    throw new Error("No data rows found to preview.");
+  }
+
+  return dataRows.map(function (row, rowIndex) {
+    if (row.length > headers.length) {
+      throw new Error(
+        "Row " +
+          (rowIndex + 1) +
+          " has " +
+          row.length +
+          " values, but only " +
+          headers.length +
+          " columns were provided.",
+      );
+    }
+    var valuesByColumn = {};
+    row.forEach(function (value, index) {
+      var columnName = headers[index];
+      if (columnMap[columnName]) {
+        valuesByColumn[columnName] = value;
+      }
+    });
+    return rowObjectForBulkInsert(valuesByColumn, columns);
+  });
+}
+
+function parseBulkInsertRows(text, columns) {
+  var trimmed = text.trim();
+  if (!trimmed) {
+    throw new Error("Paste rows before previewing.");
+  }
+  if (trimmed[0] === "[" || trimmed[0] === "{") {
+    return parseJsonBulkInsertRows(trimmed, columns);
+  }
+  return parseDelimitedBulkInsertRows(trimmed, columns);
+}
+
+function bulkInsertPreviewValue(value) {
+  if (value === null) {
+    return "null";
+  }
+  if (typeof value === "object") {
+    return JSON.stringify(value);
+  }
+  return String(value);
+}
+
+function renderBulkInsertPreview(state, rows) {
+  state.bulkInsertPreview.textContent = "";
+  var summary = document.createElement("p");
+  summary.className = "row-edit-bulk-preview-summary";
+  summary.textContent =
+    "Previewing " + rows.length + " row" + (rows.length === 1 ? "." : "s.");
+  state.bulkInsertPreview.appendChild(summary);
+
+  var tableWrap = document.createElement("div");
+  tableWrap.className = "row-edit-bulk-preview-table-wrap";
+  var table = document.createElement("table");
+  table.className = "row-edit-bulk-preview-table";
+  var thead = document.createElement("thead");
+  var headerRow = document.createElement("tr");
+  state.bulkInsertColumnDetails.forEach(function (column) {
+    var th = document.createElement("th");
+    th.scope = "col";
+    th.textContent = column.name;
+    headerRow.appendChild(th);
+  });
+  thead.appendChild(headerRow);
+  table.appendChild(thead);
+
+  var tbody = document.createElement("tbody");
+  rows.forEach(function (row) {
+    var tr = document.createElement("tr");
+    state.bulkInsertColumnDetails.forEach(function (column) {
+      var td = document.createElement("td");
+      var value = row[column.name];
+      td.textContent = bulkInsertPreviewValue(value);
+      if (value === null) {
+        td.className = "row-edit-bulk-preview-null";
+      }
+      tr.appendChild(td);
+    });
+    tbody.appendChild(tr);
+  });
+  table.appendChild(tbody);
+  tableWrap.appendChild(table);
+  state.bulkInsertPreview.appendChild(tableWrap);
+  state.bulkInsertPreview.hidden = false;
+}
+
+function previewBulkInsertRows(state) {
+  clearRowEditDialogError(state);
+  resetBulkInsertPreview(state);
+  try {
+    var rows = parseBulkInsertRows(
+      state.bulkInsertTextarea.value,
+      state.bulkInsertColumnDetails,
+    );
+    state.bulkInsertPreviewRows = rows;
+    state.bulkInsertPreviewReady = true;
+    renderBulkInsertPreview(state, rows);
+    updateRowEditDialogButtons(state);
+  } catch (error) {
+    showRowEditDialogError(state, error.message || "Could not preview rows.");
+    updateRowEditDialogButtons(state);
+  }
+}
+
+function updateBulkInsertProgress(state, inserted, total) {
+  state.bulkInsertProgress.hidden = false;
+  state.bulkInsertProgressBar.max = total || 1;
+  state.bulkInsertProgressBar.value = inserted;
+  state.bulkInsertProgressStatus.textContent =
+    inserted >= total
+      ? total + " row" + (total === 1 ? " inserted." : "s inserted.")
+      : "Inserting " + inserted + " of " + total + " rows...";
+}
+
+function bulkInsertBatches(rows, batchSize) {
+  var batches = [];
+  var size = Math.max(1, batchSize || 1);
+  for (var index = 0; index < rows.length; index += size) {
+    batches.push(rows.slice(index, index + size));
+  }
+  return batches;
+}
+
+function animateBulkInsertProgress(state, from, to, total, duration) {
+  state.bulkInsertProgress.hidden = false;
+  state.bulkInsertProgressBar.max = total || 1;
+  if (duration <= 0 || !window.requestAnimationFrame) {
+    updateBulkInsertProgress(state, to, total);
+    return Promise.resolve();
+  }
+
+  return new Promise(function (resolve) {
+    var startTime = null;
+    var step = function (timestamp) {
+      if (startTime === null) {
+        startTime = timestamp;
+      }
+      var progress = Math.min((timestamp - startTime) / duration, 1);
+      var easedProgress = 1 - Math.pow(1 - progress, 3);
+      var value = from + (to - from) * easedProgress;
+      var displayValue = progress === 1 ? to : Math.floor(value);
+      state.bulkInsertProgressBar.value = value;
+      state.bulkInsertProgressStatus.textContent =
+        displayValue >= total
+          ? total + " row" + (total === 1 ? " inserted." : "s inserted.")
+          : "Inserting " + displayValue + " of " + total + " rows...";
+      if (progress < 1) {
+        window.requestAnimationFrame(step);
+      } else {
+        updateBulkInsertProgress(state, to, total);
+        resolve();
+      }
+    };
+    window.requestAnimationFrame(step);
+  });
+}
+
+async function insertBulkPreviewRows(state) {
+  if (!state.bulkInsertPreviewRows || state.bulkInsertInserted) {
+    return;
+  }
+  if (!state.currentInsertUrl) {
+    showRowEditDialogError(state, "Could not find the row insert URL.");
+    return;
+  }
+
+  var rows = state.bulkInsertPreviewRows;
+  var total = rows.length;
+  var inserted = state.bulkInsertInsertedCount || 0;
+  var batches = bulkInsertBatches(
+    rows.slice(inserted),
+    state.bulkInsertMaxRows,
+  );
+  var progressAnimationDuration = 500 / Math.max(batches.length, 1);
+
+  clearRowEditDialogError(state);
+  updateBulkInsertProgress(state, inserted, total);
+  setRowEditDialogSaving(state, true);
+  try {
+    for (var batchIndex = 0; batchIndex < batches.length; batchIndex += 1) {
+      var batch = batches[batchIndex];
+      var response = await fetch(state.currentInsertUrl, {
+        method: "POST",
+        headers: {
+          "Content-Type": "application/json",
+          Accept: "application/json",
+        },
+        body: JSON.stringify({ rows: batch }),
+      });
+      var data = null;
+      try {
+        data = await response.json();
+      } catch (_error) {
+        data = null;
+      }
+      if (!response.ok || (data && data.ok === false)) {
+        throw rowMutationRequestError(response, data);
+      }
+      var previousInserted = inserted;
+      inserted += batch.length;
+      state.bulkInsertInsertedCount = inserted;
+      await animateBulkInsertProgress(
+        state,
+        previousInserted,
+        inserted,
+        total,
+        progressAnimationDuration,
+      );
+    }
+    state.bulkInsertInserted = true;
+    state.shouldReloadOnClose = true;
+    state.redirectOnCloseUrl = tableBaseUrl().toString();
+    updateBulkInsertProgress(state, inserted, total);
+  } catch (error) {
+    showRowEditDialogError(state, error.message || "Could not insert rows.");
+  } finally {
+    setRowEditDialogSaving(state, false);
+  }
+}
+
 function scheduleCloseRowEditDialogIfConfirmed(state) {
   // Fix for an issue in Safari where hitting Esc would show
   // the confirm() prompt asking if state should be discarded
@@ -4762,6 +5354,14 @@ async function saveRowEditDialog(state) {
   if (state.isLoading || state.isSaving || !state.hasLoaded) {
     return;
   }
+  if (rowEditIsMultipleInsert(state)) {
+    if (!state.bulkInsertPreviewReady) {
+      previewBulkInsertRows(state);
+    } else if (!state.bulkInsertInserted) {
+      await insertBulkPreviewRows(state);
+    }
+    return;
+  }
   clearRowEditDialogError(state);
   setRowEditDialogSaving(state, true);
 
@@ -4920,6 +5520,7 @@ function renderRowEditFields(state, data) {
   var primaryKeys = data.primary_keys || [];
   var columnTypes = data.column_types || {};
 
+  state.insertMode = "single";
   destroyRowEditFields(state);
   columns.forEach(function (column, index) {
     state.fields.appendChild(
@@ -4951,6 +5552,17 @@ function renderRowEditFields(state, data) {
 function renderRowInsertFields(state, data) {
   var columns = data.columns || [];
 
+  state.insertMode = "single";
+  state.bulkInsertColumnDetails = columns.slice();
+  state.bulkInsertMaxRows = data.maxInsertRows || 100;
+  state.bulkInsertColumns = columns.map(function (column) {
+    return column.name;
+  });
+  state.copyTemplateButton.disabled = !state.bulkInsertColumns.length;
+  state.copyTemplateButton.textContent = "Copy spreadsheet template";
+  clearTimeout(state.copyTemplateResetTimer);
+  state.copyTemplateResetTimer = null;
+  resetBulkInsertPreview(state);
   destroyRowEditFields(state);
   columns.forEach(function (column, index) {
     state.fields.appendChild(
@@ -5040,7 +5652,24 @@ function ensureRowEditDialog(manager) {
       <p class="row-edit-loading" role="status" aria-live="polite">Loading row...</p>
       <p class="row-edit-error" role="alert" tabindex="-1" hidden></p>
       <div class="row-edit-fields"></div>
+      <div class="row-edit-bulk" hidden>
+        <div class="row-edit-bulk-editor">
+          <label class="row-edit-bulk-label" for="row-edit-bulk-textarea">Rows to insert</label>
+          <div class="row-edit-bulk-actions">
+            <button type="button" class="btn btn-ghost row-edit-copy-template">Copy spreadsheet template</button>
+          </div>
+          <textarea class="row-edit-input row-edit-bulk-textarea" id="row-edit-bulk-textarea" name="_bulk_rows" rows="12" spellcheck="false"></textarea>
+          <p class="row-edit-bulk-note">Paste TSV, CSV, or JSON. You can also drop a text file onto this textarea.</p>
+        </div>
+        <div class="row-edit-bulk-preview" hidden></div>
+        <div class="row-edit-bulk-progress" hidden>
+          <progress class="row-edit-bulk-progress-bar" value="0" max="1"></progress>
+          <p class="row-edit-bulk-progress-status" role="status" aria-live="polite"></p>
+        </div>
+      </div>
       <div class="modal-footer">
+        <a href="#" class="row-edit-mode-link row-edit-bulk-insert" hidden>Insert multiple rows</a>
+        <a href="#" class="row-edit-mode-link row-edit-single-insert" hidden>Insert single row</a>
         <button type="button" class="btn btn-ghost row-edit-cancel">Cancel</button>
         <button type="submit" class="btn btn-primary row-edit-save" disabled>Save</button>
       </div>
@@ -5056,6 +5685,18 @@ function ensureRowEditDialog(manager) {
     loading: dialog.querySelector(".row-edit-loading"),
     error: dialog.querySelector(".row-edit-error"),
     fields: dialog.querySelector(".row-edit-fields"),
+    bulkInsertPanel: dialog.querySelector(".row-edit-bulk"),
+    bulkInsertEditor: dialog.querySelector(".row-edit-bulk-editor"),
+    bulkInsertTextarea: dialog.querySelector(".row-edit-bulk-textarea"),
+    bulkInsertPreview: dialog.querySelector(".row-edit-bulk-preview"),
+    bulkInsertProgress: dialog.querySelector(".row-edit-bulk-progress"),
+    bulkInsertProgressBar: dialog.querySelector(".row-edit-bulk-progress-bar"),
+    bulkInsertProgressStatus: dialog.querySelector(
+      ".row-edit-bulk-progress-status",
+    ),
+    copyTemplateButton: dialog.querySelector(".row-edit-copy-template"),
+    bulkInsertLink: dialog.querySelector(".row-edit-bulk-insert"),
+    singleInsertLink: dialog.querySelector(".row-edit-single-insert"),
     cancelButton: dialog.querySelector(".row-edit-cancel"),
     saveButton: dialog.querySelector(".row-edit-save"),
     currentButton: null,
@@ -5066,6 +5707,17 @@ function ensureRowEditDialog(manager) {
     currentUpdateUrl: null,
     currentFragmentUrl: null,
     mode: "edit",
+    insertMode: "single",
+    bulkInsertColumns: [],
+    bulkInsertColumnDetails: [],
+    bulkInsertPreviewRows: null,
+    bulkInsertPreviewReady: false,
+    bulkInsertInserted: false,
+    bulkInsertInsertedCount: 0,
+    bulkInsertMaxRows: 100,
+    shouldReloadOnClose: false,
+    redirectOnCloseUrl: null,
+    copyTemplateResetTimer: null,
     loadId: 0,
     manager: manager,
     isLoading: false,
@@ -5081,12 +5733,121 @@ function ensureRowEditDialog(manager) {
   });
 
   rowEditDialogState.cancelButton.addEventListener("click", function () {
+    if (
+      rowEditIsMultipleInsert(rowEditDialogState) &&
+      rowEditDialogState.bulkInsertPreviewReady &&
+      !rowEditDialogState.bulkInsertInserted &&
+      !rowEditDialogState.isSaving
+    ) {
+      resetBulkInsertPreview(rowEditDialogState);
+      updateRowEditDialogButtons(rowEditDialogState);
+      rowEditDialogState.bulkInsertTextarea.focus();
+      return;
+    }
     if (!rowEditDialogState.isSaving) {
       rowEditDialogState.shouldRestoreFocus = true;
       dialog.close();
     }
   });
 
+  rowEditDialogState.bulkInsertLink.addEventListener("click", function (ev) {
+    ev.preventDefault();
+    showMultipleRowInsert(rowEditDialogState);
+  });
+
+  rowEditDialogState.singleInsertLink.addEventListener("click", function (ev) {
+    ev.preventDefault();
+    showSingleRowInsert(rowEditDialogState);
+  });
+
+  rowEditDialogState.copyTemplateButton.addEventListener(
+    "click",
+    async function () {
+      try {
+        await copyTextToClipboard(bulkInsertTemplateText(rowEditDialogState));
+        clearRowEditDialogError(rowEditDialogState);
+        setBulkInsertCopyButtonCopied(rowEditDialogState);
+      } catch (_error) {
+        showRowEditDialogError(
+          rowEditDialogState,
+          "Could not copy the spreadsheet template.",
+        );
+      }
+    },
+  );
+
+  rowEditDialogState.bulkInsertTextarea.addEventListener(
+    "dragenter",
+    function (ev) {
+      ev.preventDefault();
+      rowEditDialogState.bulkInsertTextarea.classList.add(
+        "row-edit-bulk-drop-target",
+      );
+    },
+  );
+
+  rowEditDialogState.bulkInsertTextarea.addEventListener(
+    "dragover",
+    function (ev) {
+      ev.preventDefault();
+      rowEditDialogState.bulkInsertTextarea.classList.add(
+        "row-edit-bulk-drop-target",
+      );
+    },
+  );
+
+  rowEditDialogState.bulkInsertTextarea.addEventListener(
+    "dragleave",
+    function () {
+      rowEditDialogState.bulkInsertTextarea.classList.remove(
+        "row-edit-bulk-drop-target",
+      );
+    },
+  );
+
+  rowEditDialogState.bulkInsertTextarea.addEventListener(
+    "drop",
+    async function (ev) {
+      ev.preventDefault();
+      rowEditDialogState.bulkInsertTextarea.classList.remove(
+        "row-edit-bulk-drop-target",
+      );
+      var files = ev.dataTransfer && ev.dataTransfer.files;
+      if (!files || !files.length) {
+        return;
+      }
+      try {
+        rowEditDialogState.bulkInsertTextarea.value = await readTextFile(
+          files[0],
+        );
+        rowEditDialogState.bulkInsertTextarea.dispatchEvent(
+          new Event("input", { bubbles: true }),
+        );
+        clearRowEditDialogError(rowEditDialogState);
+      } catch (_error) {
+        showRowEditDialogError(
+          rowEditDialogState,
+          "Could not read that text file.",
+        );
+      }
+    },
+  );
+
+  rowEditDialogState.bulkInsertTextarea.addEventListener(
+    "dragend",
+    function () {
+      rowEditDialogState.bulkInsertTextarea.classList.remove(
+        "row-edit-bulk-drop-target",
+      );
+    },
+  );
+
+  rowEditDialogState.bulkInsertTextarea.addEventListener("input", function () {
+    resetBulkInsertPreview(rowEditDialogState);
+    clearRowEditDialogError(rowEditDialogState);
+    updateRowEditDialogButtons(rowEditDialogState);
+  });
+
   dialog.addEventListener("click", function (ev) {
     if (ev.target === dialog) {
       closeRowEditDialogIfConfirmed(rowEditDialogState);
@@ -5108,8 +5869,16 @@ function ensureRowEditDialog(manager) {
 
   dialog.addEventListener("close", function () {
     var state = rowEditDialogState;
+    var shouldReloadOnClose = state.shouldReloadOnClose;
+    var redirectOnCloseUrl = state.redirectOnCloseUrl;
     state.loadId += 1;
     state.isClosePending = false;
+    state.shouldReloadOnClose = false;
+    state.redirectOnCloseUrl = null;
+    clearTimeout(state.copyTemplateResetTimer);
+    state.copyTemplateResetTimer = null;
+    state.copyTemplateButton.textContent = "Copy spreadsheet template";
+    resetBulkInsertPreview(state);
     clearRowEditDialogError(state);
     state.hasLoaded = false;
     destroyRowEditFields(state);
@@ -5122,6 +5891,13 @@ function ensureRowEditDialog(manager) {
     ) {
       state.currentButton.focus();
     }
+    if (shouldReloadOnClose) {
+      if (redirectOnCloseUrl) {
+        location.href = redirectOnCloseUrl;
+      } else {
+        location.reload();
+      }
+    }
   });
 
   return rowEditDialogState;
@@ -5146,6 +5922,7 @@ async function openRowEditDialog(button, manager) {
   state.currentInsertUrl = null;
   state.currentUpdateUrl = rowUpdateUrl(row);
   state.currentFragmentUrl = rowFragmentUrl(row);
+  state.insertMode = "single";
   if (state.currentUpdateUrl) {
     state.form.action = new URL(
       state.currentUpdateUrl,
@@ -5171,6 +5948,7 @@ async function openRowEditDialog(button, manager) {
   );
   state.summary.hidden = true;
   state.summary.textContent = "";
+  syncRowEditInsertModeUi(state);
 
   if (!state.dialog.open) {
     state.dialog.showModal();
@@ -5221,6 +5999,11 @@ function openRowInsertDialog(button, manager) {
   state.currentInsertUrl = tableInsertUrl();
   state.currentUpdateUrl = null;
   state.currentFragmentUrl = null;
+  state.insertMode = "single";
+  state.bulkInsertTextarea.value = "";
+  state.shouldReloadOnClose = false;
+  state.redirectOnCloseUrl = null;
+  resetBulkInsertPreview(state);
   state.shouldRestoreFocus = true;
   state.hasLoaded = false;
   state.loadId += 1;
@@ -5238,14 +6021,10 @@ function openRowInsertDialog(button, manager) {
   setRowEditDialogLoading(state, false);
   destroyRowEditFields(state);
   state.dialog.removeAttribute("aria-describedby");
-  setRowDialogTitle(
-    state.title,
-    insertData.tableName
-      ? "Insert row into " + insertData.tableName
-      : "Insert row",
-  );
+  setRowInsertDialogTitle(state);
   state.summary.hidden = true;
   state.summary.textContent = "";
+  syncRowEditInsertModeUi(state);
 
   if (!state.dialog.open) {
     state.dialog.showModal();
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 1fc151e6..5335e6dc 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -517,6 +517,7 @@ async def _table_insert_ui(
         "tableName": table_name,
         "columns": columns,
         "primaryKeys": pks,
+        "maxInsertRows": datasette.setting("max_insert_rows"),
     }
 
 
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index ee396de5..b0580d11 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -801,11 +801,77 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins(
 
 @pytest.mark.playwright
 def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
+    page.context.grant_permissions(
+        ["clipboard-read", "clipboard-write"], origin=datasette_server.rstrip("/")
+    )
     page.goto(f"{datasette_server}data/projects")
     page.locator('button[data-table-action="insert-row"]').click()
 
     dialog = page.locator("#row-edit-dialog")
     dialog.wait_for()
+    bulk_insert = dialog.locator(".row-edit-bulk-insert")
+    bulk_insert.wait_for()
+    assert bulk_insert.inner_text() == "Insert multiple rows"
+    current_url = page.url
+    bulk_insert.click()
+    assert page.url == current_url
+    assert dialog.evaluate("node => node.open")
+    assert dialog.locator(".row-edit-fields").is_hidden()
+    assert dialog.locator(".row-edit-bulk").is_visible()
+    assert dialog.locator(".row-edit-save").inner_text() == "Preview rows"
+    assert (
+        dialog.locator(".row-edit-bulk-note").inner_text()
+        == "Paste TSV, CSV, or JSON. You can also drop a text file onto this textarea."
+    )
+    copy_template = dialog.locator(".row-edit-copy-template")
+    assert copy_template.inner_text() == "Copy spreadsheet template"
+    copy_template.click()
+    page.wait_for_function(
+        """() => document.querySelector(".row-edit-copy-template").textContent === "Copied" """
+    )
+    assert page.evaluate("navigator.clipboard.readText()") == (
+        "title\tmetadata\tlogo\tnotes\tscore"
+    )
+    textarea = dialog.locator(".row-edit-bulk-textarea")
+    textarea.fill("title\tmetadata\nFrom TSV\t{}")
+    assert textarea.input_value() == "title\tmetadata\nFrom TSV\t{}"
+    dropped_value = textarea.evaluate("""node => new Promise((resolve) => {
+            node.addEventListener("input", () => resolve(node.value), { once: true });
+            const file = new File(["\\n\\ntitle,metadata\\nFrom CSV,{}\\n,\\n  ,  \\n"], "rows.csv", { type: "text/csv" });
+            const dataTransfer = new DataTransfer();
+            dataTransfer.items.add(file);
+            node.dispatchEvent(new DragEvent("dragenter", { bubbles: true, cancelable: true, dataTransfer }));
+            node.dispatchEvent(new DragEvent("dragover", { bubbles: true, cancelable: true, dataTransfer }));
+            node.dispatchEvent(new DragEvent("drop", { bubbles: true, cancelable: true, dataTransfer }));
+        })""")
+    assert dropped_value == "\n\ntitle,metadata\nFrom CSV,{}\n,\n  ,  \n"
+    dialog.locator(".row-edit-save").click()
+    assert dialog.evaluate("node => node.open")
+    assert dialog.locator(".row-edit-bulk-textarea").is_hidden()
+    assert dialog.locator(".row-edit-save").inner_text() == "Insert these rows"
+    assert dialog.locator(".row-edit-bulk-preview-summary").inner_text() == (
+        "Previewing 1 row."
+    )
+    preview_text = dialog.locator(".row-edit-bulk-preview-table").inner_text()
+    assert "title" in preview_text
+    assert "metadata" in preview_text
+    assert "id" not in preview_text
+    assert "From CSV" in preview_text
+    assert "null" in preview_text
+    assert dialog.locator(".row-edit-cancel").inner_text() == "Back"
+    dialog.locator(".row-edit-cancel").click()
+    assert dialog.evaluate("node => node.open")
+    assert dialog.locator(".row-edit-bulk-textarea").is_visible()
+    assert dialog.locator(".row-edit-bulk-textarea").input_value() == (
+        "\n\ntitle,metadata\nFrom CSV,{}\n,\n  ,  \n"
+    )
+    assert dialog.locator(".row-edit-save").inner_text() == "Preview rows"
+    single_insert = dialog.locator(".row-edit-single-insert")
+    assert single_insert.inner_text() == "Insert single row"
+    single_insert.click()
+    assert dialog.locator(".row-edit-bulk").is_hidden()
+    assert dialog.locator(".row-edit-fields").is_visible()
+    assert dialog.locator(".row-edit-save").inner_text() == "Insert row"
     dialog.locator('input[name="title"]').fill("Launch Datasette Cloud")
     dialog.locator('textarea[name="metadata"]').fill(
         '{"ok": false, "source": "playwright"}'
@@ -835,6 +901,54 @@ def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
     assert data["score"] == 5
 
 
+@pytest.mark.playwright
+def test_bulk_insert_preview_inserts_rows(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator('button[data-table-action="insert-row"]').click()
+
+    dialog = page.locator("#row-edit-dialog")
+    dialog.wait_for()
+    dialog.locator(".row-edit-bulk-insert").click()
+    dialog.locator(".row-edit-bulk-textarea").fill(
+        "title\tmetadata\nBulk one\t{}\n\nBulk two\t{}"
+    )
+    dialog.locator(".row-edit-save").click()
+    assert dialog.locator(".row-edit-save").inner_text() == "Insert these rows"
+    dialog.locator(".row-edit-save").click()
+    dialog.locator(
+        ".row-edit-bulk-progress-status", has_text="2 rows inserted."
+    ).wait_for()
+    assert dialog.locator(".row-edit-cancel").inner_text() == "Close and view table"
+    dialog.locator(".row-edit-cancel").click()
+    page.wait_for_load_state("domcontentloaded")
+    assert page.url == f"{datasette_server}data/projects"
+
+    assert project_rows(datasette_server, title="Bulk one")
+    assert project_rows(datasette_server, title="Bulk two")
+
+
+@pytest.mark.playwright
+def test_bulk_insert_preview_accepts_single_column_input(page, datasette_server):
+    page.goto(f"{datasette_server}data/projects")
+    page.locator('button[data-table-action="insert-row"]').click()
+
+    dialog = page.locator("#row-edit-dialog")
+    dialog.wait_for()
+    dialog.locator(".row-edit-bulk-insert").click()
+    dialog.locator(".row-edit-bulk-textarea").fill("title\none\ntwo\nthree")
+    dialog.locator(".row-edit-save").click()
+
+    assert dialog.locator(".row-edit-save").inner_text() == "Insert these rows"
+    assert dialog.locator(".row-edit-bulk-preview-summary").inner_text() == (
+        "Previewing 3 rows."
+    )
+    preview_text = dialog.locator(".row-edit-bulk-preview-table").inner_text()
+    assert "one" in preview_text
+    assert "two" in preview_text
+    assert "three" in preview_text
+    assert "null" in preview_text
+
+
 @pytest.mark.playwright
 def test_edit_row_flow_validates_json_and_saves_changes(page, datasette_server):
     page.goto(f"{datasette_server}data/projects")
@@ -842,6 +956,9 @@ def test_edit_row_flow_validates_json_and_saves_changes(page, datasette_server):
 
     dialog = page.locator("#row-edit-dialog")
     dialog.wait_for()
+    assert dialog.locator(".row-edit-bulk-insert").is_hidden()
+    assert dialog.locator(".row-edit-single-insert").is_hidden()
+    assert dialog.locator(".row-edit-bulk").is_hidden()
     title = dialog.locator('input[name="title"]')
     title.wait_for()
     title.fill("Build Datasette, edited")
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 3af2bb08..be569e68 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1316,6 +1316,7 @@ async def test_table_insert_action_button_and_data():
         assert insert_data["path"] == "/data/items/-/insert"
         assert insert_data["tableName"] == "items"
         assert insert_data["primaryKeys"] == ["id"]
+        assert insert_data["maxInsertRows"] == 100
         assert [column["name"] for column in insert_data["columns"]] == [
             "name",
             "score",

From 7ae601588e1259e0ed725d59f7f92b3f42c7a56e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 25 Jun 2026 22:32:47 -0700
Subject: [PATCH 296/386] Create table from data feature

Similar to insert rows from JSON/CSV/TSV
but it creates a brand new table instead.
---
 datasette/static/app.css       | 123 ++++++
 datasette/static/edit-tools.js | 757 +++++++++++++++++++++++++++++++--
 tests/test_playwright.py       |  83 +++-
 3 files changed, 934 insertions(+), 29 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index ca51c099..91379dee 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -2225,6 +2225,114 @@ select.table-create-input {
     gap: 10px;
 }
 
+.table-create-columns[hidden],
+.table-create-data[hidden],
+.table-create-data-editor[hidden],
+.table-create-data-preview[hidden] {
+    display: none;
+}
+
+.table-create-data,
+.table-create-data-editor {
+    display: grid;
+    gap: 8px;
+}
+
+.table-create-data-label {
+    color: var(--ink);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.82rem;
+}
+
+.table-create-data-textarea {
+    min-height: 16rem;
+    resize: vertical;
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.82rem;
+    line-height: 1.45;
+}
+
+.table-create-data-textarea.table-create-data-drop-target {
+    border-color: var(--accent);
+    background: #f8fbff;
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+}
+
+.table-create-data-note {
+    color: var(--muted);
+    font-size: 0.82rem;
+    margin: 0;
+}
+
+.table-create-data-preview {
+    display: grid;
+    gap: 10px;
+}
+
+.table-create-data-preview-summary {
+    color: var(--ink);
+    font-size: 0.9rem;
+    font-weight: 600;
+    margin: 0;
+}
+
+.table-create-data-pk-field {
+    display: grid;
+    grid-template-columns: minmax(120px, 180px) minmax(0, 1fr);
+    gap: 12px;
+    align-items: center;
+}
+
+.table-create-data-preview-table-wrap {
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    max-height: 18rem;
+    overflow: auto;
+    background: #fff;
+}
+
+.table-create-data-preview-table {
+    border-collapse: collapse;
+    font-size: 0.78rem;
+    min-width: 100%;
+    width: max-content;
+}
+
+.table-create-data-preview-table th,
+.table-create-data-preview-table td {
+    border-bottom: 1px solid var(--rule);
+    border-right: 1px solid var(--rule);
+    max-width: 18rem;
+    padding: 6px 8px;
+    text-align: left;
+    vertical-align: top;
+    white-space: nowrap;
+}
+
+.table-create-data-preview-table th {
+    background: var(--paper);
+    color: var(--ink);
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-weight: 600;
+    position: sticky;
+    top: 0;
+    z-index: 1;
+}
+
+.table-create-data-preview-table tr:last-child td {
+    border-bottom: none;
+}
+
+.table-create-data-preview-table th:last-child,
+.table-create-data-preview-table td:last-child {
+    border-right: none;
+}
+
+.table-create-data-preview-null {
+    color: var(--muted);
+    font-style: italic;
+}
+
 .table-create-column-list {
     display: grid;
     gap: 8px;
@@ -2452,6 +2560,16 @@ select.table-create-input {
     background: var(--paper);
 }
 
+.table-create-mode-link {
+    color: var(--accent);
+    font-size: 0.9rem;
+    margin-right: auto;
+}
+
+.table-create-mode-link[hidden] {
+    display: none;
+}
+
 .table-create-dialog .btn {
     border: none;
     border-radius: 5px;
@@ -3216,6 +3334,11 @@ select.table-alter-input {
         padding-top: 0;
     }
 
+    .table-create-data-pk-field {
+        grid-template-columns: 1fr;
+        gap: 5px;
+    }
+
     .table-create-column-headings {
         display: none;
     }
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 58ddaf19..859bac0f 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -4,6 +4,7 @@ var ROW_EDIT_DIALOG_ID = "row-edit-dialog";
 var rowEditDialogState = null;
 var TABLE_CREATE_DIALOG_ID = "table-create-dialog";
 var tableCreateDialogState = null;
+var TABLE_CREATE_AUTOMATIC_PK = "__datasette_automatic_pk__";
 var TABLE_ALTER_DIALOG_ID = "table-alter-dialog";
 var tableAlterDialogState = null;
 
@@ -810,13 +811,61 @@ async function loadTableCreateForeignKeyTargets(state) {
   );
 }
 
+function tableCreateIsDataMode(state) {
+  return state && state.mode === "data";
+}
+
+function tableCreateSaveButtonText(state) {
+  if (tableCreateIsDataMode(state)) {
+    return state.dataPreviewReady ? "Create table" : "Preview rows";
+  }
+  return "Create table";
+}
+
+function syncTableCreateModeUi(state) {
+  if (!state) {
+    return;
+  }
+  var isDataMode = tableCreateIsDataMode(state);
+  state.columnsPanel.hidden = isDataMode;
+  state.dataPanel.hidden = !isDataMode;
+  state.dataEditor.hidden = !isDataMode || state.dataPreviewReady;
+  state.dataPreview.hidden = !isDataMode || !state.dataPreviewReady;
+  state.createFromDataLink.hidden = isDataMode;
+  state.manualCreateLink.hidden = !isDataMode;
+}
+
+function updateTableCreateDialogButtons(state) {
+  if (!state) {
+    return;
+  }
+  syncTableCreateModeUi(state);
+  state.cancelButton.disabled = state.isSaving;
+  state.saveButton.disabled = state.isSaving;
+  state.addColumnButton.disabled = state.isSaving;
+  state.cancelButton.textContent =
+    tableCreateIsDataMode(state) && state.dataPreviewReady ? "Back" : "Cancel";
+  state.saveButton.textContent = state.isSaving
+    ? "Creating..."
+    : tableCreateSaveButtonText(state);
+}
+
 function tableCreateDialogSignature(state) {
   if (!state || !state.form) {
     return "";
   }
-  return JSON.stringify({
+  var signature = {
+    mode: state.mode || "manual",
     table: state.tableName.value,
-    columns: tableCreateDialogRows(state).map(function (row) {
+    data: state.dataTextarea ? state.dataTextarea.value : "",
+    dataPrimaryKey: state.dataPkSelect
+      ? state.dataPkSelect.value
+      : TABLE_CREATE_AUTOMATIC_PK,
+  };
+  if (tableCreateIsDataMode(state)) {
+    signature.previewReady = !!state.dataPreviewReady;
+  } else {
+    signature.columns = tableCreateDialogRows(state).map(function (row) {
       return {
         name: row.querySelector(".table-create-column-name").value,
         type: row.querySelector(".table-create-column-type").value,
@@ -837,8 +886,9 @@ function tableCreateDialogSignature(state) {
             }
           ).value || "",
       };
-    }),
-  });
+    });
+  }
+  return JSON.stringify(signature);
 }
 
 function tableCreateDialogHasChanges(state) {
@@ -864,18 +914,23 @@ function showTableCreateDialogError(state, message) {
 
 function setTableCreateDialogSaving(state, isSaving) {
   state.isSaving = isSaving;
-  state.cancelButton.disabled = isSaving;
-  state.saveButton.disabled = isSaving;
-  state.addColumnButton.disabled = isSaving;
-  state.saveButton.textContent = isSaving ? "Creating..." : "Create table";
   state.columnList
     .querySelectorAll("input, select, button")
     .forEach(function (control) {
       control.disabled = isSaving;
     });
+  state.fields
+    .querySelectorAll(
+      ".table-create-data input, .table-create-data select, .table-create-data textarea, .table-create-data button",
+    )
+    .forEach(function (control) {
+      control.disabled = isSaving;
+    });
+  state.tableName.disabled = isSaving;
   if (!isSaving) {
     updateTableCreateColumnRules(state);
   }
+  updateTableCreateDialogButtons(state);
   updateTableCreateMoveButtons(state);
 }
 
@@ -1231,8 +1286,11 @@ function addTableCreateColumn(state, column) {
 }
 
 function resetTableCreateDialog(state) {
+  state.mode = "manual";
   state.nextColumnIndex = 0;
   state.tableName.value = "";
+  state.dataTextarea.value = "";
+  resetTableCreateDataPreview(state);
   state.columnList.textContent = "";
   addTableCreateColumn(state, {
     name: "id",
@@ -1245,9 +1303,39 @@ function resetTableCreateDialog(state) {
     primaryKey: false,
   });
   updateTableCreateColumnRules(state);
+  updateTableCreateDialogButtons(state);
   state.initialSignature = tableCreateDialogSignature(state);
 }
 
+function showTableCreateDataMode(state) {
+  if (!state || state.isSaving) {
+    return;
+  }
+  state.mode = "data";
+  clearTableCreateDialogError(state);
+  updateTableCreateDialogButtons(state);
+  if (state.dataPreviewReady && state.dataPkSelect) {
+    state.dataPkSelect.focus();
+  } else {
+    state.dataTextarea.focus();
+  }
+}
+
+function showTableCreateManualMode(state) {
+  if (!state || state.isSaving) {
+    return;
+  }
+  state.mode = "manual";
+  clearTableCreateDialogError(state);
+  updateTableCreateDialogButtons(state);
+  var firstInput = state.columnList.querySelector(".table-create-column-name");
+  if (firstInput) {
+    firstInput.focus();
+  } else {
+    state.tableName.focus();
+  }
+}
+
 function collectTableCreatePayload(state) {
   var payload = {
     table: state.tableName.value.trim(),
@@ -1315,14 +1403,9 @@ function collectTableCreateColumnTypeAssignments(state) {
 }
 
 function validateTableCreatePayload(payload) {
-  if (!payload.table) {
-    return "Table name is required.";
-  }
-  if (payload.table.indexOf("\n") !== -1) {
-    return "Table name cannot contain newlines.";
-  }
-  if (/^sqlite_/i.test(payload.table)) {
-    return "Table name cannot start with sqlite_.";
+  var tableNameError = validateTableCreateTableName(payload.table);
+  if (tableNameError) {
+    return tableNameError;
   }
   if (!payload.columns.length) {
     return "At least one column is required.";
@@ -1352,6 +1435,19 @@ function validateTableCreatePayload(payload) {
   return null;
 }
 
+function validateTableCreateTableName(tableName) {
+  if (!tableName) {
+    return "Table name is required.";
+  }
+  if (tableName.indexOf("\n") !== -1) {
+    return "Table name cannot contain newlines.";
+  }
+  if (/^sqlite_/i.test(tableName)) {
+    return "Table name cannot start with sqlite_.";
+  }
+  return null;
+}
+
 function validateTableCreateColumnTypeAssignments(assignments) {
   for (var i = 0; i < assignments.length; i += 1) {
     var assignment = assignments[i];
@@ -1374,6 +1470,446 @@ function validateTableCreateColumnTypeAssignments(assignments) {
   return null;
 }
 
+function normalizeCreateTableDataJsonValue(value) {
+  if (typeof value === "undefined") {
+    return null;
+  }
+  if (Array.isArray(value) || (value && typeof value === "object")) {
+    return JSON.stringify(value);
+  }
+  return value;
+}
+
+function createTableDataColumnObjects(names) {
+  return names.map(function (name) {
+    return { name: name };
+  });
+}
+
+function validateCreateTableDataHeaders(headers) {
+  if (!headers.length) {
+    throw new Error("No columns found to preview.");
+  }
+  var seen = {};
+  headers.forEach(function (name, index) {
+    if (!name) {
+      throw new Error("Column header " + (index + 1) + " is blank.");
+    }
+    if (name.indexOf("\n") !== -1) {
+      throw new Error("Column names cannot contain newlines.");
+    }
+    var key = name.toLowerCase();
+    if (seen[key]) {
+      throw new Error("Duplicate column name: " + name);
+    }
+    seen[key] = true;
+  });
+}
+
+function jsonRowIsObject(item) {
+  return !!(item && typeof item === "object" && !Array.isArray(item));
+}
+
+function extractJsonObjectRows(parsed) {
+  if (Array.isArray(parsed)) {
+    return parsed;
+  }
+  if (!jsonRowIsObject(parsed)) {
+    throw new Error(
+      "JSON must be an array of objects, or an object containing an array of objects.",
+    );
+  }
+
+  var bestRows = null;
+  Object.keys(parsed).forEach(function (key) {
+    var value = parsed[key];
+    if (!Array.isArray(value) || !value.every(jsonRowIsObject)) {
+      return;
+    }
+    if (!bestRows || value.length > bestRows.length) {
+      bestRows = value;
+    }
+  });
+  if (!bestRows) {
+    throw new Error(
+      "JSON object must contain at least one root key with an array of objects.",
+    );
+  }
+  return bestRows;
+}
+
+function parseJsonObjectRows(text) {
+  var parsed;
+  try {
+    parsed = JSON.parse(text);
+  } catch (error) {
+    throw new Error("Invalid JSON: " + error.message);
+  }
+  var rows = extractJsonObjectRows(parsed);
+  if (!rows.length) {
+    throw new Error("No rows found to preview.");
+  }
+  return rows;
+}
+
+function parseJsonCreateTableRows(text) {
+  var parsed = parseJsonObjectRows(text);
+
+  var columnNames = [];
+  var columnMap = {};
+  parsed.forEach(function (item, index) {
+    if (!item || typeof item !== "object" || Array.isArray(item)) {
+      throw new Error("JSON row " + (index + 1) + " must be an object.");
+    }
+    Object.keys(item).forEach(function (name) {
+      if (!columnMap[name]) {
+        columnMap[name] = true;
+        columnNames.push(name);
+      }
+    });
+  });
+  validateCreateTableDataHeaders(columnNames);
+
+  var rows = parsed.map(function (item) {
+    var row = {};
+    columnNames.forEach(function (name) {
+      row[name] = Object.prototype.hasOwnProperty.call(item, name)
+        ? normalizeCreateTableDataJsonValue(item[name])
+        : null;
+    });
+    return row;
+  });
+  return {
+    columns: createTableDataColumnObjects(columnNames),
+    rows: rows,
+  };
+}
+
+function createTableDelimitedValueIsInteger(value) {
+  return /^[-+]?\d+$/.test(String(value).trim());
+}
+
+function createTableDelimitedValueIsFloat(value) {
+  var trimmed = String(value).trim();
+  if (!trimmed) {
+    return false;
+  }
+  var numberValue = Number(trimmed);
+  return Number.isFinite(numberValue);
+}
+
+function inferCreateTableDelimitedColumnType(values) {
+  var nonBlankValues = values.filter(function (value) {
+    return String(value).trim() !== "";
+  });
+  if (!nonBlankValues.length) {
+    return "text";
+  }
+  if (nonBlankValues.every(createTableDelimitedValueIsInteger)) {
+    return "integer";
+  }
+  if (nonBlankValues.every(createTableDelimitedValueIsFloat)) {
+    return "float";
+  }
+  return "text";
+}
+
+function coerceCreateTableDelimitedValue(value, type) {
+  var trimmed = String(value).trim();
+  if (trimmed === "") {
+    return "";
+  }
+  if (type === "integer") {
+    return parseInt(trimmed, 10);
+  }
+  if (type === "float") {
+    return Number(trimmed);
+  }
+  return value;
+}
+
+function detectCreateTableDataDelimiter(text) {
+  var firstLine =
+    text.split(/\r\n|\n|\r/).find(function (line) {
+      return line.trim() !== "";
+    }) || "";
+  var csvRows = delimiterPreviewRows(firstLine, ",");
+  var tsvRows = delimiterPreviewRows(firstLine, "\t");
+  var csvColumns = csvRows.length ? csvRows[0].length : 0;
+  var tsvColumns = tsvRows.length ? tsvRows[0].length : 0;
+
+  if (firstLine.indexOf("\t") !== -1 && firstLine.indexOf(",") === -1) {
+    return "\t";
+  }
+  if (tsvColumns > csvColumns) {
+    return "\t";
+  }
+  if (csvColumns > 1) {
+    return ",";
+  }
+  if (tsvColumns > 1) {
+    return "\t";
+  }
+  return null;
+}
+
+function parseDelimitedCreateTableRows(text) {
+  var delimiter = detectCreateTableDataDelimiter(text);
+  var rows = (
+    delimiter === null
+      ? splitSingleColumnRows(text)
+      : splitDelimitedRows(text, delimiter)
+  ).filter(function (row) {
+    return !bulkInsertDelimitedRowIsBlank(row);
+  });
+  if (!rows.length) {
+    throw new Error("No rows found to preview.");
+  }
+
+  var headers = rows[0].map(function (value) {
+    return value.trim();
+  });
+  validateCreateTableDataHeaders(headers);
+  var dataRows = rows.slice(1);
+  if (!dataRows.length) {
+    throw new Error("No data rows found to preview.");
+  }
+
+  dataRows.forEach(function (row, index) {
+    if (row.length > headers.length) {
+      throw new Error(
+        "Row " +
+          (index + 1) +
+          " has " +
+          row.length +
+          " values, but only " +
+          headers.length +
+          " columns were provided.",
+      );
+    }
+  });
+
+  var columnTypes = headers.map(function (_name, columnIndex) {
+    return inferCreateTableDelimitedColumnType(
+      dataRows.map(function (row) {
+        return row[columnIndex] || "";
+      }),
+    );
+  });
+
+  return {
+    columns: createTableDataColumnObjects(headers),
+    rows: dataRows.map(function (row) {
+      var rowObject = {};
+      headers.forEach(function (name, columnIndex) {
+        rowObject[name] = coerceCreateTableDelimitedValue(
+          row[columnIndex] || "",
+          columnTypes[columnIndex],
+        );
+      });
+      return rowObject;
+    }),
+  };
+}
+
+function parseCreateTableDataRows(text) {
+  var trimmed = text.trim();
+  if (!trimmed) {
+    throw new Error("Paste rows before previewing.");
+  }
+  if (trimmed[0] === "[" || trimmed[0] === "{") {
+    return parseJsonCreateTableRows(trimmed);
+  }
+  return parseDelimitedCreateTableRows(trimmed);
+}
+
+function tableCreateDataRecommendedPrimaryKey(columns, rows) {
+  var candidates = [];
+  columns.forEach(function (column, columnIndex) {
+    var distinctValues = {};
+    var maxLength = 0;
+    var valid = rows.length > 0;
+    rows.forEach(function (row) {
+      if (!valid) {
+        return;
+      }
+      var value = row[column.name];
+      if (value === null || typeof value === "undefined") {
+        valid = false;
+        return;
+      }
+      var text = String(value).trim();
+      if (!text || text.length >= 20 || /\s/.test(text)) {
+        valid = false;
+        return;
+      }
+      if (distinctValues[text]) {
+        valid = false;
+        return;
+      }
+      distinctValues[text] = true;
+      maxLength = Math.max(maxLength, text.length);
+    });
+    if (valid) {
+      candidates.push({
+        name: column.name,
+        maxLength: maxLength,
+        columnIndex: columnIndex,
+      });
+    }
+  });
+  candidates.sort(function (left, right) {
+    if (left.maxLength !== right.maxLength) {
+      return left.maxLength - right.maxLength;
+    }
+    return left.columnIndex - right.columnIndex;
+  });
+  return candidates.length ? candidates[0].name : TABLE_CREATE_AUTOMATIC_PK;
+}
+
+function renderTableCreateDataPreview(state, preview) {
+  state.dataPreview.textContent = "";
+
+  var summary = document.createElement("p");
+  summary.className = "table-create-data-preview-summary";
+  summary.textContent =
+    "Previewing " +
+    preview.rows.length +
+    " row" +
+    (preview.rows.length === 1 ? "." : "s.");
+  state.dataPreview.appendChild(summary);
+
+  var pkField = document.createElement("div");
+  pkField.className = "table-create-data-pk-field";
+  var pkLabel = document.createElement("label");
+  pkLabel.className = "table-create-data-label";
+  pkLabel.setAttribute("for", "table-create-data-primary-key");
+  pkLabel.textContent = "Primary key";
+  var pkSelect = document.createElement("select");
+  pkSelect.id = "table-create-data-primary-key";
+  pkSelect.className = "table-create-input table-create-data-primary-key";
+  var automaticOption = document.createElement("option");
+  automaticOption.value = TABLE_CREATE_AUTOMATIC_PK;
+  automaticOption.textContent = "Automatic ID column";
+  pkSelect.appendChild(automaticOption);
+  preview.columns.forEach(function (column) {
+    var option = document.createElement("option");
+    option.value = column.name;
+    option.textContent = column.name;
+    pkSelect.appendChild(option);
+  });
+  pkSelect.value = tableCreateDataRecommendedPrimaryKey(
+    preview.columns,
+    preview.rows,
+  );
+  pkSelect.addEventListener("change", function () {
+    clearTableCreateDialogError(state);
+  });
+  state.dataPkSelect = pkSelect;
+  pkField.appendChild(pkLabel);
+  pkField.appendChild(pkSelect);
+  state.dataPreview.appendChild(pkField);
+
+  var tableWrap = document.createElement("div");
+  tableWrap.className = "table-create-data-preview-table-wrap";
+  var table = document.createElement("table");
+  table.className = "table-create-data-preview-table";
+  var thead = document.createElement("thead");
+  var headerRow = document.createElement("tr");
+  preview.columns.forEach(function (column) {
+    var th = document.createElement("th");
+    th.scope = "col";
+    th.textContent = column.name;
+    headerRow.appendChild(th);
+  });
+  thead.appendChild(headerRow);
+  table.appendChild(thead);
+
+  var tbody = document.createElement("tbody");
+  preview.rows.forEach(function (row) {
+    var tr = document.createElement("tr");
+    preview.columns.forEach(function (column) {
+      var td = document.createElement("td");
+      var value = row[column.name];
+      td.textContent = bulkInsertPreviewValue(value);
+      if (value === null) {
+        td.className = "table-create-data-preview-null";
+      }
+      tr.appendChild(td);
+    });
+    tbody.appendChild(tr);
+  });
+  table.appendChild(tbody);
+  tableWrap.appendChild(table);
+  state.dataPreview.appendChild(tableWrap);
+  state.dataPreview.hidden = false;
+}
+
+function resetTableCreateDataPreview(state) {
+  state.dataPreviewRows = null;
+  state.dataPreviewColumns = [];
+  state.dataPreviewReady = false;
+  state.dataPkSelect = null;
+  state.dataPreview.hidden = true;
+  state.dataPreview.textContent = "";
+  syncTableCreateModeUi(state);
+}
+
+function previewTableCreateDataRows(state) {
+  clearTableCreateDialogError(state);
+  resetTableCreateDataPreview(state);
+  try {
+    var preview = parseCreateTableDataRows(state.dataTextarea.value);
+    state.dataPreviewRows = preview.rows;
+    state.dataPreviewColumns = preview.columns;
+    state.dataPreviewReady = true;
+    renderTableCreateDataPreview(state, preview);
+    updateTableCreateDialogButtons(state);
+  } catch (error) {
+    showTableCreateDialogError(
+      state,
+      error.message || "Could not preview rows.",
+    );
+    updateTableCreateDialogButtons(state);
+  }
+}
+
+function collectTableCreateDataPayload(state) {
+  var payload = {
+    table: state.tableName.value.trim(),
+    rows: state.dataPreviewRows || [],
+  };
+  var primaryKey = state.dataPkSelect
+    ? state.dataPkSelect.value
+    : TABLE_CREATE_AUTOMATIC_PK;
+  payload.pk =
+    primaryKey === TABLE_CREATE_AUTOMATIC_PK ? "id" : primaryKey || undefined;
+  return payload;
+}
+
+function validateTableCreateDataPayload(payload, state) {
+  var tableNameError = validateTableCreateTableName(payload.table);
+  if (tableNameError) {
+    return tableNameError;
+  }
+  if (!payload.rows.length) {
+    return "No rows found to create.";
+  }
+  if (
+    state.dataPkSelect &&
+    state.dataPkSelect.value === TABLE_CREATE_AUTOMATIC_PK &&
+    payload.rows.some(function (row) {
+      return Object.prototype.hasOwnProperty.call(row, "id");
+    })
+  ) {
+    return (
+      "Automatic ID column cannot be used because the pasted data " +
+      "already has an id column."
+    );
+  }
+  return null;
+}
+
 function fallbackTableUrl(tableName) {
   var data = databaseCreateTableData() || {};
   if (!data.path) {
@@ -1441,6 +1977,57 @@ async function assignTableCreateColumnTypes(
   }
 }
 
+async function createTableFromDataPreview(state) {
+  var data = databaseCreateTableData();
+  if (!data || !data.path) {
+    showTableCreateDialogError(state, "Could not find the create table URL.");
+    return;
+  }
+  var payload = collectTableCreateDataPayload(state);
+  var validationError = validateTableCreateDataPayload(payload, state);
+  if (validationError) {
+    showTableCreateDialogError(state, validationError);
+    return;
+  }
+  clearTableCreateDialogError(state);
+  setTableCreateDialogSaving(state, true);
+  try {
+    var response = await fetch(data.path, {
+      method: "POST",
+      headers: {
+        "Content-Type": "application/json",
+        Accept: "application/json",
+      },
+      body: JSON.stringify(payload),
+    });
+    var responseData = null;
+    try {
+      responseData = await response.json();
+    } catch (_error) {
+      responseData = null;
+    }
+    if (!response.ok || (responseData && responseData.ok === false)) {
+      throw rowMutationRequestError(response, responseData);
+    }
+    var tableUrl =
+      responseData.table_url ||
+      fallbackTableUrl(responseData.table || payload.table);
+    state.shouldRestoreFocus = false;
+    state.dialog.close();
+    if (tableUrl) {
+      location.href = tableUrl;
+    } else {
+      location.reload();
+    }
+  } catch (error) {
+    setTableCreateDialogSaving(state, false);
+    showTableCreateDialogError(
+      state,
+      error.message || "Could not create table",
+    );
+  }
+}
+
 async function saveTableCreateDialog(state) {
   if (state.isSaving) {
     return;
@@ -1450,6 +2037,14 @@ async function saveTableCreateDialog(state) {
     showTableCreateDialogError(state, "Could not find the create table URL.");
     return;
   }
+  if (tableCreateIsDataMode(state)) {
+    if (!state.dataPreviewReady) {
+      previewTableCreateDataRows(state);
+    } else {
+      await createTableFromDataPreview(state);
+    }
+    return;
+  }
   clearTableCreateDialogError(state);
   var payload = collectTableCreatePayload(state);
   var columnTypeAssignments = collectTableCreateColumnTypeAssignments(state);
@@ -1560,8 +2155,18 @@ function ensureTableCreateDialog(manager) {
           <div class="table-create-column-list"></div>
           <button type="button" class="table-create-add-column"><svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M5 12h14"></path><path d="M12 5v14"></path></svg><span>Add column</span></button>
         </div>
+        <div class="table-create-data" hidden>
+          <div class="table-create-data-editor">
+            <label class="table-create-data-label" for="table-create-data-textarea">Rows for the new table</label>
+            <textarea class="table-create-input table-create-data-textarea" id="table-create-data-textarea" name="_create_rows" rows="12" spellcheck="false"></textarea>
+            <p class="table-create-data-note">Paste TSV, CSV, or JSON. You can also drop a text file onto this textarea.</p>
+          </div>
+          <div class="table-create-data-preview" hidden></div>
+        </div>
       </div>
       <div class="modal-footer">
+        <a href="#" class="table-create-mode-link table-create-from-data">Create table from data</a>
+        <a href="#" class="table-create-mode-link table-create-manual" hidden>Create table manually</a>
         <button type="button" class="btn btn-ghost table-create-cancel">Cancel</button>
         <button type="submit" class="btn btn-primary table-create-save">Create table</button>
       </div>
@@ -1576,13 +2181,25 @@ function ensureTableCreateDialog(manager) {
     error: dialog.querySelector(".table-create-error"),
     fields: dialog.querySelector(".table-create-fields"),
     tableName: dialog.querySelector(".table-create-table-name"),
+    columnsPanel: dialog.querySelector(".table-create-columns"),
     columnList: dialog.querySelector(".table-create-column-list"),
     addColumnButton: dialog.querySelector(".table-create-add-column"),
+    dataPanel: dialog.querySelector(".table-create-data"),
+    dataEditor: dialog.querySelector(".table-create-data-editor"),
+    dataTextarea: dialog.querySelector(".table-create-data-textarea"),
+    dataPreview: dialog.querySelector(".table-create-data-preview"),
+    createFromDataLink: dialog.querySelector(".table-create-from-data"),
+    manualCreateLink: dialog.querySelector(".table-create-manual"),
     cancelButton: dialog.querySelector(".table-create-cancel"),
     saveButton: dialog.querySelector(".table-create-save"),
     currentButton: null,
     shouldRestoreFocus: true,
     isSaving: false,
+    mode: "manual",
+    dataPreviewRows: null,
+    dataPreviewColumns: [],
+    dataPreviewReady: false,
+    dataPkSelect: null,
     initialSignature: "",
     nextColumnIndex: 0,
     foreignKeyTargets: [],
@@ -1606,13 +2223,108 @@ function ensureTableCreateDialog(manager) {
   });
 
   tableCreateDialogState.cancelButton.addEventListener("click", function () {
+    if (
+      tableCreateIsDataMode(tableCreateDialogState) &&
+      tableCreateDialogState.dataPreviewReady &&
+      !tableCreateDialogState.isSaving
+    ) {
+      resetTableCreateDataPreview(tableCreateDialogState);
+      updateTableCreateDialogButtons(tableCreateDialogState);
+      tableCreateDialogState.dataTextarea.focus();
+      return;
+    }
     closeTableCreateDialogIfConfirmed(tableCreateDialogState);
   });
 
+  tableCreateDialogState.createFromDataLink.addEventListener(
+    "click",
+    function (ev) {
+      ev.preventDefault();
+      showTableCreateDataMode(tableCreateDialogState);
+    },
+  );
+
+  tableCreateDialogState.manualCreateLink.addEventListener(
+    "click",
+    function (ev) {
+      ev.preventDefault();
+      showTableCreateManualMode(tableCreateDialogState);
+    },
+  );
+
   tableCreateDialogState.tableName.addEventListener("input", function () {
     clearTableCreateDialogError(tableCreateDialogState);
   });
 
+  tableCreateDialogState.dataTextarea.addEventListener(
+    "dragenter",
+    function (ev) {
+      ev.preventDefault();
+      tableCreateDialogState.dataTextarea.classList.add(
+        "table-create-data-drop-target",
+      );
+    },
+  );
+
+  tableCreateDialogState.dataTextarea.addEventListener(
+    "dragover",
+    function (ev) {
+      ev.preventDefault();
+      tableCreateDialogState.dataTextarea.classList.add(
+        "table-create-data-drop-target",
+      );
+    },
+  );
+
+  tableCreateDialogState.dataTextarea.addEventListener(
+    "dragleave",
+    function () {
+      tableCreateDialogState.dataTextarea.classList.remove(
+        "table-create-data-drop-target",
+      );
+    },
+  );
+
+  tableCreateDialogState.dataTextarea.addEventListener(
+    "drop",
+    async function (ev) {
+      ev.preventDefault();
+      tableCreateDialogState.dataTextarea.classList.remove(
+        "table-create-data-drop-target",
+      );
+      var files = ev.dataTransfer && ev.dataTransfer.files;
+      if (!files || !files.length) {
+        return;
+      }
+      try {
+        tableCreateDialogState.dataTextarea.value = await readTextFile(
+          files[0],
+        );
+        tableCreateDialogState.dataTextarea.dispatchEvent(
+          new Event("input", { bubbles: true }),
+        );
+        clearTableCreateDialogError(tableCreateDialogState);
+      } catch (_error) {
+        showTableCreateDialogError(
+          tableCreateDialogState,
+          "Could not read that text file.",
+        );
+      }
+    },
+  );
+
+  tableCreateDialogState.dataTextarea.addEventListener("dragend", function () {
+    tableCreateDialogState.dataTextarea.classList.remove(
+      "table-create-data-drop-target",
+    );
+  });
+
+  tableCreateDialogState.dataTextarea.addEventListener("input", function () {
+    resetTableCreateDataPreview(tableCreateDialogState);
+    clearTableCreateDialogError(tableCreateDialogState);
+    updateTableCreateDialogButtons(tableCreateDialogState);
+  });
+
   dialog.addEventListener("click", function (ev) {
     if (ev.target === dialog) {
       closeTableCreateDialogIfConfirmed(tableCreateDialogState);
@@ -4958,18 +5670,7 @@ function bulkInsertColumnMap(columns) {
 }
 
 function parseJsonBulkInsertRows(text, columns) {
-  var parsed;
-  try {
-    parsed = JSON.parse(text);
-  } catch (error) {
-    throw new Error("Invalid JSON: " + error.message);
-  }
-  if (!Array.isArray(parsed)) {
-    throw new Error("JSON must be an array of objects.");
-  }
-  if (!parsed.length) {
-    throw new Error("No rows found to preview.");
-  }
+  var parsed = parseJsonObjectRows(text);
 
   var columnMap = bulkInsertColumnMap(columns);
   return parsed.map(function (item, index) {
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index b0580d11..7e475738 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -123,6 +123,7 @@ def write_playwright_config(config_path):
                     "data": {
                         "permissions": {
                             "create-table": True,
+                            "insert-row": True,
                             "set-column-type": True,
                         },
                         "tables": {
@@ -381,6 +382,78 @@ def test_create_table_flow(page, datasette_server):
     assert "NOT NULL DEFAULT 'Untitled'" in schema
 
 
+@pytest.mark.playwright
+def test_create_table_from_data_flow(page, datasette_server):
+    page.goto(f"{datasette_server}data")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-database-action="create-table"]').click()
+
+    dialog = page.locator("#table-create-dialog")
+    dialog.wait_for()
+    from_data = dialog.locator(".table-create-from-data")
+    assert from_data.inner_text() == "Create table from data"
+    from_data.click()
+
+    assert dialog.locator(".table-create-columns").is_hidden()
+    assert dialog.locator(".table-create-data").is_visible()
+    assert dialog.locator(".table-create-save").inner_text() == "Preview rows"
+    assert (
+        dialog.locator(".table-create-data-note").inner_text()
+        == "Paste TSV, CSV, or JSON. You can also drop a text file onto this textarea."
+    )
+    assert dialog.locator(".table-create-manual").inner_text() == (
+        "Create table manually"
+    )
+
+    dialog.locator(".table-create-table-name").fill("playwright_from_data")
+    textarea = dialog.locator(".table-create-data-textarea")
+    textarea.fill(
+        json.dumps(
+            {
+                "metadata": [{"short_id": "a", "name": "Ignored", "score": 9}],
+                "people": [
+                    {"short_id": "b", "name": "Ada", "score": 1},
+                    {"short_id": "c", "name": "Bob", "score": 2.5},
+                ],
+            }
+        )
+    )
+    dialog.locator(".table-create-save").click()
+
+    assert dialog.locator(".table-create-data-textarea").is_hidden()
+    assert dialog.locator(".table-create-save").inner_text() == "Create table"
+    assert dialog.locator(".table-create-cancel").inner_text() == "Back"
+    assert dialog.locator(".table-create-data-preview-summary").inner_text() == (
+        "Previewing 2 rows."
+    )
+    assert dialog.locator(".table-create-data-primary-key").input_value() == "short_id"
+    preview_text = dialog.locator(".table-create-data-preview-table").inner_text()
+    assert "short_id" in preview_text
+    assert "Ada" in preview_text
+    assert "2.5" in preview_text
+
+    dialog.locator(".table-create-cancel").click()
+    assert dialog.evaluate("node => node.open")
+    assert dialog.locator(".table-create-data-textarea").is_visible()
+    assert '"people"' in dialog.locator(".table-create-data-textarea").input_value()
+    assert dialog.locator(".table-create-save").inner_text() == "Preview rows"
+
+    dialog.locator(".table-create-save").click()
+    assert dialog.locator(".table-create-save").inner_text() == "Create table"
+    dialog.locator(".table-create-save").click()
+    page.wait_for_url("**/data/playwright_from_data")
+
+    response = httpx.get(
+        f"{datasette_server}data/playwright_from_data.json?_shape=objects"
+    )
+    response.raise_for_status()
+    data = response.json()
+    assert data["rows"] == [
+        {"short_id": "b", "name": "Ada", "score": 1},
+        {"short_id": "c", "name": "Bob", "score": 2.5},
+    ]
+
+
 @pytest.mark.playwright
 def test_create_table_foreign_key_selection_updates_column_type(page, datasette_server):
     page.goto(f"{datasette_server}data")
@@ -910,7 +983,15 @@ def test_bulk_insert_preview_inserts_rows(page, datasette_server):
     dialog.wait_for()
     dialog.locator(".row-edit-bulk-insert").click()
     dialog.locator(".row-edit-bulk-textarea").fill(
-        "title\tmetadata\nBulk one\t{}\n\nBulk two\t{}"
+        json.dumps(
+            {
+                "metadata": [{"title": "Ignored", "metadata": "{}"}],
+                "projects": [
+                    {"title": "Bulk one", "metadata": "{}"},
+                    {"title": "Bulk two", "metadata": "{}"},
+                ],
+            }
+        )
     )
     dialog.locator(".row-edit-save").click()
     assert dialog.locator(".row-edit-save").inner_text() == "Insert these rows"

From cb622a3dd671c840279f9408f430da703464d218 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 25 Jun 2026 22:35:17 -0700
Subject: [PATCH 297/386] Switching to create table from data tab no longer
 marks as dirty

I was getting a confirm() dialog when I clicked outside the dialog on the
create table from data page despite not having filled out any fields.
---
 datasette/static/edit-tools.js | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 859bac0f..12ddb842 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -855,17 +855,12 @@ function tableCreateDialogSignature(state) {
     return "";
   }
   var signature = {
-    mode: state.mode || "manual",
     table: state.tableName.value,
     data: state.dataTextarea ? state.dataTextarea.value : "",
     dataPrimaryKey: state.dataPkSelect
       ? state.dataPkSelect.value
       : TABLE_CREATE_AUTOMATIC_PK,
-  };
-  if (tableCreateIsDataMode(state)) {
-    signature.previewReady = !!state.dataPreviewReady;
-  } else {
-    signature.columns = tableCreateDialogRows(state).map(function (row) {
+    columns: tableCreateDialogRows(state).map(function (row) {
       return {
         name: row.querySelector(".table-create-column-name").value,
         type: row.querySelector(".table-create-column-type").value,
@@ -886,8 +881,8 @@ function tableCreateDialogSignature(state) {
             }
           ).value || "",
       };
-    });
-  }
+    }),
+  };
   return JSON.stringify(signature);
 }
 

From 34ab85e66496567a41bd10f24e74f22af3770fe0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 29 Jun 2026 11:36:54 -0700
Subject: [PATCH 298/386] Handle recursive CTEs in query analysis

Closes #2809
---
 datasette/utils/sql_analysis.py |  5 ++-
 tests/test_queries.py           | 60 +++++++++++++++++++++++++++++++++
 2 files changed, 64 insertions(+), 1 deletion(-)

diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index 0a3a947c..3a509bd2 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -150,7 +150,6 @@ _SQLITE_INTERNAL_SCHEMA_FUNCTIONS = {
     "sqlite_rename_test",
     "substr",
 }
-
 _AUTHORIZER_ACTION_NAMES = {
     getattr(sqlite3, name): name
     for name in (
@@ -391,6 +390,10 @@ def analyze_sql_tables(
             )
             return sqlite3.SQLITE_OK
 
+        if action == sqlite3.SQLITE_RECURSIVE:
+            # Recursive CTE bookkeeping; table reads are reported separately.
+            return sqlite3.SQLITE_OK
+
         if action == sqlite3.SQLITE_FUNCTION and arg2 is not None:
             record(
                 "function",
diff --git a/tests/test_queries.py b/tests/test_queries.py
index b757f221..6dfcc8b7 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1585,6 +1585,66 @@ async def test_create_query_analyze_endpoint_uses_sql_only():
     assert old_analyze_response.status_code == 404
 
 
+@pytest.mark.asyncio
+async def test_create_query_supports_recursive_cte():
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_create_recursive_cte", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    sql = """
+    with recursive dog_tree(id, name) as (
+        select id, name from dogs
+        union all
+        select id + 1, name from dog_tree where id < 3
+    )
+    select name from dog_tree
+    """.strip()
+
+    analysis_response = await ds.client.get(
+        "/data/-/queries/analyze",
+        actor={"id": "root"},
+        params={"sql": sql},
+    )
+    form_response = await ds.client.get(
+        "/data/-/queries/store",
+        actor={"id": "root"},
+        params={"sql": sql},
+    )
+    store_response = await ds.client.post(
+        "/data/-/queries/store",
+        actor={"id": "root"},
+        data={
+            "name": "dog-tree",
+            "title": "Dog tree",
+            "sql": sql,
+            "is_private": "1",
+        },
+    )
+
+    assert analysis_response.status_code == 200
+    analysis_data = analysis_response.json()
+    assert analysis_data["ok"] is True
+    assert analysis_data["analysis_error"] is None
+    assert analysis_data["analysis_is_write"] is False
+    assert analysis_data["save_disabled"] is False
+
+    assert form_response.status_code == 200
+    soup = Soup(form_response.text, "html.parser")
+    submit = soup.select_one("[data-query-create-submit]")
+    assert submit is not None
+    assert not submit.has_attr("disabled")
+    assert "This is a read-only query." in form_response.text
+
+    assert store_response.status_code == 302
+    assert store_response.headers["location"] == "/data/dog-tree"
+    query = await ds.get_query("data", "dog-tree")
+    assert query is not None
+    assert query.sql == sql
+    assert query.is_write is False
+
+
 @pytest.mark.asyncio
 async def test_create_query_form_error_redisplays_form_with_values():
     ds = Datasette(memory=True, default_deny=True)

From e0a138ffbd8442ac693d3fa970380b2db36a57bd Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 29 Jun 2026 15:16:33 -0700
Subject: [PATCH 299/386] Tweaks to bulp insert screen

Moved text around, added clickable 'open a file' button for mobile.

Screenshot: https://github.com/simonw/datasette/pull/2813#issuecomment-4837736664
---
 datasette/static/app.css       | 46 +++++++++++++++++---
 datasette/static/edit-tools.js | 79 +++++++++++++++++++++++++---------
 tests/test_playwright.py       | 24 ++++++++++-
 3 files changed, 120 insertions(+), 29 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 91379dee..b430e208 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1819,15 +1819,12 @@ textarea.row-edit-input {
     display: none;
 }
 
-.row-edit-bulk-label {
-    color: var(--ink);
-    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
-    font-size: 0.82rem;
-}
-
 .row-edit-bulk-actions {
     display: flex;
-    justify-content: flex-end;
+    align-items: center;
+    flex-wrap: wrap;
+    gap: 8px;
+    justify-content: flex-start;
 }
 
 .row-edit-bulk-actions .btn {
@@ -1835,6 +1832,19 @@ textarea.row-edit-input {
     padding-right: 12px;
 }
 
+.row-edit-copy-template-label-narrow {
+    display: none;
+}
+
+.row-edit-bulk-template-note {
+    color: var(--muted);
+    font-size: 0.82rem;
+}
+
+.row-edit-bulk-template-note-narrow {
+    display: none;
+}
+
 .row-edit-bulk-textarea {
     min-height: 16rem;
     resize: vertical;
@@ -1855,6 +1865,28 @@ textarea.row-edit-input {
     margin: 0;
 }
 
+.row-edit-bulk-note .button-as-link {
+    font: inherit;
+}
+
+@media (max-width: 640px) {
+    .row-edit-copy-template-label-wide {
+        display: none;
+    }
+
+    .row-edit-copy-template-label-narrow {
+        display: inline;
+    }
+
+    .row-edit-bulk-template-note-wide {
+        display: none;
+    }
+
+    .row-edit-bulk-template-note-narrow {
+        display: inline;
+    }
+}
+
 .row-edit-bulk-preview {
     display: grid;
     gap: 8px;
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 12ddb842..0415d772 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -5474,6 +5474,22 @@ function readTextFile(file) {
   });
 }
 
+async function loadBulkInsertTextFile(state, file) {
+  if (!file) {
+    return;
+  }
+  try {
+    state.bulkInsertTextarea.value = await readTextFile(file);
+    state.bulkInsertTextarea.dispatchEvent(
+      new Event("input", { bubbles: true }),
+    );
+    clearRowEditDialogError(state);
+    state.bulkInsertTextarea.focus();
+  } catch (_error) {
+    showRowEditDialogError(state, "Could not read that text file.");
+  }
+}
+
 function bulkInsertTemplateText(state) {
   return (state.bulkInsertColumns || []).join("\t");
 }
@@ -5498,11 +5514,23 @@ async function copyTextToClipboard(text) {
   }
 }
 
+function setBulkInsertCopyButtonReady(state) {
+  state.copyTemplateButton.textContent = "";
+  var wideLabel = document.createElement("span");
+  wideLabel.className = "row-edit-copy-template-label-wide";
+  wideLabel.textContent = "Copy spreadsheet template";
+  state.copyTemplateButton.appendChild(wideLabel);
+  var narrowLabel = document.createElement("span");
+  narrowLabel.className = "row-edit-copy-template-label-narrow";
+  narrowLabel.textContent = "Copy template";
+  state.copyTemplateButton.appendChild(narrowLabel);
+}
+
 function setBulkInsertCopyButtonCopied(state) {
   state.copyTemplateButton.textContent = "Copied";
   clearTimeout(state.copyTemplateResetTimer);
   state.copyTemplateResetTimer = setTimeout(function () {
-    state.copyTemplateButton.textContent = "Copy spreadsheet template";
+    setBulkInsertCopyButtonReady(state);
   }, 1500);
 }
 
@@ -6255,7 +6283,7 @@ function renderRowInsertFields(state, data) {
     return column.name;
   });
   state.copyTemplateButton.disabled = !state.bulkInsertColumns.length;
-  state.copyTemplateButton.textContent = "Copy spreadsheet template";
+  setBulkInsertCopyButtonReady(state);
   clearTimeout(state.copyTemplateResetTimer);
   state.copyTemplateResetTimer = null;
   resetBulkInsertPreview(state);
@@ -6350,12 +6378,13 @@ function ensureRowEditDialog(manager) {
       <div class="row-edit-fields"></div>
       <div class="row-edit-bulk" hidden>
         <div class="row-edit-bulk-editor">
-          <label class="row-edit-bulk-label" for="row-edit-bulk-textarea">Rows to insert</label>
+          <p class="row-edit-bulk-note">Paste TSV, CSV, or JSON. You can also <button type="button" class="button-as-link row-edit-bulk-open-file">open a file</button> or drop it onto this textarea</p>
+          <input class="row-edit-bulk-file-input" type="file" accept=".csv,.tsv,.json,.txt,text/csv,text/tab-separated-values,application/json,text/plain" hidden>
+          <textarea class="row-edit-input row-edit-bulk-textarea" id="row-edit-bulk-textarea" name="_bulk_rows" rows="12" spellcheck="false" aria-label="Bulk rows"></textarea>
           <div class="row-edit-bulk-actions">
-            <button type="button" class="btn btn-ghost row-edit-copy-template">Copy spreadsheet template</button>
+            <button type="button" class="btn btn-ghost row-edit-copy-template"><span class="row-edit-copy-template-label-wide">Copy spreadsheet template</span><span class="row-edit-copy-template-label-narrow">Copy template</span></button>
+            <span class="row-edit-bulk-template-note"><span class="row-edit-bulk-template-note-wide">You can paste the template into Google Sheets or Excel.</span><span class="row-edit-bulk-template-note-narrow">Paste into Google Sheets or Excel</span></span>
           </div>
-          <textarea class="row-edit-input row-edit-bulk-textarea" id="row-edit-bulk-textarea" name="_bulk_rows" rows="12" spellcheck="false"></textarea>
-          <p class="row-edit-bulk-note">Paste TSV, CSV, or JSON. You can also drop a text file onto this textarea.</p>
         </div>
         <div class="row-edit-bulk-preview" hidden></div>
         <div class="row-edit-bulk-progress" hidden>
@@ -6391,6 +6420,8 @@ function ensureRowEditDialog(manager) {
       ".row-edit-bulk-progress-status",
     ),
     copyTemplateButton: dialog.querySelector(".row-edit-copy-template"),
+    bulkInsertOpenFileButton: dialog.querySelector(".row-edit-bulk-open-file"),
+    bulkInsertFileInput: dialog.querySelector(".row-edit-bulk-file-input"),
     bulkInsertLink: dialog.querySelector(".row-edit-bulk-insert"),
     singleInsertLink: dialog.querySelector(".row-edit-single-insert"),
     cancelButton: dialog.querySelector(".row-edit-cancel"),
@@ -6472,6 +6503,25 @@ function ensureRowEditDialog(manager) {
     },
   );
 
+  rowEditDialogState.bulkInsertOpenFileButton.addEventListener(
+    "click",
+    function () {
+      rowEditDialogState.bulkInsertFileInput.click();
+    },
+  );
+
+  rowEditDialogState.bulkInsertFileInput.addEventListener(
+    "change",
+    async function (ev) {
+      var files = ev.target.files;
+      await loadBulkInsertTextFile(
+        rowEditDialogState,
+        files && files.length ? files[0] : null,
+      );
+      ev.target.value = "";
+    },
+  );
+
   rowEditDialogState.bulkInsertTextarea.addEventListener(
     "dragenter",
     function (ev) {
@@ -6512,20 +6562,7 @@ function ensureRowEditDialog(manager) {
       if (!files || !files.length) {
         return;
       }
-      try {
-        rowEditDialogState.bulkInsertTextarea.value = await readTextFile(
-          files[0],
-        );
-        rowEditDialogState.bulkInsertTextarea.dispatchEvent(
-          new Event("input", { bubbles: true }),
-        );
-        clearRowEditDialogError(rowEditDialogState);
-      } catch (_error) {
-        showRowEditDialogError(
-          rowEditDialogState,
-          "Could not read that text file.",
-        );
-      }
+      await loadBulkInsertTextFile(rowEditDialogState, files[0]);
     },
   );
 
@@ -6573,7 +6610,7 @@ function ensureRowEditDialog(manager) {
     state.redirectOnCloseUrl = null;
     clearTimeout(state.copyTemplateResetTimer);
     state.copyTemplateResetTimer = null;
-    state.copyTemplateButton.textContent = "Copy spreadsheet template";
+    setBulkInsertCopyButtonReady(state);
     resetBulkInsertPreview(state);
     clearRowEditDialogError(state);
     state.hasLoaded = false;
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 7e475738..bc30b599 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -894,10 +894,32 @@ def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
     assert dialog.locator(".row-edit-save").inner_text() == "Preview rows"
     assert (
         dialog.locator(".row-edit-bulk-note").inner_text()
-        == "Paste TSV, CSV, or JSON. You can also drop a text file onto this textarea."
+        == "Paste TSV, CSV, or JSON. You can also open a file or drop it onto this textarea"
+    )
+    assert dialog.locator(".row-edit-bulk-open-file").inner_text() == "open a file"
+    assert (
+        dialog.locator(".row-edit-bulk-editor").evaluate(
+            """node => Array.from(node.children)
+            .filter((child) => !child.hidden)
+            .map((child) => child.className)
+            .join(" ")"""
+        )
+        == (
+            "row-edit-bulk-note row-edit-input row-edit-bulk-textarea "
+            "row-edit-bulk-actions"
+        )
     )
     copy_template = dialog.locator(".row-edit-copy-template")
     assert copy_template.inner_text() == "Copy spreadsheet template"
+    assert dialog.locator(".row-edit-copy-template-label-narrow").text_content() == (
+        "Copy template"
+    )
+    assert dialog.locator(".row-edit-bulk-template-note").inner_text() == (
+        "You can paste the template into Google Sheets or Excel."
+    )
+    assert dialog.locator(".row-edit-bulk-template-note-narrow").text_content() == (
+        "Paste into Google Sheets or Excel"
+    )
     copy_template.click()
     page.wait_for_function(
         """() => document.querySelector(".row-edit-copy-template").textContent === "Copied" """

From 9ec42b2dad050bb9cecf6bb8afa64bb7b87eee02 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 29 Jun 2026 16:02:56 -0700
Subject: [PATCH 300/386] Improvements to create table from data

---
 datasette/static/app.css       | 12 +++++-
 datasette/static/edit-tools.js | 74 +++++++++++++++++++++++++---------
 tests/test_playwright.py       | 60 ++++++++++++++++++++++++++-
 3 files changed, 124 insertions(+), 22 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index b430e208..30c4855c 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1865,6 +1865,7 @@ textarea.row-edit-input {
     margin: 0;
 }
 
+.row-edit-bulk-note label,
 .row-edit-bulk-note .button-as-link {
     font: inherit;
 }
@@ -1924,10 +1925,11 @@ textarea.row-edit-input {
     border-bottom: 1px solid var(--rule);
     border-right: 1px solid var(--rule);
     max-width: 18rem;
+    overflow-wrap: anywhere;
     padding: 6px 8px;
     text-align: left;
     vertical-align: top;
-    white-space: nowrap;
+    white-space: normal;
 }
 
 .row-edit-bulk-preview-table th {
@@ -2296,6 +2298,11 @@ select.table-create-input {
     margin: 0;
 }
 
+.table-create-data-note label,
+.table-create-data-note .button-as-link {
+    font: inherit;
+}
+
 .table-create-data-preview {
     display: grid;
     gap: 10px;
@@ -2335,10 +2342,11 @@ select.table-create-input {
     border-bottom: 1px solid var(--rule);
     border-right: 1px solid var(--rule);
     max-width: 18rem;
+    overflow-wrap: anywhere;
     padding: 6px 8px;
     text-align: left;
     vertical-align: top;
-    white-space: nowrap;
+    white-space: normal;
 }
 
 .table-create-data-preview-table th {
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 0415d772..87b63838 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -1850,6 +1850,36 @@ function resetTableCreateDataPreview(state) {
   syncTableCreateModeUi(state);
 }
 
+function tableCreateTableNameFromFileName(fileName) {
+  var baseName = (fileName || "").replace(/^.*[\\/]/, "");
+  var nameWithoutExtension = baseName.replace(/\.[^.]*$/, "");
+  return nameWithoutExtension
+    .trim()
+    .replace(/\s+/g, "_")
+    .toLowerCase()
+    .replace(/[^a-z0-9_]/g, "");
+}
+
+async function loadTableCreateDataTextFile(state, file) {
+  if (!file) {
+    return;
+  }
+  try {
+    var text = await readTextFile(file);
+    var tableName = tableCreateTableNameFromFileName(file.name);
+    if (tableName) {
+      state.tableName.value = tableName;
+      state.tableName.dispatchEvent(new Event("input", { bubbles: true }));
+    }
+    state.dataTextarea.value = text;
+    state.dataTextarea.dispatchEvent(new Event("input", { bubbles: true }));
+    clearTableCreateDialogError(state);
+    state.dataTextarea.focus();
+  } catch (_error) {
+    showTableCreateDialogError(state, "Could not read that text file.");
+  }
+}
+
 function previewTableCreateDataRows(state) {
   clearTableCreateDialogError(state);
   resetTableCreateDataPreview(state);
@@ -2152,9 +2182,9 @@ function ensureTableCreateDialog(manager) {
         </div>
         <div class="table-create-data" hidden>
           <div class="table-create-data-editor">
-            <label class="table-create-data-label" for="table-create-data-textarea">Rows for the new table</label>
+            <p class="table-create-data-note"><label for="table-create-data-textarea">Paste TSV, CSV, or JSON</label>. You can also <button type="button" class="button-as-link table-create-data-open-file">open a file</button> or drop it onto this textarea</p>
+            <input class="table-create-data-file-input" type="file" accept=".csv,.tsv,.json,.txt,text/csv,text/tab-separated-values,application/json,text/plain" hidden>
             <textarea class="table-create-input table-create-data-textarea" id="table-create-data-textarea" name="_create_rows" rows="12" spellcheck="false"></textarea>
-            <p class="table-create-data-note">Paste TSV, CSV, or JSON. You can also drop a text file onto this textarea.</p>
           </div>
           <div class="table-create-data-preview" hidden></div>
         </div>
@@ -2182,6 +2212,8 @@ function ensureTableCreateDialog(manager) {
     dataPanel: dialog.querySelector(".table-create-data"),
     dataEditor: dialog.querySelector(".table-create-data-editor"),
     dataTextarea: dialog.querySelector(".table-create-data-textarea"),
+    dataOpenFileButton: dialog.querySelector(".table-create-data-open-file"),
+    dataFileInput: dialog.querySelector(".table-create-data-file-input"),
     dataPreview: dialog.querySelector(".table-create-data-preview"),
     createFromDataLink: dialog.querySelector(".table-create-from-data"),
     manualCreateLink: dialog.querySelector(".table-create-manual"),
@@ -2251,6 +2283,25 @@ function ensureTableCreateDialog(manager) {
     clearTableCreateDialogError(tableCreateDialogState);
   });
 
+  tableCreateDialogState.dataOpenFileButton.addEventListener(
+    "click",
+    function () {
+      tableCreateDialogState.dataFileInput.click();
+    },
+  );
+
+  tableCreateDialogState.dataFileInput.addEventListener(
+    "change",
+    async function (ev) {
+      var files = ev.target.files;
+      await loadTableCreateDataTextFile(
+        tableCreateDialogState,
+        files && files.length ? files[0] : null,
+      );
+      ev.target.value = "";
+    },
+  );
+
   tableCreateDialogState.dataTextarea.addEventListener(
     "dragenter",
     function (ev) {
@@ -2291,20 +2342,7 @@ function ensureTableCreateDialog(manager) {
       if (!files || !files.length) {
         return;
       }
-      try {
-        tableCreateDialogState.dataTextarea.value = await readTextFile(
-          files[0],
-        );
-        tableCreateDialogState.dataTextarea.dispatchEvent(
-          new Event("input", { bubbles: true }),
-        );
-        clearTableCreateDialogError(tableCreateDialogState);
-      } catch (_error) {
-        showTableCreateDialogError(
-          tableCreateDialogState,
-          "Could not read that text file.",
-        );
-      }
+      await loadTableCreateDataTextFile(tableCreateDialogState, files[0]);
     },
   );
 
@@ -6378,9 +6416,9 @@ function ensureRowEditDialog(manager) {
       <div class="row-edit-fields"></div>
       <div class="row-edit-bulk" hidden>
         <div class="row-edit-bulk-editor">
-          <p class="row-edit-bulk-note">Paste TSV, CSV, or JSON. You can also <button type="button" class="button-as-link row-edit-bulk-open-file">open a file</button> or drop it onto this textarea</p>
+          <p class="row-edit-bulk-note"><label for="row-edit-bulk-textarea">Paste TSV, CSV, or JSON</label>. You can also <button type="button" class="button-as-link row-edit-bulk-open-file">open a file</button> or drop it onto this textarea</p>
           <input class="row-edit-bulk-file-input" type="file" accept=".csv,.tsv,.json,.txt,text/csv,text/tab-separated-values,application/json,text/plain" hidden>
-          <textarea class="row-edit-input row-edit-bulk-textarea" id="row-edit-bulk-textarea" name="_bulk_rows" rows="12" spellcheck="false" aria-label="Bulk rows"></textarea>
+          <textarea class="row-edit-input row-edit-bulk-textarea" id="row-edit-bulk-textarea" name="_bulk_rows" rows="12" spellcheck="false"></textarea>
           <div class="row-edit-bulk-actions">
             <button type="button" class="btn btn-ghost row-edit-copy-template"><span class="row-edit-copy-template-label-wide">Copy spreadsheet template</span><span class="row-edit-copy-template-label-narrow">Copy template</span></button>
             <span class="row-edit-bulk-template-note"><span class="row-edit-bulk-template-note-wide">You can paste the template into Google Sheets or Excel.</span><span class="row-edit-bulk-template-note-narrow">Paste into Google Sheets or Excel</span></span>
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index bc30b599..c1acff9e 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -399,14 +399,42 @@ def test_create_table_from_data_flow(page, datasette_server):
     assert dialog.locator(".table-create-save").inner_text() == "Preview rows"
     assert (
         dialog.locator(".table-create-data-note").inner_text()
-        == "Paste TSV, CSV, or JSON. You can also drop a text file onto this textarea."
+        == "Paste TSV, CSV, or JSON. You can also open a file or drop it onto this textarea"
+    )
+    assert dialog.locator(".table-create-data-open-file").inner_text() == "open a file"
+    assert (
+        dialog.locator(".table-create-data-editor").evaluate(
+            """node => Array.from(node.children)
+            .filter((child) => !child.hidden)
+            .map((child) => child.className)
+            .join(" ")"""
+        )
+        == ("table-create-data-note table-create-input table-create-data-textarea")
     )
     assert dialog.locator(".table-create-manual").inner_text() == (
         "Create table manually"
     )
+    assert (
+        dialog.get_by_label("Paste TSV, CSV, or JSON").get_attribute("id")
+        == "table-create-data-textarea"
+    )
+
+    textarea = dialog.locator(".table-create-data-textarea")
+    dropped_value = textarea.evaluate("""node => new Promise((resolve) => {
+            node.addEventListener("input", () => resolve(node.value), { once: true });
+            const file = new File(["short_id,name\\nx,Ada"], "Repo Export 2026!!.CSV", { type: "text/csv" });
+            const dataTransfer = new DataTransfer();
+            dataTransfer.items.add(file);
+            node.dispatchEvent(new DragEvent("dragenter", { bubbles: true, cancelable: true, dataTransfer }));
+            node.dispatchEvent(new DragEvent("dragover", { bubbles: true, cancelable: true, dataTransfer }));
+            node.dispatchEvent(new DragEvent("drop", { bubbles: true, cancelable: true, dataTransfer }));
+        })""")
+    assert dropped_value == "short_id,name\nx,Ada"
+    assert dialog.locator(".table-create-table-name").input_value() == (
+        "repo_export_2026"
+    )
 
     dialog.locator(".table-create-table-name").fill("playwright_from_data")
-    textarea = dialog.locator(".table-create-data-textarea")
     textarea.fill(
         json.dumps(
             {
@@ -431,6 +459,18 @@ def test_create_table_from_data_flow(page, datasette_server):
     assert "short_id" in preview_text
     assert "Ada" in preview_text
     assert "2.5" in preview_text
+    preview_cell_style = dialog.locator(
+        ".table-create-data-preview-table td"
+    ).first.evaluate(
+        """node => ({
+            overflowWrap: getComputedStyle(node).overflowWrap,
+            whiteSpace: getComputedStyle(node).whiteSpace
+        })"""
+    )
+    assert preview_cell_style == {
+        "overflowWrap": "anywhere",
+        "whiteSpace": "normal",
+    }
 
     dialog.locator(".table-create-cancel").click()
     assert dialog.evaluate("node => node.open")
@@ -911,6 +951,10 @@ def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
     )
     copy_template = dialog.locator(".row-edit-copy-template")
     assert copy_template.inner_text() == "Copy spreadsheet template"
+    assert (
+        dialog.get_by_label("Paste TSV, CSV, or JSON").get_attribute("id")
+        == "row-edit-bulk-textarea"
+    )
     assert dialog.locator(".row-edit-copy-template-label-narrow").text_content() == (
         "Copy template"
     )
@@ -953,6 +997,18 @@ def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
     assert "id" not in preview_text
     assert "From CSV" in preview_text
     assert "null" in preview_text
+    preview_cell_style = dialog.locator(
+        ".row-edit-bulk-preview-table td"
+    ).first.evaluate(
+        """node => ({
+            overflowWrap: getComputedStyle(node).overflowWrap,
+            whiteSpace: getComputedStyle(node).whiteSpace
+        })"""
+    )
+    assert preview_cell_style == {
+        "overflowWrap": "anywhere",
+        "whiteSpace": "normal",
+    }
     assert dialog.locator(".row-edit-cancel").inner_text() == "Back"
     dialog.locator(".row-edit-cancel").click()
     assert dialog.evaluate("node => node.open")

From b759ea548606bc9bf9a4bf0e33e2d57ead7e0ab8 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 29 Jun 2026 17:38:51 -0700
Subject: [PATCH 301/386] Mock navigator.clipboard so Playwright passes in all
 three browsers

---
 tests/test_playwright.py | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index c1acff9e..60c81315 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -914,9 +914,20 @@ def test_navigation_search_renders_jump_sections_from_javascript_plugins(
 
 @pytest.mark.playwright
 def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
-    page.context.grant_permissions(
-        ["clipboard-read", "clipboard-write"], origin=datasette_server.rstrip("/")
-    )
+    page.add_init_script("""
+        (() => {
+            let clipboardText = "";
+            Object.defineProperty(navigator, "clipboard", {
+                configurable: true,
+                get: () => ({
+                    writeText: async (text) => {
+                        clipboardText = String(text);
+                    },
+                    readText: async () => clipboardText,
+                }),
+            });
+        })();
+        """)
     page.goto(f"{datasette_server}data/projects")
     page.locator('button[data-table-action="insert-row"]').click()
 

From 8985ecf4387164e76147e7188693a08dc1a7dd1e Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Wed, 1 Jul 2026 22:32:28 +0000
Subject: [PATCH 302/386] Add JSON API reference and 1.0 stability review
 documents

- existing-api.md: complete reference for the JSON API as implemented,
  derived from source code (routes, views, renderer, permissions)
- stable-api-recommendations.md: consistency and completeness review
  with prioritized recommendations for the 1.0 stable release

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 existing-api.md               | 1211 +++++++++++++++++++++++++++++++++
 stable-api-recommendations.md |  367 ++++++++++
 2 files changed, 1578 insertions(+)
 create mode 100644 existing-api.md
 create mode 100644 stable-api-recommendations.md

diff --git a/existing-api.md b/existing-api.md
new file mode 100644
index 00000000..b3eda9d4
--- /dev/null
+++ b/existing-api.md
@@ -0,0 +1,1211 @@
+# Datasette JSON API — As Implemented
+
+This document describes the JSON API of this Datasette codebase (version `1.0a35`) as
+derived directly from the source code. It intentionally ignores the existing `docs/`
+directory: every claim below is based on the route table in `datasette/app.py`
+(`Datasette._routes()`, app.py:2507-2767) and the view implementations in
+`datasette/views/`.
+
+## Contents
+
+- [Cross-cutting behavior](#cross-cutting-behavior)
+- [Instance endpoints](#instance-endpoints)
+- [Database endpoints](#database-endpoints)
+- [Table and row read endpoints](#table-and-row-read-endpoints)
+- [The write API](#the-write-api)
+- [Stored (canned) queries API](#stored-canned-queries-api)
+- [Authentication and tokens](#authentication-and-tokens)
+- [Appendix: registered actions (permissions)](#appendix-registered-actions-permissions)
+
+---
+
+## Cross-cutting behavior
+
+### URL formats and content negotiation
+
+- Most read endpoints are registered with an optional format suffix:
+  `/(...)(\.(?P<format>json))?$`. The bare path returns HTML; the `.json`
+  extension returns JSON. The homepage additionally accepts the legacy
+  `.jsono` extension, which returns identical JSON (app.py:2517-2518).
+- Table, row and query routes accept any `\w+` format extension; formats other
+  than the built-in `html`, `json`, `csv`, `blob` must be provided by a plugin
+  via `register_output_renderer`, otherwise the request 404s.
+- HTML responses include a `Link: <...>; rel="alternate";
+  type="application/json+datasette"` header pointing at the `.json` variant
+  (views/base.py:141-159), unless the view opts out with
+  `has_json_alternate = False`.
+- Database, table, row and query names in paths are **tilde-encoded**
+  (a percent-encoding variant using `~` as the escape character;
+  utils/__init__.py `_TILDE_ENCODING_SAFE`). Multi-column primary keys in row
+  URLs are comma-separated.
+- JSON responses are always compact `json.dumps` output serialized by
+  `CustomJSONEncoder`; there is no pretty-printing query parameter. Binary
+  values are serialized as `{"$base64": true, "encoded": "..."}`.
+- Success content type: `application/json; charset=utf-8`
+  (`_shape=array&_nl=on` responses use `text/plain`).
+
+### Error shapes (there are several)
+
+The codebase produces **four distinct JSON error shapes**, depending on which
+layer generates the error:
+
+1. **Exception handler** (handle_exception.py:21-59) — used when a view raises
+   `NotFound`, `Forbidden` (JSON paths only — see below), `DatasetteError`,
+   `BadRequest` etc. and the request path ends in `.json`:
+
+   ```json
+   {"ok": false, "error": "message", "status": 404, "title": null}
+   ```
+
+2. **The `_error()` helper** (views/base.py:183-184) — used by the write API,
+   stored-query API, execute-write and several permission-denied paths:
+
+   ```json
+   {"ok": false, "errors": ["message", "..."]}
+   ```
+
+   Note: plural `errors`, a list, and no `status`/`title` keys.
+
+3. **JSON renderer errors** (renderer.py:52-56) — SQL errors on table/query
+   endpoints return HTTP 400 with the error embedded in the data envelope:
+
+   ```json
+   {"ok": false, "error": "no such table: x", "rows": [], "truncated": false}
+   ```
+
+   An invalid `_shape=` value produces `{"ok": false, "error": "Invalid _shape: x",
+   "status": 400, "title": null}` (renderer.py:101-108).
+
+4. **Ad-hoc `{"error": ...}` objects** — the permission debug endpoints
+   (`/-/allowed`, `/-/rules`, `/-/check`, POST `/-/permissions`) return e.g.
+   `{"error": "Unknown action: x"}` with no `ok` key (views/special.py).
+
+Method-not-allowed responses return HTTP 405
+`{"ok": false, "error": "Method not allowed"}` when the path ends in `.json`
+or the request content type is `application/json`; plain text otherwise
+(views/base.py:53, 88-98).
+
+**`Forbidden` is special:** when a view raises `Forbidden` (e.g. via
+`ensure_permission`), the default `forbidden()` plugin hook renders an **HTML
+error page with status 403 even for `.json` requests**
+(forbidden.py:4-19, app.py:2895-2904). Endpoints that check permissions
+themselves and return `_error(..., 403)` produce JSON instead. So a JSON
+client may receive either an HTML 403 page or a JSON 403 body depending on
+the endpoint.
+
+### CORS
+
+When Datasette is started with `--cors`, responses gain
+(utils/__init__.py:1297-1302):
+
+```
+Access-Control-Allow-Origin: *
+Access-Control-Allow-Headers: Authorization, Content-Type
+Access-Control-Expose-Headers: Link
+Access-Control-Allow-Methods: GET, POST, HEAD, OPTIONS
+Access-Control-Max-Age: 3600
+```
+
+### CSRF / cross-origin protection
+
+Datasette uses header-based cross-origin protection
+(`CrossOriginProtectionMiddleware`, csrf.py:67-178) rather than CSRF tokens
+for API calls. For non-GET/HEAD/OPTIONS requests:
+
+1. Requests carrying `Authorization: Bearer ...` **and no `Cookie` header**
+   bypass the check entirely (csrf.py:98-110).
+2. Otherwise `Sec-Fetch-Site` must be `same-origin` or `none`; other values → 403.
+3. If neither `Sec-Fetch-Site` nor `Origin` is present (curl, API clients),
+   the request passes.
+4. Fallback: `Origin` must exactly match the request scheme/host/port → else 403.
+
+Plain JSON API clients (no cookies, no browser headers) are never blocked;
+`Content-Type: application/json` itself plays no role in the CSRF decision.
+
+### Settings that govern the API
+
+From `SETTINGS` (app.py:197-287): `default_page_size` (100),
+`max_returned_rows` (1000), `max_insert_rows` (100), `sql_time_limit_ms`
+(1000), `default_facet_size` (30), `facet_time_limit_ms` (200),
+`allow_facet` (true), `allow_download` (true), `allow_signed_tokens` (true),
+`default_allow_sql` (true), `max_signed_tokens_ttl` (0), `default_cache_ttl`
+(5), `allow_csv_stream` (true), `max_csv_mb` (100), `force_https_urls`
+(false), `trace_debug` (false), `base_url` ("/").
+
+### The JSON renderer: `_shape`, `_nl`, `_json`, `_json_infinity`
+
+`json_renderer` (renderer.py:31-126) processes `.json` output for table, row
+and query views (but **not** for the instance/database/debug endpoints, which
+build JSON directly):
+
+- **`_shape`** (default `objects`):
+  - `objects` — `{"ok": true, "rows": [{col: val}, ...], "truncated": false, ...}`
+  - `arrays` — same envelope, each row a list of values
+  - `array` — response body is a bare JSON array of row objects
+  - `arrayfirst` — bare JSON array of the first column's values
+  - `object` — table views only: an object keyed by primary-key string.
+    On queries: `{"ok": false, "error": "_shape=object is only available on
+    tables"}` (with HTTP status 200); on tables without primary keys a similar
+    error.
+  - anything else — HTTP 400 `{"ok": false, "error": "Invalid _shape: x",
+    "status": 400, "title": null}`
+- **`_nl=on`** — with `_shape=array` only: newline-delimited JSON, `text/plain`.
+- **`_json=COLUMN`** (repeatable) — parse that column's string values with
+  `json.loads` so they nest as JSON; parse failures leave the value unchanged.
+- **`_json_infinity=1`** — preserve `Infinity`/`-Infinity`; by default they
+  are replaced with `null`.
+- `columns` is stripped from dict-shaped output unless `?_extra=columns` was
+  requested (renderer.py:110-113).
+- If a SQL error occurred, `_shape` is ignored, HTTP status is 400 and the
+  envelope carries `"ok": false, "error": ...` (renderer.py:52-56).
+
+### The `?_extra=` system
+
+Table, row and query JSON responses support `?_extra=` (repeatable and/or
+comma-separated, extras.py:9-14) to add keys to the response. Extras are
+scope-registered (`ExtraScope.TABLE` / `ROW` / `QUERY`) and only **public**
+extras are available over JSON (extras.py:73-92). Unknown extra names are
+silently ignored. The available names per scope are listed with the relevant
+endpoints below.
+
+---
+
+## Instance endpoints
+
+Most of these are implemented with `JsonDataView` (views/special.py:30-79):
+GET-only; bare path renders an HTML page (`show_json.html`), `.json` returns
+the data; permission defaults to `view-instance` and denial raises
+`Forbidden` → **HTML** 403 page.
+
+### GET /
+
+Routes: `/(\.(?P<format>jsono?))?$` and `/-/(\.(?P<format>jsono?))?$`
+(app.py:2517-2518); `/-` permanently redirects to `/-/`. `IndexView`
+(views/index.py:22-189). `GET /.json`, `/.jsono` and `/-/.json` return JSON.
+
+- **Permission:** `view-instance` (denied → 403). Databases and tables are
+  further filtered by `view-database` / `view-table` for the actor.
+- **Parameters:** `_sort=relationships` sorts each database's truncated table
+  list by foreign-key relationship count.
+- **JSON response** (index.py:147-161):
+  - `databases` — an **object keyed by database name** (not a list). Each
+    value: `name`, `hash` (or null), `color`, `path`,
+    `tables_and_views_truncated` (up to 5 items: `name`, `columns`,
+    `primary_keys`, `count` (int or null), `hidden`, `fts_table`,
+    `num_relationships_for_sorting`, `private`; view items are just
+    `{"name", "private"}`), `tables_and_views_more` (bool), `tables_count`,
+    `table_rows_sum`, `show_table_row_counts`, `hidden_table_rows_sum`,
+    `hidden_tables_count`, `views_count`, `private`.
+  - `metadata` — instance metadata object.
+
+### GET /-/versions(.json)
+
+`JsonDataView` over `Datasette._versions` (app.py:2548-2551, 2171-2245).
+Permission `view-instance`. No parameters.
+
+Response keys: `python` (`{version, full}`), `datasette` (`{version}` plus
+optional `note`), `asgi` (`"3.0"`), `uvicorn` (string or null), `sqlite`
+(`{version, fts_versions, extensions, compile_options}`; `extensions`
+includes `json1` and optionally `spatialite`), `pysqlite3` (only when
+running under pysqlite3).
+
+### GET /-/plugins(.json)
+
+app.py:2552-2557, `Datasette._plugins` (app.py:2247-2266). Permission
+`view-instance`.
+
+- **Parameters:** `?all=1` — include Datasette's built-in default plugins
+  (filtered out by default).
+- **Response:** a JSON **array**, sorted by name, of
+  `{"name", "static", "templates", "version", "hooks"}`.
+
+### GET /-/settings(.json)
+
+app.py:2558-2561. Permission `view-instance`. No parameters. Returns a flat
+object mapping every setting name (see [Settings](#settings-that-govern-the-api))
+to its effective value.
+
+### GET /-/config(.json)
+
+app.py:2562-2565. Permission `view-instance`. No parameters. Returns the full
+`datasette.yaml` configuration dict passed through
+`redact_keys(config, ("secret", "key", "password", "token", "hash", "dsn"))`
+(app.py:2502-2505) — any dict key containing one of those substrings has its
+value replaced by `"***"` (utils/__init__.py:1532-1556).
+
+### GET /-/threads(.json)
+
+app.py:2566-2569, `Datasette._threads` (app.py:2268-2285). Permission
+`view-instance`. No parameters.
+
+Response: `num_threads`, `threads` (list of `{name, ident, daemon}`),
+`num_tasks`, `tasks` (asyncio task repr strings). When the
+`num_sql_threads` setting is 0 the response is exactly
+`{"num_threads": 0, "threads": []}`.
+
+### GET /-/databases(.json)
+
+app.py:2570-2573, `Datasette._connected_databases` (app.py:2157-2169).
+Permission `view-instance`. No parameters.
+
+Response: a JSON array of `{"name", "route", "path", "size", "is_mutable",
+"is_memory", "hash"}` — **all attached databases are listed regardless of
+per-database `view-database` permissions**.
+
+### GET /-/actor(.json)
+
+app.py:2574-2579, registered with `permission=None` — **accessible to any
+request including anonymous**. No parameters.
+
+Response: `{"actor": {...}}` or `{"actor": null}` (app.py:2287-2288).
+
+### GET /-/actions(.json)
+
+app.py:2580-2589. Permission **`permissions-debug`**. No parameters.
+
+Response: a JSON array, sorted by name, of `{"name", "abbr", "description",
+"takes_parent", "takes_child", "resource_class", "also_requires"}`
+(app.py:2290-2304).
+
+### GET /-/auth-token
+
+`AuthTokenView` (app.py:2590-2593, views/special.py:198-217). GET only, no
+`.json` variant, HTML/redirect only.
+
+- **Parameter:** `token` — the one-time secret printed by `datasette --root`.
+- Match → invalidates the token, sets the signed `ds_actor` cookie to
+  `{"id": "root"}` and 302-redirects to the homepage. Mismatch or reuse →
+  `Forbidden` → 403 HTML.
+
+### GET/POST /-/create-token
+
+`CreateTokenView` (app.py:2594-2597, views/special.py:727-856). **HTML form
+endpoint only — there is no JSON request/response mode in this codebase**
+(`has_json_alternate = False`; the POST body must be form-encoded, a JSON
+content type raises `BadRequest` → 400).
+
+- **Gates** (each failure → `Forbidden` → 403): `allow_signed_tokens` must be
+  on; request must have an actor with an `id`; the actor must not itself be
+  token-derived.
+- **POST fields:** `expire_type` (`""`/`minutes`/`hours`/`days`),
+  `expire_duration` (positive int), plus restriction checkboxes named
+  `all:<action>`, `database:<db>:<action>`,
+  `resource:<db>:<table>:<action>`.
+- **Response:** HTML page containing the new `dstok_` token.
+- Programmatic alternatives: `datasette create-token` CLI or
+  `datasette.create_token()`.
+
+### GET /-/api
+
+`ApiExplorerView` (app.py:2598-2601, views/special.py:859-1020). HTML API
+explorer, GET only. Permission `view-instance` (403 on denial).
+
+### GET /-/jump(.json)
+
+`JumpView` (app.py:2602-2605, views/special.py:1023-1201). The route allows
+an optional `.json` suffix but the view **always returns JSON**.
+
+- **Permission:** none checked directly; results are filtered via
+  `allowed_resources_sql` for the current actor (default items come from the
+  `jump_items_sql` plugin hook).
+- **Parameter:** `q` — whitespace-split terms matched as a case-insensitive
+  `%term1%term2%` LIKE pattern.
+- **Response:** `{"matches": [...], "truncated": bool}`; each match:
+  `name`, `url`, `type` (`database`/`table`/`view`/`query`/plugin-defined),
+  `description`, optional `display_name`. Capped at 100 matches.
+
+### GET /-/schema(.json|.md)
+
+`InstanceSchemaView` (app.py:2610-2613, views/special.py:1257-1293).
+
+- **Permission:** no explicit check; only databases the actor can
+  `view-database` are included (others silently omitted).
+- **Formats:** no extension → HTML; `.json` →
+  `{"schemas": [{"database": name, "schema": "..."}]}`; `.md` →
+  `text/markdown` rendering.
+
+### GET/POST /-/logout
+
+`LogoutView` (app.py:2614-2617, views/special.py:220-238). HTML endpoint.
+GET renders a confirmation page (or redirects if anonymous); POST deletes the
+`ds_actor` cookie and 302-redirects to `/`.
+
+### GET/POST /-/permissions
+
+`PermissionsDebugView` (app.py:2618-2621, views/special.py:241-295). No
+`.json` route. Both methods require `view-instance` **and**
+`permissions-debug` (403 on denial).
+
+- **GET** — HTML permission-check log; `?filter=all|exclude-yours|only-yours`.
+- **POST** — form-encoded `actor` (JSON string), `permission`, optional
+  `resource_1`, `resource_2`; returns **JSON**
+  `{"action", "allowed", "resource": {"parent", "child", "path"}}` plus
+  `actor_id` when present. Errors: unknown action → 404 `{"error": ...}`;
+  child without parent → 400 `{"error": ...}`.
+
+### GET /-/allowed(.json)
+
+`AllowedResourcesView` (app.py:2622-2625, views/special.py:298-460). Bare
+path always renders the HTML form; `.json` returns JSON.
+
+- **Permission:** none — reports the **current actor's own** allowed
+  resources. Items gain a `reason` field if the actor also holds
+  `permissions-debug`.
+- **Parameters:** `action` (required; missing → 400 `{"error": ...}`, unknown
+  → 404), `parent`, `child` (requires `parent`), `page` (default 1),
+  `page_size` (default 50, silently capped at 200).
+- **Response:** `{"action", "actor_id", "page", "page_size", "total",
+  "items": [{"parent", "child", "resource"}]}` with optional `next_url` /
+  `previous_url`.
+
+### GET /-/rules(.json)
+
+`PermissionRulesView` (app.py:2626-2629, views/special.py:463-584).
+Permission `view-instance` **and** `permissions-debug`. Parameters and error
+shapes as `/-/allowed`. Response items:
+`{"parent", "child", "resource", "allow" (1|0), "reason", "source_plugin"}`.
+
+### GET /-/check(.json)
+
+`PermissionCheckView` (app.py:2630-2633, views/special.py:633-662).
+Permission `permissions-debug`. Parameters `action` (required), `parent`,
+`child`. Checks the **current request's actor**; response
+`{"action", "allowed", "resource": {...}}` plus `actor_id`.
+
+### GET/POST /-/messages
+
+`MessagesDebugView` (app.py:2634-2637, views/special.py:703-724). HTML debug
+tool for flash messages; permission `view-instance`; POST is form-encoded
+(`message`, `message_type` = INFO/WARNING/ERROR/all) and 302-redirects.
+
+### GET /-/allow-debug
+
+`AllowDebugView` (app.py:2638-2641, views/special.py:665-700). GET only, HTML
+only, **no permission required**. Parameters `actor` and `allow` (JSON
+strings); renders the result of `actor_matches_allow()` in the page.
+
+### GET /-/patterns
+
+Pattern portfolio page (app.py:2642-2645). HTML only; not part of the JSON API.
+
+### GET /-/debug/autocomplete
+
+`AutocompleteDebugView` (app.py:2646-2649, views/special.py:94-195). HTML
+debug page for the table autocomplete API; permission `view-instance` plus
+`view-table` when `?database=&table=` are supplied.
+
+---
+
+## Database endpoints
+
+### GET /\<database\>.db
+
+Downloads the raw SQLite file. Route → `database_download`
+(app.py:2650-2653; views/database.py:533-570).
+
+- **Permission:** `view-database-download` (denied → `Forbidden` → 403 HTML).
+- **Other gates:** unknown database → 404 `"Invalid database"`; in-memory
+  database → 404; `allow_download` off **or** mutable database →
+  `Forbidden("Database download is forbidden")`; no file path → 404.
+- **Response:** streamed `application/octet-stream` with a
+  `content-disposition` attachment; immutable databases with a known hash set
+  `Etag` and honor `If-None-Match` → 304.
+
+### GET /\<database\>(.json)
+
+`DatabaseView` (app.py:2654-2657; views/database.py:71-277). Only `html` and
+`json` formats are accepted; any other extension → 404 `"Invalid format: ..."`.
+
+- **Permission:** `view-database` via `check_visibility` (denied →
+  `Forbidden` → 403 HTML). Table/view listings are filtered by `view-table`;
+  stored queries by `view-query`.
+- **Parameters:**
+  - `?sql=` — non-blank value 302-redirects to `/<database>/-/query?...`
+    preserving the query string and format.
+  - No `?_extra=` and no `_shape` support — the JSON is built directly and
+    returned via `Response.json`, bypassing the JSON renderer
+    (views/database.py:189-212).
+- **JSON response** (all keys always present):
+  - `ok` — always `true`
+  - `database` — name; `private` — bool; `path` — URL path; `size` — bytes
+  - `tables` — list (includes hidden tables), each:
+    `name`, `columns` (names), `primary_keys`, `count` (int or null,
+    time-boxed), `count_truncated` (bool — count is a capped lower bound),
+    `hidden`, `fts_table`, `foreign_keys` (`{incoming: [...], outgoing: [...]}`
+    of `{other_table, column, other_column}`), `private`
+  - `hidden_count` — number of hidden tables
+  - `views` — list of `{name, private}`
+  - `queries` — **up to 5** stored queries (canonical stored-query objects,
+    see the stored-queries section); `queries_more` (bool);
+    `queries_count` (total visible)
+  - `allow_execute_sql` — bool for this actor
+  - `table_columns` — `{table: [columns]}`, empty `{}` unless
+    `allow_execute_sql` (views map to `[]`)
+  - `metadata` — database metadata dict
+
+### GET /\<database\>/-/query(.json) — arbitrary SQL
+
+`QueryView` (app.py:2691-2694; views/database.py:573-1130). The same class
+also executes stored queries dispatched from the table route (see stored
+queries section).
+
+- **Permission:** `execute-sql` on the database via `check_visibility`
+  (denied → `Forbidden` → 403 HTML).
+- **Parameters:**
+  - `sql` — SQL to run. Must pass `validate_sql_select`
+    (utils/__init__.py:345-354): after stripping `--` comment lines it must
+    start with `select`, `with` or an `explain` variant, and must not contain
+    `pragma` (except allowlisted `pragma_*()` table-valued functions).
+    Failure → 400 `DatasetteError` titled `"Invalid SQL"` → JSON
+    `{"ok": false, "error": "Statement must be a SELECT", "status": 400,
+    "title": "Invalid SQL"}`.
+  - Any other `name=value` pair supplies the `:name` named parameter; missing
+    parameters default to `""`. Names starting with `_` are excluded.
+  - `_timelimit` — per-request SQL time limit in ms.
+  - `_shape`, `_nl`, `_json`, `_json_infinity` — see the JSON renderer section.
+  - `_extra` — QUERY-scope extras: `columns`, `debug`, `request`,
+    `render_cell`, `query` (`{"sql", "params"}`), `metadata`, `database`,
+    `database_color`, `private`, `extras`.
+- **Response** (default shape):
+  `{"ok": true, "rows": [{col: val}, ...], "truncated": false}` plus any
+  requested extras. `truncated: true` when the result hit `max_returned_rows`.
+- **Errors:**
+  - SQLite errors (e.g. `no such table`) are **not** raised — they surface as
+    HTTP 400 `{"ok": false, "error": "<message>", "rows": [], "truncated": false}`.
+  - Time limit → 400 titled `"SQL Interrupted"` (the `error` value contains
+    an HTML fragment).
+  - `?sql=` omitted → 200 `{"ok": true, "rows": [], "truncated": false}`
+    (the CSV format instead errors 400 `"?sql= is required"`).
+- `.csv` streams CSV; unknown extensions → 404.
+
+### GET /\<database\>/-/query/parameters
+
+`QueryParametersView` (app.py:2687-2690; views/stored_queries.py:26-51).
+
+- **Permission:** `execute-sql` → 403 JSON
+  `{"ok": false, "errors": ["Permission denied: need execute-sql"]}`.
+- **Parameters:** only `sql` (default `""`); any other key → 400
+  `"Invalid keys: ..."`.
+- **Response:** 200 `{"ok": true, "parameters": ["name1", ...]}`. SQL with a
+  parameter beginning `_` → 400 `"Magic parameters are not allowed"`.
+- Responses carry `Content-Security-Policy: frame-ancestors 'none'` and
+  `X-Frame-Options: DENY`.
+
+### POST /\<database\>/-/create
+
+`TableCreateView` (app.py:2658; views/table_create_alter.py:785-962).
+GET → 405. Body is parsed as JSON regardless of content type; invalid JSON →
+400 `{"ok": false, "errors": ["Invalid JSON: ..."]}`.
+
+- **Permissions** (all denials → 403 `{"ok": false, "errors": [...]}`,
+  all checked at the **database** level):
+  - `create-table` — always required (`["Permission denied"]`)
+  - `insert-row` — if `rows`/`row` provided (`need insert-row`)
+  - `update-row` — if `replace: true` (`need update-row`)
+  - `alter-table` — if `alter: true` on an **existing** table
+    (`need alter-table`); when the table does not exist yet and rows are
+    supplied, alter is enabled automatically.
+- **Request schema** (pydantic `CreateTableRequest`, extra keys forbidden →
+  400 `"Invalid keys: a, b"`):
+  - `table` (required) — must match `^(?!sqlite_)[^\n]+$`
+  - `rows` (list of objects) / `row` (single object) — mutually exclusive
+  - `columns` — list of `{name, type, fk_table, fk_column, not_null,
+    default, default_expr}`; mutually exclusive with `rows`/`row`; `type` one
+    of `text`/`integer`/`float`/`blob` (default `text`); `default` and
+    `default_expr` mutually exclusive; `default_expr` one of
+    `current_timestamp`, `current_date`, `current_time`, `current_unixtime`,
+    `current_unixtime_ms`. At least one of `columns`/`rows`/`row` required.
+  - `pk` (string) / `pks` (list) — mutually exclusive. For an existing table
+    a differing pk → 400 `"pk cannot be changed for existing table"`.
+  - `ignore` / `replace` (bools) — mutually exclusive; require `row`/`rows`
+    and `pk`/`pks`.
+  - `alter` (bool) — add missing columns when inserting into an existing table.
+- **Success** — **201**:
+  ```json
+  {"ok": true, "database": "...", "table": "...",
+   "table_url": "https://.../db/table", "table_api_url": "https://.../db/table.json",
+   "schema": "CREATE TABLE ...", "row_count": 2}
+  ```
+  `row_count` only when rows were inserted. Write failures → 400
+  `{"ok": false, "errors": ["<sqlite message>"]}`. Emits `create-table` /
+  `insert-rows` / `alter-table` events.
+
+### POST /\<database\>/-/execute-write
+
+`ExecuteWriteView` (app.py:2679-2682; views/execute_write.py:236-476). GET on
+the same path renders an HTML form (requires `execute-write-sql`).
+
+- **Permission (POST):** `execute-write-sql` → 403
+  `{"ok": false, "errors": ["Permission denied: need execute-write-sql"]}`;
+  immutable database → 403 `["Database is immutable"]`.
+- **Per-statement permissions:** the SQL is analyzed
+  (`decision_for_write_sql_operation`, write_sql.py:63-189) and each
+  operation must pass:
+
+  | Operation | Requirement |
+  |---|---|
+  | `select` / internal ops / function calls | ignored |
+  | read of a table | `view-table` on that table |
+  | `insert` or `update` | **all of** `insert-row`, `update-row`, `delete-row` on the table |
+  | `delete` | `delete-row` |
+  | `create table` | `create-table` on the database |
+  | `alter table`, `create index`, `drop index` | `alter-table` on the table |
+  | `drop table` | `drop-table` |
+  | `VACUUM`, virtual-table writes, shadow-table writes | rejected outright (403) |
+  | statements touching attached databases | rejected (403) |
+
+- **Body:** JSON (`{"sql": ..., "params": {...}}` — only those two keys) or
+  form-encoded (`sql` plus one field per parameter, `_sql_param_` prefix
+  stripped). Validation errors (400): `"SQL is required"`,
+  `"params must be a dictionary"`, `"Unknown parameters: a, b"`,
+  `"Magic parameters are not allowed"`, `"Could not analyze query: ..."`,
+  `"Use /-/query for read-only SQL; this endpoint only executes writes"`.
+- **JSON is returned when** the body was JSON, `Accept: application/json`, or
+  a truthy `_json` field is present; otherwise HTML.
+- **Success** — 200:
+  ```json
+  {"ok": true, "message": "Query executed, 1 row affected", "rowcount": 1,
+   "rows": [], "truncated": false,
+   "analysis": [{"operation": "insert", "database": "db", "table": "t",
+                  "required_permission": "insert-row, update-row, delete-row",
+                  "source": null}]}
+  ```
+  `rows` is populated by `RETURNING` clauses. SQLite errors → 400
+  `{"ok": false, "errors": ["<message>"]}`. Anti-framing headers on all
+  responses.
+
+### GET /\<database\>/-/execute-write/analyze
+
+`ExecuteWriteAnalyzeView` (app.py:2675-2678; views/execute_write.py:479-507).
+
+- **Permission:** `execute-write-sql` → 403 `errors` JSON.
+- **Parameters:** only `sql` allowed (else 400 `"Invalid keys: ..."`).
+- **Response** — 200 even when analysis fails (`ok: false` in body):
+  `{"ok", "parameters", "analysis_error", "analysis_rows":
+  [{operation, database, table, required_permission, source, allowed}],
+  "execute_disabled", "execute_disabled_reason"}`. `allowed` is a per-actor
+  permission check result (true/false/null).
+
+### GET /\<database\>/-/foreign-key-targets
+
+`DatabaseForeignKeyTargetsView` (app.py:2659-2662;
+views/table_create_alter.py:965-1005).
+
+- **Parameter:** `table` (optional) — only used for the permission check.
+- **Permission:** `create-table` on the database, **or** `alter-table` on
+  `?table=` when it names an existing table. Neither → 403
+  `{"ok": false, "errors": ["Permission denied: need create-table"]}`.
+- **Response:** 200 `{"ok": true, "database": "...", "targets":
+  [{"fk_table", "fk_column", "type"}]}` — every non-hidden table with exactly
+  one primary-key column; `type` is the pk's SQLite type affinity.
+
+### GET /\<database\>/-/schema(.json|.md)
+
+`DatabaseSchemaView` (app.py:2683-2686; views/special.py:1296-1329).
+
+- **Permission:** `view-database` (denied → `Forbidden` → 403 HTML).
+- **Unknown database** → 404; for `.json`:
+  `{"ok": false, "error": "Database not found"}`. (The existence check runs
+  before the permission check.)
+- **Responses:** `.json` → 200 `{"database": "<name>", "schema": "<SQL>"}`
+  (concatenated `sqlite_master.sql` joined with `;\n`); `.md` →
+  `text/markdown`; no extension → HTML. Note the JSON has **no `ok` key** on
+  success.
+
+---
+
+## Table and row read endpoints
+
+### GET /\<database\>/\<table\>.json
+
+Route `r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)(\.(?P<format>\w+))?$"` →
+`table_view` (app.py:2711-2714; views/table.py:1670). Serves both tables and
+SQL views. GET/HEAD only — POST returns a plain-text 405. If the name is
+neither a table nor a view but matches a stored query, the request is
+dispatched to `QueryView` (views/table.py:1703-1712).
+
+**Permission:** `view-table` via `check_visibility`; denial raises
+`Forbidden` → **HTML** 403 page even for `.json`. Unknown table →
+`TableNotFound` → 404 (JSON error shape for `.json` paths).
+
+**Default JSON keys** (views/table.py:2308-2332 + renderer):
+
+| Key | Meaning |
+|---|---|
+| `ok` | `true` when data was retrieved without error |
+| `next` | pagination token string, or `null` on the last page |
+| `rows` | list of row objects `{column: value}` (default `_shape=objects`) |
+| `truncated` | always present; `false` for table pages |
+
+`columns` is computed but removed unless `?_extra=columns` was requested.
+When there is a next page the response carries a
+`Link: <next_url>; rel="next"` header (views/table.py:1911-1912).
+
+**`?_extra=` options** (TABLE scope; registry
+views/table_extras.py:1197-1235; unknown names silently ignored):
+
+| `_extra=` | Returns |
+|---|---|
+| `count` | total matching-row count, computed with a `limit 10001` subquery so it caps at 10001; `null` with `_nocount` or on count timeout |
+| `count_sql` | the SQL used for the count |
+| `facet_results` | `{"results": {name: facet}, "timed_out": [...]}`; each facet: `{name, type, hideable, toggle_url, results: [{value, label, count, toggle_url, selected}], truncated}` |
+| `facets_timed_out` | facet names that exceeded `facet_time_limit_ms` |
+| `suggested_facets` | `[{name, toggle_url, (type)}]`; empty when suggestion is disabled or paginating |
+| `human_description_en` | English description of filters + sort |
+| `next_url` | absolute URL of the next page or `null` |
+| `columns` | column names of the returned rows |
+| `all_columns` | all table columns regardless of `_col`/`_nocol` |
+| `primary_keys` | pk column names (empty for rowid tables and views) |
+| `display_columns` | HTML-oriented column metadata |
+| `render_cell` | per-row plugin-rendered HTML strings |
+| `debug` | `{url_vars, resolved, nofacet, nosuggest}` — explicitly unstable |
+| `request` | `{url, path, full_path, host, args}` |
+| `query` | `{sql, params}` of the main query |
+| `column_types` | `{column: {type, config}}` assigned column types |
+| `set_column_type_ui` | UI helper, `null` unless actor has `set-column-type` |
+| `metadata` | table metadata dict including column descriptions |
+| `extras` | self-describing list of all available extras |
+| `database`, `table`, `database_color` | identity/display values |
+| `renderers` | `{format_name: url}` of formats that can render this data |
+| `custom_table_templates` | template lookup list |
+| `sorted_facet_results` | facets as a display-ordered list |
+| `table_definition` | `CREATE TABLE` SQL |
+| `view_definition` | `CREATE VIEW` SQL, `null` for tables |
+| `is_view` | boolean |
+| `private` | `true` if visible to this actor but not anonymously |
+| `expandable_columns` | `[[foreign_key, label_column_or_null], ...]` |
+| `form_hidden_args` | pairs of `_`-prefixed args for HTML forms |
+
+Non-public extras (`actions`, `filters`, `display_rows`) are HTML-only and
+never appear in JSON. `_extra=_html` expands to the full HTML bundle
+(views/table_extras.py:1162-1194). Any `_facet*` argument implicitly adds
+`facet_results`; `_shape=object` implicitly adds `primary_keys`
+(views/table.py:2252-2256). There is **no** `filtered_table_rows_count`
+extra — it was replaced by `count`.
+
+**Column filters `?<column>__<op>=<value>`** (filters.py:260-427). Any
+querystring key not starting with `_` is a filter; bare `?column=value` means
+`exact`. Columns whose names start with `_` can be filtered as
+`?_col__exact=`. Operators:
+
+| op | SQL |
+|---|---|
+| `exact` | `"col" = :p` (default) |
+| `not` | `"col" != :p` |
+| `contains` / `notcontains` | `like '%v%'` / `not like '%v%'` |
+| `endswith` / `startswith` | `like '%v'` / `like 'v%'` |
+| `gt` / `gte` / `lt` / `lte` | `>` `>=` `<` `<=` (numeric strings cast to int) |
+| `like` / `notlike` | raw `like` / `not like` pattern |
+| `glob` | `glob` |
+| `in` / `notin` | comma-separated list, or JSON array if the value starts with `[` |
+| `arraycontains` / `arraynotcontains` | `[not] in (select value from json_each("col"))` (requires JSON1) |
+| `date` | `date("col") = :p` |
+| `isnull` / `notnull` | `is null` / `is not null` (no value) |
+| `isblank` / `notblank` | `(is null or = '')` / opposite (no value) |
+
+**Special (underscore) parameters:**
+
+| Param | Behavior |
+|---|---|
+| `_where=SQL` | extra raw where clause (repeatable); requires `execute-sql` else 403 `"_where= is not allowed"` |
+| `_search=q` | FTS against the table's FTS table |
+| `_search_<column>=q` | FTS restricted to one column; 400 if invalid |
+| `_searchmode=raw` | pass the query straight to `match` |
+| `_fts_table=` / `_fts_pk=` | override the FTS table / pk used for joins |
+| `_through={"table","column","value"}` | filter via an incoming foreign key (repeatable, JSON value) |
+| `_sort=col` / `_sort_desc=col` | sort; 400 if both given or column not sortable |
+| `_next=token` | pagination token |
+| `_size=N\|max` | page size; default `default_page_size` (100); `max` = `max_returned_rows` (1000); 400 on invalid |
+| `_col=name` (repeatable) | return only pks + these columns; 400 on invalid |
+| `_nocol=name` (repeatable) | exclude columns; 400 if invalid or a pk |
+| `_labels=on` | expand every FK column into `{"value", "label"}` |
+| `_label=col` (repeatable) | expand only the named FK column(s) |
+| `_facet=col` | request a facet; 400 `"_facet= is not allowed"` when `allow_facet` off |
+| `_facet_array=col` / `_facet_date=col` | typed facets |
+| `_facet_size=N\|max` | facet bucket count, default 30, capped at `max_returned_rows` |
+| `_nocount=1` | skip count (`count` extra → null) |
+| `_nofacet=1` | skip facets and suggestions |
+| `_nosuggest=1` | skip facet suggestions only |
+| `_shape=` | see renderer section; `array`/`object` also force `_nocount` and `_nofacet` |
+| `_nl=on` | NDJSON with `_shape=array` |
+| `_json=col` / `_json_infinity=1` | renderer options |
+| `_timelimit=ms` | custom SQL time limit |
+| `_ttl=seconds` | `Cache-Control: max-age=N` (`0` → `no-cache`); default `default_cache_ttl` (5) |
+| `_trace=1` | append `_trace` key (requires `trace_debug` setting) |
+| `_extra=` | see above |
+
+**Pagination** is keyset-based for tables: `page_size + 1` rows are fetched;
+`next` is built from the last row of the page — comma-joined tilde-encoded
+primary-key values, prefixed by the sort value when sorted (`$null` for null
+sort values) (views/table.py:2041-2111, 2421-2482). `next_url` is the
+absolute URL with `_next` replaced.
+
+### GET /\<database\>/\<view_name\>.json (SQL views)
+
+Same code path with `is_view=True`. Differences:
+
+- No primary keys: `primary_keys` → `[]`; `_shape=object` fails; base query
+  has no `order by`.
+- **Pagination is offset-based**: `_next` is an integer offset applied as
+  `limit N offset M` (views/table.py:2047-2049, 2438-2439) — unlike the
+  keyset tokens used for tables.
+- `view_definition` returns the `CREATE VIEW` SQL; `table_definition` is null.
+
+### GET /\<database\>/\<table\>/\<pks\>.json
+
+`RowView` (app.py:2715-2718; views/row.py:137). `<pks>` is comma-separated
+tilde-encoded primary key values (rowid for rowid tables).
+
+- **Permission:** `view-table` (denied → `Forbidden` → 403 HTML). Missing row
+  → 404 `"Record not found: [...]"`.
+- **Default JSON keys:** `ok`, `database`, `table`, `rows` (single-element
+  list), `primary_keys`, `primary_key_values`, `query_ms`,
+  `truncated: false`; `columns` only with `?_extra=columns`.
+- **`?_extra=` (ROW scope):** `columns`, `primary_keys`, `render_cell`,
+  `debug`, `request`, `query`, `column_types`, `metadata`, `extras`,
+  `database`, `table`, `database_color`, `private`, `foreign_key_tables`
+  (incoming FKs with `count` and `link`; single-pk rows only).
+- **Foreign-key label expansion does not apply to row JSON** — `_labels` has
+  no effect here; expansion happens only in the HTML path
+  (views/row.py:445-475).
+- `_shape`, `_json`, `_nl`, `_json_infinity`, `_ttl` apply. A `.jsono`
+  request redirects to `.json?_shape=objects`.
+
+### The .blob format
+
+`/<database>/<table>/<pks>.blob?_blob_column=col` (also on query pages) —
+fetches raw binary bytes (blob_renderer.py:10-61). `_blob_column` required
+(400 if missing/invalid); optional `_blob_hash` must equal the value's
+SHA-256 (else 400 `"Link has expired..."`). Returns `application/binary` as a
+download attachment. In JSON output, binary cells appear as
+`{"$base64": true, "encoded": "..."}`.
+
+### GET /\<database\>/\<table\>/-/schema(.json|.md)
+
+`TableSchemaView` (app.py:2751-2754; views/special.py:1332-1378).
+
+- **Permission:** `view-table` via `ensure_permission` (denied → 403 HTML).
+- **Responses:** `.json` → 200 `{"database", "table", "schema"}` (no `ok`
+  key); `.md` → `text/markdown`; no extension → HTML. Missing table → 404
+  `{"ok": false, "error": "Table not found"}` for `.json`.
+
+### GET /\<database\>/\<table\>/-/fragment
+
+`TableFragmentView` (app.py:2739-2742; views/table.py:1385-1418).
+**HTML-only** — returns the `_table.html` partial; no JSON variant. Accepts
+table querystring parameters plus `_row=<pk-path>` to render a single row.
+
+### GET /\<database\>/\<table\>/-/autocomplete
+
+`TableAutocompleteView` (app.py:2743-2746; views/table.py:1492-1595). Tables
+only — views get 400 `"Autocomplete is only available for tables"`.
+
+- **Permission:** `view-table` (denied → `Forbidden` → 403).
+- **Parameters:** `q` (matched with escaped `LIKE %q%` against pk columns and
+  the label column) and `_initial` (truthy: with empty `q`, return the 10
+  most recent rows). Neither → `{"rows": []}`.
+- **Response:** `{"rows": [{"pks": {pk_name: value}, "label": "..."}]}` — max
+  10 items; 500 ms query budget with fallbacks, timing out to
+  `{"rows": []}`.
+
+---
+
+## The write API
+
+All write endpoints return errors via `_error()`
+(`{"ok": false, "errors": [...]}`) and check permissions with
+`datasette.allowed()` directly, so their 403s are JSON (unlike the
+`Forbidden`-raising read endpoints). Routes: app.py:2719-2762.
+
+### POST /\<database\>/\<table\>/-/insert
+
+`TableInsertView` (views/table.py:907-1194).
+
+- **Permissions:** `insert-row` on the table (denied → 403
+  `["Permission denied"]`); `update-row` additionally required for
+  `replace: true` (403 `need update-row to use "replace"`); `alter-table`
+  additionally required for `alter: true` (403
+  `Permission denied for alter-table`). Immutable database → 403
+  `Database is immutable`.
+- **Request** — requires `Content-Type: application/json` (else 400
+  `"Invalid content-type, must be application/json"`). Body:
+
+  | Field | Rules |
+  |---|---|
+  | `row` | single object; mutually exclusive with `rows`; forces `return: true` |
+  | `rows` | list of objects; max `max_insert_rows` (default 100), else 400 `"Too many rows, maximum allowed is 100"` |
+  | `ignore` | skip rows whose pk already exists; mutually exclusive with `replace` |
+  | `replace` | replace rows with matching pks (needs `update-row`) |
+  | `alter` | add missing columns (needs `alter-table`) |
+  | `return` | include inserted rows in the response |
+
+  One of `row`/`rows` required. Unknown keys → 400 `"Invalid parameter: ..."`.
+  Unless `alter`, row keys must be existing columns → per-row 400
+  `"Row 0 has invalid columns: x, y"`. Values are validated against assigned
+  column types.
+- **Response** — **201** `{"ok": true}`; with `return: true` also `rows`
+  (the rows as stored, re-fetched by rowid). SQLite errors during the write →
+  400 with the message. Emits `insert-rows` (and possibly `alter-table`)
+  events.
+
+### POST /\<database\>/\<table\>/-/upsert
+
+`TableUpsertView` — subclasses insert (views/table.py:1197-1201).
+
+- **Permissions:** **both** `insert-row` and `update-row` (403
+  `need both insert-row and update-row`); `alter: true` needs `alter-table`.
+- **Request:** same as insert, except `ignore`/`replace` are rejected (400
+  `"Upsert does not support ignore or replace"`) and **every row must contain
+  the table's primary key(s)** (per-row 400
+  `Row 0 is missing primary key column(s): "id"` / `has null primary key`).
+- **Response** — **200** (note: insert returns 201) `{"ok": true}`; with
+  `return: true`, `rows` re-fetched by pk. Emits `upsert-rows`.
+
+### POST /\<database\>/\<table\>/-/alter
+
+`TableAlterView` (views/table_create_alter.py:1130-1353).
+
+- **Permission:** `alter-table` (403 `need alter-table`); immutable → 403.
+- **Request:** `{"operations": [{"op": ..., "args": {...}}, ...]}` — a
+  non-empty list, validated by pydantic (extra keys forbidden anywhere;
+  errors → 400 `location: message`):
+
+  | `op` | `args` |
+  |---|---|
+  | `add_column` | `name` (required), `type` (`text`/`integer`/`float`/`blob`, default `text`), `not_null`, `default` xor `default_expr`; `not_null: true` requires a default |
+  | `rename_column` | `name`, `to` |
+  | `rename_table` | `to` (must not start `sqlite_`) |
+  | `alter_column` | `name` + at least one of `type`, `not_null`, `default`, `default_expr` |
+  | `drop_column` | `name` |
+  | `set_primary_key` | `columns` (non-empty list) |
+  | `reorder_columns` | `columns` (non-empty list) |
+  | `add_foreign_key` | `column`, `fk_table`, optional `fk_column` |
+  | `drop_foreign_key` | `column` |
+  | `set_foreign_keys` | `foreign_keys`: list of `{column, fk_table, fk_column?}` |
+
+  `default_expr` must be one of the five `current_*` keywords. Operations are
+  applied in a single write transaction; any failure → 400.
+- **Response** — 200:
+  ```json
+  {"ok": true, "database": "...", "table": "<possibly renamed>",
+   "table_url": "...", "table_api_url": "...",
+   "altered": true, "schema": "...", "before_schema": "...",
+   "operations_applied": 2}
+  ```
+
+### POST /\<database\>/\<table\>/-/drop
+
+`TableDropView` (views/table.py:1320-1382).
+
+- **Permission:** `drop-table` (403 `Permission denied`); immutable → 403.
+- **Confirmation flow:** without `{"confirm": true}` in the body, nothing is
+  dropped and a 200 preview is returned:
+  `{"ok": true, "database", "table", "row_count",
+  "message": "Pass \"confirm\": true to confirm"}`. With `confirm: true` →
+  200 `{"ok": true}`. Emits `drop-table`.
+
+### POST /\<database\>/\<table\>/-/set-column-type
+
+`TableSetColumnTypeView` (views/table.py:1204-1317). Assigns a Datasette
+*column type* (metadata stored in the internal `column_types` table) — it
+does not change the SQLite schema.
+
+- **Permission:** `set-column-type` (403 `Permission denied`).
+- **Request** (JSON content type required): `{"column": "name",
+  "column_type": {"type": "url", "config": {...}?} | null}`. Unknown
+  keys/invalid structure → detailed 400 errors; unknown type → 400
+  `"Unknown column type: x"`. Default registered types (via the
+  `register_column_types` hook): `url`, `email`, `json`, `textarea`.
+- **Response** — 200 `{"ok": true, "database", "table", "column",
+  "column_type": {...} | null}`.
+
+### GET /\<database\>/\<table\>/-/foreign-key-suggestions
+
+`TableForeignKeySuggestionsView` (views/table_create_alter.py:1008-1127).
+**GET only** (read-only despite living beside the write endpoints).
+
+- **Permission:** `alter-table` (403 `need alter-table`); views → 400
+  `"Cannot suggest foreign keys for a view"`.
+- **Response** — 200: `{"ok": true, "database", "table",
+  "row_check": {attempted, status, row_limit, sampled_rows, checked_options},
+  "columns": [{column, type, affinity, current,
+  "suggestions": [{fk_table, fk_column, confidence, sampled_values, reasons}],
+  "options": [...]}]}`. Samples up to 500 rows within 50 ms/200 ms budgets.
+
+### POST /\<database\>/\<table\>/\<pks\>/-/update
+
+`RowUpdateView` (views/row.py:781-870).
+
+- **Permissions:** `update-row` (403 `Permission denied`); `alter: true`
+  additionally requires `alter-table` (403
+  `Permission denied for alter-table`).
+- **404s:** `Database not found: x` / `Table not found: x` /
+  `Record not found: [pks]`.
+- **Request:** `{"update": {column: value, ...}, "return"?: true,
+  "alter"?: true}`. Missing/non-dict `update` → 400
+  `"JSON must contain an update dictionary"`; unknown keys → 400
+  `"Invalid keys: ..."`; write failures (bad column, constraint violation) →
+  400 with the message.
+- **Response** — 200 `{"ok": true}`; with `return: true`,
+  `{"ok": true, "row": {...}}` (singular `row`, unlike insert/upsert's
+  `rows`). Emits `update-row`.
+
+### POST /\<database\>/\<table\>/\<pks\>/-/delete
+
+`RowDeleteView` (views/row.py:738-778).
+
+- **Permission:** `delete-row` (403 `Permission denied`). 404s as update.
+- **Request:** no body required (any body is ignored — there is no
+  confirmation step, unlike table drop).
+- **Response** — 200 `{"ok": true}`; with `?_redirect_to_table` a `redirect`
+  key is added. A failure during the write returns **500** with the message
+  (unlike update's 400). Emits `delete-row`.
+
+---
+
+## Stored (canned) queries API
+
+Stored queries live in the internal database's `queries` table
+(utils/internal_db.py:116-133). Queries defined in `datasette.yaml` are
+synced in at startup with `source="config"` and `is_trusted` defaulting to
+true; queries created via the API get `source="user"`, `is_trusted=false`,
+`owner_id` = actor id.
+
+**Canonical stored-query JSON object** (`stored_query_to_dict`,
+stored_queries.py:55-80):
+
+```json
+{
+  "database": "...", "name": "...", "sql": "...",
+  "title": null, "description": null, "description_html": null,
+  "hide_sql": false, "fragment": null,
+  "params": ["p"], "parameters": ["p"],
+  "is_write": false, "is_private": true, "is_trusted": false,
+  "source": "user", "owner_id": "...",
+  "on_success_message": null, "on_success_message_sql": null,
+  "on_success_redirect": null,
+  "on_error_message": null, "on_error_redirect": null,
+  "private": true
+}
+```
+
+`params` and `parameters` are identical lists, both always present.
+`private` appears only in list responses.
+
+**Default permission rules for queries** (default_permissions/defaults.py):
+`view-query` is default-allow, but private queries are visible only to their
+owner; the owner may `update-query`/`delete-query` their `source='user'`
+queries.
+
+### GET /-/queries(.json) and GET /\<database\>/-/queries(.json)
+
+`GlobalQueryListView` / `QueryListView` (app.py:2606-2609, 2663-2666;
+views/stored_queries.py:69-238). The global variant lists queries across all
+databases (`database`/`database_color` are null, `show_database` true).
+
+- **Permissions:** no single gate; results filtered per query by
+  `view-query` (private queries appear only for their owner).
+- **Parameters:** `_size` (default 20 HTML / **50 JSON**, clamped 1–1000;
+  non-integer → 400), `_next` (cursor), `q` (substring search over
+  name/title/description/sql), `is_write` / `is_private` (booleans; invalid →
+  400 `"is_write must be 0 or 1"`), `source`, `owner_id`.
+- **Response** — 200:
+  `{"ok": true, "database", "database_color", "queries": [...], "next",
+  "next_url", "has_more", "limit", "show_private_note",
+  "show_trusted_note", "query_list_path", "show_database",
+  "facets": [{title, items: [{label, count, href, active}]}],
+  "filters": {q, is_write, is_private, source, owner_id}}`.
+
+### GET /\<database\>/-/queries/analyze
+
+`QueryCreateAnalyzeView` (app.py:2667-2670; views/stored_queries.py:290-322).
+**GET only** despite being an "analyze" action — POST → 405.
+
+- **Permissions:** `execute-sql` then `store-query` (each denial → 403
+  `errors` JSON).
+- **Parameters:** only `sql` (others → 400 `"Invalid keys: ..."`).
+- **Response** — 200: `{"ok", "parameters", "analysis_error",
+  "analysis_rows": [{operation, database, table, required_permission,
+  source, allowed}], "has_sql", "analysis_is_write", "save_disabled"}`.
+
+### POST /\<database\>/-/queries/store
+
+`QueryStoreView` (app.py:2671-2674; views/stored_queries.py:325-388). GET on
+the same path renders the HTML create form.
+
+- **Permissions:** `execute-sql` + `store-query` (403 `errors` JSON).
+- **Request:** JSON bodies must wrap the fields:
+  `{"query": {...fields...}}`; form bodies pass fields flat. Fields:
+  `name` (required; `^[^/\.\n]+$`; conflicts with tables/views or existing
+  queries → 400), `sql` (required; read SQL must pass `validate_sql_select`;
+  write SQL must pass per-operation permission checks), `title`,
+  `description`, `hide_sql`, `fragment`, `parameters`/`params` (must exactly
+  match the SQL's named parameters; magic parameters rejected),
+  `is_private` (**default true**), and — only for write SQL —
+  `on_success_message`, `on_success_redirect`, `on_error_message`,
+  `on_error_redirect`. `is_write` is derived from SQL analysis;
+  `is_trusted`, `description_html` and `on_success_message_sql` cannot be
+  set through this API.
+- **Response:** JSON request → **201** `{"ok": true, "query": {...}}`; form
+  request → 302 redirect.
+
+### GET /\<database\>/\<query\>/-/definition
+
+`QueryDefinitionView` (app.py:2695-2698; views/stored_queries.py:391-408).
+
+- **Permission:** `view-query` (403 `["Permission denied"]`).
+- **Response:** 200 `{"ok": true, "query": {...}}`; 404
+  `["Query not found: x"]`.
+
+### GET/POST /\<database\>/\<query\>/-/edit
+
+`QueryEditView` (app.py:2699-2702) — **HTML form endpoint**
+(`has_json_alternate = False`), not part of the JSON API. Programmatic
+updates use `/-/update`.
+
+### POST /\<database\>/\<query\>/-/update
+
+`QueryUpdateView` (app.py:2703-2706; views/stored_queries.py:411-465).
+
+- **Permissions:** `update-query` (403 `need update-query`); trusted queries
+  → 403 `"Trusted queries cannot be updated using the API"`; changing `sql`
+  additionally requires `execute-sql`.
+- **Request:** `{"update": {...partial fields...}, "return"?: true}` — other
+  top-level keys → 400. Updatable fields: `sql`, `title`, `description`,
+  `hide_sql`, `fragment`, `parameters`/`params`, `is_private`, `on_*`
+  fields (write SQL only). New SQL is re-analyzed and `is_write` recomputed.
+- **Response:** 200 `{"ok": true}` (plus `query` with `return: true`); 404
+  `"Query not found: x"`.
+
+### POST /\<database\>/\<query\>/-/delete
+
+`QueryDeleteView` (app.py:2707-2710; views/stored_queries.py:594-644). GET
+renders an HTML confirmation page.
+
+- **Permission:** `delete-query` (403 `need delete-query`). Unlike update,
+  **trusted queries are not blocked** from API deletion.
+- **Response:** JSON request → 200 `{"ok": true}`; form → 302; 404
+  `"Query not found: x"`. No `confirm` field required (unlike table drop).
+
+### GET/POST /\<database\>/\<query-name\>(.json) — executing a stored query
+
+No dedicated route: the table route resolves the name, and on `TableNotFound`
+the request is dispatched to `QueryView` when a stored query matches
+(views/table.py:1698-1712). Covers both config-defined and API-stored
+queries.
+
+**GET (read queries)** — `QueryView.get` (views/database.py:695-1130):
+
+- **Permissions:** `view-query` (denied → `Forbidden` → 403 HTML). Read
+  queries then require `execute-sql` unless `is_trusted`. Write queries are
+  **not executed** on GET — JSON returns empty `rows`; HTML shows a POST form.
+- **Parameters:** each named `:param` is read from the query string (missing
+  → `""`); `_timelimit`; renderer options (`_shape`, `_nl`, `_json`,
+  `_json_infinity`); `_extra` (QUERY scope).
+- **Response:** `{"ok": true, "rows": [...], "truncated": false}` + extras.
+  SQL errors → 400 with `error` in the envelope.
+
+**POST (write queries)** — `QueryView.post` (views/database.py:574-693):
+
+- **Permissions:** `view-query`; then, unless `is_trusted`:
+  `execute-write-sql` on the database **plus** per-operation write
+  permissions (same table as `/-/execute-write`). Rejection → 403
+  `{"ok": false, "message": "...", "redirect": null}` for JSON clients.
+  Immutable database → 403.
+- **Body:** form-encoded or JSON `param=value` pairs (values coerced to
+  strings).
+- **JSON is returned when** `Accept: application/json`, `?_json=1`, or a
+  `_json` body field is present; otherwise 302 + flash message.
+- **Magic parameters** (`:_<prefix>_<key>`, resolved server-side; registered
+  via `register_magic_parameters`, default_magic_parameters.py):
+  `_now_epoch`, `_now_date_utc`, `_now_datetime_utc`, `_actor_<key>`,
+  `_random_chars_<N>`, `_cookie_<name>`, `_header_<name>` (underscores →
+  hyphens). User-stored queries cannot contain magic parameters — they are a
+  feature of config/trusted queries.
+- **Response — 200 for both success and SQL failure** (only permission
+  rejection is 403):
+  `{"ok": true|false, "message": "...", "redirect": "..."|null}` —
+  `message` honors `on_success_message_sql` / `on_success_message` /
+  `on_error_message`, falling back to `"Query executed"` or
+  `"Query executed, N rows affected"`.
+
+---
+
+## Authentication and tokens
+
+### Bearer tokens (`dstok_`)
+
+Signed API tokens are sent as `Authorization: Bearer dstok_...`. The
+`actor_from_signed_api_token` hook (default_permissions/tokens.py:25-40)
+passes the token to `datasette.verify_token()`, which tries every handler
+registered via `register_token_handler`; the default is
+`SignedTokenHandler` (tokens.py:117-193).
+
+- **Format:** `dstok_` + itsdangerous-signed payload (namespace `token`)
+  containing `a` (actor id), `t` (creation Unix time), optional `d`
+  (duration seconds), optional `_r` (restrictions).
+- **Verification** returns no actor when: `allow_signed_tokens` is off, the
+  signature is invalid, `t` is missing/non-integer, or the token is expired.
+  The effective duration is `d` capped by `max_signed_tokens_ttl` (default 0
+  = no cap; a non-zero setting also imposes a TTL on tokens without `d`).
+- **Resulting actor:** `{"id": <a>, "token": "dstok"}` plus `"_r"` and
+  `"token_expires"` when applicable. Invalid/expired tokens silently produce
+  an anonymous request (no 401) — the failure then surfaces as a 403 from
+  whatever permission check the request hits.
+
+**Restrictions (`_r`)** (default_permissions/restrictions.py):
+
+- `"a"`: list of actions allowed on any resource
+- `"d"`: `{database_name: [actions]}`
+- `"r"`: `{database_name: {table_name: [actions]}}`
+
+Actions are stored as abbreviations when available (see appendix); checks
+accept either the full name or the abbreviation. Restrictions are an
+allowlist filter layered on top of normal permission resolution — a
+restricted token can never do more than its allowlist, and never more than
+the underlying actor could do anyway.
+
+### Token creation
+
+- **`/-/create-token`** is an HTML form endpoint only (see the instance
+  section) — there is no JSON API to mint tokens in this codebase.
+- Programmatic alternatives: the `datasette create-token` CLI command and
+  the `datasette.create_token()` Python API.
+- `/-/auth-token` is the one-time `--root` login mechanism, unrelated to API
+  tokens.
+
+### Cookie authentication
+
+Browser sessions use the signed `ds_actor` cookie (set by `/-/auth-token`,
+plugins, or login flows; cleared by `/-/logout`). API POSTs from browsers are
+subject to the cross-origin checks described in
+[CSRF](#csrf--cross-origin-protection).
+
+---
+
+## Appendix: registered actions (permissions)
+
+From `datasette/default_actions.py` (registered via the `register_actions`
+hook). Token restrictions store the abbreviation when available.
+
+| Action | Abbr | Resource level | Notes |
+|---|---|---|---|
+| `view-instance` | `vi` | global | |
+| `permissions-debug` | `pd` | global | gates the debug endpoints |
+| `debug-menu` | `dm` | global | UI only |
+| `view-database` | `vd` | database | |
+| `view-database-download` | `vdd` | database | `also_requires="view-database"` |
+| `execute-sql` | `es` | database | `also_requires="view-database"`; denied when the `default_allow_sql` setting is off |
+| `execute-write-sql` | `ews` | database | `also_requires="view-database"` |
+| `create-table` | `ct` | database | |
+| `store-query` | `sq` | database | `also_requires="execute-sql"` |
+| `view-table` | `vt` | table | |
+| `insert-row` | `ir` | table | |
+| `delete-row` | `dr` | table | |
+| `update-row` | `ur` | table | |
+| `alter-table` | `at` | table | |
+| `set-column-type` | `sct` | table | |
+| `drop-table` | `dt` | table | |
+| `view-query` | `vq` | query | default-allow; private queries restricted to their owner |
+| `update-query` | `uq` | query | query owner allowed by default (source=`user` only) |
+| `delete-query` | `dq` | query | query owner allowed by default (source=`user` only) |
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
new file mode 100644
index 00000000..e630ae4b
--- /dev/null
+++ b/stable-api-recommendations.md
@@ -0,0 +1,367 @@
+# Datasette 1.0 Stable API — Consistency and Completeness Review
+
+This review is based on `existing-api.md`, which documents the JSON API as
+actually implemented in this codebase (`1.0a35`), derived from source. The
+goal here is to identify everything that should be made consistent, fixed, or
+explicitly scoped out **before** the 1.0 stability promise takes effect —
+because after 1.0, every inconsistency below becomes a compatibility
+commitment.
+
+Findings are grouped by theme. Each carries a priority:
+
+- **P1 — should block 1.0**: breaking to fix later, or a correctness/security
+  concern.
+- **P2 — strongly recommended**: fixable later only via awkward additive
+  changes.
+- **P3 — nice to have / documentation decision**: can be resolved by
+  documenting the behavior as intentional.
+
+---
+
+## 1. Error responses: four shapes is three too many (P1)
+
+The API currently produces four distinct JSON error shapes depending on which
+internal layer generates the error:
+
+| Shape | Producer | Example endpoints |
+|---|---|---|
+| `{"ok": false, "error", "status", "title"}` | exception handler (handle_exception.py:50-53) | 404s and `DatasetteError`s on any `.json` path |
+| `{"ok": false, "errors": [...]}` | `_error()` helper (views/base.py:183-184) | all write endpoints, stored-query endpoints, execute-write |
+| `{"ok": false, "error", "rows": [], "truncated": false}` | JSON renderer (renderer.py:52-56) | SQL errors on table/query reads |
+| `{"error": "..."}` (no `ok`) | permission debug views (views/special.py) | `/-/allowed`, `/-/rules`, `/-/check`, POST `/-/permissions` |
+
+Additionally, write canned queries report failure via a **fifth** vocabulary:
+`{"ok": false, "message": ..., "redirect": ...}` with HTTP **200**
+(views/database.py:678-690).
+
+A 1.0 client cannot write a single error handler today. **Recommendation:**
+pick one canonical error object — the singular/plural tension is easiest to
+resolve as:
+
+```json
+{"ok": false, "error": "human-readable summary", "errors": ["detail", "..."], "status": 400}
+```
+
+where `errors` is optional and `error` is always present — and route every
+error path through it (including the `forbidden` and `handle_exception`
+defaults). At minimum, eliminate the bare `{"error": ...}` shape and the
+`status`/`title` keys nobody else emits (`title` is a template-rendering
+concern that leaked into the API).
+
+### 1a. `Forbidden` returns an HTML 403 to JSON clients (P1)
+
+Read endpoints that deny access via `ensure_permission`/`check_visibility`
+raise `Forbidden`, and the default `forbidden()` hook renders an **HTML error
+page even for `.json` requests** (forbidden.py:4-19, app.py:2895-2904). So:
+
+- `GET /db/table.json` without `view-table` → 403 **HTML**
+- `POST /db/table/-/insert` without `insert-row` → 403 **JSON**
+
+A JSON client gets unparseable output precisely when it most needs a
+machine-readable answer. **Recommendation:** the default forbidden handler
+must return the canonical JSON error when the path ends in `.json` or the
+request prefers JSON, mirroring `handle_exception`.
+
+### 1b. Errors that return HTTP 200 (P1)
+
+- `_shape=object` on a query or pk-less table → `{"ok": false, "error":
+  "_shape=object is only available on tables"}` with **200**
+  (renderer.py:73-90), while an unknown `_shape` value returns **400**
+  (renderer.py:101-108). Same class of error, different status.
+- Write canned-query SQL failure → **200** `{"ok": false, "message": ...}`
+  (views/database.py:683-690), while the equivalent failure on
+  `/-/execute-write` returns **400**.
+
+**Recommendation:** all `ok: false` responses should carry a 4xx/5xx status.
+(`/-/execute-write/analyze` returning `ok: false` with 200 for "analysis
+completed, SQL is invalid" is defensible but should then not reuse the `ok`
+key — see §2.)
+
+### 1c. Wrong-status outliers (P2)
+
+- Row **delete** write failures return **500** (views/row.py:757) while row
+  **update** write failures return **400** (views/row.py:832-835). Same
+  failure class, different status; pick 400 (or 409 for constraint
+  violations) for both.
+- Invalid or expired bearer tokens silently degrade the request to anonymous,
+  so clients see a 403 permission error (or worse, anonymous-permitted data)
+  rather than a 401 (tokens.py:147-193). For 1.0, a malformed/expired
+  `Authorization: Bearer dstok_...` header should produce **401** with a
+  distinguishable error, so clients can tell "renew your token" apart from
+  "you lack permission".
+
+---
+
+## 2. Success envelope: `ok` is not universal, arrays are not extensible (P1/P2)
+
+Endpoints disagree about the success envelope:
+
+- **Have `ok: true`:** table/row/query reads, database view, all write
+  endpoints, stored-query endpoints, `/-/allowed`-style debug data.
+- **No `ok` key:** `/-/versions`, `/-/settings`, `/-/config`, `/-/threads`,
+  `/-/actor`, `/-/jump`, `/-/schema` variants (`{"database", "schema"}`,
+  `{"schemas": [...]}`), table `/-/schema.json`, `/-/autocomplete`
+  (`{"rows": []}`), homepage `/.json`.
+- **Top-level JSON arrays:** `/-/plugins`, `/-/databases`, `/-/actions`
+  (app.py:2247-2304). A top-level array can never grow a sibling key
+  (pagination, warnings, `ok`) without a breaking change.
+
+**Recommendations:**
+
+1. (P1) Wrap the three array endpoints in objects before 1.0:
+   `{"ok": true, "plugins": [...]}` etc. This is the single cheapest
+   future-proofing fix in this list.
+2. (P2) Add `ok: true` to every JSON-object success response, or explicitly
+   document that `ok` only exists on data endpoints. Half-consistency is the
+   worst outcome.
+3. (P2) `/db/-/schema.json` (`{"database", "schema"}`) and
+   `/db/table/-/schema.json` should match the envelope style of their sibling
+   endpoints (they are also the only data endpoints whose 404 uses the
+   exception shape but whose success has no `ok`).
+
+### 2a. Collection representations disagree (P2)
+
+- Homepage `/.json` returns `databases` as an **object keyed by name**
+  (index.py:147-161); `/-/databases.json` returns an **array**; the database
+  page returns `tables` as an array. Choose arrays-of-objects everywhere
+  (objects-keyed-by-name break when names need ordering or pagination).
+- Insert/upsert with `return: true` respond with `rows` (plural, list); row
+  update with `return: true` responds with `row` (singular, object)
+  (views/row.py:837-844). Pick one (`rows` everywhere, even for one row,
+  matches the read API).
+
+### 2b. `_extra`/`_shape` support is uneven (P2)
+
+The extras system (`?_extra=`, scope-registered) is the 1.0 mechanism for
+response shaping — but it only exists on table, row and query endpoints. The
+database view builds JSON by hand and supports **neither `_extra` nor
+`_shape`** (views/database.py:189-212); the homepage likewise. Either extend
+extras to database/instance scope before 1.0 or document clearly that shaping
+is a table/row/query feature. Also decide the contract for **unknown
+`_extra` names, which are currently silently ignored** (extras.py:116-122) —
+silent ignoring means typos return the default payload with no signal;
+recommend a 400 or a `warnings` key.
+
+### 2c. Count truncation is invisible in JSON (P2)
+
+The `count` extra is computed with a `limit 10001` subquery, so `count:
+10001` actually means "at least 10001" — the `count_truncated` flag exists
+but only in the HTML template context, never in JSON (views/table.py:
+2334-2337). Expose it (e.g. make `count` be `null` + add `count_estimate`,
+or add `count_truncated` to the JSON) before clients start trusting the
+number.
+
+---
+
+## 3. Pagination: three mechanisms, two contracts (P2)
+
+| Endpoint | Mechanism | Token | Extras |
+|---|---|---|---|
+| Table `.json` | keyset | tilde-encoded pk/sort values in `_next` | `next` always in body, `next_url` via `_extra`, `Link: rel=next` header |
+| SQL view `.json` | **offset** | integer in the same `_next` parameter | same envelope |
+| `/-/queries` lists | keyset | cursor in `_next` | `next`, `next_url`, **`has_more`** in body |
+| `/-/allowed`, `/-/rules` | **page numbers** | `page`/`page_size` | `total`, `next_url`, `previous_url` |
+
+Concerns:
+
+1. The same `_next` parameter means "start after key" on tables but "row
+   offset" on views. Offset pagination over views is also O(n) and skews
+   under concurrent writes. If unifiable, unify; if not, document loudly.
+2. `has_more` exists on query lists but not table pages; `total` exists on
+   debug endpoints but not elsewhere. Standardize the pagination block
+   (suggest: `next`, `next_url` — nullable — everywhere; treat `has_more` as
+   `next != null`).
+3. Page-size parameters: `_size` (default 100, `max` keyword allowed) on
+   tables; `_size` (default 50 JSON, clamped 1–1000, no `max` keyword) on
+   query lists; `page_size` (default 50, silently capped at 200) on debug
+   endpoints. Align names, defaults and the cap behavior (silent capping vs
+   400) as far as practical.
+
+---
+
+## 4. HTTP semantics (P2)
+
+- **201 vs 200:** insert → 201, upsert → 200 (views/table.py:1194), create
+  table → 201, store query → 201. Insert-201/upsert-200 is defensible
+  (upsert may not create) but it is undocumented subtlety; state it, or
+  return 200 for both with an explicit `created` count.
+- **Destructive-action confirmation is asymmetric:** table drop requires
+  `{"confirm": true}` and has a preview response (views/table.py:1346-1365);
+  row delete executes immediately and ignores the body; query delete
+  executes immediately. Decide the 1.0 rule (suggestion: confirmation only
+  for schema-destroying operations, i.e. keep as is — but document it as a
+  deliberate contract).
+- **Content-type enforcement is inconsistent:** `/-/insert`, `/-/upsert`,
+  `/-/alter`, `/-/set-column-type` demand `Content-Type: application/json`
+  (400 otherwise); `/-/create` parses the body as JSON regardless of
+  content type; execute-write and the query CRUD endpoints accept both JSON
+  and form encodings. Pick one rule for JSON-only endpoints.
+- **JSON-vs-HTML negotiation on POST differs per endpoint:** execute-write
+  and canned queries key off `Accept: application/json` / a `_json` body
+  field; the write API keys off nothing (always JSON); query store keys off
+  request content type. A single documented rule ("responses are JSON if the
+  request body was JSON or `Accept: application/json`") would cover all of
+  them.
+- **Endpoints named like actions but served over GET:**
+  `/-/queries/analyze`, `/-/execute-write/analyze`,
+  `/-/foreign-key-suggestions`, `/-/query/parameters` are all GET (correct,
+  they are reads) — fine, but `analyze` under a POST-shaped path invites
+  wrong calls; make sure 405 responses for POST on these return the JSON 405
+  shape (they do only when the path ends `.json` or content type is JSON —
+  a JSON POST to `/-/queries/analyze` gets JSON, a form POST gets text).
+
+---
+
+## 5. Naming and parameter conventions (P2/P3)
+
+- **`params` and `parameters` are duplicate keys** in every stored-query
+  object (stored_queries.py:55-80). Delete one before 1.0 (suggest keeping
+  `parameters`; the write side already accepts both on input).
+- **Three names for the same concept across error/message payloads:**
+  `error`, `errors`, `message`. See §1.
+- **Boolean query parameters have at least three grammars:** `_nl=on`,
+  `_labels=on/off`, `?all=1`, `is_write=1|0|true|false|t|f|yes|no|on|off`,
+  `_nocount=1`. Adopt one accepted set (the query-list parser at
+  query_helpers.py:81-94 is a good candidate) and apply it everywhere.
+- **`.jsono`** survives on the homepage route (identical output to `.json`)
+  and as a row-view redirect. Remove it at 1.0; it is pure legacy.
+- **`_json` is overloaded:** on GET it is a renderer option naming a column
+  to parse as JSON (repeatable); on canned-query POST a `_json` body field
+  forces a JSON response. Two unrelated meanings for one name.
+- The reserved `/-/` namespace is applied consistently across routes — this
+  is in good shape. The one gap: table names matching `^-$`-adjacent shapes
+  are protected by tilde-encoding; keep a test asserting `/-/` can never be
+  shadowed by user data.
+
+---
+
+## 6. Permissions and security consistency (P1/P2)
+
+- **(P1) `/-/databases.json` ignores per-database permissions** — it lists
+  every attached database (name, path on disk, size) to any actor holding
+  `view-instance` (app.py:2157-2169), while the homepage and every other
+  endpoint filter by `view-database`. On a public instance with private
+  databases this leaks filesystem paths and database names. Filter it, or
+  gate it behind `permissions-debug`.
+- **(P2) `/db/-/schema` checks existence before permission**
+  (views/special.py:1308-1317): an actor without `view-database` can
+  distinguish "database exists" (403) from "does not exist" (404).
+  Standardize on permission-check-first (as the table view does) so
+  unauthorized actors get a uniform response.
+- **(P2) `/-/threads` exposes runtime internals** (thread idents, asyncio
+  task reprs including file paths) behind only `view-instance`. Consider
+  `permissions-debug`, alongside `/-/actions` which already requires it.
+- **(P3) `/-/config` redaction is substring-based** on six key names
+  (app.py:2502-2505); plugins storing secrets under other names leak. Worth
+  a note in plugin authoring docs plus a `redact_keys` plugin hook.
+- **(P3) Database-level checks on `/-/create`** (insert-row/update-row
+  checked against `DatabaseResource`, not the about-to-exist table —
+  table_create_alter.py:819-856) vs table-level checks on `/-/insert`.
+  Correct by necessity, but document that a token restricted to
+  table-level `ir` cannot use `/-/create` with rows.
+
+---
+
+## 7. Completeness gaps for a 1.0 JSON API (P2/P3)
+
+1. **(P2) No JSON API to create tokens.** `/-/create-token` is an HTML form
+   only (`has_json_alternate = False`, form-encoded POST). Any automation
+   that wants to mint scoped tokens must shell out to `datasette
+   create-token`. An intentional JSON mode (actor-authenticated, same
+   restriction vocabulary) rounds out the write API story — or explicitly
+   document token minting as CLI/Python-only.
+2. **(P2) Row JSON cannot expand foreign-key labels.** `_labels` works on
+   table JSON but is silently ignored on row JSON (views/row.py:445-475
+   expands only for HTML). Either support it or return 400 for unsupported
+   parameters; silent ignoring is the worst option (see also §2b on unknown
+   `_extra` values).
+3. **(P2) No machine-readable "which write features does this instance/table
+   support" endpoint.** Clients must probe (`/-/insert` on an immutable
+   database → 403). The API explorer computes exactly this data for HTML
+   (views/special.py:863-990); exposing it as JSON would let clients degrade
+   gracefully. (`/-/allowed.json` covers the permission half already.)
+4. **(P3) Table list pagination.** `/db.json` inlines all tables (with
+   counts) and the homepage truncates to 5 per database; a 10,000-table
+   database has no paginated table listing. Acceptable for 1.0 if
+   documented; the internal catalog tables would support a real endpoint
+   later.
+5. **(P3) `Link: rel=next` header** exists on table JSON only. Harmless, but
+   either add it to the other paginated endpoints or drop it from the
+   contract (`Access-Control-Expose-Headers: Link` suggests it is meant to
+   be part of the API).
+
+---
+
+## 8. Behavior that looks like a bug and should be resolved before freezing
+
+1. **Trusted queries: update is blocked, delete is not.**
+   `QueryUpdateView` rejects `is_trusted` queries with 403
+   (stored_queries.py:426-427) but `QueryDeleteView.post` never checks
+   `is_trusted` — an actor with `delete-query` can delete a config-defined
+   trusted query via the API (it will resync on restart, making the
+   behavior confusing rather than catastrophic). Align delete with update.
+2. **GET `/db/-/query` with no `?sql=` returns 200 `{"ok": true, "rows":
+   []}`** while `.csv` on the same request returns 400 `"?sql= is
+   required"`. The JSON behavior masks caller bugs; return 400 on both.
+3. **`_shape=object` HTTP 200 error** (§1b) — almost certainly unintended.
+4. **Row delete 500** (§1c) — inconsistent with every sibling endpoint.
+5. **The "SQL Interrupted" error embeds an HTML fragment in the JSON `error`
+   value** (views/database.py:805-820). Error strings in the JSON API should
+   be plain text.
+
+---
+
+## 9. Define stability tiers explicitly (P1 — documentation, not code)
+
+Not everything under `/-/` can or should carry a 1.0 guarantee. Recommend
+shipping 1.0 with an explicit three-tier contract, per endpoint:
+
+- **Stable (semver-protected):** table/row/query reads (`.json`, `_shape`,
+  `_extra` public names, filters, pagination tokens as opaque strings), the
+  write API (`/-/insert`, `/-/upsert`, `/-/alter`, `/-/drop`,
+  `/-/set-column-type`, row `/-/update`, `/-/delete`, `/-/create`,
+  `/-/execute-write`), stored-query CRUD + execution, `/-/versions`,
+  `/-/plugins`, `/-/settings`, `/-/actor`, `/-/databases`, schema endpoints,
+  token format & restriction semantics (`_r` abbreviations are wire format
+  now — they are stored inside issued tokens and cannot change silently).
+- **Unstable/debug (documented as exempt):** `/-/threads`, `/-/actions`,
+  `/-/permissions`, `/-/allowed`, `/-/rules`, `/-/check`, `/-/messages`,
+  `/-/allow-debug`, `/-/patterns`, `/-/debug/autocomplete`, the `debug` and
+  `request` extras (the `debug` extra already self-describes as unstable),
+  `/-/api` and `/-/jump` (UI support endpoints), `/-/autocomplete` and
+  `/-/fragment` (UI support), `/-/foreign-key-suggestions` and
+  `/-/foreign-key-targets` (heuristic outputs).
+- **Internal:** anything HTML-only (`/-/edit`, `/-/create-token`,
+  `/-/logout`, `/-/auth-token`).
+
+Two details make tiering urgent rather than optional:
+
+- **Extras are enumerable by clients** (`?_extra=extras` self-describes the
+  registry), so every public extra name is de-facto API. Mark each extra
+  stable or unstable in its class definition and surface that in the
+  `extras` output.
+- **Pagination tokens leak implementation** (tilde-encoded pk values for
+  tables, plain integers for views). Declare them opaque now so the view
+  token can become keyset later without a "breaking" change.
+
+---
+
+## 10. Summary of P1 items (the pre-1.0 checklist)
+
+1. One canonical JSON error shape; retire the other three (§1).
+2. `Forbidden` → JSON 403 for JSON requests (§1a).
+3. No `ok: false` with HTTP 200 (§1b: `_shape=object`, write canned-query
+   SQL errors).
+4. Wrap `/-/plugins`, `/-/databases`, `/-/actions` top-level arrays in
+   objects (§2).
+5. Filter `/-/databases.json` by `view-database` or gate it behind
+   `permissions-debug` (§6).
+6. 401 (not silent-anonymous) for invalid/expired bearer tokens (§1c).
+7. Publish explicit stability tiers, including extras and pagination-token
+   opacity (§9).
+8. Resolve the looks-like-a-bug list (§8), especially trusted-query delete
+   and row-delete 500.
+
+Everything in P2 is worth doing now because each item is breaking-to-fix
+later; each P3 can be resolved by a sentence of documentation declaring the
+current behavior intentional.

From 2f84ab77f2bb958aed29dbfbe0a7c7d8e3a34039 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Thu, 2 Jul 2026 08:56:04 -0700
Subject: [PATCH 303/386] Support CREATE VIEW / DROP VIEW in execute-write-sql

New create-view and drop-view actions.

Also fix a related bug in analyze_sql_tables(): SQLite's authorizer fires a spurious SQLITE_DELETE callback against the view name when a view is dropped (the same thing it does for dropped tables), which was incorrectly surfaced as a delete-row requirement on the view. Broaden the existing drop-table-delete suppression to cover dropped views too.

Closes #2819
---
 datasette/default_actions.py    | 12 +++++
 datasette/utils/sql_analysis.py |  6 +--
 datasette/write_sql.py          | 27 ++++++++++
 docs/authentication.rst         | 24 ++++++++-
 tests/test_queries.py           | 92 ++++++++++++++++++++++++++++++++-
 5 files changed, 155 insertions(+), 6 deletions(-)

diff --git a/datasette/default_actions.py b/datasette/default_actions.py
index 2f78570b..602e0df4 100644
--- a/datasette/default_actions.py
+++ b/datasette/default_actions.py
@@ -61,6 +61,12 @@ def register_actions():
             description="Create tables",
             resource_class=DatabaseResource,
         ),
+        Action(
+            name="create-view",
+            abbr="cv",
+            description="Create views",
+            resource_class=DatabaseResource,
+        ),
         Action(
             name="store-query",
             abbr="sq",
@@ -111,6 +117,12 @@ def register_actions():
             description="Drop tables",
             resource_class=TableResource,
         ),
+        Action(
+            name="drop-view",
+            abbr="dv",
+            description="Drop views",
+            resource_class=TableResource,
+        ),
         # Query-level actions (child-level)
         Action(
             name="view-query",
diff --git a/datasette/utils/sql_analysis.py b/datasette/utils/sql_analysis.py
index 3a509bd2..1be28982 100644
--- a/datasette/utils/sql_analysis.py
+++ b/datasette/utils/sql_analysis.py
@@ -488,17 +488,17 @@ def analyze_sql_tables(
         and key.operation in {"create", "alter", "drop"}
         for key in operations
     )
-    dropped_tables = {
+    dropped_tables_and_views = {
         (key.database, key.table)
         for key in operations
-        if key.operation == "drop" and key.target_type == "table"
+        if key.operation == "drop" and key.target_type in {"table", "view"}
     }
 
     def key_is_drop_table_delete(key: OperationKey) -> bool:
         return (
             key.operation == "delete"
             and key.target_type == "table"
-            and (key.database, key.table) in dropped_tables
+            and (key.database, key.table) in dropped_tables_and_views
         )
 
     has_user_table_access_in_schema_operation = any(
diff --git a/datasette/write_sql.py b/datasette/write_sql.py
index cdc0c6d3..ca144a72 100644
--- a/datasette/write_sql.py
+++ b/datasette/write_sql.py
@@ -138,6 +138,33 @@ def decision_for_write_sql_operation(
                 ),
             )
         )
+    if operation.operation == "create" and operation.target_type == "view":
+        if operation.database is None:
+            return UnsupportedWriteSqlOperation(unsupported_message)
+        return RequireWriteSqlPermissions(
+            (
+                PermissionRequirement(
+                    action="create-view",
+                    resource=DatabaseResource(database=operation.database),
+                ),
+            )
+        )
+    if (
+        operation.operation == "drop"
+        and operation.target_type == "view"
+        and operation.database is not None
+        and operation.table is not None
+    ):
+        return RequireWriteSqlPermissions(
+            (
+                PermissionRequirement(
+                    action="drop-view",
+                    resource=TableResource(
+                        database=operation.database, table=operation.table
+                    ),
+                ),
+            )
+        )
     if (
         operation.operation == "alter"
         and operation.target_type == "table"
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 8101699c..304b589f 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -50,7 +50,7 @@ The one exception is the "root" account, which you can sign into while using Dat
 The ``--root`` flag is designed for local development and testing. When you start Datasette with ``--root``, the root user automatically receives every permission, including:
 
 * All view permissions (``view-instance``, ``view-database``, ``view-table``, etc.)
-* All write permissions (``insert-row``, ``update-row``, ``delete-row``, ``create-table``, ``alter-table``, ``set-column-type``, ``drop-table``)
+* All write permissions (``insert-row``, ``update-row``, ``delete-row``, ``create-table``, ``create-view``, ``alter-table``, ``set-column-type``, ``drop-table``, ``drop-view``)
 * Debug permissions (``permissions-debug``, ``debug-menu``)
 * Any custom permissions defined by plugins
 
@@ -1386,6 +1386,16 @@ create-table
 
 Actor is allowed to create a database table.
 
+``resource`` - ``datasette.resources.DatabaseResource(database)``
+    ``database`` is the name of the database (string)
+
+.. _actions_create_view:
+
+create-view
+-----------
+
+Actor is allowed to create a database view.
+
 ``resource`` - ``datasette.resources.DatabaseResource(database)``
     ``database`` is the name of the database (string)
 
@@ -1425,6 +1435,18 @@ Actor is allowed to drop a database table.
 
     ``table`` is the name of the table (string)
 
+.. _actions_drop_view:
+
+drop-view
+---------
+
+Actor is allowed to drop a database view.
+
+``resource`` - ``datasette.resources.TableResource(database, table)``
+    ``database`` is the name of the database (string)
+
+    ``table`` is the name of the view (string)
+
 .. _actions_execute_sql:
 
 execute-sql
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 6dfcc8b7..6d4275a3 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -3214,6 +3214,74 @@ async def test_execute_write_create_table_uses_create_table_permission():
     assert not await db.table_exists("should_not_exist")
 
 
+@pytest.mark.asyncio
+async def test_execute_write_create_view_uses_create_view_permission():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "permissions": {
+                "insert-row": {"id": "row-writer"},
+                "update-row": {"id": "row-writer"},
+            },
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-database": {"id": ["creator", "row-writer"]},
+                        "execute-write-sql": {"id": ["creator", "row-writer"]},
+                        "create-view": {"id": "creator"},
+                    }
+                }
+            },
+        },
+    )
+    db = ds.add_memory_database("execute_write_create_view", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    analysis_response = await ds.client.get(
+        "/data/-/execute-write/analyze",
+        actor={"id": "creator"},
+        params={"sql": "create view dog_names as select id, name from dogs"},
+    )
+    allowed_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "creator"},
+        json={"sql": "create view dog_names as select id, name from dogs"},
+    )
+    row_permission_response = await ds.client.post(
+        "/data/-/execute-write",
+        actor={"id": "row-writer"},
+        json={"sql": "create view should_not_exist as select id from dogs"},
+    )
+
+    assert analysis_response.status_code == 200
+    analysis_data = analysis_response.json()
+    assert analysis_data["ok"] is True
+    assert analysis_data["execute_disabled"] is False
+    assert analysis_data["analysis_rows"] == [
+        {
+            "operation": "create",
+            "database": "data",
+            "table": "dog_names",
+            "required_permission": "create-view",
+            "source": None,
+            "allowed": True,
+        }
+    ]
+
+    assert allowed_response.status_code == 200
+    assert allowed_response.json()["ok"] is True
+    assert allowed_response.json()["message"] == "Query executed"
+    assert await db.view_exists("dog_names")
+
+    assert row_permission_response.status_code == 403
+    assert row_permission_response.json()["errors"] == [
+        "Permission denied: need create-view on data"
+    ]
+    assert not await db.view_exists("should_not_exist")
+
+
 @pytest.mark.parametrize(
     (
         "database_name",
@@ -3264,8 +3332,20 @@ async def test_execute_write_create_table_uses_create_table_permission():
             (),
             "drop-table",
         ),
+        (
+            "execute_write_drop_view",
+            "dropper",
+            "drop view dogs_view",
+            "drop view cats_view",
+            "Permission denied: need drop-view on data/cats_view",
+            (
+                "create view dogs_view as select * from dogs",
+                "create view cats_view as select * from cats",
+            ),
+            "drop-view",
+        ),
     ),
-    ids=("alter-table", "create-index", "drop-index", "drop-table"),
+    ids=("alter-table", "create-index", "drop-index", "drop-table", "drop-view"),
 )
 @pytest.mark.asyncio
 async def test_execute_write_schema_operations_use_schema_permissions(
@@ -3300,7 +3380,12 @@ async def test_execute_write_schema_operations_use_schema_permissions(
                                 "drop-table": {"id": "dropper"},
                                 "view-table": {"id": "alterer"},
                             }
-                        }
+                        },
+                        "dogs_view": {
+                            "permissions": {
+                                "drop-view": {"id": "dropper"},
+                            }
+                        },
                     },
                 }
             },
@@ -3353,6 +3438,9 @@ async def test_execute_write_schema_operations_use_schema_permissions(
     elif expected_state == "drop-table":
         assert not await db.table_exists("dogs")
         assert await db.table_exists("cats")
+    elif expected_state == "drop-view":
+        assert not await db.view_exists("dogs_view")
+        assert await db.view_exists("cats_view")
 
 
 @pytest.mark.asyncio

From 4bd9d41c432934d369586ffd3c558448710128c3 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 09:45:34 -0700
Subject: [PATCH 304/386] Preserve SQLite defaults in bulk insert

Omit columns that are absent from pasted bulk insert data so SQLite defaults can fire during insert. Keep preview cells blank for omitted values while preserving explicit null rendering.

Refs [https://github.com/simonw/datasette/pull/2813#issuecomment-4878063728](https://github.com/simonw/datasette/pull/2813#issuecomment-4878063728)
---
 datasette/static/edit-tools.js | 18 +++++------
 tests/test_playwright.py       | 59 ++++++++++++++++++++++++++++++++--
 2 files changed, 66 insertions(+), 11 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 87b63838..9e2f2d01 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -5586,8 +5586,8 @@ function resetBulkInsertPreview(state) {
   syncRowEditInsertModeUi(state);
 }
 
-function normalizeBulkInsertCell(column, value, isMissing) {
-  if (isMissing || typeof value === "undefined") {
+function normalizeBulkInsertCell(column, value) {
+  if (typeof value === "undefined") {
     return column.notnull ? "" : null;
   }
   if (value === null) {
@@ -5609,11 +5609,10 @@ function rowObjectForBulkInsert(valuesByColumn, columns) {
       valuesByColumn,
       column.name,
     );
-    row[column.name] = normalizeBulkInsertCell(
-      column,
-      hasValue ? valuesByColumn[column.name] : undefined,
-      !hasValue,
-    );
+    if (!hasValue) {
+      return;
+    }
+    row[column.name] = normalizeBulkInsertCell(column, valuesByColumn[column.name]);
   });
   return row;
 }
@@ -5869,8 +5868,9 @@ function renderBulkInsertPreview(state, rows) {
     var tr = document.createElement("tr");
     state.bulkInsertColumnDetails.forEach(function (column) {
       var td = document.createElement("td");
-      var value = row[column.name];
-      td.textContent = bulkInsertPreviewValue(value);
+      var hasValue = Object.prototype.hasOwnProperty.call(row, column.name);
+      var value = hasValue ? row[column.name] : "";
+      td.textContent = hasValue ? bulkInsertPreviewValue(value) : "";
       if (value === null) {
         td.className = "row-edit-bulk-preview-null";
       }
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 60c81315..9bededc6 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -102,6 +102,12 @@ def write_playwright_database(db_path):
             id integer primary key,
             created_ms integer default (CAST((julianday('now') - 2440587.5) * 86400000 AS INTEGER))
         );
+        create table bulk_defaults (
+            id integer primary key,
+            title text not null,
+            status text not null default 'todo',
+            score integer default 5
+        );
         insert into projects (title, metadata, logo, notes, score) values
             (
                 'Build Datasette',
@@ -146,6 +152,11 @@ def write_playwright_config(config_path):
                                     "alter-table": True,
                                 },
                             },
+                            "bulk_defaults": {
+                                "permissions": {
+                                    "insert-row": True,
+                                },
+                            },
                         },
                     },
                 },
@@ -279,6 +290,16 @@ def project_row(datasette_server, pk):
     return rows[0]
 
 
+def bulk_default_rows(datasette_server, **filters):
+    params = {
+        "_shape": "objects",
+        **{key: str(value) for key, value in filters.items()},
+    }
+    response = httpx.get(f"{datasette_server}data/bulk_defaults.json", params=params)
+    response.raise_for_status()
+    return response.json()["rows"]
+
+
 def open_jump_menu(page):
     page.keyboard.press("/")
     page.locator("navigation-search .search-input").wait_for()
@@ -1007,7 +1028,8 @@ def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
     assert "metadata" in preview_text
     assert "id" not in preview_text
     assert "From CSV" in preview_text
-    assert "null" in preview_text
+    assert "null" not in preview_text
+    assert "undefined" not in preview_text
     preview_cell_style = dialog.locator(
         ".row-edit-bulk-preview-table td"
     ).first.evaluate(
@@ -1097,6 +1119,38 @@ def test_bulk_insert_preview_inserts_rows(page, datasette_server):
     assert project_rows(datasette_server, title="Bulk two")
 
 
+@pytest.mark.playwright
+def test_bulk_insert_omits_columns_absent_from_pasted_input(page, datasette_server):
+    page.goto(f"{datasette_server}data/bulk_defaults")
+    page.locator('button[data-table-action="insert-row"]').click()
+
+    dialog = page.locator("#row-edit-dialog")
+    dialog.wait_for()
+    dialog.locator(".row-edit-bulk-insert").click()
+    dialog.locator(".row-edit-bulk-textarea").fill("title\nOnly title")
+    dialog.locator(".row-edit-save").click()
+
+    assert dialog.locator(".row-edit-save").inner_text() == "Insert these rows"
+    preview_text = dialog.locator(".row-edit-bulk-preview-table").inner_text()
+    assert "Only title" in preview_text
+    assert "undefined" not in preview_text
+
+    dialog.locator(".row-edit-save").click()
+    dialog.locator(
+        ".row-edit-bulk-progress-status", has_text="1 row inserted."
+    ).wait_for()
+
+    rows = bulk_default_rows(datasette_server, title="Only title")
+    assert rows == [
+        {
+            "id": 1,
+            "title": "Only title",
+            "status": "todo",
+            "score": 5,
+        }
+    ]
+
+
 @pytest.mark.playwright
 def test_bulk_insert_preview_accepts_single_column_input(page, datasette_server):
     page.goto(f"{datasette_server}data/projects")
@@ -1116,7 +1170,8 @@ def test_bulk_insert_preview_accepts_single_column_input(page, datasette_server)
     assert "one" in preview_text
     assert "two" in preview_text
     assert "three" in preview_text
-    assert "null" in preview_text
+    assert "null" not in preview_text
+    assert "undefined" not in preview_text
 
 
 @pytest.mark.playwright

From 9c033b7ce9f9d9e0bc4b12cf458cfce8c15f5a9f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 09:50:35 -0700
Subject: [PATCH 305/386] Add Prettier check to lint recipe (#2821)

---
 Justfile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Justfile b/Justfile
index 5fcd9afd..6ffff870 100644
--- a/Justfile
+++ b/Justfile
@@ -33,10 +33,11 @@ export DATASETTE_SECRET := "not_a_secret"
   uv run codespell datasette -S datasette/static --ignore-words docs/codespell-ignore-words.txt
   uv run codespell tests --ignore-words docs/codespell-ignore-words.txt
 
-# Run linters: black, ruff, cog
+# Run linters: black, ruff, prettier, cog
 @lint: codespell
   uv run black datasette tests --check
   uv run ruff check datasette tests
+  npm run prettier -- --check
   uv run cog --check README.md docs/*.rst
 
 # Apply ruff fixes

From 4a39e44eb65fce88eb519951adee414e41625278 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 09:53:57 -0700
Subject: [PATCH 306/386] Preserve numeric inference for blank CSV values

Convert blank delimited cells to null when create-table-from-data inferred an integer or float column. This keeps sqlite-utils from treating mixed numeric and empty-string values as text.

Add a Playwright regression covering CSV table creation with a blank numeric value.
---
 datasette/static/edit-tools.js |  2 +-
 tests/test_playwright.py       | 47 ++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 9e2f2d01..74056df5 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -1612,7 +1612,7 @@ function inferCreateTableDelimitedColumnType(values) {
 function coerceCreateTableDelimitedValue(value, type) {
   var trimmed = String(value).trim();
   if (trimmed === "") {
-    return "";
+    return type === "integer" || type === "float" ? null : "";
   }
   if (type === "integer") {
     return parseInt(trimmed, 10);
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 9bededc6..833c62fa 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -515,6 +515,53 @@ def test_create_table_from_data_flow(page, datasette_server):
     ]
 
 
+@pytest.mark.playwright
+def test_create_table_from_csv_keeps_numeric_type_when_values_are_blank(
+    page, datasette_server
+):
+    page.goto(f"{datasette_server}data")
+    page.locator("details.actions-menu-links summary").click()
+    page.locator('button[data-database-action="create-table"]').click()
+
+    dialog = page.locator("#table-create-dialog")
+    dialog.wait_for()
+    dialog.locator(".table-create-from-data").click()
+    dialog.locator(".table-create-table-name").fill("playwright_numeric_blanks")
+    dialog.locator(".table-create-data-textarea").fill("name,score\nA,1\nB,")
+    dialog.locator(".table-create-save").click()
+
+    assert dialog.locator(".table-create-save").inner_text() == "Create table"
+    preview_text = dialog.locator(".table-create-data-preview-table").inner_text()
+    assert "A" in preview_text
+    assert "1" in preview_text
+    assert "B" in preview_text
+    assert "null" in preview_text
+
+    dialog.locator(".table-create-save").click()
+    page.wait_for_url("**/data/playwright_numeric_blanks")
+
+    response = httpx.get(
+        f"{datasette_server}data/playwright_numeric_blanks.json?_shape=objects"
+    )
+    response.raise_for_status()
+    assert response.json()["rows"] == [
+        {"name": "A", "score": 1},
+        {"name": "B", "score": None},
+    ]
+
+    schema_response = httpx.get(
+        f"{datasette_server}data/-/query.json",
+        params={
+            "sql": (
+                "select type from pragma_table_info('playwright_numeric_blanks') "
+                "where name = 'score'"
+            )
+        },
+    )
+    schema_response.raise_for_status()
+    assert schema_response.json()["rows"] == [{"type": "INTEGER"}]
+
+
 @pytest.mark.playwright
 def test_create_table_foreign_key_selection_updates_column_type(page, datasette_server):
     page.goto(f"{datasette_server}data")

From 141fe194c67ce5d97f65c3221e481a1cf04e7047 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 09:54:51 -0700
Subject: [PATCH 307/386] Hide create-from-data UI without insert permission

Expose whether the actor can insert rows in the create-table page data, then use that flag to hide and guard the create-table-from-data path. This avoids offering a flow that fails after preview for create-table-only actors.

Refs https://github.com/simonw/datasette/pull/2813#issuecomment-4878146376
---
 datasette/static/edit-tools.js        |  9 +++++--
 datasette/views/database.py           |  2 +-
 datasette/views/table_create_alter.py |  5 ++++
 tests/test_table_html.py              | 35 +++++++++++++++++++++++++++
 4 files changed, 48 insertions(+), 3 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 74056df5..c8072f8f 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -822,6 +822,11 @@ function tableCreateSaveButtonText(state) {
   return "Create table";
 }
 
+function tableCreateCanInsertRows() {
+  var data = databaseCreateTableData() || {};
+  return !!data.canInsertRows;
+}
+
 function syncTableCreateModeUi(state) {
   if (!state) {
     return;
@@ -831,7 +836,7 @@ function syncTableCreateModeUi(state) {
   state.dataPanel.hidden = !isDataMode;
   state.dataEditor.hidden = !isDataMode || state.dataPreviewReady;
   state.dataPreview.hidden = !isDataMode || !state.dataPreviewReady;
-  state.createFromDataLink.hidden = isDataMode;
+  state.createFromDataLink.hidden = isDataMode || !tableCreateCanInsertRows();
   state.manualCreateLink.hidden = !isDataMode;
 }
 
@@ -1303,7 +1308,7 @@ function resetTableCreateDialog(state) {
 }
 
 function showTableCreateDataMode(state) {
-  if (!state || state.isSaving) {
+  if (!state || state.isSaving || !tableCreateCanInsertRows()) {
     return;
   }
   state.mode = "data";
diff --git a/datasette/views/database.py b/datasette/views/database.py
index e02de657..c6ea57b8 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -325,7 +325,7 @@ class DatabaseContext(Context):
     database_color: str = field(metadata={"help": "The color assigned to the database"})
     database_page_data: dict = field(
         metadata={
-            "help": 'JSON data used by JavaScript on the database page. Currently ``{}`` or ``{"createTable": {...}}`` where ``createTable`` includes ``path``, ``foreignKeyTargetsPath``, ``databaseName``, ``columnTypes``, ``defaultExpressions`` and optional ``customColumnTypes``.'
+            "help": 'JSON data used by JavaScript on the database page. Currently ``{}`` or ``{"createTable": {...}}`` where ``createTable`` includes ``path``, ``foreignKeyTargetsPath``, ``databaseName``, ``columnTypes``, ``defaultExpressions``, ``canInsertRows`` and optional ``customColumnTypes``.'
         }
     )
     database_actions: callable = field(
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index ffeb7f14..6b3d82d3 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -267,6 +267,11 @@ async def _create_table_ui_context(
         "databaseName": database_name,
         "columnTypes": CREATE_TABLE_COLUMN_TYPES,
         "defaultExpressions": default_expression_options(),
+        "canInsertRows": await datasette.allowed(
+            action="insert-row",
+            resource=DatabaseResource(database=database_name),
+            actor=request.actor,
+        ),
     }
     can_set_column_type = await datasette.allowed(
         action="set-column-type",
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index be569e68..df1db1a3 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1027,6 +1027,7 @@ async def test_database_create_table_action_button_and_data():
                 "databaseName": "data",
                 "columnTypes": ["text", "integer", "float", "blob"],
                 "defaultExpressions": DEFAULT_EXPRESSION_OPTIONS,
+                "canInsertRows": False,
             },
         }
         assert "customColumnTypes" not in database_data_from_soup(soup)["createTable"]
@@ -1050,6 +1051,40 @@ async def test_database_create_table_action_button_and_data():
         ds.close()
 
 
+@pytest.mark.asyncio
+async def test_database_create_table_data_includes_insert_row_permission():
+    ds = Datasette(
+        [],
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "create-table": {"id": "root"},
+                        "insert-row": {"id": "root"},
+                    },
+                },
+            },
+        },
+    )
+    try:
+        db = ds.add_database(
+            Database(ds, memory_name="test_database_create_table_insert_permission"),
+            name="data",
+        )
+        await db.execute_write_script("""
+            create table items (id integer primary key, name text);
+            """)
+
+        response = await ds.client.get("/data", actor={"id": "root"})
+        assert response.status_code == 200
+        create_table_data = database_data_from_soup(Soup(response.text, "html.parser"))[
+            "createTable"
+        ]
+        assert create_table_data["canInsertRows"] is True
+    finally:
+        ds.close()
+
+
 @pytest.mark.asyncio
 async def test_database_create_table_data_includes_custom_column_types():
     ds = Datasette(

From ed6235e59a2b39f240168ff2eb1cdf0898141bd0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 10:30:38 -0700
Subject: [PATCH 308/386] Ran cog

---
 docs/template_context.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/template_context.rst b/docs/template_context.rst
index 5c6b1567..ad62995c 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -98,7 +98,7 @@ The page listing the tables, views and queries in a database, e.g. /fixtures. Re
     The color assigned to the database
 
 ``database_page_data`` - ``dict``
-    JSON data used by JavaScript on the database page. Currently ``{}`` or ``{"createTable": {...}}`` where ``createTable`` includes ``path``, ``foreignKeyTargetsPath``, ``databaseName``, ``columnTypes``, ``defaultExpressions`` and optional ``customColumnTypes``.
+    JSON data used by JavaScript on the database page. Currently ``{}`` or ``{"createTable": {...}}`` where ``createTable`` includes ``path``, ``foreignKeyTargetsPath``, ``databaseName``, ``columnTypes``, ``defaultExpressions``, ``canInsertRows`` and optional ``customColumnTypes``.
 
 ``editable`` - ``bool``
     Boolean indicating if the database is editable

From c864bc866d175d50f70de118e8fb739b992a5b9e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 10:44:36 -0700
Subject: [PATCH 309/386] Add bulk insert upsert controls

Expose conflict handling in the bulk insert UI when pasted rows include primary key columns, and route update-or-insert selections through the existing upsert API.

Add live validation for bulk textarea column errors and Playwright coverage for upsert permissions, conflict options, and validation behavior.

Refs shttps://github.com/simonw/datasette/pull/2813#issuecomment-4878320713
---
 datasette/static/app.css       |  37 ++++
 datasette/static/edit-tools.js | 338 +++++++++++++++++++++++++++++++--
 datasette/views/table.py       |  49 +++--
 tests/test_playwright.py       | 148 +++++++++++++++
 4 files changed, 536 insertions(+), 36 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index 30c4855c..d24a7831 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1832,6 +1832,34 @@ textarea.row-edit-input {
     padding-right: 12px;
 }
 
+.row-edit-bulk-conflict {
+    display: grid;
+    grid-template-columns: minmax(120px, 180px) minmax(0, 1fr);
+    gap: 8px 12px;
+    align-items: start;
+}
+
+.row-edit-bulk-conflict[hidden] {
+    display: none;
+}
+
+.row-edit-bulk-conflict-label {
+    color: var(--ink);
+    font-size: 0.82rem;
+    padding-top: 8px;
+}
+
+.row-edit-bulk-conflict-control {
+    display: grid;
+    gap: 4px;
+}
+
+.row-edit-bulk-conflict-help {
+    color: var(--muted);
+    font-size: 0.78rem;
+    margin: 0;
+}
+
 .row-edit-copy-template-label-narrow {
     display: none;
 }
@@ -3343,6 +3371,15 @@ select.table-alter-input {
         padding-top: 0;
     }
 
+    .row-edit-bulk-conflict {
+        grid-template-columns: 1fr;
+        gap: 5px;
+    }
+
+    .row-edit-bulk-conflict-label {
+        padding-top: 0;
+    }
+
     .row-edit-dialog .modal-footer {
         padding-left: 18px;
         padding-right: 18px;
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index c8072f8f..2712ffe7 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -4332,6 +4332,14 @@ function tableInsertUrl() {
   return url.toString();
 }
 
+function tableUpsertUrl() {
+  var data = tableInsertData();
+  if (data && data.upsertPath) {
+    return new URL(data.upsertPath, location.href).toString();
+  }
+  return null;
+}
+
 function rowResourceUrl(row) {
   var rowId = row.getAttribute("data-row");
   if (!rowId) {
@@ -5179,10 +5187,12 @@ function clearRowEditDialogError(state) {
   state.error.textContent = "";
 }
 
-function showRowEditDialogError(state, message) {
+function showRowEditDialogError(state, message, options) {
   state.error.hidden = false;
   state.error.textContent = message;
-  state.error.focus();
+  if (!options || options.focus !== false) {
+    state.error.focus();
+  }
 }
 
 function rowEditIsMultipleInsert(state) {
@@ -5205,7 +5215,10 @@ function updateRowEditDialogButtons(state) {
     state.isLoading ||
     state.isSaving ||
     !state.hasLoaded ||
-    state.bulkInsertInserted;
+    state.bulkInsertInserted ||
+    (rowEditIsMultipleInsert(state) &&
+      !state.bulkInsertPreviewReady &&
+      !!state.bulkInsertLiveValidationError);
   state.cancelButton.disabled = state.isSaving;
   syncRowEditInsertModeUi(state);
   state.cancelButton.textContent =
@@ -5220,14 +5233,16 @@ function updateRowEditDialogButtons(state) {
     ? state.bulkInsertInserted
       ? "Inserted"
       : state.bulkInsertPreviewReady
-        ? "Insert these rows"
+        ? bulkInsertSaveLabel(state)
         : "Preview rows"
     : state.mode === "insert"
       ? "Insert row"
       : "Save";
   state.saveButton.textContent = state.isSaving
     ? rowEditIsMultipleInsert(state)
-      ? "Inserting..."
+      ? bulkInsertConflictMode(state) === "upsert"
+        ? "Updating..."
+        : "Inserting..."
       : "Saving..."
     : saveLabel;
   state.form.setAttribute(
@@ -5484,6 +5499,8 @@ function showMultipleRowInsert(state) {
   }
   clearRowEditDialogError(state);
   setRowInsertDialogTitle(state);
+  syncBulkInsertConflictUi(state);
+  syncBulkInsertTextareaValidation(state);
   updateRowEditDialogButtons(state);
   state.bulkInsertTextarea.focus();
 }
@@ -5501,6 +5518,67 @@ function showSingleRowInsert(state) {
   }
 }
 
+function bulkInsertConflictMode(state) {
+  if (!state || !state.bulkInsertHasPrimaryKeyColumns) {
+    return "insert";
+  }
+  return state.bulkInsertConflictMode || "ignore";
+}
+
+function syncBulkInsertConflictUi(state) {
+  if (!state || !state.bulkInsertConflictField) {
+    return;
+  }
+  var insertData = tableInsertData() || {};
+  var primaryKeys = insertData.primaryKeys || [];
+  var hasPrimaryKeys = primaryKeys.length > 0;
+  var hasPrimaryKeyColumns =
+    hasPrimaryKeys &&
+    bulkInsertTextIncludesPrimaryKeyColumns(
+      state.bulkInsertTextarea.value,
+      state.bulkInsertColumnDetails,
+      primaryKeys,
+    );
+  state.bulkInsertHasPrimaryKeyColumns = hasPrimaryKeyColumns;
+  var canUpsert = hasPrimaryKeyColumns && !!state.currentUpsertUrl;
+  var upsertOption = state.bulkInsertConflictSelect.querySelector(
+    'option[value="upsert"]',
+  );
+  if (upsertOption) {
+    upsertOption.disabled = !canUpsert;
+    upsertOption.hidden = !canUpsert;
+  }
+  if (
+    !hasPrimaryKeyColumns ||
+    (!canUpsert && bulkInsertConflictMode(state) === "upsert")
+  ) {
+    state.bulkInsertConflictMode = hasPrimaryKeys ? "ignore" : "insert";
+    state.bulkInsertConflictSelect.value = state.bulkInsertConflictMode;
+  }
+  state.bulkInsertConflictField.hidden = !hasPrimaryKeyColumns;
+  state.bulkInsertConflictSelect.value = bulkInsertConflictMode(state);
+  var helpText = "";
+  if (bulkInsertConflictMode(state) === "upsert") {
+    helpText =
+      "Rows with existing primary keys will be updated; new primary keys will be inserted.";
+  } else if (bulkInsertConflictMode(state) === "ignore") {
+    helpText = "Rows with existing primary keys will be skipped.";
+  } else {
+    helpText = "Rows with existing primary keys will stop the import.";
+  }
+  state.bulkInsertConflictHelp.textContent = helpText;
+}
+
+function bulkInsertSaveLabel(state) {
+  if (!state.bulkInsertPreviewReady) {
+    return "Preview rows";
+  }
+  if (bulkInsertConflictMode(state) === "upsert") {
+    return "Update or insert rows";
+  }
+  return "Insert these rows";
+}
+
 function readTextFile(file) {
   if (file.text) {
     return file.text();
@@ -5526,7 +5604,6 @@ async function loadBulkInsertTextFile(state, file) {
     state.bulkInsertTextarea.dispatchEvent(
       new Event("input", { bubbles: true }),
     );
-    clearRowEditDialogError(state);
     state.bulkInsertTextarea.focus();
   } catch (_error) {
     showRowEditDialogError(state, "Could not read that text file.");
@@ -5588,6 +5665,7 @@ function resetBulkInsertPreview(state) {
   state.bulkInsertProgressBar.value = 0;
   state.bulkInsertProgressBar.max = 1;
   state.bulkInsertProgressStatus.textContent = "";
+  syncBulkInsertConflictUi(state);
   syncRowEditInsertModeUi(state);
 }
 
@@ -5617,7 +5695,10 @@ function rowObjectForBulkInsert(valuesByColumn, columns) {
     if (!hasValue) {
       return;
     }
-    row[column.name] = normalizeBulkInsertCell(column, valuesByColumn[column.name]);
+    row[column.name] = normalizeBulkInsertCell(
+      column,
+      valuesByColumn[column.name],
+    );
   });
   return row;
 }
@@ -5734,6 +5815,118 @@ function bulkInsertColumnMap(columns) {
   return map;
 }
 
+function bulkInsertTextIncludesPrimaryKeyColumns(text, columns, primaryKeys) {
+  if (!primaryKeys.length || !text.trim()) {
+    return false;
+  }
+  var trimmed = text.trim();
+  try {
+    if (trimmed[0] === "[" || trimmed[0] === "{") {
+      return jsonBulkInsertTextIncludesPrimaryKeyColumns(trimmed, primaryKeys);
+    }
+    return delimitedBulkInsertTextIncludesPrimaryKeyColumns(
+      trimmed,
+      columns,
+      primaryKeys,
+    );
+  } catch (_error) {
+    return false;
+  }
+}
+
+function jsonBulkInsertTextIncludesPrimaryKeyColumns(text, primaryKeys) {
+  var rows = parseJsonObjectRows(text);
+  var seenKeys = {};
+  rows.forEach(function (row) {
+    Object.keys(row).forEach(function (key) {
+      seenKeys[key] = true;
+    });
+  });
+  return primaryKeys.every(function (key) {
+    return !!seenKeys[key];
+  });
+}
+
+function delimitedBulkInsertTextIncludesPrimaryKeyColumns(
+  text,
+  columns,
+  primaryKeys,
+) {
+  var delimiter = detectBulkInsertDelimiter(text, columns);
+  var rows = (
+    delimiter === null
+      ? splitSingleColumnRows(text)
+      : splitDelimitedRows(text, delimiter)
+  ).filter(function (row) {
+    return !bulkInsertDelimitedRowIsBlank(row);
+  });
+  if (!rows.length) {
+    return false;
+  }
+
+  var columnMap = bulkInsertColumnMap(columns);
+  var header = rows[0].map(function (value) {
+    return value.trim();
+  });
+  var headerMatches = header.filter(function (name) {
+    return !!columnMap[name];
+  }).length;
+  if (headerMatches > 0) {
+    return primaryKeys.every(function (key) {
+      return header.indexOf(key) !== -1;
+    });
+  }
+
+  var headers = columns.map(function (column) {
+    return column.name;
+  });
+  var suppliedColumnCount = rows.reduce(function (count, row) {
+    return Math.max(count, row.length);
+  }, 0);
+  return primaryKeys.every(function (key) {
+    var index = headers.indexOf(key);
+    return index !== -1 && index < suppliedColumnCount;
+  });
+}
+
+function bulkInsertLiveValidationShouldWait(message) {
+  return (
+    message === "Paste rows before previewing." ||
+    message === "No data rows found to preview." ||
+    (message.indexOf("Invalid JSON:") === 0 &&
+      message.indexOf("Unexpected end") !== -1)
+  );
+}
+
+function bulkInsertLiveValidationError(state) {
+  var text = state.bulkInsertTextarea.value;
+  if (!text.trim()) {
+    return null;
+  }
+  try {
+    parseBulkInsertRows(text, state.bulkInsertColumnDetails);
+  } catch (error) {
+    var message = error.message || "Could not preview rows.";
+    return bulkInsertLiveValidationShouldWait(message) ? null : message;
+  }
+  return null;
+}
+
+function syncBulkInsertTextareaValidation(state) {
+  if (!rowEditIsMultipleInsert(state) || state.bulkInsertPreviewReady) {
+    state.bulkInsertLiveValidationError = null;
+    return;
+  }
+  state.bulkInsertLiveValidationError = bulkInsertLiveValidationError(state);
+  if (state.bulkInsertLiveValidationError) {
+    showRowEditDialogError(state, state.bulkInsertLiveValidationError, {
+      focus: false,
+    });
+  } else {
+    clearRowEditDialogError(state);
+  }
+}
+
 function parseJsonBulkInsertRows(text, columns) {
   var parsed = parseJsonObjectRows(text);
 
@@ -5892,6 +6085,7 @@ function renderBulkInsertPreview(state, rows) {
 function previewBulkInsertRows(state) {
   clearRowEditDialogError(state);
   resetBulkInsertPreview(state);
+  syncBulkInsertConflictUi(state);
   try {
     var rows = parseBulkInsertRows(
       state.bulkInsertTextarea.value,
@@ -5908,13 +6102,14 @@ function previewBulkInsertRows(state) {
 }
 
 function updateBulkInsertProgress(state, inserted, total) {
+  var words = bulkInsertProgressWords(state);
   state.bulkInsertProgress.hidden = false;
   state.bulkInsertProgressBar.max = total || 1;
   state.bulkInsertProgressBar.value = inserted;
   state.bulkInsertProgressStatus.textContent =
     inserted >= total
-      ? total + " row" + (total === 1 ? " inserted." : "s inserted.")
-      : "Inserting " + inserted + " of " + total + " rows...";
+      ? total + " row" + (total === 1 ? " " : "s ") + words.complete + "."
+      : words.active + " " + inserted + " of " + total + " rows...";
 }
 
 function bulkInsertBatches(rows, batchSize) {
@@ -5944,11 +6139,12 @@ function animateBulkInsertProgress(state, from, to, total, duration) {
       var easedProgress = 1 - Math.pow(1 - progress, 3);
       var value = from + (to - from) * easedProgress;
       var displayValue = progress === 1 ? to : Math.floor(value);
+      var words = bulkInsertProgressWords(state);
       state.bulkInsertProgressBar.value = value;
       state.bulkInsertProgressStatus.textContent =
         displayValue >= total
-          ? total + " row" + (total === 1 ? " inserted." : "s inserted.")
-          : "Inserting " + displayValue + " of " + total + " rows...";
+          ? total + " row" + (total === 1 ? " " : "s ") + words.complete + "."
+          : words.active + " " + displayValue + " of " + total + " rows...";
       if (progress < 1) {
         window.requestAnimationFrame(step);
       } else {
@@ -5960,16 +6156,77 @@ function animateBulkInsertProgress(state, from, to, total, duration) {
   });
 }
 
+function bulkInsertProgressWords(state) {
+  var mode = bulkInsertConflictMode(state);
+  if (mode === "upsert") {
+    return {
+      active: "Upserting",
+      complete: "upserted",
+    };
+  }
+  if (mode === "ignore") {
+    return {
+      active: "Processing",
+      complete: "processed",
+    };
+  }
+  return {
+    active: "Inserting",
+    complete: "inserted",
+  };
+}
+
+function validateBulkInsertConflictRows(state, rows) {
+  if (bulkInsertConflictMode(state) !== "upsert") {
+    return null;
+  }
+  var insertData = tableInsertData() || {};
+  var primaryKeys = insertData.primaryKeys || [];
+  for (var index = 0; index < rows.length; index += 1) {
+    var row = rows[index];
+    var missing = primaryKeys.filter(function (key) {
+      return (
+        !Object.prototype.hasOwnProperty.call(row, key) ||
+        row[key] === null ||
+        typeof row[key] === "undefined"
+      );
+    });
+    if (missing.length) {
+      return (
+        "Row " +
+        (index + 1) +
+        " is missing primary key " +
+        missing.join(", ") +
+        ". Upsert requires primary key values for every row."
+      );
+    }
+  }
+  return null;
+}
+
 async function insertBulkPreviewRows(state) {
   if (!state.bulkInsertPreviewRows || state.bulkInsertInserted) {
     return;
   }
-  if (!state.currentInsertUrl) {
-    showRowEditDialogError(state, "Could not find the row insert URL.");
+  var conflictMode = bulkInsertConflictMode(state);
+  var url =
+    conflictMode === "upsert" ? state.currentUpsertUrl : state.currentInsertUrl;
+  if (!url) {
+    showRowEditDialogError(
+      state,
+      conflictMode === "upsert"
+        ? "Could not find the row upsert URL."
+        : "Could not find the row insert URL.",
+    );
     return;
   }
 
   var rows = state.bulkInsertPreviewRows;
+  var validationError = validateBulkInsertConflictRows(state, rows);
+  if (validationError) {
+    showRowEditDialogError(state, validationError);
+    return;
+  }
   var total = rows.length;
   var inserted = state.bulkInsertInsertedCount || 0;
   var batches = bulkInsertBatches(
@@ -5984,13 +6241,17 @@ async function insertBulkPreviewRows(state) {
   try {
     for (var batchIndex = 0; batchIndex < batches.length; batchIndex += 1) {
       var batch = batches[batchIndex];
-      var response = await fetch(state.currentInsertUrl, {
+      var payload = { rows: batch };
+      if (conflictMode === "ignore") {
+        payload.ignore = true;
+      }
+      var response = await fetch(url, {
         method: "POST",
         headers: {
           "Content-Type": "application/json",
           Accept: "application/json",
         },
-        body: JSON.stringify({ rows: batch }),
+        body: JSON.stringify(payload),
       });
       var data = null;
       try {
@@ -6318,15 +6579,17 @@ function renderRowEditFields(state, data) {
 
 function renderRowInsertFields(state, data) {
   var columns = data.columns || [];
+  var bulkColumns = data.bulkColumns || columns;
 
   state.insertMode = "single";
-  state.bulkInsertColumnDetails = columns.slice();
+  state.bulkInsertColumnDetails = bulkColumns.slice();
   state.bulkInsertMaxRows = data.maxInsertRows || 100;
-  state.bulkInsertColumns = columns.map(function (column) {
+  state.bulkInsertColumns = bulkColumns.map(function (column) {
     return column.name;
   });
   state.copyTemplateButton.disabled = !state.bulkInsertColumns.length;
   setBulkInsertCopyButtonReady(state);
+  syncBulkInsertConflictUi(state);
   clearTimeout(state.copyTemplateResetTimer);
   state.copyTemplateResetTimer = null;
   resetBulkInsertPreview(state);
@@ -6424,6 +6687,17 @@ function ensureRowEditDialog(manager) {
           <p class="row-edit-bulk-note"><label for="row-edit-bulk-textarea">Paste TSV, CSV, or JSON</label>. You can also <button type="button" class="button-as-link row-edit-bulk-open-file">open a file</button> or drop it onto this textarea</p>
           <input class="row-edit-bulk-file-input" type="file" accept=".csv,.tsv,.json,.txt,text/csv,text/tab-separated-values,application/json,text/plain" hidden>
           <textarea class="row-edit-input row-edit-bulk-textarea" id="row-edit-bulk-textarea" name="_bulk_rows" rows="12" spellcheck="false"></textarea>
+          <div class="row-edit-bulk-conflict" hidden>
+            <label class="row-edit-bulk-conflict-label" for="row-edit-bulk-conflict-mode">If the row exists already</label>
+            <div class="row-edit-bulk-conflict-control">
+              <select class="row-edit-input row-edit-bulk-conflict-mode" id="row-edit-bulk-conflict-mode" aria-describedby="row-edit-bulk-conflict-help">
+                <option value="insert">Stop with an error</option>
+                <option value="ignore">Skip existing rows</option>
+                <option value="upsert">Update existing and insert new</option>
+              </select>
+              <p class="row-edit-bulk-conflict-help" id="row-edit-bulk-conflict-help"></p>
+            </div>
+          </div>
           <div class="row-edit-bulk-actions">
             <button type="button" class="btn btn-ghost row-edit-copy-template"><span class="row-edit-copy-template-label-wide">Copy spreadsheet template</span><span class="row-edit-copy-template-label-narrow">Copy template</span></button>
             <span class="row-edit-bulk-template-note"><span class="row-edit-bulk-template-note-wide">You can paste the template into Google Sheets or Excel.</span><span class="row-edit-bulk-template-note-narrow">Paste into Google Sheets or Excel</span></span>
@@ -6462,6 +6736,13 @@ function ensureRowEditDialog(manager) {
     bulkInsertProgressStatus: dialog.querySelector(
       ".row-edit-bulk-progress-status",
     ),
+    bulkInsertConflictField: dialog.querySelector(".row-edit-bulk-conflict"),
+    bulkInsertConflictSelect: dialog.querySelector(
+      ".row-edit-bulk-conflict-mode",
+    ),
+    bulkInsertConflictHelp: dialog.querySelector(
+      ".row-edit-bulk-conflict-help",
+    ),
     copyTemplateButton: dialog.querySelector(".row-edit-copy-template"),
     bulkInsertOpenFileButton: dialog.querySelector(".row-edit-bulk-open-file"),
     bulkInsertFileInput: dialog.querySelector(".row-edit-bulk-file-input"),
@@ -6474,10 +6755,14 @@ function ensureRowEditDialog(manager) {
     currentRowId: null,
     currentPkPath: null,
     currentInsertUrl: null,
+    currentUpsertUrl: null,
     currentUpdateUrl: null,
     currentFragmentUrl: null,
     mode: "edit",
     insertMode: "single",
+    bulkInsertConflictMode: "ignore",
+    bulkInsertHasPrimaryKeyColumns: false,
+    bulkInsertLiveValidationError: null,
     bulkInsertColumns: [],
     bulkInsertColumnDetails: [],
     bulkInsertPreviewRows: null,
@@ -6620,10 +6905,22 @@ function ensureRowEditDialog(manager) {
 
   rowEditDialogState.bulkInsertTextarea.addEventListener("input", function () {
     resetBulkInsertPreview(rowEditDialogState);
-    clearRowEditDialogError(rowEditDialogState);
+    syncBulkInsertTextareaValidation(rowEditDialogState);
     updateRowEditDialogButtons(rowEditDialogState);
   });
 
+  rowEditDialogState.bulkInsertConflictSelect.addEventListener(
+    "change",
+    function () {
+      rowEditDialogState.bulkInsertConflictMode =
+        rowEditDialogState.bulkInsertConflictSelect.value;
+      syncBulkInsertConflictUi(rowEditDialogState);
+      resetBulkInsertPreview(rowEditDialogState);
+      syncBulkInsertTextareaValidation(rowEditDialogState);
+      updateRowEditDialogButtons(rowEditDialogState);
+    },
+  );
+
   dialog.addEventListener("click", function (ev) {
     if (ev.target === dialog) {
       closeRowEditDialogIfConfirmed(rowEditDialogState);
@@ -6649,6 +6946,7 @@ function ensureRowEditDialog(manager) {
     var redirectOnCloseUrl = state.redirectOnCloseUrl;
     state.loadId += 1;
     state.isClosePending = false;
+    state.bulkInsertLiveValidationError = null;
     state.shouldReloadOnClose = false;
     state.redirectOnCloseUrl = null;
     clearTimeout(state.copyTemplateResetTimer);
@@ -6696,6 +6994,7 @@ async function openRowEditDialog(button, manager) {
   state.currentRowId = row.getAttribute("data-row") || "";
   state.currentPkPath = rowDisplayLabel(row);
   state.currentInsertUrl = null;
+  state.currentUpsertUrl = null;
   state.currentUpdateUrl = rowUpdateUrl(row);
   state.currentFragmentUrl = rowFragmentUrl(row);
   state.insertMode = "single";
@@ -6773,9 +7072,12 @@ function openRowInsertDialog(button, manager) {
   state.currentRowId = null;
   state.currentPkPath = null;
   state.currentInsertUrl = tableInsertUrl();
+  state.currentUpsertUrl = tableUpsertUrl();
   state.currentUpdateUrl = null;
   state.currentFragmentUrl = null;
   state.insertMode = "single";
+  state.bulkInsertConflictMode = "ignore";
+  state.bulkInsertLiveValidationError = null;
   state.bulkInsertTextarea.value = "";
   state.shouldReloadOnClose = false;
   state.redirectOnCloseUrl = null;
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 5335e6dc..caece7fd 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -480,8 +480,15 @@ async def _table_insert_ui(
     ):
         return None
 
+    can_update = await datasette.allowed(
+        action="update-row",
+        resource=TableResource(database=database_name, table=table_name),
+        actor=request.actor,
+    )
+
     column_types_map = await datasette.get_column_types(database_name, table_name)
     columns = []
+    bulk_columns = []
     column_details = await db.table_column_details(table_name)
     for column in column_details:
         if column.hidden:
@@ -492,33 +499,39 @@ async def _table_insert_ui(
             and len(pks) == 1
             and SQLiteType.from_declared_type(column.type) == SQLiteType.INTEGER
         )
+        column_type = column_types_map.get(column.name)
+        column_data = {
+            "name": column.name,
+            "sqlite_type": _column_sqlite_type_for_insert_form(column),
+            "notnull": column.notnull,
+            "default": column.default_value,
+            "has_default": column.default_value is not None,
+            "is_pk": is_pk,
+            "value_kind": _column_value_kind_for_insert_form(column),
+            "column_type": (
+                {"type": column_type.name, "config": column_type.config}
+                if column_type is not None
+                else None
+            ),
+        }
+        bulk_columns.append(column_data)
         if is_auto_pk:
             continue
-        column_type = column_types_map.get(column.name)
-        columns.append(
-            {
-                "name": column.name,
-                "sqlite_type": _column_sqlite_type_for_insert_form(column),
-                "notnull": column.notnull,
-                "default": column.default_value,
-                "has_default": column.default_value is not None,
-                "is_pk": is_pk,
-                "value_kind": _column_value_kind_for_insert_form(column),
-                "column_type": (
-                    {"type": column_type.name, "config": column_type.config}
-                    if column_type is not None
-                    else None
-                ),
-            }
-        )
+        columns.append(column_data)
 
-    return {
+    data = {
         "path": "{}/-/insert".format(datasette.urls.table(database_name, table_name)),
         "tableName": table_name,
         "columns": columns,
+        "bulkColumns": bulk_columns,
         "primaryKeys": pks,
         "maxInsertRows": datasette.setting("max_insert_rows"),
     }
+    if can_update:
+        data["upsertPath"] = "{}/-/upsert".format(
+            datasette.urls.table(database_name, table_name)
+        )
+    return data
 
 
 async def _table_alter_ui(
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 833c62fa..421b86f8 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -108,6 +108,11 @@ def write_playwright_database(db_path):
             status text not null default 'todo',
             score integer default 5
         );
+        create table upsert_items (
+            id text primary key,
+            title text,
+            metadata text
+        );
         insert into projects (title, metadata, logo, notes, score) values
             (
                 'Build Datasette',
@@ -116,6 +121,8 @@ def write_playwright_database(db_path):
                 'Initial notes',
                 5
             );
+        insert into upsert_items (id, title, metadata) values
+            ('existing', 'Existing title', '{"old": true}');
         """)
     finally:
         conn.close()
@@ -157,6 +164,12 @@ def write_playwright_config(config_path):
                                     "insert-row": True,
                                 },
                             },
+                            "upsert_items": {
+                                "permissions": {
+                                    "insert-row": True,
+                                    "update-row": True,
+                                },
+                            },
                         },
                     },
                 },
@@ -300,6 +313,31 @@ def bulk_default_rows(datasette_server, **filters):
     return response.json()["rows"]
 
 
+def upsert_item_rows(datasette_server, **filters):
+    params = {
+        "_shape": "objects",
+        **{key: str(value) for key, value in filters.items()},
+    }
+    response = httpx.get(f"{datasette_server}data/upsert_items.json", params=params)
+    response.raise_for_status()
+    return response.json()["rows"]
+
+
+def upsert_item_row(datasette_server, pk):
+    rows = upsert_item_rows(datasette_server, id=pk)
+    assert len(rows) == 1
+    return rows[0]
+
+
+def open_bulk_insert_dialog(page, url):
+    page.goto(url)
+    page.locator('button[data-table-action="insert-row"]').click()
+    dialog = page.locator("#row-edit-dialog")
+    dialog.wait_for()
+    dialog.locator(".row-edit-bulk-insert").click()
+    return dialog
+
+
 def open_jump_menu(page):
     page.keyboard.press("/")
     page.locator("navigation-search .search-input").wait_for()
@@ -1166,6 +1204,116 @@ def test_bulk_insert_preview_inserts_rows(page, datasette_server):
     assert project_rows(datasette_server, title="Bulk two")
 
 
+@pytest.mark.playwright
+def test_bulk_insert_upsert_option_updates_existing_and_inserts_new(
+    page, datasette_server
+):
+    dialog = open_bulk_insert_dialog(page, f"{datasette_server}data/upsert_items")
+    textarea = dialog.locator(".row-edit-bulk-textarea")
+    conflict_field = dialog.locator(".row-edit-bulk-conflict")
+    conflict_select = dialog.locator(".row-edit-bulk-conflict-mode")
+
+    assert conflict_field.is_hidden()
+    textarea.fill("title\nNo primary key")
+    assert conflict_field.is_hidden()
+
+    textarea.fill(
+        "id,title,metadata\nexisting,Updated by upsert,{}\nnew,Inserted by upsert,{}"
+    )
+    assert conflict_field.is_visible()
+    assert (
+        dialog.locator(".row-edit-bulk-conflict-label").inner_text()
+        == "If the row exists already"
+    )
+    assert conflict_select.input_value() == "ignore"
+    assert (
+        conflict_select.evaluate("""node => Array.from(node.options)
+        .filter((option) => !option.hidden)
+        .map((option) => option.textContent.trim())""")
+        == [
+            "Stop with an error",
+            "Skip existing rows",
+            "Update existing and insert new",
+        ]
+    )
+
+    conflict_select.select_option("upsert")
+    assert conflict_select.input_value() == "upsert"
+    dialog.locator(".row-edit-save").click()
+
+    assert dialog.locator(".row-edit-save").inner_text() == "Update or insert rows"
+    preview_text = dialog.locator(".row-edit-bulk-preview-table").inner_text()
+    assert "Updated by upsert" in preview_text
+    assert "Inserted by upsert" in preview_text
+
+    dialog.locator(".row-edit-save").click()
+    dialog.locator(
+        ".row-edit-bulk-progress-status", has_text="2 rows upserted."
+    ).wait_for()
+
+    assert upsert_item_row(datasette_server, "existing")["title"] == (
+        "Updated by upsert"
+    )
+    assert upsert_item_row(datasette_server, "new")["title"] == "Inserted by upsert"
+
+
+@pytest.mark.playwright
+def test_bulk_insert_conflicts_hide_upsert_without_update_permission(
+    page, datasette_server
+):
+    dialog = open_bulk_insert_dialog(page, f"{datasette_server}data/bulk_defaults")
+    textarea = dialog.locator(".row-edit-bulk-textarea")
+    conflict_field = dialog.locator(".row-edit-bulk-conflict")
+    conflict_select = dialog.locator(".row-edit-bulk-conflict-mode")
+
+    textarea.fill("title\nOnly title")
+    assert conflict_field.is_hidden()
+
+    textarea.fill("id,title\n1,Only title")
+    assert conflict_field.is_visible()
+    assert conflict_select.input_value() == "ignore"
+    assert (
+        conflict_select.evaluate("""node => Array.from(node.options)
+        .filter((option) => !option.hidden)
+        .map((option) => option.textContent.trim())""")
+        == [
+            "Stop with an error",
+            "Skip existing rows",
+        ]
+    )
+    assert conflict_select.locator('option[value="upsert"]').evaluate(
+        "node => node.hidden && node.disabled"
+    )
+
+
+@pytest.mark.playwright
+def test_bulk_insert_live_validation_reports_unknown_columns(page, datasette_server):
+    dialog = open_bulk_insert_dialog(page, f"{datasette_server}data/projects")
+    textarea = dialog.locator(".row-edit-bulk-textarea")
+    error = dialog.locator(".row-edit-error")
+    save = dialog.locator(".row-edit-save")
+
+    textarea.fill(json.dumps([{"id2": 1, "title": "Unknown column"}]))
+    error.wait_for()
+    assert error.inner_text() == "JSON row 1 has unknown column id2."
+    assert save.is_disabled()
+    assert textarea.evaluate("node => document.activeElement === node")
+
+    textarea.fill("id2,title\n1,Unknown column")
+    assert error.inner_text() == "Unknown column id2 in header row."
+    assert save.is_disabled()
+
+    textarea.fill("[")
+    assert error.is_hidden()
+    assert not save.is_disabled()
+
+    textarea.fill(json.dumps([{"id": 1, "title": "Known column"}]))
+    assert error.is_hidden()
+    assert not save.is_disabled()
+    assert dialog.locator(".row-edit-bulk-conflict").is_visible()
+    assert dialog.locator(".row-edit-bulk-conflict-mode").input_value() == "ignore"
+
+
 @pytest.mark.playwright
 def test_bulk_insert_omits_columns_absent_from_pasted_input(page, datasette_server):
     page.goto(f"{datasette_server}data/bulk_defaults")

From 3aea678eabdf84493557472cdb5461662bd6be3f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 12:27:02 -0700
Subject: [PATCH 310/386] Show auto primary keys in bulk insert preview

Render omitted auto integer primary key values as muted auto text in the bulk insert preview so generated IDs are easier to understand.

Expose the auto primary key flag in insert UI metadata and cover the preview behavior in Playwright.
---
 datasette/static/app.css       |  3 ++-
 datasette/static/edit-tools.js | 26 +++++++++++++++++++++++---
 datasette/views/table.py       |  3 ++-
 docs/template_context.rst      |  2 +-
 tests/test_playwright.py       |  1 +
 5 files changed, 29 insertions(+), 6 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index d24a7831..e67be340 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1979,7 +1979,8 @@ textarea.row-edit-input {
     border-right: none;
 }
 
-.row-edit-bulk-preview-null {
+.row-edit-bulk-preview-null,
+.row-edit-bulk-preview-auto {
     color: var(--muted);
     font-style: italic;
 }
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 2712ffe7..7e02ac0f 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -6038,6 +6038,25 @@ function bulkInsertPreviewValue(value) {
   return String(value);
 }
 
+function bulkInsertPreviewCell(column, hasValue, value) {
+  if (!hasValue && column.is_auto_pk) {
+    return {
+      text: "auto",
+      className: "row-edit-bulk-preview-auto",
+    };
+  }
+  if (value === null) {
+    return {
+      text: bulkInsertPreviewValue(value),
+      className: "row-edit-bulk-preview-null",
+    };
+  }
+  return {
+    text: hasValue ? bulkInsertPreviewValue(value) : "",
+    className: "",
+  };
+}
+
 function renderBulkInsertPreview(state, rows) {
   state.bulkInsertPreview.textContent = "";
   var summary = document.createElement("p");
@@ -6068,9 +6087,10 @@ function renderBulkInsertPreview(state, rows) {
       var td = document.createElement("td");
       var hasValue = Object.prototype.hasOwnProperty.call(row, column.name);
       var value = hasValue ? row[column.name] : "";
-      td.textContent = hasValue ? bulkInsertPreviewValue(value) : "";
-      if (value === null) {
-        td.className = "row-edit-bulk-preview-null";
+      var cell = bulkInsertPreviewCell(column, hasValue, value);
+      td.textContent = cell.text;
+      if (cell.className) {
+        td.className = cell.className;
       }
       tr.appendChild(td);
     });
diff --git a/datasette/views/table.py b/datasette/views/table.py
index caece7fd..b658f61e 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -205,7 +205,7 @@ class TableContext(Context):
     )
     table_insert_ui: dict = field(
         metadata={
-            "help": "Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns`` and ``primaryKeys`` keys; each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``value_kind`` and ``column_type`` keys."
+            "help": "Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns`` and ``primaryKeys`` keys; each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``is_auto_pk``, ``value_kind`` and ``column_type`` keys."
         }
     )
     table_alter_ui: dict = field(
@@ -507,6 +507,7 @@ async def _table_insert_ui(
             "default": column.default_value,
             "has_default": column.default_value is not None,
             "is_pk": is_pk,
+            "is_auto_pk": is_auto_pk,
             "value_kind": _column_value_kind_for_insert_form(column),
             "column_type": (
                 {"type": column_type.name, "config": column_type.config}
diff --git a/docs/template_context.rst b/docs/template_context.rst
index ad62995c..89de7293 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -389,7 +389,7 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     SQL definition for this table
 
 ``table_insert_ui`` - ``dict``
-    Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns`` and ``primaryKeys`` keys; each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``value_kind`` and ``column_type`` keys.
+    Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns`` and ``primaryKeys`` keys; each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``is_auto_pk``, ``value_kind`` and ``column_type`` keys.
 
 ``table_page_data`` - ``dict``
     JSON data used by JavaScript on the table page. Includes ``database``, ``table`` and ``tableUrl``, plus optional ``foreignKeys`` mapping column names to autocomplete URLs, optional ``insertRow`` data and optional ``alterTable`` data.
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 421b86f8..27967d8b 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -1329,6 +1329,7 @@ def test_bulk_insert_omits_columns_absent_from_pasted_input(page, datasette_serv
     preview_text = dialog.locator(".row-edit-bulk-preview-table").inner_text()
     assert "Only title" in preview_text
     assert "undefined" not in preview_text
+    assert dialog.locator(".row-edit-bulk-preview-auto").inner_text() == "auto"
 
     dialog.locator(".row-edit-save").click()
     dialog.locator(

From 3d67168ee58792e71ee12055633e2011e1b64d5a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 12:35:59 -0700
Subject: [PATCH 311/386] Docs and unreleased release notes for bulk
 insert/create table from data

---
 datasette/views/table.py  | 2 +-
 docs/changelog.rst        | 9 +++++++++
 docs/template_context.rst | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index b658f61e..7da68bc0 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -205,7 +205,7 @@ class TableContext(Context):
     )
     table_insert_ui: dict = field(
         metadata={
-            "help": "Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns`` and ``primaryKeys`` keys; each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``is_auto_pk``, ``value_kind`` and ``column_type`` keys."
+            "help": "Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns``, ``bulkColumns``, ``primaryKeys`` and ``maxInsertRows`` keys, plus optional ``upsertPath`` if the current actor has permission to update rows. ``columns`` lists columns for the single-row insert form, while ``bulkColumns`` lists columns for the bulk insert form. Each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``is_auto_pk``, ``value_kind`` and ``column_type`` keys."
         }
     )
     table_alter_ui: dict = field(
diff --git a/docs/changelog.rst b/docs/changelog.rst
index ec32b57e..6290b952 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,6 +4,15 @@
 Changelog
 =========
 
+.. _unreleased:
+
+Unreleased
+----------
+
+- Table pages now offer an "Insert multiple rows" mode in the row insertion dialog. This accepts pasted TSV, CSV or JSON, previews the parsed rows before inserting them, validates unknown columns as data is pasted and displays omitted auto integer primary keys as ``auto`` in the preview. (:pr:`2813`)
+- The bulk insert UI can now skip rows with existing primary keys, or update existing rows and insert new rows using the existing ``/<database>/<table>/-/upsert`` API when the actor has both :ref:`insert-row <actions_insert_row>` and :ref:`update-row <actions_update_row>` permissions. (:pr:`2813`)
+- The "Create table" dialog now includes a "Create table from data" mode. Paste TSV, CSV or JSON rows to preview inferred columns and types, choose the table name and primary key, then create the table and insert those rows in one step. (:pr:`2813`)
+
 .. _v1_0_a35:
 
 1.0a35 (2026-06-23)
diff --git a/docs/template_context.rst b/docs/template_context.rst
index 89de7293..e9447058 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -389,7 +389,7 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     SQL definition for this table
 
 ``table_insert_ui`` - ``dict``
-    Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns`` and ``primaryKeys`` keys; each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``is_auto_pk``, ``value_kind`` and ``column_type`` keys.
+    Information needed to enable the row insertion UI, or ``None`` if row insertion is not available to the current actor. When present it has ``path``, ``tableName``, ``columns``, ``bulkColumns``, ``primaryKeys`` and ``maxInsertRows`` keys, plus optional ``upsertPath`` if the current actor has permission to update rows. ``columns`` lists columns for the single-row insert form, while ``bulkColumns`` lists columns for the bulk insert form. Each column includes ``name``, ``sqlite_type``, ``notnull``, ``default``, ``has_default``, ``is_pk``, ``is_auto_pk``, ``value_kind`` and ``column_type`` keys.
 
 ``table_page_data`` - ``dict``
     JSON data used by JavaScript on the table page. Includes ``database``, ``table`` and ``tableUrl``, plus optional ``foreignKeys`` mapping column names to autocomplete URLs, optional ``insertRow`` data and optional ``alterTable`` data.

From b1d990ceba4546ef2fd71aab9b13cd46fafa88b7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 12:37:07 -0700
Subject: [PATCH 312/386] Wording tweak

---
 docs/changelog.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 6290b952..726558f9 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -10,7 +10,7 @@ Unreleased
 ----------
 
 - Table pages now offer an "Insert multiple rows" mode in the row insertion dialog. This accepts pasted TSV, CSV or JSON, previews the parsed rows before inserting them, validates unknown columns as data is pasted and displays omitted auto integer primary keys as ``auto`` in the preview. (:pr:`2813`)
-- The bulk insert UI can now skip rows with existing primary keys, or update existing rows and insert new rows using the existing ``/<database>/<table>/-/upsert`` API when the actor has both :ref:`insert-row <actions_insert_row>` and :ref:`update-row <actions_update_row>` permissions. (:pr:`2813`)
+- The bulk insert UI can skip rows with existing primary keys, or update existing rows and insert new rows using the existing ``/<database>/<table>/-/upsert`` API when the actor has both :ref:`insert-row <actions_insert_row>` and :ref:`update-row <actions_update_row>` permissions. (:pr:`2813`)
 - The "Create table" dialog now includes a "Create table from data" mode. Paste TSV, CSV or JSON rows to preview inferred columns and types, choose the table name and primary key, then create the table and insert those rows in one step. (:pr:`2813`)
 
 .. _v1_0_a35:

From 8f32a8f134ff8e4ee8682f528a55b55c852b3d8f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 12:47:22 -0700
Subject: [PATCH 313/386] Fix bulk insert Playwright expectations

Keep copied spreadsheet templates aligned with the single-row insert columns while still previewing auto primary keys in bulk insert rows.

Treat invalid JSON during live bulk-insert validation as unfinished input so Firefox does not expose browser-specific parse errors while typing.
---
 datasette/static/edit-tools.js | 11 +++++++----
 tests/test_playwright.py       |  6 +++++-
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 7e02ac0f..8a565316 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -5611,7 +5611,7 @@ async function loadBulkInsertTextFile(state, file) {
 }
 
 function bulkInsertTemplateText(state) {
-  return (state.bulkInsertColumns || []).join("\t");
+  return (state.bulkInsertTemplateColumns || []).join("\t");
 }
 
 async function copyTextToClipboard(text) {
@@ -5893,8 +5893,7 @@ function bulkInsertLiveValidationShouldWait(message) {
   return (
     message === "Paste rows before previewing." ||
     message === "No data rows found to preview." ||
-    (message.indexOf("Invalid JSON:") === 0 &&
-      message.indexOf("Unexpected end") !== -1)
+    message.indexOf("Invalid JSON:") === 0
   );
 }
 
@@ -6607,7 +6606,10 @@ function renderRowInsertFields(state, data) {
   state.bulkInsertColumns = bulkColumns.map(function (column) {
     return column.name;
   });
-  state.copyTemplateButton.disabled = !state.bulkInsertColumns.length;
+  state.bulkInsertTemplateColumns = columns.map(function (column) {
+    return column.name;
+  });
+  state.copyTemplateButton.disabled = !state.bulkInsertTemplateColumns.length;
   setBulkInsertCopyButtonReady(state);
   syncBulkInsertConflictUi(state);
   clearTimeout(state.copyTemplateResetTimer);
@@ -6784,6 +6786,7 @@ function ensureRowEditDialog(manager) {
     bulkInsertHasPrimaryKeyColumns: false,
     bulkInsertLiveValidationError: null,
     bulkInsertColumns: [],
+    bulkInsertTemplateColumns: [],
     bulkInsertColumnDetails: [],
     bulkInsertPreviewRows: null,
     bulkInsertPreviewReady: false,
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 27967d8b..798c65e4 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -1109,10 +1109,14 @@ def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
         "Previewing 1 row."
     )
     preview_text = dialog.locator(".row-edit-bulk-preview-table").inner_text()
+    assert "id" in preview_text
     assert "title" in preview_text
     assert "metadata" in preview_text
-    assert "id" not in preview_text
     assert "From CSV" in preview_text
+    assert (
+        dialog.locator(".row-edit-bulk-preview-auto").first.text_content()
+        == "auto"
+    )
     assert "null" not in preview_text
     assert "undefined" not in preview_text
     preview_cell_style = dialog.locator(

From 2bcabd8e1f4b0324f391df02ad94dfbf968b4cb5 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 12:57:36 -0700
Subject: [PATCH 314/386] Harden Playwright server startup wait

Allow the Datasette subprocess more time to become reachable under CI load.

If startup still times out, terminate the process and include stdout and stderr in the assertion so future failures have useful diagnostics.
---
 tests/test_playwright.py | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 798c65e4..0614ec36 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -17,7 +17,7 @@ def find_free_port():
         return sock.getsockname()[1]
 
 
-def wait_for_server(process, url, timeout=10):
+def wait_for_server(process, url, timeout=30):
     deadline = time.monotonic() + timeout
     last_error = None
     while time.monotonic() < deadline:
@@ -36,7 +36,20 @@ def wait_for_server(process, url, timeout=10):
         except httpx.HTTPError as ex:
             last_error = repr(ex)
         time.sleep(0.1)
-    raise AssertionError(f"Timed out waiting for {url}: {last_error}")
+    if process.poll() is None:
+        process.terminate()
+        try:
+            stdout, stderr = process.communicate(timeout=5)
+        except subprocess.TimeoutExpired:
+            process.kill()
+            stdout, stderr = process.communicate()
+    else:
+        stdout, stderr = process.communicate()
+    raise AssertionError(
+        f"Timed out waiting for {url}: {last_error}\n"
+        f"stdout:\n{stdout}\n"
+        f"stderr:\n{stderr}"
+    )
 
 
 @pytest.fixture
@@ -1113,10 +1126,7 @@ def test_insert_row_flow_uses_custom_column_field(page, datasette_server):
     assert "title" in preview_text
     assert "metadata" in preview_text
     assert "From CSV" in preview_text
-    assert (
-        dialog.locator(".row-edit-bulk-preview-auto").first.text_content()
-        == "auto"
-    )
+    assert dialog.locator(".row-edit-bulk-preview-auto").first.text_content() == "auto"
     assert "null" not in preview_text
     assert "undefined" not in preview_text
     preview_cell_style = dialog.locator(

From 3b24c88e9354cd0d78e0edfc2a3f7905b3e70ab1 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 14:05:45 -0700
Subject: [PATCH 315/386] Support editing BLOBs through JSON APIs

---
 datasette/utils/__init__.py           |  30 ++++++
 datasette/views/row.py                |   9 +-
 datasette/views/table.py              |  13 ++-
 datasette/views/table_create_alter.py |   6 ++
 docs/binary_data.rst                  |  47 ++++++++++
 docs/json_api.rst                     |  10 ++
 tests/test_api_write.py               | 127 ++++++++++++++++++++++++++
 7 files changed, 240 insertions(+), 2 deletions(-)

diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 1caff3a8..468828c5 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -1,4 +1,5 @@
 import asyncio
+import binascii
 from contextlib import contextmanager
 import aiofiles
 import click
@@ -266,6 +267,35 @@ class CustomJSONEncoder(json.JSONEncoder):
         return json.JSONEncoder.default(self, obj)
 
 
+class WriteJsonValueError(ValueError):
+    pass
+
+
+def decode_write_json_cell(value):
+    if not isinstance(value, dict):
+        return value
+    keys = set(value.keys())
+    if keys == {"$raw"}:
+        return value["$raw"]
+    if keys == {"$base64", "encoded"} and value.get("$base64") is True:
+        encoded = value["encoded"]
+        if not isinstance(encoded, str):
+            raise WriteJsonValueError("$base64 encoded value must be a string")
+        try:
+            return base64.b64decode(encoded, validate=True)
+        except binascii.Error as ex:
+            raise WriteJsonValueError("Invalid $base64 encoded value") from ex
+    return value
+
+
+def decode_write_json_row(row):
+    return {key: decode_write_json_cell(value) for key, value in row.items()}
+
+
+def decode_write_json_rows(rows):
+    return [decode_write_json_row(row) for row in rows]
+
+
 @contextmanager
 def sqlite_timelimit(conn, ms):
     deadline = time.perf_counter() + (ms / 1000)
diff --git a/datasette/views/row.py b/datasette/views/row.py
index 129216b9..f84d3a09 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -17,7 +17,9 @@ from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
     call_with_supported_arguments,
+    CustomJSONEncoder,
     CustomRow,
+    decode_write_json_row,
     InvalidSql,
     make_slot_function,
     path_from_row_pks,
@@ -27,6 +29,7 @@ from datasette.utils import (
     to_css_class,
     escape_sqlite,
     sqlite3,
+    WriteJsonValueError,
 )
 from datasette.plugins import pm
 from datasette.extras import extra_names_from_request, ExtraScope
@@ -806,6 +809,10 @@ class RowUpdateView(BaseView):
             return _error(["Invalid keys: {}".format(", ".join(invalid_keys))])
 
         update = data["update"]
+        try:
+            update = decode_write_json_row(update)
+        except WriteJsonValueError as e:
+            return _error([str(e)], 400)
 
         # Validate column types
         from datasette.views.table import _validate_column_types
@@ -867,4 +874,4 @@ class RowUpdateView(BaseView):
                 self.ds.INFO,
             )
 
-        return Response.json(result, status=200)
+        return Response.json(result, status=200, default=CustomJSONEncoder().default)
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 1fc151e6..7899877d 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -22,9 +22,11 @@ from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
     call_with_supported_arguments,
+    CustomJSONEncoder,
     CustomRow,
     append_querystring,
     compound_keys_after_sql,
+    decode_write_json_rows,
     format_bytes,
     make_slot_function,
     tilde_encode,
@@ -41,6 +43,7 @@ from datasette.utils import (
     urlsafe_components,
     value_as_boolean,
     InvalidSql,
+    WriteJsonValueError,
     sqlite3,
 )
 from datasette.utils.asgi import BadRequest, Forbidden, NotFound, Request, Response
@@ -1057,6 +1060,10 @@ class TableInsertView(BaseView):
         )
         if errors:
             return _error(errors, 400)
+        try:
+            rows = decode_write_json_rows(rows)
+        except WriteJsonValueError as e:
+            return _error([str(e)], 400)
 
         # Validate column types
         ct_errors = await _validate_column_types(
@@ -1191,7 +1198,11 @@ class TableInsertView(BaseView):
                     )
                 )
 
-        return Response.json(result, status=200 if upsert else 201)
+        return Response.json(
+            result,
+            status=200 if upsert else 201,
+            default=CustomJSONEncoder().default,
+        )
 
 
 class TableUpsertView(TableInsertView):
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index ffeb7f14..5feb1fa1 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -20,9 +20,11 @@ from datasette.column_types import SQLiteType
 from datasette.events import AlterTableEvent, CreateTableEvent, InsertRowsEvent
 from datasette.resources import DatabaseResource, TableResource
 from datasette.utils import (
+    decode_write_json_rows,
     escape_sqlite,
     get_outbound_foreign_keys,
     table_column_details,
+    WriteJsonValueError,
 )
 from datasette.utils.asgi import NotFound, Response
 from datasette.utils.sqlite import sqlite_hidden_table_names
@@ -838,6 +840,10 @@ class TableCreateView(BaseView):
                 actor=request.actor,
             ):
                 return _error(["Permission denied: need insert-row"], 403)
+            try:
+                rows = decode_write_json_rows(rows)
+            except WriteJsonValueError as e:
+                return _error([str(e)], 400)
 
         alter = False
         if rows:
diff --git a/docs/binary_data.rst b/docs/binary_data.rst
index 0c890fe5..fc972f98 100644
--- a/docs/binary_data.rst
+++ b/docs/binary_data.rst
@@ -12,6 +12,11 @@ Datasette includes special handling for these binary values. The Datasette inter
    :width: 311px
    :alt: Screenshot showing download links next to binary data in the table view
 
+.. _binary_json_format:
+
+Binary values in JSON
+---------------------
+
 Binary data is represented in ``.json`` exports using Base64 encoding.
 
 https://latest.datasette.io/fixtures/binary_data.json?_shape=array
@@ -39,6 +44,48 @@ https://latest.datasette.io/fixtures/binary_data.json?_shape=array
         }
     ]
 
+The same format can be used with the :ref:`JSON write API <json_api_write>`.
+If a column value in a ``row``, ``rows`` or ``update`` object is a JSON object with exactly ``"$base64"`` set to ``true`` and an ``"encoded"`` string, Datasette will decode that Base64 string and store the resulting bytes:
+
+.. code-block:: json
+
+    {
+        "data": {
+            "$base64": true,
+            "encoded": "FRwCx60F/g=="
+        }
+    }
+
+This works for inserts, upserts and updates. It also works when creating a table from example ``row`` or ``rows`` data: Datasette decodes the value before inferring the schema, allowing that column to be created as a ``BLOB`` column.
+
+To store a JSON object with that exact shape literally, wrap it in a ``"$raw"`` object:
+
+.. code-block:: json
+
+    {
+        "data": {
+            "$raw": {
+                "$base64": true,
+                "encoded": "FRwCx60F/g=="
+            }
+        }
+    }
+
+``"$raw"`` unwraps exactly one layer. To store a literal ``"$raw"`` object containing a Base64 object, wrap it again:
+
+.. code-block:: json
+
+    {
+        "data": {
+            "$raw": {
+                "$raw": {
+                    "$base64": true,
+                    "encoded": "FRwCx60F/g=="
+                }
+            }
+        }
+    }
+
 .. _binary_linking:
 
 Linking to binary downloads
diff --git a/docs/json_api.rst b/docs/json_api.rst
index eca22fdc..01b95f08 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -1532,6 +1532,8 @@ The JSON write API
 
 Datasette provides a write API for JSON data. This is a POST-only API that requires an authenticated API token, see :ref:`CreateTokenView`. The token will need to have the specified :ref:`authentication_permissions`.
 
+The row-based write APIs can write :ref:`binary values in JSON <binary_json_format>` using Datasette's Base64 representation for BLOB data.
+
 .. _ExecuteWriteView:
 
 Executing write SQL
@@ -1660,6 +1662,8 @@ A single row can be inserted using the ``"row"`` key:
         }
     }
 
+Column values can use the :ref:`binary value JSON format <binary_json_format>` to write BLOB data.
+
 If successful, this will return a ``201`` status code and the newly inserted row, for example:
 
 .. code-block:: json
@@ -1765,6 +1769,8 @@ An upsert is an insert or update operation. If a row with a matching primary key
 
 The upsert API is mostly the same shape as the :ref:`insert API <TableInsertView>`. It requires both the :ref:`actions_insert_row` and :ref:`actions_update_row` permissions.
 
+It also accepts the same :ref:`binary value JSON format <binary_json_format>`.
+
 ::
 
     POST /<database>/<table>/-/upsert
@@ -1895,6 +1901,8 @@ To update a row, make a ``POST`` to ``/<database>/<table>/<row-pks>/-/update``.
 
 You only need to pass the columns you want to update. Any other columns will be left unchanged.
 
+Updated values can use the :ref:`binary value JSON format <binary_json_format>`.
+
 If successful, this will return a ``200`` status code and a ``{"ok": true}`` response body.
 
 Add ``"return": true`` to the request body to return the updated row:
@@ -2098,6 +2106,8 @@ Datasette will create a table with a schema that matches those rows and insert t
         "pk": "id"
     }
 
+Example rows can use the :ref:`binary value JSON format <binary_json_format>`, allowing Datasette to infer ``BLOB`` columns.
+
 Doing this requires both the :ref:`actions_create_table` and :ref:`actions_insert_row` permissions.
 
 The ``201`` response here will be similar to the ``columns`` form, but will also include the number of rows that were inserted as ``row_count``:
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 76797742..1a4a966b 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -50,6 +50,133 @@ def _insert_and_fetch_created(conn, table, insert_sql):
     ).fetchone()
 
 
+BASE64_WRITE_API_VALUE = {"$base64": True, "encoded": "AAEC/f7/"}
+BASE64_WRITE_API_LITERAL = '{"$base64": true, "encoded": "AAEC/f7/"}'
+
+
+@pytest.mark.asyncio
+async def test_base64_write_api_create_table_infers_blob_and_raw_escapes(ds_write):
+    token = write_token(ds_write)
+    response = await ds_write.client.post(
+        "/data/-/create",
+        json={
+            "table": "binary_create",
+            "row": {
+                "id": 1,
+                "data": BASE64_WRITE_API_VALUE,
+                "literal": {"$raw": BASE64_WRITE_API_VALUE},
+                "double_raw": {"$raw": {"$raw": BASE64_WRITE_API_VALUE}},
+            },
+            "pk": "id",
+        },
+        headers=_headers(token),
+    )
+    assert response.status_code == 201
+    assert "[data] BLOB" in response.json()["schema"]
+    assert "[literal] TEXT" in response.json()["schema"]
+
+    rows = (await ds_write.get_database("data").execute("""
+            select
+              typeof(data) as data_type,
+              hex(data) as data_hex,
+              typeof(literal) as literal_type,
+              literal,
+              typeof(double_raw) as double_raw_type,
+              double_raw
+            from binary_create
+            """)).dicts()
+    assert rows == [
+        {
+            "data_type": "blob",
+            "data_hex": "000102FDFEFF",
+            "literal_type": "text",
+            "literal": BASE64_WRITE_API_LITERAL,
+            "double_raw_type": "text",
+            "double_raw": '{"$raw": {"$base64": true, "encoded": "AAEC/f7/"}}',
+        }
+    ]
+
+
+@pytest.mark.asyncio
+async def test_base64_write_api_insert_upsert_update_decode_blobs(ds_write):
+    token = write_token(ds_write)
+    db = ds_write.get_database("data")
+    await db.execute_write(
+        "create table binary_api (id integer primary key, data blob, literal text)"
+    )
+
+    insert_response = await ds_write.client.post(
+        "/data/binary_api/-/insert",
+        json={
+            "row": {
+                "id": 1,
+                "data": BASE64_WRITE_API_VALUE,
+                "literal": {"$raw": BASE64_WRITE_API_VALUE},
+            }
+        },
+        headers=_headers(token),
+    )
+    assert insert_response.status_code == 201
+    assert insert_response.json()["rows"][0]["data"] == BASE64_WRITE_API_VALUE
+
+    upsert_response = await ds_write.client.post(
+        "/data/binary_api/-/upsert",
+        json={
+            "rows": [
+                {
+                    "id": 2,
+                    "data": BASE64_WRITE_API_VALUE,
+                    "literal": {"$raw": BASE64_WRITE_API_VALUE},
+                }
+            ]
+        },
+        headers=_headers(token),
+    )
+    assert upsert_response.status_code == 200
+    assert upsert_response.json() == {"ok": True}
+
+    update_response = await ds_write.client.post(
+        "/data/binary_api/1/-/update",
+        json={
+            "update": {
+                "data": {"$base64": True, "encoded": "/wAB"},
+                "literal": {"$raw": {"$raw": BASE64_WRITE_API_VALUE}},
+            },
+            "return": True,
+        },
+        headers=_headers(token),
+    )
+    assert update_response.status_code == 200
+    assert update_response.json()["row"]["data"] == {"$base64": True, "encoded": "/wAB"}
+
+    rows = (await db.execute("""
+            select
+              id,
+              typeof(data) as data_type,
+              hex(data) as data_hex,
+              typeof(literal) as literal_type,
+              literal
+            from binary_api
+            order by id
+            """)).dicts()
+    assert rows == [
+        {
+            "id": 1,
+            "data_type": "blob",
+            "data_hex": "FF0001",
+            "literal_type": "text",
+            "literal": '{"$raw": {"$base64": true, "encoded": "AAEC/f7/"}}',
+        },
+        {
+            "id": 2,
+            "data_type": "blob",
+            "data_hex": "000102FDFEFF",
+            "literal_type": "text",
+            "literal": BASE64_WRITE_API_LITERAL,
+        },
+    ]
+
+
 @pytest.mark.asyncio
 async def test_api_explorer_upsert_example_json(ds_write):
     response = await ds_write.client.get("/-/api", actor={"id": "root"})

From 8856914be805f4dee2e241895b848031bae7c526 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 14:45:38 -0700
Subject: [PATCH 316/386] Add column_details JSON extra

---
 datasette/views/table_extras.py | 37 +++++++++++++++++++++++++++++
 docs/changelog.rst              |  7 ++++++
 docs/json_api.rst               | 36 +++++++++++++++++++++++++++++
 tests/test_api.py               | 36 ++++++++++++++++++++++++++++-
 tests/test_table_api.py         | 41 +++++++++++++++++++++++++++++++++
 5 files changed, 156 insertions(+), 1 deletion(-)

diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index db659c80..5ba4187a 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -1,6 +1,7 @@
 import itertools
 from dataclasses import dataclass
 
+from datasette.column_types import SQLiteType
 from datasette.database import QueryInterrupted
 from datasette.extras import Extra, ExtraExample, ExtraRegistry, ExtraScope, Provider
 from datasette.plugins import pm
@@ -342,6 +343,41 @@ class PrimaryKeysExtra(Extra):
         return context.pks
 
 
+def column_detail_as_json(column):
+    return {
+        "type": column.type,
+        "sqlite_type": SQLiteType.from_declared_type(column.type).value,
+        "notnull": column.notnull,
+        "default": column.default_value,
+        "is_pk": bool(column.is_pk),
+        "hidden": bool(column.hidden),
+    }
+
+
+class ColumnDetailsExtra(Extra):
+    description = (
+        "SQLite schema details for columns in this table. The dictionary maps "
+        "column names to ``type``, ``sqlite_type``, ``notnull``, ``default``, "
+        "``is_pk`` and ``hidden`` values."
+    )
+    example = ExtraExample("/fixtures/binary_data.json?_size=0&_extra=column_details")
+    examples = {
+        ExtraScope.ROW: ExtraExample(
+            "/fixtures/binary_data/1.json?_extra=column_details"
+        )
+    }
+    scopes = {ExtraScope.TABLE, ExtraScope.ROW}
+
+    async def resolve(self, context):
+        column_details = await context.datasette._get_resource_column_details(
+            context.database_name, context.table_name
+        )
+        return {
+            column_name: column_detail_as_json(column)
+            for column_name, column in column_details.items()
+        }
+
+
 class ActionsExtra(Extra):
     description = 'Async callable returning table or view actions made available by core and plugin hooks. Each item is either a link with ``href``, ``label`` and optional ``description`` keys, or a button with ``type: "button"``, ``label``, optional ``description`` and optional ``attrs``. See :ref:`plugin_actions`, :ref:`plugin_hook_table_actions` and :ref:`plugin_hook_view_actions`.'
     scopes = {ExtraScope.TABLE}
@@ -1206,6 +1242,7 @@ TABLE_EXTRA_CLASSES = [
     ColumnsExtra,
     AllColumnsExtra,
     PrimaryKeysExtra,
+    ColumnDetailsExtra,
     DisplayColumnsAndRowsProvider,
     DisplayColumnsExtra,
     DisplayRowsExtra,
diff --git a/docs/changelog.rst b/docs/changelog.rst
index ec32b57e..7f3fd2c4 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,6 +4,13 @@
 Changelog
 =========
 
+.. _v1_0_a36:
+
+1.0a36 (in development)
+-----------------------
+
+- The table and row JSON APIs now support ``?_extra=column_details`` for returning SQLite schema details for columns, including declared type, SQLite affinity, primary key, ``NOT NULL``, default and hidden-column metadata.
+
 .. _v1_0_a35:
 
 1.0a35 (2026-06-23)
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 01b95f08..05c2565f 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -402,6 +402,24 @@ The available table extras are listed below.
           "pk"
         ]
 
+``column_details``
+    SQLite schema details for columns in this table. The dictionary maps column names to ``type``, ``sqlite_type``, ``notnull``, ``default``, ``is_pk`` and ``hidden`` values.
+
+    ``GET /fixtures/binary_data.json?_size=0&_extra=column_details``
+
+    .. code-block:: json
+
+        {
+          "data": {
+            "type": "BLOB",
+            "sqlite_type": "BLOB",
+            "notnull": 0,
+            "default": null,
+            "is_pk": false,
+            "hidden": false
+          }
+        }
+
 ``display_columns``
     Column metadata used by the HTML table display. Each item includes ``name``, ``sortable``, ``is_pk``, ``type``, ``notnull``, ``description``, ``column_type`` and ``column_type_config`` keys.
 
@@ -807,6 +825,24 @@ The following extras are available for row JSON responses.
           "id"
         ]
 
+``column_details``
+    SQLite schema details for columns in this table. The dictionary maps column names to ``type``, ``sqlite_type``, ``notnull``, ``default``, ``is_pk`` and ``hidden`` values.
+
+    ``GET /fixtures/binary_data/1.json?_extra=column_details``
+
+    .. code-block:: json
+
+        {
+          "data": {
+            "type": "BLOB",
+            "sqlite_type": "BLOB",
+            "notnull": 0,
+            "default": null,
+            "is_pk": false,
+            "hidden": false
+          }
+        }
+
 ``render_cell``
     Rendered HTML for each cell using the render_cell plugin hook (See the :ref:`render_cell() plugin hook <plugin_hook_render_cell>` documentation.)
 
diff --git a/tests/test_api.py b/tests/test_api.py
index f57d0206..da9e5d00 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -429,7 +429,7 @@ async def test_row_foreign_key_tables(ds_client):
 @pytest.mark.asyncio
 async def test_row_extras(ds_client):
     response = await ds_client.get(
-        "/fixtures/simple_primary_key/1.json?_extra=database,table,primary_keys,query,request,debug,foreign_key_tables"
+        "/fixtures/simple_primary_key/1.json?_extra=database,table,primary_keys,query,request,debug,foreign_key_tables,column_details"
     )
     assert response.status_code == 200
     data = response.json()
@@ -446,6 +446,40 @@ async def test_row_extras(ds_client):
         "format": "json",
     }
     assert len(data["foreign_key_tables"]) == 5
+    assert data["column_details"]["id"] == {
+        "type": "INTEGER",
+        "sqlite_type": "INTEGER",
+        "notnull": 0,
+        "default": None,
+        "is_pk": True,
+        "hidden": False,
+    }
+    assert data["column_details"]["content"] == {
+        "type": "TEXT",
+        "sqlite_type": "TEXT",
+        "notnull": 0,
+        "default": None,
+        "is_pk": False,
+        "hidden": False,
+    }
+
+
+@pytest.mark.asyncio
+async def test_column_details_extra_row_for_null_blob(ds_client):
+    response = await ds_client.get(
+        "/fixtures/binary_data/3.json?_extra=column_details"
+    )
+    assert response.status_code == 200
+    assert response.json()["column_details"] == {
+        "data": {
+            "type": "BLOB",
+            "sqlite_type": "BLOB",
+            "notnull": 0,
+            "default": None,
+            "is_pk": False,
+            "hidden": False,
+        }
+    }
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 272e39e3..0362c701 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -1336,6 +1336,47 @@ async def test_binary_data_in_json(ds_client, path, expected_json, expected_text
         assert response.text == expected_text
 
 
+@pytest.mark.asyncio
+async def test_column_details_extra_table(ds_client):
+    response = await ds_client.get(
+        "/fixtures/binary_data.json?_size=0&_extra=column_details"
+    )
+    assert response.status_code == 200
+    assert response.json()["column_details"] == {
+        "data": {
+            "type": "BLOB",
+            "sqlite_type": "BLOB",
+            "notnull": 0,
+            "default": None,
+            "is_pk": False,
+            "hidden": False,
+        }
+    }
+
+    response = await ds_client.get(
+        "/fixtures/simple_primary_key.json?_size=0&_extra=column_details"
+    )
+    assert response.status_code == 200
+    assert response.json()["column_details"] == {
+        "id": {
+            "type": "INTEGER",
+            "sqlite_type": "INTEGER",
+            "notnull": 0,
+            "default": None,
+            "is_pk": True,
+            "hidden": False,
+        },
+        "content": {
+            "type": "TEXT",
+            "sqlite_type": "TEXT",
+            "notnull": 0,
+            "default": None,
+            "is_pk": False,
+            "hidden": False,
+        },
+    }
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "qs",

From b476218edb78447529d3085b3c1684a39aa80d62 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 16:08:34 -0700
Subject: [PATCH 317/386] Refine column_details metadata shape

---
 datasette/views/table_extras.py | 22 ++++++++--
 docs/json_api.rst               | 14 ++++---
 tests/test_api.py               | 19 ++++-----
 tests/test_table_api.py         | 71 ++++++++++++++++++++++++++++++---
 4 files changed, 101 insertions(+), 25 deletions(-)

diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index 5ba4187a..274c99ff 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -347,18 +347,32 @@ def column_detail_as_json(column):
     return {
         "type": column.type,
         "sqlite_type": SQLiteType.from_declared_type(column.type).value,
-        "notnull": column.notnull,
+        "notnull": bool(column.notnull),
         "default": column.default_value,
         "is_pk": bool(column.is_pk),
-        "hidden": bool(column.hidden),
+        "pk_position": column.is_pk,
+        "hidden": column.hidden,
     }
 
 
 class ColumnDetailsExtra(Extra):
     description = (
         "SQLite schema details for columns in this table. The dictionary maps "
-        "column names to ``type``, ``sqlite_type``, ``notnull``, ``default``, "
-        "``is_pk`` and ``hidden`` values."
+        "column names to objects describing the schema for each column."
+    )
+    docs_note = (
+        "Each object has ``type`` as the declared type string returned by "
+        'SQLite, or ``""`` if no type was declared; ``sqlite_type`` as the '
+        "normalized SQLite affinity, one of ``TEXT``, ``INTEGER``, ``REAL``, "
+        "``BLOB`` or ``NUMERIC``; ``notnull`` as a boolean; ``default`` "
+        'as the raw SQL default expression string, such as ``"42"``, '
+        "``\"'hello'\"`` or ``\"datetime('now')\"``, or ``null`` if there is "
+        "no default; ``is_pk`` as a boolean; ``pk_position`` as the integer "
+        "primary key position reported by SQLite, or ``0`` for columns that "
+        "are not part of the primary key; and ``hidden`` as the integer value "
+        "reported by SQLite's ``PRAGMA table_xinfo``. ``hidden`` is ``0`` for "
+        "normal columns, ``1`` for hidden virtual table columns, ``2`` for "
+        "virtual generated columns and ``3`` for stored generated columns."
     )
     example = ExtraExample("/fixtures/binary_data.json?_size=0&_extra=column_details")
     examples = {
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 05c2565f..f14a5c07 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -403,7 +403,7 @@ The available table extras are listed below.
         ]
 
 ``column_details``
-    SQLite schema details for columns in this table. The dictionary maps column names to ``type``, ``sqlite_type``, ``notnull``, ``default``, ``is_pk`` and ``hidden`` values.
+    SQLite schema details for columns in this table. The dictionary maps column names to objects describing the schema for each column. (Each object has ``type`` as the declared type string returned by SQLite, or ``""`` if no type was declared; ``sqlite_type`` as the normalized SQLite affinity, one of ``TEXT``, ``INTEGER``, ``REAL``, ``BLOB`` or ``NUMERIC``; ``notnull`` as a boolean; ``default`` as the raw SQL default expression string, such as ``"42"``, ``"'hello'"`` or ``"datetime('now')"``, or ``null`` if there is no default; ``is_pk`` as a boolean; ``pk_position`` as the integer primary key position reported by SQLite, or ``0`` for columns that are not part of the primary key; and ``hidden`` as the integer value reported by SQLite's ``PRAGMA table_xinfo``. ``hidden`` is ``0`` for normal columns, ``1`` for hidden virtual table columns, ``2`` for virtual generated columns and ``3`` for stored generated columns.)
 
     ``GET /fixtures/binary_data.json?_size=0&_extra=column_details``
 
@@ -413,10 +413,11 @@ The available table extras are listed below.
           "data": {
             "type": "BLOB",
             "sqlite_type": "BLOB",
-            "notnull": 0,
+            "notnull": false,
             "default": null,
             "is_pk": false,
-            "hidden": false
+            "pk_position": 0,
+            "hidden": 0
           }
         }
 
@@ -826,7 +827,7 @@ The following extras are available for row JSON responses.
         ]
 
 ``column_details``
-    SQLite schema details for columns in this table. The dictionary maps column names to ``type``, ``sqlite_type``, ``notnull``, ``default``, ``is_pk`` and ``hidden`` values.
+    SQLite schema details for columns in this table. The dictionary maps column names to objects describing the schema for each column. (Each object has ``type`` as the declared type string returned by SQLite, or ``""`` if no type was declared; ``sqlite_type`` as the normalized SQLite affinity, one of ``TEXT``, ``INTEGER``, ``REAL``, ``BLOB`` or ``NUMERIC``; ``notnull`` as a boolean; ``default`` as the raw SQL default expression string, such as ``"42"``, ``"'hello'"`` or ``"datetime('now')"``, or ``null`` if there is no default; ``is_pk`` as a boolean; ``pk_position`` as the integer primary key position reported by SQLite, or ``0`` for columns that are not part of the primary key; and ``hidden`` as the integer value reported by SQLite's ``PRAGMA table_xinfo``. ``hidden`` is ``0`` for normal columns, ``1`` for hidden virtual table columns, ``2`` for virtual generated columns and ``3`` for stored generated columns.)
 
     ``GET /fixtures/binary_data/1.json?_extra=column_details``
 
@@ -836,10 +837,11 @@ The following extras are available for row JSON responses.
           "data": {
             "type": "BLOB",
             "sqlite_type": "BLOB",
-            "notnull": 0,
+            "notnull": false,
             "default": null,
             "is_pk": false,
-            "hidden": false
+            "pk_position": 0,
+            "hidden": 0
           }
         }
 
diff --git a/tests/test_api.py b/tests/test_api.py
index da9e5d00..ee3329e1 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -449,35 +449,36 @@ async def test_row_extras(ds_client):
     assert data["column_details"]["id"] == {
         "type": "INTEGER",
         "sqlite_type": "INTEGER",
-        "notnull": 0,
+        "notnull": False,
         "default": None,
         "is_pk": True,
-        "hidden": False,
+        "pk_position": 1,
+        "hidden": 0,
     }
     assert data["column_details"]["content"] == {
         "type": "TEXT",
         "sqlite_type": "TEXT",
-        "notnull": 0,
+        "notnull": False,
         "default": None,
         "is_pk": False,
-        "hidden": False,
+        "pk_position": 0,
+        "hidden": 0,
     }
 
 
 @pytest.mark.asyncio
 async def test_column_details_extra_row_for_null_blob(ds_client):
-    response = await ds_client.get(
-        "/fixtures/binary_data/3.json?_extra=column_details"
-    )
+    response = await ds_client.get("/fixtures/binary_data/3.json?_extra=column_details")
     assert response.status_code == 200
     assert response.json()["column_details"] == {
         "data": {
             "type": "BLOB",
             "sqlite_type": "BLOB",
-            "notnull": 0,
+            "notnull": False,
             "default": None,
             "is_pk": False,
-            "hidden": False,
+            "pk_position": 0,
+            "hidden": 0,
         }
     }
 
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 0362c701..067a8bab 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -1346,10 +1346,11 @@ async def test_column_details_extra_table(ds_client):
         "data": {
             "type": "BLOB",
             "sqlite_type": "BLOB",
-            "notnull": 0,
+            "notnull": False,
             "default": None,
             "is_pk": False,
-            "hidden": False,
+            "pk_position": 0,
+            "hidden": 0,
         }
     }
 
@@ -1361,21 +1362,79 @@ async def test_column_details_extra_table(ds_client):
         "id": {
             "type": "INTEGER",
             "sqlite_type": "INTEGER",
-            "notnull": 0,
+            "notnull": False,
             "default": None,
             "is_pk": True,
-            "hidden": False,
+            "pk_position": 1,
+            "hidden": 0,
         },
         "content": {
             "type": "TEXT",
             "sqlite_type": "TEXT",
-            "notnull": 0,
+            "notnull": False,
             "default": None,
             "is_pk": False,
-            "hidden": False,
+            "pk_position": 0,
+            "hidden": 0,
         },
     }
 
+    response = await ds_client.get(
+        "/fixtures/compound_three_primary_keys.json?_size=0&_extra=column_details"
+    )
+    assert response.status_code == 200
+    column_details = response.json()["column_details"]
+    assert column_details["pk1"]["is_pk"] is True
+    assert column_details["pk1"]["pk_position"] == 1
+    assert column_details["pk2"]["is_pk"] is True
+    assert column_details["pk2"]["pk_position"] == 2
+    assert column_details["pk3"]["is_pk"] is True
+    assert column_details["pk3"]["pk_position"] == 3
+    assert column_details["content"]["is_pk"] is False
+    assert column_details["content"]["pk_position"] == 0
+
+
+def test_column_details_extra_defaults_and_notnull():
+    with make_app_client(extra_databases={"defaults.db": """
+                CREATE TABLE defaults (
+                    i INTEGER NOT NULL DEFAULT 42,
+                    s TEXT DEFAULT 'hello',
+                    dt TEXT DEFAULT (datetime('now'))
+                );
+            """}) as client:
+        response = client.get("/defaults/defaults.json?_size=0&_extra=column_details")
+        assert response.status == 200
+        column_details = response.json["column_details"]
+        assert column_details["i"]["notnull"] is True
+        assert column_details["i"]["default"] == "42"
+        assert column_details["s"]["notnull"] is False
+        assert column_details["s"]["default"] == "'hello'"
+        assert column_details["dt"]["default"] == "datetime('now')"
+
+
+@pytest.mark.skipif(
+    sqlite_version() < (3, 31, 0),
+    reason="generated columns were added in SQLite 3.31.0",
+)
+def test_column_details_extra_generated_columns():
+    with make_app_client(extra_databases={"generated.db": """
+                CREATE TABLE generated_columns (
+                    body TEXT,
+                    body_length_virtual INTEGER
+                        GENERATED ALWAYS AS (length(body)) VIRTUAL,
+                    body_length_stored INTEGER
+                        GENERATED ALWAYS AS (length(body)) STORED
+                );
+            """}) as client:
+        response = client.get(
+            "/generated/generated_columns.json?_size=0&_extra=column_details"
+        )
+        assert response.status == 200
+        column_details = response.json["column_details"]
+        assert column_details["body"]["hidden"] == 0
+        assert column_details["body_length_virtual"]["hidden"] == 2
+        assert column_details["body_length_stored"]["hidden"] == 3
+
 
 @pytest.mark.asyncio
 @pytest.mark.parametrize(

From 19dde1c8604750a7613e2aa8e9500215dcb7ebb5 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 16:09:27 -0700
Subject: [PATCH 318/386] Support BLOB values in row edit UI

---
 datasette/static/app.css       | 112 ++++++++
 datasette/static/edit-tools.js | 475 ++++++++++++++++++++++++++++++++-
 datasette/utils/__init__.py    |  18 +-
 docs/binary_data.rst           |   2 +-
 docs/changelog.rst             |   2 +
 tests/test_playwright.py       | 165 ++++++++++++
 tests/test_utils.py            |   6 +-
 7 files changed, 754 insertions(+), 26 deletions(-)

diff --git a/datasette/static/app.css b/datasette/static/app.css
index ce800f61..5bfd0aca 100644
--- a/datasette/static/app.css
+++ b/datasette/static/app.css
@@ -1700,6 +1700,118 @@ textarea.row-edit-input {
     background: var(--paper);
 }
 
+.row-edit-binary-control {
+    display: grid;
+    gap: 8px;
+    box-sizing: border-box;
+    width: 100%;
+    min-width: 0;
+    border: 1px solid var(--rule);
+    border-radius: 5px;
+    padding: 10px;
+    background: #fff;
+}
+
+.row-edit-binary-control:focus {
+    border-color: var(--accent);
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+}
+
+.row-edit-binary-preview[hidden] {
+    display: none;
+}
+
+.row-edit-binary-preview img {
+    display: block;
+    max-width: min(240px, 100%);
+    max-height: 180px;
+    border: 1px solid var(--rule);
+    border-radius: 4px;
+    background: var(--paper);
+}
+
+.row-edit-binary-status {
+    display: flex;
+    flex-wrap: wrap;
+    align-items: baseline;
+    gap: 8px;
+    min-width: 0;
+}
+
+.row-edit-binary-size {
+    font-family: ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
+    font-size: 0.86rem;
+}
+
+.row-edit-binary-name {
+    color: var(--muted);
+    font-size: 0.82rem;
+    overflow-wrap: anywhere;
+}
+
+.row-edit-binary-name[hidden] {
+    display: none;
+}
+
+.row-edit-binary-actions {
+    display: flex;
+    flex-wrap: wrap;
+    gap: 8px;
+}
+
+.row-edit-binary-file-button,
+.row-edit-binary-clear {
+    appearance: none;
+    border: 1px solid var(--rule);
+    border-radius: 4px;
+    background: #fff;
+    color: var(--accent);
+    cursor: pointer;
+    font: inherit;
+    font-size: 0.78rem;
+    line-height: 1.2;
+    padding: 6px 8px;
+}
+
+.row-edit-binary-file-button:hover,
+.row-edit-binary-file-button:focus-within,
+.row-edit-binary-clear:hover,
+.row-edit-binary-clear:focus {
+    background: #f8fafc;
+}
+
+.row-edit-binary-file-button:focus-within,
+.row-edit-binary-clear:focus {
+    outline: 3px solid rgba(26, 86, 219, 0.12);
+    outline-offset: 1px;
+}
+
+.row-edit-binary-file-button input[type="file"] {
+    position: absolute;
+    width: 1px;
+    height: 1px;
+    opacity: 0;
+    overflow: hidden;
+}
+
+.row-edit-binary-clear[hidden] {
+    display: none;
+}
+
+.row-edit-binary-drop-target {
+    border: 1px dashed var(--rule);
+    border-radius: 4px;
+    padding: 7px 8px;
+    color: var(--muted);
+    font-size: 0.78rem;
+}
+
+.row-edit-binary-dragover .row-edit-binary-drop-target {
+    border-color: var(--accent);
+    background: var(--paper);
+    color: var(--ink);
+}
+
 .row-edit-default {
     display: grid;
     grid-template-columns: minmax(0, 1fr) 7.25rem;
diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 9f4f89b9..b2891b5f 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -2,6 +2,7 @@ var ROW_DELETE_DIALOG_ID = "row-delete-dialog";
 var rowDeleteDialogState = null;
 var ROW_EDIT_DIALOG_ID = "row-edit-dialog";
 var rowEditDialogState = null;
+var ROW_EDIT_BINARY_IMAGE_PREVIEW_MAX_BYTES = 10 * 1024 * 1024;
 var TABLE_CREATE_DIALOG_ID = "table-create-dialog";
 var tableCreateDialogState = null;
 var TABLE_ALTER_DIALOG_ID = "table-alter-dialog";
@@ -3598,7 +3599,7 @@ function rowJsonUrl(row) {
     return "";
   }
   url.pathname = url.pathname + ".json";
-  url.searchParams.set("_extra", "columns,column_types");
+  url.searchParams.set("_extra", "columns,column_types,column_details");
   return url.toString();
 }
 
@@ -3878,10 +3879,155 @@ function initRowDeleteActions(manager) {
   });
 }
 
+function isBase64JsonValue(value) {
+  if (!value || typeof value !== "object" || Array.isArray(value)) {
+    return false;
+  }
+  var keys = Object.keys(value);
+  return (
+    keys.length === 2 &&
+    Object.prototype.hasOwnProperty.call(value, "$base64") &&
+    Object.prototype.hasOwnProperty.call(value, "encoded") &&
+    value.$base64 === true &&
+    typeof value.encoded === "string"
+  );
+}
+
+function shouldUseBinaryControl(value, options) {
+  options = options || {};
+  var sqliteType = (options.sqliteType || "").toLowerCase();
+  return (
+    isBase64JsonValue(value) ||
+    sqliteType === "blob" ||
+    options.valueKind === "binary"
+  );
+}
+
+function binaryEncodedValue(value) {
+  return isBase64JsonValue(value) ? value.encoded : "";
+}
+
+function binaryByteLengthFromBase64(encoded) {
+  encoded = (encoded || "").replace(/\s/g, "");
+  if (!encoded) {
+    return 0;
+  }
+  var padding = 0;
+  if (encoded.slice(-2) === "==") {
+    padding = 2;
+  } else if (encoded.slice(-1) === "=") {
+    padding = 1;
+  }
+  return Math.max(0, Math.floor((encoded.length * 3) / 4) - padding);
+}
+
+function rowEditBinaryValue(encoded) {
+  return {
+    $base64: true,
+    encoded: encoded || "",
+  };
+}
+
+function formatRowEditBinarySize(byteLength) {
+  var number = byteLength.toLocaleString();
+  return "Binary: " + number + " byte" + (byteLength === 1 ? "" : "s");
+}
+
+function base64ToUint8Array(encoded) {
+  var binary = window.atob(encoded || "");
+  var bytes = new Uint8Array(binary.length);
+  for (var i = 0; i < binary.length; i += 1) {
+    bytes[i] = binary.charCodeAt(i);
+  }
+  return bytes;
+}
+
+function uint8ArrayToBase64(bytes) {
+  var chunks = [];
+  var chunkSize = 0x8000;
+  for (var i = 0; i < bytes.length; i += chunkSize) {
+    chunks.push(
+      String.fromCharCode.apply(null, bytes.subarray(i, i + chunkSize)),
+    );
+  }
+  return window.btoa(chunks.join(""));
+}
+
+function rowEditBinaryImageMimeType(bytes) {
+  if (!bytes || !bytes.length) {
+    return null;
+  }
+  if (
+    bytes.length >= 8 &&
+    bytes[0] === 0x89 &&
+    bytes[1] === 0x50 &&
+    bytes[2] === 0x4e &&
+    bytes[3] === 0x47 &&
+    bytes[4] === 0x0d &&
+    bytes[5] === 0x0a &&
+    bytes[6] === 0x1a &&
+    bytes[7] === 0x0a
+  ) {
+    return "image/png";
+  }
+  if (
+    bytes.length >= 3 &&
+    bytes[0] === 0xff &&
+    bytes[1] === 0xd8 &&
+    bytes[2] === 0xff
+  ) {
+    return "image/jpeg";
+  }
+  if (
+    bytes.length >= 6 &&
+    bytes[0] === 0x47 &&
+    bytes[1] === 0x49 &&
+    bytes[2] === 0x46 &&
+    bytes[3] === 0x38 &&
+    (bytes[4] === 0x37 || bytes[4] === 0x39) &&
+    bytes[5] === 0x61
+  ) {
+    return "image/gif";
+  }
+  if (
+    bytes.length >= 12 &&
+    bytes[0] === 0x52 &&
+    bytes[1] === 0x49 &&
+    bytes[2] === 0x46 &&
+    bytes[3] === 0x46 &&
+    bytes[8] === 0x57 &&
+    bytes[9] === 0x45 &&
+    bytes[10] === 0x42 &&
+    bytes[11] === 0x50
+  ) {
+    return "image/webp";
+  }
+  if (
+    bytes.length >= 12 &&
+    bytes[4] === 0x66 &&
+    bytes[5] === 0x74 &&
+    bytes[6] === 0x79 &&
+    bytes[7] === 0x70 &&
+    bytes[8] === 0x61 &&
+    bytes[9] === 0x76 &&
+    bytes[10] === 0x69 &&
+    (bytes[11] === 0x66 || bytes[11] === 0x73)
+  ) {
+    return "image/avif";
+  }
+  if (bytes.length >= 2 && bytes[0] === 0x42 && bytes[1] === 0x4d) {
+    return "image/bmp";
+  }
+  return null;
+}
+
 function valueToEditText(value) {
   if (value === null || typeof value === "undefined") {
     return "";
   }
+  if (isBase64JsonValue(value)) {
+    return value.encoded;
+  }
   if (typeof value === "object") {
     return JSON.stringify(value, null, 2);
   }
@@ -3892,6 +4038,9 @@ function shouldUseTextarea(value, columnType) {
   if (columnType && columnType.type === "textarea") {
     return true;
   }
+  if (isBase64JsonValue(value)) {
+    return false;
+  }
   if (value && typeof value === "object") {
     return true;
   }
@@ -3900,6 +4049,9 @@ function shouldUseTextarea(value, columnType) {
 }
 
 function rowEditValueKind(value) {
+  if (isBase64JsonValue(value)) {
+    return "binary";
+  }
   if (value === null || typeof value === "undefined") {
     return "null";
   }
@@ -3923,6 +4075,263 @@ function rowEditControlElement(control, autocompleteUrl) {
   return autocomplete;
 }
 
+function revokeRowEditBinaryPreview(wrapper) {
+  if (wrapper && wrapper._rowEditBinaryPreviewUrl) {
+    URL.revokeObjectURL(wrapper._rowEditBinaryPreviewUrl);
+    wrapper._rowEditBinaryPreviewUrl = null;
+  }
+}
+
+function updateRowEditBinaryPreview(wrapper, encoded, byteLength) {
+  var preview = wrapper.querySelector(".row-edit-binary-preview");
+  if (!preview) {
+    return;
+  }
+  revokeRowEditBinaryPreview(wrapper);
+  preview.hidden = true;
+  preview.textContent = "";
+  if (
+    !encoded ||
+    byteLength >= ROW_EDIT_BINARY_IMAGE_PREVIEW_MAX_BYTES ||
+    !window.atob ||
+    !window.Blob ||
+    !window.URL ||
+    !URL.createObjectURL
+  ) {
+    return;
+  }
+
+  var bytes;
+  try {
+    bytes = base64ToUint8Array(encoded);
+  } catch (_error) {
+    return;
+  }
+  var mimeType = rowEditBinaryImageMimeType(bytes);
+  if (!mimeType) {
+    return;
+  }
+
+  var image = document.createElement("img");
+  image.alt = "";
+  var objectUrl = URL.createObjectURL(new Blob([bytes], { type: mimeType }));
+  wrapper._rowEditBinaryPreviewUrl = objectUrl;
+  image.src = objectUrl;
+  preview.appendChild(image);
+
+  var showPreview = function () {
+    if (wrapper._rowEditBinaryPreviewUrl === objectUrl) {
+      preview.hidden = false;
+    }
+  };
+  var hidePreview = function () {
+    if (wrapper._rowEditBinaryPreviewUrl === objectUrl) {
+      revokeRowEditBinaryPreview(wrapper);
+      preview.hidden = true;
+      preview.textContent = "";
+    }
+  };
+  if (image.decode) {
+    image.decode().then(showPreview).catch(hidePreview);
+  } else {
+    image.onload = showPreview;
+    image.onerror = hidePreview;
+  }
+}
+
+function updateRowEditBinaryDisplay(wrapper, control, fileName) {
+  var kind = rowEditControlValueKind(control);
+  var size = wrapper.querySelector(".row-edit-binary-size");
+  var name = wrapper.querySelector(".row-edit-binary-name");
+  var clear = wrapper.querySelector(".row-edit-binary-clear");
+  var byteLength =
+    kind === "binary" ? binaryByteLengthFromBase64(control.value) : null;
+
+  if (size) {
+    size.textContent =
+      kind === "binary" ? formatRowEditBinarySize(byteLength) : "No binary data";
+  }
+  if (name) {
+    name.textContent = fileName || "";
+    name.hidden = !fileName;
+  }
+  if (clear) {
+    clear.hidden = control.dataset.notNull === "1" || kind !== "binary";
+  }
+  if (kind === "binary") {
+    updateRowEditBinaryPreview(wrapper, control.value, byteLength);
+  } else {
+    updateRowEditBinaryPreview(wrapper, "", 0);
+  }
+}
+
+function setRowEditBinaryControlValue(control, encoded, fileName) {
+  control.value = encoded || "";
+  control.dataset.currentValueKind = "binary";
+  updateRowEditBinaryDisplay(control._rowEditBinaryWrapper, control, fileName);
+  control.dispatchEvent(new Event("input", { bubbles: true }));
+}
+
+function clearRowEditBinaryControlValue(control) {
+  control.value = "";
+  control.dataset.currentValueKind = "null";
+  updateRowEditBinaryDisplay(control._rowEditBinaryWrapper, control, "");
+  control.dispatchEvent(new Event("input", { bubbles: true }));
+}
+
+function readRowEditBinaryFile(file) {
+  return new Promise(function (resolve, reject) {
+    var reader = new FileReader();
+    reader.onload = function () {
+      try {
+        var bytes = new Uint8Array(reader.result || new ArrayBuffer(0));
+        resolve({
+          encoded: uint8ArrayToBase64(bytes),
+          name: file && file.name ? file.name : "",
+        });
+      } catch (error) {
+        reject(error);
+      }
+    };
+    reader.onerror = function () {
+      reject(reader.error || new Error("Could not read file"));
+    };
+    reader.readAsArrayBuffer(file);
+  });
+}
+
+function rowEditBinaryValueFromText(text) {
+  var encoder = new TextEncoder();
+  var bytes = encoder.encode(text || "");
+  return {
+    encoded: uint8ArrayToBase64(bytes),
+    name: "Pasted text",
+  };
+}
+
+function rowEditBinaryFirstClipboardFile(clipboardData) {
+  if (!clipboardData) {
+    return null;
+  }
+  if (clipboardData.files && clipboardData.files.length) {
+    return clipboardData.files[0];
+  }
+  var items = clipboardData.items || [];
+  for (var i = 0; i < items.length; i += 1) {
+    if (items[i].kind === "file") {
+      return items[i].getAsFile();
+    }
+  }
+  return null;
+}
+
+function handleRowEditBinaryFile(control, file) {
+  if (!file) {
+    return;
+  }
+  readRowEditBinaryFile(file)
+    .then(function (value) {
+      setRowEditBinaryControlValue(control, value.encoded, value.name);
+    })
+    .catch(function (error) {
+      console.error("Could not read binary file", error);
+    });
+}
+
+function createRowEditBinaryControlElement(control, value, options, labelId) {
+  var wrapper = document.createElement("div");
+  wrapper.className = "row-edit-binary-control";
+  wrapper.dataset.column = control.name;
+  wrapper.setAttribute("role", "group");
+  wrapper.setAttribute("tabindex", "0");
+  wrapper.setAttribute("aria-labelledby", labelId);
+
+  var preview = document.createElement("div");
+  preview.className = "row-edit-binary-preview";
+  preview.hidden = true;
+
+  var status = document.createElement("div");
+  status.className = "row-edit-binary-status";
+  var size = document.createElement("span");
+  size.className = "row-edit-binary-size";
+  var name = document.createElement("span");
+  name.className = "row-edit-binary-name";
+  name.hidden = true;
+  status.appendChild(size);
+  status.appendChild(name);
+
+  var actions = document.createElement("div");
+  actions.className = "row-edit-binary-actions";
+  var fileLabel = document.createElement("label");
+  fileLabel.className = "row-edit-binary-file-button";
+  fileLabel.textContent = "Attach file";
+  var fileInput = document.createElement("input");
+  fileInput.type = "file";
+  fileInput.setAttribute("aria-label", "Attach file for " + control.name);
+  fileInput.addEventListener("change", function () {
+    if (fileInput.files && fileInput.files.length) {
+      handleRowEditBinaryFile(control, fileInput.files[0]);
+    }
+  });
+  fileLabel.appendChild(fileInput);
+  actions.appendChild(fileLabel);
+
+  var clearButton = document.createElement("button");
+  clearButton.type = "button";
+  clearButton.className = "row-edit-binary-clear";
+  clearButton.textContent = "Set NULL";
+  clearButton.addEventListener("click", function () {
+    clearRowEditBinaryControlValue(control);
+    wrapper.focus();
+  });
+  actions.appendChild(clearButton);
+
+  var dropTarget = document.createElement("div");
+  dropTarget.className = "row-edit-binary-drop-target";
+  dropTarget.textContent = "Drop or paste file contents";
+  ["dragenter", "dragover"].forEach(function (eventName) {
+    wrapper.addEventListener(eventName, function (ev) {
+      ev.preventDefault();
+      wrapper.classList.add("row-edit-binary-dragover");
+    });
+  });
+  ["dragleave", "drop"].forEach(function (eventName) {
+    wrapper.addEventListener(eventName, function () {
+      wrapper.classList.remove("row-edit-binary-dragover");
+    });
+  });
+  wrapper.addEventListener("drop", function (ev) {
+    ev.preventDefault();
+    var file = ev.dataTransfer && ev.dataTransfer.files[0];
+    handleRowEditBinaryFile(control, file);
+  });
+  wrapper.addEventListener("paste", function (ev) {
+    var file = rowEditBinaryFirstClipboardFile(ev.clipboardData);
+    if (file) {
+      ev.preventDefault();
+      handleRowEditBinaryFile(control, file);
+      return;
+    }
+    var text = ev.clipboardData && ev.clipboardData.getData("text");
+    if (text) {
+      ev.preventDefault();
+      var pasted = rowEditBinaryValueFromText(text);
+      setRowEditBinaryControlValue(control, pasted.encoded, pasted.name);
+    }
+  });
+
+  control.type = "hidden";
+  control._rowEditBinaryWrapper = wrapper;
+  wrapper.appendChild(control);
+  wrapper.appendChild(preview);
+  wrapper.appendChild(status);
+  wrapper.appendChild(actions);
+  wrapper.appendChild(dropTarget);
+
+  updateRowEditBinaryDisplay(wrapper, control, "");
+  return wrapper;
+}
+
 function columnTypeForContext(columnType) {
   if (!columnType) {
     return null;
@@ -4186,6 +4595,11 @@ function focusFirstRowEditControl(state, options) {
     if (focusRowEditPluginControl(field)) {
       return true;
     }
+    var binaryControl = field.querySelector(".row-edit-binary-control");
+    if (binaryControl) {
+      binaryControl.focus();
+      return true;
+    }
     control.focus();
     return true;
   }
@@ -4209,6 +4623,11 @@ function destroyRowEditFields(state) {
         }
       }
     });
+  state.fields
+    .querySelectorAll(".row-edit-binary-control")
+    .forEach(function (binaryControl) {
+      revokeRowEditBinaryPreview(binaryControl);
+    });
   state.fields.innerHTML = "";
 }
 
@@ -4235,34 +4654,50 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   controlWrap.className = "row-edit-control-wrap";
 
   var context = columnFormControlContext(column, isPk, columnType, options);
-  var pluginControl = makeColumnField(options.manager, context);
+  var isBinaryField = shouldUseBinaryControl(value, options);
+  var pluginControl = isBinaryField
+    ? null
+    : makeColumnField(options.manager, context);
   var useTextarea =
-    (pluginControl && pluginControl.useTextarea === true) ||
-    shouldUseTextarea(value, columnType);
+    !isBinaryField &&
+    ((pluginControl && pluginControl.useTextarea === true) ||
+      shouldUseTextarea(value, columnType));
   var control = useTextarea
     ? document.createElement("textarea")
     : document.createElement("input");
+  var initialValue = isBinaryField
+    ? binaryEncodedValue(value)
+    : valueToEditText(value);
+  var initialValueKind = options.valueKind || rowEditValueKind(value);
+  if (isBinaryField) {
+    initialValueKind = isBase64JsonValue(value) ? "binary" : "null";
+  }
   control.className = "row-edit-input";
   control.id = fieldId;
   control.name = column;
-  control.value = valueToEditText(value);
+  control.value = initialValue;
   control.setAttribute("aria-describedby", metaId);
-  control.dataset.initialValue = valueToEditText(value);
-  control.dataset.initialValueKind =
-    options.valueKind || rowEditValueKind(value);
+  control.dataset.initialValue = initialValue;
+  control.dataset.initialValueKind = initialValueKind;
   control.dataset.primaryKey = isPk ? "1" : "0";
   control.dataset.currentValueKind = control.dataset.initialValueKind;
+  if (isBinaryField) {
+    control.dataset.binaryField = "1";
+    control.dataset.notNull = options.notnull ? "1" : "0";
+  }
   if (hasDefaultExpression) {
     control.dataset.useSqliteDefault = useSqliteDefault ? "1" : "0";
   }
   if (useSqliteDefault) {
     control.disabled = true;
   }
-  if (options.omitIfBlank) {
+  if (options.omitIfBlank || (isBinaryField && options.mode === "insert")) {
     control.dataset.omitIfBlank = "1";
   }
 
-  if (control.nodeName === "TEXTAREA") {
+  if (isBinaryField) {
+    control.type = "hidden";
+  } else if (control.nodeName === "TEXTAREA") {
     control.rows = Math.min(8, Math.max(3, control.value.split("\n").length));
   } else {
     control.type = "text";
@@ -4336,9 +4771,11 @@ function createRowEditField(column, value, isPk, columnType, index, options) {
   field._datasetteColumnFormField = fieldApi;
   var pluginControlElement = renderColumnField(pluginControl, fieldApi);
   var controlElement =
+    (isBinaryField &&
+      createRowEditBinaryControlElement(control, value, options, labelId)) ||
     pluginControlElement ||
     rowEditControlElement(control, options.autocompleteUrl);
-  if (options.autocompleteUrl && !pluginControlElement) {
+  if (options.autocompleteUrl && !pluginControlElement && !isBinaryField) {
     control.addEventListener("input", function () {
       setForeignKeyMetaLink(meta, options.autocompleteUrl, null);
     });
@@ -4460,6 +4897,9 @@ function setRowEditDialogSaving(state, isSaving) {
 
 function valueFromRowEditControl(control) {
   var value = control.value;
+  if (rowEditControlValueKind(control) === "binary") {
+    return rowEditBinaryValue(value);
+  }
   return valueFromRowEditText(
     control.name,
     value,
@@ -4470,6 +4910,9 @@ function valueFromRowEditControl(control) {
 function valueFromRowEditText(name, value, initialValueKind) {
   var trimmed = value.trim();
 
+  if (initialValueKind === "binary") {
+    return rowEditBinaryValue(value);
+  }
   if (initialValueKind === "null" && value === "") {
     return null;
   }
@@ -4597,7 +5040,11 @@ function collectRowFormValues(state) {
     if (control.dataset.useSqliteDefault === "1") {
       return;
     }
-    if (control.dataset.omitIfBlank === "1" && control.value === "") {
+    if (
+      control.dataset.omitIfBlank === "1" &&
+      control.value === "" &&
+      rowEditControlValueKind(control) !== "binary"
+    ) {
       return;
     }
     if (
@@ -4919,9 +5366,11 @@ function renderRowEditFields(state, data) {
   var columns = data.columns || (row ? Object.keys(row) : []);
   var primaryKeys = data.primary_keys || [];
   var columnTypes = data.column_types || {};
+  var columnDetails = data.column_details || {};
 
   destroyRowEditFields(state);
   columns.forEach(function (column, index) {
+    var columnDetail = columnDetails[column] || {};
     state.fields.appendChild(
       createRowEditField(
         column,
@@ -4935,7 +5384,9 @@ function renderRowEditFields(state, data) {
           form: state.form,
           manager: state.manager,
           mode: state.mode,
+          notnull: columnDetail.notnull,
           primaryKeyReadonly: true,
+          sqliteType: columnDetail.sqlite_type,
         },
       ),
     );
diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 468828c5..dfd5440c 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -237,10 +237,8 @@ class CustomJSONEncoder(json.JSONEncoder):
     - ``sqlite3.Row`` becomes a tuple
     - ``sqlite3.Cursor`` becomes a list
 
-    If a binary blob can be decoded as UTF-8, the encoder returns it as text.
-
-    If it can't (for example, images), it is encoded as an object, with the actual
-    data base64-encoded, like so: ::
+    Binary blobs are encoded as an object, with the actual data base64-encoded,
+    like so: ::
 
         {
             "$base64": True,
@@ -256,14 +254,10 @@ class CustomJSONEncoder(json.JSONEncoder):
         if isinstance(obj, sqlite3.Cursor):
             return list(obj)
         if isinstance(obj, bytes):
-            # Does it encode to utf8?
-            try:
-                return obj.decode("utf8")
-            except UnicodeDecodeError:
-                return {
-                    "$base64": True,
-                    "encoded": base64.b64encode(obj).decode("latin1"),
-                }
+            return {
+                "$base64": True,
+                "encoded": base64.b64encode(obj).decode("latin1"),
+            }
         return json.JSONEncoder.default(self, obj)
 
 
diff --git a/docs/binary_data.rst b/docs/binary_data.rst
index fc972f98..d41e36be 100644
--- a/docs/binary_data.rst
+++ b/docs/binary_data.rst
@@ -17,7 +17,7 @@ Datasette includes special handling for these binary values. The Datasette inter
 Binary values in JSON
 ---------------------
 
-Binary data is represented in ``.json`` exports using Base64 encoding.
+Binary data is represented in ``.json`` exports using Base64 encoding. Datasette uses this representation for every ``BLOB`` value, including binary values that could also be decoded as UTF-8 text.
 
 https://latest.datasette.io/fixtures/binary_data.json?_shape=array
 
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 7f3fd2c4..0cf1ec0b 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -9,6 +9,8 @@ Changelog
 1.0a36 (in development)
 -----------------------
 
+- Datasette's JSON APIs now consistently encode every ``BLOB`` value using the documented :ref:`binary value JSON format <binary_json_format>`, even when the bytes could be decoded as UTF-8 text.
+- The insert and edit row dialogs now provide a dedicated control for ``BLOB`` values. Existing binary values are shown by byte size, image values under 10MB are previewed as thumbnails, and replacements can be attached, dropped or pasted into the control.
 - The table and row JSON APIs now support ``?_extra=column_details`` for returning SQLite schema details for columns, including declared type, SQLite affinity, primary key, ``NOT NULL``, default and hidden-column metadata.
 
 .. _v1_0_a35:
diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index ee396de5..63e06b29 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -1,3 +1,4 @@
+import base64
 import json
 import socket
 import subprocess
@@ -10,6 +11,10 @@ import pytest
 from datasette.fixtures import write_fixture_database
 from datasette.utils.sqlite import sqlite3
 
+PNG_1X1_BYTES = base64.b64decode(
+    "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+/p9sAAAAASUVORK5CYII="
+)
+
 
 def find_free_port():
     with socket.socket() as sock:
@@ -102,6 +107,11 @@ def write_playwright_database(db_path):
             id integer primary key,
             created_ms integer default (CAST((julianday('now') - 2440587.5) * 86400000 AS INTEGER))
         );
+        create table binary_files (
+            id integer primary key,
+            name text not null,
+            data blob
+        );
         insert into projects (title, metadata, logo, notes, score) values
             (
                 'Build Datasette',
@@ -111,6 +121,19 @@ def write_playwright_database(db_path):
                 5
             );
         """)
+        conn.execute(
+            "insert into binary_files (name, data) values (?, ?)",
+            ("Raw bytes", b"\x00\x01\x02\x03"),
+        )
+        conn.execute(
+            "insert into binary_files (name, data) values (?, ?)",
+            ("PNG image", PNG_1X1_BYTES),
+        )
+        conn.execute(
+            "insert into binary_files (name, data) values (?, ?)",
+            ("Null bytes", None),
+        )
+        conn.commit()
     finally:
         conn.close()
 
@@ -145,6 +168,14 @@ def write_playwright_config(config_path):
                                     "alter-table": True,
                                 },
                             },
+                            "binary_files": {
+                                "label_column": "name",
+                                "permissions": {
+                                    "insert-row": True,
+                                    "update-row": True,
+                                    "delete-row": True,
+                                },
+                            },
                         },
                     },
                 },
@@ -278,6 +309,15 @@ def project_row(datasette_server, pk):
     return rows[0]
 
 
+def binary_file_blob(datasette_server, pk):
+    response = httpx.get(
+        f"{datasette_server}data/binary_files/{pk}.blob",
+        params={"_blob_column": "data"},
+    )
+    response.raise_for_status()
+    return response.content
+
+
 def open_jump_menu(page):
     page.keyboard.press("/")
     page.locator("navigation-search .search-input").wait_for()
@@ -877,6 +917,131 @@ def test_edit_row_flow_validates_json_and_saves_changes(page, datasette_server):
     assert data["notes"] == "Edited from Playwright"
 
 
+@pytest.mark.playwright
+def test_edit_row_binary_control_shows_size_and_image_preview(page, datasette_server):
+    page.goto(f"{datasette_server}data/binary_files")
+    page.locator('tr[data-row="1"] button[data-row-action="edit"]').click()
+
+    dialog = page.locator("#row-edit-dialog")
+    dialog.wait_for()
+    raw_control = dialog.locator('.row-edit-binary-control[data-column="data"]')
+    raw_control.wait_for()
+    assert (
+        raw_control.locator(".row-edit-binary-size").inner_text() == "Binary: 4 bytes"
+    )
+    assert raw_control.locator(".row-edit-binary-preview img").count() == 0
+    assert dialog.locator('textarea[name="data"]').count() == 0
+    assert dialog.locator('input[type="hidden"][name="data"]').count() == 1
+
+    dialog.locator(".row-edit-cancel").click()
+    page.locator('tr[data-row="2"] button[data-row-action="edit"]').click()
+
+    image_control = dialog.locator('.row-edit-binary-control[data-column="data"]')
+    image_control.wait_for()
+    assert (
+        image_control.locator(".row-edit-binary-size").inner_text()
+        == f"Binary: {len(PNG_1X1_BYTES)} bytes"
+    )
+    image = image_control.locator(".row-edit-binary-preview img")
+    image.wait_for()
+    assert image.get_attribute("src").startswith("blob:")
+
+
+@pytest.mark.playwright
+def test_edit_row_binary_control_replaces_blob_from_file(page, datasette_server):
+    replacement = b"Replacement \x00 bytes"
+
+    page.goto(f"{datasette_server}data/binary_files")
+    page.locator('tr[data-row="1"] button[data-row-action="edit"]').click()
+
+    dialog = page.locator("#row-edit-dialog")
+    binary_control = dialog.locator('.row-edit-binary-control[data-column="data"]')
+    binary_control.wait_for()
+    binary_control.locator('input[type="file"]').set_input_files(
+        {
+            "name": "replacement.bin",
+            "mimeType": "application/octet-stream",
+            "buffer": replacement,
+        }
+    )
+    assert (
+        binary_control.locator(".row-edit-binary-size").inner_text()
+        == f"Binary: {len(replacement)} bytes"
+    )
+    assert "replacement.bin" in binary_control.inner_text()
+
+    dialog.locator(".row-edit-save").click()
+    page.locator(".row-mutation-status", has_text="Updated row 1").wait_for()
+    assert binary_file_blob(datasette_server, 1) == replacement
+
+
+@pytest.mark.playwright
+def test_edit_row_binary_control_handles_null_blob(page, datasette_server):
+    replacement = b"From NULL"
+
+    page.goto(f"{datasette_server}data/binary_files")
+    page.locator('tr[data-row="3"] button[data-row-action="edit"]').click()
+
+    dialog = page.locator("#row-edit-dialog")
+    binary_control = dialog.locator('.row-edit-binary-control[data-column="data"]')
+    binary_control.wait_for()
+    assert (
+        binary_control.locator(".row-edit-binary-size").inner_text() == "No binary data"
+    )
+    binary_control.locator('input[type="file"]').set_input_files(
+        {
+            "name": "from-null.bin",
+            "mimeType": "application/octet-stream",
+            "buffer": replacement,
+        }
+    )
+    assert (
+        binary_control.locator(".row-edit-binary-size").inner_text()
+        == f"Binary: {len(replacement)} bytes"
+    )
+
+    dialog.locator(".row-edit-save").click()
+    page.locator(".row-mutation-status", has_text="Updated row 3").wait_for()
+    assert binary_file_blob(datasette_server, 3) == replacement
+
+
+@pytest.mark.playwright
+def test_insert_row_binary_control_accepts_pasted_file(page, datasette_server):
+    pasted = b"Pasted \x00 bytes"
+
+    page.goto(f"{datasette_server}data/binary_files")
+    page.locator('button[data-table-action="insert-row"]').click()
+
+    dialog = page.locator("#row-edit-dialog")
+    dialog.wait_for()
+    dialog.locator('input[name="name"]').fill("Pasted bytes")
+    binary_control = dialog.locator('.row-edit-binary-control[data-column="data"]')
+    binary_control.wait_for()
+    binary_control.evaluate(
+        """(node, bytes) => {
+          const transfer = new DataTransfer();
+          transfer.items.add(
+            new File([new Uint8Array(bytes)], "pasted.bin", {
+              type: "application/octet-stream"
+            })
+          );
+          const event = new Event("paste", { bubbles: true, cancelable: true });
+          Object.defineProperty(event, "clipboardData", { value: transfer });
+          node.dispatchEvent(event);
+        }""",
+        list(pasted),
+    )
+    assert (
+        binary_control.locator(".row-edit-binary-size").inner_text()
+        == f"Binary: {len(pasted)} bytes"
+    )
+    assert "pasted.bin" in binary_control.inner_text()
+
+    dialog.locator(".row-edit-save").click()
+    page.locator(".row-mutation-status", has_text="Inserted row 4").wait_for()
+    assert binary_file_blob(datasette_server, 4) == pasted
+
+
 @pytest.mark.playwright
 def test_delete_row_flow_removes_row(page, datasette_server):
     page.goto(f"{datasette_server}data/projects")
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 38ebb51e..46dcd89d 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -132,7 +132,11 @@ def test_path_from_row_pks(row, pks, expected_path):
             """
         {"CategoryID": 1, "Description": "Soft drinks", "Picture": {"$base64": true, "encoded": "FRwCx60F/g=="}}
     """.strip(),
-        )
+        ),
+        (
+            {"message": b"hello"},
+            '{"message": {"$base64": true, "encoded": "aGVsbG8="}}',
+        ),
     ],
 )
 def test_custom_json_encoder(obj, expected):

From 5f05d33ef70e8fb8bf5694ae1dab1f6c14719051 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 16:44:07 -0700
Subject: [PATCH 319/386] Run Prettier

---
 datasette/static/edit-tools.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index b2891b5f..89cf5f94 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -4149,7 +4149,9 @@ function updateRowEditBinaryDisplay(wrapper, control, fileName) {
 
   if (size) {
     size.textContent =
-      kind === "binary" ? formatRowEditBinarySize(byteLength) : "No binary data";
+      kind === "binary"
+        ? formatRowEditBinarySize(byteLength)
+        : "No binary data";
   }
   if (name) {
     name.textContent = fileName || "";

From 81d6ee69cd558de3ba589583a11a27ad25f9ea1b Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 17:12:26 -0700
Subject: [PATCH 320/386] Allow declared column type case to vary

---
 tests/test_api.py       | 32 +++++++++++----------
 tests/test_table_api.py | 61 +++++++++++++++++++++--------------------
 2 files changed, 50 insertions(+), 43 deletions(-)

diff --git a/tests/test_api.py b/tests/test_api.py
index ee3329e1..d99c3341 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -446,8 +446,10 @@ async def test_row_extras(ds_client):
         "format": "json",
     }
     assert len(data["foreign_key_tables"]) == 5
-    assert data["column_details"]["id"] == {
-        "type": "INTEGER",
+    id_detail = data["column_details"]["id"]
+    assert id_detail["type"].lower() == "integer"
+    assert id_detail == {
+        "type": id_detail["type"],
         "sqlite_type": "INTEGER",
         "notnull": False,
         "default": None,
@@ -455,8 +457,10 @@ async def test_row_extras(ds_client):
         "pk_position": 1,
         "hidden": 0,
     }
-    assert data["column_details"]["content"] == {
-        "type": "TEXT",
+    content_detail = data["column_details"]["content"]
+    assert content_detail["type"].lower() == "text"
+    assert content_detail == {
+        "type": content_detail["type"],
         "sqlite_type": "TEXT",
         "notnull": False,
         "default": None,
@@ -470,16 +474,16 @@ async def test_row_extras(ds_client):
 async def test_column_details_extra_row_for_null_blob(ds_client):
     response = await ds_client.get("/fixtures/binary_data/3.json?_extra=column_details")
     assert response.status_code == 200
-    assert response.json()["column_details"] == {
-        "data": {
-            "type": "BLOB",
-            "sqlite_type": "BLOB",
-            "notnull": False,
-            "default": None,
-            "is_pk": False,
-            "pk_position": 0,
-            "hidden": 0,
-        }
+    data_detail = response.json()["column_details"]["data"]
+    assert data_detail["type"].lower() == "blob"
+    assert data_detail == {
+        "type": data_detail["type"],
+        "sqlite_type": "BLOB",
+        "notnull": False,
+        "default": None,
+        "is_pk": False,
+        "pk_position": 0,
+        "hidden": 0,
     }
 
 
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 067a8bab..005a4680 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -1342,41 +1342,44 @@ async def test_column_details_extra_table(ds_client):
         "/fixtures/binary_data.json?_size=0&_extra=column_details"
     )
     assert response.status_code == 200
-    assert response.json()["column_details"] == {
-        "data": {
-            "type": "BLOB",
-            "sqlite_type": "BLOB",
-            "notnull": False,
-            "default": None,
-            "is_pk": False,
-            "pk_position": 0,
-            "hidden": 0,
-        }
+    data_detail = response.json()["column_details"]["data"]
+    assert data_detail["type"].lower() == "blob"
+    assert data_detail == {
+        "type": data_detail["type"],
+        "sqlite_type": "BLOB",
+        "notnull": False,
+        "default": None,
+        "is_pk": False,
+        "pk_position": 0,
+        "hidden": 0,
     }
 
     response = await ds_client.get(
         "/fixtures/simple_primary_key.json?_size=0&_extra=column_details"
     )
     assert response.status_code == 200
-    assert response.json()["column_details"] == {
-        "id": {
-            "type": "INTEGER",
-            "sqlite_type": "INTEGER",
-            "notnull": False,
-            "default": None,
-            "is_pk": True,
-            "pk_position": 1,
-            "hidden": 0,
-        },
-        "content": {
-            "type": "TEXT",
-            "sqlite_type": "TEXT",
-            "notnull": False,
-            "default": None,
-            "is_pk": False,
-            "pk_position": 0,
-            "hidden": 0,
-        },
+    column_details = response.json()["column_details"]
+    id_detail = column_details["id"]
+    assert id_detail["type"].lower() == "integer"
+    assert id_detail == {
+        "type": id_detail["type"],
+        "sqlite_type": "INTEGER",
+        "notnull": False,
+        "default": None,
+        "is_pk": True,
+        "pk_position": 1,
+        "hidden": 0,
+    }
+    content_detail = column_details["content"]
+    assert content_detail["type"].lower() == "text"
+    assert content_detail == {
+        "type": content_detail["type"],
+        "sqlite_type": "TEXT",
+        "notnull": False,
+        "default": None,
+        "is_pk": False,
+        "pk_position": 0,
+        "hidden": 0,
     }
 
     response = await ds_client.get(

From ae26c3372aa550aee515db831ca8d3771902473f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 17:19:13 -0700
Subject: [PATCH 321/386] Use image load events for BLOB previews

---
 datasette/static/edit-tools.js | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/datasette/static/edit-tools.js b/datasette/static/edit-tools.js
index 89cf5f94..2aa9adcf 100644
--- a/datasette/static/edit-tools.js
+++ b/datasette/static/edit-tools.js
@@ -4116,8 +4116,6 @@ function updateRowEditBinaryPreview(wrapper, encoded, byteLength) {
   image.alt = "";
   var objectUrl = URL.createObjectURL(new Blob([bytes], { type: mimeType }));
   wrapper._rowEditBinaryPreviewUrl = objectUrl;
-  image.src = objectUrl;
-  preview.appendChild(image);
 
   var showPreview = function () {
     if (wrapper._rowEditBinaryPreviewUrl === objectUrl) {
@@ -4131,12 +4129,10 @@ function updateRowEditBinaryPreview(wrapper, encoded, byteLength) {
       preview.textContent = "";
     }
   };
-  if (image.decode) {
-    image.decode().then(showPreview).catch(hidePreview);
-  } else {
-    image.onload = showPreview;
-    image.onerror = hidePreview;
-  }
+  image.onload = showPreview;
+  image.onerror = hidePreview;
+  image.src = objectUrl;
+  preview.appendChild(image);
 }
 
 function updateRowEditBinaryDisplay(wrapper, control, fileName) {

From 58c07cc26439ebc1042083e6eaf3525c52d4f08a Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 3 Jul 2026 17:42:39 -0700
Subject: [PATCH 322/386] max_post_body_bytes setting, enforced for
 reuest.post_body()

Closes #2823
---
 datasette/__init__.py                 |  8 ++-
 datasette/app.py                      | 11 ++-
 datasette/utils/asgi.py               | 50 ++++++++++++--
 datasette/views/row.py                |  4 +-
 datasette/views/table.py              | 22 ++++--
 datasette/views/table_create_alter.py |  6 +-
 docs/changelog.rst                    |  1 +
 docs/cli-reference.rst                |  3 +
 docs/internals.rst                    |  7 +-
 docs/settings.rst                     | 17 +++++
 tests/test_api.py                     |  1 +
 tests/test_api_write.py               | 29 ++++++++
 tests/test_internals_request.py       | 96 ++++++++++++++++++++++++++-
 13 files changed, 240 insertions(+), 15 deletions(-)

diff --git a/datasette/__init__.py b/datasette/__init__.py
index eb18e59e..4c96a148 100644
--- a/datasette/__init__.py
+++ b/datasette/__init__.py
@@ -2,7 +2,13 @@ from datasette.permissions import Permission  # noqa
 from datasette.version import __version_info__, __version__  # noqa
 from datasette.events import Event  # noqa
 from datasette.tokens import TokenHandler, TokenRestrictions  # noqa
-from datasette.utils.asgi import Forbidden, NotFound, Request, Response  # noqa
+from datasette.utils.asgi import (  # noqa
+    Forbidden,
+    NotFound,
+    PayloadTooLarge,
+    Request,
+    Response,
+)
 from datasette.utils import actor_matches_allow  # noqa
 from datasette.views import Context  # noqa
 from .hookspecs import hookimpl  # noqa
diff --git a/datasette/app.py b/datasette/app.py
index 9c9b7de4..2bcd50f6 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -206,6 +206,11 @@ SETTINGS = (
         100,
         "Maximum rows that can be inserted at a time using the bulk insert API",
     ),
+    Setting(
+        "max_post_body_bytes",
+        2 * 1024 * 1024,
+        "Maximum size in bytes for a POST body read into memory, e.g. JSON API requests - set 0 to disable this limit",
+    ),
     Setting(
         "num_sql_threads",
         3,
@@ -2847,7 +2852,11 @@ class DatasetteRouter:
         if base_url != "/" and path.startswith(base_url):
             path = "/" + path[len(base_url) :]
             scope = dict(scope, route_path=path)
-        request = Request(scope, receive)
+        request = Request(
+            scope,
+            receive,
+            max_post_body_bytes=self.ds.setting("max_post_body_bytes"),
+        )
         # Populate request_messages if ds_messages cookie is present
         try:
             request._messages = self.ds.unsign(
diff --git a/datasette/utils/asgi.py b/datasette/utils/asgi.py
index e1631b10..7777308f 100644
--- a/datasette/utils/asgi.py
+++ b/datasette/utils/asgi.py
@@ -67,13 +67,25 @@ class BadRequest(Base400):
     status = 400
 
 
+class PayloadTooLarge(Base400):
+    status = 413
+
+
 SAMESITE_VALUES = ("strict", "lax", "none")
 
+# Bodies read fully into memory (post_body/post_vars/json) are capped at this
+# size unless the max_post_body_bytes setting says otherwise. Kept deliberately
+# far below multipart's DEFAULT_MAX_REQUEST_SIZE: that parser streams to disk,
+# while these bodies are held in RAM and json.loads() can multiply their
+# footprint several times over.
+DEFAULT_MAX_POST_BODY_BYTES = 2 * 1024 * 1024  # 2MB
+
 
 class Request:
-    def __init__(self, scope, receive):
+    def __init__(self, scope, receive, max_post_body_bytes=DEFAULT_MAX_POST_BODY_BYTES):
         self.scope = scope
         self.receive = receive
+        self.max_post_body_bytes = max_post_body_bytes
 
     def __repr__(self):
         return '<asgi.Request method="{}" url="{}">'.format(self.method, self.url)
@@ -141,15 +153,43 @@ class Request:
     def actor(self):
         return self.scope.get("actor", None)
 
-    async def post_body(self):
-        body = b""
+    async def post_body(self, max_bytes=None):
+        """
+        Read the request body fully into memory.
+
+        The body is capped at max_bytes - or self.max_post_body_bytes
+        (default 2MB, set from the max_post_body_bytes setting for requests
+        created by Datasette) if max_bytes is not provided. Pass max_bytes=0
+        to disable the limit. Raises PayloadTooLarge (HTTP 413) if exceeded -
+        oversized bodies are rejected as soon as the limit is passed, without
+        buffering the rest.
+        """
+        if max_bytes is None:
+            max_bytes = self.max_post_body_bytes
+        too_large = PayloadTooLarge(
+            "Request body exceeded maximum size of {} bytes".format(max_bytes)
+        )
+        if max_bytes:
+            # Reject early if the client declares an oversized body
+            try:
+                if int(self.headers.get("content-length", "")) > max_bytes:
+                    raise too_large
+            except ValueError:
+                # Missing or malformed - the streaming check below still applies
+                pass
+        chunks = []
+        received = 0
         more_body = True
         while more_body:
             message = await self.receive()
             assert message["type"] == "http.request", message
-            body += message.get("body", b"")
+            chunk = message.get("body", b"")
+            received += len(chunk)
+            if max_bytes and received > max_bytes:
+                raise too_large
+            chunks.append(chunk)
             more_body = message.get("more_body", False)
-        return body
+        return b"".join(chunks)
 
     async def post_vars(self):
         body = await self.post_body()
diff --git a/datasette/views/row.py b/datasette/views/row.py
index f84d3a09..5cf2c541 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -8,7 +8,7 @@ from dataclasses import dataclass, field
 import markupsafe
 import sqlite_utils
 
-from datasette.utils.asgi import NotFound, Forbidden, Response
+from datasette.utils.asgi import NotFound, Forbidden, PayloadTooLarge, Response
 from datasette.database import QueryInterrupted
 from datasette.events import UpdateRowEvent, DeleteRowEvent
 from datasette.resources import TableResource
@@ -798,6 +798,8 @@ class RowUpdateView(BaseView):
             data = await request.json()
         except json.JSONDecodeError as e:
             return _error(["Invalid JSON: {}".format(e)])
+        except PayloadTooLarge as e:
+            return _error([str(e)], 413)
 
         if not isinstance(data, dict):
             return _error(["JSON must be a dictionary"])
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 73652f05..2e698ac3 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -46,7 +46,14 @@ from datasette.utils import (
     WriteJsonValueError,
     sqlite3,
 )
-from datasette.utils.asgi import BadRequest, Forbidden, NotFound, Request, Response
+from datasette.utils.asgi import (
+    BadRequest,
+    Forbidden,
+    NotFound,
+    PayloadTooLarge,
+    Request,
+    Response,
+)
 from datasette.filters import Filters
 import sqlite_utils
 from dataclasses import dataclass, field
@@ -1070,9 +1077,12 @@ class TableInsertView(BaseView):
 
         pks = await db.primary_keys(table_name)
 
-        rows, errors, extras = await self._validate_data(
-            request, db, table_name, pks, upsert
-        )
+        try:
+            rows, errors, extras = await self._validate_data(
+                request, db, table_name, pks, upsert
+            )
+        except PayloadTooLarge as e:
+            return _error([str(e)], 413)
         if errors:
             return _error(errors, 400)
         try:
@@ -1257,6 +1267,8 @@ class TableSetColumnTypeView(BaseView):
             data = await request.json()
         except json.JSONDecodeError as e:
             return _error(["Invalid JSON: {}".format(e)], 400)
+        except PayloadTooLarge as e:
+            return _error([str(e)], 413)
 
         if not isinstance(data, dict):
             return _error(["JSON must be a dictionary"], 400)
@@ -1375,6 +1387,8 @@ class TableDropView(BaseView):
             confirm = data.get("confirm")
         except json.JSONDecodeError:
             pass
+        except PayloadTooLarge as e:
+            return _error([str(e)], 413)
 
         if not confirm:
             return Response.json(
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index 12b8e9f9..d0384184 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -26,7 +26,7 @@ from datasette.utils import (
     table_column_details,
     WriteJsonValueError,
 )
-from datasette.utils.asgi import NotFound, Response
+from datasette.utils.asgi import NotFound, PayloadTooLarge, Response
 from datasette.utils.sqlite import sqlite_hidden_table_names
 
 from .base import BaseView, _error
@@ -811,6 +811,8 @@ class TableCreateView(BaseView):
             data = await request.json()
         except json.JSONDecodeError as e:
             return _error(["Invalid JSON: {}".format(e)])
+        except PayloadTooLarge as e:
+            return _error([str(e)], 413)
 
         if not isinstance(data, dict):
             return _error(["JSON must be an object"])
@@ -1172,6 +1174,8 @@ class TableAlterView(BaseView):
             data = await request.json()
         except json.JSONDecodeError as e:
             return _error(["Invalid JSON: {}".format(e)], 400)
+        except PayloadTooLarge as e:
+            return _error([str(e)], 413)
 
         if not isinstance(data, dict):
             return _error(["JSON must be a dictionary"], 400)
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 4e8f33d8..4541981f 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -15,6 +15,7 @@ Unreleased
 - Datasette's JSON APIs now consistently encode every ``BLOB`` value using the documented :ref:`binary value JSON format <binary_json_format>`, even when the bytes could be decoded as UTF-8 text.
 - The insert and edit row dialogs now provide a dedicated control for ``BLOB`` values. Existing binary values are shown by byte size, image values under 10MB are previewed as thumbnails, and replacements can be attached, dropped or pasted into the control.
 - The table and row JSON APIs now support ``?_extra=column_details`` for returning SQLite schema details for columns, including declared type, SQLite affinity, primary key, ``NOT NULL``, default and hidden-column metadata.
+- POST bodies that Datasette reads fully into memory - such as JSON submitted to the write API - are now capped by the new :ref:`setting_max_post_body_bytes` setting, defaulting to 2MB. Oversized requests are rejected with an HTTP 413 error as soon as the limit is exceeded, protecting smaller servers from memory exhaustion. File uploads are unaffected - ``request.form()`` streams those to disk and has its own separate limits.
 
 .. _v1_0_a35:
 
diff --git a/docs/cli-reference.rst b/docs/cli-reference.rst
index 7ca88c4e..2302f742 100644
--- a/docs/cli-reference.rst
+++ b/docs/cli-reference.rst
@@ -244,6 +244,9 @@ These can be passed to ``datasette serve`` using ``datasette serve --setting nam
                                    custom query (default=1000)
       max_insert_rows              Maximum rows that can be inserted at a time using
                                    the bulk insert API (default=100)
+      max_post_body_bytes          Maximum size in bytes for a POST body read into
+                                   memory, e.g. JSON API requests - set 0 to disable
+                                   this limit (default=2097152)
       num_sql_threads              Number of threads in the thread pool for
                                    executing SQLite queries (default=3)
       sql_time_limit_ms            Time limit for a SQL query in milliseconds
diff --git a/docs/internals.rst b/docs/internals.rst
index 9f75640f..e5e7aca5 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -52,6 +52,9 @@ The request object is passed to various plugin hooks. It represents an incoming
 ``.actor`` - dictionary (str -> Any) or None
     The currently authenticated actor (see :ref:`actors <authentication_actor>`), or ``None`` if the request is unauthenticated.
 
+``.max_post_body_bytes`` - integer
+    The maximum number of bytes ``await request.post_body()`` will read into memory, or ``0`` for no limit. Set from the :ref:`setting_max_post_body_bytes` setting (default 2MB) for requests created by Datasette. Can be passed to the ``Request`` constructor as a keyword argument.
+
 The object also has the following awaitable methods:
 
 ``await request.form(files=False, ...)`` - FormData
@@ -109,9 +112,11 @@ The object also has the following awaitable methods:
 ``await request.json()`` - Any
     Returns the parsed JSON body of a request submitted by ``POST``.
 
-``await request.post_body()`` - bytes
+``await request.post_body(max_bytes=None)`` - bytes
     Returns the un-parsed body of a request submitted by ``POST`` - useful for things like incoming JSON data.
 
+    The body is read fully into memory, capped at ``request.max_post_body_bytes`` - which Datasette sets from the :ref:`setting_max_post_body_bytes` setting (default 2MB). Bodies that exceed the limit raise a ``datasette.PayloadTooLarge`` exception, which Datasette turns into an HTTP 413 error response. Pass ``max_bytes=`` to override the limit for a specific call, or ``max_bytes=0`` to disable it. ``request.post_vars()`` and ``request.json()`` read the body through this method, so the same limit applies to them.
+
 And a class method that can be used to create fake request objects for use in tests:
 
 ``fake(path_with_query_string, method="GET", scheme="http", url_vars=None)``
diff --git a/docs/settings.rst b/docs/settings.rst
index 5cd49113..9c114e4a 100644
--- a/docs/settings.rst
+++ b/docs/settings.rst
@@ -125,6 +125,23 @@ You can increase or decrease this limit like so::
 
     datasette mydatabase.db --setting max_insert_rows 1000
 
+.. _setting_max_post_body_bytes:
+
+max_post_body_bytes
+~~~~~~~~~~~~~~~~~~~
+
+Maximum size in bytes for a POST body that Datasette reads fully into memory, such as JSON submitted to the :ref:`write API <json_api_write>`. Requests with larger bodies are rejected with an HTTP 413 error. Defaults to 2,097,152 (2MB).
+
+This limit exists to protect against memory exhaustion: unlike file uploads handled by ``request.form()``, which stream to disk, these bodies are held entirely in memory and parsing them as JSON can multiply their memory footprint several times over.
+
+If you increase :ref:`setting_max_insert_rows` to support larger bulk inserts you may need to increase this limit as well::
+
+    datasette mydatabase.db --setting max_post_body_bytes 10485760
+
+Set it to 0 to disable the limit entirely::
+
+    datasette mydatabase.db --setting max_post_body_bytes 0
+
 .. _setting_num_sql_threads:
 
 num_sql_threads
diff --git a/tests/test_api.py b/tests/test_api.py
index d99c3341..17826989 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -655,6 +655,7 @@ async def test_settings_json(ds_client):
         "facet_time_limit_ms": 200,
         "max_returned_rows": 100,
         "max_insert_rows": 100,
+        "max_post_body_bytes": 2 * 1024 * 1024,
         "sql_time_limit_ms": 200,
         "allow_download": True,
         "allow_signed_tokens": True,
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 1a4a966b..1154176f 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -307,6 +307,35 @@ async def test_insert_rows(ds_write, return_rows):
         assert response.json()["rows"] == actual_rows
 
 
+@pytest.mark.asyncio
+async def test_insert_rows_post_body_too_large(tmp_path_factory):
+    db_path = str(tmp_path_factory.mktemp("dbs") / "data.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("create table docs (id integer primary key, title text)")
+    conn.close()
+    ds = Datasette([db_path], settings={"max_post_body_bytes": 100})
+    ds.root_enabled = True
+    token = write_token(ds)
+    response = await ds.client.post(
+        "/data/docs/-/insert",
+        json={"rows": [{"title": "x" * 200}]},
+        headers=_headers(token),
+    )
+    assert response.status_code == 413
+    assert response.json() == {
+        "ok": False,
+        "errors": ["Request body exceeded maximum size of 100 bytes"],
+    }
+    # A small body should still work
+    response2 = await ds.client.post(
+        "/data/docs/-/insert",
+        json={"row": {"title": "hi"}},
+        headers=_headers(token),
+    )
+    assert response2.status_code == 201
+    ds.close()
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "path,input,special_case,expected_status,expected_errors",
diff --git a/tests/test_internals_request.py b/tests/test_internals_request.py
index 9c448186..6d2dc70a 100644
--- a/tests/test_internals_request.py
+++ b/tests/test_internals_request.py
@@ -1,8 +1,38 @@
-from datasette.utils.asgi import Request
+from datasette.utils.asgi import PayloadTooLarge, Request
 import json
 import pytest
 
 
+def _post_scope(headers=None):
+    return {
+        "http_version": "1.1",
+        "method": "POST",
+        "path": "/",
+        "raw_path": b"/",
+        "query_string": b"",
+        "scheme": "http",
+        "type": "http",
+        "headers": headers or [[b"content-type", b"application/json"]],
+    }
+
+
+def _receive_chunks(chunks):
+    messages = [
+        {
+            "type": "http.request",
+            "body": chunk,
+            "more_body": i < len(chunks) - 1,
+        }
+        for i, chunk in enumerate(chunks)
+    ]
+    messages.reverse()
+
+    async def receive():
+        return messages.pop()
+
+    return receive
+
+
 @pytest.mark.asyncio
 async def test_request_post_vars():
     scope = {
@@ -106,6 +136,70 @@ async def test_request_json_invalid():
         await request.json()
 
 
+@pytest.mark.asyncio
+async def test_request_post_body_multiple_chunks():
+    request = Request(_post_scope(), _receive_chunks([b"hello ", b"world"]))
+    assert await request.post_body() == b"hello world"
+
+
+@pytest.mark.asyncio
+async def test_request_post_body_content_length_too_large():
+    # Should reject based on content-length without reading the body
+    async def receive():
+        raise AssertionError("receive() should not be called")
+
+    scope = _post_scope(
+        headers=[
+            [b"content-type", b"application/json"],
+            [b"content-length", b"101"],
+        ]
+    )
+    request = Request(scope, receive)
+    with pytest.raises(PayloadTooLarge):
+        await request.post_body(max_bytes=100)
+
+
+@pytest.mark.asyncio
+async def test_request_post_body_streaming_too_large():
+    # No content-length header - limit enforced as chunks arrive
+    chunks = [b"a" * 60, b"b" * 60, b"c" * 60]
+    request = Request(_post_scope(), _receive_chunks(chunks))
+    with pytest.raises(PayloadTooLarge):
+        await request.post_body(max_bytes=100)
+
+
+@pytest.mark.asyncio
+async def test_request_post_body_limit_from_constructor():
+    request = Request(
+        _post_scope(), _receive_chunks([b"too much data"]), max_post_body_bytes=5
+    )
+    with pytest.raises(PayloadTooLarge):
+        await request.post_body()
+
+
+@pytest.mark.asyncio
+async def test_request_post_body_limit_disabled():
+    body = b"a" * (3 * 1024 * 1024)
+    request = Request(_post_scope(), _receive_chunks([body]), max_post_body_bytes=0)
+    assert await request.post_body() == body
+
+
+@pytest.mark.asyncio
+async def test_request_post_body_default_limit():
+    # Bodies over 2MB are rejected by default
+    request = Request(_post_scope(), _receive_chunks([b"a" * (2 * 1024 * 1024 + 1)]))
+    with pytest.raises(PayloadTooLarge):
+        await request.post_body()
+
+
+@pytest.mark.asyncio
+async def test_request_json_too_large():
+    body = json.dumps({"rows": ["x" * 100]}).encode("utf-8")
+    request = Request(_post_scope(), _receive_chunks([body]), max_post_body_bytes=50)
+    with pytest.raises(PayloadTooLarge):
+        await request.json()
+
+
 def test_request_args():
     request = Request.fake("/foo?multi=1&multi=2&single=3")
     assert "1" == request.args.get("multi")

From 0679e04bd3c293dd3d0efd45aefd6ae57133f68d Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 03:12:15 +0000
Subject: [PATCH 323/386] Unify JSON error responses into one canonical shape

All JSON error responses now use a single format built by the new
datasette.utils.error_body() helper:

    {"ok": false, "error": "...", "errors": ["..."], "status": 400}

- error is all messages joined with '; ', errors is the full list,
  status always matches the HTTP status code
- The exception handler no longer emits the legacy title key in JSON
  (it is still available to the HTML error template)
- The permission debug endpoints (/-/allowed, /-/rules, /-/check,
  POST /-/permissions) no longer return bare {"error": ...} objects
- JSON renderer SQL errors keep their rows/truncated context keys but
  now include the canonical keys as well
- _shape=object misuse (queries or tables without primary keys) now
  returns HTTP 400 instead of 200 with an error body
- Method-not-allowed 405 responses use the canonical shape

Adds tests/test_error_shape.py covering all four previous shape
producers, updates affected tests, and documents the format in a new
'Error responses' section of docs/json_api.rst.

Implements section 1 of stable-api-recommendations.md.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/handle_exception.py |  41 ++++----
 datasette/renderer.py         |  14 +--
 datasette/utils/__init__.py   |  21 ++++
 datasette/views/base.py       |  11 +-
 datasette/views/special.py    |  44 ++++----
 docs/json_api.rst             |  59 +++++++++--
 existing-api.md               |  94 ++++++++---------
 stable-api-recommendations.md |  14 ++-
 tests/test_api.py             |  25 ++---
 tests/test_api_write.py       |  80 +++++++--------
 tests/test_base_view.py       |   2 +
 tests/test_column_types.py    |   4 +-
 tests/test_error_shape.py     | 185 ++++++++++++++++++++++++++++++++++
 tests/test_table_api.py       |   8 +-
 tests/test_table_html.py      |   2 +-
 15 files changed, 432 insertions(+), 172 deletions(-)
 create mode 100644 tests/test_error_shape.py

diff --git a/datasette/handle_exception.py b/datasette/handle_exception.py
index 2b311644..fc290dbc 100644
--- a/datasette/handle_exception.py
+++ b/datasette/handle_exception.py
@@ -1,5 +1,5 @@
 from datasette import hookimpl, Response
-from .utils import add_cors_headers
+from .utils import add_cors_headers, error_body
 from .utils.asgi import (
     Base400,
 )
@@ -45,6 +45,13 @@ def handle_exception(datasette, request, exception):
             message = str(exception)
             traceback.print_exc()
         templates = [f"{status}.html", "error.html"]
+        headers = {}
+        if datasette.cors:
+            add_cors_headers(headers)
+        if request.path.split("?")[0].endswith(".json"):
+            body = dict(info)
+            body.update(error_body(message, status))
+            return Response.json(body, status=status, headers=headers)
         info.update(
             {
                 "ok": False,
@@ -53,24 +60,18 @@ def handle_exception(datasette, request, exception):
                 "title": title,
             }
         )
-        headers = {}
-        if datasette.cors:
-            add_cors_headers(headers)
-        if request.path.split("?")[0].endswith(".json"):
-            return Response.json(info, status=status, headers=headers)
-        else:
-            environment = datasette.get_jinja_environment(request)
-            template = environment.select_template(templates)
-            return Response.html(
-                await template.render_async(
-                    dict(
-                        info,
-                        urls=datasette.urls,
-                        menu_links=lambda: [],
-                    )
-                ),
-                status=status,
-                headers=headers,
-            )
+        environment = datasette.get_jinja_environment(request)
+        template = environment.select_template(templates)
+        return Response.html(
+            await template.render_async(
+                dict(
+                    info,
+                    urls=datasette.urls,
+                    menu_links=lambda: [],
+                )
+            ),
+            status=status,
+            headers=headers,
+        )
 
     return inner
diff --git a/datasette/renderer.py b/datasette/renderer.py
index f40e3dbb..7c94f6ee 100644
--- a/datasette/renderer.py
+++ b/datasette/renderer.py
@@ -1,6 +1,7 @@
 import json
 from datasette.extras import extra_names_from_request
 from datasette.utils import (
+    error_body,
     value_as_boolean,
     remove_infinites,
     CustomJSONEncoder,
@@ -52,8 +53,7 @@ def json_renderer(request, args, data, error, truncated=None):
     if error:
         shape = "objects"
         status_code = 400
-        data["error"] = error
-        data["ok"] = False
+        data.update(error_body(error, status_code))
 
     if truncated is not None:
         data["truncated"] = truncated
@@ -87,7 +87,8 @@ def json_renderer(request, args, data, error, truncated=None):
                         object_rows[pk_string] = row
                     data = object_rows
             if shape_error:
-                data = {"ok": False, "error": shape_error}
+                status_code = 400
+                data = error_body(shape_error, status_code)
         elif shape == "array":
             data = data["rows"]
 
@@ -100,12 +101,7 @@ def json_renderer(request, args, data, error, truncated=None):
             data["rows"] = [list(row.values()) for row in data["rows"]]
     else:
         status_code = 400
-        data = {
-            "ok": False,
-            "error": f"Invalid _shape: {shape}",
-            "status": 400,
-            "title": None,
-        }
+        data = error_body(f"Invalid _shape: {shape}", status_code)
 
     # Don't include "columns" in output
     # https://github.com/simonw/datasette/issues/2136
diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 1caff3a8..17c8702f 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -1294,6 +1294,27 @@ async def derive_named_parameters(db: "Database", sql: str) -> List[str]:
     return named_parameters(sql)
 
 
+def error_body(messages, status):
+    """
+    The canonical JSON error body used by every Datasette JSON error response:
+
+        {"ok": False, "error": "...", "errors": ["...", ...], "status": 400}
+
+    "error" is all of the messages joined with "; ", "errors" is the full
+    list, "status" matches the HTTP status code. Callers may add extra
+    context keys to the returned dictionary but must not remove these four.
+    """
+    if isinstance(messages, str):
+        messages = [messages]
+    messages = [str(message) for message in messages]
+    return {
+        "ok": False,
+        "error": "; ".join(messages),
+        "errors": messages,
+        "status": status,
+    }
+
+
 def add_cors_headers(headers):
     headers["Access-Control-Allow-Origin"] = "*"
     headers["Access-Control-Allow-Headers"] = "Authorization, Content-Type"
diff --git a/datasette/views/base.py b/datasette/views/base.py
index 30026f4b..a12ae050 100644
--- a/datasette/views/base.py
+++ b/datasette/views/base.py
@@ -5,6 +5,7 @@ import sys
 from datasette.utils.asgi import Request
 from datasette.utils import (
     add_cors_headers,
+    error_body,
     EscapeHtmlWriter,
     InvalidSql,
     LimitedWriter,
@@ -49,9 +50,7 @@ class View:
             request.path.endswith(".json")
             or request.headers.get("content-type") == "application/json"
         ):
-            response = Response.json(
-                {"ok": False, "error": "Method not allowed"}, status=405
-            )
+            response = Response.json(error_body("Method not allowed", 405), status=405)
         else:
             response = Response.text("Method not allowed", status=405)
         return response
@@ -90,9 +89,7 @@ class BaseView:
             request.path.endswith(".json")
             or request.headers.get("content-type") == "application/json"
         ):
-            response = Response.json(
-                {"ok": False, "error": "Method not allowed"}, status=405
-            )
+            response = Response.json(error_body("Method not allowed", 405), status=405)
         else:
             response = Response.text("Method not allowed", status=405)
         return response
@@ -181,7 +178,7 @@ class BaseView:
 
 
 def _error(messages, status=400):
-    return Response.json({"ok": False, "errors": messages}, status=status)
+    return Response.json(error_body(messages, status), status=status)
 
 
 async def stream_csv(datasette, fetch_data, request, database):
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 3245bc13..602ec5ea 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -9,6 +9,7 @@ from datasette.utils import (
     actor_matches_allow,
     add_cors_headers,
     await_me_maybe,
+    error_body,
     tilde_encode,
     tilde_decode,
 )
@@ -348,26 +349,29 @@ class AllowedResourcesView(BaseView):
     async def _allowed_payload(self, request, has_debug_permission):
         action = request.args.get("action")
         if not action:
-            return {"error": "action parameter is required"}, 400
+            return error_body("action parameter is required", 400), 400
         if action not in self.ds.actions:
-            return {"error": f"Unknown action: {action}"}, 404
+            return error_body(f"Unknown action: {action}", 404), 404
 
         actor = request.actor if isinstance(request.actor, dict) else None
         actor_id = actor.get("id") if actor else None
         parent_filter = request.args.get("parent")
         child_filter = request.args.get("child")
         if child_filter and not parent_filter:
-            return {"error": "parent must be provided when child is specified"}, 400
+            return (
+                error_body("parent must be provided when child is specified", 400),
+                400,
+            )
 
         try:
             page = int(request.args.get("page", "1"))
             page_size = int(request.args.get("page_size", "50"))
         except ValueError:
-            return {"error": "page and page_size must be integers"}, 400
+            return error_body("page and page_size must be integers", 400), 400
         if page < 1:
-            return {"error": "page must be >= 1"}, 400
+            return error_body("page must be >= 1", 400), 400
         if page_size < 1:
-            return {"error": "page_size must be >= 1"}, 400
+            return error_body("page_size must be >= 1", 400), 400
         max_page_size = 200
         if page_size > max_page_size:
             page_size = max_page_size
@@ -485,9 +489,13 @@ class PermissionRulesView(BaseView):
         # JSON API - action parameter is required
         action = request.args.get("action")
         if not action:
-            return Response.json({"error": "action parameter is required"}, status=400)
+            return Response.json(
+                error_body("action parameter is required", 400), status=400
+            )
         if action not in self.ds.actions:
-            return Response.json({"error": f"Unknown action: {action}"}, status=404)
+            return Response.json(
+                error_body(f"Unknown action: {action}", 404), status=404
+            )
 
         actor = request.actor if isinstance(request.actor, dict) else None
 
@@ -496,12 +504,12 @@ class PermissionRulesView(BaseView):
             page_size = int(request.args.get("page_size", "50"))
         except ValueError:
             return Response.json(
-                {"error": "page and page_size must be integers"}, status=400
+                error_body("page and page_size must be integers", 400), status=400
             )
         if page < 1:
-            return Response.json({"error": "page must be >= 1"}, status=400)
+            return Response.json(error_body("page must be >= 1", 400), status=400)
         if page_size < 1:
-            return Response.json({"error": "page_size must be >= 1"}, status=400)
+            return Response.json(error_body("page_size must be >= 1", 400), status=400)
         max_page_size = 200
         if page_size > max_page_size:
             page_size = max_page_size
@@ -587,15 +595,15 @@ class PermissionRulesView(BaseView):
 async def _check_permission_for_actor(ds, action, parent, child, actor):
     """Shared logic for checking permissions. Returns a dict with check results."""
     if action not in ds.actions:
-        return {"error": f"Unknown action: {action}"}, 404
+        return error_body(f"Unknown action: {action}", 404), 404
 
     if child and not parent:
-        return {"error": "parent is required when child is provided"}, 400
+        return error_body("parent is required when child is provided", 400), 400
 
     # Use the action's properties to create the appropriate resource object
     action_obj = ds.actions.get(action)
     if not action_obj:
-        return {"error": f"Unknown action: {action}"}, 400
+        return error_body(f"Unknown action: {action}", 400), 400
 
     # Global actions (no resource_class) don't have a resource
     if action_obj.resource_class is None:
@@ -610,7 +618,7 @@ async def _check_permission_for_actor(ds, action, parent, child, actor):
         resource_obj = action_obj.resource_class(parent)
     else:
         # This shouldn't happen given validation in Action.__post_init__
-        return {"error": f"Invalid action configuration: {action}"}, 500
+        return error_body(f"Invalid action configuration: {action}", 500), 500
 
     allowed = await ds.allowed(action=action, resource=resource_obj, actor=actor)
 
@@ -651,7 +659,9 @@ class PermissionCheckView(BaseView):
         # JSON API - action parameter is required
         action = request.args.get("action")
         if not action:
-            return Response.json({"error": "action parameter is required"}, status=400)
+            return Response.json(
+                error_body("action parameter is required", 400), status=400
+            )
 
         parent = request.args.get("parent")
         child = request.args.get("child")
@@ -1229,7 +1239,7 @@ class SchemaBaseView(BaseView):
             if self.ds.cors:
                 add_cors_headers(headers)
             return Response.json(
-                {"ok": False, "error": error_message}, status=status, headers=headers
+                error_body(error_message, status), status=status, headers=headers
             )
         else:
             return Response.text(error_message, status=status)
diff --git a/docs/json_api.rst b/docs/json_api.rst
index eca22fdc..3df66a8e 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -50,6 +50,37 @@ The ``"truncated"`` key lets you know if the query was truncated. This can happe
 
 For table pages, an additional key ``"next"`` may be present. This indicates that the next page in the pagination set can be retrieved using ``?_next=VALUE``.
 
+.. _json_api_errors:
+
+Error responses
+---------------
+
+Every JSON error response from Datasette uses the same format:
+
+.. code-block:: json
+
+    {
+        "ok": false,
+        "error": "Table not found",
+        "errors": [
+            "Table not found"
+        ],
+        "status": 404
+    }
+
+- ``"ok"`` is always ``false`` for an error.
+- ``"errors"`` is a list of one or more error message strings. Endpoints that
+  validate multiple things at once - such as the :ref:`insert API <TableInsertView>` -
+  may return several messages here.
+- ``"error"`` is all of those messages joined with ``"; "``, for
+  convenience when displaying a single string.
+- ``"status"`` matches the HTTP status code of the response.
+
+Some endpoints add extra context keys. For example, a SQL error from a
+:ref:`custom query <json_api_custom_sql>` also includes the empty
+``"rows"`` and ``"truncated"`` keys of the response it was unable to
+produce.
+
 .. _json_api_custom_sql:
 
 Executing custom SQL
@@ -1625,15 +1656,17 @@ the execute-write returning row limit, which defaults to 10:
         ]
     }
 
-Errors use the standard Datasette error format:
+Errors use the :ref:`standard Datasette error format <json_api_errors>`:
 
 .. code-block:: json
 
     {
         "ok": false,
+        "error": "Permission denied: need execute-write-sql",
         "errors": [
             "Permission denied: need execute-write-sql"
-        ]
+        ],
+        "status": 403
     }
 
 .. _TableInsertView:
@@ -1727,9 +1760,11 @@ If any of your rows have a primary key that is already in use, you will get an e
 
     {
         "ok": false,
+        "error": "UNIQUE constraint failed: new_table.id",
         "errors": [
             "UNIQUE constraint failed: new_table.id"
-        ]
+        ],
+        "status": 400
     }
 
 Pass ``"ignore": true`` to ignore these errors and insert the other rows:
@@ -1859,9 +1894,11 @@ When using upsert you must provide the primary key column (or columns if the tab
 
     {
         "ok": false,
+        "error": "Row 0 is missing primary key column(s): \"id\"",
         "errors": [
             "Row 0 is missing primary key column(s): \"id\""
-        ]
+        ],
+        "status": 400
     }
 
 If your table does not have an explicit primary key you should pass the SQLite ``rowid`` key instead.
@@ -1921,7 +1958,7 @@ The returned JSON will look like this:
         }
     }
 
-Any errors will return ``{"errors": ["... descriptive message ..."], "ok": false}``, and a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
+Any errors will use the :ref:`standard error format <json_api_errors>`, with a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
 
 Pass ``"alter: true`` to automatically add any missing columns to the table. This requires the :ref:`actions_alter_table` permission.
 
@@ -1942,7 +1979,7 @@ To delete a row, make a ``POST`` to ``/<database>/<table>/<row-pks>/-/delete``.
 
 If successful, this will return a ``200`` status code and a ``{"ok": true}`` response body.
 
-Any errors will return ``{"errors": ["... descriptive message ..."], "ok": false}``, and a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
+Any errors will use the :ref:`standard error format <json_api_errors>`, with a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
 
 .. _TableCreateView:
 
@@ -2122,9 +2159,11 @@ If you pass a row to the create endpoint with a primary key that already exists
 
     {
         "ok": false,
+        "error": "UNIQUE constraint failed: creatures.id",
         "errors": [
             "UNIQUE constraint failed: creatures.id"
-        ]
+        ],
+        "status": 400
     }
 
 You can avoid this error by passing the same ``"ignore": true`` or ``"replace": true`` options to the create endpoint as you can to the :ref:`insert endpoint <TableInsertView>`.
@@ -2360,7 +2399,7 @@ A successful response returns the new schema and the previous schema. If the req
         "operations_applied": 11
     }
 
-Any errors will return ``{"errors": ["... descriptive message ..."], "ok": false}``, and a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
+Any errors will use the :ref:`standard error format <json_api_errors>`, with a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
 
 .. _TableSetColumnTypeView:
 
@@ -2424,7 +2463,7 @@ To clear an existing column type assignment, set ``column_type`` to ``null``:
 
 This API stores the assignment in Datasette's internal database, so it can be used with immutable databases as well as mutable ones.
 
-Any errors will return ``{"errors": ["... descriptive message ..."], "ok": false}``, and a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
+Any errors will use the :ref:`standard error format <json_api_errors>`, with a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
 
 .. _TableDropView:
 
@@ -2461,4 +2500,4 @@ If you pass the following POST body:
 
 Then the table will be dropped and a status ``200`` response of ``{"ok": true}`` will be returned.
 
-Any errors will return ``{"errors": ["... descriptive message ..."], "ok": false}``, and a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
+Any errors will use the :ref:`standard error format <json_api_errors>`, with a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
diff --git a/existing-api.md b/existing-api.md
index b3eda9d4..1933d287 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -44,46 +44,51 @@ directory: every claim below is based on the route table in `datasette/app.py`
 - Success content type: `application/json; charset=utf-8`
   (`_shape=array&_nl=on` responses use `text/plain`).
 
-### Error shapes (there are several)
+### Error shape (canonical)
 
-The codebase produces **four distinct JSON error shapes**, depending on which
-layer generates the error:
+Every JSON error response uses one canonical shape, built by `error_body()`
+(utils/__init__.py):
 
-1. **Exception handler** (handle_exception.py:21-59) — used when a view raises
-   `NotFound`, `Forbidden` (JSON paths only — see below), `DatasetteError`,
-   `BadRequest` etc. and the request path ends in `.json`:
+```json
+{
+  "ok": false,
+  "error": "all messages joined with '; '",
+  "errors": ["message", "..."],
+  "status": 404
+}
+```
+
+- `errors` is a list of one or more message strings (multi-message
+  validation errors, e.g. per-row insert errors, list them all).
+- `error` is the messages joined with `"; "`.
+- `status` always matches the HTTP status code.
+
+The shape is produced by four code paths, all delegating to `error_body()`:
+
+1. **Exception handler** (handle_exception.py) — `NotFound`,
+   `DatasetteError`, `BadRequest` etc. on `.json` paths. `DatasetteError`
+   `error_dict` context keys are merged in; the legacy `title` key is no
+   longer emitted in JSON (it survives in the HTML error template context).
+2. **The `_error()` helper** (views/base.py:183-184) — the write API,
+   stored-query API, execute-write and permission-denied paths.
+3. **JSON renderer errors** (renderer.py) — SQL errors on table/query
+   endpoints return HTTP 400 with the canonical keys **plus** the context
+   keys of the response it could not produce:
 
    ```json
-   {"ok": false, "error": "message", "status": 404, "title": null}
+   {"ok": false, "error": "no such table: x", "errors": ["no such table: x"],
+    "status": 400, "rows": [], "truncated": false}
    ```
 
-2. **The `_error()` helper** (views/base.py:183-184) — used by the write API,
-   stored-query API, execute-write and several permission-denied paths:
+   Invalid `_shape=` values and `_shape=object` misuse (on queries or
+   pk-less tables) also return canonical 400 errors.
+4. **Permission debug endpoints** (`/-/allowed`, `/-/rules`, `/-/check`,
+   POST `/-/permissions`) — canonical shape (previously bare
+   `{"error": ...}` objects).
 
-   ```json
-   {"ok": false, "errors": ["message", "..."]}
-   ```
-
-   Note: plural `errors`, a list, and no `status`/`title` keys.
-
-3. **JSON renderer errors** (renderer.py:52-56) — SQL errors on table/query
-   endpoints return HTTP 400 with the error embedded in the data envelope:
-
-   ```json
-   {"ok": false, "error": "no such table: x", "rows": [], "truncated": false}
-   ```
-
-   An invalid `_shape=` value produces `{"ok": false, "error": "Invalid _shape: x",
-   "status": 400, "title": null}` (renderer.py:101-108).
-
-4. **Ad-hoc `{"error": ...}` objects** — the permission debug endpoints
-   (`/-/allowed`, `/-/rules`, `/-/check`, POST `/-/permissions`) return e.g.
-   `{"error": "Unknown action: x"}` with no `ok` key (views/special.py).
-
-Method-not-allowed responses return HTTP 405
-`{"ok": false, "error": "Method not allowed"}` when the path ends in `.json`
-or the request content type is `application/json`; plain text otherwise
-(views/base.py:53, 88-98).
+Method-not-allowed responses return HTTP 405 with the canonical shape when
+the path ends in `.json` or the request content type is `application/json`;
+plain text otherwise (views/base.py).
 
 **`Forbidden` is special:** when a view raises `Forbidden` (e.g. via
 `ensure_permission`), the default `forbidden()` plugin hook renders an **HTML
@@ -144,11 +149,10 @@ build JSON directly):
   - `array` — response body is a bare JSON array of row objects
   - `arrayfirst` — bare JSON array of the first column's values
   - `object` — table views only: an object keyed by primary-key string.
-    On queries: `{"ok": false, "error": "_shape=object is only available on
-    tables"}` (with HTTP status 200); on tables without primary keys a similar
-    error.
-  - anything else — HTTP 400 `{"ok": false, "error": "Invalid _shape: x",
-    "status": 400, "title": null}`
+    On queries or tables without primary keys: a canonical 400 error
+    (`_shape=object is only available on tables` /
+    `_shape=object not available for tables with no primary keys`).
+  - anything else — canonical HTTP 400 error `Invalid _shape: x`
 - **`_nl=on`** — with `_shape=array` only: newline-delimited JSON, `text/plain`.
 - **`_json=COLUMN`** (repeatable) — parse that column's string values with
   `json.loads` so they nest as JSON; parse failures leave the value unchanged.
@@ -157,7 +161,7 @@ build JSON directly):
 - `columns` is stripped from dict-shaped output unless `?_extra=columns` was
   requested (renderer.py:110-113).
 - If a SQL error occurred, `_shape` is ignored, HTTP status is 400 and the
-  envelope carries `"ok": false, "error": ...` (renderer.py:52-56).
+  envelope carries the canonical error keys alongside `rows`/`truncated`.
 
 ### The `?_extra=` system
 
@@ -340,8 +344,8 @@ GET renders a confirmation page (or redirects if anonymous); POST deletes the
 - **POST** — form-encoded `actor` (JSON string), `permission`, optional
   `resource_1`, `resource_2`; returns **JSON**
   `{"action", "allowed", "resource": {"parent", "child", "path"}}` plus
-  `actor_id` when present. Errors: unknown action → 404 `{"error": ...}`;
-  child without parent → 400 `{"error": ...}`.
+  `actor_id` when present. Errors: unknown action → 404; child without
+  parent → 400 (both canonical error shape).
 
 ### GET /-/allowed(.json)
 
@@ -351,7 +355,7 @@ path always renders the HTML form; `.json` returns JSON.
 - **Permission:** none — reports the **current actor's own** allowed
   resources. Items gain a `reason` field if the actor also holds
   `permissions-debug`.
-- **Parameters:** `action` (required; missing → 400 `{"error": ...}`, unknown
+- **Parameters:** `action` (required; missing → 400 canonical error, unknown
   → 404), `parent`, `child` (requires `parent`), `page` (default 1),
   `page_size` (default 50, silently capped at 200).
 - **Response:** `{"action", "actor_id", "page", "page_size", "total",
@@ -497,7 +501,7 @@ queries section).
 GET → 405. Body is parsed as JSON regardless of content type; invalid JSON →
 400 `{"ok": false, "errors": ["Invalid JSON: ..."]}`.
 
-- **Permissions** (all denials → 403 `{"ok": false, "errors": [...]}`,
+- **Permissions** (all denials → 403 canonical error JSON,
   all checked at the **database** level):
   - `create-table` — always required (`["Permission denied"]`)
   - `insert-row` — if `rows`/`row` provided (`need insert-row`)
@@ -812,8 +816,8 @@ only — views get 400 `"Autocomplete is only available for tables"`.
 
 ## The write API
 
-All write endpoints return errors via `_error()`
-(`{"ok": false, "errors": [...]}`) and check permissions with
+All write endpoints return errors via `_error()` (the canonical error
+shape) and check permissions with
 `datasette.allowed()` directly, so their 403s are JSON (unlike the
 `Forbidden`-raising read endpoints). Routes: app.py:2719-2762.
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index e630ae4b..9eac543f 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -18,7 +18,17 @@ Findings are grouped by theme. Each carries a priority:
 
 ---
 
-## 1. Error responses: four shapes is three too many (P1)
+## 1. Error responses: four shapes is three too many (P1) — ✅ IMPLEMENTED
+
+> **Status:** implemented. All four shapes now delegate to a shared
+> `error_body()` helper (`datasette/utils/__init__.py`) producing
+> `{"ok": false, "error": "<joined>", "errors": [...], "status": <int>}`.
+> The `title` key is no longer emitted in JSON; the bare `{"error": ...}`
+> debug-endpoint shape is gone; `_shape=object` misuse now returns HTTP 400
+> (part of §1b). Covered by `tests/test_error_shape.py` and documented in
+> the "Error responses" section of `docs/json_api.rst`. Still open from
+> this section's sub-items: §1a (`Forbidden` → HTML), the write
+> canned-query 200 (§1b), and the §1c status outliers.
 
 The API currently produces four distinct JSON error shapes depending on which
 internal layer generates the error:
@@ -348,7 +358,7 @@ Two details make tiering urgent rather than optional:
 
 ## 10. Summary of P1 items (the pre-1.0 checklist)
 
-1. One canonical JSON error shape; retire the other three (§1).
+1. ~~One canonical JSON error shape; retire the other three (§1).~~ ✅ Done.
 2. `Forbidden` → JSON 403 for JSON requests (§1a).
 3. No `ok: false` with HTTP 200 (§1b: `_shape=object`, write canned-query
    SQL errors).
diff --git a/tests/test_api.py b/tests/test_api.py
index f57d0206..e5ed1d23 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -323,20 +323,21 @@ def test_sql_time_limit(app_client_shorter_time_limit):
         "/fixtures/-/query.json?sql=select+sleep(0.5)",
     )
     assert 400 == response.status
+    expected_message = (
+        "<p>SQL query took too long. The time limit is controlled by the\n"
+        '<a href="https://docs.datasette.io/en/stable/settings.html#sql-time-limit-ms">sql_time_limit_ms</a>\n'
+        "configuration option.</p>\n"
+        '<textarea style="width: 90%">select sleep(0.5)</textarea>\n'
+        "<script>\n"
+        'let ta = document.querySelector("textarea");\n'
+        'ta.style.height = ta.scrollHeight + "px";\n'
+        "</script>"
+    )
     assert response.json == {
         "ok": False,
-        "error": (
-            "<p>SQL query took too long. The time limit is controlled by the\n"
-            '<a href="https://docs.datasette.io/en/stable/settings.html#sql-time-limit-ms">sql_time_limit_ms</a>\n'
-            "configuration option.</p>\n"
-            '<textarea style="width: 90%">select sleep(0.5)</textarea>\n'
-            "<script>\n"
-            'let ta = document.querySelector("textarea");\n'
-            'ta.style.height = ta.scrollHeight + "px";\n'
-            "</script>"
-        ),
+        "error": expected_message,
+        "errors": [expected_message],
         "status": 400,
-        "title": "SQL Interrupted",
     }
 
 
@@ -350,7 +351,7 @@ async def test_custom_sql_time_limit(ds_client):
         "/fixtures/-/query.json?sql=select+sleep(0.01)&_timelimit=5",
     )
     assert response.status_code == 400
-    assert response.json()["title"] == "SQL Interrupted"
+    assert response.json()["error"].startswith("<p>SQL query took too long.")
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 76797742..17542d4b 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1,6 +1,6 @@
 from datasette.app import Datasette
 from datasette.events import RenameTableEvent
-from datasette.utils import escape_sqlite, sqlite3
+from datasette.utils import error_body, escape_sqlite, sqlite3
 from .utils import last_event
 import pytest
 import time
@@ -788,7 +788,12 @@ async def test_update_row_invalid_key(ds_write):
         headers=_headers(token),
     )
     assert response.status_code == 400
-    assert response.json() == {"ok": False, "errors": ["Invalid keys: bad_key"]}
+    assert response.json() == {
+        "ok": False,
+        "error": "Invalid keys: bad_key",
+        "errors": ["Invalid keys: bad_key"],
+        "status": 400,
+    }
 
 
 @pytest.mark.asyncio
@@ -1103,10 +1108,9 @@ async def test_alter_table_foreign_key_requires_fk_table_for_fk_column(ds_write)
         headers=_headers(write_token(ds_write, permissions=["at"])),
     )
     assert response.status_code == 400
-    assert response.json() == {
-        "ok": False,
-        "errors": ["operations.0.add_foreign_key.args: fk_column requires fk_table"],
-    }
+    assert response.json() == error_body(
+        ["operations.0.add_foreign_key.args: fk_column requires fk_table"], 400
+    )
 
 
 @pytest.mark.asyncio
@@ -1130,10 +1134,9 @@ async def test_alter_table_foreign_key_without_fk_column_requires_single_pk(ds_w
         headers=_headers(token),
     )
     assert response.status_code == 400
-    assert response.json() == {
-        "ok": False,
-        "errors": ["Could not detect single primary key for table 'accounts'"],
-    }
+    assert response.json() == error_body(
+        ["Could not detect single primary key for table 'accounts'"], 400
+    )
 
 
 @pytest.mark.asyncio
@@ -1199,10 +1202,7 @@ async def test_foreign_key_suggestions_permission_denied(ds_write):
         headers=_headers(token),
     )
     assert response.status_code == 403
-    assert response.json() == {
-        "ok": False,
-        "errors": ["Permission denied: need alter-table"],
-    }
+    assert response.json() == error_body(["Permission denied: need alter-table"], 403)
 
 
 @pytest.mark.asyncio
@@ -1313,10 +1313,7 @@ async def test_foreign_key_targets_permission_denied(ds_write):
         headers=_headers(token),
     )
     assert response.status_code == 403
-    assert response.json() == {
-        "ok": False,
-        "errors": ["Permission denied: need create-table"],
-    }
+    assert response.json() == error_body(["Permission denied: need create-table"], 403)
 
 
 @pytest.mark.asyncio
@@ -1339,10 +1336,7 @@ async def test_alter_table_permission_denied(ds_write):
         headers=_headers(token),
     )
     assert response.status_code == 403
-    assert response.json() == {
-        "ok": False,
-        "errors": ["Permission denied: need alter-table"],
-    }
+    assert response.json() == error_body(["Permission denied: need alter-table"], 403)
 
 
 @pytest.mark.asyncio
@@ -2021,6 +2015,9 @@ async def test_create_table(
     )
     assert response.status_code == expected_status
     data = response.json()
+    if expected_response.get("ok") is False:
+        # Error expectations list their messages; derive the canonical envelope
+        expected_response = error_body(expected_response["errors"], expected_status)
     assert data == expected_response
     # Should have tracked the expected events
     events = ds_write._tracked_events
@@ -2218,13 +2215,12 @@ async def test_create_table_column_validation(ds_write, column, expected_error):
     )
     if expected_error:
         assert response.status_code == 400
-        assert response.json() == {"ok": False, "errors": [expected_error]}
+        assert response.json() == error_body([expected_error], 400)
     else:
         assert response.status_code == 400
-        assert response.json() == {
-            "ok": False,
-            "errors": ["Could not detect single primary key for table 'owners'"],
-        }
+        assert response.json() == error_body(
+            ["Could not detect single primary key for table 'owners'"], 400
+        )
 
 
 @pytest.mark.asyncio
@@ -2262,10 +2258,9 @@ async def test_create_table_foreign_key_without_fk_column_requires_single_pk(ds_
         headers=_headers(token),
     )
     assert response.status_code == 400
-    assert response.json() == {
-        "ok": False,
-        "errors": ["Could not detect single primary key for table 'accounts'"],
-    }
+    assert response.json() == error_body(
+        ["Could not detect single primary key for table 'accounts'"], 400
+    )
 
 
 @pytest.mark.asyncio
@@ -2415,10 +2410,9 @@ async def test_create_table_error_if_pk_changed(ds_write):
         headers=_headers(token),
     )
     assert second_response.status_code == 400
-    assert second_response.json() == {
-        "ok": False,
-        "errors": ["pk cannot be changed for existing table"],
-    }
+    assert second_response.json() == error_body(
+        ["pk cannot be changed for existing table"], 400
+    )
 
 
 @pytest.mark.asyncio
@@ -2442,10 +2436,9 @@ async def test_create_table_error_rows_twice_with_duplicates(ds_write):
         headers=_headers(token),
     )
     assert second_response.status_code == 400
-    assert second_response.json() == {
-        "ok": False,
-        "errors": ["UNIQUE constraint failed: test_create_twice.id"],
-    }
+    assert second_response.json() == error_body(
+        ["UNIQUE constraint failed: test_create_twice.id"], 400
+    )
 
 
 @pytest.mark.asyncio
@@ -2468,6 +2461,8 @@ async def test_method_not_allowed(ds_write, path):
     assert response.json() == {
         "ok": False,
         "error": "Method not allowed",
+        "errors": ["Method not allowed"],
+        "status": 405,
     }
 
 
@@ -2535,10 +2530,9 @@ async def test_create_using_alter_against_existing_table(
     )
     if not has_alter_permission:
         assert response2.status_code == 403
-        assert response2.json() == {
-            "ok": False,
-            "errors": ["Permission denied: need alter-table"],
-        }
+        assert response2.json() == error_body(
+            ["Permission denied: need alter-table"], 403
+        )
     else:
         assert response2.status_code == 201
 
diff --git a/tests/test_base_view.py b/tests/test_base_view.py
index 2cd4d601..c1b0cf20 100644
--- a/tests/test_base_view.py
+++ b/tests/test_base_view.py
@@ -53,6 +53,8 @@ async def test_get_view():
     assert json.loads(post_json_response.body) == {
         "ok": False,
         "error": "Method not allowed",
+        "errors": ["Method not allowed"],
+        "status": 405,
     }
     assert post_json_response.status == 405
 
diff --git a/tests/test_column_types.py b/tests/test_column_types.py
index 45a9e7d1..4e553771 100644
--- a/tests/test_column_types.py
+++ b/tests/test_column_types.py
@@ -9,7 +9,7 @@ from datasette.column_types import (
 )
 from datasette.hookspecs import hookimpl
 from datasette.plugins import pm
-from datasette.utils import sqlite3
+from datasette.utils import error_body, sqlite3
 from datasette.utils import StartupError
 import markupsafe
 import pytest
@@ -426,7 +426,7 @@ async def test_set_column_type_api_errors(
         kwargs["json"] = body
     response = await ds_ct.client.post("/data/posts/-/set-column-type", **kwargs)
     assert response.status_code == expected_status
-    assert response.json() == {"ok": False, "errors": expected_errors}
+    assert response.json() == error_body(expected_errors, expected_status)
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
new file mode 100644
index 00000000..6747e47a
--- /dev/null
+++ b/tests/test_error_shape.py
@@ -0,0 +1,185 @@
+"""
+Tests for the canonical JSON error shape.
+
+Every JSON error response from Datasette should use one shape:
+
+    {
+        "ok": false,
+        "error": "<all messages joined with '; '>",
+        "errors": ["<message>", ...],
+        "status": <int matching the HTTP status code>
+    }
+
+Additional context keys (for example "rows" and "truncated" on SQL errors)
+are permitted, but "ok", "error", "errors" and "status" must always be
+present and the legacy "title" key must not be.
+
+https://github.com/simonw/datasette/issues - 1.0 API consistency
+"""
+
+import pytest
+from datasette.app import Datasette
+from datasette.utils import sqlite3
+
+
+def assert_canonical_error(response, expected_status):
+    assert response.status_code == expected_status
+    data = response.json()
+    assert data["ok"] is False
+    assert isinstance(data["error"], str)
+    assert data["error"]
+    assert isinstance(data["errors"], list)
+    assert data["errors"]
+    assert all(isinstance(message, str) for message in data["errors"])
+    assert data["error"] == "; ".join(data["errors"])
+    assert data["status"] == expected_status
+    assert "title" not in data
+    return data
+
+
+@pytest.fixture
+def ds_error_shape(tmp_path_factory):
+    db_directory = tmp_path_factory.mktemp("dbs")
+    db_path = str(db_directory / "data.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("vacuum")
+    conn.execute("create table docs (id integer primary key, title text)")
+    conn.close()
+    ds = Datasette([db_path])
+    ds.root_enabled = True
+    yield ds
+    ds.close()
+
+
+# Shape 1: the exception handler (handle_exception.py)
+
+
+@pytest.mark.asyncio
+async def test_not_found_error_shape(ds_client):
+    response = await ds_client.get("/fixtures/no_such_table.json")
+    assert_canonical_error(response, 404)
+
+
+@pytest.mark.asyncio
+async def test_datasette_error_with_title_omits_title_key(ds_client):
+    # DatasetteError(title="Invalid SQL") previously leaked a "title" key
+    response = await ds_client.get(
+        "/fixtures/-/query.json?sql=update+facetable+set+state+=+1"
+    )
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["Statement must be a SELECT"]
+
+
+# Shape 2: the _error() helper (views/base.py) - write API and friends
+
+
+@pytest.mark.asyncio
+async def test_write_api_validation_error_shape(ds_error_shape):
+    token = "dstok_{}".format(
+        ds_error_shape.sign(
+            {"a": "root", "token": "dstok", "t": 0},
+            namespace="token",
+        )
+    )
+    response = await ds_error_shape.client.post(
+        "/data/docs/-/insert",
+        json={"rows": [{"nope": 1}, {"also_nope": 2}]},
+        headers={
+            "Authorization": "Bearer {}".format(token),
+            "Content-Type": "application/json",
+        },
+    )
+    data = assert_canonical_error(response, 400)
+    # Multiple messages: errors keeps them all, error joins them
+    assert len(data["errors"]) == 2
+    assert data["errors"][0].startswith("Row 0")
+    assert data["errors"][1].startswith("Row 1")
+
+
+@pytest.mark.asyncio
+async def test_write_api_permission_denied_shape(ds_error_shape):
+    response = await ds_error_shape.client.post(
+        "/data/docs/-/insert",
+        json={"rows": [{"title": "hello"}]},
+        headers={"Content-Type": "application/json"},
+    )
+    assert_canonical_error(response, 403)
+
+
+# Shape 3: the JSON renderer (renderer.py)
+
+
+@pytest.mark.asyncio
+async def test_sql_error_shape_keeps_context_keys(ds_client):
+    response = await ds_client.get(
+        "/fixtures/-/query.json?sql=select+*+from+no_such_table"
+    )
+    data = assert_canonical_error(response, 400)
+    # Renderer errors keep their context keys
+    assert data["rows"] == []
+    assert "truncated" in data
+
+
+@pytest.mark.asyncio
+async def test_invalid_shape_error_shape(ds_client):
+    response = await ds_client.get("/fixtures/-/query.json?sql=select+1&_shape=bananas")
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["Invalid _shape: bananas"]
+
+
+@pytest.mark.asyncio
+async def test_shape_object_on_query_is_a_400_error(ds_client):
+    # Previously returned HTTP 200 with an ok: false body
+    response = await ds_client.get("/fixtures/-/query.json?sql=select+1&_shape=object")
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["_shape=object is only available on tables"]
+
+
+# Shape 4: bare {"error": ...} from the permission debug endpoints
+
+
+@pytest.mark.asyncio
+async def test_allowed_missing_action_error_shape(ds_client):
+    response = await ds_client.get("/-/allowed.json")
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["action parameter is required"]
+
+
+@pytest.mark.asyncio
+async def test_allowed_unknown_action_error_shape(ds_client):
+    response = await ds_client.get("/-/allowed.json?action=no_such_action")
+    assert_canonical_error(response, 404)
+
+
+@pytest.mark.asyncio
+async def test_check_unknown_action_error_shape(ds_error_shape):
+    response = await ds_error_shape.client.get(
+        "/-/check.json?action=no_such_action",
+        actor={"id": "root"},
+    )
+    assert_canonical_error(response, 404)
+
+
+@pytest.mark.asyncio
+async def test_rules_missing_action_error_shape(ds_error_shape):
+    response = await ds_error_shape.client.get(
+        "/-/rules.json",
+        actor={"id": "root"},
+    )
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["action parameter is required"]
+
+
+# Other stragglers
+
+
+@pytest.mark.asyncio
+async def test_method_not_allowed_error_shape(ds_client):
+    response = await ds_client.post("/fixtures.json")
+    assert_canonical_error(response, 405)
+
+
+@pytest.mark.asyncio
+async def test_schema_unknown_database_error_shape(ds_client):
+    response = await ds_client.get("/no_such_db/-/schema.json")
+    assert_canonical_error(response, 404)
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 272e39e3..c8ba31b7 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -31,8 +31,8 @@ async def test_table_not_exists_json(ds_client):
     assert (await ds_client.get("/fixtures/blah.json")).json() == {
         "ok": False,
         "error": "Table not found",
+        "errors": ["Table not found"],
         "status": 404,
-        "title": None,
     }
 
 
@@ -242,8 +242,8 @@ async def test_table_shape_invalid(ds_client):
     assert response.json() == {
         "ok": False,
         "error": "Invalid _shape: invalid",
+        "errors": ["Invalid _shape: invalid"],
         "status": 400,
-        "title": None,
     }
 
 
@@ -635,8 +635,8 @@ async def test_searchable_invalid_column(ds_client):
     assert response.json() == {
         "ok": False,
         "error": "Cannot search by that column",
+        "errors": ["Cannot search by that column"],
         "status": 400,
-        "title": None,
     }
 
 
@@ -775,7 +775,7 @@ async def test_table_filter_extra_where_invalid(ds_client):
         "/fixtures/facetable.json?_where=_neighborhood=Dogpatch'"
     )
     assert response.status_code == 400
-    assert "Invalid SQL" == response.json()["title"]
+    assert "unrecognized token" in response.json()["error"]
 
 
 def test_table_filter_extra_where_disabled_if_no_sql_allowed():
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 3af2bb08..46d43c6c 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1979,8 +1979,8 @@ async def test_sort_errors(ds_client, json, params, error):
         assert response.json() == {
             "ok": False,
             "error": error,
+            "errors": [error],
             "status": 400,
-            "title": None,
         }
     else:
         assert error in response.text

From bc51c00724e09f71cd452139153f29eb528fd637 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 05:10:26 +0000
Subject: [PATCH 324/386] Remove legacy .jsono format extension

The homepage routes now only accept .json, and the row view no longer
redirects .jsono to .json?_shape=objects. The .jsono extension was
superseded by ?_shape= and returned output identical to .json.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/app.py              |  4 ++--
 datasette/views/row.py        | 13 -------------
 existing-api.md               |  6 ++----
 stable-api-recommendations.md |  6 ++++--
 4 files changed, 8 insertions(+), 21 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 9c9b7de4..e13f0731 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2514,8 +2514,8 @@ class Datasette:
         def add_route(view, regex):
             routes.append((regex, view))
 
-        add_route(IndexView.as_view(self), r"/(\.(?P<format>jsono?))?$")
-        add_route(IndexView.as_view(self), r"/-/(\.(?P<format>jsono?))?$")
+        add_route(IndexView.as_view(self), r"/(\.(?P<format>json))?$")
+        add_route(IndexView.as_view(self), r"/-/(\.(?P<format>json))?$")
         add_route(permanent_redirect("/-/"), r"/-$")
         add_route(favicon, "/favicon.ico")
 
diff --git a/datasette/views/row.py b/datasette/views/row.py
index 129216b9..c99b75d1 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -21,7 +21,6 @@ from datasette.utils import (
     InvalidSql,
     make_slot_function,
     path_from_row_pks,
-    path_with_added_args,
     path_with_format,
     path_with_removed_args,
     to_css_class,
@@ -209,18 +208,6 @@ class RowView(BaseView):
         end = time.perf_counter()
         data["query_ms"] = (end - start) * 1000
 
-        # Special case for .jsono extension - redirect to _shape=objects
-        if format_ == "jsono":
-            return self.redirect(
-                request,
-                path_with_added_args(
-                    request,
-                    {"_shape": "objects"},
-                    path=request.path.rsplit(".jsono", 1)[0] + ".json",
-                ),
-                forward_querystring=False,
-            )
-
         if format_ in self.ds.renderers.keys():
             # Dispatch request to the correct output format renderer
             # (CSV is not handled here due to streaming)
diff --git a/existing-api.md b/existing-api.md
index 1933d287..d7678613 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -25,8 +25,7 @@ directory: every claim below is based on the route table in `datasette/app.py`
 
 - Most read endpoints are registered with an optional format suffix:
   `/(...)(\.(?P<format>json))?$`. The bare path returns HTML; the `.json`
-  extension returns JSON. The homepage additionally accepts the legacy
-  `.jsono` extension, which returns identical JSON (app.py:2517-2518).
+  extension returns JSON.
 - Table, row and query routes accept any `\w+` format extension; formats other
   than the built-in `html`, `json`, `csv`, `blob` must be provided by a plugin
   via `register_output_renderer`, otherwise the request 404s.
@@ -772,8 +771,7 @@ tilde-encoded primary key values (rowid for rowid tables).
 - **Foreign-key label expansion does not apply to row JSON** — `_labels` has
   no effect here; expansion happens only in the HTML path
   (views/row.py:445-475).
-- `_shape`, `_json`, `_nl`, `_json_infinity`, `_ttl` apply. A `.jsono`
-  request redirects to `.json?_shape=objects`.
+- `_shape`, `_json`, `_nl`, `_json_infinity`, `_ttl` apply.
 
 ### The .blob format
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 9eac543f..8d8a87b4 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -233,8 +233,10 @@ Concerns:
   `_labels=on/off`, `?all=1`, `is_write=1|0|true|false|t|f|yes|no|on|off`,
   `_nocount=1`. Adopt one accepted set (the query-list parser at
   query_helpers.py:81-94 is a good candidate) and apply it everywhere.
-- **`.jsono`** survives on the homepage route (identical output to `.json`)
-  and as a row-view redirect. Remove it at 1.0; it is pure legacy.
+- ~~**`.jsono`** survives on the homepage route (identical output to `.json`)
+  and as a row-view redirect. Remove it at 1.0; it is pure legacy.~~
+  ✅ Removed: the homepage routes only accept `.json` and the row-view
+  redirect is gone.
 - **`_json` is overloaded:** on GET it is a renderer option naming a column
   to parse as JSON (repeatable); on canned-query POST a `_json` body field
   forces a JSON response. Two unrelated meanings for one name.

From 089e96a43763c5f215218498335d81958c59a414 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 13:40:05 +0000
Subject: [PATCH 325/386] Add "ok": true to every JSON object success response

JsonDataView now injects "ok": true into dict responses, covering
/-/versions, /-/settings, /-/config, /-/threads and /-/actor. The
homepage JSON, /-/jump, the three /-/schema endpoints, /-/allowed,
/-/rules, /-/check, POST /-/permissions and the table /-/autocomplete
endpoint set it explicitly.

The remaining top-level array endpoints (/-/plugins, /-/databases,
/-/actions) will be converted to objects in separate commits.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/index.py                 |  1 +
 datasette/views/special.py               | 10 ++-
 datasette/views/table.py                 |  9 ++-
 docs/introspection.rst                   |  9 +++
 docs/json_api.rst                        |  2 +-
 docs/pages.rst                           |  6 +-
 existing-api.md                          | 30 +++++----
 stable-api-recommendations.md            | 10 ++-
 tests/test_api.py                        |  8 ++-
 tests/test_auth.py                       |  8 +--
 tests/test_autocomplete.py               | 25 +++++---
 tests/test_cli_serve_get.py              |  8 ++-
 tests/test_docs.py                       |  4 +-
 tests/test_internals_datasette.py        |  2 +-
 tests/test_internals_datasette_client.py |  6 +-
 tests/test_permissions.py                |  3 +-
 tests/test_plugins.py                    |  8 ++-
 tests/test_success_envelope.py           | 78 ++++++++++++++++++++++++
 18 files changed, 180 insertions(+), 47 deletions(-)
 create mode 100644 tests/test_success_envelope.py

diff --git a/datasette/views/index.py b/datasette/views/index.py
index 6a9462ac..86f8ae7d 100644
--- a/datasette/views/index.py
+++ b/datasette/views/index.py
@@ -151,6 +151,7 @@ class IndexView(BaseView):
             return Response(
                 json.dumps(
                     {
+                        "ok": True,
                         "databases": {db["name"]: db for db in databases},
                         "metadata": await self.ds.get_instance_metadata(),
                     },
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 602ec5ea..c289a240 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -63,6 +63,8 @@ class JsonDataView(BaseView):
             headers = {}
             if self.ds.cors:
                 add_cors_headers(headers)
+            if isinstance(data, dict):
+                data = {"ok": True, **data}
             return Response.json(data, headers=headers)
         else:
             context = {
@@ -414,6 +416,7 @@ class AllowedResourcesView(BaseView):
             # If catalog tables don't exist yet, return empty results
             return (
                 {
+                    "ok": True,
                     "action": action,
                     "actor_id": actor_id,
                     "page": page,
@@ -448,6 +451,7 @@ class AllowedResourcesView(BaseView):
             return f"{request.path}?{query}"
 
         response = {
+            "ok": True,
             "action": action,
             "actor_id": actor_id,
             "page": page,
@@ -573,6 +577,7 @@ class PermissionRulesView(BaseView):
             return f"{request.path}?{query}"
 
         response = {
+            "ok": True,
             "action": action,
             "actor_id": (actor or {}).get("id") if actor else None,
             "page": page,
@@ -623,6 +628,7 @@ async def _check_permission_for_actor(ds, action, parent, child, actor):
     allowed = await ds.allowed(action=action, resource=resource_obj, actor=actor)
 
     response = {
+        "ok": True,
         "action": action,
         "allowed": bool(allowed),
         "resource": {
@@ -1208,7 +1214,7 @@ class JumpView(BaseView):
                 match["display_name"] = row["display_name"]
             matches.append(match)
 
-        return Response.json({"matches": matches, "truncated": truncated})
+        return Response.json({"ok": True, "matches": matches, "truncated": truncated})
 
 
 class SchemaBaseView(BaseView):
@@ -1230,7 +1236,7 @@ class SchemaBaseView(BaseView):
         headers = {}
         if self.ds.cors:
             add_cors_headers(headers)
-        return Response.json(data, headers=headers)
+        return Response.json({"ok": True, **data}, headers=headers)
 
     def format_error_response(self, error_message, format_, status=404):
         """Format error response based on requested format."""
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 1fc151e6..ef9831b2 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -1525,7 +1525,7 @@ class TableAutocompleteView(BaseView):
             and value_as_boolean(initial_arg)
         )
         if not q and not initial:
-            return Response.json({"rows": []})
+            return Response.json({"ok": True, "rows": []})
         params = {
             "q": q,
             "like": "%{}%".format(_escape_like(q)),
@@ -1588,10 +1588,13 @@ class TableAutocompleteView(BaseView):
                     custom_time_limit=AUTOCOMPLETE_TIME_LIMIT_MS,
                 )
             except QueryInterrupted:
-                return Response.json({"rows": []})
+                return Response.json({"ok": True, "rows": []})
 
         return Response.json(
-            {"rows": _autocomplete_response_rows(results.rows, pks, label_column)}
+            {
+                "ok": True,
+                "rows": _autocomplete_response_rows(results.rows, pks, label_column),
+            }
         )
 
 
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 4834f441..d0780763 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -7,6 +7,8 @@ Datasette includes some pages and JSON API endpoints for introspecting the curre
 
 Each of these pages can be viewed in your browser. Add ``.json`` to the URL to get back the contents as JSON.
 
+JSON responses that return an object include an ``"ok": true`` key, consistent with the rest of the :ref:`JSON API <json_api>`.
+
 .. _JsonDataView_metadata:
 
 /-/metadata
@@ -37,6 +39,7 @@ Shows the version of Datasette, Python and SQLite. `Versions example <https://la
 .. code-block:: json
 
     {
+        "ok": true,
         "datasette": {
             "version": "0.60"
         },
@@ -97,6 +100,7 @@ Shows the :ref:`settings` for this instance of Datasette. `Settings example <htt
 .. code-block:: json
 
     {
+        "ok": true,
         "default_facet_size": 30,
         "default_page_size": 100,
         "facet_suggest_time_limit_ms": 50,
@@ -115,6 +119,7 @@ Shows the :ref:`configuration <configuration>` for this instance of Datasette. T
 .. code-block:: json
 
     {
+        "ok": true,
         "settings": {
             "template_debug": true,
             "trace_debug": true,
@@ -160,6 +165,7 @@ The endpoint supports a ``?q=`` query parameter for filtering items by name.
 .. code-block:: json
 
     {
+        "ok": true,
         "matches": [
             {
                 "name": "fixtures",
@@ -188,6 +194,7 @@ Search example with ``?q=facet`` returns only items matching ``.*facet.*``:
 .. code-block:: json
 
     {
+        "ok": true,
         "matches": [
             {
                 "name": "fixtures: facetable",
@@ -220,6 +227,7 @@ Shows details of threads and ``asyncio`` tasks. `Threads example <https://latest
 .. code-block:: json
 
     {
+        "ok": true,
         "num_threads": 2,
         "threads": [
             {
@@ -251,6 +259,7 @@ Shows the currently authenticated actor. Useful for debugging Datasette authenti
 .. code-block:: json
 
     {
+        "ok": true,
         "actor": {
             "id": 1,
             "username": "some-user"
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 3df66a8e..27d2d705 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -42,7 +42,7 @@ looks like this:
       "truncated": false
     }
 
-``"ok"`` is always ``true`` if an error did not occur.
+``"ok"`` is always ``true`` if an error did not occur. Every Datasette JSON endpoint that returns an object includes this key on success.
 
 The ``"rows"`` key is a list of objects, each one representing a row.
 
diff --git a/docs/pages.rst b/docs/pages.rst
index ce88be12..67fe390b 100644
--- a/docs/pages.rst
+++ b/docs/pages.rst
@@ -169,11 +169,13 @@ Use ``/-/schema.json`` to get the same information as JSON, which looks like thi
 .. code-block:: json
 
     {
+      "ok": true,
       "schemas": [
         {
           "database": "content",
           "schema": "create table posts ..."
         }
+      ]
     }
 
 .. _DatabaseSchemaView:
@@ -181,11 +183,11 @@ Use ``/-/schema.json`` to get the same information as JSON, which looks like thi
 Database schema
 ---------------
 
-Use ``/database-name/-/schema`` to see the complete schema for a specific database. The ``.md`` and ``.json`` extensions work here too. The JSON returns an object with ``"database"`` and ``"schema"`` keys.
+Use ``/database-name/-/schema`` to see the complete schema for a specific database. The ``.md`` and ``.json`` extensions work here too. The JSON returns an object with ``"ok"``, ``"database"`` and ``"schema"`` keys.
 
 .. _TableSchemaView:
 
 Table schema
 ------------
 
-Use ``/database-name/table-name/-/schema`` to see the schema for a specific table. The ``.md`` and ``.json`` extensions work here too. The JSON returns an object with ``"database"``, ``"table"``, and ``"schema"`` keys.
+Use ``/database-name/table-name/-/schema`` to see the schema for a specific table. The ``.md`` and ``.json`` extensions work here too. The JSON returns an object with ``"ok"``, ``"database"``, ``"table"``, and ``"schema"`` keys.
diff --git a/existing-api.md b/existing-api.md
index d7678613..0e7ec907 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -43,6 +43,15 @@ directory: every claim below is based on the route table in `datasette/app.py`
 - Success content type: `application/json; charset=utf-8`
   (`_shape=array&_nl=on` responses use `text/plain`).
 
+### Success envelope
+
+Every JSON endpoint that returns an object includes `"ok": true` on
+success. `JsonDataView` injects it automatically for dict responses
+(views/special.py); the homepage, jump, schema, permission-debug and
+autocomplete views add it explicitly. The remaining top-level-array
+endpoints (`/-/plugins`, `/-/databases`, `/-/actions`) are being converted
+to objects.
+
 ### Error shape (canonical)
 
 Every JSON error response uses one canonical shape, built by `error_body()`
@@ -190,7 +199,7 @@ Routes: `/(\.(?P<format>jsono?))?$` and `/-/(\.(?P<format>jsono?))?$`
   further filtered by `view-database` / `view-table` for the actor.
 - **Parameters:** `_sort=relationships` sorts each database's truncated table
   list by foreign-key relationship count.
-- **JSON response** (index.py:147-161):
+- **JSON response** (index.py:147-161) — includes `ok: true` plus:
   - `databases` — an **object keyed by database name** (not a list). Each
     value: `name`, `hash` (or null), `color`, `path`,
     `tables_and_views_truncated` (up to 5 items: `name`, `columns`,
@@ -260,7 +269,7 @@ per-database `view-database` permissions**.
 app.py:2574-2579, registered with `permission=None` — **accessible to any
 request including anonymous**. No parameters.
 
-Response: `{"actor": {...}}` or `{"actor": null}` (app.py:2287-2288).
+Response: `{"ok": true, "actor": {...}}` or `{"ok": true, "actor": null}` (app.py:2287-2288).
 
 ### GET /-/actions(.json)
 
@@ -313,7 +322,7 @@ an optional `.json` suffix but the view **always returns JSON**.
   `jump_items_sql` plugin hook).
 - **Parameter:** `q` — whitespace-split terms matched as a case-insensitive
   `%term1%term2%` LIKE pattern.
-- **Response:** `{"matches": [...], "truncated": bool}`; each match:
+- **Response:** `{"ok": true, "matches": [...], "truncated": bool}`; each match:
   `name`, `url`, `type` (`database`/`table`/`view`/`query`/plugin-defined),
   `description`, optional `display_name`. Capped at 100 matches.
 
@@ -324,7 +333,7 @@ an optional `.json` suffix but the view **always returns JSON**.
 - **Permission:** no explicit check; only databases the actor can
   `view-database` are included (others silently omitted).
 - **Formats:** no extension → HTML; `.json` →
-  `{"schemas": [{"database": name, "schema": "..."}]}`; `.md` →
+  `{"ok": true, "schemas": [{"database": name, "schema": "..."}]}`; `.md` →
   `text/markdown` rendering.
 
 ### GET/POST /-/logout
@@ -610,10 +619,9 @@ views/table_create_alter.py:965-1005).
 - **Unknown database** → 404; for `.json`:
   `{"ok": false, "error": "Database not found"}`. (The existence check runs
   before the permission check.)
-- **Responses:** `.json` → 200 `{"database": "<name>", "schema": "<SQL>"}`
+- **Responses:** `.json` → 200 `{"ok": true, "database": "<name>", "schema": "<SQL>"}`
   (concatenated `sqlite_master.sql` joined with `;\n`); `.md` →
-  `text/markdown`; no extension → HTML. Note the JSON has **no `ok` key** on
-  success.
+  `text/markdown`; no extension → HTML.
 
 ---
 
@@ -787,8 +795,8 @@ download attachment. In JSON output, binary cells appear as
 `TableSchemaView` (app.py:2751-2754; views/special.py:1332-1378).
 
 - **Permission:** `view-table` via `ensure_permission` (denied → 403 HTML).
-- **Responses:** `.json` → 200 `{"database", "table", "schema"}` (no `ok`
-  key); `.md` → `text/markdown`; no extension → HTML. Missing table → 404
+- **Responses:** `.json` → 200 `{"ok": true, "database", "table", "schema"}`;
+  `.md` → `text/markdown`; no extension → HTML. Missing table → 404
   `{"ok": false, "error": "Table not found"}` for `.json`.
 
 ### GET /\<database\>/\<table\>/-/fragment
@@ -805,10 +813,10 @@ only — views get 400 `"Autocomplete is only available for tables"`.
 - **Permission:** `view-table` (denied → `Forbidden` → 403).
 - **Parameters:** `q` (matched with escaped `LIKE %q%` against pk columns and
   the label column) and `_initial` (truthy: with empty `q`, return the 10
-  most recent rows). Neither → `{"rows": []}`.
+  most recent rows). Neither → `{"ok": true, "rows": []}`.
 - **Response:** `{"rows": [{"pks": {pk_name: value}, "label": "..."}]}` — max
   10 items; 500 ms query budget with fallbacks, timing out to
-  `{"rows": []}`.
+  `{"ok": true, "rows": []}`.
 
 ---
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 8d8a87b4..48a864af 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -102,7 +102,15 @@ key — see §2.)
 
 ---
 
-## 2. Success envelope: `ok` is not universal, arrays are not extensible (P1/P2)
+## 2. Success envelope: `ok` is not universal, arrays are not extensible (P1/P2) — ✅ PARTIALLY IMPLEMENTED
+
+> **Status:** recommendation 2 and 3 are implemented — every JSON-object
+> success response now includes `"ok": true` (`JsonDataView` injects it for
+> dict responses; homepage, jump, schema, permission-debug and autocomplete
+> views set it explicitly; covered by `tests/test_success_envelope.py`).
+> Recommendation 1 (wrapping the `/-/plugins`, `/-/databases`, `/-/actions`
+> top-level arrays in objects) is being landed as separate per-endpoint
+> commits. §2a/2b/2c remain open.
 
 Endpoints disagree about the success envelope:
 
diff --git a/tests/test_api.py b/tests/test_api.py
index e5ed1d23..4635b236 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -250,6 +250,7 @@ def test_no_files_uses_memory_database(app_client_no_files):
     response = app_client_no_files.get("/.json")
     assert response.status == 200
     assert {
+        "ok": True,
         "databases": {
             "_memory": {
                 "name": "_memory",
@@ -525,7 +526,7 @@ def test_databases_json(app_client_two_attached_databases_one_immutable):
 @pytest.mark.asyncio
 async def test_threads_json(ds_client):
     response = await ds_client.get("/-/threads.json")
-    expected_keys = {"threads", "num_threads"}
+    expected_keys = {"ok", "threads", "num_threads"}
     if sys.version_info >= (3, 7, 0):
         expected_keys.update({"tasks", "num_tasks"})
     data = response.json()
@@ -610,6 +611,7 @@ async def test_actions_json(ds_client):
 async def test_settings_json(ds_client):
     response = await ds_client.get("/-/settings.json")
     assert response.json() == {
+        "ok": True,
         "default_page_size": 50,
         "default_facet_size": 30,
         "default_allow_sql": True,
@@ -884,7 +886,7 @@ async def test_config_json(config, expected):
     "/-/config.json should return redacted configuration"
     ds = Datasette(config=config)
     response = await ds.client.get("/-/config.json")
-    assert response.json() == expected
+    assert response.json() == {"ok": True, **expected}
 
 
 @pytest.mark.asyncio
@@ -980,7 +982,7 @@ async def test_config_json(config, expected):
 async def test_upgrade_metadata(metadata, expected_config, expected_metadata):
     ds = Datasette(metadata=metadata)
     response = await ds.client.get("/-/config.json")
-    assert response.json() == expected_config
+    assert response.json() == {"ok": True, **expected_config}
     response2 = await ds.client.get("/-/metadata.json")
     assert response2.json() == expected_metadata
 
diff --git a/tests/test_auth.py b/tests/test_auth.py
index 5868a21c..8e83d397 100644
--- a/tests/test_auth.py
+++ b/tests/test_auth.py
@@ -294,7 +294,7 @@ async def test_auth_with_dstok_token(ds_client, scenario, should_work):
     try:
         if should_work:
             data = response.json()
-            assert data.keys() == {"actor"}
+            assert data.keys() == {"ok", "actor"}
             actor = data["actor"]
             expected_keys = {"id", "token"}
             if scenario != "valid_unlimited_token":
@@ -305,7 +305,7 @@ async def test_auth_with_dstok_token(ds_client, scenario, should_work):
             if scenario != "valid_unlimited_token":
                 assert isinstance(actor["token_expires"], int)
         else:
-            assert response.json() == {"actor": None}
+            assert response.json() == {"ok": True, "actor": None}
     finally:
         ds_client.ds._settings["allow_signed_tokens"] = True
 
@@ -337,10 +337,10 @@ def test_cli_create_token(app_client, expires):
         }
         if expires and expires > 0:
             expected_actor["token_expires"] = details["t"] + expires
-        assert response.json == {"actor": expected_actor}
+        assert response.json == {"ok": True, "actor": expected_actor}
     else:
         expected_actor = None
-    assert response.json == {"actor": expected_actor}
+    assert response.json == {"ok": True, "actor": expected_actor}
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_autocomplete.py b/tests/test_autocomplete.py
index 76b9c902..194fcf01 100644
--- a/tests/test_autocomplete.py
+++ b/tests/test_autocomplete.py
@@ -25,13 +25,14 @@ async def test_autocomplete_single_pk_exact_match_and_label_order():
 
     assert response.status_code == 200
     assert response.json() == {
+        "ok": True,
         "rows": [
             {"pks": {"id": 2}, "label": "Longer non-label pk match"},
             {"pks": {"id": 20}, "label": "2"},
             {"pks": {"id": 21}, "label": "22"},
             {"pks": {"id": 3}, "label": "A label containing 2"},
             {"pks": {"id": 200}, "label": "A"},
-        ]
+        ],
     }
 
 
@@ -52,12 +53,12 @@ async def test_autocomplete_blank_q_returns_no_results():
     response = await ds.client.get("/autocomplete_blank/people/-/autocomplete?q=")
 
     assert response.status_code == 200
-    assert response.json() == {"rows": []}
+    assert response.json() == {"ok": True, "rows": []}
 
     response = await ds.client.get("/autocomplete_blank/people/-/autocomplete")
 
     assert response.status_code == 200
-    assert response.json() == {"rows": []}
+    assert response.json() == {"ok": True, "rows": []}
 
 
 @pytest.mark.asyncio
@@ -81,11 +82,12 @@ async def test_autocomplete_initial_returns_latest_rows():
 
     assert response.status_code == 200
     assert response.json() == {
+        "ok": True,
         "rows": [
             {"pks": {"id": 3}, "label": "Cleo"},
             {"pks": {"id": 2}, "label": "Bob"},
             {"pks": {"id": 1}, "label": "Alice"},
-        ]
+        ],
     }
 
     response = await ds.client.get(
@@ -94,11 +96,12 @@ async def test_autocomplete_initial_returns_latest_rows():
 
     assert response.status_code == 200
     assert response.json() == {
+        "ok": True,
         "rows": [
             {"pks": {"id": 3}, "label": "Cleo"},
             {"pks": {"id": 2}, "label": "Bob"},
             {"pks": {"id": 1}, "label": "Alice"},
-        ]
+        ],
     }
 
 
@@ -121,9 +124,10 @@ async def test_autocomplete_escapes_like_characters():
 
     assert response.status_code == 200
     assert response.json() == {
+        "ok": True,
         "rows": [
             {"pks": {"id": 1}, "label": "100% real"},
-        ]
+        ],
     }
 
 
@@ -149,11 +153,12 @@ async def test_autocomplete_compound_pk_searches_all_pk_columns():
 
     assert response.status_code == 200
     assert response.json() == {
+        "ok": True,
         "rows": [
             {"pks": {"country": "mx", "code": "ca"}, "label": "Campeche"},
             {"pks": {"country": "us", "code": "ca"}, "label": "California"},
             {"pks": {"country": "ca", "code": "bc"}, "label": "British Columbia"},
-        ]
+        ],
     }
 
 
@@ -184,9 +189,10 @@ async def test_autocomplete_primary_key_called_label():
 
     assert response.status_code == 200
     assert response.json() == {
+        "ok": True,
         "rows": [
             {"pks": {"label": "abc"}, "label": "Display value"},
-        ]
+        ],
     }
 
 
@@ -246,8 +252,9 @@ async def test_autocomplete_timeout_uses_prefix_fallback(monkeypatch):
     assert timeout_was_simulated
     data = response.json()
     assert data == {
+        "ok": True,
         "rows": [
             {"pks": {"id": f"item-1999{i:02d}"}, "label": f"name 1999{i:02d}"}
             for i in range(10)
-        ]
+        ],
     }
diff --git a/tests/test_cli_serve_get.py b/tests/test_cli_serve_get.py
index dc852201..fe9416d6 100644
--- a/tests/test_cli_serve_get.py
+++ b/tests/test_cli_serve_get.py
@@ -95,7 +95,10 @@ def test_serve_with_get_and_token():
         ],
     )
     assert 0 == result2.exit_code, result2.output
-    assert json.loads(result2.output) == {"actor": {"id": "root", "token": "dstok"}}
+    assert json.loads(result2.output) == {
+        "ok": True,
+        "actor": {"id": "root", "token": "dstok"},
+    }
 
 
 def test_serve_with_get_exit_code_for_error():
@@ -130,8 +133,9 @@ def test_serve_get_actor():
     )
     assert result.exit_code == 0
     assert json.loads(result.output) == {
+        "ok": True,
         "actor": {
             "id": "root",
             "extra": "x",
-        }
+        },
     }
diff --git a/tests/test_docs.py b/tests/test_docs.py
index 13b3a549..0bcb5e62 100644
--- a/tests/test_docs.py
+++ b/tests/test_docs.py
@@ -248,7 +248,7 @@ async def test_homepage():
 async def test_actor_is_null():
     ds = Datasette(memory=True)
     response = await ds.client.get("/-/actor.json")
-    assert response.json() == {"actor": None}
+    assert response.json() == {"ok": True, "actor": None}
 # -- end test_actor_is_null --
 
 
@@ -258,5 +258,5 @@ async def test_signed_cookie_actor():
     ds = Datasette(memory=True)
     cookies = {"ds_actor": ds.client.actor_cookie({"id": "root"})}
     response = await ds.client.get("/-/actor.json", cookies=cookies)
-    assert response.json() == {"actor": {"id": "root"}}
+    assert response.json() == {"ok": True, "actor": {"id": "root"}}
 # -- end test_signed_cookie_actor --
diff --git a/tests/test_internals_datasette.py b/tests/test_internals_datasette.py
index 2eaee3f9..1de394a5 100644
--- a/tests/test_internals_datasette.py
+++ b/tests/test_internals_datasette.py
@@ -188,7 +188,7 @@ async def test_num_sql_threads_zero():
     await db.execute_write("create table t(id integer primary key)")
     await db.execute_write("insert into t (id) values (1)")
     response = await ds.client.get("/-/threads.json")
-    assert response.json() == {"num_threads": 0, "threads": []}
+    assert response.json() == {"ok": True, "num_threads": 0, "threads": []}
     response2 = await ds.client.get("/test_num_sql_threads_zero/t.json?_shape=array")
     assert response2.json() == [{"id": 1}]
 
diff --git a/tests/test_internals_datasette_client.py b/tests/test_internals_datasette_client.py
index 543077a5..e9aaaae8 100644
--- a/tests/test_internals_datasette_client.py
+++ b/tests/test_internals_datasette_client.py
@@ -318,7 +318,7 @@ async def test_actor_parameter_sets_cookie(datasette):
     """Passing actor= should sign a ds_actor cookie and authenticate the request."""
     response = await datasette.client.get("/-/actor.json", actor={"id": "root"})
     assert response.status_code == 200
-    assert response.json() == {"actor": {"id": "root"}}
+    assert response.json() == {"ok": True, "actor": {"id": "root"}}
 
 
 @pytest.mark.asyncio
@@ -327,7 +327,7 @@ async def test_actor_parameter_works_with_request_method(datasette):
         "GET", "/-/actor.json", actor={"id": "root"}
     )
     assert response.status_code == 200
-    assert response.json() == {"actor": {"id": "root"}}
+    assert response.json() == {"ok": True, "actor": {"id": "root"}}
 
 
 @pytest.mark.asyncio
@@ -362,7 +362,7 @@ async def test_actor_parameter_merges_with_other_cookies(datasette):
         cookies={"unrelated": "value"},
     )
     assert response.status_code == 200
-    assert response.json() == {"actor": {"id": "root"}}
+    assert response.json() == {"ok": True, "actor": {"id": "root"}}
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 8323fe92..7d99213b 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -739,6 +739,7 @@ async def test_actor_restricted_permissions(
         "path": expected_path,
     }
     expected = {
+        "ok": True,
         "action": permission,
         "allowed": expected_result,
         "resource": expected_resource,
@@ -1115,7 +1116,7 @@ def test_cli_create_token(options, expected):
         ],
     )
     assert 0 == result2.exit_code, result2.output
-    assert json.loads(result2.output) == {"actor": expected}
+    assert json.loads(result2.output) == {"ok": True, "actor": expected}
 
 
 _visible_tables_re = re.compile(r">\/((\w+)\/(\w+))\.json<\/a> - Get rows for")
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index da14c714..59b1c0bf 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -783,9 +783,13 @@ async def test_hook_permission_resources_sql():
 
 @pytest.mark.asyncio
 async def test_actor_json(ds_client):
-    assert (await ds_client.get("/-/actor.json")).json() == {"actor": None}
+    assert (await ds_client.get("/-/actor.json")).json() == {
+        "ok": True,
+        "actor": None,
+    }
     assert (await ds_client.get("/-/actor.json?_bot2=1")).json() == {
-        "actor": {"id": "bot2", "1+1": 2}
+        "ok": True,
+        "actor": {"id": "bot2", "1+1": 2},
     }
 
 
diff --git a/tests/test_success_envelope.py b/tests/test_success_envelope.py
new file mode 100644
index 00000000..48407660
--- /dev/null
+++ b/tests/test_success_envelope.py
@@ -0,0 +1,78 @@
+"""
+Tests for the canonical JSON success envelope.
+
+Every JSON object returned by a Datasette endpoint on success should include
+"ok": true. (Endpoints that return a top-level array are being converted to
+objects separately - see /-/plugins, /-/databases, /-/actions.)
+"""
+
+import pytest
+from datasette.app import Datasette
+from datasette.utils import sqlite3
+
+
+@pytest.fixture
+def ds_envelope(tmp_path_factory):
+    db_directory = tmp_path_factory.mktemp("dbs")
+    db_path = str(db_directory / "data.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("vacuum")
+    conn.execute("create table docs (id integer primary key, title text)")
+    conn.close()
+    ds = Datasette([db_path])
+    ds.root_enabled = True
+    yield ds
+    ds.close()
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "path",
+    (
+        "/.json",
+        "/-/.json",
+        "/-/versions.json",
+        "/-/settings.json",
+        "/-/config.json",
+        "/-/threads.json",
+        "/-/actor.json",
+        "/-/jump.json",
+        "/-/schema.json",
+        "/fixtures/-/schema.json",
+        "/fixtures/facetable/-/schema.json",
+        "/-/allowed.json?action=view-instance",
+        "/fixtures/facet_cities/-/autocomplete?_initial=1",
+    ),
+)
+async def test_success_object_has_ok_true(ds_client, path):
+    response = await ds_client.get(path)
+    assert response.status_code == 200
+    data = response.json()
+    assert isinstance(data, dict)
+    assert data["ok"] is True
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "path",
+    (
+        "/-/rules.json?action=view-instance",
+        "/-/check.json?action=view-instance",
+    ),
+)
+async def test_permission_debug_success_has_ok_true(ds_envelope, path):
+    response = await ds_envelope.client.get(path, actor={"id": "root"})
+    assert response.status_code == 200
+    data = response.json()
+    assert data["ok"] is True
+
+
+@pytest.mark.asyncio
+async def test_permissions_post_success_has_ok_true(ds_envelope):
+    response = await ds_envelope.client.post(
+        "/-/permissions",
+        data={"actor": '{"id": "root"}', "permission": "view-instance"},
+        actor={"id": "root"},
+    )
+    assert response.status_code == 200
+    assert response.json()["ok"] is True

From b74a8e5b12b6e69a8717d0b0b7a37f12162f8ffc Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 13:42:24 +0000
Subject: [PATCH 326/386] Convert /-/plugins.json from top-level array to
 object

/-/plugins.json now returns {"ok": true, "plugins": [...]} instead of a
bare JSON array, so the response can grow additional keys without a
breaking change. The `datasette plugins` CLI command still outputs a
plain array.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/app.py               |  5 ++++-
 docs/introspection.rst         | 21 ++++++++++++---------
 existing-api.md                |  4 ++--
 tests/test_api.py              |  4 ++--
 tests/test_config_dir.py       |  7 ++++---
 tests/test_plugins.py          |  2 +-
 tests/test_success_envelope.py | 14 ++++++++++++++
 7 files changed, 39 insertions(+), 18 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index e13f0731..b554f9bc 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2551,7 +2551,10 @@ class Datasette:
         )
         add_route(
             JsonDataView.as_view(
-                self, "plugins.json", self._plugins, needs_request=True
+                self,
+                "plugins.json",
+                lambda request: {"plugins": self._plugins(request)},
+                needs_request=True,
             ),
             r"/-/plugins(\.(?P<format>json))?$",
         )
diff --git a/docs/introspection.rst b/docs/introspection.rst
index d0780763..99238204 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -78,15 +78,18 @@ Shows a list of currently installed plugins and their versions. `Plugins example
 
 .. code-block:: json
 
-    [
-        {
-            "name": "datasette_cluster_map",
-            "static": true,
-            "templates": false,
-            "version": "0.10",
-            "hooks": ["extra_css_urls", "extra_js_urls", "extra_body_script"]
-        }
-    ]
+    {
+        "ok": true,
+        "plugins": [
+            {
+                "name": "datasette_cluster_map",
+                "static": true,
+                "templates": false,
+                "version": "0.10",
+                "hooks": ["extra_css_urls", "extra_js_urls", "extra_body_script"]
+            }
+        ]
+    }
 
 Add ``?all=1`` to include details of the default plugins baked into Datasette.
 
diff --git a/existing-api.md b/existing-api.md
index 0e7ec907..db613d30 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -228,8 +228,8 @@ app.py:2552-2557, `Datasette._plugins` (app.py:2247-2266). Permission
 
 - **Parameters:** `?all=1` — include Datasette's built-in default plugins
   (filtered out by default).
-- **Response:** a JSON **array**, sorted by name, of
-  `{"name", "static", "templates", "version", "hooks"}`.
+- **Response:** `{"ok": true, "plugins": [...]}` — each plugin is
+  `{"name", "static", "templates", "version", "hooks"}`, sorted by name.
 
 ### GET /-/settings(.json)
 
diff --git a/tests/test_api.py b/tests/test_api.py
index 4635b236..3583503c 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -541,13 +541,13 @@ async def test_plugins_json(ds_client):
     response = await ds_client.get("/-/plugins.json")
     # Filter out TrackEventPlugin
     actual_plugins = sorted(
-        [p for p in response.json() if p["name"] != "TrackEventPlugin"],
+        [p for p in response.json()["plugins"] if p["name"] != "TrackEventPlugin"],
         key=lambda p: p["name"],
     )
     assert EXPECTED_PLUGINS == actual_plugins
     # Try with ?all=1
     response = await ds_client.get("/-/plugins.json?all=1")
-    names = {p["name"] for p in response.json()}
+    names = {p["name"] for p in response.json()["plugins"]}
     assert names.issuperset(p["name"] for p in EXPECTED_PLUGINS)
     assert names.issuperset(DEFAULT_PLUGINS)
 
diff --git a/tests/test_config_dir.py b/tests/test_config_dir.py
index 0a9b30d8..74407e20 100644
--- a/tests/test_config_dir.py
+++ b/tests/test_config_dir.py
@@ -109,9 +109,10 @@ def test_settings(config_dir_client):
 def test_plugins(config_dir_client):
     response = config_dir_client.get("/-/plugins.json")
     assert 200 == response.status
-    assert "hooray.py" in {p["name"] for p in response.json}
-    assert "non_py_file.txt" not in {p["name"] for p in response.json}
-    assert "mypy_cache" not in {p["name"] for p in response.json}
+    plugins = response.json["plugins"]
+    assert "hooray.py" in {p["name"] for p in plugins}
+    assert "non_py_file.txt" not in {p["name"] for p in plugins}
+    assert "mypy_cache" not in {p["name"] for p in plugins}
 
 
 def test_templates_and_plugin(config_dir_client):
diff --git a/tests/test_plugins.py b/tests/test_plugins.py
index 59b1c0bf..5c4034db 100644
--- a/tests/test_plugins.py
+++ b/tests/test_plugins.py
@@ -1482,7 +1482,7 @@ async def test_plugin_is_installed():
         datasette.pm.register(DummyPlugin(), name="DummyPlugin")
         response = await datasette.client.get("/-/plugins.json")
         assert response.status_code == 200
-        installed_plugins = {p["name"] for p in response.json()}
+        installed_plugins = {p["name"] for p in response.json()["plugins"]}
         assert "DummyPlugin" in installed_plugins
 
     finally:
diff --git a/tests/test_success_envelope.py b/tests/test_success_envelope.py
index 48407660..cecc8d70 100644
--- a/tests/test_success_envelope.py
+++ b/tests/test_success_envelope.py
@@ -76,3 +76,17 @@ async def test_permissions_post_success_has_ok_true(ds_envelope):
     )
     assert response.status_code == 200
     assert response.json()["ok"] is True
+
+
+@pytest.mark.asyncio
+async def test_plugins_json_is_object(ds_client):
+    response = await ds_client.get("/-/plugins.json")
+    assert response.status_code == 200
+    data = response.json()
+    assert set(data.keys()) == {"ok", "plugins"}
+    assert data["ok"] is True
+    assert isinstance(data["plugins"], list)
+    # ?all=1 should include Datasette's default plugins in the same shape
+    response_all = await ds_client.get("/-/plugins.json?all=1")
+    all_plugins = response_all.json()["plugins"]
+    assert len(all_plugins) > len(data["plugins"])

From 19e54b10d4d955e22346339a38f34190e3a1b36b Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 13:43:44 +0000
Subject: [PATCH 327/386] Convert /-/databases.json from top-level array to
 object

/-/databases.json now returns {"ok": true, "databases": [...]} instead
of a bare JSON array, so the response can grow additional keys without
a breaking change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/app.py                  |  6 +++++-
 docs/introspection.rst            | 23 +++++++++++++----------
 existing-api.md                   |  7 ++++---
 tests/test_api.py                 |  6 ++++--
 tests/test_cli.py                 |  6 +++---
 tests/test_config_dir.py          |  2 +-
 tests/test_internals_datasette.py |  2 +-
 tests/test_routes.py              |  2 +-
 tests/test_success_envelope.py    | 11 +++++++++++
 9 files changed, 43 insertions(+), 22 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index b554f9bc..bc35669f 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2571,7 +2571,11 @@ class Datasette:
             r"/-/threads(\.(?P<format>json))?$",
         )
         add_route(
-            JsonDataView.as_view(self, "databases.json", self._connected_databases),
+            JsonDataView.as_view(
+                self,
+                "databases.json",
+                lambda: {"databases": self._connected_databases()},
+            ),
             r"/-/databases(\.(?P<format>json))?$",
         )
         add_route(
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 99238204..ab47c0a5 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -141,16 +141,19 @@ Shows currently attached databases. `Databases example <https://latest.datasette
 
 .. code-block:: json
 
-    [
-        {
-            "hash": null,
-            "is_memory": false,
-            "is_mutable": true,
-            "name": "fixtures",
-            "path": "fixtures.db",
-            "size": 225280
-        }
-    ]
+    {
+        "ok": true,
+        "databases": [
+            {
+                "hash": null,
+                "is_memory": false,
+                "is_mutable": true,
+                "name": "fixtures",
+                "path": "fixtures.db",
+                "size": 225280
+            }
+        ]
+    }
 
 .. _JumpView:
 
diff --git a/existing-api.md b/existing-api.md
index db613d30..3348433f 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -260,9 +260,10 @@ Response: `num_threads`, `threads` (list of `{name, ident, daemon}`),
 app.py:2570-2573, `Datasette._connected_databases` (app.py:2157-2169).
 Permission `view-instance`. No parameters.
 
-Response: a JSON array of `{"name", "route", "path", "size", "is_mutable",
-"is_memory", "hash"}` — **all attached databases are listed regardless of
-per-database `view-database` permissions**.
+Response: `{"ok": true, "databases": [...]}` — each database is
+`{"name", "route", "path", "size", "is_mutable", "is_memory", "hash"}`.
+**All attached databases are listed regardless of per-database
+`view-database` permissions**.
 
 ### GET /-/actor(.json)
 
diff --git a/tests/test_api.py b/tests/test_api.py
index 3583503c..3263a88c 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -509,7 +509,7 @@ async def test_row_extra_render_cell():
 
 def test_databases_json(app_client_two_attached_databases_one_immutable):
     response = app_client_two_attached_databases_one_immutable.get("/-/databases.json")
-    databases = response.json
+    databases = response.json["databases"]
     assert 2 == len(databases)
     extra_database, fixtures_database = databases
     assert "extra database" == extra_database["name"]
@@ -775,7 +775,9 @@ def test_common_prefix_database_names(app_client_conflicting_database_names):
     # https://github.com/simonw/datasette/issues/597
     assert ["foo-bar", "foo", "fixtures"] == [
         d["name"]
-        for d in app_client_conflicting_database_names.get("/-/databases.json").json
+        for d in app_client_conflicting_database_names.get("/-/databases.json").json[
+            "databases"
+        ]
     ]
     for db_name, path in (("foo", "/foo.json"), ("foo-bar", "/foo-bar.json")):
         data = app_client_conflicting_database_names.get(path).json
diff --git a/tests/test_cli.py b/tests/test_cli.py
index f86d6909..7b528a8e 100644
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -444,7 +444,7 @@ def test_serve_create(tmpdir):
         cli, [str(db_path), "--create", "--get", "/-/databases.json"]
     )
     assert result.exit_code == 0, result.output
-    databases = json.loads(result.output)
+    databases = json.loads(result.output)["databases"]
     assert {
         "name": "does_not_exist_yet",
         "is_mutable": True,
@@ -493,7 +493,7 @@ def test_serve_duplicate_database_names(tmpdir):
         conn.close()
     result = runner.invoke(cli, [db_1_path, db_2_path, "--get", "/-/databases.json"])
     assert result.exit_code == 0, result.output
-    databases = json.loads(result.output)
+    databases = json.loads(result.output)["databases"]
     assert {db["name"] for db in databases} == {"db", "db_2"}
 
 
@@ -585,7 +585,7 @@ def test_duplicate_database_files_error(tmpdir):
         cli, ["serve", other_db_path, str(config_dir), "--get", "/-/databases.json"]
     )
     assert result4.exit_code == 0
-    databases = json.loads(result4.output)
+    databases = json.loads(result4.output)["databases"]
     assert {db["name"] for db in databases} == {"other", "data"}
 
     # Test that multiple directories raise an error
diff --git a/tests/test_config_dir.py b/tests/test_config_dir.py
index 74407e20..42c6ae60 100644
--- a/tests/test_config_dir.py
+++ b/tests/test_config_dir.py
@@ -137,7 +137,7 @@ def test_static_directory_browsing_not_allowed(config_dir_client):
 def test_databases(config_dir_client):
     response = config_dir_client.get("/-/databases.json")
     assert 200 == response.status
-    databases = response.json
+    databases = response.json["databases"]
     assert 4 == len(databases)
     databases.sort(key=lambda d: d["name"])
     for db, expected_name in zip(databases, ("demo", "immutable", "j", "k")):
diff --git a/tests/test_internals_datasette.py b/tests/test_internals_datasette.py
index 1de394a5..2af069c9 100644
--- a/tests/test_internals_datasette.py
+++ b/tests/test_internals_datasette.py
@@ -167,7 +167,7 @@ def test_static_rejects_path_traversal(tmp_path, monkeypatch):
 @pytest.mark.asyncio
 async def test_datasette_constructor():
     ds = Datasette()
-    databases = (await ds.client.get("/-/databases.json")).json()
+    databases = (await ds.client.get("/-/databases.json")).json()["databases"]
     assert databases == [
         {
             "name": "_memory",
diff --git a/tests/test_routes.py b/tests/test_routes.py
index 24c702fc..4965ce76 100644
--- a/tests/test_routes.py
+++ b/tests/test_routes.py
@@ -73,7 +73,7 @@ async def ds_with_route():
 @pytest.mark.asyncio
 async def test_db_with_route_databases(ds_with_route):
     response = await ds_with_route.client.get("/-/databases.json")
-    assert response.json()[0] == {
+    assert response.json()["databases"][0] == {
         "name": "original-name",
         "route": "custom-route-name",
         "path": None,
diff --git a/tests/test_success_envelope.py b/tests/test_success_envelope.py
index cecc8d70..290a51e0 100644
--- a/tests/test_success_envelope.py
+++ b/tests/test_success_envelope.py
@@ -90,3 +90,14 @@ async def test_plugins_json_is_object(ds_client):
     response_all = await ds_client.get("/-/plugins.json?all=1")
     all_plugins = response_all.json()["plugins"]
     assert len(all_plugins) > len(data["plugins"])
+
+
+@pytest.mark.asyncio
+async def test_databases_json_is_object(ds_client):
+    response = await ds_client.get("/-/databases.json")
+    assert response.status_code == 200
+    data = response.json()
+    assert set(data.keys()) == {"ok", "databases"}
+    assert data["ok"] is True
+    assert isinstance(data["databases"], list)
+    assert "fixtures" in {db["name"] for db in data["databases"]}

From 23ccdaeffc1d403563933af5fcfa90be6947f7f4 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 13:46:26 +0000
Subject: [PATCH 328/386] Convert /-/actions.json from top-level array to
 object

/-/actions.json now returns {"ok": true, "actions": [...]} instead of a
bare JSON array, so the response can grow additional keys without a
breaking change. The debug_actions.html template reads data.actions,
and the endpoint is now documented in docs/introspection.rst.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/app.py                       |  2 +-
 datasette/templates/debug_actions.html |  4 ++--
 docs/introspection.rst                 | 24 ++++++++++++++++++++++++
 existing-api.md                        | 12 ++++++------
 stable-api-recommendations.md          | 19 +++++++++++--------
 tests/test_api.py                      |  2 +-
 tests/test_success_envelope.py         | 11 +++++++++++
 7 files changed, 56 insertions(+), 18 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index bc35669f..5afca2a2 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2588,7 +2588,7 @@ class Datasette:
             JsonDataView.as_view(
                 self,
                 "actions.json",
-                self._actions,
+                lambda: {"actions": self._actions()},
                 template="debug_actions.html",
                 permission="permissions-debug",
             ),
diff --git a/datasette/templates/debug_actions.html b/datasette/templates/debug_actions.html
index 0ef7b329..c9dccaaa 100644
--- a/datasette/templates/debug_actions.html
+++ b/datasette/templates/debug_actions.html
@@ -9,7 +9,7 @@
 {% include "_permissions_debug_tabs.html" %}
 
 <p style="margin-bottom: 2em;">
-  This Datasette instance has registered {{ data|length }} action{{ data|length != 1 and "s" or "" }}.
+  This Datasette instance has registered {{ data.actions|length }} action{{ data.actions|length != 1 and "s" or "" }}.
   Actions are used by the permission system to control access to different features.
 </p>
 
@@ -26,7 +26,7 @@
     </tr>
   </thead>
   <tbody>
-    {% for action in data %}
+    {% for action in data.actions %}
     <tr>
       <td><strong>{{ action.name }}</strong></td>
       <td>{% if action.abbr %}<code>{{ action.abbr }}</code>{% endif %}</td>
diff --git a/docs/introspection.rst b/docs/introspection.rst
index ab47c0a5..0010e8b7 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -155,6 +155,30 @@ Shows currently attached databases. `Databases example <https://latest.datasette
         ]
     }
 
+.. _JsonDataView_actions:
+
+/-/actions
+----------
+
+Shows all actions registered with the permission system, including those added by plugins. Requires the ``permissions-debug`` permission.
+
+.. code-block:: json
+
+    {
+        "ok": true,
+        "actions": [
+            {
+                "name": "view-instance",
+                "abbr": "vi",
+                "description": "View Datasette instance",
+                "takes_parent": false,
+                "takes_child": false,
+                "resource_class": null,
+                "also_requires": null
+            }
+        ]
+    }
+
 .. _JumpView:
 
 /-/jump
diff --git a/existing-api.md b/existing-api.md
index 3348433f..5168819a 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -48,9 +48,9 @@ directory: every claim below is based on the route table in `datasette/app.py`
 Every JSON endpoint that returns an object includes `"ok": true` on
 success. `JsonDataView` injects it automatically for dict responses
 (views/special.py); the homepage, jump, schema, permission-debug and
-autocomplete views add it explicitly. The remaining top-level-array
-endpoints (`/-/plugins`, `/-/databases`, `/-/actions`) are being converted
-to objects.
+autocomplete views add it explicitly. The former top-level-array endpoints
+(`/-/plugins`, `/-/databases`, `/-/actions`) now return objects wrapping
+their arrays (`{"ok": true, "plugins": [...]}` etc.).
 
 ### Error shape (canonical)
 
@@ -276,9 +276,9 @@ Response: `{"ok": true, "actor": {...}}` or `{"ok": true, "actor": null}` (app.p
 
 app.py:2580-2589. Permission **`permissions-debug`**. No parameters.
 
-Response: a JSON array, sorted by name, of `{"name", "abbr", "description",
-"takes_parent", "takes_child", "resource_class", "also_requires"}`
-(app.py:2290-2304).
+Response: `{"ok": true, "actions": [...]}` — each action is
+`{"name", "abbr", "description", "takes_parent", "takes_child",
+"resource_class", "also_requires"}`, sorted by name (app.py:2290-2304).
 
 ### GET /-/auth-token
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 48a864af..bee4b414 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -102,15 +102,18 @@ key — see §2.)
 
 ---
 
-## 2. Success envelope: `ok` is not universal, arrays are not extensible (P1/P2) — ✅ PARTIALLY IMPLEMENTED
+## 2. Success envelope: `ok` is not universal, arrays are not extensible (P1/P2) — ✅ IMPLEMENTED (§2a-2c open)
 
-> **Status:** recommendation 2 and 3 are implemented — every JSON-object
+> **Status:** recommendations 1-3 are implemented. Every JSON-object
 > success response now includes `"ok": true` (`JsonDataView` injects it for
 > dict responses; homepage, jump, schema, permission-debug and autocomplete
-> views set it explicitly; covered by `tests/test_success_envelope.py`).
-> Recommendation 1 (wrapping the `/-/plugins`, `/-/databases`, `/-/actions`
-> top-level arrays in objects) is being landed as separate per-endpoint
-> commits. §2a/2b/2c remain open.
+> views set it explicitly), and the three top-level-array endpoints now
+> return objects: `/-/plugins` → `{"ok": true, "plugins": [...]}`,
+> `/-/databases` → `{"ok": true, "databases": [...]}`, `/-/actions` →
+> `{"ok": true, "actions": [...]}`. Covered by
+> `tests/test_success_envelope.py`. The sub-findings §2a (collection
+> representations), §2b (`_extra`/`_shape` coverage) and §2c (count
+> truncation) remain open.
 
 Endpoints disagree about the success envelope:
 
@@ -372,8 +375,8 @@ Two details make tiering urgent rather than optional:
 2. `Forbidden` → JSON 403 for JSON requests (§1a).
 3. No `ok: false` with HTTP 200 (§1b: `_shape=object`, write canned-query
    SQL errors).
-4. Wrap `/-/plugins`, `/-/databases`, `/-/actions` top-level arrays in
-   objects (§2).
+4. ~~Wrap `/-/plugins`, `/-/databases`, `/-/actions` top-level arrays in
+   objects (§2).~~ ✅ Done.
 5. Filter `/-/databases.json` by `view-database` or gate it behind
    `permissions-debug` (§6).
 6. 401 (not silent-anonymous) for invalid/expired bearer tokens (§1c).
diff --git a/tests/test_api.py b/tests/test_api.py
index 3263a88c..b035edb9 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -579,7 +579,7 @@ async def test_actions_json(ds_client):
     try:
         ds_client.ds.root_enabled = True
         response = await ds_client.get("/-/actions.json", actor={"id": "root"})
-        data = response.json()
+        data = response.json()["actions"]
     finally:
         ds_client.ds.root_enabled = original_root_enabled
     assert isinstance(data, list)
diff --git a/tests/test_success_envelope.py b/tests/test_success_envelope.py
index 290a51e0..22ce6580 100644
--- a/tests/test_success_envelope.py
+++ b/tests/test_success_envelope.py
@@ -101,3 +101,14 @@ async def test_databases_json_is_object(ds_client):
     assert data["ok"] is True
     assert isinstance(data["databases"], list)
     assert "fixtures" in {db["name"] for db in data["databases"]}
+
+
+@pytest.mark.asyncio
+async def test_actions_json_is_object(ds_envelope):
+    response = await ds_envelope.client.get("/-/actions.json", actor={"id": "root"})
+    assert response.status_code == 200
+    data = response.json()
+    assert set(data.keys()) == {"ok", "actions"}
+    assert data["ok"] is True
+    assert isinstance(data["actions"], list)
+    assert "view-instance" in {action["name"] for action in data["actions"]}

From f091b6dab165ec9f3a1d7689604abe97e102e60f Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 14:00:30 +0000
Subject: [PATCH 329/386] Filter /-/databases by view-database permission

/-/databases previously listed every attached database (including
filesystem paths and sizes) to any actor with view-instance, while the
homepage and every other endpoint filtered by view-database. The
endpoint now only lists databases the current actor is allowed to view.

JsonDataView data callbacks may now be async.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/app.py              | 15 ++++++++++++++-
 datasette/views/special.py    |  4 ++--
 docs/introspection.rst        |  2 +-
 existing-api.md               |  3 +--
 stable-api-recommendations.md |  9 +++++----
 tests/test_permissions.py     | 32 ++++++++++++++++++++++++++++++++
 6 files changed, 55 insertions(+), 10 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 5afca2a2..dd5d7e8c 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2168,6 +2168,18 @@ class Datasette:
             for name, d in self.databases.items()
         ]
 
+    async def _connected_databases_for_actor(self, actor):
+        page = await self.allowed_resources("view-database", actor)
+        allowed_names = {resource.parent async for resource in page.all()}
+        return [
+            database
+            for database in self._connected_databases()
+            if database["name"] in allowed_names
+        ]
+
+    async def _databases_data(self, request):
+        return {"databases": await self._connected_databases_for_actor(request.actor)}
+
     def _versions(self):
         conn = sqlite3.connect(":memory:")
         self._prepare_connection(conn, "_memory")
@@ -2574,7 +2586,8 @@ class Datasette:
             JsonDataView.as_view(
                 self,
                 "databases.json",
-                lambda: {"databases": self._connected_databases()},
+                self._databases_data,
+                needs_request=True,
             ),
             r"/-/databases(\.(?P<format>json))?$",
         )
diff --git a/datasette/views/special.py b/datasette/views/special.py
index c289a240..82a76e76 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -53,9 +53,9 @@ class JsonDataView(BaseView):
         if self.permission:
             await self.ds.ensure_permission(action=self.permission, actor=request.actor)
         if self.needs_request:
-            data = self.data_callback(request)
+            data = await await_me_maybe(self.data_callback(request))
         else:
-            data = self.data_callback()
+            data = await await_me_maybe(self.data_callback())
 
         # Return JSON or HTML depending on format parameter
         as_format = request.url_vars.get("format")
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 0010e8b7..37f258d7 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -137,7 +137,7 @@ Any keys that include the one of the following substrings in their names will be
 /-/databases
 ------------
 
-Shows currently attached databases. `Databases example <https://latest.datasette.io/-/databases>`_:
+Shows currently attached databases that the current actor is allowed to view, based on the ``view-database`` permission. `Databases example <https://latest.datasette.io/-/databases>`_:
 
 .. code-block:: json
 
diff --git a/existing-api.md b/existing-api.md
index 5168819a..722331cd 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -262,8 +262,7 @@ Permission `view-instance`. No parameters.
 
 Response: `{"ok": true, "databases": [...]}` — each database is
 `{"name", "route", "path", "size", "is_mutable", "is_memory", "hash"}`.
-**All attached databases are listed regardless of per-database
-`view-database` permissions**.
+Only databases the actor is allowed to `view-database` are listed.
 
 ### GET /-/actor(.json)
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index bee4b414..a8690f51 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -260,12 +260,13 @@ Concerns:
 
 ## 6. Permissions and security consistency (P1/P2)
 
-- **(P1) `/-/databases.json` ignores per-database permissions** — it lists
+- ~~**(P1) `/-/databases.json` ignores per-database permissions** — it lists
   every attached database (name, path on disk, size) to any actor holding
   `view-instance` (app.py:2157-2169), while the homepage and every other
   endpoint filter by `view-database`. On a public instance with private
   databases this leaks filesystem paths and database names. Filter it, or
-  gate it behind `permissions-debug`.
+  gate it behind `permissions-debug`.~~ ✅ **Done** — the endpoint now
+  filters through `allowed_resources("view-database", actor)`.
 - **(P2) `/db/-/schema` checks existence before permission**
   (views/special.py:1308-1317): an actor without `view-database` can
   distinguish "database exists" (403) from "does not exist" (404).
@@ -377,8 +378,8 @@ Two details make tiering urgent rather than optional:
    SQL errors).
 4. ~~Wrap `/-/plugins`, `/-/databases`, `/-/actions` top-level arrays in
    objects (§2).~~ ✅ Done.
-5. Filter `/-/databases.json` by `view-database` or gate it behind
-   `permissions-debug` (§6).
+5. ~~Filter `/-/databases.json` by `view-database` or gate it behind
+   `permissions-debug` (§6).~~ ✅ Done.
 6. 401 (not silent-anonymous) for invalid/expired bearer tokens (§1c).
 7. Publish explicit stability tiers, including extras and pagination-token
    opacity (§9).
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 7d99213b..32606789 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -1800,3 +1800,35 @@ async def test_root_allow_block_with_table_restricted_actor():
         actor=admin_actor,
     )
     assert result is True
+
+
+@pytest.mark.asyncio
+async def test_databases_json_respects_view_database(tmp_path_factory):
+    # https://github.com/simonw/datasette - /-/databases should not list
+    # databases the actor is not allowed to view
+    db_directory = tmp_path_factory.mktemp("dbs")
+    from datasette.utils import sqlite3 as _sqlite3
+
+    paths = []
+    for name in ("public", "private"):
+        path = str(db_directory / "{}.db".format(name))
+        conn = _sqlite3.connect(path)
+        conn.execute("vacuum")
+        conn.close()
+        paths.append(path)
+    ds = Datasette(
+        paths,
+        config={"databases": {"private": {"allow": {"id": "root"}}}},
+    )
+    ds.root_enabled = True
+    await ds.invoke_startup()
+    try:
+        anon_response = await ds.client.get("/-/databases.json")
+        assert anon_response.status_code == 200
+        anon_names = {db["name"] for db in anon_response.json()["databases"]}
+        assert anon_names == {"public"}
+        root_response = await ds.client.get("/-/databases.json", actor={"id": "root"})
+        root_names = {db["name"] for db in root_response.json()["databases"]}
+        assert root_names == {"public", "private"}
+    finally:
+        ds.close()

From ae10a99811111ff81413cc8da1210b6e824d54ff Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 14:09:01 +0000
Subject: [PATCH 330/386] Return canonical JSON error for Forbidden on JSON
 requests

The default forbidden() hook previously rendered an HTML error page even
for .json requests. It now returns the canonical JSON error shape with
status 403 when the request path ends in .json or the request sends an
Accept: application/json or Content-Type: application/json header. HTML
requests still get the error page.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/forbidden.py        | 10 +++++++
 docs/json_api.rst             |  5 ++++
 docs/plugin_hooks.rst         |  2 ++
 existing-api.md               | 14 +++++-----
 stable-api-recommendations.md | 14 ++++++----
 tests/test_cli.py             |  9 ++++---
 tests/test_error_shape.py     | 49 +++++++++++++++++++++++++++++++++++
 7 files changed, 88 insertions(+), 15 deletions(-)

diff --git a/datasette/forbidden.py b/datasette/forbidden.py
index 41c48396..3a81ac4f 100644
--- a/datasette/forbidden.py
+++ b/datasette/forbidden.py
@@ -1,9 +1,19 @@
 from datasette import hookimpl, Response
+from .utils import add_cors_headers, error_body
 
 
 @hookimpl(trylast=True)
 def forbidden(datasette, request, message):
     async def inner():
+        if (
+            request.path.split("?")[0].endswith(".json")
+            or "application/json" in (request.headers.get("accept") or "")
+            or request.headers.get("content-type") == "application/json"
+        ):
+            headers = {}
+            if datasette.cors:
+                add_cors_headers(headers)
+            return Response.json(error_body(message, 403), status=403, headers=headers)
         return Response.html(
             await datasette.render_template(
                 "error.html",
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 27d2d705..a561aa9c 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -81,6 +81,11 @@ Some endpoints add extra context keys. For example, a SQL error from a
 ``"rows"`` and ``"truncated"`` keys of the response it was unable to
 produce.
 
+Permission errors use the same format: a request that fails a permission
+check receives a ``403`` with this JSON error body when the URL ends in
+``.json`` or the request sends an ``Accept: application/json`` or
+``Content-Type: application/json`` header.
+
 .. _json_api_custom_sql:
 
 Executing custom SQL
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 81ef4acd..8614a15c 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -1685,6 +1685,8 @@ forbidden(datasette, request, message)
 
 Plugins can use this to customize how Datasette responds when a 403 Forbidden error occurs - usually because a page failed a permission check, see :ref:`authentication_permissions`.
 
+Datasette's default behavior returns the :ref:`standard JSON error format <json_api_errors>` with a 403 status when the request path ends in ``.json`` or the request has an ``Accept: application/json`` or ``Content-Type: application/json`` header; other requests get an HTML error page.
+
 If a plugin hook wishes to react to the error, it should return a :ref:`Response object <internals_response>`.
 
 This example returns a redirect to a ``/-/login`` page:
diff --git a/existing-api.md b/existing-api.md
index 722331cd..90a931d1 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -98,13 +98,13 @@ Method-not-allowed responses return HTTP 405 with the canonical shape when
 the path ends in `.json` or the request content type is `application/json`;
 plain text otherwise (views/base.py).
 
-**`Forbidden` is special:** when a view raises `Forbidden` (e.g. via
-`ensure_permission`), the default `forbidden()` plugin hook renders an **HTML
-error page with status 403 even for `.json` requests**
-(forbidden.py:4-19, app.py:2895-2904). Endpoints that check permissions
-themselves and return `_error(..., 403)` produce JSON instead. So a JSON
-client may receive either an HTML 403 page or a JSON 403 body depending on
-the endpoint.
+**`Forbidden` handling:** when a view raises `Forbidden` (e.g. via
+`ensure_permission`), the default `forbidden()` plugin hook returns the
+canonical JSON error with status 403 when the path ends in `.json` or the
+request carries an `Accept: application/json` / `Content-Type:
+application/json` header; other requests get an HTML error page
+(forbidden.py). Endpoints that check permissions themselves return
+`_error(..., 403)` JSON directly.
 
 ### CORS
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index a8690f51..d68bd32e 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -26,9 +26,9 @@ Findings are grouped by theme. Each carries a priority:
 > The `title` key is no longer emitted in JSON; the bare `{"error": ...}`
 > debug-endpoint shape is gone; `_shape=object` misuse now returns HTTP 400
 > (part of §1b). Covered by `tests/test_error_shape.py` and documented in
-> the "Error responses" section of `docs/json_api.rst`. Still open from
-> this section's sub-items: §1a (`Forbidden` → HTML), the write
-> canned-query 200 (§1b), and the §1c status outliers.
+> the "Error responses" section of `docs/json_api.rst`. §1a (`Forbidden` →
+> JSON) is now also implemented. Still open from this section's sub-items:
+> the write canned-query 200 (§1b) and the §1c status outliers.
 
 The API currently produces four distinct JSON error shapes depending on which
 internal layer generates the error:
@@ -58,7 +58,11 @@ defaults). At minimum, eliminate the bare `{"error": ...}` shape and the
 `status`/`title` keys nobody else emits (`title` is a template-rendering
 concern that leaked into the API).
 
-### 1a. `Forbidden` returns an HTML 403 to JSON clients (P1)
+### 1a. `Forbidden` returns an HTML 403 to JSON clients (P1) — ✅ IMPLEMENTED
+
+> **Status:** implemented — the default `forbidden()` hook now returns the
+> canonical JSON error for requests whose path ends in `.json` or that send
+> `Accept: application/json` / `Content-Type: application/json`.
 
 Read endpoints that deny access via `ensure_permission`/`check_visibility`
 raise `Forbidden`, and the default `forbidden()` hook renders an **HTML error
@@ -373,7 +377,7 @@ Two details make tiering urgent rather than optional:
 ## 10. Summary of P1 items (the pre-1.0 checklist)
 
 1. ~~One canonical JSON error shape; retire the other three (§1).~~ ✅ Done.
-2. `Forbidden` → JSON 403 for JSON requests (§1a).
+2. ~~`Forbidden` → JSON 403 for JSON requests (§1a).~~ ✅ Done.
 3. No `ok: false` with HTTP 200 (§1b: `_shape=object`, write canned-query
    SQL errors).
 4. ~~Wrap `/-/plugins`, `/-/databases`, `/-/actions` top-level arrays in
diff --git a/tests/test_cli.py b/tests/test_cli.py
index 7b528a8e..cbd8edad 100644
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -385,7 +385,9 @@ def test_setting_boolean_validation_false_values(value):
     )
     # Should be forbidden (setting is false)
     assert result.exit_code == 1, result.output
-    assert "Forbidden" in result.output
+    error = json.loads(result.output)
+    assert error["ok"] is False
+    assert error["status"] == 403
 
 
 @pytest.mark.parametrize("value", ("on", "true", "1"))
@@ -425,8 +427,9 @@ def test_setting_default_allow_sql(default_allow_sql):
         assert json.loads(result.output)["rows"][0] == {"21": 21}
     else:
         assert result.exit_code == 1, result.output
-        # This isn't JSON at the moment, maybe it should be though
-        assert "Forbidden" in result.output
+        error = json.loads(result.output)
+        assert error["ok"] is False
+        assert error["status"] == 403
 
 
 def test_sql_errors_logged_to_stderr():
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 6747e47a..7f12abc6 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -183,3 +183,52 @@ async def test_method_not_allowed_error_shape(ds_client):
 async def test_schema_unknown_database_error_shape(ds_client):
     response = await ds_client.get("/no_such_db/-/schema.json")
     assert_canonical_error(response, 404)
+
+
+# Forbidden responses (the default forbidden() hook)
+
+
+@pytest.fixture
+def ds_forbidden(tmp_path_factory):
+    db_directory = tmp_path_factory.mktemp("dbs")
+    db_path = str(db_directory / "data.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("vacuum")
+    conn.execute("create table docs (id integer primary key, title text)")
+    conn.close()
+    ds = Datasette(
+        [db_path],
+        config={"databases": {"data": {"tables": {"docs": {"allow": {"id": "root"}}}}}},
+    )
+    ds.root_enabled = True
+    yield ds
+    ds.close()
+
+
+@pytest.mark.asyncio
+async def test_forbidden_json_path_returns_canonical_json(ds_forbidden):
+    response = await ds_forbidden.client.get("/data/docs.json")
+    data = assert_canonical_error(response, 403)
+    assert "permission" in data["error"].lower()
+
+
+@pytest.mark.asyncio
+async def test_forbidden_accept_json_returns_canonical_json(ds_forbidden):
+    response = await ds_forbidden.client.get(
+        "/data/docs", headers={"Accept": "application/json"}
+    )
+    assert_canonical_error(response, 403)
+
+
+@pytest.mark.asyncio
+async def test_forbidden_html_path_still_returns_html(ds_forbidden):
+    response = await ds_forbidden.client.get("/data/docs")
+    assert response.status_code == 403
+    assert response.headers["content-type"].startswith("text/html")
+
+
+@pytest.mark.asyncio
+async def test_forbidden_json_path_allowed_actor_still_works(ds_forbidden):
+    response = await ds_forbidden.client.get("/data/docs.json", actor={"id": "root"})
+    assert response.status_code == 200
+    assert response.json()["ok"] is True

From e8048e023fa22971647ae38bfdf24b21b1853ffd Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 14:35:54 +0000
Subject: [PATCH 331/386] Return 400 for write canned-query SQL failures

POST to a write canned query previously returned HTTP 200 with
{"ok": false, "message": ...} when the SQL failed to execute, so JSON
clients (and anything that trusts HTTP status) recorded success for
failed writes. SQL failures now return 400 with the canonical error
shape plus the "redirect" context key from on_error_redirect; the
QueryWriteRejected 403 branch uses the canonical shape too. Successful
executions and the HTML flash-message flow are unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/database.py   |  22 +++---
 docs/sql_queries.rst          |  18 ++++-
 existing-api.md               |  14 ++--
 stable-api-recommendations.md |  15 ++--
 tests/test_error_shape.py     | 131 ++++++++++++++++++++++++++++++++++
 tests/test_queries.py         |   4 +-
 6 files changed, 179 insertions(+), 25 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index e02de657..cf7a6db3 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -16,6 +16,7 @@ from datasette.write_sql import QueryWriteRejected
 from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
+    error_body,
     call_with_supported_arguments,
     named_parameters as derive_named_parameters,
     format_bytes,
@@ -607,11 +608,7 @@ class QueryView(View):
                 "_json"
             ):
                 return Response.json(
-                    {
-                        "ok": False,
-                        "message": ex.message,
-                        "redirect": None,
-                    },
+                    dict(error_body([ex.message], 403), redirect=None),
                     status=403,
                 )
             datasette.add_message(request, ex.message, datasette.ERROR)
@@ -681,12 +678,17 @@ class QueryView(View):
             redirect_url = stored_query.on_error_redirect
             ok = False
         if should_return_json:
+            if ok:
+                return Response.json(
+                    {
+                        "ok": True,
+                        "message": message,
+                        "redirect": redirect_url,
+                    }
+                )
             return Response.json(
-                {
-                    "ok": ok,
-                    "message": message,
-                    "redirect": redirect_url,
-                }
+                dict(error_body([message], 400), redirect=redirect_url),
+                status=400,
             )
         else:
             datasette.add_message(request, message, message_type)
diff --git a/docs/sql_queries.rst b/docs/sql_queries.rst
index 371348fb..4c6e4426 100644
--- a/docs/sql_queries.rst
+++ b/docs/sql_queries.rst
@@ -657,7 +657,7 @@ There are three options for specifying that you would like the response to your
 - Include ``?_json=1`` in the URL that you POST to
 - Include ``"_json": 1`` in your JSON body, or ``&_json=1`` in your form encoded body
 
-The JSON response will look like this:
+A successful JSON response will look like this:
 
 .. code-block:: json
 
@@ -667,7 +667,21 @@ The JSON response will look like this:
         "redirect": "/data/add_name"
     }
 
-The ``"message"`` and ``"redirect"`` values here will take into account ``on_success_message``, ``on_success_message_sql``,  ``on_success_redirect``, ``on_error_message`` and ``on_error_redirect``, if they have been set.
+If the SQL fails to execute - for example a constraint violation - the response uses the :ref:`standard error format <json_api_errors>` with a ``400`` status, plus the ``"redirect"`` key from the query configuration:
+
+.. code-block:: json
+
+    {
+        "ok": false,
+        "error": "UNIQUE constraint failed: docs.id",
+        "errors": [
+            "UNIQUE constraint failed: docs.id"
+        ],
+        "status": 400,
+        "redirect": null
+    }
+
+The ``"message"``, ``"error"`` and ``"redirect"`` values here take into account ``on_success_message``, ``on_success_message_sql``, ``on_success_redirect``, ``on_error_message`` and ``on_error_redirect``, if they have been set.
 
 .. _pagination:
 
diff --git a/existing-api.md b/existing-api.md
index 90a931d1..e0842804 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -1132,12 +1132,14 @@ queries.
   `_random_chars_<N>`, `_cookie_<name>`, `_header_<name>` (underscores →
   hyphens). User-stored queries cannot contain magic parameters — they are a
   feature of config/trusted queries.
-- **Response — 200 for both success and SQL failure** (only permission
-  rejection is 403):
-  `{"ok": true|false, "message": "...", "redirect": "..."|null}` —
-  `message` honors `on_success_message_sql` / `on_success_message` /
-  `on_error_message`, falling back to `"Query executed"` or
-  `"Query executed, N rows affected"`.
+- **Response:** success → 200
+  `{"ok": true, "message": "...", "redirect": "..."|null}` — `message`
+  honors `on_success_message_sql` / `on_success_message`, falling back to
+  `"Query executed"` or `"Query executed, N rows affected"`. SQL failure →
+  **400** canonical error (message honors `on_error_message`) plus a
+  `redirect` context key from `on_error_redirect`. Operation rejection
+  (`QueryWriteRejected`, e.g. VACUUM) → 403 canonical error plus
+  `redirect: null`.
 
 ---
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index d68bd32e..c878cb70 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -27,8 +27,8 @@ Findings are grouped by theme. Each carries a priority:
 > debug-endpoint shape is gone; `_shape=object` misuse now returns HTTP 400
 > (part of §1b). Covered by `tests/test_error_shape.py` and documented in
 > the "Error responses" section of `docs/json_api.rst`. §1a (`Forbidden` →
-> JSON) is now also implemented. Still open from this section's sub-items:
-> the write canned-query 200 (§1b) and the §1c status outliers.
+> JSON) and §1b (write canned-query 200) are now also implemented. Still
+> open from this section's sub-items: the §1c status outliers.
 
 The API currently produces four distinct JSON error shapes depending on which
 internal layer generates the error:
@@ -76,7 +76,12 @@ machine-readable answer. **Recommendation:** the default forbidden handler
 must return the canonical JSON error when the path ends in `.json` or the
 request prefers JSON, mirroring `handle_exception`.
 
-### 1b. Errors that return HTTP 200 (P1)
+### 1b. Errors that return HTTP 200 (P1) — ✅ IMPLEMENTED
+
+> **Status:** implemented. `_shape=object` misuse returns 400 (done with
+> §1), and write canned-query SQL failures now return **400** with the
+> canonical error shape (plus the `redirect` context key); the
+> `QueryWriteRejected` 403 branch also uses the canonical shape.
 
 - `_shape=object` on a query or pk-less table → `{"ok": false, "error":
   "_shape=object is only available on tables"}` with **200**
@@ -378,8 +383,8 @@ Two details make tiering urgent rather than optional:
 
 1. ~~One canonical JSON error shape; retire the other three (§1).~~ ✅ Done.
 2. ~~`Forbidden` → JSON 403 for JSON requests (§1a).~~ ✅ Done.
-3. No `ok: false` with HTTP 200 (§1b: `_shape=object`, write canned-query
-   SQL errors).
+3. ~~No `ok: false` with HTTP 200 (§1b: `_shape=object`, write canned-query
+   SQL errors).~~ ✅ Done.
 4. ~~Wrap `/-/plugins`, `/-/databases`, `/-/actions` top-level arrays in
    objects (§2).~~ ✅ Done.
 5. ~~Filter `/-/databases.json` by `view-database` or gate it behind
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 7f12abc6..dd1fcfc9 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -232,3 +232,134 @@ async def test_forbidden_json_path_allowed_actor_still_works(ds_forbidden):
     response = await ds_forbidden.client.get("/data/docs.json", actor={"id": "root"})
     assert response.status_code == 200
     assert response.json()["ok"] is True
+
+
+# Write canned queries: SQL failures must not return HTTP 200
+
+
+@pytest.fixture
+def ds_write_query(tmp_path_factory):
+    db_directory = tmp_path_factory.mktemp("dbs")
+    db_path = str(db_directory / "data.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("vacuum")
+    conn.execute("create table docs (id integer primary key, title text)")
+    conn.close()
+    ds = Datasette(
+        [db_path],
+        config={
+            "databases": {
+                "data": {
+                    "queries": {
+                        "add_doc": {
+                            "sql": (
+                                "insert into docs (id, title)" " values (:id, :title)"
+                            ),
+                            "write": True,
+                        },
+                        "add_doc_custom_error": {
+                            "sql": (
+                                "insert into docs (id, title)" " values (:id, :title)"
+                            ),
+                            "write": True,
+                            "on_error_message": "Custom error message",
+                            "on_error_redirect": "/data",
+                        },
+                    }
+                }
+            }
+        },
+    )
+    yield ds
+    ds.close()
+
+
+@pytest.mark.asyncio
+async def test_write_query_success_returns_200(ds_write_query):
+    response = await ds_write_query.client.post(
+        "/data/add_doc",
+        json={"id": 1, "title": "One"},
+        headers={"Accept": "application/json"},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert data["ok"] is True
+    assert data["message"] == "Query executed, 1 row affected"
+    assert data["redirect"] is None
+
+
+@pytest.mark.asyncio
+async def test_write_query_sql_failure_returns_400(ds_write_query):
+    for _ in range(2):
+        response = await ds_write_query.client.post(
+            "/data/add_doc",
+            json={"id": 1, "title": "One"},
+            headers={"Accept": "application/json"},
+        )
+    data = assert_canonical_error(response, 400)
+    assert "UNIQUE constraint failed" in data["error"]
+    # The redirect context key from the canned query flow is preserved
+    assert data["redirect"] is None
+
+
+@pytest.mark.asyncio
+async def test_write_query_failure_uses_on_error_message_and_redirect(
+    ds_write_query,
+):
+    for _ in range(2):
+        response = await ds_write_query.client.post(
+            "/data/add_doc_custom_error",
+            json={"id": 1, "title": "One"},
+            headers={"Accept": "application/json"},
+        )
+    data = assert_canonical_error(response, 400)
+    assert data["error"] == "Custom error message"
+    assert data["redirect"] == "/data"
+
+
+@pytest.mark.asyncio
+async def test_write_query_forbidden_is_canonical_403(ds_write_query):
+    # An untrusted write query run by an actor without execute-write-sql
+    # raises Forbidden, handled by the forbidden() hook
+    await ds_write_query.invoke_startup()
+    await ds_write_query.add_query(
+        "data",
+        name="untrusted_add",
+        sql="insert into docs (id, title) values (:id, :title)",
+        is_write=True,
+        is_trusted=False,
+        source="user",
+        owner_id="someone",
+    )
+    response = await ds_write_query.client.post(
+        "/data/untrusted_add",
+        json={"id": 5, "title": "Five"},
+        headers={"Accept": "application/json"},
+        actor={"id": "someone"},
+    )
+    assert_canonical_error(response, 403)
+
+
+@pytest.mark.asyncio
+async def test_write_query_rejected_operation_is_canonical_403(ds_write_query):
+    # A rejected operation (VACUUM) raises QueryWriteRejected, handled by
+    # the dedicated branch in QueryView.post - root has execute-write-sql
+    ds_write_query.root_enabled = True
+    await ds_write_query.invoke_startup()
+    await ds_write_query.add_query(
+        "data",
+        name="vacuum_it",
+        sql="vacuum",
+        is_write=True,
+        is_trusted=False,
+        source="user",
+        owner_id="root",
+    )
+    response = await ds_write_query.client.post(
+        "/data/vacuum_it",
+        json={},
+        headers={"Accept": "application/json"},
+        actor={"id": "root"},
+    )
+    data = assert_canonical_error(response, 403)
+    assert data["redirect"] is None
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 6dfcc8b7..b79a9af4 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -3093,9 +3093,9 @@ async def test_untrusted_stored_write_query_rejects_virtual_table_control_insert
     )
 
     assert denied_response.status_code == 403
-    assert denied_response.json()["message"] == (
+    assert denied_response.json()["errors"] == [
         "Writes to virtual tables are not allowed in user-supplied SQL"
-    )
+    ]
     assert (
         await db.execute("select count(*) from docs where docs match 'hello'")
     ).first()[0] == 1

From b2cdc81d3495a497adf8a911d1171cf4609c9da4 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 14:55:41 +0000
Subject: [PATCH 332/386] Return 400 instead of 500 for row delete write
 failures

Row delete previously returned 500 when the write failed (for example
a constraint violation raised by a trigger or foreign key), while row
update and every other write endpoint report the same failure class as
400. Delete now matches.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/row.py        |  2 +-
 existing-api.md               |  4 ++--
 stable-api-recommendations.md |  8 +++++---
 tests/test_error_shape.py     | 32 ++++++++++++++++++++++++++++++++
 4 files changed, 40 insertions(+), 6 deletions(-)

diff --git a/datasette/views/row.py b/datasette/views/row.py
index c99b75d1..bdd78ed4 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -742,7 +742,7 @@ class RowDeleteView(BaseView):
         try:
             await resolved.db.execute_write_fn(delete_row, request=request)
         except Exception as e:
-            return _error([str(e)], 500)
+            return _error([str(e)], 400)
 
         await self.ds.track_event(
             DeleteRowEvent(
diff --git a/existing-api.md b/existing-api.md
index e0842804..d600179e 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -968,8 +968,8 @@ does not change the SQLite schema.
 - **Request:** no body required (any body is ignored — there is no
   confirmation step, unlike table drop).
 - **Response** — 200 `{"ok": true}`; with `?_redirect_to_table` a `redirect`
-  key is added. A failure during the write returns **500** with the message
-  (unlike update's 400). Emits `delete-row`.
+  key is added. A failure during the write returns 400 with the message,
+  matching update. Emits `delete-row`.
 
 ---
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index c878cb70..4fec5a00 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -98,10 +98,11 @@ key — see §2.)
 
 ### 1c. Wrong-status outliers (P2)
 
-- Row **delete** write failures return **500** (views/row.py:757) while row
+- ~~Row **delete** write failures return **500** (views/row.py:757) while row
   **update** write failures return **400** (views/row.py:832-835). Same
   failure class, different status; pick 400 (or 409 for constraint
-  violations) for both.
+  violations) for both.~~ ✅ **Done** — delete now returns 400, matching
+  update and the rest of the write API.
 - Invalid or expired bearer tokens silently degrade the request to anonymous,
   so clients see a 403 permission error (or worse, anonymous-permitted data)
   rather than a 401 (tokens.py:147-193). For 1.0, a malformed/expired
@@ -337,7 +338,8 @@ Concerns:
    []}`** while `.csv` on the same request returns 400 `"?sql= is
    required"`. The JSON behavior masks caller bugs; return 400 on both.
 3. **`_shape=object` HTTP 200 error** (§1b) — almost certainly unintended.
-4. **Row delete 500** (§1c) — inconsistent with every sibling endpoint.
+4. ~~**Row delete 500** (§1c) — inconsistent with every sibling endpoint.~~
+   ✅ Done — now 400.
 5. **The "SQL Interrupted" error embeds an HTML fragment in the JSON `error`
    value** (views/database.py:805-820). Error strings in the JSON API should
    be plain text.
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index dd1fcfc9..21d37cc2 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -363,3 +363,35 @@ async def test_write_query_rejected_operation_is_canonical_403(ds_write_query):
     )
     data = assert_canonical_error(response, 403)
     assert data["redirect"] is None
+
+
+# Row delete write failures must be 400, matching row update
+
+
+@pytest.mark.asyncio
+async def test_row_delete_write_failure_is_400(tmp_path_factory):
+    db_directory = tmp_path_factory.mktemp("dbs")
+    db_path = str(db_directory / "data.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("vacuum")
+    conn.execute("create table docs (id integer primary key, title text)")
+    conn.execute("insert into docs (id, title) values (1, 'One')")
+    conn.execute(
+        "create trigger no_delete before delete on docs "
+        "begin select raise(abort, 'deletes are blocked'); end"
+    )
+    conn.commit()
+    conn.close()
+    ds = Datasette([db_path])
+    ds.root_enabled = True
+    try:
+        response = await ds.client.post(
+            "/data/docs/1/-/delete",
+            json={},
+            headers={"Content-Type": "application/json"},
+            actor={"id": "root"},
+        )
+        data = assert_canonical_error(response, 400)
+        assert "deletes are blocked" in data["error"]
+    finally:
+        ds.close()

From aaaffe45b851c974fde9ce894191192718f601e5 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 15:18:12 +0000
Subject: [PATCH 333/386] Return 401 for invalid or expired bearer tokens

Invalid dstok_ tokens - bad signature, malformed payload, expired, or
presented while allow_signed_tokens is off - previously degraded the
request to anonymous, so clients saw a 403 permission error or worse,
a 200 with anonymous-visible data. Token handlers can now raise
TokenInvalid for tokens they recognize but reject; Datasette responds
with 401, the canonical JSON error body and a WWW-Authenticate: Bearer
error="invalid_token" header, even when a valid cookie is also present.

Bearer tokens no registered handler recognizes are still ignored, so
authentication plugins with their own token formats keep working.
TokenInvalid is exported from the datasette package for use by plugin
token handlers.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/__init__.py         |  2 +-
 datasette/app.py              | 31 +++++++++++-
 datasette/tokens.py           | 44 +++++++++++++-----
 docs/authentication.rst       |  4 +-
 docs/plugin_hooks.rst         |  4 ++
 existing-api.md               | 17 ++++---
 stable-api-recommendations.md | 13 ++++--
 tests/test_api_write.py       | 17 +++----
 tests/test_auth.py            | 19 ++++++--
 tests/test_error_shape.py     | 88 +++++++++++++++++++++++++++++++++++
 tests/test_token_handler.py   | 20 +++++---
 11 files changed, 214 insertions(+), 45 deletions(-)

diff --git a/datasette/__init__.py b/datasette/__init__.py
index eb18e59e..de46861c 100644
--- a/datasette/__init__.py
+++ b/datasette/__init__.py
@@ -1,7 +1,7 @@
 from datasette.permissions import Permission  # noqa
 from datasette.version import __version_info__, __version__  # noqa
 from datasette.events import Event  # noqa
-from datasette.tokens import TokenHandler, TokenRestrictions  # noqa
+from datasette.tokens import TokenHandler, TokenInvalid, TokenRestrictions  # noqa
 from datasette.utils.asgi import Forbidden, NotFound, Request, Response  # noqa
 from datasette.utils import actor_matches_allow  # noqa
 from datasette.views import Context  # noqa
diff --git a/datasette/app.py b/datasette/app.py
index dd5d7e8c..9982c58e 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -111,7 +111,9 @@ from .utils import (
     baseconv,
     call_with_supported_arguments,
     detect_json1,
+    add_cors_headers,
     display_actor,
+    error_body,
     escape_css_string,
     escape_sqlite,
     find_spatialite,
@@ -130,6 +132,7 @@ from .utils import (
     redact_keys,
     row_sql_params_pks,
 )
+from .tokens import TokenInvalid
 from .utils.asgi import (
     AsgiLifespan,
     Forbidden,
@@ -905,7 +908,9 @@ class Datasette:
         Verify an API token by trying all registered token handlers.
 
         Returns an actor dict from the first handler that recognizes the
-        token, or None if no handler accepts it.
+        token, or None if no handler accepts it. A handler may raise
+        TokenInvalid for a token it recognizes but rejects (bad signature,
+        expired) - Datasette turns that into a 401 response.
         """
         for token_handler in self._token_handlers():
             result = await token_handler.verify_token(self, token)
@@ -2887,13 +2892,24 @@ class DatasetteRouter:
         # Handle authentication
         default_actor = scope.get("actor") or None
         actor = None
+        token_error = None
         results = pm.hook.actor_from_request(datasette=self.ds, request=request)
         for result in results:
-            result = await await_me_maybe(result)
+            try:
+                result = await await_me_maybe(result)
+            except TokenInvalid as ex:
+                # A presented token was recognized but rejected - fail the
+                # request with a 401 even if another credential is valid,
+                # but keep awaiting the remaining coroutines first
+                if token_error is None:
+                    token_error = ex
+                continue
             if result and actor is None:
                 actor = result
                 # Don't break — we must await all coroutines to avoid
                 # "coroutine was never awaited" warnings
+        if token_error is not None:
+            return await self.handle_401(request, send, token_error)
         scope_modifications["actor"] = actor or default_actor
         scope = dict(scope, **scope_modifications)
 
@@ -2925,6 +2941,17 @@ class DatasetteRouter:
         except Exception as exception:
             return await self.handle_exception(request, send, exception)
 
+    async def handle_401(self, request, send, exception):
+        # A presented bearer token was recognized by a handler but rejected.
+        # Bearer tokens are API credentials, so this is always JSON.
+        headers = {"www-authenticate": 'Bearer error="invalid_token"'}
+        if self.ds.cors:
+            add_cors_headers(headers)
+        response = Response.json(
+            error_body([str(exception)], 401), status=401, headers=headers
+        )
+        await response.asgi_send(send)
+
     async def handle_404(self, request, send, exception=None):
         # If path contains % encoding, redirect to tilde encoding
         if "%" in request.path:
diff --git a/datasette/tokens.py b/datasette/tokens.py
index 38a55529..4f905339 100644
--- a/datasette/tokens.py
+++ b/datasette/tokens.py
@@ -18,6 +18,21 @@ if TYPE_CHECKING:
     from datasette.app import Datasette
 
 
+class TokenInvalid(Exception):
+    """
+    Raised by a TokenHandler when a token it recognizes is invalid -
+    for example a bad signature, malformed payload or expired token.
+
+    Datasette responds to this with an HTTP 401 error. Handlers should
+    return None instead for tokens they do not recognize at all, so that
+    other registered handlers get a chance to verify them.
+    """
+
+    def __init__(self, message="Invalid token"):
+        self.message = message
+        super().__init__(message)
+
+
 @dataclasses.dataclass
 class TokenRestrictions:
     """
@@ -108,8 +123,12 @@ class TokenHandler:
 
     async def verify_token(self, datasette: "Datasette", token: str) -> Optional[dict]:
         """
-        Verify a token and return an actor dict, or None if this handler
-        does not recognize the token.
+        Verify a token and return an actor dict.
+
+        Return None if this handler does not recognize the token at all,
+        so other handlers can try it. Raise TokenInvalid if the token is
+        recognized but invalid (bad signature, malformed, expired) - the
+        request will fail with a 401 error.
         """
         raise NotImplementedError
 
@@ -147,29 +166,32 @@ class SignedTokenHandler(TokenHandler):
     async def verify_token(self, datasette: "Datasette", token: str) -> Optional[dict]:
         prefix = "dstok_"
 
-        if not datasette.setting("allow_signed_tokens"):
+        if not token.startswith(prefix):
+            # Not one of our tokens - leave it for other handlers
             return None
 
+        if not datasette.setting("allow_signed_tokens"):
+            raise TokenInvalid(
+                "Signed tokens are not enabled for this Datasette instance"
+            )
+
         max_signed_tokens_ttl = datasette.setting("max_signed_tokens_ttl")
 
-        if not token.startswith(prefix):
-            return None
-
         raw = token[len(prefix) :]
         try:
             decoded = datasette.unsign(raw, namespace="token")
         except itsdangerous.BadSignature:
-            return None
+            raise TokenInvalid("Invalid token signature")
 
         if "t" not in decoded:
-            return None
+            raise TokenInvalid("Invalid token: no timestamp")
         created = decoded["t"]
         if not isinstance(created, int):
-            return None
+            raise TokenInvalid("Invalid token: invalid timestamp")
 
         duration = decoded.get("d")
         if duration is not None and not isinstance(duration, int):
-            return None
+            raise TokenInvalid("Invalid token: invalid duration")
 
         if (duration is None and max_signed_tokens_ttl) or (
             duration is not None
@@ -180,7 +202,7 @@ class SignedTokenHandler(TokenHandler):
 
         if duration:
             if time.time() - created > duration:
-                return None
+                raise TokenInvalid("Token has expired")
 
         actor = {"id": decoded["a"], "token": "dstok"}
 
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 8101699c..72ac5fa6 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -991,7 +991,9 @@ The ``/-/create-token`` page cannot be accessed by actors that are authenticated
 
 Datasette plugins that implement their own form of API token authentication should follow this convention.
 
-You can disable the signed token feature entirely using the :ref:`allow_signed_tokens <setting_allow_signed_tokens>` setting.
+If a request presents a token that a token handler recognizes but rejects - an invalid signature, a malformed payload or an expired token - Datasette responds with a ``401`` status, the :ref:`standard JSON error format <json_api_errors>` and a ``WWW-Authenticate: Bearer error="invalid_token"`` header. This means API clients can distinguish "your token needs to be renewed" (``401``) from "your token does not grant this permission" (``403``). A ``Bearer`` token that no registered handler recognizes at all is ignored, since it may be intended for an authentication plugin.
+
+You can disable the signed token feature entirely using the :ref:`allow_signed_tokens <setting_allow_signed_tokens>` setting. Requests presenting a ``dstok_`` token while the feature is disabled receive a ``401``.
 
 .. _authentication_cli_create_token:
 
diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 8614a15c..049cb292 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -2546,6 +2546,10 @@ The default ``SignedTokenHandler`` uses itsdangerous signed tokens (``dstok_`` p
 
         async def verify_token(self, datasette, token):
             # Look up token in database, return actor dict or None
+            # if this handler does not recognize the token. Raise
+            # datasette.TokenInvalid for a token this handler
+            # recognizes but rejects (revoked, expired) - Datasette
+            # will respond with a 401 error.
             ...
 
 
diff --git a/existing-api.md b/existing-api.md
index d600179e..8c6e1c4e 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -1156,14 +1156,17 @@ registered via `register_token_handler`; the default is
 - **Format:** `dstok_` + itsdangerous-signed payload (namespace `token`)
   containing `a` (actor id), `t` (creation Unix time), optional `d`
   (duration seconds), optional `_r` (restrictions).
-- **Verification** returns no actor when: `allow_signed_tokens` is off, the
-  signature is invalid, `t` is missing/non-integer, or the token is expired.
-  The effective duration is `d` capped by `max_signed_tokens_ttl` (default 0
-  = no cap; a non-zero setting also imposes a TTL on tokens without `d`).
+- **Verification:** a `dstok_`-prefixed token that fails verification —
+  `allow_signed_tokens` off, invalid signature, missing/non-integer `t`,
+  malformed `d`, or expired — raises `TokenInvalid`, and the request fails
+  with **401**, the canonical error body and a
+  `WWW-Authenticate: Bearer error="invalid_token"` header (even if a valid
+  `ds_actor` cookie is also present). Tokens with prefixes no registered
+  handler recognizes are ignored (they may belong to an auth plugin). The
+  effective duration is `d` capped by `max_signed_tokens_ttl` (default 0 =
+  no cap; a non-zero setting also imposes a TTL on tokens without `d`).
 - **Resulting actor:** `{"id": <a>, "token": "dstok"}` plus `"_r"` and
-  `"token_expires"` when applicable. Invalid/expired tokens silently produce
-  an anonymous request (no 401) — the failure then surfaces as a 403 from
-  whatever permission check the request hits.
+  `"token_expires"` when applicable.
 
 **Restrictions (`_r`)** (default_permissions/restrictions.py):
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 4fec5a00..273a272c 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -96,19 +96,23 @@ request prefers JSON, mirroring `handle_exception`.
 completed, SQL is invalid" is defensible but should then not reuse the `ok`
 key — see §2.)
 
-### 1c. Wrong-status outliers (P2)
+### 1c. Wrong-status outliers (P2) — ✅ IMPLEMENTED
 
 - ~~Row **delete** write failures return **500** (views/row.py:757) while row
   **update** write failures return **400** (views/row.py:832-835). Same
   failure class, different status; pick 400 (or 409 for constraint
   violations) for both.~~ ✅ **Done** — delete now returns 400, matching
   update and the rest of the write API.
-- Invalid or expired bearer tokens silently degrade the request to anonymous,
+- ~~Invalid or expired bearer tokens silently degrade the request to anonymous,
   so clients see a 403 permission error (or worse, anonymous-permitted data)
   rather than a 401 (tokens.py:147-193). For 1.0, a malformed/expired
   `Authorization: Bearer dstok_...` header should produce **401** with a
   distinguishable error, so clients can tell "renew your token" apart from
-  "you lack permission".
+  "you lack permission".~~ ✅ **Done** — token handlers can raise
+  `TokenInvalid`; Datasette responds 401 with the canonical body and a
+  `WWW-Authenticate: Bearer error="invalid_token"` header. Unrecognized
+  token prefixes still fall through to anonymous so auth plugins keep
+  working.
 
 ---
 
@@ -391,7 +395,8 @@ Two details make tiering urgent rather than optional:
    objects (§2).~~ ✅ Done.
 5. ~~Filter `/-/databases.json` by `view-database` or gate it behind
    `permissions-debug` (§6).~~ ✅ Done.
-6. 401 (not silent-anonymous) for invalid/expired bearer tokens (§1c).
+6. ~~401 (not silent-anonymous) for invalid/expired bearer tokens (§1c).~~
+   ✅ Done.
 7. Publish explicit stability tiers, including extras and pagination-token
    opacity (§9).
 8. Resolve the looks-like-a-bug list (§8), especially trusted-query delete
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 17542d4b..a29f5c99 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -202,8 +202,8 @@ async def test_insert_rows(ds_write, return_rows):
             "/data/docs/-/insert",
             {"rows": [{"title": "Test"} for i in range(10)]},
             "bad_token",
-            403,
-            ["Permission denied"],
+            401,
+            ["Invalid token signature"],
         ),
         (
             "/data/docs/-/insert",
@@ -410,12 +410,13 @@ async def test_insert_or_upsert_row_errors(
         },
     )
 
-    actor_response = (
-        await ds_write.client.get("/-/actor.json", headers=kwargs["headers"])
-    ).json()
-    assert set((actor_response["actor"] or {}).get("_r", {}).get("a") or []) == set(
-        token_permissions
-    )
+    if special_case != "bad_token":
+        actor_response = (
+            await ds_write.client.get("/-/actor.json", headers=kwargs["headers"])
+        ).json()
+        assert set((actor_response["actor"] or {}).get("_r", {}).get("a") or []) == set(
+            token_permissions
+        )
 
     if special_case == "invalid_json":
         del kwargs["json"]
diff --git a/tests/test_auth.py b/tests/test_auth.py
index 8e83d397..d2913ecc 100644
--- a/tests/test_auth.py
+++ b/tests/test_auth.py
@@ -236,7 +236,9 @@ def test_auth_create_token(
 
 @pytest.mark.asyncio
 async def test_auth_create_token_not_allowed_for_tokens(ds_client):
-    ds_tok = ds_client.ds.sign({"a": "test", "token": "dstok"}, "token")
+    ds_tok = ds_client.ds.sign(
+        {"a": "test", "token": "dstok", "t": int(time.time())}, "token"
+    )
     response = await ds_client.get(
         "/-/create-token",
         headers={"Authorization": "Bearer dstok_{}".format(ds_tok)},
@@ -304,8 +306,16 @@ async def test_auth_with_dstok_token(ds_client, scenario, should_work):
             assert actor["token"] == "dstok"
             if scenario != "valid_unlimited_token":
                 assert isinstance(actor["token_expires"], int)
-        else:
+        elif scenario == "no_token":
+            # No credentials presented - request proceeds as anonymous
             assert response.json() == {"ok": True, "actor": None}
+        else:
+            # Invalid credentials presented - hard 401
+            assert response.status_code == 401
+            data = response.json()
+            assert data["ok"] is False
+            assert data["status"] == 401
+            assert response.headers["www-authenticate"].startswith("Bearer")
     finally:
         ds_client.ds._settings["allow_signed_tokens"] = True
 
@@ -339,8 +349,9 @@ def test_cli_create_token(app_client, expires):
             expected_actor["token_expires"] = details["t"] + expires
         assert response.json == {"ok": True, "actor": expected_actor}
     else:
-        expected_actor = None
-    assert response.json == {"ok": True, "actor": expected_actor}
+        # Expired token - hard 401
+        assert response.status == 401
+        assert response.json["ok"] is False
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 21d37cc2..49b2c314 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -18,6 +18,7 @@ https://github.com/simonw/datasette/issues - 1.0 API consistency
 """
 
 import pytest
+import time
 from datasette.app import Datasette
 from datasette.utils import sqlite3
 
@@ -395,3 +396,90 @@ async def test_row_delete_write_failure_is_400(tmp_path_factory):
         assert "deletes are blocked" in data["error"]
     finally:
         ds.close()
+
+
+# Invalid bearer tokens must produce 401, not silent anonymous access
+
+
+@pytest.mark.asyncio
+async def test_expired_token_returns_401(ds_error_shape):
+    token = "dstok_{}".format(
+        ds_error_shape.sign(
+            {"a": "root", "t": int(time.time()) - 2000, "d": 1000},
+            namespace="token",
+        )
+    )
+    response = await ds_error_shape.client.get(
+        "/-/actor.json", headers={"Authorization": "Bearer {}".format(token)}
+    )
+    data = assert_canonical_error(response, 401)
+    assert "expired" in data["error"].lower()
+    assert response.headers["www-authenticate"].startswith("Bearer")
+
+
+@pytest.mark.asyncio
+async def test_bad_signature_token_returns_401(ds_error_shape):
+    response = await ds_error_shape.client.get(
+        "/-/actor.json", headers={"Authorization": "Bearer dstok_garbage"}
+    )
+    data = assert_canonical_error(response, 401)
+    assert response.headers["www-authenticate"].startswith("Bearer")
+
+
+@pytest.mark.asyncio
+async def test_unrecognized_token_prefix_stays_anonymous(ds_error_shape):
+    # No registered handler claims this token - it might belong to a
+    # plugin's actor_from_request hook, so it must not hard-fail
+    response = await ds_error_shape.client.get(
+        "/-/actor.json", headers={"Authorization": "Bearer sometoken_abc"}
+    )
+    assert response.status_code == 200
+    assert response.json() == {"ok": True, "actor": None}
+
+
+@pytest.mark.asyncio
+async def test_valid_token_still_authenticates(ds_error_shape):
+    token = "dstok_{}".format(
+        ds_error_shape.sign(
+            {"a": "root", "t": int(time.time())},
+            namespace="token",
+        )
+    )
+    response = await ds_error_shape.client.get(
+        "/-/actor.json", headers={"Authorization": "Bearer {}".format(token)}
+    )
+    assert response.status_code == 200
+    assert response.json()["actor"]["id"] == "root"
+
+
+@pytest.mark.asyncio
+async def test_bad_token_beats_valid_cookie(ds_error_shape):
+    # A malformed Authorization header is a hard error even if a valid
+    # ds_actor cookie is also present
+    response = await ds_error_shape.client.get(
+        "/-/actor.json",
+        headers={"Authorization": "Bearer dstok_garbage"},
+        cookies={"ds_actor": ds_error_shape.client.actor_cookie({"id": "root"})},
+    )
+    assert_canonical_error(response, 401)
+
+
+@pytest.mark.asyncio
+async def test_token_when_signed_tokens_disabled_returns_401(tmp_path_factory):
+    db_directory = tmp_path_factory.mktemp("dbs")
+    db_path = str(db_directory / "data.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("vacuum")
+    conn.close()
+    ds = Datasette([db_path], settings={"allow_signed_tokens": False})
+    try:
+        token = "dstok_{}".format(
+            ds.sign({"a": "root", "t": int(time.time())}, namespace="token")
+        )
+        response = await ds.client.get(
+            "/-/actor.json", headers={"Authorization": "Bearer {}".format(token)}
+        )
+        data = assert_canonical_error(response, 401)
+        assert "not enabled" in data["error"]
+    finally:
+        ds.close()
diff --git a/tests/test_token_handler.py b/tests/test_token_handler.py
index 5c87f577..f5bbfead 100644
--- a/tests/test_token_handler.py
+++ b/tests/test_token_handler.py
@@ -5,7 +5,12 @@ Tests for the register_token_handler plugin hook.
 from datasette.app import Datasette
 from datasette.hookspecs import hookimpl
 from datasette.plugins import pm
-from datasette.tokens import TokenHandler, TokenRestrictions, SignedTokenHandler
+from datasette.tokens import (
+    TokenHandler,
+    TokenInvalid,
+    TokenRestrictions,
+    SignedTokenHandler,
+)
 import pytest
 
 
@@ -66,10 +71,10 @@ async def test_verify_token_unknown_returns_none(datasette):
 
 
 @pytest.mark.asyncio
-async def test_verify_token_bad_signature_returns_none(datasette):
-    """verify_token() should return None for tokens with bad signatures."""
-    result = await datasette.verify_token("dstok_tampered_data_here")
-    assert result is None
+async def test_verify_token_bad_signature_raises(datasette):
+    """verify_token() should raise TokenInvalid for tokens with bad signatures."""
+    with pytest.raises(TokenInvalid):
+        await datasette.verify_token("dstok_tampered_data_here")
 
 
 @pytest.mark.asyncio
@@ -334,5 +339,6 @@ async def test_signed_tokens_disabled():
     ds = Datasette(settings={"allow_signed_tokens": False})
     with pytest.raises(ValueError, match="Signed tokens are not enabled"):
         await ds.create_token("test_actor", handler="signed")
-    # verify_token should return None rather than raising
-    assert await ds.verify_token("dstok_anything") is None
+    # verify_token should raise TokenInvalid for a dstok_ token
+    with pytest.raises(TokenInvalid, match="not enabled"):
+        await ds.verify_token("dstok_anything")

From ea9c1b1524279c03f0368c714438c5aacebcbec3 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 15:39:11 +0000
Subject: [PATCH 334/386] Return 400 for query data formats when ?sql= is
 missing

GET /db/-/query.json with no (or blank) ?sql= previously returned 200
with empty rows, masking caller bugs, while the .csv format returned
400 "?sql= is required" for the same request. All data formats now
return the 400; the HTML SQL editor page is unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/database.py   |  2 ++
 existing-api.md               |  5 +++--
 stable-api-recommendations.md |  6 ++++--
 tests/test_error_shape.py     | 24 ++++++++++++++++++++++++
 tests/test_table_api.py       |  6 ++++--
 5 files changed, 37 insertions(+), 6 deletions(-)

diff --git a/datasette/views/database.py b/datasette/views/database.py
index cf7a6db3..99e85d2b 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -851,6 +851,8 @@ class QueryView(View):
 
             return await stream_csv(datasette, fetch_data_for_csv, request, db.name)
         elif format_ in datasette.renderers.keys():
+            if not sql:
+                raise DatasetteError("?sql= is required", status=400)
             data = {"ok": True, "rows": rows, "columns": columns}
             extras = extra_names_from_request(request)
             if extras:
diff --git a/existing-api.md b/existing-api.md
index 8c6e1c4e..9947edeb 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -486,8 +486,9 @@ queries section).
     HTTP 400 `{"ok": false, "error": "<message>", "rows": [], "truncated": false}`.
   - Time limit → 400 titled `"SQL Interrupted"` (the `error` value contains
     an HTML fragment).
-  - `?sql=` omitted → 200 `{"ok": true, "rows": [], "truncated": false}`
-    (the CSV format instead errors 400 `"?sql= is required"`).
+  - `?sql=` omitted or blank → 400 `"?sql= is required"` for all data
+    formats (`.json`, `.csv`, plugin formats). The HTML page remains the
+    SQL editor.
 - `.csv` streams CSV; unknown extensions → 404.
 
 ### GET /\<database\>/-/query/parameters
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 273a272c..11f0a75d 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -338,9 +338,11 @@ Concerns:
    `is_trusted` — an actor with `delete-query` can delete a config-defined
    trusted query via the API (it will resync on restart, making the
    behavior confusing rather than catastrophic). Align delete with update.
-2. **GET `/db/-/query` with no `?sql=` returns 200 `{"ok": true, "rows":
+2. ~~**GET `/db/-/query` with no `?sql=` returns 200 `{"ok": true, "rows":
    []}`** while `.csv` on the same request returns 400 `"?sql= is
-   required"`. The JSON behavior masks caller bugs; return 400 on both.
+   required"`. The JSON behavior masks caller bugs; return 400 on both.~~
+   ✅ **Done** — all data formats now return 400; the HTML SQL editor page
+   is unchanged.
 3. **`_shape=object` HTTP 200 error** (§1b) — almost certainly unintended.
 4. ~~**Row delete 500** (§1c) — inconsistent with every sibling endpoint.~~
    ✅ Done — now 400.
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 49b2c314..9d4a566c 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -483,3 +483,27 @@ async def test_token_when_signed_tokens_disabled_returns_401(tmp_path_factory):
         assert "not enabled" in data["error"]
     finally:
         ds.close()
+
+
+# GET /db/-/query without SQL: 400 for data formats, HTML editor stays 200
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "path",
+    (
+        "/fixtures/-/query.json",
+        "/fixtures/-/query.json?sql=",
+    ),
+)
+async def test_query_json_without_sql_is_400(ds_client, path):
+    response = await ds_client.get(path)
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["?sql= is required"]
+
+
+@pytest.mark.asyncio
+async def test_query_html_without_sql_is_still_the_editor(ds_client):
+    response = await ds_client.get("/fixtures/-/query")
+    assert response.status_code == 200
+    assert response.headers["content-type"].startswith("text/html")
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index c8ba31b7..41c89f39 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -180,9 +180,11 @@ def test_query_extra_query_reports_bound_params():
         assert response.json["query"]["params"] == {}
 
 
-def test_query_extra_query_does_not_echo_querystring_without_sql():
+def test_query_extra_query_does_not_echo_querystring():
     with make_app_client() as client:
-        response = client.get("/fixtures/-/query.json?_extra=query&foo=bar")
+        response = client.get(
+            "/fixtures/-/query.json?sql=select+1&_extra=query&foo=bar"
+        )
         assert response.status == 200
         assert response.json["query"]["params"] == {}
 

From f3f5e891c9f3ad644a0b78c592ddd9d4f511d4b9 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 15:49:49 +0000
Subject: [PATCH 335/386] Block API deletion of trusted stored queries

QueryUpdateView already rejected is_trusted queries but QueryDeleteView
did not, so an actor with delete-query could delete a config-defined
trusted query - which would then silently reappear on restart when the
config re-syncs. Both the POST endpoint and the HTML confirmation page
now return 403, matching update. datasette.remove_query() is unchanged
for internal use.

The docs already claimed this behavior ("Trusted stored queries cannot
be edited or deleted through the web interface or the JSON API") - the
code now matches them.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/stored_queries.py |  4 +++
 existing-api.md                   |  5 ++--
 stable-api-recommendations.md     | 11 ++++---
 tests/test_queries.py             | 48 +++++++++++++++++++++++++++++++
 4 files changed, 62 insertions(+), 6 deletions(-)

diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
index 2753f876..d1f151dd 100644
--- a/datasette/views/stored_queries.py
+++ b/datasette/views/stored_queries.py
@@ -610,6 +610,8 @@ class QueryDeleteView(BaseView):
             resource=QueryResource(db.name, query_name),
             actor=request.actor,
         )
+        if existing.is_trusted:
+            return _error(["Trusted queries cannot be deleted using the API"], 403)
         return await self.render(
             ["query_delete.html"],
             request,
@@ -631,6 +633,8 @@ class QueryDeleteView(BaseView):
             actor=request.actor,
         ):
             return _error(["Permission denied: need delete-query"], 403)
+        if existing.is_trusted:
+            return _error(["Trusted queries cannot be deleted using the API"], 403)
 
         data, is_json = await _json_or_form_payload(request)
         await self.ds.remove_query(db.name, query_name)
diff --git a/existing-api.md b/existing-api.md
index 9947edeb..e11491fe 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -1093,8 +1093,9 @@ updates use `/-/update`.
 `QueryDeleteView` (app.py:2707-2710; views/stored_queries.py:594-644). GET
 renders an HTML confirmation page.
 
-- **Permission:** `delete-query` (403 `need delete-query`). Unlike update,
-  **trusted queries are not blocked** from API deletion.
+- **Permission:** `delete-query` (403 `need delete-query`). Trusted
+  queries → 403 `"Trusted queries cannot be deleted using the API"`,
+  matching update.
 - **Response:** JSON request → 200 `{"ok": true}`; form → 302; 404
   `"Query not found: x"`. No `confirm` field required (unlike table drop).
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 11f0a75d..8c3131e9 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -332,12 +332,15 @@ Concerns:
 
 ## 8. Behavior that looks like a bug and should be resolved before freezing
 
-1. **Trusted queries: update is blocked, delete is not.**
+1. ~~**Trusted queries: update is blocked, delete is not.**
    `QueryUpdateView` rejects `is_trusted` queries with 403
    (stored_queries.py:426-427) but `QueryDeleteView.post` never checks
    `is_trusted` — an actor with `delete-query` can delete a config-defined
    trusted query via the API (it will resync on restart, making the
-   behavior confusing rather than catastrophic). Align delete with update.
+   behavior confusing rather than catastrophic). Align delete with update.~~
+   ✅ **Done** — both the POST endpoint and the HTML confirmation page now
+   return 403 `"Trusted queries cannot be deleted using the API"`;
+   `datasette.remove_query()` remains available for internal use.
 2. ~~**GET `/db/-/query` with no `?sql=` returns 200 `{"ok": true, "rows":
    []}`** while `.csv` on the same request returns 400 `"?sql= is
    required"`. The JSON behavior masks caller bugs; return 400 on both.~~
@@ -401,8 +404,8 @@ Two details make tiering urgent rather than optional:
    ✅ Done.
 7. Publish explicit stability tiers, including extras and pagination-token
    opacity (§9).
-8. Resolve the looks-like-a-bug list (§8), especially trusted-query delete
-   and row-delete 500.
+8. Resolve the looks-like-a-bug list (§8), especially ~~trusted-query delete
+   and row-delete 500~~ (both done).
 
 Everything in P2 is worth doing now because each item is breaking-to-fix
 later; each P3 can be resolved by a sentence of documentation declaring the
diff --git a/tests/test_queries.py b/tests/test_queries.py
index b79a9af4..c5c1c3cd 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -3654,3 +3654,51 @@ async def test_stored_write_query_with_truncated_returning_message():
     assert response.status_code == 200
     assert response.json()["ok"] is True
     assert response.json()["message"] == "Query executed"
+
+
+@pytest.mark.asyncio
+async def test_query_delete_api_rejects_trusted_queries():
+    ds = Datasette(
+        memory=True,
+        default_deny=True,
+        config={
+            "databases": {
+                "data": {
+                    "permissions": {
+                        "view-query": {"id": "editor"},
+                        "delete-query": {"id": "editor"},
+                    },
+                    "queries": {
+                        "trusted_report": {
+                            "sql": "select 1 as one",
+                        },
+                    },
+                }
+            }
+        },
+    )
+    ds.add_memory_database("query_delete_trusted_api", name="data")
+    await ds.invoke_startup()
+
+    response = await ds.client.post(
+        "/data/trusted_report/-/delete",
+        actor={"id": "editor"},
+        json={},
+    )
+    assert response.status_code == 403
+    assert response.json()["errors"] == [
+        "Trusted queries cannot be deleted using the API"
+    ]
+    # The query must still exist
+    assert await ds.get_query("data", "trusted_report") is not None
+
+    # The HTML confirmation page refuses too
+    get_response = await ds.client.get(
+        "/data/trusted_report/-/delete",
+        actor={"id": "editor"},
+    )
+    assert get_response.status_code == 403
+
+    # datasette.remove_query() remains available for internal use
+    await ds.remove_query("data", "trusted_report")
+    assert await ds.get_query("data", "trusted_report") is None

From 6488b7a30e792c6b1af0a596ce81f7e1a0f179a3 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:00:25 +0000
Subject: [PATCH 336/386] Remove duplicate params key from stored query JSON
 objects

Every stored-query object carried the same list of parameter names
twice, as both "params" and "parameters". Output objects now carry only
"parameters", consistent with /-/query/parameters and the two analyze
endpoints (and distinct from the "params" bound-values dictionary used
by the query extra and /-/execute-write). "params" remains an accepted
input alias for query creation, update and datasette.yaml config.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/stored_queries.py   |  1 -
 docs/json_api.rst             |  1 -
 existing-api.md               |  6 +++---
 stable-api-recommendations.md |  7 +++++--
 tests/test_queries.py         | 30 ++++++++++++++++++++++++++++++
 5 files changed, 38 insertions(+), 7 deletions(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index a6123daa..d7e1ec99 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -62,7 +62,6 @@ def stored_query_to_dict(query: StoredQuery) -> dict[str, Any]:
         "description_html": query.description_html,
         "hide_sql": query.hide_sql,
         "fragment": query.fragment,
-        "params": list(query.parameters),
         "parameters": list(query.parameters),
         "is_write": query.is_write,
         "is_private": query.is_private,
diff --git a/docs/json_api.rst b/docs/json_api.rst
index a561aa9c..54f0b6bd 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -1173,7 +1173,6 @@ The following extras are available for arbitrary SQL query responses and stored,
           "description_html": null,
           "hide_sql": false,
           "fragment": null,
-          "params": [],
           "parameters": [],
           "is_write": false,
           "is_private": false,
diff --git a/existing-api.md b/existing-api.md
index e11491fe..abb82e2c 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -990,7 +990,7 @@ stored_queries.py:55-80):
   "database": "...", "name": "...", "sql": "...",
   "title": null, "description": null, "description_html": null,
   "hide_sql": false, "fragment": null,
-  "params": ["p"], "parameters": ["p"],
+  "parameters": ["p"],
   "is_write": false, "is_private": true, "is_trusted": false,
   "source": "user", "owner_id": "...",
   "on_success_message": null, "on_success_message_sql": null,
@@ -1000,8 +1000,8 @@ stored_queries.py:55-80):
 }
 ```
 
-`params` and `parameters` are identical lists, both always present.
-`private` appears only in list responses.
+`private` appears only in list responses. On input (create/update and
+`datasette.yaml`), `params` is accepted as an alias for `parameters`.
 
 **Default permission rules for queries** (default_permissions/defaults.py):
 `view-query` is default-allow, but private queries are visible only to their
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 8c3131e9..d1388549 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -249,9 +249,12 @@ Concerns:
 
 ## 5. Naming and parameter conventions (P2/P3)
 
-- **`params` and `parameters` are duplicate keys** in every stored-query
+- ~~**`params` and `parameters` are duplicate keys** in every stored-query
   object (stored_queries.py:55-80). Delete one before 1.0 (suggest keeping
-  `parameters`; the write side already accepts both on input).
+  `parameters`; the write side already accepts both on input).~~
+  ✅ **Done** — output objects carry only `parameters` (matching
+  `/-/query/parameters` and the analyze endpoints); `params` remains an
+  accepted input alias for API creation and `datasette.yaml` config.
 - **Three names for the same concept across error/message payloads:**
   `error`, `errors`, `message`. See §1.
 - **Boolean query parameters have at least three grammars:** `_nl=on`,
diff --git a/tests/test_queries.py b/tests/test_queries.py
index c5c1c3cd..11828c4e 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -3702,3 +3702,33 @@ async def test_query_delete_api_rejects_trusted_queries():
     # datasette.remove_query() remains available for internal use
     await ds.remove_query("data", "trusted_report")
     assert await ds.get_query("data", "trusted_report") is None
+
+
+@pytest.mark.asyncio
+async def test_stored_query_json_uses_parameters_not_params():
+    ds = Datasette(
+        memory=True,
+        config={
+            "databases": {
+                "data": {
+                    "queries": {
+                        "with_params": {
+                            "sql": "select :name as name, :age as age",
+                            "params": ["name", "age"],
+                        },
+                    },
+                }
+            }
+        },
+    )
+    ds.add_memory_database("query_parameters_key", name="data")
+    await ds.invoke_startup()
+
+    definition = (await ds.client.get("/data/with_params/-/definition")).json()
+    assert definition["query"]["parameters"] == ["name", "age"]
+    assert "params" not in definition["query"]
+
+    listing = (await ds.client.get("/data/-/queries.json")).json()
+    query = [q for q in listing["queries"] if q["name"] == "with_params"][0]
+    assert query["parameters"] == ["name", "age"]
+    assert "params" not in query

From b09dceea889bf076c3d35af406c5b0ae50654731 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:03:05 +0000
Subject: [PATCH 337/386] Row update return:true responds with rows list,
 matching insert/upsert

Row update previously returned a singular "row" object where insert and
upsert return a "rows" list. All write endpoints now use "rows".

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/row.py        |  2 +-
 docs/json_api.rst             | 12 +++++++-----
 existing-api.md               |  4 ++--
 stable-api-recommendations.md |  5 +++--
 tests/test_api_write.py       |  4 ++--
 tests/test_error_shape.py     | 24 ++++++++++++++++++++++++
 tests/test_table_html.py      |  2 +-
 7 files changed, 40 insertions(+), 13 deletions(-)

diff --git a/datasette/views/row.py b/datasette/views/row.py
index bdd78ed4..71539f34 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -828,7 +828,7 @@ class RowUpdateView(BaseView):
                 resolved.sql, resolved.params, truncate=True
             )
             returned_row = results.dicts()[0]
-            result["row"] = returned_row
+            result["rows"] = [returned_row]
 
         await self.ds.track_event(
             UpdateRowEvent(
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 54f0b6bd..b8287a64 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -1955,11 +1955,13 @@ The returned JSON will look like this:
 
     {
         "ok": true,
-        "row": {
-            "id": 1,
-            "title": "New title",
-            "other_column": "Will be present here too"
-        }
+        "rows": [
+            {
+                "id": 1,
+                "title": "New title",
+                "other_column": "Will be present here too"
+            }
+        ]
     }
 
 Any errors will use the :ref:`standard error format <json_api_errors>`, with a ``400`` status code for a bad input or a ``403`` status code for an authentication or permission error.
diff --git a/existing-api.md b/existing-api.md
index abb82e2c..eb7b5c20 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -958,8 +958,8 @@ does not change the SQLite schema.
   `"Invalid keys: ..."`; write failures (bad column, constraint violation) →
   400 with the message.
 - **Response** — 200 `{"ok": true}`; with `return: true`,
-  `{"ok": true, "row": {...}}` (singular `row`, unlike insert/upsert's
-  `rows`). Emits `update-row`.
+  `{"ok": true, "rows": [{...}]}` — a single-item list, matching
+  insert/upsert. Emits `update-row`.
 
 ### POST /\<database\>/\<table\>/\<pks\>/-/delete
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index d1388549..a4dbb344 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -160,10 +160,11 @@ Endpoints disagree about the success envelope:
   (index.py:147-161); `/-/databases.json` returns an **array**; the database
   page returns `tables` as an array. Choose arrays-of-objects everywhere
   (objects-keyed-by-name break when names need ordering or pagination).
-- Insert/upsert with `return: true` respond with `rows` (plural, list); row
+- ~~Insert/upsert with `return: true` respond with `rows` (plural, list); row
   update with `return: true` responds with `row` (singular, object)
   (views/row.py:837-844). Pick one (`rows` everywhere, even for one row,
-  matches the read API).
+  matches the read API).~~ ✅ **Done** — row update now returns
+  `rows: [{...}]`.
 
 ### 2b. `_extra`/`_shape` support is uneven (P2)
 
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index a29f5c99..e3363db0 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -1481,9 +1481,9 @@ async def test_update_row(ds_write, input, expected_errors, use_return):
 
     assert response.json()["ok"] is True
     if not use_return:
-        assert "row" not in response.json()
+        assert "rows" not in response.json()
     else:
-        returned_row = response.json()["row"]
+        returned_row = response.json()["rows"][0]
         assert returned_row["id"] == pk
         for k, v in input.items():
             assert returned_row[k] == v
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 9d4a566c..29f4e8fc 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -507,3 +507,27 @@ async def test_query_html_without_sql_is_still_the_editor(ds_client):
     response = await ds_client.get("/fixtures/-/query")
     assert response.status_code == 200
     assert response.headers["content-type"].startswith("text/html")
+
+
+# Write API return:true responses use "rows" consistently
+
+
+@pytest.mark.asyncio
+async def test_row_update_return_uses_rows_list(ds_error_shape):
+    await ds_error_shape.client.post(
+        "/data/docs/-/insert",
+        json={"row": {"id": 1, "title": "One"}},
+        headers={"Content-Type": "application/json"},
+        actor={"id": "root"},
+    )
+    response = await ds_error_shape.client.post(
+        "/data/docs/1/-/update",
+        json={"update": {"title": "Updated"}, "return": True},
+        headers={"Content-Type": "application/json"},
+        actor={"id": "root"},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert data["ok"] is True
+    assert "row" not in data
+    assert data["rows"] == [{"id": 1, "title": "Updated"}]
diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 46d43c6c..86fb4254 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -1629,7 +1629,7 @@ async def test_row_update_sets_message():
             json={"update": {"name": long_name}, "return": True},
         )
         assert response.status_code == 200
-        assert response.json()["row"]["name"] == long_name
+        assert response.json()["rows"][0]["name"] == long_name
         assert ds.unsign(response.cookies["ds_messages"], "messages") == [
             ["Updated row 1 ({})".format(truncated_name), ds.INFO]
         ]

From b958d03c0f0f322eeb4135e141e7877734211eef Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:09:40 +0000
Subject: [PATCH 338/386] Expose count truncation in table JSON via
 count_truncated extra

The count extra is computed with a limit subquery, so a count equal to
count_limit + 1 (default 10001) actually means "at least this many" -
but only the HTML view knew that. A public count_truncated extra now
reports the flag and is implicitly included whenever count is
requested, using the same logic the HTML view already used.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/table.py        | 23 ++++----------------
 datasette/views/table_extras.py | 34 ++++++++++++++++++++++++++++++
 docs/json_api.rst               |  9 ++++++++
 existing-api.md                 |  3 ++-
 stable-api-recommendations.md   |  5 ++++-
 tests/test_table_api.py         | 37 +++++++++++++++++++++++++++++++++
 6 files changed, 90 insertions(+), 21 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index ef9831b2..44919281 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -62,6 +62,7 @@ from .table_create_alter import (
 from .table_extras import (
     TABLE_EXTRA_BUNDLES,
     TableExtraContext,
+    count_is_truncated,
     precompute_database_action_permissions,
     precompute_table_action_permissions,
     resolve_table_extras,
@@ -2257,6 +2258,8 @@ async def table_view_data(
         extras.add("facet_results")
     if request.args.get("_shape") == "object":
         extras.add("primary_keys")
+    if "count" in extras:
+        extras.add("count_truncated")
     if extra_extras:
         extras.update(extra_extras)
 
@@ -2335,7 +2338,7 @@ async def table_view_data(
     data["rows"] = transformed_rows
 
     if context_for_html_hack:
-        data["count_truncated"] = _count_truncated_for_table_page(
+        data["count_truncated"] = count_is_truncated(
             datasette, db, database_name, table_name, count_sql, data.get("count")
         )
         data.update(extra_context_from_filters)
@@ -2403,24 +2406,6 @@ async def table_view_data(
     return data, rows[:page_size], columns, expanded_columns, sql, next_url
 
 
-def _count_truncated_for_table_page(
-    datasette, db, database_name, table_name, count_sql, count
-):
-    if count != db.count_limit + 1:
-        return False
-    if (
-        not db.is_mutable
-        and datasette.inspect_data
-        and count_sql == f"select count(*) from {table_name} "
-    ):
-        try:
-            datasette.inspect_data[database_name]["tables"][table_name]["count"]
-            return False
-        except KeyError:
-            pass
-    return True
-
-
 async def _next_value_and_url(
     datasette,
     db,
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index db659c80..f8ece55b 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -140,6 +140,39 @@ class CountExtra(Extra):
         return count
 
 
+def count_is_truncated(datasette, db, database_name, table_name, count_sql, count):
+    if count != db.count_limit + 1:
+        return False
+    if (
+        not db.is_mutable
+        and datasette.inspect_data
+        and count_sql == f"select count(*) from {table_name} "
+    ):
+        try:
+            datasette.inspect_data[database_name]["tables"][table_name]["count"]
+            return False
+        except KeyError:
+            pass
+    return True
+
+
+class CountTruncatedExtra(Extra):
+    description = "True if the count hit Datasette's counting limit, meaning the real number of matching rows is at least the reported count."
+    example = ExtraExample("/fixtures/facetable.json?_extra=count,count_truncated")
+    scopes = {ExtraScope.TABLE}
+    expensive = True
+
+    async def resolve(self, context, count):
+        return count_is_truncated(
+            context.datasette,
+            context.db,
+            context.database_name,
+            context.table_name,
+            context.count_sql,
+            count,
+        )
+
+
 class FacetInstancesProvider(Provider):
     scopes = {ExtraScope.TABLE}
 
@@ -1196,6 +1229,7 @@ TABLE_EXTRA_BUNDLES = {
 
 TABLE_EXTRA_CLASSES = [
     CountExtra,
+    CountTruncatedExtra,
     CountSqlExtra,
     FacetResultsExtra,
     FacetsTimedOutExtra,
diff --git a/docs/json_api.rst b/docs/json_api.rst
index b8287a64..2a859ba2 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -302,6 +302,15 @@ The available table extras are listed below.
 
         15
 
+``count_truncated``
+    True if the count hit Datasette's counting limit, meaning the real number of matching rows is at least the reported count. (May execute additional queries.)
+
+    ``GET /fixtures/facetable.json?_extra=count,count_truncated``
+
+    .. code-block:: json
+
+        false
+
 ``count_sql``
     SQL query string used to calculate the total count for the current table view, including active filters.
 
diff --git a/existing-api.md b/existing-api.md
index eb7b5c20..a8a2237f 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -658,7 +658,8 @@ views/table_extras.py:1197-1235; unknown names silently ignored):
 
 | `_extra=` | Returns |
 |---|---|
-| `count` | total matching-row count, computed with a `limit 10001` subquery so it caps at 10001; `null` with `_nocount` or on count timeout |
+| `count` | total matching-row count, computed with a `limit 10001` subquery so it caps at 10001; `null` with `_nocount` or on count timeout. Requesting `count` implicitly includes `count_truncated` |
+| `count_truncated` | `true` when `count` hit the counting limit (the real count is at least the reported value) |
 | `count_sql` | the SQL used for the count |
 | `facet_results` | `{"results": {name: facet}, "timed_out": [...]}`; each facet: `{name, type, hideable, toggle_url, results: [{value, label, count, toggle_url, selected}], truncated}` |
 | `facets_timed_out` | facet names that exceeded `facet_time_limit_ms` |
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index a4dbb344..64b2acbc 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -178,7 +178,10 @@ is a table/row/query feature. Also decide the contract for **unknown
 silent ignoring means typos return the default payload with no signal;
 recommend a 400 or a `warnings` key.
 
-### 2c. Count truncation is invisible in JSON (P2)
+### 2c. Count truncation is invisible in JSON (P2) — ✅ IMPLEMENTED
+
+> **Status:** implemented — a public `count_truncated` extra now exists and
+> is implicitly included whenever `count` is requested.
 
 The `count` extra is computed with a `limit 10001` subquery, so `count:
 10001` actually means "at least 10001" — the `count_truncated` flag exists
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 41c89f39..e3737ee6 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -1504,6 +1504,7 @@ async def test_col_nocol_errors(ds_client, path, expected_error):
                 "rows": [{"id": "1", "content": "hey", "content2": "world"}],
                 "truncated": False,
                 "count": 1,
+                "count_truncated": False,
             },
         ),
     ),
@@ -1590,3 +1591,39 @@ async def test_extra_render_cell():
 
     finally:
         ds.pm.unregister(name="TestRenderCellPlugin")
+
+
+@pytest.mark.asyncio
+async def test_count_truncated_included_with_count_extra(tmp_path_factory):
+    from datasette.app import Datasette
+    from datasette.utils import sqlite3
+
+    db_directory = tmp_path_factory.mktemp("dbs")
+    db_path = str(db_directory / "counts.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("vacuum")
+    conn.execute("create table big (id integer primary key)")
+    conn.execute("create table small (id integer primary key)")
+    conn.executemany("insert into big (id) values (?)", [(i,) for i in range(10)])
+    conn.executemany("insert into small (id) values (?)", [(i,) for i in range(3)])
+    conn.commit()
+    conn.close()
+    ds = Datasette([db_path])
+    ds.get_database("counts").count_limit = 5
+    try:
+        response = await ds.client.get("/counts/big.json?_extra=count")
+        data = response.json()
+        # Count is capped at count_limit + 1 and flagged as truncated
+        assert data["count"] == 6
+        assert data["count_truncated"] is True
+
+        response = await ds.client.get("/counts/small.json?_extra=count")
+        data = response.json()
+        assert data["count"] == 3
+        assert data["count_truncated"] is False
+
+        # count_truncated can also be requested on its own
+        response = await ds.client.get("/counts/big.json?_extra=count_truncated")
+        assert response.json()["count_truncated"] is True
+    finally:
+        ds.close()

From 9ee95cab3d9f451dd3529a83bd54a3998be436e0 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:11:30 +0000
Subject: [PATCH 339/386] Schema endpoints check permission before database
 existence

/db/-/schema previously returned 404 for missing databases before
checking view-database, letting unauthorized actors probe for database
existence. The permission check now runs first, so actors without
view-database get a uniform 403. The table schema endpoint also now
returns 404 for an unknown database instead of an unhandled KeyError.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/special.py    | 13 +++++++-----
 existing-api.md               |  4 ++--
 stable-api-recommendations.md |  6 ++++--
 tests/test_error_shape.py     | 39 +++++++++++++++++++++++++++++++++++
 4 files changed, 53 insertions(+), 9 deletions(-)

diff --git a/datasette/views/special.py b/datasette/views/special.py
index 82a76e76..6afb6437 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -1321,17 +1321,17 @@ class DatabaseSchemaView(SchemaBaseView):
         database_name = request.url_vars["database"]
         format_ = request.url_vars.get("format") or "html"
 
-        # Check if database exists
-        if database_name not in self.ds.databases:
-            return self.format_error_response("Database not found", format_)
-
-        # Check view-database permission
+        # Permission check comes first, so actors without view-database
+        # cannot distinguish existing databases from missing ones
         await self.ds.ensure_permission(
             action="view-database",
             resource=DatabaseResource(database=database_name),
             actor=request.actor,
         )
 
+        if database_name not in self.ds.databases:
+            return self.format_error_response("Database not found", format_)
+
         schema = await self.get_database_schema(database_name)
 
         if format_ == "json":
@@ -1365,6 +1365,9 @@ class TableSchemaView(SchemaBaseView):
             actor=request.actor,
         )
 
+        if database_name not in self.ds.databases:
+            return self.format_error_response("Database not found", format_)
+
         # Get schema for the table
         db = self.ds.databases[database_name]
         result = await db.execute(
diff --git a/existing-api.md b/existing-api.md
index a8a2237f..6ce29bf5 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -618,8 +618,8 @@ views/table_create_alter.py:965-1005).
 
 - **Permission:** `view-database` (denied → `Forbidden` → 403 HTML).
 - **Unknown database** → 404; for `.json`:
-  `{"ok": false, "error": "Database not found"}`. (The existence check runs
-  before the permission check.)
+  `{"ok": false, "error": "Database not found"}`. The permission check runs
+  first, so unauthorized actors cannot probe for database existence.
 - **Responses:** `.json` → 200 `{"ok": true, "database": "<name>", "schema": "<SQL>"}`
   (concatenated `sqlite_master.sql` joined with `;\n`); `.md` →
   `text/markdown`; no extension → HTML.
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 64b2acbc..a92fbfbd 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -288,11 +288,13 @@ Concerns:
   databases this leaks filesystem paths and database names. Filter it, or
   gate it behind `permissions-debug`.~~ ✅ **Done** — the endpoint now
   filters through `allowed_resources("view-database", actor)`.
-- **(P2) `/db/-/schema` checks existence before permission**
+- ~~**(P2) `/db/-/schema` checks existence before permission**
   (views/special.py:1308-1317): an actor without `view-database` can
   distinguish "database exists" (403) from "does not exist" (404).
   Standardize on permission-check-first (as the table view does) so
-  unauthorized actors get a uniform response.
+  unauthorized actors get a uniform response.~~ ✅ **Done** — permission is
+  checked first; the table schema view also now 404s (instead of a 500
+  KeyError) for an unknown database.
 - **(P2) `/-/threads` exposes runtime internals** (thread idents, asyncio
   task reprs including file paths) behind only `view-instance`. Consider
   `permissions-debug`, alongside `/-/actions` which already requires it.
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 29f4e8fc..55370c18 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -531,3 +531,42 @@ async def test_row_update_return_uses_rows_list(ds_error_shape):
     assert data["ok"] is True
     assert "row" not in data
     assert data["rows"] == [{"id": 1, "title": "Updated"}]
+
+
+# Schema endpoints: no existence oracle, no 500 on unknown database
+
+
+@pytest.mark.asyncio
+async def test_schema_endpoints_no_existence_oracle(tmp_path_factory):
+    db_directory = tmp_path_factory.mktemp("dbs")
+    db_path = str(db_directory / "data.db")
+    conn = sqlite3.connect(db_path)
+    conn.execute("vacuum")
+    conn.execute("create table docs (id integer primary key)")
+    conn.close()
+    ds = Datasette([db_path], default_deny=True)
+    ds.root_enabled = True
+    try:
+        # An actor without view-database cannot distinguish an existing
+        # database from a missing one
+        denied_existing = await ds.client.get("/data/-/schema.json")
+        denied_missing = await ds.client.get("/nope/-/schema.json")
+        assert denied_existing.status_code == denied_missing.status_code == 403
+
+        # An authorized actor sees the real thing
+        root_existing = await ds.client.get(
+            "/data/-/schema.json", actor={"id": "root"}
+        )
+        assert root_existing.status_code == 200
+        root_missing = await ds.client.get(
+            "/nope/-/schema.json", actor={"id": "root"}
+        )
+        assert root_missing.status_code == 404
+    finally:
+        ds.close()
+
+
+@pytest.mark.asyncio
+async def test_table_schema_unknown_database_is_404_not_500(ds_client):
+    response = await ds_client.get("/no_such_db/some_table/-/schema.json")
+    assert_canonical_error(response, 404)

From e0ba8b3c6a3d7aa2e4be9866a3dce712196f9a73 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:16:02 +0000
Subject: [PATCH 340/386] Return 400 for unknown _extra names on data formats

Unknown ?_extra= names (including internal HTML-only extras such as
display_rows) were silently ignored, so a typo returned the default
payload with no signal. Table, row and query data formats now return
400 "Unknown _extra: <names>". HTML pages continue to ignore unknown
names.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/extras.py           | 13 +++++++++++++
 datasette/views/database.py   |  3 ++-
 datasette/views/row.py        |  3 +++
 datasette/views/table.py      |  4 ++++
 docs/json_api.rst             |  2 ++
 existing-api.md               |  7 ++++---
 stable-api-recommendations.md |  6 +++++-
 tests/test_error_shape.py     | 34 ++++++++++++++++++++++++++++++++++
 tests/test_table_api.py       |  4 ++--
 9 files changed, 69 insertions(+), 7 deletions(-)

diff --git a/datasette/extras.py b/datasette/extras.py
index 36014185..fb8c2e06 100644
--- a/datasette/extras.py
+++ b/datasette/extras.py
@@ -5,6 +5,8 @@ from typing import ClassVar
 
 from asyncinject import Registry
 
+from datasette.utils.asgi import BadRequest
+
 
 def extra_names_from_request(request):
     extra_bits = request.args.getlist("_extra")
@@ -113,6 +115,17 @@ class ExtraRegistry:
             self._allowed_names[key] = names
         return names
 
+    def validate_requested(self, requested, scope):
+        """
+        Raise BadRequest if any requested extra name is not a public extra
+        for this scope. Used by data formats such as .json - HTML pages
+        silently ignore unknown names instead.
+        """
+        allowed = self._allowed_names_for_scope(scope, include_internal=False)
+        unknown = sorted(name for name in requested if name not in allowed)
+        if unknown:
+            raise BadRequest("Unknown _extra: {}".format(", ".join(unknown)))
+
     async def resolve(self, requested, context, scope, include_internal=False):
         allowed_names = self._allowed_names_for_scope(scope, include_internal)
         requested_names = [name for name in requested if name in allowed_names]
diff --git a/datasette/views/database.py b/datasette/views/database.py
index 99e85d2b..b7131a05 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -8,7 +8,7 @@ import markupsafe
 import os
 import textwrap
 
-from datasette.extras import extra_names_from_request
+from datasette.extras import extra_names_from_request, ExtraScope
 from datasette.database import QueryInterrupted
 from datasette.resources import DatabaseResource, QueryResource
 from datasette.stored_queries import StoredQuery, stored_query_to_dict
@@ -855,6 +855,7 @@ class QueryView(View):
                 raise DatasetteError("?sql= is required", status=400)
             data = {"ok": True, "rows": rows, "columns": columns}
             extras = extra_names_from_request(request)
+            table_extra_registry.validate_requested(extras, ExtraScope.QUERY)
             if extras:
                 query_extra_context = QueryExtraContext(
                     datasette=datasette,
diff --git a/datasette/views/row.py b/datasette/views/row.py
index 71539f34..296a0ac1 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -596,6 +596,9 @@ class RowView(BaseView):
         }
 
         extras = extra_names_from_request(request)
+        if request.url_vars.get("format"):
+            # Data formats reject unknown extras; HTML ignores them
+            table_extra_registry.validate_requested(extras, ExtraScope.ROW)
 
         # Process extras
         row_extra_context = RowExtraContext(
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 44919281..ed3b1276 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -2254,6 +2254,10 @@ async def table_view_data(
 
     # Resolve extras
     extras = extra_names_from_request(request)
+    if not extra_extras:
+        # Data formats reject unknown extras; the HTML path (which passes
+        # extra_extras={"_html"}) resolves internal extras of its own
+        table_extra_registry.validate_requested(extras, ExtraScope.TABLE)
     if any(k for k in request.args.keys() if k == "_facet" or k.startswith("_facet_")):
         extras.add("facet_results")
     if request.args.get("_shape") == "object":
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 2a859ba2..0069055b 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -283,6 +283,8 @@ These can be repeated or comma-separated:
 
     ?_extra=columns&_extra=count,next_url
 
+Requesting an ``_extra`` name that does not exist returns a ``400`` error in the :ref:`standard error format <json_api_errors>`, for example ``{"ok": false, "error": "Unknown _extra: nope", ...}``.
+
 .. [[[cog
     from json_api_doc import table_extras
     table_extras(cog)
diff --git a/existing-api.md b/existing-api.md
index 6ce29bf5..cf456921 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -176,9 +176,10 @@ build JSON directly):
 Table, row and query JSON responses support `?_extra=` (repeatable and/or
 comma-separated, extras.py:9-14) to add keys to the response. Extras are
 scope-registered (`ExtraScope.TABLE` / `ROW` / `QUERY`) and only **public**
-extras are available over JSON (extras.py:73-92). Unknown extra names are
-silently ignored. The available names per scope are listed with the relevant
-endpoints below.
+extras are available over JSON (extras.py:73-92). Unknown extra names (and
+internal HTML-only names) on data formats return 400
+`Unknown _extra: <names>`; HTML pages ignore them. The available names per
+scope are listed with the relevant endpoints below.
 
 ---
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index a92fbfbd..1bc2412e 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -166,7 +166,11 @@ Endpoints disagree about the success envelope:
   matches the read API).~~ ✅ **Done** — row update now returns
   `rows: [{...}]`.
 
-### 2b. `_extra`/`_shape` support is uneven (P2)
+### 2b. `_extra`/`_shape` support is uneven (P2) — partially implemented
+
+> **Status:** unknown `_extra` names on data formats now return 400
+> `Unknown _extra: <names>` (HTML pages still ignore them). Extending
+> extras/shaping to database/instance scope remains open.
 
 The extras system (`?_extra=`, scope-registered) is the 1.0 mechanism for
 response shaping — but it only exists on table, row and query endpoints. The
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 55370c18..f0ff0a42 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -570,3 +570,37 @@ async def test_schema_endpoints_no_existence_oracle(tmp_path_factory):
 async def test_table_schema_unknown_database_is_404_not_500(ds_client):
     response = await ds_client.get("/no_such_db/some_table/-/schema.json")
     assert_canonical_error(response, 404)
+
+
+# Unknown _extra names are a 400, not silently ignored
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "path",
+    (
+        "/fixtures/facetable.json?_extra=nope",
+        "/fixtures/facetable.json?_extra=count,nope",
+        "/fixtures/simple_primary_key/1.json?_extra=nope",
+        "/fixtures/-/query.json?sql=select+1&_extra=nope",
+    ),
+)
+async def test_unknown_extra_is_400(ds_client, path):
+    response = await ds_client.get(path)
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["Unknown _extra: nope"]
+
+
+@pytest.mark.asyncio
+async def test_html_only_extra_via_json_is_400(ds_client):
+    # display_rows exists for the HTML view but is not part of the JSON API
+    response = await ds_client.get("/fixtures/facetable.json?_extra=display_rows")
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["Unknown _extra: display_rows"]
+
+
+@pytest.mark.asyncio
+async def test_unknown_extra_ignored_on_html_pages(ds_client):
+    response = await ds_client.get("/fixtures/facetable?_extra=nope")
+    assert response.status_code == 200
+    assert response.headers["content-type"].startswith("text/html")
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index e3737ee6..ff413be8 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -123,8 +123,8 @@ async def test_html_only_extras_are_not_available_via_json(ds_client, extra):
     # These extras exist for the HTML view; their values are not JSON
     # serializable so they are internal, not part of the JSON API
     response = await ds_client.get(f"/fixtures/facetable.json?_extra={extra}")
-    assert response.status_code == 200
-    assert extra not in response.json()
+    assert response.status_code == 400
+    assert response.json()["errors"] == [f"Unknown _extra: {extra}"]
 
 
 @pytest.mark.asyncio

From 0bf3a54716a18521332aa55dac6a3e420851c82a Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:19:03 +0000
Subject: [PATCH 341/386] Include next_url in default table JSON keys

Table JSON responses previously only included the next pagination token
by default - the ready-to-follow next_url required ?_extra=next_url.
Both keys are now always present (null on the final page), which the
pagination documentation already claimed. The next_url extra remains
valid for backwards compatibility.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/table.py      |  1 +
 docs/json_api.rst             |  3 ++-
 existing-api.md               |  1 +
 stable-api-recommendations.md |  9 ++++++++-
 tests/test_table_api.py       | 21 +++++++++++++++++++++
 5 files changed, 33 insertions(+), 2 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index ed3b1276..69d5a075 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -2318,6 +2318,7 @@ async def table_view_data(
     data = {
         "ok": True,
         "next": next_value and str(next_value) or None,
+        "next_url": next_url,
     }
     data.update(
         await resolve_table_extras(
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 0069055b..dc611a39 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -48,7 +48,7 @@ The ``"rows"`` key is a list of objects, each one representing a row.
 
 The ``"truncated"`` key lets you know if the query was truncated. This can happen if a SQL query returns more than 1,000 results (or the :ref:`setting_max_returned_rows` setting).
 
-For table pages, an additional key ``"next"`` may be present. This indicates that the next page in the pagination set can be retrieved using ``?_next=VALUE``.
+For table pages, two additional keys are present: ``"next"``, an opaque token that can be used to retrieve the next page using ``?_next=TOKEN``, and ``"next_url"``, the full URL of that next page. Both are ``null`` on the final page. See :ref:`json_api_pagination`.
 
 .. _json_api_errors:
 
@@ -128,6 +128,7 @@ options:
     {
       "ok": true,
       "next": null,
+      "next_url": null,
       "rows": [
         [3, "Detroit"],
         [2, "Los Angeles"],
diff --git a/existing-api.md b/existing-api.md
index cf456921..f7f161f3 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -647,6 +647,7 @@ dispatched to `QueryView` (views/table.py:1703-1712).
 |---|---|
 | `ok` | `true` when data was retrieved without error |
 | `next` | pagination token string, or `null` on the last page |
+| `next_url` | absolute URL of the next page, or `null` on the last page |
 | `rows` | list of row objects `{column: value}` (default `_shape=objects`) |
 | `truncated` | always present; `false` for table pages |
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 1bc2412e..d3d5b6a6 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -196,7 +196,14 @@ number.
 
 ---
 
-## 3. Pagination: three mechanisms, two contracts (P2)
+## 3. Pagination: three mechanisms, two contracts (P2) — partially implemented
+
+> **Status:** `next_url` now accompanies `next` in the default table JSON
+> keys (previously it required `?_extra=next_url`), so every response with
+> a `next` token also carries the ready-to-follow URL. Pagination tokens
+> are deliberately left undocumented as to their internal structure. The
+> `_size`/`page_size` naming and `has_more`/`total` differences remain
+> open.
 
 | Endpoint | Mechanism | Token | Extras |
 |---|---|---|---|
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index ff413be8..0a593ff8 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -1491,6 +1491,7 @@ async def test_col_nocol_errors(ds_client, path, expected_error):
             {
                 "ok": True,
                 "next": None,
+                "next_url": None,
                 "columns": ["id", "content", "content2"],
                 "rows": [{"id": "1", "content": "hey", "content2": "world"}],
                 "truncated": False,
@@ -1501,6 +1502,7 @@ async def test_col_nocol_errors(ds_client, path, expected_error):
             {
                 "ok": True,
                 "next": None,
+                "next_url": None,
                 "rows": [{"id": "1", "content": "hey", "content2": "world"}],
                 "truncated": False,
                 "count": 1,
@@ -1627,3 +1629,22 @@ async def test_count_truncated_included_with_count_extra(tmp_path_factory):
         assert response.json()["count_truncated"] is True
     finally:
         ds.close()
+
+
+@pytest.mark.asyncio
+async def test_next_url_included_by_default(ds_client):
+    response = await ds_client.get("/fixtures/compound_three_primary_keys.json")
+    data = response.json()
+    assert data["next"] is not None
+    assert data["next_url"].endswith(
+        "/fixtures/compound_three_primary_keys.json?_next="
+        + urllib.parse.quote(data["next"], safe="")
+    )
+    # Follow to the last page - next and next_url are both null there
+    while data["next"]:
+        response = await ds_client.get(
+            "/fixtures/compound_three_primary_keys.json?_next=" + data["next"]
+        )
+        data = response.json()
+    assert data["next"] is None
+    assert data["next_url"] is None

From e5e9aca871bed96398d4702b7ae25abcfbb96ac8 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:22:31 +0000
Subject: [PATCH 342/386] Require permissions-debug for /-/threads

/-/threads exposes runtime internals - thread idents and asyncio task
reprs including file paths - but only required view-instance. It now
requires permissions-debug, like /-/actions.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/app.py                  |  4 +++-
 docs/introspection.rst            |  2 +-
 existing-api.md                   |  2 +-
 stable-api-recommendations.md     |  5 +++--
 tests/test_api.py                 |  6 +++++-
 tests/test_error_shape.py         | 20 ++++++++++++++------
 tests/test_internals_datasette.py |  3 ++-
 tests/test_success_envelope.py    |  2 +-
 8 files changed, 30 insertions(+), 14 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 9982c58e..daa3848b 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -2584,7 +2584,9 @@ class Datasette:
             r"/-/config(\.(?P<format>json))?$",
         )
         add_route(
-            JsonDataView.as_view(self, "threads.json", self._threads),
+            JsonDataView.as_view(
+                self, "threads.json", self._threads, permission="permissions-debug"
+            ),
             r"/-/threads(\.(?P<format>json))?$",
         )
         add_route(
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 37f258d7..2d13f68b 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -252,7 +252,7 @@ Without those query string arguments, the page lists up to five tables with dete
 /-/threads
 ----------
 
-Shows details of threads and ``asyncio`` tasks. `Threads example <https://latest.datasette.io/-/threads>`_:
+Shows details of threads and ``asyncio`` tasks. This endpoint requires the ``permissions-debug`` permission, since it exposes runtime internals. `Threads example <https://latest.datasette.io/-/threads>`_:
 
 .. code-block:: json
 
diff --git a/existing-api.md b/existing-api.md
index f7f161f3..af7ca3b9 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -249,7 +249,7 @@ value replaced by `"***"` (utils/__init__.py:1532-1556).
 ### GET /-/threads(.json)
 
 app.py:2566-2569, `Datasette._threads` (app.py:2268-2285). Permission
-`view-instance`. No parameters.
+**`permissions-debug`** (exposes runtime internals). No parameters.
 
 Response: `num_threads`, `threads` (list of `{name, ident, daemon}`),
 `num_tasks`, `tasks` (asyncio task repr strings). When the
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index d3d5b6a6..3c216c04 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -306,9 +306,10 @@ Concerns:
   unauthorized actors get a uniform response.~~ ✅ **Done** — permission is
   checked first; the table schema view also now 404s (instead of a 500
   KeyError) for an unknown database.
-- **(P2) `/-/threads` exposes runtime internals** (thread idents, asyncio
+- ~~**(P2) `/-/threads` exposes runtime internals** (thread idents, asyncio
   task reprs including file paths) behind only `view-instance`. Consider
-  `permissions-debug`, alongside `/-/actions` which already requires it.
+  `permissions-debug`, alongside `/-/actions` which already requires it.~~
+  ✅ **Done** — `/-/threads` now requires `permissions-debug`.
 - **(P3) `/-/config` redaction is substring-based** on six key names
   (app.py:2502-2505); plugins storing secrets under other names leak. Worth
   a note in plugin authoring docs plus a `redact_keys` plugin hook.
diff --git a/tests/test_api.py b/tests/test_api.py
index b035edb9..7a575144 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -525,7 +525,11 @@ def test_databases_json(app_client_two_attached_databases_one_immutable):
 
 @pytest.mark.asyncio
 async def test_threads_json(ds_client):
-    response = await ds_client.get("/-/threads.json")
+    ds_client.ds.root_enabled = True
+    try:
+        response = await ds_client.get("/-/threads.json", actor={"id": "root"})
+    finally:
+        ds_client.ds.root_enabled = False
     expected_keys = {"ok", "threads", "num_threads"}
     if sys.version_info >= (3, 7, 0):
         expected_keys.update({"tasks", "num_tasks"})
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index f0ff0a42..a34fbed7 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -554,13 +554,9 @@ async def test_schema_endpoints_no_existence_oracle(tmp_path_factory):
         assert denied_existing.status_code == denied_missing.status_code == 403
 
         # An authorized actor sees the real thing
-        root_existing = await ds.client.get(
-            "/data/-/schema.json", actor={"id": "root"}
-        )
+        root_existing = await ds.client.get("/data/-/schema.json", actor={"id": "root"})
         assert root_existing.status_code == 200
-        root_missing = await ds.client.get(
-            "/nope/-/schema.json", actor={"id": "root"}
-        )
+        root_missing = await ds.client.get("/nope/-/schema.json", actor={"id": "root"})
         assert root_missing.status_code == 404
     finally:
         ds.close()
@@ -604,3 +600,15 @@ async def test_unknown_extra_ignored_on_html_pages(ds_client):
     response = await ds_client.get("/fixtures/facetable?_extra=nope")
     assert response.status_code == 200
     assert response.headers["content-type"].startswith("text/html")
+
+
+# /-/threads exposes runtime internals and requires permissions-debug
+
+
+@pytest.mark.asyncio
+async def test_threads_requires_permissions_debug(ds_error_shape):
+    denied = await ds_error_shape.client.get("/-/threads.json")
+    assert_canonical_error(denied, 403)
+    allowed = await ds_error_shape.client.get("/-/threads.json", actor={"id": "root"})
+    assert allowed.status_code == 200
+    assert allowed.json()["ok"] is True
diff --git a/tests/test_internals_datasette.py b/tests/test_internals_datasette.py
index 2af069c9..85598c05 100644
--- a/tests/test_internals_datasette.py
+++ b/tests/test_internals_datasette.py
@@ -184,10 +184,11 @@ async def test_datasette_constructor():
 @pytest.mark.asyncio
 async def test_num_sql_threads_zero():
     ds = Datasette([], memory=True, settings={"num_sql_threads": 0})
+    ds.root_enabled = True
     db = ds.add_database(Database(ds, memory_name="test_num_sql_threads_zero"))
     await db.execute_write("create table t(id integer primary key)")
     await db.execute_write("insert into t (id) values (1)")
-    response = await ds.client.get("/-/threads.json")
+    response = await ds.client.get("/-/threads.json", actor={"id": "root"})
     assert response.json() == {"ok": True, "num_threads": 0, "threads": []}
     response2 = await ds.client.get("/test_num_sql_threads_zero/t.json?_shape=array")
     assert response2.json() == [{"id": 1}]
diff --git a/tests/test_success_envelope.py b/tests/test_success_envelope.py
index 22ce6580..97cfd72a 100644
--- a/tests/test_success_envelope.py
+++ b/tests/test_success_envelope.py
@@ -34,7 +34,6 @@ def ds_envelope(tmp_path_factory):
         "/-/versions.json",
         "/-/settings.json",
         "/-/config.json",
-        "/-/threads.json",
         "/-/actor.json",
         "/-/jump.json",
         "/-/schema.json",
@@ -58,6 +57,7 @@ async def test_success_object_has_ok_true(ds_client, path):
     (
         "/-/rules.json?action=view-instance",
         "/-/check.json?action=view-instance",
+        "/-/threads.json",
     ),
 )
 async def test_permission_debug_success_has_ok_true(ds_envelope, path):

From 13dc7a08b79c7b62e6eb2c54befa5e6c02915bd3 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:30:04 +0000
Subject: [PATCH 343/386] Fix foreign key label test expectations for default
 next_url key

Follow-up to the commit adding next_url to the default table JSON keys.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 tests/test_table_html.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/test_table_html.py b/tests/test_table_html.py
index 86fb4254..87c48b6b 100644
--- a/tests/test_table_html.py
+++ b/tests/test_table_html.py
@@ -2313,6 +2313,7 @@ async def test_foreign_key_labels_obey_permissions(config):
     assert root_b.json() == {
         "ok": True,
         "next": None,
+        "next_url": None,
         "rows": [{"id": 1, "name": "world", "a_id": {"value": 1, "label": "hello"}}],
         "truncated": False,
     }
@@ -2320,6 +2321,7 @@ async def test_foreign_key_labels_obey_permissions(config):
     assert anon_b.json() == {
         "ok": True,
         "next": None,
+        "next_url": None,
         "rows": [{"id": 1, "name": "world", "a_id": 1}],
         "truncated": False,
     }

From 5cb2bc6909be9a9f9cbd23e7f19f142091cbb5af Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 16:45:19 +0000
Subject: [PATCH 344/386] Homepage JSON returns databases as a list

/.json previously returned databases as an object keyed by database
name, unlike /-/databases.json and every other collection in the API.
It now returns a list of database objects. The HTML template already
consumed the list. This endpoint remains undocumented.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/index.py      |  2 +-
 existing-api.md               |  4 ++--
 stable-api-recommendations.md |  6 ++++--
 tests/test_api.py             | 18 ++++++++++--------
 4 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/datasette/views/index.py b/datasette/views/index.py
index 86f8ae7d..8c5534cb 100644
--- a/datasette/views/index.py
+++ b/datasette/views/index.py
@@ -152,7 +152,7 @@ class IndexView(BaseView):
                 json.dumps(
                     {
                         "ok": True,
-                        "databases": {db["name"]: db for db in databases},
+                        "databases": databases,
                         "metadata": await self.ds.get_instance_metadata(),
                     },
                     cls=CustomJSONEncoder,
diff --git a/existing-api.md b/existing-api.md
index af7ca3b9..8d390f76 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -201,8 +201,8 @@ Routes: `/(\.(?P<format>jsono?))?$` and `/-/(\.(?P<format>jsono?))?$`
 - **Parameters:** `_sort=relationships` sorts each database's truncated table
   list by foreign-key relationship count.
 - **JSON response** (index.py:147-161) — includes `ok: true` plus:
-  - `databases` — an **object keyed by database name** (not a list). Each
-    value: `name`, `hash` (or null), `color`, `path`,
+  - `databases` — a **list** of database objects (undocumented API, subject
+    to change). Each item: `name`, `hash` (or null), `color`, `path`,
     `tables_and_views_truncated` (up to 5 items: `name`, `columns`,
     `primary_keys`, `count` (int or null), `hidden`, `fts_table`,
     `num_relationships_for_sorting`, `private`; view items are just
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 3c216c04..d64b3fb8 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -156,10 +156,12 @@ Endpoints disagree about the success envelope:
 
 ### 2a. Collection representations disagree (P2)
 
-- Homepage `/.json` returns `databases` as an **object keyed by name**
+- ~~Homepage `/.json` returns `databases` as an **object keyed by name**
   (index.py:147-161); `/-/databases.json` returns an **array**; the database
   page returns `tables` as an array. Choose arrays-of-objects everywhere
-  (objects-keyed-by-name break when names need ordering or pagination).
+  (objects-keyed-by-name break when names need ordering or pagination).~~
+  ✅ **Done** — the homepage returns a list, matching `/-/databases.json`.
+  The homepage JSON remains deliberately undocumented.
 - ~~Insert/upsert with `return: true` respond with `rows` (plural, list); row
   update with `return: true` responds with `row` (singular, object)
   (views/row.py:837-844). Pick one (`rows` everywhere, even for one row,
diff --git a/tests/test_api.py b/tests/test_api.py
index 7a575144..17edc0e5 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -26,8 +26,9 @@ async def test_homepage(ds_client):
         "title",
     ]
     databases = data.get("databases")
-    assert databases.keys() == {"fixtures": 0}.keys()
-    d = databases["fixtures"]
+    assert isinstance(databases, list)
+    assert [d["name"] for d in databases] == ["fixtures"]
+    d = databases[0]
     assert d["name"] == "fixtures"
     assert isinstance(d["tables_count"], int)
     assert isinstance(len(d["tables_and_views_truncated"]), int)
@@ -43,7 +44,7 @@ async def test_homepage_sort_by_relationships(ds_client):
     assert response.status_code == 200
     tables = [
         t["name"]
-        for t in response.json()["databases"]["fixtures"]["tables_and_views_truncated"]
+        for t in response.json()["databases"][0]["tables_and_views_truncated"]
     ]
     assert tables == [
         "simple_primary_key",
@@ -251,8 +252,8 @@ def test_no_files_uses_memory_database(app_client_no_files):
     assert response.status == 200
     assert {
         "ok": True,
-        "databases": {
-            "_memory": {
+        "databases": [
+            {
                 "name": "_memory",
                 "hash": None,
                 "color": "a6c7b9",
@@ -267,7 +268,7 @@ def test_no_files_uses_memory_database(app_client_no_files):
                 "views_count": 0,
                 "private": False,
             },
-        },
+        ],
         "metadata": {},
     } == response.json
     # Try that SQL query
@@ -852,8 +853,9 @@ async def test_tilde_encoded_database_names(db_name):
     ds = Datasette()
     ds.add_memory_database(db_name)
     response = await ds.client.get("/.json")
-    assert db_name in response.json()["databases"].keys()
-    path = response.json()["databases"][db_name]["path"]
+    databases_by_name = {d["name"]: d for d in response.json()["databases"]}
+    assert db_name in databases_by_name
+    path = databases_by_name[db_name]["path"]
     # And the JSON for that database
     response2 = await ds.client.get(path + ".json")
     assert response2.status_code == 200

From afa7b1ba0db8e5084889a15261559bcf21435171 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 17:01:53 +0000
Subject: [PATCH 345/386] Add unstable marker to undocumented JSON endpoints

JSON endpoints that are not part of the documented API now include
"unstable": "This API is not part of Datasette's stable interface and
may change at any time" in their responses, making the stability tier
machine-readable. Applied to the homepage (/.json and /-/.json),
/db/-/queries/analyze, POST /db/-/queries/store,
/db/<query>/-/definition, /db/-/query/parameters,
/db/-/execute-write/analyze and the POST /-/permissions playground
response. The message lives in datasette.utils.UNSTABLE_API_MESSAGE.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/utils/__init__.py       |  5 +++
 datasette/views/execute_write.py  | 10 ++---
 datasette/views/index.py          |  2 +
 datasette/views/special.py        |  7 ++++
 datasette/views/stored_queries.py | 35 +++++++++++++-----
 existing-api.md                   | 14 ++++++-
 stable-api-recommendations.md     |  8 +++-
 tests/test_api.py                 |  7 +++-
 tests/test_permissions.py         |  4 ++
 tests/test_queries.py             |  9 ++++-
 tests/test_success_envelope.py    | 61 +++++++++++++++++++++++++++++++
 11 files changed, 142 insertions(+), 20 deletions(-)

diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 17c8702f..1d921f02 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -1294,6 +1294,11 @@ async def derive_named_parameters(db: "Database", sql: str) -> List[str]:
     return named_parameters(sql)
 
 
+UNSTABLE_API_MESSAGE = (
+    "This API is not part of Datasette's stable interface and may change at any time"
+)
+
+
 def error_body(messages, status):
     """
     The canonical JSON error body used by every Datasette JSON error response:
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index b7e8288e..6806e69d 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -2,7 +2,7 @@ import re
 from urllib.parse import urlencode
 
 from datasette.resources import DatabaseResource
-from datasette.utils import sqlite3
+from datasette.utils import UNSTABLE_API_MESSAGE, sqlite3
 from datasette.utils.asgi import Response
 
 from .base import BaseView, _error
@@ -500,8 +500,6 @@ class ExecuteWriteAnalyzeView(BaseView):
                 )
             )
         sql = request.args.get("sql") or ""
-        return _block_framing(
-            Response.json(
-                await _execute_write_analysis_data(self.ds, db, sql, request.actor)
-            )
-        )
+        analysis = await _execute_write_analysis_data(self.ds, db, sql, request.actor)
+        analysis["unstable"] = UNSTABLE_API_MESSAGE
+        return _block_framing(Response.json(analysis))
diff --git a/datasette/views/index.py b/datasette/views/index.py
index 8c5534cb..67296cd1 100644
--- a/datasette/views/index.py
+++ b/datasette/views/index.py
@@ -6,6 +6,7 @@ from datasette.utils import (
     await_me_maybe,
     make_slot_function,
     CustomJSONEncoder,
+    UNSTABLE_API_MESSAGE,
 )
 from datasette.utils.asgi import Response
 from datasette.version import __version__
@@ -152,6 +153,7 @@ class IndexView(BaseView):
                 json.dumps(
                     {
                         "ok": True,
+                        "unstable": UNSTABLE_API_MESSAGE,
                         "databases": databases,
                         "metadata": await self.ds.get_instance_metadata(),
                     },
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 6afb6437..28d4d6a1 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -6,6 +6,7 @@ from datasette.events import LogoutEvent, LoginEvent, CreateTokenEvent
 from datasette.resources import DatabaseResource, TableResource
 from datasette.utils.asgi import Response, Forbidden
 from datasette.utils import (
+    UNSTABLE_API_MESSAGE,
     actor_matches_allow,
     add_cors_headers,
     await_me_maybe,
@@ -295,6 +296,12 @@ class PermissionsDebugView(BaseView):
         response, status = await _check_permission_for_actor(
             self.ds, permission, parent, child, actor
         )
+        if response.get("ok"):
+            response = {
+                "ok": True,
+                "unstable": UNSTABLE_API_MESSAGE,
+                **response,
+            }
         return Response.json(response, status=status)
 
 
diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
index d1f151dd..ea49d983 100644
--- a/datasette/views/stored_queries.py
+++ b/datasette/views/stored_queries.py
@@ -2,7 +2,7 @@ from urllib.parse import parse_qsl, urlencode
 
 from datasette.resources import DatabaseResource, QueryResource
 from datasette.stored_queries import stored_query_to_dict
-from datasette.utils import sqlite3, tilde_decode
+from datasette.utils import UNSTABLE_API_MESSAGE, sqlite3, tilde_decode
 from datasette.utils.asgi import Response
 
 from .base import BaseView, _error
@@ -48,7 +48,15 @@ class QueryParametersView(BaseView):
             parameters = _derived_query_parameters(request.args.get("sql") or "")
         except QueryValidationError as ex:
             return _block_framing(_error([ex.message], ex.status))
-        return _block_framing(Response.json({"ok": True, "parameters": parameters}))
+        return _block_framing(
+            Response.json(
+                {
+                    "ok": True,
+                    "unstable": UNSTABLE_API_MESSAGE,
+                    "parameters": parameters,
+                }
+            )
+        )
 
 
 def _query_list_url(path, query_string, *, set_args=None, remove_args=None):
@@ -315,11 +323,9 @@ class QueryCreateAnalyzeView(BaseView):
                 )
             )
         sql = request.args.get("sql") or ""
-        return _block_framing(
-            Response.json(
-                await _query_create_analysis_data(self.ds, db, sql, request.actor)
-            )
-        )
+        analysis = await _query_create_analysis_data(self.ds, db, sql, request.actor)
+        analysis["unstable"] = UNSTABLE_API_MESSAGE
+        return _block_framing(Response.json(analysis))
 
 
 class QueryStoreView(QueryCreateView):
@@ -384,7 +390,12 @@ class QueryStoreView(QueryCreateView):
         assert query is not None
         if is_json:
             return Response.json(
-                {"ok": True, "query": stored_query_to_dict(query)}, status=201
+                {
+                    "ok": True,
+                    "unstable": UNSTABLE_API_MESSAGE,
+                    "query": stored_query_to_dict(query),
+                },
+                status=201,
             )
         self.ds.add_message(request, "Query saved", self.ds.INFO)
         return Response.redirect(self.ds.urls.path(self.ds.urls.table(db.name, name)))
@@ -405,7 +416,13 @@ class QueryDefinitionView(BaseView):
             actor=request.actor,
         ):
             return _error(["Permission denied"], 403)
-        return Response.json({"ok": True, "query": stored_query_to_dict(query)})
+        return Response.json(
+            {
+                "ok": True,
+                "unstable": UNSTABLE_API_MESSAGE,
+                "query": stored_query_to_dict(query),
+            }
+        )
 
 
 class QueryUpdateView(BaseView):
diff --git a/existing-api.md b/existing-api.md
index 8d390f76..2f9996dc 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -43,7 +43,7 @@ directory: every claim below is based on the route table in `datasette/app.py`
 - Success content type: `application/json; charset=utf-8`
   (`_shape=array&_nl=on` responses use `text/plain`).
 
-### Success envelope
+### Success envelope and stability marker
 
 Every JSON endpoint that returns an object includes `"ok": true` on
 success. `JsonDataView` injects it automatically for dict responses
@@ -52,6 +52,18 @@ autocomplete views add it explicitly. The former top-level-array endpoints
 (`/-/plugins`, `/-/databases`, `/-/actions`) now return objects wrapping
 their arrays (`{"ok": true, "plugins": [...]}` etc.).
 
+JSON endpoints that are **not part of the documented API** include a
+marker key (`UNSTABLE_API_MESSAGE` in utils/__init__.py):
+
+```json
+"unstable": "This API is not part of Datasette's stable interface and may change at any time"
+```
+
+Currently: the homepage (`/.json`, `/-/.json`), `/db/-/queries/analyze`,
+`POST /db/-/queries/store`, `/db/<query>/-/definition`,
+`/db/-/query/parameters`, `/db/-/execute-write/analyze` and the
+`POST /-/permissions` playground response.
+
 ### Error shape (canonical)
 
 Every JSON error response uses one canonical shape, built by `error_body()`
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index d64b3fb8..baac80f7 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -378,7 +378,13 @@ Concerns:
 
 ---
 
-## 9. Define stability tiers explicitly (P1 — documentation, not code)
+## 9. Define stability tiers explicitly (P1 — documentation, not code) — partially implemented
+
+> **Status:** undocumented JSON endpoints now self-describe with an
+> `"unstable": "This API is not part of Datasette's stable interface and
+> may change at any time"` key (homepage, queries analyze/store/definition,
+> query parameters, execute-write analyze, permissions playground POST).
+> The written tier documentation remains to be done.
 
 Not everything under `/-/` can or should carry a 1.0 guarantee. Recommend
 shipping 1.0 with an explicit three-tier contract, per endpoint:
diff --git a/tests/test_api.py b/tests/test_api.py
index 17edc0e5..8ce38fad 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -43,8 +43,7 @@ async def test_homepage_sort_by_relationships(ds_client):
     response = await ds_client.get("/.json?_sort=relationships")
     assert response.status_code == 200
     tables = [
-        t["name"]
-        for t in response.json()["databases"][0]["tables_and_views_truncated"]
+        t["name"] for t in response.json()["databases"][0]["tables_and_views_truncated"]
     ]
     assert tables == [
         "simple_primary_key",
@@ -252,6 +251,10 @@ def test_no_files_uses_memory_database(app_client_no_files):
     assert response.status == 200
     assert {
         "ok": True,
+        "unstable": (
+            "This API is not part of Datasette's stable interface"
+            " and may change at any time"
+        ),
         "databases": [
             {
                 "name": "_memory",
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index 32606789..f8d2c808 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -740,6 +740,10 @@ async def test_actor_restricted_permissions(
     }
     expected = {
         "ok": True,
+        "unstable": (
+            "This API is not part of Datasette's stable interface"
+            " and may change at any time"
+        ),
         "action": permission,
         "allowed": expected_result,
         "resource": expected_resource,
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 11828c4e..7f29a3fb 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -2140,7 +2140,14 @@ async def test_query_parameters_endpoint_uses_get_sql_only():
     )
 
     assert response.status_code == 200
-    assert response.json() == {"ok": True, "parameters": ["name", "id"]}
+    assert response.json() == {
+        "ok": True,
+        "unstable": "{}".format(
+            "This API is not part of Datasette's stable interface"
+            " and may change at any time"
+        ),
+        "parameters": ["name", "id"],
+    }
     assert permission_denied_response.status_code == 403
     assert permission_denied_response.json()["errors"] == [
         "Permission denied: need execute-sql"
diff --git a/tests/test_success_envelope.py b/tests/test_success_envelope.py
index 97cfd72a..68b042e5 100644
--- a/tests/test_success_envelope.py
+++ b/tests/test_success_envelope.py
@@ -112,3 +112,64 @@ async def test_actions_json_is_object(ds_envelope):
     assert data["ok"] is True
     assert isinstance(data["actions"], list)
     assert "view-instance" in {action["name"] for action in data["actions"]}
+
+
+UNSTABLE_MESSAGE = (
+    "This API is not part of Datasette's stable interface and may change at any time"
+)
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    "path",
+    (
+        "/.json",
+        "/-/.json",
+        "/fixtures/-/queries/analyze?sql=select+1",
+        "/fixtures/-/query/parameters?sql=select+:name",
+        "/fixtures/-/execute-write/analyze?sql=delete+from+facetable",
+    ),
+)
+async def test_undocumented_endpoints_report_unstable(ds_client, path):
+    ds_client.ds.root_enabled = True
+    try:
+        response = await ds_client.get(path, actor={"id": "root"})
+    finally:
+        ds_client.ds.root_enabled = False
+    assert response.status_code == 200
+    assert response.json()["unstable"] == UNSTABLE_MESSAGE
+
+
+@pytest.mark.asyncio
+async def test_query_store_and_definition_report_unstable(ds_envelope):
+    store = await ds_envelope.client.post(
+        "/data/-/queries/store",
+        json={"query": {"name": "unstable_check", "sql": "select 1"}},
+        actor={"id": "root"},
+    )
+    assert store.status_code == 201
+    assert store.json()["unstable"] == UNSTABLE_MESSAGE
+    definition = await ds_envelope.client.get(
+        "/data/unstable_check/-/definition", actor={"id": "root"}
+    )
+    assert definition.status_code == 200
+    assert definition.json()["unstable"] == UNSTABLE_MESSAGE
+
+
+@pytest.mark.asyncio
+async def test_permissions_post_reports_unstable(ds_envelope):
+    response = await ds_envelope.client.post(
+        "/-/permissions",
+        data={"actor": '{"id": "root"}', "permission": "view-instance"},
+        actor={"id": "root"},
+    )
+    assert response.status_code == 200
+    assert response.json()["unstable"] == UNSTABLE_MESSAGE
+
+
+@pytest.mark.asyncio
+async def test_documented_endpoints_do_not_report_unstable(ds_client):
+    for path in ("/-/versions.json", "/fixtures.json", "/fixtures/facetable.json"):
+        response = await ds_client.get(path)
+        assert response.status_code == 200
+        assert "unstable" not in response.json()

From 404ee4c3a79c213d47e263e796364f8b471bde05 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 17:07:04 +0000
Subject: [PATCH 346/386] Document the JSON API stability promise

docs/json_api.rst now opens with an API stability section declaring
what the 1.x promise covers: documented endpoints, parameters and
response keys are stable with additive-only changes; pagination tokens
are opaque strings; the error format and token restriction semantics
are stable. It lists the exempt tiers: endpoints carrying the
"unstable" marker key, debug and support endpoints (/-/threads,
/-/actions, /-/jump, the permission debug endpoints, table
autocomplete), and keys explicitly labeled unstable such as the
execute-write analysis block. Cross-referenced from the introspection
and permission-debug documentation.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 docs/authentication.rst       |  2 ++
 docs/introspection.rst        |  2 ++
 docs/json_api.rst             | 49 ++++++++++++++++++++++++++++++++++-
 stable-api-recommendations.md | 20 ++++++++------
 4 files changed, 64 insertions(+), 9 deletions(-)

diff --git a/docs/authentication.rst b/docs/authentication.rst
index 72ac5fa6..7d4d019d 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1151,6 +1151,8 @@ It also provides an interface for running hypothetical permission checks against
 
 This is designed to help administrators and plugin authors understand exactly how permission checks are being carried out, in order to effectively configure Datasette's permission system.
 
+These debug endpoints are exempt from the :ref:`JSON API stability promise <json_api_stability>` - their JSON shapes may change in future releases.
+
 .. _AllowedResourcesView:
 
 Allowed resources view
diff --git a/docs/introspection.rst b/docs/introspection.rst
index 2d13f68b..ea94b70d 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -9,6 +9,8 @@ Each of these pages can be viewed in your browser. Add ``.json`` to the URL to g
 
 JSON responses that return an object include an ``"ok": true`` key, consistent with the rest of the :ref:`JSON API <json_api>`.
 
+The introspection endpoints documented on this page are covered by the :ref:`JSON API stability promise <json_api_stability>`, with the exception of the debug endpoints ``/-/threads``, ``/-/actions`` and ``/-/jump``, whose shapes may change in future releases.
+
 .. _JsonDataView_metadata:
 
 /-/metadata
diff --git a/docs/json_api.rst b/docs/json_api.rst
index dc611a39..4b1f26d2 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -9,6 +9,53 @@ through the Datasette user interface can also be accessed as JSON via the API.
 To access the API for a page, either click on the ``.json`` link on that page or
 edit the URL and add a ``.json`` extension to it.
 
+.. _json_api_stability:
+
+API stability
+-------------
+
+Datasette 1.0 makes a stability promise for its JSON API: the endpoints,
+parameters and response keys documented here and on the pages this
+documentation links to will not change in backwards-incompatible ways for
+the duration of the 1.x release series.
+
+Stability means:
+
+- Documented endpoints will keep their URLs, methods, parameters and
+  permission requirements.
+- Documented response keys will keep their names and types. New keys may be
+  **added** in any release - clients should ignore keys they do not
+  recognize.
+- The documented ``?_extra=`` names, ``?_shape=`` values and
+  :ref:`column filter operators <table_arguments>` are stable.
+- Pagination tokens - the ``"next"`` key and ``?_next=`` parameter - are
+  **opaque strings**. Pass them back exactly as you received them; their
+  internal structure is not part of the API and can change at any time.
+- The :ref:`standard error format <json_api_errors>` and the
+  :ref:`API token format and restriction semantics <CreateTokenView>` are
+  stable, including the action abbreviations stored inside signed tokens.
+
+Some JSON endpoints are **exempt** from this promise:
+
+- Endpoints that are not documented include this marker key in their
+  responses and can change at any time::
+
+      "unstable": "This API is not part of Datasette's stable interface and may change at any time"
+
+  This currently covers the instance homepage (``/.json``), the stored
+  query ``analyze``/``store``/``definition`` endpoints, ``/-/query/parameters``,
+  ``/-/execute-write/analyze`` and the JSON returned by the ``/-/permissions``
+  debug playground.
+- Debug and support endpoints are documented so you can use them, but their
+  JSON shapes are not frozen: :ref:`/-/threads <JsonDataView_threads>`,
+  :ref:`/-/actions <JsonDataView_actions>`, :ref:`/-/jump <JumpView>`,
+  the :ref:`permission debug endpoints <PermissionsDebugView>`
+  (``/-/allowed``, ``/-/rules``, ``/-/check``) and the
+  :ref:`table autocomplete endpoint <TableAutocompleteView>`.
+- Response keys explicitly labeled as unstable in this documentation, such
+  as the ``"analysis"`` block returned by :ref:`execute-write <ExecuteWriteView>`
+  and the ``debug`` and ``request`` extras.
+
 .. _json_api_default:
 
 Default representation
@@ -1612,7 +1659,7 @@ Unsupported SQL operations are rejected by default. ``VACUUM`` is not allowed in
 A successful response includes a message, the SQLite ``rowcount``, a ``"rows"``
 list, a ``"truncated"`` flag and a summary of the operations that were executed:
 
-The shape of the ``"analysis"`` block is not yet considered a stable API and may change in future Datasette releases.
+The shape of the ``"analysis"`` block is not part of the :ref:`stable API <json_api_stability>` and may change in future Datasette releases.
 
 .. code-block:: json
 
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index baac80f7..b86d8228 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -378,13 +378,17 @@ Concerns:
 
 ---
 
-## 9. Define stability tiers explicitly (P1 — documentation, not code) — partially implemented
+## 9. Define stability tiers explicitly (P1 — documentation, not code) — ✅ IMPLEMENTED
 
-> **Status:** undocumented JSON endpoints now self-describe with an
-> `"unstable": "This API is not part of Datasette's stable interface and
-> may change at any time"` key (homepage, queries analyze/store/definition,
-> query parameters, execute-write analyze, permissions playground POST).
-> The written tier documentation remains to be done.
+> **Status:** implemented. Undocumented JSON endpoints self-describe with
+> an `"unstable"` marker key, and `docs/json_api.rst` now opens with an
+> "API stability" section (`json_api_stability`) declaring the 1.x
+> promise: documented endpoints/keys are stable with additive-only
+> changes, pagination tokens are opaque, the error format and token
+> restriction semantics are stable, and the exempt tiers (marker-key
+> endpoints, debug/support endpoints, explicitly-unstable keys) are
+> listed. Cross-referenced from the introspection and permission-debug
+> docs.
 
 Not everything under `/-/` can or should carry a 1.0 guarantee. Recommend
 shipping 1.0 with an explicit three-tier contract, per endpoint:
@@ -431,8 +435,8 @@ Two details make tiering urgent rather than optional:
    `permissions-debug` (§6).~~ ✅ Done.
 6. ~~401 (not silent-anonymous) for invalid/expired bearer tokens (§1c).~~
    ✅ Done.
-7. Publish explicit stability tiers, including extras and pagination-token
-   opacity (§9).
+7. ~~Publish explicit stability tiers, including extras and pagination-token
+   opacity (§9).~~ ✅ Done.
 8. Resolve the looks-like-a-bug list (§8), especially ~~trusted-query delete
    and row-delete 500~~ (both done).
 

From 3a0ea585572ce56576b25ba3a843c587b98891c0 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 4 Jul 2026 17:54:03 +0000
Subject: [PATCH 347/386] Unify page-size parameters on _size with table
 semantics

The stored query lists silently clamped out-of-range ?_size= values
(a request for 5000 quietly returned 1000) and did not accept the max
keyword. They now share the table view semantics via a new
parse_size_limit() helper: blank means default, "max" means the
maximum (max_returned_rows for query lists), negative or non-integer
values are a 400, and values over the maximum are a 400 instead of
being silently clamped.

The /-/allowed and /-/rules debug endpoints renamed their bare
page/page_size parameters to _page/_size, matching the underscore
grammar used by every other system parameter, with the same validation
(400 instead of silently capping page_size at 200). Their HTML debug
pages and next_url/previous_url builders use the new names.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/templates/debug_allowed.html | 10 ++---
 datasette/templates/debug_rules.html   | 10 ++---
 datasette/utils/__init__.py            | 22 +++++++++++
 datasette/views/query_helpers.py       |  9 ++---
 datasette/views/special.py             | 53 +++++++++++++-------------
 datasette/views/stored_queries.py      |  1 +
 docs/authentication.rst                |  4 +-
 docs/pages.rst                         |  2 +-
 existing-api.md                        |  9 +++--
 stable-api-recommendations.md          | 10 +++--
 tests/test_error_shape.py              | 50 ++++++++++++++++++++++++
 tests/test_html.py                     |  6 +--
 tests/test_permission_endpoints.py     | 14 +++----
 13 files changed, 137 insertions(+), 63 deletions(-)

diff --git a/datasette/templates/debug_allowed.html b/datasette/templates/debug_allowed.html
index 4f8106b8..83cc1ae6 100644
--- a/datasette/templates/debug_allowed.html
+++ b/datasette/templates/debug_allowed.html
@@ -49,7 +49,7 @@
 
         <div class="form-section">
             <label for="page_size">Page size:</label>
-            <input type="number" id="page_size" name="page_size" value="50" min="1" max="200" style="max-width: 100px;">
+            <input type="number" id="page_size" name="_size" value="50" min="1" max="200" style="max-width: 100px;">
             <small>Number of results per page (max 200)</small>
         </div>
 
@@ -88,7 +88,7 @@ const hasDebugPermission = {{ 'true' if has_debug_permission else 'false' }};
 (function() {
     const params = populateFormFromURL();
     const action = params.get('action');
-    const page = params.get('page');
+    const page = params.get('_page');
     if (action) {
         fetchResults(page ? parseInt(page) : 1);
     }
@@ -102,14 +102,14 @@ async function fetchResults(page = 1) {
     const params = new URLSearchParams();
 
     for (const [key, value] of formData.entries()) {
-        if (value && key !== 'page_size') {
+        if (value && key !== '_size' && key !== '_page') {
             params.append(key, value);
         }
     }
 
     const pageSize = document.getElementById('page_size').value || '50';
-    params.append('page', page.toString());
-    params.append('page_size', pageSize);
+    params.append('_page', page.toString());
+    params.append('_size', pageSize);
 
     try {
         const response = await fetch('{{ urls.path("-/allowed.json") }}?' + params.toString(), {
diff --git a/datasette/templates/debug_rules.html b/datasette/templates/debug_rules.html
index aafa755d..d00ba9cc 100644
--- a/datasette/templates/debug_rules.html
+++ b/datasette/templates/debug_rules.html
@@ -37,7 +37,7 @@
 
         <div class="form-section">
             <label for="page_size">Page size:</label>
-            <input type="number" id="page_size" name="page_size" value="50" min="1" max="200" style="max-width: 100px;">
+            <input type="number" id="page_size" name="_size" value="50" min="1" max="200" style="max-width: 100px;">
             <small>Number of results per page (max 200)</small>
         </div>
 
@@ -75,7 +75,7 @@ const submitBtn = document.getElementById('submit-btn');
 (function() {
     const params = populateFormFromURL();
     const action = params.get('action');
-    const page = params.get('page');
+    const page = params.get('_page');
     if (action) {
         fetchResults(page ? parseInt(page) : 1);
     }
@@ -89,14 +89,14 @@ async function fetchResults(page = 1) {
     const params = new URLSearchParams();
 
     for (const [key, value] of formData.entries()) {
-        if (value && key !== 'page_size') {
+        if (value && key !== '_size' && key !== '_page') {
             params.append(key, value);
         }
     }
 
     const pageSize = document.getElementById('page_size').value || '50';
-    params.append('page', page.toString());
-    params.append('page_size', pageSize);
+    params.append('_page', page.toString());
+    params.append('_size', pageSize);
 
     try {
         const response = await fetch('{{ urls.path("-/rules.json") }}?' + params.toString(), {
diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 1d921f02..19de31ff 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -1294,6 +1294,28 @@ async def derive_named_parameters(db: "Database", sql: str) -> List[str]:
     return named_parameters(sql)
 
 
+def parse_size_limit(value, default, maximum, name="_size"):
+    """
+    Parse a page-size parameter using the same semantics as the table
+    view's ?_size=: blank means default, "max" means maximum, integers
+    must be 0 or greater and no larger than maximum. Raises ValueError
+    with a message suitable for a 400 response.
+    """
+    if value in (None, ""):
+        return default
+    if value == "max":
+        return maximum
+    try:
+        size = int(value)
+        if size < 0:
+            raise ValueError
+    except ValueError:
+        raise ValueError("{} must be a positive integer".format(name))
+    if size > maximum:
+        raise ValueError("{} must be <= {}".format(name, maximum))
+    return size
+
+
 UNSTABLE_API_MESSAGE = (
     "This API is not part of Datasette's stable interface and may change at any time"
 )
diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index 026a999f..e9f85b6d 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -13,6 +13,7 @@ from datasette.write_sql import (
     operation_is_write,
 )
 from datasette.utils import (
+    parse_size_limit,
     named_parameters as derive_named_parameters,
     escape_sqlite,
     path_from_row_pks,
@@ -94,13 +95,11 @@ def _as_optional_bool(value, name):
     raise QueryValidationError("{} must be 0 or 1".format(name))
 
 
-def _query_list_limit(value, default=50):
-    if value in (None, ""):
-        return default
+def _query_list_limit(value, default, maximum):
     try:
-        return min(max(1, int(value)), 1000)
+        return parse_size_limit(value, default, maximum)
     except ValueError as ex:
-        raise QueryValidationError("_size must be an integer") from ex
+        raise QueryValidationError(str(ex)) from ex
 
 
 def _derived_query_parameters(sql):
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 28d4d6a1..9386440c 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -8,6 +8,7 @@ from datasette.utils.asgi import Response, Forbidden
 from datasette.utils import (
     UNSTABLE_API_MESSAGE,
     actor_matches_allow,
+    parse_size_limit,
     add_cors_headers,
     await_me_maybe,
     error_body,
@@ -373,17 +374,17 @@ class AllowedResourcesView(BaseView):
             )
 
         try:
-            page = int(request.args.get("page", "1"))
-            page_size = int(request.args.get("page_size", "50"))
+            page = int(request.args.get("_page", "1"))
+            if page < 1:
+                raise ValueError
         except ValueError:
-            return error_body("page and page_size must be integers", 400), 400
-        if page < 1:
-            return error_body("page must be >= 1", 400), 400
-        if page_size < 1:
-            return error_body("page_size must be >= 1", 400), 400
-        max_page_size = 200
-        if page_size > max_page_size:
-            page_size = max_page_size
+            return error_body("_page must be a positive integer", 400), 400
+        try:
+            page_size = parse_size_limit(
+                request.args.get("_size"), default=50, maximum=200
+            )
+        except ValueError as ex:
+            return error_body(str(ex), 400), 400
         offset = (page - 1) * page_size
 
         # Use the simplified allowed_resources method
@@ -448,12 +449,12 @@ class AllowedResourcesView(BaseView):
         def build_page_url(page_number):
             pairs = []
             for key in request.args:
-                if key in {"page", "page_size"}:
+                if key in {"_page", "_size"}:
                     continue
                 for value in request.args.getlist(key):
                     pairs.append((key, value))
-            pairs.append(("page", str(page_number)))
-            pairs.append(("page_size", str(page_size)))
+            pairs.append(("_page", str(page_number)))
+            pairs.append(("_size", str(page_size)))
             query = urllib.parse.urlencode(pairs)
             return f"{request.path}?{query}"
 
@@ -511,19 +512,19 @@ class PermissionRulesView(BaseView):
         actor = request.actor if isinstance(request.actor, dict) else None
 
         try:
-            page = int(request.args.get("page", "1"))
-            page_size = int(request.args.get("page_size", "50"))
+            page = int(request.args.get("_page", "1"))
+            if page < 1:
+                raise ValueError
         except ValueError:
             return Response.json(
-                error_body("page and page_size must be integers", 400), status=400
+                error_body("_page must be a positive integer", 400), status=400
             )
-        if page < 1:
-            return Response.json(error_body("page must be >= 1", 400), status=400)
-        if page_size < 1:
-            return Response.json(error_body("page_size must be >= 1", 400), status=400)
-        max_page_size = 200
-        if page_size > max_page_size:
-            page_size = max_page_size
+        try:
+            page_size = parse_size_limit(
+                request.args.get("_size"), default=50, maximum=200
+            )
+        except ValueError as ex:
+            return Response.json(error_body(str(ex), 400), status=400)
         offset = (page - 1) * page_size
 
         from datasette.utils.actions_sql import build_permission_rules_sql
@@ -574,12 +575,12 @@ class PermissionRulesView(BaseView):
         def build_page_url(page_number):
             pairs = []
             for key in request.args:
-                if key in {"page", "page_size"}:
+                if key in {"_page", "_size"}:
                     continue
                 for value in request.args.getlist(key):
                     pairs.append((key, value))
-            pairs.append(("page", str(page_number)))
-            pairs.append(("page_size", str(page_size)))
+            pairs.append(("_page", str(page_number)))
+            pairs.append(("_size", str(page_size)))
             query = urllib.parse.urlencode(pairs)
             return f"{request.path}?{query}"
 
diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
index ea49d983..bb23a6bd 100644
--- a/datasette/views/stored_queries.py
+++ b/datasette/views/stored_queries.py
@@ -90,6 +90,7 @@ class QueryListView(BaseView):
             limit = _query_list_limit(
                 request.args.get("_size"),
                 default=20 if format_ == "html" else 50,
+                maximum=self.ds.max_returned_rows,
             )
             is_write = _as_optional_bool(request.args.get("is_write"), "is_write")
             is_private = _as_optional_bool(request.args.get("is_private"), "is_private")
diff --git a/docs/authentication.rst b/docs/authentication.rst
index 7d4d019d..0a476c1c 100644
--- a/docs/authentication.rst
+++ b/docs/authentication.rst
@@ -1162,7 +1162,7 @@ The ``/-/allowed`` endpoint displays resources that the current actor can access
 
 This endpoint provides an interactive HTML form interface. Add ``.json`` to the URL path (e.g. ``/-/allowed.json``) to get the raw JSON response instead.
 
-Pass ``?action=view-table`` (or another action) to select the action. Optional ``parent=`` and ``child=`` query parameters can narrow the results to a specific database/table pair.
+Pass ``?action=view-table`` (or another action) to select the action. Optional ``parent=`` and ``child=`` query parameters can narrow the results to a specific database/table pair. Results are paginated: ``?_size=`` sets the page size (default 50, maximum 200, ``max`` for the maximum) and ``?_page=`` selects a page.
 
 This endpoint is publicly accessible to help users understand their own permissions. The potentially sensitive ``reason`` field is only shown to users with the ``permissions-debug`` permission - it shows the plugins and explanatory reasons that were responsible for each decision.
 
@@ -1175,7 +1175,7 @@ The ``/-/rules`` endpoint displays all permission rules (both allow and deny) fo
 
 This endpoint provides an interactive HTML form interface. Add ``.json`` to the URL path (e.g. ``/-/rules.json?action=view-table``) to get the raw JSON response instead.
 
-Pass ``?action=`` as a query parameter to specify which action to check.
+Pass ``?action=`` as a query parameter to specify which action to check. The ``?_size=`` and ``?_page=`` pagination parameters work the same as on ``/-/allowed``.
 
 This endpoint requires the ``permissions-debug`` permission.
 
diff --git a/docs/pages.rst b/docs/pages.rst
index 67fe390b..65c03a49 100644
--- a/docs/pages.rst
+++ b/docs/pages.rst
@@ -95,7 +95,7 @@ Use the :ref:`ExecuteWriteView` JSON API to execute writable SQL programmaticall
 Stored query browsers
 ---------------------
 
-The ``/-/queries`` page lists stored queries across every database visible to the current actor. The ``/database-name/-/queries`` page lists stored queries for a single database.
+The ``/-/queries`` page lists stored queries across every database visible to the current actor. The ``/database-name/-/queries`` page lists stored queries for a single database. The JSON versions accept ``?_size=`` (default 50, ``max`` for the :ref:`setting_max_returned_rows` limit) and a ``?_next=`` pagination token.
 
 These pages support search, pagination and filters for read-only or writable queries and private or public queries. Adding a ``.json`` extension to either URL returns the same list as JSON.
 
diff --git a/existing-api.md b/existing-api.md
index 2f9996dc..c0c8e442 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -377,8 +377,8 @@ path always renders the HTML form; `.json` returns JSON.
   resources. Items gain a `reason` field if the actor also holds
   `permissions-debug`.
 - **Parameters:** `action` (required; missing → 400 canonical error, unknown
-  → 404), `parent`, `child` (requires `parent`), `page` (default 1),
-  `page_size` (default 50, silently capped at 200).
+  → 404), `parent`, `child` (requires `parent`), `_page` (default 1),
+  `_size` (default 50, maximum 200, accepts `max`; out-of-range → 400).
 - **Response:** `{"action", "actor_id", "page", "page_size", "total",
   "items": [{"parent", "child", "resource"}]}` with optional `next_url` /
   `previous_url`.
@@ -1031,8 +1031,9 @@ databases (`database`/`database_color` are null, `show_database` true).
 
 - **Permissions:** no single gate; results filtered per query by
   `view-query` (private queries appear only for their owner).
-- **Parameters:** `_size` (default 20 HTML / **50 JSON**, clamped 1–1000;
-  non-integer → 400), `_next` (cursor), `q` (substring search over
+- **Parameters:** `_size` (default 20 HTML / **50 JSON**; accepts `max`;
+  values over `max_returned_rows` or non-integers → 400, matching table
+  `_size` semantics), `_next` (cursor), `q` (substring search over
   name/title/description/sql), `is_write` / `is_private` (booleans; invalid →
   400 `"is_write must be 0 or 1"`), `source`, `owner_id`.
 - **Response** — 200:
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index b86d8228..ba837204 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -203,9 +203,13 @@ number.
 > **Status:** `next_url` now accompanies `next` in the default table JSON
 > keys (previously it required `?_extra=next_url`), so every response with
 > a `next` token also carries the ready-to-follow URL. Pagination tokens
-> are deliberately left undocumented as to their internal structure. The
-> `_size`/`page_size` naming and `has_more`/`total` differences remain
-> open.
+> are deliberately left undocumented as to their internal structure.
+> `_size` is now the single page-size parameter with uniform table-style
+> semantics everywhere: query lists accept `max` and 400 on out-of-range
+> values (previously silently clamped), and the `/-/allowed` and
+> `/-/rules` debug endpoints renamed `page`/`page_size` to
+> `_page`/`_size` with the same validation (400 instead of silent
+> capping at 200). The `has_more`/`total` differences remain open.
 
 | Endpoint | Mechanism | Token | Extras |
 |---|---|---|---|
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index a34fbed7..2398940b 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -612,3 +612,53 @@ async def test_threads_requires_permissions_debug(ds_error_shape):
     allowed = await ds_error_shape.client.get("/-/threads.json", actor={"id": "root"})
     assert allowed.status_code == 200
     assert allowed.json()["ok"] is True
+
+
+# _size is the one page-size parameter, with uniform validation
+
+
+@pytest.mark.asyncio
+async def test_query_list_size_supports_max_keyword(ds_client):
+    response = await ds_client.get("/fixtures/-/queries.json?_size=max")
+    assert response.status_code == 200
+    # ds_client runs with max_returned_rows=100
+    assert response.json()["limit"] == 100
+
+
+@pytest.mark.asyncio
+async def test_query_list_size_rejects_out_of_range(ds_client):
+    response = await ds_client.get("/fixtures/-/queries.json?_size=5000")
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["_size must be <= 100"]
+
+
+@pytest.mark.asyncio
+async def test_query_list_size_rejects_non_integer(ds_client):
+    response = await ds_client.get("/fixtures/-/queries.json?_size=bananas")
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["_size must be a positive integer"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize("endpoint", ("allowed", "rules"))
+async def test_debug_endpoints_use_size_and_page_parameters(ds_error_shape, endpoint):
+    base = "/-/{}.json?action=view-instance".format(endpoint)
+    ok = await ds_error_shape.client.get(
+        base + "&_size=1&_page=1", actor={"id": "root"}
+    )
+    assert ok.status_code == 200
+    assert ok.json()["page_size"] == 1
+
+    max_size = await ds_error_shape.client.get(
+        base + "&_size=max", actor={"id": "root"}
+    )
+    assert max_size.status_code == 200
+    assert max_size.json()["page_size"] == 200
+
+    too_big = await ds_error_shape.client.get(base + "&_size=500", actor={"id": "root"})
+    data = assert_canonical_error(too_big, 400)
+    assert data["errors"] == ["_size must be <= 200"]
+
+    bad_page = await ds_error_shape.client.get(base + "&_page=0", actor={"id": "root"})
+    data = assert_canonical_error(bad_page, 400)
+    assert data["errors"] == ["_page must be a positive integer"]
diff --git a/tests/test_html.py b/tests/test_html.py
index 22943300..b4c47d80 100644
--- a/tests/test_html.py
+++ b/tests/test_html.py
@@ -1363,12 +1363,12 @@ async def test_permission_debug_tabs_with_query_string(ds_client):
 
         # Test /-/allowed with query string
         response = await ds_client.get(
-            "/-/allowed?action=view-table&page_size=50", actor=actor
+            "/-/allowed?action=view-table&_size=50", actor=actor
         )
         assert response.status_code == 200
         # Check that Rules and Check tabs have the query string
-        assert 'href="/-/rules?action=view-table&amp;page_size=50"' in response.text
-        assert 'href="/-/check?action=view-table&amp;page_size=50"' in response.text
+        assert 'href="/-/rules?action=view-table&amp;_size=50"' in response.text
+        assert 'href="/-/check?action=view-table&amp;_size=50"' in response.text
         # Playground and Actions should not have query string
         assert 'href="/-/permissions"' in response.text
         assert 'href="/-/actions"' in response.text
diff --git a/tests/test_permission_endpoints.py b/tests/test_permission_endpoints.py
index e25be23e..8726ab62 100644
--- a/tests/test_permission_endpoints.py
+++ b/tests/test_permission_endpoints.py
@@ -137,9 +137,7 @@ async def test_allowed_json_pagination():
     await ds.refresh_schemas()
 
     # Test page 1
-    response = await ds.client.get(
-        "/-/allowed.json?action=view-table&page_size=10&page=1"
-    )
+    response = await ds.client.get("/-/allowed.json?action=view-table&_size=10&_page=1")
     assert response.status_code == 200
     data = response.json()
     assert data["page"] == 1
@@ -147,9 +145,7 @@ async def test_allowed_json_pagination():
     assert len(data["items"]) == 10
 
     # Test page 2
-    response = await ds.client.get(
-        "/-/allowed.json?action=view-table&page_size=10&page=2"
-    )
+    response = await ds.client.get("/-/allowed.json?action=view-table&_size=10&_page=2")
     assert response.status_code == 200
     data = response.json()
     assert data["page"] == 2
@@ -157,10 +153,10 @@ async def test_allowed_json_pagination():
 
     # Verify items are different between pages
     response1 = await ds.client.get(
-        "/-/allowed.json?action=view-table&page_size=10&page=1"
+        "/-/allowed.json?action=view-table&_size=10&_page=1"
     )
     response2 = await ds.client.get(
-        "/-/allowed.json?action=view-table&page_size=10&page=2"
+        "/-/allowed.json?action=view-table&_size=10&_page=2"
     )
     items1 = {(item["parent"], item["child"]) for item in response1.json()["items"]}
     items2 = {(item["parent"], item["child"]) for item in response2.json()["items"]}
@@ -323,7 +319,7 @@ async def test_rules_json_pagination():
 
     # Test basic pagination structure - just verify it returns paginated results
     response = await ds.client.get(
-        "/-/rules.json?action=view-table&page_size=2&page=1",
+        "/-/rules.json?action=view-table&_size=2&_page=1",
         actor={"id": "root"},
     )
     assert response.status_code == 200

From 6d253d10c8cf187d7c06812d4fbbd3337780d939 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 5 Jul 2026 09:09:20 -0700
Subject: [PATCH 348/386] Compatibility with sqlite-utils>=4.0rc2

Runs the tests in CI. Had to add a little bit of code to handle
the difference between [table] and "table" and REAL v.s FLOAT.
---
 .github/workflows/test.yml | 22 +++++++++++++++++++
 pyproject.toml             |  2 +-
 tests/test_api_write.py    | 45 ++++++++++++++++++++++++++++++++------
 3 files changed, 61 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 9e47db6f..ba5b1611 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -51,3 +51,25 @@ jobs:
       run: |
         pip install datasette-init datasette-json-html
         tests/test-datasette-load-plugins.sh
+  test-sqlite-utils-4:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v6
+    - name: Set up Python
+      uses: actions/setup-python@v6
+      with:
+        python-version: "3.13"
+        cache: pip
+        cache-dependency-path: pyproject.toml
+    - name: Build extension for --load-extension test
+      run: |-
+        (cd tests && gcc ext.c -fPIC -shared -o ext.so)
+    - name: Install dependencies
+      run: |
+        pip install . --group dev
+        pip install --pre 'sqlite-utils>=4.0rc2'
+        pip freeze
+    - name: Run tests
+      run: |
+        pytest -n auto -m "not serial"
+        pytest -m "serial"
diff --git a/pyproject.toml b/pyproject.toml
index 215b2cca..38776b2c 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -35,7 +35,7 @@ dependencies = [
     "PyYAML>=5.3",
     "mergedeep>=1.1.1",
     "itsdangerous>=1.1",
-    "sqlite-utils>=3.30,<4.0",
+    "sqlite-utils>=3.30",
     "asyncinject>=0.7",
     "setuptools",
     "pip",
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 1154176f..af1aeb89 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -3,9 +3,31 @@ from datasette.events import RenameTableEvent
 from datasette.utils import escape_sqlite, sqlite3
 from .utils import last_event
 import pytest
+import re
 import time
 
 
+def schema_variants(schema):
+    # sqlite-utils < 4 quotes identifiers [like_this] and uses FLOAT;
+    # sqlite-utils >= 4 quotes them "like_this" and uses REAL. Given a
+    # schema fragment in the old format, return both variants so tests
+    # can pass against either version.
+    converted = re.sub(r"\[([^\]]+)\]", r'"\1"', schema).replace("FLOAT", "REAL")
+    return (schema, converted)
+
+
+def assert_schema_contains(fragment, schema):
+    assert any(
+        variant in schema for variant in schema_variants(fragment)
+    ), "Expected schema to contain {!r}, got {!r}".format(fragment, schema)
+
+
+def assert_schema_not_contains(fragment, schema):
+    assert not any(
+        variant in schema for variant in schema_variants(fragment)
+    ), "Expected schema not to contain {!r}, got {!r}".format(fragment, schema)
+
+
 @pytest.fixture
 def ds_write(tmp_path_factory):
     db_directory = tmp_path_factory.mktemp("dbs")
@@ -72,8 +94,8 @@ async def test_base64_write_api_create_table_infers_blob_and_raw_escapes(ds_writ
         headers=_headers(token),
     )
     assert response.status_code == 201
-    assert "[data] BLOB" in response.json()["schema"]
-    assert "[literal] TEXT" in response.json()["schema"]
+    assert_schema_contains("[data] BLOB", response.json()["schema"])
+    assert_schema_contains("[literal] TEXT", response.json()["schema"])
 
     rows = (await ds_write.get_database("data").execute("""
             select
@@ -1197,7 +1219,9 @@ async def test_alter_table_foreign_key_operations(ds_write):
     assert response.status_code == 200, response.text
     data = response.json()
     assert data["operations_applied"] == 2
-    assert "[owner_id] INTEGER REFERENCES [owners]([id])" in data["schema"]
+    assert_schema_contains(
+        "[owner_id] INTEGER REFERENCES [owners]([id])", data["schema"]
+    )
 
     response = await ds_write.client.post(
         "/data/docs/-/alter",
@@ -1208,7 +1232,7 @@ async def test_alter_table_foreign_key_operations(ds_write):
     )
     assert response.status_code == 200, response.text
     data = response.json()
-    assert "[owner_id] INTEGER REFERENCES" not in data["schema"]
+    assert_schema_not_contains("[owner_id] INTEGER REFERENCES", data["schema"])
 
     response = await ds_write.client.post(
         "/data/docs/-/alter",
@@ -1232,7 +1256,9 @@ async def test_alter_table_foreign_key_operations(ds_write):
     )
     assert response.status_code == 200, response.text
     data = response.json()
-    assert "[owner_id] INTEGER REFERENCES [categories]([id])" in data["schema"]
+    assert_schema_contains(
+        "[owner_id] INTEGER REFERENCES [categories]([id])", data["schema"]
+    )
 
     response = await ds_write.client.post(
         "/data/docs/-/alter",
@@ -1241,7 +1267,7 @@ async def test_alter_table_foreign_key_operations(ds_write):
     )
     assert response.status_code == 200, response.text
     data = response.json()
-    assert "[owner_id] INTEGER REFERENCES" not in data["schema"]
+    assert_schema_not_contains("[owner_id] INTEGER REFERENCES", data["schema"])
 
 
 @pytest.mark.asyncio
@@ -2177,6 +2203,9 @@ async def test_create_table(
     )
     assert response.status_code == expected_status
     data = response.json()
+    if isinstance(expected_response, dict) and "schema" in expected_response:
+        assert data.get("schema") in schema_variants(expected_response["schema"])
+        expected_response = dict(expected_response, schema=data.get("schema"))
     assert data == expected_response
     # Should have tracked the expected events
     events = ds_write._tracked_events
@@ -2219,7 +2248,9 @@ async def test_create_table_with_foreign_key(ds_write):
     )
     assert response.status_code == 201
     data = response.json()
-    assert "[owner_id] INTEGER REFERENCES [owners]([id])" in data["schema"]
+    assert_schema_contains(
+        "[owner_id] INTEGER REFERENCES [owners]([id])", data["schema"]
+    )
 
 
 @pytest.mark.asyncio

From 557e08c6ef02ba1ddee264400868d0295e11c734 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 5 Jul 2026 22:46:00 -0700
Subject: [PATCH 349/386] Make binary playwright test more robust

Failed here: https://github.com/simonw/datasette/actions/runs/28746832371/job/85239037361
---
 tests/test_playwright.py | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/tests/test_playwright.py b/tests/test_playwright.py
index 15c642fe..eb1edb57 100644
--- a/tests/test_playwright.py
+++ b/tests/test_playwright.py
@@ -356,6 +356,14 @@ def binary_file_blob(datasette_server, pk):
     return response.content
 
 
+def wait_for_binary_control_file(binary_control, size, name=None):
+    binary_control.locator(
+        ".row-edit-binary-size", has_text=f"Binary: {size} bytes"
+    ).wait_for()
+    if name:
+        binary_control.locator(".row-edit-binary-name", has_text=name).wait_for()
+
+
 def bulk_default_rows(datasette_server, **filters):
     params = {
         "_shape": "objects",
@@ -1516,11 +1524,7 @@ def test_edit_row_binary_control_replaces_blob_from_file(page, datasette_server)
             "buffer": replacement,
         }
     )
-    assert (
-        binary_control.locator(".row-edit-binary-size").inner_text()
-        == f"Binary: {len(replacement)} bytes"
-    )
-    assert "replacement.bin" in binary_control.inner_text()
+    wait_for_binary_control_file(binary_control, len(replacement), "replacement.bin")
 
     dialog.locator(".row-edit-save").click()
     page.locator(".row-mutation-status", has_text="Updated row 1").wait_for()
@@ -1547,10 +1551,7 @@ def test_edit_row_binary_control_handles_null_blob(page, datasette_server):
             "buffer": replacement,
         }
     )
-    assert (
-        binary_control.locator(".row-edit-binary-size").inner_text()
-        == f"Binary: {len(replacement)} bytes"
-    )
+    wait_for_binary_control_file(binary_control, len(replacement), "from-null.bin")
 
     dialog.locator(".row-edit-save").click()
     page.locator(".row-mutation-status", has_text="Updated row 3").wait_for()
@@ -1583,11 +1584,7 @@ def test_insert_row_binary_control_accepts_pasted_file(page, datasette_server):
         }""",
         list(pasted),
     )
-    assert (
-        binary_control.locator(".row-edit-binary-size").inner_text()
-        == f"Binary: {len(pasted)} bytes"
-    )
-    assert "pasted.bin" in binary_control.inner_text()
+    wait_for_binary_control_file(binary_control, len(pasted), "pasted.bin")
 
     dialog.locator(".row-edit-save").click()
     page.locator(".row-mutation-status", has_text="Inserted row 4").wait_for()

From c833217401898d0b2076f468f557da525c7e2daa Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 5 Jul 2026 22:47:05 -0700
Subject: [PATCH 350/386] Test with sqlite-utils>=4.0rc3

Refs https://github.com/simonw/sqlite-utils/issues/769#issuecomment-4889420844
---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ba5b1611..acc2d6b6 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -67,7 +67,7 @@ jobs:
     - name: Install dependencies
       run: |
         pip install . --group dev
-        pip install --pre 'sqlite-utils>=4.0rc2'
+        pip install --pre 'sqlite-utils>=4.0rc3'
         pip freeze
     - name: Run tests
       run: |

From 9a0b78b76cb45ab0f065f7f65ca528eec3ebf57f Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 5 Jul 2026 22:53:12 -0700
Subject: [PATCH 351/386] Vendor setup-sqlite-version

Same solution as https://github.com/simonw/sqlite-utils/pull/775
---
 .../actions/setup-sqlite-version/action.yml   |  39 +++++
 .../setup-sqlite-version.sh                   | 144 ++++++++++++++++++
 .github/workflows/test-sqlite-support.yml     |   2 +-
 3 files changed, 184 insertions(+), 1 deletion(-)
 create mode 100644 .github/actions/setup-sqlite-version/action.yml
 create mode 100644 .github/actions/setup-sqlite-version/setup-sqlite-version.sh

diff --git a/.github/actions/setup-sqlite-version/action.yml b/.github/actions/setup-sqlite-version/action.yml
new file mode 100644
index 00000000..fdbc71c9
--- /dev/null
+++ b/.github/actions/setup-sqlite-version/action.yml
@@ -0,0 +1,39 @@
+name: "Setup SQLite version"
+description: "Build and activate a specific SQLite version from its amalgamation archive"
+inputs:
+  version:
+    description: "The SQLite version to install"
+    required: true
+  cflags:
+    description: "CFLAGS to use when compiling SQLite"
+    required: false
+    default: ""
+  skip-activate:
+    description: "Set to true to skip modifying the library path"
+    required: false
+    default: "false"
+  fallback-urls:
+    description: "Whitespace-separated fallback download URLs to try after sqlite.org"
+    required: false
+    default: ""
+outputs:
+  sqlite-location:
+    description: "Directory containing the compiled SQLite library"
+    value: ${{ steps.build.outputs.sqlite-location }}
+runs:
+  using: "composite"
+  steps:
+    - shell: bash
+      run: mkdir -p "$RUNNER_TEMP/sqlite-versions/downloads"
+    - uses: actions/cache@v6
+      with:
+        path: ${{ runner.temp }}/sqlite-versions/downloads
+        key: setup-sqlite-version-${{ inputs.version }}-amalgamation-v1
+    - id: build
+      shell: bash
+      run: bash "$GITHUB_ACTION_PATH/setup-sqlite-version.sh"
+      env:
+        SQLITE_VERSION: ${{ inputs.version }}
+        SQLITE_CFLAGS: ${{ inputs.cflags }}
+        SQLITE_SKIP_ACTIVATE: ${{ inputs.skip-activate }}
+        SQLITE_EXTRA_FALLBACK_URLS: ${{ inputs.fallback-urls }}
diff --git a/.github/actions/setup-sqlite-version/setup-sqlite-version.sh b/.github/actions/setup-sqlite-version/setup-sqlite-version.sh
new file mode 100644
index 00000000..03d6a68f
--- /dev/null
+++ b/.github/actions/setup-sqlite-version/setup-sqlite-version.sh
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+version_spec="${SQLITE_VERSION:?SQLITE_VERSION is required}"
+cflags="${SQLITE_CFLAGS:-}"
+skip_activate="${SQLITE_SKIP_ACTIVATE:-false}"
+extra_fallback_urls="${SQLITE_EXTRA_FALLBACK_URLS:-}"
+
+case "$version_spec" in
+  3.46 | 3.46.0)
+    sqlite_version="3.46.0"
+    sqlite_year="2024"
+    amalgamation_id="3460000"
+    builtin_fallback_urls="https://static.simonwillison.net/static/2026/sqlite-amalgamation-3460000.zip"
+    ;;
+  3.25 | 3.25.0)
+    sqlite_version="3.25.0"
+    sqlite_year="2018"
+    amalgamation_id="3250000"
+    builtin_fallback_urls="https://static.simonwillison.net/static/2026/sqlite-amalgamation-3250000.zip?v=1"
+    ;;
+  *)
+    echo "::error::Unsupported SQLite version '$version_spec'. Add its release year and amalgamation id to $GITHUB_ACTION_PATH/setup-sqlite-version.sh."
+    exit 1
+    ;;
+esac
+
+case "$(uname -s)" in
+  Linux)
+    library_name="libsqlite3.so.0"
+    library_path_var="LD_LIBRARY_PATH"
+    ;;
+  Darwin)
+    library_name="libsqlite3.dylib"
+    library_path_var="DYLD_LIBRARY_PATH"
+    ;;
+  *)
+    echo "::error::Unsupported platform $(uname -s)"
+    exit 1
+    ;;
+esac
+
+runner_temp="${RUNNER_TEMP:-}"
+if [ -z "$runner_temp" ]; then
+  runner_temp="$(mktemp -d)"
+fi
+
+filename="sqlite-amalgamation-${amalgamation_id}"
+official_url="https://www.sqlite.org/${sqlite_year}/${filename}.zip"
+download_dir="${runner_temp}/sqlite-versions/downloads"
+source_root="${runner_temp}/sqlite-versions/source"
+source_dir="${source_root}/${filename}"
+build_dir="${runner_temp}/sqlite-versions/build/${sqlite_version}"
+archive_path="${download_dir}/${filename}.zip"
+
+mkdir -p "$download_dir" "$source_root" "$build_dir"
+
+download_archive() {
+  local url
+  local candidate_path="${archive_path}.tmp"
+  local urls=("$official_url")
+
+  for url in $builtin_fallback_urls $extra_fallback_urls; do
+    urls+=("$url")
+  done
+
+  rm -f "$candidate_path"
+  for url in "${urls[@]}"; do
+    echo "Downloading SQLite ${sqlite_version} amalgamation from ${url}"
+    if curl \
+      --fail \
+      --location \
+      --show-error \
+      --retry 5 \
+      --retry-delay 2 \
+      --retry-max-time 180 \
+      --retry-all-errors \
+      --connect-timeout 20 \
+      --max-time 240 \
+      --output "$candidate_path" \
+      "$url"; then
+      mv "$candidate_path" "$archive_path"
+      return 0
+    fi
+
+    echo "::warning::Download failed from ${url}"
+    rm -f "$candidate_path"
+  done
+
+  echo "::error::Could not download SQLite ${sqlite_version} amalgamation"
+  return 1
+}
+
+if [ ! -f "${source_dir}/sqlite3.c" ]; then
+  if [ ! -f "$archive_path" ]; then
+    download_archive
+  fi
+
+  rm -rf "$source_dir"
+  unzip -q "$archive_path" -d "$source_root"
+fi
+
+if [ ! -f "${source_dir}/sqlite3.c" ]; then
+  echo "::error::Expected ${source_dir}/sqlite3.c after extracting ${archive_path}"
+  exit 1
+fi
+
+read -r -a cflag_args <<< "$cflags"
+
+echo "Compiling SQLite ${sqlite_version} to ${build_dir}/${library_name}"
+gcc \
+  -fPIC \
+  -shared \
+  "${cflag_args[@]}" \
+  "${source_dir}/sqlite3.c" \
+  "-I${source_dir}" \
+  -o "${build_dir}/${library_name}"
+
+if [ "$library_name" = "libsqlite3.so.0" ]; then
+  ln -sf "$library_name" "${build_dir}/libsqlite3.so"
+fi
+
+if [ -n "${GITHUB_OUTPUT:-}" ]; then
+  echo "sqlite-location=${build_dir}" >> "$GITHUB_OUTPUT"
+else
+  echo "sqlite-location=${build_dir}"
+fi
+
+case "$(printf '%s' "$skip_activate" | tr '[:upper:]' '[:lower:]')" in
+  true | 1 | yes)
+    echo "Skipping ${library_path_var} activation"
+    ;;
+  *)
+    existing_value="${!library_path_var:-}"
+    if [ -n "${GITHUB_ENV:-}" ]; then
+      if [ -n "$existing_value" ]; then
+        echo "${library_path_var}=${build_dir}:${existing_value}" >> "$GITHUB_ENV"
+      else
+        echo "${library_path_var}=${build_dir}" >> "$GITHUB_ENV"
+      fi
+    fi
+    echo "Added ${build_dir} to ${library_path_var}"
+    ;;
+esac
diff --git a/.github/workflows/test-sqlite-support.yml b/.github/workflows/test-sqlite-support.yml
index 23fce459..d86000bf 100644
--- a/.github/workflows/test-sqlite-support.yml
+++ b/.github/workflows/test-sqlite-support.yml
@@ -34,7 +34,7 @@ jobs:
         cache: pip
         cache-dependency-path: pyproject.toml
     - name: Set up SQLite ${{ matrix.sqlite-version }}
-      uses: asg017/sqlite-versions@71ea0de37ae739c33e447af91ba71dda8fcf22e6
+      uses: ./.github/actions/setup-sqlite-version
       with:
         version: ${{ matrix.sqlite-version }}
         cflags: "-DSQLITE_ENABLE_DESERIALIZE -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_JSON1"

From b6f5fd5cd0fff5432cd74774d5385cb657180959 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 5 Jul 2026 23:04:51 -0700
Subject: [PATCH 352/386] test_internal_foreign_key_references() fix for
 sqlite-utils 4.0rc3

Refs https://github.com/simonw/sqlite-utils/issues/769#issuecomment-4889529980
---
 tests/test_internal_db.py | 75 +++++++++++++++++++++++++++++++++------
 1 file changed, 64 insertions(+), 11 deletions(-)

diff --git a/tests/test_internal_db.py b/tests/test_internal_db.py
index 26d63a92..340c4813 100644
--- a/tests/test_internal_db.py
+++ b/tests/test_internal_db.py
@@ -1,5 +1,6 @@
 import pytest
-import sqlite_utils
+
+from datasette.utils import escape_sqlite
 
 
 # ensure refresh_schemas() gets called before interacting with internal_db
@@ -76,19 +77,71 @@ async def test_internal_foreign_key_references(ds_client):
     internal_db = await ensure_internal(ds_client)
 
     def inner(conn):
-        db = sqlite_utils.Database(conn)
-        table_names = db.table_names()
-        for table in db.tables:
-            for fk in table.foreign_keys:
-                other_table = fk.other_table
-                other_column = fk.other_column
-                message = 'Column "{}.{}" references other column "{}.{}" which does not exist'.format(
-                    table.name, fk.column, other_table, other_column
+        table_names = [
+            row[0]
+            for row in conn.execute(
+                "select name from sqlite_master where type = 'table'"
+            ).fetchall()
+        ]
+
+        def columns_for_table(table_name):
+            return {
+                row[1]
+                for row in conn.execute(
+                    "PRAGMA table_info({})".format(escape_sqlite(table_name))
+                ).fetchall()
+            }
+
+        def primary_keys_for_table(table_name):
+            return [
+                name
+                for _, name in sorted(
+                    (row[5], row[1])
+                    for row in conn.execute(
+                        "PRAGMA table_info({})".format(escape_sqlite(table_name))
+                    ).fetchall()
+                    if row[5]
+                )
+            ]
+
+        columns_by_table = {
+            table_name: columns_for_table(table_name) for table_name in table_names
+        }
+
+        for table_name in table_names:
+            foreign_key_rows = conn.execute(
+                "PRAGMA foreign_key_list({})".format(escape_sqlite(table_name))
+            ).fetchall()
+            foreign_keys_by_id = {}
+            for foreign_key in foreign_key_rows:
+                foreign_keys_by_id.setdefault(foreign_key[0], []).append(foreign_key)
+
+            for foreign_key_rows in foreign_keys_by_id.values():
+                foreign_key_rows.sort(key=lambda row: row[1])
+                other_table = foreign_key_rows[0][2]
+                other_columns = [row[4] for row in foreign_key_rows]
+                message = 'Column "{}.{}" references other table "{}" which does not exist'.format(
+                    table_name, foreign_key_rows[0][3], other_table
                 )
                 assert other_table in table_names, message + " (bad table)"
-                assert other_column in db[other_table].columns_dict, (
-                    message + " (bad column)"
+                if all(other_column is None for other_column in other_columns):
+                    other_columns = primary_keys_for_table(other_table)
+                length_message = 'Foreign key from "{}" to "{}" has {} columns but references {} columns'.format(
+                    table_name,
+                    other_table,
+                    len(foreign_key_rows),
+                    len(other_columns),
                 )
+                assert len(other_columns) == len(foreign_key_rows), length_message
+
+                for foreign_key, other_column in zip(foreign_key_rows, other_columns):
+                    column = foreign_key[3]
+                    message = 'Column "{}.{}" references other column "{}.{}" which does not exist'.format(
+                        table_name, column, other_table, other_column
+                    )
+                    assert other_column in columns_by_table[other_table], (
+                        message + " (bad column)"
+                    )
 
     await internal_db.execute_fn(inner)
 

From f4dfd6e0f73a441ad0aa28b31bcdcf1c73942b29 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 22:19:35 +0000
Subject: [PATCH 353/386] Fix unused variable flagged by ruff

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 tests/test_error_shape.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 2398940b..b5f16b30 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -422,7 +422,7 @@ async def test_bad_signature_token_returns_401(ds_error_shape):
     response = await ds_error_shape.client.get(
         "/-/actor.json", headers={"Authorization": "Bearer dstok_garbage"}
     )
-    data = assert_canonical_error(response, 401)
+    assert_canonical_error(response, 401)
     assert response.headers["www-authenticate"].startswith("Bearer")
 
 

From 5c418efd7f18f9b469ccf14c1c8f86fd69d4427b Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 22:42:12 +0000
Subject: [PATCH 354/386] Update tests from main for canonical error shape and
 rows key

Two tests merged from main were written against the pre-merge response
shapes: the max_post_body_bytes 413 error now uses the canonical error
envelope, and row update with return:true responds with a rows list
rather than a singular row.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 tests/test_api_write.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 7145a859..14dedb73 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -169,7 +169,10 @@ async def test_base64_write_api_insert_upsert_update_decode_blobs(ds_write):
         headers=_headers(token),
     )
     assert update_response.status_code == 200
-    assert update_response.json()["row"]["data"] == {"$base64": True, "encoded": "/wAB"}
+    assert update_response.json()["rows"][0]["data"] == {
+        "$base64": True,
+        "encoded": "/wAB",
+    }
 
     rows = (await db.execute("""
             select
@@ -344,10 +347,9 @@ async def test_insert_rows_post_body_too_large(tmp_path_factory):
         headers=_headers(token),
     )
     assert response.status_code == 413
-    assert response.json() == {
-        "ok": False,
-        "errors": ["Request body exceeded maximum size of 100 bytes"],
-    }
+    assert response.json() == error_body(
+        ["Request body exceeded maximum size of 100 bytes"], 413
+    )
     # A small body should still work
     response2 = await ds.client.post(
         "/data/docs/-/insert",

From e892c686c20ab21dd9b3d3307a8b2af36149a685 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:02:42 +0000
Subject: [PATCH 355/386] Remove has_more from query list JSON - next: null
 signals the end

next: null (with next_url: null) is the single end-of-results signal
across the API, keeping default response keys to a minimum. The
StoredQueryPage.has_more attribute on the documented Python API is
unchanged.

Also fixes a bug this uncovered: the query list JSON next_url pointed
at the HTML page (it was built from the query list path, dropping the
.json extension) and was a relative path where the table view next_url
is absolute. It is now built from the request path and absolute, so it
preserves the requested format and can be followed directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/stored_queries.py       |  1 -
 datasette/views/stored_queries.py |  7 +++----
 existing-api.md                   |  2 +-
 stable-api-recommendations.md     |  8 +++++++-
 tests/test_queries.py             | 26 +++++++++++++++++++++++++-
 5 files changed, 36 insertions(+), 8 deletions(-)

diff --git a/datasette/stored_queries.py b/datasette/stored_queries.py
index d7e1ec99..f5f977d9 100644
--- a/datasette/stored_queries.py
+++ b/datasette/stored_queries.py
@@ -83,7 +83,6 @@ def stored_query_page_to_dict(page: StoredQueryPage) -> dict[str, Any]:
     return {
         "queries": [stored_query_to_dict(query) for query in page.queries],
         "next": page.next,
-        "has_more": page.has_more,
         "limit": page.limit,
     }
 
diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
index bb23a6bd..3273d13c 100644
--- a/datasette/views/stored_queries.py
+++ b/datasette/views/stored_queries.py
@@ -120,9 +120,9 @@ class QueryListView(BaseView):
                 if key != "_next"
             ]
             pairs.append(("_next", page.next))
-            next_url = "{}?{}".format(
-                query_list_path,
-                urlencode(pairs),
+            next_url = self.ds.absolute_url(
+                request,
+                "{}?{}".format(request.path, urlencode(pairs)),
             )
 
         current_filters = {
@@ -208,7 +208,6 @@ class QueryListView(BaseView):
             "queries": page.queries,
             "next": page.next,
             "next_url": next_url,
-            "has_more": page.has_more,
             "limit": page.limit,
             "show_private_note": any(query.is_private for query in page.queries),
             "show_trusted_note": any(query.is_trusted for query in page.queries),
diff --git a/existing-api.md b/existing-api.md
index c0c8e442..55e9d6a2 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -1038,7 +1038,7 @@ databases (`database`/`database_color` are null, `show_database` true).
   400 `"is_write must be 0 or 1"`), `source`, `owner_id`.
 - **Response** — 200:
   `{"ok": true, "database", "database_color", "queries": [...], "next",
-  "next_url", "has_more", "limit", "show_private_note",
+  "next_url", "limit", "show_private_note",
   "show_trusted_note", "query_list_path", "show_database",
   "facets": [{title, items: [{label, count, href, active}]}],
   "filters": {q, is_write, is_private, source, owner_id}}`.
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index ba837204..229dccd4 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -209,7 +209,13 @@ number.
 > values (previously silently clamped), and the `/-/allowed` and
 > `/-/rules` debug endpoints renamed `page`/`page_size` to
 > `_page`/`_size` with the same validation (400 instead of silent
-> capping at 200). The `has_more`/`total` differences remain open.
+> capping at 200). `has_more` has been **removed** from the query-list
+> JSON — `next: null` is the single end-of-results signal everywhere,
+> keeping default response keys minimal (`total` remains a debug-endpoint
+> nicety). Fixing this also uncovered and fixed a bug where the query
+> list's JSON `next_url` pointed at the HTML page (it dropped the `.json`
+> extension) and was relative where the table `next_url` is absolute.
+> §3 is now fully resolved.
 
 | Endpoint | Mechanism | Token | Extras |
 |---|---|---|---|
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 699743c5..c25ec358 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -879,7 +879,7 @@ async def test_query_list_html_defaults_to_twenty_and_shows_pagination():
     assert response.text.count('aria-label="Query pagination"') == 1
     assert "Demo query 20" in response.text
     assert "Demo query 21" not in response.text
-    assert 'href="/data/-/queries?_next=' in response.text
+    assert 'href="http://localhost/data/-/queries?_next=' in response.text
     assert len(json_response.json()["queries"]) == 25
 
 
@@ -3827,3 +3827,27 @@ async def test_stored_query_json_uses_parameters_not_params():
     query = [q for q in listing["queries"] if q["name"] == "with_params"][0]
     assert query["parameters"] == ["name", "age"]
     assert "params" not in query
+
+
+@pytest.mark.asyncio
+async def test_query_list_json_signals_pagination_via_next_only():
+    ds = Datasette(memory=True)
+    ds.add_memory_database("query_list_next_only", name="data")
+    await ds.invoke_startup()
+    for i in range(3):
+        await ds.add_query(
+            "data",
+            name="q{}".format(i),
+            sql="select {}".format(i),
+        )
+    first = (await ds.client.get("/data/-/queries.json?_size=2")).json()
+    assert "has_more" not in first
+    assert first["next"] is not None
+    assert first["next_url"] is not None
+    # The internal test client cannot follow absolute URLs
+    next_path = first["next_url"].replace("http://localhost", "")
+    assert next_path.startswith("/data/-/queries.json?")
+    last = (await ds.client.get(next_path)).json()
+    assert "has_more" not in last
+    assert last["next"] is None
+    assert last["next_url"] is None

From 6e17c513619a139c1157d2c207324a8eddbec8d2 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:08:05 +0000
Subject: [PATCH 356/386] Document why upsert returns 200 where insert returns
 201

An upsert may update existing rows without creating anything, so it
deliberately does not claim resource creation with a 201.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 docs/json_api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/json_api.rst b/docs/json_api.rst
index 32d28733..2105d6e0 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -1944,7 +1944,7 @@ The above example will:
 
 Similar to ``/-/insert``, a ``row`` key with an object can be used instead of a ``rows`` array to upsert a single row.
 
-If successful, this will return a ``200`` status code and a ``{"ok": true}`` response body.
+If successful, this will return a ``200`` status code and a ``{"ok": true}`` response body. This is deliberately different from the ``201`` returned by :ref:`insert <TableInsertView>`: an upsert may update existing rows without creating anything, so it does not claim resource creation.
 
 Add ``"return": true`` to the request body to return full copies of the affected rows after they have been inserted or updated:
 

From 3322e1f528f4d607eb0693a4cee2df97400eb215 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:08:28 +0000
Subject: [PATCH 357/386] Document the boolean query string argument grammar

Boolean arguments parsed by value_as_boolean() accept on/true/1 and
off/false/0 - state this once in the JSON API docs rather than leaving
each argument to imply its own grammar.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 docs/json_api.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/json_api.rst b/docs/json_api.rst
index 2105d6e0..c31ba756 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -276,6 +276,10 @@ Here is an example Python function built using `requests <https://requests.readt
 Special JSON arguments
 ----------------------
 
+Boolean query string arguments - such as ``?_labels=`` and
+``?_json_infinity=`` - accept ``on``, ``true`` or ``1`` for true and
+``off``, ``false`` or ``0`` for false.
+
 Every Datasette endpoint that can return JSON also accepts the following
 query string arguments:
 

From 8154f7149fb4e97eb3d6afa8ae94b41bb6aadb53 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:09:10 +0000
Subject: [PATCH 358/386] Advise plugin authors on naming secret configuration
 keys

/-/config redacts values for keys whose names contain secret, key,
password, token, hash or dsn. Plugins that follow that naming get
automatic redaction; plugins that don't will leak their secrets on
that endpoint.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 docs/plugins.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/plugins.rst b/docs/plugins.rst
index d2b5c20a..d32a9fe6 100644
--- a/docs/plugins.rst
+++ b/docs/plugins.rst
@@ -459,6 +459,8 @@ Secret configuration values
 
 Some plugins may need configuration that should stay secret - API keys for example. There are two ways in which you can store secret configuration values.
 
+The :ref:`/-/config <JsonDataView_config>` introspection endpoint redacts the values of any configuration keys whose names contain one of these substrings: ``secret``, ``key``, ``password``, ``token``, ``hash`` or ``dsn``. Name your plugin's secret configuration keys accordingly - for example ``api_key`` or ``client_secret`` - so they are automatically redacted there.
+
 **As environment variables**. If your secret lives in an environment variable that is available to the Datasette process, you can indicate that the configuration value should be read from that environment variable like so:
 
 .. [[[cog

From 022eb6d3a0a53961cff6b3221c2c54f64b4729a1 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:09:27 +0000
Subject: [PATCH 359/386] Mark documented items in recommendations

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 stable-api-recommendations.md | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 229dccd4..9e8fa356 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -243,10 +243,11 @@ Concerns:
 
 ## 4. HTTP semantics (P2)
 
-- **201 vs 200:** insert → 201, upsert → 200 (views/table.py:1194), create
+- ~~**201 vs 200:** insert → 201, upsert → 200 (views/table.py:1194), create
   table → 201, store query → 201. Insert-201/upsert-200 is defensible
   (upsert may not create) but it is undocumented subtlety; state it, or
-  return 200 for both with an explicit `created` count.
+  return 200 for both with an explicit `created` count.~~ ✅ **Done** —
+  documented as deliberate in the upsert docs.
 - **Destructive-action confirmation is asymmetric:** table drop requires
   `{"confirm": true}` and has a preview response (views/table.py:1346-1365);
   row delete executes immediately and ignores the body; query delete
@@ -284,10 +285,13 @@ Concerns:
   accepted input alias for API creation and `datasette.yaml` config.
 - **Three names for the same concept across error/message payloads:**
   `error`, `errors`, `message`. See §1.
-- **Boolean query parameters have at least three grammars:** `_nl=on`,
+- ~~**Boolean query parameters have at least three grammars:** `_nl=on`,
   `_labels=on/off`, `?all=1`, `is_write=1|0|true|false|t|f|yes|no|on|off`,
   `_nocount=1`. Adopt one accepted set (the query-list parser at
-  query_helpers.py:81-94 is a good candidate) and apply it everywhere.
+  query_helpers.py:81-94 is a good candidate) and apply it everywhere.~~
+  ✅ **Documented** — the JSON API docs state the canonical grammar
+  (`on/true/1`, `off/false/0`), which `value_as_boolean` already accepts
+  everywhere it is used.
 - ~~**`.jsono`** survives on the homepage route (identical output to `.json`)
   and as a row-view redirect. Remove it at 1.0; it is pure legacy.~~
   ✅ Removed: the homepage routes only accept `.json` and the row-view
@@ -322,9 +326,12 @@ Concerns:
   task reprs including file paths) behind only `view-instance`. Consider
   `permissions-debug`, alongside `/-/actions` which already requires it.~~
   ✅ **Done** — `/-/threads` now requires `permissions-debug`.
-- **(P3) `/-/config` redaction is substring-based** on six key names
+- ~~**(P3) `/-/config` redaction is substring-based** on six key names
   (app.py:2502-2505); plugins storing secrets under other names leak. Worth
-  a note in plugin authoring docs plus a `redact_keys` plugin hook.
+  a note in plugin authoring docs plus a `redact_keys` plugin hook.~~
+  ✅ **Documented** — the plugin secrets docs now advise naming keys to
+  match the redaction substrings (a `redact_keys` hook remains a possible
+  future addition).
 - **(P3) Database-level checks on `/-/create`** (insert-row/update-row
   checked against `DatabaseResource`, not the about-to-exist table —
   table_create_alter.py:819-856) vs table-level checks on `/-/insert`.

From 87cd695ca3b9293937228762a75f94e8a4931469 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:20:47 +0000
Subject: [PATCH 360/386] Write endpoints parse the body as JSON regardless of
 Content-Type

The insert, upsert, alter and set-column-type endpoints previously
required Content-Type: application/json while /-/create parsed the body
blind - and insert returned a 500 AttributeError when the header was
missing entirely. The lenient rule is now uniform: the body is always
parsed as JSON and invalid JSON is a 400. This makes curl -d and
requests data=json.dumps(...) invocations work without remembering the
header. Cross-site request forgery remains prevented by the Origin and
Sec-Fetch-Site checks in CrossOriginProtectionMiddleware, which is the
defense the strict content-type requirement was historically standing
in for.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/table.py              |  8 +---
 datasette/views/table_create_alter.py |  4 --
 docs/json_api.rst                     |  2 +
 existing-api.md                       |  6 +--
 stable-api-recommendations.md         |  8 +++-
 tests/test_api_write.py               | 13 +------
 tests/test_column_types.py            | 12 +-----
 tests/test_error_shape.py             | 55 +++++++++++++++++++++++++++
 8 files changed, 69 insertions(+), 39 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 0a9c88d4..80ad1aab 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -951,9 +951,7 @@ class TableInsertView(BaseView):
         def _errors(errors):
             return None, errors, {}
 
-        if not request.headers.get("content-type").startswith("application/json"):
-            # TODO: handle form-encoded data
-            return _errors(["Invalid content-type, must be application/json"])
+        # The body is parsed as JSON regardless of the Content-Type header
         try:
             data = await request.json()
         except json.JSONDecodeError as e:
@@ -1260,10 +1258,6 @@ class TableSetColumnTypeView(BaseView):
         ):
             return _error(["Permission denied"], 403)
 
-        content_type = request.headers.get("content-type") or ""
-        if not content_type.startswith("application/json"):
-            return _error(["Invalid content-type, must be application/json"], 400)
-
         try:
             data = await request.json()
         except json.JSONDecodeError as e:
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index d0384184..c3e06c29 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -1166,10 +1166,6 @@ class TableAlterView(BaseView):
         if not db.is_mutable:
             return _error(["Database is immutable"], 403)
 
-        content_type = request.headers.get("content-type") or ""
-        if not content_type.startswith("application/json"):
-            return _error(["Invalid content-type, must be application/json"], 400)
-
         try:
             data = await request.json()
         except json.JSONDecodeError as e:
diff --git a/docs/json_api.rst b/docs/json_api.rst
index c31ba756..893af634 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -1668,6 +1668,8 @@ The JSON write API
 
 Datasette provides a write API for JSON data. This is a POST-only API that requires an authenticated API token, see :ref:`CreateTokenView`. The token will need to have the specified :ref:`authentication_permissions`.
 
+The request body is always parsed as JSON, regardless of the request's ``Content-Type`` header - a body that is not valid JSON returns a ``400`` error. Cross-site request forgery is prevented by Datasette's ``Origin`` and ``Sec-Fetch-Site`` header checks rather than by content type requirements.
+
 The row-based write APIs can write :ref:`binary values in JSON <binary_json_format>` using Datasette's Base64 representation for BLOB data.
 
 .. _ExecuteWriteView:
diff --git a/existing-api.md b/existing-api.md
index 55e9d6a2..c58f8f41 100644
--- a/existing-api.md
+++ b/existing-api.md
@@ -853,8 +853,8 @@ shape) and check permissions with
   additionally required for `alter: true` (403
   `Permission denied for alter-table`). Immutable database → 403
   `Database is immutable`.
-- **Request** — requires `Content-Type: application/json` (else 400
-  `"Invalid content-type, must be application/json"`). Body:
+- **Request** — the body is parsed as JSON regardless of the request
+  `Content-Type` header (invalid JSON → 400). Body:
 
   | Field | Rules |
   |---|---|
@@ -937,7 +937,7 @@ shape) and check permissions with
 does not change the SQLite schema.
 
 - **Permission:** `set-column-type` (403 `Permission denied`).
-- **Request** (JSON content type required): `{"column": "name",
+- **Request**: `{"column": "name",
   "column_type": {"type": "url", "config": {...}?} | null}`. Unknown
   keys/invalid structure → detailed 400 errors; unknown type → 400
   `"Unknown column type: x"`. Default registered types (via the
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 9e8fa356..30dd0429 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -254,11 +254,15 @@ Concerns:
   executes immediately. Decide the 1.0 rule (suggestion: confirmation only
   for schema-destroying operations, i.e. keep as is — but document it as a
   deliberate contract).
-- **Content-type enforcement is inconsistent:** `/-/insert`, `/-/upsert`,
+- ~~**Content-type enforcement is inconsistent:** `/-/insert`, `/-/upsert`,
   `/-/alter`, `/-/set-column-type` demand `Content-Type: application/json`
   (400 otherwise); `/-/create` parses the body as JSON regardless of
   content type; execute-write and the query CRUD endpoints accept both JSON
-  and form encodings. Pick one rule for JSON-only endpoints.
+  and form encodings. Pick one rule for JSON-only endpoints.~~ ✅ **Done**
+  — the lenient rule won: JSON-only write endpoints parse the body as JSON
+  regardless of `Content-Type` (CSRF protection comes from the
+  cross-origin header checks, not content types). This also fixed a 500 on
+  insert when the header was absent entirely.
 - **JSON-vs-HTML negotiation on POST differs per endpoint:** execute-write
   and canned queries key off `Accept: application/json` / a `_json` body
   field; the write API keys off nothing (always JSON); query store keys off
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 14dedb73..840bd05b 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -394,13 +394,6 @@ async def test_insert_rows_post_body_too_large(tmp_path_factory):
                 "Invalid JSON: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)"
             ],
         ),
-        (
-            "/data/docs/-/insert",
-            {},
-            "invalid_content_type",
-            400,
-            ["Invalid content-type, must be application/json"],
-        ),
         (
             "/data/docs/-/insert",
             [],
@@ -582,11 +575,7 @@ async def test_insert_or_upsert_row_errors(
         json=input,
         headers={
             "Authorization": "Bearer {}".format(token),
-            "Content-Type": (
-                "text/plain"
-                if special_case == "invalid_content_type"
-                else "application/json"
-            ),
+            "Content-Type": "application/json",
         },
     )
 
diff --git a/tests/test_column_types.py b/tests/test_column_types.py
index 4e553771..cd308ec9 100644
--- a/tests/test_column_types.py
+++ b/tests/test_column_types.py
@@ -322,12 +322,6 @@ async def test_clear_column_type_api(ds_ct):
                 "Invalid JSON: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)"
             ],
         ),
-        (
-            {"column": "title", "column_type": {"type": "email"}},
-            "invalid_content_type",
-            400,
-            ["Invalid content-type, must be application/json"],
-        ),
         (
             [],
             None,
@@ -413,11 +407,7 @@ async def test_set_column_type_api_errors(
     kwargs = {
         "headers": {
             "Authorization": f"Bearer {token}",
-            "Content-Type": (
-                "text/plain"
-                if special_case == "invalid_content_type"
-                else "application/json"
-            ),
+            "Content-Type": "application/json",
         }
     }
     if special_case == "invalid_json":
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index b5f16b30..040e645a 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -662,3 +662,58 @@ async def test_debug_endpoints_use_size_and_page_parameters(ds_error_shape, endp
     bad_page = await ds_error_shape.client.get(base + "&_page=0", actor={"id": "root"})
     data = assert_canonical_error(bad_page, 400)
     assert data["errors"] == ["_page must be a positive integer"]
+
+
+# Write endpoints parse the body as JSON regardless of Content-Type
+
+
+@pytest.mark.asyncio
+async def test_insert_works_without_content_type_header(ds_error_shape):
+    # Previously a 500 AttributeError
+    response = await ds_error_shape.client.post(
+        "/data/docs/-/insert",
+        content='{"row": {"id": 1, "title": "One"}}',
+        actor={"id": "root"},
+    )
+    assert response.status_code == 201
+    assert response.json()["rows"][0]["title"] == "One"
+
+
+@pytest.mark.asyncio
+async def test_insert_works_with_form_content_type(ds_error_shape):
+    # Previously 400 "Invalid content-type, must be application/json"
+    response = await ds_error_shape.client.post(
+        "/data/docs/-/insert",
+        content='{"row": {"id": 2, "title": "Two"}}',
+        headers={"Content-Type": "application/x-www-form-urlencoded"},
+        actor={"id": "root"},
+    )
+    assert response.status_code == 201
+
+
+@pytest.mark.asyncio
+async def test_insert_form_encoded_body_is_invalid_json(ds_error_shape):
+    response = await ds_error_shape.client.post(
+        "/data/docs/-/insert",
+        content="title=Three",
+        headers={"Content-Type": "application/x-www-form-urlencoded"},
+        actor={"id": "root"},
+    )
+    data = assert_canonical_error(response, 400)
+    assert data["errors"][0].startswith("Invalid JSON:")
+
+
+@pytest.mark.asyncio
+async def test_alter_and_set_column_type_ignore_content_type(ds_error_shape):
+    alter = await ds_error_shape.client.post(
+        "/data/docs/-/alter",
+        content='{"operations": [{"op": "add_column", "args": {"name": "extra"}}]}',
+        actor={"id": "root"},
+    )
+    assert alter.status_code == 200, alter.text
+    sct = await ds_error_shape.client.post(
+        "/data/docs/-/set-column-type",
+        content='{"column": "title", "column_type": {"type": "textarea"}}',
+        actor={"id": "root"},
+    )
+    assert sct.status_code == 200, sct.text

From 60bac9439d5674f2a8e716568804c29ff43cd43a Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:21:42 +0000
Subject: [PATCH 361/386] Mark shape=object item done in recommendations

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 stable-api-recommendations.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 30dd0429..4da23934 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -390,7 +390,8 @@ Concerns:
    required"`. The JSON behavior masks caller bugs; return 400 on both.~~
    ✅ **Done** — all data formats now return 400; the HTML SQL editor page
    is unchanged.
-3. **`_shape=object` HTTP 200 error** (§1b) — almost certainly unintended.
+3. ~~**`_shape=object` HTTP 200 error** (§1b) — almost certainly unintended.~~
+   ✅ Done — now 400 (fixed with §1b).
 4. ~~**Row delete 500** (§1c) — inconsistent with every sibling endpoint.~~
    ✅ Done — now 400.
 5. **The "SQL Interrupted" error embeds an HTML fragment in the JSON `error`

From 0d962deb05a047b3cecd680983505dcf645a3fac Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:34:17 +0000
Subject: [PATCH 362/386] Plain text SQL Interrupted errors in JSON responses

The SQL time limit error embedded an HTML fragment (paragraph, textarea
and script tags) as the error string in JSON responses. DatasetteError
now accepts a plain_message which the exception handler prefers for
JSON error bodies; the HTML error page keeps the rich message with the
SQL textarea.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/handle_exception.py |  4 +++-
 datasette/views/base.py       |  3 +++
 datasette/views/database.py   |  4 ++++
 datasette/views/row.py        |  4 ++++
 stable-api-recommendations.md |  6 ++++--
 tests/test_api.py             | 12 +++---------
 tests/test_error_shape.py     | 22 ++++++++++++++++++++++
 7 files changed, 43 insertions(+), 12 deletions(-)

diff --git a/datasette/handle_exception.py b/datasette/handle_exception.py
index fc290dbc..e255ddf2 100644
--- a/datasette/handle_exception.py
+++ b/datasette/handle_exception.py
@@ -28,6 +28,7 @@ def handle_exception(datasette, request, exception):
             rich.get_console().print_exception(show_locals=True)
 
         title = None
+        plain_message = None
         if isinstance(exception, Base400):
             status = exception.status
             info = {}
@@ -36,6 +37,7 @@ def handle_exception(datasette, request, exception):
             status = exception.status
             info = exception.error_dict
             message = exception.message
+            plain_message = exception.plain_message
             if exception.message_is_html:
                 message = Markup(message)
             title = exception.title
@@ -50,7 +52,7 @@ def handle_exception(datasette, request, exception):
             add_cors_headers(headers)
         if request.path.split("?")[0].endswith(".json"):
             body = dict(info)
-            body.update(error_body(message, status))
+            body.update(error_body(plain_message or message, status))
             return Response.json(body, status=status, headers=headers)
         info.update(
             {
diff --git a/datasette/views/base.py b/datasette/views/base.py
index a12ae050..88d16753 100644
--- a/datasette/views/base.py
+++ b/datasette/views/base.py
@@ -29,12 +29,15 @@ class DatasetteError(Exception):
         status=500,
         template=None,
         message_is_html=False,
+        plain_message=None,
     ):
         self.message = message
         self.title = title
         self.error_dict = error_dict or {}
         self.status = status
         self.message_is_html = message_is_html
+        # Plain text used for JSON error responses when message is HTML
+        self.plain_message = plain_message
 
 
 class View:
diff --git a/datasette/views/database.py b/datasette/views/database.py
index c9dcfa89..10dc66ae 100644
--- a/datasette/views/database.py
+++ b/datasette/views/database.py
@@ -819,6 +819,10 @@ class QueryView(View):
                     title="SQL Interrupted",
                     status=400,
                     message_is_html=True,
+                    plain_message=(
+                        "SQL query took too long. The time limit is"
+                        " controlled by the sql_time_limit_ms setting."
+                    ),
                 )
             except sqlite3.DatabaseError as ex:
                 query_error = str(ex)
diff --git a/datasette/views/row.py b/datasette/views/row.py
index 2a103180..d9a3deeb 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -200,6 +200,10 @@ class RowView(BaseView):
                 title="SQL Interrupted",
                 status=400,
                 message_is_html=True,
+                plain_message=(
+                    "SQL query took too long. The time limit is"
+                    " controlled by the sql_time_limit_ms setting."
+                ),
             )
         except (sqlite3.OperationalError, InvalidSql) as e:
             raise DatasetteError(str(e), title="Invalid SQL", status=400)
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
index 4da23934..0d817612 100644
--- a/stable-api-recommendations.md
+++ b/stable-api-recommendations.md
@@ -394,9 +394,11 @@ Concerns:
    ✅ Done — now 400 (fixed with §1b).
 4. ~~**Row delete 500** (§1c) — inconsistent with every sibling endpoint.~~
    ✅ Done — now 400.
-5. **The "SQL Interrupted" error embeds an HTML fragment in the JSON `error`
+5. ~~**The "SQL Interrupted" error embeds an HTML fragment in the JSON `error`
    value** (views/database.py:805-820). Error strings in the JSON API should
-   be plain text.
+   be plain text.~~ ✅ **Done** — `DatasetteError` gained a `plain_message`
+   used for JSON responses; the HTML error page keeps the rich version with
+   the SQL textarea. §8 is now fully resolved.
 
 ---
 
diff --git a/tests/test_api.py b/tests/test_api.py
index da0ebc07..9a96f14f 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -329,14 +329,8 @@ def test_sql_time_limit(app_client_shorter_time_limit):
     )
     assert 400 == response.status
     expected_message = (
-        "<p>SQL query took too long. The time limit is controlled by the\n"
-        '<a href="https://docs.datasette.io/en/stable/settings.html#sql-time-limit-ms">sql_time_limit_ms</a>\n'
-        "configuration option.</p>\n"
-        '<textarea style="width: 90%">select sleep(0.5)</textarea>\n'
-        "<script>\n"
-        'let ta = document.querySelector("textarea");\n'
-        'ta.style.height = ta.scrollHeight + "px";\n'
-        "</script>"
+        "SQL query took too long. The time limit is"
+        " controlled by the sql_time_limit_ms setting."
     )
     assert response.json == {
         "ok": False,
@@ -356,7 +350,7 @@ async def test_custom_sql_time_limit(ds_client):
         "/fixtures/-/query.json?sql=select+sleep(0.01)&_timelimit=5",
     )
     assert response.status_code == 400
-    assert response.json()["error"].startswith("<p>SQL query took too long.")
+    assert response.json()["error"].startswith("SQL query took too long.")
 
 
 @pytest.mark.asyncio
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 040e645a..44856b36 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -717,3 +717,25 @@ async def test_alter_and_set_column_type_ignore_content_type(ds_error_shape):
         actor={"id": "root"},
     )
     assert sct.status_code == 200, sct.text
+
+
+# SQL Interrupted errors carry plain text in JSON, not an HTML fragment
+
+
+@pytest.mark.asyncio
+async def test_sql_interrupted_json_error_is_plain_text(ds_client):
+    response = await ds_client.get(
+        "/fixtures/-/query.json?sql=select+sleep(0.01)&_timelimit=5"
+    )
+    data = assert_canonical_error(response, 400)
+    assert "<" not in data["error"]
+    assert data["error"].startswith("SQL query took too long.")
+
+
+@pytest.mark.asyncio
+async def test_sql_interrupted_html_page_keeps_rich_error(ds_client):
+    response = await ds_client.get(
+        "/fixtures/-/query?sql=select+sleep(0.01)&_timelimit=5"
+    )
+    assert response.status_code == 400
+    assert "<textarea" in response.text

From 53ccca5e158d18777febf5e2968cd4642ed7184b Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:34:17 +0000
Subject: [PATCH 363/386] Remove working analysis documents

existing-api.md and stable-api-recommendations.md were working
documents for the 1.0 API consistency review. Their content remains
available in this branch history; they are not intended to merge to
main.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 existing-api.md               | 1244 ---------------------------------
 stable-api-recommendations.md |  469 -------------
 2 files changed, 1713 deletions(-)
 delete mode 100644 existing-api.md
 delete mode 100644 stable-api-recommendations.md

diff --git a/existing-api.md b/existing-api.md
deleted file mode 100644
index c58f8f41..00000000
--- a/existing-api.md
+++ /dev/null
@@ -1,1244 +0,0 @@
-# Datasette JSON API — As Implemented
-
-This document describes the JSON API of this Datasette codebase (version `1.0a35`) as
-derived directly from the source code. It intentionally ignores the existing `docs/`
-directory: every claim below is based on the route table in `datasette/app.py`
-(`Datasette._routes()`, app.py:2507-2767) and the view implementations in
-`datasette/views/`.
-
-## Contents
-
-- [Cross-cutting behavior](#cross-cutting-behavior)
-- [Instance endpoints](#instance-endpoints)
-- [Database endpoints](#database-endpoints)
-- [Table and row read endpoints](#table-and-row-read-endpoints)
-- [The write API](#the-write-api)
-- [Stored (canned) queries API](#stored-canned-queries-api)
-- [Authentication and tokens](#authentication-and-tokens)
-- [Appendix: registered actions (permissions)](#appendix-registered-actions-permissions)
-
----
-
-## Cross-cutting behavior
-
-### URL formats and content negotiation
-
-- Most read endpoints are registered with an optional format suffix:
-  `/(...)(\.(?P<format>json))?$`. The bare path returns HTML; the `.json`
-  extension returns JSON.
-- Table, row and query routes accept any `\w+` format extension; formats other
-  than the built-in `html`, `json`, `csv`, `blob` must be provided by a plugin
-  via `register_output_renderer`, otherwise the request 404s.
-- HTML responses include a `Link: <...>; rel="alternate";
-  type="application/json+datasette"` header pointing at the `.json` variant
-  (views/base.py:141-159), unless the view opts out with
-  `has_json_alternate = False`.
-- Database, table, row and query names in paths are **tilde-encoded**
-  (a percent-encoding variant using `~` as the escape character;
-  utils/__init__.py `_TILDE_ENCODING_SAFE`). Multi-column primary keys in row
-  URLs are comma-separated.
-- JSON responses are always compact `json.dumps` output serialized by
-  `CustomJSONEncoder`; there is no pretty-printing query parameter. Binary
-  values are serialized as `{"$base64": true, "encoded": "..."}`.
-- Success content type: `application/json; charset=utf-8`
-  (`_shape=array&_nl=on` responses use `text/plain`).
-
-### Success envelope and stability marker
-
-Every JSON endpoint that returns an object includes `"ok": true` on
-success. `JsonDataView` injects it automatically for dict responses
-(views/special.py); the homepage, jump, schema, permission-debug and
-autocomplete views add it explicitly. The former top-level-array endpoints
-(`/-/plugins`, `/-/databases`, `/-/actions`) now return objects wrapping
-their arrays (`{"ok": true, "plugins": [...]}` etc.).
-
-JSON endpoints that are **not part of the documented API** include a
-marker key (`UNSTABLE_API_MESSAGE` in utils/__init__.py):
-
-```json
-"unstable": "This API is not part of Datasette's stable interface and may change at any time"
-```
-
-Currently: the homepage (`/.json`, `/-/.json`), `/db/-/queries/analyze`,
-`POST /db/-/queries/store`, `/db/<query>/-/definition`,
-`/db/-/query/parameters`, `/db/-/execute-write/analyze` and the
-`POST /-/permissions` playground response.
-
-### Error shape (canonical)
-
-Every JSON error response uses one canonical shape, built by `error_body()`
-(utils/__init__.py):
-
-```json
-{
-  "ok": false,
-  "error": "all messages joined with '; '",
-  "errors": ["message", "..."],
-  "status": 404
-}
-```
-
-- `errors` is a list of one or more message strings (multi-message
-  validation errors, e.g. per-row insert errors, list them all).
-- `error` is the messages joined with `"; "`.
-- `status` always matches the HTTP status code.
-
-The shape is produced by four code paths, all delegating to `error_body()`:
-
-1. **Exception handler** (handle_exception.py) — `NotFound`,
-   `DatasetteError`, `BadRequest` etc. on `.json` paths. `DatasetteError`
-   `error_dict` context keys are merged in; the legacy `title` key is no
-   longer emitted in JSON (it survives in the HTML error template context).
-2. **The `_error()` helper** (views/base.py:183-184) — the write API,
-   stored-query API, execute-write and permission-denied paths.
-3. **JSON renderer errors** (renderer.py) — SQL errors on table/query
-   endpoints return HTTP 400 with the canonical keys **plus** the context
-   keys of the response it could not produce:
-
-   ```json
-   {"ok": false, "error": "no such table: x", "errors": ["no such table: x"],
-    "status": 400, "rows": [], "truncated": false}
-   ```
-
-   Invalid `_shape=` values and `_shape=object` misuse (on queries or
-   pk-less tables) also return canonical 400 errors.
-4. **Permission debug endpoints** (`/-/allowed`, `/-/rules`, `/-/check`,
-   POST `/-/permissions`) — canonical shape (previously bare
-   `{"error": ...}` objects).
-
-Method-not-allowed responses return HTTP 405 with the canonical shape when
-the path ends in `.json` or the request content type is `application/json`;
-plain text otherwise (views/base.py).
-
-**`Forbidden` handling:** when a view raises `Forbidden` (e.g. via
-`ensure_permission`), the default `forbidden()` plugin hook returns the
-canonical JSON error with status 403 when the path ends in `.json` or the
-request carries an `Accept: application/json` / `Content-Type:
-application/json` header; other requests get an HTML error page
-(forbidden.py). Endpoints that check permissions themselves return
-`_error(..., 403)` JSON directly.
-
-### CORS
-
-When Datasette is started with `--cors`, responses gain
-(utils/__init__.py:1297-1302):
-
-```
-Access-Control-Allow-Origin: *
-Access-Control-Allow-Headers: Authorization, Content-Type
-Access-Control-Expose-Headers: Link
-Access-Control-Allow-Methods: GET, POST, HEAD, OPTIONS
-Access-Control-Max-Age: 3600
-```
-
-### CSRF / cross-origin protection
-
-Datasette uses header-based cross-origin protection
-(`CrossOriginProtectionMiddleware`, csrf.py:67-178) rather than CSRF tokens
-for API calls. For non-GET/HEAD/OPTIONS requests:
-
-1. Requests carrying `Authorization: Bearer ...` **and no `Cookie` header**
-   bypass the check entirely (csrf.py:98-110).
-2. Otherwise `Sec-Fetch-Site` must be `same-origin` or `none`; other values → 403.
-3. If neither `Sec-Fetch-Site` nor `Origin` is present (curl, API clients),
-   the request passes.
-4. Fallback: `Origin` must exactly match the request scheme/host/port → else 403.
-
-Plain JSON API clients (no cookies, no browser headers) are never blocked;
-`Content-Type: application/json` itself plays no role in the CSRF decision.
-
-### Settings that govern the API
-
-From `SETTINGS` (app.py:197-287): `default_page_size` (100),
-`max_returned_rows` (1000), `max_insert_rows` (100), `sql_time_limit_ms`
-(1000), `default_facet_size` (30), `facet_time_limit_ms` (200),
-`allow_facet` (true), `allow_download` (true), `allow_signed_tokens` (true),
-`default_allow_sql` (true), `max_signed_tokens_ttl` (0), `default_cache_ttl`
-(5), `allow_csv_stream` (true), `max_csv_mb` (100), `force_https_urls`
-(false), `trace_debug` (false), `base_url` ("/").
-
-### The JSON renderer: `_shape`, `_nl`, `_json`, `_json_infinity`
-
-`json_renderer` (renderer.py:31-126) processes `.json` output for table, row
-and query views (but **not** for the instance/database/debug endpoints, which
-build JSON directly):
-
-- **`_shape`** (default `objects`):
-  - `objects` — `{"ok": true, "rows": [{col: val}, ...], "truncated": false, ...}`
-  - `arrays` — same envelope, each row a list of values
-  - `array` — response body is a bare JSON array of row objects
-  - `arrayfirst` — bare JSON array of the first column's values
-  - `object` — table views only: an object keyed by primary-key string.
-    On queries or tables without primary keys: a canonical 400 error
-    (`_shape=object is only available on tables` /
-    `_shape=object not available for tables with no primary keys`).
-  - anything else — canonical HTTP 400 error `Invalid _shape: x`
-- **`_nl=on`** — with `_shape=array` only: newline-delimited JSON, `text/plain`.
-- **`_json=COLUMN`** (repeatable) — parse that column's string values with
-  `json.loads` so they nest as JSON; parse failures leave the value unchanged.
-- **`_json_infinity=1`** — preserve `Infinity`/`-Infinity`; by default they
-  are replaced with `null`.
-- `columns` is stripped from dict-shaped output unless `?_extra=columns` was
-  requested (renderer.py:110-113).
-- If a SQL error occurred, `_shape` is ignored, HTTP status is 400 and the
-  envelope carries the canonical error keys alongside `rows`/`truncated`.
-
-### The `?_extra=` system
-
-Table, row and query JSON responses support `?_extra=` (repeatable and/or
-comma-separated, extras.py:9-14) to add keys to the response. Extras are
-scope-registered (`ExtraScope.TABLE` / `ROW` / `QUERY`) and only **public**
-extras are available over JSON (extras.py:73-92). Unknown extra names (and
-internal HTML-only names) on data formats return 400
-`Unknown _extra: <names>`; HTML pages ignore them. The available names per
-scope are listed with the relevant endpoints below.
-
----
-
-## Instance endpoints
-
-Most of these are implemented with `JsonDataView` (views/special.py:30-79):
-GET-only; bare path renders an HTML page (`show_json.html`), `.json` returns
-the data; permission defaults to `view-instance` and denial raises
-`Forbidden` → **HTML** 403 page.
-
-### GET /
-
-Routes: `/(\.(?P<format>jsono?))?$` and `/-/(\.(?P<format>jsono?))?$`
-(app.py:2517-2518); `/-` permanently redirects to `/-/`. `IndexView`
-(views/index.py:22-189). `GET /.json`, `/.jsono` and `/-/.json` return JSON.
-
-- **Permission:** `view-instance` (denied → 403). Databases and tables are
-  further filtered by `view-database` / `view-table` for the actor.
-- **Parameters:** `_sort=relationships` sorts each database's truncated table
-  list by foreign-key relationship count.
-- **JSON response** (index.py:147-161) — includes `ok: true` plus:
-  - `databases` — a **list** of database objects (undocumented API, subject
-    to change). Each item: `name`, `hash` (or null), `color`, `path`,
-    `tables_and_views_truncated` (up to 5 items: `name`, `columns`,
-    `primary_keys`, `count` (int or null), `hidden`, `fts_table`,
-    `num_relationships_for_sorting`, `private`; view items are just
-    `{"name", "private"}`), `tables_and_views_more` (bool), `tables_count`,
-    `table_rows_sum`, `show_table_row_counts`, `hidden_table_rows_sum`,
-    `hidden_tables_count`, `views_count`, `private`.
-  - `metadata` — instance metadata object.
-
-### GET /-/versions(.json)
-
-`JsonDataView` over `Datasette._versions` (app.py:2548-2551, 2171-2245).
-Permission `view-instance`. No parameters.
-
-Response keys: `python` (`{version, full}`), `datasette` (`{version}` plus
-optional `note`), `asgi` (`"3.0"`), `uvicorn` (string or null), `sqlite`
-(`{version, fts_versions, extensions, compile_options}`; `extensions`
-includes `json1` and optionally `spatialite`), `pysqlite3` (only when
-running under pysqlite3).
-
-### GET /-/plugins(.json)
-
-app.py:2552-2557, `Datasette._plugins` (app.py:2247-2266). Permission
-`view-instance`.
-
-- **Parameters:** `?all=1` — include Datasette's built-in default plugins
-  (filtered out by default).
-- **Response:** `{"ok": true, "plugins": [...]}` — each plugin is
-  `{"name", "static", "templates", "version", "hooks"}`, sorted by name.
-
-### GET /-/settings(.json)
-
-app.py:2558-2561. Permission `view-instance`. No parameters. Returns a flat
-object mapping every setting name (see [Settings](#settings-that-govern-the-api))
-to its effective value.
-
-### GET /-/config(.json)
-
-app.py:2562-2565. Permission `view-instance`. No parameters. Returns the full
-`datasette.yaml` configuration dict passed through
-`redact_keys(config, ("secret", "key", "password", "token", "hash", "dsn"))`
-(app.py:2502-2505) — any dict key containing one of those substrings has its
-value replaced by `"***"` (utils/__init__.py:1532-1556).
-
-### GET /-/threads(.json)
-
-app.py:2566-2569, `Datasette._threads` (app.py:2268-2285). Permission
-**`permissions-debug`** (exposes runtime internals). No parameters.
-
-Response: `num_threads`, `threads` (list of `{name, ident, daemon}`),
-`num_tasks`, `tasks` (asyncio task repr strings). When the
-`num_sql_threads` setting is 0 the response is exactly
-`{"num_threads": 0, "threads": []}`.
-
-### GET /-/databases(.json)
-
-app.py:2570-2573, `Datasette._connected_databases` (app.py:2157-2169).
-Permission `view-instance`. No parameters.
-
-Response: `{"ok": true, "databases": [...]}` — each database is
-`{"name", "route", "path", "size", "is_mutable", "is_memory", "hash"}`.
-Only databases the actor is allowed to `view-database` are listed.
-
-### GET /-/actor(.json)
-
-app.py:2574-2579, registered with `permission=None` — **accessible to any
-request including anonymous**. No parameters.
-
-Response: `{"ok": true, "actor": {...}}` or `{"ok": true, "actor": null}` (app.py:2287-2288).
-
-### GET /-/actions(.json)
-
-app.py:2580-2589. Permission **`permissions-debug`**. No parameters.
-
-Response: `{"ok": true, "actions": [...]}` — each action is
-`{"name", "abbr", "description", "takes_parent", "takes_child",
-"resource_class", "also_requires"}`, sorted by name (app.py:2290-2304).
-
-### GET /-/auth-token
-
-`AuthTokenView` (app.py:2590-2593, views/special.py:198-217). GET only, no
-`.json` variant, HTML/redirect only.
-
-- **Parameter:** `token` — the one-time secret printed by `datasette --root`.
-- Match → invalidates the token, sets the signed `ds_actor` cookie to
-  `{"id": "root"}` and 302-redirects to the homepage. Mismatch or reuse →
-  `Forbidden` → 403 HTML.
-
-### GET/POST /-/create-token
-
-`CreateTokenView` (app.py:2594-2597, views/special.py:727-856). **HTML form
-endpoint only — there is no JSON request/response mode in this codebase**
-(`has_json_alternate = False`; the POST body must be form-encoded, a JSON
-content type raises `BadRequest` → 400).
-
-- **Gates** (each failure → `Forbidden` → 403): `allow_signed_tokens` must be
-  on; request must have an actor with an `id`; the actor must not itself be
-  token-derived.
-- **POST fields:** `expire_type` (`""`/`minutes`/`hours`/`days`),
-  `expire_duration` (positive int), plus restriction checkboxes named
-  `all:<action>`, `database:<db>:<action>`,
-  `resource:<db>:<table>:<action>`.
-- **Response:** HTML page containing the new `dstok_` token.
-- Programmatic alternatives: `datasette create-token` CLI or
-  `datasette.create_token()`.
-
-### GET /-/api
-
-`ApiExplorerView` (app.py:2598-2601, views/special.py:859-1020). HTML API
-explorer, GET only. Permission `view-instance` (403 on denial).
-
-### GET /-/jump(.json)
-
-`JumpView` (app.py:2602-2605, views/special.py:1023-1201). The route allows
-an optional `.json` suffix but the view **always returns JSON**.
-
-- **Permission:** none checked directly; results are filtered via
-  `allowed_resources_sql` for the current actor (default items come from the
-  `jump_items_sql` plugin hook).
-- **Parameter:** `q` — whitespace-split terms matched as a case-insensitive
-  `%term1%term2%` LIKE pattern.
-- **Response:** `{"ok": true, "matches": [...], "truncated": bool}`; each match:
-  `name`, `url`, `type` (`database`/`table`/`view`/`query`/plugin-defined),
-  `description`, optional `display_name`. Capped at 100 matches.
-
-### GET /-/schema(.json|.md)
-
-`InstanceSchemaView` (app.py:2610-2613, views/special.py:1257-1293).
-
-- **Permission:** no explicit check; only databases the actor can
-  `view-database` are included (others silently omitted).
-- **Formats:** no extension → HTML; `.json` →
-  `{"ok": true, "schemas": [{"database": name, "schema": "..."}]}`; `.md` →
-  `text/markdown` rendering.
-
-### GET/POST /-/logout
-
-`LogoutView` (app.py:2614-2617, views/special.py:220-238). HTML endpoint.
-GET renders a confirmation page (or redirects if anonymous); POST deletes the
-`ds_actor` cookie and 302-redirects to `/`.
-
-### GET/POST /-/permissions
-
-`PermissionsDebugView` (app.py:2618-2621, views/special.py:241-295). No
-`.json` route. Both methods require `view-instance` **and**
-`permissions-debug` (403 on denial).
-
-- **GET** — HTML permission-check log; `?filter=all|exclude-yours|only-yours`.
-- **POST** — form-encoded `actor` (JSON string), `permission`, optional
-  `resource_1`, `resource_2`; returns **JSON**
-  `{"action", "allowed", "resource": {"parent", "child", "path"}}` plus
-  `actor_id` when present. Errors: unknown action → 404; child without
-  parent → 400 (both canonical error shape).
-
-### GET /-/allowed(.json)
-
-`AllowedResourcesView` (app.py:2622-2625, views/special.py:298-460). Bare
-path always renders the HTML form; `.json` returns JSON.
-
-- **Permission:** none — reports the **current actor's own** allowed
-  resources. Items gain a `reason` field if the actor also holds
-  `permissions-debug`.
-- **Parameters:** `action` (required; missing → 400 canonical error, unknown
-  → 404), `parent`, `child` (requires `parent`), `_page` (default 1),
-  `_size` (default 50, maximum 200, accepts `max`; out-of-range → 400).
-- **Response:** `{"action", "actor_id", "page", "page_size", "total",
-  "items": [{"parent", "child", "resource"}]}` with optional `next_url` /
-  `previous_url`.
-
-### GET /-/rules(.json)
-
-`PermissionRulesView` (app.py:2626-2629, views/special.py:463-584).
-Permission `view-instance` **and** `permissions-debug`. Parameters and error
-shapes as `/-/allowed`. Response items:
-`{"parent", "child", "resource", "allow" (1|0), "reason", "source_plugin"}`.
-
-### GET /-/check(.json)
-
-`PermissionCheckView` (app.py:2630-2633, views/special.py:633-662).
-Permission `permissions-debug`. Parameters `action` (required), `parent`,
-`child`. Checks the **current request's actor**; response
-`{"action", "allowed", "resource": {...}}` plus `actor_id`.
-
-### GET/POST /-/messages
-
-`MessagesDebugView` (app.py:2634-2637, views/special.py:703-724). HTML debug
-tool for flash messages; permission `view-instance`; POST is form-encoded
-(`message`, `message_type` = INFO/WARNING/ERROR/all) and 302-redirects.
-
-### GET /-/allow-debug
-
-`AllowDebugView` (app.py:2638-2641, views/special.py:665-700). GET only, HTML
-only, **no permission required**. Parameters `actor` and `allow` (JSON
-strings); renders the result of `actor_matches_allow()` in the page.
-
-### GET /-/patterns
-
-Pattern portfolio page (app.py:2642-2645). HTML only; not part of the JSON API.
-
-### GET /-/debug/autocomplete
-
-`AutocompleteDebugView` (app.py:2646-2649, views/special.py:94-195). HTML
-debug page for the table autocomplete API; permission `view-instance` plus
-`view-table` when `?database=&table=` are supplied.
-
----
-
-## Database endpoints
-
-### GET /\<database\>.db
-
-Downloads the raw SQLite file. Route → `database_download`
-(app.py:2650-2653; views/database.py:533-570).
-
-- **Permission:** `view-database-download` (denied → `Forbidden` → 403 HTML).
-- **Other gates:** unknown database → 404 `"Invalid database"`; in-memory
-  database → 404; `allow_download` off **or** mutable database →
-  `Forbidden("Database download is forbidden")`; no file path → 404.
-- **Response:** streamed `application/octet-stream` with a
-  `content-disposition` attachment; immutable databases with a known hash set
-  `Etag` and honor `If-None-Match` → 304.
-
-### GET /\<database\>(.json)
-
-`DatabaseView` (app.py:2654-2657; views/database.py:71-277). Only `html` and
-`json` formats are accepted; any other extension → 404 `"Invalid format: ..."`.
-
-- **Permission:** `view-database` via `check_visibility` (denied →
-  `Forbidden` → 403 HTML). Table/view listings are filtered by `view-table`;
-  stored queries by `view-query`.
-- **Parameters:**
-  - `?sql=` — non-blank value 302-redirects to `/<database>/-/query?...`
-    preserving the query string and format.
-  - No `?_extra=` and no `_shape` support — the JSON is built directly and
-    returned via `Response.json`, bypassing the JSON renderer
-    (views/database.py:189-212).
-- **JSON response** (all keys always present):
-  - `ok` — always `true`
-  - `database` — name; `private` — bool; `path` — URL path; `size` — bytes
-  - `tables` — list (includes hidden tables), each:
-    `name`, `columns` (names), `primary_keys`, `count` (int or null,
-    time-boxed), `count_truncated` (bool — count is a capped lower bound),
-    `hidden`, `fts_table`, `foreign_keys` (`{incoming: [...], outgoing: [...]}`
-    of `{other_table, column, other_column}`), `private`
-  - `hidden_count` — number of hidden tables
-  - `views` — list of `{name, private}`
-  - `queries` — **up to 5** stored queries (canonical stored-query objects,
-    see the stored-queries section); `queries_more` (bool);
-    `queries_count` (total visible)
-  - `allow_execute_sql` — bool for this actor
-  - `table_columns` — `{table: [columns]}`, empty `{}` unless
-    `allow_execute_sql` (views map to `[]`)
-  - `metadata` — database metadata dict
-
-### GET /\<database\>/-/query(.json) — arbitrary SQL
-
-`QueryView` (app.py:2691-2694; views/database.py:573-1130). The same class
-also executes stored queries dispatched from the table route (see stored
-queries section).
-
-- **Permission:** `execute-sql` on the database via `check_visibility`
-  (denied → `Forbidden` → 403 HTML).
-- **Parameters:**
-  - `sql` — SQL to run. Must pass `validate_sql_select`
-    (utils/__init__.py:345-354): after stripping `--` comment lines it must
-    start with `select`, `with` or an `explain` variant, and must not contain
-    `pragma` (except allowlisted `pragma_*()` table-valued functions).
-    Failure → 400 `DatasetteError` titled `"Invalid SQL"` → JSON
-    `{"ok": false, "error": "Statement must be a SELECT", "status": 400,
-    "title": "Invalid SQL"}`.
-  - Any other `name=value` pair supplies the `:name` named parameter; missing
-    parameters default to `""`. Names starting with `_` are excluded.
-  - `_timelimit` — per-request SQL time limit in ms.
-  - `_shape`, `_nl`, `_json`, `_json_infinity` — see the JSON renderer section.
-  - `_extra` — QUERY-scope extras: `columns`, `debug`, `request`,
-    `render_cell`, `query` (`{"sql", "params"}`), `metadata`, `database`,
-    `database_color`, `private`, `extras`.
-- **Response** (default shape):
-  `{"ok": true, "rows": [{col: val}, ...], "truncated": false}` plus any
-  requested extras. `truncated: true` when the result hit `max_returned_rows`.
-- **Errors:**
-  - SQLite errors (e.g. `no such table`) are **not** raised — they surface as
-    HTTP 400 `{"ok": false, "error": "<message>", "rows": [], "truncated": false}`.
-  - Time limit → 400 titled `"SQL Interrupted"` (the `error` value contains
-    an HTML fragment).
-  - `?sql=` omitted or blank → 400 `"?sql= is required"` for all data
-    formats (`.json`, `.csv`, plugin formats). The HTML page remains the
-    SQL editor.
-- `.csv` streams CSV; unknown extensions → 404.
-
-### GET /\<database\>/-/query/parameters
-
-`QueryParametersView` (app.py:2687-2690; views/stored_queries.py:26-51).
-
-- **Permission:** `execute-sql` → 403 JSON
-  `{"ok": false, "errors": ["Permission denied: need execute-sql"]}`.
-- **Parameters:** only `sql` (default `""`); any other key → 400
-  `"Invalid keys: ..."`.
-- **Response:** 200 `{"ok": true, "parameters": ["name1", ...]}`. SQL with a
-  parameter beginning `_` → 400 `"Magic parameters are not allowed"`.
-- Responses carry `Content-Security-Policy: frame-ancestors 'none'` and
-  `X-Frame-Options: DENY`.
-
-### POST /\<database\>/-/create
-
-`TableCreateView` (app.py:2658; views/table_create_alter.py:785-962).
-GET → 405. Body is parsed as JSON regardless of content type; invalid JSON →
-400 `{"ok": false, "errors": ["Invalid JSON: ..."]}`.
-
-- **Permissions** (all denials → 403 canonical error JSON,
-  all checked at the **database** level):
-  - `create-table` — always required (`["Permission denied"]`)
-  - `insert-row` — if `rows`/`row` provided (`need insert-row`)
-  - `update-row` — if `replace: true` (`need update-row`)
-  - `alter-table` — if `alter: true` on an **existing** table
-    (`need alter-table`); when the table does not exist yet and rows are
-    supplied, alter is enabled automatically.
-- **Request schema** (pydantic `CreateTableRequest`, extra keys forbidden →
-  400 `"Invalid keys: a, b"`):
-  - `table` (required) — must match `^(?!sqlite_)[^\n]+$`
-  - `rows` (list of objects) / `row` (single object) — mutually exclusive
-  - `columns` — list of `{name, type, fk_table, fk_column, not_null,
-    default, default_expr}`; mutually exclusive with `rows`/`row`; `type` one
-    of `text`/`integer`/`float`/`blob` (default `text`); `default` and
-    `default_expr` mutually exclusive; `default_expr` one of
-    `current_timestamp`, `current_date`, `current_time`, `current_unixtime`,
-    `current_unixtime_ms`. At least one of `columns`/`rows`/`row` required.
-  - `pk` (string) / `pks` (list) — mutually exclusive. For an existing table
-    a differing pk → 400 `"pk cannot be changed for existing table"`.
-  - `ignore` / `replace` (bools) — mutually exclusive; require `row`/`rows`
-    and `pk`/`pks`.
-  - `alter` (bool) — add missing columns when inserting into an existing table.
-- **Success** — **201**:
-  ```json
-  {"ok": true, "database": "...", "table": "...",
-   "table_url": "https://.../db/table", "table_api_url": "https://.../db/table.json",
-   "schema": "CREATE TABLE ...", "row_count": 2}
-  ```
-  `row_count` only when rows were inserted. Write failures → 400
-  `{"ok": false, "errors": ["<sqlite message>"]}`. Emits `create-table` /
-  `insert-rows` / `alter-table` events.
-
-### POST /\<database\>/-/execute-write
-
-`ExecuteWriteView` (app.py:2679-2682; views/execute_write.py:236-476). GET on
-the same path renders an HTML form (requires `execute-write-sql`).
-
-- **Permission (POST):** `execute-write-sql` → 403
-  `{"ok": false, "errors": ["Permission denied: need execute-write-sql"]}`;
-  immutable database → 403 `["Database is immutable"]`.
-- **Per-statement permissions:** the SQL is analyzed
-  (`decision_for_write_sql_operation`, write_sql.py:63-189) and each
-  operation must pass:
-
-  | Operation | Requirement |
-  |---|---|
-  | `select` / internal ops / function calls | ignored |
-  | read of a table | `view-table` on that table |
-  | `insert` or `update` | **all of** `insert-row`, `update-row`, `delete-row` on the table |
-  | `delete` | `delete-row` |
-  | `create table` | `create-table` on the database |
-  | `alter table`, `create index`, `drop index` | `alter-table` on the table |
-  | `drop table` | `drop-table` |
-  | `VACUUM`, virtual-table writes, shadow-table writes | rejected outright (403) |
-  | statements touching attached databases | rejected (403) |
-
-- **Body:** JSON (`{"sql": ..., "params": {...}}` — only those two keys) or
-  form-encoded (`sql` plus one field per parameter, `_sql_param_` prefix
-  stripped). Validation errors (400): `"SQL is required"`,
-  `"params must be a dictionary"`, `"Unknown parameters: a, b"`,
-  `"Magic parameters are not allowed"`, `"Could not analyze query: ..."`,
-  `"Use /-/query for read-only SQL; this endpoint only executes writes"`.
-- **JSON is returned when** the body was JSON, `Accept: application/json`, or
-  a truthy `_json` field is present; otherwise HTML.
-- **Success** — 200:
-  ```json
-  {"ok": true, "message": "Query executed, 1 row affected", "rowcount": 1,
-   "rows": [], "truncated": false,
-   "analysis": [{"operation": "insert", "database": "db", "table": "t",
-                  "required_permission": "insert-row, update-row, delete-row",
-                  "source": null}]}
-  ```
-  `rows` is populated by `RETURNING` clauses. SQLite errors → 400
-  `{"ok": false, "errors": ["<message>"]}`. Anti-framing headers on all
-  responses.
-
-### GET /\<database\>/-/execute-write/analyze
-
-`ExecuteWriteAnalyzeView` (app.py:2675-2678; views/execute_write.py:479-507).
-
-- **Permission:** `execute-write-sql` → 403 `errors` JSON.
-- **Parameters:** only `sql` allowed (else 400 `"Invalid keys: ..."`).
-- **Response** — 200 even when analysis fails (`ok: false` in body):
-  `{"ok", "parameters", "analysis_error", "analysis_rows":
-  [{operation, database, table, required_permission, source, allowed}],
-  "execute_disabled", "execute_disabled_reason"}`. `allowed` is a per-actor
-  permission check result (true/false/null).
-
-### GET /\<database\>/-/foreign-key-targets
-
-`DatabaseForeignKeyTargetsView` (app.py:2659-2662;
-views/table_create_alter.py:965-1005).
-
-- **Parameter:** `table` (optional) — only used for the permission check.
-- **Permission:** `create-table` on the database, **or** `alter-table` on
-  `?table=` when it names an existing table. Neither → 403
-  `{"ok": false, "errors": ["Permission denied: need create-table"]}`.
-- **Response:** 200 `{"ok": true, "database": "...", "targets":
-  [{"fk_table", "fk_column", "type"}]}` — every non-hidden table with exactly
-  one primary-key column; `type` is the pk's SQLite type affinity.
-
-### GET /\<database\>/-/schema(.json|.md)
-
-`DatabaseSchemaView` (app.py:2683-2686; views/special.py:1296-1329).
-
-- **Permission:** `view-database` (denied → `Forbidden` → 403 HTML).
-- **Unknown database** → 404; for `.json`:
-  `{"ok": false, "error": "Database not found"}`. The permission check runs
-  first, so unauthorized actors cannot probe for database existence.
-- **Responses:** `.json` → 200 `{"ok": true, "database": "<name>", "schema": "<SQL>"}`
-  (concatenated `sqlite_master.sql` joined with `;\n`); `.md` →
-  `text/markdown`; no extension → HTML.
-
----
-
-## Table and row read endpoints
-
-### GET /\<database\>/\<table\>.json
-
-Route `r"/(?P<database>[^\/\.]+)/(?P<table>[^\/\.]+)(\.(?P<format>\w+))?$"` →
-`table_view` (app.py:2711-2714; views/table.py:1670). Serves both tables and
-SQL views. GET/HEAD only — POST returns a plain-text 405. If the name is
-neither a table nor a view but matches a stored query, the request is
-dispatched to `QueryView` (views/table.py:1703-1712).
-
-**Permission:** `view-table` via `check_visibility`; denial raises
-`Forbidden` → **HTML** 403 page even for `.json`. Unknown table →
-`TableNotFound` → 404 (JSON error shape for `.json` paths).
-
-**Default JSON keys** (views/table.py:2308-2332 + renderer):
-
-| Key | Meaning |
-|---|---|
-| `ok` | `true` when data was retrieved without error |
-| `next` | pagination token string, or `null` on the last page |
-| `next_url` | absolute URL of the next page, or `null` on the last page |
-| `rows` | list of row objects `{column: value}` (default `_shape=objects`) |
-| `truncated` | always present; `false` for table pages |
-
-`columns` is computed but removed unless `?_extra=columns` was requested.
-When there is a next page the response carries a
-`Link: <next_url>; rel="next"` header (views/table.py:1911-1912).
-
-**`?_extra=` options** (TABLE scope; registry
-views/table_extras.py:1197-1235; unknown names silently ignored):
-
-| `_extra=` | Returns |
-|---|---|
-| `count` | total matching-row count, computed with a `limit 10001` subquery so it caps at 10001; `null` with `_nocount` or on count timeout. Requesting `count` implicitly includes `count_truncated` |
-| `count_truncated` | `true` when `count` hit the counting limit (the real count is at least the reported value) |
-| `count_sql` | the SQL used for the count |
-| `facet_results` | `{"results": {name: facet}, "timed_out": [...]}`; each facet: `{name, type, hideable, toggle_url, results: [{value, label, count, toggle_url, selected}], truncated}` |
-| `facets_timed_out` | facet names that exceeded `facet_time_limit_ms` |
-| `suggested_facets` | `[{name, toggle_url, (type)}]`; empty when suggestion is disabled or paginating |
-| `human_description_en` | English description of filters + sort |
-| `next_url` | absolute URL of the next page or `null` |
-| `columns` | column names of the returned rows |
-| `all_columns` | all table columns regardless of `_col`/`_nocol` |
-| `primary_keys` | pk column names (empty for rowid tables and views) |
-| `display_columns` | HTML-oriented column metadata |
-| `render_cell` | per-row plugin-rendered HTML strings |
-| `debug` | `{url_vars, resolved, nofacet, nosuggest}` — explicitly unstable |
-| `request` | `{url, path, full_path, host, args}` |
-| `query` | `{sql, params}` of the main query |
-| `column_types` | `{column: {type, config}}` assigned column types |
-| `set_column_type_ui` | UI helper, `null` unless actor has `set-column-type` |
-| `metadata` | table metadata dict including column descriptions |
-| `extras` | self-describing list of all available extras |
-| `database`, `table`, `database_color` | identity/display values |
-| `renderers` | `{format_name: url}` of formats that can render this data |
-| `custom_table_templates` | template lookup list |
-| `sorted_facet_results` | facets as a display-ordered list |
-| `table_definition` | `CREATE TABLE` SQL |
-| `view_definition` | `CREATE VIEW` SQL, `null` for tables |
-| `is_view` | boolean |
-| `private` | `true` if visible to this actor but not anonymously |
-| `expandable_columns` | `[[foreign_key, label_column_or_null], ...]` |
-| `form_hidden_args` | pairs of `_`-prefixed args for HTML forms |
-
-Non-public extras (`actions`, `filters`, `display_rows`) are HTML-only and
-never appear in JSON. `_extra=_html` expands to the full HTML bundle
-(views/table_extras.py:1162-1194). Any `_facet*` argument implicitly adds
-`facet_results`; `_shape=object` implicitly adds `primary_keys`
-(views/table.py:2252-2256). There is **no** `filtered_table_rows_count`
-extra — it was replaced by `count`.
-
-**Column filters `?<column>__<op>=<value>`** (filters.py:260-427). Any
-querystring key not starting with `_` is a filter; bare `?column=value` means
-`exact`. Columns whose names start with `_` can be filtered as
-`?_col__exact=`. Operators:
-
-| op | SQL |
-|---|---|
-| `exact` | `"col" = :p` (default) |
-| `not` | `"col" != :p` |
-| `contains` / `notcontains` | `like '%v%'` / `not like '%v%'` |
-| `endswith` / `startswith` | `like '%v'` / `like 'v%'` |
-| `gt` / `gte` / `lt` / `lte` | `>` `>=` `<` `<=` (numeric strings cast to int) |
-| `like` / `notlike` | raw `like` / `not like` pattern |
-| `glob` | `glob` |
-| `in` / `notin` | comma-separated list, or JSON array if the value starts with `[` |
-| `arraycontains` / `arraynotcontains` | `[not] in (select value from json_each("col"))` (requires JSON1) |
-| `date` | `date("col") = :p` |
-| `isnull` / `notnull` | `is null` / `is not null` (no value) |
-| `isblank` / `notblank` | `(is null or = '')` / opposite (no value) |
-
-**Special (underscore) parameters:**
-
-| Param | Behavior |
-|---|---|
-| `_where=SQL` | extra raw where clause (repeatable); requires `execute-sql` else 403 `"_where= is not allowed"` |
-| `_search=q` | FTS against the table's FTS table |
-| `_search_<column>=q` | FTS restricted to one column; 400 if invalid |
-| `_searchmode=raw` | pass the query straight to `match` |
-| `_fts_table=` / `_fts_pk=` | override the FTS table / pk used for joins |
-| `_through={"table","column","value"}` | filter via an incoming foreign key (repeatable, JSON value) |
-| `_sort=col` / `_sort_desc=col` | sort; 400 if both given or column not sortable |
-| `_next=token` | pagination token |
-| `_size=N\|max` | page size; default `default_page_size` (100); `max` = `max_returned_rows` (1000); 400 on invalid |
-| `_col=name` (repeatable) | return only pks + these columns; 400 on invalid |
-| `_nocol=name` (repeatable) | exclude columns; 400 if invalid or a pk |
-| `_labels=on` | expand every FK column into `{"value", "label"}` |
-| `_label=col` (repeatable) | expand only the named FK column(s) |
-| `_facet=col` | request a facet; 400 `"_facet= is not allowed"` when `allow_facet` off |
-| `_facet_array=col` / `_facet_date=col` | typed facets |
-| `_facet_size=N\|max` | facet bucket count, default 30, capped at `max_returned_rows` |
-| `_nocount=1` | skip count (`count` extra → null) |
-| `_nofacet=1` | skip facets and suggestions |
-| `_nosuggest=1` | skip facet suggestions only |
-| `_shape=` | see renderer section; `array`/`object` also force `_nocount` and `_nofacet` |
-| `_nl=on` | NDJSON with `_shape=array` |
-| `_json=col` / `_json_infinity=1` | renderer options |
-| `_timelimit=ms` | custom SQL time limit |
-| `_ttl=seconds` | `Cache-Control: max-age=N` (`0` → `no-cache`); default `default_cache_ttl` (5) |
-| `_trace=1` | append `_trace` key (requires `trace_debug` setting) |
-| `_extra=` | see above |
-
-**Pagination** is keyset-based for tables: `page_size + 1` rows are fetched;
-`next` is built from the last row of the page — comma-joined tilde-encoded
-primary-key values, prefixed by the sort value when sorted (`$null` for null
-sort values) (views/table.py:2041-2111, 2421-2482). `next_url` is the
-absolute URL with `_next` replaced.
-
-### GET /\<database\>/\<view_name\>.json (SQL views)
-
-Same code path with `is_view=True`. Differences:
-
-- No primary keys: `primary_keys` → `[]`; `_shape=object` fails; base query
-  has no `order by`.
-- **Pagination is offset-based**: `_next` is an integer offset applied as
-  `limit N offset M` (views/table.py:2047-2049, 2438-2439) — unlike the
-  keyset tokens used for tables.
-- `view_definition` returns the `CREATE VIEW` SQL; `table_definition` is null.
-
-### GET /\<database\>/\<table\>/\<pks\>.json
-
-`RowView` (app.py:2715-2718; views/row.py:137). `<pks>` is comma-separated
-tilde-encoded primary key values (rowid for rowid tables).
-
-- **Permission:** `view-table` (denied → `Forbidden` → 403 HTML). Missing row
-  → 404 `"Record not found: [...]"`.
-- **Default JSON keys:** `ok`, `database`, `table`, `rows` (single-element
-  list), `primary_keys`, `primary_key_values`, `query_ms`,
-  `truncated: false`; `columns` only with `?_extra=columns`.
-- **`?_extra=` (ROW scope):** `columns`, `primary_keys`, `render_cell`,
-  `debug`, `request`, `query`, `column_types`, `metadata`, `extras`,
-  `database`, `table`, `database_color`, `private`, `foreign_key_tables`
-  (incoming FKs with `count` and `link`; single-pk rows only).
-- **Foreign-key label expansion does not apply to row JSON** — `_labels` has
-  no effect here; expansion happens only in the HTML path
-  (views/row.py:445-475).
-- `_shape`, `_json`, `_nl`, `_json_infinity`, `_ttl` apply.
-
-### The .blob format
-
-`/<database>/<table>/<pks>.blob?_blob_column=col` (also on query pages) —
-fetches raw binary bytes (blob_renderer.py:10-61). `_blob_column` required
-(400 if missing/invalid); optional `_blob_hash` must equal the value's
-SHA-256 (else 400 `"Link has expired..."`). Returns `application/binary` as a
-download attachment. In JSON output, binary cells appear as
-`{"$base64": true, "encoded": "..."}`.
-
-### GET /\<database\>/\<table\>/-/schema(.json|.md)
-
-`TableSchemaView` (app.py:2751-2754; views/special.py:1332-1378).
-
-- **Permission:** `view-table` via `ensure_permission` (denied → 403 HTML).
-- **Responses:** `.json` → 200 `{"ok": true, "database", "table", "schema"}`;
-  `.md` → `text/markdown`; no extension → HTML. Missing table → 404
-  `{"ok": false, "error": "Table not found"}` for `.json`.
-
-### GET /\<database\>/\<table\>/-/fragment
-
-`TableFragmentView` (app.py:2739-2742; views/table.py:1385-1418).
-**HTML-only** — returns the `_table.html` partial; no JSON variant. Accepts
-table querystring parameters plus `_row=<pk-path>` to render a single row.
-
-### GET /\<database\>/\<table\>/-/autocomplete
-
-`TableAutocompleteView` (app.py:2743-2746; views/table.py:1492-1595). Tables
-only — views get 400 `"Autocomplete is only available for tables"`.
-
-- **Permission:** `view-table` (denied → `Forbidden` → 403).
-- **Parameters:** `q` (matched with escaped `LIKE %q%` against pk columns and
-  the label column) and `_initial` (truthy: with empty `q`, return the 10
-  most recent rows). Neither → `{"ok": true, "rows": []}`.
-- **Response:** `{"rows": [{"pks": {pk_name: value}, "label": "..."}]}` — max
-  10 items; 500 ms query budget with fallbacks, timing out to
-  `{"ok": true, "rows": []}`.
-
----
-
-## The write API
-
-All write endpoints return errors via `_error()` (the canonical error
-shape) and check permissions with
-`datasette.allowed()` directly, so their 403s are JSON (unlike the
-`Forbidden`-raising read endpoints). Routes: app.py:2719-2762.
-
-### POST /\<database\>/\<table\>/-/insert
-
-`TableInsertView` (views/table.py:907-1194).
-
-- **Permissions:** `insert-row` on the table (denied → 403
-  `["Permission denied"]`); `update-row` additionally required for
-  `replace: true` (403 `need update-row to use "replace"`); `alter-table`
-  additionally required for `alter: true` (403
-  `Permission denied for alter-table`). Immutable database → 403
-  `Database is immutable`.
-- **Request** — the body is parsed as JSON regardless of the request
-  `Content-Type` header (invalid JSON → 400). Body:
-
-  | Field | Rules |
-  |---|---|
-  | `row` | single object; mutually exclusive with `rows`; forces `return: true` |
-  | `rows` | list of objects; max `max_insert_rows` (default 100), else 400 `"Too many rows, maximum allowed is 100"` |
-  | `ignore` | skip rows whose pk already exists; mutually exclusive with `replace` |
-  | `replace` | replace rows with matching pks (needs `update-row`) |
-  | `alter` | add missing columns (needs `alter-table`) |
-  | `return` | include inserted rows in the response |
-
-  One of `row`/`rows` required. Unknown keys → 400 `"Invalid parameter: ..."`.
-  Unless `alter`, row keys must be existing columns → per-row 400
-  `"Row 0 has invalid columns: x, y"`. Values are validated against assigned
-  column types.
-- **Response** — **201** `{"ok": true}`; with `return: true` also `rows`
-  (the rows as stored, re-fetched by rowid). SQLite errors during the write →
-  400 with the message. Emits `insert-rows` (and possibly `alter-table`)
-  events.
-
-### POST /\<database\>/\<table\>/-/upsert
-
-`TableUpsertView` — subclasses insert (views/table.py:1197-1201).
-
-- **Permissions:** **both** `insert-row` and `update-row` (403
-  `need both insert-row and update-row`); `alter: true` needs `alter-table`.
-- **Request:** same as insert, except `ignore`/`replace` are rejected (400
-  `"Upsert does not support ignore or replace"`) and **every row must contain
-  the table's primary key(s)** (per-row 400
-  `Row 0 is missing primary key column(s): "id"` / `has null primary key`).
-- **Response** — **200** (note: insert returns 201) `{"ok": true}`; with
-  `return: true`, `rows` re-fetched by pk. Emits `upsert-rows`.
-
-### POST /\<database\>/\<table\>/-/alter
-
-`TableAlterView` (views/table_create_alter.py:1130-1353).
-
-- **Permission:** `alter-table` (403 `need alter-table`); immutable → 403.
-- **Request:** `{"operations": [{"op": ..., "args": {...}}, ...]}` — a
-  non-empty list, validated by pydantic (extra keys forbidden anywhere;
-  errors → 400 `location: message`):
-
-  | `op` | `args` |
-  |---|---|
-  | `add_column` | `name` (required), `type` (`text`/`integer`/`float`/`blob`, default `text`), `not_null`, `default` xor `default_expr`; `not_null: true` requires a default |
-  | `rename_column` | `name`, `to` |
-  | `rename_table` | `to` (must not start `sqlite_`) |
-  | `alter_column` | `name` + at least one of `type`, `not_null`, `default`, `default_expr` |
-  | `drop_column` | `name` |
-  | `set_primary_key` | `columns` (non-empty list) |
-  | `reorder_columns` | `columns` (non-empty list) |
-  | `add_foreign_key` | `column`, `fk_table`, optional `fk_column` |
-  | `drop_foreign_key` | `column` |
-  | `set_foreign_keys` | `foreign_keys`: list of `{column, fk_table, fk_column?}` |
-
-  `default_expr` must be one of the five `current_*` keywords. Operations are
-  applied in a single write transaction; any failure → 400.
-- **Response** — 200:
-  ```json
-  {"ok": true, "database": "...", "table": "<possibly renamed>",
-   "table_url": "...", "table_api_url": "...",
-   "altered": true, "schema": "...", "before_schema": "...",
-   "operations_applied": 2}
-  ```
-
-### POST /\<database\>/\<table\>/-/drop
-
-`TableDropView` (views/table.py:1320-1382).
-
-- **Permission:** `drop-table` (403 `Permission denied`); immutable → 403.
-- **Confirmation flow:** without `{"confirm": true}` in the body, nothing is
-  dropped and a 200 preview is returned:
-  `{"ok": true, "database", "table", "row_count",
-  "message": "Pass \"confirm\": true to confirm"}`. With `confirm: true` →
-  200 `{"ok": true}`. Emits `drop-table`.
-
-### POST /\<database\>/\<table\>/-/set-column-type
-
-`TableSetColumnTypeView` (views/table.py:1204-1317). Assigns a Datasette
-*column type* (metadata stored in the internal `column_types` table) — it
-does not change the SQLite schema.
-
-- **Permission:** `set-column-type` (403 `Permission denied`).
-- **Request**: `{"column": "name",
-  "column_type": {"type": "url", "config": {...}?} | null}`. Unknown
-  keys/invalid structure → detailed 400 errors; unknown type → 400
-  `"Unknown column type: x"`. Default registered types (via the
-  `register_column_types` hook): `url`, `email`, `json`, `textarea`.
-- **Response** — 200 `{"ok": true, "database", "table", "column",
-  "column_type": {...} | null}`.
-
-### GET /\<database\>/\<table\>/-/foreign-key-suggestions
-
-`TableForeignKeySuggestionsView` (views/table_create_alter.py:1008-1127).
-**GET only** (read-only despite living beside the write endpoints).
-
-- **Permission:** `alter-table` (403 `need alter-table`); views → 400
-  `"Cannot suggest foreign keys for a view"`.
-- **Response** — 200: `{"ok": true, "database", "table",
-  "row_check": {attempted, status, row_limit, sampled_rows, checked_options},
-  "columns": [{column, type, affinity, current,
-  "suggestions": [{fk_table, fk_column, confidence, sampled_values, reasons}],
-  "options": [...]}]}`. Samples up to 500 rows within 50 ms/200 ms budgets.
-
-### POST /\<database\>/\<table\>/\<pks\>/-/update
-
-`RowUpdateView` (views/row.py:781-870).
-
-- **Permissions:** `update-row` (403 `Permission denied`); `alter: true`
-  additionally requires `alter-table` (403
-  `Permission denied for alter-table`).
-- **404s:** `Database not found: x` / `Table not found: x` /
-  `Record not found: [pks]`.
-- **Request:** `{"update": {column: value, ...}, "return"?: true,
-  "alter"?: true}`. Missing/non-dict `update` → 400
-  `"JSON must contain an update dictionary"`; unknown keys → 400
-  `"Invalid keys: ..."`; write failures (bad column, constraint violation) →
-  400 with the message.
-- **Response** — 200 `{"ok": true}`; with `return: true`,
-  `{"ok": true, "rows": [{...}]}` — a single-item list, matching
-  insert/upsert. Emits `update-row`.
-
-### POST /\<database\>/\<table\>/\<pks\>/-/delete
-
-`RowDeleteView` (views/row.py:738-778).
-
-- **Permission:** `delete-row` (403 `Permission denied`). 404s as update.
-- **Request:** no body required (any body is ignored — there is no
-  confirmation step, unlike table drop).
-- **Response** — 200 `{"ok": true}`; with `?_redirect_to_table` a `redirect`
-  key is added. A failure during the write returns 400 with the message,
-  matching update. Emits `delete-row`.
-
----
-
-## Stored (canned) queries API
-
-Stored queries live in the internal database's `queries` table
-(utils/internal_db.py:116-133). Queries defined in `datasette.yaml` are
-synced in at startup with `source="config"` and `is_trusted` defaulting to
-true; queries created via the API get `source="user"`, `is_trusted=false`,
-`owner_id` = actor id.
-
-**Canonical stored-query JSON object** (`stored_query_to_dict`,
-stored_queries.py:55-80):
-
-```json
-{
-  "database": "...", "name": "...", "sql": "...",
-  "title": null, "description": null, "description_html": null,
-  "hide_sql": false, "fragment": null,
-  "parameters": ["p"],
-  "is_write": false, "is_private": true, "is_trusted": false,
-  "source": "user", "owner_id": "...",
-  "on_success_message": null, "on_success_message_sql": null,
-  "on_success_redirect": null,
-  "on_error_message": null, "on_error_redirect": null,
-  "private": true
-}
-```
-
-`private` appears only in list responses. On input (create/update and
-`datasette.yaml`), `params` is accepted as an alias for `parameters`.
-
-**Default permission rules for queries** (default_permissions/defaults.py):
-`view-query` is default-allow, but private queries are visible only to their
-owner; the owner may `update-query`/`delete-query` their `source='user'`
-queries.
-
-### GET /-/queries(.json) and GET /\<database\>/-/queries(.json)
-
-`GlobalQueryListView` / `QueryListView` (app.py:2606-2609, 2663-2666;
-views/stored_queries.py:69-238). The global variant lists queries across all
-databases (`database`/`database_color` are null, `show_database` true).
-
-- **Permissions:** no single gate; results filtered per query by
-  `view-query` (private queries appear only for their owner).
-- **Parameters:** `_size` (default 20 HTML / **50 JSON**; accepts `max`;
-  values over `max_returned_rows` or non-integers → 400, matching table
-  `_size` semantics), `_next` (cursor), `q` (substring search over
-  name/title/description/sql), `is_write` / `is_private` (booleans; invalid →
-  400 `"is_write must be 0 or 1"`), `source`, `owner_id`.
-- **Response** — 200:
-  `{"ok": true, "database", "database_color", "queries": [...], "next",
-  "next_url", "limit", "show_private_note",
-  "show_trusted_note", "query_list_path", "show_database",
-  "facets": [{title, items: [{label, count, href, active}]}],
-  "filters": {q, is_write, is_private, source, owner_id}}`.
-
-### GET /\<database\>/-/queries/analyze
-
-`QueryCreateAnalyzeView` (app.py:2667-2670; views/stored_queries.py:290-322).
-**GET only** despite being an "analyze" action — POST → 405.
-
-- **Permissions:** `execute-sql` then `store-query` (each denial → 403
-  `errors` JSON).
-- **Parameters:** only `sql` (others → 400 `"Invalid keys: ..."`).
-- **Response** — 200: `{"ok", "parameters", "analysis_error",
-  "analysis_rows": [{operation, database, table, required_permission,
-  source, allowed}], "has_sql", "analysis_is_write", "save_disabled"}`.
-
-### POST /\<database\>/-/queries/store
-
-`QueryStoreView` (app.py:2671-2674; views/stored_queries.py:325-388). GET on
-the same path renders the HTML create form.
-
-- **Permissions:** `execute-sql` + `store-query` (403 `errors` JSON).
-- **Request:** JSON bodies must wrap the fields:
-  `{"query": {...fields...}}`; form bodies pass fields flat. Fields:
-  `name` (required; `^[^/\.\n]+$`; conflicts with tables/views or existing
-  queries → 400), `sql` (required; read SQL must pass `validate_sql_select`;
-  write SQL must pass per-operation permission checks), `title`,
-  `description`, `hide_sql`, `fragment`, `parameters`/`params` (must exactly
-  match the SQL's named parameters; magic parameters rejected),
-  `is_private` (**default true**), and — only for write SQL —
-  `on_success_message`, `on_success_redirect`, `on_error_message`,
-  `on_error_redirect`. `is_write` is derived from SQL analysis;
-  `is_trusted`, `description_html` and `on_success_message_sql` cannot be
-  set through this API.
-- **Response:** JSON request → **201** `{"ok": true, "query": {...}}`; form
-  request → 302 redirect.
-
-### GET /\<database\>/\<query\>/-/definition
-
-`QueryDefinitionView` (app.py:2695-2698; views/stored_queries.py:391-408).
-
-- **Permission:** `view-query` (403 `["Permission denied"]`).
-- **Response:** 200 `{"ok": true, "query": {...}}`; 404
-  `["Query not found: x"]`.
-
-### GET/POST /\<database\>/\<query\>/-/edit
-
-`QueryEditView` (app.py:2699-2702) — **HTML form endpoint**
-(`has_json_alternate = False`), not part of the JSON API. Programmatic
-updates use `/-/update`.
-
-### POST /\<database\>/\<query\>/-/update
-
-`QueryUpdateView` (app.py:2703-2706; views/stored_queries.py:411-465).
-
-- **Permissions:** `update-query` (403 `need update-query`); trusted queries
-  → 403 `"Trusted queries cannot be updated using the API"`; changing `sql`
-  additionally requires `execute-sql`.
-- **Request:** `{"update": {...partial fields...}, "return"?: true}` — other
-  top-level keys → 400. Updatable fields: `sql`, `title`, `description`,
-  `hide_sql`, `fragment`, `parameters`/`params`, `is_private`, `on_*`
-  fields (write SQL only). New SQL is re-analyzed and `is_write` recomputed.
-- **Response:** 200 `{"ok": true}` (plus `query` with `return: true`); 404
-  `"Query not found: x"`.
-
-### POST /\<database\>/\<query\>/-/delete
-
-`QueryDeleteView` (app.py:2707-2710; views/stored_queries.py:594-644). GET
-renders an HTML confirmation page.
-
-- **Permission:** `delete-query` (403 `need delete-query`). Trusted
-  queries → 403 `"Trusted queries cannot be deleted using the API"`,
-  matching update.
-- **Response:** JSON request → 200 `{"ok": true}`; form → 302; 404
-  `"Query not found: x"`. No `confirm` field required (unlike table drop).
-
-### GET/POST /\<database\>/\<query-name\>(.json) — executing a stored query
-
-No dedicated route: the table route resolves the name, and on `TableNotFound`
-the request is dispatched to `QueryView` when a stored query matches
-(views/table.py:1698-1712). Covers both config-defined and API-stored
-queries.
-
-**GET (read queries)** — `QueryView.get` (views/database.py:695-1130):
-
-- **Permissions:** `view-query` (denied → `Forbidden` → 403 HTML). Read
-  queries then require `execute-sql` unless `is_trusted`. Write queries are
-  **not executed** on GET — JSON returns empty `rows`; HTML shows a POST form.
-- **Parameters:** each named `:param` is read from the query string (missing
-  → `""`); `_timelimit`; renderer options (`_shape`, `_nl`, `_json`,
-  `_json_infinity`); `_extra` (QUERY scope).
-- **Response:** `{"ok": true, "rows": [...], "truncated": false}` + extras.
-  SQL errors → 400 with `error` in the envelope.
-
-**POST (write queries)** — `QueryView.post` (views/database.py:574-693):
-
-- **Permissions:** `view-query`; then, unless `is_trusted`:
-  `execute-write-sql` on the database **plus** per-operation write
-  permissions (same table as `/-/execute-write`). Rejection → 403
-  `{"ok": false, "message": "...", "redirect": null}` for JSON clients.
-  Immutable database → 403.
-- **Body:** form-encoded or JSON `param=value` pairs (values coerced to
-  strings).
-- **JSON is returned when** `Accept: application/json`, `?_json=1`, or a
-  `_json` body field is present; otherwise 302 + flash message.
-- **Magic parameters** (`:_<prefix>_<key>`, resolved server-side; registered
-  via `register_magic_parameters`, default_magic_parameters.py):
-  `_now_epoch`, `_now_date_utc`, `_now_datetime_utc`, `_actor_<key>`,
-  `_random_chars_<N>`, `_cookie_<name>`, `_header_<name>` (underscores →
-  hyphens). User-stored queries cannot contain magic parameters — they are a
-  feature of config/trusted queries.
-- **Response:** success → 200
-  `{"ok": true, "message": "...", "redirect": "..."|null}` — `message`
-  honors `on_success_message_sql` / `on_success_message`, falling back to
-  `"Query executed"` or `"Query executed, N rows affected"`. SQL failure →
-  **400** canonical error (message honors `on_error_message`) plus a
-  `redirect` context key from `on_error_redirect`. Operation rejection
-  (`QueryWriteRejected`, e.g. VACUUM) → 403 canonical error plus
-  `redirect: null`.
-
----
-
-## Authentication and tokens
-
-### Bearer tokens (`dstok_`)
-
-Signed API tokens are sent as `Authorization: Bearer dstok_...`. The
-`actor_from_signed_api_token` hook (default_permissions/tokens.py:25-40)
-passes the token to `datasette.verify_token()`, which tries every handler
-registered via `register_token_handler`; the default is
-`SignedTokenHandler` (tokens.py:117-193).
-
-- **Format:** `dstok_` + itsdangerous-signed payload (namespace `token`)
-  containing `a` (actor id), `t` (creation Unix time), optional `d`
-  (duration seconds), optional `_r` (restrictions).
-- **Verification:** a `dstok_`-prefixed token that fails verification —
-  `allow_signed_tokens` off, invalid signature, missing/non-integer `t`,
-  malformed `d`, or expired — raises `TokenInvalid`, and the request fails
-  with **401**, the canonical error body and a
-  `WWW-Authenticate: Bearer error="invalid_token"` header (even if a valid
-  `ds_actor` cookie is also present). Tokens with prefixes no registered
-  handler recognizes are ignored (they may belong to an auth plugin). The
-  effective duration is `d` capped by `max_signed_tokens_ttl` (default 0 =
-  no cap; a non-zero setting also imposes a TTL on tokens without `d`).
-- **Resulting actor:** `{"id": <a>, "token": "dstok"}` plus `"_r"` and
-  `"token_expires"` when applicable.
-
-**Restrictions (`_r`)** (default_permissions/restrictions.py):
-
-- `"a"`: list of actions allowed on any resource
-- `"d"`: `{database_name: [actions]}`
-- `"r"`: `{database_name: {table_name: [actions]}}`
-
-Actions are stored as abbreviations when available (see appendix); checks
-accept either the full name or the abbreviation. Restrictions are an
-allowlist filter layered on top of normal permission resolution — a
-restricted token can never do more than its allowlist, and never more than
-the underlying actor could do anyway.
-
-### Token creation
-
-- **`/-/create-token`** is an HTML form endpoint only (see the instance
-  section) — there is no JSON API to mint tokens in this codebase.
-- Programmatic alternatives: the `datasette create-token` CLI command and
-  the `datasette.create_token()` Python API.
-- `/-/auth-token` is the one-time `--root` login mechanism, unrelated to API
-  tokens.
-
-### Cookie authentication
-
-Browser sessions use the signed `ds_actor` cookie (set by `/-/auth-token`,
-plugins, or login flows; cleared by `/-/logout`). API POSTs from browsers are
-subject to the cross-origin checks described in
-[CSRF](#csrf--cross-origin-protection).
-
----
-
-## Appendix: registered actions (permissions)
-
-From `datasette/default_actions.py` (registered via the `register_actions`
-hook). Token restrictions store the abbreviation when available.
-
-| Action | Abbr | Resource level | Notes |
-|---|---|---|---|
-| `view-instance` | `vi` | global | |
-| `permissions-debug` | `pd` | global | gates the debug endpoints |
-| `debug-menu` | `dm` | global | UI only |
-| `view-database` | `vd` | database | |
-| `view-database-download` | `vdd` | database | `also_requires="view-database"` |
-| `execute-sql` | `es` | database | `also_requires="view-database"`; denied when the `default_allow_sql` setting is off |
-| `execute-write-sql` | `ews` | database | `also_requires="view-database"` |
-| `create-table` | `ct` | database | |
-| `store-query` | `sq` | database | `also_requires="execute-sql"` |
-| `view-table` | `vt` | table | |
-| `insert-row` | `ir` | table | |
-| `delete-row` | `dr` | table | |
-| `update-row` | `ur` | table | |
-| `alter-table` | `at` | table | |
-| `set-column-type` | `sct` | table | |
-| `drop-table` | `dt` | table | |
-| `view-query` | `vq` | query | default-allow; private queries restricted to their owner |
-| `update-query` | `uq` | query | query owner allowed by default (source=`user` only) |
-| `delete-query` | `dq` | query | query owner allowed by default (source=`user` only) |
diff --git a/stable-api-recommendations.md b/stable-api-recommendations.md
deleted file mode 100644
index 0d817612..00000000
--- a/stable-api-recommendations.md
+++ /dev/null
@@ -1,469 +0,0 @@
-# Datasette 1.0 Stable API — Consistency and Completeness Review
-
-This review is based on `existing-api.md`, which documents the JSON API as
-actually implemented in this codebase (`1.0a35`), derived from source. The
-goal here is to identify everything that should be made consistent, fixed, or
-explicitly scoped out **before** the 1.0 stability promise takes effect —
-because after 1.0, every inconsistency below becomes a compatibility
-commitment.
-
-Findings are grouped by theme. Each carries a priority:
-
-- **P1 — should block 1.0**: breaking to fix later, or a correctness/security
-  concern.
-- **P2 — strongly recommended**: fixable later only via awkward additive
-  changes.
-- **P3 — nice to have / documentation decision**: can be resolved by
-  documenting the behavior as intentional.
-
----
-
-## 1. Error responses: four shapes is three too many (P1) — ✅ IMPLEMENTED
-
-> **Status:** implemented. All four shapes now delegate to a shared
-> `error_body()` helper (`datasette/utils/__init__.py`) producing
-> `{"ok": false, "error": "<joined>", "errors": [...], "status": <int>}`.
-> The `title` key is no longer emitted in JSON; the bare `{"error": ...}`
-> debug-endpoint shape is gone; `_shape=object` misuse now returns HTTP 400
-> (part of §1b). Covered by `tests/test_error_shape.py` and documented in
-> the "Error responses" section of `docs/json_api.rst`. §1a (`Forbidden` →
-> JSON) and §1b (write canned-query 200) are now also implemented. Still
-> open from this section's sub-items: the §1c status outliers.
-
-The API currently produces four distinct JSON error shapes depending on which
-internal layer generates the error:
-
-| Shape | Producer | Example endpoints |
-|---|---|---|
-| `{"ok": false, "error", "status", "title"}` | exception handler (handle_exception.py:50-53) | 404s and `DatasetteError`s on any `.json` path |
-| `{"ok": false, "errors": [...]}` | `_error()` helper (views/base.py:183-184) | all write endpoints, stored-query endpoints, execute-write |
-| `{"ok": false, "error", "rows": [], "truncated": false}` | JSON renderer (renderer.py:52-56) | SQL errors on table/query reads |
-| `{"error": "..."}` (no `ok`) | permission debug views (views/special.py) | `/-/allowed`, `/-/rules`, `/-/check`, POST `/-/permissions` |
-
-Additionally, write canned queries report failure via a **fifth** vocabulary:
-`{"ok": false, "message": ..., "redirect": ...}` with HTTP **200**
-(views/database.py:678-690).
-
-A 1.0 client cannot write a single error handler today. **Recommendation:**
-pick one canonical error object — the singular/plural tension is easiest to
-resolve as:
-
-```json
-{"ok": false, "error": "human-readable summary", "errors": ["detail", "..."], "status": 400}
-```
-
-where `errors` is optional and `error` is always present — and route every
-error path through it (including the `forbidden` and `handle_exception`
-defaults). At minimum, eliminate the bare `{"error": ...}` shape and the
-`status`/`title` keys nobody else emits (`title` is a template-rendering
-concern that leaked into the API).
-
-### 1a. `Forbidden` returns an HTML 403 to JSON clients (P1) — ✅ IMPLEMENTED
-
-> **Status:** implemented — the default `forbidden()` hook now returns the
-> canonical JSON error for requests whose path ends in `.json` or that send
-> `Accept: application/json` / `Content-Type: application/json`.
-
-Read endpoints that deny access via `ensure_permission`/`check_visibility`
-raise `Forbidden`, and the default `forbidden()` hook renders an **HTML error
-page even for `.json` requests** (forbidden.py:4-19, app.py:2895-2904). So:
-
-- `GET /db/table.json` without `view-table` → 403 **HTML**
-- `POST /db/table/-/insert` without `insert-row` → 403 **JSON**
-
-A JSON client gets unparseable output precisely when it most needs a
-machine-readable answer. **Recommendation:** the default forbidden handler
-must return the canonical JSON error when the path ends in `.json` or the
-request prefers JSON, mirroring `handle_exception`.
-
-### 1b. Errors that return HTTP 200 (P1) — ✅ IMPLEMENTED
-
-> **Status:** implemented. `_shape=object` misuse returns 400 (done with
-> §1), and write canned-query SQL failures now return **400** with the
-> canonical error shape (plus the `redirect` context key); the
-> `QueryWriteRejected` 403 branch also uses the canonical shape.
-
-- `_shape=object` on a query or pk-less table → `{"ok": false, "error":
-  "_shape=object is only available on tables"}` with **200**
-  (renderer.py:73-90), while an unknown `_shape` value returns **400**
-  (renderer.py:101-108). Same class of error, different status.
-- Write canned-query SQL failure → **200** `{"ok": false, "message": ...}`
-  (views/database.py:683-690), while the equivalent failure on
-  `/-/execute-write` returns **400**.
-
-**Recommendation:** all `ok: false` responses should carry a 4xx/5xx status.
-(`/-/execute-write/analyze` returning `ok: false` with 200 for "analysis
-completed, SQL is invalid" is defensible but should then not reuse the `ok`
-key — see §2.)
-
-### 1c. Wrong-status outliers (P2) — ✅ IMPLEMENTED
-
-- ~~Row **delete** write failures return **500** (views/row.py:757) while row
-  **update** write failures return **400** (views/row.py:832-835). Same
-  failure class, different status; pick 400 (or 409 for constraint
-  violations) for both.~~ ✅ **Done** — delete now returns 400, matching
-  update and the rest of the write API.
-- ~~Invalid or expired bearer tokens silently degrade the request to anonymous,
-  so clients see a 403 permission error (or worse, anonymous-permitted data)
-  rather than a 401 (tokens.py:147-193). For 1.0, a malformed/expired
-  `Authorization: Bearer dstok_...` header should produce **401** with a
-  distinguishable error, so clients can tell "renew your token" apart from
-  "you lack permission".~~ ✅ **Done** — token handlers can raise
-  `TokenInvalid`; Datasette responds 401 with the canonical body and a
-  `WWW-Authenticate: Bearer error="invalid_token"` header. Unrecognized
-  token prefixes still fall through to anonymous so auth plugins keep
-  working.
-
----
-
-## 2. Success envelope: `ok` is not universal, arrays are not extensible (P1/P2) — ✅ IMPLEMENTED (§2a-2c open)
-
-> **Status:** recommendations 1-3 are implemented. Every JSON-object
-> success response now includes `"ok": true` (`JsonDataView` injects it for
-> dict responses; homepage, jump, schema, permission-debug and autocomplete
-> views set it explicitly), and the three top-level-array endpoints now
-> return objects: `/-/plugins` → `{"ok": true, "plugins": [...]}`,
-> `/-/databases` → `{"ok": true, "databases": [...]}`, `/-/actions` →
-> `{"ok": true, "actions": [...]}`. Covered by
-> `tests/test_success_envelope.py`. The sub-findings §2a (collection
-> representations), §2b (`_extra`/`_shape` coverage) and §2c (count
-> truncation) remain open.
-
-Endpoints disagree about the success envelope:
-
-- **Have `ok: true`:** table/row/query reads, database view, all write
-  endpoints, stored-query endpoints, `/-/allowed`-style debug data.
-- **No `ok` key:** `/-/versions`, `/-/settings`, `/-/config`, `/-/threads`,
-  `/-/actor`, `/-/jump`, `/-/schema` variants (`{"database", "schema"}`,
-  `{"schemas": [...]}`), table `/-/schema.json`, `/-/autocomplete`
-  (`{"rows": []}`), homepage `/.json`.
-- **Top-level JSON arrays:** `/-/plugins`, `/-/databases`, `/-/actions`
-  (app.py:2247-2304). A top-level array can never grow a sibling key
-  (pagination, warnings, `ok`) without a breaking change.
-
-**Recommendations:**
-
-1. (P1) Wrap the three array endpoints in objects before 1.0:
-   `{"ok": true, "plugins": [...]}` etc. This is the single cheapest
-   future-proofing fix in this list.
-2. (P2) Add `ok: true` to every JSON-object success response, or explicitly
-   document that `ok` only exists on data endpoints. Half-consistency is the
-   worst outcome.
-3. (P2) `/db/-/schema.json` (`{"database", "schema"}`) and
-   `/db/table/-/schema.json` should match the envelope style of their sibling
-   endpoints (they are also the only data endpoints whose 404 uses the
-   exception shape but whose success has no `ok`).
-
-### 2a. Collection representations disagree (P2)
-
-- ~~Homepage `/.json` returns `databases` as an **object keyed by name**
-  (index.py:147-161); `/-/databases.json` returns an **array**; the database
-  page returns `tables` as an array. Choose arrays-of-objects everywhere
-  (objects-keyed-by-name break when names need ordering or pagination).~~
-  ✅ **Done** — the homepage returns a list, matching `/-/databases.json`.
-  The homepage JSON remains deliberately undocumented.
-- ~~Insert/upsert with `return: true` respond with `rows` (plural, list); row
-  update with `return: true` responds with `row` (singular, object)
-  (views/row.py:837-844). Pick one (`rows` everywhere, even for one row,
-  matches the read API).~~ ✅ **Done** — row update now returns
-  `rows: [{...}]`.
-
-### 2b. `_extra`/`_shape` support is uneven (P2) — partially implemented
-
-> **Status:** unknown `_extra` names on data formats now return 400
-> `Unknown _extra: <names>` (HTML pages still ignore them). Extending
-> extras/shaping to database/instance scope remains open.
-
-The extras system (`?_extra=`, scope-registered) is the 1.0 mechanism for
-response shaping — but it only exists on table, row and query endpoints. The
-database view builds JSON by hand and supports **neither `_extra` nor
-`_shape`** (views/database.py:189-212); the homepage likewise. Either extend
-extras to database/instance scope before 1.0 or document clearly that shaping
-is a table/row/query feature. Also decide the contract for **unknown
-`_extra` names, which are currently silently ignored** (extras.py:116-122) —
-silent ignoring means typos return the default payload with no signal;
-recommend a 400 or a `warnings` key.
-
-### 2c. Count truncation is invisible in JSON (P2) — ✅ IMPLEMENTED
-
-> **Status:** implemented — a public `count_truncated` extra now exists and
-> is implicitly included whenever `count` is requested.
-
-The `count` extra is computed with a `limit 10001` subquery, so `count:
-10001` actually means "at least 10001" — the `count_truncated` flag exists
-but only in the HTML template context, never in JSON (views/table.py:
-2334-2337). Expose it (e.g. make `count` be `null` + add `count_estimate`,
-or add `count_truncated` to the JSON) before clients start trusting the
-number.
-
----
-
-## 3. Pagination: three mechanisms, two contracts (P2) — partially implemented
-
-> **Status:** `next_url` now accompanies `next` in the default table JSON
-> keys (previously it required `?_extra=next_url`), so every response with
-> a `next` token also carries the ready-to-follow URL. Pagination tokens
-> are deliberately left undocumented as to their internal structure.
-> `_size` is now the single page-size parameter with uniform table-style
-> semantics everywhere: query lists accept `max` and 400 on out-of-range
-> values (previously silently clamped), and the `/-/allowed` and
-> `/-/rules` debug endpoints renamed `page`/`page_size` to
-> `_page`/`_size` with the same validation (400 instead of silent
-> capping at 200). `has_more` has been **removed** from the query-list
-> JSON — `next: null` is the single end-of-results signal everywhere,
-> keeping default response keys minimal (`total` remains a debug-endpoint
-> nicety). Fixing this also uncovered and fixed a bug where the query
-> list's JSON `next_url` pointed at the HTML page (it dropped the `.json`
-> extension) and was relative where the table `next_url` is absolute.
-> §3 is now fully resolved.
-
-| Endpoint | Mechanism | Token | Extras |
-|---|---|---|---|
-| Table `.json` | keyset | tilde-encoded pk/sort values in `_next` | `next` always in body, `next_url` via `_extra`, `Link: rel=next` header |
-| SQL view `.json` | **offset** | integer in the same `_next` parameter | same envelope |
-| `/-/queries` lists | keyset | cursor in `_next` | `next`, `next_url`, **`has_more`** in body |
-| `/-/allowed`, `/-/rules` | **page numbers** | `page`/`page_size` | `total`, `next_url`, `previous_url` |
-
-Concerns:
-
-1. The same `_next` parameter means "start after key" on tables but "row
-   offset" on views. Offset pagination over views is also O(n) and skews
-   under concurrent writes. If unifiable, unify; if not, document loudly.
-2. `has_more` exists on query lists but not table pages; `total` exists on
-   debug endpoints but not elsewhere. Standardize the pagination block
-   (suggest: `next`, `next_url` — nullable — everywhere; treat `has_more` as
-   `next != null`).
-3. Page-size parameters: `_size` (default 100, `max` keyword allowed) on
-   tables; `_size` (default 50 JSON, clamped 1–1000, no `max` keyword) on
-   query lists; `page_size` (default 50, silently capped at 200) on debug
-   endpoints. Align names, defaults and the cap behavior (silent capping vs
-   400) as far as practical.
-
----
-
-## 4. HTTP semantics (P2)
-
-- ~~**201 vs 200:** insert → 201, upsert → 200 (views/table.py:1194), create
-  table → 201, store query → 201. Insert-201/upsert-200 is defensible
-  (upsert may not create) but it is undocumented subtlety; state it, or
-  return 200 for both with an explicit `created` count.~~ ✅ **Done** —
-  documented as deliberate in the upsert docs.
-- **Destructive-action confirmation is asymmetric:** table drop requires
-  `{"confirm": true}` and has a preview response (views/table.py:1346-1365);
-  row delete executes immediately and ignores the body; query delete
-  executes immediately. Decide the 1.0 rule (suggestion: confirmation only
-  for schema-destroying operations, i.e. keep as is — but document it as a
-  deliberate contract).
-- ~~**Content-type enforcement is inconsistent:** `/-/insert`, `/-/upsert`,
-  `/-/alter`, `/-/set-column-type` demand `Content-Type: application/json`
-  (400 otherwise); `/-/create` parses the body as JSON regardless of
-  content type; execute-write and the query CRUD endpoints accept both JSON
-  and form encodings. Pick one rule for JSON-only endpoints.~~ ✅ **Done**
-  — the lenient rule won: JSON-only write endpoints parse the body as JSON
-  regardless of `Content-Type` (CSRF protection comes from the
-  cross-origin header checks, not content types). This also fixed a 500 on
-  insert when the header was absent entirely.
-- **JSON-vs-HTML negotiation on POST differs per endpoint:** execute-write
-  and canned queries key off `Accept: application/json` / a `_json` body
-  field; the write API keys off nothing (always JSON); query store keys off
-  request content type. A single documented rule ("responses are JSON if the
-  request body was JSON or `Accept: application/json`") would cover all of
-  them.
-- **Endpoints named like actions but served over GET:**
-  `/-/queries/analyze`, `/-/execute-write/analyze`,
-  `/-/foreign-key-suggestions`, `/-/query/parameters` are all GET (correct,
-  they are reads) — fine, but `analyze` under a POST-shaped path invites
-  wrong calls; make sure 405 responses for POST on these return the JSON 405
-  shape (they do only when the path ends `.json` or content type is JSON —
-  a JSON POST to `/-/queries/analyze` gets JSON, a form POST gets text).
-
----
-
-## 5. Naming and parameter conventions (P2/P3)
-
-- ~~**`params` and `parameters` are duplicate keys** in every stored-query
-  object (stored_queries.py:55-80). Delete one before 1.0 (suggest keeping
-  `parameters`; the write side already accepts both on input).~~
-  ✅ **Done** — output objects carry only `parameters` (matching
-  `/-/query/parameters` and the analyze endpoints); `params` remains an
-  accepted input alias for API creation and `datasette.yaml` config.
-- **Three names for the same concept across error/message payloads:**
-  `error`, `errors`, `message`. See §1.
-- ~~**Boolean query parameters have at least three grammars:** `_nl=on`,
-  `_labels=on/off`, `?all=1`, `is_write=1|0|true|false|t|f|yes|no|on|off`,
-  `_nocount=1`. Adopt one accepted set (the query-list parser at
-  query_helpers.py:81-94 is a good candidate) and apply it everywhere.~~
-  ✅ **Documented** — the JSON API docs state the canonical grammar
-  (`on/true/1`, `off/false/0`), which `value_as_boolean` already accepts
-  everywhere it is used.
-- ~~**`.jsono`** survives on the homepage route (identical output to `.json`)
-  and as a row-view redirect. Remove it at 1.0; it is pure legacy.~~
-  ✅ Removed: the homepage routes only accept `.json` and the row-view
-  redirect is gone.
-- **`_json` is overloaded:** on GET it is a renderer option naming a column
-  to parse as JSON (repeatable); on canned-query POST a `_json` body field
-  forces a JSON response. Two unrelated meanings for one name.
-- The reserved `/-/` namespace is applied consistently across routes — this
-  is in good shape. The one gap: table names matching `^-$`-adjacent shapes
-  are protected by tilde-encoding; keep a test asserting `/-/` can never be
-  shadowed by user data.
-
----
-
-## 6. Permissions and security consistency (P1/P2)
-
-- ~~**(P1) `/-/databases.json` ignores per-database permissions** — it lists
-  every attached database (name, path on disk, size) to any actor holding
-  `view-instance` (app.py:2157-2169), while the homepage and every other
-  endpoint filter by `view-database`. On a public instance with private
-  databases this leaks filesystem paths and database names. Filter it, or
-  gate it behind `permissions-debug`.~~ ✅ **Done** — the endpoint now
-  filters through `allowed_resources("view-database", actor)`.
-- ~~**(P2) `/db/-/schema` checks existence before permission**
-  (views/special.py:1308-1317): an actor without `view-database` can
-  distinguish "database exists" (403) from "does not exist" (404).
-  Standardize on permission-check-first (as the table view does) so
-  unauthorized actors get a uniform response.~~ ✅ **Done** — permission is
-  checked first; the table schema view also now 404s (instead of a 500
-  KeyError) for an unknown database.
-- ~~**(P2) `/-/threads` exposes runtime internals** (thread idents, asyncio
-  task reprs including file paths) behind only `view-instance`. Consider
-  `permissions-debug`, alongside `/-/actions` which already requires it.~~
-  ✅ **Done** — `/-/threads` now requires `permissions-debug`.
-- ~~**(P3) `/-/config` redaction is substring-based** on six key names
-  (app.py:2502-2505); plugins storing secrets under other names leak. Worth
-  a note in plugin authoring docs plus a `redact_keys` plugin hook.~~
-  ✅ **Documented** — the plugin secrets docs now advise naming keys to
-  match the redaction substrings (a `redact_keys` hook remains a possible
-  future addition).
-- **(P3) Database-level checks on `/-/create`** (insert-row/update-row
-  checked against `DatabaseResource`, not the about-to-exist table —
-  table_create_alter.py:819-856) vs table-level checks on `/-/insert`.
-  Correct by necessity, but document that a token restricted to
-  table-level `ir` cannot use `/-/create` with rows.
-
----
-
-## 7. Completeness gaps for a 1.0 JSON API (P2/P3)
-
-1. **(P2) No JSON API to create tokens.** `/-/create-token` is an HTML form
-   only (`has_json_alternate = False`, form-encoded POST). Any automation
-   that wants to mint scoped tokens must shell out to `datasette
-   create-token`. An intentional JSON mode (actor-authenticated, same
-   restriction vocabulary) rounds out the write API story — or explicitly
-   document token minting as CLI/Python-only.
-2. **(P2) Row JSON cannot expand foreign-key labels.** `_labels` works on
-   table JSON but is silently ignored on row JSON (views/row.py:445-475
-   expands only for HTML). Either support it or return 400 for unsupported
-   parameters; silent ignoring is the worst option (see also §2b on unknown
-   `_extra` values).
-3. **(P2) No machine-readable "which write features does this instance/table
-   support" endpoint.** Clients must probe (`/-/insert` on an immutable
-   database → 403). The API explorer computes exactly this data for HTML
-   (views/special.py:863-990); exposing it as JSON would let clients degrade
-   gracefully. (`/-/allowed.json` covers the permission half already.)
-4. **(P3) Table list pagination.** `/db.json` inlines all tables (with
-   counts) and the homepage truncates to 5 per database; a 10,000-table
-   database has no paginated table listing. Acceptable for 1.0 if
-   documented; the internal catalog tables would support a real endpoint
-   later.
-5. **(P3) `Link: rel=next` header** exists on table JSON only. Harmless, but
-   either add it to the other paginated endpoints or drop it from the
-   contract (`Access-Control-Expose-Headers: Link` suggests it is meant to
-   be part of the API).
-
----
-
-## 8. Behavior that looks like a bug and should be resolved before freezing
-
-1. ~~**Trusted queries: update is blocked, delete is not.**
-   `QueryUpdateView` rejects `is_trusted` queries with 403
-   (stored_queries.py:426-427) but `QueryDeleteView.post` never checks
-   `is_trusted` — an actor with `delete-query` can delete a config-defined
-   trusted query via the API (it will resync on restart, making the
-   behavior confusing rather than catastrophic). Align delete with update.~~
-   ✅ **Done** — both the POST endpoint and the HTML confirmation page now
-   return 403 `"Trusted queries cannot be deleted using the API"`;
-   `datasette.remove_query()` remains available for internal use.
-2. ~~**GET `/db/-/query` with no `?sql=` returns 200 `{"ok": true, "rows":
-   []}`** while `.csv` on the same request returns 400 `"?sql= is
-   required"`. The JSON behavior masks caller bugs; return 400 on both.~~
-   ✅ **Done** — all data formats now return 400; the HTML SQL editor page
-   is unchanged.
-3. ~~**`_shape=object` HTTP 200 error** (§1b) — almost certainly unintended.~~
-   ✅ Done — now 400 (fixed with §1b).
-4. ~~**Row delete 500** (§1c) — inconsistent with every sibling endpoint.~~
-   ✅ Done — now 400.
-5. ~~**The "SQL Interrupted" error embeds an HTML fragment in the JSON `error`
-   value** (views/database.py:805-820). Error strings in the JSON API should
-   be plain text.~~ ✅ **Done** — `DatasetteError` gained a `plain_message`
-   used for JSON responses; the HTML error page keeps the rich version with
-   the SQL textarea. §8 is now fully resolved.
-
----
-
-## 9. Define stability tiers explicitly (P1 — documentation, not code) — ✅ IMPLEMENTED
-
-> **Status:** implemented. Undocumented JSON endpoints self-describe with
-> an `"unstable"` marker key, and `docs/json_api.rst` now opens with an
-> "API stability" section (`json_api_stability`) declaring the 1.x
-> promise: documented endpoints/keys are stable with additive-only
-> changes, pagination tokens are opaque, the error format and token
-> restriction semantics are stable, and the exempt tiers (marker-key
-> endpoints, debug/support endpoints, explicitly-unstable keys) are
-> listed. Cross-referenced from the introspection and permission-debug
-> docs.
-
-Not everything under `/-/` can or should carry a 1.0 guarantee. Recommend
-shipping 1.0 with an explicit three-tier contract, per endpoint:
-
-- **Stable (semver-protected):** table/row/query reads (`.json`, `_shape`,
-  `_extra` public names, filters, pagination tokens as opaque strings), the
-  write API (`/-/insert`, `/-/upsert`, `/-/alter`, `/-/drop`,
-  `/-/set-column-type`, row `/-/update`, `/-/delete`, `/-/create`,
-  `/-/execute-write`), stored-query CRUD + execution, `/-/versions`,
-  `/-/plugins`, `/-/settings`, `/-/actor`, `/-/databases`, schema endpoints,
-  token format & restriction semantics (`_r` abbreviations are wire format
-  now — they are stored inside issued tokens and cannot change silently).
-- **Unstable/debug (documented as exempt):** `/-/threads`, `/-/actions`,
-  `/-/permissions`, `/-/allowed`, `/-/rules`, `/-/check`, `/-/messages`,
-  `/-/allow-debug`, `/-/patterns`, `/-/debug/autocomplete`, the `debug` and
-  `request` extras (the `debug` extra already self-describes as unstable),
-  `/-/api` and `/-/jump` (UI support endpoints), `/-/autocomplete` and
-  `/-/fragment` (UI support), `/-/foreign-key-suggestions` and
-  `/-/foreign-key-targets` (heuristic outputs).
-- **Internal:** anything HTML-only (`/-/edit`, `/-/create-token`,
-  `/-/logout`, `/-/auth-token`).
-
-Two details make tiering urgent rather than optional:
-
-- **Extras are enumerable by clients** (`?_extra=extras` self-describes the
-  registry), so every public extra name is de-facto API. Mark each extra
-  stable or unstable in its class definition and surface that in the
-  `extras` output.
-- **Pagination tokens leak implementation** (tilde-encoded pk values for
-  tables, plain integers for views). Declare them opaque now so the view
-  token can become keyset later without a "breaking" change.
-
----
-
-## 10. Summary of P1 items (the pre-1.0 checklist)
-
-1. ~~One canonical JSON error shape; retire the other three (§1).~~ ✅ Done.
-2. ~~`Forbidden` → JSON 403 for JSON requests (§1a).~~ ✅ Done.
-3. ~~No `ok: false` with HTTP 200 (§1b: `_shape=object`, write canned-query
-   SQL errors).~~ ✅ Done.
-4. ~~Wrap `/-/plugins`, `/-/databases`, `/-/actions` top-level arrays in
-   objects (§2).~~ ✅ Done.
-5. ~~Filter `/-/databases.json` by `view-database` or gate it behind
-   `permissions-debug` (§6).~~ ✅ Done.
-6. ~~401 (not silent-anonymous) for invalid/expired bearer tokens (§1c).~~
-   ✅ Done.
-7. ~~Publish explicit stability tiers, including extras and pagination-token
-   opacity (§9).~~ ✅ Done.
-8. Resolve the looks-like-a-bug list (§8), especially ~~trusted-query delete
-   and row-delete 500~~ (both done).
-
-Everything in P2 is worth doing now because each item is breaking-to-fix
-later; each P3 can be resolved by a sentence of documentation declaring the
-current behavior intentional.

From 8b159144a58992f8fe1f5a0489a3566f57e8d20c Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:48:49 +0000
Subject: [PATCH 364/386] Add Response.error() for JSON errors in the standard
 format

Response.error(messages, status=400) builds a JSON error response in
Datasette's standard error format, alongside Response.json/html/text.
messages can be a single string or a list. All internal error response
construction now uses it - the private views.base._error() helper is
gone and the verbose Response.json(error_body(...), status=...) sites
are converted. error_body() remains for the cases that merge the error
keys into a larger payload (the JSON renderer, handle_exception and the
permission debug payload builders).

Since Response is public plugin API, plugins that build JSON endpoints
now have an obvious way to return errors in the canonical shape.
Documented in the internals documentation, including the guidance to
raise Forbidden/NotFound/BadRequest/DatasetteError instead when the
error should content-negotiate.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/app.py                      |  5 +-
 datasette/forbidden.py                |  4 +-
 datasette/utils/asgi.py               | 14 ++++-
 datasette/views/base.py               |  9 +---
 datasette/views/execute_write.py      | 16 +++---
 datasette/views/row.py                | 32 ++++++------
 datasette/views/special.py            | 18 ++-----
 datasette/views/stored_queries.py     | 70 ++++++++++++++-----------
 datasette/views/table.py              | 74 ++++++++++++++-------------
 datasette/views/table_create_alter.py | 50 +++++++++---------
 docs/internals.rst                    |  6 ++-
 tests/test_internals_response.py      | 24 +++++++++
 12 files changed, 182 insertions(+), 140 deletions(-)

diff --git a/datasette/app.py b/datasette/app.py
index 463c9be2..9c7e768b 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -113,7 +113,6 @@ from .utils import (
     detect_json1,
     add_cors_headers,
     display_actor,
-    error_body,
     escape_css_string,
     escape_sqlite,
     find_spatialite,
@@ -2958,9 +2957,7 @@ class DatasetteRouter:
         headers = {"www-authenticate": 'Bearer error="invalid_token"'}
         if self.ds.cors:
             add_cors_headers(headers)
-        response = Response.json(
-            error_body([str(exception)], 401), status=401, headers=headers
-        )
+        response = Response.error([str(exception)], 401, headers=headers)
         await response.asgi_send(send)
 
     async def handle_404(self, request, send, exception=None):
diff --git a/datasette/forbidden.py b/datasette/forbidden.py
index 3a81ac4f..91b1ff96 100644
--- a/datasette/forbidden.py
+++ b/datasette/forbidden.py
@@ -1,5 +1,5 @@
 from datasette import hookimpl, Response
-from .utils import add_cors_headers, error_body
+from .utils import add_cors_headers
 
 
 @hookimpl(trylast=True)
@@ -13,7 +13,7 @@ def forbidden(datasette, request, message):
             headers = {}
             if datasette.cors:
                 add_cors_headers(headers)
-            return Response.json(error_body(message, 403), status=403, headers=headers)
+            return Response.error(message, 403, headers=headers)
         return Response.html(
             await datasette.render_template(
                 "error.html",
diff --git a/datasette/utils/asgi.py b/datasette/utils/asgi.py
index 7777308f..610b86f2 100644
--- a/datasette/utils/asgi.py
+++ b/datasette/utils/asgi.py
@@ -1,6 +1,6 @@
 import json
 from typing import Optional
-from datasette.utils import MultiParams, calculate_etag, sha256_file
+from datasette.utils import MultiParams, calculate_etag, error_body, sha256_file
 from datasette.utils.multipart import (
     parse_form_data,
     MultipartParseError,
@@ -575,6 +575,18 @@ class Response:
             content_type="application/json; charset=utf-8",
         )
 
+    @classmethod
+    def error(cls, messages, status=400, headers=None):
+        """
+        A JSON error response using Datasette's standard error format.
+
+        messages can be a single string or a list of strings. For errors
+        that should content-negotiate between JSON and HTML, raise
+        Forbidden, NotFound, BadRequest or DatasetteError instead and let
+        Datasette's error handling hooks build the response.
+        """
+        return cls.json(error_body(messages, status), status=status, headers=headers)
+
     @classmethod
     def redirect(cls, path, status=302, headers=None):
         headers = headers or {}
diff --git a/datasette/views/base.py b/datasette/views/base.py
index 88d16753..66e14a6d 100644
--- a/datasette/views/base.py
+++ b/datasette/views/base.py
@@ -5,7 +5,6 @@ import sys
 from datasette.utils.asgi import Request
 from datasette.utils import (
     add_cors_headers,
-    error_body,
     EscapeHtmlWriter,
     InvalidSql,
     LimitedWriter,
@@ -53,7 +52,7 @@ class View:
             request.path.endswith(".json")
             or request.headers.get("content-type") == "application/json"
         ):
-            response = Response.json(error_body("Method not allowed", 405), status=405)
+            response = Response.error("Method not allowed", 405)
         else:
             response = Response.text("Method not allowed", status=405)
         return response
@@ -92,7 +91,7 @@ class BaseView:
             request.path.endswith(".json")
             or request.headers.get("content-type") == "application/json"
         ):
-            response = Response.json(error_body("Method not allowed", 405), status=405)
+            response = Response.error("Method not allowed", 405)
         else:
             response = Response.text("Method not allowed", status=405)
         return response
@@ -180,10 +179,6 @@ class BaseView:
         return view
 
 
-def _error(messages, status=400):
-    return Response.json(error_body(messages, status), status=status)
-
-
 async def stream_csv(datasette, fetch_data, request, database):
     kwargs = {}
     stream = request.args.get("_stream")
diff --git a/datasette/views/execute_write.py b/datasette/views/execute_write.py
index 6806e69d..dd35b127 100644
--- a/datasette/views/execute_write.py
+++ b/datasette/views/execute_write.py
@@ -5,7 +5,7 @@ from datasette.resources import DatabaseResource
 from datasette.utils import UNSTABLE_API_MESSAGE, sqlite3
 from datasette.utils.asgi import Response
 
-from .base import BaseView, _error
+from .base import BaseView
 from .database import display_rows as display_query_rows
 from .query_helpers import (
     QueryValidationError,
@@ -348,7 +348,7 @@ class ExecuteWriteView(BaseView):
         )
         if not db.is_mutable:
             return _block_framing(
-                _error(
+                Response.error(
                     ["Cannot execute write SQL because this database is immutable."],
                     403,
                 )
@@ -367,10 +367,10 @@ class ExecuteWriteView(BaseView):
             actor=request.actor,
         ):
             return _block_framing(
-                _error(["Permission denied: need execute-write-sql"], 403)
+                Response.error(["Permission denied: need execute-write-sql"], 403)
             )
         if not db.is_mutable:
-            return _block_framing(_error(["Database is immutable"], 403))
+            return _block_framing(Response.error(["Database is immutable"], 403))
 
         data = {}
         is_json = request.headers.get("content-type", "").startswith("application/json")
@@ -384,7 +384,7 @@ class ExecuteWriteView(BaseView):
             )
         except QueryValidationError as ex:
             if _wants_json(request, is_json, data):
-                return _block_framing(_error([ex.message], ex.status))
+                return _block_framing(Response.error([ex.message], ex.status))
             if ex.flash:
                 self.ds.add_message(request, ex.message, self.ds.ERROR)
             return await self._render_form(
@@ -405,7 +405,7 @@ class ExecuteWriteView(BaseView):
         except sqlite3.DatabaseError as ex:
             message = str(ex)
             if wants_json:
-                return _block_framing(_error([message], 400))
+                return _block_framing(Response.error([message], 400))
             return await self._render_form(
                 request,
                 db,
@@ -488,13 +488,13 @@ class ExecuteWriteAnalyzeView(BaseView):
             actor=request.actor,
         ):
             return _block_framing(
-                _error(["Permission denied: need execute-write-sql"], 403)
+                Response.error(["Permission denied: need execute-write-sql"], 403)
             )
 
         invalid_keys = set(request.args) - {"sql"}
         if invalid_keys:
             return _block_framing(
-                _error(
+                Response.error(
                     ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
                     400,
                 )
diff --git a/datasette/views/row.py b/datasette/views/row.py
index d9a3deeb..c90a3bbe 100644
--- a/datasette/views/row.py
+++ b/datasette/views/row.py
@@ -12,7 +12,7 @@ from datasette.utils.asgi import NotFound, Forbidden, PayloadTooLarge, Response
 from datasette.database import QueryInterrupted
 from datasette.events import UpdateRowEvent, DeleteRowEvent
 from datasette.resources import TableResource
-from .base import BaseView, DatasetteError, _error, stream_csv
+from .base import BaseView, DatasetteError, stream_csv
 from datasette.utils import (
     add_cors_headers,
     await_me_maybe,
@@ -715,11 +715,13 @@ async def _resolve_row_and_check_permission(datasette, request, permission):
     try:
         resolved = await datasette.resolve_row(request)
     except DatabaseNotFound as e:
-        return False, _error(["Database not found: {}".format(e.database_name)], 404)
+        return False, Response.error(
+            ["Database not found: {}".format(e.database_name)], 404
+        )
     except TableNotFound as e:
-        return False, _error(["Table not found: {}".format(e.table)], 404)
+        return False, Response.error(["Table not found: {}".format(e.table)], 404)
     except RowNotFound as e:
-        return False, _error(["Record not found: {}".format(e.pk_values)], 404)
+        return False, Response.error(["Record not found: {}".format(e.pk_values)], 404)
 
     # Ensure user has permission to delete this row
     if not await datasette.allowed(
@@ -727,7 +729,7 @@ async def _resolve_row_and_check_permission(datasette, request, permission):
         resource=TableResource(database=resolved.db.name, table=resolved.table),
         actor=request.actor,
     ):
-        return False, _error(["Permission denied"], 403)
+        return False, Response.error(["Permission denied"], 403)
 
     return True, resolved
 
@@ -752,7 +754,7 @@ class RowDeleteView(BaseView):
         try:
             await resolved.db.execute_write_fn(delete_row, request=request)
         except Exception as e:
-            return _error([str(e)], 400)
+            return Response.error([str(e)], 400)
 
         await self.ds.track_event(
             DeleteRowEvent(
@@ -791,24 +793,24 @@ class RowUpdateView(BaseView):
         try:
             data = await request.json()
         except json.JSONDecodeError as e:
-            return _error(["Invalid JSON: {}".format(e)])
+            return Response.error(["Invalid JSON: {}".format(e)])
         except PayloadTooLarge as e:
-            return _error([str(e)], 413)
+            return Response.error([str(e)], 413)
 
         if not isinstance(data, dict):
-            return _error(["JSON must be a dictionary"])
+            return Response.error(["JSON must be a dictionary"])
         if "update" not in data or not isinstance(data["update"], dict):
-            return _error(["JSON must contain an update dictionary"])
+            return Response.error(["JSON must contain an update dictionary"])
 
         invalid_keys = set(data.keys()) - {"update", "return", "alter"}
         if invalid_keys:
-            return _error(["Invalid keys: {}".format(", ".join(invalid_keys))])
+            return Response.error(["Invalid keys: {}".format(", ".join(invalid_keys))])
 
         update = data["update"]
         try:
             update = decode_write_json_row(update)
         except WriteJsonValueError as e:
-            return _error([str(e)], 400)
+            return Response.error([str(e)], 400)
 
         # Validate column types
         from datasette.views.table import _validate_column_types
@@ -817,7 +819,7 @@ class RowUpdateView(BaseView):
             self.ds, resolved.db.name, resolved.table, [update]
         )
         if ct_errors:
-            return _error(ct_errors, 400)
+            return Response.error(ct_errors, 400)
 
         alter = data.get("alter")
         if alter and not await self.ds.allowed(
@@ -825,7 +827,7 @@ class RowUpdateView(BaseView):
             resource=TableResource(database=resolved.db.name, table=resolved.table),
             actor=request.actor,
         ):
-            return _error(["Permission denied for alter-table"], 403)
+            return Response.error(["Permission denied for alter-table"], 403)
 
         def update_row(conn):
             sqlite_utils.Database(conn)[resolved.table].update(
@@ -835,7 +837,7 @@ class RowUpdateView(BaseView):
         try:
             await resolved.db.execute_write_fn(update_row, request=request)
         except Exception as e:
-            return _error([str(e)], 400)
+            return Response.error([str(e)], 400)
 
         result = {"ok": True}
         returned_row = None
diff --git a/datasette/views/special.py b/datasette/views/special.py
index 9386440c..c13191a1 100644
--- a/datasette/views/special.py
+++ b/datasette/views/special.py
@@ -501,13 +501,9 @@ class PermissionRulesView(BaseView):
         # JSON API - action parameter is required
         action = request.args.get("action")
         if not action:
-            return Response.json(
-                error_body("action parameter is required", 400), status=400
-            )
+            return Response.error("action parameter is required", 400)
         if action not in self.ds.actions:
-            return Response.json(
-                error_body(f"Unknown action: {action}", 404), status=404
-            )
+            return Response.error(f"Unknown action: {action}", 404)
 
         actor = request.actor if isinstance(request.actor, dict) else None
 
@@ -516,15 +512,13 @@ class PermissionRulesView(BaseView):
             if page < 1:
                 raise ValueError
         except ValueError:
-            return Response.json(
-                error_body("_page must be a positive integer", 400), status=400
-            )
+            return Response.error("_page must be a positive integer", 400)
         try:
             page_size = parse_size_limit(
                 request.args.get("_size"), default=50, maximum=200
             )
         except ValueError as ex:
-            return Response.json(error_body(str(ex), 400), status=400)
+            return Response.error(str(ex), 400)
         offset = (page - 1) * page_size
 
         from datasette.utils.actions_sql import build_permission_rules_sql
@@ -673,9 +667,7 @@ class PermissionCheckView(BaseView):
         # JSON API - action parameter is required
         action = request.args.get("action")
         if not action:
-            return Response.json(
-                error_body("action parameter is required", 400), status=400
-            )
+            return Response.error("action parameter is required", 400)
 
         parent = request.args.get("parent")
         child = request.args.get("child")
diff --git a/datasette/views/stored_queries.py b/datasette/views/stored_queries.py
index 3273d13c..d64f37d2 100644
--- a/datasette/views/stored_queries.py
+++ b/datasette/views/stored_queries.py
@@ -5,7 +5,7 @@ from datasette.stored_queries import stored_query_to_dict
 from datasette.utils import UNSTABLE_API_MESSAGE, sqlite3, tilde_decode
 from datasette.utils.asgi import Response
 
-from .base import BaseView, _error
+from .base import BaseView
 from .query_helpers import (
     QueryValidationError,
     _as_bool,
@@ -34,12 +34,14 @@ class QueryParametersView(BaseView):
             resource=DatabaseResource(db.name),
             actor=request.actor,
         ):
-            return _block_framing(_error(["Permission denied: need execute-sql"], 403))
+            return _block_framing(
+                Response.error(["Permission denied: need execute-sql"], 403)
+            )
 
         invalid_keys = set(request.args) - {"sql"}
         if invalid_keys:
             return _block_framing(
-                _error(
+                Response.error(
                     ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
                     400,
                 )
@@ -47,7 +49,7 @@ class QueryParametersView(BaseView):
         try:
             parameters = _derived_query_parameters(request.args.get("sql") or "")
         except QueryValidationError as ex:
-            return _block_framing(_error([ex.message], ex.status))
+            return _block_framing(Response.error([ex.message], ex.status))
         return _block_framing(
             Response.json(
                 {
@@ -95,7 +97,7 @@ class QueryListView(BaseView):
             is_write = _as_optional_bool(request.args.get("is_write"), "is_write")
             is_private = _as_optional_bool(request.args.get("is_private"), "is_private")
         except QueryValidationError as ex:
-            return _error([ex.message], ex.status)
+            return Response.error([ex.message], ex.status)
 
         page = await self.ds.list_queries(
             database,
@@ -306,18 +308,22 @@ class QueryCreateAnalyzeView(BaseView):
             resource=DatabaseResource(db.name),
             actor=request.actor,
         ):
-            return _block_framing(_error(["Permission denied: need execute-sql"], 403))
+            return _block_framing(
+                Response.error(["Permission denied: need execute-sql"], 403)
+            )
         if not await self.ds.allowed(
             action="store-query",
             resource=DatabaseResource(db.name),
             actor=request.actor,
         ):
-            return _block_framing(_error(["Permission denied: need store-query"], 403))
+            return _block_framing(
+                Response.error(["Permission denied: need store-query"], 403)
+            )
 
         invalid_keys = set(request.args) - {"sql"}
         if invalid_keys:
             return _block_framing(
-                _error(
+                Response.error(
                     ["Invalid keys: {}".format(", ".join(sorted(invalid_keys)))],
                     400,
                 )
@@ -352,13 +358,13 @@ class QueryStoreView(QueryCreateView):
             resource=DatabaseResource(db.name),
             actor=request.actor,
         ):
-            return _error(["Permission denied: need execute-sql"], 403)
+            return Response.error(["Permission denied: need execute-sql"], 403)
         if not await self.ds.allowed(
             action="store-query",
             resource=DatabaseResource(db.name),
             actor=request.actor,
         ):
-            return _error(["Permission denied: need store-query"], 403)
+            return Response.error(["Permission denied: need store-query"], 403)
 
         is_json = False
         query_data = {}
@@ -375,7 +381,7 @@ class QueryStoreView(QueryCreateView):
                 return await self._error_response(
                     request, db, query_data, ex.message, ex.status
                 )
-            return _error([ex.message], ex.status)
+            return Response.error([ex.message], ex.status)
 
         prepared.pop("analysis")
         name = prepared.pop("name")
@@ -384,7 +390,7 @@ class QueryStoreView(QueryCreateView):
         except sqlite3.IntegrityError as ex:
             if not is_json and isinstance(query_data, dict):
                 return await self._error_response(request, db, query_data, str(ex), 400)
-            return _error([str(ex)], 400)
+            return Response.error([str(ex)], 400)
 
         query = await self.ds.get_query(db.name, name)
         assert query is not None
@@ -409,13 +415,13 @@ class QueryDefinitionView(BaseView):
         query_name = tilde_decode(request.url_vars["query"])
         query = await self.ds.get_query(db.name, query_name)
         if query is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
+            return Response.error(["Query not found: {}".format(query_name)], 404)
         if not await self.ds.allowed(
             action="view-query",
             resource=QueryResource(db.name, query_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied"], 403)
+            return Response.error(["Permission denied"], 403)
         return Response.json(
             {
                 "ok": True,
@@ -433,15 +439,17 @@ class QueryUpdateView(BaseView):
         query_name = tilde_decode(request.url_vars["query"])
         existing = await self.ds.get_query(db.name, query_name)
         if existing is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
+            return Response.error(["Query not found: {}".format(query_name)], 404)
         if not await self.ds.allowed(
             action="update-query",
             resource=QueryResource(db.name, query_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied: need update-query"], 403)
+            return Response.error(["Permission denied: need update-query"], 403)
         if existing.is_trusted:
-            return _error(["Trusted queries cannot be updated using the API"], 403)
+            return Response.error(
+                ["Trusted queries cannot be updated using the API"], 403
+            )
 
         try:
             data, _ = await _json_or_form_payload(request)
@@ -467,7 +475,7 @@ class QueryUpdateView(BaseView):
                 self.ds, request, db, existing, update
             )
         except QueryValidationError as ex:
-            return _error([ex.message], ex.status)
+            return Response.error([ex.message], ex.status)
 
         await self.ds.update_query(db.name, query_name, **update_kwargs)
         if data.get("return"):
@@ -524,32 +532,32 @@ class QueryEditView(BaseView):
     async def get(self, request):
         db, query_name, existing = await self._load(request)
         if existing is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
+            return Response.error(["Query not found: {}".format(query_name)], 404)
         await self.ds.ensure_permission(
             action="update-query",
             resource=QueryResource(db.name, query_name),
             actor=request.actor,
         )
         if existing.is_trusted:
-            return _error(["Trusted queries cannot be edited"], 403)
+            return Response.error(["Trusted queries cannot be edited"], 403)
         return await self._render_form(request, db, existing)
 
     async def post(self, request):
         db, query_name, existing = await self._load(request)
         if existing is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
+            return Response.error(["Query not found: {}".format(query_name)], 404)
         if not await self.ds.allowed(
             action="update-query",
             resource=QueryResource(db.name, query_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied: need update-query"], 403)
+            return Response.error(["Permission denied: need update-query"], 403)
         if existing.is_trusted:
-            return _error(["Trusted queries cannot be edited"], 403)
+            return Response.error(["Trusted queries cannot be edited"], 403)
 
         data, _ = await _json_or_form_payload(request)
         if not isinstance(data, dict):
-            return _error(["Invalid form submission"], 400)
+            return Response.error(["Invalid form submission"], 400)
         sql = data.get("sql")
         sql = existing.sql if sql is None else sql.strip()
         title = data.get("title") or ""
@@ -621,14 +629,16 @@ class QueryDeleteView(BaseView):
     async def get(self, request):
         db, query_name, existing = await self._load(request)
         if existing is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
+            return Response.error(["Query not found: {}".format(query_name)], 404)
         await self.ds.ensure_permission(
             action="delete-query",
             resource=QueryResource(db.name, query_name),
             actor=request.actor,
         )
         if existing.is_trusted:
-            return _error(["Trusted queries cannot be deleted using the API"], 403)
+            return Response.error(
+                ["Trusted queries cannot be deleted using the API"], 403
+            )
         return await self.render(
             ["query_delete.html"],
             request,
@@ -643,15 +653,17 @@ class QueryDeleteView(BaseView):
     async def post(self, request):
         db, query_name, existing = await self._load(request)
         if existing is None:
-            return _error(["Query not found: {}".format(query_name)], 404)
+            return Response.error(["Query not found: {}".format(query_name)], 404)
         if not await self.ds.allowed(
             action="delete-query",
             resource=QueryResource(db.name, query_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied: need delete-query"], 403)
+            return Response.error(["Permission denied: need delete-query"], 403)
         if existing.is_trusted:
-            return _error(["Trusted queries cannot be deleted using the API"], 403)
+            return Response.error(
+                ["Trusted queries cannot be deleted using the API"], 403
+            )
 
         data, is_json = await _json_or_form_payload(request)
         await self.ds.remove_query(db.name, query_name)
diff --git a/datasette/views/table.py b/datasette/views/table.py
index 80ad1aab..8ce4b711 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -60,7 +60,7 @@ from dataclasses import dataclass, field
 
 from datasette.extras import ExtraScope
 from . import Context, from_extra
-from .base import BaseView, DatasetteError, _error, stream_csv
+from .base import BaseView, DatasetteError, stream_csv
 from .database import QueryView
 from .table_create_alter import (
     ALTER_TABLE_COLUMN_TYPES,
@@ -1035,7 +1035,7 @@ class TableInsertView(BaseView):
         try:
             resolved = await self.ds.resolve_table(request)
         except NotFound as e:
-            return _error([e.args[0]], 404)
+            return Response.error([e.args[0]], 404)
         db = resolved.db
         database_name = db.name
         table_name = resolved.table
@@ -1043,7 +1043,7 @@ class TableInsertView(BaseView):
         # Table must exist (may handle table creation in the future)
         db = self.ds.get_database(database_name)
         if not await db.table_exists(table_name):
-            return _error(["Table not found: {}".format(table_name)], 404)
+            return Response.error(["Table not found: {}".format(table_name)], 404)
 
         if upsert:
             # Must have insert-row AND upsert-row permissions
@@ -1059,7 +1059,7 @@ class TableInsertView(BaseView):
                     actor=request.actor,
                 )
             ):
-                return _error(
+                return Response.error(
                     ["Permission denied: need both insert-row and update-row"], 403
                 )
         else:
@@ -1069,10 +1069,10 @@ class TableInsertView(BaseView):
                 resource=TableResource(database=database_name, table=table_name),
                 actor=request.actor,
             ):
-                return _error(["Permission denied"], 403)
+                return Response.error(["Permission denied"], 403)
 
         if not db.is_mutable:
-            return _error(["Database is immutable"], 403)
+            return Response.error(["Database is immutable"], 403)
 
         pks = await db.primary_keys(table_name)
 
@@ -1081,20 +1081,20 @@ class TableInsertView(BaseView):
                 request, db, table_name, pks, upsert
             )
         except PayloadTooLarge as e:
-            return _error([str(e)], 413)
+            return Response.error([str(e)], 413)
         if errors:
-            return _error(errors, 400)
+            return Response.error(errors, 400)
         try:
             rows = decode_write_json_rows(rows)
         except WriteJsonValueError as e:
-            return _error([str(e)], 400)
+            return Response.error([str(e)], 400)
 
         # Validate column types
         ct_errors = await _validate_column_types(
             self.ds, database_name, table_name, rows
         )
         if ct_errors:
-            return _error(ct_errors, 400)
+            return Response.error(ct_errors, 400)
 
         num_rows = len(rows)
 
@@ -1108,14 +1108,16 @@ class TableInsertView(BaseView):
         alter = extras.get("alter")
 
         if upsert and (ignore or replace):
-            return _error(["Upsert does not support ignore or replace"], 400)
+            return Response.error(["Upsert does not support ignore or replace"], 400)
 
         if replace and not await self.ds.allowed(
             action="update-row",
             resource=TableResource(database=database_name, table=table_name),
             actor=request.actor,
         ):
-            return _error(['Permission denied: need update-row to use "replace"'], 403)
+            return Response.error(
+                ['Permission denied: need update-row to use "replace"'], 403
+            )
 
         initial_schema = None
         if alter:
@@ -1125,7 +1127,7 @@ class TableInsertView(BaseView):
                 resource=TableResource(database=database_name, table=table_name),
                 actor=request.actor,
             ):
-                return _error(["Permission denied for alter-table"], 403)
+                return Response.error(["Permission denied for alter-table"], 403)
             # Track initial schema to check if it changed later
             initial_schema = await db.execute_fn(
                 lambda conn: sqlite_utils.Database(conn)[table_name].schema
@@ -1165,7 +1167,7 @@ class TableInsertView(BaseView):
         try:
             rows = await db.execute_write_fn(insert_or_upsert_rows, request=request)
         except Exception as e:
-            return _error([str(e)])
+            return Response.error([str(e)])
         result = {"ok": True}
         if should_return:
             if upsert:
@@ -1246,7 +1248,7 @@ class TableSetColumnTypeView(BaseView):
         try:
             resolved = await self.ds.resolve_table(request)
         except NotFound as e:
-            return _error([e.args[0]], 404)
+            return Response.error([e.args[0]], 404)
 
         database_name = resolved.db.name
         table_name = resolved.table
@@ -1256,39 +1258,39 @@ class TableSetColumnTypeView(BaseView):
             resource=TableResource(database=database_name, table=table_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied"], 403)
+            return Response.error(["Permission denied"], 403)
 
         try:
             data = await request.json()
         except json.JSONDecodeError as e:
-            return _error(["Invalid JSON: {}".format(e)], 400)
+            return Response.error(["Invalid JSON: {}".format(e)], 400)
         except PayloadTooLarge as e:
-            return _error([str(e)], 413)
+            return Response.error([str(e)], 413)
 
         if not isinstance(data, dict):
-            return _error(["JSON must be a dictionary"], 400)
+            return Response.error(["JSON must be a dictionary"], 400)
 
         invalid_keys = set(data.keys()) - {"column", "column_type"}
         if invalid_keys:
-            return _error(
+            return Response.error(
                 ['Invalid parameter: "{}"'.format('", "'.join(sorted(invalid_keys)))],
                 400,
             )
 
         if "column" not in data:
-            return _error(['"column" is required'], 400)
+            return Response.error(['"column" is required'], 400)
         column = data["column"]
         if not isinstance(column, str):
-            return _error(['"column" must be a string'], 400)
+            return Response.error(['"column" must be a string'], 400)
 
         if "column_type" not in data:
-            return _error(['"column_type" is required'], 400)
+            return Response.error(['"column_type" is required'], 400)
 
         column_details = await self.ds._get_resource_column_details(
             database_name, table_name
         )
         if column not in column_details:
-            return _error(["Column not found: {}".format(column)], 400)
+            return Response.error(["Column not found: {}".format(column)], 400)
 
         column_type_data = data["column_type"]
         if column_type_data is None:
@@ -1305,11 +1307,11 @@ class TableSetColumnTypeView(BaseView):
             )
 
         if not isinstance(column_type_data, dict):
-            return _error(['"column_type" must be an object or null'], 400)
+            return Response.error(['"column_type" must be an object or null'], 400)
 
         invalid_column_type_keys = set(column_type_data.keys()) - {"type", "config"}
         if invalid_column_type_keys:
-            return _error(
+            return Response.error(
                 [
                     'Invalid column_type parameter: "{}"'.format(
                         '", "'.join(sorted(invalid_column_type_keys))
@@ -1319,24 +1321,24 @@ class TableSetColumnTypeView(BaseView):
             )
 
         if "type" not in column_type_data:
-            return _error(['"column_type.type" is required'], 400)
+            return Response.error(['"column_type.type" is required'], 400)
         column_type = column_type_data["type"]
         if not isinstance(column_type, str):
-            return _error(['"column_type.type" must be a string'], 400)
+            return Response.error(['"column_type.type" must be a string'], 400)
 
         config = column_type_data.get("config")
         if config is not None and not isinstance(config, dict):
-            return _error(['"column_type.config" must be a dictionary'], 400)
+            return Response.error(['"column_type.config" must be a dictionary'], 400)
 
         if column_type not in self.ds._column_types:
-            return _error(["Unknown column type: {}".format(column_type)], 400)
+            return Response.error(["Unknown column type: {}".format(column_type)], 400)
 
         try:
             await self.ds.set_column_type(
                 database_name, table_name, column, column_type, config
             )
         except ValueError as e:
-            return _error([str(e)], 400)
+            return Response.error([str(e)], 400)
 
         return Response.json(
             {
@@ -1360,22 +1362,22 @@ class TableDropView(BaseView):
         try:
             resolved = await self.ds.resolve_table(request)
         except NotFound as e:
-            return _error([e.args[0]], 404)
+            return Response.error([e.args[0]], 404)
         db = resolved.db
         database_name = db.name
         table_name = resolved.table
         # Table must exist
         db = self.ds.get_database(database_name)
         if not await db.table_exists(table_name):
-            return _error(["Table not found: {}".format(table_name)], 404)
+            return Response.error(["Table not found: {}".format(table_name)], 404)
         if not await self.ds.allowed(
             action="drop-table",
             resource=TableResource(database=database_name, table=table_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied"], 403)
+            return Response.error(["Permission denied"], 403)
         if not db.is_mutable:
-            return _error(["Database is immutable"], 403)
+            return Response.error(["Database is immutable"], 403)
         confirm = False
         try:
             data = await request.json()
@@ -1383,7 +1385,7 @@ class TableDropView(BaseView):
         except json.JSONDecodeError:
             pass
         except PayloadTooLarge as e:
-            return _error([str(e)], 413)
+            return Response.error([str(e)], 413)
 
         if not confirm:
             return Response.json(
diff --git a/datasette/views/table_create_alter.py b/datasette/views/table_create_alter.py
index c3e06c29..4deeafcc 100644
--- a/datasette/views/table_create_alter.py
+++ b/datasette/views/table_create_alter.py
@@ -29,7 +29,7 @@ from datasette.utils import (
 from datasette.utils.asgi import NotFound, PayloadTooLarge, Response
 from datasette.utils.sqlite import sqlite_hidden_table_names
 
-from .base import BaseView, _error
+from .base import BaseView
 
 CREATE_TABLE_COLUMN_TYPES = ["text", "integer", "float", "blob"]
 CREATE_TABLE_SQLITE_TYPES = {
@@ -805,22 +805,22 @@ class TableCreateView(BaseView):
             resource=DatabaseResource(database=database_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied"], 403)
+            return Response.error(["Permission denied"], 403)
 
         try:
             data = await request.json()
         except json.JSONDecodeError as e:
-            return _error(["Invalid JSON: {}".format(e)])
+            return Response.error(["Invalid JSON: {}".format(e)])
         except PayloadTooLarge as e:
-            return _error([str(e)], 413)
+            return Response.error([str(e)], 413)
 
         if not isinstance(data, dict):
-            return _error(["JSON must be an object"])
+            return Response.error(["JSON must be an object"])
 
         try:
             create_request = CreateTableRequest.model_validate(data)
         except ValidationError as e:
-            return _error(_create_table_pydantic_errors(e))
+            return Response.error(_create_table_pydantic_errors(e))
 
         ignore = create_request.ignore
         replace = create_request.replace
@@ -832,7 +832,7 @@ class TableCreateView(BaseView):
                 resource=DatabaseResource(database=database_name),
                 actor=request.actor,
             ):
-                return _error(["Permission denied: need update-row"], 403)
+                return Response.error(["Permission denied: need update-row"], 403)
 
         table_name = create_request.table
         table_exists = await db.table_exists(table_name)
@@ -846,11 +846,11 @@ class TableCreateView(BaseView):
                 resource=DatabaseResource(database=database_name),
                 actor=request.actor,
             ):
-                return _error(["Permission denied: need insert-row"], 403)
+                return Response.error(["Permission denied: need insert-row"], 403)
             try:
                 rows = decode_write_json_rows(rows)
             except WriteJsonValueError as e:
-                return _error([str(e)], 400)
+                return Response.error([str(e)], 400)
 
         alter = False
         if rows:
@@ -865,7 +865,9 @@ class TableCreateView(BaseView):
                         resource=DatabaseResource(database=database_name),
                         actor=request.actor,
                     ):
-                        return _error(["Permission denied: need alter-table"], 403)
+                        return Response.error(
+                            ["Permission denied: need alter-table"], 403
+                        )
                     alter = True
 
         pk = create_request.pk
@@ -881,7 +883,7 @@ class TableCreateView(BaseView):
             elif len(actual_pks) > 1 and pks and set(pks) != set(actual_pks):
                 bad_pks = True
             if bad_pks:
-                return _error(["pk cannot be changed for existing table"])
+                return Response.error(["pk cannot be changed for existing table"])
             pks = actual_pks
 
         initial_schema = None
@@ -924,7 +926,7 @@ class TableCreateView(BaseView):
         try:
             schema = await db.execute_write_fn(create_table, request=request)
         except Exception as e:
-            return _error([str(e)])
+            return Response.error([str(e)])
 
         if initial_schema is not None and initial_schema != schema:
             await self.ds.track_event(
@@ -999,7 +1001,7 @@ class DatabaseForeignKeyTargetsView(BaseView):
                 actor=request.actor,
             )
         if not (can_create_table or can_alter_table):
-            return _error(["Permission denied: need create-table"], 403)
+            return Response.error(["Permission denied: need create-table"], 403)
 
         hidden_tables = await db.execute_fn(
             lambda conn: set(sqlite_hidden_table_names(conn))
@@ -1028,21 +1030,21 @@ class TableForeignKeySuggestionsView(BaseView):
         try:
             resolved = await self.ds.resolve_table(request)
         except NotFound as e:
-            return _error([e.args[0]], 404)
+            return Response.error([e.args[0]], 404)
 
         db = resolved.db
         database_name = db.name
         table_name = resolved.table
 
         if resolved.is_view:
-            return _error(["Cannot suggest foreign keys for a view"], 400)
+            return Response.error(["Cannot suggest foreign keys for a view"], 400)
 
         if not await self.ds.allowed(
             action="alter-table",
             resource=TableResource(database=database_name, table=table_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied: need alter-table"], 403)
+            return Response.error(["Permission denied: need alter-table"], 403)
 
         source_columns, targets, current_by_column = await db.execute_fn(
             lambda conn: _foreign_key_suggestion_metadata(conn, table_name)
@@ -1150,7 +1152,7 @@ class TableAlterView(BaseView):
         try:
             resolved = await self.ds.resolve_table(request)
         except NotFound as e:
-            return _error([e.args[0]], 404)
+            return Response.error([e.args[0]], 404)
 
         db = resolved.db
         database_name = db.name
@@ -1161,25 +1163,25 @@ class TableAlterView(BaseView):
             resource=TableResource(database=database_name, table=table_name),
             actor=request.actor,
         ):
-            return _error(["Permission denied: need alter-table"], 403)
+            return Response.error(["Permission denied: need alter-table"], 403)
 
         if not db.is_mutable:
-            return _error(["Database is immutable"], 403)
+            return Response.error(["Database is immutable"], 403)
 
         try:
             data = await request.json()
         except json.JSONDecodeError as e:
-            return _error(["Invalid JSON: {}".format(e)], 400)
+            return Response.error(["Invalid JSON: {}".format(e)], 400)
         except PayloadTooLarge as e:
-            return _error([str(e)], 413)
+            return Response.error([str(e)], 413)
 
         if not isinstance(data, dict):
-            return _error(["JSON must be a dictionary"], 400)
+            return Response.error(["JSON must be a dictionary"], 400)
 
         try:
             alter_request = AlterTableRequest.model_validate(data)
         except ValidationError as e:
-            return _error(_pydantic_errors(e), 400)
+            return Response.error(_pydantic_errors(e), 400)
 
         def alter_table(conn):
             before_schema = _table_schema_from_conn(conn, table_name)
@@ -1328,7 +1330,7 @@ class TableAlterView(BaseView):
                 alter_table, request=request
             )
         except Exception as e:
-            return _error([str(e)], 400)
+            return Response.error([str(e)], 400)
 
         altered = before_schema != after_schema
         if altered:
diff --git a/docs/internals.rst b/docs/internals.rst
index e5e7aca5..7258e6f3 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -284,7 +284,7 @@ For example:
         content_type="application/xml; charset=utf-8",
     )
 
-The quickest way to create responses is using the ``Response.text(...)``, ``Response.html(...)``, ``Response.json(...)`` or ``Response.redirect(...)`` helper methods:
+The quickest way to create responses is using the ``Response.text(...)``, ``Response.html(...)``, ``Response.json(...)``, ``Response.error(...)`` or ``Response.redirect(...)`` helper methods:
 
 .. code-block:: python
 
@@ -295,6 +295,8 @@ The quickest way to create responses is using the ``Response.text(...)``, ``Resp
     text_response = Response.text(
         "This will become utf-8 encoded text"
     )
+    # A JSON error in Datasette's standard error format:
+    error_response = Response.error("Cannot do that", 400)
     # Redirects are served as 302, unless you pass status=301:
     redirect_response = Response.redirect(
         "https://latest.datasette.io/"
@@ -304,6 +306,8 @@ Each of these responses will use the correct corresponding content-type - ``text
 
 Each of the helper methods take optional ``status=`` and ``headers=`` arguments, documented above.
 
+``Response.error(messages, status=400)`` returns a JSON error in the :ref:`standard Datasette error format <json_api_errors>`. ``messages`` can be a single string or a list of strings. Use this for JSON-only endpoints; if your error should content-negotiate between JSON and HTML, raise ``Forbidden``, ``NotFound``, ``BadRequest`` or ``DatasetteError`` instead and Datasette's error handling will build the appropriate response.
+
 .. _internals_response_asgi_send:
 
 Returning a response with .asgi_send(send)
diff --git a/tests/test_internals_response.py b/tests/test_internals_response.py
index 820b20b2..2366dcde 100644
--- a/tests/test_internals_response.py
+++ b/tests/test_internals_response.py
@@ -1,4 +1,5 @@
 from datasette.utils.asgi import Response
+import json
 import pytest
 
 
@@ -52,3 +53,26 @@ async def test_response_set_cookie():
         },
         {"type": "http.response.body", "body": b""},
     ] == events
+
+
+def test_response_error_single_message():
+    response = Response.error("Method not allowed", 405)
+    assert response.status == 405
+    assert response.content_type == "application/json; charset=utf-8"
+    assert json.loads(response.body) == {
+        "ok": False,
+        "error": "Method not allowed",
+        "errors": ["Method not allowed"],
+        "status": 405,
+    }
+
+
+def test_response_error_message_list_and_default_status():
+    response = Response.error(["First problem", "Second problem"])
+    assert response.status == 400
+    assert json.loads(response.body) == {
+        "ok": False,
+        "error": "First problem; Second problem",
+        "errors": ["First problem", "Second problem"],
+        "status": 400,
+    }

From 4874c292860c7ad67da2a730d6e58dde2718adda Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 6 Jul 2026 23:59:44 +0000
Subject: [PATCH 365/386] Remove the next_url extra - the key is always present

next_url became a default table JSON key alongside next, making the
extra a no-op. Requesting ?_extra=next_url now returns the standard
unknown-extra 400 error.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/table.py        |  6 +++++-
 datasette/views/table_extras.py | 17 -----------------
 docs/json_api.rst               | 13 +------------
 docs/template_context.rst       |  2 +-
 tests/test_api.py               |  2 +-
 tests/test_error_shape.py       |  8 ++++++++
 tests/test_table_api.py         | 18 +++++++-----------
 7 files changed, 23 insertions(+), 43 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index 8ce4b711..f7edd744 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -107,7 +107,6 @@ class TableContext(Context):
     human_description_en: str = from_extra()
     is_view: bool = from_extra()
     metadata: dict = from_extra()
-    next_url: str = from_extra()
     primary_keys: list = from_extra()
     private: bool = from_extra()
     query: dict = from_extra()
@@ -124,6 +123,11 @@ class TableContext(Context):
         metadata={"help": "True if the data for this page was retrieved without errors"}
     )
     next: str = field(metadata={"help": "Pagination token for the next page, or None"})
+    next_url: str = field(
+        metadata={
+            "help": "Full URL for the next page of results, or None if there are no more pages. See :ref:`json_api_pagination`."
+        }
+    )
     count_truncated: bool = field(
         metadata={
             "help": "True if ``count`` is a capped lower bound rather than an exact total, because Datasette stopped counting after its configured row-count limit."
diff --git a/datasette/views/table_extras.py b/datasette/views/table_extras.py
index e36e8161..50002d92 100644
--- a/datasette/views/table_extras.py
+++ b/datasette/views/table_extras.py
@@ -321,21 +321,6 @@ class HumanDescriptionEnExtra(Extra):
         return human_description_en
 
 
-class NextUrlExtra(Extra):
-    description = "Full URL for the next page of results"
-    example = ExtraExample(
-        "/fixtures/facetable.json?_size=1&_extra=next_url",
-        note=(
-            "``null`` if there are no more pages of results. "
-            "See :ref:`json_api_pagination`."
-        ),
-    )
-    scopes = {ExtraScope.TABLE}
-
-    async def resolve(self, context):
-        return context.next_url
-
-
 class ColumnsExtra(Extra):
     description = "List of column names returned by this table, row or query."
     example = ExtraExample("/fixtures/facetable.json?_extra=columns")
@@ -1250,7 +1235,6 @@ TABLE_EXTRA_BUNDLES = {
         "count",
         "count_sql",
         "human_description_en",
-        "next_url",
         "metadata",
         "query",
         "columns",
@@ -1286,7 +1270,6 @@ TABLE_EXTRA_CLASSES = [
     SuggestedFacetsExtra,
     FacetInstancesProvider,
     HumanDescriptionEnExtra,
-    NextUrlExtra,
     ColumnsExtra,
     AllColumnsExtra,
     PrimaryKeysExtra,
diff --git a/docs/json_api.rst b/docs/json_api.rst
index 893af634..ec60a3a9 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -333,7 +333,7 @@ These can be repeated or comma-separated:
 
 ::
 
-    ?_extra=columns&_extra=count,next_url
+    ?_extra=columns&_extra=count,count_sql
 
 Requesting an ``_extra`` name that does not exist returns a ``400`` error in the :ref:`standard error format <json_api_errors>`, for example ``{"ok": false, "error": "Unknown _extra: nope", ...}``.
 
@@ -437,17 +437,6 @@ The available table extras are listed below.
 
         "where state = \"CA\" sorted by pk"
 
-``next_url``
-    Full URL for the next page of results
-
-    ``GET /fixtures/facetable.json?_size=1&_extra=next_url``
-
-    ``null`` if there are no more pages of results. See :ref:`json_api_pagination`.
-
-    .. code-block:: json
-
-        "http://localhost/fixtures/facetable.json?_size=1&_extra=next_url&_next=1"
-
 ``columns``
     List of column names returned by this table, row or query.
 
diff --git a/docs/template_context.rst b/docs/template_context.rst
index e9447058..e445b335 100644
--- a/docs/template_context.rst
+++ b/docs/template_context.rst
@@ -329,7 +329,7 @@ Many of these keys are shared with the :ref:`JSON API <json_api>` for this page.
     Pagination token for the next page, or None
 
 ``next_url`` - ``str``
-    Full URL for the next page of results
+    Full URL for the next page of results, or None if there are no more pages. See :ref:`json_api_pagination`.
 
 ``ok`` - ``bool``
     True if the data for this page was retrieved without errors
diff --git a/tests/test_api.py b/tests/test_api.py
index 9a96f14f..a15a507c 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -722,7 +722,7 @@ def test_config_cache_size(app_client_larger_cache_size):
 def test_config_force_https_urls():
     with make_app_client(settings={"force_https_urls": True}) as client:
         response = client.get(
-            "/fixtures/facetable.json?_size=3&_facet=state&_extra=next_url,suggested_facets"
+            "/fixtures/facetable.json?_size=3&_facet=state&_extra=suggested_facets"
         )
         assert response.json["next_url"].startswith("https://")
         assert response.json["facet_results"]["results"]["state"]["results"][0][
diff --git a/tests/test_error_shape.py b/tests/test_error_shape.py
index 44856b36..768814fd 100644
--- a/tests/test_error_shape.py
+++ b/tests/test_error_shape.py
@@ -739,3 +739,11 @@ async def test_sql_interrupted_html_page_keeps_rich_error(ds_client):
     )
     assert response.status_code == 400
     assert "<textarea" in response.text
+
+
+@pytest.mark.asyncio
+async def test_next_url_extra_no_longer_exists(ds_client):
+    # next_url is always present in table JSON; the extra was removed
+    response = await ds_client.get("/fixtures/facetable.json?_extra=next_url")
+    data = assert_canonical_error(response, 400)
+    assert data["errors"] == ["Unknown _extra: next_url"]
diff --git a/tests/test_table_api.py b/tests/test_table_api.py
index 30eee5d9..b8c6be87 100644
--- a/tests/test_table_api.py
+++ b/tests/test_table_api.py
@@ -323,10 +323,6 @@ async def test_paginate_tables_and_views(
     fetched = []
     count = 0
     while path:
-        if "?" in path:
-            path += "&_extra=next_url"
-        else:
-            path += "?_extra=next_url"
         response = await ds_client.get(path)
         assert response.status_code == 200
         count += 1
@@ -359,9 +355,7 @@ async def test_validate_page_size(ds_client, path, expected_error):
 @pytest.mark.asyncio
 async def test_page_size_zero(ds_client):
     """For _size=0 we return the counts, empty rows and no continuation token"""
-    response = await ds_client.get(
-        "/fixtures/no_primary_key.json?_size=0&_extra=count,next_url"
-    )
+    response = await ds_client.get("/fixtures/no_primary_key.json?_size=0&_extra=count")
     assert response.status_code == 200
     assert [] == response.json()["rows"]
     assert 202 == response.json()["count"]
@@ -372,7 +366,7 @@ async def test_page_size_zero(ds_client):
 @pytest.mark.asyncio
 async def test_paginate_compound_keys(ds_client):
     fetched = []
-    path = "/fixtures/compound_three_primary_keys.json?_shape=objects&_extra=next_url"
+    path = "/fixtures/compound_three_primary_keys.json?_shape=objects"
     page = 0
     while path:
         page += 1
@@ -393,7 +387,9 @@ async def test_paginate_compound_keys(ds_client):
 @pytest.mark.asyncio
 async def test_paginate_compound_keys_with_extra_filters(ds_client):
     fetched = []
-    path = "/fixtures/compound_three_primary_keys.json?content__contains=d&_shape=objects&_extra=next_url"
+    path = (
+        "/fixtures/compound_three_primary_keys.json?content__contains=d&_shape=objects"
+    )
     page = 0
     while path:
         page += 1
@@ -446,7 +442,7 @@ async def test_paginate_compound_keys_with_extra_filters(ds_client):
     ],
 )
 async def test_sortable(ds_client, query_string, sort_key, human_description_en):
-    path = f"/fixtures/sortable.json?_shape=objects&_extra=human_description_en,next_url&{query_string}"
+    path = f"/fixtures/sortable.json?_shape=objects&_extra=human_description_en&{query_string}"
     fetched = []
     page = 0
     while path:
@@ -850,7 +846,7 @@ def test_page_size_matching_max_returned_rows(
     app_client_returned_rows_matches_page_size,
 ):
     fetched = []
-    path = "/fixtures/no_primary_key.json?_extra=next_url"
+    path = "/fixtures/no_primary_key.json"
     while path:
         response = app_client_returned_rows_matches_page_size.get(path)
         fetched.extend(response.json["rows"])

From 610c24d59a3886e3b52db500330782294fbbfe18 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Tue, 7 Jul 2026 00:25:09 +0000
Subject: [PATCH 366/386] /-/jump is a stable documented endpoint, not a debug
 exemption

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 docs/introspection.rst | 2 +-
 docs/json_api.rst      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/introspection.rst b/docs/introspection.rst
index ea94b70d..b78e4860 100644
--- a/docs/introspection.rst
+++ b/docs/introspection.rst
@@ -9,7 +9,7 @@ Each of these pages can be viewed in your browser. Add ``.json`` to the URL to g
 
 JSON responses that return an object include an ``"ok": true`` key, consistent with the rest of the :ref:`JSON API <json_api>`.
 
-The introspection endpoints documented on this page are covered by the :ref:`JSON API stability promise <json_api_stability>`, with the exception of the debug endpoints ``/-/threads``, ``/-/actions`` and ``/-/jump``, whose shapes may change in future releases.
+The introspection endpoints documented on this page are covered by the :ref:`JSON API stability promise <json_api_stability>`, with the exception of the debug endpoints ``/-/threads`` and ``/-/actions``, whose shapes may change in future releases.
 
 .. _JsonDataView_metadata:
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index ec60a3a9..a96fd73d 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -48,7 +48,7 @@ Some JSON endpoints are **exempt** from this promise:
   debug playground.
 - Debug and support endpoints are documented so you can use them, but their
   JSON shapes are not frozen: :ref:`/-/threads <JsonDataView_threads>`,
-  :ref:`/-/actions <JsonDataView_actions>`, :ref:`/-/jump <JumpView>`,
+  :ref:`/-/actions <JsonDataView_actions>`,
   the :ref:`permission debug endpoints <PermissionsDebugView>`
   (``/-/allowed``, ``/-/rules``, ``/-/check``) and the
   :ref:`table autocomplete endpoint <TableAutocompleteView>`.

From b23fc4ec48cbd68a072379a03aec3af7245084e3 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Tue, 7 Jul 2026 00:32:29 +0000
Subject: [PATCH 367/386] Unreleased release notes for the JSON API consistency
 review

Documents the canonical error format, the ok/envelope changes, the
array-to-object endpoint conversions, 401s for invalid tokens, the
pagination and page-size unification, removed legacy keys and formats,
and the new Response.error(), TokenInvalid, count_truncated and
unstable-marker APIs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 docs/changelog.rst | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 4541981f..3230575d 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -17,6 +17,42 @@ Unreleased
 - The table and row JSON APIs now support ``?_extra=column_details`` for returning SQLite schema details for columns, including declared type, SQLite affinity, primary key, ``NOT NULL``, default and hidden-column metadata.
 - POST bodies that Datasette reads fully into memory - such as JSON submitted to the write API - are now capped by the new :ref:`setting_max_post_body_bytes` setting, defaulting to 2MB. Oversized requests are rejected with an HTTP 413 error as soon as the limit is exceeded, protecting smaller servers from memory exhaustion. File uploads are unaffected - ``request.form()`` streams those to disk and has its own separate limits.
 
+This release also includes the results of a detailed consistency review of Datasette's JSON API in preparation for the 1.0 stable release. Several of these changes are backwards-incompatible with previous 1.0 alphas. The new :ref:`API stability documentation <json_api_stability>` describes exactly which parts of the JSON API are covered by the 1.0 stability promise.
+
+JSON API: breaking changes
+~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+- JSON error responses now use a single canonical format across every endpoint: ``{"ok": false, "error": "...", "errors": [...], "status": 400}``. The ``error`` key joins all error messages together, ``errors`` is the full list of messages and ``status`` always matches the HTTP status code. The legacy ``title`` key is no longer included in JSON errors (it remains available to the HTML error template), and endpoints that previously returned bare ``{"error": ...}`` objects have been updated. See :ref:`json_api_errors`.
+- Every JSON object success response now includes ``"ok": true``, including introspection endpoints such as ``/-/versions`` and ``/-/settings``.
+- ``/-/plugins.json``, ``/-/databases.json`` and ``/-/actions.json`` now return objects - ``{"ok": true, "plugins": [...]}`` and equivalents - instead of top-level JSON arrays, so these responses can gain additional keys in the future without a breaking change. The ``datasette plugins`` CLI command still outputs a plain array.
+- ``/-/databases`` now only lists databases the current actor is allowed to view. It previously listed every attached database, including their filesystem paths, to any actor with ``view-instance``.
+- Requests with an invalid or expired ``Authorization: Bearer`` token now receive a ``401`` status with the standard error body and a ``WWW-Authenticate: Bearer error="invalid_token"`` header, instead of being silently treated as unauthenticated. Bearer tokens that no registered token handler recognizes are still ignored, so authentication plugins with their own token formats keep working. Plugin :ref:`token handlers <plugin_hook_register_token_handler>` can raise the new ``datasette.TokenInvalid`` exception to trigger the same behavior.
+- Permission errors for JSON requests now return the standard JSON error format with a ``403`` status. The default forbidden handling previously rendered an HTML error page even for ``.json`` requests.
+- ``POST`` to a write canned query now returns a ``400`` error when the SQL fails to execute, instead of a ``200`` status with ``"ok": false`` in the body. The error response includes the standard error keys plus a ``"redirect"`` key.
+- The :ref:`row update API <RowUpdateView>` with ``"return": true`` now responds with a ``"rows"`` list, matching insert and upsert, instead of a singular ``"row"`` object.
+- Row delete write failures - such as a constraint violation raised by a trigger - now return ``400`` instead of ``500``, matching the other write endpoints.
+- ``/<database>/-/query.json`` with a missing or blank ``?sql=`` parameter now returns a ``400`` error, as the CSV format already did, instead of a ``200`` with empty rows.
+- Unknown ``?_extra=`` names now return a ``400`` error for JSON and other data formats, instead of being silently ignored. HTML pages continue to ignore unknown names.
+- Table JSON responses now include ``next_url`` alongside ``next`` by default - both are ``null`` on the final page. The now-redundant ``?_extra=next_url`` parameter has been removed.
+- The stored query list JSON no longer includes ``has_more`` - ``"next": null`` is the end-of-results signal across the whole API. This change also uncovered and fixed a bug where the query list ``next_url`` pointed at the HTML page and was a relative path; it is now an absolute URL that preserves the requested format.
+- Stored query JSON objects no longer duplicate the list of parameter names as both ``params`` and ``parameters`` - only ``parameters`` remains in the output. ``params`` is still accepted as an input alias when creating or updating queries.
+- Page size parameters are now consistent across the API: the stored query lists accept ``?_size=max`` and return a ``400`` error for values over the maximum instead of silently clamping them, and the ``/-/allowed`` and ``/-/rules`` permission debug endpoints renamed their ``page`` and ``page_size`` parameters to ``_page`` and ``_size``, matching the underscore grammar used by every other Datasette system parameter.
+- ``/-/threads`` now requires the ``permissions-debug`` permission, since it exposes runtime internals such as file paths. It previously only required ``view-instance``.
+- Trusted stored queries - those defined in configuration - can no longer be deleted through the JSON API or web interface, matching the existing restriction on editing them.
+- The ``/<database>/-/schema`` endpoints now check the ``view-database`` permission before checking whether the database exists, so unauthorized actors can no longer probe for the existence of databases.
+- SQL time limit errors in JSON responses are now a plain text message. The error string previously embedded an HTML fragment.
+- The undocumented homepage JSON at ``/.json`` now returns ``databases`` as a list of objects rather than an object keyed by database name, matching every other collection in the API.
+- The legacy ``.jsono`` format extension, long since superseded by ``?_shape=``, has been removed.
+
+JSON API: other improvements
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+- The :ref:`write API <json_api_write>` endpoints now parse the request body as JSON regardless of the ``Content-Type`` header, so ``curl -d`` invocations work without remembering to set it. Invalid JSON is a ``400`` error. Cross-site request forgery remains prevented by Datasette's ``Origin`` and ``Sec-Fetch-Site`` checks. This also fixes a ``500`` error from the insert API when the ``Content-Type`` header was missing entirely.
+- New ``Response.error(messages, status=400)`` helper for plugins that need to return a JSON error in Datasette's standard format. See :ref:`internals_response`.
+- New ``count_truncated`` extra for table JSON, included automatically whenever ``count`` is requested. ``true`` means the count reached Datasette's counting limit and the real number of rows may be higher. See :ref:`json_api_extra`.
+- JSON endpoints that are not part of the documented stable API now declare themselves with an ``"unstable"`` key in their responses, making the stability tier machine-readable.
+- New documentation covering the grammar for :ref:`boolean query string arguments <json_api_table_arguments>`, the reason :ref:`upsert <TableUpsertView>` returns ``200`` where insert returns ``201``, and advice for plugin authors on :ref:`naming secret configuration keys <plugins_configuration_secret>` so that ``/-/config`` redacts them automatically.
+
 .. _v1_0_a35:
 
 1.0a35 (2026-06-23)

From b83b12dd7abc5b0fce8353792d796bf3943e4a1a Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Tue, 7 Jul 2026 01:13:33 +0000
Subject: [PATCH 368/386] Remove params input alias from the query create and
 update APIs

The alias existed so API payloads could mirror the params key used by
queries defined in datasette.yaml, but it was undocumented and untested,
and the create endpoint is not part of the stable API. The API now only
accepts parameters - sending params is a 400 Invalid keys error. The
documented params key for queries in configuration is unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 datasette/views/query_helpers.py |  7 +++---
 docs/changelog.rst               |  2 +-
 tests/test_queries.py            | 41 ++++++++++++++++++++++++++++++++
 3 files changed, 45 insertions(+), 5 deletions(-)

diff --git a/datasette/views/query_helpers.py b/datasette/views/query_helpers.py
index e9f85b6d..588891d4 100644
--- a/datasette/views/query_helpers.py
+++ b/datasette/views/query_helpers.py
@@ -33,7 +33,6 @@ _query_fields = {
     "hide_sql",
     "fragment",
     "parameters",
-    "params",
     "is_private",
     "on_success_message",
     "on_success_redirect",
@@ -540,7 +539,7 @@ async def _prepare_query_create(datasette, request, db, data):
         raise QueryValidationError("Writable query fields require writable SQL")
 
     parameters = _coerce_query_parameters(
-        data.get("parameters", data.get("params")),
+        data.get("parameters"),
         derived,
     )
     return {
@@ -585,9 +584,9 @@ async def _prepare_query_update(datasette, request, db, existing: StoredQuery, u
             actor=request.actor,
         )
 
-    if "parameters" in update or "params" in update:
+    if "parameters" in update:
         parameters = _coerce_query_parameters(
-            update.get("parameters", update.get("params")),
+            update.get("parameters"),
             derived,
         )
     elif "sql" in update:
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 3230575d..0079aaf2 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -35,7 +35,7 @@ JSON API: breaking changes
 - Unknown ``?_extra=`` names now return a ``400`` error for JSON and other data formats, instead of being silently ignored. HTML pages continue to ignore unknown names.
 - Table JSON responses now include ``next_url`` alongside ``next`` by default - both are ``null`` on the final page. The now-redundant ``?_extra=next_url`` parameter has been removed.
 - The stored query list JSON no longer includes ``has_more`` - ``"next": null`` is the end-of-results signal across the whole API. This change also uncovered and fixed a bug where the query list ``next_url`` pointed at the HTML page and was a relative path; it is now an absolute URL that preserves the requested format.
-- Stored query JSON objects no longer duplicate the list of parameter names as both ``params`` and ``parameters`` - only ``parameters`` remains in the output. ``params`` is still accepted as an input alias when creating or updating queries.
+- Stored query JSON objects no longer duplicate the list of parameter names as both ``params`` and ``parameters`` - only ``parameters`` remains. The query create and update APIs no longer accept ``params`` as an input alias either; ``params`` is still the documented key for :ref:`queries defined in configuration <queries_named_parameters>`.
 - Page size parameters are now consistent across the API: the stored query lists accept ``?_size=max`` and return a ``400`` error for values over the maximum instead of silently clamping them, and the ``/-/allowed`` and ``/-/rules`` permission debug endpoints renamed their ``page`` and ``page_size`` parameters to ``_page`` and ``_size``, matching the underscore grammar used by every other Datasette system parameter.
 - ``/-/threads`` now requires the ``permissions-debug`` permission, since it exposes runtime internals such as file paths. It previously only required ``view-instance``.
 - Trusted stored queries - those defined in configuration - can no longer be deleted through the JSON API or web interface, matching the existing restriction on editing them.
diff --git a/tests/test_queries.py b/tests/test_queries.py
index c25ec358..1cda740e 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -1125,6 +1125,47 @@ async def test_query_update_api_rejects_config_only_fields():
     assert query.on_success_message_sql is None
 
 
+@pytest.mark.asyncio
+async def test_query_api_rejects_params_alias():
+    # "params" is a datasette.yaml configuration key, not an API input -
+    # the API only accepts "parameters"
+    ds = Datasette(memory=True, default_deny=True)
+    ds.root_enabled = True
+    db = ds.add_memory_database("query_params_alias", name="data")
+    await db.execute_write("create table dogs (id integer primary key, name text)")
+    await ds.invoke_startup()
+
+    store_response = await ds.client.post(
+        "/data/-/queries/store",
+        actor={"id": "root"},
+        json={
+            "query": {
+                "name": "by_name",
+                "sql": "select * from dogs where name = :name",
+                "params": ["name"],
+            }
+        },
+    )
+    assert store_response.status_code == 400
+    assert store_response.json()["errors"] == ["Invalid keys: params"]
+    assert await ds.get_query("data", "by_name") is None
+
+    await ds.add_query(
+        "data",
+        "editable",
+        "select * from dogs where name = :name",
+        source="user",
+        owner_id="root",
+    )
+    update_response = await ds.client.post(
+        "/data/editable/-/update",
+        actor={"id": "root"},
+        json={"update": {"params": ["name"]}},
+    )
+    assert update_response.status_code == 400
+    assert update_response.json()["errors"] == ["Invalid keys: params"]
+
+
 @pytest.mark.asyncio
 async def test_query_update_api_rejects_trusted_queries_but_internal_update_allowed():
     ds = Datasette(

From 57ce1a059fce43b32cc54ca4afeeb645e7a6f5af Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Tue, 7 Jul 2026 01:13:33 +0000
Subject: [PATCH 369/386] Tighten unstable marker release note

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 docs/changelog.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 0079aaf2..60918ddf 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -50,7 +50,7 @@ JSON API: other improvements
 - The :ref:`write API <json_api_write>` endpoints now parse the request body as JSON regardless of the ``Content-Type`` header, so ``curl -d`` invocations work without remembering to set it. Invalid JSON is a ``400`` error. Cross-site request forgery remains prevented by Datasette's ``Origin`` and ``Sec-Fetch-Site`` checks. This also fixes a ``500`` error from the insert API when the ``Content-Type`` header was missing entirely.
 - New ``Response.error(messages, status=400)`` helper for plugins that need to return a JSON error in Datasette's standard format. See :ref:`internals_response`.
 - New ``count_truncated`` extra for table JSON, included automatically whenever ``count`` is requested. ``true`` means the count reached Datasette's counting limit and the real number of rows may be higher. See :ref:`json_api_extra`.
-- JSON endpoints that are not part of the documented stable API now declare themselves with an ``"unstable"`` key in their responses, making the stability tier machine-readable.
+- JSON endpoints that are not part of the documented stable API now declare themselves with an ``"unstable"`` key in their responses.
 - New documentation covering the grammar for :ref:`boolean query string arguments <json_api_table_arguments>`, the reason :ref:`upsert <TableUpsertView>` returns ``200`` where insert returns ``201``, and advice for plugin authors on :ref:`naming secret configuration keys <plugins_configuration_secret>` so that ``/-/config`` redacts them automatically.
 
 .. _v1_0_a35:

From 4a853cb10ca6fd0c1aaecf0af7dd26665424c540 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Tue, 7 Jul 2026 05:18:54 +0000
Subject: [PATCH 370/386] Use UNSTABLE_API_MESSAGE constant in tests

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 tests/test_api.py              |  6 ++----
 tests/test_permissions.py      |  6 ++----
 tests/test_queries.py          |  6 ++----
 tests/test_success_envelope.py | 15 +++++----------
 4 files changed, 11 insertions(+), 22 deletions(-)

diff --git a/tests/test_api.py b/tests/test_api.py
index a15a507c..235d394b 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -1,5 +1,6 @@
 from datasette.app import Datasette
 from datasette.plugins import DEFAULT_PLUGINS
+from datasette.utils import UNSTABLE_API_MESSAGE
 from datasette.utils.sqlite import sqlite_version
 from datasette.version import __version__
 from .fixtures import make_app_client, EXPECTED_PLUGINS
@@ -251,10 +252,7 @@ def test_no_files_uses_memory_database(app_client_no_files):
     assert response.status == 200
     assert {
         "ok": True,
-        "unstable": (
-            "This API is not part of Datasette's stable interface"
-            " and may change at any time"
-        ),
+        "unstable": UNSTABLE_API_MESSAGE,
         "databases": [
             {
                 "name": "_memory",
diff --git a/tests/test_permissions.py b/tests/test_permissions.py
index f8d2c808..88fe577f 100644
--- a/tests/test_permissions.py
+++ b/tests/test_permissions.py
@@ -3,6 +3,7 @@ from asgiref.sync import async_to_sync
 from datasette.app import Datasette
 from datasette.cli import cli
 from datasette.default_permissions import restrictions_allow_action
+from datasette.utils import UNSTABLE_API_MESSAGE
 from .fixtures import assert_permissions_checked, make_app_client
 from click.testing import CliRunner
 from bs4 import BeautifulSoup as Soup
@@ -740,10 +741,7 @@ async def test_actor_restricted_permissions(
     }
     expected = {
         "ok": True,
-        "unstable": (
-            "This API is not part of Datasette's stable interface"
-            " and may change at any time"
-        ),
+        "unstable": UNSTABLE_API_MESSAGE,
         "action": permission,
         "allowed": expected_result,
         "resource": expected_resource,
diff --git a/tests/test_queries.py b/tests/test_queries.py
index 1cda740e..a7e492eb 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -8,6 +8,7 @@ from bs4 import BeautifulSoup as Soup
 from datasette.app import Datasette
 from datasette.resources import DatabaseResource, QueryResource
 from datasette.stored_queries import StoredQuery, StoredQueryPage
+from datasette.utils import UNSTABLE_API_MESSAGE
 from datasette.utils.asgi import Forbidden
 from datasette.utils.sqlite import sqlite3, supports_returning
 
@@ -2183,10 +2184,7 @@ async def test_query_parameters_endpoint_uses_get_sql_only():
     assert response.status_code == 200
     assert response.json() == {
         "ok": True,
-        "unstable": "{}".format(
-            "This API is not part of Datasette's stable interface"
-            " and may change at any time"
-        ),
+        "unstable": UNSTABLE_API_MESSAGE,
         "parameters": ["name", "id"],
     }
     assert permission_denied_response.status_code == 403
diff --git a/tests/test_success_envelope.py b/tests/test_success_envelope.py
index 68b042e5..3c413d73 100644
--- a/tests/test_success_envelope.py
+++ b/tests/test_success_envelope.py
@@ -8,7 +8,7 @@ objects separately - see /-/plugins, /-/databases, /-/actions.)
 
 import pytest
 from datasette.app import Datasette
-from datasette.utils import sqlite3
+from datasette.utils import sqlite3, UNSTABLE_API_MESSAGE
 
 
 @pytest.fixture
@@ -114,11 +114,6 @@ async def test_actions_json_is_object(ds_envelope):
     assert "view-instance" in {action["name"] for action in data["actions"]}
 
 
-UNSTABLE_MESSAGE = (
-    "This API is not part of Datasette's stable interface and may change at any time"
-)
-
-
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "path",
@@ -137,7 +132,7 @@ async def test_undocumented_endpoints_report_unstable(ds_client, path):
     finally:
         ds_client.ds.root_enabled = False
     assert response.status_code == 200
-    assert response.json()["unstable"] == UNSTABLE_MESSAGE
+    assert response.json()["unstable"] == UNSTABLE_API_MESSAGE
 
 
 @pytest.mark.asyncio
@@ -148,12 +143,12 @@ async def test_query_store_and_definition_report_unstable(ds_envelope):
         actor={"id": "root"},
     )
     assert store.status_code == 201
-    assert store.json()["unstable"] == UNSTABLE_MESSAGE
+    assert store.json()["unstable"] == UNSTABLE_API_MESSAGE
     definition = await ds_envelope.client.get(
         "/data/unstable_check/-/definition", actor={"id": "root"}
     )
     assert definition.status_code == 200
-    assert definition.json()["unstable"] == UNSTABLE_MESSAGE
+    assert definition.json()["unstable"] == UNSTABLE_API_MESSAGE
 
 
 @pytest.mark.asyncio
@@ -164,7 +159,7 @@ async def test_permissions_post_reports_unstable(ds_envelope):
         actor={"id": "root"},
     )
     assert response.status_code == 200
-    assert response.json()["unstable"] == UNSTABLE_MESSAGE
+    assert response.json()["unstable"] == UNSTABLE_API_MESSAGE
 
 
 @pytest.mark.asyncio

From be25d6e3e41117a2217a986f11ca9467eac6f558 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Tue, 7 Jul 2026 05:18:54 +0000
Subject: [PATCH 371/386] Remove
 test_query_list_json_signals_pagination_via_next_only

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 tests/test_queries.py | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/tests/test_queries.py b/tests/test_queries.py
index a7e492eb..ffa948a9 100644
--- a/tests/test_queries.py
+++ b/tests/test_queries.py
@@ -3866,27 +3866,3 @@ async def test_stored_query_json_uses_parameters_not_params():
     query = [q for q in listing["queries"] if q["name"] == "with_params"][0]
     assert query["parameters"] == ["name", "age"]
     assert "params" not in query
-
-
-@pytest.mark.asyncio
-async def test_query_list_json_signals_pagination_via_next_only():
-    ds = Datasette(memory=True)
-    ds.add_memory_database("query_list_next_only", name="data")
-    await ds.invoke_startup()
-    for i in range(3):
-        await ds.add_query(
-            "data",
-            name="q{}".format(i),
-            sql="select {}".format(i),
-        )
-    first = (await ds.client.get("/data/-/queries.json?_size=2")).json()
-    assert "has_more" not in first
-    assert first["next"] is not None
-    assert first["next_url"] is not None
-    # The internal test client cannot follow absolute URLs
-    next_path = first["next_url"].replace("http://localhost", "")
-    assert next_path.startswith("/data/-/queries.json?")
-    last = (await ds.client.get(next_path)).json()
-    assert "has_more" not in last
-    assert last["next"] is None
-    assert last["next_url"] is None

From b7bbde04bed8efad028d646d636a4364c31cf618 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Tue, 7 Jul 2026 05:18:54 +0000
Subject: [PATCH 372/386] Link the consistency review release note to PR #2824

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GrHZSypDfMnym1tM5XJAFZ
---
 docs/changelog.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 60918ddf..d48ab152 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -17,7 +17,7 @@ Unreleased
 - The table and row JSON APIs now support ``?_extra=column_details`` for returning SQLite schema details for columns, including declared type, SQLite affinity, primary key, ``NOT NULL``, default and hidden-column metadata.
 - POST bodies that Datasette reads fully into memory - such as JSON submitted to the write API - are now capped by the new :ref:`setting_max_post_body_bytes` setting, defaulting to 2MB. Oversized requests are rejected with an HTTP 413 error as soon as the limit is exceeded, protecting smaller servers from memory exhaustion. File uploads are unaffected - ``request.form()`` streams those to disk and has its own separate limits.
 
-This release also includes the results of a detailed consistency review of Datasette's JSON API in preparation for the 1.0 stable release. Several of these changes are backwards-incompatible with previous 1.0 alphas. The new :ref:`API stability documentation <json_api_stability>` describes exactly which parts of the JSON API are covered by the 1.0 stability promise.
+This release also includes the results of a `detailed consistency review <https://github.com/simonw/datasette/pull/2824>`__ of Datasette's JSON API in preparation for the 1.0 stable release. Several of these changes are backwards-incompatible with previous 1.0 alphas. The new :ref:`API stability documentation <json_api_stability>` describes exactly which parts of the JSON API are covered by the 1.0 stability promise.
 
 JSON API: breaking changes
 ~~~~~~~~~~~~~~~~~~~~~~~~~~

From ebd013c6effa52ef74334a4f86e391ed0b622464 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 6 Jul 2026 22:38:40 -0700
Subject: [PATCH 373/386] Bump GitHub Actions versions

---
 .github/workflows/publish.yml | 8 ++++----
 .github/workflows/test.yml    | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 87300593..21ed4c12 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -14,7 +14,7 @@ jobs:
       matrix:
         python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v6
       with:
@@ -35,7 +35,7 @@ jobs:
     permissions:
       id-token: write
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
@@ -56,7 +56,7 @@ jobs:
     needs: [deploy]
     if: "!github.event.release.prerelease"
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
@@ -92,7 +92,7 @@ jobs:
     needs: [deploy]
     if: "!github.event.release.prerelease"
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Build and push to Docker Hub
       env:
         DOCKER_USER: ${{ secrets.DOCKER_USER }}
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index acc2d6b6..9fceca24 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -13,7 +13,7 @@ jobs:
       matrix:
         python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v6
       with:
@@ -54,7 +54,7 @@ jobs:
   test-sqlite-utils-4:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python
       uses: actions/setup-python@v6
       with:

From d2695a0c2f2303a71fbd8959f3a3a3451fd50fca Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Mon, 6 Jul 2026 22:43:04 -0700
Subject: [PATCH 374/386] Test Datasette against sqlite-utils>=4.0rc4

Refs https://github.com/simonw/sqlite-utils/issues/769#issuecomment-4900497417
---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 9fceca24..b8337fc0 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -67,7 +67,7 @@ jobs:
     - name: Install dependencies
       run: |
         pip install . --group dev
-        pip install --pre 'sqlite-utils>=4.0rc3'
+        pip install --pre 'sqlite-utils>=4.0rc4'
         pip freeze
     - name: Run tests
       run: |

From 6f27aa112aba805f8bc82cfeeb29ec31f3e84fb0 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 12:03:28 -0700
Subject: [PATCH 375/386] Test against sqlite-utils>=4.0

https://github.com/simonw/sqlite-utils/issues/769
---
 .github/workflows/test.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index b8337fc0..d2597f01 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -58,7 +58,7 @@ jobs:
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
-        python-version: "3.13"
+        python-version: "3.14"
         cache: pip
         cache-dependency-path: pyproject.toml
     - name: Build extension for --load-extension test
@@ -67,7 +67,7 @@ jobs:
     - name: Install dependencies
       run: |
         pip install . --group dev
-        pip install --pre 'sqlite-utils>=4.0rc4'
+        pip install --pre 'sqlite-utils>=4.0'
         pip freeze
     - name: Run tests
       run: |

From 96e8b8552314e177165496a6fac0ebb17117507c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 13:51:29 -0700
Subject: [PATCH 376/386] Upgrade to sqlite-utils 4.0

---
 .github/workflows/test.yml | 22 ------------
 pyproject.toml             |  2 +-
 tests/test_api_write.py    | 70 ++++++++++++++++----------------------
 3 files changed, 31 insertions(+), 63 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index d2597f01..751eedfd 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -51,25 +51,3 @@ jobs:
       run: |
         pip install datasette-init datasette-json-html
         tests/test-datasette-load-plugins.sh
-  test-sqlite-utils-4:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v7
-    - name: Set up Python
-      uses: actions/setup-python@v6
-      with:
-        python-version: "3.14"
-        cache: pip
-        cache-dependency-path: pyproject.toml
-    - name: Build extension for --load-extension test
-      run: |-
-        (cd tests && gcc ext.c -fPIC -shared -o ext.so)
-    - name: Install dependencies
-      run: |
-        pip install . --group dev
-        pip install --pre 'sqlite-utils>=4.0'
-        pip freeze
-    - name: Run tests
-      run: |
-        pytest -n auto -m "not serial"
-        pytest -m "serial"
diff --git a/pyproject.toml b/pyproject.toml
index 38776b2c..70496cdb 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -35,7 +35,7 @@ dependencies = [
     "PyYAML>=5.3",
     "mergedeep>=1.1.1",
     "itsdangerous>=1.1",
-    "sqlite-utils>=3.30",
+    "sqlite-utils>=4.0",
     "asyncinject>=0.7",
     "setuptools",
     "pip",
diff --git a/tests/test_api_write.py b/tests/test_api_write.py
index 840bd05b..a803fbbc 100644
--- a/tests/test_api_write.py
+++ b/tests/test_api_write.py
@@ -3,28 +3,18 @@ from datasette.events import RenameTableEvent
 from datasette.utils import error_body, escape_sqlite, sqlite3
 from .utils import last_event
 import pytest
-import re
 import time
 
 
-def schema_variants(schema):
-    # sqlite-utils < 4 quotes identifiers [like_this] and uses FLOAT;
-    # sqlite-utils >= 4 quotes them "like_this" and uses REAL. Given a
-    # schema fragment in the old format, return both variants so tests
-    # can pass against either version.
-    converted = re.sub(r"\[([^\]]+)\]", r'"\1"', schema).replace("FLOAT", "REAL")
-    return (schema, converted)
-
-
 def assert_schema_contains(fragment, schema):
-    assert any(
-        variant in schema for variant in schema_variants(fragment)
-    ), "Expected schema to contain {!r}, got {!r}".format(fragment, schema)
+    assert fragment in schema, "Expected schema to contain {!r}, got {!r}".format(
+        fragment, schema
+    )
 
 
 def assert_schema_not_contains(fragment, schema):
-    assert not any(
-        variant in schema for variant in schema_variants(fragment)
+    assert (
+        fragment not in schema
     ), "Expected schema not to contain {!r}, got {!r}".format(fragment, schema)
 
 
@@ -94,8 +84,8 @@ async def test_base64_write_api_create_table_infers_blob_and_raw_escapes(ds_writ
         headers=_headers(token),
     )
     assert response.status_code == 201
-    assert_schema_contains("[data] BLOB", response.json()["schema"])
-    assert_schema_contains("[literal] TEXT", response.json()["schema"])
+    assert_schema_contains('"data" BLOB', response.json()["schema"])
+    assert_schema_contains('"literal" TEXT', response.json()["schema"])
 
     rows = (await ds_write.get_database("data").execute("""
             select
@@ -1217,7 +1207,7 @@ async def test_alter_table_foreign_key_operations(ds_write):
     data = response.json()
     assert data["operations_applied"] == 2
     assert_schema_contains(
-        "[owner_id] INTEGER REFERENCES [owners]([id])", data["schema"]
+        '"owner_id" INTEGER REFERENCES "owners"("id")', data["schema"]
     )
 
     response = await ds_write.client.post(
@@ -1229,7 +1219,7 @@ async def test_alter_table_foreign_key_operations(ds_write):
     )
     assert response.status_code == 200, response.text
     data = response.json()
-    assert_schema_not_contains("[owner_id] INTEGER REFERENCES", data["schema"])
+    assert_schema_not_contains('"owner_id" INTEGER REFERENCES', data["schema"])
 
     response = await ds_write.client.post(
         "/data/docs/-/alter",
@@ -1254,7 +1244,7 @@ async def test_alter_table_foreign_key_operations(ds_write):
     assert response.status_code == 200, response.text
     data = response.json()
     assert_schema_contains(
-        "[owner_id] INTEGER REFERENCES [categories]([id])", data["schema"]
+        '"owner_id" INTEGER REFERENCES "categories"("id")', data["schema"]
     )
 
     response = await ds_write.client.post(
@@ -1264,7 +1254,7 @@ async def test_alter_table_foreign_key_operations(ds_write):
     )
     assert response.status_code == 200, response.text
     data = response.json()
-    assert_schema_not_contains("[owner_id] INTEGER REFERENCES", data["schema"])
+    assert_schema_not_contains('"owner_id" INTEGER REFERENCES', data["schema"])
 
 
 @pytest.mark.asyncio
@@ -1791,12 +1781,12 @@ async def test_drop_table(ds_write, scenario):
                 "table_url": "http://localhost/data/one",
                 "table_api_url": "http://localhost/data/one.json",
                 "schema": (
-                    "CREATE TABLE [one] (\n"
-                    "   [id] INTEGER PRIMARY KEY,\n"
-                    "   [title] TEXT,\n"
-                    "   [score] INTEGER,\n"
-                    "   [weight] FLOAT,\n"
-                    "   [thumbnail] BLOB\n"
+                    'CREATE TABLE "one" (\n'
+                    '   "id" INTEGER PRIMARY KEY,\n'
+                    '   "title" TEXT,\n'
+                    '   "score" INTEGER,\n'
+                    '   "weight" REAL,\n'
+                    '   "thumbnail" BLOB\n'
                     ")"
                 ),
             },
@@ -1828,10 +1818,10 @@ async def test_drop_table(ds_write, scenario):
                 "table_url": "http://localhost/data/two",
                 "table_api_url": "http://localhost/data/two.json",
                 "schema": (
-                    "CREATE TABLE [two] (\n"
-                    "   [id] INTEGER PRIMARY KEY,\n"
-                    "   [title] TEXT,\n"
-                    "   [score] FLOAT\n"
+                    'CREATE TABLE "two" (\n'
+                    '   "id" INTEGER PRIMARY KEY,\n'
+                    '   "title" TEXT,\n'
+                    '   "score" REAL\n'
                     ")"
                 ),
                 "row_count": 2,
@@ -1857,10 +1847,10 @@ async def test_drop_table(ds_write, scenario):
                 "table_url": "http://localhost/data/three",
                 "table_api_url": "http://localhost/data/three.json",
                 "schema": (
-                    "CREATE TABLE [three] (\n"
-                    "   [id] INTEGER PRIMARY KEY,\n"
-                    "   [title] TEXT,\n"
-                    "   [score] FLOAT\n"
+                    'CREATE TABLE "three" (\n'
+                    '   "id" INTEGER PRIMARY KEY,\n'
+                    '   "title" TEXT,\n'
+                    '   "score" REAL\n'
                     ")"
                 ),
                 "row_count": 1,
@@ -1882,7 +1872,7 @@ async def test_drop_table(ds_write, scenario):
                 "table": "four",
                 "table_url": "http://localhost/data/four",
                 "table_api_url": "http://localhost/data/four.json",
-                "schema": ("CREATE TABLE [four] (\n" "   [name] TEXT\n" ")"),
+                "schema": ('CREATE TABLE "four" (\n' '   "name" TEXT\n' ")"),
                 "row_count": 1,
             },
             ["create-table", "insert-rows"],
@@ -1902,8 +1892,8 @@ async def test_drop_table(ds_write, scenario):
                 "table_url": "http://localhost/data/five",
                 "table_api_url": "http://localhost/data/five.json",
                 "schema": (
-                    "CREATE TABLE [five] (\n   [type] TEXT,\n   [key] INTEGER,\n"
-                    "   [title] TEXT,\n   PRIMARY KEY ([type], [key])\n)"
+                    'CREATE TABLE "five" (\n   "type" TEXT,\n   "key" INTEGER,\n'
+                    '   "title" TEXT,\n   PRIMARY KEY ("type", "key")\n)'
                 ),
                 "row_count": 1,
             },
@@ -2193,7 +2183,7 @@ async def test_create_table(
         # Error expectations list their messages; derive the canonical envelope
         expected_response = error_body(expected_response["errors"], expected_status)
     if isinstance(expected_response, dict) and "schema" in expected_response:
-        assert data.get("schema") in schema_variants(expected_response["schema"])
+        assert data.get("schema") == expected_response["schema"]
         expected_response = dict(expected_response, schema=data.get("schema"))
     assert data == expected_response
     # Should have tracked the expected events
@@ -2238,7 +2228,7 @@ async def test_create_table_with_foreign_key(ds_write):
     assert response.status_code == 201
     data = response.json()
     assert_schema_contains(
-        "[owner_id] INTEGER REFERENCES [owners]([id])", data["schema"]
+        '"owner_id" INTEGER REFERENCES "owners"("id")', data["schema"]
     )
 
 

From db7ba1d30c0fb9e9e6eb2e39403a062fd93a973d Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 13:58:48 -0700
Subject: [PATCH 377/386] Switch to sqlite-utils migrations for internal.db,
 closes #2827

---
 datasette/utils/internal_db.py | 165 +++++++++++++++++++++------------
 tests/test_internal_db.py      |  49 ++++++++++
 2 files changed, 153 insertions(+), 61 deletions(-)

diff --git a/datasette/utils/internal_db.py b/datasette/utils/internal_db.py
index bf172667..10ca32a5 100644
--- a/datasette/utils/internal_db.py
+++ b/datasette/utils/internal_db.py
@@ -1,9 +1,30 @@
 import textwrap
+
+from sqlite_utils import Database as SQLiteUtilsDatabase
+from sqlite_utils import Migrations
+
 from datasette.utils import table_column_details
 
+INTERNAL_DB_SCHEMA_TABLES = {
+    "catalog_databases",
+    "catalog_tables",
+    "catalog_views",
+    "catalog_columns",
+    "catalog_indexes",
+    "catalog_foreign_keys",
+    "metadata_instance",
+    "metadata_databases",
+    "metadata_resources",
+    "metadata_columns",
+    "column_types",
+    "queries",
+}
 
-async def init_internal_db(db):
-    create_tables_sql = textwrap.dedent("""
+INTERNAL_DB_SCHEMA_INDEXES = {
+    "queries_owner_idx",
+}
+
+INTERNAL_DB_SCHEMA_SQL = textwrap.dedent("""
     CREATE TABLE IF NOT EXISTS catalog_databases (
         database_name TEXT PRIMARY KEY,
         path TEXT,
@@ -67,74 +88,96 @@ async def init_internal_db(db):
         FOREIGN KEY (database_name) REFERENCES catalog_databases(database_name),
         FOREIGN KEY (database_name, table_name) REFERENCES catalog_tables(database_name, table_name)
     );
+
+    CREATE TABLE IF NOT EXISTS metadata_instance (
+        key text,
+        value text,
+        unique(key)
+    );
+
+    CREATE TABLE IF NOT EXISTS metadata_databases (
+        database_name text,
+        key text,
+        value text,
+        unique(database_name, key)
+    );
+
+    CREATE TABLE IF NOT EXISTS metadata_resources (
+        database_name text,
+        resource_name text,
+        key text,
+        value text,
+        unique(database_name, resource_name, key)
+    );
+
+    CREATE TABLE IF NOT EXISTS metadata_columns (
+        database_name text,
+        resource_name text,
+        column_name text,
+        key text,
+        value text,
+        unique(database_name, resource_name, column_name, key)
+    );
+
+    CREATE TABLE IF NOT EXISTS column_types (
+        database_name TEXT NOT NULL,
+        resource_name TEXT NOT NULL,
+        column_name TEXT NOT NULL,
+        column_type TEXT NOT NULL,
+        config TEXT,
+        PRIMARY KEY (database_name, resource_name, column_name)
+    );
+
+    CREATE TABLE IF NOT EXISTS queries (
+        database_name TEXT NOT NULL,
+        name TEXT NOT NULL,
+        sql TEXT NOT NULL,
+        title TEXT,
+        description TEXT,
+        description_html TEXT,
+        options TEXT NOT NULL DEFAULT '{}',
+        parameters TEXT NOT NULL DEFAULT '[]',
+        is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
+        is_private INTEGER NOT NULL DEFAULT 0 CHECK (is_private IN (0, 1)),
+        is_trusted INTEGER NOT NULL DEFAULT 0 CHECK (is_trusted IN (0, 1)),
+        source TEXT NOT NULL DEFAULT 'user',
+        owner_id TEXT,
+        created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+        updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+        PRIMARY KEY (database_name, name)
+    );
+
+    CREATE INDEX IF NOT EXISTS queries_owner_idx
+        ON queries(owner_id);
     """).strip()
-    await db.execute_write_script(create_tables_sql)
-    await initialize_metadata_tables(db)
 
 
-async def initialize_metadata_tables(db):
-    await db.execute_write_script(textwrap.dedent("""
-        CREATE TABLE IF NOT EXISTS metadata_instance (
-            key text,
-            value text,
-            unique(key)
-        );
+internal_migrations = Migrations("datasette_internal")
 
-        CREATE TABLE IF NOT EXISTS metadata_databases (
-            database_name text,
-            key text,
-            value text,
-            unique(database_name, key)
-        );
 
-        CREATE TABLE IF NOT EXISTS metadata_resources (
-            database_name text,
-            resource_name text,
-            key text,
-            value text,
-            unique(database_name, resource_name, key)
-        );
+def _internal_schema_exists(db):
+    table_names = set(db.table_names())
+    if not INTERNAL_DB_SCHEMA_TABLES.issubset(table_names):
+        return False
+    index_names = {
+        row[0]
+        for row in db.execute("select name from sqlite_master where type = 'index'")
+    }
+    return INTERNAL_DB_SCHEMA_INDEXES.issubset(index_names)
 
-        CREATE TABLE IF NOT EXISTS metadata_columns (
-            database_name text,
-            resource_name text,
-            column_name text,
-            key text,
-            value text,
-            unique(database_name, resource_name, column_name, key)
-        );
 
-        CREATE TABLE IF NOT EXISTS column_types (
-            database_name TEXT NOT NULL,
-            resource_name TEXT NOT NULL,
-            column_name TEXT NOT NULL,
-            column_type TEXT NOT NULL,
-            config TEXT,
-            PRIMARY KEY (database_name, resource_name, column_name)
-        );
+@internal_migrations(name="0001_initial")
+def initial_internal_schema(db):
+    if _internal_schema_exists(db):
+        return
+    db.executescript(INTERNAL_DB_SCHEMA_SQL)
 
-        CREATE TABLE IF NOT EXISTS queries (
-            database_name TEXT NOT NULL,
-            name TEXT NOT NULL,
-            sql TEXT NOT NULL,
-            title TEXT,
-            description TEXT,
-            description_html TEXT,
-            options TEXT NOT NULL DEFAULT '{}',
-            parameters TEXT NOT NULL DEFAULT '[]',
-            is_write INTEGER NOT NULL DEFAULT 0 CHECK (is_write IN (0, 1)),
-            is_private INTEGER NOT NULL DEFAULT 0 CHECK (is_private IN (0, 1)),
-            is_trusted INTEGER NOT NULL DEFAULT 0 CHECK (is_trusted IN (0, 1)),
-            source TEXT NOT NULL DEFAULT 'user',
-            owner_id TEXT,
-            created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
-            updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
-            PRIMARY KEY (database_name, name)
-        );
 
-        CREATE INDEX IF NOT EXISTS queries_owner_idx
-            ON queries(owner_id);
-            """))
+async def init_internal_db(db):
+    def apply_migrations(conn):
+        internal_migrations.apply(SQLiteUtilsDatabase(conn, execute_plugins=False))
+
+    await db.execute_write_fn(apply_migrations, transaction=False)
 
 
 async def populate_schema_tables(internal_db, db):
diff --git a/tests/test_internal_db.py b/tests/test_internal_db.py
index 340c4813..e1ab51bb 100644
--- a/tests/test_internal_db.py
+++ b/tests/test_internal_db.py
@@ -1,6 +1,8 @@
 import pytest
+import sqlite3
 
 from datasette.utils import escape_sqlite
+from datasette.utils.internal_db import INTERNAL_DB_SCHEMA_SQL
 
 
 # ensure refresh_schemas() gets called before interacting with internal_db
@@ -17,6 +19,53 @@ async def test_internal_databases(ds_client):
     assert databases.rows[0]["database_name"] == "fixtures"
 
 
+@pytest.mark.asyncio
+async def test_internal_migrations_recorded(ds_client):
+    internal_db = await ensure_internal(ds_client)
+    migrations = await internal_db.execute("""
+        select migration_set, name
+        from _sqlite_migrations
+        order by id
+        """)
+    assert [tuple(row) for row in migrations.rows] == [
+        ("datasette_internal", "0001_initial")
+    ]
+
+
+@pytest.mark.asyncio
+async def test_internal_migrations_adopt_existing_internal_db(tmp_path):
+    from datasette.app import Datasette
+
+    internal_db_path = str(tmp_path / "internal.db")
+    conn = sqlite3.connect(internal_db_path)
+    conn.executescript(INTERNAL_DB_SCHEMA_SQL)
+    conn.execute(
+        "insert into metadata_instance (key, value) values (?, ?)",
+        ("legacy", "preserved"),
+    )
+    conn.commit()
+    conn.close()
+
+    ds = Datasette(internal=internal_db_path)
+    await ds.invoke_startup()
+    internal_db = ds.get_internal_database()
+
+    metadata = await internal_db.execute(
+        "select key, value from metadata_instance where key = 'legacy'"
+    )
+    assert [tuple(row) for row in metadata.rows] == [("legacy", "preserved")]
+    migrations = await internal_db.execute("""
+        select migration_set, name
+        from _sqlite_migrations
+        order by id
+        """)
+    assert [tuple(row) for row in migrations.rows] == [
+        ("datasette_internal", "0001_initial")
+    ]
+
+    ds.close()
+
+
 @pytest.mark.asyncio
 async def test_internal_tables(ds_client):
     internal_db = await ensure_internal(ds_client)

From a926ab392e6ecf0264bb8d90c0b0411800c498c7 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 14:02:02 -0700
Subject: [PATCH 378/386] Updated internals.rst schema using cog, refs #2827

---
 docs/internals.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/docs/internals.rst b/docs/internals.rst
index 7258e6f3..2048c7e4 100644
--- a/docs/internals.rst
+++ b/docs/internals.rst
@@ -2363,6 +2363,14 @@ The internal database schema is as follows:
 
 .. code-block:: sql
 
+    CREATE TABLE "_sqlite_migrations" (
+       "id" INTEGER PRIMARY KEY,
+       "migration_set" TEXT,
+       "name" TEXT,
+       "applied_at" TEXT
+    );
+    CREATE UNIQUE INDEX "idx__sqlite_migrations_migration_set_name"
+        ON "_sqlite_migrations" ("migration_set", "name");
     CREATE TABLE catalog_databases (
         database_name TEXT PRIMARY KEY,
         path TEXT,

From 7f37205e7696e8876bfd8fb0d14b543b66a748bf Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 14:04:46 -0700
Subject: [PATCH 379/386] Remove Datasette Desktop from installation guide

Until I have time to fix it up and bring it back.
---
 docs/installation.rst | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/docs/installation.rst b/docs/installation.rst
index 33d3d6a1..ceec7f23 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -17,13 +17,6 @@ If you want to start making contributions to the Datasette project by installing
 Basic installation
 ==================
 
-.. _installation_datasette_desktop:
-
-Datasette Desktop for Mac
--------------------------
-
-`Datasette Desktop <https://datasette.io/desktop>`__ is a packaged Mac application which bundles Datasette together with Python and allows you to install and run Datasette directly on your laptop. This is the best option for local installation if you are not comfortable using the command line.
-
 .. _installation_homebrew:
 
 Using Homebrew

From 617acedd387ff80769c6b40c7b673d2c489fc346 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 14:18:10 -0700
Subject: [PATCH 380/386] Remove readthedocs/actions/preview

Closes #2828
---
 .github/workflows/documentation-links.yml | 16 ----------------
 docs/changelog.rst                        | 10 +++++++---
 2 files changed, 7 insertions(+), 19 deletions(-)
 delete mode 100644 .github/workflows/documentation-links.yml

diff --git a/.github/workflows/documentation-links.yml b/.github/workflows/documentation-links.yml
deleted file mode 100644
index b8fb8aaa..00000000
--- a/.github/workflows/documentation-links.yml
+++ /dev/null
@@ -1,16 +0,0 @@
-name: Read the Docs Pull Request Preview
-on:
-  pull_request:
-    types:
-      - opened
-
-permissions:
-  pull-requests: write
-
-jobs:
-  documentation-links:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: readthedocs/actions/preview@v1
-        with:
-          project-slug: "datasette"
diff --git a/docs/changelog.rst b/docs/changelog.rst
index d48ab152..de2ca85b 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -12,10 +12,14 @@ Unreleased
 - Table pages now offer an "Insert multiple rows" mode in the row insertion dialog. This accepts pasted TSV, CSV or JSON, previews the parsed rows before inserting them, validates unknown columns as data is pasted and displays omitted auto integer primary keys as ``auto`` in the preview. (:pr:`2813`)
 - The bulk insert UI can skip rows with existing primary keys, or update existing rows and insert new rows using the existing ``/<database>/<table>/-/upsert`` API when the actor has both :ref:`insert-row <actions_insert_row>` and :ref:`update-row <actions_update_row>` permissions. (:pr:`2813`)
 - The "Create table" dialog now includes a "Create table from data" mode. Paste TSV, CSV or JSON rows to preview inferred columns and types, choose the table name and primary key, then create the table and insert those rows in one step. (:pr:`2813`)
-- Datasette's JSON APIs now consistently encode every ``BLOB`` value using the documented :ref:`binary value JSON format <binary_json_format>`, even when the bytes could be decoded as UTF-8 text.
-- The insert and edit row dialogs now provide a dedicated control for ``BLOB`` values. Existing binary values are shown by byte size, image values under 10MB are previewed as thumbnails, and replacements can be attached, dropped or pasted into the control.
+- Datasette's JSON APIs now consistently encode every ``BLOB`` value using the documented :ref:`binary value JSON format <binary_json_format>`, even when the bytes could be decoded as UTF-8 text. (:issue:`2806`, :pr:`2822`)
+- The insert and edit row dialogs now provide a dedicated control for ``BLOB`` values. Existing binary values are shown by byte size, image values under 10MB are previewed as thumbnails, and replacements can be attached, dropped or pasted into the control. (:issue:`2806`, :pr:`2822`)
 - The table and row JSON APIs now support ``?_extra=column_details`` for returning SQLite schema details for columns, including declared type, SQLite affinity, primary key, ``NOT NULL``, default and hidden-column metadata.
-- POST bodies that Datasette reads fully into memory - such as JSON submitted to the write API - are now capped by the new :ref:`setting_max_post_body_bytes` setting, defaulting to 2MB. Oversized requests are rejected with an HTTP 413 error as soon as the limit is exceeded, protecting smaller servers from memory exhaustion. File uploads are unaffected - ``request.form()`` streams those to disk and has its own separate limits.
+- POST bodies that Datasette reads fully into memory - such as JSON submitted to the write API - are now capped by the new :ref:`setting_max_post_body_bytes` setting, defaulting to 2MB. Oversized requests are rejected with an HTTP 413 error as soon as the limit is exceeded, protecting smaller servers from memory exhaustion. File uploads are unaffected - ``request.form()`` streams those to disk and has its own separate limits. (:issue:`2823`)
+- The :ref:`execute-write-sql <actions_execute_write_sql>` interface now supports ``CREATE VIEW`` and ``DROP VIEW`` statements, gated by the new :ref:`create-view <actions_create_view>` and :ref:`drop-view <actions_drop_view>` permissions. (:issue:`2819`, :pr:`2818`)
+- Saved-query SQL analysis now handles recursive CTEs, fixing a bug where storing a valid read-only recursive query could be disabled by SQLite's internal ``SQLITE_RECURSIVE`` authorizer callback. (:issue:`2809`, :pr:`2812`)
+- Datasette's internal database schema is now managed using `sqlite-utils migrations <https://sqlite-utils.datasette.io/en/stable/python-api.html#migrations>`__, using the new dependency on ``sqlite-utils>=4.0``. (:issue:`2827`)
+- ``datasette.utils.CustomJSONEncoder`` is now documented as a public API for plugins that need to serialize Datasette values to JSON. Thanks, `Chris Amico <https://github.com/eyeseast>`__. (:issue:`1983`, :pr:`1996`)
 
 This release also includes the results of a `detailed consistency review <https://github.com/simonw/datasette/pull/2824>`__ of Datasette's JSON API in preparation for the 1.0 stable release. Several of these changes are backwards-incompatible with previous 1.0 alphas. The new :ref:`API stability documentation <json_api_stability>` describes exactly which parts of the JSON API are covered by the 1.0 stability promise.
 

From 211e70d4e1f1f7d99e06b378993f26e8cbd8937a Mon Sep 17 00:00:00 2001
From: Zain Dana Harper <zaindharper@gmail.com>
Date: Tue, 7 Jul 2026 14:19:08 -0700
Subject: [PATCH 381/386] Return 400 not 500 for wrong-arity composite-PK row
 URLs (#2815)

Fixes #2811

Co-authored-by: Zain Dana Harper <zain@aurora-framework.dev>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
---
 datasette/app.py  |  5 +++++
 tests/test_api.py | 34 ++++++++++++++++++++++++++++++++++
 2 files changed, 39 insertions(+)

diff --git a/datasette/app.py b/datasette/app.py
index 9c7e768b..4ba5d20f 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -134,6 +134,7 @@ from .utils import (
 from .tokens import TokenInvalid
 from .utils.asgi import (
     AsgiLifespan,
+    BadRequest,
     Forbidden,
     NotFound,
     DatabaseNotFound,
@@ -2820,6 +2821,10 @@ class Datasette:
         db, table_name, _ = await self.resolve_table(request)
         pk_values = urlsafe_components(request.url_vars["pks"])
         sql, params, pks = await row_sql_params_pks(db, table_name, pk_values)
+        if len(pk_values) != len(pks):
+            raise BadRequest(
+                "URL row identifier does not match the primary key for this table"
+            )
         results = await db.execute(sql, params, truncate=True)
         row = results.first()
         if row is None:
diff --git a/tests/test_api.py b/tests/test_api.py
index 235d394b..5ed14283 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -369,6 +369,40 @@ async def test_row(ds_client):
     assert response.json()["rows"] == [{"id": 1, "content": "hello"}]
 
 
+@pytest.mark.asyncio
+@pytest.mark.parametrize("suffix", ("", ".json"))
+@pytest.mark.parametrize(
+    "row_path",
+    (
+        "a",  # too few components for a two-column primary key
+        "a,b,c",  # too many components for a two-column primary key
+    ),
+)
+async def test_row_pk_arity_mismatch_returns_400(ds_client, row_path, suffix):
+    # A row URL with the wrong number of comma-separated primary key
+    # components used to raise an uncaught sqlite3.ProgrammingError (HTTP 500)
+    # because the SQL had one bind placeholder per PK column but params were
+    # only bound for the supplied components. It should be a 400 instead,
+    # mirroring the existing guard in datasette/views/table.py.
+    response = await ds_client.get(
+        "/fixtures/compound_primary_key/{}{}".format(row_path, suffix)
+    )
+    assert response.status_code == 400
+    if suffix == ".json":
+        assert response.json()["ok"] is False
+        assert response.json()["status"] == 400
+
+
+@pytest.mark.asyncio
+async def test_row_compound_pk_correct_arity(ds_client):
+    # The valid two-component URL still resolves the row.
+    response = await ds_client.get(
+        "/fixtures/compound_primary_key/a,b.json?_shape=objects"
+    )
+    assert response.status_code == 200
+    assert response.json()["rows"] == [{"pk1": "a", "pk2": "b", "content": "c"}]
+
+
 @pytest.mark.asyncio
 async def test_row_strange_table_name(ds_client):
     response = await ds_client.get(

From bf3e277c9819b45ae34810ff5aafd794fd7ff4b9 Mon Sep 17 00:00:00 2001
From: JSap0914 <116227558+JSap0914@users.noreply.github.com>
Date: Wed, 8 Jul 2026 06:23:31 +0900
Subject: [PATCH 382/386] Fix named_parameters when string literals contain
 comment markers (#2783)

named_parameters stripped SQL comments before string literals in
separate passes. A string literal such as '-- TODO' would be treated
as the start of a line comment, swallowing the rest of the line and
hiding any named parameters that followed it. For example:

    select * from t where note = '-- TODO' and id = :id

returned [] instead of ['id'], so the query parameter input form
would be missing the :id field.

Match comments and string literals in a single left-to-right pass so
that whichever construct starts first wins, matching how SQL is
actually tokenized.

Co-authored-by: JSap0914 <JSap0914@users.noreply.github.com>
---
 datasette/utils/__init__.py | 23 +++++++++++++++--------
 tests/test_utils.py         | 10 ++++++++++
 2 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 64c63dde..7b9a90b9 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -1288,10 +1288,18 @@ class StartupError(Exception):
     pass
 
 
-_single_line_comment_re = re.compile(r"--.*")
-_multi_line_comment_re = re.compile(r"/\*.*?\*/", re.DOTALL)
-_single_quote_re = re.compile(r"'(?:''|[^'])*'")
-_double_quote_re = re.compile(r'"(?:\"\"|[^"])*"')
+# Comments and string literals, matched in a single pass so that whichever
+# construct starts first "wins" - this ensures a comment marker inside a string
+# literal (or a quote inside a comment) does not confuse the parameter scan.
+_comments_and_strings_re = re.compile(
+    r"""
+    --[^\n]*            # single line comment
+    | /\*.*?\*/         # multi line comment
+    | '(?:''|[^'])*'    # single quoted string ('' escapes a quote)
+    | "(?:""|[^"])*"    # double quoted identifier ("" escapes a quote)
+    """,
+    re.DOTALL | re.VERBOSE,
+)
 _named_param_re = re.compile(r":(\w+)")
 
 
@@ -1302,10 +1310,9 @@ def named_parameters(sql: str) -> List[str]:
 
     e.g. for ``select * from foo where id=:id`` this would return ``["id"]``
     """
-    sql = _single_line_comment_re.sub("", sql)
-    sql = _multi_line_comment_re.sub("", sql)
-    sql = _single_quote_re.sub("", sql)
-    sql = _double_quote_re.sub("", sql)
+    # Strip comments and string literals first so that any ":name" sequences
+    # inside them are not mistaken for named parameters
+    sql = _comments_and_strings_re.sub("", sql)
     # Extract parameters from what is left
     return _named_param_re.findall(sql)
 
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 46dcd89d..0b2fcd2b 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -756,6 +756,16 @@ def test_parse_metadata(content, expected):
         ("select 1 + :one + :two", ["one", "two"]),
         ("select 'bob' || '0:00' || :cat", ["cat"]),
         ("select this is invalid :one, :two, :three", ["one", "two", "three"]),
+        # A string literal containing a comment marker should not hide
+        # parameters that come after it
+        ("select * from t where note = '-- TODO' and id = :id", ["id"]),
+        ("select '--' || :y", ["y"]),
+        ("select * from t where note = '/* x */' and id = :id", ["id"]),
+        # Parameters that live inside a comment should be ignored
+        ("select :x -- and :ignored", ["x"]),
+        ("select :x /* and :ignored */ from t", ["x"]),
+        # Parameters inside a string literal should be ignored
+        ("select ':ignored' || :real", ["real"]),
     ),
 )
 @pytest.mark.parametrize("use_async_version", (False, True))

From 54597f22fafb1744718b98f3018da595374f8e7e Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 14:26:34 -0700
Subject: [PATCH 383/386] A few more SQLite string fixes, refs #2783

---
 datasette/utils/__init__.py | 4 +++-
 tests/test_utils.py         | 5 +++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py
index 7b9a90b9..42574d3b 100644
--- a/datasette/utils/__init__.py
+++ b/datasette/utils/__init__.py
@@ -1294,9 +1294,11 @@ class StartupError(Exception):
 _comments_and_strings_re = re.compile(
     r"""
     --[^\n]*            # single line comment
-    | /\*.*?\*/         # multi line comment
+    | /\*.*?(?:\*/|\Z)  # multi line comment, possibly to end-of-input
     | '(?:''|[^'])*'    # single quoted string ('' escapes a quote)
     | "(?:""|[^"])*"    # double quoted identifier ("" escapes a quote)
+    | \[(?:[^\]])*\]    # square-bracket quoted identifier
+    | `(?:``|[^`])*`    # backtick quoted identifier
     """,
     re.DOTALL | re.VERBOSE,
 )
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 0b2fcd2b..a535ca93 100644
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -764,6 +764,11 @@ def test_parse_metadata(content, expected):
         # Parameters that live inside a comment should be ignored
         ("select :x -- and :ignored", ["x"]),
         ("select :x /* and :ignored */ from t", ["x"]),
+        ("select :x /* and :ignored", ["x"]),
+        # Parameters inside quoted identifiers should be ignored
+        ("select [a:b] from t where id = :id", ["id"]),
+        ("select `a:b` from t where id = :id", ["id"]),
+        ("select `a``:b` from t where id = :id", ["id"]),
         # Parameters inside a string literal should be ignored
         ("select ':ignored' || :real", ["real"]),
     ),

From a31673c90b56ba72b50d037ff60829070d32e85c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 14:26:48 -0700
Subject: [PATCH 384/386] Changelog for #2811, #2815, #2783

---
 docs/changelog.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index de2ca85b..c217192b 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -16,8 +16,10 @@ Unreleased
 - The insert and edit row dialogs now provide a dedicated control for ``BLOB`` values. Existing binary values are shown by byte size, image values under 10MB are previewed as thumbnails, and replacements can be attached, dropped or pasted into the control. (:issue:`2806`, :pr:`2822`)
 - The table and row JSON APIs now support ``?_extra=column_details`` for returning SQLite schema details for columns, including declared type, SQLite affinity, primary key, ``NOT NULL``, default and hidden-column metadata.
 - POST bodies that Datasette reads fully into memory - such as JSON submitted to the write API - are now capped by the new :ref:`setting_max_post_body_bytes` setting, defaulting to 2MB. Oversized requests are rejected with an HTTP 413 error as soon as the limit is exceeded, protecting smaller servers from memory exhaustion. File uploads are unaffected - ``request.form()`` streams those to disk and has its own separate limits. (:issue:`2823`)
+- Row pages for tables with compound primary keys now return a ``400`` error instead of a ``500`` error when the URL row identifier does not contain the correct number of primary key values. Thanks, `Zain Dana Harper <https://github.com/HarperZ9>`__. (:issue:`2811`, :pr:`2815`)
 - The :ref:`execute-write-sql <actions_execute_write_sql>` interface now supports ``CREATE VIEW`` and ``DROP VIEW`` statements, gated by the new :ref:`create-view <actions_create_view>` and :ref:`drop-view <actions_drop_view>` permissions. (:issue:`2819`, :pr:`2818`)
 - Saved-query SQL analysis now handles recursive CTEs, fixing a bug where storing a valid read-only recursive query could be disabled by SQLite's internal ``SQLITE_RECURSIVE`` authorizer callback. (:issue:`2809`, :pr:`2812`)
+- ``named_parameters()`` now correctly ignores SQLite comment markers that appear inside string literals, so query forms no longer drop later ``:named`` parameters from SQL such as ``select '--' || :name``. Thanks, `JSap0914 <https://github.com/JSap0914>`__. (:pr:`2783`)
 - Datasette's internal database schema is now managed using `sqlite-utils migrations <https://sqlite-utils.datasette.io/en/stable/python-api.html#migrations>`__, using the new dependency on ``sqlite-utils>=4.0``. (:issue:`2827`)
 - ``datasette.utils.CustomJSONEncoder`` is now documented as a public API for plugins that need to serialize Datasette values to JSON. Thanks, `Chris Amico <https://github.com/eyeseast>`__. (:issue:`1983`, :pr:`1996`)
 

From 52ae7d1b6d2ed738904677a80edc0e61ef85fac2 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 14:32:25 -0700
Subject: [PATCH 385/386] Release 1.0a36

Refs
#1983, #1996, #2783, #2806, #2809, #2811, #2812, #2813, #2815, #2818, #2819, #2822, #2823, #2827
---
 datasette/version.py | 2 +-
 docs/changelog.rst   | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/datasette/version.py b/datasette/version.py
index 49d270e4..387144e9 100644
--- a/datasette/version.py
+++ b/datasette/version.py
@@ -1,2 +1,2 @@
-__version__ = "1.0a35"
+__version__ = "1.0a36"
 __version_info__ = tuple(__version__.split("."))
diff --git a/docs/changelog.rst b/docs/changelog.rst
index c217192b..e3718543 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -4,10 +4,12 @@
 Changelog
 =========
 
-.. _unreleased:
+.. _v1_0_a36:
 
-Unreleased
-----------
+1.0a36 (2026-07-07)
+-------------------
+
+The signature features of this alpha are new UIs for **inserting multiple rows at once** (from TSV, CSV or JSON) and for **creating a table from rows**, plus a large number of small **JSON API consistency fixes** in preparation for a 1.0 stable release.
 
 - Table pages now offer an "Insert multiple rows" mode in the row insertion dialog. This accepts pasted TSV, CSV or JSON, previews the parsed rows before inserting them, validates unknown columns as data is pasted and displays omitted auto integer primary keys as ``auto`` in the preview. (:pr:`2813`)
 - The bulk insert UI can skip rows with existing primary keys, or update existing rows and insert new rows using the existing ``/<database>/<table>/-/upsert`` API when the actor has both :ref:`insert-row <actions_insert_row>` and :ref:`update-row <actions_update_row>` permissions. (:pr:`2813`)

From db82123108dec69ffc8541c815ae57a46ae45727 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Tue, 7 Jul 2026 14:40:33 -0700
Subject: [PATCH 386/386] Bump a whole lot of GitHub Actions versions

---
 .github/workflows/deploy-latest.yml       | 2 +-
 .github/workflows/playwright.yml          | 6 +++---
 .github/workflows/prettier.yml            | 4 ++--
 .github/workflows/push_docker_tag.yml     | 2 +-
 .github/workflows/spellcheck.yml          | 2 +-
 .github/workflows/stable-docs.yml         | 2 +-
 .github/workflows/test-coverage.yml       | 2 +-
 .github/workflows/test-pyodide.yml        | 4 ++--
 .github/workflows/test-sqlite-support.yml | 2 +-
 .github/workflows/tmate-mac.yml           | 2 +-
 .github/workflows/tmate.yml               | 2 +-
 11 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/deploy-latest.yml b/.github/workflows/deploy-latest.yml
index b0640ae8..3fc83438 100644
--- a/.github/workflows/deploy-latest.yml
+++ b/.github/workflows/deploy-latest.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out datasette
-      uses: actions/checkout@v6
+      uses: actions/checkout@v7
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
index 5275ddef..f5b8dbf6 100644
--- a/.github/workflows/playwright.yml
+++ b/.github/workflows/playwright.yml
@@ -16,7 +16,7 @@ jobs:
       matrix:
         browser: [chromium, firefox, webkit]
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python 3.14
       uses: actions/setup-python@v6
       with:
@@ -25,14 +25,14 @@ jobs:
         cache: pip
         cache-dependency-path: pyproject.toml
     - name: Cache uv
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         path: ~/.cache/uv
         key: ${{ runner.os }}-py3.14-uv-${{ hashFiles('pyproject.toml') }}
         restore-keys: |
           ${{ runner.os }}-py3.14-uv-
     - name: Cache Playwright browsers
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         path: ~/.cache/ms-playwright/
         key: ${{ runner.os }}-playwright-${{ matrix.browser }}-${{ hashFiles('pyproject.toml') }}
diff --git a/.github/workflows/prettier.yml b/.github/workflows/prettier.yml
index 735e14e9..d92ab82b 100644
--- a/.github/workflows/prettier.yml
+++ b/.github/workflows/prettier.yml
@@ -10,8 +10,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out repo
-      uses: actions/checkout@v6
-    - uses: actions/cache@v5
+      uses: actions/checkout@v7
+    - uses: actions/cache@v6
       name: Configure npm caching
       with:
         path: ~/.npm
diff --git a/.github/workflows/push_docker_tag.yml b/.github/workflows/push_docker_tag.yml
index e622ef4c..c5a4f0db 100644
--- a/.github/workflows/push_docker_tag.yml
+++ b/.github/workflows/push_docker_tag.yml
@@ -13,7 +13,7 @@ jobs:
   deploy_docker:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Build and push to Docker Hub
       env:
         DOCKER_USER: ${{ secrets.DOCKER_USER }}
diff --git a/.github/workflows/spellcheck.yml b/.github/workflows/spellcheck.yml
index 9a808194..58635025 100644
--- a/.github/workflows/spellcheck.yml
+++ b/.github/workflows/spellcheck.yml
@@ -9,7 +9,7 @@ jobs:
   spellcheck:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/stable-docs.yml b/.github/workflows/stable-docs.yml
index 59b5fbc0..ecde5940 100644
--- a/.github/workflows/stable-docs.yml
+++ b/.github/workflows/stable-docs.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v6
+      uses: actions/checkout@v7
       with:
         fetch-depth: 0  # We need all commits to find docs/ changes
     - name: Set up Git user
diff --git a/.github/workflows/test-coverage.yml b/.github/workflows/test-coverage.yml
index c514048e..e9bd4bab 100644
--- a/.github/workflows/test-coverage.yml
+++ b/.github/workflows/test-coverage.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out datasette
-      uses: actions/checkout@v6
+      uses: actions/checkout@v7
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/test-pyodide.yml b/.github/workflows/test-pyodide.yml
index 5162c47a..5e81ed82 100644
--- a/.github/workflows/test-pyodide.yml
+++ b/.github/workflows/test-pyodide.yml
@@ -12,7 +12,7 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python 3.10
       uses: actions/setup-python@v6
       with:
@@ -20,7 +20,7 @@ jobs:
         cache: 'pip'
         cache-dependency-path: '**/pyproject.toml'
     - name: Cache Playwright browsers
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         path: ~/.cache/ms-playwright/
         key: ${{ runner.os }}-browsers
diff --git a/.github/workflows/test-sqlite-support.yml b/.github/workflows/test-sqlite-support.yml
index d86000bf..2fdb3a40 100644
--- a/.github/workflows/test-sqlite-support.yml
+++ b/.github/workflows/test-sqlite-support.yml
@@ -25,7 +25,7 @@ jobs:
           #"3.23.1" # 2018-04-10, before UPSERT
         ]
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v6
       with:
diff --git a/.github/workflows/tmate-mac.yml b/.github/workflows/tmate-mac.yml
index a033cd92..f2c074a6 100644
--- a/.github/workflows/tmate-mac.yml
+++ b/.github/workflows/tmate-mac.yml
@@ -10,6 +10,6 @@ jobs:
   build:
     runs-on: macos-latest
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Setup tmate session
       uses: mxschmitt/action-tmate@v3
diff --git a/.github/workflows/tmate.yml b/.github/workflows/tmate.yml
index 72af1eec..5b8818c3 100644
--- a/.github/workflows/tmate.yml
+++ b/.github/workflows/tmate.yml
@@ -11,7 +11,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - name: Setup tmate session
       uses: mxschmitt/action-tmate@v3
       env: