mirror of
https://github.com/simonw/datasette.git
synced 2026-06-12 03:57:00 +02:00
* Add web UI to edit and delete stored queries Stored query pages now offer Edit and Delete actions in the query actions menu, gated by the update-query and delete-query permissions. - New QueryEditView (GET/POST at /<db>/<query>/-/edit) renders a pre-filled form for editing a query's title, description, SQL and privacy, reusing the create-query analysis UI. Changing the SQL still requires execute-sql; metadata-only edits do not. - QueryDeleteView gains a GET confirmation page and HTML form POST that redirects to the query list, while keeping the existing JSON API. - New default query_actions hook adds the Edit/Delete links for stored (non-config, non-trusted) queries the actor is allowed to manage. Permission semantics (already enforced by default_query_permissions_sql) are surfaced in the UI: owners can always edit/delete their queries; non-private queries can be edited/deleted by any actor with the relevant permission; private queries remain owner-only. Shared the create-query form styles into _query_form_styles.html so the edit form can reuse them. Animated demo: https://github.com/simonw/datasette/pull/2764#issuecomment-4655694668 Closes #2760 https://claude.ai/code/session_019GU9g3pZAERukLKYNa4uAL
129 lines
4.3 KiB
Python
129 lines
4.3 KiB
Python
import importlib
|
|
import os
|
|
import pluggy
|
|
from pprint import pprint
|
|
import sys
|
|
from . import hookspecs
|
|
|
|
if sys.version_info >= (3, 9):
|
|
import importlib.resources as importlib_resources
|
|
else:
|
|
import importlib_resources
|
|
if sys.version_info >= (3, 10):
|
|
import importlib.metadata as importlib_metadata
|
|
else:
|
|
import importlib_metadata
|
|
|
|
|
|
DEFAULT_PLUGINS = (
|
|
"datasette.publish.heroku",
|
|
"datasette.publish.cloudrun",
|
|
"datasette.facets",
|
|
"datasette.filters",
|
|
"datasette.sql_functions",
|
|
"datasette.actor_auth_cookie",
|
|
"datasette.default_permissions",
|
|
"datasette.default_permissions.tokens",
|
|
"datasette.default_actions",
|
|
"datasette.default_column_types",
|
|
"datasette.default_magic_parameters",
|
|
"datasette.blob_renderer",
|
|
"datasette.default_debug_menu",
|
|
"datasette.default_jump_items",
|
|
"datasette.default_database_actions",
|
|
"datasette.default_query_actions",
|
|
"datasette.handle_exception",
|
|
"datasette.forbidden",
|
|
"datasette.events",
|
|
)
|
|
|
|
pm = pluggy.PluginManager("datasette")
|
|
pm.add_hookspecs(hookspecs)
|
|
|
|
DATASETTE_TRACE_PLUGINS = os.environ.get("DATASETTE_TRACE_PLUGINS", None)
|
|
|
|
|
|
def before(hook_name, hook_impls, kwargs):
|
|
print(file=sys.stderr)
|
|
print(f"{hook_name}:", file=sys.stderr)
|
|
pprint(kwargs, width=40, indent=4, stream=sys.stderr)
|
|
print("Hook implementations:", file=sys.stderr)
|
|
pprint(hook_impls, width=40, indent=4, stream=sys.stderr)
|
|
|
|
|
|
def after(outcome, hook_name, hook_impls, kwargs):
|
|
results = outcome.get_result()
|
|
if not isinstance(results, list):
|
|
results = [results]
|
|
print("Results:", file=sys.stderr)
|
|
pprint(results, width=40, indent=4, stream=sys.stderr)
|
|
|
|
|
|
if DATASETTE_TRACE_PLUGINS:
|
|
pm.add_hookcall_monitoring(before, after)
|
|
|
|
|
|
DATASETTE_LOAD_PLUGINS = os.environ.get("DATASETTE_LOAD_PLUGINS", None)
|
|
|
|
if not hasattr(sys, "_called_from_test") and DATASETTE_LOAD_PLUGINS is None:
|
|
# Only load plugins if not running tests
|
|
pm.load_setuptools_entrypoints("datasette")
|
|
|
|
# Load any plugins specified in DATASETTE_LOAD_PLUGINS")
|
|
if DATASETTE_LOAD_PLUGINS is not None:
|
|
for package_name in [
|
|
name for name in DATASETTE_LOAD_PLUGINS.split(",") if name.strip()
|
|
]:
|
|
try:
|
|
distribution = importlib_metadata.distribution(package_name)
|
|
entry_points = distribution.entry_points
|
|
for entry_point in entry_points:
|
|
if entry_point.group == "datasette":
|
|
mod = entry_point.load()
|
|
pm.register(mod, name=entry_point.name)
|
|
# Ensure name can be found in plugin_to_distinfo later:
|
|
pm._plugin_distinfo.append((mod, distribution))
|
|
except importlib_metadata.PackageNotFoundError:
|
|
sys.stderr.write("Plugin {} could not be found\n".format(package_name))
|
|
|
|
|
|
# Load default plugins
|
|
for plugin in DEFAULT_PLUGINS:
|
|
mod = importlib.import_module(plugin)
|
|
pm.register(mod, plugin)
|
|
|
|
|
|
def get_plugins():
|
|
plugins = []
|
|
plugin_to_distinfo = dict(pm.list_plugin_distinfo())
|
|
for plugin in pm.get_plugins():
|
|
static_path = None
|
|
templates_path = None
|
|
plugin_name = (
|
|
plugin.__name__
|
|
if hasattr(plugin, "__name__")
|
|
else plugin.__class__.__name__
|
|
)
|
|
if plugin_name not in DEFAULT_PLUGINS:
|
|
try:
|
|
if (importlib_resources.files(plugin_name) / "static").is_dir():
|
|
static_path = str(importlib_resources.files(plugin_name) / "static")
|
|
if (importlib_resources.files(plugin_name) / "templates").is_dir():
|
|
templates_path = str(
|
|
importlib_resources.files(plugin_name) / "templates"
|
|
)
|
|
except (TypeError, ModuleNotFoundError):
|
|
# Caused by --plugins_dir= plugins
|
|
pass
|
|
plugin_info = {
|
|
"name": plugin_name,
|
|
"static_path": static_path,
|
|
"templates_path": templates_path,
|
|
"hooks": [h.name for h in pm.get_hookcallers(plugin)],
|
|
}
|
|
distinfo = plugin_to_distinfo.get(plugin)
|
|
if distinfo:
|
|
plugin_info["version"] = distinfo.version
|
|
plugin_info["name"] = distinfo.name or distinfo.project_name
|
|
plugins.append(plugin_info)
|
|
return plugins
|