mirror of
https://github.com/simonw/datasette.git
synced 2026-09-02 14:44:07 +02:00
8194cb5a1d
Datasette core is gaining OpenTelemetry spans alongside the existing hand-rolled tracer. This commit only lays the groundwork - no span is emitted yet. Core takes a runtime dependency on opentelemetry-api and nothing more. It deliberately never creates a TracerProvider, configures an exporter, or touches sampling: that belongs to whoever runs Datasette, normally via an opentelemetry-instrument agent. Owning a provider in core was tried in an earlier design and produced a cross-request span leak, a process-global provider that tests could not tear down, and a sampling env var that silently blanked output. With no provider installed every span is a NonRecordingSpan and costs approximately nothing. datasette/telemetry.py exposes the module-level tracer plus sql_attribute(), which truncates SQL to 2048 characters. On a public instance the SQL is attacker-controlled and unbounded - someone can paste a 10MB query into ?sql= - so it must never reach a telemetry pipeline verbatim. opentelemetry-sdk goes in the dev dependency group only, because the test suite needs it to assert on spans while the package itself must not import it. tests/test_telemetry.py enforces that by importing datasette in a fresh interpreter and inspecting sys.modules, which catches a lazy import inside a function body that a grep would miss. conftest.py gains a session-scoped autouse fixture installing an SDK provider with an InMemorySpanExporter. It has to be session-scoped because set_tracer_provider() is effectively once-per-process - a second call logs a warning and is ignored. SimpleSpanProcessor rather than BatchSpanProcessor, so assertions made right after a request never race a background export thread. The otel_spans fixture that later tickets assert against is added here too. test_datasette_package_never_imports_the_sdk is moved to the front of the run. Late in a serial run the pytest process holds enough threads that the fork half of subprocess' fork+exec segfaults the interpreter on macOS/CPython 3.13. That reproduces with any subprocess call in that position on an unmodified tree, so it is a pre-existing hazard rather than something this commit introduces; the repo already moves its other subprocess-spawning tests to the front for related reasons. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
108 lines
2.6 KiB
TOML
108 lines
2.6 KiB
TOML
[project]
|
|
name = "datasette"
|
|
dynamic = ["version"]
|
|
description = "An open source multi-tool for exploring and publishing data"
|
|
readme = { file = "README.md", content-type = "text/markdown" }
|
|
authors = [
|
|
{ name = "Simon Willison" },
|
|
]
|
|
license = "Apache-2.0"
|
|
requires-python = ">=3.10"
|
|
classifiers = [
|
|
"Development Status :: 4 - Beta",
|
|
"Framework :: Datasette",
|
|
"Intended Audience :: Developers",
|
|
"Intended Audience :: Science/Research",
|
|
"Intended Audience :: End Users/Desktop",
|
|
"Topic :: Database",
|
|
"Programming Language :: Python :: 3.10",
|
|
"Programming Language :: Python :: 3.11",
|
|
"Programming Language :: Python :: 3.12",
|
|
"Programming Language :: Python :: 3.13",
|
|
"Programming Language :: Python :: 3.14",
|
|
]
|
|
|
|
dependencies = [
|
|
"asgiref>=3.2.10",
|
|
"click>=7.1.1",
|
|
"click-default-group>=1.2.3",
|
|
"Jinja2>=2.10.3",
|
|
"hupper>=1.9",
|
|
"httpx>=0.20,<1.0",
|
|
"pluggy>=1.0",
|
|
"uvicorn>=0.29",
|
|
"aiofiles>=0.4",
|
|
"PyYAML>=5.3",
|
|
"mergedeep>=1.1.1",
|
|
"itsdangerous>=1.1",
|
|
"sqlite-utils>=4.0",
|
|
"asyncinject>=0.7",
|
|
"setuptools",
|
|
"pip",
|
|
"pydantic>=2",
|
|
"opentelemetry-api>=1.37",
|
|
]
|
|
|
|
[project.urls]
|
|
Homepage = "https://datasette.io/"
|
|
Documentation = "https://docs.datasette.io/en/stable/"
|
|
Changelog = "https://docs.datasette.io/en/stable/changelog.html"
|
|
"Live demo" = "https://latest.datasette.io/"
|
|
"Source code" = "https://github.com/simonw/datasette"
|
|
Issues = "https://github.com/simonw/datasette/issues"
|
|
CI = "https://github.com/simonw/datasette/actions?query=workflow%3ATest"
|
|
|
|
[project.scripts]
|
|
datasette = "datasette.cli:cli"
|
|
|
|
[project.entry-points.pytest11]
|
|
datasette = "datasette._pytest_plugin"
|
|
|
|
[dependency-groups]
|
|
dev = [
|
|
"pytest>=9",
|
|
"pytest-xdist>=2.2.1",
|
|
"pytest-asyncio>=1.2.0",
|
|
"beautifulsoup4>=4.8.1",
|
|
"black==26.3.1",
|
|
"blacken-docs==1.20.0",
|
|
"pytest-timeout>=1.4.2",
|
|
"trustme>=0.7",
|
|
"cogapp>=3.3.0",
|
|
"multipart-form-data-conformance==0.1a0",
|
|
"ruff>=0.16.0",
|
|
"opentelemetry-sdk>=1.37",
|
|
# docs
|
|
"Sphinx==7.4.7",
|
|
"furo==2025.9.25",
|
|
"sphinx-autobuild",
|
|
"codespell>=2.2.5",
|
|
"sphinx-copybutton",
|
|
"sphinx-inline-tabs",
|
|
"myst-parser",
|
|
"sphinx-markdown-builder",
|
|
"ruamel.yaml",
|
|
"psutil>=5.9",
|
|
]
|
|
playwright = [
|
|
"pytest-playwright>=0.8.0",
|
|
]
|
|
|
|
[project.optional-dependencies]
|
|
rich = ["rich"]
|
|
|
|
[build-system]
|
|
requires = ["setuptools"]
|
|
build-backend = "setuptools.build_meta"
|
|
|
|
[tool.setuptools.packages.find]
|
|
include = ["datasette*"]
|
|
|
|
[tool.setuptools.package-data]
|
|
datasette = ["templates/*.html"]
|
|
|
|
[tool.setuptools.dynamic]
|
|
version = {attr = "datasette.version.__version__"}
|
|
|
|
[tool.uv]
|
|
package = true
|