mirror of
https://github.com/simonw/datasette.git
synced 2026-06-14 21:16:56 +02:00
0a924524be* Split default_permissions.py into a package, refs #2602 * Remove unused is_resource_allowed() method, improve test coverage - Remove dead code: is_resource_allowed() method was never called - Change isinstance check to assertion with error message - Add test cases for table-level restrictions in restrictions_allow_action() - Coverage for restrictions.py improved from 79% to 99% 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Additional permission test for gap spotted by coverage
85 lines
2.5 KiB
Python
85 lines
2.5 KiB
Python
"""
|
|
Shared helper utilities for default permission implementations.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from dataclasses import dataclass
|
|
from typing import TYPE_CHECKING, List, Optional, Set
|
|
|
|
if TYPE_CHECKING:
|
|
from datasette.app import Datasette
|
|
|
|
from datasette.permissions import PermissionSQL
|
|
|
|
|
|
def get_action_name_variants(datasette: "Datasette", action: str) -> Set[str]:
|
|
"""
|
|
Get all name variants for an action (full name and abbreviation).
|
|
|
|
Example:
|
|
get_action_name_variants(ds, "view-table") -> {"view-table", "vt"}
|
|
"""
|
|
variants = {action}
|
|
action_obj = datasette.actions.get(action)
|
|
if action_obj and action_obj.abbr:
|
|
variants.add(action_obj.abbr)
|
|
return variants
|
|
|
|
|
|
def action_in_list(datasette: "Datasette", action: str, action_list: list) -> bool:
|
|
"""Check if an action (or its abbreviation) is in a list."""
|
|
return bool(get_action_name_variants(datasette, action).intersection(action_list))
|
|
|
|
|
|
@dataclass
|
|
class PermissionRow:
|
|
"""A single permission rule row."""
|
|
|
|
parent: Optional[str]
|
|
child: Optional[str]
|
|
allow: bool
|
|
reason: str
|
|
|
|
|
|
class PermissionRowCollector:
|
|
"""Collects permission rows and converts them to PermissionSQL."""
|
|
|
|
def __init__(self, prefix: str = "row"):
|
|
self.rows: List[PermissionRow] = []
|
|
self.prefix = prefix
|
|
|
|
def add(
|
|
self,
|
|
parent: Optional[str],
|
|
child: Optional[str],
|
|
allow: Optional[bool],
|
|
reason: str,
|
|
if_not_none: bool = False,
|
|
) -> None:
|
|
"""Add a permission row. If if_not_none=True, only add if allow is not None."""
|
|
if if_not_none and allow is None:
|
|
return
|
|
self.rows.append(PermissionRow(parent, child, allow, reason))
|
|
|
|
def to_permission_sql(self) -> Optional[PermissionSQL]:
|
|
"""Convert collected rows to a PermissionSQL object."""
|
|
if not self.rows:
|
|
return None
|
|
|
|
parts = []
|
|
params = {}
|
|
|
|
for idx, row in enumerate(self.rows):
|
|
key = f"{self.prefix}_{idx}"
|
|
parts.append(
|
|
f"SELECT :{key}_parent AS parent, :{key}_child AS child, "
|
|
f":{key}_allow AS allow, :{key}_reason AS reason"
|
|
)
|
|
params[f"{key}_parent"] = row.parent
|
|
params[f"{key}_child"] = row.child
|
|
params[f"{key}_allow"] = 1 if row.allow else 0
|
|
params[f"{key}_reason"] = row.reason
|
|
|
|
sql = "\nUNION ALL\n".join(parts)
|
|
return PermissionSQL(sql=sql, params=params)
|