From 46a332757f481ac1ee04b5b8d4f3a35e7b928dfc Mon Sep 17 00:00:00 2001 From: Deluan Date: Fri, 14 Aug 2026 15:07:30 -0400 Subject: [PATCH] refactor(cli): simplify parseArtworkKind with slices.Contains Replaces a nested loop and a manual append with slices.Contains and the repo's slice.Map helper. Same behaviour, same error message. --- cmd/artwork.go | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/cmd/artwork.go b/cmd/artwork.go index 99c4001c7..1b1a8ccba 100644 --- a/cmd/artwork.go +++ b/cmd/artwork.go @@ -493,17 +493,10 @@ func refreshItems(ctx context.Context, ds model.DataStore, kind model.Kind, ids func parseArtworkKind(s string) (model.Kind, error) { kind, ok := model.ParseKind(s) - if ok { - for _, k := range artworkKinds { - if k == kind { - return kind, nil - } - } - } - valid := make([]string, 0, len(artworkKinds)) - for _, k := range artworkKinds { - valid = append(valid, k.Prefix()) + if ok && slices.Contains(artworkKinds, kind) { + return kind, nil } + valid := slice.Map(artworkKinds, func(k model.Kind) string { return k.Prefix() }) return kind, fmt.Errorf("invalid kind %q, expected one of: %s", s, strings.Join(valid, ", ")) }