From 4faed5bc44b64cb07f3388a179480a9991b60e3b Mon Sep 17 00:00:00 2001 From: Deluan Date: Fri, 19 Jun 2026 16:41:14 -0400 Subject: [PATCH] refactor(lyrics): simplify test descriptions for structured lyrics Signed-off-by: Deluan --- server/e2e/subsonic_lyrics_test.go | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/server/e2e/subsonic_lyrics_test.go b/server/e2e/subsonic_lyrics_test.go index ca4dd7195..8a1e207e6 100644 --- a/server/e2e/subsonic_lyrics_test.go +++ b/server/e2e/subsonic_lyrics_test.go @@ -28,7 +28,7 @@ var _ = Describe("Lyrics endpoints", func() { } Describe("getLyricsBySongId (v2 structured)", func() { - DescribeTable("returns structured lyrics for embedded formats", + DescribeTable("returns structured lyrics", func(title string, wantSynced bool, wantFirstLine, wantLang string) { resp := doReq("getLyricsBySongId", "id", songID(title)) Expect(resp.Status).To(Equal("ok")) @@ -39,21 +39,9 @@ var _ = Describe("Lyrics endpoints", func() { Expect(got.Line[0].Value).To(Equal(wantFirstLine)) }, // "xxx" is the ISO 639-2 code for "no language specified" - Entry("synced LRC", "Embedded Synced LRC", true, "embedded lrc line one", "xxx"), - Entry("plain text", "Embedded Plain", false, "plain embedded line one", "xxx"), - Entry("TTML", "Embedded TTML", true, "embedded ttml line", "xxx"), - ) - - DescribeTable("returns structured lyrics for sidecar formats", - func(title string, wantSynced bool, wantFirstLine, wantLang string) { - resp := doReq("getLyricsBySongId", "id", songID(title)) - Expect(resp.Status).To(Equal("ok")) - got := firstLyric(resp.LyricsList) - Expect(got.Synced).To(Equal(wantSynced)) - Expect(got.Lang).To(Equal(wantLang)) - Expect(got.Line).ToNot(BeEmpty()) - Expect(got.Line[0].Value).To(Equal(wantFirstLine)) - }, + Entry("synced LRC embedded", "Embedded Synced LRC", true, "embedded lrc line one", "xxx"), + Entry("plain text embedded", "Embedded Plain", false, "plain embedded line one", "xxx"), + Entry("TTML embedded", "Embedded TTML", true, "embedded ttml line", "xxx"), Entry("LRC sidecar", "Sidecar LRC", true, "sidecar lrc line", "xxx"), Entry("SRT sidecar", "Sidecar SRT", true, "sidecar srt line", "xxx"), // YAML sidecar fixture sets "language: eng"; verify Navidrome passes it through unchanged.