remote/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-10-12 12:27:09 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(artwork): export the trace outcome vocabulary

Browse source 
The CLI hardcoded the outcome literals and the "external:" prefix, so renaming a
constant's value in core/artwork left cmd compiling and the suite green while
`artwork explain` silently degraded its verdict.

Renaming a value now fails the golden vocabulary test in core/artwork and the
explainResult tests in cmd.
This commit is contained in:
Deluan 2026-08-14 14:47:21 -04:00
commit a1b9976521
7 changed files with 92 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

8
cmd/artwork.go
View file

@ -517,10 +517,10 @@ func walksPriorityChain(kind model.Kind) bool {
func explainResult(source string, steps []artwork.TraceStep) string {
if source != "" {
for _, s := range steps {
if s.Outcome == "hit" {
if s.Outcome == artwork.OutcomeHit {
break
}
if s.Outcome == "would-try" {
if s.Outcome == artwork.OutcomeWouldTry {
return "resolved from " + source +
" (offline: a higher-priority external candidate was not tried; re-run with --live)"
}
@ -529,9 +529,9 @@ func explainResult(source string, steps []artwork.TraceStep) string {
}
for _, s := range steps {
switch {
case s.Outcome == "would-try":
case s.Outcome == artwork.OutcomeWouldTry:
return "indeterminate (external agents not called; re-run with --live)"
case s.Outcome == "error" && strings.HasPrefix(s.Candidate, "external:"):
case s.Outcome == artwork.OutcomeError && strings.HasPrefix(s.Candidate, artwork.ExternalPrefix):
return "indeterminate (an external lookup failed; the item may resolve on a later attempt)"
}
}