remote/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-11-07 02:38:50 +01:00
Code Issues Projects Releases Packages Wiki Activity

refactor: remove MissingFiles interface and update references

Browse source 
Remove obsolete MissingFiles interface and its references:
- Delete core/missing_files.go and core/missing_files_test.go
- Remove RefreshAlbums method from AlbumRepository interface and implementation
- Remove RefreshAlbums tests from AlbumRepository test suite
- Update wire providers to use NewMaintenance instead of NewMissingFiles
- Update native API router to use Maintenance service
- Update missing.go handler to use Maintenance interface

All functionality is now consolidated in the core.Maintenance service.

Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan 2025-11-08 18:03:15 -05:00
commit a1ff9f3f2b
10 changed files with 70 additions and 738 deletions
Download patch file Download diff file Expand all files Collapse all files

6
server/nativeapi/missing.go
View file

@ -63,7 +63,7 @@ func (r *missingRepository) EntityName() string {
return "missing_files"
}
func deleteMissingFiles(missingFiles core.MissingFiles) http.HandlerFunc {
func deleteMissingFiles(maintenance core.Maintenance) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
@ -72,9 +72,9 @@ func deleteMissingFiles(missingFiles core.MissingFiles) http.HandlerFunc {
var err error
if len(ids) == 0 {
err = missingFiles.DeleteAllMissingFiles(ctx)
err = maintenance.DeleteAllMissingFiles(ctx)
} else {
err = missingFiles.DeleteMissingFiles(ctx, ids)
err = maintenance.DeleteMissingFiles(ctx, ids)
}
if len(ids) == 1 && errors.Is(err, model.ErrNotFound) {

18
server/nativeapi/native_api.go
View file

@ -22,16 +22,16 @@ import (
type Router struct {
http.Handler
ds model.DataStore
share core.Share
playlists core.Playlists
insights metrics.Insights
libs core.Library
missingFiles core.MissingFiles
ds model.DataStore
share core.Share
playlists core.Playlists
insights metrics.Insights
libs core.Library
maintenance core.Maintenance
}
func New(ds model.DataStore, share core.Share, playlists core.Playlists, insights metrics.Insights, libraryService core.Library, missingFiles core.MissingFiles) *Router {
r := &Router{ds: ds, share: share, playlists: playlists, insights: insights, libs: libraryService, missingFiles: missingFiles}
func New(ds model.DataStore, share core.Share, playlists core.Playlists, insights metrics.Insights, libraryService core.Library, maintenance core.Maintenance) *Router {
r := &Router{ds: ds, share: share, playlists: playlists, insights: insights, libs: libraryService, maintenance: maintenance}
r.Handler = r.routes()
return r
}
@ -173,7 +173,7 @@ func (api *Router) addQueueRoute(r chi.Router) {
func (api *Router) addMissingFilesRoute(r chi.Router) {
r.Route("/missing", func(r chi.Router) {
api.RX(r, "/", newMissingRepository(api.ds), false)
r.Delete("/", deleteMissingFiles(api.missingFiles))
r.Delete("/", deleteMissingFiles(api.maintenance))
})
}