mirror of
https://github.com/navidrome/navidrome.git
synced 2026-11-20 17:09:54 +01:00
perf: reduce hot-path heap escapes from value-param pointer aliasing (#5342)
* perf(subsonic): keep album/mediafile params on stack in response helpers Two helpers were forcing their entire value parameter onto the heap via pointer-to-field aliasing, adding one full-struct heap allocation per response item on hot Subsonic endpoints (search3, getAlbumList2, etc.). - childFromMediaFile assigned &mf.BirthTime to the returned Child, pulling the whole ~1KB model.MediaFile to the heap on every call. - buildDiscSubtitles passed &a.UpdatedAt to NewArtworkID inside a loop, pulling the whole model.Album to the heap on every album with discs. Both now copy the time.Time to a stack-local and use gg.P / &local so only the small time.Time escapes. Verified via go build -gcflags=-m=2: moved to heap: mf and moved to heap: a are gone at these sites. * perf(metadata): avoid per-track closure allocations in PID computation createGetPID was a factory that returned nested closures capturing mf model.MediaFile (~992 bytes) by reference. Since it is called three times per track during scans (trackPID, albumID, artistID), every track triggered the allocation of three closures plus a heap copy of the full MediaFile. Refactor the body into package-level functions (computePID, getPIDAttr) that take hash as an explicit parameter and the inner slice.Map callback to an indexed for loop, removing the closure-capture of mf entirely. trackPID/albumID/artistID now call computePID directly. The tiny createGetPID wrapper was kept only for tests; move the closure-building into the test file so production has no dead API. Verified via go build -gcflags=-m=2 on model/metadata: no "moved to heap: mf" anywhere in persistent_ids.go, and the callers in map_mediafile.go / map_participants.go no longer heap-promote their MediaFile argument.
This commit is contained in:
parent
9b0bfc606b
commit
ab2f1b45de
3 changed files with 66 additions and 65 deletions
|
|
@ -217,7 +217,7 @@ func childFromMediaFile(ctx context.Context, mf model.MediaFile) responses.Child
|
|||
child.Path = fakePath(mf)
|
||||
}
|
||||
child.DiscNumber = int32(mf.DiscNumber)
|
||||
child.Created = &mf.BirthTime
|
||||
child.Created = P(mf.BirthTime)
|
||||
child.AlbumId = mf.AlbumID
|
||||
child.ArtistId = mf.ArtistID
|
||||
child.Type = "music"
|
||||
|
|
@ -407,9 +407,12 @@ func buildDiscSubtitles(a model.Album) []responses.DiscTitle {
|
|||
return nil
|
||||
}
|
||||
var discTitles []responses.DiscTitle
|
||||
// Hoist UpdatedAt to a single stack-local so &updatedAt doesn't force the
|
||||
// whole model.Album parameter onto the heap.
|
||||
updatedAt := a.UpdatedAt
|
||||
for num, title := range a.Discs {
|
||||
artID := model.NewArtworkID(model.KindDiscArtwork,
|
||||
model.DiscArtworkID(a.ID, num), &a.UpdatedAt)
|
||||
model.DiscArtworkID(a.ID, num), &updatedAt)
|
||||
discTitles = append(discTitles, responses.DiscTitle{
|
||||
Disc: int32(num),
|
||||
Title: title,
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue