mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-08 18:37:09 +02:00
* refactor(persistence): adopt generic deluan/rest repository API Pin deluan/rest to the refactor branch. REST-facing repository methods take a context and return typed values. Drop DataStore.Resource and ResourceRepository; the native API names typed repositories directly through a per-request adapter that later commits remove. * refactor(persistence): base repository helpers take a context * refactor(persistence): LibraryRepository takes a context per call * refactor(persistence): PropertyRepository takes a context per call * refactor(persistence): UserPropsRepository takes a context per call * refactor(persistence): TranscodingRepository takes a context per call * refactor(persistence): ShareRepository takes a context per call * refactor(persistence): PlayerRepository takes a context per call * refactor(persistence): RadioRepository takes a context per call * refactor(persistence): PlayQueueRepository takes a context per call * refactor(persistence): Tag and Genre repositories take a context per call * refactor(persistence): PluginRepository takes a context per call * refactor(persistence): Scrobble repositories take a context per call * refactor(persistence): FolderRepository takes a context per call * refactor(persistence): Artwork repositories take a context per call * refactor(persistence): UserRepository takes a context per call * refactor(persistence): ArtistRepository takes a context per call ReadAll no longer rewrites the shared sort mappings for the role filter; it works on a per-call copy. * test(persistence): assert artist role sort sanitization in ReadAll * refactor(persistence): AlbumRepository takes a context per call * test(persistence): pass the test context to album repository helpers * refactor(persistence): MediaFileRepository takes a context per call * refactor(persistence): Playlist repositories take a context per call * refactor(persistence): build all repositories once per store * refactor(core): REST repository wrappers are built once * refactor(persistence): repositories are stateless Remove the context field from the base repository and the per-request REST adapter. Enable the containedctx linter so no repository can hold a request context again. * chore(lint): skip containedctx in test files * refactor: share simplifications from the stateless repositories sweep Add deleteOwnedAll on sqlRepository and use it in player/share Delete to remove the duplicated bulk-delete loop; have Share.Repository() return model.ShareRepository so subsonic sharing.go drops its repeated type assertions. * chore(core): assert REST wrappers implement Persistable * chore: reformat imports * perf(persistence): build repositories on first use Each transaction store used to construct all 21 repositories up front, paying for filter and sort mapping setup the block never touched. Fields are now sync.OnceValue thunks, so a store only builds what it uses. * fix(persistence): clean plugin references per deleted user A bulk user delete that fails on a later id had already removed the earlier rows but skipped their plugin cleanup. Cleanup now runs right after each successful delete. * fix(core): unload disabled plugins even when a user delete fails A bulk delete can fail on a later id after earlier users were removed and their plugins auto-disabled. The wrapper returned before unloading, leaving those plugins running until the next successful delete or a restart. * chore(deps): pin deluan/rest to v1.0.1 Replaces the pseudo-version of the refactor branch with the tagged release. REST error messages now name the bare type (Artist, not model.Artist). * test: use the spec context instead of context.Background() Replace the context.Background()/context.TODO() calls this branch added to tests with the spec's ctx, GinkgoT().Context(), or t/b.Context(), so repository calls are bound to the running spec's lifetime. * test: declare the spec context once per Describe Set ctx from GinkgoT().Context() first in each top-level BeforeEach and reuse it, building user contexts on top of it instead of repeating inline calls.
449 lines
15 KiB
Go
449 lines
15 KiB
Go
package subsonic
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"slices"
|
|
"strconv"
|
|
|
|
"github.com/navidrome/navidrome/core/ffmpeg"
|
|
"github.com/navidrome/navidrome/core/stream"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/model/request"
|
|
"github.com/navidrome/navidrome/server/subsonic/responses"
|
|
"github.com/navidrome/navidrome/utils/req"
|
|
)
|
|
|
|
// API-layer request structs for JSON unmarshaling (decoupled from core structs)
|
|
|
|
// clientInfoRequest represents client playback capabilities from the request body
|
|
type clientInfoRequest struct {
|
|
Name string `json:"name,omitempty"`
|
|
Platform string `json:"platform,omitempty"`
|
|
MaxAudioBitrate int `json:"maxAudioBitrate,omitempty"`
|
|
MaxTranscodingAudioBitrate int `json:"maxTranscodingAudioBitrate,omitempty"`
|
|
DirectPlayProfiles []directPlayProfileRequest `json:"directPlayProfiles,omitempty"`
|
|
TranscodingProfiles []transcodingProfileRequest `json:"transcodingProfiles,omitempty"`
|
|
CodecProfiles []codecProfileRequest `json:"codecProfiles,omitempty"`
|
|
}
|
|
|
|
// directPlayProfileRequest describes a format the client can play directly
|
|
type directPlayProfileRequest struct {
|
|
Containers []string `json:"containers,omitempty"`
|
|
AudioCodecs []string `json:"audioCodecs,omitempty"`
|
|
Protocols []string `json:"protocols,omitempty"`
|
|
MaxAudioChannels int `json:"maxAudioChannels,omitempty"`
|
|
}
|
|
|
|
// transcodingProfileRequest describes a transcoding target the client supports
|
|
type transcodingProfileRequest struct {
|
|
Container string `json:"container,omitempty"`
|
|
AudioCodec string `json:"audioCodec,omitempty"`
|
|
Protocol string `json:"protocol,omitempty"`
|
|
MaxAudioChannels int `json:"maxAudioChannels,omitempty"`
|
|
}
|
|
|
|
// codecProfileRequest describes codec-specific limitations
|
|
type codecProfileRequest struct {
|
|
Type string `json:"type,omitempty"`
|
|
Name string `json:"name,omitempty"`
|
|
Limitations []limitationRequest `json:"limitations,omitempty"`
|
|
}
|
|
|
|
// limitationRequest describes a specific codec limitation
|
|
type limitationRequest struct {
|
|
Name string `json:"name,omitempty"`
|
|
Comparison string `json:"comparison,omitempty"`
|
|
Values []string `json:"values,omitempty"`
|
|
Required bool `json:"required,omitempty"`
|
|
}
|
|
|
|
// toCoreClientInfo converts the API request struct to the stream.ClientInfo struct.
|
|
// The OpenSubsonic spec uses bps for bitrate values; core uses kbps.
|
|
func (r *clientInfoRequest) toCoreClientInfo() *stream.ClientInfo {
|
|
ci := &stream.ClientInfo{
|
|
Name: r.Name,
|
|
Platform: r.Platform,
|
|
MaxAudioBitrate: bpsToKbps(r.MaxAudioBitrate),
|
|
MaxTranscodingAudioBitrate: bpsToKbps(r.MaxTranscodingAudioBitrate),
|
|
}
|
|
|
|
for _, dp := range r.DirectPlayProfiles {
|
|
ci.DirectPlayProfiles = append(ci.DirectPlayProfiles, stream.DirectPlayProfile{
|
|
Containers: dp.Containers,
|
|
AudioCodecs: dp.AudioCodecs,
|
|
Protocols: dp.Protocols,
|
|
MaxAudioChannels: dp.MaxAudioChannels,
|
|
})
|
|
}
|
|
|
|
for _, tp := range r.TranscodingProfiles {
|
|
ci.TranscodingProfiles = append(ci.TranscodingProfiles, stream.Profile{
|
|
Container: tp.Container,
|
|
AudioCodec: tp.AudioCodec,
|
|
Protocol: tp.Protocol,
|
|
MaxAudioChannels: tp.MaxAudioChannels,
|
|
})
|
|
}
|
|
|
|
for _, cp := range r.CodecProfiles {
|
|
coreCP := stream.CodecProfile{
|
|
Type: cp.Type,
|
|
Name: cp.Name,
|
|
}
|
|
for _, lim := range cp.Limitations {
|
|
coreLim := stream.Limitation{
|
|
Name: lim.Name,
|
|
Comparison: lim.Comparison,
|
|
Values: lim.Values,
|
|
Required: lim.Required,
|
|
}
|
|
// Convert audioBitrate limitation values from bps to kbps
|
|
if lim.Name == stream.LimitationAudioBitrate {
|
|
coreLim.Values = convertBitrateValues(lim.Values)
|
|
}
|
|
coreCP.Limitations = append(coreCP.Limitations, coreLim)
|
|
}
|
|
ci.CodecProfiles = append(ci.CodecProfiles, coreCP)
|
|
}
|
|
|
|
return ci
|
|
}
|
|
|
|
// bpsToKbps converts bits per second to kilobits per second (rounded).
|
|
func bpsToKbps(bps int) int {
|
|
if bps < 0 {
|
|
return 0
|
|
}
|
|
return (bps + 500) / 1000
|
|
}
|
|
|
|
// kbpsToBps converts kilobits per second to bits per second.
|
|
func kbpsToBps(kbps int) int {
|
|
return kbps * 1000
|
|
}
|
|
|
|
// convertBitrateValues converts a slice of bps string values to kbps string values.
|
|
func convertBitrateValues(bpsValues []string) []string {
|
|
result := make([]string, len(bpsValues))
|
|
for i, v := range bpsValues {
|
|
n, err := strconv.Atoi(v)
|
|
if err == nil {
|
|
result[i] = strconv.Itoa(bpsToKbps(n))
|
|
} else {
|
|
result[i] = v // preserve unparseable values as-is
|
|
}
|
|
}
|
|
return result
|
|
}
|
|
|
|
// validate checks that all enum fields in the request contain valid values per the OpenSubsonic spec.
|
|
func (r *clientInfoRequest) validate() error {
|
|
for _, dp := range r.DirectPlayProfiles {
|
|
for _, p := range dp.Protocols {
|
|
if !isValidProtocol(p) {
|
|
return fmt.Errorf("invalid protocol: %s", p)
|
|
}
|
|
}
|
|
}
|
|
for _, tp := range r.TranscodingProfiles {
|
|
if tp.Protocol != "" && !isValidProtocol(tp.Protocol) {
|
|
return fmt.Errorf("invalid protocol: %s", tp.Protocol)
|
|
}
|
|
}
|
|
for _, cp := range r.CodecProfiles {
|
|
if !isValidCodecProfileType(cp.Type) {
|
|
return fmt.Errorf("invalid codec profile type: %s", cp.Type)
|
|
}
|
|
for _, lim := range cp.Limitations {
|
|
if !isValidLimitationName(lim.Name) {
|
|
return fmt.Errorf("invalid limitation name: %s", lim.Name)
|
|
}
|
|
if !isValidComparison(lim.Comparison) {
|
|
return fmt.Errorf("invalid comparison: %s", lim.Comparison)
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Only support songs for now
|
|
var validMediaTypes = []string{
|
|
"song",
|
|
}
|
|
|
|
func isValidMediaType(mediaType string) bool {
|
|
return slices.Contains(validMediaTypes, mediaType)
|
|
}
|
|
|
|
var validProtocols = []string{
|
|
stream.ProtocolHTTP,
|
|
stream.ProtocolHLS,
|
|
}
|
|
|
|
func isValidProtocol(p string) bool {
|
|
return slices.Contains(validProtocols, p)
|
|
}
|
|
|
|
var validCodecProfileTypes = []string{
|
|
stream.CodecProfileTypeAudio,
|
|
}
|
|
|
|
func isValidCodecProfileType(t string) bool {
|
|
return slices.Contains(validCodecProfileTypes, t)
|
|
}
|
|
|
|
var validLimitationNames = []string{
|
|
stream.LimitationAudioChannels,
|
|
stream.LimitationAudioBitrate,
|
|
stream.LimitationAudioProfile,
|
|
stream.LimitationAudioSamplerate,
|
|
stream.LimitationAudioBitdepth,
|
|
}
|
|
|
|
func isValidLimitationName(n string) bool {
|
|
return slices.Contains(validLimitationNames, n)
|
|
}
|
|
|
|
var validComparisons = []string{
|
|
stream.ComparisonEquals,
|
|
stream.ComparisonNotEquals,
|
|
stream.ComparisonLessThanEqual,
|
|
stream.ComparisonGreaterThanEqual,
|
|
}
|
|
|
|
func isValidComparison(c string) bool {
|
|
return slices.Contains(validComparisons, c)
|
|
}
|
|
|
|
// toResponseStreamDetails converts a core StreamDetails to the API response type.
|
|
func toResponseStreamDetails(sd *stream.Details) *responses.StreamDetails {
|
|
return &responses.StreamDetails{
|
|
Protocol: stream.ProtocolHTTP, // TODO: derive from decision when HLS support is added
|
|
Container: sd.Container,
|
|
Codec: sd.Codec,
|
|
AudioBitrate: int32(kbpsToBps(sd.Bitrate)),
|
|
AudioProfile: sd.Profile,
|
|
AudioSamplerate: int32(sd.SampleRate),
|
|
AudioBitdepth: int32(sd.BitDepth),
|
|
AudioChannels: int32(sd.Channels),
|
|
}
|
|
}
|
|
|
|
// GetTranscodeDecision handles the OpenSubsonic getTranscodeDecision endpoint.
|
|
// It receives client capabilities and returns a decision on whether to direct play or stream.
|
|
func (api *Router) GetTranscodeDecision(w http.ResponseWriter, r *http.Request) (*responses.Subsonic, error) {
|
|
if r.Method != http.MethodPost {
|
|
w.Header().Set("Allow", "POST")
|
|
http.Error(w, "Method Not Allowed", http.StatusMethodNotAllowed)
|
|
return nil, nil
|
|
}
|
|
|
|
ctx := r.Context()
|
|
p := req.Params(r)
|
|
|
|
mediaID, err := p.String("mediaId")
|
|
if err != nil {
|
|
return nil, newError(responses.ErrorMissingParameter, "missing required parameter: mediaId")
|
|
}
|
|
|
|
mediaType, err := p.String("mediaType")
|
|
if err != nil {
|
|
return nil, newError(responses.ErrorMissingParameter, "missing required parameter: mediaType")
|
|
}
|
|
|
|
if !isValidMediaType(mediaType) {
|
|
return nil, newError(responses.ErrorGeneric, "mediaType '%s' is not yet supported", mediaType)
|
|
}
|
|
|
|
// Parse and validate ClientInfo from request body (required per OpenSubsonic spec)
|
|
var clientInfoReq clientInfoRequest
|
|
r.Body = http.MaxBytesReader(w, r.Body, 1<<20) // 1 MB limit
|
|
if err := json.NewDecoder(r.Body).Decode(&clientInfoReq); err != nil {
|
|
return nil, newError(responses.ErrorGeneric, "invalid JSON request body")
|
|
}
|
|
if err := clientInfoReq.validate(); err != nil {
|
|
return nil, newError(responses.ErrorGeneric, "%v", err)
|
|
}
|
|
clientInfo := clientInfoReq.toCoreClientInfo()
|
|
|
|
// TODO: Remove this filter once AAC transcoding works reliably
|
|
// with streaming clients (Sonos, etc).
|
|
// See https://github.com/navidrome/navidrome/discussions/4832#discussioncomment-16068231
|
|
clientInfo.TranscodingProfiles = slices.DeleteFunc(clientInfo.TranscodingProfiles, func(p stream.Profile) bool {
|
|
if p.AudioCodec != "" {
|
|
return stream.IsAACCodec(p.AudioCodec)
|
|
}
|
|
return stream.IsAACCodec(p.Container)
|
|
})
|
|
|
|
player, hasPlayer := request.PlayerFrom(ctx)
|
|
|
|
// Honor the player's forced transcoding format, falling back to normal
|
|
// negotiation when the client can't play it (issue #5583).
|
|
maxBitRate := 0
|
|
if trc, ok := request.TranscodingFrom(ctx); ok && trc.TargetFormat != "" {
|
|
if clientInfo.ForceFormat(trc.TargetFormat) {
|
|
// DirectPlayProfile carries no bitrate, so this ceiling is the only
|
|
// thing keeping an over-bitrate source out of direct play.
|
|
maxBitRate = trc.DefaultBitRate
|
|
} else {
|
|
clientName := clientInfo.Name
|
|
if hasPlayer && player.Client != "" {
|
|
clientName = player.Client
|
|
}
|
|
log.Debug(ctx, "Player forced format not supported by client; falling back to negotiation",
|
|
"forcedFormat", trc.TargetFormat, "client", clientName)
|
|
}
|
|
}
|
|
|
|
// The player's own MaxBitRate outranks the forced-format default (issue #5583).
|
|
if hasPlayer && player.MaxBitRate > 0 {
|
|
maxBitRate = player.MaxBitRate
|
|
}
|
|
if clientInfo.CapBitrate(maxBitRate) {
|
|
log.Debug(ctx, "Applied bitrate ceiling to transcode decision",
|
|
"maxBitRate", maxBitRate, "client", clientInfo.Name)
|
|
}
|
|
|
|
// Get media file
|
|
mf, err := api.ds.MediaFile().Get(ctx, mediaID)
|
|
if err != nil {
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
return nil, newError(responses.ErrorDataNotFound, "media file not found: %s", mediaID)
|
|
}
|
|
log.Error(ctx, "Error retrieving media file", "mediaID", mediaID, err)
|
|
return nil, newError(responses.ErrorGeneric, "error retrieving media file")
|
|
}
|
|
|
|
// Make the decision
|
|
decision, err := api.transcodeDecision.MakeDecision(ctx, mf, clientInfo, stream.TranscodeOptions{})
|
|
if err != nil {
|
|
log.Error(ctx, "Failed to make transcode decision", "mediaID", mediaID, err)
|
|
code, reason := transcodeFailure(err)
|
|
return nil, newError(code, "failed to make transcode decision: %s", reason)
|
|
}
|
|
|
|
// Only create a token when there is a valid playback path
|
|
var transcodeParams string
|
|
if decision.CanDirectPlay || decision.CanTranscode {
|
|
transcodeParams, err = api.transcodeDecision.CreateTranscodeParams(decision)
|
|
if err != nil {
|
|
log.Error(ctx, "Failed to create transcode token", "mediaID", mediaID, err)
|
|
return nil, newError(responses.ErrorGeneric, "failed to create transcode token")
|
|
}
|
|
}
|
|
|
|
// Build response (convert kbps from core to bps for the API)
|
|
response := newResponse()
|
|
response.TranscodeDecision = &responses.TranscodeDecision{
|
|
CanDirectPlay: decision.CanDirectPlay,
|
|
CanTranscode: decision.CanTranscode,
|
|
TranscodeReasons: decision.TranscodeReasons,
|
|
ErrorReason: decision.ErrorReason,
|
|
TranscodeParams: transcodeParams,
|
|
SourceStream: toResponseStreamDetails(&decision.SourceStream),
|
|
}
|
|
|
|
if decision.TranscodeStream != nil {
|
|
response.TranscodeDecision.TranscodeStream = toResponseStreamDetails(decision.TranscodeStream)
|
|
}
|
|
|
|
return response, nil
|
|
}
|
|
|
|
// transcodeFailure maps a decision error to a Subsonic error code and a reason
|
|
// safe to send to clients, omitting server file paths.
|
|
func transcodeFailure(err error) (int32, string) {
|
|
pe, ok := errors.AsType[*ffmpeg.ProbeError](err)
|
|
if !ok {
|
|
return responses.ErrorGeneric, "internal error"
|
|
}
|
|
if pe.NotFound {
|
|
return responses.ErrorDataNotFound, pe.SafeReason()
|
|
}
|
|
return responses.ErrorGeneric, pe.SafeReason()
|
|
}
|
|
|
|
// GetTranscodeStream handles the OpenSubsonic getTranscodeStream endpoint.
|
|
// It streams media using the decision encoded in the transcodeParams JWT token.
|
|
// All errors are returned as proper HTTP status codes (not Subsonic error responses).
|
|
func (api *Router) GetTranscodeStream(w http.ResponseWriter, r *http.Request) (*responses.Subsonic, error) {
|
|
ctx := r.Context()
|
|
p := req.Params(r)
|
|
|
|
mediaID, err := p.String("mediaId")
|
|
if err != nil {
|
|
http.Error(w, "Bad Request", http.StatusBadRequest)
|
|
return nil, nil
|
|
}
|
|
|
|
mediaType, err := p.String("mediaType")
|
|
if err != nil {
|
|
http.Error(w, "Bad Request", http.StatusBadRequest)
|
|
return nil, nil
|
|
}
|
|
|
|
transcodeParamsToken, err := p.String("transcodeParams")
|
|
if err != nil {
|
|
http.Error(w, "Bad Request", http.StatusBadRequest)
|
|
return nil, nil
|
|
}
|
|
|
|
if !isValidMediaType(mediaType) {
|
|
http.Error(w, "Bad Request", http.StatusBadRequest)
|
|
return nil, nil
|
|
}
|
|
|
|
// Fetch the media file
|
|
mf, err := api.ds.MediaFile().Get(ctx, mediaID)
|
|
if err != nil {
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
http.Error(w, "Not Found", http.StatusNotFound)
|
|
} else {
|
|
log.Error(ctx, "Error retrieving media file", "mediaID", mediaID, err)
|
|
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
// Validate the token and resolve streaming parameters
|
|
streamReq, err := api.transcodeDecision.ResolveRequestFromToken(ctx, transcodeParamsToken, mf, p.IntOr("offset", 0))
|
|
if err != nil {
|
|
switch {
|
|
case errors.Is(err, stream.ErrTokenInvalid), errors.Is(err, stream.ErrTokenStale):
|
|
log.Warn(ctx, "Invalid or stale transcode token", "mediaID", mediaID, err)
|
|
http.Error(w, "Gone", http.StatusGone)
|
|
default:
|
|
log.Error(ctx, "Error validating transcode params", err)
|
|
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
// Create stream
|
|
stream, err := api.streamer.NewStream(ctx, mf, streamReq)
|
|
if err != nil {
|
|
log.Error(ctx, "Error creating stream", "mediaID", mediaID, err)
|
|
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
|
|
return nil, nil
|
|
}
|
|
|
|
// Make sure the stream will be closed at the end
|
|
defer func() {
|
|
if err := stream.Close(); err != nil && log.IsGreaterOrEqualTo(log.LevelDebug) {
|
|
log.Error("Error closing stream", "id", mediaID, "file", stream.Name(), err)
|
|
}
|
|
}()
|
|
|
|
w.Header().Set("X-Content-Type-Options", "nosniff")
|
|
|
|
n, err := stream.Serve(ctx, w, r)
|
|
if err != nil || n == 0 {
|
|
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
|
|
}
|
|
return nil, nil
|
|
}
|