mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-08 10:27:08 +02:00
* refactor(persistence): adopt generic deluan/rest repository API Pin deluan/rest to the refactor branch. REST-facing repository methods take a context and return typed values. Drop DataStore.Resource and ResourceRepository; the native API names typed repositories directly through a per-request adapter that later commits remove. * refactor(persistence): base repository helpers take a context * refactor(persistence): LibraryRepository takes a context per call * refactor(persistence): PropertyRepository takes a context per call * refactor(persistence): UserPropsRepository takes a context per call * refactor(persistence): TranscodingRepository takes a context per call * refactor(persistence): ShareRepository takes a context per call * refactor(persistence): PlayerRepository takes a context per call * refactor(persistence): RadioRepository takes a context per call * refactor(persistence): PlayQueueRepository takes a context per call * refactor(persistence): Tag and Genre repositories take a context per call * refactor(persistence): PluginRepository takes a context per call * refactor(persistence): Scrobble repositories take a context per call * refactor(persistence): FolderRepository takes a context per call * refactor(persistence): Artwork repositories take a context per call * refactor(persistence): UserRepository takes a context per call * refactor(persistence): ArtistRepository takes a context per call ReadAll no longer rewrites the shared sort mappings for the role filter; it works on a per-call copy. * test(persistence): assert artist role sort sanitization in ReadAll * refactor(persistence): AlbumRepository takes a context per call * test(persistence): pass the test context to album repository helpers * refactor(persistence): MediaFileRepository takes a context per call * refactor(persistence): Playlist repositories take a context per call * refactor(persistence): build all repositories once per store * refactor(core): REST repository wrappers are built once * refactor(persistence): repositories are stateless Remove the context field from the base repository and the per-request REST adapter. Enable the containedctx linter so no repository can hold a request context again. * chore(lint): skip containedctx in test files * refactor: share simplifications from the stateless repositories sweep Add deleteOwnedAll on sqlRepository and use it in player/share Delete to remove the duplicated bulk-delete loop; have Share.Repository() return model.ShareRepository so subsonic sharing.go drops its repeated type assertions. * chore(core): assert REST wrappers implement Persistable * chore: reformat imports * perf(persistence): build repositories on first use Each transaction store used to construct all 21 repositories up front, paying for filter and sort mapping setup the block never touched. Fields are now sync.OnceValue thunks, so a store only builds what it uses. * fix(persistence): clean plugin references per deleted user A bulk user delete that fails on a later id had already removed the earlier rows but skipped their plugin cleanup. Cleanup now runs right after each successful delete. * fix(core): unload disabled plugins even when a user delete fails A bulk delete can fail on a later id after earlier users were removed and their plugins auto-disabled. The wrapper returned before unloading, leaving those plugins running until the next successful delete or a restart. * chore(deps): pin deluan/rest to v1.0.1 Replaces the pseudo-version of the refactor branch with the tagged release. REST error messages now name the bare type (Artist, not model.Artist). * test: use the spec context instead of context.Background() Replace the context.Background()/context.TODO() calls this branch added to tests with the spec's ctx, GinkgoT().Context(), or t/b.Context(), so repository calls are bound to the running spec's lifetime. * test: declare the spec context once per Describe Set ctx from GinkgoT().Context() first in each top-level BeforeEach and reuse it, building user contexts on top of it instead of repeating inline calls.
143 lines
4.6 KiB
Go
143 lines
4.6 KiB
Go
package plugins
|
|
|
|
import (
|
|
"context"
|
|
"crypto/rand"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
|
|
extism "github.com/extism/go-sdk"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/tetratelabs/wazero"
|
|
)
|
|
|
|
// plugin represents a loaded plugin
|
|
type plugin struct {
|
|
name string // Plugin name (from filename)
|
|
path string // Path to the wasm file
|
|
manifest *Manifest
|
|
compiled *extism.CompiledPlugin
|
|
capabilities []Capability // Auto-detected capabilities based on exported functions
|
|
closers []io.Closer // Cleanup functions to call on unload
|
|
metrics PluginMetricsRecorder
|
|
allowedUserIDs []string // User IDs this plugin can access (from DB configuration)
|
|
allUsers bool // If true, plugin can access all users
|
|
libraries libraryAccess
|
|
lyricsSem chan struct{} // Caps concurrent lyrics calls (see LyricsPlugin.GetLyrics)
|
|
fsConfig wazero.FSConfig // Sandboxed library mounts, nil if no filesystem permission
|
|
}
|
|
|
|
// instanceConfig is used by every call site, so all instances get the sandboxed mounts.
|
|
func instanceConfig(fsConfig wazero.FSConfig) extism.PluginInstanceConfig {
|
|
moduleConfig := wazero.NewModuleConfig().WithSysWalltime().WithRandSource(rand.Reader)
|
|
if fsConfig != nil {
|
|
moduleConfig = moduleConfig.WithFSConfig(fsConfig)
|
|
}
|
|
return extism.PluginInstanceConfig{ModuleConfig: moduleConfig}
|
|
}
|
|
|
|
// instance creates a new plugin instance for the given context.
|
|
// The context is used for cancellation - if cancelled during a call,
|
|
// the module will be terminated and the instance becomes unusable.
|
|
func (p *plugin) instance(ctx context.Context) (*extism.Plugin, error) {
|
|
instance, err := p.compiled.Instance(ctx, instanceConfig(p.fsConfig))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
instance.SetLogger(extismLogger(p.name))
|
|
return instance, nil
|
|
}
|
|
|
|
func (p *plugin) Close() error {
|
|
var errs []error
|
|
for _, f := range p.closers {
|
|
err := f.Close()
|
|
if err != nil {
|
|
errs = append(errs, err)
|
|
}
|
|
}
|
|
return errors.Join(errs...)
|
|
}
|
|
|
|
func (p *plugin) hasLibraryFilesystemAccess(libID int) bool {
|
|
return p.manifest.HasLibraryFilesystemPermission() && p.libraries.contains(libID)
|
|
}
|
|
|
|
// libraryAccess captures the set of libraries a plugin is permitted to see,
|
|
// precomputed at load time for O(1) lookup.
|
|
type libraryAccess struct {
|
|
allLibraries bool
|
|
libraryIDSet map[int]struct{}
|
|
}
|
|
|
|
func newLibraryAccess(allowedLibraryIDs []int, allLibraries bool) libraryAccess {
|
|
set := make(map[int]struct{}, len(allowedLibraryIDs))
|
|
for _, id := range allowedLibraryIDs {
|
|
set[id] = struct{}{}
|
|
}
|
|
return libraryAccess{allLibraries: allLibraries, libraryIDSet: set}
|
|
}
|
|
|
|
func (a libraryAccess) contains(libID int) bool {
|
|
if a.allLibraries {
|
|
return true
|
|
}
|
|
_, ok := a.libraryIDSet[libID]
|
|
return ok
|
|
}
|
|
|
|
// configured reports whether the plugin has any library scope (all, or specific).
|
|
func (a libraryAccess) configured() bool {
|
|
return a.allLibraries || len(a.libraryIDSet) > 0
|
|
}
|
|
|
|
// userAccess captures the set of users a plugin is permitted to act as,
|
|
// precomputed at load time for O(1) lookup.
|
|
type userAccess struct {
|
|
allUsers bool
|
|
userIDSet map[string]struct{}
|
|
}
|
|
|
|
func newUserAccess(allowedUserIDs []string, allUsers bool) userAccess {
|
|
set := make(map[string]struct{}, len(allowedUserIDs))
|
|
for _, id := range allowedUserIDs {
|
|
set[id] = struct{}{}
|
|
}
|
|
return userAccess{allUsers: allUsers, userIDSet: set}
|
|
}
|
|
|
|
// allows reports whether the plugin may act as the given user ID.
|
|
func (a userAccess) allows(userID string) bool {
|
|
if a.allUsers {
|
|
return true
|
|
}
|
|
_, ok := a.userIDSet[userID]
|
|
return ok
|
|
}
|
|
|
|
// resolve looks up a user by username and authorizes it against this access set,
|
|
// distinguishing an absent user from a backend failure.
|
|
//
|
|
// When the plugin has no user scope at all, it rejects before the lookup with a
|
|
// single fixed error, so a caller cannot tell a real account from a missing one by
|
|
// the error text (username enumeration).
|
|
func (a userAccess) resolve(ctx context.Context, ds model.DataStore, username string) (*model.User, error) {
|
|
if !a.allUsers && len(a.userIDSet) == 0 {
|
|
return nil, fmt.Errorf("plugin is not authorized to scope by user")
|
|
}
|
|
usr, err := ds.User().FindByUsername(ctx, username)
|
|
if err != nil {
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
return nil, fmt.Errorf("user %q not found", username)
|
|
}
|
|
return nil, fmt.Errorf("looking up user %q: %w", username, err)
|
|
}
|
|
if usr == nil { // defensive: a conforming repo returns ErrNotFound, not (nil, nil)
|
|
return nil, fmt.Errorf("user %q not found", username)
|
|
}
|
|
if !a.allows(usr.ID) {
|
|
return nil, fmt.Errorf("plugin is not allowed to act as user %q", username)
|
|
}
|
|
return usr, nil
|
|
}
|