mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-31 15:37:51 +01:00
* refactor(persistence): adopt generic deluan/rest repository API Pin deluan/rest to the refactor branch. REST-facing repository methods take a context and return typed values. Drop DataStore.Resource and ResourceRepository; the native API names typed repositories directly through a per-request adapter that later commits remove. * refactor(persistence): base repository helpers take a context * refactor(persistence): LibraryRepository takes a context per call * refactor(persistence): PropertyRepository takes a context per call * refactor(persistence): UserPropsRepository takes a context per call * refactor(persistence): TranscodingRepository takes a context per call * refactor(persistence): ShareRepository takes a context per call * refactor(persistence): PlayerRepository takes a context per call * refactor(persistence): RadioRepository takes a context per call * refactor(persistence): PlayQueueRepository takes a context per call * refactor(persistence): Tag and Genre repositories take a context per call * refactor(persistence): PluginRepository takes a context per call * refactor(persistence): Scrobble repositories take a context per call * refactor(persistence): FolderRepository takes a context per call * refactor(persistence): Artwork repositories take a context per call * refactor(persistence): UserRepository takes a context per call * refactor(persistence): ArtistRepository takes a context per call ReadAll no longer rewrites the shared sort mappings for the role filter; it works on a per-call copy. * test(persistence): assert artist role sort sanitization in ReadAll * refactor(persistence): AlbumRepository takes a context per call * test(persistence): pass the test context to album repository helpers * refactor(persistence): MediaFileRepository takes a context per call * refactor(persistence): Playlist repositories take a context per call * refactor(persistence): build all repositories once per store * refactor(core): REST repository wrappers are built once * refactor(persistence): repositories are stateless Remove the context field from the base repository and the per-request REST adapter. Enable the containedctx linter so no repository can hold a request context again. * chore(lint): skip containedctx in test files * refactor: share simplifications from the stateless repositories sweep Add deleteOwnedAll on sqlRepository and use it in player/share Delete to remove the duplicated bulk-delete loop; have Share.Repository() return model.ShareRepository so subsonic sharing.go drops its repeated type assertions. * chore(core): assert REST wrappers implement Persistable * chore: reformat imports * perf(persistence): build repositories on first use Each transaction store used to construct all 21 repositories up front, paying for filter and sort mapping setup the block never touched. Fields are now sync.OnceValue thunks, so a store only builds what it uses. * fix(persistence): clean plugin references per deleted user A bulk user delete that fails on a later id had already removed the earlier rows but skipped their plugin cleanup. Cleanup now runs right after each successful delete. * fix(core): unload disabled plugins even when a user delete fails A bulk delete can fail on a later id after earlier users were removed and their plugins auto-disabled. The wrapper returned before unloading, leaving those plugins running until the next successful delete or a restart. * chore(deps): pin deluan/rest to v1.0.1 Replaces the pseudo-version of the refactor branch with the tagged release. REST error messages now name the bare type (Artist, not model.Artist). * test: use the spec context instead of context.Background() Replace the context.Background()/context.TODO() calls this branch added to tests with the spec's ctx, GinkgoT().Context(), or t/b.Context(), so repository calls are bound to the running spec's lifetime. * test: declare the spec context once per Describe Set ctx from GinkgoT().Context() first in each top-level BeforeEach and reuse it, building user contexts on top of it instead of repeating inline calls.
159 lines
5.3 KiB
Go
159 lines
5.3 KiB
Go
// nolint:unused
|
|
package scanner
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"github.com/Masterminds/squirrel"
|
|
ppl "github.com/google/go-pipeline/pkg/pipeline"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
)
|
|
|
|
// phaseRefreshAlbums is responsible for refreshing albums that have been
|
|
// newly added or changed during the scan process. This phase ensures that
|
|
// the album information in the database is up-to-date by performing the
|
|
// following steps:
|
|
// 1. Loads all libraries and their albums that have been touched (new or changed).
|
|
// 2. For each album, it filters out unmodified albums by comparing the current
|
|
// state with the state in the database.
|
|
// 3. Refreshes the album information in the database if any changes are detected.
|
|
// 4. Logs the results and finalizes the phase by reporting the total number of
|
|
// refreshed and skipped albums.
|
|
// 5. As a last step, it refreshes the artist statistics to reflect the changes
|
|
type phaseRefreshAlbums struct {
|
|
ds model.DataStore
|
|
ctx context.Context //nolint:containedctx // phase runs under a single scan ctx
|
|
refreshed atomic.Uint32
|
|
skipped atomic.Uint32
|
|
state *scanState
|
|
}
|
|
|
|
func createPhaseRefreshAlbums(ctx context.Context, state *scanState, ds model.DataStore) *phaseRefreshAlbums {
|
|
return &phaseRefreshAlbums{ctx: ctx, ds: ds, state: state}
|
|
}
|
|
|
|
func (p *phaseRefreshAlbums) description() string {
|
|
return "Refresh all new/changed albums"
|
|
}
|
|
|
|
func (p *phaseRefreshAlbums) producer() ppl.Producer[*model.Album] {
|
|
return ppl.NewProducer(p.produce, ppl.Name("load albums from db"))
|
|
}
|
|
|
|
func (p *phaseRefreshAlbums) produce(put func(album *model.Album)) error {
|
|
count := 0
|
|
for _, lib := range p.state.libraries {
|
|
cursor, err := p.ds.Album().GetTouchedAlbums(p.ctx, lib.ID)
|
|
if err != nil {
|
|
return fmt.Errorf("loading touched albums: %w", err)
|
|
}
|
|
log.Debug(p.ctx, "Scanner: Checking albums that may need refresh", "libraryId", lib.ID, "libraryName", lib.Name)
|
|
for album, err := range cursor {
|
|
if err != nil {
|
|
return fmt.Errorf("loading touched albums: %w", err)
|
|
}
|
|
count++
|
|
put(&album)
|
|
}
|
|
}
|
|
if count == 0 {
|
|
log.Debug(p.ctx, "Scanner: No albums needing refresh")
|
|
} else {
|
|
log.Debug(p.ctx, "Scanner: Found albums that may need refreshing", "count", count)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (p *phaseRefreshAlbums) stages() []ppl.Stage[*model.Album] {
|
|
return []ppl.Stage[*model.Album]{
|
|
ppl.NewStage(p.filterUnmodified, ppl.Name("filter unmodified"), ppl.Concurrency(5)),
|
|
ppl.NewStage(p.refreshAlbum, ppl.Name("refresh albums")),
|
|
}
|
|
}
|
|
|
|
func (p *phaseRefreshAlbums) filterUnmodified(album *model.Album) (*model.Album, error) {
|
|
mfs, err := p.ds.MediaFile().GetAll(p.ctx, model.QueryOptions{Filters: squirrel.Eq{"album_id": album.ID}})
|
|
if err != nil {
|
|
log.Error(p.ctx, "Error loading media files for album", "album_id", album.ID, err)
|
|
return nil, err
|
|
}
|
|
if len(mfs) == 0 {
|
|
log.Debug(p.ctx, "Scanner: album has no media files. Skipping", "album_id", album.ID,
|
|
"name", album.Name, "songCount", album.SongCount, "updatedAt", album.UpdatedAt)
|
|
p.skipped.Add(1)
|
|
return nil, nil
|
|
}
|
|
|
|
newAlbum := mfs.ToAlbum()
|
|
if album.Equals(newAlbum) {
|
|
log.Trace("Scanner: album is up to date. Skipping", "album_id", album.ID,
|
|
"name", album.Name, "songCount", album.SongCount, "updatedAt", album.UpdatedAt)
|
|
p.skipped.Add(1)
|
|
return nil, nil
|
|
}
|
|
return &newAlbum, nil
|
|
}
|
|
|
|
func (p *phaseRefreshAlbums) refreshAlbum(album *model.Album) (*model.Album, error) {
|
|
if album == nil {
|
|
return nil, nil
|
|
}
|
|
start := time.Now()
|
|
err := p.ds.WithTxRetry(p.ctx, func(ctx context.Context, tx model.DataStore) error {
|
|
return tx.Album().Put(ctx, album)
|
|
}, "scanner: refresh album")
|
|
log.Debug(p.ctx, "Scanner: refreshing album", "album_id", album.ID, "name", album.Name, "songCount", album.SongCount, "elapsed", time.Since(start), err)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("refreshing album %s: %w", album.ID, err)
|
|
}
|
|
p.refreshed.Add(1)
|
|
p.state.changesDetected.Store(true)
|
|
return album, nil
|
|
}
|
|
|
|
func (p *phaseRefreshAlbums) finalize(err error) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
logF := log.Info
|
|
refreshed := p.refreshed.Load()
|
|
skipped := p.skipped.Load()
|
|
if refreshed == 0 {
|
|
logF = log.Debug
|
|
}
|
|
logF(p.ctx, "Scanner: Finished refreshing albums", "refreshed", refreshed, "skipped", skipped, err)
|
|
if !p.state.changesDetected.Load() {
|
|
log.Debug(p.ctx, "Scanner: No changes detected, skipping refreshing annotations")
|
|
return nil
|
|
}
|
|
// Refresh album annotations
|
|
start := time.Now()
|
|
var cnt int64
|
|
err = p.ds.WithTxRetry(p.ctx, func(ctx context.Context, tx model.DataStore) error {
|
|
var txErr error
|
|
cnt, txErr = tx.Album().RefreshPlayCounts(ctx)
|
|
return txErr
|
|
}, "scanner: refresh album play counts")
|
|
if err != nil {
|
|
return fmt.Errorf("refreshing album annotations: %w", err)
|
|
}
|
|
log.Debug(p.ctx, "Scanner: Refreshed album annotations", "albums", cnt, "elapsed", time.Since(start))
|
|
|
|
// Refresh artist annotations
|
|
start = time.Now()
|
|
err = p.ds.WithTxRetry(p.ctx, func(ctx context.Context, tx model.DataStore) error {
|
|
var txErr error
|
|
cnt, txErr = tx.Artist().RefreshPlayCounts(ctx)
|
|
return txErr
|
|
}, "scanner: refresh artist play counts")
|
|
if err != nil {
|
|
return fmt.Errorf("refreshing artist annotations: %w", err)
|
|
}
|
|
log.Debug(p.ctx, "Scanner: Refreshed artist annotations", "artists", cnt, "elapsed", time.Since(start))
|
|
p.state.changesDetected.Store(true)
|
|
return nil
|
|
}
|