navidrome/adapters/lastfm
Deluan Quintão 285dc4f391
fix(lastfm): report a failure when the artist page has no image (#6198)
GetArtistImages scrapes the og:image tag off the Last.fm artist page, because
the API only ever returns the placeholder image. Last.fm now answers non-browser
clients with a Fastly bot challenge, served as a 200 with valid HTML, so the
query found no og:image and the agent returned an empty list with no error. The
artwork worker read that as a definitive "this artist has no image" and settled
the state as absent, silently and with nothing in the log.

A real artist page always carries an og:image, so its absence now returns an
error instead. The worker keeps the previous state, other agents still get their
turn, and its per-agent circuit breaker bounds the retries. The error is
deliberately not a RetryLaterError: that would park the whole Last.fm agent,
including the API-backed biography, similar-artists and top-songs calls, which
the page block does not affect.

The new fixture is the real 3038-byte challenge page.

Fixes #6192
2026-09-21 17:34:32 -04:00
..
agent.go fix(lastfm): report a failure when the artist page has no image (#6198) 2026-09-21 17:34:32 -04:00
agent_test.go fix(lastfm): report a failure when the artist page has no image (#6198) 2026-09-21 17:34:32 -04:00
auth_router.go fix: miscellaneous fixes for shares, artwork resize, auth limits, and watcher start (#6098) 2026-09-11 15:03:54 -04:00
auth_router_test.go feat(jellyfin): non-expiring, audience-scoped tokens revocable by password change (#6013) 2026-08-22 20:36:24 -04:00
client.go fix(lastfm): double-encode plus signs in artist and track names (#6158) 2026-09-17 07:29:56 -04:00
client_test.go fix(lastfm): double-encode plus signs in artist and track names (#6158) 2026-09-17 07:29:56 -04:00
lastfm_suite_test.go refactor: move agent files to adapters for consistency 2026-01-14 19:33:54 -05:00
link_token.go fix(lastfm): require signed state token on link callback (#5521) 2026-05-23 12:16:15 -03:00
responses.go feat: add similar songs functionality in agents, and Instant Mix (song-based) to UI (#4919) 2026-01-25 16:16:43 -05:00
responses_test.go refactor: move agent files to adapters for consistency 2026-01-14 19:33:54 -05:00
token_received.html refactor: move agent files to adapters for consistency 2026-01-14 19:33:54 -05:00