mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-15 13:57:09 +02:00
b293b96256* refactor(persistence): adopt generic deluan/rest repository API Pin deluan/rest to the refactor branch. REST-facing repository methods take a context and return typed values. Drop DataStore.Resource and ResourceRepository; the native API names typed repositories directly through a per-request adapter that later commits remove. * refactor(persistence): base repository helpers take a context * refactor(persistence): LibraryRepository takes a context per call * refactor(persistence): PropertyRepository takes a context per call * refactor(persistence): UserPropsRepository takes a context per call * refactor(persistence): TranscodingRepository takes a context per call * refactor(persistence): ShareRepository takes a context per call * refactor(persistence): PlayerRepository takes a context per call * refactor(persistence): RadioRepository takes a context per call * refactor(persistence): PlayQueueRepository takes a context per call * refactor(persistence): Tag and Genre repositories take a context per call * refactor(persistence): PluginRepository takes a context per call * refactor(persistence): Scrobble repositories take a context per call * refactor(persistence): FolderRepository takes a context per call * refactor(persistence): Artwork repositories take a context per call * refactor(persistence): UserRepository takes a context per call * refactor(persistence): ArtistRepository takes a context per call ReadAll no longer rewrites the shared sort mappings for the role filter; it works on a per-call copy. * test(persistence): assert artist role sort sanitization in ReadAll * refactor(persistence): AlbumRepository takes a context per call * test(persistence): pass the test context to album repository helpers * refactor(persistence): MediaFileRepository takes a context per call * refactor(persistence): Playlist repositories take a context per call * refactor(persistence): build all repositories once per store * refactor(core): REST repository wrappers are built once * refactor(persistence): repositories are stateless Remove the context field from the base repository and the per-request REST adapter. Enable the containedctx linter so no repository can hold a request context again. * chore(lint): skip containedctx in test files * refactor: share simplifications from the stateless repositories sweep Add deleteOwnedAll on sqlRepository and use it in player/share Delete to remove the duplicated bulk-delete loop; have Share.Repository() return model.ShareRepository so subsonic sharing.go drops its repeated type assertions. * chore(core): assert REST wrappers implement Persistable * chore: reformat imports * perf(persistence): build repositories on first use Each transaction store used to construct all 21 repositories up front, paying for filter and sort mapping setup the block never touched. Fields are now sync.OnceValue thunks, so a store only builds what it uses. * fix(persistence): clean plugin references per deleted user A bulk user delete that fails on a later id had already removed the earlier rows but skipped their plugin cleanup. Cleanup now runs right after each successful delete. * fix(core): unload disabled plugins even when a user delete fails A bulk delete can fail on a later id after earlier users were removed and their plugins auto-disabled. The wrapper returned before unloading, leaving those plugins running until the next successful delete or a restart. * chore(deps): pin deluan/rest to v1.0.1 Replaces the pseudo-version of the refactor branch with the tagged release. REST error messages now name the bare type (Artist, not model.Artist). * test: use the spec context instead of context.Background() Replace the context.Background()/context.TODO() calls this branch added to tests with the spec's ctx, GinkgoT().Context(), or t/b.Context(), so repository calls are bound to the running spec's lifetime. * test: declare the spec context once per Describe Set ctx from GinkgoT().Context() first in each top-level BeforeEach and reuse it, building user contexts on top of it instead of repeating inline calls.
280 lines
8.9 KiB
Go
280 lines
8.9 KiB
Go
package e2e
|
|
|
|
import (
|
|
"github.com/Masterminds/squirrel"
|
|
"github.com/navidrome/navidrome/conf"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/server/subsonic/responses"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("Sharing Endpoints", Ordered, func() {
|
|
var shareID string
|
|
var albumID string
|
|
var songID string
|
|
|
|
BeforeAll(func() {
|
|
conf.Server.EnableSharing = true
|
|
setupTestDB()
|
|
|
|
albums, err := ds.Album().GetAll(ctx, model.QueryOptions{
|
|
Filters: squirrel.Eq{"album.name": "Abbey Road"},
|
|
})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(albums).ToNot(BeEmpty())
|
|
albumID = albums[0].ID
|
|
|
|
songs, err := ds.MediaFile().GetAll(ctx, model.QueryOptions{
|
|
Filters: squirrel.Eq{"title": "Come Together"},
|
|
})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(songs).ToNot(BeEmpty())
|
|
songID = songs[0].ID
|
|
})
|
|
|
|
It("getShares returns empty initially", func() {
|
|
resp := doReq("getShares")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares).ToNot(BeNil())
|
|
Expect(resp.Shares.Share).To(BeEmpty())
|
|
})
|
|
|
|
It("createShare creates a share for an album", func() {
|
|
resp := doReq("createShare", "id", albumID, "description", "Check out this album")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares).ToNot(BeNil())
|
|
Expect(resp.Shares.Share).To(HaveLen(1))
|
|
|
|
share := resp.Shares.Share[0]
|
|
Expect(share.ID).ToNot(BeEmpty())
|
|
Expect(share.Description).To(Equal("Check out this album"))
|
|
Expect(share.Username).To(Equal(adminUser.UserName))
|
|
shareID = share.ID
|
|
})
|
|
|
|
It("getShares returns the created share", func() {
|
|
resp := doReq("getShares")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares).ToNot(BeNil())
|
|
Expect(resp.Shares.Share).To(HaveLen(1))
|
|
|
|
share := resp.Shares.Share[0]
|
|
Expect(share.ID).To(Equal(shareID))
|
|
Expect(share.Description).To(Equal("Check out this album"))
|
|
Expect(share.Username).To(Equal(adminUser.UserName))
|
|
Expect(share.Entry).ToNot(BeEmpty())
|
|
})
|
|
|
|
It("updateShare modifies the description", func() {
|
|
resp := doReq("updateShare", "id", shareID, "description", "Updated description")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
|
|
// Verify update
|
|
resp = doReq("getShares")
|
|
Expect(resp.Shares.Share).To(HaveLen(1))
|
|
Expect(resp.Shares.Share[0].Description).To(Equal("Updated description"))
|
|
})
|
|
|
|
It("deleteShare removes it", func() {
|
|
resp := doReq("deleteShare", "id", shareID)
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
})
|
|
|
|
It("getShares returns empty after deletion", func() {
|
|
resp := doReq("getShares")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares).ToNot(BeNil())
|
|
Expect(resp.Shares.Share).To(BeEmpty())
|
|
})
|
|
|
|
It("createShare works with a song ID", func() {
|
|
resp := doReq("createShare", "id", songID, "description", "Great song")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares).ToNot(BeNil())
|
|
Expect(resp.Shares.Share).To(HaveLen(1))
|
|
Expect(resp.Shares.Share[0].Description).To(Equal("Great song"))
|
|
Expect(resp.Shares.Share[0].Entry).To(HaveLen(1))
|
|
})
|
|
|
|
It("createShare returns error when id parameter is missing", func() {
|
|
resp := doReq("createShare")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusFailed))
|
|
Expect(resp.Error).ToNot(BeNil())
|
|
Expect(resp.Error.Code).To(Equal(responses.ErrorMissingParameter))
|
|
})
|
|
|
|
It("updateShare returns error when id parameter is missing", func() {
|
|
resp := doReq("updateShare")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusFailed))
|
|
Expect(resp.Error).ToNot(BeNil())
|
|
})
|
|
|
|
It("deleteShare returns error when id parameter is missing", func() {
|
|
resp := doReq("deleteShare")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusFailed))
|
|
Expect(resp.Error).ToNot(BeNil())
|
|
})
|
|
})
|
|
|
|
var _ = Describe("Sharing Cross-User Isolation", Ordered, func() {
|
|
var userA, userB model.User
|
|
var shareID string
|
|
var albumID string
|
|
|
|
BeforeAll(func() {
|
|
conf.Server.EnableSharing = true
|
|
setupTestDB()
|
|
|
|
userA = createUser("share-user-a", "share-user-a", "Share User A", false)
|
|
userB = createUser("share-user-b", "share-user-b", "Share User B", false)
|
|
|
|
albums, err := ds.Album().GetAll(ctx, model.QueryOptions{
|
|
Filters: squirrel.Eq{"album.name": "Abbey Road"},
|
|
})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(albums).ToNot(BeEmpty())
|
|
albumID = albums[0].ID
|
|
|
|
resp := doReqWithUser(userA, "createShare", "id", albumID, "description", "User A's share")
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares.Share).To(HaveLen(1))
|
|
shareID = resp.Shares.Share[0].ID
|
|
Expect(resp.Shares.Share[0].Username).To(Equal(userA.UserName))
|
|
})
|
|
|
|
It("userB's getShares does not leak userA's share", func() {
|
|
resp := doReqWithUser(userB, "getShares")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares).ToNot(BeNil())
|
|
Expect(resp.Shares.Share).To(BeEmpty())
|
|
})
|
|
|
|
It("userA still sees own share", func() {
|
|
resp := doReqWithUser(userA, "getShares")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares.Share).To(HaveLen(1))
|
|
Expect(resp.Shares.Share[0].ID).To(Equal(shareID))
|
|
Expect(resp.Shares.Share[0].Description).To(Equal("User A's share"))
|
|
})
|
|
|
|
It("admin sees userA's share", func() {
|
|
resp := doReqWithUser(adminUser, "getShares")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
ids := make([]string, len(resp.Shares.Share))
|
|
for i, s := range resp.Shares.Share {
|
|
ids[i] = s.ID
|
|
}
|
|
Expect(ids).To(ContainElement(shareID))
|
|
})
|
|
|
|
It("userB cannot updateShare on userA's share", func() {
|
|
resp := doReqWithUser(userB, "updateShare", "id", shareID, "description", "hijacked")
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusFailed))
|
|
Expect(resp.Error).ToNot(BeNil())
|
|
|
|
// Confirm description unchanged for userA.
|
|
check := doReqWithUser(userA, "getShares")
|
|
Expect(check.Shares.Share).To(HaveLen(1))
|
|
Expect(check.Shares.Share[0].Description).To(Equal("User A's share"))
|
|
})
|
|
|
|
It("userB cannot deleteShare on userA's share", func() {
|
|
resp := doReqWithUser(userB, "deleteShare", "id", shareID)
|
|
|
|
Expect(resp.Status).To(Equal(responses.StatusFailed))
|
|
Expect(resp.Error).ToNot(BeNil())
|
|
|
|
// Confirm share still present for userA.
|
|
check := doReqWithUser(userA, "getShares")
|
|
Expect(check.Shares.Share).To(HaveLen(1))
|
|
Expect(check.Shares.Share[0].ID).To(Equal(shareID))
|
|
})
|
|
})
|
|
|
|
var _ = Describe("Sharing Downloadable Default", func() {
|
|
var albumID string
|
|
|
|
BeforeEach(func() {
|
|
conf.Server.EnableSharing = true
|
|
setupTestDB()
|
|
conf.Server.EnableDownloads = true
|
|
albumID = albumIDByName("Abbey Road")
|
|
})
|
|
|
|
createShare := func(params ...string) *model.Share {
|
|
GinkgoHelper()
|
|
resp := doReq("createShare", append([]string{"id", albumID}, params...)...)
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
Expect(resp.Shares.Share).To(HaveLen(1))
|
|
share, err := ds.Share().Get(ctx, resp.Shares.Share[0].ID)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
return share
|
|
}
|
|
|
|
DescribeTable("createShare resolves downloadable",
|
|
func(defaultDownloadable, enableDownloads bool, params []string, expected bool) {
|
|
conf.Server.DefaultDownloadableShare = defaultDownloadable
|
|
conf.Server.EnableDownloads = enableDownloads
|
|
|
|
Expect(createShare(params...).Downloadable).To(Equal(expected))
|
|
},
|
|
Entry("applies the default when the param is absent", true, true, nil, true),
|
|
Entry("stays off when the default is off", false, true, nil, false),
|
|
Entry("ignores the default when downloads are disabled", true, false, nil, false),
|
|
Entry("honors an explicit false over the default", true, true, []string{"downloadable", "false"}, false),
|
|
Entry("honors an explicit true over the default", false, true, []string{"downloadable", "true"}, true),
|
|
)
|
|
|
|
It("updateShare keeps the current downloadable when the param is absent", func() {
|
|
conf.Server.DefaultDownloadableShare = true
|
|
share := createShare()
|
|
Expect(share.Downloadable).To(BeTrue())
|
|
|
|
resp := doReq("updateShare", "id", share.ID, "description", "Updated")
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
|
|
updated, err := ds.Share().Get(ctx, share.ID)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(updated.Description).To(Equal("Updated"))
|
|
Expect(updated.Downloadable).To(BeTrue())
|
|
})
|
|
|
|
It("updateShare applies an explicit downloadable and keeps the description", func() {
|
|
conf.Server.DefaultDownloadableShare = true
|
|
share := createShare("description", "Keep me")
|
|
|
|
resp := doReq("updateShare", "id", share.ID, "downloadable", "false")
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
|
|
updated, err := ds.Share().Get(ctx, share.ID)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(updated.Downloadable).To(BeFalse())
|
|
Expect(updated.Description).To(Equal("Keep me"))
|
|
})
|
|
|
|
It("updateShare clears the description when it is sent empty", func() {
|
|
share := createShare("description", "Clear me")
|
|
|
|
resp := doReq("updateShare", "id", share.ID, "description", "")
|
|
Expect(resp.Status).To(Equal(responses.StatusOK))
|
|
|
|
updated, err := ds.Share().Get(ctx, share.ID)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(updated.Description).To(BeEmpty())
|
|
})
|
|
})
|