mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-26 18:27:09 +01:00
755ae5106f
The uploader re-encodes the image (PNG only when the source was PNG, WebP when EnableWebPEncoding is on, JPEG otherwise) but stores it under the caller's extension, so a .gif file can hold JPEG bytes. Deriving Content-Type from the extension made getAvatar and /UserImage announce a type they were not sending.
49 lines
1.5 KiB
Go
49 lines
1.5 KiB
Go
package imghttp
|
|
|
|
import (
|
|
"errors"
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
)
|
|
|
|
// ServeUserAvatar writes the user's uploaded avatar, reporting whether it answered the request;
|
|
// when false the caller must fall back. http.ServeContent gives correct ETag/If-None-Match handling.
|
|
func ServeUserAvatar(w http.ResponseWriter, r *http.Request, u *model.User) bool {
|
|
path := u.UploadedImagePath()
|
|
if path == "" {
|
|
return false
|
|
}
|
|
f, err := os.Open(path)
|
|
if err != nil {
|
|
log.Warn(r.Context(), "Could not open user avatar", "user", u.UserName, err)
|
|
return false
|
|
}
|
|
defer f.Close()
|
|
info, err := f.Stat()
|
|
if err != nil {
|
|
log.Warn(r.Context(), "Could not stat user avatar", "user", u.UserName, err)
|
|
return false
|
|
}
|
|
|
|
// The stored extension can disagree with the bytes: the uploader re-encodes while keeping the
|
|
// caller's extension, so the type is sniffed from the content instead.
|
|
head := make([]byte, 512)
|
|
n, err := io.ReadFull(f, head)
|
|
if err != nil && !errors.Is(err, io.EOF) && !errors.Is(err, io.ErrUnexpectedEOF) {
|
|
log.Warn(r.Context(), "Could not read user avatar", "user", u.UserName, err)
|
|
return false
|
|
}
|
|
if _, err := f.Seek(0, io.SeekStart); err != nil {
|
|
log.Warn(r.Context(), "Could not rewind user avatar", "user", u.UserName, err)
|
|
return false
|
|
}
|
|
w.Header().Set("Content-Type", http.DetectContentType(head[:n]))
|
|
w.Header().Set("ETag", `"`+u.AvatarTag()+`"`)
|
|
w.Header().Set("Cache-Control", "private, no-cache")
|
|
http.ServeContent(w, r, info.Name(), info.ModTime(), f)
|
|
return true
|
|
}
|