mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-12 04:17:16 +02:00
3759488db5
The blurhash worker previously recomputed on every artwork serve and reconciled a row-level freshness oracle against serve-time hints (force, sourceGone, imageUpdatedAt) to decide whether the served bytes had actually changed. Every staleness bug found in review was one case where that weak oracle disagreed with the true one, and each fix imported one more serve-time fragment into it. Move the trigger to the image-cache fill instead: an original-size cache miss is exactly when the served bytes change, so the reader's LastUpdated snapshot is the truth and no reconciliation is needed. Resized fills recurse through Get(size=0) and hash the original once; a disabled cache reports every original serve as a fill, keeping real hashes available (the worker's unchanged-hash guard keeps that write-free). This deletes the force/sourceGone/imageUpdatedAt flags, the double-freshness comparison, and the entire negative cache. Only the two irreducible pieces survive: the placeholder byte-compare and the ErrUnavailable clear-hook (EnqueueGone), since deletion-without-rescan is invisible to every passive signal. Adds an e2e test for in-place cover swaps, the scenario that drove the deleted machinery, now covered structurally by the fill trigger. Schema, DTO, repositories and the blurhash encoder package are unchanged. |
||
|---|---|---|
| .. | ||
| blurhash | ||
| e2e | ||
| animation.go | ||
| animation_test.go | ||
| artwork.go | ||
| artwork_internal_test.go | ||
| artwork_suite_test.go | ||
| artwork_test.go | ||
| benchmark_decode_test.go | ||
| benchmark_e2e_test.go | ||
| benchmark_encode_test.go | ||
| benchmark_helpers_test.go | ||
| benchmark_pipeline_test.go | ||
| benchmark_tag_test.go | ||
| blurhash_updater.go | ||
| blurhash_updater_internal_test.go | ||
| cache_warmer.go | ||
| cache_warmer_test.go | ||
| image_cache.go | ||
| library_fs.go | ||
| library_fs_test.go | ||
| reader_album.go | ||
| reader_album_test.go | ||
| reader_artist.go | ||
| reader_artist_test.go | ||
| reader_disc.go | ||
| reader_disc_test.go | ||
| reader_mediafile.go | ||
| reader_playlist.go | ||
| reader_radio.go | ||
| reader_radio_test.go | ||
| reader_resized.go | ||
| reader_resized_test.go | ||
| sources.go | ||
| sources_internal_test.go | ||
| wire_providers.go | ||