mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-23 17:57:09 +02:00
8d77a49b31
The Default Bit Rate dropdown on the Transcoding create/edit forms was fed BITRATE_CHOICES, which starts at 32. There was no way to pick 0, and the SelectInput was not resettable, so an admin could neither create nor restore a transcoding with no default bit rate, such as the default FLAC one (seeded with 0 in consts.DefaultTranscodings). Editing that row also rendered a blank dropdown, since its stored value matched no choice. Adds TRANSCODING_BITRATE_CHOICES, which prepends a 0 entry labelled 'None' to the shared list. The forms use it as SelectInput choices, and the list and read-only show view render it through SelectField, so all four screens resolve the label from the same array and cannot drift. The shared BITRATE_CHOICES is left untouched, because 0 is not a meaningful option for the player Max. Bit Rate or the share dialog. Reported in discussion #6107, where a user had deleted the default transcodings and could not recreate the FLAC one.
51 lines
1.2 KiB
JavaScript
51 lines
1.2 KiB
JavaScript
import React from 'react'
|
|
import {
|
|
TextInput,
|
|
SelectInput,
|
|
Create,
|
|
required,
|
|
SimpleForm,
|
|
useTranslate,
|
|
} from 'react-admin'
|
|
import { Title } from '../common'
|
|
import { TRANSCODING_BITRATE_CHOICES } from '../consts'
|
|
|
|
const TranscodingTitle = () => {
|
|
const translate = useTranslate()
|
|
const resourceName = translate('resources.transcoding.name', {
|
|
smart_count: 1,
|
|
})
|
|
const title = translate('ra.page.create', {
|
|
name: `${resourceName}`,
|
|
})
|
|
return <Title subTitle={title} />
|
|
}
|
|
|
|
const TranscodingCreate = (props) => (
|
|
<Create title={<TranscodingTitle />} {...props}>
|
|
<SimpleForm redirect="list" variant={'outlined'}>
|
|
<TextInput source="name" validate={[required()]} />
|
|
<TextInput source="targetFormat" validate={[required()]} />
|
|
<SelectInput
|
|
source="defaultBitRate"
|
|
choices={TRANSCODING_BITRATE_CHOICES}
|
|
defaultValue={192}
|
|
/>
|
|
<TextInput
|
|
source="command"
|
|
fullWidth
|
|
validate={[required()]}
|
|
helperText={
|
|
<span>
|
|
Substitutions: <br />
|
|
%s: File path <br />
|
|
%b: BitRate (in kbps)
|
|
<br />
|
|
</span>
|
|
}
|
|
/>
|
|
</SimpleForm>
|
|
</Create>
|
|
)
|
|
|
|
export default TranscodingCreate
|