mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-08 18:37:09 +02:00
a2de8e61ef* test(plugins): make the suite safe to run in parallel processes Two things broke when the suite ran across several Ginkgo processes. buildTestPlugins ran in every process, so N copies of make raced in the same directory. The packaging rule made that worse by staging every plugin through one shared plugin.wasm, so concurrent targets clobbered each other and left orphaned temp files behind. That also ruled out make -j. Stage each package under its own per-target directory, and move the build into SynchronizedBeforeSuite so process 1 does it once while the others wait. * ci: run the plugins suite in parallel processes With the compilation cache warm the suite is bound by spec execution, which splits cleanly across processes. Run it as its own step with the ginkgo CLI, already declared as a tool in go.mod, and drop the package from the main go test invocation so it is not run twice. Locally, with -race: 69s to 19s warm, and 256s to 96s cold. * ci: give the plugins suite its own job so it runs concurrently Running it as a second step in the go job serialised it against the other 90 packages, which cancelled out the parallel win: the job went from 5m41s to only 5m29s even though the suite itself dropped from ~175s to 82s. Move it to its own job so the two run at the same time. The WASM compilation cache moves with it, since the go job no longer runs the suite. |
||
|---|---|---|
| .. | ||
| partial-metadata-agent | ||
| test-artwork | ||
| test-cache-plugin | ||
| test-config | ||
| test-kvstore | ||
| test-library | ||
| test-lyrics | ||
| test-matcher | ||
| test-metadata-agent | ||
| test-scheduler | ||
| test-scrobble-retriever | ||
| test-scrobbler | ||
| test-sonic-similarity | ||
| test-storage-plugin | ||
| test-subsonicapi-plugin | ||
| test-taskqueue | ||
| test-users | ||
| test-websocket | ||
| Makefile | ||
| test-storage-plugin-2 | ||