mirror of
https://github.com/navidrome/navidrome.git
synced 2026-10-09 19:07:12 +02:00
8e784b6af7On a multi-library instance, a few reads and writes built their own queries without the per-user library filter that every other media read applies. A user granted only some libraries could see, and store, tracks from libraries they had no access to. - getBookmarks now filters the query. It has to be the query and not the result: the loop below it pre-sizes the response from the bookmark count, so a row dropped afterwards would emit an empty bookmark entry. - createBookmark rejects an id the caller cannot read, returning error 70 to match getSong. Stored rows are left alone rather than purged, so a temporary revoke does not lose saved playback positions. - playlistTrackRepository Read, Count and GetAlbumIDs get the filter their siblings CountAll and GetMediaFileIDs already had. Read is the one that mattered most: its id is the integer playlist position, so it needed no track id at all. - Playlist track writes are filtered in playlistRepository.addTracks, the only writer of playlist_tracks rows apart from smart playlists, so Add, Insert, AddAlbums/AddArtists/AddDiscs and a full replace through Put all go through it. Insert reserves a slot per requested id, so when the filter drops one it renumbers to close the hole. - playTracker.GetNowPlaying honours its context instead of discarding it. The cache is process-global, so the filter belongs in the tracker rather than in the Subsonic handler, and any future caller inherits it. Admins and single-library installs are unaffected: applyLibraryFilter and HasLibraryAccess both short-circuit for them. Scanner playlist sync runs as admin, and M3U and CLI imports already resolve tracks through FindByPaths as the same user, so neither changes. |
||
|---|---|---|
| .. | ||
| doc.go | ||
| e2e_suite_test.go | ||
| subsonic_album_lists_test.go | ||
| subsonic_artwork_test.go | ||
| subsonic_bookmarks_test.go | ||
| subsonic_browsing_test.go | ||
| subsonic_lyrics_test.go | ||
| subsonic_media_annotation_test.go | ||
| subsonic_media_retrieval_test.go | ||
| subsonic_multilibrary_test.go | ||
| subsonic_multiuser_test.go | ||
| subsonic_playlists_test.go | ||
| subsonic_radio_test.go | ||
| subsonic_scan_test.go | ||
| subsonic_searching_test.go | ||
| subsonic_sharing_test.go | ||
| subsonic_sonic_similarity_test.go | ||
| subsonic_stream_test.go | ||
| subsonic_system_test.go | ||
| subsonic_transcode_test.go | ||
| subsonic_users_test.go | ||